type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
428k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
11
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/comments/296027410","pull_request_review_id":252556212,"id":296027410,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjAyNzQxMA==","diff_hunk":"@@ -1279,7 +1279,7 @@ def group_log_entries_by_tag_and_local_resource_id(chunk)\n chunk.msgpack_each do |tag, time, record|\n unless record.is_a?(Hash)\n @log.warn 'Dropping log entries with malformed record: ' \\\n- \"'#{record.inspect}'. \" \\\n+ \"'#{record.inspect}' from tag '#{tag}'. \" \\","path":"lib/fluent/plugin/out_google_cloud.rb","position":null,"original_position":5,"commit_id":"5929f455e0599cd3d76a28bb45ee21c118886563","original_commit_id":"3de2a05e3dbd00de496e51eb6c4e065b3dd60a60","user":{"login":"qingling128","id":5287526,"node_id":"MDQ6VXNlcjUyODc1MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5287526?v=4","gravatar_id":"","url":"https://api.github.com/users/qingling128","html_url":"https://github.com/qingling128","followers_url":"https://api.github.com/users/qingling128/followers","following_url":"https://api.github.com/users/qingling128/following{/other_user}","gists_url":"https://api.github.com/users/qingling128/gists{/gist_id}","starred_url":"https://api.github.com/users/qingling128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qingling128/subscriptions","organizations_url":"https://api.github.com/users/qingling128/orgs","repos_url":"https://api.github.com/users/qingling128/repos","events_url":"https://api.github.com/users/qingling128/events{/privacy}","received_events_url":"https://api.github.com/users/qingling128/received_events","type":"User","site_admin":false},"body":"The more the better. Added.","created_at":"2019-06-20T21:49:22Z","updated_at":"2019-06-20T21:49:22Z","html_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/318#discussion_r296027410","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/318","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/comments/296027410"},"html":{"href":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/318#discussion_r296027410"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/318"}},"in_reply_to_id":295954232},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/318","id":290323906,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwMzIzOTA2","html_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/318","diff_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/318.diff","patch_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/318.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/318","number":318,"state":"open","locked":false,"title":"Add debugging info for non-hash records.","user":{"login":"qingling128","id":5287526,"node_id":"MDQ6VXNlcjUyODc1MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5287526?v=4","gravatar_id":"","url":"https://api.github.com/users/qingling128","html_url":"https://github.com/qingling128","followers_url":"https://api.github.com/users/qingling128/followers","following_url":"https://api.github.com/users/qingling128/following{/other_user}","gists_url":"https://api.github.com/users/qingling128/gists{/gist_id}","starred_url":"https://api.github.com/users/qingling128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qingling128/subscriptions","organizations_url":"https://api.github.com/users/qingling128/orgs","repos_url":"https://api.github.com/users/qingling128/repos","events_url":"https://api.github.com/users/qingling128/events{/privacy}","received_events_url":"https://api.github.com/users/qingling128/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-20T18:21:51Z","updated_at":"2019-06-20T21:49:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5eeed8b462fb48626c52c9cc63f3280717ba1ed9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":249372076,"node_id":"MDU6TGFiZWwyNDkzNzIwNzY=","url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/318/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/318/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/318/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/statuses/5929f455e0599cd3d76a28bb45ee21c118886563","head":{"label":"GoogleCloudPlatform:lingshi-debug","ref":"lingshi-debug","sha":"5929f455e0599cd3d76a28bb45ee21c118886563","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":19799990,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTk5MA==","name":"fluent-plugin-google-cloud","full_name":"GoogleCloudPlatform/fluent-plugin-google-cloud","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud","description":"Plugin for Fluentd that sends logs to the Google Cloud Platform's log ingestion API.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/deployments","created_at":"2014-05-14T23:46:51Z","updated_at":"2019-06-19T08:09:00Z","pushed_at":"2019-06-20T21:49:07Z","git_url":"git://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud.git","ssh_url":"git@github.com:GoogleCloudPlatform/fluent-plugin-google-cloud.git","clone_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud.git","svn_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud","homepage":null,"size":1206,"stargazers_count":128,"watchers_count":128,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":76,"open_issues":41,"watchers":128,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"975357e659a519bfefece1ea2d2ce7791cc1c00d","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":19799990,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTk5MA==","name":"fluent-plugin-google-cloud","full_name":"GoogleCloudPlatform/fluent-plugin-google-cloud","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud","description":"Plugin for Fluentd that sends logs to the Google Cloud Platform's log ingestion API.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/deployments","created_at":"2014-05-14T23:46:51Z","updated_at":"2019-06-19T08:09:00Z","pushed_at":"2019-06-20T21:49:07Z","git_url":"git://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud.git","ssh_url":"git@github.com:GoogleCloudPlatform/fluent-plugin-google-cloud.git","clone_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud.git","svn_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud","homepage":null,"size":1206,"stargazers_count":128,"watchers_count":128,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":76,"open_issues":41,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/318"},"html":{"href":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/318"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/318"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/statuses/5929f455e0599cd3d76a28bb45ee21c118886563"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 19799990,
"name": "GoogleCloudPlatform/fluent-plugin-google-cloud",
"url": "https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud"
}
|
{
"id": 5287526,
"login": "qingling128",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5287526?",
"url": "https://api.github.com/users/qingling128"
}
|
{
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
}
| 2019-06-20T21:49:22 |
9864258911
|
{"actor":{"display_login":"qingling128"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/comments/259470586","pull_request_review_id":206976847,"id":259470586,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTQ3MDU4Ng==","diff_hunk":"@@ -97,6 +97,11 @@ def load_yaml(yaml_str):\n return Schema(yaml.load(yaml_str))\n \n def __init__(self, dictionary):\n+ self._x_google_marketplace = None","path":"marketplace/deployer_util/config_helper.py","position":13,"original_position":13,"commit_id":"1ffcc392806ec1262924001a8e4aba07562bf34f","original_commit_id":"1ffcc392806ec1262924001a8e4aba07562bf34f","user":{"login":"thiagolacerda","id":2013754,"node_id":"MDQ6VXNlcjIwMTM3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2013754?v=4","gravatar_id":"","url":"https://api.github.com/users/thiagolacerda","html_url":"https://github.com/thiagolacerda","followers_url":"https://api.github.com/users/thiagolacerda/followers","following_url":"https://api.github.com/users/thiagolacerda/following{/other_user}","gists_url":"https://api.github.com/users/thiagolacerda/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagolacerda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagolacerda/subscriptions","organizations_url":"https://api.github.com/users/thiagolacerda/orgs","repos_url":"https://api.github.com/users/thiagolacerda/repos","events_url":"https://api.github.com/users/thiagolacerda/events{/privacy}","received_events_url":"https://api.github.com/users/thiagolacerda/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n self._x_google_marketplace = dictionary.get('x-google-marketplace', None)\r\n```","created_at":"2019-02-22T18:59:45Z","updated_at":"2019-02-22T18:59:45Z","html_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools/pull/318#discussion_r259470586","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/318","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/comments/259470586"},"html":{"href":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools/pull/318#discussion_r259470586"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/318"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/318","id":255238735,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1MjM4NzM1","html_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools/pull/318","diff_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools/pull/318.diff","patch_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools/pull/318.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues/318","number":318,"state":"open","locked":false,"title":"Update schema to support version 2","user":{"login":"huyhg","id":20563968,"node_id":"MDQ6VXNlcjIwNTYzOTY4","avatar_url":"https://avatars1.githubusercontent.com/u/20563968?v=4","gravatar_id":"","url":"https://api.github.com/users/huyhg","html_url":"https://github.com/huyhg","followers_url":"https://api.github.com/users/huyhg/followers","following_url":"https://api.github.com/users/huyhg/following{/other_user}","gists_url":"https://api.github.com/users/huyhg/gists{/gist_id}","starred_url":"https://api.github.com/users/huyhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huyhg/subscriptions","organizations_url":"https://api.github.com/users/huyhg/orgs","repos_url":"https://api.github.com/users/huyhg/repos","events_url":"https://api.github.com/users/huyhg/events{/privacy}","received_events_url":"https://api.github.com/users/huyhg/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-22T01:07:40Z","updated_at":"2019-02-22T18:59:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2371c5f9de4f6b0d87e64bd1a88de101633e17da","assignee":null,"assignees":[],"requested_reviewers":[{"login":"trironkk","id":529712,"node_id":"MDQ6VXNlcjUyOTcxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/529712?v=4","gravatar_id":"","url":"https://api.github.com/users/trironkk","html_url":"https://github.com/trironkk","followers_url":"https://api.github.com/users/trironkk/followers","following_url":"https://api.github.com/users/trironkk/following{/other_user}","gists_url":"https://api.github.com/users/trironkk/gists{/gist_id}","starred_url":"https://api.github.com/users/trironkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trironkk/subscriptions","organizations_url":"https://api.github.com/users/trironkk/orgs","repos_url":"https://api.github.com/users/trironkk/repos","events_url":"https://api.github.com/users/trironkk/events{/privacy}","received_events_url":"https://api.github.com/users/trironkk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/318/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/318/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues/318/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/statuses/1ffcc392806ec1262924001a8e4aba07562bf34f","head":{"label":"GoogleCloudPlatform:huyhg/kalm","ref":"huyhg/kalm","sha":"1ffcc392806ec1262924001a8e4aba07562bf34f","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":122230979,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyMzA5Nzk=","name":"marketplace-k8s-app-tools","full_name":"GoogleCloudPlatform/marketplace-k8s-app-tools","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/deployments","created_at":"2018-02-20T17:27:15Z","updated_at":"2019-02-22T00:27:14Z","pushed_at":"2019-02-22T01:07:40Z","git_url":"git://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools.git","ssh_url":"git@github.com:GoogleCloudPlatform/marketplace-k8s-app-tools.git","clone_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools.git","svn_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools","homepage":null,"size":917,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":37,"watchers":25,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"bb5c9aa516803f0aef7013a16c58a489ef5c2b8b","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":122230979,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyMzA5Nzk=","name":"marketplace-k8s-app-tools","full_name":"GoogleCloudPlatform/marketplace-k8s-app-tools","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/deployments","created_at":"2018-02-20T17:27:15Z","updated_at":"2019-02-22T00:27:14Z","pushed_at":"2019-02-22T01:07:40Z","git_url":"git://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools.git","ssh_url":"git@github.com:GoogleCloudPlatform/marketplace-k8s-app-tools.git","clone_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools.git","svn_url":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools","homepage":null,"size":917,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":37,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/318"},"html":{"href":"https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools/pull/318"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues/318"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools/statuses/1ffcc392806ec1262924001a8e4aba07562bf34f"}},"author_association":"COLLABORATOR"}}
|
{
"id": 122230979,
"name": "GoogleCloudPlatform/marketplace-k8s-app-tools",
"url": "https://api.github.com/repos/GoogleCloudPlatform/marketplace-k8s-app-tools"
}
|
{
"id": 2013754,
"login": "thiagolacerda",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2013754?",
"url": "https://api.github.com/users/thiagolacerda"
}
|
{
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
}
| 2019-02-22T18:59:45 |
9120105663
|
{"actor":{"display_login":"thiagolacerda"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/comments/256378451","pull_request_review_id":203188486,"id":256378451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjM3ODQ1MQ==","diff_hunk":"@@ -46,14 +46,7 @@ const CardGrid = ({ items, hidePromoText }: Props) => {\n end={!item.isPermanent ? item.end : null}\n statusOverride={item.statusOverride}\n position={i}\n- // TODO: Make this logic a little more sound\n- // This is to replicate what we have with installations at the\n- // moment\n- description={\n- item.format && item.format.title === 'Installation'\n- ? item.promoText\n- : ''\n- }\n+ description={``}","path":"common/views/components/CardGrid/CardGrid.js","position":12,"original_position":12,"commit_id":"3ebce19f2957a07f89041d1249d9561e3232a2b9","original_commit_id":"3ebce19f2957a07f89041d1249d9561e3232a2b9","user":{"login":"jamesgorrie","id":31692,"node_id":"MDQ6VXNlcjMxNjky","avatar_url":"https://avatars3.githubusercontent.com/u/31692?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesgorrie","html_url":"https://github.com/jamesgorrie","followers_url":"https://api.github.com/users/jamesgorrie/followers","following_url":"https://api.github.com/users/jamesgorrie/following{/other_user}","gists_url":"https://api.github.com/users/jamesgorrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgorrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgorrie/subscriptions","organizations_url":"https://api.github.com/users/jamesgorrie/orgs","repos_url":"https://api.github.com/users/jamesgorrie/repos","events_url":"https://api.github.com/users/jamesgorrie/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgorrie/received_events","type":"User","site_admin":false},"body":"If we're removing this, we can remove the property while we're at it.","created_at":"2019-02-13T12:42:51Z","updated_at":"2019-02-13T12:42:51Z","html_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/4124#discussion_r256378451","pull_request_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/4124","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/comments/256378451"},"html":{"href":"https://github.com/wellcometrust/wellcomecollection.org/pull/4124#discussion_r256378451"},"pull_request":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/4124"}}},"pull_request":{"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/4124","id":252667535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyNjY3NTM1","html_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/4124","diff_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/4124.diff","patch_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/4124.patch","issue_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/4124","number":4124,"state":"open","locked":false,"title":"Remove installation description","user":{"login":"davidpmccormick","id":1394592,"node_id":"MDQ6VXNlcjEzOTQ1OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1394592?v=4","gravatar_id":"","url":"https://api.github.com/users/davidpmccormick","html_url":"https://github.com/davidpmccormick","followers_url":"https://api.github.com/users/davidpmccormick/followers","following_url":"https://api.github.com/users/davidpmccormick/following{/other_user}","gists_url":"https://api.github.com/users/davidpmccormick/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpmccormick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpmccormick/subscriptions","organizations_url":"https://api.github.com/users/davidpmccormick/orgs","repos_url":"https://api.github.com/users/davidpmccormick/repos","events_url":"https://api.github.com/users/davidpmccormick/events{/privacy}","received_events_url":"https://api.github.com/users/davidpmccormick/received_events","type":"User","site_admin":false},"body":"☝️ \r\n\r\n\r\n","created_at":"2019-02-13T12:01:17Z","updated_at":"2019-02-13T12:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f21d3b6de24c0ef9a5426d7e76488b74ce5a7975","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gestchild","id":6051896,"node_id":"MDQ6VXNlcjYwNTE4OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6051896?v=4","gravatar_id":"","url":"https://api.github.com/users/gestchild","html_url":"https://github.com/gestchild","followers_url":"https://api.github.com/users/gestchild/followers","following_url":"https://api.github.com/users/gestchild/following{/other_user}","gists_url":"https://api.github.com/users/gestchild/gists{/gist_id}","starred_url":"https://api.github.com/users/gestchild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gestchild/subscriptions","organizations_url":"https://api.github.com/users/gestchild/orgs","repos_url":"https://api.github.com/users/gestchild/repos","events_url":"https://api.github.com/users/gestchild/events{/privacy}","received_events_url":"https://api.github.com/users/gestchild/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/4124/commits","review_comments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/4124/comments","review_comment_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/4124/comments","statuses_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/statuses/3ebce19f2957a07f89041d1249d9561e3232a2b9","head":{"label":"wellcometrust:installation-description","ref":"installation-description","sha":"3ebce19f2957a07f89041d1249d9561e3232a2b9","user":{"login":"wellcometrust","id":2814213,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTQyMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2814213?v=4","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":69954837,"node_id":"MDEwOlJlcG9zaXRvcnk2OTk1NDgzNw==","name":"wellcomecollection.org","full_name":"wellcometrust/wellcomecollection.org","private":false,"owner":{"login":"wellcometrust","id":2814213,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTQyMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2814213?v=4","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wellcometrust/wellcomecollection.org","description":"Wellcome Collection's website","fork":false,"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org","forks_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/forks","keys_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/teams","hooks_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/events","assignees_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/tags","blobs_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/subscription","commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/merges","archive_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/downloads","issues_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/deployments","created_at":"2016-10-04T10:29:50Z","updated_at":"2019-02-13T11:46:41Z","pushed_at":"2019-02-13T12:41:18Z","git_url":"git://github.com/wellcometrust/wellcomecollection.org.git","ssh_url":"git@github.com:wellcometrust/wellcomecollection.org.git","clone_url":"https://github.com/wellcometrust/wellcomecollection.org.git","svn_url":"https://github.com/wellcometrust/wellcomecollection.org","homepage":"https://wellcomecollection.org","size":30786,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":112,"watchers":16,"default_branch":"master"}},"base":{"label":"wellcometrust:master","ref":"master","sha":"344df5ffd79c5068282eb934ba7951d8e3c5569c","user":{"login":"wellcometrust","id":2814213,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTQyMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2814213?v=4","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":69954837,"node_id":"MDEwOlJlcG9zaXRvcnk2OTk1NDgzNw==","name":"wellcomecollection.org","full_name":"wellcometrust/wellcomecollection.org","private":false,"owner":{"login":"wellcometrust","id":2814213,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTQyMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2814213?v=4","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wellcometrust/wellcomecollection.org","description":"Wellcome Collection's website","fork":false,"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org","forks_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/forks","keys_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/teams","hooks_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/events","assignees_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/tags","blobs_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/subscription","commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/merges","archive_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/downloads","issues_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/deployments","created_at":"2016-10-04T10:29:50Z","updated_at":"2019-02-13T11:46:41Z","pushed_at":"2019-02-13T12:41:18Z","git_url":"git://github.com/wellcometrust/wellcomecollection.org.git","ssh_url":"git@github.com:wellcometrust/wellcomecollection.org.git","clone_url":"https://github.com/wellcometrust/wellcomecollection.org.git","svn_url":"https://github.com/wellcometrust/wellcomecollection.org","homepage":"https://wellcomecollection.org","size":30786,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":112,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/4124"},"html":{"href":"https://github.com/wellcometrust/wellcomecollection.org/pull/4124"},"issue":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/4124"},"comments":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/4124/comments"},"review_comments":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/4124/comments"},"review_comment":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/4124/commits"},"statuses":{"href":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/statuses/3ebce19f2957a07f89041d1249d9561e3232a2b9"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 69954837,
"name": "wellcometrust/wellcomecollection.org",
"url": "https://api.github.com/repos/wellcometrust/wellcomecollection.org"
}
|
{
"id": 31692,
"login": "jamesgorrie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31692?",
"url": "https://api.github.com/users/jamesgorrie"
}
|
{
"id": 2814213,
"login": "wellcometrust",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2814213?",
"url": "https://api.github.com/orgs/wellcometrust"
}
| 2019-02-13T12:42:51 |
9059857556
|
{"actor":{"display_login":"jamesgorrie"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/358167308","pull_request_review_id":332482786,"id":358167308,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODE2NzMwOA==","diff_hunk":"@@ -0,0 +1,103 @@\n+<!--**\n+* 2007-2019 PrestaShop SA and Contributors\n+*\n+* NOTICE OF LICENSE\n+*\n+* This source file is subject to the Open Software License (OSL 3.0)\n+* that is bundled with this package in the file LICENSE.txt.\n+* It is also available through the world-wide-web at this URL:\n+* https://opensource.org/licenses/OSL-3.0\n+* If you did not receive a copy of the license and are unable to\n+* obtain it through the world-wide-web, please send an email\n+* to license@prestashop.com so we can send you a copy immediately.\n+*\n+* DISCLAIMER\n+*\n+* Do not edit or add to this file if you wish to upgrade PrestaShop to newer\n+* versions in the future. If you wish to customize PrestaShop for your\n+* needs please refer to https://www.prestashop.com for more information.\n+*\n+* @author PrestaShop SA <contact@prestashop.com>\n+* @copyright 2007-2019 PrestaShop SA and Contributors\n+* @license https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0)\n+* International Registered Trademark & Property of PrestaShop SA\n+*-->\n+<template>\n+ <div :id=\"id\" class=\"card-block row\">\n+ <div class=\"col-sm\">\n+ <language-list\n+ v-if=\"languagesCount\"\n+ :languages=\"languages\"\n+ @selectLanguage=\"selectLanguage\"\n+ @resetLanguage=\"resetLanguage\"\n+ >\n+ </language-list>\n+\n+ <currency-modal\n+ :language=\"selectedLanguage\"\n+ @close=\"closeModal\"\n+ @applyCustomization=\"applyCustomization\"\n+ >\n+ </currency-modal>\n+ </div>\n+ </div>\n+</template>\n+\n+<script>\n+ import LanguageList from './LanguageList';\n+ import CurrencyModal from './CurrencyModal';\n+\n+ export default {\n+ name: 'currency-formatter',\n+ data: () => ({selectedLanguage: null}),\n+ props: {\n+ id: {\n+ type: String,","path":"admin-dev/themes/new-theme/js/pages/currency/form/components/CurrencyFormatter.vue","position":55,"original_position":55,"commit_id":"5f000d00603058af68fb61a553616233ea3c5bb3","original_commit_id":"5f000d00603058af68fb61a553616233ea3c5bb3","user":{"login":"PierreRambaud","id":1462701,"node_id":"MDQ6VXNlcjE0NjI3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1462701?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreRambaud","html_url":"https://github.com/PierreRambaud","followers_url":"https://api.github.com/users/PierreRambaud/followers","following_url":"https://api.github.com/users/PierreRambaud/following{/other_user}","gists_url":"https://api.github.com/users/PierreRambaud/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreRambaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreRambaud/subscriptions","organizations_url":"https://api.github.com/users/PierreRambaud/orgs","repos_url":"https://api.github.com/users/PierreRambaud/repos","events_url":"https://api.github.com/users/PierreRambaud/events{/privacy}","received_events_url":"https://api.github.com/users/PierreRambaud/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n type: Number,\r\n```\r\nShoudn't be a Number :thinking: ","created_at":"2019-12-16T10:52:00Z","updated_at":"2019-12-16T10:52:01Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/16668#discussion_r358167308","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/16668","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/358167308"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/16668#discussion_r358167308"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/16668"}}},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/16668","id":348252779,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4MjUyNzc5","html_url":"https://github.com/PrestaShop/PrestaShop/pull/16668","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/16668.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/16668.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/16668","number":16668,"state":"open","locked":false,"title":"Integrate a Vue component to manage Currency customization in the BO","user":{"login":"jolelievre","id":13801017,"node_id":"MDQ6VXNlcjEzODAxMDE3","avatar_url":"https://avatars1.githubusercontent.com/u/13801017?v=4","gravatar_id":"","url":"https://api.github.com/users/jolelievre","html_url":"https://github.com/jolelievre","followers_url":"https://api.github.com/users/jolelievre/followers","following_url":"https://api.github.com/users/jolelievre/following{/other_user}","gists_url":"https://api.github.com/users/jolelievre/gists{/gist_id}","starred_url":"https://api.github.com/users/jolelievre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolelievre/subscriptions","organizations_url":"https://api.github.com/users/jolelievre/orgs","repos_url":"https://api.github.com/users/jolelievre/repos","events_url":"https://api.github.com/users/jolelievre/events{/privacy}","received_events_url":"https://api.github.com/users/jolelievre/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information.\r\n\r\nCheck out our contribution guidelines to find out how to complete it:\r\nhttps://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/#pull-requests\r\n -->\r\n\r\n| Questions | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch? | develop\r\n| Description? | Integrate Vue component into Currency form edition to customize the format for each language\r\n| Type? | new feature\r\n| Category? | BO\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed ticket? | Fixes #14750\r\n| How to test? | Go to International > Localization > Currencies, edit one of your currencies You can change the display (by language) and change the symbol and its position Once the form is saved the modification should work instantly in the front (the cache has been cleared)<br />Then you try the reset button (in the customization list) and the Reset default button (for official currencies only) and check that the format is correctly reset<br />Also try it with \"unusual\" currency formats like for languages Dutch (with negative pattern) or Hindi (the group size is 2 not 3)\r\n\r\n<!-- Click the form's \"Preview\" button to make sure the table is functional in GitHub. Thank you! -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/16668)\r\n<!-- Reviewable:end -->\r\n","created_at":"2019-12-03T10:39:19Z","updated_at":"2019-12-16T10:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e50f098030b419cf44e24f868031f473d01ef20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":19737369,"node_id":"MDU6TGFiZWwxOTczNzM2OQ==","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Bug","name":"Bug","color":"d4c5f9","default":false,"description":"Type: Bug"},{"id":982530767,"node_id":"MDU6TGFiZWw5ODI1MzA3Njc=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Feature","name":"Feature","color":"d4c5f9","default":false,"description":"Type: New Feature"},{"id":1126077824,"node_id":"MDU6TGFiZWwxMTI2MDc3ODI0","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Wording%20%E2%9C%94%EF%B8%8F","name":"Wording ✔️","color":"b8ed50","default":false,"description":"Status: Wording-Approved"},{"id":904910825,"node_id":"MDU6TGFiZWw5MDQ5MTA4MjU=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"6270ea","default":false,"description":"Branch"}],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/16668/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/16668/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/16668/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/5f000d00603058af68fb61a553616233ea3c5bb3","head":{"label":"jolelievre:currency-custom","ref":"currency-custom","sha":"5f000d00603058af68fb61a553616233ea3c5bb3","user":{"login":"jolelievre","id":13801017,"node_id":"MDQ6VXNlcjEzODAxMDE3","avatar_url":"https://avatars1.githubusercontent.com/u/13801017?v=4","gravatar_id":"","url":"https://api.github.com/users/jolelievre","html_url":"https://github.com/jolelievre","followers_url":"https://api.github.com/users/jolelievre/followers","following_url":"https://api.github.com/users/jolelievre/following{/other_user}","gists_url":"https://api.github.com/users/jolelievre/gists{/gist_id}","starred_url":"https://api.github.com/users/jolelievre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolelievre/subscriptions","organizations_url":"https://api.github.com/users/jolelievre/orgs","repos_url":"https://api.github.com/users/jolelievre/repos","events_url":"https://api.github.com/users/jolelievre/events{/privacy}","received_events_url":"https://api.github.com/users/jolelievre/received_events","type":"User","site_admin":false},"repo":{"id":143984804,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5ODQ4MDQ=","name":"PrestaShop","full_name":"jolelievre/PrestaShop","private":false,"owner":{"login":"jolelievre","id":13801017,"node_id":"MDQ6VXNlcjEzODAxMDE3","avatar_url":"https://avatars1.githubusercontent.com/u/13801017?v=4","gravatar_id":"","url":"https://api.github.com/users/jolelievre","html_url":"https://github.com/jolelievre","followers_url":"https://api.github.com/users/jolelievre/followers","following_url":"https://api.github.com/users/jolelievre/following{/other_user}","gists_url":"https://api.github.com/users/jolelievre/gists{/gist_id}","starred_url":"https://api.github.com/users/jolelievre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolelievre/subscriptions","organizations_url":"https://api.github.com/users/jolelievre/orgs","repos_url":"https://api.github.com/users/jolelievre/repos","events_url":"https://api.github.com/users/jolelievre/events{/privacy}","received_events_url":"https://api.github.com/users/jolelievre/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jolelievre/PrestaShop","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":true,"url":"https://api.github.com/repos/jolelievre/PrestaShop","forks_url":"https://api.github.com/repos/jolelievre/PrestaShop/forks","keys_url":"https://api.github.com/repos/jolelievre/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jolelievre/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jolelievre/PrestaShop/teams","hooks_url":"https://api.github.com/repos/jolelievre/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/jolelievre/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/jolelievre/PrestaShop/events","assignees_url":"https://api.github.com/repos/jolelievre/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/jolelievre/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/jolelievre/PrestaShop/tags","blobs_url":"https://api.github.com/repos/jolelievre/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jolelievre/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jolelievre/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/jolelievre/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jolelievre/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/jolelievre/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/jolelievre/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/jolelievre/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/jolelievre/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/jolelievre/PrestaShop/subscription","commits_url":"https://api.github.com/repos/jolelievre/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/jolelievre/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/jolelievre/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/jolelievre/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/jolelievre/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/jolelievre/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jolelievre/PrestaShop/merges","archive_url":"https://api.github.com/repos/jolelievre/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jolelievre/PrestaShop/downloads","issues_url":"https://api.github.com/repos/jolelievre/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/jolelievre/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/jolelievre/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/jolelievre/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jolelievre/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/jolelievre/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/jolelievre/PrestaShop/deployments","created_at":"2018-08-08T08:35:21Z","updated_at":"2019-12-03T14:21:29Z","pushed_at":"2019-12-13T13:57:33Z","git_url":"git://github.com/jolelievre/PrestaShop.git","ssh_url":"git@github.com:jolelievre/PrestaShop.git","clone_url":"https://github.com/jolelievre/PrestaShop.git","svn_url":"https://github.com/jolelievre/PrestaShop","homepage":"http://www.prestashop.com/","size":410303,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:develop","ref":"develop","sha":"87a8b3b90577ec48b24a28e4f4ad5ea707b7bc51","user":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYzNTg3","name":"PrestaShop","full_name":"PrestaShop/PrestaShop","private":false,"owner":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2019-12-16T10:30:41Z","pushed_at":"2019-12-16T10:30:33Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"https://www.prestashop.com/","size":495853,"stargazers_count":4270,"watchers_count":4270,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3465,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1712,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3465,"open_issues":1712,"watchers":4270,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/16668"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/16668"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/16668"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/16668/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/16668/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/16668/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/5f000d00603058af68fb61a553616233ea3c5bb3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 6763587,
"name": "PrestaShop/PrestaShop",
"url": "https://api.github.com/repos/PrestaShop/PrestaShop"
}
|
{
"id": 1462701,
"login": "PierreRambaud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1462701?",
"url": "https://api.github.com/users/PierreRambaud"
}
|
{
"id": 2815696,
"login": "PrestaShop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2815696?",
"url": "https://api.github.com/orgs/PrestaShop"
}
| 2019-12-16T10:52:00 |
11096305269
|
{"actor":{"display_login":"PierreRambaud"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/283208222","pull_request_review_id":236501970,"id":283208222,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzIwODIyMg==","diff_hunk":"@@ -0,0 +1,40 @@\n+<?php\n+/**\n+ * 2007-2019 PrestaShop SA and Contributors\n+ *\n+ * NOTICE OF LICENSE\n+ *\n+ * This source file is subject to the Open Software License (OSL 3.0)\n+ * that is bundled with this package in the file LICENSE.txt.\n+ * It is also available through the world-wide-web at this URL:\n+ * https://opensource.org/licenses/OSL-3.0\n+ * If you did not receive a copy of the license and are unable to\n+ * obtain it through the world-wide-web, please send an email\n+ * to license@prestashop.com so we can send you a copy immediately.\n+ *\n+ * DISCLAIMER\n+ *\n+ * Do not edit or add to this file if you wish to upgrade PrestaShop to newer\n+ * versions in the future. If you wish to customize PrestaShop for your\n+ * needs please refer to http://www.prestashop.com for more information.\n+ *\n+ * @author PrestaShop SA <contact@prestashop.com>\n+ * @copyright 2007-2019 PrestaShop SA and Contributors\n+ * @license https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0)\n+ * International Registered Trademark & Property of PrestaShop SA\n+ */\n+\n+namespace PrestaShop\\PrestaShop\\Core\\Util\\String;\n+\n+/**\n+ * Defines reusable methods for strings modifications.\n+ */\n+interface StringModifierInterface","path":"src/Core/Util/String/StringModifierInterface.php","position":32,"original_position":32,"commit_id":"84e0623ee09122c9f54af0987b56bc1b44dbd317","original_commit_id":"84e0623ee09122c9f54af0987b56bc1b44dbd317","user":{"login":"tomas862","id":17051250,"node_id":"MDQ6VXNlcjE3MDUxMjUw","avatar_url":"https://avatars3.githubusercontent.com/u/17051250?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas862","html_url":"https://github.com/tomas862","followers_url":"https://api.github.com/users/tomas862/followers","following_url":"https://api.github.com/users/tomas862/following{/other_user}","gists_url":"https://api.github.com/users/tomas862/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas862/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas862/subscriptions","organizations_url":"https://api.github.com/users/tomas862/orgs","repos_url":"https://api.github.com/users/tomas862/repos","events_url":"https://api.github.com/users/tomas862/events{/privacy}","received_events_url":"https://api.github.com/users/tomas862/received_events","type":"User","site_admin":false},"body":"the method `splitByCamelCase` was very useful in my case - its a low chance that someone will need it. Main reason I split the functionality due to I could easily apply tests for it, I feel more secure with tests applied here. \r\n\r\nAnyway, in my opinion since it is in `util` folder I would keep it here :slightly_smiling_face: ","created_at":"2019-05-13T07:01:37Z","updated_at":"2019-05-13T07:01:37Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/13593#discussion_r283208222","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/13593","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/283208222"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/13593#discussion_r283208222"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/13593"}},"in_reply_to_id":282402161},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/13593","id":274093631,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0MDkzNjMx","html_url":"https://github.com/PrestaShop/PrestaShop/pull/13593","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/13593.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/13593.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/13593","number":13593,"state":"open","locked":false,"title":"Automated hooks discovery and updating hooks list in xml and sql files","user":{"login":"tomas862","id":17051250,"node_id":"MDQ6VXNlcjE3MDUxMjUw","avatar_url":"https://avatars3.githubusercontent.com/u/17051250?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas862","html_url":"https://github.com/tomas862","followers_url":"https://api.github.com/users/tomas862/followers","following_url":"https://api.github.com/users/tomas862/following{/other_user}","gists_url":"https://api.github.com/users/tomas862/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas862/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas862/subscriptions","organizations_url":"https://api.github.com/users/tomas862/orgs","repos_url":"https://api.github.com/users/tomas862/repos","events_url":"https://api.github.com/users/tomas862/events{/privacy}","received_events_url":"https://api.github.com/users/tomas862/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information.\r\n\r\nCheck out our contribution guidelines to find out how to complete it:\r\nhttps://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/#pull-requests\r\n -->\r\n\r\n| Questions | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch? | develop\r\n| Description? | With just a single command you can list all the hooks and if they are new they will be appended to the **install-dev/data/xml/hook.xml** file\r\n| Type? | new feature\r\n| Category? | BO\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed ticket? | https://github.com/PrestaShop/PrestaShop/issues/13408 not fully\r\n| How to test? | Just need to check if all hooks from options, identifiable object forms and grid are added to the file.\r\n\r\n<!-- Click the form's \"Preview\" button to make sure the table is functional in GitHub. Thank you! -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/13593)\n<!-- Reviewable:end -->\n","created_at":"2019-04-27T09:01:19Z","updated_at":"2019-05-13T07:01:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f42dfa1679b5285a144c79404e7b51b421c06f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":982530767,"node_id":"MDU6TGFiZWw5ODI1MzA3Njc=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Feature","name":"Feature","color":"d4c5f9","default":false},{"id":904910825,"node_id":"MDU6TGFiZWw5MDQ5MTA4MjU=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"6270ea","default":false},{"id":1039184119,"node_id":"MDU6TGFiZWwxMDM5MTg0MTE5","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/migration","name":"migration","color":"06e032","default":false},{"id":186105912,"node_id":"MDU6TGFiZWwxODYxMDU5MTI=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/waiting%20for%20author","name":"waiting for author","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/13593/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/13593/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/13593/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/84e0623ee09122c9f54af0987b56bc1b44dbd317","head":{"label":"tomas862:features/auto-hooks-discovery-and-xml-sql-file-generation","ref":"features/auto-hooks-discovery-and-xml-sql-file-generation","sha":"84e0623ee09122c9f54af0987b56bc1b44dbd317","user":{"login":"tomas862","id":17051250,"node_id":"MDQ6VXNlcjE3MDUxMjUw","avatar_url":"https://avatars3.githubusercontent.com/u/17051250?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas862","html_url":"https://github.com/tomas862","followers_url":"https://api.github.com/users/tomas862/followers","following_url":"https://api.github.com/users/tomas862/following{/other_user}","gists_url":"https://api.github.com/users/tomas862/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas862/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas862/subscriptions","organizations_url":"https://api.github.com/users/tomas862/orgs","repos_url":"https://api.github.com/users/tomas862/repos","events_url":"https://api.github.com/users/tomas862/events{/privacy}","received_events_url":"https://api.github.com/users/tomas862/received_events","type":"User","site_admin":false},"repo":{"id":145734441,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3MzQ0NDE=","name":"PrestaShop","full_name":"tomas862/PrestaShop","private":false,"owner":{"login":"tomas862","id":17051250,"node_id":"MDQ6VXNlcjE3MDUxMjUw","avatar_url":"https://avatars3.githubusercontent.com/u/17051250?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas862","html_url":"https://github.com/tomas862","followers_url":"https://api.github.com/users/tomas862/followers","following_url":"https://api.github.com/users/tomas862/following{/other_user}","gists_url":"https://api.github.com/users/tomas862/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas862/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas862/subscriptions","organizations_url":"https://api.github.com/users/tomas862/orgs","repos_url":"https://api.github.com/users/tomas862/repos","events_url":"https://api.github.com/users/tomas862/events{/privacy}","received_events_url":"https://api.github.com/users/tomas862/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tomas862/PrestaShop","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":true,"url":"https://api.github.com/repos/tomas862/PrestaShop","forks_url":"https://api.github.com/repos/tomas862/PrestaShop/forks","keys_url":"https://api.github.com/repos/tomas862/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomas862/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomas862/PrestaShop/teams","hooks_url":"https://api.github.com/repos/tomas862/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/tomas862/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/tomas862/PrestaShop/events","assignees_url":"https://api.github.com/repos/tomas862/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/tomas862/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/tomas862/PrestaShop/tags","blobs_url":"https://api.github.com/repos/tomas862/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomas862/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomas862/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomas862/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomas862/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/tomas862/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/tomas862/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/tomas862/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/tomas862/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/tomas862/PrestaShop/subscription","commits_url":"https://api.github.com/repos/tomas862/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomas862/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomas862/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomas862/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomas862/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/tomas862/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomas862/PrestaShop/merges","archive_url":"https://api.github.com/repos/tomas862/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomas862/PrestaShop/downloads","issues_url":"https://api.github.com/repos/tomas862/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/tomas862/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/tomas862/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/tomas862/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomas862/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/tomas862/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/tomas862/PrestaShop/deployments","created_at":"2018-08-22T16:22:27Z","updated_at":"2019-05-03T11:55:21Z","pushed_at":"2019-05-08T14:42:41Z","git_url":"git://github.com/tomas862/PrestaShop.git","ssh_url":"git@github.com:tomas862/PrestaShop.git","clone_url":"https://github.com/tomas862/PrestaShop.git","svn_url":"https://github.com/tomas862/PrestaShop","homepage":"http://www.prestashop.com/","size":379410,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:develop","ref":"develop","sha":"584c02f661ee6e6da63bc14ff23425e1c60f9a64","user":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYzNTg3","name":"PrestaShop","full_name":"PrestaShop/PrestaShop","private":false,"owner":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2019-05-12T22:01:32Z","pushed_at":"2019-05-13T06:53:30Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":440442,"stargazers_count":3641,"watchers_count":3641,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3166,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1416,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3166,"open_issues":1416,"watchers":3641,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/13593"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/13593"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/13593"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/13593/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/13593/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/13593/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/84e0623ee09122c9f54af0987b56bc1b44dbd317"}},"author_association":"MEMBER"}}
|
{
"id": 6763587,
"name": "PrestaShop/PrestaShop",
"url": "https://api.github.com/repos/PrestaShop/PrestaShop"
}
|
{
"id": 17051250,
"login": "tomas862",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17051250?",
"url": "https://api.github.com/users/tomas862"
}
|
{
"id": 2815696,
"login": "PrestaShop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2815696?",
"url": "https://api.github.com/orgs/PrestaShop"
}
| 2019-05-13T07:01:37 |
9611718484
|
{"actor":{"display_login":"tomas862"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/comments/364625610","pull_request_review_id":340374329,"id":364625610,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDYyNTYxMA==","diff_hunk":"@@ -0,0 +1,132 @@\n+---\n+layout: post\n+title: \"Do you speak PrestaShop? – December 2019 edition\"\n+subtitle: \"Where you'll learn that PrestaShop was awarded for its international strategy\"\n+date: 2020-01-09 09:10:11\n+authors: [LouiseBonnard]\n+icon: icon-world\n+image: /assets/images/2019/01/Build-Crowdin-banner.jpg\n+tags: [translation, i18n, l10n]\n+---\n+\n+Contributing to PrestaShop is not only about the code, it's also about taking part in the [PrestaShop translation project](https://crowdin.com/project/prestashop-official)! This report tells you how the translations of the software evolved in December.\n+\n+\n+\n+## Project news\n+\n+\n+### :sparkles: Best wishes for 2020\n+\n+It is that time of the year, so let us send you our best wishes for 2020! We know it is not celebrated everywhere yet but it is never too early to do so: have a happy new year, with love from family and friends, challenging and fulfilling professional opportunities and great vibes in your everyday life. You have been great in 2019, I am sure you will be even more wonderful in 2020. :-)\n+\n+\n+### :trophy: PrestaShop wins, you win\n+\n+At the [Paris Open Source Summit]( https://www.opensourcesummit.paris) in December, PrestaShop has been surprised and delighted to receive… a prize for its international development! Awarded by the CNLL ([read here, in French]( https://cnll.fr/news/le-cnll-r%C3%A9v%C3%A8le-les-laur%C3%A9ats-du-concours-des-acteurs-du-libre-2019)), it rewards the international development strategy carried out since the creation of PrestaShop, possible because of its community.","path":"news/_posts/translation/2020-01-09-do-you-speak-prestashop-december-2019.md","position":26,"original_position":26,"commit_id":"7211eb22a90828ced0364128bfaa487222828a85","original_commit_id":"7211eb22a90828ced0364128bfaa487222828a85","user":{"login":"LouiseBonnard","id":32565890,"node_id":"MDQ6VXNlcjMyNTY1ODkw","avatar_url":"https://avatars0.githubusercontent.com/u/32565890?v=4","gravatar_id":"","url":"https://api.github.com/users/LouiseBonnard","html_url":"https://github.com/LouiseBonnard","followers_url":"https://api.github.com/users/LouiseBonnard/followers","following_url":"https://api.github.com/users/LouiseBonnard/following{/other_user}","gists_url":"https://api.github.com/users/LouiseBonnard/gists{/gist_id}","starred_url":"https://api.github.com/users/LouiseBonnard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LouiseBonnard/subscriptions","organizations_url":"https://api.github.com/users/LouiseBonnard/orgs","repos_url":"https://api.github.com/users/LouiseBonnard/repos","events_url":"https://api.github.com/users/LouiseBonnard/events{/privacy}","received_events_url":"https://api.github.com/users/LouiseBonnard/received_events","type":"User","site_admin":false},"body":"Thanks for the review!","created_at":"2020-01-09T09:09:07Z","updated_at":"2020-01-09T09:09:08Z","html_url":"https://github.com/PrestaShop/prestashop.github.io/pull/616#discussion_r364625610","pull_request_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/616","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/comments/364625610"},"html":{"href":"https://github.com/PrestaShop/prestashop.github.io/pull/616#discussion_r364625610"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/616"}},"in_reply_to_id":364613396},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/616","id":360565073,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYwNTY1MDcz","html_url":"https://github.com/PrestaShop/prestashop.github.io/pull/616","diff_url":"https://github.com/PrestaShop/prestashop.github.io/pull/616.diff","patch_url":"https://github.com/PrestaShop/prestashop.github.io/pull/616.patch","issue_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues/616","number":616,"state":"open","locked":false,"title":"DYSP 12/19","user":{"login":"LouiseBonnard","id":32565890,"node_id":"MDQ6VXNlcjMyNTY1ODkw","avatar_url":"https://avatars0.githubusercontent.com/u/32565890?v=4","gravatar_id":"","url":"https://api.github.com/users/LouiseBonnard","html_url":"https://github.com/LouiseBonnard","followers_url":"https://api.github.com/users/LouiseBonnard/followers","following_url":"https://api.github.com/users/LouiseBonnard/following{/other_user}","gists_url":"https://api.github.com/users/LouiseBonnard/gists{/gist_id}","starred_url":"https://api.github.com/users/LouiseBonnard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LouiseBonnard/subscriptions","organizations_url":"https://api.github.com/users/LouiseBonnard/orgs","repos_url":"https://api.github.com/users/LouiseBonnard/repos","events_url":"https://api.github.com/users/LouiseBonnard/events{/privacy}","received_events_url":"https://api.github.com/users/LouiseBonnard/received_events","type":"User","site_admin":false},"body":"","created_at":"2020-01-08T17:16:09Z","updated_at":"2020-01-09T09:09:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddc4b1f2f567ca1ec5f577e434dd4a8c1a438590","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/616/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/616/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues/616/comments","statuses_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/statuses/7211eb22a90828ced0364128bfaa487222828a85","head":{"label":"PrestaShop:LouiseBonnard-patch-2","ref":"LouiseBonnard-patch-2","sha":"7211eb22a90828ced0364128bfaa487222828a85","user":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":31912519,"node_id":"MDEwOlJlcG9zaXRvcnkzMTkxMjUxOQ==","name":"prestashop.github.io","full_name":"PrestaShop/prestashop.github.io","private":false,"owner":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrestaShop/prestashop.github.io","description":"PrestaShop Build: Official blog for PrestaShop development straight from the product and core dev team.","fork":false,"url":"https://api.github.com/repos/PrestaShop/prestashop.github.io","forks_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/forks","keys_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/teams","hooks_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/events","assignees_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/tags","blobs_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/subscription","commits_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/merges","archive_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/downloads","issues_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/deployments","created_at":"2015-03-09T17:27:49Z","updated_at":"2020-01-08T15:14:38Z","pushed_at":"2020-01-09T08:59:56Z","git_url":"git://github.com/PrestaShop/prestashop.github.io.git","ssh_url":"git@github.com:PrestaShop/prestashop.github.io.git","clone_url":"https://github.com/PrestaShop/prestashop.github.io.git","svn_url":"https://github.com/PrestaShop/prestashop.github.io","homepage":"https://build.prestashop.com/","size":94054,"stargazers_count":18,"watchers_count":18,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":null,"forks":37,"open_issues":17,"watchers":18,"default_branch":"master"}},"base":{"label":"PrestaShop:master","ref":"master","sha":"77e89fc18f54ba9f2a046c5ff40782a0fb5ef5e5","user":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":31912519,"node_id":"MDEwOlJlcG9zaXRvcnkzMTkxMjUxOQ==","name":"prestashop.github.io","full_name":"PrestaShop/prestashop.github.io","private":false,"owner":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrestaShop/prestashop.github.io","description":"PrestaShop Build: Official blog for PrestaShop development straight from the product and core dev team.","fork":false,"url":"https://api.github.com/repos/PrestaShop/prestashop.github.io","forks_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/forks","keys_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/teams","hooks_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/events","assignees_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/tags","blobs_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/subscription","commits_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/merges","archive_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/downloads","issues_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/prestashop.github.io/deployments","created_at":"2015-03-09T17:27:49Z","updated_at":"2020-01-08T15:14:38Z","pushed_at":"2020-01-09T08:59:56Z","git_url":"git://github.com/PrestaShop/prestashop.github.io.git","ssh_url":"git@github.com:PrestaShop/prestashop.github.io.git","clone_url":"https://github.com/PrestaShop/prestashop.github.io.git","svn_url":"https://github.com/PrestaShop/prestashop.github.io","homepage":"https://build.prestashop.com/","size":94054,"stargazers_count":18,"watchers_count":18,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":null,"forks":37,"open_issues":17,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/616"},"html":{"href":"https://github.com/PrestaShop/prestashop.github.io/pull/616"},"issue":{"href":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues/616"},"comments":{"href":"https://api.github.com/repos/PrestaShop/prestashop.github.io/issues/616/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/616/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/prestashop.github.io/pulls/616/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/prestashop.github.io/statuses/7211eb22a90828ced0364128bfaa487222828a85"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 31912519,
"name": "PrestaShop/prestashop.github.io",
"url": "https://api.github.com/repos/PrestaShop/prestashop.github.io"
}
|
{
"id": 32565890,
"login": "LouiseBonnard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32565890?",
"url": "https://api.github.com/users/LouiseBonnard"
}
|
{
"id": 2815696,
"login": "PrestaShop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2815696?",
"url": "https://api.github.com/orgs/PrestaShop"
}
| 2020-01-09T09:09:07 |
11235793605
|
{"actor":{"display_login":"LouiseBonnard"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/comments/326846398","pull_request_review_id":291449922,"id":326846398,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjg0NjM5OA==","diff_hunk":"@@ -0,0 +1,15 @@\n+<!DOCTYPE html>","path":"src/index2.html","position":1,"original_position":1,"commit_id":"0a537e2a94f07d106250c459f574a592dda061c5","original_commit_id":"0a537e2a94f07d106250c459f574a592dda061c5","user":{"login":"gndx","id":10554486,"node_id":"MDQ6VXNlcjEwNTU0NDg2","avatar_url":"https://avatars0.githubusercontent.com/u/10554486?v=4","gravatar_id":"","url":"https://api.github.com/users/gndx","html_url":"https://github.com/gndx","followers_url":"https://api.github.com/users/gndx/followers","following_url":"https://api.github.com/users/gndx/following{/other_user}","gists_url":"https://api.github.com/users/gndx/gists{/gist_id}","starred_url":"https://api.github.com/users/gndx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gndx/subscriptions","organizations_url":"https://api.github.com/users/gndx/orgs","repos_url":"https://api.github.com/users/gndx/repos","events_url":"https://api.github.com/users/gndx/events{/privacy}","received_events_url":"https://api.github.com/users/gndx/received_events","type":"User","site_admin":false},"body":"Este documento no es necesario. ","created_at":"2019-09-21T04:17:04Z","updated_at":"2019-09-21T04:17:40Z","html_url":"https://github.com/platzi/escuelajs-reto-03/pull/51#discussion_r326846398","pull_request_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/51","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/comments/326846398"},"html":{"href":"https://github.com/platzi/escuelajs-reto-03/pull/51#discussion_r326846398"},"pull_request":{"href":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/51","id":317613717,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NjEzNzE3","html_url":"https://github.com/platzi/escuelajs-reto-03/pull/51","diff_url":"https://github.com/platzi/escuelajs-reto-03/pull/51.diff","patch_url":"https://github.com/platzi/escuelajs-reto-03/pull/51.patch","issue_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/issues/51","number":51,"state":"open","locked":false,"title":"Se terminaronlos retos","user":{"login":"javierfuentesm","id":19244527,"node_id":"MDQ6VXNlcjE5MjQ0NTI3","avatar_url":"https://avatars1.githubusercontent.com/u/19244527?v=4","gravatar_id":"","url":"https://api.github.com/users/javierfuentesm","html_url":"https://github.com/javierfuentesm","followers_url":"https://api.github.com/users/javierfuentesm/followers","following_url":"https://api.github.com/users/javierfuentesm/following{/other_user}","gists_url":"https://api.github.com/users/javierfuentesm/gists{/gist_id}","starred_url":"https://api.github.com/users/javierfuentesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierfuentesm/subscriptions","organizations_url":"https://api.github.com/users/javierfuentesm/orgs","repos_url":"https://api.github.com/users/javierfuentesm/repos","events_url":"https://api.github.com/users/javierfuentesm/events{/privacy}","received_events_url":"https://api.github.com/users/javierfuentesm/received_events","type":"User","site_admin":false},"body":"## DESCRIPTION\r\ntermine los retos , los dos primeros se pueden ver en el archivo index.html ,\r\nel tercer reto al solicitar ayuda a mi mentor me dijo que podía usar fetch así que decidí aprender y usarlo , me dijo que son en cierta manera promesas , asi que hice que por eso decidí ponerlo en otro archivo llamado index2.html para que pudiera visualizare que termine los tres retos \r\nNombre:\r\nUsuario Platzi: javier.fuentesm@hotmail.com\r\n\r\n## Ciudad\r\n- [ X] Ciudad de México\r\n- [ ] Bogotá\r\n\r\n# Retos:\r\n - [ X] Primer problema\r\n - [ X] Segundo problema\r\n - [ X] Tercer problema\r\n","created_at":"2019-09-15T06:30:06Z","updated_at":"2019-09-21T04:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"216015d4720f046bbfdc0b9a4bbb83519d3b24f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/51/commits","review_comments_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/51/comments","review_comment_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/comments{/number}","comments_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/issues/51/comments","statuses_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/statuses/0a537e2a94f07d106250c459f574a592dda061c5","head":{"label":"javierfuentesm:master","ref":"master","sha":"0a537e2a94f07d106250c459f574a592dda061c5","user":{"login":"javierfuentesm","id":19244527,"node_id":"MDQ6VXNlcjE5MjQ0NTI3","avatar_url":"https://avatars1.githubusercontent.com/u/19244527?v=4","gravatar_id":"","url":"https://api.github.com/users/javierfuentesm","html_url":"https://github.com/javierfuentesm","followers_url":"https://api.github.com/users/javierfuentesm/followers","following_url":"https://api.github.com/users/javierfuentesm/following{/other_user}","gists_url":"https://api.github.com/users/javierfuentesm/gists{/gist_id}","starred_url":"https://api.github.com/users/javierfuentesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierfuentesm/subscriptions","organizations_url":"https://api.github.com/users/javierfuentesm/orgs","repos_url":"https://api.github.com/users/javierfuentesm/repos","events_url":"https://api.github.com/users/javierfuentesm/events{/privacy}","received_events_url":"https://api.github.com/users/javierfuentesm/received_events","type":"User","site_admin":false},"repo":{"id":208551132,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg1NTExMzI=","name":"escuelajs-reto-03","full_name":"javierfuentesm/escuelajs-reto-03","private":false,"owner":{"login":"javierfuentesm","id":19244527,"node_id":"MDQ6VXNlcjE5MjQ0NTI3","avatar_url":"https://avatars1.githubusercontent.com/u/19244527?v=4","gravatar_id":"","url":"https://api.github.com/users/javierfuentesm","html_url":"https://github.com/javierfuentesm","followers_url":"https://api.github.com/users/javierfuentesm/followers","following_url":"https://api.github.com/users/javierfuentesm/following{/other_user}","gists_url":"https://api.github.com/users/javierfuentesm/gists{/gist_id}","starred_url":"https://api.github.com/users/javierfuentesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierfuentesm/subscriptions","organizations_url":"https://api.github.com/users/javierfuentesm/orgs","repos_url":"https://api.github.com/users/javierfuentesm/repos","events_url":"https://api.github.com/users/javierfuentesm/events{/privacy}","received_events_url":"https://api.github.com/users/javierfuentesm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/javierfuentesm/escuelajs-reto-03","description":"Reto 3 Septiembre 14: Curso de Fundamentos de JavaScript","fork":true,"url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03","forks_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/forks","keys_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/teams","hooks_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/hooks","issue_events_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/issues/events{/number}","events_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/events","assignees_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/assignees{/user}","branches_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/branches{/branch}","tags_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/tags","blobs_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/statuses/{sha}","languages_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/languages","stargazers_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/stargazers","contributors_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/contributors","subscribers_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/subscribers","subscription_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/subscription","commits_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/issues/comments{/number}","contents_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/contents/{+path}","compare_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/merges","archive_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/downloads","issues_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/issues{/number}","pulls_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/pulls{/number}","milestones_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/milestones{/number}","notifications_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/labels{/name}","releases_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/releases{/id}","deployments_url":"https://api.github.com/repos/javierfuentesm/escuelajs-reto-03/deployments","created_at":"2019-09-15T06:18:56Z","updated_at":"2019-09-15T06:25:33Z","pushed_at":"2019-09-15T06:25:31Z","git_url":"git://github.com/javierfuentesm/escuelajs-reto-03.git","ssh_url":"git@github.com:javierfuentesm/escuelajs-reto-03.git","clone_url":"https://github.com/javierfuentesm/escuelajs-reto-03.git","svn_url":"https://github.com/javierfuentesm/escuelajs-reto-03","homepage":"https://platzi.com","size":6,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"platzi:master","ref":"master","sha":"eb2b1da9a514bf06621cef6db0b6d05a190ba77f","user":{"login":"platzi","id":2975064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUwNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2975064?v=4","gravatar_id":"","url":"https://api.github.com/users/platzi","html_url":"https://github.com/platzi","followers_url":"https://api.github.com/users/platzi/followers","following_url":"https://api.github.com/users/platzi/following{/other_user}","gists_url":"https://api.github.com/users/platzi/gists{/gist_id}","starred_url":"https://api.github.com/users/platzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platzi/subscriptions","organizations_url":"https://api.github.com/users/platzi/orgs","repos_url":"https://api.github.com/users/platzi/repos","events_url":"https://api.github.com/users/platzi/events{/privacy}","received_events_url":"https://api.github.com/users/platzi/received_events","type":"Organization","site_admin":false},"repo":{"id":208140665,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgxNDA2NjU=","name":"escuelajs-reto-03","full_name":"platzi/escuelajs-reto-03","private":false,"owner":{"login":"platzi","id":2975064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUwNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2975064?v=4","gravatar_id":"","url":"https://api.github.com/users/platzi","html_url":"https://github.com/platzi","followers_url":"https://api.github.com/users/platzi/followers","following_url":"https://api.github.com/users/platzi/following{/other_user}","gists_url":"https://api.github.com/users/platzi/gists{/gist_id}","starred_url":"https://api.github.com/users/platzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platzi/subscriptions","organizations_url":"https://api.github.com/users/platzi/orgs","repos_url":"https://api.github.com/users/platzi/repos","events_url":"https://api.github.com/users/platzi/events{/privacy}","received_events_url":"https://api.github.com/users/platzi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/platzi/escuelajs-reto-03","description":"Reto 3 Septiembre 14: Curso de Fundamentos de JavaScript","fork":false,"url":"https://api.github.com/repos/platzi/escuelajs-reto-03","forks_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/forks","keys_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/keys{/key_id}","collaborators_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/teams","hooks_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/hooks","issue_events_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/issues/events{/number}","events_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/events","assignees_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/assignees{/user}","branches_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/branches{/branch}","tags_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/tags","blobs_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/git/refs{/sha}","trees_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/git/trees{/sha}","statuses_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/statuses/{sha}","languages_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/languages","stargazers_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/stargazers","contributors_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/contributors","subscribers_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/subscribers","subscription_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/subscription","commits_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/commits{/sha}","git_commits_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/git/commits{/sha}","comments_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/comments{/number}","issue_comment_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/issues/comments{/number}","contents_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/contents/{+path}","compare_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/compare/{base}...{head}","merges_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/merges","archive_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/downloads","issues_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/issues{/number}","pulls_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls{/number}","milestones_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/milestones{/number}","notifications_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/labels{/name}","releases_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/releases{/id}","deployments_url":"https://api.github.com/repos/platzi/escuelajs-reto-03/deployments","created_at":"2019-09-12T20:28:07Z","updated_at":"2019-09-19T18:33:25Z","pushed_at":"2019-09-21T04:02:31Z","git_url":"git://github.com/platzi/escuelajs-reto-03.git","ssh_url":"git@github.com:platzi/escuelajs-reto-03.git","clone_url":"https://github.com/platzi/escuelajs-reto-03.git","svn_url":"https://github.com/platzi/escuelajs-reto-03","homepage":"https://platzi.com","size":5,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":98,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":138,"open_issues":98,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/51"},"html":{"href":"https://github.com/platzi/escuelajs-reto-03/pull/51"},"issue":{"href":"https://api.github.com/repos/platzi/escuelajs-reto-03/issues/51"},"comments":{"href":"https://api.github.com/repos/platzi/escuelajs-reto-03/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/platzi/escuelajs-reto-03/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/platzi/escuelajs-reto-03/statuses/0a537e2a94f07d106250c459f574a592dda061c5"}},"author_association":"NONE"}}
|
{
"id": 208140665,
"name": "platzi/escuelajs-reto-03",
"url": "https://api.github.com/repos/platzi/escuelajs-reto-03"
}
|
{
"id": 10554486,
"login": "gndx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10554486?",
"url": "https://api.github.com/users/gndx"
}
|
{
"id": 2975064,
"login": "platzi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2975064?",
"url": "https://api.github.com/orgs/platzi"
}
| 2019-09-21T04:17:04 |
10464735438
|
{"actor":{"display_login":"gndx"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/aixigo/PREvant/pulls/comments/306155944","pull_request_review_id":265204761,"id":306155944,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjE1NTk0NA==","diff_hunk":"@@ -131,6 +125,42 @@ paths:\n application/problem+json:\n schema:\n $ref: '#/components/schemas/ProblemDetails'\n+ /apps/{appName}/logs/{serviceName}/:\n+ get:\n+ summary: Retrieves the logs from stdout/stderr of the specified container.\n+ parameters:\n+ - $ref: '#/components/parameters/appName'\n+ - in: path\n+ name: serviceName\n+ description: Name of the service\n+ required: true\n+ schema:\n+ type: string\n+ - in: query\n+ name: since\n+ description: Date time since when the logs have to retrieved. By default the logs from the beginning are crawled.\n+ schema:\n+ type: string\n+ format: date-time\n+ example: '2019-07-22T08:42:47-00:00'\n+ - in: query\n+ name: limit","path":"api/res/openapi.yml","position":38,"original_position":38,"commit_id":"6a926495ace0611ed37dccf13dd18b3e9332868a","original_commit_id":"6a926495ace0611ed37dccf13dd18b3e9332868a","user":{"login":"FabianEmmes","id":2706627,"node_id":"MDQ6VXNlcjI3MDY2Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/2706627?v=4","gravatar_id":"","url":"https://api.github.com/users/FabianEmmes","html_url":"https://github.com/FabianEmmes","followers_url":"https://api.github.com/users/FabianEmmes/followers","following_url":"https://api.github.com/users/FabianEmmes/following{/other_user}","gists_url":"https://api.github.com/users/FabianEmmes/gists{/gist_id}","starred_url":"https://api.github.com/users/FabianEmmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabianEmmes/subscriptions","organizations_url":"https://api.github.com/users/FabianEmmes/orgs","repos_url":"https://api.github.com/users/FabianEmmes/repos","events_url":"https://api.github.com/users/FabianEmmes/events{/privacy}","received_events_url":"https://api.github.com/users/FabianEmmes/received_events","type":"User","site_admin":false},"body":"I was surprised that the limit is a limit on the first `n` lines rather than the last `n` lines. Is it possible to the most current `n` lines also? IMHO this will be a common use case. ","created_at":"2019-07-23T07:01:15Z","updated_at":"2019-07-23T07:01:15Z","html_url":"https://github.com/aixigo/PREvant/pull/12#discussion_r306155944","pull_request_url":"https://api.github.com/repos/aixigo/PREvant/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/aixigo/PREvant/pulls/comments/306155944"},"html":{"href":"https://github.com/aixigo/PREvant/pull/12#discussion_r306155944"},"pull_request":{"href":"https://api.github.com/repos/aixigo/PREvant/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/aixigo/PREvant/pulls/12","id":300144365,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMTQ0MzY1","html_url":"https://github.com/aixigo/PREvant/pull/12","diff_url":"https://github.com/aixigo/PREvant/pull/12.diff","patch_url":"https://github.com/aixigo/PREvant/pull/12.patch","issue_url":"https://api.github.com/repos/aixigo/PREvant/issues/12","number":12,"state":"open","locked":false,"title":"Frontend: Retrieve and Display Logs of Services","user":{"login":"schrieveslaach","id":16558417,"node_id":"MDQ6VXNlcjE2NTU4NDE3","avatar_url":"https://avatars0.githubusercontent.com/u/16558417?v=4","gravatar_id":"","url":"https://api.github.com/users/schrieveslaach","html_url":"https://github.com/schrieveslaach","followers_url":"https://api.github.com/users/schrieveslaach/followers","following_url":"https://api.github.com/users/schrieveslaach/following{/other_user}","gists_url":"https://api.github.com/users/schrieveslaach/gists{/gist_id}","starred_url":"https://api.github.com/users/schrieveslaach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schrieveslaach/subscriptions","organizations_url":"https://api.github.com/users/schrieveslaach/orgs","repos_url":"https://api.github.com/users/schrieveslaach/repos","events_url":"https://api.github.com/users/schrieveslaach/events{/privacy}","received_events_url":"https://api.github.com/users/schrieveslaach/received_events","type":"User","site_admin":false},"body":"This PR adds following features:\r\n\r\n- Add an REST resource to retrieve the log messages of a service of an review app with pagination.\r\n- Utilize this resource to display the log messages in the frontend.","created_at":"2019-07-23T06:25:30Z","updated_at":"2019-07-23T07:01:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc24ad0741cdf662b3e10dad4a25d832262f2043","assignee":null,"assignees":[],"requested_reviewers":[{"login":"x1B","id":327904,"node_id":"MDQ6VXNlcjMyNzkwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/327904?v=4","gravatar_id":"","url":"https://api.github.com/users/x1B","html_url":"https://github.com/x1B","followers_url":"https://api.github.com/users/x1B/followers","following_url":"https://api.github.com/users/x1B/following{/other_user}","gists_url":"https://api.github.com/users/x1B/gists{/gist_id}","starred_url":"https://api.github.com/users/x1B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x1B/subscriptions","organizations_url":"https://api.github.com/users/x1B/orgs","repos_url":"https://api.github.com/users/x1B/repos","events_url":"https://api.github.com/users/x1B/events{/privacy}","received_events_url":"https://api.github.com/users/x1B/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aixigo/PREvant/pulls/12/commits","review_comments_url":"https://api.github.com/repos/aixigo/PREvant/pulls/12/comments","review_comment_url":"https://api.github.com/repos/aixigo/PREvant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aixigo/PREvant/issues/12/comments","statuses_url":"https://api.github.com/repos/aixigo/PREvant/statuses/6a926495ace0611ed37dccf13dd18b3e9332868a","head":{"label":"aixigo:feature/container-logs","ref":"feature/container-logs","sha":"6a926495ace0611ed37dccf13dd18b3e9332868a","user":{"login":"aixigo","id":3010214,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTAyMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3010214?v=4","gravatar_id":"","url":"https://api.github.com/users/aixigo","html_url":"https://github.com/aixigo","followers_url":"https://api.github.com/users/aixigo/followers","following_url":"https://api.github.com/users/aixigo/following{/other_user}","gists_url":"https://api.github.com/users/aixigo/gists{/gist_id}","starred_url":"https://api.github.com/users/aixigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aixigo/subscriptions","organizations_url":"https://api.github.com/users/aixigo/orgs","repos_url":"https://api.github.com/users/aixigo/repos","events_url":"https://api.github.com/users/aixigo/events{/privacy}","received_events_url":"https://api.github.com/users/aixigo/received_events","type":"Organization","site_admin":false},"repo":{"id":159496434,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0OTY0MzQ=","name":"PREvant","full_name":"aixigo/PREvant","private":false,"owner":{"login":"aixigo","id":3010214,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTAyMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3010214?v=4","gravatar_id":"","url":"https://api.github.com/users/aixigo","html_url":"https://github.com/aixigo","followers_url":"https://api.github.com/users/aixigo/followers","following_url":"https://api.github.com/users/aixigo/following{/other_user}","gists_url":"https://api.github.com/users/aixigo/gists{/gist_id}","starred_url":"https://api.github.com/users/aixigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aixigo/subscriptions","organizations_url":"https://api.github.com/users/aixigo/orgs","repos_url":"https://api.github.com/users/aixigo/repos","events_url":"https://api.github.com/users/aixigo/events{/privacy}","received_events_url":"https://api.github.com/users/aixigo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aixigo/PREvant","description":"Composing Microservices into Reviewable and Testable Applications","fork":false,"url":"https://api.github.com/repos/aixigo/PREvant","forks_url":"https://api.github.com/repos/aixigo/PREvant/forks","keys_url":"https://api.github.com/repos/aixigo/PREvant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aixigo/PREvant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aixigo/PREvant/teams","hooks_url":"https://api.github.com/repos/aixigo/PREvant/hooks","issue_events_url":"https://api.github.com/repos/aixigo/PREvant/issues/events{/number}","events_url":"https://api.github.com/repos/aixigo/PREvant/events","assignees_url":"https://api.github.com/repos/aixigo/PREvant/assignees{/user}","branches_url":"https://api.github.com/repos/aixigo/PREvant/branches{/branch}","tags_url":"https://api.github.com/repos/aixigo/PREvant/tags","blobs_url":"https://api.github.com/repos/aixigo/PREvant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aixigo/PREvant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aixigo/PREvant/git/refs{/sha}","trees_url":"https://api.github.com/repos/aixigo/PREvant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aixigo/PREvant/statuses/{sha}","languages_url":"https://api.github.com/repos/aixigo/PREvant/languages","stargazers_url":"https://api.github.com/repos/aixigo/PREvant/stargazers","contributors_url":"https://api.github.com/repos/aixigo/PREvant/contributors","subscribers_url":"https://api.github.com/repos/aixigo/PREvant/subscribers","subscription_url":"https://api.github.com/repos/aixigo/PREvant/subscription","commits_url":"https://api.github.com/repos/aixigo/PREvant/commits{/sha}","git_commits_url":"https://api.github.com/repos/aixigo/PREvant/git/commits{/sha}","comments_url":"https://api.github.com/repos/aixigo/PREvant/comments{/number}","issue_comment_url":"https://api.github.com/repos/aixigo/PREvant/issues/comments{/number}","contents_url":"https://api.github.com/repos/aixigo/PREvant/contents/{+path}","compare_url":"https://api.github.com/repos/aixigo/PREvant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aixigo/PREvant/merges","archive_url":"https://api.github.com/repos/aixigo/PREvant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aixigo/PREvant/downloads","issues_url":"https://api.github.com/repos/aixigo/PREvant/issues{/number}","pulls_url":"https://api.github.com/repos/aixigo/PREvant/pulls{/number}","milestones_url":"https://api.github.com/repos/aixigo/PREvant/milestones{/number}","notifications_url":"https://api.github.com/repos/aixigo/PREvant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aixigo/PREvant/labels{/name}","releases_url":"https://api.github.com/repos/aixigo/PREvant/releases{/id}","deployments_url":"https://api.github.com/repos/aixigo/PREvant/deployments","created_at":"2018-11-28T12:10:01Z","updated_at":"2019-07-11T14:37:33Z","pushed_at":"2019-07-23T06:25:30Z","git_url":"git://github.com/aixigo/PREvant.git","ssh_url":"git@github.com:aixigo/PREvant.git","clone_url":"https://github.com/aixigo/PREvant.git","svn_url":"https://github.com/aixigo/PREvant","homepage":null,"size":7533,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"aixigo:master","ref":"master","sha":"73cc32100220dcc54a476fe4951ea0b3b0ac0229","user":{"login":"aixigo","id":3010214,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTAyMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3010214?v=4","gravatar_id":"","url":"https://api.github.com/users/aixigo","html_url":"https://github.com/aixigo","followers_url":"https://api.github.com/users/aixigo/followers","following_url":"https://api.github.com/users/aixigo/following{/other_user}","gists_url":"https://api.github.com/users/aixigo/gists{/gist_id}","starred_url":"https://api.github.com/users/aixigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aixigo/subscriptions","organizations_url":"https://api.github.com/users/aixigo/orgs","repos_url":"https://api.github.com/users/aixigo/repos","events_url":"https://api.github.com/users/aixigo/events{/privacy}","received_events_url":"https://api.github.com/users/aixigo/received_events","type":"Organization","site_admin":false},"repo":{"id":159496434,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0OTY0MzQ=","name":"PREvant","full_name":"aixigo/PREvant","private":false,"owner":{"login":"aixigo","id":3010214,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTAyMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3010214?v=4","gravatar_id":"","url":"https://api.github.com/users/aixigo","html_url":"https://github.com/aixigo","followers_url":"https://api.github.com/users/aixigo/followers","following_url":"https://api.github.com/users/aixigo/following{/other_user}","gists_url":"https://api.github.com/users/aixigo/gists{/gist_id}","starred_url":"https://api.github.com/users/aixigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aixigo/subscriptions","organizations_url":"https://api.github.com/users/aixigo/orgs","repos_url":"https://api.github.com/users/aixigo/repos","events_url":"https://api.github.com/users/aixigo/events{/privacy}","received_events_url":"https://api.github.com/users/aixigo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aixigo/PREvant","description":"Composing Microservices into Reviewable and Testable Applications","fork":false,"url":"https://api.github.com/repos/aixigo/PREvant","forks_url":"https://api.github.com/repos/aixigo/PREvant/forks","keys_url":"https://api.github.com/repos/aixigo/PREvant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aixigo/PREvant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aixigo/PREvant/teams","hooks_url":"https://api.github.com/repos/aixigo/PREvant/hooks","issue_events_url":"https://api.github.com/repos/aixigo/PREvant/issues/events{/number}","events_url":"https://api.github.com/repos/aixigo/PREvant/events","assignees_url":"https://api.github.com/repos/aixigo/PREvant/assignees{/user}","branches_url":"https://api.github.com/repos/aixigo/PREvant/branches{/branch}","tags_url":"https://api.github.com/repos/aixigo/PREvant/tags","blobs_url":"https://api.github.com/repos/aixigo/PREvant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aixigo/PREvant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aixigo/PREvant/git/refs{/sha}","trees_url":"https://api.github.com/repos/aixigo/PREvant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aixigo/PREvant/statuses/{sha}","languages_url":"https://api.github.com/repos/aixigo/PREvant/languages","stargazers_url":"https://api.github.com/repos/aixigo/PREvant/stargazers","contributors_url":"https://api.github.com/repos/aixigo/PREvant/contributors","subscribers_url":"https://api.github.com/repos/aixigo/PREvant/subscribers","subscription_url":"https://api.github.com/repos/aixigo/PREvant/subscription","commits_url":"https://api.github.com/repos/aixigo/PREvant/commits{/sha}","git_commits_url":"https://api.github.com/repos/aixigo/PREvant/git/commits{/sha}","comments_url":"https://api.github.com/repos/aixigo/PREvant/comments{/number}","issue_comment_url":"https://api.github.com/repos/aixigo/PREvant/issues/comments{/number}","contents_url":"https://api.github.com/repos/aixigo/PREvant/contents/{+path}","compare_url":"https://api.github.com/repos/aixigo/PREvant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aixigo/PREvant/merges","archive_url":"https://api.github.com/repos/aixigo/PREvant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aixigo/PREvant/downloads","issues_url":"https://api.github.com/repos/aixigo/PREvant/issues{/number}","pulls_url":"https://api.github.com/repos/aixigo/PREvant/pulls{/number}","milestones_url":"https://api.github.com/repos/aixigo/PREvant/milestones{/number}","notifications_url":"https://api.github.com/repos/aixigo/PREvant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aixigo/PREvant/labels{/name}","releases_url":"https://api.github.com/repos/aixigo/PREvant/releases{/id}","deployments_url":"https://api.github.com/repos/aixigo/PREvant/deployments","created_at":"2018-11-28T12:10:01Z","updated_at":"2019-07-11T14:37:33Z","pushed_at":"2019-07-23T06:25:30Z","git_url":"git://github.com/aixigo/PREvant.git","ssh_url":"git@github.com:aixigo/PREvant.git","clone_url":"https://github.com/aixigo/PREvant.git","svn_url":"https://github.com/aixigo/PREvant","homepage":null,"size":7533,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aixigo/PREvant/pulls/12"},"html":{"href":"https://github.com/aixigo/PREvant/pull/12"},"issue":{"href":"https://api.github.com/repos/aixigo/PREvant/issues/12"},"comments":{"href":"https://api.github.com/repos/aixigo/PREvant/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/aixigo/PREvant/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/aixigo/PREvant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aixigo/PREvant/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/aixigo/PREvant/statuses/6a926495ace0611ed37dccf13dd18b3e9332868a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 159496434,
"name": "aixigo/PREvant",
"url": "https://api.github.com/repos/aixigo/PREvant"
}
|
{
"id": 2706627,
"login": "FabianEmmes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2706627?",
"url": "https://api.github.com/users/FabianEmmes"
}
|
{
"id": 3010214,
"login": "aixigo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3010214?",
"url": "https://api.github.com/orgs/aixigo"
}
| 2019-07-23T07:01:15 |
10063781132
|
{"actor":{"display_login":"FabianEmmes"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/loopback-next/pulls/comments/329654677","pull_request_review_id":295074193,"id":329654677,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTY1NDY3Nw==","diff_hunk":"@@ -2,21 +2,77 @@\n \n connect to story https://github.com/strongloop/loopback-next/issues/2246\n \n-I picked the `authentication-passport` module to start the spike for more flexible user profile because compared with the custom authentication strategies, users have less control to the returned user when using the passport adapter. I believe if we could find a solution for the passport based strategies, applying similar approach to a custom strategy would be easy.\n+I picked the `authentication-passport` module to start the spike for more\n+flexible user profile because compared with the custom authentication\n+strategies, users have less control to the returned user when using the passport\n+adapter. I believe if we could find a solution for the passport based\n+strategies, applying similar approach to a custom strategy would be easy.\n \n # Solution\n \n-A converter function is introduced to be passed into the `StrategyAdapter`'s constructor. It takes in a custom user, converts it to a user profile described by `UserProfile` then returns it.\n+A converter function is introduced to be passed into the `StrategyAdapter`'s\n+constructor. It takes in a custom user, converts it to a user profile described\n+by `UserProfile` then returns it.\n \n # Example\n \n-See the corresponding change made in file 'authentication-with-passport-strategy-adapter.acceptance.ts':\n+See the corresponding change made in file\n+'authentication-with-passport-strategy-adapter.acceptance.ts':\n \n-- Type `UserProfileInDB` is defined to describe the custom user. In a real application it should be a custom User model.\n-- Define a converter function `converter` that turns an `UserProfileInDb` instance into a user profile. It's provided in the constructor when create the adapter.\n-- The converter is invoked in the strategy's `authentication()` function to make sure it returns a user profile in type `UserProfile`\n-- If the strategy is returned in a provider, you can inject the converter.\n+- Type `UserProfileInDB` is defined to describe the custom user. In a real\n+ application it should be a custom User model.\n+- Define a factory function `userProfileFactory` that turns an `UserProfileInDB`\n+ instance into a user profile. It's provided in the constructor when creating\n+ the adapter.\n+- The converter is invoked in the strategy's `authentication()` function to make\n+ sure it returns a user profile in type `UserProfile`\n+- If the strategy is returned in a provider, you can inject the factory.","path":"extensions/authentication-passport/spike-user-profile.md","position":29,"original_position":35,"commit_id":"8c1e9fe71b2c9b9fcdd23c8460edbf8972ad0943","original_commit_id":"8c1e9fe71b2c9b9fcdd23c8460edbf8972ad0943","user":{"login":"emonddr","id":6864736,"node_id":"MDQ6VXNlcjY4NjQ3MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6864736?v=4","gravatar_id":"","url":"https://api.github.com/users/emonddr","html_url":"https://github.com/emonddr","followers_url":"https://api.github.com/users/emonddr/followers","following_url":"https://api.github.com/users/emonddr/following{/other_user}","gists_url":"https://api.github.com/users/emonddr/gists{/gist_id}","starred_url":"https://api.github.com/users/emonddr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emonddr/subscriptions","organizations_url":"https://api.github.com/users/emonddr/orgs","repos_url":"https://api.github.com/users/emonddr/repos","events_url":"https://api.github.com/users/emonddr/events{/privacy}","received_events_url":"https://api.github.com/users/emonddr/received_events","type":"User","site_admin":false},"body":"Can you provide a tiny example of what you mean?","created_at":"2019-09-30T15:51:47Z","updated_at":"2019-09-30T15:55:22Z","html_url":"https://github.com/strongloop/loopback-next/pull/3771#discussion_r329654677","pull_request_url":"https://api.github.com/repos/strongloop/loopback-next/pulls/3771","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/comments/329654677"},"html":{"href":"https://github.com/strongloop/loopback-next/pull/3771#discussion_r329654677"},"pull_request":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/3771"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback-next/pulls/3771","id":319344875,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5MzQ0ODc1","html_url":"https://github.com/strongloop/loopback-next/pull/3771","diff_url":"https://github.com/strongloop/loopback-next/pull/3771.diff","patch_url":"https://github.com/strongloop/loopback-next/pull/3771.patch","issue_url":"https://api.github.com/repos/strongloop/loopback-next/issues/3771","number":3771,"state":"open","locked":false,"title":"Spike more flexible user profile","user":{"login":"jannyHou","id":12554153,"node_id":"MDQ6VXNlcjEyNTU0MTUz","avatar_url":"https://avatars0.githubusercontent.com/u/12554153?v=4","gravatar_id":"","url":"https://api.github.com/users/jannyHou","html_url":"https://github.com/jannyHou","followers_url":"https://api.github.com/users/jannyHou/followers","following_url":"https://api.github.com/users/jannyHou/following{/other_user}","gists_url":"https://api.github.com/users/jannyHou/gists{/gist_id}","starred_url":"https://api.github.com/users/jannyHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannyHou/subscriptions","organizations_url":"https://api.github.com/users/jannyHou/orgs","repos_url":"https://api.github.com/users/jannyHou/repos","events_url":"https://api.github.com/users/jannyHou/events{/privacy}","received_events_url":"https://api.github.com/users/jannyHou/received_events","type":"User","site_admin":false},"body":"connect to https://github.com/strongloop/loopback-next/issues/2246\r\nReviewers can read [spike-user-profile.md](https://github.com/strongloop/loopback-next/pull/3771/files#diff-f35e305427c53a74556505e9920f786e) to start.\r\n\r\n## Checklist\r\n\r\n👉 [Read and sign the CLA (Contributor License Agreement)](https://cla.strongloop.com/agreements/strongloop/loopback-next) 👈\r\n\r\n- [ ] `npm test` passes on your machine\r\n- [ ] New tests added or existing tests modified to cover all changes\r\n- [ ] Code conforms with the [style guide](http://loopback.io/doc/en/contrib/style-guide.html)\r\n- [ ] API Documentation in code was updated\r\n- [ ] Documentation in [/docs/site](../tree/master/docs/site) was updated\r\n- [ ] Affected artifact templates in `packages/cli` were updated\r\n- [ ] Affected example projects in `examples/*` were updated\r\n\r\n👉 [Check out how to submit a PR](https://loopback.io/doc/en/lb4/submitting_a_pr.html) 👈\r\n","created_at":"2019-09-19T15:44:59Z","updated_at":"2019-09-30T15:55:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68e4d5dc43a2a40e1e8daf8cbaae9ba84eb93ab2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/loopback-next/pulls/3771/commits","review_comments_url":"https://api.github.com/repos/strongloop/loopback-next/pulls/3771/comments","review_comment_url":"https://api.github.com/repos/strongloop/loopback-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/loopback-next/issues/3771/comments","statuses_url":"https://api.github.com/repos/strongloop/loopback-next/statuses/8c1e9fe71b2c9b9fcdd23c8460edbf8972ad0943","head":{"label":"strongloop:spike/user-profile-with-passport","ref":"spike/user-profile-with-passport","sha":"8c1e9fe71b2c9b9fcdd23c8460edbf8972ad0943","user":{"login":"strongloop","id":3020012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjAwMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":78452015,"node_id":"MDEwOlJlcG9zaXRvcnk3ODQ1MjAxNQ==","name":"loopback-next","full_name":"strongloop/loopback-next","private":false,"owner":{"login":"strongloop","id":3020012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjAwMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strongloop/loopback-next","description":"LoopBack makes it easy to build modern API applications that require complex integrations.","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-next","forks_url":"https://api.github.com/repos/strongloop/loopback-next/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-next/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-next/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-next/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-next/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-next/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-next/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-next/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-next/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-next/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-next/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-next/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-next/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-next/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-next/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-next/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-next/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-next/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-next/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-next/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-next/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-next/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-next/deployments","created_at":"2017-01-09T17:27:14Z","updated_at":"2019-09-30T14:01:26Z","pushed_at":"2019-09-30T15:37:36Z","git_url":"git://github.com/strongloop/loopback-next.git","ssh_url":"git@github.com:strongloop/loopback-next.git","clone_url":"https://github.com/strongloop/loopback-next.git","svn_url":"https://github.com/strongloop/loopback-next","homepage":"https://loopback.io/","size":35544,"stargazers_count":2216,"watchers_count":2216,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":566,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":344,"open_issues":566,"watchers":2216,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"51df5eb67afc77bca0b097f61267f8e0e8987e95","user":{"login":"strongloop","id":3020012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjAwMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":78452015,"node_id":"MDEwOlJlcG9zaXRvcnk3ODQ1MjAxNQ==","name":"loopback-next","full_name":"strongloop/loopback-next","private":false,"owner":{"login":"strongloop","id":3020012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjAwMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strongloop/loopback-next","description":"LoopBack makes it easy to build modern API applications that require complex integrations.","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-next","forks_url":"https://api.github.com/repos/strongloop/loopback-next/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-next/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-next/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-next/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-next/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-next/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-next/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-next/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-next/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-next/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-next/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-next/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-next/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-next/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-next/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-next/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-next/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-next/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-next/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-next/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-next/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-next/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-next/deployments","created_at":"2017-01-09T17:27:14Z","updated_at":"2019-09-30T14:01:26Z","pushed_at":"2019-09-30T15:37:36Z","git_url":"git://github.com/strongloop/loopback-next.git","ssh_url":"git@github.com:strongloop/loopback-next.git","clone_url":"https://github.com/strongloop/loopback-next.git","svn_url":"https://github.com/strongloop/loopback-next","homepage":"https://loopback.io/","size":35544,"stargazers_count":2216,"watchers_count":2216,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":566,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":344,"open_issues":566,"watchers":2216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/3771"},"html":{"href":"https://github.com/strongloop/loopback-next/pull/3771"},"issue":{"href":"https://api.github.com/repos/strongloop/loopback-next/issues/3771"},"comments":{"href":"https://api.github.com/repos/strongloop/loopback-next/issues/3771/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/3771/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/3771/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/loopback-next/statuses/8c1e9fe71b2c9b9fcdd23c8460edbf8972ad0943"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 78452015,
"name": "strongloop/loopback-next",
"url": "https://api.github.com/repos/strongloop/loopback-next"
}
|
{
"id": 6864736,
"login": "emonddr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6864736?",
"url": "https://api.github.com/users/emonddr"
}
|
{
"id": 3020012,
"login": "strongloop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3020012?",
"url": "https://api.github.com/orgs/strongloop"
}
| 2019-09-30T15:51:47 |
10525893100
|
{"actor":{"display_login":"emonddr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/317560003","pull_request_review_id":279535269,"id":317560003,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzU2MDAwMw==","diff_hunk":"@@ -118,6 +128,12 @@ int l2util_ipv6_iid_from_addr(int dev_type,\n return -EINVAL;\n }\n #endif /* defined(MODULE_CC110X) || defined(MODULE_NRFMIN) */\n+#if defined(MODULE_NIMBLE_NETIF)\n+ case NETDEV_TYPE_BLE:\n+ l2util_eui64_from_addr(dev_type, addr, addr_len, iid);\n+ /* for BLE we don't flip the universal local flag... */","path":"sys/net/link_layer/l2util/l2util.c","position":null,"original_position":39,"commit_id":"2683d266b49958f2fc1f34b3586bc4f1ee95d250","original_commit_id":"27f69ff4ccc3d147e942e26cff0170e0da9e948a","user":{"login":"haukepetersen","id":620834,"node_id":"MDQ6VXNlcjYyMDgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/620834?v=4","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"body":"fixed :-)","created_at":"2019-08-26T11:23:14Z","updated_at":"2019-08-26T11:23:14Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/11578#discussion_r317560003","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/11578","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/317560003"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/11578#discussion_r317560003"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/11578"}},"in_reply_to_id":317559146},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/11578","id":282075203,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyMDc1MjAz","html_url":"https://github.com/RIOT-OS/RIOT/pull/11578","diff_url":"https://github.com/RIOT-OS/RIOT/pull/11578.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/11578.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/11578","number":11578,"state":"open","locked":false,"title":"pkg/nimble: add IP-over-BLE support via netif/GNRC","user":{"login":"haukepetersen","id":620834,"node_id":"MDQ6VXNlcjYyMDgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/620834?v=4","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"body":"### Contribution description\r\nThis PR provides support for IP-over-BLE by providing a GNRC-netif wrapper for Nimble. The provided behavior is should be conform to RFC7668 and the Bluetooth IPSP profile, but some details do still need to be verified.\r\n\r\nThe PR provides an application for 'fully manual' control of BLE behavior. Other means for BLE connection management (e.g. towards [ipv6-mesh-over-ble](https://tools.ietf.org/html/draft-ietf-6lo-blemesh-05)) will follow in upcoming PRs.\r\n\r\nCurrent State:\r\n- code (architecture, structure, implementation) is functional and ready to be looked at\r\n- a lot of documentation (high-level and doxygen) is missing (hence the WIP label)\r\n- some debug helpers are left in the code, will remove them once everything runs stable\r\n\r\nI PR this code now, as it would be wonderful if someone could look over the code to see if there are some critical things I overlooked. I've been staring at this stuff for too long now and a bad tunnel vision :-)\r\n\r\n### Testing procedure\r\nThe provided `nimble_gnrc` application provides a mighty `ble` shell command, that can be used for advertising, scanning, and connecting to other nodes. Once at least two nodes are connected, all the IP magic (udp, icmp, ifconfig, rpl) is available...\r\n\r\nAt least in theory, this code should also work for connecting a RIOT BLE node to Linux. But I did not try this, yet.\r\n\r\n### Issues/PRs references\r\nrebased on #11296\r\n\r\nKnown issues:\r\n- using the unpatched Nimble version a node can only have a single connection. If a second connection is opened, Nimble fails to allocate a second connection context from its context buffer (see `nimble/host/src/ble_hs_conn.c` -> `ble_hs_conn_alloc()`). I can't tell why, but it seems the memblock list for `ble_hs_conn_pool` is corrupted somehow. But when renaming that var to `_ble_hs_conn_pool` everything works again. So really now idea yet, what is causing this...\r\n- I did not fully verify, that GNRC behaves fully to spec of RFC7668 (e.g. neighbor discovery options...)\r\n","created_at":"2019-05-24T16:05:45Z","updated_at":"2019-08-26T11:23:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d34581e889fbd309056c4c9b6a0d07559b36fa19","assignee":{"login":"miri64","id":675644,"node_id":"MDQ6VXNlcjY3NTY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"assignees":[{"login":"miri64","id":675644,"node_id":"MDQ6VXNlcjY3NTY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":219094476,"node_id":"MDU6TGFiZWwyMTkwOTQ0NzY=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Area:%20BLE","name":"Area: BLE","color":"6600ff","default":false},{"id":86443543,"node_id":"MDU6TGFiZWw4NjQ0MzU0Mw==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Area:%20network","name":"Area: network","color":"6600ff","default":false},{"id":97458574,"node_id":"MDU6TGFiZWw5NzQ1ODU3NA==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Type:%20new%20feature","name":"Type: new feature","color":"ffff66","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/11578/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/11578/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/11578/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/2683d266b49958f2fc1f34b3586bc4f1ee95d250","head":{"label":"haukepetersen:add_nimble_netif","ref":"add_nimble_netif","sha":"2683d266b49958f2fc1f34b3586bc4f1ee95d250","user":{"login":"haukepetersen","id":620834,"node_id":"MDQ6VXNlcjYyMDgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/620834?v=4","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"repo":{"id":13741766,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0MTc2Ng==","name":"RIOT","full_name":"haukepetersen/RIOT","private":false,"owner":{"login":"haukepetersen","id":620834,"node_id":"MDQ6VXNlcjYyMDgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/620834?v=4","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/haukepetersen/RIOT","description":"RIOT OS - The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/haukepetersen/RIOT","forks_url":"https://api.github.com/repos/haukepetersen/RIOT/forks","keys_url":"https://api.github.com/repos/haukepetersen/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haukepetersen/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haukepetersen/RIOT/teams","hooks_url":"https://api.github.com/repos/haukepetersen/RIOT/hooks","issue_events_url":"https://api.github.com/repos/haukepetersen/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/haukepetersen/RIOT/events","assignees_url":"https://api.github.com/repos/haukepetersen/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/haukepetersen/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/haukepetersen/RIOT/tags","blobs_url":"https://api.github.com/repos/haukepetersen/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haukepetersen/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haukepetersen/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/haukepetersen/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haukepetersen/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/haukepetersen/RIOT/languages","stargazers_url":"https://api.github.com/repos/haukepetersen/RIOT/stargazers","contributors_url":"https://api.github.com/repos/haukepetersen/RIOT/contributors","subscribers_url":"https://api.github.com/repos/haukepetersen/RIOT/subscribers","subscription_url":"https://api.github.com/repos/haukepetersen/RIOT/subscription","commits_url":"https://api.github.com/repos/haukepetersen/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/haukepetersen/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/haukepetersen/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/haukepetersen/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/haukepetersen/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/haukepetersen/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haukepetersen/RIOT/merges","archive_url":"https://api.github.com/repos/haukepetersen/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haukepetersen/RIOT/downloads","issues_url":"https://api.github.com/repos/haukepetersen/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/haukepetersen/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/haukepetersen/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/haukepetersen/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haukepetersen/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/haukepetersen/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/haukepetersen/RIOT/deployments","created_at":"2013-10-21T12:31:38Z","updated_at":"2019-02-26T00:34:55Z","pushed_at":"2019-08-26T11:23:06Z","git_url":"git://github.com/haukepetersen/RIOT.git","ssh_url":"git@github.com:haukepetersen/RIOT.git","clone_url":"https://github.com/haukepetersen/RIOT.git","svn_url":"https://github.com/haukepetersen/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":70278,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"552e425b66373f1eb0948ca4f0c93a698646db7b","user":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcwMjQx","name":"RIOT","full_name":"RIOT-OS/RIOT","private":false,"owner":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT - The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2019-08-26T01:07:55Z","pushed_at":"2019-08-26T11:23:08Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":68948,"stargazers_count":2808,"watchers_count":2808,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1382,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1048,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1382,"open_issues":1048,"watchers":2808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/11578"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/11578"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/11578"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/11578/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/11578/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/11578/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/2683d266b49958f2fc1f34b3586bc4f1ee95d250"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 7370241,
"name": "RIOT-OS/RIOT",
"url": "https://api.github.com/repos/RIOT-OS/RIOT"
}
|
{
"id": 620834,
"login": "haukepetersen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/620834?",
"url": "https://api.github.com/users/haukepetersen"
}
|
{
"id": 3079480,
"login": "RIOT-OS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3079480?",
"url": "https://api.github.com/orgs/RIOT-OS"
}
| 2019-08-26T11:23:14 |
10282519311
|
{"actor":{"display_login":"haukepetersen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/comments/297661909","pull_request_review_id":254607651,"id":297661909,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzY2MTkwOQ==","diff_hunk":"@@ -0,0 +1,35 @@\n+{\n+ \"name\": \"quixo-isomorphic\",\n+ \"version\": \"1.0.0\",\n+ \"description\": \"Quixo game with react isomorphic\",\n+ \"main\": \"index.js\",\n+ \"scripts\": {\n+ \"dev\": \"next\",\n+ \"build\": \"next build\",\n+ \"start\": \"next start\",\n+ \"test\": \"echo \\\"Error: no test specified\\\" && exit 1\"\n+ },\n+ \"repository\": {\n+ \"type\": \"git\",\n+ \"url\": \"git+https://github.com/marmelab/quixo-isomorphic.git\"\n+ },\n+ \"keywords\": [\n+ \"quixo\",\n+ \"react\",\n+ \"next.js\"\n+ ],\n+ \"author\": \"Pierre h\",\n+ \"license\": \"MIT\",\n+ \"bugs\": {\n+ \"url\": \"https://github.com/marmelab/quixo-isomorphic/issues\"\n+ },\n+ \"homepage\": \"https://github.com/marmelab/quixo-isomorphic#readme\",\n+ \"dependencies\": {\n+ \"babel-plugin-styled-components\": \"1.10.2\",","path":"src/package.json","position":28,"original_position":28,"commit_id":"d974f9fc9acd9a922cfbcbd9669fce6897510dde","original_commit_id":"d974f9fc9acd9a922cfbcbd9669fce6897510dde","user":{"login":"zyhou","id":2212144,"node_id":"MDQ6VXNlcjIyMTIxNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2212144?v=4","gravatar_id":"","url":"https://api.github.com/users/zyhou","html_url":"https://github.com/zyhou","followers_url":"https://api.github.com/users/zyhou/followers","following_url":"https://api.github.com/users/zyhou/following{/other_user}","gists_url":"https://api.github.com/users/zyhou/gists{/gist_id}","starred_url":"https://api.github.com/users/zyhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyhou/subscriptions","organizations_url":"https://api.github.com/users/zyhou/orgs","repos_url":"https://api.github.com/users/zyhou/repos","events_url":"https://api.github.com/users/zyhou/events{/privacy}","received_events_url":"https://api.github.com/users/zyhou/received_events","type":"User","site_admin":false},"body":"Babel plugin is dev dep","created_at":"2019-06-26T13:23:13Z","updated_at":"2019-06-26T13:33:41Z","html_url":"https://github.com/marmelab/quixo-isomorphic/pull/1#discussion_r297661909","pull_request_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/comments/297661909"},"html":{"href":"https://github.com/marmelab/quixo-isomorphic/pull/1#discussion_r297661909"},"pull_request":{"href":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/1","id":291981784,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxOTgxNzg0","html_url":"https://github.com/marmelab/quixo-isomorphic/pull/1","diff_url":"https://github.com/marmelab/quixo-isomorphic/pull/1.diff","patch_url":"https://github.com/marmelab/quixo-isomorphic/pull/1.patch","issue_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues/1","number":1,"state":"open","locked":false,"title":"[WIP] Launch a new game","user":{"login":"HALLERPierre","id":6030943,"node_id":"MDQ6VXNlcjYwMzA5NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/6030943?v=4","gravatar_id":"","url":"https://api.github.com/users/HALLERPierre","html_url":"https://github.com/HALLERPierre","followers_url":"https://api.github.com/users/HALLERPierre/followers","following_url":"https://api.github.com/users/HALLERPierre/following{/other_user}","gists_url":"https://api.github.com/users/HALLERPierre/gists{/gist_id}","starred_url":"https://api.github.com/users/HALLERPierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HALLERPierre/subscriptions","organizations_url":"https://api.github.com/users/HALLERPierre/orgs","repos_url":"https://api.github.com/users/HALLERPierre/repos","events_url":"https://api.github.com/users/HALLERPierre/events{/privacy}","received_events_url":"https://api.github.com/users/HALLERPierre/received_events","type":"User","site_admin":false},"body":"[trello](https://trello.com/c/J0Q0i62A/1-1-as-fred-i-want-to-launch-a-new-game)\r\n\r\n# TODO\r\n\r\n- [x] Create app\r\n- [x] Create landing page\r\n- [x] Create game page\r\n- [x] Add styles\r\n- [x] Add statics files\r\n- [x] Add docker-compose file\r\n- [x] Add Makefile\r\n- [ ] Add tests\r\n\r\n# Result\r\n\r\n","created_at":"2019-06-26T13:10:48Z","updated_at":"2019-06-26T13:33:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fa6e6b5d492daf4084498a8d46aef37cf00e639","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/1/commits","review_comments_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/1/comments","review_comment_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues/1/comments","statuses_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/statuses/d974f9fc9acd9a922cfbcbd9669fce6897510dde","head":{"label":"marmelab:init-project","ref":"init-project","sha":"d974f9fc9acd9a922cfbcbd9669fce6897510dde","user":{"login":"marmelab","id":3116319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTYzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"repo":{"id":193717418,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM3MTc0MTg=","name":"quixo-isomorphic","full_name":"marmelab/quixo-isomorphic","private":false,"owner":{"login":"marmelab","id":3116319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTYzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/marmelab/quixo-isomorphic","description":null,"fork":false,"url":"https://api.github.com/repos/marmelab/quixo-isomorphic","forks_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/forks","keys_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/teams","hooks_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/hooks","issue_events_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues/events{/number}","events_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/events","assignees_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/assignees{/user}","branches_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/branches{/branch}","tags_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/tags","blobs_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/statuses/{sha}","languages_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/languages","stargazers_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/stargazers","contributors_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/contributors","subscribers_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/subscribers","subscription_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/subscription","commits_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/contents/{+path}","compare_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/merges","archive_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/downloads","issues_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues{/number}","pulls_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls{/number}","milestones_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/milestones{/number}","notifications_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/labels{/name}","releases_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/releases{/id}","deployments_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/deployments","created_at":"2019-06-25T13:52:41Z","updated_at":"2019-06-25T13:53:22Z","pushed_at":"2019-06-26T13:15:32Z","git_url":"git://github.com/marmelab/quixo-isomorphic.git","ssh_url":"git@github.com:marmelab/quixo-isomorphic.git","clone_url":"https://github.com/marmelab/quixo-isomorphic.git","svn_url":"https://github.com/marmelab/quixo-isomorphic","homepage":null,"size":1302,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"marmelab:master","ref":"master","sha":"93f55d1bd5561f98a0f275e28300ef1cf78f3b74","user":{"login":"marmelab","id":3116319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTYzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"repo":{"id":193717418,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM3MTc0MTg=","name":"quixo-isomorphic","full_name":"marmelab/quixo-isomorphic","private":false,"owner":{"login":"marmelab","id":3116319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTYzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/marmelab/quixo-isomorphic","description":null,"fork":false,"url":"https://api.github.com/repos/marmelab/quixo-isomorphic","forks_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/forks","keys_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/teams","hooks_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/hooks","issue_events_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues/events{/number}","events_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/events","assignees_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/assignees{/user}","branches_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/branches{/branch}","tags_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/tags","blobs_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/statuses/{sha}","languages_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/languages","stargazers_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/stargazers","contributors_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/contributors","subscribers_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/subscribers","subscription_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/subscription","commits_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/contents/{+path}","compare_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/merges","archive_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/downloads","issues_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues{/number}","pulls_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls{/number}","milestones_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/milestones{/number}","notifications_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/labels{/name}","releases_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/releases{/id}","deployments_url":"https://api.github.com/repos/marmelab/quixo-isomorphic/deployments","created_at":"2019-06-25T13:52:41Z","updated_at":"2019-06-25T13:53:22Z","pushed_at":"2019-06-26T13:15:32Z","git_url":"git://github.com/marmelab/quixo-isomorphic.git","ssh_url":"git@github.com:marmelab/quixo-isomorphic.git","clone_url":"https://github.com/marmelab/quixo-isomorphic.git","svn_url":"https://github.com/marmelab/quixo-isomorphic","homepage":null,"size":1302,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/1"},"html":{"href":"https://github.com/marmelab/quixo-isomorphic/pull/1"},"issue":{"href":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues/1"},"comments":{"href":"https://api.github.com/repos/marmelab/quixo-isomorphic/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marmelab/quixo-isomorphic/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/marmelab/quixo-isomorphic/statuses/d974f9fc9acd9a922cfbcbd9669fce6897510dde"}},"author_association":"NONE"}}
|
{
"id": 193717418,
"name": "marmelab/quixo-isomorphic",
"url": "https://api.github.com/repos/marmelab/quixo-isomorphic"
}
|
{
"id": 2212144,
"login": "zyhou",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2212144?",
"url": "https://api.github.com/users/zyhou"
}
|
{
"id": 3116319,
"login": "marmelab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3116319?",
"url": "https://api.github.com/orgs/marmelab"
}
| 2019-06-26T13:23:13 |
9897881154
|
{"actor":{"display_login":"zyhou"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments/344488341","pull_request_review_id":314608081,"id":344488341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDQ4ODM0MQ==","diff_hunk":"@@ -80,6 +80,10 @@ if [ -n \"\\$JAVA_HOME\" ] ; then\n Please set the JAVA_HOME variable in your environment to match the\n location of your Java installation.\"\n fi\n+# For Darwin, find JAVA_HOME for 1.8\n+elif $darwin; then\n+ JAVA_HOME=`/usr/libexec/java_home -v 1.8`","path":"asciidoctorj-distribution/src/main/resources/customUnixStartScript.txt","position":null,"original_position":6,"commit_id":"30b67716cae5c0354fe4cd6cddb09ac6fbe3c1f3","original_commit_id":"0c4c77faf7495e376d9bfe6ae993f8a564c5461e","user":{"login":"robertpanzer","id":1163662,"node_id":"MDQ6VXNlcjExNjM2NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1163662?v=4","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"body":"> regarding awt headless, the adverse implication of not being headless on macOX is that a full GUI application is launched, appears in the dock even if it has no window, and grabs the keyboard focus, which is quite annoying for a command-line tool like asciidoctorj\r\n\r\nAgreed, I just want to be sure that it doesn't break the asciidoctor-diagram extension.\r\nI tested manually that the Ditaa and Plantuml sequence and class diagrams still work.","created_at":"2019-11-10T12:12:01Z","updated_at":"2019-11-10T12:12:01Z","html_url":"https://github.com/asciidoctor/asciidoctorj/pull/863#discussion_r344488341","pull_request_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/863","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments/344488341"},"html":{"href":"https://github.com/asciidoctor/asciidoctorj/pull/863#discussion_r344488341"},"pull_request":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/863"}},"in_reply_to_id":344450403},"pull_request":{"url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/863","id":337074451,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM3MDc0NDUx","html_url":"https://github.com/asciidoctor/asciidoctorj/pull/863","diff_url":"https://github.com/asciidoctor/asciidoctorj/pull/863.diff","patch_url":"https://github.com/asciidoctor/asciidoctorj/pull/863.patch","issue_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/863","number":863,"state":"open","locked":false,"title":"Use headless jdk on all platforms","user":{"login":"nicerloop","id":44115467,"node_id":"MDQ6VXNlcjQ0MTE1NDY3","avatar_url":"https://avatars2.githubusercontent.com/u/44115467?v=4","gravatar_id":"","url":"https://api.github.com/users/nicerloop","html_url":"https://github.com/nicerloop","followers_url":"https://api.github.com/users/nicerloop/followers","following_url":"https://api.github.com/users/nicerloop/following{/other_user}","gists_url":"https://api.github.com/users/nicerloop/gists{/gist_id}","starred_url":"https://api.github.com/users/nicerloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicerloop/subscriptions","organizations_url":"https://api.github.com/users/nicerloop/orgs","repos_url":"https://api.github.com/users/nicerloop/repos","events_url":"https://api.github.com/users/nicerloop/events{/privacy}","received_events_url":"https://api.github.com/users/nicerloop/received_events","type":"User","site_admin":false},"body":null,"created_at":"2019-11-05T23:36:13Z","updated_at":"2019-11-10T12:12:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65789fc8323eb741dd7de9707687e1b3d217b867","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/863/commits","review_comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/863/comments","review_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/863/comments","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/statuses/30b67716cae5c0354fe4cd6cddb09ac6fbe3c1f3","head":{"label":"nicerloop:master","ref":"master","sha":"30b67716cae5c0354fe4cd6cddb09ac6fbe3c1f3","user":{"login":"nicerloop","id":44115467,"node_id":"MDQ6VXNlcjQ0MTE1NDY3","avatar_url":"https://avatars2.githubusercontent.com/u/44115467?v=4","gravatar_id":"","url":"https://api.github.com/users/nicerloop","html_url":"https://github.com/nicerloop","followers_url":"https://api.github.com/users/nicerloop/followers","following_url":"https://api.github.com/users/nicerloop/following{/other_user}","gists_url":"https://api.github.com/users/nicerloop/gists{/gist_id}","starred_url":"https://api.github.com/users/nicerloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicerloop/subscriptions","organizations_url":"https://api.github.com/users/nicerloop/orgs","repos_url":"https://api.github.com/users/nicerloop/repos","events_url":"https://api.github.com/users/nicerloop/events{/privacy}","received_events_url":"https://api.github.com/users/nicerloop/received_events","type":"User","site_admin":false},"repo":{"id":219870106,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk4NzAxMDY=","name":"asciidoctorj","full_name":"nicerloop/asciidoctorj","private":false,"owner":{"login":"nicerloop","id":44115467,"node_id":"MDQ6VXNlcjQ0MTE1NDY3","avatar_url":"https://avatars2.githubusercontent.com/u/44115467?v=4","gravatar_id":"","url":"https://api.github.com/users/nicerloop","html_url":"https://github.com/nicerloop","followers_url":"https://api.github.com/users/nicerloop/followers","following_url":"https://api.github.com/users/nicerloop/following{/other_user}","gists_url":"https://api.github.com/users/nicerloop/gists{/gist_id}","starred_url":"https://api.github.com/users/nicerloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicerloop/subscriptions","organizations_url":"https://api.github.com/users/nicerloop/orgs","repos_url":"https://api.github.com/users/nicerloop/repos","events_url":"https://api.github.com/users/nicerloop/events{/privacy}","received_events_url":"https://api.github.com/users/nicerloop/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nicerloop/asciidoctorj","description":":coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!","fork":true,"url":"https://api.github.com/repos/nicerloop/asciidoctorj","forks_url":"https://api.github.com/repos/nicerloop/asciidoctorj/forks","keys_url":"https://api.github.com/repos/nicerloop/asciidoctorj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicerloop/asciidoctorj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicerloop/asciidoctorj/teams","hooks_url":"https://api.github.com/repos/nicerloop/asciidoctorj/hooks","issue_events_url":"https://api.github.com/repos/nicerloop/asciidoctorj/issues/events{/number}","events_url":"https://api.github.com/repos/nicerloop/asciidoctorj/events","assignees_url":"https://api.github.com/repos/nicerloop/asciidoctorj/assignees{/user}","branches_url":"https://api.github.com/repos/nicerloop/asciidoctorj/branches{/branch}","tags_url":"https://api.github.com/repos/nicerloop/asciidoctorj/tags","blobs_url":"https://api.github.com/repos/nicerloop/asciidoctorj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicerloop/asciidoctorj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicerloop/asciidoctorj/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicerloop/asciidoctorj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicerloop/asciidoctorj/statuses/{sha}","languages_url":"https://api.github.com/repos/nicerloop/asciidoctorj/languages","stargazers_url":"https://api.github.com/repos/nicerloop/asciidoctorj/stargazers","contributors_url":"https://api.github.com/repos/nicerloop/asciidoctorj/contributors","subscribers_url":"https://api.github.com/repos/nicerloop/asciidoctorj/subscribers","subscription_url":"https://api.github.com/repos/nicerloop/asciidoctorj/subscription","commits_url":"https://api.github.com/repos/nicerloop/asciidoctorj/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicerloop/asciidoctorj/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicerloop/asciidoctorj/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicerloop/asciidoctorj/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicerloop/asciidoctorj/contents/{+path}","compare_url":"https://api.github.com/repos/nicerloop/asciidoctorj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicerloop/asciidoctorj/merges","archive_url":"https://api.github.com/repos/nicerloop/asciidoctorj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicerloop/asciidoctorj/downloads","issues_url":"https://api.github.com/repos/nicerloop/asciidoctorj/issues{/number}","pulls_url":"https://api.github.com/repos/nicerloop/asciidoctorj/pulls{/number}","milestones_url":"https://api.github.com/repos/nicerloop/asciidoctorj/milestones{/number}","notifications_url":"https://api.github.com/repos/nicerloop/asciidoctorj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicerloop/asciidoctorj/labels{/name}","releases_url":"https://api.github.com/repos/nicerloop/asciidoctorj/releases{/id}","deployments_url":"https://api.github.com/repos/nicerloop/asciidoctorj/deployments","created_at":"2019-11-05T23:27:49Z","updated_at":"2019-11-09T19:05:07Z","pushed_at":"2019-11-09T19:05:05Z","git_url":"git://github.com/nicerloop/asciidoctorj.git","ssh_url":"git@github.com:nicerloop/asciidoctorj.git","clone_url":"https://github.com/nicerloop/asciidoctorj.git","svn_url":"https://github.com/nicerloop/asciidoctorj","homepage":"http://asciidoctor.org","size":3372,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asciidoctor:master","ref":"master","sha":"947d002e027f98b2e52dd5acb5fd70e608103870","user":{"login":"asciidoctor","id":3137042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzcwNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3137042?v=4","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"repo":{"id":8862411,"node_id":"MDEwOlJlcG9zaXRvcnk4ODYyNDEx","name":"asciidoctorj","full_name":"asciidoctor/asciidoctorj","private":false,"owner":{"login":"asciidoctor","id":3137042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzcwNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3137042?v=4","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/asciidoctor/asciidoctorj","description":":coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!","fork":false,"url":"https://api.github.com/repos/asciidoctor/asciidoctorj","forks_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/forks","keys_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/teams","hooks_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/hooks","issue_events_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/events{/number}","events_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/events","assignees_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/assignees{/user}","branches_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/branches{/branch}","tags_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/tags","blobs_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/refs{/sha}","trees_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/statuses/{sha}","languages_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/languages","stargazers_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/stargazers","contributors_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/contributors","subscribers_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/subscribers","subscription_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/subscription","commits_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/commits{/sha}","git_commits_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/commits{/sha}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/comments{/number}","issue_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/comments{/number}","contents_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/contents/{+path}","compare_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/merges","archive_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/downloads","issues_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues{/number}","pulls_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls{/number}","milestones_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/milestones{/number}","notifications_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/labels{/name}","releases_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/releases{/id}","deployments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/deployments","created_at":"2013-03-18T19:36:27Z","updated_at":"2019-11-09T04:32:01Z","pushed_at":"2019-11-09T19:05:07Z","git_url":"git://github.com/asciidoctor/asciidoctorj.git","ssh_url":"git@github.com:asciidoctor/asciidoctorj.git","clone_url":"https://github.com/asciidoctor/asciidoctorj.git","svn_url":"https://github.com/asciidoctor/asciidoctorj","homepage":"http://asciidoctor.org","size":3366,"stargazers_count":431,"watchers_count":431,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":140,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":115,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":140,"open_issues":115,"watchers":431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/863"},"html":{"href":"https://github.com/asciidoctor/asciidoctorj/pull/863"},"issue":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/863"},"comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/863/comments"},"review_comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/863/comments"},"review_comment":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/863/commits"},"statuses":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/statuses/30b67716cae5c0354fe4cd6cddb09ac6fbe3c1f3"}},"author_association":"NONE"}}
|
{
"id": 8862411,
"name": "asciidoctor/asciidoctorj",
"url": "https://api.github.com/repos/asciidoctor/asciidoctorj"
}
|
{
"id": 1163662,
"login": "robertpanzer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1163662?",
"url": "https://api.github.com/users/robertpanzer"
}
|
{
"id": 3137042,
"login": "asciidoctor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3137042?",
"url": "https://api.github.com/orgs/asciidoctor"
}
| 2019-11-10T12:12:01 |
10827796626
|
{"actor":{"display_login":"robertpanzer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/288144031","pull_request_review_id":242720748,"id":288144031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODE0NDAzMQ==","diff_hunk":"@@ -10,8 +10,24 @@ Context\n =======\n \n We are implementing platform-wide discounts that are determined using a combination of course and user. The\n-data used in this determination lives in the lms. The discount will be messaged in the lms, and then autoapplied\n-on the basket page of ecommerce.\n+data used in this determination lives in the LMS. The discount will be messaged in the LMS, and then autoapplied\n+on the basket page of Ecommerce. See the table below for information on how this new discount differs from our\n+current discounting schemes.\n+\n++-------------------------------------+-------------------------------------+------------------------------------+ \n+| Discounts | Coupons | Enterprise Offers | ","path":"openedx/features/discounts/docs/decisions/0001-determining-discount-location.rst","position":18,"original_position":11,"commit_id":"030057cf16847553d5a8f4d072c1336d38d38adf","original_commit_id":"7353a9ac436ba65198bc453f7e2d8a8a3111b0eb","user":{"login":"MatthewPiatetsky","id":5958221,"node_id":"MDQ6VXNlcjU5NTgyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/5958221?v=4","gravatar_id":"","url":"https://api.github.com/users/MatthewPiatetsky","html_url":"https://github.com/MatthewPiatetsky","followers_url":"https://api.github.com/users/MatthewPiatetsky/followers","following_url":"https://api.github.com/users/MatthewPiatetsky/following{/other_user}","gists_url":"https://api.github.com/users/MatthewPiatetsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewPiatetsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewPiatetsky/subscriptions","organizations_url":"https://api.github.com/users/MatthewPiatetsky/orgs","repos_url":"https://api.github.com/users/MatthewPiatetsky/repos","events_url":"https://api.github.com/users/MatthewPiatetsky/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewPiatetsky/received_events","type":"User","site_admin":false},"body":"sure, that's what the word offers means in enterprise offers \r\nPotentially relevant because i'm sure we'll have offers that are not enterprise and not discounts in the future","created_at":"2019-05-28T14:46:28Z","updated_at":"2019-05-28T14:46:28Z","html_url":"https://github.com/edx/edx-platform/pull/20661#discussion_r288144031","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/20661","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/288144031"},"html":{"href":"https://github.com/edx/edx-platform/pull/20661#discussion_r288144031"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/20661"}},"in_reply_to_id":288138832},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/20661","id":280946155,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwOTQ2MTU1","html_url":"https://github.com/edx/edx-platform/pull/20661","diff_url":"https://github.com/edx/edx-platform/pull/20661.diff","patch_url":"https://github.com/edx/edx-platform/pull/20661.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/20661","number":20661,"state":"open","locked":false,"title":"add arch decision of computation of course-user discount","user":{"login":"emma-green","id":32077611,"node_id":"MDQ6VXNlcjMyMDc3NjEx","avatar_url":"https://avatars2.githubusercontent.com/u/32077611?v=4","gravatar_id":"","url":"https://api.github.com/users/emma-green","html_url":"https://github.com/emma-green","followers_url":"https://api.github.com/users/emma-green/followers","following_url":"https://api.github.com/users/emma-green/following{/other_user}","gists_url":"https://api.github.com/users/emma-green/gists{/gist_id}","starred_url":"https://api.github.com/users/emma-green/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emma-green/subscriptions","organizations_url":"https://api.github.com/users/emma-green/orgs","repos_url":"https://api.github.com/users/emma-green/repos","events_url":"https://api.github.com/users/emma-green/events{/privacy}","received_events_url":"https://api.github.com/users/emma-green/received_events","type":"User","site_admin":false},"body":"This is the information about why the computation of the discount is where it is. This is the first time that I've written one of these, so I would appreciate feedback!","created_at":"2019-05-21T20:56:08Z","updated_at":"2019-05-28T14:46:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"125ea77ffe2ade82c4fa9dbee4c45ce75da731a4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cpennington","id":30236,"node_id":"MDQ6VXNlcjMwMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/30236?v=4","gravatar_id":"","url":"https://api.github.com/users/cpennington","html_url":"https://github.com/cpennington","followers_url":"https://api.github.com/users/cpennington/followers","following_url":"https://api.github.com/users/cpennington/following{/other_user}","gists_url":"https://api.github.com/users/cpennington/gists{/gist_id}","starred_url":"https://api.github.com/users/cpennington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpennington/subscriptions","organizations_url":"https://api.github.com/users/cpennington/orgs","repos_url":"https://api.github.com/users/cpennington/repos","events_url":"https://api.github.com/users/cpennington/events{/privacy}","received_events_url":"https://api.github.com/users/cpennington/received_events","type":"User","site_admin":false},{"login":"mulby","id":627177,"node_id":"MDQ6VXNlcjYyNzE3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/627177?v=4","gravatar_id":"","url":"https://api.github.com/users/mulby","html_url":"https://github.com/mulby","followers_url":"https://api.github.com/users/mulby/followers","following_url":"https://api.github.com/users/mulby/following{/other_user}","gists_url":"https://api.github.com/users/mulby/gists{/gist_id}","starred_url":"https://api.github.com/users/mulby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulby/subscriptions","organizations_url":"https://api.github.com/users/mulby/orgs","repos_url":"https://api.github.com/users/mulby/repos","events_url":"https://api.github.com/users/mulby/events{/privacy}","received_events_url":"https://api.github.com/users/mulby/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/20661/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/20661/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/20661/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/030057cf16847553d5a8f4d072c1336d38d38adf","head":{"label":"edx:emma-green/REVEM-355/add-arch-decision","ref":"emma-green/REVEM-355/add-arch-decision","sha":"030057cf16847553d5a8f4d072c1336d38d38adf","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5MTA3Mw==","name":"edx-platform","full_name":"edx/edx-platform","private":false,"owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2019-05-28T14:28:20Z","pushed_at":"2019-05-28T14:42:26Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":1050087,"stargazers_count":4352,"watchers_count":4352,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2407,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":252,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2407,"open_issues":252,"watchers":4352,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"1cfc6738cf44e0003d649da111f53d67c62588e0","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5MTA3Mw==","name":"edx-platform","full_name":"edx/edx-platform","private":false,"owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2019-05-28T14:28:20Z","pushed_at":"2019-05-28T14:42:26Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":1050087,"stargazers_count":4352,"watchers_count":4352,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2407,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":252,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2407,"open_issues":252,"watchers":4352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/20661"},"html":{"href":"https://github.com/edx/edx-platform/pull/20661"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/20661"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/20661/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/20661/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/20661/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/030057cf16847553d5a8f4d072c1336d38d38adf"}},"author_association":"MEMBER"}}
|
{
"id": 10391073,
"name": "edx/edx-platform",
"url": "https://api.github.com/repos/edx/edx-platform"
}
|
{
"id": 5958221,
"login": "MatthewPiatetsky",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5958221?",
"url": "https://api.github.com/users/MatthewPiatetsky"
}
|
{
"id": 3179841,
"login": "edx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179841?",
"url": "https://api.github.com/orgs/edx"
}
| 2019-05-28T14:46:28 |
9711531453
|
{"actor":{"display_login":"MatthewPiatetsky"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/edx/paragon/pulls/comments/268261006","pull_request_review_id":217874300,"id":268261006,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODI2MTAwNg==","diff_hunk":"@@ -1,10 +1,5 @@\n-/* eslint-disable import/no-extraneous-dependencies */\n import React from 'react';\n import { storiesOf } from '@storybook/react';\n-import centered from '@storybook/addon-centered';\n-import { checkA11y } from '@storybook/addon-a11y';\n-import { withInfo } from '@storybook/addon-info';\n-import { withReadme } from 'storybook-readme';","path":"src/Breadcrumb/Breadcrumb.stories.jsx","position":7,"original_position":7,"commit_id":"d40a1227f383fc98aa0d4d212dcacee61d911a66","original_commit_id":"d40a1227f383fc98aa0d4d212dcacee61d911a66","user":{"login":"AlasdairSwan","id":2052185,"node_id":"MDQ6VXNlcjIwNTIxODU=","avatar_url":"https://avatars1.githubusercontent.com/u/2052185?v=4","gravatar_id":"","url":"https://api.github.com/users/AlasdairSwan","html_url":"https://github.com/AlasdairSwan","followers_url":"https://api.github.com/users/AlasdairSwan/followers","following_url":"https://api.github.com/users/AlasdairSwan/following{/other_user}","gists_url":"https://api.github.com/users/AlasdairSwan/gists{/gist_id}","starred_url":"https://api.github.com/users/AlasdairSwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlasdairSwan/subscriptions","organizations_url":"https://api.github.com/users/AlasdairSwan/orgs","repos_url":"https://api.github.com/users/AlasdairSwan/repos","events_url":"https://api.github.com/users/AlasdairSwan/events{/privacy}","received_events_url":"https://api.github.com/users/AlasdairSwan/received_events","type":"User","site_admin":false},"body":"@abutterworth why are these being removed? Because of the Storybook version update?","created_at":"2019-03-22T17:08:18Z","updated_at":"2019-03-22T17:08:18Z","html_url":"https://github.com/edx/paragon/pull/400#discussion_r268261006","pull_request_url":"https://api.github.com/repos/edx/paragon/pulls/400","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edx/paragon/pulls/comments/268261006"},"html":{"href":"https://github.com/edx/paragon/pull/400#discussion_r268261006"},"pull_request":{"href":"https://api.github.com/repos/edx/paragon/pulls/400"}}},"pull_request":{"url":"https://api.github.com/repos/edx/paragon/pulls/400","id":263388616,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzMzg4NjE2","html_url":"https://github.com/edx/paragon/pull/400","diff_url":"https://github.com/edx/paragon/pull/400.diff","patch_url":"https://github.com/edx/paragon/pull/400.patch","issue_url":"https://api.github.com/repos/edx/paragon/issues/400","number":400,"state":"open","locked":false,"title":"Update packages, simplify build targets, remove css modules","user":{"login":"abutterworth","id":1615421,"node_id":"MDQ6VXNlcjE2MTU0MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1615421?v=4","gravatar_id":"","url":"https://api.github.com/users/abutterworth","html_url":"https://github.com/abutterworth","followers_url":"https://api.github.com/users/abutterworth/followers","following_url":"https://api.github.com/users/abutterworth/following{/other_user}","gists_url":"https://api.github.com/users/abutterworth/gists{/gist_id}","starred_url":"https://api.github.com/users/abutterworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutterworth/subscriptions","organizations_url":"https://api.github.com/users/abutterworth/orgs","repos_url":"https://api.github.com/users/abutterworth/repos","events_url":"https://api.github.com/users/abutterworth/events{/privacy}","received_events_url":"https://api.github.com/users/abutterworth/received_events","type":"User","site_admin":false},"body":"# Paragon 4.0.0\r\n\r\n**This PR removes support for the static, css-namespaced build that is used in edx-platform.** See all uses here: https://github.com/search?q=org%3Aedx+%22paragon%2Fstatic%22&type=Code\r\nIn letting go of this requirement the following changes are contained in this release:\r\n\r\n### CSS Modules have been removed.\r\nSCSS is no longer imported into Paragon component JSX files and those that no longer serve a purpose have been deleted.\r\n\r\n### The way to include Paragon SCSS has changed\r\nInclude in your SCSS file:\r\n```\r\nimport '~bootstrap/scss/bootstrap'; // Or other inclusion of bootstrap\r\nimport '~@edx/paragon/src/index.scss';\r\n```\r\nThis file contains style modifications for all paragon components. It is not large and is the simplest way to include Paragon styles. Note\r\n\r\n* It does not include bootstrap. You must include that yourself.\r\n* It must be included after bootstrap functions, variables, and mixins\r\n\r\nIf you are not using SCSS you can include a minified CSS file that also does not include bootstrap:\r\n```\r\nimport '~@edx/paragon/dist/paragon.min.css';\r\n```\r\n\r\n### You will see minor changes in your snapshot tests\r\nThere are no breaking changes in the usage of Paragon components, but there are a couple minor changes in html output. \r\n- null values will be present on scope attributes in tables (this seems to be a change in the way React handles null values)\r\n- Dropdowns with icons have a className that is no longer outputted incorrectly as an array.","created_at":"2019-03-21T20:16:04Z","updated_at":"2019-03-22T17:08:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a84c9469170ecdcc4b95b933ab89673776f5977f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adamstankiewicz","id":2828721,"node_id":"MDQ6VXNlcjI4Mjg3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/2828721?v=4","gravatar_id":"","url":"https://api.github.com/users/adamstankiewicz","html_url":"https://github.com/adamstankiewicz","followers_url":"https://api.github.com/users/adamstankiewicz/followers","following_url":"https://api.github.com/users/adamstankiewicz/following{/other_user}","gists_url":"https://api.github.com/users/adamstankiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamstankiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamstankiewicz/subscriptions","organizations_url":"https://api.github.com/users/adamstankiewicz/orgs","repos_url":"https://api.github.com/users/adamstankiewicz/repos","events_url":"https://api.github.com/users/adamstankiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/adamstankiewicz/received_events","type":"User","site_admin":false},{"login":"matthugs","id":6405097,"node_id":"MDQ6VXNlcjY0MDUwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/6405097?v=4","gravatar_id":"","url":"https://api.github.com/users/matthugs","html_url":"https://github.com/matthugs","followers_url":"https://api.github.com/users/matthugs/followers","following_url":"https://api.github.com/users/matthugs/following{/other_user}","gists_url":"https://api.github.com/users/matthugs/gists{/gist_id}","starred_url":"https://api.github.com/users/matthugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthugs/subscriptions","organizations_url":"https://api.github.com/users/matthugs/orgs","repos_url":"https://api.github.com/users/matthugs/repos","events_url":"https://api.github.com/users/matthugs/events{/privacy}","received_events_url":"https://api.github.com/users/matthugs/received_events","type":"User","site_admin":false},{"login":"Tj-Tracy","id":16495365,"node_id":"MDQ6VXNlcjE2NDk1MzY1","avatar_url":"https://avatars1.githubusercontent.com/u/16495365?v=4","gravatar_id":"","url":"https://api.github.com/users/Tj-Tracy","html_url":"https://github.com/Tj-Tracy","followers_url":"https://api.github.com/users/Tj-Tracy/followers","following_url":"https://api.github.com/users/Tj-Tracy/following{/other_user}","gists_url":"https://api.github.com/users/Tj-Tracy/gists{/gist_id}","starred_url":"https://api.github.com/users/Tj-Tracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tj-Tracy/subscriptions","organizations_url":"https://api.github.com/users/Tj-Tracy/orgs","repos_url":"https://api.github.com/users/Tj-Tracy/repos","events_url":"https://api.github.com/users/Tj-Tracy/events{/privacy}","received_events_url":"https://api.github.com/users/Tj-Tracy/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"arch-squad","id":3128578,"node_id":"MDQ6VGVhbTMxMjg1Nzg=","slug":"arch-squad","description":"edX Architecture Squad","privacy":"closed","url":"https://api.github.com/teams/3128578","html_url":"https://github.com/orgs/edx/teams/arch-squad","members_url":"https://api.github.com/teams/3128578/members{/member}","repositories_url":"https://api.github.com/teams/3128578/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/paragon/pulls/400/commits","review_comments_url":"https://api.github.com/repos/edx/paragon/pulls/400/comments","review_comment_url":"https://api.github.com/repos/edx/paragon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/paragon/issues/400/comments","statuses_url":"https://api.github.com/repos/edx/paragon/statuses/d40a1227f383fc98aa0d4d212dcacee61d911a66","head":{"label":"edx:v4-dev","ref":"v4-dev","sha":"d40a1227f383fc98aa0d4d212dcacee61d911a66","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":89630641,"node_id":"MDEwOlJlcG9zaXRvcnk4OTYzMDY0MQ==","name":"paragon","full_name":"edx/paragon","private":false,"owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edx/paragon","description":"💎 Accessible components done right.","fork":false,"url":"https://api.github.com/repos/edx/paragon","forks_url":"https://api.github.com/repos/edx/paragon/forks","keys_url":"https://api.github.com/repos/edx/paragon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/paragon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/paragon/teams","hooks_url":"https://api.github.com/repos/edx/paragon/hooks","issue_events_url":"https://api.github.com/repos/edx/paragon/issues/events{/number}","events_url":"https://api.github.com/repos/edx/paragon/events","assignees_url":"https://api.github.com/repos/edx/paragon/assignees{/user}","branches_url":"https://api.github.com/repos/edx/paragon/branches{/branch}","tags_url":"https://api.github.com/repos/edx/paragon/tags","blobs_url":"https://api.github.com/repos/edx/paragon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/paragon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/paragon/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/paragon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/paragon/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/paragon/languages","stargazers_url":"https://api.github.com/repos/edx/paragon/stargazers","contributors_url":"https://api.github.com/repos/edx/paragon/contributors","subscribers_url":"https://api.github.com/repos/edx/paragon/subscribers","subscription_url":"https://api.github.com/repos/edx/paragon/subscription","commits_url":"https://api.github.com/repos/edx/paragon/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/paragon/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/paragon/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/paragon/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/paragon/contents/{+path}","compare_url":"https://api.github.com/repos/edx/paragon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/paragon/merges","archive_url":"https://api.github.com/repos/edx/paragon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/paragon/downloads","issues_url":"https://api.github.com/repos/edx/paragon/issues{/number}","pulls_url":"https://api.github.com/repos/edx/paragon/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/paragon/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/paragon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/paragon/labels{/name}","releases_url":"https://api.github.com/repos/edx/paragon/releases{/id}","deployments_url":"https://api.github.com/repos/edx/paragon/deployments","created_at":"2017-04-27T18:57:22Z","updated_at":"2019-03-18T14:28:35Z","pushed_at":"2019-03-22T13:57:50Z","git_url":"git://github.com/edx/paragon.git","ssh_url":"git@github.com:edx/paragon.git","clone_url":"https://github.com/edx/paragon.git","svn_url":"https://github.com/edx/paragon","homepage":"https://edx.github.io/paragon","size":7305,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":65,"watchers":34,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"8af1f5d6b49490d1661181153c70b0bc99a634d6","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":89630641,"node_id":"MDEwOlJlcG9zaXRvcnk4OTYzMDY0MQ==","name":"paragon","full_name":"edx/paragon","private":false,"owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edx/paragon","description":"💎 Accessible components done right.","fork":false,"url":"https://api.github.com/repos/edx/paragon","forks_url":"https://api.github.com/repos/edx/paragon/forks","keys_url":"https://api.github.com/repos/edx/paragon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/paragon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/paragon/teams","hooks_url":"https://api.github.com/repos/edx/paragon/hooks","issue_events_url":"https://api.github.com/repos/edx/paragon/issues/events{/number}","events_url":"https://api.github.com/repos/edx/paragon/events","assignees_url":"https://api.github.com/repos/edx/paragon/assignees{/user}","branches_url":"https://api.github.com/repos/edx/paragon/branches{/branch}","tags_url":"https://api.github.com/repos/edx/paragon/tags","blobs_url":"https://api.github.com/repos/edx/paragon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/paragon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/paragon/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/paragon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/paragon/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/paragon/languages","stargazers_url":"https://api.github.com/repos/edx/paragon/stargazers","contributors_url":"https://api.github.com/repos/edx/paragon/contributors","subscribers_url":"https://api.github.com/repos/edx/paragon/subscribers","subscription_url":"https://api.github.com/repos/edx/paragon/subscription","commits_url":"https://api.github.com/repos/edx/paragon/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/paragon/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/paragon/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/paragon/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/paragon/contents/{+path}","compare_url":"https://api.github.com/repos/edx/paragon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/paragon/merges","archive_url":"https://api.github.com/repos/edx/paragon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/paragon/downloads","issues_url":"https://api.github.com/repos/edx/paragon/issues{/number}","pulls_url":"https://api.github.com/repos/edx/paragon/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/paragon/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/paragon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/paragon/labels{/name}","releases_url":"https://api.github.com/repos/edx/paragon/releases{/id}","deployments_url":"https://api.github.com/repos/edx/paragon/deployments","created_at":"2017-04-27T18:57:22Z","updated_at":"2019-03-18T14:28:35Z","pushed_at":"2019-03-22T13:57:50Z","git_url":"git://github.com/edx/paragon.git","ssh_url":"git@github.com:edx/paragon.git","clone_url":"https://github.com/edx/paragon.git","svn_url":"https://github.com/edx/paragon","homepage":"https://edx.github.io/paragon","size":7305,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":65,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/paragon/pulls/400"},"html":{"href":"https://github.com/edx/paragon/pull/400"},"issue":{"href":"https://api.github.com/repos/edx/paragon/issues/400"},"comments":{"href":"https://api.github.com/repos/edx/paragon/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/paragon/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/paragon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/paragon/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/edx/paragon/statuses/d40a1227f383fc98aa0d4d212dcacee61d911a66"}},"author_association":"NONE"}}
|
{
"id": 89630641,
"name": "edx/paragon",
"url": "https://api.github.com/repos/edx/paragon"
}
|
{
"id": 2052185,
"login": "AlasdairSwan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2052185?",
"url": "https://api.github.com/users/AlasdairSwan"
}
|
{
"id": 3179841,
"login": "edx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179841?",
"url": "https://api.github.com/orgs/edx"
}
| 2019-03-22T17:08:18 |
9297006407
|
{"actor":{"display_login":"AlasdairSwan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CMSgov/bcda-app/pulls/comments/315412205","pull_request_review_id":276815788,"id":315412205,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNTQxMjIwNQ==","diff_hunk":"@@ -352,6 +357,71 @@ func getCCLFFileMetadata(filePath string) (cclfFileMetadata, error) {\n \treturn metadata, nil\n }\n \n+\n+func getCCLFFileMetadataBCD(filePath string) (cclfFileMetadata, error) {","path":"bcda/cclf/cclf.go","position":24,"original_position":24,"commit_id":"bce0becc0e405f5fb4e76f2f8459414a607d9a84","original_commit_id":"bce0becc0e405f5fb4e76f2f8459414a607d9a84","user":{"login":"tbellj","id":42976557,"node_id":"MDQ6VXNlcjQyOTc2NTU3","avatar_url":"https://avatars2.githubusercontent.com/u/42976557?v=4","gravatar_id":"","url":"https://api.github.com/users/tbellj","html_url":"https://github.com/tbellj","followers_url":"https://api.github.com/users/tbellj/followers","following_url":"https://api.github.com/users/tbellj/following{/other_user}","gists_url":"https://api.github.com/users/tbellj/gists{/gist_id}","starred_url":"https://api.github.com/users/tbellj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbellj/subscriptions","organizations_url":"https://api.github.com/users/tbellj/orgs","repos_url":"https://api.github.com/users/tbellj/repos","events_url":"https://api.github.com/users/tbellj/events{/privacy}","received_events_url":"https://api.github.com/users/tbellj/received_events","type":"User","site_admin":false},"body":"interesting! I think I was leaning towards separate methods because of the actual logic change for getting the acoID. Its not a simple \"filenameMatches[2]\" like it used to be for the new format. And also was thinking that this is temporary since it'll just be one way in the future (whenever they decide to phase out the old way). This logic will just be the entire getCCLFFileMetadata. Also wanted to avoid a bunch of if statements lol. Let me think.. ","created_at":"2019-08-19T21:07:56Z","updated_at":"2019-08-19T21:07:56Z","html_url":"https://github.com/CMSgov/bcda-app/pull/367#discussion_r315412205","pull_request_url":"https://api.github.com/repos/CMSgov/bcda-app/pulls/367","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CMSgov/bcda-app/pulls/comments/315412205"},"html":{"href":"https://github.com/CMSgov/bcda-app/pull/367#discussion_r315412205"},"pull_request":{"href":"https://api.github.com/repos/CMSgov/bcda-app/pulls/367"}},"in_reply_to_id":315279841},"pull_request":{"url":"https://api.github.com/repos/CMSgov/bcda-app/pulls/367","id":308638580,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4NjM4NTgw","html_url":"https://github.com/CMSgov/bcda-app/pull/367","diff_url":"https://github.com/CMSgov/bcda-app/pull/367.diff","patch_url":"https://github.com/CMSgov/bcda-app/pull/367.patch","issue_url":"https://api.github.com/repos/CMSgov/bcda-app/issues/367","number":367,"state":"open","locked":false,"title":"BCDA-1630 Feature: Updated cclf file name validation","user":{"login":"tbellj","id":42976557,"node_id":"MDQ6VXNlcjQyOTc2NTU3","avatar_url":"https://avatars2.githubusercontent.com/u/42976557?v=4","gravatar_id":"","url":"https://api.github.com/users/tbellj","html_url":"https://github.com/tbellj","followers_url":"https://api.github.com/users/tbellj/followers","following_url":"https://api.github.com/users/tbellj/following{/other_user}","gists_url":"https://api.github.com/users/tbellj/gists{/gist_id}","starred_url":"https://api.github.com/users/tbellj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbellj/subscriptions","organizations_url":"https://api.github.com/users/tbellj/orgs","repos_url":"https://api.github.com/users/tbellj/repos","events_url":"https://api.github.com/users/tbellj/events{/privacy}","received_events_url":"https://api.github.com/users/tbellj/received_events","type":"User","site_admin":false},"body":"Fixes [BCDA-1630](https://jira.cms.gov/browse/BCDA-1630)\r\n\r\nProblem:\r\nThe filename format for cclf files will change and we need a way to simultaneously support both file formats. This will allow us to support both the current implementation and the new one. \r\n\r\n\r\nProposed changes:\r\nAn update to our getCCLFFileMetadata method to parse data for both cclf file formats (with and without the BCD identifier)\r\n\r\n\r\nChange Details:\r\nbcda/cclf/cclf.go - additional method to handle new file format with the BCD identifier.\r\nbcda/cclf/cclf_test.go - testing code to support the new function.\r\nshared_files/cclf_BCD/T.BCD.ACO.ZC0Y18.D181120.T0001000 - new file formats\r\nshared_files/cclf_BCD/T.BCD.ACO.ZC8Y18.D181120.T0001000 - new file formats\r\nshared_files/cclf_BCD/T.BCD.ACO.ZC9Y18.D181120.T0001000 - new file formats\r\n\r\n\r\nSecurity Implications:\r\nThis change does deal with PII/PHI directly. - This code will be responsible for ingesting cclf files (with the new BCD identifier) into our system. \r\nThis change does **not** add new software dependencies\r\nThis change does **not** alter security controls or supporting software\r\nThis change does **not** introduce storage of new data\r\nA security checklist has been completed for this change: https://confluence.cms.gov/pages/viewpage.action?spaceKey=BCDA&title=Sprint+4.4+ACO+API+-+Security+Checklist\r\n\r\nAcceptance Validation\r\nYes, all tests pass.\r\n\r\nFeedback Requested:\r\nAny and all","created_at":"2019-08-19T14:30:35Z","updated_at":"2019-08-19T21:07:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68f51e4dc826cfb359fbd7cfa184bae7ca29dcc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CMSgov/bcda-app/pulls/367/commits","review_comments_url":"https://api.github.com/repos/CMSgov/bcda-app/pulls/367/comments","review_comment_url":"https://api.github.com/repos/CMSgov/bcda-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CMSgov/bcda-app/issues/367/comments","statuses_url":"https://api.github.com/repos/CMSgov/bcda-app/statuses/bce0becc0e405f5fb4e76f2f8459414a607d9a84","head":{"label":"CMSgov:tbell/BCDA-1630","ref":"tbell/BCDA-1630","sha":"bce0becc0e405f5fb4e76f2f8459414a607d9a84","user":{"login":"CMSgov","id":3209407,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDk0MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":141726185,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3MjYxODU=","name":"bcda-app","full_name":"CMSgov/bcda-app","private":false,"owner":{"login":"CMSgov","id":3209407,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDk0MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CMSgov/bcda-app","description":null,"fork":false,"url":"https://api.github.com/repos/CMSgov/bcda-app","forks_url":"https://api.github.com/repos/CMSgov/bcda-app/forks","keys_url":"https://api.github.com/repos/CMSgov/bcda-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/bcda-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/bcda-app/teams","hooks_url":"https://api.github.com/repos/CMSgov/bcda-app/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/bcda-app/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/bcda-app/events","assignees_url":"https://api.github.com/repos/CMSgov/bcda-app/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/bcda-app/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/bcda-app/tags","blobs_url":"https://api.github.com/repos/CMSgov/bcda-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/bcda-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/bcda-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/bcda-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/bcda-app/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/bcda-app/languages","stargazers_url":"https://api.github.com/repos/CMSgov/bcda-app/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/bcda-app/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/bcda-app/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/bcda-app/subscription","commits_url":"https://api.github.com/repos/CMSgov/bcda-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/bcda-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/bcda-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/bcda-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/bcda-app/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/bcda-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/bcda-app/merges","archive_url":"https://api.github.com/repos/CMSgov/bcda-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/bcda-app/downloads","issues_url":"https://api.github.com/repos/CMSgov/bcda-app/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/bcda-app/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/bcda-app/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/bcda-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/bcda-app/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/bcda-app/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/bcda-app/deployments","created_at":"2018-07-20T15:04:55Z","updated_at":"2019-08-19T20:40:12Z","pushed_at":"2019-08-19T20:51:57Z","git_url":"git://github.com/CMSgov/bcda-app.git","ssh_url":"git@github.com:CMSgov/bcda-app.git","clone_url":"https://github.com/CMSgov/bcda-app.git","svn_url":"https://github.com/CMSgov/bcda-app","homepage":null,"size":26960,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":7,"watchers":4,"default_branch":"master"}},"base":{"label":"CMSgov:master","ref":"master","sha":"f5d5d01d31e698c8ee7c9864905cac34da154bbe","user":{"login":"CMSgov","id":3209407,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDk0MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":141726185,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3MjYxODU=","name":"bcda-app","full_name":"CMSgov/bcda-app","private":false,"owner":{"login":"CMSgov","id":3209407,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDk0MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CMSgov/bcda-app","description":null,"fork":false,"url":"https://api.github.com/repos/CMSgov/bcda-app","forks_url":"https://api.github.com/repos/CMSgov/bcda-app/forks","keys_url":"https://api.github.com/repos/CMSgov/bcda-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/bcda-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/bcda-app/teams","hooks_url":"https://api.github.com/repos/CMSgov/bcda-app/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/bcda-app/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/bcda-app/events","assignees_url":"https://api.github.com/repos/CMSgov/bcda-app/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/bcda-app/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/bcda-app/tags","blobs_url":"https://api.github.com/repos/CMSgov/bcda-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/bcda-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/bcda-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/bcda-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/bcda-app/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/bcda-app/languages","stargazers_url":"https://api.github.com/repos/CMSgov/bcda-app/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/bcda-app/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/bcda-app/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/bcda-app/subscription","commits_url":"https://api.github.com/repos/CMSgov/bcda-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/bcda-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/bcda-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/bcda-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/bcda-app/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/bcda-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/bcda-app/merges","archive_url":"https://api.github.com/repos/CMSgov/bcda-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/bcda-app/downloads","issues_url":"https://api.github.com/repos/CMSgov/bcda-app/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/bcda-app/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/bcda-app/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/bcda-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/bcda-app/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/bcda-app/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/bcda-app/deployments","created_at":"2018-07-20T15:04:55Z","updated_at":"2019-08-19T20:40:12Z","pushed_at":"2019-08-19T20:51:57Z","git_url":"git://github.com/CMSgov/bcda-app.git","ssh_url":"git@github.com:CMSgov/bcda-app.git","clone_url":"https://github.com/CMSgov/bcda-app.git","svn_url":"https://github.com/CMSgov/bcda-app","homepage":null,"size":26960,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":7,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CMSgov/bcda-app/pulls/367"},"html":{"href":"https://github.com/CMSgov/bcda-app/pull/367"},"issue":{"href":"https://api.github.com/repos/CMSgov/bcda-app/issues/367"},"comments":{"href":"https://api.github.com/repos/CMSgov/bcda-app/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/CMSgov/bcda-app/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/CMSgov/bcda-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CMSgov/bcda-app/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/CMSgov/bcda-app/statuses/bce0becc0e405f5fb4e76f2f8459414a607d9a84"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 141726185,
"name": "CMSgov/bcda-app",
"url": "https://api.github.com/repos/CMSgov/bcda-app"
}
|
{
"id": 42976557,
"login": "tbellj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42976557?",
"url": "https://api.github.com/users/tbellj"
}
|
{
"id": 3209407,
"login": "CMSgov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3209407?",
"url": "https://api.github.com/orgs/CMSgov"
}
| 2019-08-19T21:07:56 |
10240562050
|
{"actor":{"display_login":"tbellj"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/345798457","pull_request_review_id":316295610,"id":345798457,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NTc5ODQ1Nw==","diff_hunk":"@@ -23,22 +23,22 @@ const filterByHealth = ({ upCount, targets }: ScrapePool, { showHealthy, showUnh\n };\n \n const ScrapePoolList: FC<ScrapePoolListProps & PathPrefixProps> = ({ filter, pathPrefix }) => {\n- const { response, error } = useFetch(`${pathPrefix}/api/v1/targets?state=active`);\n+ const { response, error } = useFetch<TargetsResponse>(`${pathPrefix}/api/v1/targets?state=active`);\n \n if (error) {\n return (\n <Alert color=\"danger\">\n <strong>Error fetching targets:</strong> {error.message}\n </Alert>\n );\n- } else if (response && response.status !== 'success') {\n+ } else if (response && response.status !== 'success' && response.status !== 'start fetching') {","path":"web/ui/react-app/src/pages/targets/ScrapePoolList.tsx","position":14,"original_position":14,"commit_id":"d2df97ac09a49277e8fc0fddde5704cc16d64818","original_commit_id":"d2df97ac09a49277e8fc0fddde5704cc16d64818","user":{"login":"juliusv","id":538008,"node_id":"MDQ6VXNlcjUzODAwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/538008?v=4","gravatar_id":"","url":"https://api.github.com/users/juliusv","html_url":"https://github.com/juliusv","followers_url":"https://api.github.com/users/juliusv/followers","following_url":"https://api.github.com/users/juliusv/following{/other_user}","gists_url":"https://api.github.com/users/juliusv/gists{/gist_id}","starred_url":"https://api.github.com/users/juliusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliusv/subscriptions","organizations_url":"https://api.github.com/users/juliusv/orgs","repos_url":"https://api.github.com/users/juliusv/repos","events_url":"https://api.github.com/users/juliusv/events{/privacy}","received_events_url":"https://api.github.com/users/juliusv/received_events","type":"User","site_admin":false},"body":"Hm yeah, or would it not make sense to allow the whole `response` to be null as long as it't not fetched yet? E.g. via:\r\n\r\n`response: APIResponse<T>;` ---> `response: APIResponse<T> | null;`\r\n\r\nSeems like we check for `response` to be truthy anyway in the caller.","created_at":"2019-11-13T14:45:25Z","updated_at":"2019-11-13T14:45:26Z","html_url":"https://github.com/prometheus/prometheus/pull/6314#discussion_r345798457","pull_request_url":"https://api.github.com/repos/prometheus/prometheus/pulls/6314","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/345798457"},"html":{"href":"https://github.com/prometheus/prometheus/pull/6314#discussion_r345798457"},"pull_request":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/6314"}},"in_reply_to_id":345768090},"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/6314","id":340462050,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQwNDYyMDUw","html_url":"https://github.com/prometheus/prometheus/pull/6314","diff_url":"https://github.com/prometheus/prometheus/pull/6314.diff","patch_url":"https://github.com/prometheus/prometheus/pull/6314.patch","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/6314","number":6314,"state":"closed","locked":false,"title":"unit test fixes","user":{"login":"boyskila","id":10514821,"node_id":"MDQ6VXNlcjEwNTE0ODIx","avatar_url":"https://avatars2.githubusercontent.com/u/10514821?v=4","gravatar_id":"","url":"https://api.github.com/users/boyskila","html_url":"https://github.com/boyskila","followers_url":"https://api.github.com/users/boyskila/followers","following_url":"https://api.github.com/users/boyskila/following{/other_user}","gists_url":"https://api.github.com/users/boyskila/gists{/gist_id}","starred_url":"https://api.github.com/users/boyskila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyskila/subscriptions","organizations_url":"https://api.github.com/users/boyskila/orgs","repos_url":"https://api.github.com/users/boyskila/repos","events_url":"https://api.github.com/users/boyskila/events{/privacy}","received_events_url":"https://api.github.com/users/boyskila/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-13T13:27:14Z","updated_at":"2019-11-13T14:45:26Z","closed_at":"2019-11-13T13:58:45Z","merged_at":"2019-11-13T13:58:45Z","merge_commit_sha":"12d347e4db04c926dab54f37e46eaca42f2ea685","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/prometheus/pulls/6314/commits","review_comments_url":"https://api.github.com/repos/prometheus/prometheus/pulls/6314/comments","review_comment_url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/6314/comments","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/d2df97ac09a49277e8fc0fddde5704cc16d64818","head":{"label":"boyskila:unit-test-fixes","ref":"unit-test-fixes","sha":"d2df97ac09a49277e8fc0fddde5704cc16d64818","user":{"login":"boyskila","id":10514821,"node_id":"MDQ6VXNlcjEwNTE0ODIx","avatar_url":"https://avatars2.githubusercontent.com/u/10514821?v=4","gravatar_id":"","url":"https://api.github.com/users/boyskila","html_url":"https://github.com/boyskila","followers_url":"https://api.github.com/users/boyskila/followers","following_url":"https://api.github.com/users/boyskila/following{/other_user}","gists_url":"https://api.github.com/users/boyskila/gists{/gist_id}","starred_url":"https://api.github.com/users/boyskila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyskila/subscriptions","organizations_url":"https://api.github.com/users/boyskila/orgs","repos_url":"https://api.github.com/users/boyskila/repos","events_url":"https://api.github.com/users/boyskila/events{/privacy}","received_events_url":"https://api.github.com/users/boyskila/received_events","type":"User","site_admin":false},"repo":{"id":215795829,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU3OTU4Mjk=","name":"prometheus","full_name":"boyskila/prometheus","private":false,"owner":{"login":"boyskila","id":10514821,"node_id":"MDQ6VXNlcjEwNTE0ODIx","avatar_url":"https://avatars2.githubusercontent.com/u/10514821?v=4","gravatar_id":"","url":"https://api.github.com/users/boyskila","html_url":"https://github.com/boyskila","followers_url":"https://api.github.com/users/boyskila/followers","following_url":"https://api.github.com/users/boyskila/following{/other_user}","gists_url":"https://api.github.com/users/boyskila/gists{/gist_id}","starred_url":"https://api.github.com/users/boyskila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyskila/subscriptions","organizations_url":"https://api.github.com/users/boyskila/orgs","repos_url":"https://api.github.com/users/boyskila/repos","events_url":"https://api.github.com/users/boyskila/events{/privacy}","received_events_url":"https://api.github.com/users/boyskila/received_events","type":"User","site_admin":false},"html_url":"https://github.com/boyskila/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/boyskila/prometheus","forks_url":"https://api.github.com/repos/boyskila/prometheus/forks","keys_url":"https://api.github.com/repos/boyskila/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boyskila/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boyskila/prometheus/teams","hooks_url":"https://api.github.com/repos/boyskila/prometheus/hooks","issue_events_url":"https://api.github.com/repos/boyskila/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/boyskila/prometheus/events","assignees_url":"https://api.github.com/repos/boyskila/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/boyskila/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/boyskila/prometheus/tags","blobs_url":"https://api.github.com/repos/boyskila/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boyskila/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boyskila/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/boyskila/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boyskila/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/boyskila/prometheus/languages","stargazers_url":"https://api.github.com/repos/boyskila/prometheus/stargazers","contributors_url":"https://api.github.com/repos/boyskila/prometheus/contributors","subscribers_url":"https://api.github.com/repos/boyskila/prometheus/subscribers","subscription_url":"https://api.github.com/repos/boyskila/prometheus/subscription","commits_url":"https://api.github.com/repos/boyskila/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/boyskila/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/boyskila/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/boyskila/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/boyskila/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/boyskila/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boyskila/prometheus/merges","archive_url":"https://api.github.com/repos/boyskila/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boyskila/prometheus/downloads","issues_url":"https://api.github.com/repos/boyskila/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/boyskila/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/boyskila/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/boyskila/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boyskila/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/boyskila/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/boyskila/prometheus/deployments","created_at":"2019-10-17T13:12:46Z","updated_at":"2019-11-12T19:53:50Z","pushed_at":"2019-11-13T13:27:42Z","git_url":"git://github.com/boyskila/prometheus.git","ssh_url":"git@github.com:boyskila/prometheus.git","clone_url":"https://github.com/boyskila/prometheus.git","svn_url":"https://github.com/boyskila/prometheus","homepage":"https://prometheus.io/","size":89869,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"e110402d44d43b261ee58ef4e72477ba0c03ea8a","user":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":6838921,"node_id":"MDEwOlJlcG9zaXRvcnk2ODM4OTIx","name":"prometheus","full_name":"prometheus/prometheus","private":false,"owner":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prometheus/prometheus","description":"The Prometheus monitoring system and time series database.","fork":false,"url":"https://api.github.com/repos/prometheus/prometheus","forks_url":"https://api.github.com/repos/prometheus/prometheus/forks","keys_url":"https://api.github.com/repos/prometheus/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/prometheus/teams","hooks_url":"https://api.github.com/repos/prometheus/prometheus/hooks","issue_events_url":"https://api.github.com/repos/prometheus/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/prometheus/events","assignees_url":"https://api.github.com/repos/prometheus/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/prometheus/tags","blobs_url":"https://api.github.com/repos/prometheus/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/prometheus/languages","stargazers_url":"https://api.github.com/repos/prometheus/prometheus/stargazers","contributors_url":"https://api.github.com/repos/prometheus/prometheus/contributors","subscribers_url":"https://api.github.com/repos/prometheus/prometheus/subscribers","subscription_url":"https://api.github.com/repos/prometheus/prometheus/subscription","commits_url":"https://api.github.com/repos/prometheus/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/prometheus/merges","archive_url":"https://api.github.com/repos/prometheus/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/prometheus/downloads","issues_url":"https://api.github.com/repos/prometheus/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/prometheus/deployments","created_at":"2012-11-24T11:14:12Z","updated_at":"2019-11-13T13:58:50Z","pushed_at":"2019-11-13T13:58:46Z","git_url":"git://github.com/prometheus/prometheus.git","ssh_url":"git@github.com:prometheus/prometheus.git","clone_url":"https://github.com/prometheus/prometheus.git","svn_url":"https://github.com/prometheus/prometheus","homepage":"https://prometheus.io/","size":90683,"stargazers_count":27542,"watchers_count":27542,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4061,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":483,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4061,"open_issues":483,"watchers":27542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/6314"},"html":{"href":"https://github.com/prometheus/prometheus/pull/6314"},"issue":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/6314"},"comments":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/6314/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/6314/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/6314/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/prometheus/statuses/d2df97ac09a49277e8fc0fddde5704cc16d64818"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 6838921,
"name": "prometheus/prometheus",
"url": "https://api.github.com/repos/prometheus/prometheus"
}
|
{
"id": 538008,
"login": "juliusv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/538008?",
"url": "https://api.github.com/users/juliusv"
}
|
{
"id": 3380462,
"login": "prometheus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3380462?",
"url": "https://api.github.com/orgs/prometheus"
}
| 2019-11-13T14:45:25 |
10853455898
|
{"actor":{"display_login":"juliusv"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/prombench/pulls/comments/360671344","pull_request_review_id":335625121,"id":360671344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MDY3MTM0NA==","diff_hunk":"@@ -0,0 +1,78 @@\n+apiVersion: v1\n+kind: ConfigMap\n+metadata:\n+ name: workflow\n+ namespace: funcbench-{{ .PR_NUMBER }}\n+data:\n+ event.json: |\n+ {\n+ \"action\": \"created\",\n+ \"issue\": {\n+ \"number\": {{ .PR_NUMBER }}\n+ },\n+ \"repository\": {\n+ \"name\": \"{{ .GITHUB_REPO }}\",\n+ \"owner\": {\n+ \"login\": \"{{ .GITHUB_ORG }}\"\n+ }\n+ }\n+ }\n+ BRANCH: {{ .BRANCH }}\n+ RACE: {{ .RACE }}\n+ REGEX: {{ .REGEX }}","path":"funcbench/manifests/benchmark/2_job.yaml","position":22,"original_position":22,"commit_id":"bd4ad54780c4351d880b2bbfc839e3bc1cae5f6e","original_commit_id":"bd4ad54780c4351d880b2bbfc839e3bc1cae5f6e","user":{"login":"nevill","id":114409,"node_id":"MDQ6VXNlcjExNDQwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/114409?v=4","gravatar_id":"","url":"https://api.github.com/users/nevill","html_url":"https://github.com/nevill","followers_url":"https://api.github.com/users/nevill/followers","following_url":"https://api.github.com/users/nevill/following{/other_user}","gists_url":"https://api.github.com/users/nevill/gists{/gist_id}","starred_url":"https://api.github.com/users/nevill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nevill/subscriptions","organizations_url":"https://api.github.com/users/nevill/orgs","repos_url":"https://api.github.com/users/nevill/repos","events_url":"https://api.github.com/users/nevill/events{/privacy}","received_events_url":"https://api.github.com/users/nevill/received_events","type":"User","site_admin":false},"body":"@geekodour the workflow file is [here](https://github.com/nevill/prometheus/blob/master/.github/workflows/benchmark.yml)","created_at":"2019-12-21T22:38:48Z","updated_at":"2019-12-21T22:38:48Z","html_url":"https://github.com/prometheus/prombench/pull/311#discussion_r360671344","pull_request_url":"https://api.github.com/repos/prometheus/prombench/pulls/311","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/prometheus/prombench/pulls/comments/360671344"},"html":{"href":"https://github.com/prometheus/prombench/pull/311#discussion_r360671344"},"pull_request":{"href":"https://api.github.com/repos/prometheus/prombench/pulls/311"}},"in_reply_to_id":359983809},"pull_request":{"url":"https://api.github.com/repos/prometheus/prombench/pulls/311","id":354705401,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0NzA1NDAx","html_url":"https://github.com/prometheus/prombench/pull/311","diff_url":"https://github.com/prometheus/prombench/pull/311.diff","patch_url":"https://github.com/prometheus/prombench/pull/311.patch","issue_url":"https://api.github.com/repos/prometheus/prombench/issues/311","number":311,"state":"open","locked":false,"title":"Run funcbench via GKE","user":{"login":"nevill","id":114409,"node_id":"MDQ6VXNlcjExNDQwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/114409?v=4","gravatar_id":"","url":"https://api.github.com/users/nevill","html_url":"https://github.com/nevill","followers_url":"https://api.github.com/users/nevill/followers","following_url":"https://api.github.com/users/nevill/following{/other_user}","gists_url":"https://api.github.com/users/nevill/gists{/gist_id}","starred_url":"https://api.github.com/users/nevill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nevill/subscriptions","organizations_url":"https://api.github.com/users/nevill/orgs","repos_url":"https://api.github.com/users/nevill/repos","events_url":"https://api.github.com/users/nevill/events{/privacy}","received_events_url":"https://api.github.com/users/nevill/received_events","type":"User","site_admin":false},"body":"xref #310 \r\n\r\nit includes:\r\n- [x] Run `funcbench` as a Kubernetes Job\r\n- [ ] Replace docker images `nevill/prombench`, `nevill/funcbench` once the latest are released\r\n- [ ] Let `funcbench` run on Sole-tenant nodes\r\n\r\nOnce it's merge, we also have to update Github actions in main repository","created_at":"2019-12-18T16:34:51Z","updated_at":"2019-12-21T22:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cbfa1f7bb1667e213395a2500c309df5375f4d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/prombench/pulls/311/commits","review_comments_url":"https://api.github.com/repos/prometheus/prombench/pulls/311/comments","review_comment_url":"https://api.github.com/repos/prometheus/prombench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/prombench/issues/311/comments","statuses_url":"https://api.github.com/repos/prometheus/prombench/statuses/bd4ad54780c4351d880b2bbfc839e3bc1cae5f6e","head":{"label":"nevill:master","ref":"master","sha":"bd4ad54780c4351d880b2bbfc839e3bc1cae5f6e","user":{"login":"nevill","id":114409,"node_id":"MDQ6VXNlcjExNDQwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/114409?v=4","gravatar_id":"","url":"https://api.github.com/users/nevill","html_url":"https://github.com/nevill","followers_url":"https://api.github.com/users/nevill/followers","following_url":"https://api.github.com/users/nevill/following{/other_user}","gists_url":"https://api.github.com/users/nevill/gists{/gist_id}","starred_url":"https://api.github.com/users/nevill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nevill/subscriptions","organizations_url":"https://api.github.com/users/nevill/orgs","repos_url":"https://api.github.com/users/nevill/repos","events_url":"https://api.github.com/users/nevill/events{/privacy}","received_events_url":"https://api.github.com/users/nevill/received_events","type":"User","site_admin":false},"repo":{"id":227304677,"node_id":"MDEwOlJlcG9zaXRvcnkyMjczMDQ2Nzc=","name":"prombench","full_name":"nevill/prombench","private":false,"owner":{"login":"nevill","id":114409,"node_id":"MDQ6VXNlcjExNDQwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/114409?v=4","gravatar_id":"","url":"https://api.github.com/users/nevill","html_url":"https://github.com/nevill","followers_url":"https://api.github.com/users/nevill/followers","following_url":"https://api.github.com/users/nevill/following{/other_user}","gists_url":"https://api.github.com/users/nevill/gists{/gist_id}","starred_url":"https://api.github.com/users/nevill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nevill/subscriptions","organizations_url":"https://api.github.com/users/nevill/orgs","repos_url":"https://api.github.com/users/nevill/repos","events_url":"https://api.github.com/users/nevill/events{/privacy}","received_events_url":"https://api.github.com/users/nevill/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nevill/prombench","description":"Prometheus E2E benchmarking tool","fork":true,"url":"https://api.github.com/repos/nevill/prombench","forks_url":"https://api.github.com/repos/nevill/prombench/forks","keys_url":"https://api.github.com/repos/nevill/prombench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nevill/prombench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nevill/prombench/teams","hooks_url":"https://api.github.com/repos/nevill/prombench/hooks","issue_events_url":"https://api.github.com/repos/nevill/prombench/issues/events{/number}","events_url":"https://api.github.com/repos/nevill/prombench/events","assignees_url":"https://api.github.com/repos/nevill/prombench/assignees{/user}","branches_url":"https://api.github.com/repos/nevill/prombench/branches{/branch}","tags_url":"https://api.github.com/repos/nevill/prombench/tags","blobs_url":"https://api.github.com/repos/nevill/prombench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nevill/prombench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nevill/prombench/git/refs{/sha}","trees_url":"https://api.github.com/repos/nevill/prombench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nevill/prombench/statuses/{sha}","languages_url":"https://api.github.com/repos/nevill/prombench/languages","stargazers_url":"https://api.github.com/repos/nevill/prombench/stargazers","contributors_url":"https://api.github.com/repos/nevill/prombench/contributors","subscribers_url":"https://api.github.com/repos/nevill/prombench/subscribers","subscription_url":"https://api.github.com/repos/nevill/prombench/subscription","commits_url":"https://api.github.com/repos/nevill/prombench/commits{/sha}","git_commits_url":"https://api.github.com/repos/nevill/prombench/git/commits{/sha}","comments_url":"https://api.github.com/repos/nevill/prombench/comments{/number}","issue_comment_url":"https://api.github.com/repos/nevill/prombench/issues/comments{/number}","contents_url":"https://api.github.com/repos/nevill/prombench/contents/{+path}","compare_url":"https://api.github.com/repos/nevill/prombench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nevill/prombench/merges","archive_url":"https://api.github.com/repos/nevill/prombench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nevill/prombench/downloads","issues_url":"https://api.github.com/repos/nevill/prombench/issues{/number}","pulls_url":"https://api.github.com/repos/nevill/prombench/pulls{/number}","milestones_url":"https://api.github.com/repos/nevill/prombench/milestones{/number}","notifications_url":"https://api.github.com/repos/nevill/prombench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nevill/prombench/labels{/name}","releases_url":"https://api.github.com/repos/nevill/prombench/releases{/id}","deployments_url":"https://api.github.com/repos/nevill/prombench/deployments","created_at":"2019-12-11T07:36:42Z","updated_at":"2019-12-19T13:02:46Z","pushed_at":"2019-12-19T13:02:44Z","git_url":"git://github.com/nevill/prombench.git","ssh_url":"git@github.com:nevill/prombench.git","clone_url":"https://github.com/nevill/prombench.git","svn_url":"https://github.com/nevill/prombench","homepage":null,"size":7229,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"ef0e09c928de60d4c14db39306003ef408f9a580","user":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":80425943,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQyNTk0Mw==","name":"prombench","full_name":"prometheus/prombench","private":false,"owner":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prometheus/prombench","description":"Prometheus E2E benchmarking tool","fork":false,"url":"https://api.github.com/repos/prometheus/prombench","forks_url":"https://api.github.com/repos/prometheus/prombench/forks","keys_url":"https://api.github.com/repos/prometheus/prombench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/prombench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/prombench/teams","hooks_url":"https://api.github.com/repos/prometheus/prombench/hooks","issue_events_url":"https://api.github.com/repos/prometheus/prombench/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/prombench/events","assignees_url":"https://api.github.com/repos/prometheus/prombench/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/prombench/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/prombench/tags","blobs_url":"https://api.github.com/repos/prometheus/prombench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/prombench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/prombench/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/prombench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/prombench/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/prombench/languages","stargazers_url":"https://api.github.com/repos/prometheus/prombench/stargazers","contributors_url":"https://api.github.com/repos/prometheus/prombench/contributors","subscribers_url":"https://api.github.com/repos/prometheus/prombench/subscribers","subscription_url":"https://api.github.com/repos/prometheus/prombench/subscription","commits_url":"https://api.github.com/repos/prometheus/prombench/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/prombench/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/prombench/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/prombench/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/prombench/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/prombench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/prombench/merges","archive_url":"https://api.github.com/repos/prometheus/prombench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/prombench/downloads","issues_url":"https://api.github.com/repos/prometheus/prombench/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/prombench/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/prombench/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/prombench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/prombench/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/prombench/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/prombench/deployments","created_at":"2017-01-30T13:57:29Z","updated_at":"2019-12-20T20:29:02Z","pushed_at":"2019-12-21T11:38:33Z","git_url":"git://github.com/prometheus/prombench.git","ssh_url":"git@github.com:prometheus/prombench.git","clone_url":"https://github.com/prometheus/prombench.git","svn_url":"https://github.com/prometheus/prombench","homepage":null,"size":7224,"stargazers_count":79,"watchers_count":79,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":32,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/prombench/pulls/311"},"html":{"href":"https://github.com/prometheus/prombench/pull/311"},"issue":{"href":"https://api.github.com/repos/prometheus/prombench/issues/311"},"comments":{"href":"https://api.github.com/repos/prometheus/prombench/issues/311/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/prombench/pulls/311/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/prombench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/prombench/pulls/311/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/prombench/statuses/bd4ad54780c4351d880b2bbfc839e3bc1cae5f6e"}},"author_association":"NONE"}}
|
{
"id": 80425943,
"name": "prometheus/prombench",
"url": "https://api.github.com/repos/prometheus/prombench"
}
|
{
"id": 114409,
"login": "nevill",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/114409?",
"url": "https://api.github.com/users/nevill"
}
|
{
"id": 3380462,
"login": "prometheus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3380462?",
"url": "https://api.github.com/orgs/prometheus"
}
| 2019-12-21T22:38:48 |
11141420886
|
{"actor":{"display_login":"nevill"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/LLK/scratch-vm/pulls/comments/325400562","pull_request_review_id":289565541,"id":325400562,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNTQwMDU2Mg==","diff_hunk":"@@ -1219,10 +1219,24 @@ class Runtime extends EventEmitter {\n // Sanitize the placeholder to ensure valid XML\n placeholder = placeholder.replace(/[<\"&]/, '_');\n \n- const argJSON = {\n- type: 'input_value',\n- name: placeholder\n- };\n+ const iconURI = context.blockInfo.arguments[placeholder].iconURI;","path":"src/engine/runtime.js","position":8,"original_position":8,"commit_id":"7af9f92138592eef78278c039191ee5cf1630c5f","original_commit_id":"7af9f92138592eef78278c039191ee5cf1630c5f","user":{"login":"kchadha","id":1786240,"node_id":"MDQ6VXNlcjE3ODYyNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1786240?v=4","gravatar_id":"","url":"https://api.github.com/users/kchadha","html_url":"https://github.com/kchadha","followers_url":"https://api.github.com/users/kchadha/followers","following_url":"https://api.github.com/users/kchadha/following{/other_user}","gists_url":"https://api.github.com/users/kchadha/gists{/gist_id}","starred_url":"https://api.github.com/users/kchadha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchadha/subscriptions","organizations_url":"https://api.github.com/users/kchadha/orgs","repos_url":"https://api.github.com/users/kchadha/repos","events_url":"https://api.github.com/users/kchadha/events{/privacy}","received_events_url":"https://api.github.com/users/kchadha/received_events","type":"User","site_admin":false},"body":"I am also a little concerned about this approach to specifying an image field from an extension spec design perspective in general. Whether or not `field_image` is used in place of `input_value` should be determined by the argument type as opposed to whether a regular argument has an additional `iconURI` property provided.","created_at":"2019-09-17T21:47:38Z","updated_at":"2019-09-17T21:47:39Z","html_url":"https://github.com/LLK/scratch-vm/pull/2259#discussion_r325400562","pull_request_url":"https://api.github.com/repos/LLK/scratch-vm/pulls/2259","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/comments/325400562"},"html":{"href":"https://github.com/LLK/scratch-vm/pull/2259#discussion_r325400562"},"pull_request":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/2259"}},"in_reply_to_id":325396897},"pull_request":{"url":"https://api.github.com/repos/LLK/scratch-vm/pulls/2259","id":306887835,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2ODg3ODM1","html_url":"https://github.com/LLK/scratch-vm/pull/2259","diff_url":"https://github.com/LLK/scratch-vm/pull/2259.diff","patch_url":"https://github.com/LLK/scratch-vm/pull/2259.patch","issue_url":"https://api.github.com/repos/LLK/scratch-vm/issues/2259","number":2259,"state":"open","locked":false,"title":"Image as value support","user":{"login":"asnoba","id":361101,"node_id":"MDQ6VXNlcjM2MTEwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/361101?v=4","gravatar_id":"","url":"https://api.github.com/users/asnoba","html_url":"https://github.com/asnoba","followers_url":"https://api.github.com/users/asnoba/followers","following_url":"https://api.github.com/users/asnoba/following{/other_user}","gists_url":"https://api.github.com/users/asnoba/gists{/gist_id}","starred_url":"https://api.github.com/users/asnoba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asnoba/subscriptions","organizations_url":"https://api.github.com/users/asnoba/orgs","repos_url":"https://api.github.com/users/asnoba/repos","events_url":"https://api.github.com/users/asnoba/events{/privacy}","received_events_url":"https://api.github.com/users/asnoba/received_events","type":"User","site_admin":false},"body":"### Proposed Changes\r\nWhen a `iconURI` is present use `field_image` instead of `field_value`.\r\n\r\n### Reason for Changes\r\nWhen a value need a visual representation in form of an image.","created_at":"2019-08-13T12:40:06Z","updated_at":"2019-09-17T21:47:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4504bc24b41aca2e0b6db5bbddffe3363fb7cf8","assignee":{"login":"kchadha","id":1786240,"node_id":"MDQ6VXNlcjE3ODYyNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1786240?v=4","gravatar_id":"","url":"https://api.github.com/users/kchadha","html_url":"https://github.com/kchadha","followers_url":"https://api.github.com/users/kchadha/followers","following_url":"https://api.github.com/users/kchadha/following{/other_user}","gists_url":"https://api.github.com/users/kchadha/gists{/gist_id}","starred_url":"https://api.github.com/users/kchadha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchadha/subscriptions","organizations_url":"https://api.github.com/users/kchadha/orgs","repos_url":"https://api.github.com/users/kchadha/repos","events_url":"https://api.github.com/users/kchadha/events{/privacy}","received_events_url":"https://api.github.com/users/kchadha/received_events","type":"User","site_admin":false},"assignees":[{"login":"kchadha","id":1786240,"node_id":"MDQ6VXNlcjE3ODYyNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1786240?v=4","gravatar_id":"","url":"https://api.github.com/users/kchadha","html_url":"https://github.com/kchadha","followers_url":"https://api.github.com/users/kchadha/followers","following_url":"https://api.github.com/users/kchadha/following{/other_user}","gists_url":"https://api.github.com/users/kchadha/gists{/gist_id}","starred_url":"https://api.github.com/users/kchadha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchadha/subscriptions","organizations_url":"https://api.github.com/users/kchadha/orgs","repos_url":"https://api.github.com/users/kchadha/repos","events_url":"https://api.github.com/users/kchadha/events{/privacy}","received_events_url":"https://api.github.com/users/kchadha/received_events","type":"User","site_admin":false},{"login":"cwillisf","id":7019101,"node_id":"MDQ6VXNlcjcwMTkxMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/7019101?v=4","gravatar_id":"","url":"https://api.github.com/users/cwillisf","html_url":"https://github.com/cwillisf","followers_url":"https://api.github.com/users/cwillisf/followers","following_url":"https://api.github.com/users/cwillisf/following{/other_user}","gists_url":"https://api.github.com/users/cwillisf/gists{/gist_id}","starred_url":"https://api.github.com/users/cwillisf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwillisf/subscriptions","organizations_url":"https://api.github.com/users/cwillisf/orgs","repos_url":"https://api.github.com/users/cwillisf/repos","events_url":"https://api.github.com/users/cwillisf/events{/privacy}","received_events_url":"https://api.github.com/users/cwillisf/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":364575324,"node_id":"MDU6TGFiZWwzNjQ1NzUzMjQ=","url":"https://api.github.com/repos/LLK/scratch-vm/labels/pr%20-%20needs%20review","name":"pr - needs review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/LLK/scratch-vm/milestones/48","html_url":"https://github.com/LLK/scratch-vm/milestone/48","labels_url":"https://api.github.com/repos/LLK/scratch-vm/milestones/48/labels","id":4029595,"node_id":"MDk6TWlsZXN0b25lNDAyOTU5NQ==","number":48,"title":"September 2019","description":"","creator":{"login":"thisandagain","id":747641,"node_id":"MDQ6VXNlcjc0NzY0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/747641?v=4","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":1,"state":"open","created_at":"2019-02-04T20:49:47Z","updated_at":"2019-09-17T19:20:52Z","due_on":"2019-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/LLK/scratch-vm/pulls/2259/commits","review_comments_url":"https://api.github.com/repos/LLK/scratch-vm/pulls/2259/comments","review_comment_url":"https://api.github.com/repos/LLK/scratch-vm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLK/scratch-vm/issues/2259/comments","statuses_url":"https://api.github.com/repos/LLK/scratch-vm/statuses/7af9f92138592eef78278c039191ee5cf1630c5f","head":{"label":"asnoba:develop","ref":"develop","sha":"7af9f92138592eef78278c039191ee5cf1630c5f","user":{"login":"asnoba","id":361101,"node_id":"MDQ6VXNlcjM2MTEwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/361101?v=4","gravatar_id":"","url":"https://api.github.com/users/asnoba","html_url":"https://github.com/asnoba","followers_url":"https://api.github.com/users/asnoba/followers","following_url":"https://api.github.com/users/asnoba/following{/other_user}","gists_url":"https://api.github.com/users/asnoba/gists{/gist_id}","starred_url":"https://api.github.com/users/asnoba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asnoba/subscriptions","organizations_url":"https://api.github.com/users/asnoba/orgs","repos_url":"https://api.github.com/users/asnoba/repos","events_url":"https://api.github.com/users/asnoba/events{/privacy}","received_events_url":"https://api.github.com/users/asnoba/received_events","type":"User","site_admin":false},"repo":{"id":202136253,"node_id":"MDEwOlJlcG9zaXRvcnkyMDIxMzYyNTM=","name":"scratch-vm","full_name":"asnoba/scratch-vm","private":false,"owner":{"login":"asnoba","id":361101,"node_id":"MDQ6VXNlcjM2MTEwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/361101?v=4","gravatar_id":"","url":"https://api.github.com/users/asnoba","html_url":"https://github.com/asnoba","followers_url":"https://api.github.com/users/asnoba/followers","following_url":"https://api.github.com/users/asnoba/following{/other_user}","gists_url":"https://api.github.com/users/asnoba/gists{/gist_id}","starred_url":"https://api.github.com/users/asnoba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asnoba/subscriptions","organizations_url":"https://api.github.com/users/asnoba/orgs","repos_url":"https://api.github.com/users/asnoba/repos","events_url":"https://api.github.com/users/asnoba/events{/privacy}","received_events_url":"https://api.github.com/users/asnoba/received_events","type":"User","site_admin":false},"html_url":"https://github.com/asnoba/scratch-vm","description":"Virtual Machine used to represent, run, and maintain the state of programs for Scratch 3.0","fork":true,"url":"https://api.github.com/repos/asnoba/scratch-vm","forks_url":"https://api.github.com/repos/asnoba/scratch-vm/forks","keys_url":"https://api.github.com/repos/asnoba/scratch-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asnoba/scratch-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asnoba/scratch-vm/teams","hooks_url":"https://api.github.com/repos/asnoba/scratch-vm/hooks","issue_events_url":"https://api.github.com/repos/asnoba/scratch-vm/issues/events{/number}","events_url":"https://api.github.com/repos/asnoba/scratch-vm/events","assignees_url":"https://api.github.com/repos/asnoba/scratch-vm/assignees{/user}","branches_url":"https://api.github.com/repos/asnoba/scratch-vm/branches{/branch}","tags_url":"https://api.github.com/repos/asnoba/scratch-vm/tags","blobs_url":"https://api.github.com/repos/asnoba/scratch-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asnoba/scratch-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asnoba/scratch-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/asnoba/scratch-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asnoba/scratch-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/asnoba/scratch-vm/languages","stargazers_url":"https://api.github.com/repos/asnoba/scratch-vm/stargazers","contributors_url":"https://api.github.com/repos/asnoba/scratch-vm/contributors","subscribers_url":"https://api.github.com/repos/asnoba/scratch-vm/subscribers","subscription_url":"https://api.github.com/repos/asnoba/scratch-vm/subscription","commits_url":"https://api.github.com/repos/asnoba/scratch-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/asnoba/scratch-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/asnoba/scratch-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/asnoba/scratch-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/asnoba/scratch-vm/contents/{+path}","compare_url":"https://api.github.com/repos/asnoba/scratch-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asnoba/scratch-vm/merges","archive_url":"https://api.github.com/repos/asnoba/scratch-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asnoba/scratch-vm/downloads","issues_url":"https://api.github.com/repos/asnoba/scratch-vm/issues{/number}","pulls_url":"https://api.github.com/repos/asnoba/scratch-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/asnoba/scratch-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/asnoba/scratch-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asnoba/scratch-vm/labels{/name}","releases_url":"https://api.github.com/repos/asnoba/scratch-vm/releases{/id}","deployments_url":"https://api.github.com/repos/asnoba/scratch-vm/deployments","created_at":"2019-08-13T12:09:19Z","updated_at":"2019-08-13T12:20:16Z","pushed_at":"2019-08-13T12:20:14Z","git_url":"git://github.com/asnoba/scratch-vm.git","ssh_url":"git@github.com:asnoba/scratch-vm.git","clone_url":"https://github.com/asnoba/scratch-vm.git","svn_url":"https://github.com/asnoba/scratch-vm","homepage":"http://llk.github.io/scratch-vm","size":316511,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLK:develop","ref":"develop","sha":"33ef283787d4ea9a90c3d0d069a6b97dee24f51b","user":{"login":"LLK","id":3420800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3420800?v=4","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"repo":{"id":55796146,"node_id":"MDEwOlJlcG9zaXRvcnk1NTc5NjE0Ng==","name":"scratch-vm","full_name":"LLK/scratch-vm","private":false,"owner":{"login":"LLK","id":3420800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3420800?v=4","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LLK/scratch-vm","description":"Virtual Machine used to represent, run, and maintain the state of programs for Scratch 3.0","fork":false,"url":"https://api.github.com/repos/LLK/scratch-vm","forks_url":"https://api.github.com/repos/LLK/scratch-vm/forks","keys_url":"https://api.github.com/repos/LLK/scratch-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLK/scratch-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLK/scratch-vm/teams","hooks_url":"https://api.github.com/repos/LLK/scratch-vm/hooks","issue_events_url":"https://api.github.com/repos/LLK/scratch-vm/issues/events{/number}","events_url":"https://api.github.com/repos/LLK/scratch-vm/events","assignees_url":"https://api.github.com/repos/LLK/scratch-vm/assignees{/user}","branches_url":"https://api.github.com/repos/LLK/scratch-vm/branches{/branch}","tags_url":"https://api.github.com/repos/LLK/scratch-vm/tags","blobs_url":"https://api.github.com/repos/LLK/scratch-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLK/scratch-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLK/scratch-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLK/scratch-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLK/scratch-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/LLK/scratch-vm/languages","stargazers_url":"https://api.github.com/repos/LLK/scratch-vm/stargazers","contributors_url":"https://api.github.com/repos/LLK/scratch-vm/contributors","subscribers_url":"https://api.github.com/repos/LLK/scratch-vm/subscribers","subscription_url":"https://api.github.com/repos/LLK/scratch-vm/subscription","commits_url":"https://api.github.com/repos/LLK/scratch-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLK/scratch-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLK/scratch-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLK/scratch-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLK/scratch-vm/contents/{+path}","compare_url":"https://api.github.com/repos/LLK/scratch-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLK/scratch-vm/merges","archive_url":"https://api.github.com/repos/LLK/scratch-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLK/scratch-vm/downloads","issues_url":"https://api.github.com/repos/LLK/scratch-vm/issues{/number}","pulls_url":"https://api.github.com/repos/LLK/scratch-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/LLK/scratch-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/LLK/scratch-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLK/scratch-vm/labels{/name}","releases_url":"https://api.github.com/repos/LLK/scratch-vm/releases{/id}","deployments_url":"https://api.github.com/repos/LLK/scratch-vm/deployments","created_at":"2016-04-08T17:08:04Z","updated_at":"2019-09-17T16:29:43Z","pushed_at":"2019-09-17T16:40:07Z","git_url":"git://github.com/LLK/scratch-vm.git","ssh_url":"git@github.com:LLK/scratch-vm.git","clone_url":"https://github.com/LLK/scratch-vm.git","svn_url":"https://github.com/LLK/scratch-vm","homepage":"http://llk.github.io/scratch-vm","size":316988,"stargazers_count":623,"watchers_count":623,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":571,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":379,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":571,"open_issues":379,"watchers":623,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/2259"},"html":{"href":"https://github.com/LLK/scratch-vm/pull/2259"},"issue":{"href":"https://api.github.com/repos/LLK/scratch-vm/issues/2259"},"comments":{"href":"https://api.github.com/repos/LLK/scratch-vm/issues/2259/comments"},"review_comments":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/2259/comments"},"review_comment":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/2259/commits"},"statuses":{"href":"https://api.github.com/repos/LLK/scratch-vm/statuses/7af9f92138592eef78278c039191ee5cf1630c5f"}},"author_association":"NONE"}}
|
{
"id": 55796146,
"name": "LLK/scratch-vm",
"url": "https://api.github.com/repos/LLK/scratch-vm"
}
|
{
"id": 1786240,
"login": "kchadha",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1786240?",
"url": "https://api.github.com/users/kchadha"
}
|
{
"id": 3420800,
"login": "LLK",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3420800?",
"url": "https://api.github.com/orgs/LLK"
}
| 2019-09-17T21:47:38 |
10437342187
|
{"actor":{"display_login":"kchadha"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/comments/360293855","pull_request_review_id":335152842,"id":360293855,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MDI5Mzg1NQ==","diff_hunk":"@@ -96,4 +102,4 @@ workflows:\n - dredd\n - docker_build:\n requires:\n- - build\n+ - build","path":".circleci/config.yml","position":106,"original_position":106,"commit_id":"029556b2b6d4b28f2902f95f0012e73144e08d0d","original_commit_id":"029556b2b6d4b28f2902f95f0012e73144e08d0d","user":{"login":"gkazakov111","id":46991794,"node_id":"MDQ6VXNlcjQ2OTkxNzk0","avatar_url":"https://avatars1.githubusercontent.com/u/46991794?v=4","gravatar_id":"","url":"https://api.github.com/users/gkazakov111","html_url":"https://github.com/gkazakov111","followers_url":"https://api.github.com/users/gkazakov111/followers","following_url":"https://api.github.com/users/gkazakov111/following{/other_user}","gists_url":"https://api.github.com/users/gkazakov111/gists{/gist_id}","starred_url":"https://api.github.com/users/gkazakov111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkazakov111/subscriptions","organizations_url":"https://api.github.com/users/gkazakov111/orgs","repos_url":"https://api.github.com/users/gkazakov111/repos","events_url":"https://api.github.com/users/gkazakov111/events{/privacy}","received_events_url":"https://api.github.com/users/gkazakov111/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2019-12-20T09:37:32Z","updated_at":"2019-12-20T09:37:33Z","html_url":"https://github.com/Financial-Times/content-rw-neo4j/pull/37#discussion_r360293855","pull_request_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/37","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/comments/360293855"},"html":{"href":"https://github.com/Financial-Times/content-rw-neo4j/pull/37#discussion_r360293855"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/37"}},"in_reply_to_id":360291003},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/37","id":353625405,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzNjI1NDA1","html_url":"https://github.com/Financial-Times/content-rw-neo4j/pull/37","diff_url":"https://github.com/Financial-Times/content-rw-neo4j/pull/37.diff","patch_url":"https://github.com/Financial-Times/content-rw-neo4j/pull/37.patch","issue_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues/37","number":37,"state":"open","locked":false,"title":"UPPSF-666-update-docker-image","user":{"login":"gkazakov111","id":46991794,"node_id":"MDQ6VXNlcjQ2OTkxNzk0","avatar_url":"https://avatars1.githubusercontent.com/u/46991794?v=4","gravatar_id":"","url":"https://api.github.com/users/gkazakov111","html_url":"https://github.com/gkazakov111","followers_url":"https://api.github.com/users/gkazakov111/followers","following_url":"https://api.github.com/users/gkazakov111/following{/other_user}","gists_url":"https://api.github.com/users/gkazakov111/gists{/gist_id}","starred_url":"https://api.github.com/users/gkazakov111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkazakov111/subscriptions","organizations_url":"https://api.github.com/users/gkazakov111/orgs","repos_url":"https://api.github.com/users/gkazakov111/repos","events_url":"https://api.github.com/users/gkazakov111/events{/privacy}","received_events_url":"https://api.github.com/users/gkazakov111/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-16T15:35:41Z","updated_at":"2019-12-20T09:37:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdeed76f6129f8ba5be2156b8bb24468705e555d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/37/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/37/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues/37/comments","statuses_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/statuses/029556b2b6d4b28f2902f95f0012e73144e08d0d","head":{"label":"Financial-Times:fix/UPPSF-666-update-docker-image","ref":"fix/UPPSF-666-update-docker-image","sha":"029556b2b6d4b28f2902f95f0012e73144e08d0d","user":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":50043490,"node_id":"MDEwOlJlcG9zaXRvcnk1MDA0MzQ5MA==","name":"content-rw-neo4j","full_name":"Financial-Times/content-rw-neo4j","private":false,"owner":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Financial-Times/content-rw-neo4j","description":null,"fork":false,"url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j","forks_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/forks","keys_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/teams","hooks_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/events","assignees_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/tags","blobs_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/subscription","commits_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/merges","archive_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/downloads","issues_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/deployments","created_at":"2016-01-20T16:33:49Z","updated_at":"2019-04-17T08:06:45Z","pushed_at":"2019-12-19T16:35:04Z","git_url":"git://github.com/Financial-Times/content-rw-neo4j.git","ssh_url":"git@github.com:Financial-Times/content-rw-neo4j.git","clone_url":"https://github.com/Financial-Times/content-rw-neo4j.git","svn_url":"https://github.com/Financial-Times/content-rw-neo4j","homepage":null,"size":12077,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"a8b4c6720d8e72c3eeb1fb22ff0138b6ae20e31f","user":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":50043490,"node_id":"MDEwOlJlcG9zaXRvcnk1MDA0MzQ5MA==","name":"content-rw-neo4j","full_name":"Financial-Times/content-rw-neo4j","private":false,"owner":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Financial-Times/content-rw-neo4j","description":null,"fork":false,"url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j","forks_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/forks","keys_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/teams","hooks_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/events","assignees_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/tags","blobs_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/subscription","commits_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/merges","archive_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/downloads","issues_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/deployments","created_at":"2016-01-20T16:33:49Z","updated_at":"2019-04-17T08:06:45Z","pushed_at":"2019-12-19T16:35:04Z","git_url":"git://github.com/Financial-Times/content-rw-neo4j.git","ssh_url":"git@github.com:Financial-Times/content-rw-neo4j.git","clone_url":"https://github.com/Financial-Times/content-rw-neo4j.git","svn_url":"https://github.com/Financial-Times/content-rw-neo4j","homepage":null,"size":12077,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/37"},"html":{"href":"https://github.com/Financial-Times/content-rw-neo4j/pull/37"},"issue":{"href":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues/37"},"comments":{"href":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/content-rw-neo4j/statuses/029556b2b6d4b28f2902f95f0012e73144e08d0d"}},"author_association":"NONE"}}
|
{
"id": 50043490,
"name": "Financial-Times/content-rw-neo4j",
"url": "https://api.github.com/repos/Financial-Times/content-rw-neo4j"
}
|
{
"id": 46991794,
"login": "gkazakov111",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46991794?",
"url": "https://api.github.com/users/gkazakov111"
}
|
{
"id": 3502508,
"login": "Financial-Times",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3502508?",
"url": "https://api.github.com/orgs/Financial-Times"
}
| 2019-12-20T09:37:32 |
11133538933
|
{"actor":{"display_login":"gkazakov111"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/256368472","pull_request_review_id":203176017,"id":256368472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjM2ODQ3Mg==","diff_hunk":"@@ -307,10 +307,15 @@ const mock7 = jest.fn((arg: number) => arg);\n const mock8: jest.Mock = jest.fn((arg: number) => arg);\n // $ExpectType Mock<Promise<boolean>, [number, string, {}, [], boolean]>\n const mock9 = jest.fn((a: number, _b: string, _c: {}, _iReallyDontCare: [], _makeItStop: boolean) => Promise.resolve(_makeItStop));\n-// $ExpectType Mock<never, [never]>\n-const mock10 = jest.fn((arg: never) => { throw new Error(arg); });\n+// $ExpectType Mock<never, []>\n+const mock10 = jest.fn(() => { throw new Error(); });\n // $ExpectType Mock<unknown, [unknown]>\n const mock11 = jest.fn((arg: unknown) => arg);\n+interface TestApi {\n+ test(x: number): string;\n+}\n+// $ExpectType Mock<string, [number]>\n+const mock12 = jest.fn<ReturnType<TestApi[\"test\"]>, ArgsType<TestApi[\"test\"]>>();","path":"types/jest/jest-tests.ts","position":14,"original_position":14,"commit_id":"a76bd2230a7d0f18fe36d70118761e4c298ced1b","original_commit_id":"a76bd2230a7d0f18fe36d70118761e4c298ced1b","user":{"login":"jerico-dev","id":138091,"node_id":"MDQ6VXNlcjEzODA5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/138091?v=4","gravatar_id":"","url":"https://api.github.com/users/jerico-dev","html_url":"https://github.com/jerico-dev","followers_url":"https://api.github.com/users/jerico-dev/followers","following_url":"https://api.github.com/users/jerico-dev/following{/other_user}","gists_url":"https://api.github.com/users/jerico-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jerico-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerico-dev/subscriptions","organizations_url":"https://api.github.com/users/jerico-dev/orgs","repos_url":"https://api.github.com/users/jerico-dev/repos","events_url":"https://api.github.com/users/jerico-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jerico-dev/received_events","type":"User","site_admin":false},"body":"It doesn't seem to be a problem as the only change was that ArgsType was moved inside the jest namespace. I'm referencing it within the same namespace so it doesn't need the jest. prefix (tested).","created_at":"2019-02-13T12:13:31Z","updated_at":"2019-02-13T12:13:31Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32864#discussion_r256368472","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32864","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/256368472"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32864#discussion_r256368472"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32864"}},"in_reply_to_id":255762042},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32864","id":251174763,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxMTc0NzYz","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32864","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32864.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32864.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/32864","number":32864,"state":"open","locked":false,"title":"[jest] fix jest.fn to match spec","user":{"login":"jerico-dev","id":138091,"node_id":"MDQ6VXNlcjEzODA5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/138091?v=4","gravatar_id":"","url":"https://api.github.com/users/jerico-dev","html_url":"https://github.com/jerico-dev","followers_url":"https://api.github.com/users/jerico-dev/followers","following_url":"https://api.github.com/users/jerico-dev/following{/other_user}","gists_url":"https://api.github.com/users/jerico-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jerico-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerico-dev/subscriptions","organizations_url":"https://api.github.com/users/jerico-dev/orgs","repos_url":"https://api.github.com/users/jerico-dev/repos","events_url":"https://api.github.com/users/jerico-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jerico-dev/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://jestjs.io/docs/en/jest-object#jestfnimplementation => \"optionally takes a mock implementation\"\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nfixes #32863","created_at":"2019-02-07T16:13:00Z","updated_at":"2019-02-13T12:13:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88a95fff23c9aa3aec682f0a877e11f321d14bda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":644152277,"node_id":"MDU6TGFiZWw2NDQxNTIyNzc=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:LGTM","name":"Merge:LGTM","color":"0e8a16","default":false},{"id":586177063,"node_id":"MDU6TGFiZWw1ODYxNzcwNjM=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Other%20Approved","name":"Other Approved","color":"006b75","default":false},{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false},{"id":395679059,"node_id":"MDU6TGFiZWwzOTU2NzkwNTk=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32864/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32864/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/32864/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/a76bd2230a7d0f18fe36d70118761e4c298ced1b","head":{"label":"jerico-dev:fix-jest-fn","ref":"fix-jest-fn","sha":"a76bd2230a7d0f18fe36d70118761e4c298ced1b","user":{"login":"jerico-dev","id":138091,"node_id":"MDQ6VXNlcjEzODA5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/138091?v=4","gravatar_id":"","url":"https://api.github.com/users/jerico-dev","html_url":"https://github.com/jerico-dev","followers_url":"https://api.github.com/users/jerico-dev/followers","following_url":"https://api.github.com/users/jerico-dev/following{/other_user}","gists_url":"https://api.github.com/users/jerico-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jerico-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerico-dev/subscriptions","organizations_url":"https://api.github.com/users/jerico-dev/orgs","repos_url":"https://api.github.com/users/jerico-dev/repos","events_url":"https://api.github.com/users/jerico-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jerico-dev/received_events","type":"User","site_admin":false},"repo":{"id":169583121,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk1ODMxMjE=","name":"DefinitelyTyped","full_name":"jerico-dev/DefinitelyTyped","private":false,"owner":{"login":"jerico-dev","id":138091,"node_id":"MDQ6VXNlcjEzODA5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/138091?v=4","gravatar_id":"","url":"https://api.github.com/users/jerico-dev","html_url":"https://github.com/jerico-dev","followers_url":"https://api.github.com/users/jerico-dev/followers","following_url":"https://api.github.com/users/jerico-dev/following{/other_user}","gists_url":"https://api.github.com/users/jerico-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jerico-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerico-dev/subscriptions","organizations_url":"https://api.github.com/users/jerico-dev/orgs","repos_url":"https://api.github.com/users/jerico-dev/repos","events_url":"https://api.github.com/users/jerico-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jerico-dev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jerico-dev/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped","forks_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/jerico-dev/DefinitelyTyped/deployments","created_at":"2019-02-07T14:18:44Z","updated_at":"2019-02-07T14:19:22Z","pushed_at":"2019-02-12T07:58:50Z","git_url":"git://github.com/jerico-dev/DefinitelyTyped.git","ssh_url":"git@github.com:jerico-dev/DefinitelyTyped.git","clone_url":"https://github.com/jerico-dev/DefinitelyTyped.git","svn_url":"https://github.com/jerico-dev/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":430662,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"510f81374c99b2b985400faa92af10444c3b8127","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2019-02-13T10:49:39Z","pushed_at":"2019-02-13T12:05:38Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":431871,"stargazers_count":20352,"watchers_count":20352,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16411,"mirror_url":null,"archived":false,"open_issues_count":2631,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16411,"open_issues":2631,"watchers":20352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32864"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32864"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/32864"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/32864/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32864/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32864/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/a76bd2230a7d0f18fe36d70118761e4c298ced1b"}},"author_association":"NONE"}}
|
{
"id": 6093316,
"name": "DefinitelyTyped/DefinitelyTyped",
"url": "https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped"
}
|
{
"id": 138091,
"login": "jerico-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/138091?",
"url": "https://api.github.com/users/jerico-dev"
}
|
{
"id": 3637556,
"login": "DefinitelyTyped",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3637556?",
"url": "https://api.github.com/orgs/DefinitelyTyped"
}
| 2019-02-13T12:13:31 |
9059684629
|
{"actor":{"display_login":"jerico-dev"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/298580885","pull_request_review_id":255750724,"id":298580885,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5ODU4MDg4NQ==","diff_hunk":"@@ -4,7 +4,7 @@\n // Mathias Lorenzen <https://github.com/ffMathy>\n // Leonardo Lombardi <https://github.com/ltlombardi>\n // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n-// TypeScript Version: 2.3\n+// TypeScript Version: 2.8","path":"types/knockout.mapping/index.d.ts","position":5,"original_position":5,"commit_id":"caf13dca525d05728a379b76d6061871c10a8f6b","original_commit_id":"caf13dca525d05728a379b76d6061871c10a8f6b","user":{"login":"ltlombardi","id":898124,"node_id":"MDQ6VXNlcjg5ODEyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/898124?v=4","gravatar_id":"","url":"https://api.github.com/users/ltlombardi","html_url":"https://github.com/ltlombardi","followers_url":"https://api.github.com/users/ltlombardi/followers","following_url":"https://api.github.com/users/ltlombardi/following{/other_user}","gists_url":"https://api.github.com/users/ltlombardi/gists{/gist_id}","starred_url":"https://api.github.com/users/ltlombardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltlombardi/subscriptions","organizations_url":"https://api.github.com/users/ltlombardi/orgs","repos_url":"https://api.github.com/users/ltlombardi/repos","events_url":"https://api.github.com/users/ltlombardi/events{/privacy}","received_events_url":"https://api.github.com/users/ltlombardi/received_events","type":"User","site_admin":false},"body":"The problem I see is that it only works in TS 3.1 or above. So people with TS 2.8 thru 3.0 would be getting the older knockout.mapping file. Basically the version present in the PR will only be available to TS 3.1 users or above. \r\n\r\nI guess this is acceptable, but I really believe this is not the way to do it.\r\n\r\nMy reasoning:\r\n1) If the project doesn't use a package delivery system, the dev already included the `.d.ts` file in it's project repository, so this PR has no harm for the legacy project and it's developer.\r\n2) If the project uses Nuget, again, this changes won't affect him. He is stuck to the typings version in his projects.\r\n3) If the project uses NPM, with a specific version set, again, this changes won't affect him. He is stuck to the typings version in his projects.\r\n4) If the project uses NPM, without any version established, then this is the devs fault / decision to use the latest version and deal with the consequences. \r\n\r\nSo my conclusion is that this won't really harm anyone already using knockout.mapping. \r\nSomeone that will start to use now, will be actively developing on a legacy code... so It won't really be legacy, will it? That person would be more than better off upping the TSC version. But again he is not required, he can just set a specific version in NPM packages.json and be happy.\r\n","created_at":"2019-06-28T12:54:18Z","updated_at":"2019-06-28T12:54:18Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/36025#discussion_r298580885","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/36025","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/298580885"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/36025#discussion_r298580885"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/36025"}},"in_reply_to_id":297311315},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/36025","id":286185270,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2MTg1Mjcw","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/36025","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/36025.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/36025.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/36025","number":36025,"state":"open","locked":false,"title":"Knockout mapping return properly typed with TS 2.8","user":{"login":"ltlombardi","id":898124,"node_id":"MDQ6VXNlcjg5ODEyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/898124?v=4","gravatar_id":"","url":"https://api.github.com/users/ltlombardi","html_url":"https://github.com/ltlombardi","followers_url":"https://api.github.com/users/ltlombardi/followers","following_url":"https://api.github.com/users/ltlombardi/following{/other_user}","gists_url":"https://api.github.com/users/ltlombardi/gists{/gist_id}","starred_url":"https://api.github.com/users/ltlombardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltlombardi/subscriptions","organizations_url":"https://api.github.com/users/ltlombardi/orgs","repos_url":"https://api.github.com/users/ltlombardi/repos","events_url":"https://api.github.com/users/ltlombardi/events{/privacy}","received_events_url":"https://api.github.com/users/ltlombardi/received_events","type":"User","site_admin":false},"body":"- Reduction of duplication due to Conditional Typing present in TS 2.8\r\n- To allow the KnockoutObservableType<T> to work properly, it was necessary to update to TS 2.8.\r\nNow, the methods that return a mapped object, if the object source is typed, the return type will also be typed properly.\r\n- Changed some tslint rules to improve code.\r\n- Small fixes\r\n\r\n- Removed knockout.mapping plugin tests present in father project (knockout). It should not have dependency in it's children. It's the other way around.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.) // failing due to other projects\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).","created_at":"2019-06-07T13:19:05Z","updated_at":"2019-06-28T12:54:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f4d56fc88f7afa97dd21617e939d9211ca4d4fd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"borisyankov","id":867242,"node_id":"MDQ6VXNlcjg2NzI0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/867242?v=4","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":798737478,"node_id":"MDU6TGFiZWw3OTg3Mzc0Nzg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Author%20is%20Owner","name":"Author is Owner","color":"6fede0","default":false},{"id":395679059,"node_id":"MDU6TGFiZWwzOTU2NzkwNTk=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/36025/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/36025/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/36025/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/caf13dca525d05728a379b76d6061871c10a8f6b","head":{"label":"ltlombardi:knockout-mapping-return-properly-typed","ref":"knockout-mapping-return-properly-typed","sha":"caf13dca525d05728a379b76d6061871c10a8f6b","user":{"login":"ltlombardi","id":898124,"node_id":"MDQ6VXNlcjg5ODEyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/898124?v=4","gravatar_id":"","url":"https://api.github.com/users/ltlombardi","html_url":"https://github.com/ltlombardi","followers_url":"https://api.github.com/users/ltlombardi/followers","following_url":"https://api.github.com/users/ltlombardi/following{/other_user}","gists_url":"https://api.github.com/users/ltlombardi/gists{/gist_id}","starred_url":"https://api.github.com/users/ltlombardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltlombardi/subscriptions","organizations_url":"https://api.github.com/users/ltlombardi/orgs","repos_url":"https://api.github.com/users/ltlombardi/repos","events_url":"https://api.github.com/users/ltlombardi/events{/privacy}","received_events_url":"https://api.github.com/users/ltlombardi/received_events","type":"User","site_admin":false},"repo":{"id":145159468,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNTk0Njg=","name":"DefinitelyTyped","full_name":"ltlombardi/DefinitelyTyped","private":false,"owner":{"login":"ltlombardi","id":898124,"node_id":"MDQ6VXNlcjg5ODEyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/898124?v=4","gravatar_id":"","url":"https://api.github.com/users/ltlombardi","html_url":"https://github.com/ltlombardi","followers_url":"https://api.github.com/users/ltlombardi/followers","following_url":"https://api.github.com/users/ltlombardi/following{/other_user}","gists_url":"https://api.github.com/users/ltlombardi/gists{/gist_id}","starred_url":"https://api.github.com/users/ltlombardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltlombardi/subscriptions","organizations_url":"https://api.github.com/users/ltlombardi/orgs","repos_url":"https://api.github.com/users/ltlombardi/repos","events_url":"https://api.github.com/users/ltlombardi/events{/privacy}","received_events_url":"https://api.github.com/users/ltlombardi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ltlombardi/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped","forks_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/ltlombardi/DefinitelyTyped/deployments","created_at":"2018-08-17T19:35:09Z","updated_at":"2018-12-21T11:23:49Z","pushed_at":"2019-06-13T12:58:20Z","git_url":"git://github.com/ltlombardi/DefinitelyTyped.git","ssh_url":"git@github.com:ltlombardi/DefinitelyTyped.git","clone_url":"https://github.com/ltlombardi/DefinitelyTyped.git","svn_url":"https://github.com/ltlombardi/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":470874,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"022dbd5d9115992722c50043b930b2dbafa94b43","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2019-06-28T10:14:05Z","pushed_at":"2019-06-28T12:29:53Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":478640,"stargazers_count":22879,"watchers_count":22879,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17960,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2947,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17960,"open_issues":2947,"watchers":22879,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/36025"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/36025"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/36025"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/36025/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/36025/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/36025/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/caf13dca525d05728a379b76d6061871c10a8f6b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 6093316,
"name": "DefinitelyTyped/DefinitelyTyped",
"url": "https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped"
}
|
{
"id": 898124,
"login": "ltlombardi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/898124?",
"url": "https://api.github.com/users/ltlombardi"
}
|
{
"id": 3637556,
"login": "DefinitelyTyped",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3637556?",
"url": "https://api.github.com/orgs/DefinitelyTyped"
}
| 2019-06-28T12:54:18 |
9913814374
|
{"actor":{"display_login":"ltlombardi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/275128319","pull_request_review_id":226364844,"id":275128319,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTEyODMxOQ==","diff_hunk":"@@ -98,6 +87,37 @@ declare namespace got {\n (url: GotUrl, options: GotBodyOptions<null>): GotPromise<Buffer>;\n }\n \n+ interface GotJSONFn {\n+ (url: GotUrl): GotPromise<any>;\n+ (url: GotUrl, options: GotJSONOptions): GotPromise<any>;\n+ }\n+\n+ type GotInstance<T = GotFn> = T &\n+ Record<'get' | 'post' | 'put' | 'patch' | 'head' | 'delete', T> &\n+ {\n+ stream: GotStreamFn & Record<'get' | 'post' | 'put' | 'patch' | 'head' | 'delete', GotStreamFn>;\n+ extend: GotExtend;\n+ RequestError: typeof RequestError;\n+ ReadError: typeof ReadError;\n+ ParseError: typeof ParseError;\n+ HTTPError: typeof HTTPError;\n+ MaxRedirectsError: typeof MaxRedirectsError;\n+ UnsupportedProtocolError: typeof UnsupportedProtocolError;\n+ CancelError: typeof CancelError;\n+ TimeoutError: typeof TimeoutError;\n+ };\n+\n+ type DefaultGotInstance = GotInstance;","path":"types/got/index.d.ts","position":53,"original_position":53,"commit_id":"4a98006b062812c2cf10d267b1a3769c2e0c23e5","original_commit_id":"4a98006b062812c2cf10d267b1a3769c2e0c23e5","user":{"login":"ikokostya","id":328125,"node_id":"MDQ6VXNlcjMyODEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/328125?v=4","gravatar_id":"","url":"https://api.github.com/users/ikokostya","html_url":"https://github.com/ikokostya","followers_url":"https://api.github.com/users/ikokostya/followers","following_url":"https://api.github.com/users/ikokostya/following{/other_user}","gists_url":"https://api.github.com/users/ikokostya/gists{/gist_id}","starred_url":"https://api.github.com/users/ikokostya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikokostya/subscriptions","organizations_url":"https://api.github.com/users/ikokostya/orgs","repos_url":"https://api.github.com/users/ikokostya/repos","events_url":"https://api.github.com/users/ikokostya/events{/privacy}","received_events_url":"https://api.github.com/users/ikokostya/received_events","type":"User","site_admin":false},"body":"I think the following type aliases are redundant for public use cases:\r\n\r\n* `GotInstance` can be used instead `DefaultGotInstance`.\r\n* `GotInstance<ConcreteType>` can be used instead `JSONGotInstance`.","created_at":"2019-04-13T18:48:48Z","updated_at":"2019-04-13T18:58:27Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32602#discussion_r275128319","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32602","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/275128319"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32602#discussion_r275128319"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32602"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32602","id":248680801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ4NjgwODAx","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32602","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32602.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32602.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/32602","number":32602,"state":"open","locked":false,"title":"Add support for `got.extend`","user":{"login":"wingsbob","id":11092696,"node_id":"MDQ6VXNlcjExMDkyNjk2","avatar_url":"https://avatars3.githubusercontent.com/u/11092696?v=4","gravatar_id":"","url":"https://api.github.com/users/wingsbob","html_url":"https://github.com/wingsbob","followers_url":"https://api.github.com/users/wingsbob/followers","following_url":"https://api.github.com/users/wingsbob/following{/other_user}","gists_url":"https://api.github.com/users/wingsbob/gists{/gist_id}","starred_url":"https://api.github.com/users/wingsbob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingsbob/subscriptions","organizations_url":"https://api.github.com/users/wingsbob/orgs","repos_url":"https://api.github.com/users/wingsbob/repos","events_url":"https://api.github.com/users/wingsbob/events{/privacy}","received_events_url":"https://api.github.com/users/wingsbob/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/sindresorhus/got#gotextendoptions\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nRelates to #29735\r\n","created_at":"2019-01-29T22:29:19Z","updated_at":"2019-04-13T18:58:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc58eb95cca4a0ee5e2fbc1dadebbea4f49f65f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false},{"id":395679059,"node_id":"MDU6TGFiZWwzOTU2NzkwNTk=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32602/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32602/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/32602/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/4a98006b062812c2cf10d267b1a3769c2e0c23e5","head":{"label":"wingsbob:got-extend","ref":"got-extend","sha":"4a98006b062812c2cf10d267b1a3769c2e0c23e5","user":{"login":"wingsbob","id":11092696,"node_id":"MDQ6VXNlcjExMDkyNjk2","avatar_url":"https://avatars3.githubusercontent.com/u/11092696?v=4","gravatar_id":"","url":"https://api.github.com/users/wingsbob","html_url":"https://github.com/wingsbob","followers_url":"https://api.github.com/users/wingsbob/followers","following_url":"https://api.github.com/users/wingsbob/following{/other_user}","gists_url":"https://api.github.com/users/wingsbob/gists{/gist_id}","starred_url":"https://api.github.com/users/wingsbob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingsbob/subscriptions","organizations_url":"https://api.github.com/users/wingsbob/orgs","repos_url":"https://api.github.com/users/wingsbob/repos","events_url":"https://api.github.com/users/wingsbob/events{/privacy}","received_events_url":"https://api.github.com/users/wingsbob/received_events","type":"User","site_admin":false},"repo":{"id":109674291,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2NzQyOTE=","name":"DefinitelyTyped","full_name":"wingsbob/DefinitelyTyped","private":false,"owner":{"login":"wingsbob","id":11092696,"node_id":"MDQ6VXNlcjExMDkyNjk2","avatar_url":"https://avatars3.githubusercontent.com/u/11092696?v=4","gravatar_id":"","url":"https://api.github.com/users/wingsbob","html_url":"https://github.com/wingsbob","followers_url":"https://api.github.com/users/wingsbob/followers","following_url":"https://api.github.com/users/wingsbob/following{/other_user}","gists_url":"https://api.github.com/users/wingsbob/gists{/gist_id}","starred_url":"https://api.github.com/users/wingsbob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingsbob/subscriptions","organizations_url":"https://api.github.com/users/wingsbob/orgs","repos_url":"https://api.github.com/users/wingsbob/repos","events_url":"https://api.github.com/users/wingsbob/events{/privacy}","received_events_url":"https://api.github.com/users/wingsbob/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wingsbob/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/wingsbob/DefinitelyTyped","forks_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/wingsbob/DefinitelyTyped/deployments","created_at":"2017-11-06T09:30:39Z","updated_at":"2019-01-29T22:31:17Z","pushed_at":"2019-01-31T16:43:17Z","git_url":"git://github.com/wingsbob/DefinitelyTyped.git","ssh_url":"git@github.com:wingsbob/DefinitelyTyped.git","clone_url":"https://github.com/wingsbob/DefinitelyTyped.git","svn_url":"https://github.com/wingsbob/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":417228,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"fda6ae2b4f8b652ec6f5ffc006a4297bb4264d3f","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2019-04-13T18:01:33Z","pushed_at":"2019-04-13T12:15:33Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":465877,"stargazers_count":21541,"watchers_count":21541,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17140,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2771,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17140,"open_issues":2771,"watchers":21541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32602"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32602"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/32602"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/32602/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32602/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/32602/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/4a98006b062812c2cf10d267b1a3769c2e0c23e5"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 6093316,
"name": "DefinitelyTyped/DefinitelyTyped",
"url": "https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped"
}
|
{
"id": 328125,
"login": "ikokostya",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/328125?",
"url": "https://api.github.com/users/ikokostya"
}
|
{
"id": 3637556,
"login": "DefinitelyTyped",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3637556?",
"url": "https://api.github.com/orgs/DefinitelyTyped"
}
| 2019-04-13T18:48:48 |
9437926260
|
{"actor":{"display_login":"ikokostya"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jibri/pulls/comments/336695557","pull_request_review_id":304162890,"id":336695557,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjY5NTU1Nw==","diff_hunk":"@@ -161,5 +163,29 @@ internal class ProcessWrapperTest : ShouldSpec() {\n }\n }\n }\n+ \"stopAndWaitFor\" {\n+ should(\"invoke the correct command\") {\n+ val execCaptor = argumentCaptor<String>()\n+ whenever(runtime.exec(execCaptor.capture())).thenReturn(process)\n+ whenever(process.waitFor(any(), any())).thenReturn(true)\n+ processWrapper.stopAndWaitFor(Duration.ofSeconds(10)) shouldBe true\n+ execCaptor.firstValue.let {\n+ it shouldContain \"kill -s SIGINT\"\n+ }\n+ }\n+ \"when the runtime throws IOException\" {\n+ whenever(runtime.exec(anyString())).thenAnswer { throw IOException() }\n+ should(\"handle it correctly\") {\n+ processWrapper.stopAndWaitFor(Duration.ofSeconds(10)) shouldBe false\n+ }\n+\n+ }\n+ \"when the runtime throws RuntimeException\" {\n+ whenever(runtime.exec(anyString())).thenAnswer { throw RuntimeException() }\n+ should(\"handle it correctly\") {\n+ processWrapper.stopAndWaitFor(Duration.ofSeconds(10)) shouldBe false\n+ }\n+ }\n+ }","path":"src/test/kotlin/org/jitsi/jibri/util/ProcessWrapperTest.kt","position":95,"original_position":43,"commit_id":"d152e2774c1961052e4b76e9b947fb1173fe06fa","original_commit_id":"539cb9d6cf05d32fa34305fbc000425f53e9d230","user":{"login":"virtuacoplenny","id":1243084,"node_id":"MDQ6VXNlcjEyNDMwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1243084?v=4","gravatar_id":"","url":"https://api.github.com/users/virtuacoplenny","html_url":"https://github.com/virtuacoplenny","followers_url":"https://api.github.com/users/virtuacoplenny/followers","following_url":"https://api.github.com/users/virtuacoplenny/following{/other_user}","gists_url":"https://api.github.com/users/virtuacoplenny/gists{/gist_id}","starred_url":"https://api.github.com/users/virtuacoplenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtuacoplenny/subscriptions","organizations_url":"https://api.github.com/users/virtuacoplenny/orgs","repos_url":"https://api.github.com/users/virtuacoplenny/repos","events_url":"https://api.github.com/users/virtuacoplenny/events{/privacy}","received_events_url":"https://api.github.com/users/virtuacoplenny/received_events","type":"User","site_admin":false},"body":"destroyForciblyAndWaitFor tests?","created_at":"2019-10-18T22:23:24Z","updated_at":"2019-10-18T22:23:24Z","html_url":"https://github.com/jitsi/jibri/pull/228#discussion_r336695557","pull_request_url":"https://api.github.com/repos/jitsi/jibri/pulls/228","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/comments/336695557"},"html":{"href":"https://github.com/jitsi/jibri/pull/228#discussion_r336695557"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/228"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/jibri/pulls/228","id":329483253,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5NDgzMjUz","html_url":"https://github.com/jitsi/jibri/pull/228","diff_url":"https://github.com/jitsi/jibri/pull/228.diff","patch_url":"https://github.com/jitsi/jibri/pull/228.patch","issue_url":"https://api.github.com/repos/jitsi/jibri/issues/228","number":228,"state":"open","locked":false,"title":"Subprocess stop fixes","user":{"login":"bbaldino","id":4016469,"node_id":"MDQ6VXNlcjQwMTY0Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/4016469?v=4","gravatar_id":"","url":"https://api.github.com/users/bbaldino","html_url":"https://github.com/bbaldino","followers_url":"https://api.github.com/users/bbaldino/followers","following_url":"https://api.github.com/users/bbaldino/following{/other_user}","gists_url":"https://api.github.com/users/bbaldino/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaldino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaldino/subscriptions","organizations_url":"https://api.github.com/users/bbaldino/orgs","repos_url":"https://api.github.com/users/bbaldino/repos","events_url":"https://api.github.com/users/bbaldino/events{/privacy}","received_events_url":"https://api.github.com/users/bbaldino/received_events","type":"User","site_admin":false},"body":"this adds some better handling for a couple exception scenarios around stopping a subprocess","created_at":"2019-10-17T22:11:09Z","updated_at":"2019-10-18T22:23:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d83c9aed510c17d0ab5affe30b9754d4fb1e455d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"damencho","id":3263098,"node_id":"MDQ6VXNlcjMyNjMwOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3263098?v=4","gravatar_id":"","url":"https://api.github.com/users/damencho","html_url":"https://github.com/damencho","followers_url":"https://api.github.com/users/damencho/followers","following_url":"https://api.github.com/users/damencho/following{/other_user}","gists_url":"https://api.github.com/users/damencho/gists{/gist_id}","starred_url":"https://api.github.com/users/damencho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damencho/subscriptions","organizations_url":"https://api.github.com/users/damencho/orgs","repos_url":"https://api.github.com/users/damencho/repos","events_url":"https://api.github.com/users/damencho/events{/privacy}","received_events_url":"https://api.github.com/users/damencho/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jibri/pulls/228/commits","review_comments_url":"https://api.github.com/repos/jitsi/jibri/pulls/228/comments","review_comment_url":"https://api.github.com/repos/jitsi/jibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jibri/issues/228/comments","statuses_url":"https://api.github.com/repos/jitsi/jibri/statuses/d152e2774c1961052e4b76e9b947fb1173fe06fa","head":{"label":"bbaldino:subprocess_stop_fixes","ref":"subprocess_stop_fixes","sha":"d152e2774c1961052e4b76e9b947fb1173fe06fa","user":{"login":"bbaldino","id":4016469,"node_id":"MDQ6VXNlcjQwMTY0Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/4016469?v=4","gravatar_id":"","url":"https://api.github.com/users/bbaldino","html_url":"https://github.com/bbaldino","followers_url":"https://api.github.com/users/bbaldino/followers","following_url":"https://api.github.com/users/bbaldino/following{/other_user}","gists_url":"https://api.github.com/users/bbaldino/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaldino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaldino/subscriptions","organizations_url":"https://api.github.com/users/bbaldino/orgs","repos_url":"https://api.github.com/users/bbaldino/repos","events_url":"https://api.github.com/users/bbaldino/events{/privacy}","received_events_url":"https://api.github.com/users/bbaldino/received_events","type":"User","site_admin":false},"repo":{"id":124580204,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ1ODAyMDQ=","name":"jibri","full_name":"bbaldino/jibri","private":false,"owner":{"login":"bbaldino","id":4016469,"node_id":"MDQ6VXNlcjQwMTY0Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/4016469?v=4","gravatar_id":"","url":"https://api.github.com/users/bbaldino","html_url":"https://github.com/bbaldino","followers_url":"https://api.github.com/users/bbaldino/followers","following_url":"https://api.github.com/users/bbaldino/following{/other_user}","gists_url":"https://api.github.com/users/bbaldino/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaldino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaldino/subscriptions","organizations_url":"https://api.github.com/users/bbaldino/orgs","repos_url":"https://api.github.com/users/bbaldino/repos","events_url":"https://api.github.com/users/bbaldino/events{/privacy}","received_events_url":"https://api.github.com/users/bbaldino/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bbaldino/jibri","description":"Jitsi BRoadcasting Infrastructure","fork":true,"url":"https://api.github.com/repos/bbaldino/jibri","forks_url":"https://api.github.com/repos/bbaldino/jibri/forks","keys_url":"https://api.github.com/repos/bbaldino/jibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbaldino/jibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbaldino/jibri/teams","hooks_url":"https://api.github.com/repos/bbaldino/jibri/hooks","issue_events_url":"https://api.github.com/repos/bbaldino/jibri/issues/events{/number}","events_url":"https://api.github.com/repos/bbaldino/jibri/events","assignees_url":"https://api.github.com/repos/bbaldino/jibri/assignees{/user}","branches_url":"https://api.github.com/repos/bbaldino/jibri/branches{/branch}","tags_url":"https://api.github.com/repos/bbaldino/jibri/tags","blobs_url":"https://api.github.com/repos/bbaldino/jibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbaldino/jibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbaldino/jibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbaldino/jibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbaldino/jibri/statuses/{sha}","languages_url":"https://api.github.com/repos/bbaldino/jibri/languages","stargazers_url":"https://api.github.com/repos/bbaldino/jibri/stargazers","contributors_url":"https://api.github.com/repos/bbaldino/jibri/contributors","subscribers_url":"https://api.github.com/repos/bbaldino/jibri/subscribers","subscription_url":"https://api.github.com/repos/bbaldino/jibri/subscription","commits_url":"https://api.github.com/repos/bbaldino/jibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbaldino/jibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbaldino/jibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbaldino/jibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbaldino/jibri/contents/{+path}","compare_url":"https://api.github.com/repos/bbaldino/jibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbaldino/jibri/merges","archive_url":"https://api.github.com/repos/bbaldino/jibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbaldino/jibri/downloads","issues_url":"https://api.github.com/repos/bbaldino/jibri/issues{/number}","pulls_url":"https://api.github.com/repos/bbaldino/jibri/pulls{/number}","milestones_url":"https://api.github.com/repos/bbaldino/jibri/milestones{/number}","notifications_url":"https://api.github.com/repos/bbaldino/jibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbaldino/jibri/labels{/name}","releases_url":"https://api.github.com/repos/bbaldino/jibri/releases{/id}","deployments_url":"https://api.github.com/repos/bbaldino/jibri/deployments","created_at":"2018-03-09T18:47:05Z","updated_at":"2018-03-09T18:47:07Z","pushed_at":"2019-10-18T16:42:11Z","git_url":"git://github.com/bbaldino/jibri.git","ssh_url":"git@github.com:bbaldino/jibri.git","clone_url":"https://github.com/bbaldino/jibri.git","svn_url":"https://github.com/bbaldino/jibri","homepage":"","size":1190,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"0c615af7915c65adf1b870e99df859700a932f52","user":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":51473177,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQ3MzE3Nw==","name":"jibri","full_name":"jitsi/jibri","private":false,"owner":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jitsi/jibri","description":"Jitsi BRoadcasting Infrastructure","fork":false,"url":"https://api.github.com/repos/jitsi/jibri","forks_url":"https://api.github.com/repos/jitsi/jibri/forks","keys_url":"https://api.github.com/repos/jitsi/jibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jibri/teams","hooks_url":"https://api.github.com/repos/jitsi/jibri/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jibri/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jibri/events","assignees_url":"https://api.github.com/repos/jitsi/jibri/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jibri/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jibri/tags","blobs_url":"https://api.github.com/repos/jitsi/jibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jibri/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jibri/languages","stargazers_url":"https://api.github.com/repos/jitsi/jibri/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jibri/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jibri/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jibri/subscription","commits_url":"https://api.github.com/repos/jitsi/jibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jibri/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jibri/merges","archive_url":"https://api.github.com/repos/jitsi/jibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jibri/downloads","issues_url":"https://api.github.com/repos/jitsi/jibri/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jibri/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jibri/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jibri/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jibri/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jibri/deployments","created_at":"2016-02-10T21:22:20Z","updated_at":"2019-10-18T16:42:10Z","pushed_at":"2019-10-18T16:42:08Z","git_url":"git://github.com/jitsi/jibri.git","ssh_url":"git@github.com:jitsi/jibri.git","clone_url":"https://github.com/jitsi/jibri.git","svn_url":"https://github.com/jitsi/jibri","homepage":"","size":906,"stargazers_count":135,"watchers_count":135,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":71,"open_issues":29,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/228"},"html":{"href":"https://github.com/jitsi/jibri/pull/228"},"issue":{"href":"https://api.github.com/repos/jitsi/jibri/issues/228"},"comments":{"href":"https://api.github.com/repos/jitsi/jibri/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jibri/statuses/d152e2774c1961052e4b76e9b947fb1173fe06fa"}},"author_association":"MEMBER"}}
|
{
"id": 51473177,
"name": "jitsi/jibri",
"url": "https://api.github.com/repos/jitsi/jibri"
}
|
{
"id": 1243084,
"login": "virtuacoplenny",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1243084?",
"url": "https://api.github.com/users/virtuacoplenny"
}
|
{
"id": 3671647,
"login": "jitsi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3671647?",
"url": "https://api.github.com/orgs/jitsi"
}
| 2019-10-18T22:23:24 |
10665652241
|
{"actor":{"display_login":"virtuacoplenny"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/comments/265998382","pull_request_review_id":215056063,"id":265998382,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTk5ODM4Mg==","diff_hunk":"@@ -11,16 +11,28 @@ net.java.sip.communicator.impl.protocol.sip.acc1=acc1\n {{ if and .Env.JIGASI_SIP_PORT .Env.JIGASI_SIP_TRANSPORT }}\n net.java.sip.communicator.impl.protocol.sip.acc1.PROXY_ADDRESS={{ .Env.JIGASI_SIP_SERVER }}\n net.java.sip.communicator.impl.protocol.sip.acc1.PROXY_AUTO_CONFIG=false\n-net.java.sip.communicator.impl.protocol.sip.acc1.PROXY_PORT={{ .Env.JIGASI_SIP_PORT }}\n-net.java.sip.communicator.impl.protocol.sip.acc1.PREFERRED_TRANSPORT={{ .Env.JIGASI_SIP_TRANSPORT }}\n+net.java.sip.communicator.impl.protocol.sip.acc1.PROXY_PORT={{ .Env.JIGASI_SIP_PORT | default \"5060\" }}\n+net.java.sip.communicator.impl.protocol.sip.acc1.PREFERRED_TRANSPORT={{ .Env.JIGASI_SIP_TRANSPORT | default \"UDP\" }}\n+{{ end }}\n+{{ if and .Env.JIGASI_ENABLE_SDES_SRTP | default \"0\" | toBool }}\n+net.java.sip.communicator.impl.protocol.sip.acc1.SAVP_OPTION=1\n+net.java.sip.communicator.impl.protocol.sip.acc1.DEFAULT_ENCRYPTION=true\n+net.java.sip.communicator.impl.protocol.sip.acc1.DEFAULT_SIPZRTP_ATTRIBUTE=false\n+net.java.sip.communicator.impl.protocol.sip.acc1.ENCRYPTION_PROTOCOL.ZRTP=0\n+net.java.sip.communicator.impl.protocol.sip.acc1.ENCRYPTION_PROTOCOL.SDES=1\n+net.java.sip.communicator.impl.protocol.sip.acc1.ENCRYPTION_PROTOCOL.DTLS-SRTP=2","path":"jigasi/rootfs/defaults/sip-communicator.properties","position":null,"original_position":15,"commit_id":"00a552bfe8c634657a923df4c0acfa9e37d1110a","original_commit_id":"5a5b30a4541907304ee21a34fc918bc845d7cd30","user":{"login":"saghul","id":317464,"node_id":"MDQ6VXNlcjMxNzQ2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/317464?v=4","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"body":"exactly","created_at":"2019-03-15T14:14:37Z","updated_at":"2019-03-15T14:14:37Z","html_url":"https://github.com/jitsi/docker-jitsi-meet/pull/80#discussion_r265998382","pull_request_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/80","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/comments/265998382"},"html":{"href":"https://github.com/jitsi/docker-jitsi-meet/pull/80#discussion_r265998382"},"pull_request":{"href":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/80"}},"in_reply_to_id":265958474},"pull_request":{"url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/80","id":261529502,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxNTI5NTAy","html_url":"https://github.com/jitsi/docker-jitsi-meet/pull/80","diff_url":"https://github.com/jitsi/docker-jitsi-meet/pull/80.diff","patch_url":"https://github.com/jitsi/docker-jitsi-meet/pull/80.patch","issue_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/issues/80","number":80,"state":"open","locked":false,"title":"jigasi: add SDES srtp enabling possibility and healthcheck","user":{"login":"netaskd","id":1027361,"node_id":"MDQ6VXNlcjEwMjczNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1027361?v=4","gravatar_id":"","url":"https://api.github.com/users/netaskd","html_url":"https://github.com/netaskd","followers_url":"https://api.github.com/users/netaskd/followers","following_url":"https://api.github.com/users/netaskd/following{/other_user}","gists_url":"https://api.github.com/users/netaskd/gists{/gist_id}","starred_url":"https://api.github.com/users/netaskd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netaskd/subscriptions","organizations_url":"https://api.github.com/users/netaskd/orgs","repos_url":"https://api.github.com/users/netaskd/repos","events_url":"https://api.github.com/users/netaskd/events{/privacy}","received_events_url":"https://api.github.com/users/netaskd/received_events","type":"User","site_admin":false},"body":"this PR adds possibility to set in .env file: \r\n- JIGASI_ENABLE_SDES_SRTP for enabling SDES srtp in jigasi\r\n- JIGASI_HEALTH_CHECK_SIP_URI set healthcheck extansion for call to\r\n- JIGASI_HEALTH_CHECK_INTERVAL set time interval (in ms) for calling healthcheck extension\r\n- JIGASI_SIP_KEEP_ALIVE_METHOD set change default sip ping method, by default is OPTION\r\n","created_at":"2019-03-15T12:17:29Z","updated_at":"2019-03-15T14:14:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17e2f17e93ebcfeb2a6ad2edb703e197ef2f33e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/80/commits","review_comments_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/80/comments","review_comment_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/issues/80/comments","statuses_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/statuses/00a552bfe8c634657a923df4c0acfa9e37d1110a","head":{"label":"netaskd:pr_jigasi_srtp","ref":"pr_jigasi_srtp","sha":"00a552bfe8c634657a923df4c0acfa9e37d1110a","user":{"login":"netaskd","id":1027361,"node_id":"MDQ6VXNlcjEwMjczNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1027361?v=4","gravatar_id":"","url":"https://api.github.com/users/netaskd","html_url":"https://github.com/netaskd","followers_url":"https://api.github.com/users/netaskd/followers","following_url":"https://api.github.com/users/netaskd/following{/other_user}","gists_url":"https://api.github.com/users/netaskd/gists{/gist_id}","starred_url":"https://api.github.com/users/netaskd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netaskd/subscriptions","organizations_url":"https://api.github.com/users/netaskd/orgs","repos_url":"https://api.github.com/users/netaskd/repos","events_url":"https://api.github.com/users/netaskd/events{/privacy}","received_events_url":"https://api.github.com/users/netaskd/received_events","type":"User","site_admin":false},"repo":{"id":158838018,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg4MzgwMTg=","name":"docker-jitsi-meet","full_name":"netaskd/docker-jitsi-meet","private":false,"owner":{"login":"netaskd","id":1027361,"node_id":"MDQ6VXNlcjEwMjczNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1027361?v=4","gravatar_id":"","url":"https://api.github.com/users/netaskd","html_url":"https://github.com/netaskd","followers_url":"https://api.github.com/users/netaskd/followers","following_url":"https://api.github.com/users/netaskd/following{/other_user}","gists_url":"https://api.github.com/users/netaskd/gists{/gist_id}","starred_url":"https://api.github.com/users/netaskd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netaskd/subscriptions","organizations_url":"https://api.github.com/users/netaskd/orgs","repos_url":"https://api.github.com/users/netaskd/repos","events_url":"https://api.github.com/users/netaskd/events{/privacy}","received_events_url":"https://api.github.com/users/netaskd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/netaskd/docker-jitsi-meet","description":"Jitsi Meet on Docker based on jitsi/docker-jitsi-meet with additional features","fork":true,"url":"https://api.github.com/repos/netaskd/docker-jitsi-meet","forks_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/forks","keys_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/events","assignees_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/merges","archive_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/netaskd/docker-jitsi-meet/deployments","created_at":"2018-11-23T13:42:49Z","updated_at":"2019-03-06T19:43:54Z","pushed_at":"2019-03-15T13:47:53Z","git_url":"git://github.com/netaskd/docker-jitsi-meet.git","ssh_url":"git@github.com:netaskd/docker-jitsi-meet.git","clone_url":"https://github.com/netaskd/docker-jitsi-meet.git","svn_url":"https://github.com/netaskd/docker-jitsi-meet","homepage":"https://hub.docker.com/u/jitsi/","size":440,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"jitsi:dev","ref":"dev","sha":"fb93051bea06346be13275b6f0120251537fbcb6","user":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":141265446,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNjU0NDY=","name":"docker-jitsi-meet","full_name":"jitsi/docker-jitsi-meet","private":false,"owner":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jitsi/docker-jitsi-meet","description":"Jitsi Meet on Docker","fork":false,"url":"https://api.github.com/repos/jitsi/docker-jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/docker-jitsi-meet/deployments","created_at":"2018-07-17T09:23:37Z","updated_at":"2019-03-15T06:22:04Z","pushed_at":"2019-03-15T13:47:55Z","git_url":"git://github.com/jitsi/docker-jitsi-meet.git","ssh_url":"git@github.com:jitsi/docker-jitsi-meet.git","clone_url":"https://github.com/jitsi/docker-jitsi-meet.git","svn_url":"https://github.com/jitsi/docker-jitsi-meet","homepage":"https://hub.docker.com/u/jitsi/","size":382,"stargazers_count":131,"watchers_count":131,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":50,"open_issues":10,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/80"},"html":{"href":"https://github.com/jitsi/docker-jitsi-meet/pull/80"},"issue":{"href":"https://api.github.com/repos/jitsi/docker-jitsi-meet/issues/80"},"comments":{"href":"https://api.github.com/repos/jitsi/docker-jitsi-meet/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/docker-jitsi-meet/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/docker-jitsi-meet/statuses/00a552bfe8c634657a923df4c0acfa9e37d1110a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 141265446,
"name": "jitsi/docker-jitsi-meet",
"url": "https://api.github.com/repos/jitsi/docker-jitsi-meet"
}
|
{
"id": 317464,
"login": "saghul",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/317464?",
"url": "https://api.github.com/users/saghul"
}
|
{
"id": 3671647,
"login": "jitsi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3671647?",
"url": "https://api.github.com/orgs/jitsi"
}
| 2019-03-15T14:14:37 |
9251196338
|
{"actor":{"display_login":"saghul"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/MLton/mlton/pulls/comments/321652780","pull_request_review_id":284754600,"id":321652780,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMTY1Mjc4MA==","diff_hunk":"@@ -461,9 +498,15 @@ fun toMachine (rssa: Rssa.Program.t) =\n in\n case s of\n Bind {dst = (var, _), src, ...} =>\n- Vector.new1\n- (M.Statement.move {dst = varOperand var,\n- src = translateOperand src})\n+ let\n+ val oper = varOperand var\n+ in\n+ if M.Operand.isDestination oper","path":"mlton/backend/backend.fun","position":144,"original_position":152,"commit_id":"3e563a7b2179374a5f1786128eadb8498ddd77f3","original_commit_id":"2d4849399230d628f80e8df662c078c3d4270be8","user":{"login":"MatthewFluet","id":931523,"node_id":"MDQ6VXNlcjkzMTUyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/931523?v=4","gravatar_id":"","url":"https://api.github.com/users/MatthewFluet","html_url":"https://github.com/MatthewFluet","followers_url":"https://api.github.com/users/MatthewFluet/followers","following_url":"https://api.github.com/users/MatthewFluet/following{/other_user}","gists_url":"https://api.github.com/users/MatthewFluet/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewFluet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewFluet/subscriptions","organizations_url":"https://api.github.com/users/MatthewFluet/orgs","repos_url":"https://api.github.com/users/MatthewFluet/repos","events_url":"https://api.github.com/users/MatthewFluet/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewFluet/received_events","type":"User","site_admin":false},"body":"But, RSSA can also `Bind` a `Const` operand to a variable. So, why wasn't this check already here to avoid emitting an invalid instruction to move into a `Const`? I guess because of RSSA copy propagation --- although the RSSA IR allows `Bind`ing a `Const`, it never occurred in the RSSA program that was processed by the backend.","created_at":"2019-09-06T09:29:14Z","updated_at":"2019-09-06T09:29:14Z","html_url":"https://github.com/MLton/mlton/pull/328#discussion_r321652780","pull_request_url":"https://api.github.com/repos/MLton/mlton/pulls/328","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MLton/mlton/pulls/comments/321652780"},"html":{"href":"https://github.com/MLton/mlton/pull/328#discussion_r321652780"},"pull_request":{"href":"https://api.github.com/repos/MLton/mlton/pulls/328"}},"in_reply_to_id":320968860},"pull_request":{"url":"https://api.github.com/repos/MLton/mlton/pulls/328","id":306685775,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2Njg1Nzc1","html_url":"https://github.com/MLton/mlton/pull/328","diff_url":"https://github.com/MLton/mlton/pull/328.diff","patch_url":"https://github.com/MLton/mlton/pull/328.patch","issue_url":"https://api.github.com/repos/MLton/mlton/issues/328","number":328,"state":"open","locked":false,"title":"Add static allocation support in Rssa through codegen","user":{"login":"jasoncarr0","id":6874204,"node_id":"MDQ6VXNlcjY4NzQyMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6874204?v=4","gravatar_id":"","url":"https://api.github.com/users/jasoncarr0","html_url":"https://github.com/jasoncarr0","followers_url":"https://api.github.com/users/jasoncarr0/followers","following_url":"https://api.github.com/users/jasoncarr0/following{/other_user}","gists_url":"https://api.github.com/users/jasoncarr0/gists{/gist_id}","starred_url":"https://api.github.com/users/jasoncarr0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasoncarr0/subscriptions","organizations_url":"https://api.github.com/users/jasoncarr0/orgs","repos_url":"https://api.github.com/users/jasoncarr0/repos","events_url":"https://api.github.com/users/jasoncarr0/events{/privacy}","received_events_url":"https://api.github.com/users/jasoncarr0/received_events","type":"User","site_admin":false},"body":"The later IRs now support static data of various sorts. Some features are merged into statics: `isMutable` in Rssa has been weakened to `pinned` which is only needed to maintain the changes from BounceVars without excessive liveness analysis. The vectors field of Machine.Program.T has been changed to include general statics. In Rssa, a new expression defines a unique static for each usage in the program. In the backend, statics are moved into the program (no uniqueifying is performed, as it seems to be an artifact of propagation of constants), and references are done through an operand. The operand Static is a constant value which has type CPointer or ObjPtr, and its data can be accessed with Offset/Contents as normal. Thus, it has no address, and it cannot be written to (which indicated some conflations of meaning for isLocation).\r\n\r\nUnder the default behavior, globals are not statically allocated if they have one or more mutable fields which can hold an object pointer (after packing) or if their data is not statically allocated. In practice, there are no such globals for just about all programs.\r\n\r\nThis version has support in all codegens. As expected, code size and compile time are improved across the board, particularly for larger programs. Runtime improves sometimes, but should only affect programs which had hot code accessing globals, as it removes one level of indirection. We should also expect marginally faster garbage collections, as globals are now mostly skipped.\r\n\r\nA couple pieces are still outstanding for discussion and review:\r\n\r\n- Command line options. There's a lot of dimensions to this, and in general they should all be enabled unless a bug or performance regression arises in user code, or a GC choice makes them impossible. Right now disabling it for particular sorts of data still leaves them statically initialized (and heap allocated), but ...\r\n- Objects which are not statically allocated are currently created in code. It seems not to be worth it to make a statically initialized heap allocated object, as the code to initialize them is quite small. The statically allocated objects should have better compile time though.\r\n- There's still a good bit of complexity that I'd like to reduce as much as possible of. Some options are partially coupled: generally the heap allocated statics are precisely the statics with destination globals. As an awkwardness with this, which de-facto cannot occur (due to propagation), is a non-heap static with global, which would be copied to the heap under the current code (but doing something else would be an additional edge case). Empty (array) data has to have different initialization rules from others to avoid executable bloat (so it goes in bss, instead of text). I have at least managed to center all decision-making to ssa2-to-rssa and all initialization to c codegen's outputDecls.\r\n- Rssa still has WordXVector support for constants. Only one particular pass in Rssa created them, so it may be easiest to just disable it, which would simplify the backend and reduce redundancy. The complexity here is that disabling this requires duplicating or factoring the logic for deciding where to place statics (WordXVectors are only placed on the heap at the moment).\r\n- Statics are somewhat inconsistent with globals: they are stored with the program, and information about them is local, whereas globals are created and stored globally, but I couldn't convince myself to create a module just for a single integer counter.\r\n\r\nThis resolves https://github.com/MLton/mlton/issues/300\r\n\r\nThis affects the previous globalization changes in https://github.com/MLton/mlton/pull/288, so they should be re-examined as well. In particular effects due to extra indirections should disappear, so remaining effects will only be due to low-level perturbations and interactions with other passes (local-ref for instance).","created_at":"2019-08-12T22:42:54Z","updated_at":"2019-09-06T09:29:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"188510fa1e045a0d198ae68edf53eeab55ef3dcf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MLton/mlton/pulls/328/commits","review_comments_url":"https://api.github.com/repos/MLton/mlton/pulls/328/comments","review_comment_url":"https://api.github.com/repos/MLton/mlton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MLton/mlton/issues/328/comments","statuses_url":"https://api.github.com/repos/MLton/mlton/statuses/3e563a7b2179374a5f1786128eadb8498ddd77f3","head":{"label":"jasoncarr0:static-alloc","ref":"static-alloc","sha":"3e563a7b2179374a5f1786128eadb8498ddd77f3","user":{"login":"jasoncarr0","id":6874204,"node_id":"MDQ6VXNlcjY4NzQyMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6874204?v=4","gravatar_id":"","url":"https://api.github.com/users/jasoncarr0","html_url":"https://github.com/jasoncarr0","followers_url":"https://api.github.com/users/jasoncarr0/followers","following_url":"https://api.github.com/users/jasoncarr0/following{/other_user}","gists_url":"https://api.github.com/users/jasoncarr0/gists{/gist_id}","starred_url":"https://api.github.com/users/jasoncarr0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasoncarr0/subscriptions","organizations_url":"https://api.github.com/users/jasoncarr0/orgs","repos_url":"https://api.github.com/users/jasoncarr0/repos","events_url":"https://api.github.com/users/jasoncarr0/events{/privacy}","received_events_url":"https://api.github.com/users/jasoncarr0/received_events","type":"User","site_admin":false},"repo":{"id":94806076,"node_id":"MDEwOlJlcG9zaXRvcnk5NDgwNjA3Ng==","name":"mlton","full_name":"jasoncarr0/mlton","private":false,"owner":{"login":"jasoncarr0","id":6874204,"node_id":"MDQ6VXNlcjY4NzQyMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6874204?v=4","gravatar_id":"","url":"https://api.github.com/users/jasoncarr0","html_url":"https://github.com/jasoncarr0","followers_url":"https://api.github.com/users/jasoncarr0/followers","following_url":"https://api.github.com/users/jasoncarr0/following{/other_user}","gists_url":"https://api.github.com/users/jasoncarr0/gists{/gist_id}","starred_url":"https://api.github.com/users/jasoncarr0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasoncarr0/subscriptions","organizations_url":"https://api.github.com/users/jasoncarr0/orgs","repos_url":"https://api.github.com/users/jasoncarr0/repos","events_url":"https://api.github.com/users/jasoncarr0/events{/privacy}","received_events_url":"https://api.github.com/users/jasoncarr0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jasoncarr0/mlton","description":"The MLton repository","fork":true,"url":"https://api.github.com/repos/jasoncarr0/mlton","forks_url":"https://api.github.com/repos/jasoncarr0/mlton/forks","keys_url":"https://api.github.com/repos/jasoncarr0/mlton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasoncarr0/mlton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasoncarr0/mlton/teams","hooks_url":"https://api.github.com/repos/jasoncarr0/mlton/hooks","issue_events_url":"https://api.github.com/repos/jasoncarr0/mlton/issues/events{/number}","events_url":"https://api.github.com/repos/jasoncarr0/mlton/events","assignees_url":"https://api.github.com/repos/jasoncarr0/mlton/assignees{/user}","branches_url":"https://api.github.com/repos/jasoncarr0/mlton/branches{/branch}","tags_url":"https://api.github.com/repos/jasoncarr0/mlton/tags","blobs_url":"https://api.github.com/repos/jasoncarr0/mlton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasoncarr0/mlton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasoncarr0/mlton/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasoncarr0/mlton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasoncarr0/mlton/statuses/{sha}","languages_url":"https://api.github.com/repos/jasoncarr0/mlton/languages","stargazers_url":"https://api.github.com/repos/jasoncarr0/mlton/stargazers","contributors_url":"https://api.github.com/repos/jasoncarr0/mlton/contributors","subscribers_url":"https://api.github.com/repos/jasoncarr0/mlton/subscribers","subscription_url":"https://api.github.com/repos/jasoncarr0/mlton/subscription","commits_url":"https://api.github.com/repos/jasoncarr0/mlton/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasoncarr0/mlton/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasoncarr0/mlton/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasoncarr0/mlton/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasoncarr0/mlton/contents/{+path}","compare_url":"https://api.github.com/repos/jasoncarr0/mlton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasoncarr0/mlton/merges","archive_url":"https://api.github.com/repos/jasoncarr0/mlton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasoncarr0/mlton/downloads","issues_url":"https://api.github.com/repos/jasoncarr0/mlton/issues{/number}","pulls_url":"https://api.github.com/repos/jasoncarr0/mlton/pulls{/number}","milestones_url":"https://api.github.com/repos/jasoncarr0/mlton/milestones{/number}","notifications_url":"https://api.github.com/repos/jasoncarr0/mlton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasoncarr0/mlton/labels{/name}","releases_url":"https://api.github.com/repos/jasoncarr0/mlton/releases{/id}","deployments_url":"https://api.github.com/repos/jasoncarr0/mlton/deployments","created_at":"2017-06-19T18:04:02Z","updated_at":"2019-07-08T18:30:48Z","pushed_at":"2019-09-06T00:55:27Z","git_url":"git://github.com/jasoncarr0/mlton.git","ssh_url":"git@github.com:jasoncarr0/mlton.git","clone_url":"https://github.com/jasoncarr0/mlton.git","svn_url":"https://github.com/jasoncarr0/mlton","homepage":"http://mlton.org","size":67075,"stargazers_count":0,"watchers_count":0,"language":"Standard ML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"MLton:master","ref":"master","sha":"a1faf761bdb211a81b0f6a95f5a749698b6891fa","user":{"login":"MLton","id":3707101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDcxMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3707101?v=4","gravatar_id":"","url":"https://api.github.com/users/MLton","html_url":"https://github.com/MLton","followers_url":"https://api.github.com/users/MLton/followers","following_url":"https://api.github.com/users/MLton/following{/other_user}","gists_url":"https://api.github.com/users/MLton/gists{/gist_id}","starred_url":"https://api.github.com/users/MLton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MLton/subscriptions","organizations_url":"https://api.github.com/users/MLton/orgs","repos_url":"https://api.github.com/users/MLton/repos","events_url":"https://api.github.com/users/MLton/events{/privacy}","received_events_url":"https://api.github.com/users/MLton/received_events","type":"Organization","site_admin":false},"repo":{"id":8658931,"node_id":"MDEwOlJlcG9zaXRvcnk4NjU4OTMx","name":"mlton","full_name":"MLton/mlton","private":false,"owner":{"login":"MLton","id":3707101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDcxMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3707101?v=4","gravatar_id":"","url":"https://api.github.com/users/MLton","html_url":"https://github.com/MLton","followers_url":"https://api.github.com/users/MLton/followers","following_url":"https://api.github.com/users/MLton/following{/other_user}","gists_url":"https://api.github.com/users/MLton/gists{/gist_id}","starred_url":"https://api.github.com/users/MLton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MLton/subscriptions","organizations_url":"https://api.github.com/users/MLton/orgs","repos_url":"https://api.github.com/users/MLton/repos","events_url":"https://api.github.com/users/MLton/events{/privacy}","received_events_url":"https://api.github.com/users/MLton/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MLton/mlton","description":"The MLton repository","fork":false,"url":"https://api.github.com/repos/MLton/mlton","forks_url":"https://api.github.com/repos/MLton/mlton/forks","keys_url":"https://api.github.com/repos/MLton/mlton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MLton/mlton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MLton/mlton/teams","hooks_url":"https://api.github.com/repos/MLton/mlton/hooks","issue_events_url":"https://api.github.com/repos/MLton/mlton/issues/events{/number}","events_url":"https://api.github.com/repos/MLton/mlton/events","assignees_url":"https://api.github.com/repos/MLton/mlton/assignees{/user}","branches_url":"https://api.github.com/repos/MLton/mlton/branches{/branch}","tags_url":"https://api.github.com/repos/MLton/mlton/tags","blobs_url":"https://api.github.com/repos/MLton/mlton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MLton/mlton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MLton/mlton/git/refs{/sha}","trees_url":"https://api.github.com/repos/MLton/mlton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MLton/mlton/statuses/{sha}","languages_url":"https://api.github.com/repos/MLton/mlton/languages","stargazers_url":"https://api.github.com/repos/MLton/mlton/stargazers","contributors_url":"https://api.github.com/repos/MLton/mlton/contributors","subscribers_url":"https://api.github.com/repos/MLton/mlton/subscribers","subscription_url":"https://api.github.com/repos/MLton/mlton/subscription","commits_url":"https://api.github.com/repos/MLton/mlton/commits{/sha}","git_commits_url":"https://api.github.com/repos/MLton/mlton/git/commits{/sha}","comments_url":"https://api.github.com/repos/MLton/mlton/comments{/number}","issue_comment_url":"https://api.github.com/repos/MLton/mlton/issues/comments{/number}","contents_url":"https://api.github.com/repos/MLton/mlton/contents/{+path}","compare_url":"https://api.github.com/repos/MLton/mlton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MLton/mlton/merges","archive_url":"https://api.github.com/repos/MLton/mlton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MLton/mlton/downloads","issues_url":"https://api.github.com/repos/MLton/mlton/issues{/number}","pulls_url":"https://api.github.com/repos/MLton/mlton/pulls{/number}","milestones_url":"https://api.github.com/repos/MLton/mlton/milestones{/number}","notifications_url":"https://api.github.com/repos/MLton/mlton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MLton/mlton/labels{/name}","releases_url":"https://api.github.com/repos/MLton/mlton/releases{/id}","deployments_url":"https://api.github.com/repos/MLton/mlton/deployments","created_at":"2013-03-08T20:08:27Z","updated_at":"2019-09-06T06:54:09Z","pushed_at":"2019-09-06T00:55:29Z","git_url":"git://github.com/MLton/mlton.git","ssh_url":"git@github.com:MLton/mlton.git","clone_url":"https://github.com/MLton/mlton.git","svn_url":"https://github.com/MLton/mlton","homepage":"http://mlton.org","size":66553,"stargazers_count":515,"watchers_count":515,"language":"Standard ML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":88,"open_issues":29,"watchers":515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MLton/mlton/pulls/328"},"html":{"href":"https://github.com/MLton/mlton/pull/328"},"issue":{"href":"https://api.github.com/repos/MLton/mlton/issues/328"},"comments":{"href":"https://api.github.com/repos/MLton/mlton/issues/328/comments"},"review_comments":{"href":"https://api.github.com/repos/MLton/mlton/pulls/328/comments"},"review_comment":{"href":"https://api.github.com/repos/MLton/mlton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MLton/mlton/pulls/328/commits"},"statuses":{"href":"https://api.github.com/repos/MLton/mlton/statuses/3e563a7b2179374a5f1786128eadb8498ddd77f3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 8658931,
"name": "MLton/mlton",
"url": "https://api.github.com/repos/MLton/mlton"
}
|
{
"id": 931523,
"login": "MatthewFluet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/931523?",
"url": "https://api.github.com/users/MatthewFluet"
}
|
{
"id": 3707101,
"login": "MLton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3707101?",
"url": "https://api.github.com/orgs/MLton"
}
| 2019-09-06T09:29:14 |
10361210028
|
{"actor":{"display_login":"MatthewFluet"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/comments/331274662","pull_request_review_id":297178871,"id":331274662,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMTI3NDY2Mg==","diff_hunk":"@@ -25,29 +25,21 @@ pipeline {\n '''\n }\n }\n- stage('Polkadot') {\n- steps {\n- sh '''\n- make deps-polkadot\n- '''\n- }\n- }","path":"Jenkinsfile","position":null,"original_position":10,"commit_id":"da86e6d578affbd514f25a750cebd6d52f766614","original_commit_id":"1013a46db5984708991baba7f0610d40bc9e6e30","user":{"login":"ehildenb","id":12721972,"node_id":"MDQ6VXNlcjEyNzIxOTcy","avatar_url":"https://avatars0.githubusercontent.com/u/12721972?v=4","gravatar_id":"","url":"https://api.github.com/users/ehildenb","html_url":"https://github.com/ehildenb","followers_url":"https://api.github.com/users/ehildenb/followers","following_url":"https://api.github.com/users/ehildenb/following{/other_user}","gists_url":"https://api.github.com/users/ehildenb/gists{/gist_id}","starred_url":"https://api.github.com/users/ehildenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehildenb/subscriptions","organizations_url":"https://api.github.com/users/ehildenb/orgs","repos_url":"https://api.github.com/users/ehildenb/repos","events_url":"https://api.github.com/users/ehildenb/events{/privacy}","received_events_url":"https://api.github.com/users/ehildenb/received_events","type":"User","site_admin":false},"body":"I added the tests back in.","created_at":"2019-10-03T22:06:59Z","updated_at":"2019-10-03T22:06:59Z","html_url":"https://github.com/runtimeverification/polkadot-verification/pull/40#discussion_r331274662","pull_request_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/40","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/comments/331274662"},"html":{"href":"https://github.com/runtimeverification/polkadot-verification/pull/40#discussion_r331274662"},"pull_request":{"href":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/40"}},"in_reply_to_id":330877268},"pull_request":{"url":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/40","id":323541001,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzNTQxMDAx","html_url":"https://github.com/runtimeverification/polkadot-verification/pull/40","diff_url":"https://github.com/runtimeverification/polkadot-verification/pull/40.diff","patch_url":"https://github.com/runtimeverification/polkadot-verification/pull/40.patch","issue_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues/40","number":40,"state":"open","locked":false,"title":"Auto unparsing based on definition, limit coverage to semantic rules","user":{"login":"ehildenb","id":12721972,"node_id":"MDQ6VXNlcjEyNzIxOTcy","avatar_url":"https://avatars0.githubusercontent.com/u/12721972?v=4","gravatar_id":"","url":"https://api.github.com/users/ehildenb","html_url":"https://github.com/ehildenb","followers_url":"https://api.github.com/users/ehildenb/followers","following_url":"https://api.github.com/users/ehildenb/following{/other_user}","gists_url":"https://api.github.com/users/ehildenb/gists{/gist_id}","starred_url":"https://api.github.com/users/ehildenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehildenb/subscriptions","organizations_url":"https://api.github.com/users/ehildenb/orgs","repos_url":"https://api.github.com/users/ehildenb/repos","events_url":"https://api.github.com/users/ehildenb/events{/privacy}","received_events_url":"https://api.github.com/users/ehildenb/received_events","type":"User","site_admin":false},"body":"Fixes: #41\r\n\r\n- Update KWasm submodule (BLOCKED on kframework/wasm-semantics#227)\r\n- `translateCoverage.py` only converts semantic rules, not function rules.\r\n- Using auto-unparser which comes via `pyk. instead of manually written one.","created_at":"2019-10-02T01:27:37Z","updated_at":"2019-10-03T22:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e5339780f5a610635334c99efc5dfe8fb089a0e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"virgil-serbanuta","id":25692529,"node_id":"MDQ6VXNlcjI1NjkyNTI5","avatar_url":"https://avatars1.githubusercontent.com/u/25692529?v=4","gravatar_id":"","url":"https://api.github.com/users/virgil-serbanuta","html_url":"https://github.com/virgil-serbanuta","followers_url":"https://api.github.com/users/virgil-serbanuta/followers","following_url":"https://api.github.com/users/virgil-serbanuta/following{/other_user}","gists_url":"https://api.github.com/users/virgil-serbanuta/gists{/gist_id}","starred_url":"https://api.github.com/users/virgil-serbanuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virgil-serbanuta/subscriptions","organizations_url":"https://api.github.com/users/virgil-serbanuta/orgs","repos_url":"https://api.github.com/users/virgil-serbanuta/repos","events_url":"https://api.github.com/users/virgil-serbanuta/events{/privacy}","received_events_url":"https://api.github.com/users/virgil-serbanuta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/40/commits","review_comments_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/40/comments","review_comment_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues/40/comments","statuses_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/statuses/da86e6d578affbd514f25a750cebd6d52f766614","head":{"label":"runtimeverification:auto-unparsing","ref":"auto-unparsing","sha":"da86e6d578affbd514f25a750cebd6d52f766614","user":{"login":"runtimeverification","id":3732719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzI3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3732719?v=4","gravatar_id":"","url":"https://api.github.com/users/runtimeverification","html_url":"https://github.com/runtimeverification","followers_url":"https://api.github.com/users/runtimeverification/followers","following_url":"https://api.github.com/users/runtimeverification/following{/other_user}","gists_url":"https://api.github.com/users/runtimeverification/gists{/gist_id}","starred_url":"https://api.github.com/users/runtimeverification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runtimeverification/subscriptions","organizations_url":"https://api.github.com/users/runtimeverification/orgs","repos_url":"https://api.github.com/users/runtimeverification/repos","events_url":"https://api.github.com/users/runtimeverification/events{/privacy}","received_events_url":"https://api.github.com/users/runtimeverification/received_events","type":"Organization","site_admin":false},"repo":{"id":201503662,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE1MDM2NjI=","name":"polkadot-verification","full_name":"runtimeverification/polkadot-verification","private":false,"owner":{"login":"runtimeverification","id":3732719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzI3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3732719?v=4","gravatar_id":"","url":"https://api.github.com/users/runtimeverification","html_url":"https://github.com/runtimeverification","followers_url":"https://api.github.com/users/runtimeverification/followers","following_url":"https://api.github.com/users/runtimeverification/following{/other_user}","gists_url":"https://api.github.com/users/runtimeverification/gists{/gist_id}","starred_url":"https://api.github.com/users/runtimeverification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runtimeverification/subscriptions","organizations_url":"https://api.github.com/users/runtimeverification/orgs","repos_url":"https://api.github.com/users/runtimeverification/repos","events_url":"https://api.github.com/users/runtimeverification/events{/privacy}","received_events_url":"https://api.github.com/users/runtimeverification/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/runtimeverification/polkadot-verification","description":"Verification of Polkadot WASM code","fork":false,"url":"https://api.github.com/repos/runtimeverification/polkadot-verification","forks_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/forks","keys_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/teams","hooks_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/hooks","issue_events_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues/events{/number}","events_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/events","assignees_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/assignees{/user}","branches_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/branches{/branch}","tags_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/tags","blobs_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/refs{/sha}","trees_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/statuses/{sha}","languages_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/languages","stargazers_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/stargazers","contributors_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/contributors","subscribers_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/subscribers","subscription_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/subscription","commits_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/commits{/sha}","git_commits_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/commits{/sha}","comments_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/comments{/number}","issue_comment_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues/comments{/number}","contents_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/contents/{+path}","compare_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/merges","archive_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/downloads","issues_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues{/number}","pulls_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls{/number}","milestones_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/milestones{/number}","notifications_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/labels{/name}","releases_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/releases{/id}","deployments_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/deployments","created_at":"2019-08-09T16:21:23Z","updated_at":"2019-09-26T02:52:18Z","pushed_at":"2019-10-03T21:44:49Z","git_url":"git://github.com/runtimeverification/polkadot-verification.git","ssh_url":"git@github.com:runtimeverification/polkadot-verification.git","clone_url":"https://github.com/runtimeverification/polkadot-verification.git","svn_url":"https://github.com/runtimeverification/polkadot-verification","homepage":null,"size":1507,"stargazers_count":2,"watchers_count":2,"language":"WebAssembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":null,"forks":1,"open_issues":17,"watchers":2,"default_branch":"master"}},"base":{"label":"runtimeverification:master","ref":"master","sha":"1020671891e71488ce77b55ec516f19e7f84cd71","user":{"login":"runtimeverification","id":3732719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzI3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3732719?v=4","gravatar_id":"","url":"https://api.github.com/users/runtimeverification","html_url":"https://github.com/runtimeverification","followers_url":"https://api.github.com/users/runtimeverification/followers","following_url":"https://api.github.com/users/runtimeverification/following{/other_user}","gists_url":"https://api.github.com/users/runtimeverification/gists{/gist_id}","starred_url":"https://api.github.com/users/runtimeverification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runtimeverification/subscriptions","organizations_url":"https://api.github.com/users/runtimeverification/orgs","repos_url":"https://api.github.com/users/runtimeverification/repos","events_url":"https://api.github.com/users/runtimeverification/events{/privacy}","received_events_url":"https://api.github.com/users/runtimeverification/received_events","type":"Organization","site_admin":false},"repo":{"id":201503662,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE1MDM2NjI=","name":"polkadot-verification","full_name":"runtimeverification/polkadot-verification","private":false,"owner":{"login":"runtimeverification","id":3732719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzI3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3732719?v=4","gravatar_id":"","url":"https://api.github.com/users/runtimeverification","html_url":"https://github.com/runtimeverification","followers_url":"https://api.github.com/users/runtimeverification/followers","following_url":"https://api.github.com/users/runtimeverification/following{/other_user}","gists_url":"https://api.github.com/users/runtimeverification/gists{/gist_id}","starred_url":"https://api.github.com/users/runtimeverification/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runtimeverification/subscriptions","organizations_url":"https://api.github.com/users/runtimeverification/orgs","repos_url":"https://api.github.com/users/runtimeverification/repos","events_url":"https://api.github.com/users/runtimeverification/events{/privacy}","received_events_url":"https://api.github.com/users/runtimeverification/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/runtimeverification/polkadot-verification","description":"Verification of Polkadot WASM code","fork":false,"url":"https://api.github.com/repos/runtimeverification/polkadot-verification","forks_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/forks","keys_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/teams","hooks_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/hooks","issue_events_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues/events{/number}","events_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/events","assignees_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/assignees{/user}","branches_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/branches{/branch}","tags_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/tags","blobs_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/refs{/sha}","trees_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/statuses/{sha}","languages_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/languages","stargazers_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/stargazers","contributors_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/contributors","subscribers_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/subscribers","subscription_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/subscription","commits_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/commits{/sha}","git_commits_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/git/commits{/sha}","comments_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/comments{/number}","issue_comment_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues/comments{/number}","contents_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/contents/{+path}","compare_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/merges","archive_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/downloads","issues_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues{/number}","pulls_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls{/number}","milestones_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/milestones{/number}","notifications_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/labels{/name}","releases_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/releases{/id}","deployments_url":"https://api.github.com/repos/runtimeverification/polkadot-verification/deployments","created_at":"2019-08-09T16:21:23Z","updated_at":"2019-09-26T02:52:18Z","pushed_at":"2019-10-03T21:44:49Z","git_url":"git://github.com/runtimeverification/polkadot-verification.git","ssh_url":"git@github.com:runtimeverification/polkadot-verification.git","clone_url":"https://github.com/runtimeverification/polkadot-verification.git","svn_url":"https://github.com/runtimeverification/polkadot-verification","homepage":null,"size":1507,"stargazers_count":2,"watchers_count":2,"language":"WebAssembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":null,"forks":1,"open_issues":17,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/40"},"html":{"href":"https://github.com/runtimeverification/polkadot-verification/pull/40"},"issue":{"href":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues/40"},"comments":{"href":"https://api.github.com/repos/runtimeverification/polkadot-verification/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runtimeverification/polkadot-verification/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/runtimeverification/polkadot-verification/statuses/da86e6d578affbd514f25a750cebd6d52f766614"}},"author_association":"COLLABORATOR"}}
|
{
"id": 201503662,
"name": "runtimeverification/polkadot-verification",
"url": "https://api.github.com/repos/runtimeverification/polkadot-verification"
}
|
{
"id": 12721972,
"login": "ehildenb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12721972?",
"url": "https://api.github.com/users/ehildenb"
}
|
{
"id": 3732719,
"login": "runtimeverification",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3732719?",
"url": "https://api.github.com/orgs/runtimeverification"
}
| 2019-10-03T22:06:59 |
10555518002
|
{"actor":{"display_login":"ehildenb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gonum/gonum/pulls/comments/263404417","pull_request_review_id":211809962,"id":263404417,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzQwNDQxNw==","diff_hunk":"@@ -6,134 +6,163 @@ package gonum\n \n // This list is duplicated in netlib/lapack/netlib. Keep in sync.\n const (\n-\tabsIncNotOne = \"lapack: increment not one or negative one\"\n-\tbadAlpha = \"lapack: bad alpha length\"\n-\tbadApplyOrtho = \"lapack: bad ApplyOrtho\"\n-\tbadAuxv = \"lapack: auxv has insufficient length\"\n-\tbadBeta = \"lapack: bad beta length\"\n-\tbadD = \"lapack: d has insufficient length\"\n-\tbadDiag = \"lapack: bad diag\"\n-\tbadDims = \"lapack: bad input dimensions\"\n-\tbadDirect = \"lapack: bad direct\"\n-\tbadE = \"lapack: e has insufficient length\"\n-\tbadEVComp = \"lapack: bad EVComp\"\n-\tbadEVHowMany = \"lapack: bad EVHowMany\"\n-\tbadEVJob = \"lapack: bad EVJob\"\n-\tbadEVSide = \"lapack: bad EVSide\"\n-\tbadGenOrtho = \"lapack: bad GenOrtho\"\n-\tbadGSVDJob = \"lapack: bad GSVDJob\"\n-\tbadIlo = \"lapack: ilo out of range\"\n-\tbadIhi = \"lapack: ihi out of range\"\n-\tbadIpiv = \"lapack: bad permutation length\"\n-\tbadIfst = \"lapack: ifst out of range\"\n-\tbadIlst = \"lapack: ilst out of range\"\n-\tbadBalanceJob = \"lapack: bad BalanceJob\"\n-\tbadJ1 = \"lapack: j1 out of range\"\n-\tbadK1 = \"lapack: k1 out of range\"\n-\tbadK2 = \"lapack: k2 out of range\"\n-\tbadKperm = \"lapack: incorrect permutation length\"\n-\tbadLdA = \"lapack: bad leading dimension of A\"\n-\tbadLdB = \"lapack: bad leading dimension of B\"\n-\tbadLdC = \"lapack: bad leading dimension of C\"\n-\tbadLdF = \"lapack: bad leading dimension of F\"\n-\tbadLdH = \"lapack: bad leading dimension of H\"\n-\tbadLdQ = \"lapack: bad leading dimension of Q\"\n-\tbadLdT = \"lapack: bad leading dimension of T\"\n-\tbadLdU = \"lapack: bad leading dimension of U\"\n-\tbadLdV = \"lapack: bad leading dimension of V\"\n-\tbadLdVL = \"lapack: bad leading dimension of VL\"\n-\tbadLdVR = \"lapack: bad leading dimension of VR\"\n-\tbadLdVT = \"lapack: bad leading dimension of VT\"\n-\tbadLdW = \"lapack: bad leading dimension of W\"\n-\tbadLdWH = \"lapack: bad leading dimension of WH\"\n-\tbadLdWV = \"lapack: bad leading dimension of WV\"\n-\tbadLdWork = \"lapack: bad leading dimension of Work\"\n-\tbadLdX = \"lapack: bad leading dimension of X\"\n-\tbadLdY = \"lapack: bad leading dimension of Y\"\n-\tbadLdZ = \"lapack: bad leading dimension of Z\"\n-\tbadMM = \"lapack: bad value of mm\"\n-\tbadNb = \"lapack: nb out of range\"\n-\tbadNorm = \"lapack: bad norm\"\n-\tbadPivot = \"lapack: bad pivot\"\n-\tbadPP = \"lapack: bad value of pp\"\n-\tbadS = \"lapack: s has insufficient length\"\n-\tbadSchurComp = \"lapack: bad SchurComp\"\n-\tbadSchurJob = \"lapack: bad SchurJob\"\n-\tbadSelected = \"lapack: bad length of selected\"\n-\tbadShifts = \"lapack: bad shifts\"\n-\tbadSide = \"lapack: bad side\"\n-\tbadSlice = \"lapack: bad input slice length\"\n-\tbadSort = \"lapack: bad Sort\"\n-\tbadStore = \"lapack: bad store\"\n-\tbadTau = \"lapack: tau has insufficient length\"\n-\tbadTauQ = \"lapack: tauQ has insufficient length\"\n-\tbadTauP = \"lapack: tauP has insufficient length\"\n-\tbadTrans = \"lapack: bad trans\"\n-\tbadVn1 = \"lapack: vn1 has insufficient length\"\n-\tbadVn2 = \"lapack: vn2 has insufficient length\"\n-\tbadUplo = \"lapack: illegal triangle\"\n-\tbadWork = \"lapack: insufficient working memory\"\n-\tbadZ = \"lapack: insufficient z length\"\n-\tzeroIncV = \"lapack: incv == 0\"\n-\tbadIncX = \"lapack: incX <= 0\"\n-\tbadIncY = \"lapack: incY <= 0\"\n-\ti0LT0 = \"lapack: i0 < 0\"\n-\tn0LT0 = \"lapack: n0 < 0\"\n-\tkGTM = \"lapack: k > m\"\n-\tkGTN = \"lapack: k > n\"\n-\tkLT0 = \"lapack: k < 0\"\n-\tkLT1 = \"lapack: k < 1\"\n-\tkdLT0 = \"lapack: kd < 0\"\n-\tmLT0 = \"lapack: m < 0\"\n-\tmLTN = \"lapack: m < n\"\n-\tmmLT0 = \"lapack: mm < 0\"\n-\tnGTM = \"lapack: n > m\"\n-\tmGTN = \"lapack: m > n\"\n-\tnanScale = \"lapack: NaN scale factor\"\n-\tnegANorm = \"lapack: anorm < 0\"\n-\tnegDimension = \"lapack: negative matrix dimension\"\n-\tnegZ = \"lapack: negative z value\"\n-\tnLT0 = \"lapack: n < 0\"\n-\tnLT1 = \"lapack: n < 1\"\n-\tnbLT0 = \"lapack: nb < 0\"\n-\tnLTM = \"lapack: n < m\"\n-\tnrhsLT0 = \"lapack: nrhs < 0\"\n-\tncvtLT0 = \"lapack: ncvt < 0\"\n-\tnruLT0 = \"lapack: nru < 0\"\n-\tnccLT0 = \"lapack: ncc < 0\"\n-\tpLT0 = \"lapack: p < 0\"\n-\toffsetLT0 = \"lapack: offset < 0\"\n-\toffsetGTM = \"lapack: offset > m\"\n-\tshortA = \"lapack: insufficient length of a\"\n-\tshortAB = \"lapack: insufficient length of ab\"\n-\tshortB = \"lapack: insufficient length of b\"\n-\tshortC = \"lapack: insufficient length of c\"\n-\tshortCNorm = \"lapack: insufficient length of cnorm\"\n-\tshortD = \"lapack: insufficient length of d\"\n-\tshortE = \"lapack: insufficient length of e\"\n-\tshortF = \"lapack: insufficient length of f\"\n-\tshortH = \"lapack: insufficient length of h\"\n-\tshortIsgn = \"lapack: insufficient length of isgn\"\n-\tshortQ = \"lapack: insufficient length of q\"\n-\tshortS = \"lapack: insufficient length of s\"\n-\tshortScale = \"lapack: insufficient length of scale\"\n-\tshortT = \"lapack: insufficient length of t\"\n-\tshortU = \"lapack: insufficient length of u\"\n-\tshortV = \"lapack: insufficient length of v\"\n-\tshortVL = \"lapack: insufficient length of vl\"\n-\tshortVR = \"lapack: insufficient length of vr\"\n-\tshortVT = \"lapack: insufficient length of vt\"\n-\tshortW = \"lapack: insufficient length of w\"\n-\tshortWH = \"lapack: insufficient length of wh\"\n-\tshortWI = \"lapack: insufficient length of wi\"\n-\tshortWR = \"lapack: insufficient length of wr\"\n-\tshortWV = \"lapack: insufficient length of wv\"\n-\tshortX = \"lapack: insufficient length of x\"\n-\tshortY = \"lapack: insufficient length of y\"\n-\tshortZ = \"lapack: insufficient length of z\"\n-\tshortIWork = \"lapack: insufficient length of iwork\"\n-\tshortWork = \"lapack: working array shorter than declared\"\n-\tzeroDiv = \"lapack: zero divisor\"\n-\n+\tbadApplyOrtho = \"lapack: bad ApplyOrtho\"","path":"lapack/gonum/errors.go","position":133,"original_position":133,"commit_id":"1e5aa6f10f1fbd60c2fda860f837bc1aea1f34ad","original_commit_id":"1e5aa6f10f1fbd60c2fda860f837bc1aea1f34ad","user":{"login":"vladimir-ch","id":1837502,"node_id":"MDQ6VXNlcjE4Mzc1MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1837502?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-ch","html_url":"https://github.com/vladimir-ch","followers_url":"https://api.github.com/users/vladimir-ch/followers","following_url":"https://api.github.com/users/vladimir-ch/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-ch/subscriptions","organizations_url":"https://api.github.com/users/vladimir-ch/orgs","repos_url":"https://api.github.com/users/vladimir-ch/repos","events_url":"https://api.github.com/users/vladimir-ch/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-ch/received_events","type":"User","site_admin":false},"body":"The first block are bad enum values, then bad general parameter values, bad vector increments, bad slice lengths, insufficient slice lengths, and bad leading dimensions. The order of the blocks is arbitrary.\r\n\r\nWithin a block the strings are ordered alphabetically.","created_at":"2019-03-07T14:26:02Z","updated_at":"2019-03-07T14:26:02Z","html_url":"https://github.com/gonum/gonum/pull/889#discussion_r263404417","pull_request_url":"https://api.github.com/repos/gonum/gonum/pulls/889","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gonum/gonum/pulls/comments/263404417"},"html":{"href":"https://github.com/gonum/gonum/pull/889#discussion_r263404417"},"pull_request":{"href":"https://api.github.com/repos/gonum/gonum/pulls/889"}},"in_reply_to_id":263324357},"pull_request":{"url":"https://api.github.com/repos/gonum/gonum/pulls/889","id":259045191,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MDQ1MTkx","html_url":"https://github.com/gonum/gonum/pull/889","diff_url":"https://github.com/gonum/gonum/pull/889.diff","patch_url":"https://github.com/gonum/gonum/pull/889.patch","issue_url":"https://api.github.com/repos/gonum/gonum/issues/889","number":889,"state":"open","locked":false,"title":"lapack/gonum: clean up panic strings and their usage","user":{"login":"vladimir-ch","id":1837502,"node_id":"MDQ6VXNlcjE4Mzc1MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1837502?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-ch","html_url":"https://github.com/vladimir-ch","followers_url":"https://api.github.com/users/vladimir-ch/followers","following_url":"https://api.github.com/users/vladimir-ch/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-ch/subscriptions","organizations_url":"https://api.github.com/users/vladimir-ch/orgs","repos_url":"https://api.github.com/users/vladimir-ch/repos","events_url":"https://api.github.com/users/vladimir-ch/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-ch/received_events","type":"User","site_admin":false},"body":"Please take a look.\r\n\r\n<!--\r\nChecklist:\r\n\r\n- API changes have been discussed\r\n- code is goformated correctly (goimports)\r\n- packages with generated code have had code generation run\r\n- tests pass locally\r\n- linked to relevant issues\r\n\r\nPlease make sure your commit message summary line and pull request\r\ntitle match the Go convention; a one-line summary of the change,\r\nprefixed by the primary affected package that should complete the\r\nsentence, \"This change modifies Gonum to _____.\"\r\n-->\r\n","created_at":"2019-03-07T10:01:48Z","updated_at":"2019-03-07T14:26:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26a6245da8cfeb664e02ae5e0c26b66975d17a0b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kortschak","id":275221,"node_id":"MDQ6VXNlcjI3NTIyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/275221?v=4","gravatar_id":"","url":"https://api.github.com/users/kortschak","html_url":"https://github.com/kortschak","followers_url":"https://api.github.com/users/kortschak/followers","following_url":"https://api.github.com/users/kortschak/following{/other_user}","gists_url":"https://api.github.com/users/kortschak/gists{/gist_id}","starred_url":"https://api.github.com/users/kortschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kortschak/subscriptions","organizations_url":"https://api.github.com/users/kortschak/orgs","repos_url":"https://api.github.com/users/kortschak/repos","events_url":"https://api.github.com/users/kortschak/events{/privacy}","received_events_url":"https://api.github.com/users/kortschak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gonum/gonum/pulls/889/commits","review_comments_url":"https://api.github.com/repos/gonum/gonum/pulls/889/comments","review_comment_url":"https://api.github.com/repos/gonum/gonum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gonum/gonum/issues/889/comments","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/1e5aa6f10f1fbd60c2fda860f837bc1aea1f34ad","head":{"label":"gonum:lapack/panic-strings-cleanup","ref":"lapack/panic-strings-cleanup","sha":"1e5aa6f10f1fbd60c2fda860f837bc1aea1f34ad","user":{"login":"gonum","id":3771091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzEwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":86164982,"node_id":"MDEwOlJlcG9zaXRvcnk4NjE2NDk4Mg==","name":"gonum","full_name":"gonum/gonum","private":false,"owner":{"login":"gonum","id":3771091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzEwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gonum/gonum","description":"Gonum is a set of numeric libraries for the Go programming language. It contains libraries for matrices, statistics, optimization, and more","fork":false,"url":"https://api.github.com/repos/gonum/gonum","forks_url":"https://api.github.com/repos/gonum/gonum/forks","keys_url":"https://api.github.com/repos/gonum/gonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/gonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/gonum/teams","hooks_url":"https://api.github.com/repos/gonum/gonum/hooks","issue_events_url":"https://api.github.com/repos/gonum/gonum/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/gonum/events","assignees_url":"https://api.github.com/repos/gonum/gonum/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/gonum/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/gonum/tags","blobs_url":"https://api.github.com/repos/gonum/gonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/gonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/gonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/gonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/gonum/languages","stargazers_url":"https://api.github.com/repos/gonum/gonum/stargazers","contributors_url":"https://api.github.com/repos/gonum/gonum/contributors","subscribers_url":"https://api.github.com/repos/gonum/gonum/subscribers","subscription_url":"https://api.github.com/repos/gonum/gonum/subscription","commits_url":"https://api.github.com/repos/gonum/gonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/gonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/gonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/gonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonum/gonum/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/gonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/gonum/merges","archive_url":"https://api.github.com/repos/gonum/gonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/gonum/downloads","issues_url":"https://api.github.com/repos/gonum/gonum/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/gonum/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/gonum/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/gonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/gonum/labels{/name}","releases_url":"https://api.github.com/repos/gonum/gonum/releases{/id}","deployments_url":"https://api.github.com/repos/gonum/gonum/deployments","created_at":"2017-03-25T14:54:38Z","updated_at":"2019-03-07T12:20:24Z","pushed_at":"2019-03-07T10:40:33Z","git_url":"git://github.com/gonum/gonum.git","ssh_url":"git@github.com:gonum/gonum.git","clone_url":"https://github.com/gonum/gonum.git","svn_url":"https://github.com/gonum/gonum","homepage":"https://www.gonum.org/","size":12414,"stargazers_count":2456,"watchers_count":2456,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":179,"open_issues":168,"watchers":2456,"default_branch":"master"}},"base":{"label":"gonum:master","ref":"master","sha":"3b3c374240fbc4e0a1fa4e1311384e83cf296f54","user":{"login":"gonum","id":3771091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzEwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":86164982,"node_id":"MDEwOlJlcG9zaXRvcnk4NjE2NDk4Mg==","name":"gonum","full_name":"gonum/gonum","private":false,"owner":{"login":"gonum","id":3771091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzEwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gonum/gonum","description":"Gonum is a set of numeric libraries for the Go programming language. It contains libraries for matrices, statistics, optimization, and more","fork":false,"url":"https://api.github.com/repos/gonum/gonum","forks_url":"https://api.github.com/repos/gonum/gonum/forks","keys_url":"https://api.github.com/repos/gonum/gonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/gonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/gonum/teams","hooks_url":"https://api.github.com/repos/gonum/gonum/hooks","issue_events_url":"https://api.github.com/repos/gonum/gonum/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/gonum/events","assignees_url":"https://api.github.com/repos/gonum/gonum/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/gonum/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/gonum/tags","blobs_url":"https://api.github.com/repos/gonum/gonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/gonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/gonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/gonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/gonum/languages","stargazers_url":"https://api.github.com/repos/gonum/gonum/stargazers","contributors_url":"https://api.github.com/repos/gonum/gonum/contributors","subscribers_url":"https://api.github.com/repos/gonum/gonum/subscribers","subscription_url":"https://api.github.com/repos/gonum/gonum/subscription","commits_url":"https://api.github.com/repos/gonum/gonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/gonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/gonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/gonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonum/gonum/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/gonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/gonum/merges","archive_url":"https://api.github.com/repos/gonum/gonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/gonum/downloads","issues_url":"https://api.github.com/repos/gonum/gonum/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/gonum/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/gonum/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/gonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/gonum/labels{/name}","releases_url":"https://api.github.com/repos/gonum/gonum/releases{/id}","deployments_url":"https://api.github.com/repos/gonum/gonum/deployments","created_at":"2017-03-25T14:54:38Z","updated_at":"2019-03-07T12:20:24Z","pushed_at":"2019-03-07T10:40:33Z","git_url":"git://github.com/gonum/gonum.git","ssh_url":"git@github.com:gonum/gonum.git","clone_url":"https://github.com/gonum/gonum.git","svn_url":"https://github.com/gonum/gonum","homepage":"https://www.gonum.org/","size":12414,"stargazers_count":2456,"watchers_count":2456,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":179,"open_issues":168,"watchers":2456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gonum/gonum/pulls/889"},"html":{"href":"https://github.com/gonum/gonum/pull/889"},"issue":{"href":"https://api.github.com/repos/gonum/gonum/issues/889"},"comments":{"href":"https://api.github.com/repos/gonum/gonum/issues/889/comments"},"review_comments":{"href":"https://api.github.com/repos/gonum/gonum/pulls/889/comments"},"review_comment":{"href":"https://api.github.com/repos/gonum/gonum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gonum/gonum/pulls/889/commits"},"statuses":{"href":"https://api.github.com/repos/gonum/gonum/statuses/1e5aa6f10f1fbd60c2fda860f837bc1aea1f34ad"}},"author_association":"MEMBER"}}
|
{
"id": 86164982,
"name": "gonum/gonum",
"url": "https://api.github.com/repos/gonum/gonum"
}
|
{
"id": 1837502,
"login": "vladimir-ch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1837502?",
"url": "https://api.github.com/users/vladimir-ch"
}
|
{
"id": 3771091,
"login": "gonum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3771091?",
"url": "https://api.github.com/orgs/gonum"
}
| 2019-03-07T14:26:02 |
9199190824
|
{"actor":{"display_login":"vladimir-ch"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/freenas/freenas-docs/pulls/comments/299559043","pull_request_review_id":256990005,"id":299559043,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTU1OTA0Mw==","diff_hunk":"@@ -117,8 +117,15 @@ These major features are new in this version:\n :menuselection:`System --> SSH Keypairs`\n screens.\n \n+* :ref:`Configuring reporting graphs <Configure Reporting>` has been\n+ added with a new menu option added to","path":"userguide/intro.rst","position":5,"original_position":5,"commit_id":"8531a8cde7e5873858589f1e9db55204d22ec64c","original_commit_id":"8531a8cde7e5873858589f1e9db55204d22ec64c","user":{"login":"wblock","id":222640,"node_id":"MDQ6VXNlcjIyMjY0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/222640?v=4","gravatar_id":"","url":"https://api.github.com/users/wblock","html_url":"https://github.com/wblock","followers_url":"https://api.github.com/users/wblock/followers","following_url":"https://api.github.com/users/wblock/following{/other_user}","gists_url":"https://api.github.com/users/wblock/gists{/gist_id}","starred_url":"https://api.github.com/users/wblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wblock/subscriptions","organizations_url":"https://api.github.com/users/wblock/orgs","repos_url":"https://api.github.com/users/wblock/repos","events_url":"https://api.github.com/users/wblock/events{/privacy}","received_events_url":"https://api.github.com/users/wblock/received_events","type":"User","site_admin":false},"body":"The two instances of \"added\" are confusing. Is it clearer to say\r\n`` \"A new menu option in :menuselection:... allows :ref:`configuring reporting graphs <Configure Reporting>`.\" ``","created_at":"2019-07-02T15:55:04Z","updated_at":"2019-07-02T15:55:29Z","html_url":"https://github.com/freenas/freenas-docs/pull/1215#discussion_r299559043","pull_request_url":"https://api.github.com/repos/freenas/freenas-docs/pulls/1215","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/comments/299559043"},"html":{"href":"https://github.com/freenas/freenas-docs/pull/1215#discussion_r299559043"},"pull_request":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/1215"}}},"pull_request":{"url":"https://api.github.com/repos/freenas/freenas-docs/pulls/1215","id":291672378,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxNjcyMzc4","html_url":"https://github.com/freenas/freenas-docs/pull/1215","diff_url":"https://github.com/freenas/freenas-docs/pull/1215.diff","patch_url":"https://github.com/freenas/freenas-docs/pull/1215.patch","issue_url":"https://api.github.com/repos/freenas/freenas-docs/issues/1215","number":1215,"state":"open","locked":false,"title":"NAS-100038: Add new System > Reporting screen to legacy UI docs","user":{"login":"Mrt134","id":17933320,"node_id":"MDQ6VXNlcjE3OTMzMzIw","avatar_url":"https://avatars2.githubusercontent.com/u/17933320?v=4","gravatar_id":"","url":"https://api.github.com/users/Mrt134","html_url":"https://github.com/Mrt134","followers_url":"https://api.github.com/users/Mrt134/followers","following_url":"https://api.github.com/users/Mrt134/following{/other_user}","gists_url":"https://api.github.com/users/Mrt134/gists{/gist_id}","starred_url":"https://api.github.com/users/Mrt134/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mrt134/subscriptions","organizations_url":"https://api.github.com/users/Mrt134/orgs","repos_url":"https://api.github.com/users/Mrt134/repos","events_url":"https://api.github.com/users/Mrt134/events{/privacy}","received_events_url":"https://api.github.com/users/Mrt134/received_events","type":"User","site_admin":false},"body":"Add intro entry for this new menu option and add note for collectd storage location.\r\nAdd new Reporting subsection to system.rst\r\nAdd image of the new screen.\r\nAdd table and describe the new options.\r\nHTML build test: no issues.","created_at":"2019-06-25T18:09:00Z","updated_at":"2019-07-02T15:55:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72257a90a1e1892bc3e327a3d696339cf7865693","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1382447795,"node_id":"MDU6TGFiZWwxMzgyNDQ3Nzk1","url":"https://api.github.com/repos/freenas/freenas-docs/labels/11.3%20Beta%201","name":"11.3 Beta 1","color":"f99af5","default":false},{"id":1179128417,"node_id":"MDU6TGFiZWwxMTc5MTI4NDE3","url":"https://api.github.com/repos/freenas/freenas-docs/labels/FN/TN","name":"FN/TN","color":"0052cc","default":false},{"id":407715382,"node_id":"MDU6TGFiZWw0MDc3MTUzODI=","url":"https://api.github.com/repos/freenas/freenas-docs/labels/Master","name":"Master","color":"cc317c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/freenas/freenas-docs/pulls/1215/commits","review_comments_url":"https://api.github.com/repos/freenas/freenas-docs/pulls/1215/comments","review_comment_url":"https://api.github.com/repos/freenas/freenas-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freenas/freenas-docs/issues/1215/comments","statuses_url":"https://api.github.com/repos/freenas/freenas-docs/statuses/8531a8cde7e5873858589f1e9db55204d22ec64c","head":{"label":"freenas:nas100038-reporting-changes","ref":"nas100038-reporting-changes","sha":"8531a8cde7e5873858589f1e9db55204d22ec64c","user":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":63272790,"node_id":"MDEwOlJlcG9zaXRvcnk2MzI3Mjc5MA==","name":"freenas-docs","full_name":"freenas/freenas-docs","private":false,"owner":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freenas/freenas-docs","description":"FreeNAS & TrueNAS Guides","fork":false,"url":"https://api.github.com/repos/freenas/freenas-docs","forks_url":"https://api.github.com/repos/freenas/freenas-docs/forks","keys_url":"https://api.github.com/repos/freenas/freenas-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/freenas-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/freenas-docs/teams","hooks_url":"https://api.github.com/repos/freenas/freenas-docs/hooks","issue_events_url":"https://api.github.com/repos/freenas/freenas-docs/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/freenas-docs/events","assignees_url":"https://api.github.com/repos/freenas/freenas-docs/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/freenas-docs/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/freenas-docs/tags","blobs_url":"https://api.github.com/repos/freenas/freenas-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/freenas-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/freenas-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/freenas-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/freenas-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/freenas-docs/languages","stargazers_url":"https://api.github.com/repos/freenas/freenas-docs/stargazers","contributors_url":"https://api.github.com/repos/freenas/freenas-docs/contributors","subscribers_url":"https://api.github.com/repos/freenas/freenas-docs/subscribers","subscription_url":"https://api.github.com/repos/freenas/freenas-docs/subscription","commits_url":"https://api.github.com/repos/freenas/freenas-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/freenas-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/freenas-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/freenas-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/freenas-docs/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/freenas-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/freenas-docs/merges","archive_url":"https://api.github.com/repos/freenas/freenas-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/freenas-docs/downloads","issues_url":"https://api.github.com/repos/freenas/freenas-docs/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/freenas-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/freenas-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/freenas-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/freenas-docs/labels{/name}","releases_url":"https://api.github.com/repos/freenas/freenas-docs/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/freenas-docs/deployments","created_at":"2016-07-13T19:12:31Z","updated_at":"2019-06-28T11:29:04Z","pushed_at":"2019-07-02T15:52:01Z","git_url":"git://github.com/freenas/freenas-docs.git","ssh_url":"git@github.com:freenas/freenas-docs.git","clone_url":"https://github.com/freenas/freenas-docs.git","svn_url":"https://github.com/freenas/freenas-docs","homepage":null,"size":450680,"stargazers_count":16,"watchers_count":16,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":45,"license":null,"forks":27,"open_issues":45,"watchers":16,"default_branch":"master"}},"base":{"label":"freenas:master","ref":"master","sha":"474311ba7886003e4afe0c96f99afee5dc36722f","user":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":63272790,"node_id":"MDEwOlJlcG9zaXRvcnk2MzI3Mjc5MA==","name":"freenas-docs","full_name":"freenas/freenas-docs","private":false,"owner":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freenas/freenas-docs","description":"FreeNAS & TrueNAS Guides","fork":false,"url":"https://api.github.com/repos/freenas/freenas-docs","forks_url":"https://api.github.com/repos/freenas/freenas-docs/forks","keys_url":"https://api.github.com/repos/freenas/freenas-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/freenas-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/freenas-docs/teams","hooks_url":"https://api.github.com/repos/freenas/freenas-docs/hooks","issue_events_url":"https://api.github.com/repos/freenas/freenas-docs/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/freenas-docs/events","assignees_url":"https://api.github.com/repos/freenas/freenas-docs/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/freenas-docs/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/freenas-docs/tags","blobs_url":"https://api.github.com/repos/freenas/freenas-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/freenas-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/freenas-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/freenas-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/freenas-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/freenas-docs/languages","stargazers_url":"https://api.github.com/repos/freenas/freenas-docs/stargazers","contributors_url":"https://api.github.com/repos/freenas/freenas-docs/contributors","subscribers_url":"https://api.github.com/repos/freenas/freenas-docs/subscribers","subscription_url":"https://api.github.com/repos/freenas/freenas-docs/subscription","commits_url":"https://api.github.com/repos/freenas/freenas-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/freenas-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/freenas-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/freenas-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/freenas-docs/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/freenas-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/freenas-docs/merges","archive_url":"https://api.github.com/repos/freenas/freenas-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/freenas-docs/downloads","issues_url":"https://api.github.com/repos/freenas/freenas-docs/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/freenas-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/freenas-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/freenas-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/freenas-docs/labels{/name}","releases_url":"https://api.github.com/repos/freenas/freenas-docs/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/freenas-docs/deployments","created_at":"2016-07-13T19:12:31Z","updated_at":"2019-06-28T11:29:04Z","pushed_at":"2019-07-02T15:52:01Z","git_url":"git://github.com/freenas/freenas-docs.git","ssh_url":"git@github.com:freenas/freenas-docs.git","clone_url":"https://github.com/freenas/freenas-docs.git","svn_url":"https://github.com/freenas/freenas-docs","homepage":null,"size":450680,"stargazers_count":16,"watchers_count":16,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":45,"license":null,"forks":27,"open_issues":45,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/1215"},"html":{"href":"https://github.com/freenas/freenas-docs/pull/1215"},"issue":{"href":"https://api.github.com/repos/freenas/freenas-docs/issues/1215"},"comments":{"href":"https://api.github.com/repos/freenas/freenas-docs/issues/1215/comments"},"review_comments":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/1215/comments"},"review_comment":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/1215/commits"},"statuses":{"href":"https://api.github.com/repos/freenas/freenas-docs/statuses/8531a8cde7e5873858589f1e9db55204d22ec64c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 63272790,
"name": "freenas/freenas-docs",
"url": "https://api.github.com/repos/freenas/freenas-docs"
}
|
{
"id": 222640,
"login": "wblock",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/222640?",
"url": "https://api.github.com/users/wblock"
}
|
{
"id": 3792476,
"login": "freenas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3792476?",
"url": "https://api.github.com/orgs/freenas"
}
| 2019-07-02T15:55:04 |
9935168936
|
{"actor":{"display_login":"wblock"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/comments/324173985","pull_request_review_id":287990819,"id":324173985,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDE3Mzk4NQ==","diff_hunk":"@@ -0,0 +1,50 @@\n+\"\"\"\n+\n+Subsidiary handlers for the fork system call. The main handler is implemented by NaCl.\n+\n+Called from dispatcher.repy\n+\n+Safe version checks all parameters, then calls real handler that forks the file system.\n+\n+Fork handler pulls out the arguments, does any manditory checking\n+then calls the repy posix library fork system call. Then packs\n+the result back up.\n+\n+\"\"\"\n+def lind_fs_fork(args):\n+ \"\"\" fork calls are dispatched to this function.\n+\n+ See dispatcher.repy for details.\n+\n+ Given the cageid of the child process, fork the file table.\n+\n+ Pack the single int returned, or error.\n+ \"\"\"\n+ cagenum = args[0]\n+ try:\n+ result = get_fs_call(args[-1],\"fork_syscall\")(cagenum)\n+ except SyscallError, e:\n+ message = \"Encountered error in fork.\\n Parent Cageid: \" + args[-1] + \\\n+ \"\\nChild Cageid: \" + cagenum\n+ return ErrorResponseBuilder(\"fs_fork\", e[1], message)\n+ return SuccessResponseBuilder(\"fs_fork\", result)\n+\n+def lind_safe_fs_fork(args):\n+ \"\"\" Safely wrap the fork call.\n+\n+ See dispatcher.repy for details.\n+\n+ Check the child's cageid for consistancy,","path":"seattlelib/fs_fork.repy","position":37,"original_position":37,"commit_id":"a6458f74c171bd516363b04e32fcc7717fcd8392","original_commit_id":"a6458f74c171bd516363b04e32fcc7717fcd8392","user":{"login":"jesings","id":34111484,"node_id":"MDQ6VXNlcjM0MTExNDg0","avatar_url":"https://avatars3.githubusercontent.com/u/34111484?v=4","gravatar_id":"","url":"https://api.github.com/users/jesings","html_url":"https://github.com/jesings","followers_url":"https://api.github.com/users/jesings/followers","following_url":"https://api.github.com/users/jesings/following{/other_user}","gists_url":"https://api.github.com/users/jesings/gists{/gist_id}","starred_url":"https://api.github.com/users/jesings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesings/subscriptions","organizations_url":"https://api.github.com/users/jesings/orgs","repos_url":"https://api.github.com/users/jesings/repos","events_url":"https://api.github.com/users/jesings/events{/privacy}","received_events_url":"https://api.github.com/users/jesings/received_events","type":"User","site_admin":false},"body":"Same deal as above, this was copy pasted","created_at":"2019-09-13T12:42:20Z","updated_at":"2019-09-13T12:42:20Z","html_url":"https://github.com/Lind-Project/nacl_repy/pull/14#discussion_r324173985","pull_request_url":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/14","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/comments/324173985"},"html":{"href":"https://github.com/Lind-Project/nacl_repy/pull/14#discussion_r324173985"},"pull_request":{"href":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/14"}},"in_reply_to_id":324132366},"pull_request":{"url":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/14","id":313736352,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzNzM2MzUy","html_url":"https://github.com/Lind-Project/nacl_repy/pull/14","diff_url":"https://github.com/Lind-Project/nacl_repy/pull/14.diff","patch_url":"https://github.com/Lind-Project/nacl_repy/pull/14.patch","issue_url":"https://api.github.com/repos/Lind-Project/nacl_repy/issues/14","number":14,"state":"open","locked":false,"title":"Cageid","user":{"login":"rennergade","id":7719272,"node_id":"MDQ6VXNlcjc3MTkyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/7719272?v=4","gravatar_id":"","url":"https://api.github.com/users/rennergade","html_url":"https://github.com/rennergade","followers_url":"https://api.github.com/users/rennergade/followers","following_url":"https://api.github.com/users/rennergade/following{/other_user}","gists_url":"https://api.github.com/users/rennergade/gists{/gist_id}","starred_url":"https://api.github.com/users/rennergade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rennergade/subscriptions","organizations_url":"https://api.github.com/users/rennergade/orgs","repos_url":"https://api.github.com/users/rennergade/repos","events_url":"https://api.github.com/users/rennergade/events{/privacy}","received_events_url":"https://api.github.com/users/rennergade/received_events","type":"User","site_admin":false},"body":"Per [Lind Issue 14](https://github.com/Lind-Project/lind_project/issues/14)\r\n\r\n- Creates \"per-process\" master fdtable\r\n- Adds Fork() system call to SafePOSIX, which deep copies the parent process's fdtable to a new fdtable. \r\n- Accepts cageid from system calls via RPC\r\n- Uses closure to set fd system in context of current transmitted cageid","created_at":"2019-09-03T19:39:46Z","updated_at":"2019-09-13T12:42:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d94c18d09c3a83c777d02145d2e14960b66f5264","assignee":{"login":"rennergade","id":7719272,"node_id":"MDQ6VXNlcjc3MTkyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/7719272?v=4","gravatar_id":"","url":"https://api.github.com/users/rennergade","html_url":"https://github.com/rennergade","followers_url":"https://api.github.com/users/rennergade/followers","following_url":"https://api.github.com/users/rennergade/following{/other_user}","gists_url":"https://api.github.com/users/rennergade/gists{/gist_id}","starred_url":"https://api.github.com/users/rennergade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rennergade/subscriptions","organizations_url":"https://api.github.com/users/rennergade/orgs","repos_url":"https://api.github.com/users/rennergade/repos","events_url":"https://api.github.com/users/rennergade/events{/privacy}","received_events_url":"https://api.github.com/users/rennergade/received_events","type":"User","site_admin":false},"assignees":[{"login":"rennergade","id":7719272,"node_id":"MDQ6VXNlcjc3MTkyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/7719272?v=4","gravatar_id":"","url":"https://api.github.com/users/rennergade","html_url":"https://github.com/rennergade","followers_url":"https://api.github.com/users/rennergade/followers","following_url":"https://api.github.com/users/rennergade/following{/other_user}","gists_url":"https://api.github.com/users/rennergade/gists{/gist_id}","starred_url":"https://api.github.com/users/rennergade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rennergade/subscriptions","organizations_url":"https://api.github.com/users/rennergade/orgs","repos_url":"https://api.github.com/users/rennergade/repos","events_url":"https://api.github.com/users/rennergade/events{/privacy}","received_events_url":"https://api.github.com/users/rennergade/received_events","type":"User","site_admin":false},{"login":"jesings","id":34111484,"node_id":"MDQ6VXNlcjM0MTExNDg0","avatar_url":"https://avatars3.githubusercontent.com/u/34111484?v=4","gravatar_id":"","url":"https://api.github.com/users/jesings","html_url":"https://github.com/jesings","followers_url":"https://api.github.com/users/jesings/followers","following_url":"https://api.github.com/users/jesings/following{/other_user}","gists_url":"https://api.github.com/users/jesings/gists{/gist_id}","starred_url":"https://api.github.com/users/jesings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesings/subscriptions","organizations_url":"https://api.github.com/users/jesings/orgs","repos_url":"https://api.github.com/users/jesings/repos","events_url":"https://api.github.com/users/jesings/events{/privacy}","received_events_url":"https://api.github.com/users/jesings/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"moyix","id":34380,"node_id":"MDQ6VXNlcjM0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/34380?v=4","gravatar_id":"","url":"https://api.github.com/users/moyix","html_url":"https://github.com/moyix","followers_url":"https://api.github.com/users/moyix/followers","following_url":"https://api.github.com/users/moyix/following{/other_user}","gists_url":"https://api.github.com/users/moyix/gists{/gist_id}","starred_url":"https://api.github.com/users/moyix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moyix/subscriptions","organizations_url":"https://api.github.com/users/moyix/orgs","repos_url":"https://api.github.com/users/moyix/repos","events_url":"https://api.github.com/users/moyix/events{/privacy}","received_events_url":"https://api.github.com/users/moyix/received_events","type":"User","site_admin":false},{"login":"JustinCappos","id":857871,"node_id":"MDQ6VXNlcjg1Nzg3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/857871?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinCappos","html_url":"https://github.com/JustinCappos","followers_url":"https://api.github.com/users/JustinCappos/followers","following_url":"https://api.github.com/users/JustinCappos/following{/other_user}","gists_url":"https://api.github.com/users/JustinCappos/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinCappos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinCappos/subscriptions","organizations_url":"https://api.github.com/users/JustinCappos/orgs","repos_url":"https://api.github.com/users/JustinCappos/repos","events_url":"https://api.github.com/users/JustinCappos/events{/privacy}","received_events_url":"https://api.github.com/users/JustinCappos/received_events","type":"User","site_admin":false},{"login":"jesings","id":34111484,"node_id":"MDQ6VXNlcjM0MTExNDg0","avatar_url":"https://avatars3.githubusercontent.com/u/34111484?v=4","gravatar_id":"","url":"https://api.github.com/users/jesings","html_url":"https://github.com/jesings","followers_url":"https://api.github.com/users/jesings/followers","following_url":"https://api.github.com/users/jesings/following{/other_user}","gists_url":"https://api.github.com/users/jesings/gists{/gist_id}","starred_url":"https://api.github.com/users/jesings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesings/subscriptions","organizations_url":"https://api.github.com/users/jesings/orgs","repos_url":"https://api.github.com/users/jesings/repos","events_url":"https://api.github.com/users/jesings/events{/privacy}","received_events_url":"https://api.github.com/users/jesings/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/14/commits","review_comments_url":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/14/comments","review_comment_url":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lind-Project/nacl_repy/issues/14/comments","statuses_url":"https://api.github.com/repos/Lind-Project/nacl_repy/statuses/a6458f74c171bd516363b04e32fcc7717fcd8392","head":{"label":"Lind-Project:cageid","ref":"cageid","sha":"a6458f74c171bd516363b04e32fcc7717fcd8392","user":{"login":"Lind-Project","id":3805527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3805527?v=4","gravatar_id":"","url":"https://api.github.com/users/Lind-Project","html_url":"https://github.com/Lind-Project","followers_url":"https://api.github.com/users/Lind-Project/followers","following_url":"https://api.github.com/users/Lind-Project/following{/other_user}","gists_url":"https://api.github.com/users/Lind-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/Lind-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lind-Project/subscriptions","organizations_url":"https://api.github.com/users/Lind-Project/orgs","repos_url":"https://api.github.com/users/Lind-Project/repos","events_url":"https://api.github.com/users/Lind-Project/events{/privacy}","received_events_url":"https://api.github.com/users/Lind-Project/received_events","type":"Organization","site_admin":false},"repo":{"id":9251346,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUxMzQ2","name":"nacl_repy","full_name":"Lind-Project/nacl_repy","private":false,"owner":{"login":"Lind-Project","id":3805527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3805527?v=4","gravatar_id":"","url":"https://api.github.com/users/Lind-Project","html_url":"https://github.com/Lind-Project","followers_url":"https://api.github.com/users/Lind-Project/followers","following_url":"https://api.github.com/users/Lind-Project/following{/other_user}","gists_url":"https://api.github.com/users/Lind-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/Lind-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lind-Project/subscriptions","organizations_url":"https://api.github.com/users/Lind-Project/orgs","repos_url":"https://api.github.com/users/Lind-Project/repos","events_url":"https://api.github.com/users/Lind-Project/events{/privacy}","received_events_url":"https://api.github.com/users/Lind-Project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Lind-Project/nacl_repy","description":"NaCl Repy","fork":false,"url":"https://api.github.com/repos/Lind-Project/nacl_repy","forks_url":"https://api.github.com/repos/Lind-Project/nacl_repy/forks","keys_url":"https://api.github.com/repos/Lind-Project/nacl_repy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lind-Project/nacl_repy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lind-Project/nacl_repy/teams","hooks_url":"https://api.github.com/repos/Lind-Project/nacl_repy/hooks","issue_events_url":"https://api.github.com/repos/Lind-Project/nacl_repy/issues/events{/number}","events_url":"https://api.github.com/repos/Lind-Project/nacl_repy/events","assignees_url":"https://api.github.com/repos/Lind-Project/nacl_repy/assignees{/user}","branches_url":"https://api.github.com/repos/Lind-Project/nacl_repy/branches{/branch}","tags_url":"https://api.github.com/repos/Lind-Project/nacl_repy/tags","blobs_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lind-Project/nacl_repy/statuses/{sha}","languages_url":"https://api.github.com/repos/Lind-Project/nacl_repy/languages","stargazers_url":"https://api.github.com/repos/Lind-Project/nacl_repy/stargazers","contributors_url":"https://api.github.com/repos/Lind-Project/nacl_repy/contributors","subscribers_url":"https://api.github.com/repos/Lind-Project/nacl_repy/subscribers","subscription_url":"https://api.github.com/repos/Lind-Project/nacl_repy/subscription","commits_url":"https://api.github.com/repos/Lind-Project/nacl_repy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lind-Project/nacl_repy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lind-Project/nacl_repy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lind-Project/nacl_repy/contents/{+path}","compare_url":"https://api.github.com/repos/Lind-Project/nacl_repy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lind-Project/nacl_repy/merges","archive_url":"https://api.github.com/repos/Lind-Project/nacl_repy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lind-Project/nacl_repy/downloads","issues_url":"https://api.github.com/repos/Lind-Project/nacl_repy/issues{/number}","pulls_url":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls{/number}","milestones_url":"https://api.github.com/repos/Lind-Project/nacl_repy/milestones{/number}","notifications_url":"https://api.github.com/repos/Lind-Project/nacl_repy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lind-Project/nacl_repy/labels{/name}","releases_url":"https://api.github.com/repos/Lind-Project/nacl_repy/releases{/id}","deployments_url":"https://api.github.com/repos/Lind-Project/nacl_repy/deployments","created_at":"2013-04-05T21:46:41Z","updated_at":"2018-06-16T18:01:37Z","pushed_at":"2019-09-13T00:10:10Z","git_url":"git://github.com/Lind-Project/nacl_repy.git","ssh_url":"git@github.com:Lind-Project/nacl_repy.git","clone_url":"https://github.com/Lind-Project/nacl_repy.git","svn_url":"https://github.com/Lind-Project/nacl_repy","homepage":null,"size":2448,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":2,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"Lind-Project:develop","ref":"develop","sha":"f4a4cc314e9fb554feb05747fa7595a64a0a250b","user":{"login":"Lind-Project","id":3805527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3805527?v=4","gravatar_id":"","url":"https://api.github.com/users/Lind-Project","html_url":"https://github.com/Lind-Project","followers_url":"https://api.github.com/users/Lind-Project/followers","following_url":"https://api.github.com/users/Lind-Project/following{/other_user}","gists_url":"https://api.github.com/users/Lind-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/Lind-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lind-Project/subscriptions","organizations_url":"https://api.github.com/users/Lind-Project/orgs","repos_url":"https://api.github.com/users/Lind-Project/repos","events_url":"https://api.github.com/users/Lind-Project/events{/privacy}","received_events_url":"https://api.github.com/users/Lind-Project/received_events","type":"Organization","site_admin":false},"repo":{"id":9251346,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUxMzQ2","name":"nacl_repy","full_name":"Lind-Project/nacl_repy","private":false,"owner":{"login":"Lind-Project","id":3805527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3805527?v=4","gravatar_id":"","url":"https://api.github.com/users/Lind-Project","html_url":"https://github.com/Lind-Project","followers_url":"https://api.github.com/users/Lind-Project/followers","following_url":"https://api.github.com/users/Lind-Project/following{/other_user}","gists_url":"https://api.github.com/users/Lind-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/Lind-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lind-Project/subscriptions","organizations_url":"https://api.github.com/users/Lind-Project/orgs","repos_url":"https://api.github.com/users/Lind-Project/repos","events_url":"https://api.github.com/users/Lind-Project/events{/privacy}","received_events_url":"https://api.github.com/users/Lind-Project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Lind-Project/nacl_repy","description":"NaCl Repy","fork":false,"url":"https://api.github.com/repos/Lind-Project/nacl_repy","forks_url":"https://api.github.com/repos/Lind-Project/nacl_repy/forks","keys_url":"https://api.github.com/repos/Lind-Project/nacl_repy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lind-Project/nacl_repy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lind-Project/nacl_repy/teams","hooks_url":"https://api.github.com/repos/Lind-Project/nacl_repy/hooks","issue_events_url":"https://api.github.com/repos/Lind-Project/nacl_repy/issues/events{/number}","events_url":"https://api.github.com/repos/Lind-Project/nacl_repy/events","assignees_url":"https://api.github.com/repos/Lind-Project/nacl_repy/assignees{/user}","branches_url":"https://api.github.com/repos/Lind-Project/nacl_repy/branches{/branch}","tags_url":"https://api.github.com/repos/Lind-Project/nacl_repy/tags","blobs_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lind-Project/nacl_repy/statuses/{sha}","languages_url":"https://api.github.com/repos/Lind-Project/nacl_repy/languages","stargazers_url":"https://api.github.com/repos/Lind-Project/nacl_repy/stargazers","contributors_url":"https://api.github.com/repos/Lind-Project/nacl_repy/contributors","subscribers_url":"https://api.github.com/repos/Lind-Project/nacl_repy/subscribers","subscription_url":"https://api.github.com/repos/Lind-Project/nacl_repy/subscription","commits_url":"https://api.github.com/repos/Lind-Project/nacl_repy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lind-Project/nacl_repy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lind-Project/nacl_repy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lind-Project/nacl_repy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lind-Project/nacl_repy/contents/{+path}","compare_url":"https://api.github.com/repos/Lind-Project/nacl_repy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lind-Project/nacl_repy/merges","archive_url":"https://api.github.com/repos/Lind-Project/nacl_repy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lind-Project/nacl_repy/downloads","issues_url":"https://api.github.com/repos/Lind-Project/nacl_repy/issues{/number}","pulls_url":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls{/number}","milestones_url":"https://api.github.com/repos/Lind-Project/nacl_repy/milestones{/number}","notifications_url":"https://api.github.com/repos/Lind-Project/nacl_repy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lind-Project/nacl_repy/labels{/name}","releases_url":"https://api.github.com/repos/Lind-Project/nacl_repy/releases{/id}","deployments_url":"https://api.github.com/repos/Lind-Project/nacl_repy/deployments","created_at":"2013-04-05T21:46:41Z","updated_at":"2018-06-16T18:01:37Z","pushed_at":"2019-09-13T00:10:10Z","git_url":"git://github.com/Lind-Project/nacl_repy.git","ssh_url":"git@github.com:Lind-Project/nacl_repy.git","clone_url":"https://github.com/Lind-Project/nacl_repy.git","svn_url":"https://github.com/Lind-Project/nacl_repy","homepage":null,"size":2448,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":2,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/14"},"html":{"href":"https://github.com/Lind-Project/nacl_repy/pull/14"},"issue":{"href":"https://api.github.com/repos/Lind-Project/nacl_repy/issues/14"},"comments":{"href":"https://api.github.com/repos/Lind-Project/nacl_repy/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lind-Project/nacl_repy/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/Lind-Project/nacl_repy/statuses/a6458f74c171bd516363b04e32fcc7717fcd8392"}},"author_association":"NONE"}}
|
{
"id": 9251346,
"name": "Lind-Project/nacl_repy",
"url": "https://api.github.com/repos/Lind-Project/nacl_repy"
}
|
{
"id": 34111484,
"login": "jesings",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34111484?",
"url": "https://api.github.com/users/jesings"
}
|
{
"id": 3805527,
"login": "Lind-Project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3805527?",
"url": "https://api.github.com/orgs/Lind-Project"
}
| 2019-09-13T12:42:20 |
10410920199
|
{"actor":{"display_login":"jesings"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/openstax/rex-web/pulls/comments/364295145","pull_request_review_id":339949522,"id":364295145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDI5NTE0NQ==","diff_hunk":"@@ -0,0 +1,136 @@\n+import React from 'react';\n+import { FormattedMessage } from 'react-intl';\n+import { useSelector } from 'react-redux';\n+import myHighlightsEmptyImage from '../../../../assets/MHpage-empty-logged-in.png';\n+import htmlMessage from '../../../components/htmlMessage';\n+import Loader from '../../../components/Loader';\n+import { assertDefined } from '../../../utils';\n+import { LinkedArchiveTreeNode } from '../../types';\n+import { archiveTreeSectionIsChapter, findArchiveTreeNode } from '../../utils/archiveTreeUtils';\n+import { stripIdVersion } from '../../utils/idUtils';\n+import { highlightLocationFilters, summaryFilters, summaryHighlights, summaryIsLoading } from '../selectors';\n+import { SummaryHighlights } from '../types';\n+import * as HStyled from './HighlightStyles';\n+import * as Styled from './ShowMyHighlightsStyles';\n+\n+// tslint:disable-next-line: variable-name\n+const NoHighlightsTip = htmlMessage(\n+ 'i18n:toolbar:highlights:popup:heading:no-highlights-tip',\n+ () => <span/>","path":"src/app/content/highlights/components/Highlights.tsx","position":19,"original_position":19,"commit_id":"ff663e3595c5ae6321dda244aaf3accc6afe5155","original_commit_id":"da88b1b9bd9681c909b02cc446d63ad32daf986f","user":{"login":"PiotrKozlowski","id":31478212,"node_id":"MDQ6VXNlcjMxNDc4MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/31478212?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrKozlowski","html_url":"https://github.com/PiotrKozlowski","followers_url":"https://api.github.com/users/PiotrKozlowski/followers","following_url":"https://api.github.com/users/PiotrKozlowski/following{/other_user}","gists_url":"https://api.github.com/users/PiotrKozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrKozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrKozlowski/subscriptions","organizations_url":"https://api.github.com/users/PiotrKozlowski/orgs","repos_url":"https://api.github.com/users/PiotrKozlowski/repos","events_url":"https://api.github.com/users/PiotrKozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrKozlowski/received_events","type":"User","site_admin":false},"body":"Not sure what you want me to do here","created_at":"2020-01-08T15:38:58Z","updated_at":"2020-01-08T15:38:58Z","html_url":"https://github.com/openstax/rex-web/pull/398#discussion_r364295145","pull_request_url":"https://api.github.com/repos/openstax/rex-web/pulls/398","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openstax/rex-web/pulls/comments/364295145"},"html":{"href":"https://github.com/openstax/rex-web/pull/398#discussion_r364295145"},"pull_request":{"href":"https://api.github.com/repos/openstax/rex-web/pulls/398"}},"in_reply_to_id":364262245},"pull_request":{"url":"https://api.github.com/repos/openstax/rex-web/pulls/398","id":352961638,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyOTYxNjM4","html_url":"https://github.com/openstax/rex-web/pull/398","diff_url":"https://github.com/openstax/rex-web/pull/398.diff","patch_url":"https://github.com/openstax/rex-web/pull/398.patch","issue_url":"https://api.github.com/repos/openstax/rex-web/issues/398","number":398,"state":"open","locked":false,"title":"Filters","user":{"login":"PiotrKozlowski","id":31478212,"node_id":"MDQ6VXNlcjMxNDc4MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/31478212?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrKozlowski","html_url":"https://github.com/PiotrKozlowski","followers_url":"https://api.github.com/users/PiotrKozlowski/followers","following_url":"https://api.github.com/users/PiotrKozlowski/following{/other_user}","gists_url":"https://api.github.com/users/PiotrKozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrKozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrKozlowski/subscriptions","organizations_url":"https://api.github.com/users/PiotrKozlowski/orgs","repos_url":"https://api.github.com/users/PiotrKozlowski/repos","events_url":"https://api.github.com/users/PiotrKozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrKozlowski/received_events","type":"User","site_admin":false},"body":"#https://github.com/openstax/unified/issues/587\r\n\r\n- Filters are saved in redux store\r\n- Filters are displayed\r\n- New actions are created for updating filters and receiving summary highlights\r\n- Display summary highlights\r\n- Loading state when changing filters\r\n- When there is no colors or chapters selected then highlights will not be shown\r\n- On ~~locationChange~~ summary popup open, current page / chapter will be added to filters\r\n\r\nTODO:\r\n- [x] Add more test and fixed those which are broken\r\n- [x] Check if everything is displaying correctly on mobile and if not then fix it\r\n\r\n","created_at":"2019-12-13T16:31:00Z","updated_at":"2020-01-08T15:38:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08042dbe3c16c823f409a4b9df1421268bbeab50","assignee":{"login":"PiotrKozlowski","id":31478212,"node_id":"MDQ6VXNlcjMxNDc4MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/31478212?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrKozlowski","html_url":"https://github.com/PiotrKozlowski","followers_url":"https://api.github.com/users/PiotrKozlowski/followers","following_url":"https://api.github.com/users/PiotrKozlowski/following{/other_user}","gists_url":"https://api.github.com/users/PiotrKozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrKozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrKozlowski/subscriptions","organizations_url":"https://api.github.com/users/PiotrKozlowski/orgs","repos_url":"https://api.github.com/users/PiotrKozlowski/repos","events_url":"https://api.github.com/users/PiotrKozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrKozlowski/received_events","type":"User","site_admin":false},"assignees":[{"login":"PiotrKozlowski","id":31478212,"node_id":"MDQ6VXNlcjMxNDc4MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/31478212?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrKozlowski","html_url":"https://github.com/PiotrKozlowski","followers_url":"https://api.github.com/users/PiotrKozlowski/followers","following_url":"https://api.github.com/users/PiotrKozlowski/following{/other_user}","gists_url":"https://api.github.com/users/PiotrKozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrKozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrKozlowski/subscriptions","organizations_url":"https://api.github.com/users/PiotrKozlowski/orgs","repos_url":"https://api.github.com/users/PiotrKozlowski/repos","events_url":"https://api.github.com/users/PiotrKozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrKozlowski/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openstax/rex-web/pulls/398/commits","review_comments_url":"https://api.github.com/repos/openstax/rex-web/pulls/398/comments","review_comment_url":"https://api.github.com/repos/openstax/rex-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstax/rex-web/issues/398/comments","statuses_url":"https://api.github.com/repos/openstax/rex-web/statuses/ff663e3595c5ae6321dda244aaf3accc6afe5155","head":{"label":"openstax:filters","ref":"filters","sha":"ff663e3595c5ae6321dda244aaf3accc6afe5155","user":{"login":"openstax","id":3805549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU1NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/3805549?v=4","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":156439828,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY0Mzk4Mjg=","name":"rex-web","full_name":"openstax/rex-web","private":false,"owner":{"login":"openstax","id":3805549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU1NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/3805549?v=4","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openstax/rex-web","description":"Unified Reading EXperience","fork":false,"url":"https://api.github.com/repos/openstax/rex-web","forks_url":"https://api.github.com/repos/openstax/rex-web/forks","keys_url":"https://api.github.com/repos/openstax/rex-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/rex-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/rex-web/teams","hooks_url":"https://api.github.com/repos/openstax/rex-web/hooks","issue_events_url":"https://api.github.com/repos/openstax/rex-web/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/rex-web/events","assignees_url":"https://api.github.com/repos/openstax/rex-web/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/rex-web/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/rex-web/tags","blobs_url":"https://api.github.com/repos/openstax/rex-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/rex-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/rex-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/rex-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/rex-web/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/rex-web/languages","stargazers_url":"https://api.github.com/repos/openstax/rex-web/stargazers","contributors_url":"https://api.github.com/repos/openstax/rex-web/contributors","subscribers_url":"https://api.github.com/repos/openstax/rex-web/subscribers","subscription_url":"https://api.github.com/repos/openstax/rex-web/subscription","commits_url":"https://api.github.com/repos/openstax/rex-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/rex-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/rex-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/rex-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/rex-web/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/rex-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/rex-web/merges","archive_url":"https://api.github.com/repos/openstax/rex-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/rex-web/downloads","issues_url":"https://api.github.com/repos/openstax/rex-web/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/rex-web/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/rex-web/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/rex-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/rex-web/labels{/name}","releases_url":"https://api.github.com/repos/openstax/rex-web/releases{/id}","deployments_url":"https://api.github.com/repos/openstax/rex-web/deployments","created_at":"2018-11-06T19:58:13Z","updated_at":"2020-01-08T14:41:46Z","pushed_at":"2020-01-08T15:33:16Z","git_url":"git://github.com/openstax/rex-web.git","ssh_url":"git@github.com:openstax/rex-web.git","clone_url":"https://github.com/openstax/rex-web.git","svn_url":"https://github.com/openstax/rex-web","homepage":"https://rex-web.herokuapp.com/","size":52980,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":14,"watchers":2,"default_branch":"master"}},"base":{"label":"openstax:master","ref":"master","sha":"7353db6c472a799e6f2741aa3254bbe0cc3cde2e","user":{"login":"openstax","id":3805549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU1NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/3805549?v=4","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":156439828,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY0Mzk4Mjg=","name":"rex-web","full_name":"openstax/rex-web","private":false,"owner":{"login":"openstax","id":3805549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU1NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/3805549?v=4","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openstax/rex-web","description":"Unified Reading EXperience","fork":false,"url":"https://api.github.com/repos/openstax/rex-web","forks_url":"https://api.github.com/repos/openstax/rex-web/forks","keys_url":"https://api.github.com/repos/openstax/rex-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/rex-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/rex-web/teams","hooks_url":"https://api.github.com/repos/openstax/rex-web/hooks","issue_events_url":"https://api.github.com/repos/openstax/rex-web/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/rex-web/events","assignees_url":"https://api.github.com/repos/openstax/rex-web/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/rex-web/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/rex-web/tags","blobs_url":"https://api.github.com/repos/openstax/rex-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/rex-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/rex-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/rex-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/rex-web/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/rex-web/languages","stargazers_url":"https://api.github.com/repos/openstax/rex-web/stargazers","contributors_url":"https://api.github.com/repos/openstax/rex-web/contributors","subscribers_url":"https://api.github.com/repos/openstax/rex-web/subscribers","subscription_url":"https://api.github.com/repos/openstax/rex-web/subscription","commits_url":"https://api.github.com/repos/openstax/rex-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/rex-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/rex-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/rex-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/rex-web/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/rex-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/rex-web/merges","archive_url":"https://api.github.com/repos/openstax/rex-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/rex-web/downloads","issues_url":"https://api.github.com/repos/openstax/rex-web/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/rex-web/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/rex-web/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/rex-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/rex-web/labels{/name}","releases_url":"https://api.github.com/repos/openstax/rex-web/releases{/id}","deployments_url":"https://api.github.com/repos/openstax/rex-web/deployments","created_at":"2018-11-06T19:58:13Z","updated_at":"2020-01-08T14:41:46Z","pushed_at":"2020-01-08T15:33:16Z","git_url":"git://github.com/openstax/rex-web.git","ssh_url":"git@github.com:openstax/rex-web.git","clone_url":"https://github.com/openstax/rex-web.git","svn_url":"https://github.com/openstax/rex-web","homepage":"https://rex-web.herokuapp.com/","size":52980,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstax/rex-web/pulls/398"},"html":{"href":"https://github.com/openstax/rex-web/pull/398"},"issue":{"href":"https://api.github.com/repos/openstax/rex-web/issues/398"},"comments":{"href":"https://api.github.com/repos/openstax/rex-web/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/openstax/rex-web/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/openstax/rex-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstax/rex-web/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/openstax/rex-web/statuses/ff663e3595c5ae6321dda244aaf3accc6afe5155"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 156439828,
"name": "openstax/rex-web",
"url": "https://api.github.com/repos/openstax/rex-web"
}
|
{
"id": 31478212,
"login": "PiotrKozlowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31478212?",
"url": "https://api.github.com/users/PiotrKozlowski"
}
|
{
"id": 3805549,
"login": "openstax",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3805549?",
"url": "https://api.github.com/orgs/openstax"
}
| 2020-01-08T15:38:58 |
11229503355
|
{"actor":{"display_login":"PiotrKozlowski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/osmlab/atlas/pulls/comments/296942515","pull_request_review_id":253692136,"id":296942515,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5Njk0MjUxNQ==","diff_hunk":"@@ -288,6 +289,17 @@ public String toString()\n + this.relationIdentifiers + \"]\";\n }\n \n+ @Override\n+ public String toWkt()\n+ {\n+ if (this.bounds == null)\n+ {\n+ return null;\n+ }\n+ final WktPolygonConverter converter = new WktPolygonConverter();\n+ return converter.convert(this.bounds);","path":"src/main/java/org/openstreetmap/atlas/geography/atlas/complete/CompleteRelation.java","position":20,"original_position":20,"commit_id":"fb5e84efdfb12f7a4292eb289c46b979eec88000","original_commit_id":"fb5e84efdfb12f7a4292eb289c46b979eec88000","user":{"login":"lucaspcram","id":8269882,"node_id":"MDQ6VXNlcjgyNjk4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/8269882?v=4","gravatar_id":"","url":"https://api.github.com/users/lucaspcram","html_url":"https://github.com/lucaspcram","followers_url":"https://api.github.com/users/lucaspcram/followers","following_url":"https://api.github.com/users/lucaspcram/following{/other_user}","gists_url":"https://api.github.com/users/lucaspcram/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaspcram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaspcram/subscriptions","organizations_url":"https://api.github.com/users/lucaspcram/orgs","repos_url":"https://api.github.com/users/lucaspcram/repos","events_url":"https://api.github.com/users/lucaspcram/events{/privacy}","received_events_url":"https://api.github.com/users/lucaspcram/received_events","type":"User","site_admin":false},"body":"Whoops missed that.","created_at":"2019-06-24T22:33:44Z","updated_at":"2019-06-24T22:33:44Z","html_url":"https://github.com/osmlab/atlas/pull/469#discussion_r296942515","pull_request_url":"https://api.github.com/repos/osmlab/atlas/pulls/469","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/comments/296942515"},"html":{"href":"https://github.com/osmlab/atlas/pull/469#discussion_r296942515"},"pull_request":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/469"}},"in_reply_to_id":296940673},"pull_request":{"url":"https://api.github.com/repos/osmlab/atlas/pulls/469","id":290763673,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNzYzNjcz","html_url":"https://github.com/osmlab/atlas/pull/469","diff_url":"https://github.com/osmlab/atlas/pull/469.diff","patch_url":"https://github.com/osmlab/atlas/pull/469.patch","issue_url":"https://api.github.com/repos/osmlab/atlas/issues/469","number":469,"state":"open","locked":false,"title":"Generate deterministic IDs for CompleteEntities","user":{"login":"lucaspcram","id":8269882,"node_id":"MDQ6VXNlcjgyNjk4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/8269882?v=4","gravatar_id":"","url":"https://api.github.com/users/lucaspcram","html_url":"https://github.com/lucaspcram","followers_url":"https://api.github.com/users/lucaspcram/followers","following_url":"https://api.github.com/users/lucaspcram/following{/other_user}","gists_url":"https://api.github.com/users/lucaspcram/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaspcram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaspcram/subscriptions","organizations_url":"https://api.github.com/users/lucaspcram/orgs","repos_url":"https://api.github.com/users/lucaspcram/repos","events_url":"https://api.github.com/users/lucaspcram/events{/privacy}","received_events_url":"https://api.github.com/users/lucaspcram/received_events","type":"User","site_admin":false},"body":"### Description:\r\n\r\nAdded a generator to compute a deterministic ID for a `CompleteEntity`. This ID is based on the entity properties.\r\n\r\n### Potential Impact:\r\n\r\nN/A\r\n\r\n### Unit Test Approach:\r\n\r\nTests added in `EntityIdentifierGeneratorTest`.\r\n\r\n### Test Results:\r\n\r\nTests pass.\r\n\r\n------\r\n\r\nIn doubt: [Contributing Guidelines](CONTRIBUTING.md)\r\n","created_at":"2019-06-21T22:18:33Z","updated_at":"2019-06-24T22:33:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9368f789fc238af9a3c4f38ab136cc79bd1ddd8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":664543820,"node_id":"MDU6TGFiZWw2NjQ1NDM4MjA=","url":"https://api.github.com/repos/osmlab/atlas/labels/New%20Feature","name":"New Feature","color":"128A0C","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/osmlab/atlas/pulls/469/commits","review_comments_url":"https://api.github.com/repos/osmlab/atlas/pulls/469/comments","review_comment_url":"https://api.github.com/repos/osmlab/atlas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osmlab/atlas/issues/469/comments","statuses_url":"https://api.github.com/repos/osmlab/atlas/statuses/fb5e84efdfb12f7a4292eb289c46b979eec88000","head":{"label":"lucaspcram:id","ref":"id","sha":"fb5e84efdfb12f7a4292eb289c46b979eec88000","user":{"login":"lucaspcram","id":8269882,"node_id":"MDQ6VXNlcjgyNjk4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/8269882?v=4","gravatar_id":"","url":"https://api.github.com/users/lucaspcram","html_url":"https://github.com/lucaspcram","followers_url":"https://api.github.com/users/lucaspcram/followers","following_url":"https://api.github.com/users/lucaspcram/following{/other_user}","gists_url":"https://api.github.com/users/lucaspcram/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaspcram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaspcram/subscriptions","organizations_url":"https://api.github.com/users/lucaspcram/orgs","repos_url":"https://api.github.com/users/lucaspcram/repos","events_url":"https://api.github.com/users/lucaspcram/events{/privacy}","received_events_url":"https://api.github.com/users/lucaspcram/received_events","type":"User","site_admin":false},"repo":{"id":127447366,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc0NDczNjY=","name":"atlas","full_name":"lucaspcram/atlas","private":false,"owner":{"login":"lucaspcram","id":8269882,"node_id":"MDQ6VXNlcjgyNjk4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/8269882?v=4","gravatar_id":"","url":"https://api.github.com/users/lucaspcram","html_url":"https://github.com/lucaspcram","followers_url":"https://api.github.com/users/lucaspcram/followers","following_url":"https://api.github.com/users/lucaspcram/following{/other_user}","gists_url":"https://api.github.com/users/lucaspcram/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaspcram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaspcram/subscriptions","organizations_url":"https://api.github.com/users/lucaspcram/orgs","repos_url":"https://api.github.com/users/lucaspcram/repos","events_url":"https://api.github.com/users/lucaspcram/events{/privacy}","received_events_url":"https://api.github.com/users/lucaspcram/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lucaspcram/atlas","description":"OSM in memory","fork":true,"url":"https://api.github.com/repos/lucaspcram/atlas","forks_url":"https://api.github.com/repos/lucaspcram/atlas/forks","keys_url":"https://api.github.com/repos/lucaspcram/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucaspcram/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucaspcram/atlas/teams","hooks_url":"https://api.github.com/repos/lucaspcram/atlas/hooks","issue_events_url":"https://api.github.com/repos/lucaspcram/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/lucaspcram/atlas/events","assignees_url":"https://api.github.com/repos/lucaspcram/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/lucaspcram/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/lucaspcram/atlas/tags","blobs_url":"https://api.github.com/repos/lucaspcram/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucaspcram/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucaspcram/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucaspcram/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucaspcram/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/lucaspcram/atlas/languages","stargazers_url":"https://api.github.com/repos/lucaspcram/atlas/stargazers","contributors_url":"https://api.github.com/repos/lucaspcram/atlas/contributors","subscribers_url":"https://api.github.com/repos/lucaspcram/atlas/subscribers","subscription_url":"https://api.github.com/repos/lucaspcram/atlas/subscription","commits_url":"https://api.github.com/repos/lucaspcram/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucaspcram/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucaspcram/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucaspcram/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucaspcram/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/lucaspcram/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucaspcram/atlas/merges","archive_url":"https://api.github.com/repos/lucaspcram/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucaspcram/atlas/downloads","issues_url":"https://api.github.com/repos/lucaspcram/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/lucaspcram/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/lucaspcram/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/lucaspcram/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucaspcram/atlas/labels{/name}","releases_url":"https://api.github.com/repos/lucaspcram/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/lucaspcram/atlas/deployments","created_at":"2018-03-30T16:07:04Z","updated_at":"2019-06-24T19:49:12Z","pushed_at":"2019-06-24T21:18:09Z","git_url":"git://github.com/lucaspcram/atlas.git","ssh_url":"git@github.com:lucaspcram/atlas.git","clone_url":"https://github.com/lucaspcram/atlas.git","svn_url":"https://github.com/lucaspcram/atlas","homepage":null,"size":63241,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"osmlab:dev","ref":"dev","sha":"b13622aa6815f5dec1248906e625a17173c1914c","user":{"login":"osmlab","id":3856374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTYzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"repo":{"id":99717758,"node_id":"MDEwOlJlcG9zaXRvcnk5OTcxNzc1OA==","name":"atlas","full_name":"osmlab/atlas","private":false,"owner":{"login":"osmlab","id":3856374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTYzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/osmlab/atlas","description":"OSM in memory","fork":false,"url":"https://api.github.com/repos/osmlab/atlas","forks_url":"https://api.github.com/repos/osmlab/atlas/forks","keys_url":"https://api.github.com/repos/osmlab/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osmlab/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osmlab/atlas/teams","hooks_url":"https://api.github.com/repos/osmlab/atlas/hooks","issue_events_url":"https://api.github.com/repos/osmlab/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/osmlab/atlas/events","assignees_url":"https://api.github.com/repos/osmlab/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/osmlab/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/osmlab/atlas/tags","blobs_url":"https://api.github.com/repos/osmlab/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osmlab/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osmlab/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/osmlab/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osmlab/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/osmlab/atlas/languages","stargazers_url":"https://api.github.com/repos/osmlab/atlas/stargazers","contributors_url":"https://api.github.com/repos/osmlab/atlas/contributors","subscribers_url":"https://api.github.com/repos/osmlab/atlas/subscribers","subscription_url":"https://api.github.com/repos/osmlab/atlas/subscription","commits_url":"https://api.github.com/repos/osmlab/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/osmlab/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/osmlab/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/osmlab/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/osmlab/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/osmlab/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osmlab/atlas/merges","archive_url":"https://api.github.com/repos/osmlab/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osmlab/atlas/downloads","issues_url":"https://api.github.com/repos/osmlab/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/osmlab/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/osmlab/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/osmlab/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osmlab/atlas/labels{/name}","releases_url":"https://api.github.com/repos/osmlab/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/osmlab/atlas/deployments","created_at":"2017-08-08T17:14:27Z","updated_at":"2019-06-24T20:55:07Z","pushed_at":"2019-06-24T21:18:11Z","git_url":"git://github.com/osmlab/atlas.git","ssh_url":"git@github.com:osmlab/atlas.git","clone_url":"https://github.com/osmlab/atlas.git","svn_url":"https://github.com/osmlab/atlas","homepage":null,"size":63234,"stargazers_count":124,"watchers_count":124,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":48,"open_issues":15,"watchers":124,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/469"},"html":{"href":"https://github.com/osmlab/atlas/pull/469"},"issue":{"href":"https://api.github.com/repos/osmlab/atlas/issues/469"},"comments":{"href":"https://api.github.com/repos/osmlab/atlas/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/osmlab/atlas/statuses/fb5e84efdfb12f7a4292eb289c46b979eec88000"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 99717758,
"name": "osmlab/atlas",
"url": "https://api.github.com/repos/osmlab/atlas"
}
|
{
"id": 8269882,
"login": "lucaspcram",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8269882?",
"url": "https://api.github.com/users/lucaspcram"
}
|
{
"id": 3856374,
"login": "osmlab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3856374?",
"url": "https://api.github.com/orgs/osmlab"
}
| 2019-06-24T22:33:44 |
9884552071
|
{"actor":{"display_login":"lucaspcram"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/317413718","pull_request_review_id":279352043,"id":317413718,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzQxMzcxOA==","diff_hunk":"@@ -79,3 +85,17 @@\n pfCTaggingTask\n )\n btagging = cms.Sequence(btaggingTask)\n+\n+\n+\n+# Create b-tagging sequences without pixelClusterTagInfos\n+pfBTaggingTaskNoPixelCluster = pfBTaggingTask.copy()\n+pfBTaggingTaskNoPixelCluster.remove(pixelClusterTagInfos)\n+\n+btaggingNoPixelCluster = btagging.copy()\n+btaggingNoPixelCluster.remove(pixelClusterTagInfos)\n+\n+## FastSim modifier (do not run pixelClusterTagInfos because the siPixelCluster input collection is not produced in FastSim)\n+from Configuration.Eras.Modifier_fastSim_cff import fastSim\n+fastSim.toReplaceWith(btagging, btaggingNoPixelCluster)","path":"RecoBTag/Configuration/python/RecoBTag_cff.py","position":47,"original_position":47,"commit_id":"ea3cd05dbf1d1bd3c982cc03ba9436fb355b523a","original_commit_id":"0cb01ddd87b6bb86b27726f13a8cdce268ca24cc","user":{"login":"perrotta","id":4069749,"node_id":"MDQ6VXNlcjQwNjk3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/4069749?v=4","gravatar_id":"","url":"https://api.github.com/users/perrotta","html_url":"https://github.com/perrotta","followers_url":"https://api.github.com/users/perrotta/followers","following_url":"https://api.github.com/users/perrotta/following{/other_user}","gists_url":"https://api.github.com/users/perrotta/gists{/gist_id}","starred_url":"https://api.github.com/users/perrotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perrotta/subscriptions","organizations_url":"https://api.github.com/users/perrotta/orgs","repos_url":"https://api.github.com/users/perrotta/repos","events_url":"https://api.github.com/users/perrotta/events{/privacy}","received_events_url":"https://api.github.com/users/perrotta/received_events","type":"User","site_admin":false},"body":"@zucchett , I think that the suggestion from @slava77 was to apply the modifiers to the pixelClusterTagInfos module, and not to the main reco BTag sequence (or miniAOD).\r\nYou can use modifiers to replace pixelClusterTagInfos with some dummy/empty module inside RecoBTag/PixelCluster/python/pixelClusterTagInfos_cfi.py, and you don't have to apply modifiers elsewhere","created_at":"2019-08-25T20:35:14Z","updated_at":"2019-08-25T20:35:14Z","html_url":"https://github.com/cms-sw/cmssw/pull/27738#discussion_r317413718","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/27738","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/317413718"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/27738#discussion_r317413718"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/27738"}},"in_reply_to_id":315786866},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/27738","id":305977517,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1OTc3NTE3","html_url":"https://github.com/cms-sw/cmssw/pull/27738","diff_url":"https://github.com/cms-sw/cmssw/pull/27738.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/27738.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/27738","number":27738,"state":"open","locked":false,"title":"Addition of pixelClusterTagInfos to AOD and miniAOD","user":{"login":"zucchett","id":6450143,"node_id":"MDQ6VXNlcjY0NTAxNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6450143?v=4","gravatar_id":"","url":"https://api.github.com/users/zucchett","html_url":"https://github.com/zucchett","followers_url":"https://api.github.com/users/zucchett/followers","following_url":"https://api.github.com/users/zucchett/following{/other_user}","gists_url":"https://api.github.com/users/zucchett/gists{/gist_id}","starred_url":"https://api.github.com/users/zucchett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zucchett/subscriptions","organizations_url":"https://api.github.com/users/zucchett/orgs","repos_url":"https://api.github.com/users/zucchett/repos","events_url":"https://api.github.com/users/zucchett/events{/privacy}","received_events_url":"https://api.github.com/users/zucchett/received_events","type":"User","site_admin":false},"body":"#### PR description:\r\n\r\nThis pull request defines a new TagInfo object (PixelClusterTagInfo), produced from the RECO format starting from the siPixelCluster collection, propagated to AOD, and embedded in miniAOD. The TagInfo contains a very compressed information of the pixel clusters geometrically matched to an AK4 jet, consisting of a char for each 4 pixel layers times 6 jet-cluster association cones, plus four unsigned integers for the collected charge. This information is added only to jets with pT > 100 GeV, and is critical for novel studies of b-tagging at high pT without relying on tracks, whose reconstruction efficiency decreases in very energetic jets. The pixel cluster information can be provided to a standalone tagger or (in the future) integrated in combined b-tagging algorithms. Preliminary studies performed on very limited samples estimate that a pixel-based tagger provides a better performance than the DeepCSV for jet pT > 1.2 TeV.\r\n\r\nLatest presentations:\r\nhttps://indico.cern.ch/event/828712/contributions/3468910/attachments/1869375/3075401/Sommerhalder_Zucchetta.pdf\r\nhttps://indico.cern.ch/event/830302/contributions/3483708/attachments/1871179/3079451/190628_Zucchetta.pdf\r\nhttps://indico.cern.ch/event/833434/contributions/3495708/attachments/1877898/3093199/190710_Zucchetta.pdf\r\n\r\n#### PR validation:\r\n\r\nThe basic checks have been successfully run (code-checks, runTheMatrix). The only exception is represented by two jobs in runTheMatrix that run on already-produced AOD (136.7611* and 136.8311*) that fail because the needed collections are not found. This is understandable because neither the basic siPixelCluster nor the pixelClusterTagInfo collections are present in AODs by default; the latter collection is added to AODs with this PR.\r\nEDIT: Era modifiers have been introduced to exclude pixelClusterTagInfos from 80X and 94X miniAOD productions, avoiding the crash.\r\n\r\n\r\n@msommerh as developer, and BTV conveners @mverzett , @kskovpen, @XavierAtCERN, @smoortga are also involved and interested in these developments.\r\n","created_at":"2019-08-09T12:52:33Z","updated_at":"2019-08-25T20:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccb4ebcdcd387480660a22cd2b51a9835d13da91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":52881179,"node_id":"MDU6TGFiZWw1Mjg4MTE3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131152,"node_id":"MDU6TGFiZWw1NjEzMTE1Mg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/81","html_url":"https://github.com/cms-sw/cmssw/milestone/81","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/81/labels","id":4314065,"node_id":"MDk6TWlsZXN0b25lNDMxNDA2NQ==","number":81,"title":"CMSSW_11_0_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":81,"closed_issues":877,"state":"open","created_at":"2019-05-14T17:36:57Z","updated_at":"2019-08-25T15:07:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/27738/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/27738/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/27738/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/ea3cd05dbf1d1bd3c982cc03ba9436fb355b523a","head":{"label":"zucchett:PixelClusterTagInfo","ref":"PixelClusterTagInfo","sha":"ea3cd05dbf1d1bd3c982cc03ba9436fb355b523a","user":{"login":"zucchett","id":6450143,"node_id":"MDQ6VXNlcjY0NTAxNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6450143?v=4","gravatar_id":"","url":"https://api.github.com/users/zucchett","html_url":"https://github.com/zucchett","followers_url":"https://api.github.com/users/zucchett/followers","following_url":"https://api.github.com/users/zucchett/following{/other_user}","gists_url":"https://api.github.com/users/zucchett/gists{/gist_id}","starred_url":"https://api.github.com/users/zucchett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zucchett/subscriptions","organizations_url":"https://api.github.com/users/zucchett/orgs","repos_url":"https://api.github.com/users/zucchett/repos","events_url":"https://api.github.com/users/zucchett/events{/privacy}","received_events_url":"https://api.github.com/users/zucchett/received_events","type":"User","site_admin":false},"repo":{"id":16070105,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3MDEwNQ==","name":"cmssw","full_name":"zucchett/cmssw","private":false,"owner":{"login":"zucchett","id":6450143,"node_id":"MDQ6VXNlcjY0NTAxNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6450143?v=4","gravatar_id":"","url":"https://api.github.com/users/zucchett","html_url":"https://github.com/zucchett","followers_url":"https://api.github.com/users/zucchett/followers","following_url":"https://api.github.com/users/zucchett/following{/other_user}","gists_url":"https://api.github.com/users/zucchett/gists{/gist_id}","starred_url":"https://api.github.com/users/zucchett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zucchett/subscriptions","organizations_url":"https://api.github.com/users/zucchett/orgs","repos_url":"https://api.github.com/users/zucchett/repos","events_url":"https://api.github.com/users/zucchett/events{/privacy}","received_events_url":"https://api.github.com/users/zucchett/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zucchett/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/zucchett/cmssw","forks_url":"https://api.github.com/repos/zucchett/cmssw/forks","keys_url":"https://api.github.com/repos/zucchett/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zucchett/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zucchett/cmssw/teams","hooks_url":"https://api.github.com/repos/zucchett/cmssw/hooks","issue_events_url":"https://api.github.com/repos/zucchett/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/zucchett/cmssw/events","assignees_url":"https://api.github.com/repos/zucchett/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/zucchett/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/zucchett/cmssw/tags","blobs_url":"https://api.github.com/repos/zucchett/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zucchett/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zucchett/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/zucchett/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zucchett/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/zucchett/cmssw/languages","stargazers_url":"https://api.github.com/repos/zucchett/cmssw/stargazers","contributors_url":"https://api.github.com/repos/zucchett/cmssw/contributors","subscribers_url":"https://api.github.com/repos/zucchett/cmssw/subscribers","subscription_url":"https://api.github.com/repos/zucchett/cmssw/subscription","commits_url":"https://api.github.com/repos/zucchett/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/zucchett/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/zucchett/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/zucchett/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/zucchett/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/zucchett/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zucchett/cmssw/merges","archive_url":"https://api.github.com/repos/zucchett/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zucchett/cmssw/downloads","issues_url":"https://api.github.com/repos/zucchett/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/zucchett/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/zucchett/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/zucchett/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zucchett/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/zucchett/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/zucchett/cmssw/deployments","created_at":"2014-01-20T12:31:52Z","updated_at":"2014-01-20T12:33:05Z","pushed_at":"2019-08-25T14:16:02Z","git_url":"git://github.com/zucchett/cmssw.git","ssh_url":"git@github.com:zucchett/cmssw.git","clone_url":"https://github.com/zucchett/cmssw.git","svn_url":"https://github.com/zucchett/cmssw","homepage":"cms-sw.github.io/cmssw","size":1003202,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"a6191a11f9a39a95324f883b4a35363354d92324","user":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2OTU1MQ==","name":"cmssw","full_name":"cms-sw/cmssw","private":false,"owner":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2019-08-24T13:49:49Z","pushed_at":"2019-08-25T16:30:57Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1097837,"stargazers_count":697,"watchers_count":697,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3004,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":499,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3004,"open_issues":499,"watchers":697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/27738"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/27738"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/27738"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/27738/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/27738/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/27738/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/ea3cd05dbf1d1bd3c982cc03ba9436fb355b523a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 10969551,
"name": "cms-sw/cmssw",
"url": "https://api.github.com/repos/cms-sw/cmssw"
}
|
{
"id": 4069749,
"login": "perrotta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4069749?",
"url": "https://api.github.com/users/perrotta"
}
|
{
"id": 3863500,
"login": "cms-sw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3863500?",
"url": "https://api.github.com/orgs/cms-sw"
}
| 2019-08-25T20:35:14 |
10279167337
|
{"actor":{"display_login":"perrotta"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/353759267","pull_request_review_id":326854438,"id":353759267,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Mzc1OTI2Nw==","diff_hunk":"@@ -1,21 +1,32 @@\n from rest_framework import viewsets\n from rest_framework.response import Response\n \n+from .models import DynamicNetworkLocation\n from .models import NetworkLocation\n+from .models import StaticNetworkLocation\n from .serializers import NetworkLocationSerializer\n from kolibri.core.content.permissions import CanManageContent\n-from kolibri.core.device.permissions import UserHasAnyDevicePermissions\n-from kolibri.core.discovery.utils.network.search import get_available_instances\n+from kolibri.core.discovery.utils.network.search import run_peer_discovery\n \n \n class NetworkLocationViewSet(viewsets.ModelViewSet):\n permission_classes = (CanManageContent,)\n serializer_class = NetworkLocationSerializer\n- queryset = NetworkLocation.objects.all()\n+ queryset = NetworkLocation.objects","path":"kolibri/core/discovery/api.py","position":18,"original_position":18,"commit_id":"1ebfed83b4b7cb69c744bee25bedf910e9df97b1","original_commit_id":"1ebfed83b4b7cb69c744bee25bedf910e9df97b1","user":{"login":"rtibbles","id":1680573,"node_id":"MDQ6VXNlcjE2ODA1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1680573?v=4","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"body":"Does this work? `NetworkLocation.objects` is a Manager instance, not a queryset.","created_at":"2019-12-04T14:00:57Z","updated_at":"2019-12-04T14:20:16Z","html_url":"https://github.com/learningequality/kolibri/pull/6207#discussion_r353759267","pull_request_url":"https://api.github.com/repos/learningequality/kolibri/pulls/6207","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/353759267"},"html":{"href":"https://github.com/learningequality/kolibri/pull/6207#discussion_r353759267"},"pull_request":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/6207"}}},"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/6207","id":348740027,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4NzQwMDI3","html_url":"https://github.com/learningequality/kolibri/pull/6207","diff_url":"https://github.com/learningequality/kolibri/pull/6207.diff","patch_url":"https://github.com/learningequality/kolibri/pull/6207.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/6207","number":6207,"state":"open","locked":false,"title":"Updated peer discovery functionality","user":{"login":"micahscopes","id":389782,"node_id":"MDQ6VXNlcjM4OTc4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/389782?v=4","gravatar_id":"","url":"https://api.github.com/users/micahscopes","html_url":"https://github.com/micahscopes","followers_url":"https://api.github.com/users/micahscopes/followers","following_url":"https://api.github.com/users/micahscopes/following{/other_user}","gists_url":"https://api.github.com/users/micahscopes/gists{/gist_id}","starred_url":"https://api.github.com/users/micahscopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahscopes/subscriptions","organizations_url":"https://api.github.com/users/micahscopes/orgs","repos_url":"https://api.github.com/users/micahscopes/repos","events_url":"https://api.github.com/users/micahscopes/events{/privacy}","received_events_url":"https://api.github.com/users/micahscopes/received_events","type":"User","site_admin":false},"body":"### Summary\r\nThis PR completes the initial implementation of 0.13 peer discovery functionality. It includes two big changes from the previous zeroconf work:\r\n- Retooling the `NetworkLocation` data structures and API to handle both static and dynamic locations using a common interface that is compatible with the import wizard as is.\r\n- An update to the front-end implementation to match designs.\r\n\r\n**TLDR**: The main interface for peer discovery currently resides at an endpoint called `/api/discovery/dynamicnetworklocation/`\r\n\r\nPlease see my comments for implementation details!\r\n\r\nBefore:\r\n\r\n\r\nAfter:\r\n\r\n\r\n### Reviewer guidance\r\nThere are some Gherkin stories you can look at.\r\n\r\nYou can start lots of little Kolibri's on your computer using stuff like:\r\n```\r\nKOLIBRI_HOME=~/.kolibriLocalPeer12 kolibri start --port 8285\r\nKOLIBRI_HOME=~/.kolibriLocalPeer932 kolibri start --port 9191\r\n```\r\nTry starting and stopping them and see if your peer list updates correctly.\r\n\r\n**known flaw**: I still didn't extend the public API to provide information about the number of channels available. So Kolibri instances with no content will show up as viable peers.\r\n\r\n### References\r\n[notion docs](https://www.notion.so/learningequality/Auto-discovery-of-P2P-import-sources-4b5199f75def4c93982a155f15fd6a9b)\r\n\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n\r\nPR process:\r\n\r\n- [x] PR has the correct target branch and milestone\r\n- [x] PR has 'needs review' or 'work-in-progress' label\r\n- [x] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n- [x] If this is an important user-facing change, PR or related issue has a 'changelog' label\r\n- [ ] If this includes an internal dependency change, a link to the diff is provided\r\n\r\nTesting:\r\n\r\n- [x] Contributor has fully tested the PR manually\r\n- [x] If there are any front-end changes, before/after screenshots are included\r\n- [x] Critical user journeys are covered by Gherkin stories\r\n- [ ] Critical and brittle code paths are covered by unit tests\r\n\r\nIt needs more tests... probably even some end to end (simulated p2p) testing in a tox environment.\r\n\r\n### Reviewer Checklist\r\n\r\n- Automated test coverage is satisfactory\r\n- PR is fully functional\r\n- PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- External dependency files were updated if necessary (`yarn` and `pip`)\r\n- Documentation is updated\r\n- Contributor is in AUTHORS.md\r\n","created_at":"2019-12-04T07:45:19Z","updated_at":"2019-12-04T14:20:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"235cc9149943edfe8f18474a20ddeb9df3c45236","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jamalex","id":618416,"node_id":"MDQ6VXNlcjYxODQxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/618416?v=4","gravatar_id":"","url":"https://api.github.com/users/jamalex","html_url":"https://github.com/jamalex","followers_url":"https://api.github.com/users/jamalex/followers","following_url":"https://api.github.com/users/jamalex/following{/other_user}","gists_url":"https://api.github.com/users/jamalex/gists{/gist_id}","starred_url":"https://api.github.com/users/jamalex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamalex/subscriptions","organizations_url":"https://api.github.com/users/jamalex/orgs","repos_url":"https://api.github.com/users/jamalex/repos","events_url":"https://api.github.com/users/jamalex/events{/privacy}","received_events_url":"https://api.github.com/users/jamalex/received_events","type":"User","site_admin":false},{"login":"jonboiser","id":10248067,"node_id":"MDQ6VXNlcjEwMjQ4MDY3","avatar_url":"https://avatars2.githubusercontent.com/u/10248067?v=4","gravatar_id":"","url":"https://api.github.com/users/jonboiser","html_url":"https://github.com/jonboiser","followers_url":"https://api.github.com/users/jonboiser/followers","following_url":"https://api.github.com/users/jonboiser/following{/other_user}","gists_url":"https://api.github.com/users/jonboiser/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboiser/subscriptions","organizations_url":"https://api.github.com/users/jonboiser/orgs","repos_url":"https://api.github.com/users/jonboiser/repos","events_url":"https://api.github.com/users/jonboiser/events{/privacy}","received_events_url":"https://api.github.com/users/jonboiser/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":410338552,"node_id":"MDU6TGFiZWw0MTAzMzg1NTI=","url":"https://api.github.com/repos/learningequality/kolibri/labels/TODO:%20needs%20review","name":"TODO: needs review","color":"c1e23b","default":false,"description":"Waiting for review"},{"id":831979218,"node_id":"MDU6TGFiZWw4MzE5NzkyMTg=","url":"https://api.github.com/repos/learningequality/kolibri/labels/changelog","name":"changelog","color":"000000","default":false,"description":"Important user-facing changes"}],"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/6207/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/6207/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/6207/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/1ebfed83b4b7cb69c744bee25bedf910e9df97b1","head":{"label":"micahscopes:release-v0.13.x","ref":"release-v0.13.x","sha":"1ebfed83b4b7cb69c744bee25bedf910e9df97b1","user":{"login":"micahscopes","id":389782,"node_id":"MDQ6VXNlcjM4OTc4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/389782?v=4","gravatar_id":"","url":"https://api.github.com/users/micahscopes","html_url":"https://github.com/micahscopes","followers_url":"https://api.github.com/users/micahscopes/followers","following_url":"https://api.github.com/users/micahscopes/following{/other_user}","gists_url":"https://api.github.com/users/micahscopes/gists{/gist_id}","starred_url":"https://api.github.com/users/micahscopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahscopes/subscriptions","organizations_url":"https://api.github.com/users/micahscopes/orgs","repos_url":"https://api.github.com/users/micahscopes/repos","events_url":"https://api.github.com/users/micahscopes/events{/privacy}","received_events_url":"https://api.github.com/users/micahscopes/received_events","type":"User","site_admin":false},"repo":{"id":117873258,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4NzMyNTg=","name":"kolibri","full_name":"micahscopes/kolibri","private":false,"owner":{"login":"micahscopes","id":389782,"node_id":"MDQ6VXNlcjM4OTc4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/389782?v=4","gravatar_id":"","url":"https://api.github.com/users/micahscopes","html_url":"https://github.com/micahscopes","followers_url":"https://api.github.com/users/micahscopes/followers","following_url":"https://api.github.com/users/micahscopes/following{/other_user}","gists_url":"https://api.github.com/users/micahscopes/gists{/gist_id}","starred_url":"https://api.github.com/users/micahscopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahscopes/subscriptions","organizations_url":"https://api.github.com/users/micahscopes/orgs","repos_url":"https://api.github.com/users/micahscopes/repos","events_url":"https://api.github.com/users/micahscopes/events{/privacy}","received_events_url":"https://api.github.com/users/micahscopes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/micahscopes/kolibri","description":"Kolibri: the offline app for universal education","fork":true,"url":"https://api.github.com/repos/micahscopes/kolibri","forks_url":"https://api.github.com/repos/micahscopes/kolibri/forks","keys_url":"https://api.github.com/repos/micahscopes/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micahscopes/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micahscopes/kolibri/teams","hooks_url":"https://api.github.com/repos/micahscopes/kolibri/hooks","issue_events_url":"https://api.github.com/repos/micahscopes/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/micahscopes/kolibri/events","assignees_url":"https://api.github.com/repos/micahscopes/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/micahscopes/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/micahscopes/kolibri/tags","blobs_url":"https://api.github.com/repos/micahscopes/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micahscopes/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micahscopes/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/micahscopes/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micahscopes/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/micahscopes/kolibri/languages","stargazers_url":"https://api.github.com/repos/micahscopes/kolibri/stargazers","contributors_url":"https://api.github.com/repos/micahscopes/kolibri/contributors","subscribers_url":"https://api.github.com/repos/micahscopes/kolibri/subscribers","subscription_url":"https://api.github.com/repos/micahscopes/kolibri/subscription","commits_url":"https://api.github.com/repos/micahscopes/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/micahscopes/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/micahscopes/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/micahscopes/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/micahscopes/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/micahscopes/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micahscopes/kolibri/merges","archive_url":"https://api.github.com/repos/micahscopes/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micahscopes/kolibri/downloads","issues_url":"https://api.github.com/repos/micahscopes/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/micahscopes/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/micahscopes/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/micahscopes/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micahscopes/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/micahscopes/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/micahscopes/kolibri/deployments","created_at":"2018-01-17T18:03:37Z","updated_at":"2019-10-25T21:46:19Z","pushed_at":"2019-12-04T13:37:17Z","git_url":"git://github.com/micahscopes/kolibri.git","ssh_url":"git@github.com:micahscopes/kolibri.git","clone_url":"https://github.com/micahscopes/kolibri.git","svn_url":"https://github.com/micahscopes/kolibri","homepage":"http://learningequality.org/kolibri/","size":72135,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"learningequality:release-v0.13.x","ref":"release-v0.13.x","sha":"cb4ffba0c74d518ddf16b14010c07462a3ea75c2","user":{"login":"learningequality","id":3926525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3NjkzOQ==","name":"kolibri","full_name":"learningequality/kolibri","private":false,"owner":{"login":"learningequality","id":3926525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/learningequality/kolibri","description":"Kolibri: the offline app for universal education","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2019-12-03T15:40:57Z","pushed_at":"2019-12-04T13:37:19Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"https://learningequality.org/kolibri/","size":71685,"stargazers_count":295,"watchers_count":295,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":176,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":404,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":176,"open_issues":404,"watchers":295,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/6207"},"html":{"href":"https://github.com/learningequality/kolibri/pull/6207"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/6207"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/6207/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/6207/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/6207/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/1ebfed83b4b7cb69c744bee25bedf910e9df97b1"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 49976939,
"name": "learningequality/kolibri",
"url": "https://api.github.com/repos/learningequality/kolibri"
}
|
{
"id": 1680573,
"login": "rtibbles",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1680573?",
"url": "https://api.github.com/users/rtibbles"
}
|
{
"id": 3926525,
"login": "learningequality",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3926525?",
"url": "https://api.github.com/orgs/learningequality"
}
| 2019-12-04T14:00:57 |
11010287680
|
{"actor":{"display_login":"rtibbles"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/comments/366096019","pull_request_review_id":342223387,"id":366096019,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NjA5NjAxOQ==","diff_hunk":"@@ -199,28 +199,28 @@ - (void)paymentMethodOption {\n cardDetails:nil\n redirectCompletion:nil\n completion:^(JPResponse * response, NSError * error) {\n- if (error || response.items.count == 0) {\n- if (error.domain == JudoErrorDomain && error.code == JudoErrorUserDidCancel) {\n- [self dismissViewControllerAnimated:YES completion:nil];\n- return;\n- }\n- \n- [self dismissViewControllerAnimated:YES completion:^{\n- [self presentErrorWithMessage: error.userInfo[NSLocalizedDescriptionKey]];\n- }];\n- return;\n- }\n- JPTransactionData *tData = response.items[0];\n- if (tData.cardDetails) {\n- self.cardDetails = tData.cardDetails;\n- self.payToken = tData.paymentToken;\n- }\n- DetailViewController *viewController = [[DetailViewController alloc] initWithNibName:@\"DetailViewController\" bundle:nil];\n- viewController.transactionData = tData;\n- [self dismissViewControllerAnimated:YES completion:^{\n- [self.navigationController pushViewController:viewController animated:YES];\n- }];\n- }];\n+ if (error || response.items.count == 0) {\n+ if (error.domain == JudoErrorDomain && error.code == JudoErrorUserDidCancel) {\n+ [self dismissViewControllerAnimated:YES completion:nil];\n+ return;\n+ }\n+ \n+ [self dismissViewControllerAnimated:YES completion:^{\n+ [self presentErrorWithMessage: error.userInfo[NSLocalizedDescriptionKey]];\n+ }];\n+ return;\n+ }\n+ JPTransactionData *tData = response.items[0];","path":"JudoKitObjCExampleApp/Controllers/MainViewController.m","position":107,"original_position":107,"commit_id":"33d10d981ce1871edf0b08cc3b64ff1dfce63c18","original_commit_id":"33d10d981ce1871edf0b08cc3b64ff1dfce63c18","user":{"login":"stpopa","id":51994215,"node_id":"MDQ6VXNlcjUxOTk0MjE1","avatar_url":"https://avatars3.githubusercontent.com/u/51994215?v=4","gravatar_id":"","url":"https://api.github.com/users/stpopa","html_url":"https://github.com/stpopa","followers_url":"https://api.github.com/users/stpopa/followers","following_url":"https://api.github.com/users/stpopa/following{/other_user}","gists_url":"https://api.github.com/users/stpopa/gists{/gist_id}","starred_url":"https://api.github.com/users/stpopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stpopa/subscriptions","organizations_url":"https://api.github.com/users/stpopa/orgs","repos_url":"https://api.github.com/users/stpopa/repos","events_url":"https://api.github.com/users/stpopa/events{/privacy}","received_events_url":"https://api.github.com/users/stpopa/received_events","type":"User","site_admin":false},"body":"`response.items.firstObject` ?","created_at":"2020-01-14T00:14:05Z","updated_at":"2020-01-14T00:14:05Z","html_url":"https://github.com/Judopay/JudoKitObjC/pull/182#discussion_r366096019","pull_request_url":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/182","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/comments/366096019"},"html":{"href":"https://github.com/Judopay/JudoKitObjC/pull/182#discussion_r366096019"},"pull_request":{"href":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/182","id":349444686,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5NDQ0Njg2","html_url":"https://github.com/Judopay/JudoKitObjC/pull/182","diff_url":"https://github.com/Judopay/JudoKitObjC/pull/182.diff","patch_url":"https://github.com/Judopay/JudoKitObjC/pull/182.patch","issue_url":"https://api.github.com/repos/Judopay/JudoKitObjC/issues/182","number":182,"state":"open","locked":false,"title":"dark mode fixes","user":{"login":"gcojocaru","id":53559849,"node_id":"MDQ6VXNlcjUzNTU5ODQ5","avatar_url":"https://avatars1.githubusercontent.com/u/53559849?v=4","gravatar_id":"","url":"https://api.github.com/users/gcojocaru","html_url":"https://github.com/gcojocaru","followers_url":"https://api.github.com/users/gcojocaru/followers","following_url":"https://api.github.com/users/gcojocaru/following{/other_user}","gists_url":"https://api.github.com/users/gcojocaru/gists{/gist_id}","starred_url":"https://api.github.com/users/gcojocaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcojocaru/subscriptions","organizations_url":"https://api.github.com/users/gcojocaru/orgs","repos_url":"https://api.github.com/users/gcojocaru/repos","events_url":"https://api.github.com/users/gcojocaru/events{/privacy}","received_events_url":"https://api.github.com/users/gcojocaru/received_events","type":"User","site_admin":false},"body":"- fixed DetailsViewController visibility in dark mode\r\n- fixed pay and back buttons not being visible on ideal view controller\r\n- fixed activity indicator not being visible in dark mode","created_at":"2019-12-05T13:36:27Z","updated_at":"2020-01-14T00:14:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"465c89880ce3d859b883365d6b4672ec6cc47d30","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mpetrenco","id":53521805,"node_id":"MDQ6VXNlcjUzNTIxODA1","avatar_url":"https://avatars2.githubusercontent.com/u/53521805?v=4","gravatar_id":"","url":"https://api.github.com/users/mpetrenco","html_url":"https://github.com/mpetrenco","followers_url":"https://api.github.com/users/mpetrenco/followers","following_url":"https://api.github.com/users/mpetrenco/following{/other_user}","gists_url":"https://api.github.com/users/mpetrenco/gists{/gist_id}","starred_url":"https://api.github.com/users/mpetrenco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpetrenco/subscriptions","organizations_url":"https://api.github.com/users/mpetrenco/orgs","repos_url":"https://api.github.com/users/mpetrenco/repos","events_url":"https://api.github.com/users/mpetrenco/events{/privacy}","received_events_url":"https://api.github.com/users/mpetrenco/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/182/commits","review_comments_url":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/182/comments","review_comment_url":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Judopay/JudoKitObjC/issues/182/comments","statuses_url":"https://api.github.com/repos/Judopay/JudoKitObjC/statuses/33d10d981ce1871edf0b08cc3b64ff1dfce63c18","head":{"label":"Judopay:bugfix/quick_fixes","ref":"bugfix/quick_fixes","sha":"33d10d981ce1871edf0b08cc3b64ff1dfce63c18","user":{"login":"Judopay","id":3963274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NjMyNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3963274?v=4","gravatar_id":"","url":"https://api.github.com/users/Judopay","html_url":"https://github.com/Judopay","followers_url":"https://api.github.com/users/Judopay/followers","following_url":"https://api.github.com/users/Judopay/following{/other_user}","gists_url":"https://api.github.com/users/Judopay/gists{/gist_id}","starred_url":"https://api.github.com/users/Judopay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Judopay/subscriptions","organizations_url":"https://api.github.com/users/Judopay/orgs","repos_url":"https://api.github.com/users/Judopay/repos","events_url":"https://api.github.com/users/Judopay/events{/privacy}","received_events_url":"https://api.github.com/users/Judopay/received_events","type":"Organization","site_admin":false},"repo":{"id":45906608,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkwNjYwOA==","name":"JudoKitObjC","full_name":"Judopay/JudoKitObjC","private":false,"owner":{"login":"Judopay","id":3963274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NjMyNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3963274?v=4","gravatar_id":"","url":"https://api.github.com/users/Judopay","html_url":"https://github.com/Judopay","followers_url":"https://api.github.com/users/Judopay/followers","following_url":"https://api.github.com/users/Judopay/following{/other_user}","gists_url":"https://api.github.com/users/Judopay/gists{/gist_id}","starred_url":"https://api.github.com/users/Judopay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Judopay/subscriptions","organizations_url":"https://api.github.com/users/Judopay/orgs","repos_url":"https://api.github.com/users/Judopay/repos","events_url":"https://api.github.com/users/Judopay/events{/privacy}","received_events_url":"https://api.github.com/users/Judopay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Judopay/JudoKitObjC","description":"Judopay's Objective-C SDK for a simple, quick, and secure integration of in-app payments.","fork":false,"url":"https://api.github.com/repos/Judopay/JudoKitObjC","forks_url":"https://api.github.com/repos/Judopay/JudoKitObjC/forks","keys_url":"https://api.github.com/repos/Judopay/JudoKitObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Judopay/JudoKitObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Judopay/JudoKitObjC/teams","hooks_url":"https://api.github.com/repos/Judopay/JudoKitObjC/hooks","issue_events_url":"https://api.github.com/repos/Judopay/JudoKitObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Judopay/JudoKitObjC/events","assignees_url":"https://api.github.com/repos/Judopay/JudoKitObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Judopay/JudoKitObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Judopay/JudoKitObjC/tags","blobs_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Judopay/JudoKitObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Judopay/JudoKitObjC/languages","stargazers_url":"https://api.github.com/repos/Judopay/JudoKitObjC/stargazers","contributors_url":"https://api.github.com/repos/Judopay/JudoKitObjC/contributors","subscribers_url":"https://api.github.com/repos/Judopay/JudoKitObjC/subscribers","subscription_url":"https://api.github.com/repos/Judopay/JudoKitObjC/subscription","commits_url":"https://api.github.com/repos/Judopay/JudoKitObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Judopay/JudoKitObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Judopay/JudoKitObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Judopay/JudoKitObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Judopay/JudoKitObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Judopay/JudoKitObjC/merges","archive_url":"https://api.github.com/repos/Judopay/JudoKitObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Judopay/JudoKitObjC/downloads","issues_url":"https://api.github.com/repos/Judopay/JudoKitObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Judopay/JudoKitObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Judopay/JudoKitObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Judopay/JudoKitObjC/labels{/name}","releases_url":"https://api.github.com/repos/Judopay/JudoKitObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Judopay/JudoKitObjC/deployments","created_at":"2015-11-10T11:07:10Z","updated_at":"2020-01-10T14:19:38Z","pushed_at":"2020-01-13T15:17:02Z","git_url":"git://github.com/Judopay/JudoKitObjC.git","ssh_url":"git@github.com:Judopay/JudoKitObjC.git","clone_url":"https://github.com/Judopay/JudoKitObjC.git","svn_url":"https://github.com/Judopay/JudoKitObjC","homepage":"https://judopay.com","size":2238,"stargazers_count":3,"watchers_count":3,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":10,"watchers":3,"default_branch":"master"}},"base":{"label":"Judopay:develop","ref":"develop","sha":"d9ef3701cf48b102c23a2db61340c185ff92f009","user":{"login":"Judopay","id":3963274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NjMyNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3963274?v=4","gravatar_id":"","url":"https://api.github.com/users/Judopay","html_url":"https://github.com/Judopay","followers_url":"https://api.github.com/users/Judopay/followers","following_url":"https://api.github.com/users/Judopay/following{/other_user}","gists_url":"https://api.github.com/users/Judopay/gists{/gist_id}","starred_url":"https://api.github.com/users/Judopay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Judopay/subscriptions","organizations_url":"https://api.github.com/users/Judopay/orgs","repos_url":"https://api.github.com/users/Judopay/repos","events_url":"https://api.github.com/users/Judopay/events{/privacy}","received_events_url":"https://api.github.com/users/Judopay/received_events","type":"Organization","site_admin":false},"repo":{"id":45906608,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkwNjYwOA==","name":"JudoKitObjC","full_name":"Judopay/JudoKitObjC","private":false,"owner":{"login":"Judopay","id":3963274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NjMyNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3963274?v=4","gravatar_id":"","url":"https://api.github.com/users/Judopay","html_url":"https://github.com/Judopay","followers_url":"https://api.github.com/users/Judopay/followers","following_url":"https://api.github.com/users/Judopay/following{/other_user}","gists_url":"https://api.github.com/users/Judopay/gists{/gist_id}","starred_url":"https://api.github.com/users/Judopay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Judopay/subscriptions","organizations_url":"https://api.github.com/users/Judopay/orgs","repos_url":"https://api.github.com/users/Judopay/repos","events_url":"https://api.github.com/users/Judopay/events{/privacy}","received_events_url":"https://api.github.com/users/Judopay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Judopay/JudoKitObjC","description":"Judopay's Objective-C SDK for a simple, quick, and secure integration of in-app payments.","fork":false,"url":"https://api.github.com/repos/Judopay/JudoKitObjC","forks_url":"https://api.github.com/repos/Judopay/JudoKitObjC/forks","keys_url":"https://api.github.com/repos/Judopay/JudoKitObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Judopay/JudoKitObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Judopay/JudoKitObjC/teams","hooks_url":"https://api.github.com/repos/Judopay/JudoKitObjC/hooks","issue_events_url":"https://api.github.com/repos/Judopay/JudoKitObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Judopay/JudoKitObjC/events","assignees_url":"https://api.github.com/repos/Judopay/JudoKitObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Judopay/JudoKitObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Judopay/JudoKitObjC/tags","blobs_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Judopay/JudoKitObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Judopay/JudoKitObjC/languages","stargazers_url":"https://api.github.com/repos/Judopay/JudoKitObjC/stargazers","contributors_url":"https://api.github.com/repos/Judopay/JudoKitObjC/contributors","subscribers_url":"https://api.github.com/repos/Judopay/JudoKitObjC/subscribers","subscription_url":"https://api.github.com/repos/Judopay/JudoKitObjC/subscription","commits_url":"https://api.github.com/repos/Judopay/JudoKitObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Judopay/JudoKitObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Judopay/JudoKitObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Judopay/JudoKitObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Judopay/JudoKitObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Judopay/JudoKitObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Judopay/JudoKitObjC/merges","archive_url":"https://api.github.com/repos/Judopay/JudoKitObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Judopay/JudoKitObjC/downloads","issues_url":"https://api.github.com/repos/Judopay/JudoKitObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Judopay/JudoKitObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Judopay/JudoKitObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Judopay/JudoKitObjC/labels{/name}","releases_url":"https://api.github.com/repos/Judopay/JudoKitObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Judopay/JudoKitObjC/deployments","created_at":"2015-11-10T11:07:10Z","updated_at":"2020-01-10T14:19:38Z","pushed_at":"2020-01-13T15:17:02Z","git_url":"git://github.com/Judopay/JudoKitObjC.git","ssh_url":"git@github.com:Judopay/JudoKitObjC.git","clone_url":"https://github.com/Judopay/JudoKitObjC.git","svn_url":"https://github.com/Judopay/JudoKitObjC","homepage":"https://judopay.com","size":2238,"stargazers_count":3,"watchers_count":3,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/182"},"html":{"href":"https://github.com/Judopay/JudoKitObjC/pull/182"},"issue":{"href":"https://api.github.com/repos/Judopay/JudoKitObjC/issues/182"},"comments":{"href":"https://api.github.com/repos/Judopay/JudoKitObjC/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Judopay/JudoKitObjC/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/Judopay/JudoKitObjC/statuses/33d10d981ce1871edf0b08cc3b64ff1dfce63c18"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 45906608,
"name": "Judopay/JudoKitObjC",
"url": "https://api.github.com/repos/Judopay/JudoKitObjC"
}
|
{
"id": 51994215,
"login": "stpopa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51994215?",
"url": "https://api.github.com/users/stpopa"
}
|
{
"id": 3963274,
"login": "Judopay",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3963274?",
"url": "https://api.github.com/orgs/Judopay"
}
| 2020-01-14T00:14:05 |
11266879870
|
{"actor":{"display_login":"stpopa"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rcl/pulls/comments/322519823","pull_request_review_id":285865556,"id":322519823,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjUxOTgyMw==","diff_hunk":"@@ -39,15 +39,19 @@ typedef struct rcl_arguments_t\n #define RCL_ROS_ARGS_EXPLICIT_END_TOKEN \"--\"\n #define RCL_PARAM_FLAG \"--param\"\n #define RCL_SHORT_PARAM_FLAG \"-p\"\n+#define RCL_PARAM_FILE_FLAG \"--params-file\"\n+#define RCL_SHORT_PARAM_FILE_FLAG \"-f\"\n #define RCL_REMAP_FLAG \"--remap\"\n #define RCL_SHORT_REMAP_FLAG \"-r\"\n+#define RCL_LOG_LEVEL_FLAG \"--log-level\"\n+#define RCL_SHORT_LOG_LEVEL_FLAG \"-l\"\n+#define RCL_EXTERNAL_LOG_CONFIG_FLAG \"--log-config-file\"\n+#define RCL_SHORT_EXTERNAL_LOG_CONFIG_FLAG \"-c\"\n+// To be prefixed with --enable- or --disable-\n+#define RCL_LOG_STDOUT_FLAG_SUFFIX \"stdout-logs\"\n+#define RCL_LOG_ROSOUT_FLAG_SUFFIX \"rosout-logs\"\n+#define RCL_LOG_EXT_LIB_FLAG_SUFFIX \"external-lib-logs\"\n \n-#define RCL_LOG_LEVEL_ARG_RULE \"__log_level:=\"","path":"rcl/include/rcl/arguments.h","position":14,"original_position":17,"commit_id":"5f8181c1aa39c562417557720e6ae697e859e735","original_commit_id":"cefafd47e5fb15fb327ff7c8bed50529dd2a3429","user":{"login":"hidmic","id":13500507,"node_id":"MDQ6VXNlcjEzNTAwNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/13500507?v=4","gravatar_id":"","url":"https://api.github.com/users/hidmic","html_url":"https://github.com/hidmic","followers_url":"https://api.github.com/users/hidmic/followers","following_url":"https://api.github.com/users/hidmic/following{/other_user}","gists_url":"https://api.github.com/users/hidmic/gists{/gist_id}","starred_url":"https://api.github.com/users/hidmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hidmic/subscriptions","organizations_url":"https://api.github.com/users/hidmic/orgs","repos_url":"https://api.github.com/users/hidmic/repos","events_url":"https://api.github.com/users/hidmic/events{/privacy}","received_events_url":"https://api.github.com/users/hidmic/received_events","type":"User","site_admin":false},"body":"Right, that's sort of my point. If we strictly abide to a deprecation cycle we need to support arguments outside `--ros-args`, the ones that used to be there in Dashing. Otherwise, it's like half breaking compatibility.","created_at":"2019-09-10T01:34:36Z","updated_at":"2019-09-10T01:34:36Z","html_url":"https://github.com/ros2/rcl/pull/495#discussion_r322519823","pull_request_url":"https://api.github.com/repos/ros2/rcl/pulls/495","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ros2/rcl/pulls/comments/322519823"},"html":{"href":"https://github.com/ros2/rcl/pull/495#discussion_r322519823"},"pull_request":{"href":"https://api.github.com/repos/ros2/rcl/pulls/495"}},"in_reply_to_id":322366467},"pull_request":{"url":"https://api.github.com/repos/ros2/rcl/pulls/495","id":315071512,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1MDcxNTEy","html_url":"https://github.com/ros2/rcl/pull/495","diff_url":"https://github.com/ros2/rcl/pull/495.diff","patch_url":"https://github.com/ros2/rcl/pull/495.patch","issue_url":"https://api.github.com/repos/ros2/rcl/issues/495","number":495,"state":"open","locked":false,"title":"Promote special CLI rules to flags","user":{"login":"hidmic","id":13500507,"node_id":"MDQ6VXNlcjEzNTAwNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/13500507?v=4","gravatar_id":"","url":"https://api.github.com/users/hidmic","html_url":"https://github.com/hidmic","followers_url":"https://api.github.com/users/hidmic/followers","following_url":"https://api.github.com/users/hidmic/following{/other_user}","gists_url":"https://api.github.com/users/hidmic/gists{/gist_id}","starred_url":"https://api.github.com/users/hidmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hidmic/subscriptions","organizations_url":"https://api.github.com/users/hidmic/orgs","repos_url":"https://api.github.com/users/hidmic/repos","events_url":"https://api.github.com/users/hidmic/events{/privacy}","received_events_url":"https://api.github.com/users/hidmic/received_events","type":"User","site_admin":false},"body":"Precisely what the title says. This pull request promotes all leading double underscore CLI rules to regular flags e.g. `__params:=some_file.yaml` to `--params-file some_file.yaml`, to be expected in the context of CLI provided `--ros-args ... --`.","created_at":"2019-09-06T18:45:26Z","updated_at":"2019-09-10T01:34:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"204cd0142783651934b15a7102de01b96d50e242","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jacobperron","id":1218431,"node_id":"MDQ6VXNlcjEyMTg0MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1218431?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobperron","html_url":"https://github.com/jacobperron","followers_url":"https://api.github.com/users/jacobperron/followers","following_url":"https://api.github.com/users/jacobperron/following{/other_user}","gists_url":"https://api.github.com/users/jacobperron/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobperron/subscriptions","organizations_url":"https://api.github.com/users/jacobperron/orgs","repos_url":"https://api.github.com/users/jacobperron/repos","events_url":"https://api.github.com/users/jacobperron/events{/privacy}","received_events_url":"https://api.github.com/users/jacobperron/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rcl/pulls/495/commits","review_comments_url":"https://api.github.com/repos/ros2/rcl/pulls/495/comments","review_comment_url":"https://api.github.com/repos/ros2/rcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rcl/issues/495/comments","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/5f8181c1aa39c562417557720e6ae697e859e735","head":{"label":"ros2:hidmic/switch-to-cli-flags","ref":"hidmic/switch-to-cli-flags","sha":"5f8181c1aa39c562417557720e6ae697e859e735","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":31091419,"node_id":"MDEwOlJlcG9zaXRvcnkzMTA5MTQxOQ==","name":"rcl","full_name":"ros2/rcl","private":false,"owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros2/rcl","description":"Library to support implementation of language specific ROS Client Libraries.","fork":false,"url":"https://api.github.com/repos/ros2/rcl","forks_url":"https://api.github.com/repos/ros2/rcl/forks","keys_url":"https://api.github.com/repos/ros2/rcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rcl/teams","hooks_url":"https://api.github.com/repos/ros2/rcl/hooks","issue_events_url":"https://api.github.com/repos/ros2/rcl/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rcl/events","assignees_url":"https://api.github.com/repos/ros2/rcl/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rcl/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rcl/tags","blobs_url":"https://api.github.com/repos/ros2/rcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rcl/languages","stargazers_url":"https://api.github.com/repos/ros2/rcl/stargazers","contributors_url":"https://api.github.com/repos/ros2/rcl/contributors","subscribers_url":"https://api.github.com/repos/ros2/rcl/subscribers","subscription_url":"https://api.github.com/repos/ros2/rcl/subscription","commits_url":"https://api.github.com/repos/ros2/rcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rcl/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rcl/merges","archive_url":"https://api.github.com/repos/ros2/rcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rcl/downloads","issues_url":"https://api.github.com/repos/ros2/rcl/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rcl/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rcl/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rcl/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rcl/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rcl/deployments","created_at":"2015-02-21T00:06:40Z","updated_at":"2019-09-06T18:35:36Z","pushed_at":"2019-09-10T01:27:56Z","git_url":"git://github.com/ros2/rcl.git","ssh_url":"git@github.com:ros2/rcl.git","clone_url":"https://github.com/ros2/rcl.git","svn_url":"https://github.com/ros2/rcl","homepage":null,"size":1586,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":57,"open_issues":42,"watchers":33,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"40a276b6f45e3bd990aab75fbf476554ee96f46f","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":31091419,"node_id":"MDEwOlJlcG9zaXRvcnkzMTA5MTQxOQ==","name":"rcl","full_name":"ros2/rcl","private":false,"owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros2/rcl","description":"Library to support implementation of language specific ROS Client Libraries.","fork":false,"url":"https://api.github.com/repos/ros2/rcl","forks_url":"https://api.github.com/repos/ros2/rcl/forks","keys_url":"https://api.github.com/repos/ros2/rcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rcl/teams","hooks_url":"https://api.github.com/repos/ros2/rcl/hooks","issue_events_url":"https://api.github.com/repos/ros2/rcl/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rcl/events","assignees_url":"https://api.github.com/repos/ros2/rcl/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rcl/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rcl/tags","blobs_url":"https://api.github.com/repos/ros2/rcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rcl/languages","stargazers_url":"https://api.github.com/repos/ros2/rcl/stargazers","contributors_url":"https://api.github.com/repos/ros2/rcl/contributors","subscribers_url":"https://api.github.com/repos/ros2/rcl/subscribers","subscription_url":"https://api.github.com/repos/ros2/rcl/subscription","commits_url":"https://api.github.com/repos/ros2/rcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rcl/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rcl/merges","archive_url":"https://api.github.com/repos/ros2/rcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rcl/downloads","issues_url":"https://api.github.com/repos/ros2/rcl/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rcl/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rcl/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rcl/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rcl/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rcl/deployments","created_at":"2015-02-21T00:06:40Z","updated_at":"2019-09-06T18:35:36Z","pushed_at":"2019-09-10T01:27:56Z","git_url":"git://github.com/ros2/rcl.git","ssh_url":"git@github.com:ros2/rcl.git","clone_url":"https://github.com/ros2/rcl.git","svn_url":"https://github.com/ros2/rcl","homepage":null,"size":1586,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":57,"open_issues":42,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rcl/pulls/495"},"html":{"href":"https://github.com/ros2/rcl/pull/495"},"issue":{"href":"https://api.github.com/repos/ros2/rcl/issues/495"},"comments":{"href":"https://api.github.com/repos/ros2/rcl/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rcl/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rcl/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rcl/statuses/5f8181c1aa39c562417557720e6ae697e859e735"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 31091419,
"name": "ros2/rcl",
"url": "https://api.github.com/repos/ros2/rcl"
}
|
{
"id": 13500507,
"login": "hidmic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13500507?",
"url": "https://api.github.com/users/hidmic"
}
|
{
"id": 3979232,
"login": "ros2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3979232?",
"url": "https://api.github.com/orgs/ros2"
}
| 2019-09-10T01:34:36 |
10380913354
|
{"actor":{"display_login":"hidmic"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/comments/278621635","pull_request_review_id":230741051,"id":278621635,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODYyMTYzNQ==","diff_hunk":"@@ -707,6 +707,134 @@ func testBitbucketServerSetDefaultRepositoryQueryMigration(store repos.Store) fu\n \t}\n }\n \n+func TestBitbucketServerUsernameMigration(t *testing.T) {\n+\tt.Parallel()\n+\ttestBitbucketServerUsernameMigration(new(repos.FakeStore))(t)\n+}\n+\n+func testBitbucketServerUsernameMigration(store repos.Store) func(*testing.T) {","path":"cmd/repo-updater/repos/migrations_test.go","position":9,"original_position":9,"commit_id":"629cf0c619638cb8d0f935107d87583687f3becc","original_commit_id":"629cf0c619638cb8d0f935107d87583687f3becc","user":{"login":"tsenart","id":67471,"node_id":"MDQ6VXNlcjY3NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/67471?v=4","gravatar_id":"","url":"https://api.github.com/users/tsenart","html_url":"https://github.com/tsenart","followers_url":"https://api.github.com/users/tsenart/followers","following_url":"https://api.github.com/users/tsenart/following{/other_user}","gists_url":"https://api.github.com/users/tsenart/gists{/gist_id}","starred_url":"https://api.github.com/users/tsenart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsenart/subscriptions","organizations_url":"https://api.github.com/users/tsenart/orgs","repos_url":"https://api.github.com/users/tsenart/repos","events_url":"https://api.github.com/users/tsenart/events{/privacy}","received_events_url":"https://api.github.com/users/tsenart/received_events","type":"User","site_admin":false},"body":"Because their ran with different `repos.Store` implementations. One with a real `repos.DBStore` in `TestIntegration`, and the other with a `repos.FakeStore`.\r\n","created_at":"2019-04-25T16:00:24Z","updated_at":"2019-04-25T16:00:24Z","html_url":"https://github.com/sourcegraph/sourcegraph/pull/3601#discussion_r278621635","pull_request_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/3601","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/comments/278621635"},"html":{"href":"https://github.com/sourcegraph/sourcegraph/pull/3601#discussion_r278621635"},"pull_request":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/3601"}},"in_reply_to_id":278579354},"pull_request":{"url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/3601","id":273480663,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczNDgwNjYz","html_url":"https://github.com/sourcegraph/sourcegraph/pull/3601","diff_url":"https://github.com/sourcegraph/sourcegraph/pull/3601.diff","patch_url":"https://github.com/sourcegraph/sourcegraph/pull/3601.patch","issue_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/3601","number":3601,"state":"open","locked":false,"title":"repo-updater: BitbucketServerUsernameMigration","user":{"login":"tsenart","id":67471,"node_id":"MDQ6VXNlcjY3NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/67471?v=4","gravatar_id":"","url":"https://api.github.com/users/tsenart","html_url":"https://github.com/tsenart","followers_url":"https://api.github.com/users/tsenart/followers","following_url":"https://api.github.com/users/tsenart/following{/other_user}","gists_url":"https://api.github.com/users/tsenart/gists{/gist_id}","starred_url":"https://api.github.com/users/tsenart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsenart/subscriptions","organizations_url":"https://api.github.com/users/tsenart/orgs","repos_url":"https://api.github.com/users/tsenart/repos","events_url":"https://api.github.com/users/tsenart/events{/privacy}","received_events_url":"https://api.github.com/users/tsenart/received_events","type":"User","site_admin":false},"body":"This commit implements a best effort migration that extracts the\r\nusername from the `url` field of Bitbucket Server external service\r\nconfigurations and sets in the `username` field if missing or empty.\r\n\r\nThe `username` field became required in #3299 because it was always\r\nactually required for things to fuction properly.\r\n\r\nIf there are configs without the `username` field set not the `user`\r\npart of the `url` set, the admins will need to intervene to fix their\r\nconfigs manually.\r\n\r\nFixes #3592\r\n","created_at":"2019-04-25T11:14:38Z","updated_at":"2019-04-25T16:00:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9a92fe25cf32a7c612f8b8f94ba839024b25442","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mrnugget","id":1185253,"node_id":"MDQ6VXNlcjExODUyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1185253?v=4","gravatar_id":"","url":"https://api.github.com/users/mrnugget","html_url":"https://github.com/mrnugget","followers_url":"https://api.github.com/users/mrnugget/followers","following_url":"https://api.github.com/users/mrnugget/following{/other_user}","gists_url":"https://api.github.com/users/mrnugget/gists{/gist_id}","starred_url":"https://api.github.com/users/mrnugget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrnugget/subscriptions","organizations_url":"https://api.github.com/users/mrnugget/orgs","repos_url":"https://api.github.com/users/mrnugget/repos","events_url":"https://api.github.com/users/mrnugget/events{/privacy}","received_events_url":"https://api.github.com/users/mrnugget/received_events","type":"User","site_admin":false},{"login":"slimsag","id":3173176,"node_id":"MDQ6VXNlcjMxNzMxNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3173176?v=4","gravatar_id":"","url":"https://api.github.com/users/slimsag","html_url":"https://github.com/slimsag","followers_url":"https://api.github.com/users/slimsag/followers","following_url":"https://api.github.com/users/slimsag/following{/other_user}","gists_url":"https://api.github.com/users/slimsag/gists{/gist_id}","starred_url":"https://api.github.com/users/slimsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimsag/subscriptions","organizations_url":"https://api.github.com/users/slimsag/orgs","repos_url":"https://api.github.com/users/slimsag/repos","events_url":"https://api.github.com/users/slimsag/events{/privacy}","received_events_url":"https://api.github.com/users/slimsag/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1309179802,"node_id":"MDU6TGFiZWwxMzA5MTc5ODAy","url":"https://api.github.com/repos/sourcegraph/sourcegraph/labels/team/core-services","name":"team/core-services","color":"ff9bb6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/3601/commits","review_comments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/3601/comments","review_comment_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/3601/comments","statuses_url":"https://api.github.com/repos/sourcegraph/sourcegraph/statuses/629cf0c619638cb8d0f935107d87583687f3becc","head":{"label":"sourcegraph:core/bitbucket-username-migration","ref":"core/bitbucket-username-migration","sha":"629cf0c619638cb8d0f935107d87583687f3becc","user":{"login":"sourcegraph","id":3979584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzk1ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3979584?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":41288708,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI4ODcwOA==","name":"sourcegraph","full_name":"sourcegraph/sourcegraph","private":false,"owner":{"login":"sourcegraph","id":3979584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzk1ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3979584?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sourcegraph/sourcegraph","description":"Code search and navigation tool (self-hosted)","fork":false,"url":"https://api.github.com/repos/sourcegraph/sourcegraph","forks_url":"https://api.github.com/repos/sourcegraph/sourcegraph/forks","keys_url":"https://api.github.com/repos/sourcegraph/sourcegraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/sourcegraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/sourcegraph/teams","hooks_url":"https://api.github.com/repos/sourcegraph/sourcegraph/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/sourcegraph/events","assignees_url":"https://api.github.com/repos/sourcegraph/sourcegraph/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/sourcegraph/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/sourcegraph/tags","blobs_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/sourcegraph/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/sourcegraph/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/sourcegraph/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/sourcegraph/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/sourcegraph/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/sourcegraph/subscription","commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/sourcegraph/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/sourcegraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/sourcegraph/merges","archive_url":"https://api.github.com/repos/sourcegraph/sourcegraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/sourcegraph/downloads","issues_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/sourcegraph/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/sourcegraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/sourcegraph/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/sourcegraph/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/deployments","created_at":"2015-08-24T07:27:28Z","updated_at":"2019-04-25T15:58:01Z","pushed_at":"2019-04-25T15:58:24Z","git_url":"git://github.com/sourcegraph/sourcegraph.git","ssh_url":"git@github.com:sourcegraph/sourcegraph.git","clone_url":"https://github.com/sourcegraph/sourcegraph.git","svn_url":"https://github.com/sourcegraph/sourcegraph","homepage":"https://sourcegraph.com","size":297056,"stargazers_count":2047,"watchers_count":2047,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":783,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":137,"open_issues":783,"watchers":2047,"default_branch":"master"}},"base":{"label":"sourcegraph:master","ref":"master","sha":"90938366c4c2bcacd58220333cfd51f93a701aa9","user":{"login":"sourcegraph","id":3979584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzk1ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3979584?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":41288708,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI4ODcwOA==","name":"sourcegraph","full_name":"sourcegraph/sourcegraph","private":false,"owner":{"login":"sourcegraph","id":3979584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzk1ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3979584?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sourcegraph/sourcegraph","description":"Code search and navigation tool (self-hosted)","fork":false,"url":"https://api.github.com/repos/sourcegraph/sourcegraph","forks_url":"https://api.github.com/repos/sourcegraph/sourcegraph/forks","keys_url":"https://api.github.com/repos/sourcegraph/sourcegraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/sourcegraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/sourcegraph/teams","hooks_url":"https://api.github.com/repos/sourcegraph/sourcegraph/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/sourcegraph/events","assignees_url":"https://api.github.com/repos/sourcegraph/sourcegraph/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/sourcegraph/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/sourcegraph/tags","blobs_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/sourcegraph/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/sourcegraph/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/sourcegraph/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/sourcegraph/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/sourcegraph/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/sourcegraph/subscription","commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/sourcegraph/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/sourcegraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/sourcegraph/merges","archive_url":"https://api.github.com/repos/sourcegraph/sourcegraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/sourcegraph/downloads","issues_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/sourcegraph/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/sourcegraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/sourcegraph/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/sourcegraph/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/deployments","created_at":"2015-08-24T07:27:28Z","updated_at":"2019-04-25T15:58:01Z","pushed_at":"2019-04-25T15:58:24Z","git_url":"git://github.com/sourcegraph/sourcegraph.git","ssh_url":"git@github.com:sourcegraph/sourcegraph.git","clone_url":"https://github.com/sourcegraph/sourcegraph.git","svn_url":"https://github.com/sourcegraph/sourcegraph","homepage":"https://sourcegraph.com","size":297056,"stargazers_count":2047,"watchers_count":2047,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":783,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":137,"open_issues":783,"watchers":2047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/3601"},"html":{"href":"https://github.com/sourcegraph/sourcegraph/pull/3601"},"issue":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/3601"},"comments":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/3601/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/3601/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/3601/commits"},"statuses":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/statuses/629cf0c619638cb8d0f935107d87583687f3becc"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 41288708,
"name": "sourcegraph/sourcegraph",
"url": "https://api.github.com/repos/sourcegraph/sourcegraph"
}
|
{
"id": 67471,
"login": "tsenart",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/67471?",
"url": "https://api.github.com/users/tsenart"
}
|
{
"id": 3979584,
"login": "sourcegraph",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3979584?",
"url": "https://api.github.com/orgs/sourcegraph"
}
| 2019-04-25T16:00:24 |
9511630986
|
{"actor":{"display_login":"tsenart"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/crate/crate/pulls/comments/270078755","pull_request_review_id":220119047,"id":270078755,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MDA3ODc1NQ==","diff_hunk":"@@ -41,6 +41,11 @@ Unreleased Changes\n Breaking Changes\n ================\n \n+- Removed deprecated ``nGram``, ``edgeNGram`` token filter and ``htmlStrip``\n+ char filter, they are superseded by ``ngram``, ``edge_ngram``and","path":"blackbox/docs/appendices/release-notes/unreleased.rst","position":5,"original_position":5,"commit_id":"11c4aef03326820f33498fd457a34a677bf33907","original_commit_id":"11c4aef03326820f33498fd457a34a677bf33907","user":{"login":"seut","id":219690,"node_id":"MDQ6VXNlcjIxOTY5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/219690?v=4","gravatar_id":"","url":"https://api.github.com/users/seut","html_url":"https://github.com/seut","followers_url":"https://api.github.com/users/seut/followers","following_url":"https://api.github.com/users/seut/following{/other_user}","gists_url":"https://api.github.com/users/seut/gists{/gist_id}","starred_url":"https://api.github.com/users/seut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seut/subscriptions","organizations_url":"https://api.github.com/users/seut/orgs","repos_url":"https://api.github.com/users/seut/repos","events_url":"https://api.github.com/users/seut/events{/privacy}","received_events_url":"https://api.github.com/users/seut/received_events","type":"User","site_admin":false},"body":"Please move to `Deprecations`, these changes are not breaking.","created_at":"2019-03-28T16:02:35Z","updated_at":"2019-03-28T16:02:39Z","html_url":"https://github.com/crate/crate/pull/8464#discussion_r270078755","pull_request_url":"https://api.github.com/repos/crate/crate/pulls/8464","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/crate/crate/pulls/comments/270078755"},"html":{"href":"https://github.com/crate/crate/pull/8464#discussion_r270078755"},"pull_request":{"href":"https://api.github.com/repos/crate/crate/pulls/8464"}},"in_reply_to_id":270078111},"pull_request":{"url":"https://api.github.com/repos/crate/crate/pulls/8464","id":264964281,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0OTY0Mjgx","html_url":"https://github.com/crate/crate/pull/8464","diff_url":"https://github.com/crate/crate/pull/8464.diff","patch_url":"https://github.com/crate/crate/pull/8464.patch","issue_url":"https://api.github.com/repos/crate/crate/issues/8464","number":8464,"state":"open","locked":false,"title":"Remove deprecated nGram, edgeNGram, htmlStrip Tokenfilters names in favour for ngram, edge_ngram, and html_strip","user":{"login":"mkleen","id":338234,"node_id":"MDQ6VXNlcjMzODIzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/338234?v=4","gravatar_id":"","url":"https://api.github.com/users/mkleen","html_url":"https://github.com/mkleen","followers_url":"https://api.github.com/users/mkleen/followers","following_url":"https://api.github.com/users/mkleen/following{/other_user}","gists_url":"https://api.github.com/users/mkleen/gists{/gist_id}","starred_url":"https://api.github.com/users/mkleen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkleen/subscriptions","organizations_url":"https://api.github.com/users/mkleen/orgs","repos_url":"https://api.github.com/users/mkleen/repos","events_url":"https://api.github.com/users/mkleen/events{/privacy}","received_events_url":"https://api.github.com/users/mkleen/received_events","type":"User","site_admin":false},"body":"## Summary of the changes / Why this improves CrateDB\r\n\r\n\r\n## Checklist\r\n\r\n - [x] User relevant changes are recorded in ``CHANGES.txt``\r\n - [ ] Touched code is covered by tests\r\n - [x] Documentation has been updated if necessary\r\n - [x] [CLA](https://crate.io/community/contribute/cla/) is signed\r\n","created_at":"2019-03-27T14:56:28Z","updated_at":"2019-03-28T16:02:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1245cb3a3ee4af60362607dbc63080849187398d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crate/crate/pulls/8464/commits","review_comments_url":"https://api.github.com/repos/crate/crate/pulls/8464/comments","review_comment_url":"https://api.github.com/repos/crate/crate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crate/crate/issues/8464/comments","statuses_url":"https://api.github.com/repos/crate/crate/statuses/11c4aef03326820f33498fd457a34a677bf33907","head":{"label":"crate:mkleen/remove_deprecated_tokenfilters","ref":"mkleen/remove_deprecated_tokenfilters","sha":"11c4aef03326820f33498fd457a34a677bf33907","user":{"login":"crate","id":4048232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":9342529,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQyNTI5","name":"crate","full_name":"crate/crate","private":false,"owner":{"login":"crate","id":4048232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crate/crate","description":"CrateDB is a distributed SQL database that makes it simple to store and analyze massive amounts of machine data in real-time.","fork":false,"url":"https://api.github.com/repos/crate/crate","forks_url":"https://api.github.com/repos/crate/crate/forks","keys_url":"https://api.github.com/repos/crate/crate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/crate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/crate/teams","hooks_url":"https://api.github.com/repos/crate/crate/hooks","issue_events_url":"https://api.github.com/repos/crate/crate/issues/events{/number}","events_url":"https://api.github.com/repos/crate/crate/events","assignees_url":"https://api.github.com/repos/crate/crate/assignees{/user}","branches_url":"https://api.github.com/repos/crate/crate/branches{/branch}","tags_url":"https://api.github.com/repos/crate/crate/tags","blobs_url":"https://api.github.com/repos/crate/crate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/crate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/crate/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/crate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/crate/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/crate/languages","stargazers_url":"https://api.github.com/repos/crate/crate/stargazers","contributors_url":"https://api.github.com/repos/crate/crate/contributors","subscribers_url":"https://api.github.com/repos/crate/crate/subscribers","subscription_url":"https://api.github.com/repos/crate/crate/subscription","commits_url":"https://api.github.com/repos/crate/crate/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/crate/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/crate/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/crate/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/crate/contents/{+path}","compare_url":"https://api.github.com/repos/crate/crate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/crate/merges","archive_url":"https://api.github.com/repos/crate/crate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/crate/downloads","issues_url":"https://api.github.com/repos/crate/crate/issues{/number}","pulls_url":"https://api.github.com/repos/crate/crate/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/crate/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/crate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/crate/labels{/name}","releases_url":"https://api.github.com/repos/crate/crate/releases{/id}","deployments_url":"https://api.github.com/repos/crate/crate/deployments","created_at":"2013-04-10T09:17:16Z","updated_at":"2019-03-28T15:41:05Z","pushed_at":"2019-03-28T15:57:32Z","git_url":"git://github.com/crate/crate.git","ssh_url":"git@github.com:crate/crate.git","clone_url":"https://github.com/crate/crate.git","svn_url":"https://github.com/crate/crate","homepage":"https://crate.io","size":91904,"stargazers_count":2364,"watchers_count":2364,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":324,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":324,"open_issues":86,"watchers":2364,"default_branch":"master"}},"base":{"label":"crate:master","ref":"master","sha":"720aa1fe3c5256d6dcddb7dc271f04e9b64d4ddb","user":{"login":"crate","id":4048232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":9342529,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQyNTI5","name":"crate","full_name":"crate/crate","private":false,"owner":{"login":"crate","id":4048232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4048232?v=4","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crate/crate","description":"CrateDB is a distributed SQL database that makes it simple to store and analyze massive amounts of machine data in real-time.","fork":false,"url":"https://api.github.com/repos/crate/crate","forks_url":"https://api.github.com/repos/crate/crate/forks","keys_url":"https://api.github.com/repos/crate/crate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/crate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/crate/teams","hooks_url":"https://api.github.com/repos/crate/crate/hooks","issue_events_url":"https://api.github.com/repos/crate/crate/issues/events{/number}","events_url":"https://api.github.com/repos/crate/crate/events","assignees_url":"https://api.github.com/repos/crate/crate/assignees{/user}","branches_url":"https://api.github.com/repos/crate/crate/branches{/branch}","tags_url":"https://api.github.com/repos/crate/crate/tags","blobs_url":"https://api.github.com/repos/crate/crate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/crate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/crate/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/crate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/crate/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/crate/languages","stargazers_url":"https://api.github.com/repos/crate/crate/stargazers","contributors_url":"https://api.github.com/repos/crate/crate/contributors","subscribers_url":"https://api.github.com/repos/crate/crate/subscribers","subscription_url":"https://api.github.com/repos/crate/crate/subscription","commits_url":"https://api.github.com/repos/crate/crate/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/crate/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/crate/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/crate/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/crate/contents/{+path}","compare_url":"https://api.github.com/repos/crate/crate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/crate/merges","archive_url":"https://api.github.com/repos/crate/crate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/crate/downloads","issues_url":"https://api.github.com/repos/crate/crate/issues{/number}","pulls_url":"https://api.github.com/repos/crate/crate/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/crate/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/crate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/crate/labels{/name}","releases_url":"https://api.github.com/repos/crate/crate/releases{/id}","deployments_url":"https://api.github.com/repos/crate/crate/deployments","created_at":"2013-04-10T09:17:16Z","updated_at":"2019-03-28T15:41:05Z","pushed_at":"2019-03-28T15:57:32Z","git_url":"git://github.com/crate/crate.git","ssh_url":"git@github.com:crate/crate.git","clone_url":"https://github.com/crate/crate.git","svn_url":"https://github.com/crate/crate","homepage":"https://crate.io","size":91904,"stargazers_count":2364,"watchers_count":2364,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":324,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":324,"open_issues":86,"watchers":2364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crate/crate/pulls/8464"},"html":{"href":"https://github.com/crate/crate/pull/8464"},"issue":{"href":"https://api.github.com/repos/crate/crate/issues/8464"},"comments":{"href":"https://api.github.com/repos/crate/crate/issues/8464/comments"},"review_comments":{"href":"https://api.github.com/repos/crate/crate/pulls/8464/comments"},"review_comment":{"href":"https://api.github.com/repos/crate/crate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crate/crate/pulls/8464/commits"},"statuses":{"href":"https://api.github.com/repos/crate/crate/statuses/11c4aef03326820f33498fd457a34a677bf33907"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 9342529,
"name": "crate/crate",
"url": "https://api.github.com/repos/crate/crate"
}
|
{
"id": 219690,
"login": "seut",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/219690?",
"url": "https://api.github.com/users/seut"
}
|
{
"id": 4048232,
"login": "crate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4048232?",
"url": "https://api.github.com/orgs/crate"
}
| 2019-03-28T16:02:35 |
9334301697
|
{"actor":{"display_login":"seut"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/comments/289979052","pull_request_review_id":245051067,"id":289979052,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4OTk3OTA1Mg==","diff_hunk":"@@ -9,11 +9,21 @@ import UIKit\n \n class FirstViewController: UIViewController {\n \n+ // This is the GameStatRepo that is instanitated in the AppDelegate file\n+ var gameRepo: GameStatProtocol?\n+ \n override func viewDidLoad() {\n super.viewDidLoad()\n // Do any additional setup after loading the view.\n }\n \n-\n+ // Handle the segues to the GameStatHistoryViewController and GalleryViewController\n+ override func prepare(for segue: UIStoryboardSegue, sender: Any?) {\n+ // The 'forward' method is located in the UIStoryboardSegue file\n+ if(segue.identifier == \"segueShowGameStatHistory\") {","path":"GYBITG/FirstViewController.swift","position":16,"original_position":16,"commit_id":"1a9d7a22f74427d4813998ef974103cafb3b8b6f","original_commit_id":"1a9d7a22f74427d4813998ef974103cafb3b8b6f","user":{"login":"jc-hayes","id":35407151,"node_id":"MDQ6VXNlcjM1NDA3MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/35407151?v=4","gravatar_id":"","url":"https://api.github.com/users/jc-hayes","html_url":"https://github.com/jc-hayes","followers_url":"https://api.github.com/users/jc-hayes/followers","following_url":"https://api.github.com/users/jc-hayes/following{/other_user}","gists_url":"https://api.github.com/users/jc-hayes/gists{/gist_id}","starred_url":"https://api.github.com/users/jc-hayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc-hayes/subscriptions","organizations_url":"https://api.github.com/users/jc-hayes/orgs","repos_url":"https://api.github.com/users/jc-hayes/repos","events_url":"https://api.github.com/users/jc-hayes/events{/privacy}","received_events_url":"https://api.github.com/users/jc-hayes/received_events","type":"User","site_admin":false},"body":"Got it, I'll make those changes.","created_at":"2019-06-03T18:33:46Z","updated_at":"2019-06-03T18:33:47Z","html_url":"https://github.com/MobileApps-Cascadia/gybitg-ios/pull/28#discussion_r289979052","pull_request_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/28","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/comments/289979052"},"html":{"href":"https://github.com/MobileApps-Cascadia/gybitg-ios/pull/28#discussion_r289979052"},"pull_request":{"href":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/28"}},"in_reply_to_id":289674574},"pull_request":{"url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/28","id":284316536,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0MzE2NTM2","html_url":"https://github.com/MobileApps-Cascadia/gybitg-ios/pull/28","diff_url":"https://github.com/MobileApps-Cascadia/gybitg-ios/pull/28.diff","patch_url":"https://github.com/MobileApps-Cascadia/gybitg-ios/pull/28.patch","issue_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues/28","number":28,"state":"open","locked":false,"title":"closes issue#17-save-GameStat","user":{"login":"jc-hayes","id":35407151,"node_id":"MDQ6VXNlcjM1NDA3MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/35407151?v=4","gravatar_id":"","url":"https://api.github.com/users/jc-hayes","html_url":"https://github.com/jc-hayes","followers_url":"https://api.github.com/users/jc-hayes/followers","following_url":"https://api.github.com/users/jc-hayes/following{/other_user}","gists_url":"https://api.github.com/users/jc-hayes/gists{/gist_id}","starred_url":"https://api.github.com/users/jc-hayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc-hayes/subscriptions","organizations_url":"https://api.github.com/users/jc-hayes/orgs","repos_url":"https://api.github.com/users/jc-hayes/repos","events_url":"https://api.github.com/users/jc-hayes/events{/privacy}","received_events_url":"https://api.github.com/users/jc-hayes/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-02T04:55:54Z","updated_at":"2019-06-03T18:33:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4494fff3461ee0b6166f185aac20f9c06faf4d6a","assignee":{"login":"jc-hayes","id":35407151,"node_id":"MDQ6VXNlcjM1NDA3MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/35407151?v=4","gravatar_id":"","url":"https://api.github.com/users/jc-hayes","html_url":"https://github.com/jc-hayes","followers_url":"https://api.github.com/users/jc-hayes/followers","following_url":"https://api.github.com/users/jc-hayes/following{/other_user}","gists_url":"https://api.github.com/users/jc-hayes/gists{/gist_id}","starred_url":"https://api.github.com/users/jc-hayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc-hayes/subscriptions","organizations_url":"https://api.github.com/users/jc-hayes/orgs","repos_url":"https://api.github.com/users/jc-hayes/repos","events_url":"https://api.github.com/users/jc-hayes/events{/privacy}","received_events_url":"https://api.github.com/users/jc-hayes/received_events","type":"User","site_admin":false},"assignees":[{"login":"jc-hayes","id":35407151,"node_id":"MDQ6VXNlcjM1NDA3MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/35407151?v=4","gravatar_id":"","url":"https://api.github.com/users/jc-hayes","html_url":"https://github.com/jc-hayes","followers_url":"https://api.github.com/users/jc-hayes/followers","following_url":"https://api.github.com/users/jc-hayes/following{/other_user}","gists_url":"https://api.github.com/users/jc-hayes/gists{/gist_id}","starred_url":"https://api.github.com/users/jc-hayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc-hayes/subscriptions","organizations_url":"https://api.github.com/users/jc-hayes/orgs","repos_url":"https://api.github.com/users/jc-hayes/repos","events_url":"https://api.github.com/users/jc-hayes/events{/privacy}","received_events_url":"https://api.github.com/users/jc-hayes/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"shariefyoussef","id":1047107,"node_id":"MDQ6VXNlcjEwNDcxMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1047107?v=4","gravatar_id":"","url":"https://api.github.com/users/shariefyoussef","html_url":"https://github.com/shariefyoussef","followers_url":"https://api.github.com/users/shariefyoussef/followers","following_url":"https://api.github.com/users/shariefyoussef/following{/other_user}","gists_url":"https://api.github.com/users/shariefyoussef/gists{/gist_id}","starred_url":"https://api.github.com/users/shariefyoussef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shariefyoussef/subscriptions","organizations_url":"https://api.github.com/users/shariefyoussef/orgs","repos_url":"https://api.github.com/users/shariefyoussef/repos","events_url":"https://api.github.com/users/shariefyoussef/events{/privacy}","received_events_url":"https://api.github.com/users/shariefyoussef/received_events","type":"User","site_admin":false},{"login":"MeyAyre","id":14324873,"node_id":"MDQ6VXNlcjE0MzI0ODcz","avatar_url":"https://avatars1.githubusercontent.com/u/14324873?v=4","gravatar_id":"","url":"https://api.github.com/users/MeyAyre","html_url":"https://github.com/MeyAyre","followers_url":"https://api.github.com/users/MeyAyre/followers","following_url":"https://api.github.com/users/MeyAyre/following{/other_user}","gists_url":"https://api.github.com/users/MeyAyre/gists{/gist_id}","starred_url":"https://api.github.com/users/MeyAyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeyAyre/subscriptions","organizations_url":"https://api.github.com/users/MeyAyre/orgs","repos_url":"https://api.github.com/users/MeyAyre/repos","events_url":"https://api.github.com/users/MeyAyre/events{/privacy}","received_events_url":"https://api.github.com/users/MeyAyre/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/28/commits","review_comments_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/28/comments","review_comment_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues/28/comments","statuses_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/statuses/1a9d7a22f74427d4813998ef974103cafb3b8b6f","head":{"label":"MobileApps-Cascadia:james-issue17-saveGameStat","ref":"james-issue17-saveGameStat","sha":"1a9d7a22f74427d4813998ef974103cafb3b8b6f","user":{"login":"MobileApps-Cascadia","id":4070232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzAyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4070232?v=4","gravatar_id":"","url":"https://api.github.com/users/MobileApps-Cascadia","html_url":"https://github.com/MobileApps-Cascadia","followers_url":"https://api.github.com/users/MobileApps-Cascadia/followers","following_url":"https://api.github.com/users/MobileApps-Cascadia/following{/other_user}","gists_url":"https://api.github.com/users/MobileApps-Cascadia/gists{/gist_id}","starred_url":"https://api.github.com/users/MobileApps-Cascadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobileApps-Cascadia/subscriptions","organizations_url":"https://api.github.com/users/MobileApps-Cascadia/orgs","repos_url":"https://api.github.com/users/MobileApps-Cascadia/repos","events_url":"https://api.github.com/users/MobileApps-Cascadia/events{/privacy}","received_events_url":"https://api.github.com/users/MobileApps-Cascadia/received_events","type":"Organization","site_admin":false},"repo":{"id":181424171,"node_id":"MDEwOlJlcG9zaXRvcnkxODE0MjQxNzE=","name":"gybitg-ios","full_name":"MobileApps-Cascadia/gybitg-ios","private":false,"owner":{"login":"MobileApps-Cascadia","id":4070232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzAyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4070232?v=4","gravatar_id":"","url":"https://api.github.com/users/MobileApps-Cascadia","html_url":"https://github.com/MobileApps-Cascadia","followers_url":"https://api.github.com/users/MobileApps-Cascadia/followers","following_url":"https://api.github.com/users/MobileApps-Cascadia/following{/other_user}","gists_url":"https://api.github.com/users/MobileApps-Cascadia/gists{/gist_id}","starred_url":"https://api.github.com/users/MobileApps-Cascadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobileApps-Cascadia/subscriptions","organizations_url":"https://api.github.com/users/MobileApps-Cascadia/orgs","repos_url":"https://api.github.com/users/MobileApps-Cascadia/repos","events_url":"https://api.github.com/users/MobileApps-Cascadia/events{/privacy}","received_events_url":"https://api.github.com/users/MobileApps-Cascadia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MobileApps-Cascadia/gybitg-ios","description":null,"fork":false,"url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios","forks_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/forks","keys_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/teams","hooks_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/hooks","issue_events_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues/events{/number}","events_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/events","assignees_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/assignees{/user}","branches_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/branches{/branch}","tags_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/tags","blobs_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/languages","stargazers_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/stargazers","contributors_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/contributors","subscribers_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/subscribers","subscription_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/subscription","commits_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/contents/{+path}","compare_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/merges","archive_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/downloads","issues_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues{/number}","pulls_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/labels{/name}","releases_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/releases{/id}","deployments_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/deployments","created_at":"2019-04-15T06:18:27Z","updated_at":"2019-05-01T01:20:11Z","pushed_at":"2019-06-02T05:05:28Z","git_url":"git://github.com/MobileApps-Cascadia/gybitg-ios.git","ssh_url":"git@github.com:MobileApps-Cascadia/gybitg-ios.git","clone_url":"https://github.com/MobileApps-Cascadia/gybitg-ios.git","svn_url":"https://github.com/MobileApps-Cascadia/gybitg-ios","homepage":null,"size":8312,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"MobileApps-Cascadia:develop","ref":"develop","sha":"6b1938766594a52956569764e90b5c3a8061bd66","user":{"login":"MobileApps-Cascadia","id":4070232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzAyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4070232?v=4","gravatar_id":"","url":"https://api.github.com/users/MobileApps-Cascadia","html_url":"https://github.com/MobileApps-Cascadia","followers_url":"https://api.github.com/users/MobileApps-Cascadia/followers","following_url":"https://api.github.com/users/MobileApps-Cascadia/following{/other_user}","gists_url":"https://api.github.com/users/MobileApps-Cascadia/gists{/gist_id}","starred_url":"https://api.github.com/users/MobileApps-Cascadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobileApps-Cascadia/subscriptions","organizations_url":"https://api.github.com/users/MobileApps-Cascadia/orgs","repos_url":"https://api.github.com/users/MobileApps-Cascadia/repos","events_url":"https://api.github.com/users/MobileApps-Cascadia/events{/privacy}","received_events_url":"https://api.github.com/users/MobileApps-Cascadia/received_events","type":"Organization","site_admin":false},"repo":{"id":181424171,"node_id":"MDEwOlJlcG9zaXRvcnkxODE0MjQxNzE=","name":"gybitg-ios","full_name":"MobileApps-Cascadia/gybitg-ios","private":false,"owner":{"login":"MobileApps-Cascadia","id":4070232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzAyMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4070232?v=4","gravatar_id":"","url":"https://api.github.com/users/MobileApps-Cascadia","html_url":"https://github.com/MobileApps-Cascadia","followers_url":"https://api.github.com/users/MobileApps-Cascadia/followers","following_url":"https://api.github.com/users/MobileApps-Cascadia/following{/other_user}","gists_url":"https://api.github.com/users/MobileApps-Cascadia/gists{/gist_id}","starred_url":"https://api.github.com/users/MobileApps-Cascadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobileApps-Cascadia/subscriptions","organizations_url":"https://api.github.com/users/MobileApps-Cascadia/orgs","repos_url":"https://api.github.com/users/MobileApps-Cascadia/repos","events_url":"https://api.github.com/users/MobileApps-Cascadia/events{/privacy}","received_events_url":"https://api.github.com/users/MobileApps-Cascadia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MobileApps-Cascadia/gybitg-ios","description":null,"fork":false,"url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios","forks_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/forks","keys_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/teams","hooks_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/hooks","issue_events_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues/events{/number}","events_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/events","assignees_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/assignees{/user}","branches_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/branches{/branch}","tags_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/tags","blobs_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/languages","stargazers_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/stargazers","contributors_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/contributors","subscribers_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/subscribers","subscription_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/subscription","commits_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/contents/{+path}","compare_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/merges","archive_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/downloads","issues_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues{/number}","pulls_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/labels{/name}","releases_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/releases{/id}","deployments_url":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/deployments","created_at":"2019-04-15T06:18:27Z","updated_at":"2019-05-01T01:20:11Z","pushed_at":"2019-06-02T05:05:28Z","git_url":"git://github.com/MobileApps-Cascadia/gybitg-ios.git","ssh_url":"git@github.com:MobileApps-Cascadia/gybitg-ios.git","clone_url":"https://github.com/MobileApps-Cascadia/gybitg-ios.git","svn_url":"https://github.com/MobileApps-Cascadia/gybitg-ios","homepage":null,"size":8312,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/28"},"html":{"href":"https://github.com/MobileApps-Cascadia/gybitg-ios/pull/28"},"issue":{"href":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues/28"},"comments":{"href":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios/statuses/1a9d7a22f74427d4813998ef974103cafb3b8b6f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 181424171,
"name": "MobileApps-Cascadia/gybitg-ios",
"url": "https://api.github.com/repos/MobileApps-Cascadia/gybitg-ios"
}
|
{
"id": 35407151,
"login": "jc-hayes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35407151?",
"url": "https://api.github.com/users/jc-hayes"
}
|
{
"id": 4070232,
"login": "MobileApps-Cascadia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4070232?",
"url": "https://api.github.com/orgs/MobileApps-Cascadia"
}
| 2019-06-03T18:33:46 |
9749280014
|
{"actor":{"display_login":"jc-hayes"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wework/grabbit/pulls/comments/314832894","pull_request_review_id":276093970,"id":314832894,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDgzMjg5NA==","diff_hunk":"@@ -9,6 +9,12 @@ github.com/Shopify/sarama v1.23.0 h1:slvlbm7bxyp7sKQbUwha5BQdZTqurhRoI+zbKorVigQ\n github.com/Shopify/sarama v1.23.0/go.mod h1:XLH1GYJnLVE0XCr6KdJGVJRTwY30moWNJ4sERjXX6fs=\n github.com/Shopify/toxiproxy v2.1.4+incompatible h1:TKdv8HiTLgE5wdJuEML90aBgNWsokNbMijUGhmcoBJc=\n github.com/Shopify/toxiproxy v2.1.4+incompatible/go.mod h1:OXgGpZ6Cli1/URJOF1DMxUHB2q5Ap20/P/eIdh4G0pI=\n+github.com/adiweiss/migrator v0.1.1 h1:unnb8Z83UIOrjRPI/A8jS67EGQs3W8V0OtnzEJOhIuY=","path":"go.sum","position":4,"original_position":4,"commit_id":"d7fcce924def78012eb28a2519e96b7a70bffaee","original_commit_id":"d7fcce924def78012eb28a2519e96b7a70bffaee","user":{"login":"rhinof","id":526333,"node_id":"MDQ6VXNlcjUyNjMzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/526333?v=4","gravatar_id":"","url":"https://api.github.com/users/rhinof","html_url":"https://github.com/rhinof","followers_url":"https://api.github.com/users/rhinof/followers","following_url":"https://api.github.com/users/rhinof/following{/other_user}","gists_url":"https://api.github.com/users/rhinof/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinof/subscriptions","organizations_url":"https://api.github.com/users/rhinof/orgs","repos_url":"https://api.github.com/users/rhinof/repos","events_url":"https://api.github.com/users/rhinof/events{/privacy}","received_events_url":"https://api.github.com/users/rhinof/received_events","type":"User","site_admin":false},"body":"remove references to github.com/adiweiss/migrator","created_at":"2019-08-16T18:10:43Z","updated_at":"2019-08-16T18:12:57Z","html_url":"https://github.com/wework/grabbit/pull/111#discussion_r314832894","pull_request_url":"https://api.github.com/repos/wework/grabbit/pulls/111","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wework/grabbit/pulls/comments/314832894"},"html":{"href":"https://github.com/wework/grabbit/pull/111#discussion_r314832894"},"pull_request":{"href":"https://api.github.com/repos/wework/grabbit/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/wework/grabbit/pulls/111","id":304047891,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0MDQ3ODkx","html_url":"https://github.com/wework/grabbit/pull/111","diff_url":"https://github.com/wework/grabbit/pull/111.diff","patch_url":"https://github.com/wework/grabbit/pull/111.patch","issue_url":"https://api.github.com/repos/wework/grabbit/issues/111","number":111,"state":"open","locked":false,"title":"Migrations functionality","user":{"login":"adiweiss","id":46281796,"node_id":"MDQ6VXNlcjQ2MjgxNzk2","avatar_url":"https://avatars1.githubusercontent.com/u/46281796?v=4","gravatar_id":"","url":"https://api.github.com/users/adiweiss","html_url":"https://github.com/adiweiss","followers_url":"https://api.github.com/users/adiweiss/followers","following_url":"https://api.github.com/users/adiweiss/following{/other_user}","gists_url":"https://api.github.com/users/adiweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/adiweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiweiss/subscriptions","organizations_url":"https://api.github.com/users/adiweiss/orgs","repos_url":"https://api.github.com/users/adiweiss/repos","events_url":"https://api.github.com/users/adiweiss/events{/privacy}","received_events_url":"https://api.github.com/users/adiweiss/received_events","type":"User","site_admin":false},"body":"issue: https://github.com/wework/grabbit/issues/42\r\n","created_at":"2019-08-04T07:20:29Z","updated_at":"2019-08-16T18:12:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"077cb5b10299e82600f5b295c84329ae4e86d15e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wework/grabbit/pulls/111/commits","review_comments_url":"https://api.github.com/repos/wework/grabbit/pulls/111/comments","review_comment_url":"https://api.github.com/repos/wework/grabbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wework/grabbit/issues/111/comments","statuses_url":"https://api.github.com/repos/wework/grabbit/statuses/d7fcce924def78012eb28a2519e96b7a70bffaee","head":{"label":"wework:migrations_functionality","ref":"migrations_functionality","sha":"d7fcce924def78012eb28a2519e96b7a70bffaee","user":{"login":"wework","id":4072897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzI4OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4072897?v=4","gravatar_id":"","url":"https://api.github.com/users/wework","html_url":"https://github.com/wework","followers_url":"https://api.github.com/users/wework/followers","following_url":"https://api.github.com/users/wework/following{/other_user}","gists_url":"https://api.github.com/users/wework/gists{/gist_id}","starred_url":"https://api.github.com/users/wework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wework/subscriptions","organizations_url":"https://api.github.com/users/wework/orgs","repos_url":"https://api.github.com/users/wework/repos","events_url":"https://api.github.com/users/wework/events{/privacy}","received_events_url":"https://api.github.com/users/wework/received_events","type":"Organization","site_admin":false},"repo":{"id":179554098,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk1NTQwOTg=","name":"grabbit","full_name":"wework/grabbit","private":false,"owner":{"login":"wework","id":4072897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzI4OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4072897?v=4","gravatar_id":"","url":"https://api.github.com/users/wework","html_url":"https://github.com/wework","followers_url":"https://api.github.com/users/wework/followers","following_url":"https://api.github.com/users/wework/following{/other_user}","gists_url":"https://api.github.com/users/wework/gists{/gist_id}","starred_url":"https://api.github.com/users/wework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wework/subscriptions","organizations_url":"https://api.github.com/users/wework/orgs","repos_url":"https://api.github.com/users/wework/repos","events_url":"https://api.github.com/users/wework/events{/privacy}","received_events_url":"https://api.github.com/users/wework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wework/grabbit","description":"A lightweight transactional message bus on top of RabbitMQ","fork":false,"url":"https://api.github.com/repos/wework/grabbit","forks_url":"https://api.github.com/repos/wework/grabbit/forks","keys_url":"https://api.github.com/repos/wework/grabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wework/grabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wework/grabbit/teams","hooks_url":"https://api.github.com/repos/wework/grabbit/hooks","issue_events_url":"https://api.github.com/repos/wework/grabbit/issues/events{/number}","events_url":"https://api.github.com/repos/wework/grabbit/events","assignees_url":"https://api.github.com/repos/wework/grabbit/assignees{/user}","branches_url":"https://api.github.com/repos/wework/grabbit/branches{/branch}","tags_url":"https://api.github.com/repos/wework/grabbit/tags","blobs_url":"https://api.github.com/repos/wework/grabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wework/grabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wework/grabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/wework/grabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wework/grabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/wework/grabbit/languages","stargazers_url":"https://api.github.com/repos/wework/grabbit/stargazers","contributors_url":"https://api.github.com/repos/wework/grabbit/contributors","subscribers_url":"https://api.github.com/repos/wework/grabbit/subscribers","subscription_url":"https://api.github.com/repos/wework/grabbit/subscription","commits_url":"https://api.github.com/repos/wework/grabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/wework/grabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/wework/grabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/wework/grabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/wework/grabbit/contents/{+path}","compare_url":"https://api.github.com/repos/wework/grabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wework/grabbit/merges","archive_url":"https://api.github.com/repos/wework/grabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wework/grabbit/downloads","issues_url":"https://api.github.com/repos/wework/grabbit/issues{/number}","pulls_url":"https://api.github.com/repos/wework/grabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/wework/grabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/wework/grabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wework/grabbit/labels{/name}","releases_url":"https://api.github.com/repos/wework/grabbit/releases{/id}","deployments_url":"https://api.github.com/repos/wework/grabbit/deployments","created_at":"2019-04-04T18:30:07Z","updated_at":"2019-08-15T20:06:55Z","pushed_at":"2019-08-16T06:17:21Z","git_url":"git://github.com/wework/grabbit.git","ssh_url":"git@github.com:wework/grabbit.git","clone_url":"https://github.com/wework/grabbit.git","svn_url":"https://github.com/wework/grabbit","homepage":"","size":1668,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":23,"watchers":25,"default_branch":"master"}},"base":{"label":"wework:v1.x","ref":"v1.x","sha":"82eb197a637dec08d553e75122ac7d8239662261","user":{"login":"wework","id":4072897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzI4OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4072897?v=4","gravatar_id":"","url":"https://api.github.com/users/wework","html_url":"https://github.com/wework","followers_url":"https://api.github.com/users/wework/followers","following_url":"https://api.github.com/users/wework/following{/other_user}","gists_url":"https://api.github.com/users/wework/gists{/gist_id}","starred_url":"https://api.github.com/users/wework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wework/subscriptions","organizations_url":"https://api.github.com/users/wework/orgs","repos_url":"https://api.github.com/users/wework/repos","events_url":"https://api.github.com/users/wework/events{/privacy}","received_events_url":"https://api.github.com/users/wework/received_events","type":"Organization","site_admin":false},"repo":{"id":179554098,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk1NTQwOTg=","name":"grabbit","full_name":"wework/grabbit","private":false,"owner":{"login":"wework","id":4072897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzI4OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4072897?v=4","gravatar_id":"","url":"https://api.github.com/users/wework","html_url":"https://github.com/wework","followers_url":"https://api.github.com/users/wework/followers","following_url":"https://api.github.com/users/wework/following{/other_user}","gists_url":"https://api.github.com/users/wework/gists{/gist_id}","starred_url":"https://api.github.com/users/wework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wework/subscriptions","organizations_url":"https://api.github.com/users/wework/orgs","repos_url":"https://api.github.com/users/wework/repos","events_url":"https://api.github.com/users/wework/events{/privacy}","received_events_url":"https://api.github.com/users/wework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wework/grabbit","description":"A lightweight transactional message bus on top of RabbitMQ","fork":false,"url":"https://api.github.com/repos/wework/grabbit","forks_url":"https://api.github.com/repos/wework/grabbit/forks","keys_url":"https://api.github.com/repos/wework/grabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wework/grabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wework/grabbit/teams","hooks_url":"https://api.github.com/repos/wework/grabbit/hooks","issue_events_url":"https://api.github.com/repos/wework/grabbit/issues/events{/number}","events_url":"https://api.github.com/repos/wework/grabbit/events","assignees_url":"https://api.github.com/repos/wework/grabbit/assignees{/user}","branches_url":"https://api.github.com/repos/wework/grabbit/branches{/branch}","tags_url":"https://api.github.com/repos/wework/grabbit/tags","blobs_url":"https://api.github.com/repos/wework/grabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wework/grabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wework/grabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/wework/grabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wework/grabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/wework/grabbit/languages","stargazers_url":"https://api.github.com/repos/wework/grabbit/stargazers","contributors_url":"https://api.github.com/repos/wework/grabbit/contributors","subscribers_url":"https://api.github.com/repos/wework/grabbit/subscribers","subscription_url":"https://api.github.com/repos/wework/grabbit/subscription","commits_url":"https://api.github.com/repos/wework/grabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/wework/grabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/wework/grabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/wework/grabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/wework/grabbit/contents/{+path}","compare_url":"https://api.github.com/repos/wework/grabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wework/grabbit/merges","archive_url":"https://api.github.com/repos/wework/grabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wework/grabbit/downloads","issues_url":"https://api.github.com/repos/wework/grabbit/issues{/number}","pulls_url":"https://api.github.com/repos/wework/grabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/wework/grabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/wework/grabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wework/grabbit/labels{/name}","releases_url":"https://api.github.com/repos/wework/grabbit/releases{/id}","deployments_url":"https://api.github.com/repos/wework/grabbit/deployments","created_at":"2019-04-04T18:30:07Z","updated_at":"2019-08-15T20:06:55Z","pushed_at":"2019-08-16T06:17:21Z","git_url":"git://github.com/wework/grabbit.git","ssh_url":"git@github.com:wework/grabbit.git","clone_url":"https://github.com/wework/grabbit.git","svn_url":"https://github.com/wework/grabbit","homepage":"","size":1668,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":23,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wework/grabbit/pulls/111"},"html":{"href":"https://github.com/wework/grabbit/pull/111"},"issue":{"href":"https://api.github.com/repos/wework/grabbit/issues/111"},"comments":{"href":"https://api.github.com/repos/wework/grabbit/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/wework/grabbit/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/wework/grabbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wework/grabbit/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/wework/grabbit/statuses/d7fcce924def78012eb28a2519e96b7a70bffaee"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 179554098,
"name": "wework/grabbit",
"url": "https://api.github.com/repos/wework/grabbit"
}
|
{
"id": 526333,
"login": "rhinof",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/526333?",
"url": "https://api.github.com/users/rhinof"
}
|
{
"id": 4072897,
"login": "wework",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4072897?",
"url": "https://api.github.com/orgs/wework"
}
| 2019-08-16T18:10:43 |
10226575315
|
{"actor":{"display_login":"rhinof"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/andela/vali-ah-backend/pulls/comments/306285931","pull_request_review_id":265366262,"id":306285931,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjI4NTkzMQ==","diff_hunk":"@@ -4,7 +4,10 @@\n \"description\": \"A Social platform for the creative at heart\",\n \"main\": \"index.js\",\n \"scripts\": {\n- \"test\": \"echo \\\"Error: no test specified\\\" && exit 1\"\n+ \"prestart\": \"npm run build\",","path":"package.json","position":5,"original_position":5,"commit_id":"448e2e93f1d15c599d86f7b96bac845287e07a57","original_commit_id":"448e2e93f1d15c599d86f7b96bac845287e07a57","user":{"login":"ibkadeeko","id":39800005,"node_id":"MDQ6VXNlcjM5ODAwMDA1","avatar_url":"https://avatars1.githubusercontent.com/u/39800005?v=4","gravatar_id":"","url":"https://api.github.com/users/ibkadeeko","html_url":"https://github.com/ibkadeeko","followers_url":"https://api.github.com/users/ibkadeeko/followers","following_url":"https://api.github.com/users/ibkadeeko/following{/other_user}","gists_url":"https://api.github.com/users/ibkadeeko/gists{/gist_id}","starred_url":"https://api.github.com/users/ibkadeeko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibkadeeko/subscriptions","organizations_url":"https://api.github.com/users/ibkadeeko/orgs","repos_url":"https://api.github.com/users/ibkadeeko/repos","events_url":"https://api.github.com/users/ibkadeeko/events{/privacy}","received_events_url":"https://api.github.com/users/ibkadeeko/received_events","type":"User","site_admin":false},"body":"Ok\r\nWill do that immediately","created_at":"2019-07-23T12:19:29Z","updated_at":"2019-07-23T12:19:29Z","html_url":"https://github.com/andela/vali-ah-backend/pull/4#discussion_r306285931","pull_request_url":"https://api.github.com/repos/andela/vali-ah-backend/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/andela/vali-ah-backend/pulls/comments/306285931"},"html":{"href":"https://github.com/andela/vali-ah-backend/pull/4#discussion_r306285931"},"pull_request":{"href":"https://api.github.com/repos/andela/vali-ah-backend/pulls/4"}},"in_reply_to_id":306284996},"pull_request":{"url":"https://api.github.com/repos/andela/vali-ah-backend/pulls/4","id":300018811,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMDE4ODEx","html_url":"https://github.com/andela/vali-ah-backend/pull/4","diff_url":"https://github.com/andela/vali-ah-backend/pull/4.diff","patch_url":"https://github.com/andela/vali-ah-backend/pull/4.patch","issue_url":"https://api.github.com/repos/andela/vali-ah-backend/issues/4","number":4,"state":"open","locked":false,"title":"#167439730 Setup Babel ","user":{"login":"ibkadeeko","id":39800005,"node_id":"MDQ6VXNlcjM5ODAwMDA1","avatar_url":"https://avatars1.githubusercontent.com/u/39800005?v=4","gravatar_id":"","url":"https://api.github.com/users/ibkadeeko","html_url":"https://github.com/ibkadeeko","followers_url":"https://api.github.com/users/ibkadeeko/followers","following_url":"https://api.github.com/users/ibkadeeko/following{/other_user}","gists_url":"https://api.github.com/users/ibkadeeko/gists{/gist_id}","starred_url":"https://api.github.com/users/ibkadeeko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibkadeeko/subscriptions","organizations_url":"https://api.github.com/users/ibkadeeko/orgs","repos_url":"https://api.github.com/users/ibkadeeko/repos","events_url":"https://api.github.com/users/ibkadeeko/events{/privacy}","received_events_url":"https://api.github.com/users/ibkadeeko/received_events","type":"User","site_admin":false},"body":"**What does this PR do?**\r\nThis pull request sets up babel, for compiling ES2015+ Javascript code for backward compatibility\r\n\r\n**Description of Task to be completed**\r\n- install `@babel/cli` `@babel/core` `@babel/node` `@babel/preset-env`\r\n- add babel config\r\n- add build script to package.json\r\n- add start scripts to package.json\r\n- add src folder\r\n- move `/config` `/models` `/routes` and `index.js` to src folder\r\n- add .eslintignore file for dist folder\r\n\r\n**How should this be manually tested?**\r\nN/A\r\n\r\n**Any Background Context You want to provide?**\r\nN/A\r\n\r\n**What are the relevant pivotal tracker stories?**\r\n[#167439730](https://www.pivotaltracker.com/story/show/167439730)\r\n\r\n**Screenshots (if appropriate)**\r\nN/A\r\n\r\n**Questions**\r\nN/A","created_at":"2019-07-22T20:06:02Z","updated_at":"2019-07-23T12:19:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7785e46338086c72648a121caff1a82a4fe2b1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1463466647,"node_id":"MDU6TGFiZWwxNDYzNDY2NjQ3","url":"https://api.github.com/repos/andela/vali-ah-backend/labels/ready-for-review","name":"ready-for-review","color":"bde041","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/andela/vali-ah-backend/pulls/4/commits","review_comments_url":"https://api.github.com/repos/andela/vali-ah-backend/pulls/4/comments","review_comment_url":"https://api.github.com/repos/andela/vali-ah-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/vali-ah-backend/issues/4/comments","statuses_url":"https://api.github.com/repos/andela/vali-ah-backend/statuses/448e2e93f1d15c599d86f7b96bac845287e07a57","head":{"label":"andela:ch-setup-babel-167439730","ref":"ch-setup-babel-167439730","sha":"448e2e93f1d15c599d86f7b96bac845287e07a57","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":197616451,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc2MTY0NTE=","name":"vali-ah-backend","full_name":"andela/vali-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/vali-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/vali-ah-backend","forks_url":"https://api.github.com/repos/andela/vali-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/vali-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/vali-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/vali-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/vali-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/vali-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/vali-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/vali-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/vali-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/vali-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/vali-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/vali-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/vali-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/vali-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/vali-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/vali-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/vali-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/vali-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/vali-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/vali-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/vali-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/vali-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/vali-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/vali-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/vali-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/vali-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/vali-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/vali-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/vali-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/vali-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/vali-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/vali-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/vali-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/vali-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/vali-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/vali-ah-backend/deployments","created_at":"2019-07-18T15:50:12Z","updated_at":"2019-07-22T19:17:44Z","pushed_at":"2019-07-23T12:17:43Z","git_url":"git://github.com/andela/vali-ah-backend.git","ssh_url":"git@github.com:andela/vali-ah-backend.git","clone_url":"https://github.com/andela/vali-ah-backend.git","svn_url":"https://github.com/andela/vali-ah-backend","homepage":null,"size":144,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"40d7c22bbe903928cdc36419634fb49b68217b60","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":197616451,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc2MTY0NTE=","name":"vali-ah-backend","full_name":"andela/vali-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/vali-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/vali-ah-backend","forks_url":"https://api.github.com/repos/andela/vali-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/vali-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/vali-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/vali-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/vali-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/vali-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/vali-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/vali-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/vali-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/vali-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/vali-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/vali-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/vali-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/vali-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/vali-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/vali-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/vali-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/vali-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/vali-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/vali-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/vali-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/vali-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/vali-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/vali-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/vali-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/vali-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/vali-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/vali-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/vali-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/vali-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/vali-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/vali-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/vali-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/vali-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/vali-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/vali-ah-backend/deployments","created_at":"2019-07-18T15:50:12Z","updated_at":"2019-07-22T19:17:44Z","pushed_at":"2019-07-23T12:17:43Z","git_url":"git://github.com/andela/vali-ah-backend.git","ssh_url":"git@github.com:andela/vali-ah-backend.git","clone_url":"https://github.com/andela/vali-ah-backend.git","svn_url":"https://github.com/andela/vali-ah-backend","homepage":null,"size":144,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/vali-ah-backend/pulls/4"},"html":{"href":"https://github.com/andela/vali-ah-backend/pull/4"},"issue":{"href":"https://api.github.com/repos/andela/vali-ah-backend/issues/4"},"comments":{"href":"https://api.github.com/repos/andela/vali-ah-backend/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/vali-ah-backend/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/vali-ah-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/vali-ah-backend/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/andela/vali-ah-backend/statuses/448e2e93f1d15c599d86f7b96bac845287e07a57"}},"author_association":"COLLABORATOR"}}
|
{
"id": 197616451,
"name": "andela/vali-ah-backend",
"url": "https://api.github.com/repos/andela/vali-ah-backend"
}
|
{
"id": 39800005,
"login": "ibkadeeko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39800005?",
"url": "https://api.github.com/users/ibkadeeko"
}
|
{
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
}
| 2019-07-23T12:19:29 |
10066002022
|
{"actor":{"display_login":"ibkadeeko"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/comments/295184819","pull_request_review_id":251553520,"id":295184819,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTE4NDgxOQ==","diff_hunk":"@@ -1,10 +1,11 @@\n import express from 'express';\n-import articles from '<controllers>/article';\n-import { verifyUser } from '<middlewares>/verifyUser';\n+import { createArticle, getArticles } from '<controllers>/article';\n+import { verifyUser, checkIsVerified } from '<middlewares>/verifyUser';\n import { validateCreateArticle } from '<validations>/article';\n \n const article = express.Router();\n \n-article.post('/', validateCreateArticle, verifyUser, articles);\n+article.post('/', validateCreateArticle, verifyUser, checkIsVerified, createArticle);","path":"server/routes/v1/article.js","position":11,"original_position":11,"commit_id":"ad15588f447815de4cd5fcda1c85e5a8aea1e675","original_commit_id":"ad15588f447815de4cd5fcda1c85e5a8aea1e675","user":{"login":"Sojisoyoye","id":43131939,"node_id":"MDQ6VXNlcjQzMTMxOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/43131939?v=4","gravatar_id":"","url":"https://api.github.com/users/Sojisoyoye","html_url":"https://github.com/Sojisoyoye","followers_url":"https://api.github.com/users/Sojisoyoye/followers","following_url":"https://api.github.com/users/Sojisoyoye/following{/other_user}","gists_url":"https://api.github.com/users/Sojisoyoye/gists{/gist_id}","starred_url":"https://api.github.com/users/Sojisoyoye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sojisoyoye/subscriptions","organizations_url":"https://api.github.com/users/Sojisoyoye/orgs","repos_url":"https://api.github.com/users/Sojisoyoye/repos","events_url":"https://api.github.com/users/Sojisoyoye/events{/privacy}","received_events_url":"https://api.github.com/users/Sojisoyoye/received_events","type":"User","site_admin":false},"body":"The comment above applies here too","created_at":"2019-06-19T08:43:51Z","updated_at":"2019-06-19T08:43:51Z","html_url":"https://github.com/andela/king-kong-ah-backend/pull/22#discussion_r295184819","pull_request_url":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/22","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/comments/295184819"},"html":{"href":"https://github.com/andela/king-kong-ah-backend/pull/22#discussion_r295184819"},"pull_request":{"href":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/22"}},"in_reply_to_id":294990355},"pull_request":{"url":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/22","id":288919389,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4OTE5Mzg5","html_url":"https://github.com/andela/king-kong-ah-backend/pull/22","diff_url":"https://github.com/andela/king-kong-ah-backend/pull/22.diff","patch_url":"https://github.com/andela/king-kong-ah-backend/pull/22.patch","issue_url":"https://api.github.com/repos/andela/king-kong-ah-backend/issues/22","number":22,"state":"open","locked":false,"title":"#166696942 get all articles","user":{"login":"Sojisoyoye","id":43131939,"node_id":"MDQ6VXNlcjQzMTMxOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/43131939?v=4","gravatar_id":"","url":"https://api.github.com/users/Sojisoyoye","html_url":"https://github.com/Sojisoyoye","followers_url":"https://api.github.com/users/Sojisoyoye/followers","following_url":"https://api.github.com/users/Sojisoyoye/following{/other_user}","gists_url":"https://api.github.com/users/Sojisoyoye/gists{/gist_id}","starred_url":"https://api.github.com/users/Sojisoyoye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sojisoyoye/subscriptions","organizations_url":"https://api.github.com/users/Sojisoyoye/orgs","repos_url":"https://api.github.com/users/Sojisoyoye/repos","events_url":"https://api.github.com/users/Sojisoyoye/events{/privacy}","received_events_url":"https://api.github.com/users/Sojisoyoye/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\nThis PR gets all articles\r\n\r\n#### Description of Task to be completed?\r\n\r\n- create get articles controller\r\n- add get articles route\r\n- add verify user middleware\r\n- write test for the route\r\n\r\n#### How should this be manually tested?\r\n\r\nAfter cloning the repo, CD to the directory\r\ncd to branch ft-get-articles-166696942\r\nrun npm install\r\nrun npm test\r\n\r\n#### Any background context you want to provide?\r\n\r\nTo run this project, you need nodejs and postgres installed\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n\r\n[166696942]","created_at":"2019-06-17T16:20:00Z","updated_at":"2019-06-19T08:43:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bc17074c3cac4030184aec396feec01f8473adb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"frankly034","id":31358867,"node_id":"MDQ6VXNlcjMxMzU4ODY3","avatar_url":"https://avatars3.githubusercontent.com/u/31358867?v=4","gravatar_id":"","url":"https://api.github.com/users/frankly034","html_url":"https://github.com/frankly034","followers_url":"https://api.github.com/users/frankly034/followers","following_url":"https://api.github.com/users/frankly034/following{/other_user}","gists_url":"https://api.github.com/users/frankly034/gists{/gist_id}","starred_url":"https://api.github.com/users/frankly034/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankly034/subscriptions","organizations_url":"https://api.github.com/users/frankly034/orgs","repos_url":"https://api.github.com/users/frankly034/repos","events_url":"https://api.github.com/users/frankly034/events{/privacy}","received_events_url":"https://api.github.com/users/frankly034/received_events","type":"User","site_admin":false},{"login":"mosinmiloluwa01","id":41510712,"node_id":"MDQ6VXNlcjQxNTEwNzEy","avatar_url":"https://avatars3.githubusercontent.com/u/41510712?v=4","gravatar_id":"","url":"https://api.github.com/users/mosinmiloluwa01","html_url":"https://github.com/mosinmiloluwa01","followers_url":"https://api.github.com/users/mosinmiloluwa01/followers","following_url":"https://api.github.com/users/mosinmiloluwa01/following{/other_user}","gists_url":"https://api.github.com/users/mosinmiloluwa01/gists{/gist_id}","starred_url":"https://api.github.com/users/mosinmiloluwa01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosinmiloluwa01/subscriptions","organizations_url":"https://api.github.com/users/mosinmiloluwa01/orgs","repos_url":"https://api.github.com/users/mosinmiloluwa01/repos","events_url":"https://api.github.com/users/mosinmiloluwa01/events{/privacy}","received_events_url":"https://api.github.com/users/mosinmiloluwa01/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1381184832,"node_id":"MDU6TGFiZWwxMzgxMTg0ODMy","url":"https://api.github.com/repos/andela/king-kong-ah-backend/labels/work%20in%20progress","name":"work in progress","color":"dbbc0f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/22/commits","review_comments_url":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/22/comments","review_comment_url":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/king-kong-ah-backend/issues/22/comments","statuses_url":"https://api.github.com/repos/andela/king-kong-ah-backend/statuses/ad15588f447815de4cd5fcda1c85e5a8aea1e675","head":{"label":"andela:ft-get-articles-166696942","ref":"ft-get-articles-166696942","sha":"ad15588f447815de4cd5fcda1c85e5a8aea1e675","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":188863042,"node_id":"MDEwOlJlcG9zaXRvcnkxODg4NjMwNDI=","name":"king-kong-ah-backend","full_name":"andela/king-kong-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/king-kong-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/king-kong-ah-backend","forks_url":"https://api.github.com/repos/andela/king-kong-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/king-kong-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/king-kong-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/king-kong-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/king-kong-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/king-kong-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/king-kong-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/king-kong-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/king-kong-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/king-kong-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/king-kong-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/king-kong-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/king-kong-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/king-kong-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/king-kong-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/king-kong-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/king-kong-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/king-kong-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/king-kong-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/king-kong-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/king-kong-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/king-kong-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/king-kong-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/king-kong-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/king-kong-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/king-kong-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/king-kong-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/king-kong-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/king-kong-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/king-kong-ah-backend/deployments","created_at":"2019-05-27T14:55:02Z","updated_at":"2019-06-17T15:08:52Z","pushed_at":"2019-06-19T08:41:41Z","git_url":"git://github.com/andela/king-kong-ah-backend.git","ssh_url":"git@github.com:andela/king-kong-ah-backend.git","clone_url":"https://github.com/andela/king-kong-ah-backend.git","svn_url":"https://github.com/andela/king-kong-ah-backend","homepage":null,"size":214,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"331e466223c52bcfb1cf41c2737e8721aea311d9","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":188863042,"node_id":"MDEwOlJlcG9zaXRvcnkxODg4NjMwNDI=","name":"king-kong-ah-backend","full_name":"andela/king-kong-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/king-kong-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/king-kong-ah-backend","forks_url":"https://api.github.com/repos/andela/king-kong-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/king-kong-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/king-kong-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/king-kong-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/king-kong-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/king-kong-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/king-kong-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/king-kong-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/king-kong-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/king-kong-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/king-kong-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/king-kong-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/king-kong-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/king-kong-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/king-kong-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/king-kong-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/king-kong-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/king-kong-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/king-kong-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/king-kong-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/king-kong-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/king-kong-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/king-kong-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/king-kong-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/king-kong-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/king-kong-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/king-kong-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/king-kong-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/king-kong-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/king-kong-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/king-kong-ah-backend/deployments","created_at":"2019-05-27T14:55:02Z","updated_at":"2019-06-17T15:08:52Z","pushed_at":"2019-06-19T08:41:41Z","git_url":"git://github.com/andela/king-kong-ah-backend.git","ssh_url":"git@github.com:andela/king-kong-ah-backend.git","clone_url":"https://github.com/andela/king-kong-ah-backend.git","svn_url":"https://github.com/andela/king-kong-ah-backend","homepage":null,"size":214,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/22"},"html":{"href":"https://github.com/andela/king-kong-ah-backend/pull/22"},"issue":{"href":"https://api.github.com/repos/andela/king-kong-ah-backend/issues/22"},"comments":{"href":"https://api.github.com/repos/andela/king-kong-ah-backend/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/king-kong-ah-backend/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/andela/king-kong-ah-backend/statuses/ad15588f447815de4cd5fcda1c85e5a8aea1e675"}},"author_association":"COLLABORATOR"}}
|
{
"id": 188863042,
"name": "andela/king-kong-ah-backend",
"url": "https://api.github.com/repos/andela/king-kong-ah-backend"
}
|
{
"id": 43131939,
"login": "Sojisoyoye",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43131939?",
"url": "https://api.github.com/users/Sojisoyoye"
}
|
{
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
}
| 2019-06-19T08:43:51 |
9850672647
|
{"actor":{"display_login":"Sojisoyoye"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/andela/shadowcat-backend/pulls/comments/314995187","pull_request_review_id":276288695,"id":314995187,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDk5NTE4Nw==","diff_hunk":"@@ -0,0 +1,28 @@\n+import bcrypt from 'bcryptjs';\n+export default {\n+ up: (queryInterface, Sequelize) => queryInterface.bulkInsert(\n+ 'Users',\n+ [\n+ {\n+ firstname: 'Chima',\n+ lastname:'Mark',\n+ email: 'chimamark@example.com',\n+ password:bcrypt.hashSync('Chibyke8%', 10),\n+ createdAt: new Date(),\n+ updatedAt: new Date(),\n+ },\n+ {\n+ firstname: 'frank',\n+ lastname:'chidinma',","path":"src/database/seeders/20190817154557-User.js","position":16,"original_position":16,"commit_id":"331a01b473871e49d1708fe8c50a97126e874b58","original_commit_id":"331a01b473871e49d1708fe8c50a97126e874b58","user":{"login":"hound[bot]","id":30008653,"node_id":"MDM6Qm90MzAwMDg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/in/3598?v=4","gravatar_id":"","url":"https://api.github.com/users/hound%5Bbot%5D","html_url":"https://github.com/apps/hound","followers_url":"https://api.github.com/users/hound%5Bbot%5D/followers","following_url":"https://api.github.com/users/hound%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/hound%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/hound%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hound%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/hound%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/hound%5Bbot%5D/repos","events_url":"https://api.github.com/users/hound%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/hound%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Missing space before value for key 'lastname' key-spacing","created_at":"2019-08-18T17:39:28Z","updated_at":"2019-08-18T17:39:28Z","html_url":"https://github.com/andela/shadowcat-backend/pull/15#discussion_r314995187","pull_request_url":"https://api.github.com/repos/andela/shadowcat-backend/pulls/15","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/shadowcat-backend/pulls/comments/314995187"},"html":{"href":"https://github.com/andela/shadowcat-backend/pull/15#discussion_r314995187"},"pull_request":{"href":"https://api.github.com/repos/andela/shadowcat-backend/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/andela/shadowcat-backend/pulls/15","id":308372135,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4MzcyMTM1","html_url":"https://github.com/andela/shadowcat-backend/pull/15","diff_url":"https://github.com/andela/shadowcat-backend/pull/15.diff","patch_url":"https://github.com/andela/shadowcat-backend/pull/15.patch","issue_url":"https://api.github.com/repos/andela/shadowcat-backend/issues/15","number":15,"state":"open","locked":false,"title":"#167729772 setting up sequelize","user":{"login":"chibytez","id":40635822,"node_id":"MDQ6VXNlcjQwNjM1ODIy","avatar_url":"https://avatars1.githubusercontent.com/u/40635822?v=4","gravatar_id":"","url":"https://api.github.com/users/chibytez","html_url":"https://github.com/chibytez","followers_url":"https://api.github.com/users/chibytez/followers","following_url":"https://api.github.com/users/chibytez/following{/other_user}","gists_url":"https://api.github.com/users/chibytez/gists{/gist_id}","starred_url":"https://api.github.com/users/chibytez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibytez/subscriptions","organizations_url":"https://api.github.com/users/chibytez/orgs","repos_url":"https://api.github.com/users/chibytez/repos","events_url":"https://api.github.com/users/chibytez/events{/privacy}","received_events_url":"https://api.github.com/users/chibytez/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nadding sequelize\r\n#### Description of Task to be completed?\r\nset up sequelize\r\ninstall bcryptjs\r\nadd migration\r\nseed the user's table\r\n#### How should this be manually tested?\r\n#### Any background context you want to provide?\r\nnone\r\n#### What are the relevant pivotal tracker stories?\r\n #167729772\r\n#### Screenshots (if appropriate)\r\n\r\n\r\n\r\n\r\n#### Questions:","created_at":"2019-08-18T15:16:46Z","updated_at":"2019-08-18T17:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc007a0916525a13811bbd84d077e026a3adadc4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"okabamac","id":30778719,"node_id":"MDQ6VXNlcjMwNzc4NzE5","avatar_url":"https://avatars3.githubusercontent.com/u/30778719?v=4","gravatar_id":"","url":"https://api.github.com/users/okabamac","html_url":"https://github.com/okabamac","followers_url":"https://api.github.com/users/okabamac/followers","following_url":"https://api.github.com/users/okabamac/following{/other_user}","gists_url":"https://api.github.com/users/okabamac/gists{/gist_id}","starred_url":"https://api.github.com/users/okabamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okabamac/subscriptions","organizations_url":"https://api.github.com/users/okabamac/orgs","repos_url":"https://api.github.com/users/okabamac/repos","events_url":"https://api.github.com/users/okabamac/events{/privacy}","received_events_url":"https://api.github.com/users/okabamac/received_events","type":"User","site_admin":false},{"login":"davidfrank96","id":43038045,"node_id":"MDQ6VXNlcjQzMDM4MDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/43038045?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfrank96","html_url":"https://github.com/davidfrank96","followers_url":"https://api.github.com/users/davidfrank96/followers","following_url":"https://api.github.com/users/davidfrank96/following{/other_user}","gists_url":"https://api.github.com/users/davidfrank96/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfrank96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfrank96/subscriptions","organizations_url":"https://api.github.com/users/davidfrank96/orgs","repos_url":"https://api.github.com/users/davidfrank96/repos","events_url":"https://api.github.com/users/davidfrank96/events{/privacy}","received_events_url":"https://api.github.com/users/davidfrank96/received_events","type":"User","site_admin":false},{"login":"okafor-chidimma","id":50335408,"node_id":"MDQ6VXNlcjUwMzM1NDA4","avatar_url":"https://avatars0.githubusercontent.com/u/50335408?v=4","gravatar_id":"","url":"https://api.github.com/users/okafor-chidimma","html_url":"https://github.com/okafor-chidimma","followers_url":"https://api.github.com/users/okafor-chidimma/followers","following_url":"https://api.github.com/users/okafor-chidimma/following{/other_user}","gists_url":"https://api.github.com/users/okafor-chidimma/gists{/gist_id}","starred_url":"https://api.github.com/users/okafor-chidimma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okafor-chidimma/subscriptions","organizations_url":"https://api.github.com/users/okafor-chidimma/orgs","repos_url":"https://api.github.com/users/okafor-chidimma/repos","events_url":"https://api.github.com/users/okafor-chidimma/events{/privacy}","received_events_url":"https://api.github.com/users/okafor-chidimma/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/shadowcat-backend/pulls/15/commits","review_comments_url":"https://api.github.com/repos/andela/shadowcat-backend/pulls/15/comments","review_comment_url":"https://api.github.com/repos/andela/shadowcat-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/shadowcat-backend/issues/15/comments","statuses_url":"https://api.github.com/repos/andela/shadowcat-backend/statuses/331a01b473871e49d1708fe8c50a97126e874b58","head":{"label":"andela:ch-sequelize-167729772","ref":"ch-sequelize-167729772","sha":"331a01b473871e49d1708fe8c50a97126e874b58","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":200845766,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA4NDU3NjY=","name":"shadowcat-backend","full_name":"andela/shadowcat-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/shadowcat-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/shadowcat-backend","forks_url":"https://api.github.com/repos/andela/shadowcat-backend/forks","keys_url":"https://api.github.com/repos/andela/shadowcat-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/shadowcat-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/shadowcat-backend/teams","hooks_url":"https://api.github.com/repos/andela/shadowcat-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/shadowcat-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/shadowcat-backend/events","assignees_url":"https://api.github.com/repos/andela/shadowcat-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/shadowcat-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/shadowcat-backend/tags","blobs_url":"https://api.github.com/repos/andela/shadowcat-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/shadowcat-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/shadowcat-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/shadowcat-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/shadowcat-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/shadowcat-backend/languages","stargazers_url":"https://api.github.com/repos/andela/shadowcat-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/shadowcat-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/shadowcat-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/shadowcat-backend/subscription","commits_url":"https://api.github.com/repos/andela/shadowcat-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/shadowcat-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/shadowcat-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/shadowcat-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/shadowcat-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/shadowcat-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/shadowcat-backend/merges","archive_url":"https://api.github.com/repos/andela/shadowcat-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/shadowcat-backend/downloads","issues_url":"https://api.github.com/repos/andela/shadowcat-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/shadowcat-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/shadowcat-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/shadowcat-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/shadowcat-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/shadowcat-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/shadowcat-backend/deployments","created_at":"2019-08-06T12:20:45Z","updated_at":"2019-08-16T17:38:08Z","pushed_at":"2019-08-18T17:39:22Z","git_url":"git://github.com/andela/shadowcat-backend.git","ssh_url":"git@github.com:andela/shadowcat-backend.git","clone_url":"https://github.com/andela/shadowcat-backend.git","svn_url":"https://github.com/andela/shadowcat-backend","homepage":null,"size":210,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"staging"}},"base":{"label":"andela:staging","ref":"staging","sha":"9ec256d8c75290a445e3ca3a4117de1cf289e49e","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":200845766,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA4NDU3NjY=","name":"shadowcat-backend","full_name":"andela/shadowcat-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/shadowcat-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/shadowcat-backend","forks_url":"https://api.github.com/repos/andela/shadowcat-backend/forks","keys_url":"https://api.github.com/repos/andela/shadowcat-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/shadowcat-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/shadowcat-backend/teams","hooks_url":"https://api.github.com/repos/andela/shadowcat-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/shadowcat-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/shadowcat-backend/events","assignees_url":"https://api.github.com/repos/andela/shadowcat-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/shadowcat-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/shadowcat-backend/tags","blobs_url":"https://api.github.com/repos/andela/shadowcat-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/shadowcat-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/shadowcat-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/shadowcat-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/shadowcat-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/shadowcat-backend/languages","stargazers_url":"https://api.github.com/repos/andela/shadowcat-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/shadowcat-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/shadowcat-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/shadowcat-backend/subscription","commits_url":"https://api.github.com/repos/andela/shadowcat-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/shadowcat-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/shadowcat-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/shadowcat-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/shadowcat-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/shadowcat-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/shadowcat-backend/merges","archive_url":"https://api.github.com/repos/andela/shadowcat-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/shadowcat-backend/downloads","issues_url":"https://api.github.com/repos/andela/shadowcat-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/shadowcat-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/shadowcat-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/shadowcat-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/shadowcat-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/shadowcat-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/shadowcat-backend/deployments","created_at":"2019-08-06T12:20:45Z","updated_at":"2019-08-16T17:38:08Z","pushed_at":"2019-08-18T17:39:22Z","git_url":"git://github.com/andela/shadowcat-backend.git","ssh_url":"git@github.com:andela/shadowcat-backend.git","clone_url":"https://github.com/andela/shadowcat-backend.git","svn_url":"https://github.com/andela/shadowcat-backend","homepage":null,"size":210,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/shadowcat-backend/pulls/15"},"html":{"href":"https://github.com/andela/shadowcat-backend/pull/15"},"issue":{"href":"https://api.github.com/repos/andela/shadowcat-backend/issues/15"},"comments":{"href":"https://api.github.com/repos/andela/shadowcat-backend/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/shadowcat-backend/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/shadowcat-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/shadowcat-backend/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/andela/shadowcat-backend/statuses/331a01b473871e49d1708fe8c50a97126e874b58"}},"author_association":"COLLABORATOR"}}
|
{
"id": 200845766,
"name": "andela/shadowcat-backend",
"url": "https://api.github.com/repos/andela/shadowcat-backend"
}
|
{
"id": 30008653,
"login": "hound[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30008653?",
"url": "https://api.github.com/users/hound[bot]"
}
|
{
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
}
| 2019-08-18T17:39:28 |
10232458120
|
{"actor":{"display_login":"hound"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/comments/256966947","pull_request_review_id":203913906,"id":256966947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1Njk2Njk0Nw==","diff_hunk":"@@ -0,0 +1,99 @@\n+import React, { Component } from 'react';\n+import '../../../app.scss';\n+import PropTypes from 'prop-types';\n+import {sendEmail} from '../../../actions/resetPasswordAction';\n+import {connect} from 'react-redux';\n+\n+\n+class Resetemail extends Component {\n+ \n+ state ={\n+ email:'',\n+ reply:null\n+ }\n+ handleChange = (e)=>{\n+ this.setState({\n+ email: e.target.value\n+ })\n+ }\n+ handleSubmit = (e)=>{\n+ e.preventDefault();\n+ this.setState({\n+ reply:null,\n+ }) \n+ const user_email= this.state.email","path":"src/components/login/passwordreset/Resetpasswordemail.js","position":24,"original_position":24,"commit_id":"1998286b0275df2af1b38d7c35a0d18b5a8a2843","original_commit_id":"1998286b0275df2af1b38d7c35a0d18b5a8a2843","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Missing semicolon semi","created_at":"2019-02-14T18:57:54Z","updated_at":"2019-02-14T18:57:56Z","html_url":"https://github.com/andela/ah-the-unsullied-frontend/pull/13#discussion_r256966947","pull_request_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/13","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/comments/256966947"},"html":{"href":"https://github.com/andela/ah-the-unsullied-frontend/pull/13#discussion_r256966947"},"pull_request":{"href":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/13","id":253065343,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzMDY1MzQz","html_url":"https://github.com/andela/ah-the-unsullied-frontend/pull/13","diff_url":"https://github.com/andela/ah-the-unsullied-frontend/pull/13.diff","patch_url":"https://github.com/andela/ah-the-unsullied-frontend/pull/13.patch","issue_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues/13","number":13,"state":"open","locked":false,"title":"#162949171 Users should be able to presented with a reset password link","user":{"login":"kelvinwm","id":23077054,"node_id":"MDQ6VXNlcjIzMDc3MDU0","avatar_url":"https://avatars1.githubusercontent.com/u/23077054?v=4","gravatar_id":"","url":"https://api.github.com/users/kelvinwm","html_url":"https://github.com/kelvinwm","followers_url":"https://api.github.com/users/kelvinwm/followers","following_url":"https://api.github.com/users/kelvinwm/following{/other_user}","gists_url":"https://api.github.com/users/kelvinwm/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvinwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvinwm/subscriptions","organizations_url":"https://api.github.com/users/kelvinwm/orgs","repos_url":"https://api.github.com/users/kelvinwm/repos","events_url":"https://api.github.com/users/kelvinwm/events{/privacy}","received_events_url":"https://api.github.com/users/kelvinwm/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\nCreates a reset password link\r\n\r\n#### Description of Task to be completed?\r\n* User can reset their password via an email link\r\n\r\n#### How should this be manually tested?\r\n\r\n1. Clone the repository\r\n```\r\ngit clone https://github.com/andela/ah-the-unsullied-frontend.git\r\n```\r\n2. Cd into the cloned repo\r\n```\r\ncd ah-the-unsullied-frontend\r\n```\r\n3. Checkout to this branch\r\n```\r\ngit checkout ft-reset-password-162949171\r\n```\r\n4. Install the dependencies of the project\r\n```\r\nnpm install\r\n```\r\n5. Run the app\r\n```\r\nnpm start\r\n```\r\n6. Visit the default route `http://localhost:3000/password-reset` and click the login button\r\n\r\n7. To run tests, run `npm test`\r\n\r\n#### Any background context you want to provide?\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n[#162949171](https://www.pivotaltracker.com/story/show/162949171)\r\n\r\n#### Screenshots (if appropriate)\r\n\r\n\r\n","created_at":"2019-02-14T13:08:11Z","updated_at":"2019-02-14T18:57:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e295beec6e429afde5e3d34a946a98e8c301530","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/13/commits","review_comments_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/13/comments","review_comment_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues/13/comments","statuses_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/statuses/1998286b0275df2af1b38d7c35a0d18b5a8a2843","head":{"label":"andela:ft-reset-password-162949171","ref":"ft-reset-password-162949171","sha":"1998286b0275df2af1b38d7c35a0d18b5a8a2843","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":169082161,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwODIxNjE=","name":"ah-the-unsullied-frontend","full_name":"andela/ah-the-unsullied-frontend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-the-unsullied-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend","forks_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/forks","keys_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/teams","hooks_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/events","assignees_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/tags","blobs_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/languages","stargazers_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/subscription","commits_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/merges","archive_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/downloads","issues_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/deployments","created_at":"2019-02-04T13:25:36Z","updated_at":"2019-02-08T10:37:45Z","pushed_at":"2019-02-14T18:56:10Z","git_url":"git://github.com/andela/ah-the-unsullied-frontend.git","ssh_url":"git@github.com:andela/ah-the-unsullied-frontend.git","clone_url":"https://github.com/andela/ah-the-unsullied-frontend.git","svn_url":"https://github.com/andela/ah-the-unsullied-frontend","homepage":null,"size":667,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"fb811e5a1556ab22d0ac0cd00c4e2ce07e141b16","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":169082161,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwODIxNjE=","name":"ah-the-unsullied-frontend","full_name":"andela/ah-the-unsullied-frontend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-the-unsullied-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend","forks_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/forks","keys_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/teams","hooks_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/events","assignees_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/tags","blobs_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/languages","stargazers_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/subscription","commits_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/merges","archive_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/downloads","issues_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/deployments","created_at":"2019-02-04T13:25:36Z","updated_at":"2019-02-08T10:37:45Z","pushed_at":"2019-02-14T18:56:10Z","git_url":"git://github.com/andela/ah-the-unsullied-frontend.git","ssh_url":"git@github.com:andela/ah-the-unsullied-frontend.git","clone_url":"https://github.com/andela/ah-the-unsullied-frontend.git","svn_url":"https://github.com/andela/ah-the-unsullied-frontend","homepage":null,"size":667,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/13"},"html":{"href":"https://github.com/andela/ah-the-unsullied-frontend/pull/13"},"issue":{"href":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues/13"},"comments":{"href":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/andela/ah-the-unsullied-frontend/statuses/1998286b0275df2af1b38d7c35a0d18b5a8a2843"}},"author_association":"COLLABORATOR"}}
|
{
"id": 169082161,
"name": "andela/ah-the-unsullied-frontend",
"url": "https://api.github.com/repos/andela/ah-the-unsullied-frontend"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
}
| 2019-02-14T18:57:54 |
9070224039
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/comments/267882779","pull_request_review_id":217397821,"id":267882779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Nzg4Mjc3OQ==","diff_hunk":"@@ -0,0 +1,116 @@\n+import articleReducer from '../article';\n+\n+import * as actionTypes from '../../actions/actionTypes';\n+\n+describe('Article reducer', () => {\n+ it('should return initial state if no action', () => {\n+ expect(articleReducer(undefined, {})).toEqual({\n+ article: null,\n+ error: null,\n+ loading: false,\n+ message: \"\"\n+ });\n+ });\n+\n+ it('should return updated state of loading true is action in started', () => {\n+ expect(articleReducer(undefined, { type: actionTypes.GET_ARTICLE_START })).toEqual({\n+ article: null,\n+ error: null,\n+ loading: true,\n+ message: \"\"\n+ });\n+ });\n+\n+ it('reducer should update error in state if action is fail', () => {\n+ expect(articleReducer(undefined, {\n+ type: actionTypes.GET_ARTICLE_FAIL,\n+ error: \"article loading\"\n+ })).toEqual({\n+ article: null,\n+ error: \"article loading\",\n+ loading: false,\n+ message: \"\"\n+ });\n+ });\n+\n+ it('should update article value in state if action is success', () => {\n+ expect(articleReducer(undefined, {\n+ type: actionTypes.GET_ARTICLE_SUCCESS,\n+ data: { articles: \"successfull\" }\n+ })).toEqual({\n+ article: \"successfull\",\n+ error: null,\n+ loading: false,\n+ message: \"\"\n+ });\n+ });\n+\n+ it('should update article value in state if action for update article is successful', () => {\n+ expect(articleReducer(undefined, {\n+ type: actionTypes.UPDATE_ARTICLE_SUCCESS,\n+ data: { articles: \"updated successfully\" }\n+ })).toEqual({\n+ article: \"updated successfully\",\n+ error: null,\n+ loading: false,\n+ message: \"Changes saved succefully\"\n+ });\n+ });\n+\n+ it('reducer should update error in state if action for updating article is fails', () => {\n+ expect(articleReducer(undefined, {\n+ type: actionTypes.UPDATE_ARTICLE_FAIL,\n+ error: \"failed updating\"\n+ })).toEqual({\n+ article: null,\n+ error: \"failed updating\",\n+ loading: false,\n+ message: \"\"\n+ });\n+ });\n+\n+ it('should update article value in state if action for creating article is successful', () => {\n+ expect(articleReducer(undefined, {\n+ type: actionTypes.CREATE_ARTICLE_SUCCESS,\n+ data: { articles: \"Article created\" }\n+ })).toEqual({\n+ article: \"Article created\",\n+ error: null,\n+ loading: false,\n+ message: \"Article created successfully\"\n+ });\n+ });\n+\n+ it('reducer should update error in state if action for creating article is fails', () => {\n+ expect(articleReducer(undefined, {\n+ type: actionTypes.CREATE_ARTICLE_FAIL,\n+ error: \"failed creating an article\"\n+ })).toEqual({\n+ article: null,\n+ error: \"failed creating an article\",\n+ loading: false,\n+ message: \"\"\n+ });\n+ });\n+\n+ it('should update article value if delete action is dispatched', () => {\n+ expect(articleReducer(undefined, {\n+ type: actionTypes.DELETE_ARTICLE,\n+ data: {articles: \"deleted\"} })).toEqual({\n+ article: \"deleted\",\n+ error: null,\n+ loading: false,\n+ message: \"\"\n+ });\n+ });\n+\n+ it('should return initial state if is action ended', () => {\n+ expect(articleReducer(undefined, {type: actionTypes.ACTION_ENDED})).toEqual({\n+ article: null,","path":"src/store/reducers/__tests__/article.test.js","position":109,"original_position":109,"commit_id":"0ad1cdb4c8f63513ee4a02d8778581d8c4de0313","original_commit_id":"0ad1cdb4c8f63513ee4a02d8778581d8c4de0313","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Expected indentation of 6 spaces but found 12 indent","created_at":"2019-03-21T17:47:37Z","updated_at":"2019-03-21T17:47:38Z","html_url":"https://github.com/andela/ah-frontend-summer/pull/25#discussion_r267882779","pull_request_url":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/25","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/comments/267882779"},"html":{"href":"https://github.com/andela/ah-frontend-summer/pull/25#discussion_r267882779"},"pull_request":{"href":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/25","id":262864937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyODY0OTM3","html_url":"https://github.com/andela/ah-frontend-summer/pull/25","diff_url":"https://github.com/andela/ah-frontend-summer/pull/25.diff","patch_url":"https://github.com/andela/ah-frontend-summer/pull/25.patch","issue_url":"https://api.github.com/repos/andela/ah-frontend-summer/issues/25","number":25,"state":"open","locked":false,"title":"163383137 Implement CRUD Article","user":{"login":"FahdJamy","id":27225249,"node_id":"MDQ6VXNlcjI3MjI1MjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/27225249?v=4","gravatar_id":"","url":"https://api.github.com/users/FahdJamy","html_url":"https://github.com/FahdJamy","followers_url":"https://api.github.com/users/FahdJamy/followers","following_url":"https://api.github.com/users/FahdJamy/following{/other_user}","gists_url":"https://api.github.com/users/FahdJamy/gists{/gist_id}","starred_url":"https://api.github.com/users/FahdJamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FahdJamy/subscriptions","organizations_url":"https://api.github.com/users/FahdJamy/orgs","repos_url":"https://api.github.com/users/FahdJamy/repos","events_url":"https://api.github.com/users/FahdJamy/events{/privacy}","received_events_url":"https://api.github.com/users/FahdJamy/received_events","type":"User","site_admin":false},"body":"#### Description\r\n---\r\n1. Users once they have logged in, they can create articles.\r\n##### Screenshot\r\n\r\n2. Authors of the article can update and delete their articles if they are logged in.\r\n##### Screenshots\r\n\r\n\r\n\r\n#### Type of change\r\n---\r\n- New Feature\r\n#### How Has This Been Tested?\r\n---\r\n- Unit tests\r\n#### Relevant Pivotal Tracker stories\r\n---\r\n[163383137](https://www.pivotaltracker.com/story/show/163383137)","created_at":"2019-03-20T13:30:40Z","updated_at":"2019-03-21T17:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3da42e94d8868b29391b432631d7c32586265245","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Karuhanga","id":12200860,"node_id":"MDQ6VXNlcjEyMjAwODYw","avatar_url":"https://avatars1.githubusercontent.com/u/12200860?v=4","gravatar_id":"","url":"https://api.github.com/users/Karuhanga","html_url":"https://github.com/Karuhanga","followers_url":"https://api.github.com/users/Karuhanga/followers","following_url":"https://api.github.com/users/Karuhanga/following{/other_user}","gists_url":"https://api.github.com/users/Karuhanga/gists{/gist_id}","starred_url":"https://api.github.com/users/Karuhanga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karuhanga/subscriptions","organizations_url":"https://api.github.com/users/Karuhanga/orgs","repos_url":"https://api.github.com/users/Karuhanga/repos","events_url":"https://api.github.com/users/Karuhanga/events{/privacy}","received_events_url":"https://api.github.com/users/Karuhanga/received_events","type":"User","site_admin":false},{"login":"oma0256","id":14260655,"node_id":"MDQ6VXNlcjE0MjYwNjU1","avatar_url":"https://avatars3.githubusercontent.com/u/14260655?v=4","gravatar_id":"","url":"https://api.github.com/users/oma0256","html_url":"https://github.com/oma0256","followers_url":"https://api.github.com/users/oma0256/followers","following_url":"https://api.github.com/users/oma0256/following{/other_user}","gists_url":"https://api.github.com/users/oma0256/gists{/gist_id}","starred_url":"https://api.github.com/users/oma0256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oma0256/subscriptions","organizations_url":"https://api.github.com/users/oma0256/orgs","repos_url":"https://api.github.com/users/oma0256/repos","events_url":"https://api.github.com/users/oma0256/events{/privacy}","received_events_url":"https://api.github.com/users/oma0256/received_events","type":"User","site_admin":false},{"login":"collinewait","id":21334508,"node_id":"MDQ6VXNlcjIxMzM0NTA4","avatar_url":"https://avatars1.githubusercontent.com/u/21334508?v=4","gravatar_id":"","url":"https://api.github.com/users/collinewait","html_url":"https://github.com/collinewait","followers_url":"https://api.github.com/users/collinewait/followers","following_url":"https://api.github.com/users/collinewait/following{/other_user}","gists_url":"https://api.github.com/users/collinewait/gists{/gist_id}","starred_url":"https://api.github.com/users/collinewait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collinewait/subscriptions","organizations_url":"https://api.github.com/users/collinewait/orgs","repos_url":"https://api.github.com/users/collinewait/repos","events_url":"https://api.github.com/users/collinewait/events{/privacy}","received_events_url":"https://api.github.com/users/collinewait/received_events","type":"User","site_admin":false},{"login":"missvicki","id":31304859,"node_id":"MDQ6VXNlcjMxMzA0ODU5","avatar_url":"https://avatars0.githubusercontent.com/u/31304859?v=4","gravatar_id":"","url":"https://api.github.com/users/missvicki","html_url":"https://github.com/missvicki","followers_url":"https://api.github.com/users/missvicki/followers","following_url":"https://api.github.com/users/missvicki/following{/other_user}","gists_url":"https://api.github.com/users/missvicki/gists{/gist_id}","starred_url":"https://api.github.com/users/missvicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/missvicki/subscriptions","organizations_url":"https://api.github.com/users/missvicki/orgs","repos_url":"https://api.github.com/users/missvicki/repos","events_url":"https://api.github.com/users/missvicki/events{/privacy}","received_events_url":"https://api.github.com/users/missvicki/received_events","type":"User","site_admin":false},{"login":"pbkabali","id":38935418,"node_id":"MDQ6VXNlcjM4OTM1NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/38935418?v=4","gravatar_id":"","url":"https://api.github.com/users/pbkabali","html_url":"https://github.com/pbkabali","followers_url":"https://api.github.com/users/pbkabali/followers","following_url":"https://api.github.com/users/pbkabali/following{/other_user}","gists_url":"https://api.github.com/users/pbkabali/gists{/gist_id}","starred_url":"https://api.github.com/users/pbkabali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbkabali/subscriptions","organizations_url":"https://api.github.com/users/pbkabali/orgs","repos_url":"https://api.github.com/users/pbkabali/repos","events_url":"https://api.github.com/users/pbkabali/events{/privacy}","received_events_url":"https://api.github.com/users/pbkabali/received_events","type":"User","site_admin":false},{"login":"codjoero","id":39584366,"node_id":"MDQ6VXNlcjM5NTg0MzY2","avatar_url":"https://avatars3.githubusercontent.com/u/39584366?v=4","gravatar_id":"","url":"https://api.github.com/users/codjoero","html_url":"https://github.com/codjoero","followers_url":"https://api.github.com/users/codjoero/followers","following_url":"https://api.github.com/users/codjoero/following{/other_user}","gists_url":"https://api.github.com/users/codjoero/gists{/gist_id}","starred_url":"https://api.github.com/users/codjoero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codjoero/subscriptions","organizations_url":"https://api.github.com/users/codjoero/orgs","repos_url":"https://api.github.com/users/codjoero/repos","events_url":"https://api.github.com/users/codjoero/events{/privacy}","received_events_url":"https://api.github.com/users/codjoero/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/25/commits","review_comments_url":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/25/comments","review_comment_url":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/ah-frontend-summer/issues/25/comments","statuses_url":"https://api.github.com/repos/andela/ah-frontend-summer/statuses/0ad1cdb4c8f63513ee4a02d8778581d8c4de0313","head":{"label":"andela:ft-create-read-delete-article-163383137","ref":"ft-create-read-delete-article-163383137","sha":"0ad1cdb4c8f63513ee4a02d8778581d8c4de0313","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":172698370,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI2OTgzNzA=","name":"ah-frontend-summer","full_name":"andela/ah-frontend-summer","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-frontend-summer","description":"Frontend Repository for Team Summer","fork":false,"url":"https://api.github.com/repos/andela/ah-frontend-summer","forks_url":"https://api.github.com/repos/andela/ah-frontend-summer/forks","keys_url":"https://api.github.com/repos/andela/ah-frontend-summer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-frontend-summer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-frontend-summer/teams","hooks_url":"https://api.github.com/repos/andela/ah-frontend-summer/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-frontend-summer/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-frontend-summer/events","assignees_url":"https://api.github.com/repos/andela/ah-frontend-summer/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-frontend-summer/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-frontend-summer/tags","blobs_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-frontend-summer/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-frontend-summer/languages","stargazers_url":"https://api.github.com/repos/andela/ah-frontend-summer/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-frontend-summer/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-frontend-summer/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-frontend-summer/subscription","commits_url":"https://api.github.com/repos/andela/ah-frontend-summer/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-frontend-summer/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-frontend-summer/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-frontend-summer/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-frontend-summer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-frontend-summer/merges","archive_url":"https://api.github.com/repos/andela/ah-frontend-summer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-frontend-summer/downloads","issues_url":"https://api.github.com/repos/andela/ah-frontend-summer/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-frontend-summer/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-frontend-summer/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-frontend-summer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-frontend-summer/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-frontend-summer/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-frontend-summer/deployments","created_at":"2019-02-26T11:27:11Z","updated_at":"2019-03-18T09:27:13Z","pushed_at":"2019-03-21T17:47:10Z","git_url":"git://github.com/andela/ah-frontend-summer.git","ssh_url":"git@github.com:andela/ah-frontend-summer.git","clone_url":"https://github.com/andela/ah-frontend-summer.git","svn_url":"https://github.com/andela/ah-frontend-summer","homepage":null,"size":9546,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"91c13141a27612ffb26b701964b6c5abbf7c0e23","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":172698370,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI2OTgzNzA=","name":"ah-frontend-summer","full_name":"andela/ah-frontend-summer","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-frontend-summer","description":"Frontend Repository for Team Summer","fork":false,"url":"https://api.github.com/repos/andela/ah-frontend-summer","forks_url":"https://api.github.com/repos/andela/ah-frontend-summer/forks","keys_url":"https://api.github.com/repos/andela/ah-frontend-summer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-frontend-summer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-frontend-summer/teams","hooks_url":"https://api.github.com/repos/andela/ah-frontend-summer/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-frontend-summer/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-frontend-summer/events","assignees_url":"https://api.github.com/repos/andela/ah-frontend-summer/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-frontend-summer/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-frontend-summer/tags","blobs_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-frontend-summer/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-frontend-summer/languages","stargazers_url":"https://api.github.com/repos/andela/ah-frontend-summer/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-frontend-summer/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-frontend-summer/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-frontend-summer/subscription","commits_url":"https://api.github.com/repos/andela/ah-frontend-summer/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-frontend-summer/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-frontend-summer/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-frontend-summer/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-frontend-summer/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-frontend-summer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-frontend-summer/merges","archive_url":"https://api.github.com/repos/andela/ah-frontend-summer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-frontend-summer/downloads","issues_url":"https://api.github.com/repos/andela/ah-frontend-summer/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-frontend-summer/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-frontend-summer/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-frontend-summer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-frontend-summer/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-frontend-summer/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-frontend-summer/deployments","created_at":"2019-02-26T11:27:11Z","updated_at":"2019-03-18T09:27:13Z","pushed_at":"2019-03-21T17:47:10Z","git_url":"git://github.com/andela/ah-frontend-summer.git","ssh_url":"git@github.com:andela/ah-frontend-summer.git","clone_url":"https://github.com/andela/ah-frontend-summer.git","svn_url":"https://github.com/andela/ah-frontend-summer","homepage":null,"size":9546,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/25"},"html":{"href":"https://github.com/andela/ah-frontend-summer/pull/25"},"issue":{"href":"https://api.github.com/repos/andela/ah-frontend-summer/issues/25"},"comments":{"href":"https://api.github.com/repos/andela/ah-frontend-summer/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/ah-frontend-summer/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/andela/ah-frontend-summer/statuses/0ad1cdb4c8f63513ee4a02d8778581d8c4de0313"}},"author_association":"COLLABORATOR"}}
|
{
"id": 172698370,
"name": "andela/ah-frontend-summer",
"url": "https://api.github.com/repos/andela/ah-frontend-summer"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
}
| 2019-03-21T17:47:37 |
9289706715
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/comments/292000845","pull_request_review_id":247601194,"id":292000845,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MjAwMDg0NQ==","diff_hunk":"@@ -0,0 +1,137 @@\n+$main-color: #094469;\n+$button-hover-color: #0c5e91;\n+$input-error: rgb(216, 75, 75);\n+$succes-background-color: rgba(12, 182, 125, 0.678);\n+\n+.card {\n+ padding: 60px 50px 30px 50px;\n+ margin-top: 10px;\n+ margin-right: 15px;\n+ margin-bottom: 20px !important;\n+ margin-left: 15px;\n+ background-color: rgb(255, 255, 255);\n+ box-shadow: 0 8px 16px -8px rgba(0, 0, 0, 0.4);\n+ border-radius: 6px;\n+}\n+\n+.input-field {\n+ margin-bottom: 10px;\n+}\n+\n+.input-field::placeholder {\n+ font-size: .9em;\n+}\n+\n+.input-field:focus {\n+ box-shadow: none !important;\n+}\n+\n+.signup-btn {\n+ width: 100%;\n+ margin-bottom: 10px;\n+ background-color: $main-color !important;\n+ border: 1px solid $main-color !important;\n+}\n+\n+.signup-btn:hover {\n+ background-color: $button-hover-color !important;\n+ border-color: $button-hover-color !important;\n+}\n+\n+.banner {\n+ margin-top: 50px;\n+}\n+\n+.signupwith {\n+ margin-bottom: 30px;\n+}\n+\n+.banner-img {\n+ width: 100%;\n+ height: auto;\n+}\n+\n+.signupwith-img {\n+ width: 100%;\n+ height: auto;\n+}\n+\n+.socialmedia-img {\n+ width: 70%;\n+ height: auto;\n+}\n+\n+.have-account {\n+ text-align: left;\n+}\n+\n+.success {\n+ background-color: $succes-background-color;\n+ border-radius: .4em;\n+ padding-top: 15px;\n+ padding-right: 10px;\n+ padding-bottom: 5px;\n+ padding-left: 15px;\n+ margin-left: 5px;\n+ margin-right: 5px;\n+\n+ p {\n+ color: rgb(6, 53, 38);\n+ font-size: auto;\n+ }\n+}\n+\n+p {\n+ text-align: left;\n+\n+ .input-error {\n+ color: $input-error;\n+ font-size: 80%;\n+ margin-top: 1px;\n+ }\n+}\n+\n+@media screen and (min-width: 768px) {\n+ .card {\n+ margin-top: 10px;\n+ }\n+}\n+\n+@media screen and (max-width: 765px) {\n+ .card {\n+ margin: 10px 40px 0px 40px;\n+ }\n+\n+ .socialmedia-img {\n+ height: auto;\n+ margin-right: 15px !important;\n+ width: 40px !important;\n+ }\n+\n+ .social-media-row {\n+ margin-left: 10% !important;\n+ }\n+}\n+\n+@media screen and (max-width: 440px) {\n+ .twitter-img {\n+ margin-right: 20px !important;\n+ margin-left: 10px !important;\n+ }\n+}\n+\n+@media screen and (max-width: 440px) {\n+ .socialmedia-img {\n+ width: 30px !important;\n+ height: auto;\n+ margin: 5px;\n+ }\n+}\n+\n+@media screen and (max-width: 440px) {\n+ .socialmedia-img {\n+ width: 30px;","path":"src/assets/styles/signup.scss","position":133,"original_position":133,"commit_id":"3b7e9b6be01a84962b291f587e36a9c3894e6c03","original_commit_id":"3b7e9b6be01a84962b291f587e36a9c3894e6c03","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Properties should be ordered height, margin, width","created_at":"2019-06-10T13:02:38Z","updated_at":"2019-06-10T13:02:41Z","html_url":"https://github.com/andela/ah-frontend-invictus/pull/15#discussion_r292000845","pull_request_url":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/15","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/comments/292000845"},"html":{"href":"https://github.com/andela/ah-frontend-invictus/pull/15#discussion_r292000845"},"pull_request":{"href":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/15","id":285712926,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1NzEyOTI2","html_url":"https://github.com/andela/ah-frontend-invictus/pull/15","diff_url":"https://github.com/andela/ah-frontend-invictus/pull/15.diff","patch_url":"https://github.com/andela/ah-frontend-invictus/pull/15.patch","issue_url":"https://api.github.com/repos/andela/ah-frontend-invictus/issues/15","number":15,"state":"open","locked":false,"title":"#165273431 Add signup feature","user":{"login":"sanya-kenneth","id":11665036,"node_id":"MDQ6VXNlcjExNjY1MDM2","avatar_url":"https://avatars0.githubusercontent.com/u/11665036?v=4","gravatar_id":"","url":"https://api.github.com/users/sanya-kenneth","html_url":"https://github.com/sanya-kenneth","followers_url":"https://api.github.com/users/sanya-kenneth/followers","following_url":"https://api.github.com/users/sanya-kenneth/following{/other_user}","gists_url":"https://api.github.com/users/sanya-kenneth/gists{/gist_id}","starred_url":"https://api.github.com/users/sanya-kenneth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanya-kenneth/subscriptions","organizations_url":"https://api.github.com/users/sanya-kenneth/orgs","repos_url":"https://api.github.com/users/sanya-kenneth/repos","events_url":"https://api.github.com/users/sanya-kenneth/events{/privacy}","received_events_url":"https://api.github.com/users/sanya-kenneth/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n Adds signup/register functionality to the app\r\n\r\n\r\n#### Description of Task to be completed\r\n- Add signup page for the app\r\n- Add link to login page\r\n- Add social signup buttons\r\n- Add nav bar the app\r\n\r\n#### How should this be manually tested?\r\n- clone the project repo `git clone https://github.com/andela/ah-frontend-invictus`\r\n- checkout into the signup branch `git checkout ft-user-signup-165273431`\r\n- run `npm install`\r\n- run `npm start`\r\n\r\n\r\n#### Any background context you want to provide?\r\nNone\r\n\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n[#165273431](https://www.pivotaltracker.com/story/show/165273431)\r\n\r\n\r\n#### Screenshots (if appropriate)\r\n<img width=\"1440\" alt=\"Screenshot 2019-06-06 at 12 14 09\" src=\"https://user-images.githubusercontent.com/11665036/59021562-b235a000-8854-11e9-94b7-6cf02a742040.png\">\r\n\r\n\r\n","created_at":"2019-06-06T09:16:09Z","updated_at":"2019-06-10T13:02:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86d95a1f884634f486dba34a3d02eb253574003f","assignee":{"login":"3Nakajugo","id":42472856,"node_id":"MDQ6VXNlcjQyNDcyODU2","avatar_url":"https://avatars0.githubusercontent.com/u/42472856?v=4","gravatar_id":"","url":"https://api.github.com/users/3Nakajugo","html_url":"https://github.com/3Nakajugo","followers_url":"https://api.github.com/users/3Nakajugo/followers","following_url":"https://api.github.com/users/3Nakajugo/following{/other_user}","gists_url":"https://api.github.com/users/3Nakajugo/gists{/gist_id}","starred_url":"https://api.github.com/users/3Nakajugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3Nakajugo/subscriptions","organizations_url":"https://api.github.com/users/3Nakajugo/orgs","repos_url":"https://api.github.com/users/3Nakajugo/repos","events_url":"https://api.github.com/users/3Nakajugo/events{/privacy}","received_events_url":"https://api.github.com/users/3Nakajugo/received_events","type":"User","site_admin":false},"assignees":[{"login":"3Nakajugo","id":42472856,"node_id":"MDQ6VXNlcjQyNDcyODU2","avatar_url":"https://avatars0.githubusercontent.com/u/42472856?v=4","gravatar_id":"","url":"https://api.github.com/users/3Nakajugo","html_url":"https://github.com/3Nakajugo","followers_url":"https://api.github.com/users/3Nakajugo/followers","following_url":"https://api.github.com/users/3Nakajugo/following{/other_user}","gists_url":"https://api.github.com/users/3Nakajugo/gists{/gist_id}","starred_url":"https://api.github.com/users/3Nakajugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3Nakajugo/subscriptions","organizations_url":"https://api.github.com/users/3Nakajugo/orgs","repos_url":"https://api.github.com/users/3Nakajugo/repos","events_url":"https://api.github.com/users/3Nakajugo/events{/privacy}","received_events_url":"https://api.github.com/users/3Nakajugo/received_events","type":"User","site_admin":false},{"login":"KabohaJeanMark","id":44635784,"node_id":"MDQ6VXNlcjQ0NjM1Nzg0","avatar_url":"https://avatars0.githubusercontent.com/u/44635784?v=4","gravatar_id":"","url":"https://api.github.com/users/KabohaJeanMark","html_url":"https://github.com/KabohaJeanMark","followers_url":"https://api.github.com/users/KabohaJeanMark/followers","following_url":"https://api.github.com/users/KabohaJeanMark/following{/other_user}","gists_url":"https://api.github.com/users/KabohaJeanMark/gists{/gist_id}","starred_url":"https://api.github.com/users/KabohaJeanMark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KabohaJeanMark/subscriptions","organizations_url":"https://api.github.com/users/KabohaJeanMark/orgs","repos_url":"https://api.github.com/users/KabohaJeanMark/repos","events_url":"https://api.github.com/users/KabohaJeanMark/events{/privacy}","received_events_url":"https://api.github.com/users/KabohaJeanMark/received_events","type":"User","site_admin":false},{"login":"joelmugaya","id":49488163,"node_id":"MDQ6VXNlcjQ5NDg4MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/49488163?v=4","gravatar_id":"","url":"https://api.github.com/users/joelmugaya","html_url":"https://github.com/joelmugaya","followers_url":"https://api.github.com/users/joelmugaya/followers","following_url":"https://api.github.com/users/joelmugaya/following{/other_user}","gists_url":"https://api.github.com/users/joelmugaya/gists{/gist_id}","starred_url":"https://api.github.com/users/joelmugaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelmugaya/subscriptions","organizations_url":"https://api.github.com/users/joelmugaya/orgs","repos_url":"https://api.github.com/users/joelmugaya/repos","events_url":"https://api.github.com/users/joelmugaya/events{/privacy}","received_events_url":"https://api.github.com/users/joelmugaya/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1375190368,"node_id":"MDU6TGFiZWwxMzc1MTkwMzY4","url":"https://api.github.com/repos/andela/ah-frontend-invictus/labels/ready%20for%20review","name":"ready for review","color":"7c7fd6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/15/commits","review_comments_url":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/15/comments","review_comment_url":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/ah-frontend-invictus/issues/15/comments","statuses_url":"https://api.github.com/repos/andela/ah-frontend-invictus/statuses/3b7e9b6be01a84962b291f587e36a9c3894e6c03","head":{"label":"andela:ft-user-signup-165273431","ref":"ft-user-signup-165273431","sha":"3b7e9b6be01a84962b291f587e36a9c3894e6c03","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":188375211,"node_id":"MDEwOlJlcG9zaXRvcnkxODgzNzUyMTE=","name":"ah-frontend-invictus","full_name":"andela/ah-frontend-invictus","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-frontend-invictus","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-frontend-invictus","forks_url":"https://api.github.com/repos/andela/ah-frontend-invictus/forks","keys_url":"https://api.github.com/repos/andela/ah-frontend-invictus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-frontend-invictus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-frontend-invictus/teams","hooks_url":"https://api.github.com/repos/andela/ah-frontend-invictus/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-frontend-invictus/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-frontend-invictus/events","assignees_url":"https://api.github.com/repos/andela/ah-frontend-invictus/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-frontend-invictus/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-frontend-invictus/tags","blobs_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-frontend-invictus/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-frontend-invictus/languages","stargazers_url":"https://api.github.com/repos/andela/ah-frontend-invictus/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-frontend-invictus/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-frontend-invictus/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-frontend-invictus/subscription","commits_url":"https://api.github.com/repos/andela/ah-frontend-invictus/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-frontend-invictus/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-frontend-invictus/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-frontend-invictus/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-frontend-invictus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-frontend-invictus/merges","archive_url":"https://api.github.com/repos/andela/ah-frontend-invictus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-frontend-invictus/downloads","issues_url":"https://api.github.com/repos/andela/ah-frontend-invictus/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-frontend-invictus/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-frontend-invictus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-frontend-invictus/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-frontend-invictus/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-frontend-invictus/deployments","created_at":"2019-05-24T07:34:08Z","updated_at":"2019-06-07T10:30:09Z","pushed_at":"2019-06-10T13:02:27Z","git_url":"git://github.com/andela/ah-frontend-invictus.git","ssh_url":"git@github.com:andela/ah-frontend-invictus.git","clone_url":"https://github.com/andela/ah-frontend-invictus.git","svn_url":"https://github.com/andela/ah-frontend-invictus","homepage":null,"size":527,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"cd6b16a4f9d5f6358d00586b79dd1acb6728d7f9","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":188375211,"node_id":"MDEwOlJlcG9zaXRvcnkxODgzNzUyMTE=","name":"ah-frontend-invictus","full_name":"andela/ah-frontend-invictus","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ah-frontend-invictus","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-frontend-invictus","forks_url":"https://api.github.com/repos/andela/ah-frontend-invictus/forks","keys_url":"https://api.github.com/repos/andela/ah-frontend-invictus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-frontend-invictus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-frontend-invictus/teams","hooks_url":"https://api.github.com/repos/andela/ah-frontend-invictus/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-frontend-invictus/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-frontend-invictus/events","assignees_url":"https://api.github.com/repos/andela/ah-frontend-invictus/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-frontend-invictus/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-frontend-invictus/tags","blobs_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-frontend-invictus/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-frontend-invictus/languages","stargazers_url":"https://api.github.com/repos/andela/ah-frontend-invictus/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-frontend-invictus/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-frontend-invictus/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-frontend-invictus/subscription","commits_url":"https://api.github.com/repos/andela/ah-frontend-invictus/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-frontend-invictus/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-frontend-invictus/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-frontend-invictus/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-frontend-invictus/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-frontend-invictus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-frontend-invictus/merges","archive_url":"https://api.github.com/repos/andela/ah-frontend-invictus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-frontend-invictus/downloads","issues_url":"https://api.github.com/repos/andela/ah-frontend-invictus/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-frontend-invictus/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-frontend-invictus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-frontend-invictus/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-frontend-invictus/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-frontend-invictus/deployments","created_at":"2019-05-24T07:34:08Z","updated_at":"2019-06-07T10:30:09Z","pushed_at":"2019-06-10T13:02:27Z","git_url":"git://github.com/andela/ah-frontend-invictus.git","ssh_url":"git@github.com:andela/ah-frontend-invictus.git","clone_url":"https://github.com/andela/ah-frontend-invictus.git","svn_url":"https://github.com/andela/ah-frontend-invictus","homepage":null,"size":527,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/15"},"html":{"href":"https://github.com/andela/ah-frontend-invictus/pull/15"},"issue":{"href":"https://api.github.com/repos/andela/ah-frontend-invictus/issues/15"},"comments":{"href":"https://api.github.com/repos/andela/ah-frontend-invictus/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/ah-frontend-invictus/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/andela/ah-frontend-invictus/statuses/3b7e9b6be01a84962b291f587e36a9c3894e6c03"}},"author_association":"COLLABORATOR"}}
|
{
"id": 188375211,
"name": "andela/ah-frontend-invictus",
"url": "https://api.github.com/repos/andela/ah-frontend-invictus"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
}
| 2019-06-10T13:02:38 |
9790548228
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/comments/276227949","pull_request_review_id":227737072,"id":276227949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NjIyNzk0OQ==","diff_hunk":"@@ -15,7 +15,9 @@ const password = joi.string().trim().regex(/^[\\w\\W]{8,32}$/)\n const resetToken = joi.string().trim().regex(/^[\\w\\W]+\\.[\\w\\W]+\\.[\\w\\W]+$/)\n .error(() => 'The password reset link has expired, kindly request for a new reset link')\n .required();\n-\n+ \n+const highlightedText = joi.string().error(() => 'invalid highlighted text');\n+const textPosition = joi.number().integer().error(() => 'position must be an integer'); ","path":"src/middlewares/validator/validator.js","position":7,"original_position":7,"commit_id":"88f3be3974419eb942c4b259619d634720cda605","original_commit_id":"88f3be3974419eb942c4b259619d634720cda605","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing spaces not allowed no-trailing-spaces","created_at":"2019-04-17T13:01:27Z","updated_at":"2019-04-17T13:01:27Z","html_url":"https://github.com/andela/ivy-ah-backend/pull/62#discussion_r276227949","pull_request_url":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/62","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/comments/276227949"},"html":{"href":"https://github.com/andela/ivy-ah-backend/pull/62#discussion_r276227949"},"pull_request":{"href":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/62","id":271231946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxMjMxOTQ2","html_url":"https://github.com/andela/ivy-ah-backend/pull/62","diff_url":"https://github.com/andela/ivy-ah-backend/pull/62.diff","patch_url":"https://github.com/andela/ivy-ah-backend/pull/62.patch","issue_url":"https://api.github.com/repos/andela/ivy-ah-backend/issues/62","number":62,"state":"open","locked":false,"title":"161780582 Adds highlight and comment feature","user":{"login":"kayroy247","id":38121456,"node_id":"MDQ6VXNlcjM4MTIxNDU2","avatar_url":"https://avatars3.githubusercontent.com/u/38121456?v=4","gravatar_id":"","url":"https://api.github.com/users/kayroy247","html_url":"https://github.com/kayroy247","followers_url":"https://api.github.com/users/kayroy247/followers","following_url":"https://api.github.com/users/kayroy247/following{/other_user}","gists_url":"https://api.github.com/users/kayroy247/gists{/gist_id}","starred_url":"https://api.github.com/users/kayroy247/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kayroy247/subscriptions","organizations_url":"https://api.github.com/users/kayroy247/orgs","repos_url":"https://api.github.com/users/kayroy247/repos","events_url":"https://api.github.com/users/kayroy247/events{/privacy}","received_events_url":"https://api.github.com/users/kayroy247/received_events","type":"User","site_admin":false},"body":"**Description**\r\n- Adds Highlight and comment functionality\r\n\r\n**Type of Change**\r\n- Feature\r\n\r\n**Flow Chart**\r\n\r\n\r\n**Pivotal Tracker ID**\r\n161780582","created_at":"2019-04-17T09:43:49Z","updated_at":"2019-04-17T13:01:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"808529a9953994208ee08e8ad357bc63275398d3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Bobjayafam","id":19153324,"node_id":"MDQ6VXNlcjE5MTUzMzI0","avatar_url":"https://avatars2.githubusercontent.com/u/19153324?v=4","gravatar_id":"","url":"https://api.github.com/users/Bobjayafam","html_url":"https://github.com/Bobjayafam","followers_url":"https://api.github.com/users/Bobjayafam/followers","following_url":"https://api.github.com/users/Bobjayafam/following{/other_user}","gists_url":"https://api.github.com/users/Bobjayafam/gists{/gist_id}","starred_url":"https://api.github.com/users/Bobjayafam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bobjayafam/subscriptions","organizations_url":"https://api.github.com/users/Bobjayafam/orgs","repos_url":"https://api.github.com/users/Bobjayafam/repos","events_url":"https://api.github.com/users/Bobjayafam/events{/privacy}","received_events_url":"https://api.github.com/users/Bobjayafam/received_events","type":"User","site_admin":false},{"login":"kossy360","id":22268023,"node_id":"MDQ6VXNlcjIyMjY4MDIz","avatar_url":"https://avatars3.githubusercontent.com/u/22268023?v=4","gravatar_id":"","url":"https://api.github.com/users/kossy360","html_url":"https://github.com/kossy360","followers_url":"https://api.github.com/users/kossy360/followers","following_url":"https://api.github.com/users/kossy360/following{/other_user}","gists_url":"https://api.github.com/users/kossy360/gists{/gist_id}","starred_url":"https://api.github.com/users/kossy360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kossy360/subscriptions","organizations_url":"https://api.github.com/users/kossy360/orgs","repos_url":"https://api.github.com/users/kossy360/repos","events_url":"https://api.github.com/users/kossy360/events{/privacy}","received_events_url":"https://api.github.com/users/kossy360/received_events","type":"User","site_admin":false},{"login":"Fiyiin","id":38258693,"node_id":"MDQ6VXNlcjM4MjU4Njkz","avatar_url":"https://avatars0.githubusercontent.com/u/38258693?v=4","gravatar_id":"","url":"https://api.github.com/users/Fiyiin","html_url":"https://github.com/Fiyiin","followers_url":"https://api.github.com/users/Fiyiin/followers","following_url":"https://api.github.com/users/Fiyiin/following{/other_user}","gists_url":"https://api.github.com/users/Fiyiin/gists{/gist_id}","starred_url":"https://api.github.com/users/Fiyiin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fiyiin/subscriptions","organizations_url":"https://api.github.com/users/Fiyiin/orgs","repos_url":"https://api.github.com/users/Fiyiin/repos","events_url":"https://api.github.com/users/Fiyiin/events{/privacy}","received_events_url":"https://api.github.com/users/Fiyiin/received_events","type":"User","site_admin":false},{"login":"innocentEdosa","id":45862608,"node_id":"MDQ6VXNlcjQ1ODYyNjA4","avatar_url":"https://avatars1.githubusercontent.com/u/45862608?v=4","gravatar_id":"","url":"https://api.github.com/users/innocentEdosa","html_url":"https://github.com/innocentEdosa","followers_url":"https://api.github.com/users/innocentEdosa/followers","following_url":"https://api.github.com/users/innocentEdosa/following{/other_user}","gists_url":"https://api.github.com/users/innocentEdosa/gists{/gist_id}","starred_url":"https://api.github.com/users/innocentEdosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/innocentEdosa/subscriptions","organizations_url":"https://api.github.com/users/innocentEdosa/orgs","repos_url":"https://api.github.com/users/innocentEdosa/repos","events_url":"https://api.github.com/users/innocentEdosa/events{/privacy}","received_events_url":"https://api.github.com/users/innocentEdosa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/62/commits","review_comments_url":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/62/comments","review_comment_url":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/ivy-ah-backend/issues/62/comments","statuses_url":"https://api.github.com/repos/andela/ivy-ah-backend/statuses/88f3be3974419eb942c4b259619d634720cda605","head":{"label":"andela:feat/161780582-user-can-highlight-and-comment-on-article","ref":"feat/161780582-user-can-highlight-and-comment-on-article","sha":"88f3be3974419eb942c4b259619d634720cda605","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":156544478,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1NDQ0Nzg=","name":"ivy-ah-backend","full_name":"andela/ivy-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ivy-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ivy-ah-backend","forks_url":"https://api.github.com/repos/andela/ivy-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/ivy-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ivy-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ivy-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/ivy-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/ivy-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ivy-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/ivy-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ivy-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ivy-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ivy-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ivy-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/ivy-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/ivy-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/ivy-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/ivy-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/ivy-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ivy-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ivy-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ivy-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ivy-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ivy-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/ivy-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ivy-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/ivy-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ivy-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ivy-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ivy-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ivy-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/ivy-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ivy-ah-backend/deployments","created_at":"2018-11-07T12:39:04Z","updated_at":"2019-04-17T12:27:13Z","pushed_at":"2019-04-17T13:01:15Z","git_url":"git://github.com/andela/ivy-ah-backend.git","ssh_url":"git@github.com:andela/ivy-ah-backend.git","clone_url":"https://github.com/andela/ivy-ah-backend.git","svn_url":"https://github.com/andela/ivy-ah-backend","homepage":null,"size":471,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"d0d2fb81bb7385018f6801d6eebfa95e9396dbc5","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":156544478,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1NDQ0Nzg=","name":"ivy-ah-backend","full_name":"andela/ivy-ah-backend","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/ivy-ah-backend","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ivy-ah-backend","forks_url":"https://api.github.com/repos/andela/ivy-ah-backend/forks","keys_url":"https://api.github.com/repos/andela/ivy-ah-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ivy-ah-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ivy-ah-backend/teams","hooks_url":"https://api.github.com/repos/andela/ivy-ah-backend/hooks","issue_events_url":"https://api.github.com/repos/andela/ivy-ah-backend/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ivy-ah-backend/events","assignees_url":"https://api.github.com/repos/andela/ivy-ah-backend/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ivy-ah-backend/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ivy-ah-backend/tags","blobs_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ivy-ah-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ivy-ah-backend/languages","stargazers_url":"https://api.github.com/repos/andela/ivy-ah-backend/stargazers","contributors_url":"https://api.github.com/repos/andela/ivy-ah-backend/contributors","subscribers_url":"https://api.github.com/repos/andela/ivy-ah-backend/subscribers","subscription_url":"https://api.github.com/repos/andela/ivy-ah-backend/subscription","commits_url":"https://api.github.com/repos/andela/ivy-ah-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ivy-ah-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ivy-ah-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ivy-ah-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ivy-ah-backend/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ivy-ah-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ivy-ah-backend/merges","archive_url":"https://api.github.com/repos/andela/ivy-ah-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ivy-ah-backend/downloads","issues_url":"https://api.github.com/repos/andela/ivy-ah-backend/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ivy-ah-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ivy-ah-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ivy-ah-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ivy-ah-backend/labels{/name}","releases_url":"https://api.github.com/repos/andela/ivy-ah-backend/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ivy-ah-backend/deployments","created_at":"2018-11-07T12:39:04Z","updated_at":"2019-04-17T12:27:13Z","pushed_at":"2019-04-17T13:01:15Z","git_url":"git://github.com/andela/ivy-ah-backend.git","ssh_url":"git@github.com:andela/ivy-ah-backend.git","clone_url":"https://github.com/andela/ivy-ah-backend.git","svn_url":"https://github.com/andela/ivy-ah-backend","homepage":null,"size":471,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/62"},"html":{"href":"https://github.com/andela/ivy-ah-backend/pull/62"},"issue":{"href":"https://api.github.com/repos/andela/ivy-ah-backend/issues/62"},"comments":{"href":"https://api.github.com/repos/andela/ivy-ah-backend/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/ivy-ah-backend/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/andela/ivy-ah-backend/statuses/88f3be3974419eb942c4b259619d634720cda605"}},"author_association":"COLLABORATOR"}}
|
{
"id": 156544478,
"name": "andela/ivy-ah-backend",
"url": "https://api.github.com/repos/andela/ivy-ah-backend"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
}
| 2019-04-17T13:01:27 |
9461228582
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/comments/324370204","pull_request_review_id":288254420,"id":324370204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDM3MDIwNA==","diff_hunk":"@@ -20,139 +21,219 @@ include::https://raw.githubusercontent.com/spring-guides/getting-started-macros/\n \n include::https://raw.githubusercontent.com/spring-guides/getting-started-macros/master/how_to_complete_this_guide.adoc[]\n \n-\n-include::https://raw.githubusercontent.com/spring-guides/getting-started-macros/master/hide-show-gradle.adoc[]\n-\n-include::https://raw.githubusercontent.com/spring-guides/getting-started-macros/master/hide-show-maven.adoc[]\n-\n-include::https://raw.githubusercontent.com/spring-guides/getting-started-macros/master/hide-show-sts.adoc[]\n-\n == Business Data\n \n-Typically your customer or a business analyst supplies a spreadsheet. In this case, you make it up.\n+Typically, your customer or a business analyst supplies a spreadsheet. For this simple\n+example, you can find some made-up data in `src/main/resources/sample-data.csv`:\n \n-`src/main/resources/sample-data.csv`\n+====\n [source,csv]\n ----\n include::initial/src/main/resources/sample-data.csv[]\n ----\n+====\n \n-This spreadsheet contains a first name and a last name on each row, separated by a comma. This is a fairly common pattern that Spring handles out-of-the-box, as you will see.\n-\n+This spreadsheet contains a first name and a last name on each row, separated by a comma.\n+This is a fairly common pattern that Spring can handle without customization.\n \n-Next, you write a SQL script to create a table to store the data.\n+Next, you need to write an SQL script to create a table to store the data. You can find\n+such a script in `src/main/resources/schema-all.sql`:\n \n-`src/main/resources/schema-all.sql`\n+====\n [source,sql]\n ----\n include::initial/src/main/resources/schema-all.sql[]\n ----\n+====\n \n NOTE: Spring Boot runs `schema-@@platform@@.sql` automatically during startup. `-all` is the default for all platforms.\n \n+== Starting with Spring Initializr\n+\n+For all Spring applications, you should start with the https://start.spring.io[Spring\n+Initializr]. The Initializr offers a fast way to pull in all the dependencies you need for\n+an application and does a lot of the set up for you. This example needs the Spring Batch\n+and HyperSQL Database dependencies. The following image shows the Initializr set up for\n+this sample project:\n+\n+image::images/initializr.jpg[]\n+","path":"README.adoc","position":68,"original_position":68,"commit_id":"4cfd7fee9e172b79d8aaac337b92d304fc95e180","original_commit_id":"4cfd7fee9e172b79d8aaac337b92d304fc95e180","user":{"login":"gregturn","id":311040,"node_id":"MDQ6VXNlcjMxMTA0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/311040?v=4","gravatar_id":"","url":"https://api.github.com/users/gregturn","html_url":"https://github.com/gregturn","followers_url":"https://api.github.com/users/gregturn/followers","following_url":"https://api.github.com/users/gregturn/following{/other_user}","gists_url":"https://api.github.com/users/gregturn/gists{/gist_id}","starred_url":"https://api.github.com/users/gregturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregturn/subscriptions","organizations_url":"https://api.github.com/users/gregturn/orgs","repos_url":"https://api.github.com/users/gregturn/repos","events_url":"https://api.github.com/users/gregturn/events{/privacy}","received_events_url":"https://api.github.com/users/gregturn/received_events","type":"User","site_admin":false},"body":"`.png`?","created_at":"2019-09-13T21:12:10Z","updated_at":"2019-09-13T21:12:11Z","html_url":"https://github.com/spring-guides/gs-batch-processing/pull/33#discussion_r324370204","pull_request_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/comments/324370204"},"html":{"href":"https://github.com/spring-guides/gs-batch-processing/pull/33#discussion_r324370204"},"pull_request":{"href":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/33","id":316933844,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2OTMzODQ0","html_url":"https://github.com/spring-guides/gs-batch-processing/pull/33","diff_url":"https://github.com/spring-guides/gs-batch-processing/pull/33.diff","patch_url":"https://github.com/spring-guides/gs-batch-processing/pull/33.patch","issue_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/issues/33","number":33,"state":"open","locked":false,"title":"Use the Spring Initializr","user":{"login":"Buzzardo","id":5225162,"node_id":"MDQ6VXNlcjUyMjUxNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/5225162?v=4","gravatar_id":"","url":"https://api.github.com/users/Buzzardo","html_url":"https://github.com/Buzzardo","followers_url":"https://api.github.com/users/Buzzardo/followers","following_url":"https://api.github.com/users/Buzzardo/following{/other_user}","gists_url":"https://api.github.com/users/Buzzardo/gists{/gist_id}","starred_url":"https://api.github.com/users/Buzzardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Buzzardo/subscriptions","organizations_url":"https://api.github.com/users/Buzzardo/orgs","repos_url":"https://api.github.com/users/Buzzardo/repos","events_url":"https://api.github.com/users/Buzzardo/events{/privacy}","received_events_url":"https://api.github.com/users/Buzzardo/received_events","type":"User","site_admin":false},"body":"I rewrote the doc and rearranged the code to use the Spring Initializr.","created_at":"2019-09-12T14:23:33Z","updated_at":"2019-09-13T21:12:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1abec98f1b87bdc6fdd65d9688cb0ed68e81b20a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/33/commits","review_comments_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/33/comments","review_comment_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/issues/33/comments","statuses_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/statuses/4cfd7fee9e172b79d8aaac337b92d304fc95e180","head":{"label":"Buzzardo:initializr","ref":"initializr","sha":"4cfd7fee9e172b79d8aaac337b92d304fc95e180","user":{"login":"Buzzardo","id":5225162,"node_id":"MDQ6VXNlcjUyMjUxNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/5225162?v=4","gravatar_id":"","url":"https://api.github.com/users/Buzzardo","html_url":"https://github.com/Buzzardo","followers_url":"https://api.github.com/users/Buzzardo/followers","following_url":"https://api.github.com/users/Buzzardo/following{/other_user}","gists_url":"https://api.github.com/users/Buzzardo/gists{/gist_id}","starred_url":"https://api.github.com/users/Buzzardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Buzzardo/subscriptions","organizations_url":"https://api.github.com/users/Buzzardo/orgs","repos_url":"https://api.github.com/users/Buzzardo/repos","events_url":"https://api.github.com/users/Buzzardo/events{/privacy}","received_events_url":"https://api.github.com/users/Buzzardo/received_events","type":"User","site_admin":false},"repo":{"id":207849906,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc4NDk5MDY=","name":"gs-batch-processing","full_name":"Buzzardo/gs-batch-processing","private":false,"owner":{"login":"Buzzardo","id":5225162,"node_id":"MDQ6VXNlcjUyMjUxNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/5225162?v=4","gravatar_id":"","url":"https://api.github.com/users/Buzzardo","html_url":"https://github.com/Buzzardo","followers_url":"https://api.github.com/users/Buzzardo/followers","following_url":"https://api.github.com/users/Buzzardo/following{/other_user}","gists_url":"https://api.github.com/users/Buzzardo/gists{/gist_id}","starred_url":"https://api.github.com/users/Buzzardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Buzzardo/subscriptions","organizations_url":"https://api.github.com/users/Buzzardo/orgs","repos_url":"https://api.github.com/users/Buzzardo/repos","events_url":"https://api.github.com/users/Buzzardo/events{/privacy}","received_events_url":"https://api.github.com/users/Buzzardo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Buzzardo/gs-batch-processing","description":"Creating a Batch Service :: Learn how to create a basic batch-driven solution.","fork":true,"url":"https://api.github.com/repos/Buzzardo/gs-batch-processing","forks_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/forks","keys_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/teams","hooks_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/hooks","issue_events_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/issues/events{/number}","events_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/events","assignees_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/assignees{/user}","branches_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/branches{/branch}","tags_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/tags","blobs_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/git/refs{/sha}","trees_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/statuses/{sha}","languages_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/languages","stargazers_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/stargazers","contributors_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/contributors","subscribers_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/subscribers","subscription_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/subscription","commits_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/commits{/sha}","git_commits_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/git/commits{/sha}","comments_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/comments{/number}","issue_comment_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/issues/comments{/number}","contents_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/contents/{+path}","compare_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/merges","archive_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/downloads","issues_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/issues{/number}","pulls_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/pulls{/number}","milestones_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/milestones{/number}","notifications_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/labels{/name}","releases_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/releases{/id}","deployments_url":"https://api.github.com/repos/Buzzardo/gs-batch-processing/deployments","created_at":"2019-09-11T15:48:37Z","updated_at":"2019-09-11T15:48:39Z","pushed_at":"2019-09-12T14:21:36Z","git_url":"git://github.com/Buzzardo/gs-batch-processing.git","ssh_url":"git@github.com:Buzzardo/gs-batch-processing.git","clone_url":"https://github.com/Buzzardo/gs-batch-processing.git","svn_url":"https://github.com/Buzzardo/gs-batch-processing","homepage":"https://spring.io/guides/gs/batch-processing/","size":701,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-guides:master","ref":"master","sha":"77a2bd0b98ef13c43edf0f94e4489ae01eb74304","user":{"login":"spring-guides","id":4161866,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjE4NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4161866?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-guides","html_url":"https://github.com/spring-guides","followers_url":"https://api.github.com/users/spring-guides/followers","following_url":"https://api.github.com/users/spring-guides/following{/other_user}","gists_url":"https://api.github.com/users/spring-guides/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-guides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-guides/subscriptions","organizations_url":"https://api.github.com/users/spring-guides/orgs","repos_url":"https://api.github.com/users/spring-guides/repos","events_url":"https://api.github.com/users/spring-guides/events{/privacy}","received_events_url":"https://api.github.com/users/spring-guides/received_events","type":"Organization","site_admin":false},"repo":{"id":10085312,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA4NTMxMg==","name":"gs-batch-processing","full_name":"spring-guides/gs-batch-processing","private":false,"owner":{"login":"spring-guides","id":4161866,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjE4NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4161866?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-guides","html_url":"https://github.com/spring-guides","followers_url":"https://api.github.com/users/spring-guides/followers","following_url":"https://api.github.com/users/spring-guides/following{/other_user}","gists_url":"https://api.github.com/users/spring-guides/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-guides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-guides/subscriptions","organizations_url":"https://api.github.com/users/spring-guides/orgs","repos_url":"https://api.github.com/users/spring-guides/repos","events_url":"https://api.github.com/users/spring-guides/events{/privacy}","received_events_url":"https://api.github.com/users/spring-guides/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-guides/gs-batch-processing","description":"Creating a Batch Service :: Learn how to create a basic batch-driven solution.","fork":false,"url":"https://api.github.com/repos/spring-guides/gs-batch-processing","forks_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/forks","keys_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/teams","hooks_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/hooks","issue_events_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/issues/events{/number}","events_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/events","assignees_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/assignees{/user}","branches_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/branches{/branch}","tags_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/tags","blobs_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/languages","stargazers_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/stargazers","contributors_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/contributors","subscribers_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/subscribers","subscription_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/subscription","commits_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/contents/{+path}","compare_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/merges","archive_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/downloads","issues_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/issues{/number}","pulls_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/labels{/name}","releases_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/releases{/id}","deployments_url":"https://api.github.com/repos/spring-guides/gs-batch-processing/deployments","created_at":"2013-05-15T18:33:30Z","updated_at":"2019-09-05T11:58:49Z","pushed_at":"2019-09-12T14:23:34Z","git_url":"git://github.com/spring-guides/gs-batch-processing.git","ssh_url":"git@github.com:spring-guides/gs-batch-processing.git","clone_url":"https://github.com/spring-guides/gs-batch-processing.git","svn_url":"https://github.com/spring-guides/gs-batch-processing","homepage":"https://spring.io/guides/gs/batch-processing/","size":465,"stargazers_count":95,"watchers_count":95,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":209,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":null,"forks":209,"open_issues":7,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/33"},"html":{"href":"https://github.com/spring-guides/gs-batch-processing/pull/33"},"issue":{"href":"https://api.github.com/repos/spring-guides/gs-batch-processing/issues/33"},"comments":{"href":"https://api.github.com/repos/spring-guides/gs-batch-processing/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-guides/gs-batch-processing/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/spring-guides/gs-batch-processing/statuses/4cfd7fee9e172b79d8aaac337b92d304fc95e180"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 10085312,
"name": "spring-guides/gs-batch-processing",
"url": "https://api.github.com/repos/spring-guides/gs-batch-processing"
}
|
{
"id": 311040,
"login": "gregturn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/311040?",
"url": "https://api.github.com/users/gregturn"
}
|
{
"id": 4161866,
"login": "spring-guides",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4161866?",
"url": "https://api.github.com/orgs/spring-guides"
}
| 2019-09-13T21:12:10 |
10414368551
|
{"actor":{"display_login":"gregturn"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/macports/upt-macports/pulls/comments/291786369","pull_request_review_id":247345685,"id":291786369,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTc4NjM2OQ==","diff_hunk":"@@ -30,9 +30,15 @@ def licenses(self):\n filepath = pkg_resources.resource_filename(__name__, relpath)\n with open(filepath) as f:\n spdx2macports = json.loads(f.read())\n-\n- return ' '.join([spdx2macports.get(license.spdx_identifier, 'unknown')\n- for license in self.upt_pkg.licenses]) or 'unknown'\n+ licenses = []\n+ for license in self.upt_pkg.licenses:\n+ port_license = spdx2macports.get(license.spdx_identifier,\n+ 'unknown')\n+ if license.spdx_identifier != 'unknown'and port_license == 'unknown': # noqa\n+ self.logger.error(f'spdx2macports license conversion failed for {license.spdx_identifier}') # noqa\n+ else:\n+ licenses.append(port_license)","path":"upt_macports/upt_macports.py","position":14,"original_position":14,"commit_id":"98645adf69c3a6486fcd426e6a7faf1455f846dd","original_commit_id":"98645adf69c3a6486fcd426e6a7faf1455f846dd","user":{"login":"Steap","id":416834,"node_id":"MDQ6VXNlcjQxNjgzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/416834?v=4","gravatar_id":"","url":"https://api.github.com/users/Steap","html_url":"https://github.com/Steap","followers_url":"https://api.github.com/users/Steap/followers","following_url":"https://api.github.com/users/Steap/following{/other_user}","gists_url":"https://api.github.com/users/Steap/gists{/gist_id}","starred_url":"https://api.github.com/users/Steap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steap/subscriptions","organizations_url":"https://api.github.com/users/Steap/orgs","repos_url":"https://api.github.com/users/Steap/repos","events_url":"https://api.github.com/users/Steap/events{/privacy}","received_events_url":"https://api.github.com/users/Steap/received_events","type":"User","site_admin":false},"body":"Should we log this? \r\n\r\n> self.logging.info (f'Found license {port_license)')\r\n","created_at":"2019-06-08T00:23:33Z","updated_at":"2019-06-08T00:23:53Z","html_url":"https://github.com/macports/upt-macports/pull/25#discussion_r291786369","pull_request_url":"https://api.github.com/repos/macports/upt-macports/pulls/25","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/macports/upt-macports/pulls/comments/291786369"},"html":{"href":"https://github.com/macports/upt-macports/pull/25#discussion_r291786369"},"pull_request":{"href":"https://api.github.com/repos/macports/upt-macports/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/macports/upt-macports/pulls/25","id":286363300,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2MzYzMzAw","html_url":"https://github.com/macports/upt-macports/pull/25","diff_url":"https://github.com/macports/upt-macports/pull/25.diff","patch_url":"https://github.com/macports/upt-macports/pull/25.patch","issue_url":"https://api.github.com/repos/macports/upt-macports/issues/25","number":25,"state":"open","locked":false,"title":"Add license logging","user":{"login":"Korusuke","id":15181757,"node_id":"MDQ6VXNlcjE1MTgxNzU3","avatar_url":"https://avatars0.githubusercontent.com/u/15181757?v=4","gravatar_id":"","url":"https://api.github.com/users/Korusuke","html_url":"https://github.com/Korusuke","followers_url":"https://api.github.com/users/Korusuke/followers","following_url":"https://api.github.com/users/Korusuke/following{/other_user}","gists_url":"https://api.github.com/users/Korusuke/gists{/gist_id}","starred_url":"https://api.github.com/users/Korusuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Korusuke/subscriptions","organizations_url":"https://api.github.com/users/Korusuke/orgs","repos_url":"https://api.github.com/users/Korusuke/repos","events_url":"https://api.github.com/users/Korusuke/events{/privacy}","received_events_url":"https://api.github.com/users/Korusuke/received_events","type":"User","site_admin":false},"body":"This will only log when upt detected the license but the conversion failed and not when upt itself failed to detect the license.","created_at":"2019-06-07T23:57:33Z","updated_at":"2019-06-08T00:23:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de8246bb918b407875e07205e24e3f918511b8f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/macports/upt-macports/pulls/25/commits","review_comments_url":"https://api.github.com/repos/macports/upt-macports/pulls/25/comments","review_comment_url":"https://api.github.com/repos/macports/upt-macports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/macports/upt-macports/issues/25/comments","statuses_url":"https://api.github.com/repos/macports/upt-macports/statuses/98645adf69c3a6486fcd426e6a7faf1455f846dd","head":{"label":"Korusuke:license","ref":"license","sha":"98645adf69c3a6486fcd426e6a7faf1455f846dd","user":{"login":"Korusuke","id":15181757,"node_id":"MDQ6VXNlcjE1MTgxNzU3","avatar_url":"https://avatars0.githubusercontent.com/u/15181757?v=4","gravatar_id":"","url":"https://api.github.com/users/Korusuke","html_url":"https://github.com/Korusuke","followers_url":"https://api.github.com/users/Korusuke/followers","following_url":"https://api.github.com/users/Korusuke/following{/other_user}","gists_url":"https://api.github.com/users/Korusuke/gists{/gist_id}","starred_url":"https://api.github.com/users/Korusuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Korusuke/subscriptions","organizations_url":"https://api.github.com/users/Korusuke/orgs","repos_url":"https://api.github.com/users/Korusuke/repos","events_url":"https://api.github.com/users/Korusuke/events{/privacy}","received_events_url":"https://api.github.com/users/Korusuke/received_events","type":"User","site_admin":false},"repo":{"id":187220783,"node_id":"MDEwOlJlcG9zaXRvcnkxODcyMjA3ODM=","name":"upt-macports","full_name":"Korusuke/upt-macports","private":false,"owner":{"login":"Korusuke","id":15181757,"node_id":"MDQ6VXNlcjE1MTgxNzU3","avatar_url":"https://avatars0.githubusercontent.com/u/15181757?v=4","gravatar_id":"","url":"https://api.github.com/users/Korusuke","html_url":"https://github.com/Korusuke","followers_url":"https://api.github.com/users/Korusuke/followers","following_url":"https://api.github.com/users/Korusuke/following{/other_user}","gists_url":"https://api.github.com/users/Korusuke/gists{/gist_id}","starred_url":"https://api.github.com/users/Korusuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Korusuke/subscriptions","organizations_url":"https://api.github.com/users/Korusuke/orgs","repos_url":"https://api.github.com/users/Korusuke/repos","events_url":"https://api.github.com/users/Korusuke/events{/privacy}","received_events_url":"https://api.github.com/users/Korusuke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Korusuke/upt-macports","description":"The Universal Packaging Tool (upt) backend for MacPorts","fork":true,"url":"https://api.github.com/repos/Korusuke/upt-macports","forks_url":"https://api.github.com/repos/Korusuke/upt-macports/forks","keys_url":"https://api.github.com/repos/Korusuke/upt-macports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Korusuke/upt-macports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Korusuke/upt-macports/teams","hooks_url":"https://api.github.com/repos/Korusuke/upt-macports/hooks","issue_events_url":"https://api.github.com/repos/Korusuke/upt-macports/issues/events{/number}","events_url":"https://api.github.com/repos/Korusuke/upt-macports/events","assignees_url":"https://api.github.com/repos/Korusuke/upt-macports/assignees{/user}","branches_url":"https://api.github.com/repos/Korusuke/upt-macports/branches{/branch}","tags_url":"https://api.github.com/repos/Korusuke/upt-macports/tags","blobs_url":"https://api.github.com/repos/Korusuke/upt-macports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Korusuke/upt-macports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Korusuke/upt-macports/git/refs{/sha}","trees_url":"https://api.github.com/repos/Korusuke/upt-macports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Korusuke/upt-macports/statuses/{sha}","languages_url":"https://api.github.com/repos/Korusuke/upt-macports/languages","stargazers_url":"https://api.github.com/repos/Korusuke/upt-macports/stargazers","contributors_url":"https://api.github.com/repos/Korusuke/upt-macports/contributors","subscribers_url":"https://api.github.com/repos/Korusuke/upt-macports/subscribers","subscription_url":"https://api.github.com/repos/Korusuke/upt-macports/subscription","commits_url":"https://api.github.com/repos/Korusuke/upt-macports/commits{/sha}","git_commits_url":"https://api.github.com/repos/Korusuke/upt-macports/git/commits{/sha}","comments_url":"https://api.github.com/repos/Korusuke/upt-macports/comments{/number}","issue_comment_url":"https://api.github.com/repos/Korusuke/upt-macports/issues/comments{/number}","contents_url":"https://api.github.com/repos/Korusuke/upt-macports/contents/{+path}","compare_url":"https://api.github.com/repos/Korusuke/upt-macports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Korusuke/upt-macports/merges","archive_url":"https://api.github.com/repos/Korusuke/upt-macports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Korusuke/upt-macports/downloads","issues_url":"https://api.github.com/repos/Korusuke/upt-macports/issues{/number}","pulls_url":"https://api.github.com/repos/Korusuke/upt-macports/pulls{/number}","milestones_url":"https://api.github.com/repos/Korusuke/upt-macports/milestones{/number}","notifications_url":"https://api.github.com/repos/Korusuke/upt-macports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Korusuke/upt-macports/labels{/name}","releases_url":"https://api.github.com/repos/Korusuke/upt-macports/releases{/id}","deployments_url":"https://api.github.com/repos/Korusuke/upt-macports/deployments","created_at":"2019-05-17T13:25:41Z","updated_at":"2019-06-06T18:29:39Z","pushed_at":"2019-06-07T23:53:40Z","git_url":"git://github.com/Korusuke/upt-macports.git","ssh_url":"git@github.com:Korusuke/upt-macports.git","clone_url":"https://github.com/Korusuke/upt-macports.git","svn_url":"https://github.com/Korusuke/upt-macports","homepage":"https://framagit.org/upt/upt","size":24,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"macports:master","ref":"master","sha":"26b268a7aa22741d208ba2f4941d9ed9ba30791e","user":{"login":"macports","id":4225322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjUzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4225322?v=4","gravatar_id":"","url":"https://api.github.com/users/macports","html_url":"https://github.com/macports","followers_url":"https://api.github.com/users/macports/followers","following_url":"https://api.github.com/users/macports/following{/other_user}","gists_url":"https://api.github.com/users/macports/gists{/gist_id}","starred_url":"https://api.github.com/users/macports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macports/subscriptions","organizations_url":"https://api.github.com/users/macports/orgs","repos_url":"https://api.github.com/users/macports/repos","events_url":"https://api.github.com/users/macports/events{/privacy}","received_events_url":"https://api.github.com/users/macports/received_events","type":"Organization","site_admin":false},"repo":{"id":179967566,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk5Njc1NjY=","name":"upt-macports","full_name":"macports/upt-macports","private":false,"owner":{"login":"macports","id":4225322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjUzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4225322?v=4","gravatar_id":"","url":"https://api.github.com/users/macports","html_url":"https://github.com/macports","followers_url":"https://api.github.com/users/macports/followers","following_url":"https://api.github.com/users/macports/following{/other_user}","gists_url":"https://api.github.com/users/macports/gists{/gist_id}","starred_url":"https://api.github.com/users/macports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macports/subscriptions","organizations_url":"https://api.github.com/users/macports/orgs","repos_url":"https://api.github.com/users/macports/repos","events_url":"https://api.github.com/users/macports/events{/privacy}","received_events_url":"https://api.github.com/users/macports/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/macports/upt-macports","description":"The Universal Packaging Tool (upt) backend for MacPorts","fork":false,"url":"https://api.github.com/repos/macports/upt-macports","forks_url":"https://api.github.com/repos/macports/upt-macports/forks","keys_url":"https://api.github.com/repos/macports/upt-macports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macports/upt-macports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macports/upt-macports/teams","hooks_url":"https://api.github.com/repos/macports/upt-macports/hooks","issue_events_url":"https://api.github.com/repos/macports/upt-macports/issues/events{/number}","events_url":"https://api.github.com/repos/macports/upt-macports/events","assignees_url":"https://api.github.com/repos/macports/upt-macports/assignees{/user}","branches_url":"https://api.github.com/repos/macports/upt-macports/branches{/branch}","tags_url":"https://api.github.com/repos/macports/upt-macports/tags","blobs_url":"https://api.github.com/repos/macports/upt-macports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macports/upt-macports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macports/upt-macports/git/refs{/sha}","trees_url":"https://api.github.com/repos/macports/upt-macports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macports/upt-macports/statuses/{sha}","languages_url":"https://api.github.com/repos/macports/upt-macports/languages","stargazers_url":"https://api.github.com/repos/macports/upt-macports/stargazers","contributors_url":"https://api.github.com/repos/macports/upt-macports/contributors","subscribers_url":"https://api.github.com/repos/macports/upt-macports/subscribers","subscription_url":"https://api.github.com/repos/macports/upt-macports/subscription","commits_url":"https://api.github.com/repos/macports/upt-macports/commits{/sha}","git_commits_url":"https://api.github.com/repos/macports/upt-macports/git/commits{/sha}","comments_url":"https://api.github.com/repos/macports/upt-macports/comments{/number}","issue_comment_url":"https://api.github.com/repos/macports/upt-macports/issues/comments{/number}","contents_url":"https://api.github.com/repos/macports/upt-macports/contents/{+path}","compare_url":"https://api.github.com/repos/macports/upt-macports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macports/upt-macports/merges","archive_url":"https://api.github.com/repos/macports/upt-macports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macports/upt-macports/downloads","issues_url":"https://api.github.com/repos/macports/upt-macports/issues{/number}","pulls_url":"https://api.github.com/repos/macports/upt-macports/pulls{/number}","milestones_url":"https://api.github.com/repos/macports/upt-macports/milestones{/number}","notifications_url":"https://api.github.com/repos/macports/upt-macports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macports/upt-macports/labels{/name}","releases_url":"https://api.github.com/repos/macports/upt-macports/releases{/id}","deployments_url":"https://api.github.com/repos/macports/upt-macports/deployments","created_at":"2019-04-07T13:06:52Z","updated_at":"2019-06-04T02:51:51Z","pushed_at":"2019-06-07T23:57:33Z","git_url":"git://github.com/macports/upt-macports.git","ssh_url":"git@github.com:macports/upt-macports.git","clone_url":"https://github.com/macports/upt-macports.git","svn_url":"https://github.com/macports/upt-macports","homepage":"https://framagit.org/upt/upt","size":20,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/macports/upt-macports/pulls/25"},"html":{"href":"https://github.com/macports/upt-macports/pull/25"},"issue":{"href":"https://api.github.com/repos/macports/upt-macports/issues/25"},"comments":{"href":"https://api.github.com/repos/macports/upt-macports/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/macports/upt-macports/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/macports/upt-macports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/macports/upt-macports/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/macports/upt-macports/statuses/98645adf69c3a6486fcd426e6a7faf1455f846dd"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 179967566,
"name": "macports/upt-macports",
"url": "https://api.github.com/repos/macports/upt-macports"
}
|
{
"id": 416834,
"login": "Steap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/416834?",
"url": "https://api.github.com/users/Steap"
}
|
{
"id": 4225322,
"login": "macports",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4225322?",
"url": "https://api.github.com/orgs/macports"
}
| 2019-06-08T00:23:33 |
9782542850
|
{"actor":{"display_login":"Steap"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/comments/299892352","pull_request_review_id":257405338,"id":299892352,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTg5MjM1Mg==","diff_hunk":"@@ -76,3 +76,14 @@ export type FormatDateTimeGetterFn = (locale: string | string[]) => FormatterFn;\n export type DateTimeFormatInstanceFn = (\n locale: string | string[], formatOptions: Intl.DateTimeFormatOptions,\n ) => Intl.DateTimeFormat;\n+/** @internal */\n+export type ScrollingAPI = {","path":"packages/dx-scheduler-core/src/types/scheduler-core.types.ts","position":5,"original_position":5,"commit_id":"006dc109c7bef91258f5058e0979f0a110fa36be","original_commit_id":"006dc109c7bef91258f5058e0979f0a110fa36be","user":{"login":"ushkal","id":44223690,"node_id":"MDQ6VXNlcjQ0MjIzNjkw","avatar_url":"https://avatars3.githubusercontent.com/u/44223690?v=4","gravatar_id":"","url":"https://api.github.com/users/ushkal","html_url":"https://github.com/ushkal","followers_url":"https://api.github.com/users/ushkal/followers","following_url":"https://api.github.com/users/ushkal/following{/other_user}","gists_url":"https://api.github.com/users/ushkal/gists{/gist_id}","starred_url":"https://api.github.com/users/ushkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushkal/subscriptions","organizations_url":"https://api.github.com/users/ushkal/orgs","repos_url":"https://api.github.com/users/ushkal/repos","events_url":"https://api.github.com/users/ushkal/events{/privacy}","received_events_url":"https://api.github.com/users/ushkal/received_events","type":"User","site_admin":false},"body":"Suggest to rename it to `ScrollingStrategy` too","created_at":"2019-07-03T10:45:19Z","updated_at":"2019-07-03T10:45:19Z","html_url":"https://github.com/DevExpress/devextreme-reactive/pull/2068#discussion_r299892352","pull_request_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/2068","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/comments/299892352"},"html":{"href":"https://github.com/DevExpress/devextreme-reactive/pull/2068#discussion_r299892352"},"pull_request":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/2068"}}},"pull_request":{"url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/2068","id":285423142,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1NDIzMTQy","html_url":"https://github.com/DevExpress/devextreme-reactive/pull/2068","diff_url":"https://github.com/DevExpress/devextreme-reactive/pull/2068.diff","patch_url":"https://github.com/DevExpress/devextreme-reactive/pull/2068.patch","issue_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/2068","number":2068,"state":"open","locked":false,"title":"refactor(react-scheduler): transfer DOM operations into theme package","user":{"login":"MaximKudriavtsev","id":15093892,"node_id":"MDQ6VXNlcjE1MDkzODky","avatar_url":"https://avatars2.githubusercontent.com/u/15093892?v=4","gravatar_id":"","url":"https://api.github.com/users/MaximKudriavtsev","html_url":"https://github.com/MaximKudriavtsev","followers_url":"https://api.github.com/users/MaximKudriavtsev/followers","following_url":"https://api.github.com/users/MaximKudriavtsev/following{/other_user}","gists_url":"https://api.github.com/users/MaximKudriavtsev/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximKudriavtsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximKudriavtsev/subscriptions","organizations_url":"https://api.github.com/users/MaximKudriavtsev/orgs","repos_url":"https://api.github.com/users/MaximKudriavtsev/repos","events_url":"https://api.github.com/users/MaximKudriavtsev/events{/privacy}","received_events_url":"https://api.github.com/users/MaximKudriavtsev/received_events","type":"User","site_admin":false},"body":"1. Transfer DOM manipulations into the theme package\r\n2. Make scrolling API to manage a view scroll position\r\n\r\n\r\n\r\nBC draft\r\n\r\nAllDayPanel plugin\r\n- layout component\r\n-- -allDayPanelRef\r\n-- +foramtDate\r\n-- +setCellElementsMeta\r\n\r\n","created_at":"2019-06-05T15:15:34Z","updated_at":"2019-07-03T10:45:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f69564ad6cc776eb05ce0a24c06c1e24670327b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"DmitryBogomolov","id":2501124,"node_id":"MDQ6VXNlcjI1MDExMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2501124?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryBogomolov","html_url":"https://github.com/DmitryBogomolov","followers_url":"https://api.github.com/users/DmitryBogomolov/followers","following_url":"https://api.github.com/users/DmitryBogomolov/following{/other_user}","gists_url":"https://api.github.com/users/DmitryBogomolov/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryBogomolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryBogomolov/subscriptions","organizations_url":"https://api.github.com/users/DmitryBogomolov/orgs","repos_url":"https://api.github.com/users/DmitryBogomolov/repos","events_url":"https://api.github.com/users/DmitryBogomolov/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryBogomolov/received_events","type":"User","site_admin":false},{"login":"churkin","id":5182202,"node_id":"MDQ6VXNlcjUxODIyMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5182202?v=4","gravatar_id":"","url":"https://api.github.com/users/churkin","html_url":"https://github.com/churkin","followers_url":"https://api.github.com/users/churkin/followers","following_url":"https://api.github.com/users/churkin/following{/other_user}","gists_url":"https://api.github.com/users/churkin/gists{/gist_id}","starred_url":"https://api.github.com/users/churkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/churkin/subscriptions","organizations_url":"https://api.github.com/users/churkin/orgs","repos_url":"https://api.github.com/users/churkin/repos","events_url":"https://api.github.com/users/churkin/events{/privacy}","received_events_url":"https://api.github.com/users/churkin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/2068/commits","review_comments_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/2068/comments","review_comment_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/2068/comments","statuses_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/statuses/006dc109c7bef91258f5058e0979f0a110fa36be","head":{"label":"MaximKudriavtsev:scheduler-views-refactoring","ref":"scheduler-views-refactoring","sha":"006dc109c7bef91258f5058e0979f0a110fa36be","user":{"login":"MaximKudriavtsev","id":15093892,"node_id":"MDQ6VXNlcjE1MDkzODky","avatar_url":"https://avatars2.githubusercontent.com/u/15093892?v=4","gravatar_id":"","url":"https://api.github.com/users/MaximKudriavtsev","html_url":"https://github.com/MaximKudriavtsev","followers_url":"https://api.github.com/users/MaximKudriavtsev/followers","following_url":"https://api.github.com/users/MaximKudriavtsev/following{/other_user}","gists_url":"https://api.github.com/users/MaximKudriavtsev/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximKudriavtsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximKudriavtsev/subscriptions","organizations_url":"https://api.github.com/users/MaximKudriavtsev/orgs","repos_url":"https://api.github.com/users/MaximKudriavtsev/repos","events_url":"https://api.github.com/users/MaximKudriavtsev/events{/privacy}","received_events_url":"https://api.github.com/users/MaximKudriavtsev/received_events","type":"User","site_admin":false},"repo":{"id":138300199,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMDAxOTk=","name":"devextreme-reactive","full_name":"MaximKudriavtsev/devextreme-reactive","private":false,"owner":{"login":"MaximKudriavtsev","id":15093892,"node_id":"MDQ6VXNlcjE1MDkzODky","avatar_url":"https://avatars2.githubusercontent.com/u/15093892?v=4","gravatar_id":"","url":"https://api.github.com/users/MaximKudriavtsev","html_url":"https://github.com/MaximKudriavtsev","followers_url":"https://api.github.com/users/MaximKudriavtsev/followers","following_url":"https://api.github.com/users/MaximKudriavtsev/following{/other_user}","gists_url":"https://api.github.com/users/MaximKudriavtsev/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximKudriavtsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximKudriavtsev/subscriptions","organizations_url":"https://api.github.com/users/MaximKudriavtsev/orgs","repos_url":"https://api.github.com/users/MaximKudriavtsev/repos","events_url":"https://api.github.com/users/MaximKudriavtsev/events{/privacy}","received_events_url":"https://api.github.com/users/MaximKudriavtsev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MaximKudriavtsev/devextreme-reactive","description":"DevExtreme Reactive Components","fork":true,"url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive","forks_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/forks","keys_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/teams","hooks_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/hooks","issue_events_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/issues/events{/number}","events_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/events","assignees_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/assignees{/user}","branches_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/branches{/branch}","tags_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/tags","blobs_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/languages","stargazers_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/stargazers","contributors_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/contributors","subscribers_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/subscribers","subscription_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/subscription","commits_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/contents/{+path}","compare_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/merges","archive_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/downloads","issues_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/issues{/number}","pulls_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/labels{/name}","releases_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/releases{/id}","deployments_url":"https://api.github.com/repos/MaximKudriavtsev/devextreme-reactive/deployments","created_at":"2018-06-22T12:27:36Z","updated_at":"2019-07-03T06:22:21Z","pushed_at":"2019-07-03T10:41:27Z","git_url":"git://github.com/MaximKudriavtsev/devextreme-reactive.git","ssh_url":"git@github.com:MaximKudriavtsev/devextreme-reactive.git","clone_url":"https://github.com/MaximKudriavtsev/devextreme-reactive.git","svn_url":"https://github.com/MaximKudriavtsev/devextreme-reactive","homepage":"https://devexpress.github.io/devextreme-reactive/","size":43434,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DevExpress:master","ref":"master","sha":"c2573e3abed647b578672e1683b4f72a3b1d6dea","user":{"login":"DevExpress","id":4243232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMyMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":85281744,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI4MTc0NA==","name":"devextreme-reactive","full_name":"DevExpress/devextreme-reactive","private":false,"owner":{"login":"DevExpress","id":4243232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMyMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DevExpress/devextreme-reactive","description":"Business React components for Bootstrap and Material-UI","fork":false,"url":"https://api.github.com/repos/DevExpress/devextreme-reactive","forks_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/forks","keys_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/teams","hooks_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/hooks","issue_events_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/events{/number}","events_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/events","assignees_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/assignees{/user}","branches_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/branches{/branch}","tags_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/tags","blobs_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/statuses/{sha}","languages_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/languages","stargazers_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/stargazers","contributors_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/contributors","subscribers_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/subscribers","subscription_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/subscription","commits_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/contents/{+path}","compare_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/merges","archive_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/downloads","issues_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues{/number}","pulls_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls{/number}","milestones_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/milestones{/number}","notifications_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/labels{/name}","releases_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/releases{/id}","deployments_url":"https://api.github.com/repos/DevExpress/devextreme-reactive/deployments","created_at":"2017-03-17T07:10:12Z","updated_at":"2019-07-03T08:17:29Z","pushed_at":"2019-07-03T10:41:28Z","git_url":"git://github.com/DevExpress/devextreme-reactive.git","ssh_url":"git@github.com:DevExpress/devextreme-reactive.git","clone_url":"https://github.com/DevExpress/devextreme-reactive.git","svn_url":"https://github.com/DevExpress/devextreme-reactive","homepage":"https://devexpress.github.io/devextreme-reactive/","size":74985,"stargazers_count":1059,"watchers_count":1059,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":180,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":180,"open_issues":73,"watchers":1059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/2068"},"html":{"href":"https://github.com/DevExpress/devextreme-reactive/pull/2068"},"issue":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/2068"},"comments":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/issues/2068/comments"},"review_comments":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/2068/comments"},"review_comment":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/pulls/2068/commits"},"statuses":{"href":"https://api.github.com/repos/DevExpress/devextreme-reactive/statuses/006dc109c7bef91258f5058e0979f0a110fa36be"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 85281744,
"name": "DevExpress/devextreme-reactive",
"url": "https://api.github.com/repos/DevExpress/devextreme-reactive"
}
|
{
"id": 44223690,
"login": "ushkal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44223690?",
"url": "https://api.github.com/users/ushkal"
}
|
{
"id": 4243232,
"login": "DevExpress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4243232?",
"url": "https://api.github.com/orgs/DevExpress"
}
| 2019-07-03T10:45:19 |
9941113456
|
{"actor":{"display_login":"ushkal"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/comments/343683589","pull_request_review_id":313381273,"id":343683589,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzY4MzU4OQ==","diff_hunk":"@@ -0,0 +1,53 @@\n+# Accept and Reject Changes\n+\n+## Accept Changes\n+\n+### Accept A Specific Change\n+\n+To accept a single change, select the change you want to accept and click **Accept** button in the **Changes** ribbon group on the **Review** tab. The change will be accepted, and the cursor will be moved to the next change.\n+\n+\n+\n+To accept the change and keep the cursor at the same position, open the **Accept** drop down menu and select **Accept This Change**.","path":"interface-elements-for-desktop/articles/rich-text-editor/track-changes/accept-and-reject-tracked-changes.md","position":11,"original_position":11,"commit_id":"aeb44ffb0869ff912730b091a4cfd1398a78fba7","original_commit_id":"aeb44ffb0869ff912730b091a4cfd1398a78fba7","user":{"login":"dirk-pieterse","id":26871970,"node_id":"MDQ6VXNlcjI2ODcxOTcw","avatar_url":"https://avatars0.githubusercontent.com/u/26871970?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-pieterse","html_url":"https://github.com/dirk-pieterse","followers_url":"https://api.github.com/users/dirk-pieterse/followers","following_url":"https://api.github.com/users/dirk-pieterse/following{/other_user}","gists_url":"https://api.github.com/users/dirk-pieterse/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-pieterse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-pieterse/subscriptions","organizations_url":"https://api.github.com/users/dirk-pieterse/orgs","repos_url":"https://api.github.com/users/dirk-pieterse/repos","events_url":"https://api.github.com/users/dirk-pieterse/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-pieterse/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nTo accept the change and keep the cursor at the same position, open the **Accept** drop-down menu and select **Accept This Change**.\r\n```","created_at":"2019-11-07T14:37:04Z","updated_at":"2019-11-07T14:47:12Z","html_url":"https://github.com/DevExpress/dotnet-eud/pull/94#discussion_r343683589","pull_request_url":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/94","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/comments/343683589"},"html":{"href":"https://github.com/DevExpress/dotnet-eud/pull/94#discussion_r343683589"},"pull_request":{"href":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/94","id":337956263,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM3OTU2MjYz","html_url":"https://github.com/DevExpress/dotnet-eud/pull/94","diff_url":"https://github.com/DevExpress/dotnet-eud/pull/94.diff","patch_url":"https://github.com/DevExpress/dotnet-eud/pull/94.patch","issue_url":"https://api.github.com/repos/DevExpress/dotnet-eud/issues/94","number":94,"state":"open","locked":false,"title":"track changes","user":{"login":"geumjaLee","id":28955238,"node_id":"MDQ6VXNlcjI4OTU1MjM4","avatar_url":"https://avatars1.githubusercontent.com/u/28955238?v=4","gravatar_id":"","url":"https://api.github.com/users/geumjaLee","html_url":"https://github.com/geumjaLee","followers_url":"https://api.github.com/users/geumjaLee/followers","following_url":"https://api.github.com/users/geumjaLee/following{/other_user}","gists_url":"https://api.github.com/users/geumjaLee/gists{/gist_id}","starred_url":"https://api.github.com/users/geumjaLee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geumjaLee/subscriptions","organizations_url":"https://api.github.com/users/geumjaLee/orgs","repos_url":"https://api.github.com/users/geumjaLee/repos","events_url":"https://api.github.com/users/geumjaLee/events{/privacy}","received_events_url":"https://api.github.com/users/geumjaLee/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-07T10:09:36Z","updated_at":"2019-11-07T14:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"134ec8e30140f3a78c5c6b74536cdbda5195acdf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/94/commits","review_comments_url":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/94/comments","review_comment_url":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevExpress/dotnet-eud/issues/94/comments","statuses_url":"https://api.github.com/repos/DevExpress/dotnet-eud/statuses/aeb44ffb0869ff912730b091a4cfd1398a78fba7","head":{"label":"geumjaLee:master","ref":"master","sha":"aeb44ffb0869ff912730b091a4cfd1398a78fba7","user":{"login":"geumjaLee","id":28955238,"node_id":"MDQ6VXNlcjI4OTU1MjM4","avatar_url":"https://avatars1.githubusercontent.com/u/28955238?v=4","gravatar_id":"","url":"https://api.github.com/users/geumjaLee","html_url":"https://github.com/geumjaLee","followers_url":"https://api.github.com/users/geumjaLee/followers","following_url":"https://api.github.com/users/geumjaLee/following{/other_user}","gists_url":"https://api.github.com/users/geumjaLee/gists{/gist_id}","starred_url":"https://api.github.com/users/geumjaLee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geumjaLee/subscriptions","organizations_url":"https://api.github.com/users/geumjaLee/orgs","repos_url":"https://api.github.com/users/geumjaLee/repos","events_url":"https://api.github.com/users/geumjaLee/events{/privacy}","received_events_url":"https://api.github.com/users/geumjaLee/received_events","type":"User","site_admin":false},"repo":{"id":158199767,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgxOTk3Njc=","name":"dotnet-eud","full_name":"geumjaLee/dotnet-eud","private":false,"owner":{"login":"geumjaLee","id":28955238,"node_id":"MDQ6VXNlcjI4OTU1MjM4","avatar_url":"https://avatars1.githubusercontent.com/u/28955238?v=4","gravatar_id":"","url":"https://api.github.com/users/geumjaLee","html_url":"https://github.com/geumjaLee","followers_url":"https://api.github.com/users/geumjaLee/followers","following_url":"https://api.github.com/users/geumjaLee/following{/other_user}","gists_url":"https://api.github.com/users/geumjaLee/gists{/gist_id}","starred_url":"https://api.github.com/users/geumjaLee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geumjaLee/subscriptions","organizations_url":"https://api.github.com/users/geumjaLee/orgs","repos_url":"https://api.github.com/users/geumjaLee/repos","events_url":"https://api.github.com/users/geumjaLee/events{/privacy}","received_events_url":"https://api.github.com/users/geumjaLee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/geumjaLee/dotnet-eud","description":".NET Controls End-User Documentation","fork":true,"url":"https://api.github.com/repos/geumjaLee/dotnet-eud","forks_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/forks","keys_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/teams","hooks_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/hooks","issue_events_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/issues/events{/number}","events_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/events","assignees_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/assignees{/user}","branches_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/branches{/branch}","tags_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/tags","blobs_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/git/refs{/sha}","trees_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/statuses/{sha}","languages_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/languages","stargazers_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/stargazers","contributors_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/contributors","subscribers_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/subscribers","subscription_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/subscription","commits_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/commits{/sha}","git_commits_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/git/commits{/sha}","comments_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/comments{/number}","issue_comment_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/issues/comments{/number}","contents_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/contents/{+path}","compare_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/merges","archive_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/downloads","issues_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/issues{/number}","pulls_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/pulls{/number}","milestones_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/milestones{/number}","notifications_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/labels{/name}","releases_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/releases{/id}","deployments_url":"https://api.github.com/repos/geumjaLee/dotnet-eud/deployments","created_at":"2018-11-19T10:02:52Z","updated_at":"2019-11-07T10:08:24Z","pushed_at":"2019-11-07T10:08:22Z","git_url":"git://github.com/geumjaLee/dotnet-eud.git","ssh_url":"git@github.com:geumjaLee/dotnet-eud.git","clone_url":"https://github.com/geumjaLee/dotnet-eud.git","svn_url":"https://github.com/geumjaLee/dotnet-eud","homepage":"https://devexpress.github.io/dotnet-eud/","size":150567,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DevExpress:master","ref":"master","sha":"1f21e21dd945b117e389c8c1ec1bdd3587ecdcaf","user":{"login":"DevExpress","id":4243232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMyMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":96305547,"node_id":"MDEwOlJlcG9zaXRvcnk5NjMwNTU0Nw==","name":"dotnet-eud","full_name":"DevExpress/dotnet-eud","private":false,"owner":{"login":"DevExpress","id":4243232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMyMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DevExpress/dotnet-eud","description":".NET Controls End-User Documentation","fork":false,"url":"https://api.github.com/repos/DevExpress/dotnet-eud","forks_url":"https://api.github.com/repos/DevExpress/dotnet-eud/forks","keys_url":"https://api.github.com/repos/DevExpress/dotnet-eud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevExpress/dotnet-eud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevExpress/dotnet-eud/teams","hooks_url":"https://api.github.com/repos/DevExpress/dotnet-eud/hooks","issue_events_url":"https://api.github.com/repos/DevExpress/dotnet-eud/issues/events{/number}","events_url":"https://api.github.com/repos/DevExpress/dotnet-eud/events","assignees_url":"https://api.github.com/repos/DevExpress/dotnet-eud/assignees{/user}","branches_url":"https://api.github.com/repos/DevExpress/dotnet-eud/branches{/branch}","tags_url":"https://api.github.com/repos/DevExpress/dotnet-eud/tags","blobs_url":"https://api.github.com/repos/DevExpress/dotnet-eud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevExpress/dotnet-eud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevExpress/dotnet-eud/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevExpress/dotnet-eud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevExpress/dotnet-eud/statuses/{sha}","languages_url":"https://api.github.com/repos/DevExpress/dotnet-eud/languages","stargazers_url":"https://api.github.com/repos/DevExpress/dotnet-eud/stargazers","contributors_url":"https://api.github.com/repos/DevExpress/dotnet-eud/contributors","subscribers_url":"https://api.github.com/repos/DevExpress/dotnet-eud/subscribers","subscription_url":"https://api.github.com/repos/DevExpress/dotnet-eud/subscription","commits_url":"https://api.github.com/repos/DevExpress/dotnet-eud/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevExpress/dotnet-eud/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevExpress/dotnet-eud/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevExpress/dotnet-eud/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevExpress/dotnet-eud/contents/{+path}","compare_url":"https://api.github.com/repos/DevExpress/dotnet-eud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevExpress/dotnet-eud/merges","archive_url":"https://api.github.com/repos/DevExpress/dotnet-eud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevExpress/dotnet-eud/downloads","issues_url":"https://api.github.com/repos/DevExpress/dotnet-eud/issues{/number}","pulls_url":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls{/number}","milestones_url":"https://api.github.com/repos/DevExpress/dotnet-eud/milestones{/number}","notifications_url":"https://api.github.com/repos/DevExpress/dotnet-eud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevExpress/dotnet-eud/labels{/name}","releases_url":"https://api.github.com/repos/DevExpress/dotnet-eud/releases{/id}","deployments_url":"https://api.github.com/repos/DevExpress/dotnet-eud/deployments","created_at":"2017-07-05T10:04:47Z","updated_at":"2019-11-05T12:56:43Z","pushed_at":"2019-11-07T11:23:15Z","git_url":"git://github.com/DevExpress/dotnet-eud.git","ssh_url":"git@github.com:DevExpress/dotnet-eud.git","clone_url":"https://github.com/DevExpress/dotnet-eud.git","svn_url":"https://github.com/DevExpress/dotnet-eud","homepage":"https://devexpress.github.io/dotnet-eud/","size":311435,"stargazers_count":45,"watchers_count":45,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":35,"open_issues":2,"watchers":45,"default_branch":"19.1"}},"_links":{"self":{"href":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/94"},"html":{"href":"https://github.com/DevExpress/dotnet-eud/pull/94"},"issue":{"href":"https://api.github.com/repos/DevExpress/dotnet-eud/issues/94"},"comments":{"href":"https://api.github.com/repos/DevExpress/dotnet-eud/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevExpress/dotnet-eud/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/DevExpress/dotnet-eud/statuses/aeb44ffb0869ff912730b091a4cfd1398a78fba7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 96305547,
"name": "DevExpress/dotnet-eud",
"url": "https://api.github.com/repos/DevExpress/dotnet-eud"
}
|
{
"id": 26871970,
"login": "dirk-pieterse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26871970?",
"url": "https://api.github.com/users/dirk-pieterse"
}
|
{
"id": 4243232,
"login": "DevExpress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4243232?",
"url": "https://api.github.com/orgs/DevExpress"
}
| 2019-11-07T14:37:04 |
10810469078
|
{"actor":{"display_login":"dirk-pieterse"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments/267047702","pull_request_review_id":216356381,"id":267047702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzA0NzcwMg==","diff_hunk":"@@ -0,0 +1,393 @@\n+// Copyright 2018, Oracle Corporation and/or its affiliates. All rights reserved.\n+// Licensed under the Universal Permissive License v 1.0 as shown at\n+// http://oss.oracle.com/licenses/upl.\n+\n+package oracle.kubernetes.operator;\n+\n+import java.util.HashMap;\n+import java.util.Map;\n+import java.util.regex.Matcher;\n+import java.util.regex.Pattern;\n+import oracle.kubernetes.operator.utils.Domain;\n+import oracle.kubernetes.operator.utils.ExecCommand;\n+import oracle.kubernetes.operator.utils.ExecResult;\n+import oracle.kubernetes.operator.utils.Operator;\n+import oracle.kubernetes.operator.utils.TestUtils;\n+import org.junit.AfterClass;\n+import org.junit.Assume;\n+import org.junit.BeforeClass;\n+import org.junit.FixMethodOrder;\n+import org.junit.Ignore;\n+import org.junit.Test;\n+import org.junit.runners.MethodSorters;\n+\n+/**\n+ * Simple JUnit test file used for testing Operator.\n+ *\n+ * <p>This test is used for creating Operator(s) and domain(s) which are managed by the Operator(s).\n+ * And to test WLS Session Migration feature\n+ */\n+@FixMethodOrder(MethodSorters.NAME_ASCENDING)\n+public class ITSessionMigration extends BaseTest {\n+\n+ // property file used to customize operator properties for operator inputs yaml\n+ private static String operatorYmlFile = \"operator1.yaml\";\n+\n+ // file used to customize domain properties for domain, PV and LB inputs yaml\n+ private static String domainonpvwlstFile = \"domainonpvwlst.yaml\";\n+\n+ // property file used to configure constants for integration tests\n+ private static String appPropsFile = \"OperatorIT.properties\";\n+\n+ private static final String TESTAPPNAME = \"httpsessionreplication\";\n+ private static Map<String, String> httpAttrMap;\n+\n+ private static String httpHeaderFile;\n+\n+ private static Operator operator;\n+ private static Domain domain;\n+\n+ private static boolean QUICKTEST;\n+ private static boolean SMOKETEST;\n+ private static boolean JENKINS;\n+ private static boolean INGRESSPERDOMAIN = true;\n+\n+ // Set QUICKTEST env var to true to run a small subset of tests.\n+ // Set SMOKETEST env var to true to run an even smaller subset\n+ // of tests, plus leave domain1 up and running when the test completes.\n+ // set INGRESSPERDOMAIN to false to create LB's ingress by kubectl yaml file\n+ static {\n+ QUICKTEST =\n+ System.getenv(\"QUICKTEST\") != null && System.getenv(\"QUICKTEST\").equalsIgnoreCase(\"true\");\n+ SMOKETEST =\n+ System.getenv(\"SMOKETEST\") != null && System.getenv(\"SMOKETEST\").equalsIgnoreCase(\"true\");\n+ if (SMOKETEST) QUICKTEST = true;\n+ if (System.getenv(\"JENKINS\") != null) {\n+ JENKINS = new Boolean(System.getenv(\"JENKINS\")).booleanValue();\n+ }\n+ if (System.getenv(\"INGRESSPERDOMAIN\") != null) {\n+ INGRESSPERDOMAIN = new Boolean(System.getenv(\"INGRESSPERDOMAIN\")).booleanValue();\n+ }\n+ }\n+\n+ /**\n+ * This method gets called only once before any of the test methods are executed. It does the\n+ * initialization of the integration test properties defined in OperatorIT.properties and setting\n+ * the resultRoot, pvRoot and projectRoot attributes.\n+ *\n+ * <p>It also create operator and verify its deployed successfully. Create domain and verify\n+ * domain is created.\n+ *\n+ * @throws Exception\n+ */\n+ @BeforeClass\n+ public static void staticPrepare() throws Exception {\n+ if (!QUICKTEST) {\n+ // initialize test properties and create the directories\n+ initialize(appPropsFile);\n+\n+ // create operator1\n+ if (operator == null) {\n+ logger.info(\"Creating Operator & waiting for the script to complete execution\");\n+ operator = TestUtils.createOperator(operatorYmlFile);\n+ }\n+\n+ // create domain\n+ if (domain == null) {\n+ logger.info(\"Creating WLS Domain & waiting for the script to complete execution\");\n+ domain = TestUtils.createDomain(domainonpvwlstFile);\n+ domain.verifyDomainCreated();\n+\n+ domain.deployWebAppViaREST(\n+ TESTAPPNAME,\n+ BaseTest.getProjectRoot() + \"/src/integration-tests/apps/httpsessionreplication.war\",\n+ BaseTest.getUsername(),\n+ BaseTest.getPassword());\n+\n+ // wait sometime for deployment gets ready\n+ Thread.sleep(30 * 1000);\n+\n+ httpHeaderFile = BaseTest.getResultDir() + \"/headers\";\n+\n+ httpAttrMap = new HashMap<String, String>();\n+ httpAttrMap.put(\"sessioncreatetime\", \"(.*)sessioncreatetime>(.*)</sessioncreatetime(.*)\");\n+ httpAttrMap.put(\"sessionid\", \"(.*)sessionid>(.*)</sessionid(.*)\");\n+ httpAttrMap.put(\"primary\", \"(.*)primary>(.*)</primary(.*)\");\n+ httpAttrMap.put(\"secondary\", \"(.*)secondary>(.*)</secondary(.*)\");\n+ httpAttrMap.put(\"count\", \"(.*)countattribute>(.*)</countattribute(.*)\");\n+ }\n+ }\n+ }\n+\n+ /**\n+ * Releases k8s cluster lease, archives result, pv directories\n+ *\n+ * @throws Exception\n+ */\n+ @AfterClass\n+ public static void staticUnPrepare() throws Exception {\n+ if (!QUICKTEST) {\n+ logger.info(\"++++++++++++++++++++++++++++++++++\");\n+ logger.info(\"BEGIN\");\n+ logger.info(\"Run once, release cluster lease\");\n+\n+ tearDown();\n+\n+ logger.info(\"SUCCESS\");\n+ }\n+ }\n+\n+ /**\n+ * verify that after the primary server shutdown, a new and running managed server is picked up as\n+ * the primary server\n+ *\n+ * @throws Exception\n+ */\n+ @Test\n+ public void testRepickPrimary() throws Exception {\n+ Assume.assumeFalse(QUICKTEST);\n+ String testMethodName = new Object() {}.getClass().getEnclosingMethod().getName();\n+ logTestBegin(testMethodName);\n+\n+ Map<String, Object> domainMap = domain.getDomainMap();\n+ String domainNS = domainMap.get(\"namespace\").toString();\n+ String domainUid = domain.getDomainUid();\n+\n+ String testAppPath = TESTAPPNAME + \"/CounterServlet\";\n+ String sessCreateTime = \"sessioncreatetime\";\n+ String primaryServ = \"primary\";\n+\n+ // Send the 1st HTTP request and save http header/sessionID info\n+ logger.info(\"Send the first HTTP request to query Primary server name.\");\n+ String curlSaveHttpHeader = \" -D \" + httpHeaderFile;\n+ String curlCmd = buildWebServiceUrl(testAppPath, curlSaveHttpHeader);\n+ ExecResult result = execCurlCmd(curlCmd);\n+ // logger.info(\"HTTP resp bf promary server is stopped:\\n \" + result.stdout());\n+\n+ // get primary server name & session create time bf primaryServName1 is stopped\n+ String primaryServName1 = getHttpResponseAttribute(result.stdout(), primaryServ);\n+ String sessCreateTime1 = getHttpResponseAttribute(result.stdout(), sessCreateTime);\n+ logger.info(\"Primary server before is: \" + primaryServName1);\n+ logger.info(\"Session created time before is: \" + sessCreateTime1);\n+\n+ // stop primary server\n+ // TODO this doesn't work. need to file a bug\n+ // domain.shutdownManagedServerUsingServerStartPolicy(primaryServName1);\n+ String msPodName = domainUid + \"-\" + primaryServName1;\n+ String cmd = \"kubectl delete po/\" + msPodName + \" -n \" + domainNS;\n+ logger.info(\"Stop managed server <\" + primaryServName1 + \"> using command:\\n\" + cmd);\n+ result = ExecCommand.exec(cmd);\n+ logger.info(result.stdout());\n+\n+ // Send the 2nd HTTP request by use http header/sessionID info save before\n+ logger.info(\"Send the second HTTP request to query Primary server name.\");\n+ String curlUseHttpHeader = \" -b \" + httpHeaderFile;\n+ curlCmd = buildWebServiceUrl(testAppPath, curlUseHttpHeader);\n+ result = execCurlCmd(curlCmd);\n+ // logger.info(\"HTTP resp af promary server is stopped:\\n \" + result.stdout());\n+\n+ // get primary server name & session create time af primaryServName1 is stopped\n+ String primaryServName2 = getHttpResponseAttribute(result.stdout(), primaryServ);\n+ String sessCreateTime2 = getHttpResponseAttribute(result.stdout(), sessCreateTime);\n+ logger.info(\"Primary server after is: \" + primaryServName2);\n+ logger.info(\"Session created time after is: \" + sessCreateTime2);\n+\n+ // verify that the same session info is used\n+ Assume.assumeTrue(\"HTTP Session should NOT change!\", sessCreateTime1.equals(sessCreateTime2));\n+\n+ // verify that a new primary server is picked\n+ Assume.assumeFalse(\n+ \"A new primary server should be picked!\",\n+ primaryServName1.trim().equals(primaryServName2.trim()));\n+\n+ // restore test env\n+ // TODO will use this when it works\n+ // domain.restartManagedServerUsingServerStartPolicy(primaryServName1);\n+ // wait sometime for ms pod gets ready\n+ Thread.sleep(30 * 1000);\n+ TestUtils.checkPodCreated(domainUid + \"-\" + primaryServName1, domainNS);\n+ TestUtils.checkPodReady(domainUid + \"-\" + primaryServName1, domainNS);\n+\n+ logger.info(\"SUCCESS - \" + testMethodName + \". ms <\" + primaryServName2 + \"> now is primary.\");\n+ }\n+\n+ /**\n+ * verify that after the primary server shutdown, HTTP session state is migrated to the new\n+ * primary server\n+ *\n+ * @throws Exception\n+ */\n+ @Test\n+ public void testHttpSessionMigr() throws Exception {\n+ Assume.assumeFalse(QUICKTEST);\n+ String testMethodName = new Object() {}.getClass().getEnclosingMethod().getName();\n+ logTestBegin(testMethodName);\n+\n+ Map<String, Object> domainMap = domain.getDomainMap();\n+ String domainNS = domainMap.get(\"namespace\").toString();\n+ String domainUid = domain.getDomainUid();\n+\n+ int counterNum = 4;\n+ String testAppPath = TESTAPPNAME + \"/CounterServlet\";\n+ String webServiceSetUrl = testAppPath + \"?setCounter=\" + counterNum;\n+ String webServiceGetUrl = testAppPath + \"?getCounter\";\n+\n+ String primaryServ = \"primary\";\n+ String count = \"count\";\n+\n+ // Send the 1st HTTP request and save http header/sessionID info\n+ logger.info(\"Send the first HTTP request to set a count number.\");\n+ String curlSaveHttpHeader = \" -D \" + httpHeaderFile;\n+ String curlCmd = buildWebServiceUrl(webServiceSetUrl, curlSaveHttpHeader);\n+ ExecResult result = execCurlCmd(curlCmd);\n+ // logger.info(\"HTTP resp bf promary server is stopped:\\n \" + result.stdout());\n+\n+ // get primary server name & count number bf primaryServName1 is stopped\n+ String primaryServName1 = getHttpResponseAttribute(result.stdout(), primaryServ);\n+ String countattribute1 = getHttpResponseAttribute(result.stdout(), count);\n+ logger.info(\"Primary server before is: \" + primaryServName1);\n+ logger.info(\"count is set to: \" + countattribute1);\n+\n+ // stop primary server\n+ // TODO this doesn't work. need to file a bug\n+ // domain.shutdownManagedServerUsingServerStartPolicy(primaryServName1);\n+ String msPodName = domainUid + \"-\" + primaryServName1;\n+ String cmd = \"kubectl delete po/\" + msPodName + \" -n \" + domainNS;\n+ logger.info(\"Stop managed server <\" + msPodName + \"> using command:\\n\" + cmd);\n+ result = ExecCommand.exec(cmd);\n+ logger.info(result.stdout());\n+\n+ // Send the 2nd HTTP request by use http header/sessionID info save before\n+ logger.info(\"Send the second HTTP request to get a count number.\");\n+ String curlUseHttpHeader = \" -b \" + httpHeaderFile;\n+ curlCmd = buildWebServiceUrl(webServiceGetUrl, curlUseHttpHeader);\n+ result = execCurlCmd(curlCmd);\n+ // logger.info(\"HTTP response af promary server is stopped: \\n\" + result.stdout());\n+\n+ // get primary server name & count number af primaryServName1 is stopped\n+ String primaryServName2 = getHttpResponseAttribute(result.stdout(), primaryServ);\n+ String countattribute2 = getHttpResponseAttribute(result.stdout(), count);\n+\n+ logger.info(\"Primary server after is: \" + primaryServName2);\n+ logger.info(\"Get count: \" + countattribute2);\n+\n+ // verify that the count number is from a new primary server\n+ Assume.assumeFalse(\n+ \"A new primary server should be picked!\",\n+ primaryServName1.trim().equals(primaryServName2.trim()));\n+\n+ // verify that HTTP session state is migrated by checking the count number same\n+ // bf and af primaryServName1 stopped\n+ Assume.assumeTrue(\n+ \"HTTP session state is NOT migrated!\", countattribute1.equals(countattribute2));\n+\n+ // restore test env\n+ // TODO will use this when it works\n+ // domain.restartManagedServerUsingServerStartPolicy(primaryServName1);\n+ // wait sometime for ms pod gets ready\n+ Thread.sleep(30 * 1000);\n+ TestUtils.checkPodCreated(domainUid + \"-\" + primaryServName1, domainNS);\n+ TestUtils.checkPodReady(domainUid + \"-\" + primaryServName1, domainNS);\n+\n+ logger.info(\"SUCCESS - \" + testMethodName + \". HTTP session state is migrated!\");\n+ }\n+\n+ @Ignore\n+ @Test\n+ public void myTest1() throws Exception {\n+ Assume.assumeFalse(QUICKTEST);\n+ Map<String, Object> domainMap = domain.getDomainMap();\n+ String domainNS = domainMap.get(\"namespace\").toString();\n+\n+ domain.shutdownManagedServerUsingServerStartPolicy(\"managed-server2\");\n+ TestUtils.checkPodDeleted(\"domainonpvwlst-managed-server2\", domainNS);\n+ }\n+\n+ @Ignore\n+ @Test\n+ public void myTest2() throws Exception {\n+ Assume.assumeFalse(QUICKTEST);\n+ Map<String, Object> domainMap = domain.getDomainMap();\n+ String domainNS = domainMap.get(\"namespace\").toString();\n+\n+ domain.shutdownManagedServerUsingServerStartPolicy(\"domainonpvwlst-managed-server1\");\n+ TestUtils.checkPodDeleted(\"domainonpvwlst-managed-server1\", domainNS);\n+ }\n+\n+ /**\n+ * build\n+ *\n+ * @throws Exception\n+ */\n+ private String getHttpResponseAttribute(String httpResponseString, String attribute)\n+ throws Exception {\n+ // logger.info(\"Looking for <\" + attribute + \"> in\\n \" + httpResponseString);\n+ String attrPatn = httpAttrMap.get(attribute);\n+\n+ Assume.assumeNotNull(attrPatn);\n+\n+ String httpAttribute = null;\n+\n+ Pattern pattern = Pattern.compile(attrPatn);\n+ Matcher matcher = pattern.matcher(httpResponseString);\n+ if (matcher.find()) {\n+ httpAttribute = matcher.group(2);\n+ }\n+\n+ // logger.info(\"Value for HTTP attribute found.: \" + attribute + \" = \" + httpAttribute);\n+\n+ return httpAttribute;\n+ }\n+\n+ /**\n+ * build\n+ *\n+ * @throws Exception\n+ */\n+ private String buildWebServiceUrl(String curlURLPath, String paramToAppend) throws Exception {\n+ String nodePortHost = domain.getHostNameForCurl();\n+ int nodePort = domain.getLoadBalancerWebPort();\n+\n+ StringBuffer webServiceUrl = new StringBuffer(\"curl --silent \");\n+ webServiceUrl\n+ .append(\" -H 'host: \")\n+ .append(domain.getDomainUid())\n+ .append(\".org' \")\n+ .append(\" http://\")\n+ .append(nodePortHost)\n+ .append(\":\")\n+ .append(nodePort)\n+ .append(\"/\")\n+ .append(curlURLPath)\n+ .append(paramToAppend);\n+\n+ logger.info(\"Built web service url: \" + webServiceUrl);\n+\n+ return webServiceUrl.toString();\n+ }\n+\n+ /**\n+ * build\n+ *\n+ * @throws Exception\n+ */\n+ private ExecResult execCurlCmd(String curlCmd) throws Exception {\n+ logger.info(\"curl command to exec is:\\n\" + curlCmd);\n+\n+ ExecResult result = ExecCommand.exec(curlCmd);\n+\n+ if (result.exitValue() != 0) {\n+ throw new RuntimeException(","path":"integration-tests/src/test/java/oracle/kubernetes/operator/ITSessionMigration.java","position":380,"original_position":380,"commit_id":"cdeb88c2732c0ba200b9010dafca3a0763f60de9","original_commit_id":"cdeb88c2732c0ba200b9010dafca3a0763f60de9","user":{"login":"hzhao-github","id":41090416,"node_id":"MDQ6VXNlcjQxMDkwNDE2","avatar_url":"https://avatars2.githubusercontent.com/u/41090416?v=4","gravatar_id":"","url":"https://api.github.com/users/hzhao-github","html_url":"https://github.com/hzhao-github","followers_url":"https://api.github.com/users/hzhao-github/followers","following_url":"https://api.github.com/users/hzhao-github/following{/other_user}","gists_url":"https://api.github.com/users/hzhao-github/gists{/gist_id}","starred_url":"https://api.github.com/users/hzhao-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzhao-github/subscriptions","organizations_url":"https://api.github.com/users/hzhao-github/orgs","repos_url":"https://api.github.com/users/hzhao-github/repos","events_url":"https://api.github.com/users/hzhao-github/events{/privacy}","received_events_url":"https://api.github.com/users/hzhao-github/received_events","type":"User","site_admin":false},"body":"changed to throw new Exception","created_at":"2019-03-19T18:52:06Z","updated_at":"2019-03-19T18:52:06Z","html_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/950#discussion_r267047702","pull_request_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/950","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments/267047702"},"html":{"href":"https://github.com/oracle/weblogic-kubernetes-operator/pull/950#discussion_r267047702"},"pull_request":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/950"}},"in_reply_to_id":267002585},"pull_request":{"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/950","id":262271846,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyMjcxODQ2","html_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/950","diff_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/950.diff","patch_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/950.patch","issue_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/950","number":950,"state":"open","locked":false,"title":"WIP: Completed JIRA OWLS-71984 - Migrate Session Migration test suite to GitHub","user":{"login":"hzhao-github","id":41090416,"node_id":"MDQ6VXNlcjQxMDkwNDE2","avatar_url":"https://avatars2.githubusercontent.com/u/41090416?v=4","gravatar_id":"","url":"https://api.github.com/users/hzhao-github","html_url":"https://github.com/hzhao-github","followers_url":"https://api.github.com/users/hzhao-github/followers","following_url":"https://api.github.com/users/hzhao-github/following{/other_user}","gists_url":"https://api.github.com/users/hzhao-github/gists{/gist_id}","starred_url":"https://api.github.com/users/hzhao-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzhao-github/subscriptions","organizations_url":"https://api.github.com/users/hzhao-github/orgs","repos_url":"https://api.github.com/users/hzhao-github/repos","events_url":"https://api.github.com/users/hzhao-github/events{/privacy}","received_events_url":"https://api.github.com/users/hzhao-github/received_events","type":"User","site_admin":false},"body":"Created on GitHub the first time","created_at":"2019-03-19T00:29:57Z","updated_at":"2019-03-19T18:52:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"759bfd50bc417f045eeda1450ff7376a7e70e1a0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"marinakog","id":27022987,"node_id":"MDQ6VXNlcjI3MDIyOTg3","avatar_url":"https://avatars1.githubusercontent.com/u/27022987?v=4","gravatar_id":"","url":"https://api.github.com/users/marinakog","html_url":"https://github.com/marinakog","followers_url":"https://api.github.com/users/marinakog/followers","following_url":"https://api.github.com/users/marinakog/following{/other_user}","gists_url":"https://api.github.com/users/marinakog/gists{/gist_id}","starred_url":"https://api.github.com/users/marinakog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marinakog/subscriptions","organizations_url":"https://api.github.com/users/marinakog/orgs","repos_url":"https://api.github.com/users/marinakog/repos","events_url":"https://api.github.com/users/marinakog/events{/privacy}","received_events_url":"https://api.github.com/users/marinakog/received_events","type":"User","site_admin":false},{"login":"anpanigr","id":31135902,"node_id":"MDQ6VXNlcjMxMTM1OTAy","avatar_url":"https://avatars0.githubusercontent.com/u/31135902?v=4","gravatar_id":"","url":"https://api.github.com/users/anpanigr","html_url":"https://github.com/anpanigr","followers_url":"https://api.github.com/users/anpanigr/followers","following_url":"https://api.github.com/users/anpanigr/following{/other_user}","gists_url":"https://api.github.com/users/anpanigr/gists{/gist_id}","starred_url":"https://api.github.com/users/anpanigr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anpanigr/subscriptions","organizations_url":"https://api.github.com/users/anpanigr/orgs","repos_url":"https://api.github.com/users/anpanigr/repos","events_url":"https://api.github.com/users/anpanigr/events{/privacy}","received_events_url":"https://api.github.com/users/anpanigr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/950/commits","review_comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/950/comments","review_comment_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/950/comments","statuses_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/cdeb88c2732c0ba200b9010dafca3a0763f60de9","head":{"label":"oracle:session-migration-tests","ref":"session-migration-tests","sha":"cdeb88c2732c0ba200b9010dafca3a0763f60de9","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":113222463,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyMjI0NjM=","name":"weblogic-kubernetes-operator","full_name":"oracle/weblogic-kubernetes-operator","private":false,"owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oracle/weblogic-kubernetes-operator","description":"Oracle Weblogic Server Kubernetes Operator","fork":false,"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator","forks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/forks","keys_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/teams","hooks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/hooks","issue_events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/events","assignees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/tags","blobs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/languages","stargazers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/stargazers","contributors_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contributors","subscribers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscribers","subscription_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscription","commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/merges","archive_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/downloads","issues_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/labels{/name}","releases_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/deployments","created_at":"2017-12-05T19:11:06Z","updated_at":"2019-03-19T18:37:05Z","pushed_at":"2019-03-19T18:50:35Z","git_url":"git://github.com/oracle/weblogic-kubernetes-operator.git","ssh_url":"git@github.com:oracle/weblogic-kubernetes-operator.git","clone_url":"https://github.com/oracle/weblogic-kubernetes-operator.git","svn_url":"https://github.com/oracle/weblogic-kubernetes-operator","homepage":"","size":53555,"stargazers_count":98,"watchers_count":98,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":87,"open_issues":31,"watchers":98,"default_branch":"master"}},"base":{"label":"oracle:develop","ref":"develop","sha":"7065237332ef0b7f94966a5a69ad48cb37caf84e","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":113222463,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyMjI0NjM=","name":"weblogic-kubernetes-operator","full_name":"oracle/weblogic-kubernetes-operator","private":false,"owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oracle/weblogic-kubernetes-operator","description":"Oracle Weblogic Server Kubernetes Operator","fork":false,"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator","forks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/forks","keys_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/teams","hooks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/hooks","issue_events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/events","assignees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/tags","blobs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/languages","stargazers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/stargazers","contributors_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contributors","subscribers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscribers","subscription_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscription","commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/merges","archive_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/downloads","issues_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/labels{/name}","releases_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/deployments","created_at":"2017-12-05T19:11:06Z","updated_at":"2019-03-19T18:37:05Z","pushed_at":"2019-03-19T18:50:35Z","git_url":"git://github.com/oracle/weblogic-kubernetes-operator.git","ssh_url":"git@github.com:oracle/weblogic-kubernetes-operator.git","clone_url":"https://github.com/oracle/weblogic-kubernetes-operator.git","svn_url":"https://github.com/oracle/weblogic-kubernetes-operator","homepage":"","size":53555,"stargazers_count":98,"watchers_count":98,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":87,"open_issues":31,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/950"},"html":{"href":"https://github.com/oracle/weblogic-kubernetes-operator/pull/950"},"issue":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/950"},"comments":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/950/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/950/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/950/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/cdeb88c2732c0ba200b9010dafca3a0763f60de9"}},"author_association":"MEMBER"}}
|
{
"id": 113222463,
"name": "oracle/weblogic-kubernetes-operator",
"url": "https://api.github.com/repos/oracle/weblogic-kubernetes-operator"
}
|
{
"id": 41090416,
"login": "hzhao-github",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41090416?",
"url": "https://api.github.com/users/hzhao-github"
}
|
{
"id": 4430336,
"login": "oracle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4430336?",
"url": "https://api.github.com/orgs/oracle"
}
| 2019-03-19T18:52:06 |
9274066157
|
{"actor":{"display_login":"hzhao-github"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/graal/pulls/comments/308604722","pull_request_review_id":268244217,"id":308604722,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODYwNDcyMg==","diff_hunk":"@@ -0,0 +1,178 @@\n+/*\n+ * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.\n+ * Copyright (c) 2019, Arm Limited and affiliates. All rights reserved.\n+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.\n+ *\n+ * This code is free software; you can redistribute it and/or modify it\n+ * under the terms of the GNU General Public License version 2 only, as\n+ * published by the Free Software Foundation. Oracle designates this\n+ * particular file as subject to the \"Classpath\" exception as provided\n+ * by Oracle in the LICENSE file that accompanied this code.\n+ *\n+ * This code is distributed in the hope that it will be useful, but WITHOUT\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License\n+ * version 2 for more details (a copy is included in the LICENSE file that\n+ * accompanied this code).\n+ *\n+ * You should have received a copy of the GNU General Public License version\n+ * 2 along with this work; if not, write to the Free Software Foundation,\n+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.\n+ *\n+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA\n+ * or visit www.oracle.com if you need additional information or have any\n+ * questions.\n+ */\n+package org.graalvm.compiler.lir.aarch64;\n+\n+import jdk.vm.ci.code.CodeUtil;\n+import jdk.vm.ci.code.Register;\n+import jdk.vm.ci.meta.AllocatableValue;\n+import org.graalvm.compiler.asm.Label;\n+import org.graalvm.compiler.asm.aarch64.AArch64Address;\n+import org.graalvm.compiler.asm.aarch64.AArch64Assembler;\n+import org.graalvm.compiler.asm.aarch64.AArch64MacroAssembler;\n+import org.graalvm.compiler.lir.LIRInstructionClass;\n+import org.graalvm.compiler.lir.Opcode;\n+import org.graalvm.compiler.lir.asm.CompilationResultBuilder;\n+\n+import static jdk.vm.ci.aarch64.AArch64.zr;\n+import static jdk.vm.ci.code.ValueUtil.asRegister;\n+import static org.graalvm.compiler.lir.LIRInstruction.OperandFlag.REG;\n+\n+/**\n+ * Zero a chunk of memory on AArch64.\n+ */\n+@Opcode(\"ZERO_MEMORY\")\n+public final class AArch64ZeroMemoryOp extends AArch64LIRInstruction {\n+ public static final LIRInstructionClass<AArch64ZeroMemoryOp> TYPE = LIRInstructionClass.create(AArch64ZeroMemoryOp.class);\n+\n+ @Use({REG}) protected AllocatableValue addressValue;\n+ @Use({REG}) protected AllocatableValue lengthValue;\n+\n+ private final boolean useDcZva; // Use DC ZVA instructions to zero memory.\n+ private final int zvaLength; // The ZVA length of current AArch64 CPU, negative value\n+ // indicates length is unknown at compile time.\n+\n+ public AArch64ZeroMemoryOp(AllocatableValue address, AllocatableValue length, boolean useDcZva, int zvaLength) {\n+ super(TYPE);\n+ this.addressValue = address;\n+ this.lengthValue = length;\n+ this.useDcZva = useDcZva;\n+ this.zvaLength = zvaLength;\n+ }\n+\n+ @Override\n+ protected void emitCode(CompilationResultBuilder crb, AArch64MacroAssembler masm) {\n+ Register base = asRegister(addressValue);\n+ Register size = asRegister(lengthValue);\n+ if (useDcZva && zvaLength > 0) {\n+ // From ARMv8-A architecture reference manual D12.2.35 Data Cache Zero ID register:\n+ // A valid ZVA length should be a power-of-2 value in [4, 2048]\n+ assert (CodeUtil.isPowerOf2(zvaLength) && 4 <= zvaLength && zvaLength <= 2048);\n+ emitZeroMemoryWithDc(masm, base, size, zvaLength);\n+ } else {\n+ // Use store pair instructions (STP) to zero memory as a fallback.\n+ emitZeroMemoryWithStp(masm, base, size);\n+ }\n+ }\n+\n+ /**\n+ * Zero a chunk of memory with DC ZVA instructions.\n+ *\n+ * @param masm the AArch64 macro assembler\n+ * @param base base an 8-byte aligned address of the memory chunk to be zeroed.\n+ * @param size size of the memory chunk to be zeroed, in bytes, must be multiple of 8.\n+ * @param zvaLength the ZVA length of current AArch64 CPU, must be power of 2.\n+ */\n+ private void emitZeroMemoryWithDc(AArch64MacroAssembler masm, Register base, Register size, int zvaLength) {\n+ // Checkstyle: stop\n+ Label PRE_LOOP = new Label();\n+ Label ZVA_LOOP = new Label();\n+ Label POST_LOOP = new Label();\n+ Label TAIL = new Label();\n+ Label DONE = new Label();","path":"compiler/src/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ZeroMemoryOp.java","position":94,"original_position":94,"commit_id":"1738d9668121a3a22661825f697e121a419fa84e","original_commit_id":"1738d9668121a3a22661825f697e121a419fa84e","user":{"login":"pli-arm","id":45187772,"node_id":"MDQ6VXNlcjQ1MTg3Nzcy","avatar_url":"https://avatars0.githubusercontent.com/u/45187772?v=4","gravatar_id":"","url":"https://api.github.com/users/pli-arm","html_url":"https://github.com/pli-arm","followers_url":"https://api.github.com/users/pli-arm/followers","following_url":"https://api.github.com/users/pli-arm/following{/other_user}","gists_url":"https://api.github.com/users/pli-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/pli-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pli-arm/subscriptions","organizations_url":"https://api.github.com/users/pli-arm/orgs","repos_url":"https://api.github.com/users/pli-arm/repos","events_url":"https://api.github.com/users/pli-arm/events{/privacy}","received_events_url":"https://api.github.com/users/pli-arm/received_events","type":"User","site_admin":false},"body":"Thanks. I will change the style.","created_at":"2019-07-30T08:49:52Z","updated_at":"2019-07-30T08:49:53Z","html_url":"https://github.com/oracle/graal/pull/1497#discussion_r308604722","pull_request_url":"https://api.github.com/repos/oracle/graal/pulls/1497","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oracle/graal/pulls/comments/308604722"},"html":{"href":"https://github.com/oracle/graal/pull/1497#discussion_r308604722"},"pull_request":{"href":"https://api.github.com/repos/oracle/graal/pulls/1497"}},"in_reply_to_id":308150667},"pull_request":{"url":"https://api.github.com/repos/oracle/graal/pulls/1497","id":297499614,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3NDk5NjE0","html_url":"https://github.com/oracle/graal/pull/1497","diff_url":"https://github.com/oracle/graal/pull/1497.diff","patch_url":"https://github.com/oracle/graal/pull/1497.patch","issue_url":"https://api.github.com/repos/oracle/graal/issues/1497","number":1497,"state":"open","locked":false,"title":"Memory bulk zeroing for AArch64","user":{"login":"pli-arm","id":45187772,"node_id":"MDQ6VXNlcjQ1MTg3Nzcy","avatar_url":"https://avatars0.githubusercontent.com/u/45187772?v=4","gravatar_id":"","url":"https://api.github.com/users/pli-arm","html_url":"https://github.com/pli-arm","followers_url":"https://api.github.com/users/pli-arm/followers","following_url":"https://api.github.com/users/pli-arm/following{/other_user}","gists_url":"https://api.github.com/users/pli-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/pli-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pli-arm/subscriptions","organizations_url":"https://api.github.com/users/pli-arm/orgs","repos_url":"https://api.github.com/users/pli-arm/repos","events_url":"https://api.github.com/users/pli-arm/events{/privacy}","received_events_url":"https://api.github.com/users/pli-arm/received_events","type":"User","site_admin":false},"body":"Current AArch64 Graal generates inefficient STR loops to zero memory of\r\nnew arrays/objects in TLAB fast path. To improve the performance of new\r\narray/object allocations, this patch implements memory bulk zeroing with\r\nAArch64 store pair (STP) and cache maintenance (DC ZVA) instructions.\r\n\r\nIn this implementation, we try to read the pre-loaded value of AArch64\r\nsystem register DCZID_EL0 from HotSpot field via JVMCI at compile-time,\r\nand generate loops with DC ZVA instruction based on the zva length. In\r\ncases that use of DC ZVA is prohibited, bulk zeroing is disabled by VM\r\noptions or the HotSpot field is unable to read, we generate bulk zeroing\r\ncode with STP instructions as a fallback.\r\n\r\nPerformance numbers of JMH case ArrayAllocationBenchmark.java:\r\n```\r\n (size) Before After Units Delta\r\n 128 12247939.660 12286886.510 ops/s ~0%\r\n 256 12779460.750 12744019.880 ops/s ~0%\r\n 512 11359980.920 11378595.970 ops/s ~0%\r\n 1024 8612579.648 8605721.524 ops/s ~0%\r\n 2048 5179105.584 5874018.934 ops/s +13.4%\r\n 4096 2910263.315 3127318.244 ops/s +7.5%\r\n 8192 1562452.712 1645597.896 ops/s +5.3%\r\n 16384 822959.316 848823.521 ops/s +3.1%\r\n 32768 421660.441 430801.295 ops/s +2.2%\r\n 65536 215829.630 215310.007 ops/s ~0%\r\n 131072 108880.555 108901.943 ops/s ~0%\r\n```\r\nWe see performance improved when the allocation size is in [2048, 32768]\r\nin this test since it hits the bulk zeroing path.","created_at":"2019-07-15T07:32:04Z","updated_at":"2019-07-30T08:49:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78531b97e1458d277cb3c04e1c5c7f24ab56959f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":770329812,"node_id":"MDU6TGFiZWw3NzAzMjk4MTI=","url":"https://api.github.com/repos/oracle/graal/labels/compiler","name":"compiler","color":"a547d1","default":false},{"id":319809836,"node_id":"MDU6TGFiZWwzMTk4MDk4MzY=","url":"https://api.github.com/repos/oracle/graal/labels/oca-signed","name":"oca-signed","color":"bfe5bf","default":false},{"id":929259064,"node_id":"MDU6TGFiZWw5MjkyNTkwNjQ=","url":"https://api.github.com/repos/oracle/graal/labels/performance","name":"performance","color":"f4abc7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/graal/pulls/1497/commits","review_comments_url":"https://api.github.com/repos/oracle/graal/pulls/1497/comments","review_comment_url":"https://api.github.com/repos/oracle/graal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/graal/issues/1497/comments","statuses_url":"https://api.github.com/repos/oracle/graal/statuses/1738d9668121a3a22661825f697e121a419fa84e","head":{"label":"pli-arm:bulkzeroing","ref":"bulkzeroing","sha":"1738d9668121a3a22661825f697e121a419fa84e","user":{"login":"pli-arm","id":45187772,"node_id":"MDQ6VXNlcjQ1MTg3Nzcy","avatar_url":"https://avatars0.githubusercontent.com/u/45187772?v=4","gravatar_id":"","url":"https://api.github.com/users/pli-arm","html_url":"https://github.com/pli-arm","followers_url":"https://api.github.com/users/pli-arm/followers","following_url":"https://api.github.com/users/pli-arm/following{/other_user}","gists_url":"https://api.github.com/users/pli-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/pli-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pli-arm/subscriptions","organizations_url":"https://api.github.com/users/pli-arm/orgs","repos_url":"https://api.github.com/users/pli-arm/repos","events_url":"https://api.github.com/users/pli-arm/events{/privacy}","received_events_url":"https://api.github.com/users/pli-arm/received_events","type":"User","site_admin":false},"repo":{"id":182182472,"node_id":"MDEwOlJlcG9zaXRvcnkxODIxODI0NzI=","name":"graal","full_name":"pli-arm/graal","private":false,"owner":{"login":"pli-arm","id":45187772,"node_id":"MDQ6VXNlcjQ1MTg3Nzcy","avatar_url":"https://avatars0.githubusercontent.com/u/45187772?v=4","gravatar_id":"","url":"https://api.github.com/users/pli-arm","html_url":"https://github.com/pli-arm","followers_url":"https://api.github.com/users/pli-arm/followers","following_url":"https://api.github.com/users/pli-arm/following{/other_user}","gists_url":"https://api.github.com/users/pli-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/pli-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pli-arm/subscriptions","organizations_url":"https://api.github.com/users/pli-arm/orgs","repos_url":"https://api.github.com/users/pli-arm/repos","events_url":"https://api.github.com/users/pli-arm/events{/privacy}","received_events_url":"https://api.github.com/users/pli-arm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pli-arm/graal","description":"GraalVM: Run Programs Faster Anywhere :rocket:","fork":true,"url":"https://api.github.com/repos/pli-arm/graal","forks_url":"https://api.github.com/repos/pli-arm/graal/forks","keys_url":"https://api.github.com/repos/pli-arm/graal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pli-arm/graal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pli-arm/graal/teams","hooks_url":"https://api.github.com/repos/pli-arm/graal/hooks","issue_events_url":"https://api.github.com/repos/pli-arm/graal/issues/events{/number}","events_url":"https://api.github.com/repos/pli-arm/graal/events","assignees_url":"https://api.github.com/repos/pli-arm/graal/assignees{/user}","branches_url":"https://api.github.com/repos/pli-arm/graal/branches{/branch}","tags_url":"https://api.github.com/repos/pli-arm/graal/tags","blobs_url":"https://api.github.com/repos/pli-arm/graal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pli-arm/graal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pli-arm/graal/git/refs{/sha}","trees_url":"https://api.github.com/repos/pli-arm/graal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pli-arm/graal/statuses/{sha}","languages_url":"https://api.github.com/repos/pli-arm/graal/languages","stargazers_url":"https://api.github.com/repos/pli-arm/graal/stargazers","contributors_url":"https://api.github.com/repos/pli-arm/graal/contributors","subscribers_url":"https://api.github.com/repos/pli-arm/graal/subscribers","subscription_url":"https://api.github.com/repos/pli-arm/graal/subscription","commits_url":"https://api.github.com/repos/pli-arm/graal/commits{/sha}","git_commits_url":"https://api.github.com/repos/pli-arm/graal/git/commits{/sha}","comments_url":"https://api.github.com/repos/pli-arm/graal/comments{/number}","issue_comment_url":"https://api.github.com/repos/pli-arm/graal/issues/comments{/number}","contents_url":"https://api.github.com/repos/pli-arm/graal/contents/{+path}","compare_url":"https://api.github.com/repos/pli-arm/graal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pli-arm/graal/merges","archive_url":"https://api.github.com/repos/pli-arm/graal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pli-arm/graal/downloads","issues_url":"https://api.github.com/repos/pli-arm/graal/issues{/number}","pulls_url":"https://api.github.com/repos/pli-arm/graal/pulls{/number}","milestones_url":"https://api.github.com/repos/pli-arm/graal/milestones{/number}","notifications_url":"https://api.github.com/repos/pli-arm/graal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pli-arm/graal/labels{/name}","releases_url":"https://api.github.com/repos/pli-arm/graal/releases{/id}","deployments_url":"https://api.github.com/repos/pli-arm/graal/deployments","created_at":"2019-04-19T01:40:56Z","updated_at":"2019-07-15T07:21:38Z","pushed_at":"2019-07-15T07:29:16Z","git_url":"git://github.com/pli-arm/graal.git","ssh_url":"git@github.com:pli-arm/graal.git","clone_url":"https://github.com/pli-arm/graal.git","svn_url":"https://github.com/pli-arm/graal","homepage":"https://www.graalvm.org","size":567058,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oracle:master","ref":"master","sha":"7598cb130feffc434a99a065daa087a28406b8a7","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":49662222,"node_id":"MDEwOlJlcG9zaXRvcnk0OTY2MjIyMg==","name":"graal","full_name":"oracle/graal","private":false,"owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oracle/graal","description":"GraalVM: Run Programs Faster Anywhere :rocket:","fork":false,"url":"https://api.github.com/repos/oracle/graal","forks_url":"https://api.github.com/repos/oracle/graal/forks","keys_url":"https://api.github.com/repos/oracle/graal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/graal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/graal/teams","hooks_url":"https://api.github.com/repos/oracle/graal/hooks","issue_events_url":"https://api.github.com/repos/oracle/graal/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/graal/events","assignees_url":"https://api.github.com/repos/oracle/graal/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/graal/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/graal/tags","blobs_url":"https://api.github.com/repos/oracle/graal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/graal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/graal/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/graal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/graal/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/graal/languages","stargazers_url":"https://api.github.com/repos/oracle/graal/stargazers","contributors_url":"https://api.github.com/repos/oracle/graal/contributors","subscribers_url":"https://api.github.com/repos/oracle/graal/subscribers","subscription_url":"https://api.github.com/repos/oracle/graal/subscription","commits_url":"https://api.github.com/repos/oracle/graal/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/graal/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/graal/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/graal/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/graal/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/graal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/graal/merges","archive_url":"https://api.github.com/repos/oracle/graal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/graal/downloads","issues_url":"https://api.github.com/repos/oracle/graal/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/graal/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/graal/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/graal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/graal/labels{/name}","releases_url":"https://api.github.com/repos/oracle/graal/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/graal/deployments","created_at":"2016-01-14T17:11:35Z","updated_at":"2019-07-30T07:04:05Z","pushed_at":"2019-07-30T07:19:40Z","git_url":"git://github.com/oracle/graal.git","ssh_url":"git@github.com:oracle/graal.git","clone_url":"https://github.com/oracle/graal.git","svn_url":"https://github.com/oracle/graal","homepage":"https://www.graalvm.org","size":746259,"stargazers_count":9793,"watchers_count":9793,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":627,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":443,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":627,"open_issues":443,"watchers":9793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/graal/pulls/1497"},"html":{"href":"https://github.com/oracle/graal/pull/1497"},"issue":{"href":"https://api.github.com/repos/oracle/graal/issues/1497"},"comments":{"href":"https://api.github.com/repos/oracle/graal/issues/1497/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/graal/pulls/1497/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/graal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/graal/pulls/1497/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/graal/statuses/1738d9668121a3a22661825f697e121a419fa84e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 49662222,
"name": "oracle/graal",
"url": "https://api.github.com/repos/oracle/graal"
}
|
{
"id": 45187772,
"login": "pli-arm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45187772?",
"url": "https://api.github.com/users/pli-arm"
}
|
{
"id": 4430336,
"login": "oracle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4430336?",
"url": "https://api.github.com/orgs/oracle"
}
| 2019-07-30T08:49:52 |
10109787096
|
{"actor":{"display_login":"pli-arm"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/helidon/pulls/comments/274090239","pull_request_review_id":225133294,"id":274090239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NDA5MDIzOQ==","diff_hunk":"@@ -287,34 +268,45 @@ public boolean hasConverter(Class<?> clazz) {\n */\n @SuppressWarnings(\"unchecked\")\n public <T> T convert(Class<T> type, String value) {\n- if (null == value) {\n+ if (value == null) {\n return null;\n }\n \n- // now check if we have local added converter for this class\n- Converter<?> maybeConverter = converters.get(mapType(type));\n-\n- if (null == maybeConverter) {\n- // ask helidon config to do appropriate transformation (built-in, implicit and classpath mappers)\n- Config c = Config.builder()\n- .disableSystemPropertiesSource()\n- .disableFilterServices()\n- .disableEnvironmentVariablesSource()\n- .sources(ConfigSources.create(CollectionsHelper.mapOf(\"key\", value)))\n- .build();\n-\n- try {\n- return c.get(\"key\").as(type).get();\n- } catch (ConfigMappingException e) {\n- throw new IllegalArgumentException(\"Failed to convert \" + value + \" to \" + type.getName(), e);\n- }\n+ // Use a local converter for this class if we have one\n+ final Converter<?> converter = converters.get(type);\n+ if (null != converter) {","path":"microprofile/config/config/src/main/java/io/helidon/microprofile/config/MpConfig.java","position":142,"original_position":142,"commit_id":"57e90ee8fd300236cd124bc7f8ebac60c62b5642","original_commit_id":"57e90ee8fd300236cd124bc7f8ebac60c62b5642","user":{"login":"batsatt","id":4099370,"node_id":"MDQ6VXNlcjQwOTkzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/4099370?v=4","gravatar_id":"","url":"https://api.github.com/users/batsatt","html_url":"https://github.com/batsatt","followers_url":"https://api.github.com/users/batsatt/followers","following_url":"https://api.github.com/users/batsatt/following{/other_user}","gists_url":"https://api.github.com/users/batsatt/gists{/gist_id}","starred_url":"https://api.github.com/users/batsatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batsatt/subscriptions","organizations_url":"https://api.github.com/users/batsatt/orgs","repos_url":"https://api.github.com/users/batsatt/repos","events_url":"https://api.github.com/users/batsatt/events{/privacy}","received_events_url":"https://api.github.com/users/batsatt/received_events","type":"User","site_admin":false},"body":"I prefer to put expected pathways first, and don't see a simple negation like this as complex.\r\n\r\nIn this case, we're explicitly trying to use a local converter if it is present so having the code that uses it first seems far more logical to me.\r\n","created_at":"2019-04-10T18:08:14Z","updated_at":"2019-04-10T18:08:14Z","html_url":"https://github.com/oracle/helidon/pull/537#discussion_r274090239","pull_request_url":"https://api.github.com/repos/oracle/helidon/pulls/537","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oracle/helidon/pulls/comments/274090239"},"html":{"href":"https://github.com/oracle/helidon/pull/537#discussion_r274090239"},"pull_request":{"href":"https://api.github.com/repos/oracle/helidon/pulls/537"}},"in_reply_to_id":273697283},"pull_request":{"url":"https://api.github.com/repos/oracle/helidon/pulls/537","id":265527411,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1NTI3NDEx","html_url":"https://github.com/oracle/helidon/pull/537","diff_url":"https://github.com/oracle/helidon/pull/537.diff","patch_url":"https://github.com/oracle/helidon/pull/537.patch","issue_url":"https://api.github.com/repos/oracle/helidon/issues/537","number":537,"state":"open","locked":false,"title":"Update MP config to 1.3 ","user":{"login":"batsatt","id":4099370,"node_id":"MDQ6VXNlcjQwOTkzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/4099370?v=4","gravatar_id":"","url":"https://api.github.com/users/batsatt","html_url":"https://github.com/batsatt","followers_url":"https://api.github.com/users/batsatt/followers","following_url":"https://api.github.com/users/batsatt/following{/other_user}","gists_url":"https://api.github.com/users/batsatt/gists{/gist_id}","starred_url":"https://api.github.com/users/batsatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batsatt/subscriptions","organizations_url":"https://api.github.com/users/batsatt/orgs","repos_url":"https://api.github.com/users/batsatt/repos","events_url":"https://api.github.com/users/batsatt/events{/privacy}","received_events_url":"https://api.github.com/users/batsatt/received_events","type":"User","site_admin":false},"body":"Fixes #432 and includes changes to SE for improved symmetry.\r\n\r\nUnfortunately, the different models for handling config sources in SE and MP have made symmetry for environment variables a bit complicated. \r\n\r\nIn SE, the contents of the config sources are _merged_ during the config build and not consulted during a search. In order to support environment variables taking precedence over application config entries, an optimistic mapping must take place **prior** to the merge; see `EnvironmentVariables.expand()`. This approach produces key aliases that are highly _likely_ to match search keys, but is limited in what it can do.\r\n\r\nI've been referring to this approach as the \"static\" mapping.\r\n\r\nIn MP, the config sources _are_ consulted during the search and the `MpcSourceEnvironmentVariables` class can easily implement the mapping required by the [spec](https://github.com/eclipse/microprofile-config/blob/master/spec/src/main/asciidoc/configsources.asciidoc). Prior to the current change, it was (mostly) sufficient to just do the same static mapping; however, the one place where this falls down is with unusual characters in keys (e.g. slash in `app.my/property`, or a Unicode character). The spec wants _any_ non-alphanumeric character other than underscore mapped to underscore, and the 1.3 config TCK checks for this case. \r\n\r\nTo fix this, the current change switches to use a \"dynamic\" mapping within `MpcSourceEnvironmentVariables`; see its use of `EnvironmentVariableAliases`.\r\n\r\nSo far, so good, except... SE does not handle unusual characters, so it isn't symmetric in this case. We can't simply switch to the static mapping or else mapped environment variables can't take precedence. We can't enhance the static mapping because the set of unusual characters is vast and would obviously result in an unacceptable explosion of entries.\r\n\r\nSo we can either live with the asymmetry or try to address it. I've attempted to address it here, using the dynamic mapping as a last resort when a search **fails**; see `aliasGenerator` usage in `ConfigFactory`. If the config key with the odd characters is actually present in the config, you get that value; if it is not, but one of the MP aliases is present you get that. Note a few things here:\r\n\r\n1. The value with the aliased key is not restricted to the env variables source (e.g. you could have `\"FOO_BAR\"` in an application source and find it using `\"foo.bar\"` as the key.\r\n1. Since this lookup happens only after searching everything else, it doesn't support overriding an existing value.\r\n1. This behavior is enabled only when the default environment variable source is enabled.\r\n1. It adds a small cost for every lookup miss, but it is one-time since the result is cached.\r\n\r\nLike I said... complicated. It is clearly debatable whether this fallback search is worth it.","created_at":"2019-03-28T22:37:38Z","updated_at":"2019-04-10T18:08:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eed4309e388cddc8a7f19e23ae494dda863e810","assignee":{"login":"batsatt","id":4099370,"node_id":"MDQ6VXNlcjQwOTkzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/4099370?v=4","gravatar_id":"","url":"https://api.github.com/users/batsatt","html_url":"https://github.com/batsatt","followers_url":"https://api.github.com/users/batsatt/followers","following_url":"https://api.github.com/users/batsatt/following{/other_user}","gists_url":"https://api.github.com/users/batsatt/gists{/gist_id}","starred_url":"https://api.github.com/users/batsatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batsatt/subscriptions","organizations_url":"https://api.github.com/users/batsatt/orgs","repos_url":"https://api.github.com/users/batsatt/repos","events_url":"https://api.github.com/users/batsatt/events{/privacy}","received_events_url":"https://api.github.com/users/batsatt/received_events","type":"User","site_admin":false},"assignees":[{"login":"batsatt","id":4099370,"node_id":"MDQ6VXNlcjQwOTkzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/4099370?v=4","gravatar_id":"","url":"https://api.github.com/users/batsatt","html_url":"https://github.com/batsatt","followers_url":"https://api.github.com/users/batsatt/followers","following_url":"https://api.github.com/users/batsatt/following{/other_user}","gists_url":"https://api.github.com/users/batsatt/gists{/gist_id}","starred_url":"https://api.github.com/users/batsatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batsatt/subscriptions","organizations_url":"https://api.github.com/users/batsatt/orgs","repos_url":"https://api.github.com/users/batsatt/repos","events_url":"https://api.github.com/users/batsatt/events{/privacy}","received_events_url":"https://api.github.com/users/batsatt/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tjquinno","id":24591185,"node_id":"MDQ6VXNlcjI0NTkxMTg1","avatar_url":"https://avatars1.githubusercontent.com/u/24591185?v=4","gravatar_id":"","url":"https://api.github.com/users/tjquinno","html_url":"https://github.com/tjquinno","followers_url":"https://api.github.com/users/tjquinno/followers","following_url":"https://api.github.com/users/tjquinno/following{/other_user}","gists_url":"https://api.github.com/users/tjquinno/gists{/gist_id}","starred_url":"https://api.github.com/users/tjquinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjquinno/subscriptions","organizations_url":"https://api.github.com/users/tjquinno/orgs","repos_url":"https://api.github.com/users/tjquinno/repos","events_url":"https://api.github.com/users/tjquinno/events{/privacy}","received_events_url":"https://api.github.com/users/tjquinno/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/helidon/pulls/537/commits","review_comments_url":"https://api.github.com/repos/oracle/helidon/pulls/537/comments","review_comment_url":"https://api.github.com/repos/oracle/helidon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/helidon/issues/537/comments","statuses_url":"https://api.github.com/repos/oracle/helidon/statuses/57e90ee8fd300236cd124bc7f8ebac60c62b5642","head":{"label":"batsatt:config-to-1.3","ref":"config-to-1.3","sha":"57e90ee8fd300236cd124bc7f8ebac60c62b5642","user":{"login":"batsatt","id":4099370,"node_id":"MDQ6VXNlcjQwOTkzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/4099370?v=4","gravatar_id":"","url":"https://api.github.com/users/batsatt","html_url":"https://github.com/batsatt","followers_url":"https://api.github.com/users/batsatt/followers","following_url":"https://api.github.com/users/batsatt/following{/other_user}","gists_url":"https://api.github.com/users/batsatt/gists{/gist_id}","starred_url":"https://api.github.com/users/batsatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batsatt/subscriptions","organizations_url":"https://api.github.com/users/batsatt/orgs","repos_url":"https://api.github.com/users/batsatt/repos","events_url":"https://api.github.com/users/batsatt/events{/privacy}","received_events_url":"https://api.github.com/users/batsatt/received_events","type":"User","site_admin":false},"repo":{"id":170774321,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA3NzQzMjE=","name":"helidon","full_name":"batsatt/helidon","private":false,"owner":{"login":"batsatt","id":4099370,"node_id":"MDQ6VXNlcjQwOTkzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/4099370?v=4","gravatar_id":"","url":"https://api.github.com/users/batsatt","html_url":"https://github.com/batsatt","followers_url":"https://api.github.com/users/batsatt/followers","following_url":"https://api.github.com/users/batsatt/following{/other_user}","gists_url":"https://api.github.com/users/batsatt/gists{/gist_id}","starred_url":"https://api.github.com/users/batsatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batsatt/subscriptions","organizations_url":"https://api.github.com/users/batsatt/orgs","repos_url":"https://api.github.com/users/batsatt/repos","events_url":"https://api.github.com/users/batsatt/events{/privacy}","received_events_url":"https://api.github.com/users/batsatt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/batsatt/helidon","description":"Java libraries for writing microservices","fork":true,"url":"https://api.github.com/repos/batsatt/helidon","forks_url":"https://api.github.com/repos/batsatt/helidon/forks","keys_url":"https://api.github.com/repos/batsatt/helidon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/batsatt/helidon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/batsatt/helidon/teams","hooks_url":"https://api.github.com/repos/batsatt/helidon/hooks","issue_events_url":"https://api.github.com/repos/batsatt/helidon/issues/events{/number}","events_url":"https://api.github.com/repos/batsatt/helidon/events","assignees_url":"https://api.github.com/repos/batsatt/helidon/assignees{/user}","branches_url":"https://api.github.com/repos/batsatt/helidon/branches{/branch}","tags_url":"https://api.github.com/repos/batsatt/helidon/tags","blobs_url":"https://api.github.com/repos/batsatt/helidon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/batsatt/helidon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/batsatt/helidon/git/refs{/sha}","trees_url":"https://api.github.com/repos/batsatt/helidon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/batsatt/helidon/statuses/{sha}","languages_url":"https://api.github.com/repos/batsatt/helidon/languages","stargazers_url":"https://api.github.com/repos/batsatt/helidon/stargazers","contributors_url":"https://api.github.com/repos/batsatt/helidon/contributors","subscribers_url":"https://api.github.com/repos/batsatt/helidon/subscribers","subscription_url":"https://api.github.com/repos/batsatt/helidon/subscription","commits_url":"https://api.github.com/repos/batsatt/helidon/commits{/sha}","git_commits_url":"https://api.github.com/repos/batsatt/helidon/git/commits{/sha}","comments_url":"https://api.github.com/repos/batsatt/helidon/comments{/number}","issue_comment_url":"https://api.github.com/repos/batsatt/helidon/issues/comments{/number}","contents_url":"https://api.github.com/repos/batsatt/helidon/contents/{+path}","compare_url":"https://api.github.com/repos/batsatt/helidon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/batsatt/helidon/merges","archive_url":"https://api.github.com/repos/batsatt/helidon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/batsatt/helidon/downloads","issues_url":"https://api.github.com/repos/batsatt/helidon/issues{/number}","pulls_url":"https://api.github.com/repos/batsatt/helidon/pulls{/number}","milestones_url":"https://api.github.com/repos/batsatt/helidon/milestones{/number}","notifications_url":"https://api.github.com/repos/batsatt/helidon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/batsatt/helidon/labels{/name}","releases_url":"https://api.github.com/repos/batsatt/helidon/releases{/id}","deployments_url":"https://api.github.com/repos/batsatt/helidon/deployments","created_at":"2019-02-14T23:50:46Z","updated_at":"2019-04-03T16:26:21Z","pushed_at":"2019-04-03T19:48:54Z","git_url":"git://github.com/batsatt/helidon.git","ssh_url":"git@github.com:batsatt/helidon.git","clone_url":"https://github.com/batsatt/helidon.git","svn_url":"https://github.com/batsatt/helidon","homepage":"https://helidon.io","size":5501,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oracle:master","ref":"master","sha":"ce7444ab5c8231cbaf727eb6e50f909cca5810ee","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":146285827,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYyODU4Mjc=","name":"helidon","full_name":"oracle/helidon","private":false,"owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oracle/helidon","description":"Java libraries for writing microservices","fork":false,"url":"https://api.github.com/repos/oracle/helidon","forks_url":"https://api.github.com/repos/oracle/helidon/forks","keys_url":"https://api.github.com/repos/oracle/helidon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/helidon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/helidon/teams","hooks_url":"https://api.github.com/repos/oracle/helidon/hooks","issue_events_url":"https://api.github.com/repos/oracle/helidon/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/helidon/events","assignees_url":"https://api.github.com/repos/oracle/helidon/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/helidon/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/helidon/tags","blobs_url":"https://api.github.com/repos/oracle/helidon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/helidon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/helidon/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/helidon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/helidon/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/helidon/languages","stargazers_url":"https://api.github.com/repos/oracle/helidon/stargazers","contributors_url":"https://api.github.com/repos/oracle/helidon/contributors","subscribers_url":"https://api.github.com/repos/oracle/helidon/subscribers","subscription_url":"https://api.github.com/repos/oracle/helidon/subscription","commits_url":"https://api.github.com/repos/oracle/helidon/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/helidon/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/helidon/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/helidon/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/helidon/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/helidon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/helidon/merges","archive_url":"https://api.github.com/repos/oracle/helidon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/helidon/downloads","issues_url":"https://api.github.com/repos/oracle/helidon/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/helidon/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/helidon/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/helidon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/helidon/labels{/name}","releases_url":"https://api.github.com/repos/oracle/helidon/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/helidon/deployments","created_at":"2018-08-27T11:03:52Z","updated_at":"2019-04-10T16:28:21Z","pushed_at":"2019-04-10T17:27:50Z","git_url":"git://github.com/oracle/helidon.git","ssh_url":"git@github.com:oracle/helidon.git","clone_url":"https://github.com/oracle/helidon.git","svn_url":"https://github.com/oracle/helidon","homepage":"https://helidon.io","size":5524,"stargazers_count":1336,"watchers_count":1336,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":90,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":174,"open_issues":90,"watchers":1336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/helidon/pulls/537"},"html":{"href":"https://github.com/oracle/helidon/pull/537"},"issue":{"href":"https://api.github.com/repos/oracle/helidon/issues/537"},"comments":{"href":"https://api.github.com/repos/oracle/helidon/issues/537/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/helidon/pulls/537/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/helidon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/helidon/pulls/537/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/helidon/statuses/57e90ee8fd300236cd124bc7f8ebac60c62b5642"}},"author_association":"MEMBER"}}
|
{
"id": 146285827,
"name": "oracle/helidon",
"url": "https://api.github.com/repos/oracle/helidon"
}
|
{
"id": 4099370,
"login": "batsatt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4099370?",
"url": "https://api.github.com/users/batsatt"
}
|
{
"id": 4430336,
"login": "oracle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4430336?",
"url": "https://api.github.com/orgs/oracle"
}
| 2019-04-10T18:08:14 |
9418007732
|
{"actor":{"display_login":"batsatt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/helidon/pulls/comments/321846048","pull_request_review_id":285012993,"id":321846048,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMTg0NjA0OA==","diff_hunk":"@@ -69,7 +69,8 @@\n * @see #builder()\n * @see #create(Config)\n */\n-public final class Security {\n+// class cannot be final, so CDI can create a proxy for it","path":"security/security/src/main/java/io/helidon/security/Security.java","position":12,"original_position":12,"commit_id":"bd6a7b440ef342537c23a50467963f59eb7d8850","original_commit_id":"bd6a7b440ef342537c23a50467963f59eb7d8850","user":{"login":"tomas-langer","id":13766491,"node_id":"MDQ6VXNlcjEzNzY2NDkx","avatar_url":"https://avatars1.githubusercontent.com/u/13766491?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas-langer","html_url":"https://github.com/tomas-langer","followers_url":"https://api.github.com/users/tomas-langer/followers","following_url":"https://api.github.com/users/tomas-langer/following{/other_user}","gists_url":"https://api.github.com/users/tomas-langer/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-langer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-langer/subscriptions","organizations_url":"https://api.github.com/users/tomas-langer/orgs","repos_url":"https://api.github.com/users/tomas-langer/repos","events_url":"https://api.github.com/users/tomas-langer/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-langer/received_events","type":"User","site_admin":false},"body":"Yes, this is registered by the `SecurityProducer` (part of this PR) in `AppicationScoped`.\r\nThe startup failed because CDI was not able to proxy this class. Once I removed the `final` keyword, Security is injected as expected.","created_at":"2019-09-06T17:56:28Z","updated_at":"2019-09-06T17:56:28Z","html_url":"https://github.com/oracle/helidon/pull/986#discussion_r321846048","pull_request_url":"https://api.github.com/repos/oracle/helidon/pulls/986","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oracle/helidon/pulls/comments/321846048"},"html":{"href":"https://github.com/oracle/helidon/pull/986#discussion_r321846048"},"pull_request":{"href":"https://api.github.com/repos/oracle/helidon/pulls/986"}},"in_reply_to_id":321834701},"pull_request":{"url":"https://api.github.com/repos/oracle/helidon/pulls/986","id":314062472,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE0MDYyNDcy","html_url":"https://github.com/oracle/helidon/pull/986","diff_url":"https://github.com/oracle/helidon/pull/986.diff","patch_url":"https://github.com/oracle/helidon/pull/986.patch","issue_url":"https://api.github.com/repos/oracle/helidon/issues/986","number":986,"state":"open","locked":false,"title":"Injection of SecurityContext using CDI.","user":{"login":"tomas-langer","id":13766491,"node_id":"MDQ6VXNlcjEzNzY2NDkx","avatar_url":"https://avatars1.githubusercontent.com/u/13766491?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas-langer","html_url":"https://github.com/tomas-langer","followers_url":"https://api.github.com/users/tomas-langer/followers","following_url":"https://api.github.com/users/tomas-langer/following{/other_user}","gists_url":"https://api.github.com/users/tomas-langer/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-langer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-langer/subscriptions","organizations_url":"https://api.github.com/users/tomas-langer/orgs","repos_url":"https://api.github.com/users/tomas-langer/repos","events_url":"https://api.github.com/users/tomas-langer/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-langer/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Tomas Langer <tomas.langer@oracle.com>\r\n\r\nResolves #486 ","created_at":"2019-09-04T14:24:11Z","updated_at":"2019-09-06T17:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"989fae348f336ec555c1c119cb2aa06178d78f39","assignee":{"login":"tomas-langer","id":13766491,"node_id":"MDQ6VXNlcjEzNzY2NDkx","avatar_url":"https://avatars1.githubusercontent.com/u/13766491?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas-langer","html_url":"https://github.com/tomas-langer","followers_url":"https://api.github.com/users/tomas-langer/followers","following_url":"https://api.github.com/users/tomas-langer/following{/other_user}","gists_url":"https://api.github.com/users/tomas-langer/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-langer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-langer/subscriptions","organizations_url":"https://api.github.com/users/tomas-langer/orgs","repos_url":"https://api.github.com/users/tomas-langer/repos","events_url":"https://api.github.com/users/tomas-langer/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-langer/received_events","type":"User","site_admin":false},"assignees":[{"login":"tomas-langer","id":13766491,"node_id":"MDQ6VXNlcjEzNzY2NDkx","avatar_url":"https://avatars1.githubusercontent.com/u/13766491?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas-langer","html_url":"https://github.com/tomas-langer","followers_url":"https://api.github.com/users/tomas-langer/followers","following_url":"https://api.github.com/users/tomas-langer/following{/other_user}","gists_url":"https://api.github.com/users/tomas-langer/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-langer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-langer/subscriptions","organizations_url":"https://api.github.com/users/tomas-langer/orgs","repos_url":"https://api.github.com/users/tomas-langer/repos","events_url":"https://api.github.com/users/tomas-langer/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-langer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1265894123,"node_id":"MDU6TGFiZWwxMjY1ODk0MTIz","url":"https://api.github.com/repos/oracle/helidon/labels/security","name":"security","color":"0000CC","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/helidon/pulls/986/commits","review_comments_url":"https://api.github.com/repos/oracle/helidon/pulls/986/comments","review_comment_url":"https://api.github.com/repos/oracle/helidon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/helidon/issues/986/comments","statuses_url":"https://api.github.com/repos/oracle/helidon/statuses/bd6a7b440ef342537c23a50467963f59eb7d8850","head":{"label":"tomas-langer:486-inject-sec-context","ref":"486-inject-sec-context","sha":"bd6a7b440ef342537c23a50467963f59eb7d8850","user":{"login":"tomas-langer","id":13766491,"node_id":"MDQ6VXNlcjEzNzY2NDkx","avatar_url":"https://avatars1.githubusercontent.com/u/13766491?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas-langer","html_url":"https://github.com/tomas-langer","followers_url":"https://api.github.com/users/tomas-langer/followers","following_url":"https://api.github.com/users/tomas-langer/following{/other_user}","gists_url":"https://api.github.com/users/tomas-langer/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-langer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-langer/subscriptions","organizations_url":"https://api.github.com/users/tomas-langer/orgs","repos_url":"https://api.github.com/users/tomas-langer/repos","events_url":"https://api.github.com/users/tomas-langer/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-langer/received_events","type":"User","site_admin":false},"repo":{"id":151087480,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwODc0ODA=","name":"helidon","full_name":"tomas-langer/helidon","private":false,"owner":{"login":"tomas-langer","id":13766491,"node_id":"MDQ6VXNlcjEzNzY2NDkx","avatar_url":"https://avatars1.githubusercontent.com/u/13766491?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas-langer","html_url":"https://github.com/tomas-langer","followers_url":"https://api.github.com/users/tomas-langer/followers","following_url":"https://api.github.com/users/tomas-langer/following{/other_user}","gists_url":"https://api.github.com/users/tomas-langer/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-langer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-langer/subscriptions","organizations_url":"https://api.github.com/users/tomas-langer/orgs","repos_url":"https://api.github.com/users/tomas-langer/repos","events_url":"https://api.github.com/users/tomas-langer/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-langer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tomas-langer/helidon","description":"Java libraries for writing microservices","fork":true,"url":"https://api.github.com/repos/tomas-langer/helidon","forks_url":"https://api.github.com/repos/tomas-langer/helidon/forks","keys_url":"https://api.github.com/repos/tomas-langer/helidon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomas-langer/helidon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomas-langer/helidon/teams","hooks_url":"https://api.github.com/repos/tomas-langer/helidon/hooks","issue_events_url":"https://api.github.com/repos/tomas-langer/helidon/issues/events{/number}","events_url":"https://api.github.com/repos/tomas-langer/helidon/events","assignees_url":"https://api.github.com/repos/tomas-langer/helidon/assignees{/user}","branches_url":"https://api.github.com/repos/tomas-langer/helidon/branches{/branch}","tags_url":"https://api.github.com/repos/tomas-langer/helidon/tags","blobs_url":"https://api.github.com/repos/tomas-langer/helidon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomas-langer/helidon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomas-langer/helidon/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomas-langer/helidon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomas-langer/helidon/statuses/{sha}","languages_url":"https://api.github.com/repos/tomas-langer/helidon/languages","stargazers_url":"https://api.github.com/repos/tomas-langer/helidon/stargazers","contributors_url":"https://api.github.com/repos/tomas-langer/helidon/contributors","subscribers_url":"https://api.github.com/repos/tomas-langer/helidon/subscribers","subscription_url":"https://api.github.com/repos/tomas-langer/helidon/subscription","commits_url":"https://api.github.com/repos/tomas-langer/helidon/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomas-langer/helidon/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomas-langer/helidon/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomas-langer/helidon/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomas-langer/helidon/contents/{+path}","compare_url":"https://api.github.com/repos/tomas-langer/helidon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomas-langer/helidon/merges","archive_url":"https://api.github.com/repos/tomas-langer/helidon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomas-langer/helidon/downloads","issues_url":"https://api.github.com/repos/tomas-langer/helidon/issues{/number}","pulls_url":"https://api.github.com/repos/tomas-langer/helidon/pulls{/number}","milestones_url":"https://api.github.com/repos/tomas-langer/helidon/milestones{/number}","notifications_url":"https://api.github.com/repos/tomas-langer/helidon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomas-langer/helidon/labels{/name}","releases_url":"https://api.github.com/repos/tomas-langer/helidon/releases{/id}","deployments_url":"https://api.github.com/repos/tomas-langer/helidon/deployments","created_at":"2018-10-01T12:46:40Z","updated_at":"2018-10-01T12:46:46Z","pushed_at":"2019-09-06T17:16:55Z","git_url":"git://github.com/tomas-langer/helidon.git","ssh_url":"git@github.com:tomas-langer/helidon.git","clone_url":"https://github.com/tomas-langer/helidon.git","svn_url":"https://github.com/tomas-langer/helidon","homepage":"https://helidon.io","size":7510,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oracle:master","ref":"master","sha":"1631da77e7323e5b43110f4c4ec0bd0ef83e8613","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":146285827,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYyODU4Mjc=","name":"helidon","full_name":"oracle/helidon","private":false,"owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oracle/helidon","description":"Java libraries for writing microservices","fork":false,"url":"https://api.github.com/repos/oracle/helidon","forks_url":"https://api.github.com/repos/oracle/helidon/forks","keys_url":"https://api.github.com/repos/oracle/helidon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/helidon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/helidon/teams","hooks_url":"https://api.github.com/repos/oracle/helidon/hooks","issue_events_url":"https://api.github.com/repos/oracle/helidon/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/helidon/events","assignees_url":"https://api.github.com/repos/oracle/helidon/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/helidon/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/helidon/tags","blobs_url":"https://api.github.com/repos/oracle/helidon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/helidon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/helidon/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/helidon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/helidon/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/helidon/languages","stargazers_url":"https://api.github.com/repos/oracle/helidon/stargazers","contributors_url":"https://api.github.com/repos/oracle/helidon/contributors","subscribers_url":"https://api.github.com/repos/oracle/helidon/subscribers","subscription_url":"https://api.github.com/repos/oracle/helidon/subscription","commits_url":"https://api.github.com/repos/oracle/helidon/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/helidon/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/helidon/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/helidon/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/helidon/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/helidon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/helidon/merges","archive_url":"https://api.github.com/repos/oracle/helidon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/helidon/downloads","issues_url":"https://api.github.com/repos/oracle/helidon/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/helidon/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/helidon/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/helidon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/helidon/labels{/name}","releases_url":"https://api.github.com/repos/oracle/helidon/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/helidon/deployments","created_at":"2018-08-27T11:03:52Z","updated_at":"2019-09-06T17:16:17Z","pushed_at":"2019-09-06T17:16:57Z","git_url":"git://github.com/oracle/helidon.git","ssh_url":"git@github.com:oracle/helidon.git","clone_url":"https://github.com/oracle/helidon.git","svn_url":"https://github.com/oracle/helidon","homepage":"https://helidon.io","size":8486,"stargazers_count":1540,"watchers_count":1540,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":131,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":217,"open_issues":131,"watchers":1540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/helidon/pulls/986"},"html":{"href":"https://github.com/oracle/helidon/pull/986"},"issue":{"href":"https://api.github.com/repos/oracle/helidon/issues/986"},"comments":{"href":"https://api.github.com/repos/oracle/helidon/issues/986/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/helidon/pulls/986/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/helidon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/helidon/pulls/986/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/helidon/statuses/bd6a7b440ef342537c23a50467963f59eb7d8850"}},"author_association":"MEMBER"}}
|
{
"id": 146285827,
"name": "oracle/helidon",
"url": "https://api.github.com/repos/oracle/helidon"
}
|
{
"id": 13766491,
"login": "tomas-langer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13766491?",
"url": "https://api.github.com/users/tomas-langer"
}
|
{
"id": 4430336,
"login": "oracle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4430336?",
"url": "https://api.github.com/orgs/oracle"
}
| 2019-09-06T17:56:28 |
10364735109
|
{"actor":{"display_login":"tomas-langer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/comments/340971762","pull_request_review_id":309663290,"id":340971762,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDk3MTc2Mg==","diff_hunk":"@@ -0,0 +1,36 @@\n+import boto3\n+import logging\n+import os\n+from ssh import exec_command\n+\n+LOG = logging.getLogger(__name__)\n+LOG.setLevel(logging.INFO)\n+\n+\n+def automate_rolling_archive(s3_client, s3_bucket, filelist, execute_command=exec_command):\n+ execute_command(f'execute_s2nbar_rolling_archive --s3client {s3_client} --s3bucket {s3_bucket} '\n+ f'--filelist {filelist}')\n+\n+\n+def handler(event, context):\n+ \"\"\"\n+ SNS handler\n+\n+ Level 1 process done list is generated manually till wagl code is updated to push sns notification\n+ that the Sentinel-2 Definitive ard processing is completed\n+\n+ # raijin$ module use /g/data/v10/public/modules/modulefiles/\n+ # raijin$ module use /g/data/v10/private/modules/modulefiles/\n+ # raijin$ module load wagl/5.4.0\n+ # raijin$ batch_summary --indir /g/data/v10/work/s2_ard/wagl/batchid-21e0db8763/ --outdir=$PWD\n+ \"\"\"\n+ _level1_done_filepath = os.environ.get('LEVEL1_DONE_LIST')\n+ _aws_profile = os.environ.get('AWS_PROFILE')\n+ _s3_bucket = os.environ.get('S3_BUCKET')\n+\n+ # Create an S3 client\n+ session = boto3.Session(profile_name=_aws_profile)","path":"lambda_functions/automate_s2_nbar_rolling_archive/execute_s2nbar/handler.py","position":null,"original_position":32,"commit_id":"f54cb2c5bf84412ff46e602137339d9ac5886d32","original_commit_id":"e019314523c8483802d3a4f03fec221dfb9805c3","user":{"login":"santoshamohan","id":39038859,"node_id":"MDQ6VXNlcjM5MDM4ODU5","avatar_url":"https://avatars0.githubusercontent.com/u/39038859?v=4","gravatar_id":"","url":"https://api.github.com/users/santoshamohan","html_url":"https://github.com/santoshamohan","followers_url":"https://api.github.com/users/santoshamohan/followers","following_url":"https://api.github.com/users/santoshamohan/following{/other_user}","gists_url":"https://api.github.com/users/santoshamohan/gists{/gist_id}","starred_url":"https://api.github.com/users/santoshamohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santoshamohan/subscriptions","organizations_url":"https://api.github.com/users/santoshamohan/orgs","repos_url":"https://api.github.com/users/santoshamohan/repos","events_url":"https://api.github.com/users/santoshamohan/events{/privacy}","received_events_url":"https://api.github.com/users/santoshamohan/received_events","type":"User","site_admin":false},"body":"Refactored `handler.py` file to simplify handler function logic","created_at":"2019-10-31T06:04:07Z","updated_at":"2019-10-31T06:04:08Z","html_url":"https://github.com/GeoscienceAustralia/dea-orchestration/pull/141#discussion_r340971762","pull_request_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/141","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/comments/340971762"},"html":{"href":"https://github.com/GeoscienceAustralia/dea-orchestration/pull/141#discussion_r340971762"},"pull_request":{"href":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/141"}},"in_reply_to_id":340949694},"pull_request":{"url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/141","id":332976271,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyOTc2Mjcx","html_url":"https://github.com/GeoscienceAustralia/dea-orchestration/pull/141","diff_url":"https://github.com/GeoscienceAustralia/dea-orchestration/pull/141.diff","patch_url":"https://github.com/GeoscienceAustralia/dea-orchestration/pull/141.patch","issue_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues/141","number":141,"state":"open","locked":false,"title":"Automate s2nbar rolling archive","user":{"login":"santoshamohan","id":39038859,"node_id":"MDQ6VXNlcjM5MDM4ODU5","avatar_url":"https://avatars0.githubusercontent.com/u/39038859?v=4","gravatar_id":"","url":"https://api.github.com/users/santoshamohan","html_url":"https://github.com/santoshamohan","followers_url":"https://api.github.com/users/santoshamohan/followers","following_url":"https://api.github.com/users/santoshamohan/following{/other_user}","gists_url":"https://api.github.com/users/santoshamohan/gists{/gist_id}","starred_url":"https://api.github.com/users/santoshamohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santoshamohan/subscriptions","organizations_url":"https://api.github.com/users/santoshamohan/orgs","repos_url":"https://api.github.com/users/santoshamohan/repos","events_url":"https://api.github.com/users/santoshamohan/events{/privacy}","received_events_url":"https://api.github.com/users/santoshamohan/received_events","type":"User","site_admin":false},"body":"## Background\r\n`Sentinel-2 Definitive NBAR` product generation is required to be a rolling archive for last two years. This process requires `sls` automation to kick start weekly generation of new datasets once `S2 ARD Granules` are successfully generated by `execute_ssh_command_js` `sls` `lambda` function\r\n\r\n## Following are the updates within this PR\r\n- User is expected to run `wagl` `batch_summary` command to generate `s2` `level1` completed zip file list in a text file\r\n- User then needs to update the new `level1` `done` list in the `sls` file\r\n- Lambda function is scheduled to run weekly. Once the list is completely processed, file is renamed to avoid duplicate dataset generation. If the file list is not updated, then lambda function is expected to fail without doing any processing\r\n- To access `NCI` `/g/data` for `sls` orchestration, `handler` function will run `raijin_scripts/execute_s2nbar_rolling_archive/run` `raijin` script","created_at":"2019-10-28T06:59:58Z","updated_at":"2019-10-31T06:04:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b040ee1e79021c584dc5dc05fc831b604eb1884a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/141/commits","review_comments_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/141/comments","review_comment_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues/141/comments","statuses_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/statuses/f54cb2c5bf84412ff46e602137339d9ac5886d32","head":{"label":"GeoscienceAustralia:automate-s2nbar-rolling-archive","ref":"automate-s2nbar-rolling-archive","sha":"f54cb2c5bf84412ff46e602137339d9ac5886d32","user":{"login":"GeoscienceAustralia","id":4704285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4704285?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoscienceAustralia","html_url":"https://github.com/GeoscienceAustralia","followers_url":"https://api.github.com/users/GeoscienceAustralia/followers","following_url":"https://api.github.com/users/GeoscienceAustralia/following{/other_user}","gists_url":"https://api.github.com/users/GeoscienceAustralia/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoscienceAustralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoscienceAustralia/subscriptions","organizations_url":"https://api.github.com/users/GeoscienceAustralia/orgs","repos_url":"https://api.github.com/users/GeoscienceAustralia/repos","events_url":"https://api.github.com/users/GeoscienceAustralia/events{/privacy}","received_events_url":"https://api.github.com/users/GeoscienceAustralia/received_events","type":"Organization","site_admin":false},"repo":{"id":101592016,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE1OTIwMTY=","name":"dea-orchestration","full_name":"GeoscienceAustralia/dea-orchestration","private":false,"owner":{"login":"GeoscienceAustralia","id":4704285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4704285?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoscienceAustralia","html_url":"https://github.com/GeoscienceAustralia","followers_url":"https://api.github.com/users/GeoscienceAustralia/followers","following_url":"https://api.github.com/users/GeoscienceAustralia/following{/other_user}","gists_url":"https://api.github.com/users/GeoscienceAustralia/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoscienceAustralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoscienceAustralia/subscriptions","organizations_url":"https://api.github.com/users/GeoscienceAustralia/orgs","repos_url":"https://api.github.com/users/GeoscienceAustralia/repos","events_url":"https://api.github.com/users/GeoscienceAustralia/events{/privacy}","received_events_url":"https://api.github.com/users/GeoscienceAustralia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GeoscienceAustralia/dea-orchestration","description":null,"fork":false,"url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration","forks_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/forks","keys_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/teams","hooks_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/hooks","issue_events_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/events","assignees_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/tags","blobs_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/languages","stargazers_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/stargazers","contributors_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/contributors","subscribers_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/subscribers","subscription_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/subscription","commits_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/merges","archive_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/downloads","issues_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/releases{/id}","deployments_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/deployments","created_at":"2017-08-28T01:26:11Z","updated_at":"2019-10-18T01:55:42Z","pushed_at":"2019-10-31T04:15:17Z","git_url":"git://github.com/GeoscienceAustralia/dea-orchestration.git","ssh_url":"git@github.com:GeoscienceAustralia/dea-orchestration.git","clone_url":"https://github.com/GeoscienceAustralia/dea-orchestration.git","svn_url":"https://github.com/GeoscienceAustralia/dea-orchestration","homepage":null,"size":7062,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"GeoscienceAustralia:master","ref":"master","sha":"e968b2c6b1d842adb8ce49e62916d03dcf2a9b89","user":{"login":"GeoscienceAustralia","id":4704285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4704285?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoscienceAustralia","html_url":"https://github.com/GeoscienceAustralia","followers_url":"https://api.github.com/users/GeoscienceAustralia/followers","following_url":"https://api.github.com/users/GeoscienceAustralia/following{/other_user}","gists_url":"https://api.github.com/users/GeoscienceAustralia/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoscienceAustralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoscienceAustralia/subscriptions","organizations_url":"https://api.github.com/users/GeoscienceAustralia/orgs","repos_url":"https://api.github.com/users/GeoscienceAustralia/repos","events_url":"https://api.github.com/users/GeoscienceAustralia/events{/privacy}","received_events_url":"https://api.github.com/users/GeoscienceAustralia/received_events","type":"Organization","site_admin":false},"repo":{"id":101592016,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE1OTIwMTY=","name":"dea-orchestration","full_name":"GeoscienceAustralia/dea-orchestration","private":false,"owner":{"login":"GeoscienceAustralia","id":4704285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4704285?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoscienceAustralia","html_url":"https://github.com/GeoscienceAustralia","followers_url":"https://api.github.com/users/GeoscienceAustralia/followers","following_url":"https://api.github.com/users/GeoscienceAustralia/following{/other_user}","gists_url":"https://api.github.com/users/GeoscienceAustralia/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoscienceAustralia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoscienceAustralia/subscriptions","organizations_url":"https://api.github.com/users/GeoscienceAustralia/orgs","repos_url":"https://api.github.com/users/GeoscienceAustralia/repos","events_url":"https://api.github.com/users/GeoscienceAustralia/events{/privacy}","received_events_url":"https://api.github.com/users/GeoscienceAustralia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GeoscienceAustralia/dea-orchestration","description":null,"fork":false,"url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration","forks_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/forks","keys_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/teams","hooks_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/hooks","issue_events_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/events","assignees_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/tags","blobs_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/languages","stargazers_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/stargazers","contributors_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/contributors","subscribers_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/subscribers","subscription_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/subscription","commits_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/merges","archive_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/downloads","issues_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/releases{/id}","deployments_url":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/deployments","created_at":"2017-08-28T01:26:11Z","updated_at":"2019-10-18T01:55:42Z","pushed_at":"2019-10-31T04:15:17Z","git_url":"git://github.com/GeoscienceAustralia/dea-orchestration.git","ssh_url":"git@github.com:GeoscienceAustralia/dea-orchestration.git","clone_url":"https://github.com/GeoscienceAustralia/dea-orchestration.git","svn_url":"https://github.com/GeoscienceAustralia/dea-orchestration","homepage":null,"size":7062,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/141"},"html":{"href":"https://github.com/GeoscienceAustralia/dea-orchestration/pull/141"},"issue":{"href":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues/141"},"comments":{"href":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/GeoscienceAustralia/dea-orchestration/statuses/f54cb2c5bf84412ff46e602137339d9ac5886d32"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 101592016,
"name": "GeoscienceAustralia/dea-orchestration",
"url": "https://api.github.com/repos/GeoscienceAustralia/dea-orchestration"
}
|
{
"id": 39038859,
"login": "santoshamohan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39038859?",
"url": "https://api.github.com/users/santoshamohan"
}
|
{
"id": 4704285,
"login": "GeoscienceAustralia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4704285?",
"url": "https://api.github.com/orgs/GeoscienceAustralia"
}
| 2019-10-31T06:04:07 |
10754365992
|
{"actor":{"display_login":"santoshamohan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/keycloak/keycloak-community/pulls/comments/277545852","pull_request_review_id":229384127,"id":277545852,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzU0NTg1Mg==","diff_hunk":"@@ -0,0 +1,389 @@\n+# REST API Guideline\n+\n+* **Status**: Draft\n+* **Author**: [pedroigor](https://github.com/pedroigor), [abstractj](https://github.com/abstractj), [ssilvert](https://github.com/ssilvert)\n+* **JIRA**: [KEYCLOAK-9344](https://issues.jboss.org/browse/KEYCLOAK-9344)\n+\n+## Abstract\n+\n+The Keycloak REST API Guideline provides a set of design principles and practices that should be considered by developers when designing, implementing and exposing a RESTful API. To provide the best experience for developers consuming Keycloak REST APIs, it's important API developers to follow to the principles and practices defined herein, making these APIs intuitive and easy to use.\n+\n+The goals of the guideline are:\n+\n+* Define the [overall principles](#principles) that should be taken into account when designing REST APIs for Keycloak\n+\n+* Define common practices and patterns for all Keycloak REST APIs such as:\n+ * [Filtering](#filtering)\n+ * [Pagination](#pagination)\n+ * [Error Handling](#error_handling)\n+ * [Documentation](#securityp)\n+\n+* Define common practices for [documentation](#documentation)\n+\n+Although the guideline is based on the REST architectural style, it does not try to strictly adhere to RESTful constraints. The principles covered by the guideline are based on practical experiences in the development of REST APIs in Keycloak while still conforming with most of the constraints of REST architectures.\n+\n+**Table of Contents**\n+\n+\n+ - [Principles](#principles)\n+ - [Level of Service Maturity](#level-of-service-maturity)\n+ - [Resource Path](#resource-path)\n+ - [Group](#group)\n+ - [Versioning](#versioning)\n+ - [Extensions](#extensions)\n+ - [Technology Preview](#technology-preview)\n+ - [Store Resources](#store-resources)\n+ - [Controller Resources](#controller-resources)\n+ - [Resource Representation](#resource-representation)\n+ - [HTTP Status Codes](#http-status-codes)\n+ - [HTTP Verbs](#http-verbs)\n+ - [GET](#get)\n+ - [POST](#post)\n+ - [PUT](#put)\n+ - [DELETE](#delete)\n+ - [Practices](#practices)\n+ - [Error Handling](#error-handling)\n+ - [Filtering](#filtering)\n+ - [Pagination](#pagination)\n+ - [Documentation](#documentation)\n+ - [Examples](#examples)\n+\n+## Principles\n+\n+This section defines the general principles that should be considered by API developers, regardless of the practices defined through this document.\n+\n+### Level of Service Maturity\n+\n+Based on [Richardson Maturity Model](https://martinfowler.com/articles/richardsonMaturityModel.html), developers MUST adhere to the maturity Level 2, where interactions with the API endpoints are based on the usage of HTTP Verbs and status codes to communicate status and errors.\n+\n+### Resource Path\n+\n+In Keycloak, we choose to stick with the following convention for resource paths:\n+\n+```\n+/apis/{API_GROUP}/{version}\n+```\n+\n+When the resource operates in the context of a `realm`, the resource path should be as follows:\n+\n+```\n+/apis/{API_GROUP}/{version}/realms/{realm}\n+```\n+\n+When operating in the context of a `realm`, a `/realms/{realm}` should be included at the end of the resource root path.\n+\n+#### Group\n+\n+The `API_GROUP` refers to a set of one or more functionality that can be grouped together. The endpoints associated with a group can manage different resources as far as they are strictly related with the functionality represented by the group.\n+\n+By including the group in the resource path, we aim to provide a clear and consistency view of the functionalities exposed by the different APIs, with more control over the groups of functionality (in terms of functional and non-functional aspects) as well as make more clear how we communicate the functional structure of these APIs through the documentation.\n+\n+Here is an example of a resource path related with the group of functionalities provided by the Account Management REST API:\n+\n+```\n+/apis/accounts/v1/{user_id}\n+```\n+\n+The path refers to the `accounts` group and any resource/operation related with user account management (in this case for user with id `user_id`) can be accessed from that path.\n+Note that by grouping functionalities together and in conjunction with the versioning schema, we can keep the root path and also the semantics of the API without impact the adaptability for new changes or improvements to the API.\n+\n+Group names should be in lowercase, a single word name and plural.","path":"design/rest-api-guideline.md","position":90,"original_position":90,"commit_id":"d8f21a6f335cedfa4f49b16b3c08107e3b52096f","original_commit_id":"eb54d008165d8956de9ed49549a76cefd8e23c08","user":{"login":"vmuzikar","id":13906855,"node_id":"MDQ6VXNlcjEzOTA2ODU1","avatar_url":"https://avatars3.githubusercontent.com/u/13906855?v=4","gravatar_id":"","url":"https://api.github.com/users/vmuzikar","html_url":"https://github.com/vmuzikar","followers_url":"https://api.github.com/users/vmuzikar/followers","following_url":"https://api.github.com/users/vmuzikar/following{/other_user}","gists_url":"https://api.github.com/users/vmuzikar/gists{/gist_id}","starred_url":"https://api.github.com/users/vmuzikar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmuzikar/subscriptions","organizations_url":"https://api.github.com/users/vmuzikar/orgs","repos_url":"https://api.github.com/users/vmuzikar/repos","events_url":"https://api.github.com/users/vmuzikar/events{/privacy}","received_events_url":"https://api.github.com/users/vmuzikar/received_events","type":"User","site_admin":false},"body":"Ok, I think I get the idea now - the API \"group\" is basically a resource (in terms of REST). But then why to call it a group when it's a resource? Isn't it a bit confusing? :)\r\n\r\nOne thing I don't understand now is why the API version is present after the resource (`/apis/{API_GROUP}/{version}`)? Are we going to have a different versioning for each resource? Isn't it a best practice to have a single unified version for the whole API (to not overcomplicate things)?","created_at":"2019-04-23T07:24:06Z","updated_at":"2019-04-23T07:24:06Z","html_url":"https://github.com/keycloak/keycloak-community/pull/4#discussion_r277545852","pull_request_url":"https://api.github.com/repos/keycloak/keycloak-community/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/keycloak/keycloak-community/pulls/comments/277545852"},"html":{"href":"https://github.com/keycloak/keycloak-community/pull/4#discussion_r277545852"},"pull_request":{"href":"https://api.github.com/repos/keycloak/keycloak-community/pulls/4"}},"in_reply_to_id":276561340},"pull_request":{"url":"https://api.github.com/repos/keycloak/keycloak-community/pulls/4","id":270111737,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMTExNzM3","html_url":"https://github.com/keycloak/keycloak-community/pull/4","diff_url":"https://github.com/keycloak/keycloak-community/pull/4.diff","patch_url":"https://github.com/keycloak/keycloak-community/pull/4.patch","issue_url":"https://api.github.com/repos/keycloak/keycloak-community/issues/4","number":4,"state":"open","locked":false,"title":"[KEYCLOAK-9344] - REST API Guideline","user":{"login":"pedroigor","id":1143437,"node_id":"MDQ6VXNlcjExNDM0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1143437?v=4","gravatar_id":"","url":"https://api.github.com/users/pedroigor","html_url":"https://github.com/pedroigor","followers_url":"https://api.github.com/users/pedroigor/followers","following_url":"https://api.github.com/users/pedroigor/following{/other_user}","gists_url":"https://api.github.com/users/pedroigor/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroigor/subscriptions","organizations_url":"https://api.github.com/users/pedroigor/orgs","repos_url":"https://api.github.com/users/pedroigor/repos","events_url":"https://api.github.com/users/pedroigor/events{/privacy}","received_events_url":"https://api.github.com/users/pedroigor/received_events","type":"User","site_admin":false},"body":"The task list below will be used to track changes agreed during discussions:\r\n\r\n- [ ] Include `extension_id` to the extension resource path format","created_at":"2019-04-12T18:33:59Z","updated_at":"2019-04-23T07:24:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c59f5ff4730e9ff230708be0cab043878f74192","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keycloak/keycloak-community/pulls/4/commits","review_comments_url":"https://api.github.com/repos/keycloak/keycloak-community/pulls/4/comments","review_comment_url":"https://api.github.com/repos/keycloak/keycloak-community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keycloak/keycloak-community/issues/4/comments","statuses_url":"https://api.github.com/repos/keycloak/keycloak-community/statuses/d8f21a6f335cedfa4f49b16b3c08107e3b52096f","head":{"label":"pedroigor:KEYCLOAK-9344","ref":"KEYCLOAK-9344","sha":"d8f21a6f335cedfa4f49b16b3c08107e3b52096f","user":{"login":"pedroigor","id":1143437,"node_id":"MDQ6VXNlcjExNDM0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1143437?v=4","gravatar_id":"","url":"https://api.github.com/users/pedroigor","html_url":"https://github.com/pedroigor","followers_url":"https://api.github.com/users/pedroigor/followers","following_url":"https://api.github.com/users/pedroigor/following{/other_user}","gists_url":"https://api.github.com/users/pedroigor/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroigor/subscriptions","organizations_url":"https://api.github.com/users/pedroigor/orgs","repos_url":"https://api.github.com/users/pedroigor/repos","events_url":"https://api.github.com/users/pedroigor/events{/privacy}","received_events_url":"https://api.github.com/users/pedroigor/received_events","type":"User","site_admin":false},"repo":{"id":180579692,"node_id":"MDEwOlJlcG9zaXRvcnkxODA1Nzk2OTI=","name":"keycloak-community","full_name":"pedroigor/keycloak-community","private":false,"owner":{"login":"pedroigor","id":1143437,"node_id":"MDQ6VXNlcjExNDM0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1143437?v=4","gravatar_id":"","url":"https://api.github.com/users/pedroigor","html_url":"https://github.com/pedroigor","followers_url":"https://api.github.com/users/pedroigor/followers","following_url":"https://api.github.com/users/pedroigor/following{/other_user}","gists_url":"https://api.github.com/users/pedroigor/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroigor/subscriptions","organizations_url":"https://api.github.com/users/pedroigor/orgs","repos_url":"https://api.github.com/users/pedroigor/repos","events_url":"https://api.github.com/users/pedroigor/events{/privacy}","received_events_url":"https://api.github.com/users/pedroigor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pedroigor/keycloak-community","description":null,"fork":true,"url":"https://api.github.com/repos/pedroigor/keycloak-community","forks_url":"https://api.github.com/repos/pedroigor/keycloak-community/forks","keys_url":"https://api.github.com/repos/pedroigor/keycloak-community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedroigor/keycloak-community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedroigor/keycloak-community/teams","hooks_url":"https://api.github.com/repos/pedroigor/keycloak-community/hooks","issue_events_url":"https://api.github.com/repos/pedroigor/keycloak-community/issues/events{/number}","events_url":"https://api.github.com/repos/pedroigor/keycloak-community/events","assignees_url":"https://api.github.com/repos/pedroigor/keycloak-community/assignees{/user}","branches_url":"https://api.github.com/repos/pedroigor/keycloak-community/branches{/branch}","tags_url":"https://api.github.com/repos/pedroigor/keycloak-community/tags","blobs_url":"https://api.github.com/repos/pedroigor/keycloak-community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedroigor/keycloak-community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedroigor/keycloak-community/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedroigor/keycloak-community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedroigor/keycloak-community/statuses/{sha}","languages_url":"https://api.github.com/repos/pedroigor/keycloak-community/languages","stargazers_url":"https://api.github.com/repos/pedroigor/keycloak-community/stargazers","contributors_url":"https://api.github.com/repos/pedroigor/keycloak-community/contributors","subscribers_url":"https://api.github.com/repos/pedroigor/keycloak-community/subscribers","subscription_url":"https://api.github.com/repos/pedroigor/keycloak-community/subscription","commits_url":"https://api.github.com/repos/pedroigor/keycloak-community/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedroigor/keycloak-community/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedroigor/keycloak-community/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedroigor/keycloak-community/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedroigor/keycloak-community/contents/{+path}","compare_url":"https://api.github.com/repos/pedroigor/keycloak-community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedroigor/keycloak-community/merges","archive_url":"https://api.github.com/repos/pedroigor/keycloak-community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedroigor/keycloak-community/downloads","issues_url":"https://api.github.com/repos/pedroigor/keycloak-community/issues{/number}","pulls_url":"https://api.github.com/repos/pedroigor/keycloak-community/pulls{/number}","milestones_url":"https://api.github.com/repos/pedroigor/keycloak-community/milestones{/number}","notifications_url":"https://api.github.com/repos/pedroigor/keycloak-community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedroigor/keycloak-community/labels{/name}","releases_url":"https://api.github.com/repos/pedroigor/keycloak-community/releases{/id}","deployments_url":"https://api.github.com/repos/pedroigor/keycloak-community/deployments","created_at":"2019-04-10T12:43:38Z","updated_at":"2019-04-10T12:43:40Z","pushed_at":"2019-04-18T11:42:44Z","git_url":"git://github.com/pedroigor/keycloak-community.git","ssh_url":"git@github.com:pedroigor/keycloak-community.git","clone_url":"https://github.com/pedroigor/keycloak-community.git","svn_url":"https://github.com/pedroigor/keycloak-community","homepage":null,"size":80,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keycloak:master","ref":"master","sha":"54cfe918b6edf96c0c66a2a6fb4eaeaaef85922b","user":{"login":"keycloak","id":4921466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4921466?v=4","gravatar_id":"","url":"https://api.github.com/users/keycloak","html_url":"https://github.com/keycloak","followers_url":"https://api.github.com/users/keycloak/followers","following_url":"https://api.github.com/users/keycloak/following{/other_user}","gists_url":"https://api.github.com/users/keycloak/gists{/gist_id}","starred_url":"https://api.github.com/users/keycloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keycloak/subscriptions","organizations_url":"https://api.github.com/users/keycloak/orgs","repos_url":"https://api.github.com/users/keycloak/repos","events_url":"https://api.github.com/users/keycloak/events{/privacy}","received_events_url":"https://api.github.com/users/keycloak/received_events","type":"Organization","site_admin":false},"repo":{"id":171517850,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE1MTc4NTA=","name":"keycloak-community","full_name":"keycloak/keycloak-community","private":false,"owner":{"login":"keycloak","id":4921466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4921466?v=4","gravatar_id":"","url":"https://api.github.com/users/keycloak","html_url":"https://github.com/keycloak","followers_url":"https://api.github.com/users/keycloak/followers","following_url":"https://api.github.com/users/keycloak/following{/other_user}","gists_url":"https://api.github.com/users/keycloak/gists{/gist_id}","starred_url":"https://api.github.com/users/keycloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keycloak/subscriptions","organizations_url":"https://api.github.com/users/keycloak/orgs","repos_url":"https://api.github.com/users/keycloak/repos","events_url":"https://api.github.com/users/keycloak/events{/privacy}","received_events_url":"https://api.github.com/users/keycloak/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keycloak/keycloak-community","description":null,"fork":false,"url":"https://api.github.com/repos/keycloak/keycloak-community","forks_url":"https://api.github.com/repos/keycloak/keycloak-community/forks","keys_url":"https://api.github.com/repos/keycloak/keycloak-community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keycloak/keycloak-community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keycloak/keycloak-community/teams","hooks_url":"https://api.github.com/repos/keycloak/keycloak-community/hooks","issue_events_url":"https://api.github.com/repos/keycloak/keycloak-community/issues/events{/number}","events_url":"https://api.github.com/repos/keycloak/keycloak-community/events","assignees_url":"https://api.github.com/repos/keycloak/keycloak-community/assignees{/user}","branches_url":"https://api.github.com/repos/keycloak/keycloak-community/branches{/branch}","tags_url":"https://api.github.com/repos/keycloak/keycloak-community/tags","blobs_url":"https://api.github.com/repos/keycloak/keycloak-community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keycloak/keycloak-community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keycloak/keycloak-community/git/refs{/sha}","trees_url":"https://api.github.com/repos/keycloak/keycloak-community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keycloak/keycloak-community/statuses/{sha}","languages_url":"https://api.github.com/repos/keycloak/keycloak-community/languages","stargazers_url":"https://api.github.com/repos/keycloak/keycloak-community/stargazers","contributors_url":"https://api.github.com/repos/keycloak/keycloak-community/contributors","subscribers_url":"https://api.github.com/repos/keycloak/keycloak-community/subscribers","subscription_url":"https://api.github.com/repos/keycloak/keycloak-community/subscription","commits_url":"https://api.github.com/repos/keycloak/keycloak-community/commits{/sha}","git_commits_url":"https://api.github.com/repos/keycloak/keycloak-community/git/commits{/sha}","comments_url":"https://api.github.com/repos/keycloak/keycloak-community/comments{/number}","issue_comment_url":"https://api.github.com/repos/keycloak/keycloak-community/issues/comments{/number}","contents_url":"https://api.github.com/repos/keycloak/keycloak-community/contents/{+path}","compare_url":"https://api.github.com/repos/keycloak/keycloak-community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keycloak/keycloak-community/merges","archive_url":"https://api.github.com/repos/keycloak/keycloak-community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keycloak/keycloak-community/downloads","issues_url":"https://api.github.com/repos/keycloak/keycloak-community/issues{/number}","pulls_url":"https://api.github.com/repos/keycloak/keycloak-community/pulls{/number}","milestones_url":"https://api.github.com/repos/keycloak/keycloak-community/milestones{/number}","notifications_url":"https://api.github.com/repos/keycloak/keycloak-community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keycloak/keycloak-community/labels{/name}","releases_url":"https://api.github.com/repos/keycloak/keycloak-community/releases{/id}","deployments_url":"https://api.github.com/repos/keycloak/keycloak-community/deployments","created_at":"2019-02-19T17:25:07Z","updated_at":"2019-04-17T22:39:19Z","pushed_at":"2019-04-18T11:42:45Z","git_url":"git://github.com/keycloak/keycloak-community.git","ssh_url":"git@github.com:keycloak/keycloak-community.git","clone_url":"https://github.com/keycloak/keycloak-community.git","svn_url":"https://github.com/keycloak/keycloak-community","homepage":null,"size":108,"stargazers_count":16,"watchers_count":16,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":8,"open_issues":2,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keycloak/keycloak-community/pulls/4"},"html":{"href":"https://github.com/keycloak/keycloak-community/pull/4"},"issue":{"href":"https://api.github.com/repos/keycloak/keycloak-community/issues/4"},"comments":{"href":"https://api.github.com/repos/keycloak/keycloak-community/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/keycloak/keycloak-community/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/keycloak/keycloak-community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keycloak/keycloak-community/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/keycloak/keycloak-community/statuses/d8f21a6f335cedfa4f49b16b3c08107e3b52096f"}},"author_association":"NONE"}}
|
{
"id": 171517850,
"name": "keycloak/keycloak-community",
"url": "https://api.github.com/repos/keycloak/keycloak-community"
}
|
{
"id": 13906855,
"login": "vmuzikar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13906855?",
"url": "https://api.github.com/users/vmuzikar"
}
|
{
"id": 4921466,
"login": "keycloak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4921466?",
"url": "https://api.github.com/orgs/keycloak"
}
| 2019-04-23T07:24:06 |
9491460028
|
{"actor":{"display_login":"vmuzikar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/comments/316227745","pull_request_review_id":277849987,"id":316227745,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjIyNzc0NQ==","diff_hunk":"@@ -73,7 +73,9 @@ dateRange[] = publishDate\n ; for a large number of building facets where top level is organization and\n ; second level the library branch)\n ; all = Sort all levels alphabetically\n-;hierarchicalFacetSortOptions[building] = top","path":"config/vufind/facets.ini","position":4,"original_position":4,"commit_id":"f933dc01b252178dfc2a47e72cfa95135d22e5bc","original_commit_id":"f933dc01b252178dfc2a47e72cfa95135d22e5bc","user":{"login":"demiankatz","id":309069,"node_id":"MDQ6VXNlcjMwOTA2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/309069?v=4","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"body":"Is there a specific reason why the building example was removed? (Not that I'm hugely concerned about this, but I see that the comments above describe this example, so it might be worth keeping it here).","created_at":"2019-08-21T14:47:01Z","updated_at":"2019-08-21T14:47:02Z","html_url":"https://github.com/vufind-org/vufind/pull/1389#discussion_r316227745","pull_request_url":"https://api.github.com/repos/vufind-org/vufind/pulls/1389","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/comments/316227745"},"html":{"href":"https://github.com/vufind-org/vufind/pull/1389#discussion_r316227745"},"pull_request":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/1389"}}},"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/1389","id":294517757,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0NTE3NzU3","html_url":"https://github.com/vufind-org/vufind/pull/1389","diff_url":"https://github.com/vufind-org/vufind/pull/1389.diff","patch_url":"https://github.com/vufind-org/vufind/pull/1389.patch","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/1389","number":1389,"state":"open","locked":false,"title":"Add configuration options for sorting hierarchical facets (homepage, advanced search, sidefacets)","user":{"login":"samuli","id":3889,"node_id":"MDQ6VXNlcjM4ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/3889?v=4","gravatar_id":"","url":"https://api.github.com/users/samuli","html_url":"https://github.com/samuli","followers_url":"https://api.github.com/users/samuli/followers","following_url":"https://api.github.com/users/samuli/following{/other_user}","gists_url":"https://api.github.com/users/samuli/gists{/gist_id}","starred_url":"https://api.github.com/users/samuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuli/subscriptions","organizations_url":"https://api.github.com/users/samuli/orgs","repos_url":"https://api.github.com/users/samuli/repos","events_url":"https://api.github.com/users/samuli/events{/privacy}","received_events_url":"https://api.github.com/users/samuli/received_events","type":"User","site_admin":false},"body":"@demiankatz We're planning to sort Advanced Search hierarchical facets by count on all levels. Rather than overriding AbstractSolrSearch::processAdvancedFacets I'm trying to figure out a more general way. I think this works if the facets are sorted by count by Solr (I'm using HierarchicalFacetHelper to sort only when sorting by displayText or top-level). (BTW: I'm out of office until 5.8.) \r\n\r\nTODO:\r\n- [ ] Consider applying the same logic to HomePage facets as well\r\n- [ ] Run full test suite","created_at":"2019-07-04T10:18:51Z","updated_at":"2019-08-21T14:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9eeb2b51c36e1014929b378aad490fb442c6e9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vufind-org/vufind/pulls/1389/commits","review_comments_url":"https://api.github.com/repos/vufind-org/vufind/pulls/1389/comments","review_comment_url":"https://api.github.com/repos/vufind-org/vufind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/1389/comments","statuses_url":"https://api.github.com/repos/vufind-org/vufind/statuses/f933dc01b252178dfc2a47e72cfa95135d22e5bc","head":{"label":"samuli:advanced-search-facet-sort2","ref":"advanced-search-facet-sort2","sha":"f933dc01b252178dfc2a47e72cfa95135d22e5bc","user":{"login":"samuli","id":3889,"node_id":"MDQ6VXNlcjM4ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/3889?v=4","gravatar_id":"","url":"https://api.github.com/users/samuli","html_url":"https://github.com/samuli","followers_url":"https://api.github.com/users/samuli/followers","following_url":"https://api.github.com/users/samuli/following{/other_user}","gists_url":"https://api.github.com/users/samuli/gists{/gist_id}","starred_url":"https://api.github.com/users/samuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuli/subscriptions","organizations_url":"https://api.github.com/users/samuli/orgs","repos_url":"https://api.github.com/users/samuli/repos","events_url":"https://api.github.com/users/samuli/events{/privacy}","received_events_url":"https://api.github.com/users/samuli/received_events","type":"User","site_admin":false},"repo":{"id":29350003,"node_id":"MDEwOlJlcG9zaXRvcnkyOTM1MDAwMw==","name":"NDL-VuFind2","full_name":"samuli/NDL-VuFind2","private":false,"owner":{"login":"samuli","id":3889,"node_id":"MDQ6VXNlcjM4ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/3889?v=4","gravatar_id":"","url":"https://api.github.com/users/samuli","html_url":"https://github.com/samuli","followers_url":"https://api.github.com/users/samuli/followers","following_url":"https://api.github.com/users/samuli/following{/other_user}","gists_url":"https://api.github.com/users/samuli/gists{/gist_id}","starred_url":"https://api.github.com/users/samuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuli/subscriptions","organizations_url":"https://api.github.com/users/samuli/orgs","repos_url":"https://api.github.com/users/samuli/repos","events_url":"https://api.github.com/users/samuli/events{/privacy}","received_events_url":"https://api.github.com/users/samuli/received_events","type":"User","site_admin":false},"html_url":"https://github.com/samuli/NDL-VuFind2","description":"NDL VuFind 2 implementation, work in progress","fork":true,"url":"https://api.github.com/repos/samuli/NDL-VuFind2","forks_url":"https://api.github.com/repos/samuli/NDL-VuFind2/forks","keys_url":"https://api.github.com/repos/samuli/NDL-VuFind2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuli/NDL-VuFind2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuli/NDL-VuFind2/teams","hooks_url":"https://api.github.com/repos/samuli/NDL-VuFind2/hooks","issue_events_url":"https://api.github.com/repos/samuli/NDL-VuFind2/issues/events{/number}","events_url":"https://api.github.com/repos/samuli/NDL-VuFind2/events","assignees_url":"https://api.github.com/repos/samuli/NDL-VuFind2/assignees{/user}","branches_url":"https://api.github.com/repos/samuli/NDL-VuFind2/branches{/branch}","tags_url":"https://api.github.com/repos/samuli/NDL-VuFind2/tags","blobs_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuli/NDL-VuFind2/statuses/{sha}","languages_url":"https://api.github.com/repos/samuli/NDL-VuFind2/languages","stargazers_url":"https://api.github.com/repos/samuli/NDL-VuFind2/stargazers","contributors_url":"https://api.github.com/repos/samuli/NDL-VuFind2/contributors","subscribers_url":"https://api.github.com/repos/samuli/NDL-VuFind2/subscribers","subscription_url":"https://api.github.com/repos/samuli/NDL-VuFind2/subscription","commits_url":"https://api.github.com/repos/samuli/NDL-VuFind2/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuli/NDL-VuFind2/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuli/NDL-VuFind2/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuli/NDL-VuFind2/contents/{+path}","compare_url":"https://api.github.com/repos/samuli/NDL-VuFind2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuli/NDL-VuFind2/merges","archive_url":"https://api.github.com/repos/samuli/NDL-VuFind2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuli/NDL-VuFind2/downloads","issues_url":"https://api.github.com/repos/samuli/NDL-VuFind2/issues{/number}","pulls_url":"https://api.github.com/repos/samuli/NDL-VuFind2/pulls{/number}","milestones_url":"https://api.github.com/repos/samuli/NDL-VuFind2/milestones{/number}","notifications_url":"https://api.github.com/repos/samuli/NDL-VuFind2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuli/NDL-VuFind2/labels{/name}","releases_url":"https://api.github.com/repos/samuli/NDL-VuFind2/releases{/id}","deployments_url":"https://api.github.com/repos/samuli/NDL-VuFind2/deployments","created_at":"2015-01-16T13:42:11Z","updated_at":"2018-10-25T06:32:36Z","pushed_at":"2019-08-21T09:52:32Z","git_url":"git://github.com/samuli/NDL-VuFind2.git","ssh_url":"git@github.com:samuli/NDL-VuFind2.git","clone_url":"https://github.com/samuli/NDL-VuFind2.git","svn_url":"https://github.com/samuli/NDL-VuFind2","homepage":"","size":377374,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vufind-org:master","ref":"master","sha":"d7182b46ebc313aab9b8a7af43baf47f32aa18a1","user":{"login":"vufind-org","id":5072328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzIzMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5072328?v=4","gravatar_id":"","url":"https://api.github.com/users/vufind-org","html_url":"https://github.com/vufind-org","followers_url":"https://api.github.com/users/vufind-org/followers","following_url":"https://api.github.com/users/vufind-org/following{/other_user}","gists_url":"https://api.github.com/users/vufind-org/gists{/gist_id}","starred_url":"https://api.github.com/users/vufind-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vufind-org/subscriptions","organizations_url":"https://api.github.com/users/vufind-org/orgs","repos_url":"https://api.github.com/users/vufind-org/repos","events_url":"https://api.github.com/users/vufind-org/events{/privacy}","received_events_url":"https://api.github.com/users/vufind-org/received_events","type":"Organization","site_admin":false},"repo":{"id":11680792,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MDc5Mg==","name":"vufind","full_name":"vufind-org/vufind","private":false,"owner":{"login":"vufind-org","id":5072328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzIzMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5072328?v=4","gravatar_id":"","url":"https://api.github.com/users/vufind-org","html_url":"https://github.com/vufind-org","followers_url":"https://api.github.com/users/vufind-org/followers","following_url":"https://api.github.com/users/vufind-org/following{/other_user}","gists_url":"https://api.github.com/users/vufind-org/gists{/gist_id}","starred_url":"https://api.github.com/users/vufind-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vufind-org/subscriptions","organizations_url":"https://api.github.com/users/vufind-org/orgs","repos_url":"https://api.github.com/users/vufind-org/repos","events_url":"https://api.github.com/users/vufind-org/events{/privacy}","received_events_url":"https://api.github.com/users/vufind-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vufind-org/vufind","description":"A library resource discovery portal designed and developed for libraries by libraries","fork":false,"url":"https://api.github.com/repos/vufind-org/vufind","forks_url":"https://api.github.com/repos/vufind-org/vufind/forks","keys_url":"https://api.github.com/repos/vufind-org/vufind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vufind-org/vufind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vufind-org/vufind/teams","hooks_url":"https://api.github.com/repos/vufind-org/vufind/hooks","issue_events_url":"https://api.github.com/repos/vufind-org/vufind/issues/events{/number}","events_url":"https://api.github.com/repos/vufind-org/vufind/events","assignees_url":"https://api.github.com/repos/vufind-org/vufind/assignees{/user}","branches_url":"https://api.github.com/repos/vufind-org/vufind/branches{/branch}","tags_url":"https://api.github.com/repos/vufind-org/vufind/tags","blobs_url":"https://api.github.com/repos/vufind-org/vufind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vufind-org/vufind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vufind-org/vufind/git/refs{/sha}","trees_url":"https://api.github.com/repos/vufind-org/vufind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vufind-org/vufind/statuses/{sha}","languages_url":"https://api.github.com/repos/vufind-org/vufind/languages","stargazers_url":"https://api.github.com/repos/vufind-org/vufind/stargazers","contributors_url":"https://api.github.com/repos/vufind-org/vufind/contributors","subscribers_url":"https://api.github.com/repos/vufind-org/vufind/subscribers","subscription_url":"https://api.github.com/repos/vufind-org/vufind/subscription","commits_url":"https://api.github.com/repos/vufind-org/vufind/commits{/sha}","git_commits_url":"https://api.github.com/repos/vufind-org/vufind/git/commits{/sha}","comments_url":"https://api.github.com/repos/vufind-org/vufind/comments{/number}","issue_comment_url":"https://api.github.com/repos/vufind-org/vufind/issues/comments{/number}","contents_url":"https://api.github.com/repos/vufind-org/vufind/contents/{+path}","compare_url":"https://api.github.com/repos/vufind-org/vufind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vufind-org/vufind/merges","archive_url":"https://api.github.com/repos/vufind-org/vufind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vufind-org/vufind/downloads","issues_url":"https://api.github.com/repos/vufind-org/vufind/issues{/number}","pulls_url":"https://api.github.com/repos/vufind-org/vufind/pulls{/number}","milestones_url":"https://api.github.com/repos/vufind-org/vufind/milestones{/number}","notifications_url":"https://api.github.com/repos/vufind-org/vufind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vufind-org/vufind/labels{/name}","releases_url":"https://api.github.com/repos/vufind-org/vufind/releases{/id}","deployments_url":"https://api.github.com/repos/vufind-org/vufind/deployments","created_at":"2013-07-26T08:05:45Z","updated_at":"2019-08-21T12:45:30Z","pushed_at":"2019-08-21T12:48:05Z","git_url":"git://github.com/vufind-org/vufind.git","ssh_url":"git@github.com:vufind-org/vufind.git","clone_url":"https://github.com/vufind-org/vufind.git","svn_url":"https://github.com/vufind-org/vufind","homepage":null,"size":344793,"stargazers_count":171,"watchers_count":171,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":242,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":242,"open_issues":20,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/1389"},"html":{"href":"https://github.com/vufind-org/vufind/pull/1389"},"issue":{"href":"https://api.github.com/repos/vufind-org/vufind/issues/1389"},"comments":{"href":"https://api.github.com/repos/vufind-org/vufind/issues/1389/comments"},"review_comments":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/1389/comments"},"review_comment":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/1389/commits"},"statuses":{"href":"https://api.github.com/repos/vufind-org/vufind/statuses/f933dc01b252178dfc2a47e72cfa95135d22e5bc"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 11680792,
"name": "vufind-org/vufind",
"url": "https://api.github.com/repos/vufind-org/vufind"
}
|
{
"id": 309069,
"login": "demiankatz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/309069?",
"url": "https://api.github.com/users/demiankatz"
}
|
{
"id": 5072328,
"login": "vufind-org",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5072328?",
"url": "https://api.github.com/orgs/vufind-org"
}
| 2019-08-21T14:47:01 |
10255091233
|
{"actor":{"display_login":"demiankatz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/comments/267202848","pull_request_review_id":216549003,"id":267202848,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzIwMjg0OA==","diff_hunk":"@@ -0,0 +1,29 @@\n+.PHONY: source-deps test release deploy clean\n+\n+VERSION ?= 1.9","path":"Makefile","position":3,"original_position":3,"commit_id":"ca75cd28334856c67e1d166455012d9e4473efc2","original_commit_id":"ca75cd28334856c67e1d166455012d9e4473efc2","user":{"login":"shen-tian","id":4621961,"node_id":"MDQ6VXNlcjQ2MjE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4621961?v=4","gravatar_id":"","url":"https://api.github.com/users/shen-tian","html_url":"https://github.com/shen-tian","followers_url":"https://api.github.com/users/shen-tian/followers","following_url":"https://api.github.com/users/shen-tian/following{/other_user}","gists_url":"https://api.github.com/users/shen-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/shen-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shen-tian/subscriptions","organizations_url":"https://api.github.com/users/shen-tian/orgs","repos_url":"https://api.github.com/users/shen-tian/repos","events_url":"https://api.github.com/users/shen-tian/events{/privacy}","received_events_url":"https://api.github.com/users/shen-tian/received_events","type":"User","site_admin":false},"body":"That's a copy+paste. I assume that's the default value? If so, will change to 1.10","created_at":"2019-03-20T06:48:52Z","updated_at":"2019-03-20T06:48:52Z","html_url":"https://github.com/clojure-emacs/refactor-nrepl/pull/242#discussion_r267202848","pull_request_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/242","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/comments/267202848"},"html":{"href":"https://github.com/clojure-emacs/refactor-nrepl/pull/242#discussion_r267202848"},"pull_request":{"href":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/242"}},"in_reply_to_id":267202672},"pull_request":{"url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/242","id":262737055,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyNzM3MDU1","html_url":"https://github.com/clojure-emacs/refactor-nrepl/pull/242","diff_url":"https://github.com/clojure-emacs/refactor-nrepl/pull/242.diff","patch_url":"https://github.com/clojure-emacs/refactor-nrepl/pull/242.patch","issue_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/issues/242","number":242,"state":"open","locked":false,"title":"CircleCI migration","user":{"login":"shen-tian","id":4621961,"node_id":"MDQ6VXNlcjQ2MjE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4621961?v=4","gravatar_id":"","url":"https://api.github.com/users/shen-tian","html_url":"https://github.com/shen-tian","followers_url":"https://api.github.com/users/shen-tian/followers","following_url":"https://api.github.com/users/shen-tian/following{/other_user}","gists_url":"https://api.github.com/users/shen-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/shen-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shen-tian/subscriptions","organizations_url":"https://api.github.com/users/shen-tian/orgs","repos_url":"https://api.github.com/users/shen-tian/repos","events_url":"https://api.github.com/users/shen-tian/events{/privacy}","received_events_url":"https://api.github.com/users/shen-tian/received_events","type":"User","site_admin":false},"body":"I added a Makefile, in attempt to bring this more in line with how the other Clojure projects in the org works. Very similar CircleCI config.\r\n\r\nhttps://circleci.com/gh/shen-tian/workflows/refactor-nrepl\r\n\r\nAs it stood, the project was tested on Oracle Java 8 and Clojure 1.8 and 1.9 in a single job. I've move that over to OpenJDK 8, added Clojure 1.10 tests, and split them up into separate jobs.\r\n\r\nI've tried to add Java 11 tests, but they are not passing. Will jot down some notes so we can investigate. Given that we are not testing on Java 11 right now, this PR is good to go.\r\n\r\nEdit: a quick look suggests that #241 addresses the Java 11 issues, as that function is where the tests are failing.","created_at":"2019-03-20T06:33:44Z","updated_at":"2019-03-20T06:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1206fbb0f621bbeaf3ed3a4a7035f04b680627c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/242/commits","review_comments_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/242/comments","review_comment_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/issues/242/comments","statuses_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/statuses/ca75cd28334856c67e1d166455012d9e4473efc2","head":{"label":"shen-tian:circleci","ref":"circleci","sha":"ca75cd28334856c67e1d166455012d9e4473efc2","user":{"login":"shen-tian","id":4621961,"node_id":"MDQ6VXNlcjQ2MjE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4621961?v=4","gravatar_id":"","url":"https://api.github.com/users/shen-tian","html_url":"https://github.com/shen-tian","followers_url":"https://api.github.com/users/shen-tian/followers","following_url":"https://api.github.com/users/shen-tian/following{/other_user}","gists_url":"https://api.github.com/users/shen-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/shen-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shen-tian/subscriptions","organizations_url":"https://api.github.com/users/shen-tian/orgs","repos_url":"https://api.github.com/users/shen-tian/repos","events_url":"https://api.github.com/users/shen-tian/events{/privacy}","received_events_url":"https://api.github.com/users/shen-tian/received_events","type":"User","site_admin":false},"repo":{"id":176581891,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY1ODE4OTE=","name":"refactor-nrepl","full_name":"shen-tian/refactor-nrepl","private":false,"owner":{"login":"shen-tian","id":4621961,"node_id":"MDQ6VXNlcjQ2MjE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4621961?v=4","gravatar_id":"","url":"https://api.github.com/users/shen-tian","html_url":"https://github.com/shen-tian","followers_url":"https://api.github.com/users/shen-tian/followers","following_url":"https://api.github.com/users/shen-tian/following{/other_user}","gists_url":"https://api.github.com/users/shen-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/shen-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shen-tian/subscriptions","organizations_url":"https://api.github.com/users/shen-tian/orgs","repos_url":"https://api.github.com/users/shen-tian/repos","events_url":"https://api.github.com/users/shen-tian/events{/privacy}","received_events_url":"https://api.github.com/users/shen-tian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shen-tian/refactor-nrepl","description":"nREPL middleware to support refactorings in an editor agnostic way","fork":true,"url":"https://api.github.com/repos/shen-tian/refactor-nrepl","forks_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/forks","keys_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/teams","hooks_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/hooks","issue_events_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/events","assignees_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/tags","blobs_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/languages","stargazers_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/stargazers","contributors_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/contributors","subscribers_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/subscribers","subscription_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/subscription","commits_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/merges","archive_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/downloads","issues_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/labels{/name}","releases_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/releases{/id}","deployments_url":"https://api.github.com/repos/shen-tian/refactor-nrepl/deployments","created_at":"2019-03-19T19:12:04Z","updated_at":"2019-03-19T19:12:06Z","pushed_at":"2019-03-20T06:47:43Z","git_url":"git://github.com/shen-tian/refactor-nrepl.git","ssh_url":"git@github.com:shen-tian/refactor-nrepl.git","clone_url":"https://github.com/shen-tian/refactor-nrepl.git","svn_url":"https://github.com/shen-tian/refactor-nrepl","homepage":null,"size":863,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clojure-emacs:master","ref":"master","sha":"17d576430632633538aed5d0e9b9348db5df6de7","user":{"login":"clojure-emacs","id":5080083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwODAwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/5080083?v=4","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"repo":{"id":21541051,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU0MTA1MQ==","name":"refactor-nrepl","full_name":"clojure-emacs/refactor-nrepl","private":false,"owner":{"login":"clojure-emacs","id":5080083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwODAwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/5080083?v=4","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clojure-emacs/refactor-nrepl","description":"nREPL middleware to support refactorings in an editor agnostic way","fork":false,"url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl","forks_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/forks","keys_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/teams","hooks_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/hooks","issue_events_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/events","assignees_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/tags","blobs_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/languages","stargazers_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/stargazers","contributors_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/contributors","subscribers_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/subscribers","subscription_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/subscription","commits_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/merges","archive_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/downloads","issues_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/labels{/name}","releases_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/releases{/id}","deployments_url":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/deployments","created_at":"2014-07-06T14:00:15Z","updated_at":"2019-03-14T18:10:26Z","pushed_at":"2019-03-20T06:33:45Z","git_url":"git://github.com/clojure-emacs/refactor-nrepl.git","ssh_url":"git@github.com:clojure-emacs/refactor-nrepl.git","clone_url":"https://github.com/clojure-emacs/refactor-nrepl.git","svn_url":"https://github.com/clojure-emacs/refactor-nrepl","homepage":null,"size":847,"stargazers_count":156,"watchers_count":156,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":47,"open_issues":18,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/242"},"html":{"href":"https://github.com/clojure-emacs/refactor-nrepl/pull/242"},"issue":{"href":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/issues/242"},"comments":{"href":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/clojure-emacs/refactor-nrepl/statuses/ca75cd28334856c67e1d166455012d9e4473efc2"}},"author_association":"NONE"}}
|
{
"id": 21541051,
"name": "clojure-emacs/refactor-nrepl",
"url": "https://api.github.com/repos/clojure-emacs/refactor-nrepl"
}
|
{
"id": 4621961,
"login": "shen-tian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4621961?",
"url": "https://api.github.com/users/shen-tian"
}
|
{
"id": 5080083,
"login": "clojure-emacs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5080083?",
"url": "https://api.github.com/orgs/clojure-emacs"
}
| 2019-03-20T06:48:52 |
9277274222
|
{"actor":{"display_login":"shen-tian"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/comments/273020931","pull_request_review_id":223812104,"id":273020931,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzAyMDkzMQ==","diff_hunk":"@@ -337,6 +340,20 @@ void CreateGxsForumMsg::loadFormInformation()\n \t//ui.forumMessage->setText(\"\");\n }\n \n+void CreateGxsForumMsg::checkLength()\n+{\n+\tQString text;\n+\tRsHtml::optimizeHtml(ui.forumMessage, text);\n+\tstd::wstring msg = text.toStdWString();\n+\tint charRemains = 199000 - msg.length(); // MAX_ALLOWED_GXS_MESSAGE_SIZE","path":"retroshare-gui/src/gui/gxsforums/CreateGxsForumMsg.cpp","position":26,"original_position":26,"commit_id":"a9cf0ab10a9ba4a620f7e0592d4a4e73c59b2326","original_commit_id":"a9cf0ab10a9ba4a620f7e0592d4a4e73c59b2326","user":{"login":"hunbernd","id":4907599,"node_id":"MDQ6VXNlcjQ5MDc1OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4907599?v=4","gravatar_id":"","url":"https://api.github.com/users/hunbernd","html_url":"https://github.com/hunbernd","followers_url":"https://api.github.com/users/hunbernd/followers","following_url":"https://api.github.com/users/hunbernd/following{/other_user}","gists_url":"https://api.github.com/users/hunbernd/gists{/gist_id}","starred_url":"https://api.github.com/users/hunbernd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunbernd/subscriptions","organizations_url":"https://api.github.com/users/hunbernd/orgs","repos_url":"https://api.github.com/users/hunbernd/repos","events_url":"https://api.github.com/users/hunbernd/events{/privacy}","received_events_url":"https://api.github.com/users/hunbernd/received_events","type":"User","site_admin":false},"body":"Do not hardcode the value, use the MAX_ALLOWED_GXS_MESSAGE_SIZE instead!","created_at":"2019-04-08T12:31:25Z","updated_at":"2019-04-08T12:32:27Z","html_url":"https://github.com/RetroShare/RetroShare/pull/1514#discussion_r273020931","pull_request_url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/1514","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/comments/273020931"},"html":{"href":"https://github.com/RetroShare/RetroShare/pull/1514#discussion_r273020931"},"pull_request":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/1514"}}},"pull_request":{"url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/1514","id":268309880,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4MzA5ODgw","html_url":"https://github.com/RetroShare/RetroShare/pull/1514","diff_url":"https://github.com/RetroShare/RetroShare/pull/1514.diff","patch_url":"https://github.com/RetroShare/RetroShare/pull/1514.patch","issue_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/1514","number":1514,"state":"open","locked":false,"title":"attach picture button in forum post dialog; message size check","user":{"login":"RetroPooh","id":24979253,"node_id":"MDQ6VXNlcjI0OTc5MjUz","avatar_url":"https://avatars3.githubusercontent.com/u/24979253?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroPooh","html_url":"https://github.com/RetroPooh","followers_url":"https://api.github.com/users/RetroPooh/followers","following_url":"https://api.github.com/users/RetroPooh/following{/other_user}","gists_url":"https://api.github.com/users/RetroPooh/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroPooh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroPooh/subscriptions","organizations_url":"https://api.github.com/users/RetroPooh/orgs","repos_url":"https://api.github.com/users/RetroPooh/repos","events_url":"https://api.github.com/users/RetroPooh/events{/privacy}","received_events_url":"https://api.github.com/users/RetroPooh/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-08T12:17:25Z","updated_at":"2019-04-08T12:32:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95788e87a2017018ef8bcafcce780284cdd2d0ba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/1514/commits","review_comments_url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/1514/comments","review_comment_url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/1514/comments","statuses_url":"https://api.github.com/repos/RetroShare/RetroShare/statuses/a9cf0ab10a9ba4a620f7e0592d4a4e73c59b2326","head":{"label":"RetroPooh:forumattachimagebutton","ref":"forumattachimagebutton","sha":"a9cf0ab10a9ba4a620f7e0592d4a4e73c59b2326","user":{"login":"RetroPooh","id":24979253,"node_id":"MDQ6VXNlcjI0OTc5MjUz","avatar_url":"https://avatars3.githubusercontent.com/u/24979253?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroPooh","html_url":"https://github.com/RetroPooh","followers_url":"https://api.github.com/users/RetroPooh/followers","following_url":"https://api.github.com/users/RetroPooh/following{/other_user}","gists_url":"https://api.github.com/users/RetroPooh/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroPooh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroPooh/subscriptions","organizations_url":"https://api.github.com/users/RetroPooh/orgs","repos_url":"https://api.github.com/users/RetroPooh/repos","events_url":"https://api.github.com/users/RetroPooh/events{/privacy}","received_events_url":"https://api.github.com/users/RetroPooh/received_events","type":"User","site_admin":false},"repo":{"id":78298352,"node_id":"MDEwOlJlcG9zaXRvcnk3ODI5ODM1Mg==","name":"RetroShare-EXP","full_name":"RetroPooh/RetroShare-EXP","private":false,"owner":{"login":"RetroPooh","id":24979253,"node_id":"MDQ6VXNlcjI0OTc5MjUz","avatar_url":"https://avatars3.githubusercontent.com/u/24979253?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroPooh","html_url":"https://github.com/RetroPooh","followers_url":"https://api.github.com/users/RetroPooh/followers","following_url":"https://api.github.com/users/RetroPooh/following{/other_user}","gists_url":"https://api.github.com/users/RetroPooh/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroPooh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroPooh/subscriptions","organizations_url":"https://api.github.com/users/RetroPooh/orgs","repos_url":"https://api.github.com/users/RetroPooh/repos","events_url":"https://api.github.com/users/RetroPooh/events{/privacy}","received_events_url":"https://api.github.com/users/RetroPooh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RetroPooh/RetroShare-EXP","description":"RetroShare is a Free and Open Source cross-platform, Friend-2-Friend and secure decentralised communication platform. (upstream Repository)","fork":true,"url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP","forks_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/forks","keys_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/teams","hooks_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/hooks","issue_events_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/issues/events{/number}","events_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/events","assignees_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/assignees{/user}","branches_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/branches{/branch}","tags_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/tags","blobs_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/git/refs{/sha}","trees_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/statuses/{sha}","languages_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/languages","stargazers_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/stargazers","contributors_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/contributors","subscribers_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/subscribers","subscription_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/subscription","commits_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/commits{/sha}","git_commits_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/git/commits{/sha}","comments_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/comments{/number}","issue_comment_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/issues/comments{/number}","contents_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/contents/{+path}","compare_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/merges","archive_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/downloads","issues_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/issues{/number}","pulls_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/pulls{/number}","milestones_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/milestones{/number}","notifications_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/labels{/name}","releases_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/releases{/id}","deployments_url":"https://api.github.com/repos/RetroPooh/RetroShare-EXP/deployments","created_at":"2017-01-07T19:13:11Z","updated_at":"2017-01-07T20:13:22Z","pushed_at":"2019-04-08T12:12:46Z","git_url":"git://github.com/RetroPooh/RetroShare-EXP.git","ssh_url":"git@github.com:RetroPooh/RetroShare-EXP.git","clone_url":"https://github.com/RetroPooh/RetroShare-EXP.git","svn_url":"https://github.com/RetroPooh/RetroShare-EXP","homepage":"https://retroshare.github.io/","size":106802,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RetroShare:master","ref":"master","sha":"da088746de5e8afddc6eb179cb60162dd5027c40","user":{"login":"RetroShare","id":5185222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxODUyMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5185222?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroShare","html_url":"https://github.com/RetroShare","followers_url":"https://api.github.com/users/RetroShare/followers","following_url":"https://api.github.com/users/RetroShare/following{/other_user}","gists_url":"https://api.github.com/users/RetroShare/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroShare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroShare/subscriptions","organizations_url":"https://api.github.com/users/RetroShare/orgs","repos_url":"https://api.github.com/users/RetroShare/repos","events_url":"https://api.github.com/users/RetroShare/events{/privacy}","received_events_url":"https://api.github.com/users/RetroShare/received_events","type":"Organization","site_admin":false},"repo":{"id":40011265,"node_id":"MDEwOlJlcG9zaXRvcnk0MDAxMTI2NQ==","name":"RetroShare","full_name":"RetroShare/RetroShare","private":false,"owner":{"login":"RetroShare","id":5185222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxODUyMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5185222?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroShare","html_url":"https://github.com/RetroShare","followers_url":"https://api.github.com/users/RetroShare/followers","following_url":"https://api.github.com/users/RetroShare/following{/other_user}","gists_url":"https://api.github.com/users/RetroShare/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroShare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroShare/subscriptions","organizations_url":"https://api.github.com/users/RetroShare/orgs","repos_url":"https://api.github.com/users/RetroShare/repos","events_url":"https://api.github.com/users/RetroShare/events{/privacy}","received_events_url":"https://api.github.com/users/RetroShare/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RetroShare/RetroShare","description":"RetroShare is a Free and Open Source cross-platform, Friend-2-Friend and secure decentralised communication platform.","fork":false,"url":"https://api.github.com/repos/RetroShare/RetroShare","forks_url":"https://api.github.com/repos/RetroShare/RetroShare/forks","keys_url":"https://api.github.com/repos/RetroShare/RetroShare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RetroShare/RetroShare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RetroShare/RetroShare/teams","hooks_url":"https://api.github.com/repos/RetroShare/RetroShare/hooks","issue_events_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/events{/number}","events_url":"https://api.github.com/repos/RetroShare/RetroShare/events","assignees_url":"https://api.github.com/repos/RetroShare/RetroShare/assignees{/user}","branches_url":"https://api.github.com/repos/RetroShare/RetroShare/branches{/branch}","tags_url":"https://api.github.com/repos/RetroShare/RetroShare/tags","blobs_url":"https://api.github.com/repos/RetroShare/RetroShare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RetroShare/RetroShare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RetroShare/RetroShare/git/refs{/sha}","trees_url":"https://api.github.com/repos/RetroShare/RetroShare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RetroShare/RetroShare/statuses/{sha}","languages_url":"https://api.github.com/repos/RetroShare/RetroShare/languages","stargazers_url":"https://api.github.com/repos/RetroShare/RetroShare/stargazers","contributors_url":"https://api.github.com/repos/RetroShare/RetroShare/contributors","subscribers_url":"https://api.github.com/repos/RetroShare/RetroShare/subscribers","subscription_url":"https://api.github.com/repos/RetroShare/RetroShare/subscription","commits_url":"https://api.github.com/repos/RetroShare/RetroShare/commits{/sha}","git_commits_url":"https://api.github.com/repos/RetroShare/RetroShare/git/commits{/sha}","comments_url":"https://api.github.com/repos/RetroShare/RetroShare/comments{/number}","issue_comment_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/comments{/number}","contents_url":"https://api.github.com/repos/RetroShare/RetroShare/contents/{+path}","compare_url":"https://api.github.com/repos/RetroShare/RetroShare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RetroShare/RetroShare/merges","archive_url":"https://api.github.com/repos/RetroShare/RetroShare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RetroShare/RetroShare/downloads","issues_url":"https://api.github.com/repos/RetroShare/RetroShare/issues{/number}","pulls_url":"https://api.github.com/repos/RetroShare/RetroShare/pulls{/number}","milestones_url":"https://api.github.com/repos/RetroShare/RetroShare/milestones{/number}","notifications_url":"https://api.github.com/repos/RetroShare/RetroShare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RetroShare/RetroShare/labels{/name}","releases_url":"https://api.github.com/repos/RetroShare/RetroShare/releases{/id}","deployments_url":"https://api.github.com/repos/RetroShare/RetroShare/deployments","created_at":"2015-07-31T15:16:42Z","updated_at":"2019-04-07T02:27:11Z","pushed_at":"2019-04-08T12:17:26Z","git_url":"git://github.com/RetroShare/RetroShare.git","ssh_url":"git@github.com:RetroShare/RetroShare.git","clone_url":"https://github.com/RetroShare/RetroShare.git","svn_url":"https://github.com/RetroShare/RetroShare","homepage":"https://retroshare.cc/","size":109462,"stargazers_count":845,"watchers_count":845,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":288,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":174,"open_issues":288,"watchers":845,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/1514"},"html":{"href":"https://github.com/RetroShare/RetroShare/pull/1514"},"issue":{"href":"https://api.github.com/repos/RetroShare/RetroShare/issues/1514"},"comments":{"href":"https://api.github.com/repos/RetroShare/RetroShare/issues/1514/comments"},"review_comments":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/1514/comments"},"review_comment":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/1514/commits"},"statuses":{"href":"https://api.github.com/repos/RetroShare/RetroShare/statuses/a9cf0ab10a9ba4a620f7e0592d4a4e73c59b2326"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 40011265,
"name": "RetroShare/RetroShare",
"url": "https://api.github.com/repos/RetroShare/RetroShare"
}
|
{
"id": 4907599,
"login": "hunbernd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4907599?",
"url": "https://api.github.com/users/hunbernd"
}
|
{
"id": 5185222,
"login": "RetroShare",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5185222?",
"url": "https://api.github.com/orgs/RetroShare"
}
| 2019-04-08T12:31:25 |
9398536628
|
{"actor":{"display_login":"hunbernd"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hyperopt/hyperopt/pulls/comments/291492371","pull_request_review_id":246950773,"id":291492371,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTQ5MjM3MQ==","diff_hunk":"@@ -0,0 +1,19 @@\n+Running unit tests\n+==============\n+\n+To run the unit tests, run the `run-tests.sh` script. You will need to set these environment variables:\n+\n+- `SPARK_HOME`: your local copy of Apache Spark. Look at download_spark_dependencies.sh for more details.\n+- `HYPEROPT_FMIN_SEED`: the random seed. You need to get its value from `.travis.yml`.\n+\n+For example:\n+\n+```bash\n+hyperopt$ HYPEROPT_FMIN_SEED=3 SPARK_HOME=/usr/local/lib/spark-2.4.0-bin-hadoop2.7 ./run_tests.sh","path":"unit-test.md","position":12,"original_position":12,"commit_id":"9945982a988b39dd5d702c6d0d3c4de679dfad63","original_commit_id":"9945982a988b39dd5d702c6d0d3c4de679dfad63","user":{"login":"maxpumperla","id":3462566,"node_id":"MDQ6VXNlcjM0NjI1NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3462566?v=4","gravatar_id":"","url":"https://api.github.com/users/maxpumperla","html_url":"https://github.com/maxpumperla","followers_url":"https://api.github.com/users/maxpumperla/followers","following_url":"https://api.github.com/users/maxpumperla/following{/other_user}","gists_url":"https://api.github.com/users/maxpumperla/gists{/gist_id}","starred_url":"https://api.github.com/users/maxpumperla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxpumperla/subscriptions","organizations_url":"https://api.github.com/users/maxpumperla/orgs","repos_url":"https://api.github.com/users/maxpumperla/repos","events_url":"https://api.github.com/users/maxpumperla/events{/privacy}","received_events_url":"https://api.github.com/users/maxpumperla/received_events","type":"User","site_admin":false},"body":"Do you have explicit recommendations which Spark version to use? If so, we should document that.","created_at":"2019-06-07T08:14:04Z","updated_at":"2019-06-07T08:20:11Z","html_url":"https://github.com/hyperopt/hyperopt/pull/509#discussion_r291492371","pull_request_url":"https://api.github.com/repos/hyperopt/hyperopt/pulls/509","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperopt/hyperopt/pulls/comments/291492371"},"html":{"href":"https://github.com/hyperopt/hyperopt/pull/509#discussion_r291492371"},"pull_request":{"href":"https://api.github.com/repos/hyperopt/hyperopt/pulls/509"}}},"pull_request":{"url":"https://api.github.com/repos/hyperopt/hyperopt/pulls/509","id":286000717,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2MDAwNzE3","html_url":"https://github.com/hyperopt/hyperopt/pull/509","diff_url":"https://github.com/hyperopt/hyperopt/pull/509.diff","patch_url":"https://github.com/hyperopt/hyperopt/pull/509.patch","issue_url":"https://api.github.com/repos/hyperopt/hyperopt/issues/509","number":509,"state":"open","locked":false,"title":"Add SparkTrials","user":{"login":"hanyucui","id":9649417,"node_id":"MDQ6VXNlcjk2NDk0MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9649417?v=4","gravatar_id":"","url":"https://api.github.com/users/hanyucui","html_url":"https://github.com/hanyucui","followers_url":"https://api.github.com/users/hanyucui/followers","following_url":"https://api.github.com/users/hanyucui/following{/other_user}","gists_url":"https://api.github.com/users/hanyucui/gists{/gist_id}","starred_url":"https://api.github.com/users/hanyucui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanyucui/subscriptions","organizations_url":"https://api.github.com/users/hanyucui/orgs","repos_url":"https://api.github.com/users/hanyucui/repos","events_url":"https://api.github.com/users/hanyucui/events{/privacy}","received_events_url":"https://api.github.com/users/hanyucui/received_events","type":"User","site_admin":false},"body":"This PR integrates hyperopt with Apache Spark clusters. The goal is to provide users a scalable distributed hyperopt implementation under the hood. This is limited to hyperopt tasks which can run on a single machine, e.g., for scikit-learn.\r\n\r\nA `SparkTrials` type is added to distribute trial runs across a Spark cluster. It uses concurrent Spark jobs for running asynchronous hyperopt tasks on Spark executors.\r\n\r\nThis PR is based on this [design doc](https://docs.google.com/document/d/1R-qMVOYxaLw3HdqMiTADQDZ5z7uInMR-x42HFCXu2-s/edit), which was discussed with @maxpumperla. Contributors include @WeichenXu123, @lu-wang-dl, @jkbradley, and the author.\r\n","created_at":"2019-06-06T23:12:43Z","updated_at":"2019-06-07T08:20:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59c599326e8702a096f60587646b17c705e0a30d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperopt/hyperopt/pulls/509/commits","review_comments_url":"https://api.github.com/repos/hyperopt/hyperopt/pulls/509/comments","review_comment_url":"https://api.github.com/repos/hyperopt/hyperopt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperopt/hyperopt/issues/509/comments","statuses_url":"https://api.github.com/repos/hyperopt/hyperopt/statuses/9945982a988b39dd5d702c6d0d3c4de679dfad63","head":{"label":"hanyucui:add-sparktrials","ref":"add-sparktrials","sha":"9945982a988b39dd5d702c6d0d3c4de679dfad63","user":{"login":"hanyucui","id":9649417,"node_id":"MDQ6VXNlcjk2NDk0MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9649417?v=4","gravatar_id":"","url":"https://api.github.com/users/hanyucui","html_url":"https://github.com/hanyucui","followers_url":"https://api.github.com/users/hanyucui/followers","following_url":"https://api.github.com/users/hanyucui/following{/other_user}","gists_url":"https://api.github.com/users/hanyucui/gists{/gist_id}","starred_url":"https://api.github.com/users/hanyucui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanyucui/subscriptions","organizations_url":"https://api.github.com/users/hanyucui/orgs","repos_url":"https://api.github.com/users/hanyucui/repos","events_url":"https://api.github.com/users/hanyucui/events{/privacy}","received_events_url":"https://api.github.com/users/hanyucui/received_events","type":"User","site_admin":false},"repo":{"id":190659269,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA2NTkyNjk=","name":"hyperopt","full_name":"hanyucui/hyperopt","private":false,"owner":{"login":"hanyucui","id":9649417,"node_id":"MDQ6VXNlcjk2NDk0MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9649417?v=4","gravatar_id":"","url":"https://api.github.com/users/hanyucui","html_url":"https://github.com/hanyucui","followers_url":"https://api.github.com/users/hanyucui/followers","following_url":"https://api.github.com/users/hanyucui/following{/other_user}","gists_url":"https://api.github.com/users/hanyucui/gists{/gist_id}","starred_url":"https://api.github.com/users/hanyucui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanyucui/subscriptions","organizations_url":"https://api.github.com/users/hanyucui/orgs","repos_url":"https://api.github.com/users/hanyucui/repos","events_url":"https://api.github.com/users/hanyucui/events{/privacy}","received_events_url":"https://api.github.com/users/hanyucui/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hanyucui/hyperopt","description":"Distributed Asynchronous Hyperparameter Optimization in Python","fork":true,"url":"https://api.github.com/repos/hanyucui/hyperopt","forks_url":"https://api.github.com/repos/hanyucui/hyperopt/forks","keys_url":"https://api.github.com/repos/hanyucui/hyperopt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hanyucui/hyperopt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hanyucui/hyperopt/teams","hooks_url":"https://api.github.com/repos/hanyucui/hyperopt/hooks","issue_events_url":"https://api.github.com/repos/hanyucui/hyperopt/issues/events{/number}","events_url":"https://api.github.com/repos/hanyucui/hyperopt/events","assignees_url":"https://api.github.com/repos/hanyucui/hyperopt/assignees{/user}","branches_url":"https://api.github.com/repos/hanyucui/hyperopt/branches{/branch}","tags_url":"https://api.github.com/repos/hanyucui/hyperopt/tags","blobs_url":"https://api.github.com/repos/hanyucui/hyperopt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hanyucui/hyperopt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hanyucui/hyperopt/git/refs{/sha}","trees_url":"https://api.github.com/repos/hanyucui/hyperopt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hanyucui/hyperopt/statuses/{sha}","languages_url":"https://api.github.com/repos/hanyucui/hyperopt/languages","stargazers_url":"https://api.github.com/repos/hanyucui/hyperopt/stargazers","contributors_url":"https://api.github.com/repos/hanyucui/hyperopt/contributors","subscribers_url":"https://api.github.com/repos/hanyucui/hyperopt/subscribers","subscription_url":"https://api.github.com/repos/hanyucui/hyperopt/subscription","commits_url":"https://api.github.com/repos/hanyucui/hyperopt/commits{/sha}","git_commits_url":"https://api.github.com/repos/hanyucui/hyperopt/git/commits{/sha}","comments_url":"https://api.github.com/repos/hanyucui/hyperopt/comments{/number}","issue_comment_url":"https://api.github.com/repos/hanyucui/hyperopt/issues/comments{/number}","contents_url":"https://api.github.com/repos/hanyucui/hyperopt/contents/{+path}","compare_url":"https://api.github.com/repos/hanyucui/hyperopt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hanyucui/hyperopt/merges","archive_url":"https://api.github.com/repos/hanyucui/hyperopt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hanyucui/hyperopt/downloads","issues_url":"https://api.github.com/repos/hanyucui/hyperopt/issues{/number}","pulls_url":"https://api.github.com/repos/hanyucui/hyperopt/pulls{/number}","milestones_url":"https://api.github.com/repos/hanyucui/hyperopt/milestones{/number}","notifications_url":"https://api.github.com/repos/hanyucui/hyperopt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hanyucui/hyperopt/labels{/name}","releases_url":"https://api.github.com/repos/hanyucui/hyperopt/releases{/id}","deployments_url":"https://api.github.com/repos/hanyucui/hyperopt/deployments","created_at":"2019-06-06T22:46:25Z","updated_at":"2019-06-06T22:46:27Z","pushed_at":"2019-06-06T23:02:58Z","git_url":"git://github.com/hanyucui/hyperopt.git","ssh_url":"git@github.com:hanyucui/hyperopt.git","clone_url":"https://github.com/hanyucui/hyperopt.git","svn_url":"https://github.com/hanyucui/hyperopt","homepage":"http://hyperopt.github.io/hyperopt","size":3662,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperopt:master","ref":"master","sha":"762e89f14af8a6bacbcf258f8b5db063e297bcca","user":{"login":"hyperopt","id":5280805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODA4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5280805?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperopt","html_url":"https://github.com/hyperopt","followers_url":"https://api.github.com/users/hyperopt/followers","following_url":"https://api.github.com/users/hyperopt/following{/other_user}","gists_url":"https://api.github.com/users/hyperopt/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperopt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperopt/subscriptions","organizations_url":"https://api.github.com/users/hyperopt/orgs","repos_url":"https://api.github.com/users/hyperopt/repos","events_url":"https://api.github.com/users/hyperopt/events{/privacy}","received_events_url":"https://api.github.com/users/hyperopt/received_events","type":"Organization","site_admin":false},"repo":{"id":2337852,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM3ODUy","name":"hyperopt","full_name":"hyperopt/hyperopt","private":false,"owner":{"login":"hyperopt","id":5280805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODA4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5280805?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperopt","html_url":"https://github.com/hyperopt","followers_url":"https://api.github.com/users/hyperopt/followers","following_url":"https://api.github.com/users/hyperopt/following{/other_user}","gists_url":"https://api.github.com/users/hyperopt/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperopt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperopt/subscriptions","organizations_url":"https://api.github.com/users/hyperopt/orgs","repos_url":"https://api.github.com/users/hyperopt/repos","events_url":"https://api.github.com/users/hyperopt/events{/privacy}","received_events_url":"https://api.github.com/users/hyperopt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyperopt/hyperopt","description":"Distributed Asynchronous Hyperparameter Optimization in Python","fork":false,"url":"https://api.github.com/repos/hyperopt/hyperopt","forks_url":"https://api.github.com/repos/hyperopt/hyperopt/forks","keys_url":"https://api.github.com/repos/hyperopt/hyperopt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperopt/hyperopt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperopt/hyperopt/teams","hooks_url":"https://api.github.com/repos/hyperopt/hyperopt/hooks","issue_events_url":"https://api.github.com/repos/hyperopt/hyperopt/issues/events{/number}","events_url":"https://api.github.com/repos/hyperopt/hyperopt/events","assignees_url":"https://api.github.com/repos/hyperopt/hyperopt/assignees{/user}","branches_url":"https://api.github.com/repos/hyperopt/hyperopt/branches{/branch}","tags_url":"https://api.github.com/repos/hyperopt/hyperopt/tags","blobs_url":"https://api.github.com/repos/hyperopt/hyperopt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperopt/hyperopt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperopt/hyperopt/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperopt/hyperopt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperopt/hyperopt/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperopt/hyperopt/languages","stargazers_url":"https://api.github.com/repos/hyperopt/hyperopt/stargazers","contributors_url":"https://api.github.com/repos/hyperopt/hyperopt/contributors","subscribers_url":"https://api.github.com/repos/hyperopt/hyperopt/subscribers","subscription_url":"https://api.github.com/repos/hyperopt/hyperopt/subscription","commits_url":"https://api.github.com/repos/hyperopt/hyperopt/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperopt/hyperopt/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperopt/hyperopt/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperopt/hyperopt/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperopt/hyperopt/contents/{+path}","compare_url":"https://api.github.com/repos/hyperopt/hyperopt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperopt/hyperopt/merges","archive_url":"https://api.github.com/repos/hyperopt/hyperopt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperopt/hyperopt/downloads","issues_url":"https://api.github.com/repos/hyperopt/hyperopt/issues{/number}","pulls_url":"https://api.github.com/repos/hyperopt/hyperopt/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperopt/hyperopt/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperopt/hyperopt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperopt/hyperopt/labels{/name}","releases_url":"https://api.github.com/repos/hyperopt/hyperopt/releases{/id}","deployments_url":"https://api.github.com/repos/hyperopt/hyperopt/deployments","created_at":"2011-09-06T22:24:59Z","updated_at":"2019-06-07T00:02:51Z","pushed_at":"2019-06-06T23:12:43Z","git_url":"git://github.com/hyperopt/hyperopt.git","ssh_url":"git@github.com:hyperopt/hyperopt.git","clone_url":"https://github.com/hyperopt/hyperopt.git","svn_url":"https://github.com/hyperopt/hyperopt","homepage":"http://hyperopt.github.io/hyperopt","size":3641,"stargazers_count":3431,"watchers_count":3431,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":620,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":226,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":620,"open_issues":226,"watchers":3431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperopt/hyperopt/pulls/509"},"html":{"href":"https://github.com/hyperopt/hyperopt/pull/509"},"issue":{"href":"https://api.github.com/repos/hyperopt/hyperopt/issues/509"},"comments":{"href":"https://api.github.com/repos/hyperopt/hyperopt/issues/509/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperopt/hyperopt/pulls/509/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperopt/hyperopt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperopt/hyperopt/pulls/509/commits"},"statuses":{"href":"https://api.github.com/repos/hyperopt/hyperopt/statuses/9945982a988b39dd5d702c6d0d3c4de679dfad63"}},"author_association":"NONE"}}
|
{
"id": 2337852,
"name": "hyperopt/hyperopt",
"url": "https://api.github.com/repos/hyperopt/hyperopt"
}
|
{
"id": 3462566,
"login": "maxpumperla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3462566?",
"url": "https://api.github.com/users/maxpumperla"
}
|
{
"id": 5280805,
"login": "hyperopt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5280805?",
"url": "https://api.github.com/orgs/hyperopt"
}
| 2019-06-07T08:14:04 |
9777161665
|
{"actor":{"display_login":"maxpumperla"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/comments/314673081","pull_request_review_id":275884170,"id":314673081,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDY3MzA4MQ==","diff_hunk":"@@ -0,0 +1,234 @@\n+:host ::ng-deep {\n+ .fintech-icons {\n+ display: flex;\n+ align-items: center;\n+ igx-icon {\n+ font-size: 16px;\n+ width: 16px;\n+ height: 16px;\n+ margin-left: 4px;\n+ }\n+ }\n+ .igx-grid__grouparea {\n+ max-height: 100%;\n+ height: auto;\n+ }\n+ .changePos,\n+ .changeNeg,\n+ .strongPositive,\n+ .strongNegative {\n+ color: #fff !important;\n+ .igx-grid__td-text {\n+ padding: 2px 5px;\n+ }\n+ }\n+ .positive {\n+ color: #4eb862 !important;\n+ }\n+ .positive.strongPositive {\n+ .igx-grid__td-text {\n+ color: rgba(78, 184, 98, 0.8) !important;\n+ }\n+ }\n+ .negative {\n+ color: #d31642 !important;\n+ }\n+ .negative.strongNegative {\n+ .igx-grid__td-text {\n+ color: rgba(255, 19, 74, 0.8) !important;\n+ }\n+ }\n+ // NORMAL\n+ // positive\n+ .changePos {\n+ .igx-grid__td-text {\n+ background: #335e3b;\n+ }\n+ }\n+ .changePos1 {\n+ background: #335e3b;\n+ color: #fff;\n+ }\n+ .changePos2 {\n+ .igx-grid__td-text {\n+ border-right: 4px solid #335e3b;\n+ padding-right: 4px;\n+ }\n+ }\n+ // negative\n+ .changeNeg {\n+ .igx-grid__td-text {\n+ background: #7a1c32;\n+ }\n+ }\n+ .changeNeg1 {\n+ color: #fff;\n+ background: #7a1c32;\n+ }\n+ .changeNeg2 {\n+ .igx-grid__td-text {\n+ border-right: 4px solid #7a1c32;\n+ padding-right: 4px;\n+ }\n+ }\n+ // selected\n+ .igx-grid__td--selected.changePos1,\n+ .igx-grid__td--selected.changePos2,\n+ .igx-grid__td--selected.changePos {\n+ background-color: #335e3b !important;\n+ .fintech-icons,\n+ .igx-grid__td-text {\n+ color: #fff;\n+ }\n+ }\n+ .igx-grid__td--selected.changeNeg1,\n+ .igx-grid__td--selected.changeNeg2,\n+ .igx-grid__td--selected.changeNeg {\n+ background-color: #7a1c32 !important;\n+ .fintech-icons,\n+ .igx-grid__td-text {\n+ color: #fff;\n+ }\n+ }\n+ // STRONG\n+ // positive\n+ .strongPositive {\n+ .igx-grid__td-text {\n+ background: #459a55;\n+ }\n+ }\n+ .strongPositive1 {\n+ background: #459a55;\n+ color: #fff;\n+ }\n+ .strongPositive2 {\n+ .igx-grid__td-text {\n+ border-right: 4px solid #459a55;\n+ padding-right: 4px;\n+ }\n+ }\n+ // negative\n+ .strongNegative {\n+ .igx-grid__td-text {\n+ background: #d31642;\n+ color: #fff;\n+ }\n+ }\n+ .strongNegative1 {\n+ background: #d31642;\n+ color: #fff;\n+ }\n+ .strongNegative2 {\n+ .igx-grid__td-text {\n+ border-right: 4px solid #d31642;\n+ padding-right: 4px;\n+ }\n+ }\n+ // selected\n+ .igx-grid__td--selected.strongPositive1,\n+ .igx-grid__td--selected.strongPositive2,\n+ .igx-grid__td--selected.strongPositive {\n+ background-color: #459a55 !important;\n+ .fintech-icons,\n+ .igx-grid__td-text {\n+ color: #fff;\n+ }\n+ }\n+ .igx-grid__td--selected.strongNegative1,\n+ .igx-grid__td--selected.strongNegative2,\n+ .igx-grid__td--selected.strongNegative {\n+ background-color: #d31642 !important;\n+ .fintech-icons,\n+ .igx-grid__td-text {\n+ color: #fff;\n+ }\n+ }\n+ .controls-holder {\n+ display: flex;\n+ justify-content: space-between;\n+ align-items: center;\n+ flex-wrap: wrap;\n+ }\n+ .switches {\n+ display: flex;\n+ justify-content: space-between;\n+ align-items: center;\n+ flex: 1 0 0%;\n+ min-width: 500px;\n+ padding-right: 20px;\n+ font-size: 0.9rem;\n+ margin-bottom: -20px;\n+ }\n+ .control-item {\n+ padding-right: 20px;\n+ }\n+ .igx-slider,\n+ .igx-slider--disabled {\n+ height: 24px;\n+ }\n+ .fintech-slider {\n+ width: 40%;\n+ min-width: 145px;\n+ }\n+ .fintech-play-controls {\n+ width: 45%;\n+ min-width: 500px;\n+ margin-top: 20px;\n+ }\n+ .sample-toolbar {\n+ height: 20px;\n+ font-size: 0.8rem;\n+ line-height: 20px;\n+ }\n+ .fin-dark-theme {\n+ .fintech-slider,\n+ .sample-toolbar {\n+ color: rgba(255, 255, 255, 0.87);\n+ }\n+ }\n+ .igx-grid__outlet span,\n+ .igx-excel-filter span,\n+ .igx-excel-filter header,\n+ .igx-excel-filter input {\n+ font-size: 0.8125rem;\n+ }\n+ // .igx-button-group > .igx-button--compact {\n+ // height: 1rem;\n+ // min-height: 1.5rem;\n+ // }\n+ // .igx-button-group > .igx-button--cosy {\n+ // height: 1rem;\n+ // min-height: 1.875rem;\n+ // }\n+}\n+\n+.grid__wrapper {\n+ padding: 5px 15px;\n+ height: 100%;\n+}\n+\n+ // Custom Dark Theme\n+\n+ // Import the theme utilities first\n+@import '~igniteui-angular/lib/core/styles/themes/utilities';\n+@import '~igniteui-angular/lib/core/styles/themes/index';\n+@include igx-core();\n+@include igx-theme($default-palette);\n+\n+ @import '../themes/mixins';\n+\n+ @include scrollbar-love();","path":"templates/angular/igx-ts/custom-templates/tree-grid-finjs/files/src/app/__path__/__name__.component.scss","position":220,"original_position":220,"commit_id":"906564ff41a2969939498cbb7f94f58e07e2aecd","original_commit_id":"906564ff41a2969939498cbb7f94f58e07e2aecd","user":{"login":"ViktorSlavov","id":24314672,"node_id":"MDQ6VXNlcjI0MzE0Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/24314672?v=4","gravatar_id":"","url":"https://api.github.com/users/ViktorSlavov","html_url":"https://github.com/ViktorSlavov","followers_url":"https://api.github.com/users/ViktorSlavov/followers","following_url":"https://api.github.com/users/ViktorSlavov/following{/other_user}","gists_url":"https://api.github.com/users/ViktorSlavov/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorSlavov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorSlavov/subscriptions","organizations_url":"https://api.github.com/users/ViktorSlavov/orgs","repos_url":"https://api.github.com/users/ViktorSlavov/repos","events_url":"https://api.github.com/users/ViktorSlavov/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorSlavov/received_events","type":"User","site_admin":false},"body":"move this include inside of the below `::ng-deep` selector, so that the scrollbars are properly affected","created_at":"2019-08-16T10:53:49Z","updated_at":"2019-08-16T10:59:04Z","html_url":"https://github.com/IgniteUI/igniteui-cli/pull/549#discussion_r314673081","pull_request_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/549","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/comments/314673081"},"html":{"href":"https://github.com/IgniteUI/igniteui-cli/pull/549#discussion_r314673081"},"pull_request":{"href":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/549"}}},"pull_request":{"url":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/549","id":307682500,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3NjgyNTAw","html_url":"https://github.com/IgniteUI/igniteui-cli/pull/549","diff_url":"https://github.com/IgniteUI/igniteui-cli/pull/549.diff","patch_url":"https://github.com/IgniteUI/igniteui-cli/pull/549.patch","issue_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues/549","number":549,"state":"open","locked":false,"title":"Adding Tree Grid FinTech template","user":{"login":"dafo","id":2778393,"node_id":"MDQ6VXNlcjI3NzgzOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2778393?v=4","gravatar_id":"","url":"https://api.github.com/users/dafo","html_url":"https://github.com/dafo","followers_url":"https://api.github.com/users/dafo/followers","following_url":"https://api.github.com/users/dafo/following{/other_user}","gists_url":"https://api.github.com/users/dafo/gists{/gist_id}","starred_url":"https://api.github.com/users/dafo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dafo/subscriptions","organizations_url":"https://api.github.com/users/dafo/orgs","repos_url":"https://api.github.com/users/dafo/repos","events_url":"https://api.github.com/users/dafo/events{/privacy}","received_events_url":"https://api.github.com/users/dafo/received_events","type":"User","site_admin":false},"body":"Closes #547. \r\n\r\n","created_at":"2019-08-15T12:07:47Z","updated_at":"2019-08-16T10:59:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46ec7d07b14c37fd96c3f485a9871d5ae3895e78","assignee":{"login":"ViktorSlavov","id":24314672,"node_id":"MDQ6VXNlcjI0MzE0Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/24314672?v=4","gravatar_id":"","url":"https://api.github.com/users/ViktorSlavov","html_url":"https://github.com/ViktorSlavov","followers_url":"https://api.github.com/users/ViktorSlavov/followers","following_url":"https://api.github.com/users/ViktorSlavov/following{/other_user}","gists_url":"https://api.github.com/users/ViktorSlavov/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorSlavov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorSlavov/subscriptions","organizations_url":"https://api.github.com/users/ViktorSlavov/orgs","repos_url":"https://api.github.com/users/ViktorSlavov/repos","events_url":"https://api.github.com/users/ViktorSlavov/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorSlavov/received_events","type":"User","site_admin":false},"assignees":[{"login":"ViktorSlavov","id":24314672,"node_id":"MDQ6VXNlcjI0MzE0Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/24314672?v=4","gravatar_id":"","url":"https://api.github.com/users/ViktorSlavov","html_url":"https://github.com/ViktorSlavov","followers_url":"https://api.github.com/users/ViktorSlavov/followers","following_url":"https://api.github.com/users/ViktorSlavov/following{/other_user}","gists_url":"https://api.github.com/users/ViktorSlavov/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorSlavov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorSlavov/subscriptions","organizations_url":"https://api.github.com/users/ViktorSlavov/orgs","repos_url":"https://api.github.com/users/ViktorSlavov/repos","events_url":"https://api.github.com/users/ViktorSlavov/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorSlavov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":715851388,"node_id":"MDU6TGFiZWw3MTU4NTEzODg=","url":"https://api.github.com/repos/IgniteUI/igniteui-cli/labels/angular","name":"angular","color":"DD0031","default":false},{"id":805356826,"node_id":"MDU6TGFiZWw4MDUzNTY4MjY=","url":"https://api.github.com/repos/IgniteUI/igniteui-cli/labels/status:%20in-test","name":"status: in-test","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/549/commits","review_comments_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/549/comments","review_comment_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues/549/comments","statuses_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/statuses/906564ff41a2969939498cbb7f94f58e07e2aecd","head":{"label":"IgniteUI:AMarinov/issue547","ref":"AMarinov/issue547","sha":"906564ff41a2969939498cbb7f94f58e07e2aecd","user":{"login":"IgniteUI","id":5366066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5366066?v=4","gravatar_id":"","url":"https://api.github.com/users/IgniteUI","html_url":"https://github.com/IgniteUI","followers_url":"https://api.github.com/users/IgniteUI/followers","following_url":"https://api.github.com/users/IgniteUI/following{/other_user}","gists_url":"https://api.github.com/users/IgniteUI/gists{/gist_id}","starred_url":"https://api.github.com/users/IgniteUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgniteUI/subscriptions","organizations_url":"https://api.github.com/users/IgniteUI/orgs","repos_url":"https://api.github.com/users/IgniteUI/repos","events_url":"https://api.github.com/users/IgniteUI/events{/privacy}","received_events_url":"https://api.github.com/users/IgniteUI/received_events","type":"Organization","site_admin":false},"repo":{"id":106006714,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwMDY3MTQ=","name":"igniteui-cli","full_name":"IgniteUI/igniteui-cli","private":false,"owner":{"login":"IgniteUI","id":5366066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5366066?v=4","gravatar_id":"","url":"https://api.github.com/users/IgniteUI","html_url":"https://github.com/IgniteUI","followers_url":"https://api.github.com/users/IgniteUI/followers","following_url":"https://api.github.com/users/IgniteUI/following{/other_user}","gists_url":"https://api.github.com/users/IgniteUI/gists{/gist_id}","starred_url":"https://api.github.com/users/IgniteUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgniteUI/subscriptions","organizations_url":"https://api.github.com/users/IgniteUI/orgs","repos_url":"https://api.github.com/users/IgniteUI/repos","events_url":"https://api.github.com/users/IgniteUI/events{/privacy}","received_events_url":"https://api.github.com/users/IgniteUI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IgniteUI/igniteui-cli","description":"Ignite UI Command-Line Interface by Infragistics","fork":false,"url":"https://api.github.com/repos/IgniteUI/igniteui-cli","forks_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/forks","keys_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/teams","hooks_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/hooks","issue_events_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues/events{/number}","events_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/events","assignees_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/assignees{/user}","branches_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/branches{/branch}","tags_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/tags","blobs_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/languages","stargazers_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/stargazers","contributors_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/contributors","subscribers_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/subscribers","subscription_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/subscription","commits_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/contents/{+path}","compare_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/merges","archive_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/downloads","issues_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues{/number}","pulls_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/labels{/name}","releases_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/releases{/id}","deployments_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/deployments","created_at":"2017-10-06T13:17:49Z","updated_at":"2019-07-23T19:20:22Z","pushed_at":"2019-08-16T10:34:49Z","git_url":"git://github.com/IgniteUI/igniteui-cli.git","ssh_url":"git@github.com:IgniteUI/igniteui-cli.git","clone_url":"https://github.com/IgniteUI/igniteui-cli.git","svn_url":"https://github.com/IgniteUI/igniteui-cli","homepage":"https://www.infragistics.com/products/ignite-ui","size":15533,"stargazers_count":101,"watchers_count":101,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":52,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":52,"watchers":101,"default_branch":"master"}},"base":{"label":"IgniteUI:master","ref":"master","sha":"0850d3252df2e02927c93dfa0c88a936d0e0d1d9","user":{"login":"IgniteUI","id":5366066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5366066?v=4","gravatar_id":"","url":"https://api.github.com/users/IgniteUI","html_url":"https://github.com/IgniteUI","followers_url":"https://api.github.com/users/IgniteUI/followers","following_url":"https://api.github.com/users/IgniteUI/following{/other_user}","gists_url":"https://api.github.com/users/IgniteUI/gists{/gist_id}","starred_url":"https://api.github.com/users/IgniteUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgniteUI/subscriptions","organizations_url":"https://api.github.com/users/IgniteUI/orgs","repos_url":"https://api.github.com/users/IgniteUI/repos","events_url":"https://api.github.com/users/IgniteUI/events{/privacy}","received_events_url":"https://api.github.com/users/IgniteUI/received_events","type":"Organization","site_admin":false},"repo":{"id":106006714,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwMDY3MTQ=","name":"igniteui-cli","full_name":"IgniteUI/igniteui-cli","private":false,"owner":{"login":"IgniteUI","id":5366066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5366066?v=4","gravatar_id":"","url":"https://api.github.com/users/IgniteUI","html_url":"https://github.com/IgniteUI","followers_url":"https://api.github.com/users/IgniteUI/followers","following_url":"https://api.github.com/users/IgniteUI/following{/other_user}","gists_url":"https://api.github.com/users/IgniteUI/gists{/gist_id}","starred_url":"https://api.github.com/users/IgniteUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgniteUI/subscriptions","organizations_url":"https://api.github.com/users/IgniteUI/orgs","repos_url":"https://api.github.com/users/IgniteUI/repos","events_url":"https://api.github.com/users/IgniteUI/events{/privacy}","received_events_url":"https://api.github.com/users/IgniteUI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IgniteUI/igniteui-cli","description":"Ignite UI Command-Line Interface by Infragistics","fork":false,"url":"https://api.github.com/repos/IgniteUI/igniteui-cli","forks_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/forks","keys_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/teams","hooks_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/hooks","issue_events_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues/events{/number}","events_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/events","assignees_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/assignees{/user}","branches_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/branches{/branch}","tags_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/tags","blobs_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/languages","stargazers_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/stargazers","contributors_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/contributors","subscribers_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/subscribers","subscription_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/subscription","commits_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/contents/{+path}","compare_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/merges","archive_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/downloads","issues_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues{/number}","pulls_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/labels{/name}","releases_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/releases{/id}","deployments_url":"https://api.github.com/repos/IgniteUI/igniteui-cli/deployments","created_at":"2017-10-06T13:17:49Z","updated_at":"2019-07-23T19:20:22Z","pushed_at":"2019-08-16T10:34:49Z","git_url":"git://github.com/IgniteUI/igniteui-cli.git","ssh_url":"git@github.com:IgniteUI/igniteui-cli.git","clone_url":"https://github.com/IgniteUI/igniteui-cli.git","svn_url":"https://github.com/IgniteUI/igniteui-cli","homepage":"https://www.infragistics.com/products/ignite-ui","size":15533,"stargazers_count":101,"watchers_count":101,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":52,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":52,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/549"},"html":{"href":"https://github.com/IgniteUI/igniteui-cli/pull/549"},"issue":{"href":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues/549"},"comments":{"href":"https://api.github.com/repos/IgniteUI/igniteui-cli/issues/549/comments"},"review_comments":{"href":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/549/comments"},"review_comment":{"href":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IgniteUI/igniteui-cli/pulls/549/commits"},"statuses":{"href":"https://api.github.com/repos/IgniteUI/igniteui-cli/statuses/906564ff41a2969939498cbb7f94f58e07e2aecd"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 106006714,
"name": "IgniteUI/igniteui-cli",
"url": "https://api.github.com/repos/IgniteUI/igniteui-cli"
}
|
{
"id": 24314672,
"login": "ViktorSlavov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24314672?",
"url": "https://api.github.com/users/ViktorSlavov"
}
|
{
"id": 5366066,
"login": "IgniteUI",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5366066?",
"url": "https://api.github.com/orgs/IgniteUI"
}
| 2019-08-16T10:53:49 |
10223879494
|
{"actor":{"display_login":"ViktorSlavov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/comments/343017148","pull_request_review_id":312325436,"id":343017148,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzAxNzE0OA==","diff_hunk":"@@ -594,6 +603,118 @@ paths:\n application/json:\n schema:\n $ref: '#/components/schemas/ErrorResponse'\n+ '/documents/{documentId}/favourite/{userId}':\n+ patch:\n+ tags:\n+ - Documents\n+ summary: Add a document to favourites\n+ description: Add a document to favourites by document Id and user Id.\n+ operationId: FavouriteDocument\n+ parameters:\n+ - in: path\n+ name: documentId\n+ schema:\n+ $ref: '#/components/schemas/documentId'\n+ required: true \n+ - in: path\n+ name: userId\n+ schema:\n+ $ref: '#/components/schemas/userId'\n+ required: true \t\t \n+ responses:\n+ '200':\n+ description: Successful. Document favourited.\n+ content:\n+ application/json:\n+ schema:\n+ $ref: '#/components/schemas/Document'\n+ '400':\n+ description: Invalid parameters.\n+ content:\n+ application/json:\n+ schema:\n+ $ref: '#/components/schemas/ErrorResponse'\n+ '401':\n+ description: Not authorized to favourite Document.\n+ content:\n+ application/json:\n+ schema:\n+ $ref: '#/components/schemas/ErrorResponse'\n+ '403':\n+ description: Forbidden.\n+ content:\n+ application/json:\n+ schema:\n+ $ref: '#/components/schemas/ErrorResponse'\n+ '404':\n+ description: Document not found.\n+ content:\n+ application/json:\n+ schema:\n+ $ref: '#/components/schemas/ErrorResponse'\n+ '500':\n+ description: An unexpeced error occurred.\n+ content:\n+ application/json:\n+ schema:\n+ $ref: '#/components/schemas/ErrorResponse'\n+ '/documents/{documentId}/unfavourite/{userId}':\n+ patch:","path":"doc/dokuti_api.yml","position":76,"original_position":76,"commit_id":"0eee8226368eb733389a3b267ed6b0649148eaaf","original_commit_id":"0eee8226368eb733389a3b267ed6b0649148eaaf","user":{"login":"akorneyc","id":55878479,"node_id":"MDQ6VXNlcjU1ODc4NDc5","avatar_url":"https://avatars0.githubusercontent.com/u/55878479?v=4","gravatar_id":"","url":"https://api.github.com/users/akorneyc","html_url":"https://github.com/akorneyc","followers_url":"https://api.github.com/users/akorneyc/followers","following_url":"https://api.github.com/users/akorneyc/following{/other_user}","gists_url":"https://api.github.com/users/akorneyc/gists{/gist_id}","starred_url":"https://api.github.com/users/akorneyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akorneyc/subscriptions","organizations_url":"https://api.github.com/users/akorneyc/orgs","repos_url":"https://api.github.com/users/akorneyc/repos","events_url":"https://api.github.com/users/akorneyc/events{/privacy}","received_events_url":"https://api.github.com/users/akorneyc/received_events","type":"User","site_admin":false},"body":"ok, will replace with \"post\"","created_at":"2019-11-06T10:21:17Z","updated_at":"2019-11-06T10:21:17Z","html_url":"https://github.com/GrindrodBank/dokuti/pull/31#discussion_r343017148","pull_request_url":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/31","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/comments/343017148"},"html":{"href":"https://github.com/GrindrodBank/dokuti/pull/31#discussion_r343017148"},"pull_request":{"href":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/31"}},"in_reply_to_id":342952446},"pull_request":{"url":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/31","id":336781055,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2NzgxMDU1","html_url":"https://github.com/GrindrodBank/dokuti/pull/31","diff_url":"https://github.com/GrindrodBank/dokuti/pull/31.diff","patch_url":"https://github.com/GrindrodBank/dokuti/pull/31.patch","issue_url":"https://api.github.com/repos/GrindrodBank/dokuti/issues/31","number":31,"state":"open","locked":false,"title":"added favourite feature","user":{"login":"akorneyc","id":55878479,"node_id":"MDQ6VXNlcjU1ODc4NDc5","avatar_url":"https://avatars0.githubusercontent.com/u/55878479?v=4","gravatar_id":"","url":"https://api.github.com/users/akorneyc","html_url":"https://github.com/akorneyc","followers_url":"https://api.github.com/users/akorneyc/followers","following_url":"https://api.github.com/users/akorneyc/following{/other_user}","gists_url":"https://api.github.com/users/akorneyc/gists{/gist_id}","starred_url":"https://api.github.com/users/akorneyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akorneyc/subscriptions","organizations_url":"https://api.github.com/users/akorneyc/orgs","repos_url":"https://api.github.com/users/akorneyc/repos","events_url":"https://api.github.com/users/akorneyc/events{/privacy}","received_events_url":"https://api.github.com/users/akorneyc/received_events","type":"User","site_admin":false},"body":"This PR include implementation of document favourite feature :\r\n-changed model\r\n-changed db schema\r\n-added postman tests\r\n-added unit tests\r\n","created_at":"2019-11-05T13:35:48Z","updated_at":"2019-11-06T10:21:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ce10f52146f12c421cbe66c4c37ff7808c4c2ec","assignee":null,"assignees":[],"requested_reviewers":[{"login":"VictorSzewczenko","id":19466311,"node_id":"MDQ6VXNlcjE5NDY2MzEx","avatar_url":"https://avatars1.githubusercontent.com/u/19466311?v=4","gravatar_id":"","url":"https://api.github.com/users/VictorSzewczenko","html_url":"https://github.com/VictorSzewczenko","followers_url":"https://api.github.com/users/VictorSzewczenko/followers","following_url":"https://api.github.com/users/VictorSzewczenko/following{/other_user}","gists_url":"https://api.github.com/users/VictorSzewczenko/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorSzewczenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorSzewczenko/subscriptions","organizations_url":"https://api.github.com/users/VictorSzewczenko/orgs","repos_url":"https://api.github.com/users/VictorSzewczenko/repos","events_url":"https://api.github.com/users/VictorSzewczenko/events{/privacy}","received_events_url":"https://api.github.com/users/VictorSzewczenko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/31/commits","review_comments_url":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/31/comments","review_comment_url":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GrindrodBank/dokuti/issues/31/comments","statuses_url":"https://api.github.com/repos/GrindrodBank/dokuti/statuses/0eee8226368eb733389a3b267ed6b0649148eaaf","head":{"label":"GrindrodBank:2050_Favorites_Feature","ref":"2050_Favorites_Feature","sha":"0eee8226368eb733389a3b267ed6b0649148eaaf","user":{"login":"GrindrodBank","id":5393912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzOTM5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5393912?v=4","gravatar_id":"","url":"https://api.github.com/users/GrindrodBank","html_url":"https://github.com/GrindrodBank","followers_url":"https://api.github.com/users/GrindrodBank/followers","following_url":"https://api.github.com/users/GrindrodBank/following{/other_user}","gists_url":"https://api.github.com/users/GrindrodBank/gists{/gist_id}","starred_url":"https://api.github.com/users/GrindrodBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrindrodBank/subscriptions","organizations_url":"https://api.github.com/users/GrindrodBank/orgs","repos_url":"https://api.github.com/users/GrindrodBank/repos","events_url":"https://api.github.com/users/GrindrodBank/events{/privacy}","received_events_url":"https://api.github.com/users/GrindrodBank/received_events","type":"Organization","site_admin":false},"repo":{"id":177935303,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc5MzUzMDM=","name":"dokuti","full_name":"GrindrodBank/dokuti","private":false,"owner":{"login":"GrindrodBank","id":5393912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzOTM5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5393912?v=4","gravatar_id":"","url":"https://api.github.com/users/GrindrodBank","html_url":"https://github.com/GrindrodBank","followers_url":"https://api.github.com/users/GrindrodBank/followers","following_url":"https://api.github.com/users/GrindrodBank/following{/other_user}","gists_url":"https://api.github.com/users/GrindrodBank/gists{/gist_id}","starred_url":"https://api.github.com/users/GrindrodBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrindrodBank/subscriptions","organizations_url":"https://api.github.com/users/GrindrodBank/orgs","repos_url":"https://api.github.com/users/GrindrodBank/repos","events_url":"https://api.github.com/users/GrindrodBank/events{/privacy}","received_events_url":"https://api.github.com/users/GrindrodBank/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GrindrodBank/dokuti","description":"A document utility service for the storing, pulling and versioning of all documents throughout the enterprise.","fork":false,"url":"https://api.github.com/repos/GrindrodBank/dokuti","forks_url":"https://api.github.com/repos/GrindrodBank/dokuti/forks","keys_url":"https://api.github.com/repos/GrindrodBank/dokuti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GrindrodBank/dokuti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GrindrodBank/dokuti/teams","hooks_url":"https://api.github.com/repos/GrindrodBank/dokuti/hooks","issue_events_url":"https://api.github.com/repos/GrindrodBank/dokuti/issues/events{/number}","events_url":"https://api.github.com/repos/GrindrodBank/dokuti/events","assignees_url":"https://api.github.com/repos/GrindrodBank/dokuti/assignees{/user}","branches_url":"https://api.github.com/repos/GrindrodBank/dokuti/branches{/branch}","tags_url":"https://api.github.com/repos/GrindrodBank/dokuti/tags","blobs_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/refs{/sha}","trees_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GrindrodBank/dokuti/statuses/{sha}","languages_url":"https://api.github.com/repos/GrindrodBank/dokuti/languages","stargazers_url":"https://api.github.com/repos/GrindrodBank/dokuti/stargazers","contributors_url":"https://api.github.com/repos/GrindrodBank/dokuti/contributors","subscribers_url":"https://api.github.com/repos/GrindrodBank/dokuti/subscribers","subscription_url":"https://api.github.com/repos/GrindrodBank/dokuti/subscription","commits_url":"https://api.github.com/repos/GrindrodBank/dokuti/commits{/sha}","git_commits_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/commits{/sha}","comments_url":"https://api.github.com/repos/GrindrodBank/dokuti/comments{/number}","issue_comment_url":"https://api.github.com/repos/GrindrodBank/dokuti/issues/comments{/number}","contents_url":"https://api.github.com/repos/GrindrodBank/dokuti/contents/{+path}","compare_url":"https://api.github.com/repos/GrindrodBank/dokuti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GrindrodBank/dokuti/merges","archive_url":"https://api.github.com/repos/GrindrodBank/dokuti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GrindrodBank/dokuti/downloads","issues_url":"https://api.github.com/repos/GrindrodBank/dokuti/issues{/number}","pulls_url":"https://api.github.com/repos/GrindrodBank/dokuti/pulls{/number}","milestones_url":"https://api.github.com/repos/GrindrodBank/dokuti/milestones{/number}","notifications_url":"https://api.github.com/repos/GrindrodBank/dokuti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GrindrodBank/dokuti/labels{/name}","releases_url":"https://api.github.com/repos/GrindrodBank/dokuti/releases{/id}","deployments_url":"https://api.github.com/repos/GrindrodBank/dokuti/deployments","created_at":"2019-03-27T06:51:22Z","updated_at":"2019-11-01T11:00:59Z","pushed_at":"2019-11-05T21:02:45Z","git_url":"git://github.com/GrindrodBank/dokuti.git","ssh_url":"git@github.com:GrindrodBank/dokuti.git","clone_url":"https://github.com/GrindrodBank/dokuti.git","svn_url":"https://github.com/GrindrodBank/dokuti","homepage":null,"size":1634,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"GrindrodBank:master","ref":"master","sha":"9ba6d1c351d1c9ec6f67ac1ed67b2faabdcbe63c","user":{"login":"GrindrodBank","id":5393912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzOTM5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5393912?v=4","gravatar_id":"","url":"https://api.github.com/users/GrindrodBank","html_url":"https://github.com/GrindrodBank","followers_url":"https://api.github.com/users/GrindrodBank/followers","following_url":"https://api.github.com/users/GrindrodBank/following{/other_user}","gists_url":"https://api.github.com/users/GrindrodBank/gists{/gist_id}","starred_url":"https://api.github.com/users/GrindrodBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrindrodBank/subscriptions","organizations_url":"https://api.github.com/users/GrindrodBank/orgs","repos_url":"https://api.github.com/users/GrindrodBank/repos","events_url":"https://api.github.com/users/GrindrodBank/events{/privacy}","received_events_url":"https://api.github.com/users/GrindrodBank/received_events","type":"Organization","site_admin":false},"repo":{"id":177935303,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc5MzUzMDM=","name":"dokuti","full_name":"GrindrodBank/dokuti","private":false,"owner":{"login":"GrindrodBank","id":5393912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzOTM5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5393912?v=4","gravatar_id":"","url":"https://api.github.com/users/GrindrodBank","html_url":"https://github.com/GrindrodBank","followers_url":"https://api.github.com/users/GrindrodBank/followers","following_url":"https://api.github.com/users/GrindrodBank/following{/other_user}","gists_url":"https://api.github.com/users/GrindrodBank/gists{/gist_id}","starred_url":"https://api.github.com/users/GrindrodBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrindrodBank/subscriptions","organizations_url":"https://api.github.com/users/GrindrodBank/orgs","repos_url":"https://api.github.com/users/GrindrodBank/repos","events_url":"https://api.github.com/users/GrindrodBank/events{/privacy}","received_events_url":"https://api.github.com/users/GrindrodBank/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GrindrodBank/dokuti","description":"A document utility service for the storing, pulling and versioning of all documents throughout the enterprise.","fork":false,"url":"https://api.github.com/repos/GrindrodBank/dokuti","forks_url":"https://api.github.com/repos/GrindrodBank/dokuti/forks","keys_url":"https://api.github.com/repos/GrindrodBank/dokuti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GrindrodBank/dokuti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GrindrodBank/dokuti/teams","hooks_url":"https://api.github.com/repos/GrindrodBank/dokuti/hooks","issue_events_url":"https://api.github.com/repos/GrindrodBank/dokuti/issues/events{/number}","events_url":"https://api.github.com/repos/GrindrodBank/dokuti/events","assignees_url":"https://api.github.com/repos/GrindrodBank/dokuti/assignees{/user}","branches_url":"https://api.github.com/repos/GrindrodBank/dokuti/branches{/branch}","tags_url":"https://api.github.com/repos/GrindrodBank/dokuti/tags","blobs_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/refs{/sha}","trees_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GrindrodBank/dokuti/statuses/{sha}","languages_url":"https://api.github.com/repos/GrindrodBank/dokuti/languages","stargazers_url":"https://api.github.com/repos/GrindrodBank/dokuti/stargazers","contributors_url":"https://api.github.com/repos/GrindrodBank/dokuti/contributors","subscribers_url":"https://api.github.com/repos/GrindrodBank/dokuti/subscribers","subscription_url":"https://api.github.com/repos/GrindrodBank/dokuti/subscription","commits_url":"https://api.github.com/repos/GrindrodBank/dokuti/commits{/sha}","git_commits_url":"https://api.github.com/repos/GrindrodBank/dokuti/git/commits{/sha}","comments_url":"https://api.github.com/repos/GrindrodBank/dokuti/comments{/number}","issue_comment_url":"https://api.github.com/repos/GrindrodBank/dokuti/issues/comments{/number}","contents_url":"https://api.github.com/repos/GrindrodBank/dokuti/contents/{+path}","compare_url":"https://api.github.com/repos/GrindrodBank/dokuti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GrindrodBank/dokuti/merges","archive_url":"https://api.github.com/repos/GrindrodBank/dokuti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GrindrodBank/dokuti/downloads","issues_url":"https://api.github.com/repos/GrindrodBank/dokuti/issues{/number}","pulls_url":"https://api.github.com/repos/GrindrodBank/dokuti/pulls{/number}","milestones_url":"https://api.github.com/repos/GrindrodBank/dokuti/milestones{/number}","notifications_url":"https://api.github.com/repos/GrindrodBank/dokuti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GrindrodBank/dokuti/labels{/name}","releases_url":"https://api.github.com/repos/GrindrodBank/dokuti/releases{/id}","deployments_url":"https://api.github.com/repos/GrindrodBank/dokuti/deployments","created_at":"2019-03-27T06:51:22Z","updated_at":"2019-11-01T11:00:59Z","pushed_at":"2019-11-05T21:02:45Z","git_url":"git://github.com/GrindrodBank/dokuti.git","ssh_url":"git@github.com:GrindrodBank/dokuti.git","clone_url":"https://github.com/GrindrodBank/dokuti.git","svn_url":"https://github.com/GrindrodBank/dokuti","homepage":null,"size":1634,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/31"},"html":{"href":"https://github.com/GrindrodBank/dokuti/pull/31"},"issue":{"href":"https://api.github.com/repos/GrindrodBank/dokuti/issues/31"},"comments":{"href":"https://api.github.com/repos/GrindrodBank/dokuti/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GrindrodBank/dokuti/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/GrindrodBank/dokuti/statuses/0eee8226368eb733389a3b267ed6b0649148eaaf"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 177935303,
"name": "GrindrodBank/dokuti",
"url": "https://api.github.com/repos/GrindrodBank/dokuti"
}
|
{
"id": 55878479,
"login": "akorneyc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55878479?",
"url": "https://api.github.com/users/akorneyc"
}
|
{
"id": 5393912,
"login": "GrindrodBank",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5393912?",
"url": "https://api.github.com/orgs/GrindrodBank"
}
| 2019-11-06T10:21:17 |
10798596355
|
{"actor":{"display_login":"akorneyc"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/343870008","pull_request_review_id":313630553,"id":343870008,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0Mzg3MDAwOA==","diff_hunk":"@@ -54,32 +55,6 @@ const messageIDToOrdinal = (\n return null\n }\n \n-const passToTeamBuildingReducer = (\n- draftState: Container.Draft<Types.State>,\n- action: TeamBuildingGen.Actions\n-) => {\n- draftState.teamBuilding = teamBuildingReducer(\n- 'chat2',\n- draftState.teamBuilding as Types.State['teamBuilding'],\n- action\n- )\n-}\n-\n-const teamActions: Container.ActionHandler<Actions, Types.State> = {","path":"shared/reducers/chat2.tsx","position":23,"original_position":23,"commit_id":"247800a94676a841587fb52e16f206c64b028efa","original_commit_id":"247800a94676a841587fb52e16f206c64b028efa","user":{"login":"chrisnojima","id":516435,"node_id":"MDQ6VXNlcjUxNjQzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/516435?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisnojima","html_url":"https://github.com/chrisnojima","followers_url":"https://api.github.com/users/chrisnojima/followers","following_url":"https://api.github.com/users/chrisnojima/following{/other_user}","gists_url":"https://api.github.com/users/chrisnojima/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnojima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnojima/subscriptions","organizations_url":"https://api.github.com/users/chrisnojima/orgs","repos_url":"https://api.github.com/users/chrisnojima/repos","events_url":"https://api.github.com/users/chrisnojima/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnojima/received_events","type":"User","site_admin":false},"body":"moved to a helper so its not copy/pasted / leaves a new action getting missed somewhere possibly","created_at":"2019-11-07T20:56:06Z","updated_at":"2019-11-07T20:56:34Z","html_url":"https://github.com/keybase/client/pull/20847#discussion_r343870008","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/20847","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/343870008"},"html":{"href":"https://github.com/keybase/client/pull/20847#discussion_r343870008"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/20847"}}},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/20847","id":338237137,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4MjM3MTM3","html_url":"https://github.com/keybase/client/pull/20847","diff_url":"https://github.com/keybase/client/pull/20847.diff","patch_url":"https://github.com/keybase/client/pull/20847.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/20847","number":20847,"state":"open","locked":false,"title":"fix reset store being overwritten in makeReducer","user":{"login":"chrisnojima","id":516435,"node_id":"MDQ6VXNlcjUxNjQzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/516435?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisnojima","html_url":"https://github.com/chrisnojima","followers_url":"https://api.github.com/users/chrisnojima/followers","following_url":"https://api.github.com/users/chrisnojima/following{/other_user}","gists_url":"https://api.github.com/users/chrisnojima/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnojima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnojima/subscriptions","organizations_url":"https://api.github.com/users/chrisnojima/orgs","repos_url":"https://api.github.com/users/chrisnojima/repos","events_url":"https://api.github.com/users/chrisnojima/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnojima/received_events","type":"User","site_admin":false},"body":"This fixes the issue where `resetStore` in the parent reducer and in the teamsbuilding reducer are in conflict. Before by convention we had large switch statements so the first item would win. With `makeReducer` it makes a map so the last item wins. We don't actually want either case. So now the team building uses a `chainAction` to make its own custom resetStore action that it can safely listen to\r\n\r\nAlso moved some helper stuff that was made for chat into a re-usable helper","created_at":"2019-11-07T20:54:55Z","updated_at":"2019-11-07T20:56:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eff2b114c39307f5c5a6815b866762dc191bdbc6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"buoyad","id":11968340,"node_id":"MDQ6VXNlcjExOTY4MzQw","avatar_url":"https://avatars1.githubusercontent.com/u/11968340?v=4","gravatar_id":"","url":"https://api.github.com/users/buoyad","html_url":"https://github.com/buoyad","followers_url":"https://api.github.com/users/buoyad/followers","following_url":"https://api.github.com/users/buoyad/following{/other_user}","gists_url":"https://api.github.com/users/buoyad/gists{/gist_id}","starred_url":"https://api.github.com/users/buoyad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buoyad/subscriptions","organizations_url":"https://api.github.com/users/buoyad/orgs","repos_url":"https://api.github.com/users/buoyad/repos","events_url":"https://api.github.com/users/buoyad/events{/privacy}","received_events_url":"https://api.github.com/users/buoyad/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"React Hackers","id":1810420,"node_id":"MDQ6VGVhbTE4MTA0MjA=","slug":"react-hackers","description":"People working on electron/react-native","privacy":"closed","url":"https://api.github.com/teams/1810420","html_url":"https://github.com/orgs/keybase/teams/react-hackers","members_url":"https://api.github.com/teams/1810420/members{/member}","repositories_url":"https://api.github.com/teams/1810420/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/20847/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/20847/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/20847/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/247800a94676a841587fb52e16f206c64b028efa","head":{"label":"keybase:nojima/HOTPOT-fix-teambuilding-reset","ref":"nojima/HOTPOT-fix-teambuilding-reset","sha":"247800a94676a841587fb52e16f206c64b028efa","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA5OTE4MQ==","name":"client","full_name":"keybase/client","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2019-11-07T20:50:13Z","pushed_at":"2019-11-07T20:54:56Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":497918,"stargazers_count":6093,"watchers_count":6093,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":750,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3224,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":750,"open_issues":3224,"watchers":6093,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"547f273b5130e5dc912aa0a0b8583bdb2e7df779","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA5OTE4MQ==","name":"client","full_name":"keybase/client","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2019-11-07T20:50:13Z","pushed_at":"2019-11-07T20:54:56Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":497918,"stargazers_count":6093,"watchers_count":6093,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":750,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3224,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":750,"open_issues":3224,"watchers":6093,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/20847"},"html":{"href":"https://github.com/keybase/client/pull/20847"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/20847"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/20847/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/20847/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/20847/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/247800a94676a841587fb52e16f206c64b028efa"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 29099181,
"name": "keybase/client",
"url": "https://api.github.com/repos/keybase/client"
}
|
{
"id": 516435,
"login": "chrisnojima",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/516435?",
"url": "https://api.github.com/users/chrisnojima"
}
|
{
"id": 5400834,
"login": "keybase",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5400834?",
"url": "https://api.github.com/orgs/keybase"
}
| 2019-11-07T20:56:06 |
10813506058
|
{"actor":{"display_login":"chrisnojima"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments/260739559","pull_request_review_id":208511648,"id":260739559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDczOTU1OQ==","diff_hunk":"@@ -28,5 +29,31 @@ def va_profile=(new_va_profile)\n raise Common::Exceptions::ParameterMissing 'X-VA-Birth-Date' unless matches\n super(new_va_profile)\n end\n+\n+ def self.from_headers(headers, with_gender = false)","path":"modules/claims_api/app/models/claims_api/veteran.rb","position":null,"original_position":13,"commit_id":"fd7647772abbf8c14b17d33f9f3de0e0511ed340","original_commit_id":"b1d21da36d4cf0c2d463365174a391012b7da8d7","user":{"login":"ATeal","id":5629145,"node_id":"MDQ6VXNlcjU2MjkxNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5629145?v=4","gravatar_id":"","url":"https://api.github.com/users/ATeal","html_url":"https://github.com/ATeal","followers_url":"https://api.github.com/users/ATeal/followers","following_url":"https://api.github.com/users/ATeal/following{/other_user}","gists_url":"https://api.github.com/users/ATeal/gists{/gist_id}","starred_url":"https://api.github.com/users/ATeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ATeal/subscriptions","organizations_url":"https://api.github.com/users/ATeal/orgs","repos_url":"https://api.github.com/users/ATeal/repos","events_url":"https://api.github.com/users/ATeal/events{/privacy}","received_events_url":"https://api.github.com/users/ATeal/received_events","type":"User","site_admin":false},"body":"resolved in fd76477","created_at":"2019-02-27T13:09:05Z","updated_at":"2019-02-27T13:09:06Z","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2800#discussion_r260739559","pull_request_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2800","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments/260739559"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-api/pull/2800#discussion_r260739559"},"pull_request":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2800"}},"in_reply_to_id":260471835},"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2800","id":251595210,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNTk1MjEw","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2800","diff_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2800.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2800.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2800","number":2800,"state":"open","locked":false,"title":"526 Auto CEST ","user":{"login":"ATeal","id":5629145,"node_id":"MDQ6VXNlcjU2MjkxNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5629145?v=4","gravatar_id":"","url":"https://api.github.com/users/ATeal","html_url":"https://github.com/ATeal","followers_url":"https://api.github.com/users/ATeal/followers","following_url":"https://api.github.com/users/ATeal/following{/other_user}","gists_url":"https://api.github.com/users/ATeal/gists{/gist_id}","starred_url":"https://api.github.com/users/ATeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ATeal/subscriptions","organizations_url":"https://api.github.com/users/ATeal/orgs","repos_url":"https://api.github.com/users/ATeal/repos","events_url":"https://api.github.com/users/ATeal/events{/privacy}","received_events_url":"https://api.github.com/users/ATeal/received_events","type":"User","site_admin":false},"body":"## Description of change\r\n<!-- Please include a description of the change. What would a code reviewer, or a future dev, need to know about this PR in order to understand why this PR is necessary. This could include dependencies introduced, changes in behavior, pointers to more detailed documentation -->\r\n\r\nresolves https://github.com/department-of-veterans-affairs/vets-contrib/issues/1267\r\n\r\n## Testing done\r\n<!-- Please describe testing done to verify the changes. -->\r\n\r\n## Testing planned\r\n<!-- Please describe testing planned. -->\r\n\r\n## Acceptance Criteria (Definition of Done)\r\n\r\n#### Unique to this PR\r\n<!-- This would be a good place to include feature flag check item and info, specific dashboards and instrumentation check item and info -->\r\n- [ ] _Replace this line with individual tasks unique to your PR_\r\n\r\n#### Applies to all PRs\r\n\r\n- [ ] Appropriate logging\r\n- [ ] Swagger docs have been updated, if applicable\r\n- [ ] Provide link to originating GitHub issue, or connected to it via ZenHub\r\n- [ ] Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)\r\n- [ ] Provide which alerts would indicate a problem with this functionality (if applicable)\r\n","created_at":"2019-02-08T20:55:55Z","updated_at":"2019-02-27T13:09:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ff186aa4e64c9d6d2d2a3195d57233d604854c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2800/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2800/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2800/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/fd7647772abbf8c14b17d33f9f3de0e0511ed340","head":{"label":"department-of-veterans-affairs:auto-cest-526","ref":"auto-cest-526","sha":"fd7647772abbf8c14b17d33f9f3de0e0511ed340","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"node_id":"MDEwOlJlcG9zaXRvcnk2MjQwOTQxNw==","name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","private":false,"owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2019-02-26T21:44:10Z","pushed_at":"2019-02-27T13:08:42Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":88167,"stargazers_count":51,"watchers_count":51,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":24,"watchers":51,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"bfd25961868692a29177fe7df4217ddf75bd9b72","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"node_id":"MDEwOlJlcG9zaXRvcnk2MjQwOTQxNw==","name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","private":false,"owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2019-02-26T21:44:10Z","pushed_at":"2019-02-27T13:08:42Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":88167,"stargazers_count":51,"watchers_count":51,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":24,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2800"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-api/pull/2800"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2800"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2800/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2800/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2800/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/fd7647772abbf8c14b17d33f9f3de0e0511ed340"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 62409417,
"name": "department-of-veterans-affairs/vets-api",
"url": "https://api.github.com/repos/department-of-veterans-affairs/vets-api"
}
|
{
"id": 5629145,
"login": "ATeal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5629145?",
"url": "https://api.github.com/users/ATeal"
}
|
{
"id": 5421563,
"login": "department-of-veterans-affairs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5421563?",
"url": "https://api.github.com/orgs/department-of-veterans-affairs"
}
| 2019-02-27T13:09:05 |
9146557241
|
{"actor":{"display_login":"ATeal"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/comments/364945832","pull_request_review_id":340794641,"id":364945832,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDk0NTgzMg==","diff_hunk":"@@ -83,14 +88,23 @@ def upload_params\n @upload_params ||= params.require(:upload).permit(:csv_type, :skip_lines, :col_sep, :upload_file, :comment)\n end\n \n+ def set_options\n+ csv_type = @upload.csv_type\n+ options = { skip_lines: @upload.skip_lines.try(:to_i), col_sep: @upload.col_sep }\n+ unless defaults(csv_type)['force_simple_split'].nil? && defaults(csv_type)['strip_chars_from_headers'].nil?\n+ options[:force_simple_split] = defaults(csv_type)['force_simple_split']\n+ options[:strip_chars_from_headers] = defaults(csv_type)['strip_chars_from_headers']\n+ end","path":"app/controllers/uploads_controller.rb","position":24,"original_position":24,"commit_id":"4b9932ccf40cb00cf68cd3ef15ecc64d84326ee3","original_commit_id":"4b9932ccf40cb00cf68cd3ef15ecc64d84326ee3","user":{"login":"jholton","id":733873,"node_id":"MDQ6VXNlcjczMzg3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/733873?v=4","gravatar_id":"","url":"https://api.github.com/users/jholton","html_url":"https://github.com/jholton","followers_url":"https://api.github.com/users/jholton/followers","following_url":"https://api.github.com/users/jholton/following{/other_user}","gists_url":"https://api.github.com/users/jholton/gists{/gist_id}","starred_url":"https://api.github.com/users/jholton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jholton/subscriptions","organizations_url":"https://api.github.com/users/jholton/orgs","repos_url":"https://api.github.com/users/jholton/repos","events_url":"https://api.github.com/users/jholton/events{/privacy}","received_events_url":"https://api.github.com/users/jholton/received_events","type":"User","site_admin":false},"body":"Same comment: Looks like `force_simple_split` and `strip_chars_from_headers` default to `nil` anyway, so I don't think you need these conditionals. ","created_at":"2020-01-09T20:30:10Z","updated_at":"2020-01-09T20:30:26Z","html_url":"https://github.com/department-of-veterans-affairs/gibct-data-service/pull/539#discussion_r364945832","pull_request_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/539","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/comments/364945832"},"html":{"href":"https://github.com/department-of-veterans-affairs/gibct-data-service/pull/539#discussion_r364945832"},"pull_request":{"href":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/539"}}},"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/539","id":359997085,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5OTk3MDg1","html_url":"https://github.com/department-of-veterans-affairs/gibct-data-service/pull/539","diff_url":"https://github.com/department-of-veterans-affairs/gibct-data-service/pull/539.diff","patch_url":"https://github.com/department-of-veterans-affairs/gibct-data-service/pull/539.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues/539","number":539,"state":"open","locked":false,"title":"Remove quotation marks from SCO csv during upload","user":{"login":"hughes-dustin","id":48804654,"node_id":"MDQ6VXNlcjQ4ODA0NjU0","avatar_url":"https://avatars1.githubusercontent.com/u/48804654?v=4","gravatar_id":"","url":"https://api.github.com/users/hughes-dustin","html_url":"https://github.com/hughes-dustin","followers_url":"https://api.github.com/users/hughes-dustin/followers","following_url":"https://api.github.com/users/hughes-dustin/following{/other_user}","gists_url":"https://api.github.com/users/hughes-dustin/gists{/gist_id}","starred_url":"https://api.github.com/users/hughes-dustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughes-dustin/subscriptions","organizations_url":"https://api.github.com/users/hughes-dustin/orgs","repos_url":"https://api.github.com/users/hughes-dustin/repos","events_url":"https://api.github.com/users/hughes-dustin/events{/privacy}","received_events_url":"https://api.github.com/users/hughes-dustin/received_events","type":"User","site_admin":false},"body":"## Description\r\nhttps://app.zenhub.com/workspaces/vft-59c95ae5fda7577a9b3184f8/issues/department-of-veterans-affairs/va.gov-team/4308\r\n\r\nThere are cases where we have quotation marks within fields of the SCO file that causes [SmarterCSV](https://www.rubydoc.info/github/tilo/smarter_csv) to throw an invalid quotation mark error. We are using the fix as suggested by [SmarterCSV's](https://www.rubydoc.info/github/tilo/smarter_csv) documentation to fix the nested quotation marks issue that comes up when uploading the SCO csv.\r\n\r\n\r\n## Testing done\r\n\r\n\r\n## Screenshots\r\n\r\n\r\n## Acceptance criteria\r\n- [x] Able to upload a SCO file.\r\n\r\n## Definition of done\r\n- [ ] Events are logged appropriately\r\n- [ ] Documentation has been updated, if applicable\r\n- [ ] A link has been provided to the originating GitHub issue (or connected to it via ZenHub)\r\n- [ ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs","created_at":"2020-01-07T13:46:27Z","updated_at":"2020-01-09T20:30:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2052c74140af7ee5f4e11fe399b41aa0c892309","assignee":{"login":"hughes-dustin","id":48804654,"node_id":"MDQ6VXNlcjQ4ODA0NjU0","avatar_url":"https://avatars1.githubusercontent.com/u/48804654?v=4","gravatar_id":"","url":"https://api.github.com/users/hughes-dustin","html_url":"https://github.com/hughes-dustin","followers_url":"https://api.github.com/users/hughes-dustin/followers","following_url":"https://api.github.com/users/hughes-dustin/following{/other_user}","gists_url":"https://api.github.com/users/hughes-dustin/gists{/gist_id}","starred_url":"https://api.github.com/users/hughes-dustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughes-dustin/subscriptions","organizations_url":"https://api.github.com/users/hughes-dustin/orgs","repos_url":"https://api.github.com/users/hughes-dustin/repos","events_url":"https://api.github.com/users/hughes-dustin/events{/privacy}","received_events_url":"https://api.github.com/users/hughes-dustin/received_events","type":"User","site_admin":false},"assignees":[{"login":"hughes-dustin","id":48804654,"node_id":"MDQ6VXNlcjQ4ODA0NjU0","avatar_url":"https://avatars1.githubusercontent.com/u/48804654?v=4","gravatar_id":"","url":"https://api.github.com/users/hughes-dustin","html_url":"https://github.com/hughes-dustin","followers_url":"https://api.github.com/users/hughes-dustin/followers","following_url":"https://api.github.com/users/hughes-dustin/following{/other_user}","gists_url":"https://api.github.com/users/hughes-dustin/gists{/gist_id}","starred_url":"https://api.github.com/users/hughes-dustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughes-dustin/subscriptions","organizations_url":"https://api.github.com/users/hughes-dustin/orgs","repos_url":"https://api.github.com/users/hughes-dustin/repos","events_url":"https://api.github.com/users/hughes-dustin/events{/privacy}","received_events_url":"https://api.github.com/users/hughes-dustin/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"annaswims","id":19188,"node_id":"MDQ6VXNlcjE5MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/19188?v=4","gravatar_id":"","url":"https://api.github.com/users/annaswims","html_url":"https://github.com/annaswims","followers_url":"https://api.github.com/users/annaswims/followers","following_url":"https://api.github.com/users/annaswims/following{/other_user}","gists_url":"https://api.github.com/users/annaswims/gists{/gist_id}","starred_url":"https://api.github.com/users/annaswims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annaswims/subscriptions","organizations_url":"https://api.github.com/users/annaswims/orgs","repos_url":"https://api.github.com/users/annaswims/repos","events_url":"https://api.github.com/users/annaswims/events{/privacy}","received_events_url":"https://api.github.com/users/annaswims/received_events","type":"User","site_admin":false},{"login":"zurbergram","id":1094999,"node_id":"MDQ6VXNlcjEwOTQ5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1094999?v=4","gravatar_id":"","url":"https://api.github.com/users/zurbergram","html_url":"https://github.com/zurbergram","followers_url":"https://api.github.com/users/zurbergram/followers","following_url":"https://api.github.com/users/zurbergram/following{/other_user}","gists_url":"https://api.github.com/users/zurbergram/gists{/gist_id}","starred_url":"https://api.github.com/users/zurbergram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurbergram/subscriptions","organizations_url":"https://api.github.com/users/zurbergram/orgs","repos_url":"https://api.github.com/users/zurbergram/repos","events_url":"https://api.github.com/users/zurbergram/events{/privacy}","received_events_url":"https://api.github.com/users/zurbergram/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1399748730,"node_id":"MDU6TGFiZWwxMzk5NzQ4NzMw","url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/labels/BAH","name":"BAH","color":"1c7677","default":false,"description":"Booz Allen Hamilton"}],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/539/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/539/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues/539/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/statuses/4b9932ccf40cb00cf68cd3ef15ecc64d84326ee3","head":{"label":"department-of-veterans-affairs:bah-4308","ref":"bah-4308","sha":"4b9932ccf40cb00cf68cd3ef15ecc64d84326ee3","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":52401729,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQwMTcyOQ==","name":"gibct-data-service","full_name":"department-of-veterans-affairs/gibct-data-service","private":false,"owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/department-of-veterans-affairs/gibct-data-service","description":"Allows stakeholders to build a valid GIBCT database from various data sources and apis.","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/deployments","created_at":"2016-02-24T00:24:29Z","updated_at":"2020-01-08T17:39:13Z","pushed_at":"2020-01-09T20:10:46Z","git_url":"git://github.com/department-of-veterans-affairs/gibct-data-service.git","ssh_url":"git@github.com:department-of-veterans-affairs/gibct-data-service.git","clone_url":"https://github.com/department-of-veterans-affairs/gibct-data-service.git","svn_url":"https://github.com/department-of-veterans-affairs/gibct-data-service","homepage":null,"size":85788,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":9,"watchers":5,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"49909e935d1142f43a47d299bacb58999ba4c1ab","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":52401729,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQwMTcyOQ==","name":"gibct-data-service","full_name":"department-of-veterans-affairs/gibct-data-service","private":false,"owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/department-of-veterans-affairs/gibct-data-service","description":"Allows stakeholders to build a valid GIBCT database from various data sources and apis.","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/deployments","created_at":"2016-02-24T00:24:29Z","updated_at":"2020-01-08T17:39:13Z","pushed_at":"2020-01-09T20:10:46Z","git_url":"git://github.com/department-of-veterans-affairs/gibct-data-service.git","ssh_url":"git@github.com:department-of-veterans-affairs/gibct-data-service.git","clone_url":"https://github.com/department-of-veterans-affairs/gibct-data-service.git","svn_url":"https://github.com/department-of-veterans-affairs/gibct-data-service","homepage":null,"size":85788,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":9,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/539"},"html":{"href":"https://github.com/department-of-veterans-affairs/gibct-data-service/pull/539"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues/539"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service/statuses/4b9932ccf40cb00cf68cd3ef15ecc64d84326ee3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 52401729,
"name": "department-of-veterans-affairs/gibct-data-service",
"url": "https://api.github.com/repos/department-of-veterans-affairs/gibct-data-service"
}
|
{
"id": 733873,
"login": "jholton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/733873?",
"url": "https://api.github.com/users/jholton"
}
|
{
"id": 5421563,
"login": "department-of-veterans-affairs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5421563?",
"url": "https://api.github.com/orgs/department-of-veterans-affairs"
}
| 2020-01-09T20:30:10 |
11241332413
|
{"actor":{"display_login":"jholton"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/comments/359401489","pull_request_review_id":334042020,"id":359401489,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTQwMTQ4OQ==","diff_hunk":"@@ -1146,26 +1211,29 @@ protected final OpResult _put(DHTKey key, ByteBuffer value, StorageParametersAnd\n Log.warningf(\"%s %d %d %s\", key, storageParams.getVersion(), storageParams.getRequiredPreviousVersion(), versionCheckResult);\n }\n }\n- switch (versionCheckResult) {\n- case Invalid:\n+ if (versionCheckResult == VersionCheckResult.Invalid) {\n if (debug) {\n- System.out.println(\"_put returning INVALID_VERSION\");\n+ Log.fineAsync(\"_put returning INVALID_VERSION\");","path":"src/com/ms/silverking/cloud/dht/daemon/storage/NamespaceStore.java","position":467,"original_position":467,"commit_id":"676fe6363f155b271128f3b6cd8d53a54e2f07b7","original_commit_id":"676fe6363f155b271128f3b6cd8d53a54e2f07b7","user":{"login":"gjms","id":24530958,"node_id":"MDQ6VXNlcjI0NTMwOTU4","avatar_url":"https://avatars1.githubusercontent.com/u/24530958?v=4","gravatar_id":"","url":"https://api.github.com/users/gjms","html_url":"https://github.com/gjms","followers_url":"https://api.github.com/users/gjms/followers","following_url":"https://api.github.com/users/gjms/following{/other_user}","gists_url":"https://api.github.com/users/gjms/gists{/gist_id}","starred_url":"https://api.github.com/users/gjms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjms/subscriptions","organizations_url":"https://api.github.com/users/gjms/orgs","repos_url":"https://api.github.com/users/gjms/repos","events_url":"https://api.github.com/users/gjms/events{/privacy}","received_events_url":"https://api.github.com/users/gjms/received_events","type":"User","site_admin":false},"body":"warning","created_at":"2019-12-18T15:17:44Z","updated_at":"2019-12-18T15:27:48Z","html_url":"https://github.com/Morgan-Stanley/SilverKing/pull/15#discussion_r359401489","pull_request_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/comments/359401489"},"html":{"href":"https://github.com/Morgan-Stanley/SilverKing/pull/15#discussion_r359401489"},"pull_request":{"href":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/15","id":347753103,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3NzUzMTAz","html_url":"https://github.com/Morgan-Stanley/SilverKing/pull/15","diff_url":"https://github.com/Morgan-Stanley/SilverKing/pull/15.diff","patch_url":"https://github.com/Morgan-Stanley/SilverKing/pull/15.patch","issue_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/issues/15","number":15,"state":"open","locked":false,"title":"release internal development changes","user":{"login":"cbwl","id":511316,"node_id":"MDQ6VXNlcjUxMTMxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/511316?v=4","gravatar_id":"","url":"https://api.github.com/users/cbwl","html_url":"https://github.com/cbwl","followers_url":"https://api.github.com/users/cbwl/followers","following_url":"https://api.github.com/users/cbwl/following{/other_user}","gists_url":"https://api.github.com/users/cbwl/gists{/gist_id}","starred_url":"https://api.github.com/users/cbwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbwl/subscriptions","organizations_url":"https://api.github.com/users/cbwl/orgs","repos_url":"https://api.github.com/users/cbwl/repos","events_url":"https://api.github.com/users/cbwl/events{/privacy}","received_events_url":"https://api.github.com/users/cbwl/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-02T16:51:48Z","updated_at":"2019-12-18T15:27:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52bd8ca7dcea9b42768929fe7585410293a357cd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/issues/15/comments","statuses_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/statuses/676fe6363f155b271128f3b6cd8d53a54e2f07b7","head":{"label":"cbwl:release/50","ref":"release/50","sha":"676fe6363f155b271128f3b6cd8d53a54e2f07b7","user":{"login":"cbwl","id":511316,"node_id":"MDQ6VXNlcjUxMTMxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/511316?v=4","gravatar_id":"","url":"https://api.github.com/users/cbwl","html_url":"https://github.com/cbwl","followers_url":"https://api.github.com/users/cbwl/followers","following_url":"https://api.github.com/users/cbwl/following{/other_user}","gists_url":"https://api.github.com/users/cbwl/gists{/gist_id}","starred_url":"https://api.github.com/users/cbwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbwl/subscriptions","organizations_url":"https://api.github.com/users/cbwl/orgs","repos_url":"https://api.github.com/users/cbwl/repos","events_url":"https://api.github.com/users/cbwl/events{/privacy}","received_events_url":"https://api.github.com/users/cbwl/received_events","type":"User","site_admin":false},"repo":{"id":190175216,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAxNzUyMTY=","name":"SilverKing","full_name":"cbwl/SilverKing","private":false,"owner":{"login":"cbwl","id":511316,"node_id":"MDQ6VXNlcjUxMTMxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/511316?v=4","gravatar_id":"","url":"https://api.github.com/users/cbwl","html_url":"https://github.com/cbwl","followers_url":"https://api.github.com/users/cbwl/followers","following_url":"https://api.github.com/users/cbwl/following{/other_user}","gists_url":"https://api.github.com/users/cbwl/gists{/gist_id}","starred_url":"https://api.github.com/users/cbwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbwl/subscriptions","organizations_url":"https://api.github.com/users/cbwl/orgs","repos_url":"https://api.github.com/users/cbwl/repos","events_url":"https://api.github.com/users/cbwl/events{/privacy}","received_events_url":"https://api.github.com/users/cbwl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cbwl/SilverKing","description":"Scalable, high-throughput storage and coordination","fork":true,"url":"https://api.github.com/repos/cbwl/SilverKing","forks_url":"https://api.github.com/repos/cbwl/SilverKing/forks","keys_url":"https://api.github.com/repos/cbwl/SilverKing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbwl/SilverKing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbwl/SilverKing/teams","hooks_url":"https://api.github.com/repos/cbwl/SilverKing/hooks","issue_events_url":"https://api.github.com/repos/cbwl/SilverKing/issues/events{/number}","events_url":"https://api.github.com/repos/cbwl/SilverKing/events","assignees_url":"https://api.github.com/repos/cbwl/SilverKing/assignees{/user}","branches_url":"https://api.github.com/repos/cbwl/SilverKing/branches{/branch}","tags_url":"https://api.github.com/repos/cbwl/SilverKing/tags","blobs_url":"https://api.github.com/repos/cbwl/SilverKing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbwl/SilverKing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbwl/SilverKing/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbwl/SilverKing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbwl/SilverKing/statuses/{sha}","languages_url":"https://api.github.com/repos/cbwl/SilverKing/languages","stargazers_url":"https://api.github.com/repos/cbwl/SilverKing/stargazers","contributors_url":"https://api.github.com/repos/cbwl/SilverKing/contributors","subscribers_url":"https://api.github.com/repos/cbwl/SilverKing/subscribers","subscription_url":"https://api.github.com/repos/cbwl/SilverKing/subscription","commits_url":"https://api.github.com/repos/cbwl/SilverKing/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbwl/SilverKing/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbwl/SilverKing/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbwl/SilverKing/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbwl/SilverKing/contents/{+path}","compare_url":"https://api.github.com/repos/cbwl/SilverKing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbwl/SilverKing/merges","archive_url":"https://api.github.com/repos/cbwl/SilverKing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbwl/SilverKing/downloads","issues_url":"https://api.github.com/repos/cbwl/SilverKing/issues{/number}","pulls_url":"https://api.github.com/repos/cbwl/SilverKing/pulls{/number}","milestones_url":"https://api.github.com/repos/cbwl/SilverKing/milestones{/number}","notifications_url":"https://api.github.com/repos/cbwl/SilverKing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbwl/SilverKing/labels{/name}","releases_url":"https://api.github.com/repos/cbwl/SilverKing/releases{/id}","deployments_url":"https://api.github.com/repos/cbwl/SilverKing/deployments","created_at":"2019-06-04T09:56:44Z","updated_at":"2019-06-04T09:56:51Z","pushed_at":"2019-12-16T09:38:35Z","git_url":"git://github.com/cbwl/SilverKing.git","ssh_url":"git@github.com:cbwl/SilverKing.git","clone_url":"https://github.com/cbwl/SilverKing.git","svn_url":"https://github.com/cbwl/SilverKing","homepage":"","size":122836,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Morgan-Stanley:master","ref":"master","sha":"a4febcdebe6b039ca45a325fa12e2387274d6cb6","user":{"login":"Morgan-Stanley","id":5435928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzU5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5435928?v=4","gravatar_id":"","url":"https://api.github.com/users/Morgan-Stanley","html_url":"https://github.com/Morgan-Stanley","followers_url":"https://api.github.com/users/Morgan-Stanley/followers","following_url":"https://api.github.com/users/Morgan-Stanley/following{/other_user}","gists_url":"https://api.github.com/users/Morgan-Stanley/gists{/gist_id}","starred_url":"https://api.github.com/users/Morgan-Stanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morgan-Stanley/subscriptions","organizations_url":"https://api.github.com/users/Morgan-Stanley/orgs","repos_url":"https://api.github.com/users/Morgan-Stanley/repos","events_url":"https://api.github.com/users/Morgan-Stanley/events{/privacy}","received_events_url":"https://api.github.com/users/Morgan-Stanley/received_events","type":"Organization","site_admin":false},"repo":{"id":76290583,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI5MDU4Mw==","name":"SilverKing","full_name":"Morgan-Stanley/SilverKing","private":false,"owner":{"login":"Morgan-Stanley","id":5435928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzU5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5435928?v=4","gravatar_id":"","url":"https://api.github.com/users/Morgan-Stanley","html_url":"https://github.com/Morgan-Stanley","followers_url":"https://api.github.com/users/Morgan-Stanley/followers","following_url":"https://api.github.com/users/Morgan-Stanley/following{/other_user}","gists_url":"https://api.github.com/users/Morgan-Stanley/gists{/gist_id}","starred_url":"https://api.github.com/users/Morgan-Stanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morgan-Stanley/subscriptions","organizations_url":"https://api.github.com/users/Morgan-Stanley/orgs","repos_url":"https://api.github.com/users/Morgan-Stanley/repos","events_url":"https://api.github.com/users/Morgan-Stanley/events{/privacy}","received_events_url":"https://api.github.com/users/Morgan-Stanley/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Morgan-Stanley/SilverKing","description":"Scalable, high-throughput storage and coordination","fork":false,"url":"https://api.github.com/repos/Morgan-Stanley/SilverKing","forks_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/forks","keys_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/teams","hooks_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/hooks","issue_events_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/issues/events{/number}","events_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/events","assignees_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/assignees{/user}","branches_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/branches{/branch}","tags_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/tags","blobs_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/git/refs{/sha}","trees_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/statuses/{sha}","languages_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/languages","stargazers_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/stargazers","contributors_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/contributors","subscribers_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/subscribers","subscription_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/subscription","commits_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/commits{/sha}","git_commits_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/git/commits{/sha}","comments_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/comments{/number}","issue_comment_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/issues/comments{/number}","contents_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/contents/{+path}","compare_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/merges","archive_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/downloads","issues_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/issues{/number}","pulls_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls{/number}","milestones_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/milestones{/number}","notifications_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/labels{/name}","releases_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/releases{/id}","deployments_url":"https://api.github.com/repos/Morgan-Stanley/SilverKing/deployments","created_at":"2016-12-12T19:56:12Z","updated_at":"2019-12-14T07:25:14Z","pushed_at":"2019-12-16T09:38:38Z","git_url":"git://github.com/Morgan-Stanley/SilverKing.git","ssh_url":"git@github.com:Morgan-Stanley/SilverKing.git","clone_url":"https://github.com/Morgan-Stanley/SilverKing.git","svn_url":"https://github.com/Morgan-Stanley/SilverKing","homepage":"","size":119167,"stargazers_count":39,"watchers_count":39,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":2,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/15"},"html":{"href":"https://github.com/Morgan-Stanley/SilverKing/pull/15"},"issue":{"href":"https://api.github.com/repos/Morgan-Stanley/SilverKing/issues/15"},"comments":{"href":"https://api.github.com/repos/Morgan-Stanley/SilverKing/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Morgan-Stanley/SilverKing/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Morgan-Stanley/SilverKing/statuses/676fe6363f155b271128f3b6cd8d53a54e2f07b7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 76290583,
"name": "Morgan-Stanley/SilverKing",
"url": "https://api.github.com/repos/Morgan-Stanley/SilverKing"
}
|
{
"id": 24530958,
"login": "gjms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24530958?",
"url": "https://api.github.com/users/gjms"
}
|
{
"id": 5435928,
"login": "Morgan-Stanley",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5435928?",
"url": "https://api.github.com/orgs/Morgan-Stanley"
}
| 2019-12-18T15:17:44 |
11117744101
|
{"actor":{"display_login":"gjms"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/comments/342442555","pull_request_review_id":311577884,"id":342442555,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MjQ0MjU1NQ==","diff_hunk":"@@ -0,0 +1,56 @@\n+package ru.tinkoff.qa.neptune.data.base.api.queries.jdoql;\n+\n+import ru.tinkoff.qa.neptune.data.base.api.PersistableObject;\n+\n+import javax.jdo.JDOQLTypedQuery;\n+import javax.jdo.query.PersistableExpression;\n+\n+import static java.util.Objects.nonNull;\n+import static java.util.Optional.ofNullable;\n+\n+/**\n+ * This class is designed to construct/detail {@link JDOQLTypedQuery} to select list of stored objects\n+ *\n+ * @param <T> is a type of {@link PersistableObject} to be selected\n+ * @param <Q> is a type of {@link PersistableExpression} that represents {@code T} in a query\n+ */\n+public final class JDOQLQueryParameters<T extends PersistableObject, Q extends PersistableExpression<T>>\n+ extends JDOParameters<T, Q, JDOQLQueryParameters<T, Q>>{\n+\n+ private JDOQLQueryParameters(Class<? extends Q> toUse) {\n+ super(toUse);\n+ }\n+\n+ /**\n+ * Creates an object that constructs/adds details to a query.\n+ *\n+ * @param toUse is a class of {@link PersistableExpression} that represents {@code T} in a query. It is important:\n+ * <p>\n+ * The class should have the accessible static {@code 'candidate()'} methods that creates/returns an instance\n+ * </p>\n+ *\n+ * @param <T> is a type of {@link PersistableObject} to be selected.\n+ * @param <Q> is a type of {@link PersistableExpression} that represents {@code T} in a query\n+ * @return new {@link JDOQLQueryParameters}\n+ */\n+ public static <T extends PersistableObject, Q extends PersistableExpression<T>> JDOQLQueryParameters<T, Q> byJDOQuery(Class<Q> toUse) {\n+ return new JDOQLQueryParameters<>(toUse);\n+ }\n+\n+ public <M extends JDOQLTypedQuery<T>> M buildQuery(M m) {\n+ ofNullable(where).ifPresent(m::filter);\n+\n+ if (nonNull(rangeStart) && nonNull(rangeEnd)) {\n+ m.range(rangeStart, rangeEnd);\n+ }\n+\n+ ofNullable(orderExpressions)","path":"data.base.api/src/main/java/ru/tinkoff/qa/neptune/data/base/api/queries/jdoql/JDOQLQueryParameters.java","position":47,"original_position":47,"commit_id":"fd8444da4d82b27343340069e37b91131d4a1924","original_commit_id":"fd8444da4d82b27343340069e37b91131d4a1924","user":{"login":"ArisAgnew","id":22876165,"node_id":"MDQ6VXNlcjIyODc2MTY1","avatar_url":"https://avatars1.githubusercontent.com/u/22876165?v=4","gravatar_id":"","url":"https://api.github.com/users/ArisAgnew","html_url":"https://github.com/ArisAgnew","followers_url":"https://api.github.com/users/ArisAgnew/followers","following_url":"https://api.github.com/users/ArisAgnew/following{/other_user}","gists_url":"https://api.github.com/users/ArisAgnew/gists{/gist_id}","starred_url":"https://api.github.com/users/ArisAgnew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArisAgnew/subscriptions","organizations_url":"https://api.github.com/users/ArisAgnew/orgs","repos_url":"https://api.github.com/users/ArisAgnew/repos","events_url":"https://api.github.com/users/ArisAgnew/events{/privacy}","received_events_url":"https://api.github.com/users/ArisAgnew/received_events","type":"User","site_admin":false},"body":"```\r\nofNullable(orderExpressions)\r\n .filter(oe -> oe.length > 0)\r\n .ifPresent(oe -> m.orderBy(oe));\r\n```\r\nI suggest like alluded to above.","created_at":"2019-11-05T08:57:50Z","updated_at":"2019-11-05T08:59:08Z","html_url":"https://github.com/TinkoffCreditSystems/neptune/pull/133#discussion_r342442555","pull_request_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/133","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/comments/342442555"},"html":{"href":"https://github.com/TinkoffCreditSystems/neptune/pull/133#discussion_r342442555"},"pull_request":{"href":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/133","id":334353375,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0MzUzMzc1","html_url":"https://github.com/TinkoffCreditSystems/neptune/pull/133","diff_url":"https://github.com/TinkoffCreditSystems/neptune/pull/133.diff","patch_url":"https://github.com/TinkoffCreditSystems/neptune/pull/133.patch","issue_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/issues/133","number":133,"state":"open","locked":false,"title":"Data base module. Fully redesigned.","user":{"login":"TikhomirovSergey","id":4927589,"node_id":"MDQ6VXNlcjQ5Mjc1ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/4927589?v=4","gravatar_id":"","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"body":"## Preconditions\r\n\r\nImagine that we have 2 data bases. Tables are mapped as following:\r\n\r\n**DB 1**\r\n\r\n[Authors](https://gist.github.com/TikhomirovSergey/454a353ae146260a49076f0e05881818)\r\n[Books](https://gist.github.com/TikhomirovSergey/1c25521412af0d72d4e504931b33460f)\r\n[Publishers](https://gist.github.com/TikhomirovSergey/2a55fd1a86b1b747644fa4bd21914c49)\r\n[Catalog](https://gist.github.com/TikhomirovSergey/d75bf2715daad442158464b4937977aa)\r\n\r\n**DB 2**\r\n\r\n[Manufacturer](https://gist.github.com/TikhomirovSergey/39c286ca17783979034779b5b4cfb370)\r\n[Car](https://gist.github.com/TikhomirovSergey/d06cccd7be786b3687ce090596da74d0)\r\n[CarModels](https://gist.github.com/TikhomirovSergey/e253594f714443440903b0765618c88e)\r\n\r\nSo lets get started.\r\n\r\n_______________________________________________________________________________________________\r\n## Connection metadata\r\n\r\n**The issue to resolve**\r\n\r\nPreviously we used the property `default.db.connection` to define the frequently used **DB connection**/**persistance manager factory**. With other data bases we had to define desired **DB connection**/**persistance manager factory** explicitly.\r\n\r\n```java\r\nvar result= databaseSteps.get(selected(aSingleByQuery(ofType(Manufacturer.class)\r\n .where(QManufacturer.candidate().name.eq(\"Ferrari\"))))\r\n .useConnection(DB2ConnectionSupplier.class))\r\n```\r\n\r\nThis is not convenient in many cases. \r\n\r\n**The solution**\r\n\r\nThe binding of **mapping classes** to classes that describe **DB connection**/**persistance manager factory** on metadata level:\r\n\r\n- by annotating classes\r\n\r\n```java\r\nimport ru.tinkoff.qa.neptune.data.base.api.ConnectionToUse;\r\n...\r\nimport ...ConnectionDataSupplierForTestBase1;\r\n...\r\n\r\nimport javax.jdo.annotations.*;\r\n\r\n@ConnectionToUse(connectionSupplier = ConnectionDataSupplierForTestBase1.class)\r\n@PersistenceCapable(table = \"Books\")\r\npublic class Book extends PersistableObject {\r\n...\r\n```\r\n\r\n- by annotating packages\r\nCreate a file `package-info.java` and put it to package that contains mapping classes or put it some to some more highlevel package.\r\n\r\n```java\r\n@ConnectionToUse(connectionSupplier = ConnectionDataSupplierForTestBase2.class)\r\npackage some.package;\r\n\r\nimport ru.tinkoff.qa.neptune.data.base.api.ConnectionToUse;\r\nimport ...ConnectionDataSupplierForTestBase2;\r\n```\r\n\r\n\r\n**And then**: \r\n\r\n```java\r\ndataBaseSteps.select(oneOf(Manufacturer.class, byJDOQuery(QManufacturer.class)\r\n .where(qManufacturer -> qManufacturer.name.eq(\"Ferrari\"))))\r\n```\r\n\r\n**Result**\r\n\r\nThe property `default.db.connection` is not supported any more. \r\n\r\n**Still not resolved**\r\n\r\nIt is necessary to define **DB connection**/**persistance manager factory** explicitly when it tries to select raw data by SQL\r\n\r\n```java\r\ndataBaseSteps.select(rows(\"Select * from Books join Authors on Books.Author = Authors.Id \" +\r\n \"where Books.YearOfFinishing >= ? order by YearOfFinishing asc\",\r\n ConnectionDataSupplierForTestBase1.class,\r\n 1820))\r\n```\r\n_______________________________________________________________________________________________\r\n\r\n## Querying (full examples)\r\n\r\n### With no query\r\n\r\n- Select a single first found object:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.oneOf;\r\n...\r\n\r\ndataBaseSteps.select(oneOf(Publisher.class)\r\n .criteria(\"Criteria one \", publisher -> {return true;}) //criteria if \r\n .criteria(OR, \"Criteria two\", publisher -> {return true;}) //necessary\r\n .timeOut(ofSeconds(30)) //time if where is no such object right now, but it is supposed\r\n //to appear after some time\r\n .pollingInterval(ofMillis(500)) //between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\")); //when it is necessary to throw\r\n //exception on empty result\r\n```\r\n\r\n- Select list of objects:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.listOf;\r\n...\r\n\r\ndataBaseSteps.select(listOf(Publisher.class)\r\n .criteria(\"Criteria one \", publisher -> {return true;}) //criteria if \r\n .criteria(OR, \"Criteria two\", publisher -> {return true;}) //necessary\r\n .timeOut(ofSeconds(30))//time if where is no such objects right now, but it is supposed\r\n //to appear after some time\r\n .pollingInterval(ofMillis(500)) //between to attempts to get values\r\n .throwWhenResultEmpty(\"Some exception message\")); //when it is necessary to throw\r\n //exception on empty result\r\n```\r\n\r\n### By ids\r\n\r\n- Select a single object by id:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.oneOf;\r\n...\r\n\r\ndataBaseSteps.select(oneOf(Publisher.class, 1) //id = 1\r\n .criteria(\"Criteria one \", publisher -> ...) //criteria if id is not\r\n .criteria(OR, \"Criteria two\", publisher -> ...) //enough\r\n .timeOut(ofSeconds(30)) //time if where is no such object right now, but it is supposed\r\n //to appear after some time\r\n .pollingInterval(ofMillis(500)) //between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\")); //when it is necessary to throw\r\n //exception on empty result\r\n```\r\n\r\n- Select list of objects by ids:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.listOf;\r\n...\r\n\r\ndataBaseSteps.select(listOf(Publisher.class, 1, 2, 3) //ids = 1 and/or 2 and/or 3\r\n .criteria(\"Criteria one \", publisher -> ...) //criteria if id is not\r\n .criteria(OR, \"Criteria two\", publisher -> ...) //enough\r\n .timeOut(ofSeconds(30))//time if where is no such objects right now, but it is supposed\r\n //to appear after some time\r\n .pollingInterval(ofMillis(500))//between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\")); //when it is necessary to throw\r\n //exception on empty result\r\n```\r\n\r\n### By SQL\r\n\r\n- Select a single persistent object by SQL:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.oneOf;\r\n...\r\n\r\ndataBaseSteps.select(oneOf(Author.class,\r\n \"Select * from Books join Authors on Books.Author = Authors.Id \" +\r\n \"where Books.YearOfFinishing >= ? order by YearOfFinishing asc\",\r\n 1820) //sql above contains '?'. This is the parameter mask\r\n //1820 is the parameter value\r\n .criteria(\"Criteria one\", author -> ...)//criteria if sql is not\r\n .criteria(XOR,\"Criteria two\", author -> ...)//enough to get desired object\r\n .timeOut(ofSeconds(30))//time if where is no such object right now, but it is supposed\r\n //to appear after some time\r\n .pollingInterval(ofMillis(500))//between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\")); //when it is necessary to throw\r\n // exception on empty result\r\n```\r\n\r\n- Select a list of persistent objects by SQL:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.listOf;\r\n...\r\n\r\ndataBaseSteps.select(listOf(Author.class,\r\n \"Select * from Books join Authors on Books.Author = Authors.Id \" +\r\n \"where Books.YearOfFinishing >= ? order by YearOfFinishing asc\",\r\n 1820) //sql above contains '?'. This is the parameter mask\r\n //1820 is the parameter value\r\n .criteria(\"Criteria one\", author -> ...)//criteria if sql is not\r\n .criteria(XOR,\"Criteria two\", author -> ...)//enough to get desired objects\r\n .timeOut(ofSeconds(30))//time if where is no such objects right now, but it is supposed\r\n //to appear after some time\r\n .pollingInterval(ofMillis(500))//between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\"));//when it is necessary to throw\r\n // exception on empty result\r\n```\r\n\r\n- Select a single row of raw stored data by SQL:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.row;\r\n...\r\n\r\ndataBaseSteps.select(row(\"Select * from Books join Authors on Books.Author = Authors.Id \" +\r\n \"where Books.YearOfFinishing >= ? order by YearOfFinishing asc\",\r\n ConnectionDataSupplierForTestBase1.class,\r\n 1820) //sql above contains '?'. This is the parameter mask\r\n //1820 is the parameter value\r\n .criteria(\"Criteria one\", objects -> ...)//criteria if sql is not\r\n .criteria(XOR,\"Criteria two\", objects -> ...)//enough to get desired record\r\n .timeOut(ofSeconds(30))//time if where is no such record right now,\r\n // but it is supposed to appear after some time\r\n .pollingInterval(ofMillis(500))//between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\"));//when it is necessary to throw\r\n // exception on empty result\r\n```\r\n\r\n- Select rows of raw stored data by SQL:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.rows;\r\n...\r\n\r\ndataBaseSteps.select(rows(\"Select * from Books join Authors on Books.Author = Authors.Id \" +\r\n \"where Books.YearOfFinishing >= ? order by YearOfFinishing asc\",\r\n ConnectionDataSupplierForTestBase1.class,\r\n 1820)//sql above contains '?'. This is the parameter mask\r\n //1820 is the parameter value\r\n .criteria(\"Criteria one\", objects -> ...)//criteria if sql is not\r\n .criteria(XOR,\"Criteria two\", objects -> ...)//enough to get desired records\r\n .timeOut(ofSeconds(30))//time if where is no such records right now,\r\n // but it is supposed to appear after some time\r\n .pollingInterval(ofMillis(500))//between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\"));//when it is necessary to throw\r\n // exception on empty result\r\n```\r\n\r\n### By JDO Typed queries\r\n\r\n- Select a single persistent object:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.oneOf;\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.jdoql.JDOQLQueryParameters.byJDOQuery;\r\n...\r\n\r\ndataBaseSteps.select(oneOf(Author.class, byJDOQuery(QAuthor.class)\r\n .where(qAuthor -> qAuthor.firstName.eq(\"Carlos\").and(qAuthor.lastName.eq(\"Castaneda\")))\r\n .addOrderBy(qAuthor -> qAuthor.id.asc()) //where and order by clauses are supported\r\n .range(0, 100))\r\n .criteria(\"Criteria one\", author -> ...)//criteria if query is not\r\n .criteria(XOR,\"Criteria two\", author -> ...) //enough/convenient to get \r\n // desired object\r\n .timeOut(ofSeconds(30))//time if where is no such object right now,\r\n .pollingInterval(ofMillis(500))//between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\"));//when it is necessary to throw\r\n // exception on empty result\r\n```\r\n\r\n- Select a list of persistent objects:\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.listOf;\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.jdoql.JDOQLQueryParameters.byJDOQuery;\r\n...\r\n\r\ndataBaseSteps.select(listOf(Author.class, byJDOQuery(QAuthor.class)\r\n .where(qAuthor -> qAuthor.firstName.eq(\"Carlos\").and(qAuthor.lastName.eq(\"Castaneda\")))\r\n .addOrderBy(qAuthor -> qAuthor.id.asc()) //where and order by clauses are supported\r\n .range(0, 100))\r\n .criteria(\"Criteria one\", author -> ...)//criteria if query is not\r\n .criteria(XOR,\"Criteria two\", author -> ...) //enough/convenient to get\r\n // desired objects\r\n .timeOut(ofSeconds(30))//time if where is no such objects right now,\r\n .pollingInterval(ofMillis(500))//between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\"));//when it is necessary to throw\r\n // exception on empty result\r\n```\r\n\r\n- Select a single row of data retrieved from fields of persistent object (new feature):\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.row;\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.jdoql.JDOQLResultQueryParams.byJDOResultQuery;\r\n...\r\n\r\ndataBaseSteps.select(row(Book.class, byJDOResultQuery(QBook.class)\r\n .addResultField(qBook -> qBook.author)\r\n .addResultField(qBook -> qBook.name) //it is necessary to define result fields here\r\n .addResultField(qBook -> qBook.yearOfFinishing.max())\r\n .where(qBook -> qBook.yearOfFinishing.lt(1972))//where and order by clauses are supported\r\n .addGroupBy(qBook -> qBook.author)//also supported group by\r\n .addOrderBy(qBook -> qBook.id.asc())\r\n .having(qBook -> qBook.id.count().gteq(1))//and having\r\n .distinct(true))//when it is necessary to retrieve distinct rows\r\n .criteria(\"Criteria one\", objects -> ...) //criteria if query is not\r\n .criteria(XOR,\"Criteria two\", objects -> ...) //enough/convenient to get\r\n //desired row\r\n .timeOut(ofSeconds(30))//time if where is no such object right now,\r\n .pollingInterval(ofMillis(500))//between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\"));//when it is necessary to throw\r\n // exception on empty result\r\n```\r\n\r\nIt is sumilar to the selecting of raw data by sql, but it looks like it is query to the mapping class. Result is not a raw last of values selected from the datastore directly. Resulted list/row contains values retrieved from an object of the mapping class.\r\n\r\nThe result of such query see below: \r\n\r\n\r\n\r\n- Select a rows of data retrieved from fields of persistent objects:\r\n\r\nIt is similar to the sample above. Result is a list of lists. Each list item contains fields values retrieved from found persistent objects.\r\n\r\n```java\r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.rows;\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.jdoql.JDOQLResultQueryParams.byJDOResultQuery;\r\n...\r\n\r\ndataBaseSteps.select(rows(Book.class, byJDOResultQuery(QBook.class)\r\n .addResultField(qBook -> qBook.author)\r\n .addResultField(qBook -> qBook.name) //it is necessary to define result fields here\r\n .addResultField(qBook -> qBook.yearOfFinishing.max())\r\n .where(qBook -> qBook.yearOfFinishing.lt(1972))//where and order by clauses are supported\r\n .addGroupBy(qBook -> qBook.author)//also supported group by\r\n .addOrderBy(qBook -> qBook.id.asc())\r\n .having(qBook -> qBook.id.count().gteq(1))//and having\r\n .distinct(true))//when it is necessary to retrieve distinct rows\r\n .criteria(\"Criteria one\", objects -> true) //criteria if query is not\r\n .criteria(XOR,\"Criteria two\", objects -> true) //enough/convenient to get\r\n //desired rows\r\n .timeOut(ofSeconds(30))//time if where is no such objects right now,\r\n .pollingInterval(ofMillis(500))//between to attempts to get value\r\n .throwWhenResultEmpty(\"Some exception message\"));//when it is necessary to throw\r\n // exception on empty result\r\n```\r\n_______________________________________________________________________________________________\r\n\r\n## Data operations\r\n\r\n## Inserting\r\n\r\nIt is not posible to insert data to a data store directly. So it works using mapping classes. \r\n\r\n```java\r\nvar catalogItem = new Catalog().setBook(...)\r\n .setPublisher(...)\r\n .setYearOfPublishing(...);\r\n\r\nvar insertedItem = dataBaseSteps.insert(catalogItem); \r\n//single object\r\n```\r\n\r\n```java\r\nvar catalogItem1 = new Catalog().setBook(...)\r\n .setPublisher(...)\r\n .setYearOfPublishing(...);\r\n\r\nvar catalogItem2 = new Catalog().setBook(...)\r\n .setPublisher(...)\r\n .setYearOfPublishing(...);\r\n\r\nvar insertedItem2 = dataBaseSteps.insert(catalogItem1, catalogItem2); \r\n//list of objects\r\n```\r\n\r\n```java\r\nvar catalogItem1 = new Catalog().setBook(...)\r\n .setPublisher(...)\r\n .setYearOfPublishing(...);\r\n\r\nvar catalogItem2 = new Catalog().setBook(...)\r\n .setPublisher(...)\r\n .setYearOfPublishing(...);\r\n\r\nvar carModel = new CarModel().setCar(new Car().setManufacturer(...)\r\n .setName(...))\r\n .setCarModelName(...)\r\n .setProducedFrom(...);\r\n\r\n//below is the sample how to insert objects \r\n//from different databases at one pseudo transaction\r\nvar insertedItem2 = dataBaseSteps.insert(catalogItem1, catalogItem2, carModel ); \r\n//list of objects\r\n```\r\n\r\n## Updating\r\n\r\nIt is not posible to update data directly. So it works using mapping classes. \r\n\r\n- updating previously selected objects:\r\n\r\n```java \r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.data.operations.UpdateExpression.change;\r\n...\r\n\r\n//updating a single object\r\nAuthor dostoevsky = ... //selecting the record \r\n\r\n...\r\n//a single object is returned\r\nvar updatedAuthor = dataBaseSteps.update(dostoevsky,\r\n change(\"Add biography details\", author -> author.setBiography(\"...\")),\r\n change(\"Improve birthday\", author -> author.setBirthDate(...)),\r\n change(\"change something else\", author -> {...}));\r\n```\r\n\r\n```java \r\n...\r\nimport static java.util.List.of;\r\nimport static ru.tinkoff.qa.neptune.data.base.api.data.operations.UpdateExpression.change;\r\n...\r\n\r\n//updating multiple objects from the same data base\r\nAuthor dostoevsky = ... //selecting the record \r\nAuthor jackLondon = ... //selecting the record \r\n\r\n...\r\n//list of updated objects returns here\r\nvar updatedAuthors = dataBaseSteps.update(of(dostoevsky, jackLondon),\r\n change(\"Add biography details\", author -> author.setBiography(\"...\")),\r\n change(\"Improve birthday\", author -> author.setBirthDate(...)),\r\n change(\"change something else\", author -> {...}));\r\n```\r\n\r\n```java \r\n...\r\nimport static java.util.List.of;\r\nimport static ru.tinkoff.qa.neptune.data.base.api.data.operations.UpdateExpression.change;\r\n...\r\n\r\n//updating multiple objects from the different data bases at one pseudo transaction\r\nAuthor dostoevsky = ... //selecting the record \r\nCarModel crownVictoria= ... //selecting the record \r\n\r\n...\r\n//list of updated objects returns here\r\nvar updatedObjects = dataBaseSteps.update(of(dostoevsky, crownVictoria),\r\n change(\"Add biography details to Author\", persistableObject -> {\r\n if (Author.class.isAssignableFrom(persistableObject.getClass())) {\r\n ((Author) persistableObject).setBiography(BIO1);\r\n }\r\n }),\r\n change(\"Change date of the 'Produced to' to current \", persistableObject -> {\r\n if (CarModel.class.isAssignableFrom(persistableObject.getClass())) {\r\n ((CarModel) persistableObject).setProducedTo(dateToChange);\r\n }\r\n }));\r\n```\r\n\r\n- updating objects with selecting by queries \r\n\r\n```java \r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.oneOf;\r\nimport static ru.tinkoff.qa.neptune.data.base.api.data.operations.UpdateExpression.change;\r\n...\r\n\r\n//updating a single object\r\n//a single object is returned\r\nvar updatedAuthor = dataBaseSteps.update(oneOf(Author.class, ...),\r\n change(\"Add biography details to Author\", author ->author.setBiography(...)));\r\n```\r\n\r\n```java \r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.listOf;\r\nimport static ru.tinkoff.qa.neptune.data.base.api.data.operations.UpdateExpression.change;\r\n...\r\n\r\n//updating multiple\r\n//a list of objects is returned\r\nvar updatedAuthor = dataBaseSteps.update(listOf(Author.class, ...),\r\n change(\"Add biography details to Author\", author ->author.setBiography(...)));\r\n```\r\n\r\nWays how to use `ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.oneOf` and \r\n`ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.listOf` have been described above.\r\n\r\n## Deleting\r\n\r\nIt is not posible to remove data from a data store directly. So it works using mapping classes. \r\n\r\n- deleting previously selected objects:\r\n\r\n```java\r\n//deleting a single object\r\nAuthor jackLondon = ... //selecting the record \r\n\r\n...\r\n//a single object is returned\r\nvar deletedAuthor = dataBaseSteps.delete(jackLondon);\r\n```\r\n\r\n```java\r\n//deleting multiple objects from the same data base\r\nAuthor jackLondon = ... //selecting the record \r\nAuthor mikhailBulgakov = ... //selecting the record \r\n\r\n...\r\n//a list of objects is returned\r\nvar deletedAuthors = dataBaseSteps.delete(jackLondon, mikhailBulgakov);\r\n```\r\n\r\n```java\r\n//deleting multiple objects from the different data bases at one \r\n//pseudo transaction\r\nAuthor jackLondon = ... //selecting the record \r\nManufacturer mazda = ... //selecting the record \r\n\r\n...\r\n//a list of objects is returned\r\nvar deletedAuthors = dataBaseSteps.delete(jackLondon, mazda);\r\n```\r\n\r\n- deleting objects with selecting by queries \r\n\r\n```java \r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.oneOf;\r\n...\r\n\r\n//deleting a single object\r\n//a single object is returned\r\nvar updatedAuthor = dataBaseSteps.delete(oneOf(Author.class, ...));\r\n```\r\n\r\n```java \r\n...\r\nimport static ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.listOf;\r\n...\r\n\r\n//updating multiple\r\n//a list of objects is returned\r\nvar updatedAuthor = dataBaseSteps.delete(listOf(Author.class, ...));\r\n```\r\n\r\nWays how to use `ru.tinkoff.qa.neptune.data.base.api.queries.SelectASingle.oneOf` and \r\n`ru.tinkoff.qa.neptune.data.base.api.queries.SelectList.listOf` have been described above.\r\n\r\n## Also\r\n\r\nNow all persistent objects are in detached state after the selecting/inserting/updating/deleting and \r\nthey can change data of a data store only by transactions.\r\n\r\n## Proposed\r\n- re-designed code\r\n- unit tests\r\n","created_at":"2019-10-30T15:58:25Z","updated_at":"2019-11-05T08:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bea5596b0e7730b25f22e262cde5519ac46fb347","assignee":{"login":"TikhomirovSergey","id":4927589,"node_id":"MDQ6VXNlcjQ5Mjc1ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/4927589?v=4","gravatar_id":"","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"assignees":[{"login":"TikhomirovSergey","id":4927589,"node_id":"MDQ6VXNlcjQ5Mjc1ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/4927589?v=4","gravatar_id":"","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"neparij","id":17128581,"node_id":"MDQ6VXNlcjE3MTI4NTgx","avatar_url":"https://avatars3.githubusercontent.com/u/17128581?v=4","gravatar_id":"","url":"https://api.github.com/users/neparij","html_url":"https://github.com/neparij","followers_url":"https://api.github.com/users/neparij/followers","following_url":"https://api.github.com/users/neparij/following{/other_user}","gists_url":"https://api.github.com/users/neparij/gists{/gist_id}","starred_url":"https://api.github.com/users/neparij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neparij/subscriptions","organizations_url":"https://api.github.com/users/neparij/orgs","repos_url":"https://api.github.com/users/neparij/repos","events_url":"https://api.github.com/users/neparij/events{/privacy}","received_events_url":"https://api.github.com/users/neparij/received_events","type":"User","site_admin":false},{"login":"AndrewCharykov","id":32836172,"node_id":"MDQ6VXNlcjMyODM2MTcy","avatar_url":"https://avatars3.githubusercontent.com/u/32836172?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewCharykov","html_url":"https://github.com/AndrewCharykov","followers_url":"https://api.github.com/users/AndrewCharykov/followers","following_url":"https://api.github.com/users/AndrewCharykov/following{/other_user}","gists_url":"https://api.github.com/users/AndrewCharykov/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewCharykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewCharykov/subscriptions","organizations_url":"https://api.github.com/users/AndrewCharykov/orgs","repos_url":"https://api.github.com/users/AndrewCharykov/repos","events_url":"https://api.github.com/users/AndrewCharykov/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewCharykov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":997314596,"node_id":"MDU6TGFiZWw5OTczMTQ1OTY=","url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":1056661241,"node_id":"MDU6TGFiZWwxMDU2NjYxMjQx","url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/labels/core","name":"core","color":"c5def5","default":false},{"id":1052851777,"node_id":"MDU6TGFiZWwxMDUyODUxNzc3","url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/labels/data%20base","name":"data base","color":"097703","default":false},{"id":997314598,"node_id":"MDU6TGFiZWw5OTczMTQ1OTg=","url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":1062018612,"node_id":"MDU6TGFiZWwxMDYyMDE4NjEy","url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/labels/re-design","name":"re-design","color":"3582a3","default":false}],"milestone":{"url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/milestones/2","html_url":"https://github.com/TinkoffCreditSystems/neptune/milestone/2","labels_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/milestones/2/labels","id":4660391,"node_id":"MDk6TWlsZXN0b25lNDY2MDM5MQ==","number":2,"title":"0.10.x-ALPHA/BETA","description":"","creator":{"login":"TikhomirovSergey","id":4927589,"node_id":"MDQ6VXNlcjQ5Mjc1ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/4927589?v=4","gravatar_id":"","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":5,"state":"open","created_at":"2019-09-15T15:43:27Z","updated_at":"2019-11-01T06:46:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/133/commits","review_comments_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/133/comments","review_comment_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/issues/133/comments","statuses_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/statuses/fd8444da4d82b27343340069e37b91131d4a1924","head":{"label":"TikhomirovSergey:db_connection","ref":"db_connection","sha":"fd8444da4d82b27343340069e37b91131d4a1924","user":{"login":"TikhomirovSergey","id":4927589,"node_id":"MDQ6VXNlcjQ5Mjc1ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/4927589?v=4","gravatar_id":"","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"repo":{"id":189189460,"node_id":"MDEwOlJlcG9zaXRvcnkxODkxODk0NjA=","name":"neptune","full_name":"TikhomirovSergey/neptune","private":false,"owner":{"login":"TikhomirovSergey","id":4927589,"node_id":"MDQ6VXNlcjQ5Mjc1ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/4927589?v=4","gravatar_id":"","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TikhomirovSergey/neptune","description":"Test automation framework","fork":true,"url":"https://api.github.com/repos/TikhomirovSergey/neptune","forks_url":"https://api.github.com/repos/TikhomirovSergey/neptune/forks","keys_url":"https://api.github.com/repos/TikhomirovSergey/neptune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TikhomirovSergey/neptune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TikhomirovSergey/neptune/teams","hooks_url":"https://api.github.com/repos/TikhomirovSergey/neptune/hooks","issue_events_url":"https://api.github.com/repos/TikhomirovSergey/neptune/issues/events{/number}","events_url":"https://api.github.com/repos/TikhomirovSergey/neptune/events","assignees_url":"https://api.github.com/repos/TikhomirovSergey/neptune/assignees{/user}","branches_url":"https://api.github.com/repos/TikhomirovSergey/neptune/branches{/branch}","tags_url":"https://api.github.com/repos/TikhomirovSergey/neptune/tags","blobs_url":"https://api.github.com/repos/TikhomirovSergey/neptune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TikhomirovSergey/neptune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TikhomirovSergey/neptune/git/refs{/sha}","trees_url":"https://api.github.com/repos/TikhomirovSergey/neptune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TikhomirovSergey/neptune/statuses/{sha}","languages_url":"https://api.github.com/repos/TikhomirovSergey/neptune/languages","stargazers_url":"https://api.github.com/repos/TikhomirovSergey/neptune/stargazers","contributors_url":"https://api.github.com/repos/TikhomirovSergey/neptune/contributors","subscribers_url":"https://api.github.com/repos/TikhomirovSergey/neptune/subscribers","subscription_url":"https://api.github.com/repos/TikhomirovSergey/neptune/subscription","commits_url":"https://api.github.com/repos/TikhomirovSergey/neptune/commits{/sha}","git_commits_url":"https://api.github.com/repos/TikhomirovSergey/neptune/git/commits{/sha}","comments_url":"https://api.github.com/repos/TikhomirovSergey/neptune/comments{/number}","issue_comment_url":"https://api.github.com/repos/TikhomirovSergey/neptune/issues/comments{/number}","contents_url":"https://api.github.com/repos/TikhomirovSergey/neptune/contents/{+path}","compare_url":"https://api.github.com/repos/TikhomirovSergey/neptune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TikhomirovSergey/neptune/merges","archive_url":"https://api.github.com/repos/TikhomirovSergey/neptune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TikhomirovSergey/neptune/downloads","issues_url":"https://api.github.com/repos/TikhomirovSergey/neptune/issues{/number}","pulls_url":"https://api.github.com/repos/TikhomirovSergey/neptune/pulls{/number}","milestones_url":"https://api.github.com/repos/TikhomirovSergey/neptune/milestones{/number}","notifications_url":"https://api.github.com/repos/TikhomirovSergey/neptune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TikhomirovSergey/neptune/labels{/name}","releases_url":"https://api.github.com/repos/TikhomirovSergey/neptune/releases{/id}","deployments_url":"https://api.github.com/repos/TikhomirovSergey/neptune/deployments","created_at":"2019-05-29T09:03:30Z","updated_at":"2019-11-02T15:43:07Z","pushed_at":"2019-11-04T16:45:42Z","git_url":"git://github.com/TikhomirovSergey/neptune.git","ssh_url":"git@github.com:TikhomirovSergey/neptune.git","clone_url":"https://github.com/TikhomirovSergey/neptune.git","svn_url":"https://github.com/TikhomirovSergey/neptune","homepage":"","size":7233,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TinkoffCreditSystems:master","ref":"master","sha":"a42b5e597e647ab17972dbf329f20ae1107ce2b1","user":{"login":"TinkoffCreditSystems","id":5486989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0ODY5ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/5486989?v=4","gravatar_id":"","url":"https://api.github.com/users/TinkoffCreditSystems","html_url":"https://github.com/TinkoffCreditSystems","followers_url":"https://api.github.com/users/TinkoffCreditSystems/followers","following_url":"https://api.github.com/users/TinkoffCreditSystems/following{/other_user}","gists_url":"https://api.github.com/users/TinkoffCreditSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/TinkoffCreditSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TinkoffCreditSystems/subscriptions","organizations_url":"https://api.github.com/users/TinkoffCreditSystems/orgs","repos_url":"https://api.github.com/users/TinkoffCreditSystems/repos","events_url":"https://api.github.com/users/TinkoffCreditSystems/events{/privacy}","received_events_url":"https://api.github.com/users/TinkoffCreditSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":141402922,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0MDI5MjI=","name":"neptune","full_name":"TinkoffCreditSystems/neptune","private":false,"owner":{"login":"TinkoffCreditSystems","id":5486989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0ODY5ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/5486989?v=4","gravatar_id":"","url":"https://api.github.com/users/TinkoffCreditSystems","html_url":"https://github.com/TinkoffCreditSystems","followers_url":"https://api.github.com/users/TinkoffCreditSystems/followers","following_url":"https://api.github.com/users/TinkoffCreditSystems/following{/other_user}","gists_url":"https://api.github.com/users/TinkoffCreditSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/TinkoffCreditSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TinkoffCreditSystems/subscriptions","organizations_url":"https://api.github.com/users/TinkoffCreditSystems/orgs","repos_url":"https://api.github.com/users/TinkoffCreditSystems/repos","events_url":"https://api.github.com/users/TinkoffCreditSystems/events{/privacy}","received_events_url":"https://api.github.com/users/TinkoffCreditSystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TinkoffCreditSystems/neptune","description":"Test automation framework","fork":false,"url":"https://api.github.com/repos/TinkoffCreditSystems/neptune","forks_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/forks","keys_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/teams","hooks_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/hooks","issue_events_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/issues/events{/number}","events_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/events","assignees_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/assignees{/user}","branches_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/branches{/branch}","tags_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/tags","blobs_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/git/refs{/sha}","trees_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/statuses/{sha}","languages_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/languages","stargazers_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/stargazers","contributors_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/contributors","subscribers_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/subscribers","subscription_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/subscription","commits_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/commits{/sha}","git_commits_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/git/commits{/sha}","comments_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/comments{/number}","issue_comment_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/issues/comments{/number}","contents_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/contents/{+path}","compare_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/merges","archive_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/downloads","issues_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/issues{/number}","pulls_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls{/number}","milestones_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/milestones{/number}","notifications_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/labels{/name}","releases_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/releases{/id}","deployments_url":"https://api.github.com/repos/TinkoffCreditSystems/neptune/deployments","created_at":"2018-07-18T08:11:43Z","updated_at":"2019-11-01T06:46:39Z","pushed_at":"2019-11-03T12:06:52Z","git_url":"git://github.com/TinkoffCreditSystems/neptune.git","ssh_url":"git@github.com:TinkoffCreditSystems/neptune.git","clone_url":"https://github.com/TinkoffCreditSystems/neptune.git","svn_url":"https://github.com/TinkoffCreditSystems/neptune","homepage":"","size":11276,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":10,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/133"},"html":{"href":"https://github.com/TinkoffCreditSystems/neptune/pull/133"},"issue":{"href":"https://api.github.com/repos/TinkoffCreditSystems/neptune/issues/133"},"comments":{"href":"https://api.github.com/repos/TinkoffCreditSystems/neptune/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TinkoffCreditSystems/neptune/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/TinkoffCreditSystems/neptune/statuses/fd8444da4d82b27343340069e37b91131d4a1924"}},"author_association":"COLLABORATOR"}}
|
{
"id": 141402922,
"name": "TinkoffCreditSystems/neptune",
"url": "https://api.github.com/repos/TinkoffCreditSystems/neptune"
}
|
{
"id": 22876165,
"login": "ArisAgnew",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22876165?",
"url": "https://api.github.com/users/ArisAgnew"
}
|
{
"id": 5486989,
"login": "TinkoffCreditSystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5486989?",
"url": "https://api.github.com/orgs/TinkoffCreditSystems"
}
| 2019-11-05T08:57:50 |
10788038305
|
{"actor":{"display_login":"ArisAgnew"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/comments/339466922","pull_request_review_id":307721013,"id":339466922,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTQ2NjkyMg==","diff_hunk":"@@ -0,0 +1,47 @@\n+/*\n+ * Copyright (c) 2019 Nordic Semiconductor ASA\n+ *\n+ * SPDX-License-Identifier: LicenseRef-BSD-5-Clause-Nordic\n+ */\n+#ifndef __CPU_LOAD_H\n+#define __CPU_LOAD_H\n+\n+#include <zephyr/types.h>\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+/**\n+ * @defgroup cpu_load CPU load\n+ * @brief Module for measuring CPU load.\n+ *\n+ * @{\n+ */\n+\n+/** @brief Initialize CPU load measurement module.\n+ *\n+ * During initialization TIMER driver and PPI channels are allocated.\n+ *\n+ * @return 0 on success, error code otherwise.\n+ */\n+int cpu_load_init(void);\n+\n+/** @brief Reset measurement. */\n+void cpu_load_reset(void);\n+\n+/** @brief Get CPU load.","path":"include/debug/cpu_load.h","position":33,"original_position":33,"commit_id":"8e3532943f6b3f30a6485aa1f3f308fde78a15be","original_commit_id":"8e3532943f6b3f30a6485aa1f3f308fde78a15be","user":{"login":"greg-fer","id":41291385,"node_id":"MDQ6VXNlcjQxMjkxMzg1","avatar_url":"https://avatars3.githubusercontent.com/u/41291385?v=4","gravatar_id":"","url":"https://api.github.com/users/greg-fer","html_url":"https://github.com/greg-fer","followers_url":"https://api.github.com/users/greg-fer/followers","following_url":"https://api.github.com/users/greg-fer/following{/other_user}","gists_url":"https://api.github.com/users/greg-fer/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-fer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-fer/subscriptions","organizations_url":"https://api.github.com/users/greg-fer/orgs","repos_url":"https://api.github.com/users/greg-fer/repos","events_url":"https://api.github.com/users/greg-fer/events{/privacy}","received_events_url":"https://api.github.com/users/greg-fer/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n/** @brief Get the CPU load measurement value.\r\n```","created_at":"2019-10-28T09:32:39Z","updated_at":"2019-10-28T09:34:37Z","html_url":"https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/1272#discussion_r339466922","pull_request_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/1272","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/comments/339466922"},"html":{"href":"https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/1272#discussion_r339466922"},"pull_request":{"href":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/1272"}}},"pull_request":{"url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/1272","id":327058908,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3MDU4OTA4","html_url":"https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/1272","diff_url":"https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/1272.diff","patch_url":"https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/1272.patch","issue_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/issues/1272","number":1272,"state":"open","locked":false,"title":"Add debug module for measuring CPU load","user":{"login":"nordic-krch","id":16899589,"node_id":"MDQ6VXNlcjE2ODk5NTg5","avatar_url":"https://avatars3.githubusercontent.com/u/16899589?v=4","gravatar_id":"","url":"https://api.github.com/users/nordic-krch","html_url":"https://github.com/nordic-krch","followers_url":"https://api.github.com/users/nordic-krch/followers","following_url":"https://api.github.com/users/nordic-krch/following{/other_user}","gists_url":"https://api.github.com/users/nordic-krch/gists{/gist_id}","starred_url":"https://api.github.com/users/nordic-krch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordic-krch/subscriptions","organizations_url":"https://api.github.com/users/nordic-krch/orgs","repos_url":"https://api.github.com/users/nordic-krch/repos","events_url":"https://api.github.com/users/nordic-krch/events{/privacy}","received_events_url":"https://api.github.com/users/nordic-krch/received_events","type":"User","site_admin":false},"body":"Content:\r\n- cpu_load module with API for retrieving CPU load and shell commands\r\n- test\r\n\r\nModule is using one TIMER instance and SLEEPENTER SLEEPEXIT events (2 PPI channels) to accurately measure CPU load.","created_at":"2019-10-11T07:01:48Z","updated_at":"2019-10-28T09:34:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2676822c242741c646a915780cb4273602a18132","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carlescufi","id":12450381,"node_id":"MDQ6VXNlcjEyNDUwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12450381?v=4","gravatar_id":"","url":"https://api.github.com/users/carlescufi","html_url":"https://github.com/carlescufi","followers_url":"https://api.github.com/users/carlescufi/followers","following_url":"https://api.github.com/users/carlescufi/following{/other_user}","gists_url":"https://api.github.com/users/carlescufi/gists{/gist_id}","starred_url":"https://api.github.com/users/carlescufi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlescufi/subscriptions","organizations_url":"https://api.github.com/users/carlescufi/orgs","repos_url":"https://api.github.com/users/carlescufi/repos","events_url":"https://api.github.com/users/carlescufi/events{/privacy}","received_events_url":"https://api.github.com/users/carlescufi/received_events","type":"User","site_admin":false},{"login":"anangl","id":16913290,"node_id":"MDQ6VXNlcjE2OTEzMjkw","avatar_url":"https://avatars3.githubusercontent.com/u/16913290?v=4","gravatar_id":"","url":"https://api.github.com/users/anangl","html_url":"https://github.com/anangl","followers_url":"https://api.github.com/users/anangl/followers","following_url":"https://api.github.com/users/anangl/following{/other_user}","gists_url":"https://api.github.com/users/anangl/gists{/gist_id}","starred_url":"https://api.github.com/users/anangl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anangl/subscriptions","organizations_url":"https://api.github.com/users/anangl/orgs","repos_url":"https://api.github.com/users/anangl/repos","events_url":"https://api.github.com/users/anangl/events{/privacy}","received_events_url":"https://api.github.com/users/anangl/received_events","type":"User","site_admin":false},{"login":"pizi-nordic","id":18549729,"node_id":"MDQ6VXNlcjE4NTQ5NzI5","avatar_url":"https://avatars1.githubusercontent.com/u/18549729?v=4","gravatar_id":"","url":"https://api.github.com/users/pizi-nordic","html_url":"https://github.com/pizi-nordic","followers_url":"https://api.github.com/users/pizi-nordic/followers","following_url":"https://api.github.com/users/pizi-nordic/following{/other_user}","gists_url":"https://api.github.com/users/pizi-nordic/gists{/gist_id}","starred_url":"https://api.github.com/users/pizi-nordic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pizi-nordic/subscriptions","organizations_url":"https://api.github.com/users/pizi-nordic/orgs","repos_url":"https://api.github.com/users/pizi-nordic/repos","events_url":"https://api.github.com/users/pizi-nordic/events{/privacy}","received_events_url":"https://api.github.com/users/pizi-nordic/received_events","type":"User","site_admin":false},{"login":"rlubos","id":22167799,"node_id":"MDQ6VXNlcjIyMTY3Nzk5","avatar_url":"https://avatars0.githubusercontent.com/u/22167799?v=4","gravatar_id":"","url":"https://api.github.com/users/rlubos","html_url":"https://github.com/rlubos","followers_url":"https://api.github.com/users/rlubos/followers","following_url":"https://api.github.com/users/rlubos/following{/other_user}","gists_url":"https://api.github.com/users/rlubos/gists{/gist_id}","starred_url":"https://api.github.com/users/rlubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlubos/subscriptions","organizations_url":"https://api.github.com/users/rlubos/orgs","repos_url":"https://api.github.com/users/rlubos/repos","events_url":"https://api.github.com/users/rlubos/events{/privacy}","received_events_url":"https://api.github.com/users/rlubos/received_events","type":"User","site_admin":false},{"login":"b-gent","id":29537761,"node_id":"MDQ6VXNlcjI5NTM3NzYx","avatar_url":"https://avatars1.githubusercontent.com/u/29537761?v=4","gravatar_id":"","url":"https://api.github.com/users/b-gent","html_url":"https://github.com/b-gent","followers_url":"https://api.github.com/users/b-gent/followers","following_url":"https://api.github.com/users/b-gent/following{/other_user}","gists_url":"https://api.github.com/users/b-gent/gists{/gist_id}","starred_url":"https://api.github.com/users/b-gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-gent/subscriptions","organizations_url":"https://api.github.com/users/b-gent/orgs","repos_url":"https://api.github.com/users/b-gent/repos","events_url":"https://api.github.com/users/b-gent/events{/privacy}","received_events_url":"https://api.github.com/users/b-gent/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/1272/commits","review_comments_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/1272/comments","review_comment_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/issues/1272/comments","statuses_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/statuses/8e3532943f6b3f30a6485aa1f3f308fde78a15be","head":{"label":"nordic-krch:cpu_load","ref":"cpu_load","sha":"8e3532943f6b3f30a6485aa1f3f308fde78a15be","user":{"login":"nordic-krch","id":16899589,"node_id":"MDQ6VXNlcjE2ODk5NTg5","avatar_url":"https://avatars3.githubusercontent.com/u/16899589?v=4","gravatar_id":"","url":"https://api.github.com/users/nordic-krch","html_url":"https://github.com/nordic-krch","followers_url":"https://api.github.com/users/nordic-krch/followers","following_url":"https://api.github.com/users/nordic-krch/following{/other_user}","gists_url":"https://api.github.com/users/nordic-krch/gists{/gist_id}","starred_url":"https://api.github.com/users/nordic-krch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordic-krch/subscriptions","organizations_url":"https://api.github.com/users/nordic-krch/orgs","repos_url":"https://api.github.com/users/nordic-krch/repos","events_url":"https://api.github.com/users/nordic-krch/events{/privacy}","received_events_url":"https://api.github.com/users/nordic-krch/received_events","type":"User","site_admin":false},"repo":{"id":173918311,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM5MTgzMTE=","name":"fw-nrfconnect-nrf","full_name":"nordic-krch/fw-nrfconnect-nrf","private":false,"owner":{"login":"nordic-krch","id":16899589,"node_id":"MDQ6VXNlcjE2ODk5NTg5","avatar_url":"https://avatars3.githubusercontent.com/u/16899589?v=4","gravatar_id":"","url":"https://api.github.com/users/nordic-krch","html_url":"https://github.com/nordic-krch","followers_url":"https://api.github.com/users/nordic-krch/followers","following_url":"https://api.github.com/users/nordic-krch/following{/other_user}","gists_url":"https://api.github.com/users/nordic-krch/gists{/gist_id}","starred_url":"https://api.github.com/users/nordic-krch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordic-krch/subscriptions","organizations_url":"https://api.github.com/users/nordic-krch/orgs","repos_url":"https://api.github.com/users/nordic-krch/repos","events_url":"https://api.github.com/users/nordic-krch/events{/privacy}","received_events_url":"https://api.github.com/users/nordic-krch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nordic-krch/fw-nrfconnect-nrf","description":"nRF Connect SDK nrf tree","fork":true,"url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf","forks_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/forks","keys_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/teams","hooks_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/hooks","issue_events_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/issues/events{/number}","events_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/events","assignees_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/assignees{/user}","branches_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/branches{/branch}","tags_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/tags","blobs_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/git/refs{/sha}","trees_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/statuses/{sha}","languages_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/languages","stargazers_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/stargazers","contributors_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/contributors","subscribers_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/subscribers","subscription_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/subscription","commits_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/commits{/sha}","git_commits_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/git/commits{/sha}","comments_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/comments{/number}","issue_comment_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/issues/comments{/number}","contents_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/contents/{+path}","compare_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/merges","archive_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/downloads","issues_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/issues{/number}","pulls_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/pulls{/number}","milestones_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/milestones{/number}","notifications_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/labels{/name}","releases_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/releases{/id}","deployments_url":"https://api.github.com/repos/nordic-krch/fw-nrfconnect-nrf/deployments","created_at":"2019-03-05T09:42:10Z","updated_at":"2019-03-05T09:42:13Z","pushed_at":"2019-10-23T09:33:14Z","git_url":"git://github.com/nordic-krch/fw-nrfconnect-nrf.git","ssh_url":"git@github.com:nordic-krch/fw-nrfconnect-nrf.git","clone_url":"https://github.com/nordic-krch/fw-nrfconnect-nrf.git","svn_url":"https://github.com/nordic-krch/fw-nrfconnect-nrf","homepage":"http://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/","size":5964,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NordicPlayground:master","ref":"master","sha":"6454e910391c6500a7058dd022caee2859f1a301","user":{"login":"NordicPlayground","id":5527425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1Mjc0MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/5527425?v=4","gravatar_id":"","url":"https://api.github.com/users/NordicPlayground","html_url":"https://github.com/NordicPlayground","followers_url":"https://api.github.com/users/NordicPlayground/followers","following_url":"https://api.github.com/users/NordicPlayground/following{/other_user}","gists_url":"https://api.github.com/users/NordicPlayground/gists{/gist_id}","starred_url":"https://api.github.com/users/NordicPlayground/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NordicPlayground/subscriptions","organizations_url":"https://api.github.com/users/NordicPlayground/orgs","repos_url":"https://api.github.com/users/NordicPlayground/repos","events_url":"https://api.github.com/users/NordicPlayground/events{/privacy}","received_events_url":"https://api.github.com/users/NordicPlayground/received_events","type":"Organization","site_admin":false},"repo":{"id":121516035,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1MTYwMzU=","name":"fw-nrfconnect-nrf","full_name":"NordicPlayground/fw-nrfconnect-nrf","private":false,"owner":{"login":"NordicPlayground","id":5527425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1Mjc0MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/5527425?v=4","gravatar_id":"","url":"https://api.github.com/users/NordicPlayground","html_url":"https://github.com/NordicPlayground","followers_url":"https://api.github.com/users/NordicPlayground/followers","following_url":"https://api.github.com/users/NordicPlayground/following{/other_user}","gists_url":"https://api.github.com/users/NordicPlayground/gists{/gist_id}","starred_url":"https://api.github.com/users/NordicPlayground/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NordicPlayground/subscriptions","organizations_url":"https://api.github.com/users/NordicPlayground/orgs","repos_url":"https://api.github.com/users/NordicPlayground/repos","events_url":"https://api.github.com/users/NordicPlayground/events{/privacy}","received_events_url":"https://api.github.com/users/NordicPlayground/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NordicPlayground/fw-nrfconnect-nrf","description":"nRF Connect SDK nrf tree","fork":false,"url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf","forks_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/forks","keys_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/teams","hooks_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/hooks","issue_events_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/issues/events{/number}","events_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/events","assignees_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/assignees{/user}","branches_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/branches{/branch}","tags_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/tags","blobs_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/git/refs{/sha}","trees_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/statuses/{sha}","languages_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/languages","stargazers_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/stargazers","contributors_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/contributors","subscribers_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/subscribers","subscription_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/subscription","commits_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/commits{/sha}","git_commits_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/git/commits{/sha}","comments_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/comments{/number}","issue_comment_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/issues/comments{/number}","contents_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/contents/{+path}","compare_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/merges","archive_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/downloads","issues_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/issues{/number}","pulls_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls{/number}","milestones_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/milestones{/number}","notifications_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/labels{/name}","releases_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/releases{/id}","deployments_url":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/deployments","created_at":"2018-02-14T13:50:55Z","updated_at":"2019-10-26T15:48:03Z","pushed_at":"2019-10-28T08:31:14Z","git_url":"git://github.com/NordicPlayground/fw-nrfconnect-nrf.git","ssh_url":"git@github.com:NordicPlayground/fw-nrfconnect-nrf.git","clone_url":"https://github.com/NordicPlayground/fw-nrfconnect-nrf.git","svn_url":"https://github.com/NordicPlayground/fw-nrfconnect-nrf","homepage":"http://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/","size":6199,"stargazers_count":82,"watchers_count":82,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":227,"open_issues":45,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/1272"},"html":{"href":"https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/1272"},"issue":{"href":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/issues/1272"},"comments":{"href":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/issues/1272/comments"},"review_comments":{"href":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/1272/comments"},"review_comment":{"href":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/pulls/1272/commits"},"statuses":{"href":"https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf/statuses/8e3532943f6b3f30a6485aa1f3f308fde78a15be"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 121516035,
"name": "NordicPlayground/fw-nrfconnect-nrf",
"url": "https://api.github.com/repos/NordicPlayground/fw-nrfconnect-nrf"
}
|
{
"id": 41291385,
"login": "greg-fer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41291385?",
"url": "https://api.github.com/users/greg-fer"
}
|
{
"id": 5527425,
"login": "NordicPlayground",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5527425?",
"url": "https://api.github.com/orgs/NordicPlayground"
}
| 2019-10-28T09:32:39 |
10726512938
|
{"actor":{"display_login":"greg-fer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/octobercms/docs/pulls/comments/334198044","pull_request_review_id":300958276,"id":334198044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDE5ODA0NA==","diff_hunk":"@@ -83,3 +83,17 @@ Outputs a standard FORM closing tag. This tag is generally available to provide\n The above example would output as the following:\n \n </form>\n+\n+## Passing parameters through the form tag","path":"markup-function-form.md","position":5,"original_position":5,"commit_id":"dcdbffae4a37e16e9bd6b9a0ede2ec89f7adcb27","original_commit_id":"dcdbffae4a37e16e9bd6b9a0ede2ec89f7adcb27","user":{"login":"LukeTowers","id":7253840,"node_id":"MDQ6VXNlcjcyNTM4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7253840?v=4","gravatar_id":"","url":"https://api.github.com/users/LukeTowers","html_url":"https://github.com/LukeTowers","followers_url":"https://api.github.com/users/LukeTowers/followers","following_url":"https://api.github.com/users/LukeTowers/following{/other_user}","gists_url":"https://api.github.com/users/LukeTowers/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeTowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeTowers/subscriptions","organizations_url":"https://api.github.com/users/LukeTowers/orgs","repos_url":"https://api.github.com/users/LukeTowers/repos","events_url":"https://api.github.com/users/LukeTowers/events{/privacy}","received_events_url":"https://api.github.com/users/LukeTowers/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n## Passing attributes to the generated element\r\n```","created_at":"2019-10-11T22:49:13Z","updated_at":"2019-10-11T22:49:13Z","html_url":"https://github.com/octobercms/docs/pull/411#discussion_r334198044","pull_request_url":"https://api.github.com/repos/octobercms/docs/pulls/411","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/octobercms/docs/pulls/comments/334198044"},"html":{"href":"https://github.com/octobercms/docs/pull/411#discussion_r334198044"},"pull_request":{"href":"https://api.github.com/repos/octobercms/docs/pulls/411"}}},"pull_request":{"url":"https://api.github.com/repos/octobercms/docs/pulls/411","id":327301517,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3MzAxNTE3","html_url":"https://github.com/octobercms/docs/pull/411","diff_url":"https://github.com/octobercms/docs/pull/411.diff","patch_url":"https://github.com/octobercms/docs/pull/411.patch","issue_url":"https://api.github.com/repos/octobercms/docs/issues/411","number":411,"state":"open","locked":false,"title":"Add example to show people how to pass parameters through the form tag","user":{"login":"ayumihamasaki2019","id":55155131,"node_id":"MDQ6VXNlcjU1MTU1MTMx","avatar_url":"https://avatars1.githubusercontent.com/u/55155131?v=4","gravatar_id":"","url":"https://api.github.com/users/ayumihamasaki2019","html_url":"https://github.com/ayumihamasaki2019","followers_url":"https://api.github.com/users/ayumihamasaki2019/followers","following_url":"https://api.github.com/users/ayumihamasaki2019/following{/other_user}","gists_url":"https://api.github.com/users/ayumihamasaki2019/gists{/gist_id}","starred_url":"https://api.github.com/users/ayumihamasaki2019/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayumihamasaki2019/subscriptions","organizations_url":"https://api.github.com/users/ayumihamasaki2019/orgs","repos_url":"https://api.github.com/users/ayumihamasaki2019/repos","events_url":"https://api.github.com/users/ayumihamasaki2019/events{/privacy}","received_events_url":"https://api.github.com/users/ayumihamasaki2019/received_events","type":"User","site_admin":false},"body":"Related github issue: https://github.com/octobercms/docs/issues/410\r\n\r\n@LukeTowers Please review you are best with these kind of things.","created_at":"2019-10-11T17:43:33Z","updated_at":"2019-10-11T22:49:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98a4008ffaaef19381aea4c9c8fe7736da415f58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/octobercms/docs/pulls/411/commits","review_comments_url":"https://api.github.com/repos/octobercms/docs/pulls/411/comments","review_comment_url":"https://api.github.com/repos/octobercms/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/octobercms/docs/issues/411/comments","statuses_url":"https://api.github.com/repos/octobercms/docs/statuses/dcdbffae4a37e16e9bd6b9a0ede2ec89f7adcb27","head":{"label":"ayumihamasaki2019:form","ref":"form","sha":"dcdbffae4a37e16e9bd6b9a0ede2ec89f7adcb27","user":{"login":"ayumihamasaki2019","id":55155131,"node_id":"MDQ6VXNlcjU1MTU1MTMx","avatar_url":"https://avatars1.githubusercontent.com/u/55155131?v=4","gravatar_id":"","url":"https://api.github.com/users/ayumihamasaki2019","html_url":"https://github.com/ayumihamasaki2019","followers_url":"https://api.github.com/users/ayumihamasaki2019/followers","following_url":"https://api.github.com/users/ayumihamasaki2019/following{/other_user}","gists_url":"https://api.github.com/users/ayumihamasaki2019/gists{/gist_id}","starred_url":"https://api.github.com/users/ayumihamasaki2019/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayumihamasaki2019/subscriptions","organizations_url":"https://api.github.com/users/ayumihamasaki2019/orgs","repos_url":"https://api.github.com/users/ayumihamasaki2019/repos","events_url":"https://api.github.com/users/ayumihamasaki2019/events{/privacy}","received_events_url":"https://api.github.com/users/ayumihamasaki2019/received_events","type":"User","site_admin":false},"repo":{"id":214493825,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQ0OTM4MjU=","name":"docs","full_name":"ayumihamasaki2019/docs","private":false,"owner":{"login":"ayumihamasaki2019","id":55155131,"node_id":"MDQ6VXNlcjU1MTU1MTMx","avatar_url":"https://avatars1.githubusercontent.com/u/55155131?v=4","gravatar_id":"","url":"https://api.github.com/users/ayumihamasaki2019","html_url":"https://github.com/ayumihamasaki2019","followers_url":"https://api.github.com/users/ayumihamasaki2019/followers","following_url":"https://api.github.com/users/ayumihamasaki2019/following{/other_user}","gists_url":"https://api.github.com/users/ayumihamasaki2019/gists{/gist_id}","starred_url":"https://api.github.com/users/ayumihamasaki2019/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayumihamasaki2019/subscriptions","organizations_url":"https://api.github.com/users/ayumihamasaki2019/orgs","repos_url":"https://api.github.com/users/ayumihamasaki2019/repos","events_url":"https://api.github.com/users/ayumihamasaki2019/events{/privacy}","received_events_url":"https://api.github.com/users/ayumihamasaki2019/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ayumihamasaki2019/docs","description":"The OctoberCMS Documentation","fork":true,"url":"https://api.github.com/repos/ayumihamasaki2019/docs","forks_url":"https://api.github.com/repos/ayumihamasaki2019/docs/forks","keys_url":"https://api.github.com/repos/ayumihamasaki2019/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ayumihamasaki2019/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ayumihamasaki2019/docs/teams","hooks_url":"https://api.github.com/repos/ayumihamasaki2019/docs/hooks","issue_events_url":"https://api.github.com/repos/ayumihamasaki2019/docs/issues/events{/number}","events_url":"https://api.github.com/repos/ayumihamasaki2019/docs/events","assignees_url":"https://api.github.com/repos/ayumihamasaki2019/docs/assignees{/user}","branches_url":"https://api.github.com/repos/ayumihamasaki2019/docs/branches{/branch}","tags_url":"https://api.github.com/repos/ayumihamasaki2019/docs/tags","blobs_url":"https://api.github.com/repos/ayumihamasaki2019/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ayumihamasaki2019/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ayumihamasaki2019/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ayumihamasaki2019/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ayumihamasaki2019/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/ayumihamasaki2019/docs/languages","stargazers_url":"https://api.github.com/repos/ayumihamasaki2019/docs/stargazers","contributors_url":"https://api.github.com/repos/ayumihamasaki2019/docs/contributors","subscribers_url":"https://api.github.com/repos/ayumihamasaki2019/docs/subscribers","subscription_url":"https://api.github.com/repos/ayumihamasaki2019/docs/subscription","commits_url":"https://api.github.com/repos/ayumihamasaki2019/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ayumihamasaki2019/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ayumihamasaki2019/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ayumihamasaki2019/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ayumihamasaki2019/docs/contents/{+path}","compare_url":"https://api.github.com/repos/ayumihamasaki2019/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ayumihamasaki2019/docs/merges","archive_url":"https://api.github.com/repos/ayumihamasaki2019/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ayumihamasaki2019/docs/downloads","issues_url":"https://api.github.com/repos/ayumihamasaki2019/docs/issues{/number}","pulls_url":"https://api.github.com/repos/ayumihamasaki2019/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/ayumihamasaki2019/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/ayumihamasaki2019/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ayumihamasaki2019/docs/labels{/name}","releases_url":"https://api.github.com/repos/ayumihamasaki2019/docs/releases{/id}","deployments_url":"https://api.github.com/repos/ayumihamasaki2019/docs/deployments","created_at":"2019-10-11T17:27:15Z","updated_at":"2019-10-11T17:27:16Z","pushed_at":"2019-10-11T17:42:09Z","git_url":"git://github.com/ayumihamasaki2019/docs.git","ssh_url":"git@github.com:ayumihamasaki2019/docs.git","clone_url":"https://github.com/ayumihamasaki2019/docs.git","svn_url":"https://github.com/ayumihamasaki2019/docs","homepage":"","size":2243,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"octobercms:master","ref":"master","sha":"edc17d97c0936bc2aa3401d68d15387c7ac242b5","user":{"login":"octobercms","id":5554805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTQ4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5554805?v=4","gravatar_id":"","url":"https://api.github.com/users/octobercms","html_url":"https://github.com/octobercms","followers_url":"https://api.github.com/users/octobercms/followers","following_url":"https://api.github.com/users/octobercms/following{/other_user}","gists_url":"https://api.github.com/users/octobercms/gists{/gist_id}","starred_url":"https://api.github.com/users/octobercms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octobercms/subscriptions","organizations_url":"https://api.github.com/users/octobercms/orgs","repos_url":"https://api.github.com/users/octobercms/repos","events_url":"https://api.github.com/users/octobercms/events{/privacy}","received_events_url":"https://api.github.com/users/octobercms/received_events","type":"Organization","site_admin":false},"repo":{"id":15482601,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4MjYwMQ==","name":"docs","full_name":"octobercms/docs","private":false,"owner":{"login":"octobercms","id":5554805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTQ4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5554805?v=4","gravatar_id":"","url":"https://api.github.com/users/octobercms","html_url":"https://github.com/octobercms","followers_url":"https://api.github.com/users/octobercms/followers","following_url":"https://api.github.com/users/octobercms/following{/other_user}","gists_url":"https://api.github.com/users/octobercms/gists{/gist_id}","starred_url":"https://api.github.com/users/octobercms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octobercms/subscriptions","organizations_url":"https://api.github.com/users/octobercms/orgs","repos_url":"https://api.github.com/users/octobercms/repos","events_url":"https://api.github.com/users/octobercms/events{/privacy}","received_events_url":"https://api.github.com/users/octobercms/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/octobercms/docs","description":"The OctoberCMS Documentation","fork":false,"url":"https://api.github.com/repos/octobercms/docs","forks_url":"https://api.github.com/repos/octobercms/docs/forks","keys_url":"https://api.github.com/repos/octobercms/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octobercms/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octobercms/docs/teams","hooks_url":"https://api.github.com/repos/octobercms/docs/hooks","issue_events_url":"https://api.github.com/repos/octobercms/docs/issues/events{/number}","events_url":"https://api.github.com/repos/octobercms/docs/events","assignees_url":"https://api.github.com/repos/octobercms/docs/assignees{/user}","branches_url":"https://api.github.com/repos/octobercms/docs/branches{/branch}","tags_url":"https://api.github.com/repos/octobercms/docs/tags","blobs_url":"https://api.github.com/repos/octobercms/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octobercms/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octobercms/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/octobercms/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octobercms/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/octobercms/docs/languages","stargazers_url":"https://api.github.com/repos/octobercms/docs/stargazers","contributors_url":"https://api.github.com/repos/octobercms/docs/contributors","subscribers_url":"https://api.github.com/repos/octobercms/docs/subscribers","subscription_url":"https://api.github.com/repos/octobercms/docs/subscription","commits_url":"https://api.github.com/repos/octobercms/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/octobercms/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/octobercms/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/octobercms/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/octobercms/docs/contents/{+path}","compare_url":"https://api.github.com/repos/octobercms/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octobercms/docs/merges","archive_url":"https://api.github.com/repos/octobercms/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octobercms/docs/downloads","issues_url":"https://api.github.com/repos/octobercms/docs/issues{/number}","pulls_url":"https://api.github.com/repos/octobercms/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/octobercms/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/octobercms/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octobercms/docs/labels{/name}","releases_url":"https://api.github.com/repos/octobercms/docs/releases{/id}","deployments_url":"https://api.github.com/repos/octobercms/docs/deployments","created_at":"2013-12-27T21:54:18Z","updated_at":"2019-10-10T15:44:02Z","pushed_at":"2019-10-11T17:43:34Z","git_url":"git://github.com/octobercms/docs.git","ssh_url":"git@github.com:octobercms/docs.git","clone_url":"https://github.com/octobercms/docs.git","svn_url":"https://github.com/octobercms/docs","homepage":"","size":2243,"stargazers_count":128,"watchers_count":128,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":null,"forks":204,"open_issues":26,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/octobercms/docs/pulls/411"},"html":{"href":"https://github.com/octobercms/docs/pull/411"},"issue":{"href":"https://api.github.com/repos/octobercms/docs/issues/411"},"comments":{"href":"https://api.github.com/repos/octobercms/docs/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/octobercms/docs/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/octobercms/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/octobercms/docs/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/octobercms/docs/statuses/dcdbffae4a37e16e9bd6b9a0ede2ec89f7adcb27"}},"author_association":"NONE"}}
|
{
"id": 15482601,
"name": "octobercms/docs",
"url": "https://api.github.com/repos/octobercms/docs"
}
|
{
"id": 7253840,
"login": "LukeTowers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7253840?",
"url": "https://api.github.com/users/LukeTowers"
}
|
{
"id": 5554805,
"login": "octobercms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5554805?",
"url": "https://api.github.com/orgs/octobercms"
}
| 2019-10-11T22:49:13 |
10614685903
|
{"actor":{"display_login":"LukeTowers"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments/272107298","pull_request_review_id":222656438,"id":272107298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MjEwNzI5OA==","diff_hunk":"@@ -157,8 +158,12 @@ def compile_coordinate_element(ufl_coordinate_element, contains_eps, parameters=\n \"convergence_epsilon\": 1e-12,\n \"dX_norm_square\": dX_norm_square(cell.topological_dimension()),\n \"X_isub_dX\": X_isub_dX(cell.topological_dimension()),\n- \"extruded_arg\": \", %s nlayers\" % as_cstr(IntType) if extruded else \"\",\n- \"nlayers\": \", f->n_layers\" if extruded else \"\",\n+ \"extruded_arg\": \", int const *__restrict__ layers\" if extruded else \"\",\n+ # \"layer_arg\": \", int layer\" if extruded else \"\",\n+ # \"layers_init\":\"int layers[2] = [layer, layer+1]\" if extruded else \"\",\n+ \"extr_comment_out\": \"//\" if extruded else \"\",\n+ \"non_extr_comment_out\": \"//\" if not extruded else \"\",\n+ # \"layers\": \", layers\" if extruded else \"\",","path":"firedrake/pointquery_utils.py","position":60,"original_position":60,"commit_id":"ba7d54e99b6f271928bb02fa55b6a5fadf268e9c","original_commit_id":"ba7d54e99b6f271928bb02fa55b6a5fadf268e9c","user":{"login":"wence-","id":1126981,"node_id":"MDQ6VXNlcjExMjY5ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/1126981?v=4","gravatar_id":"","url":"https://api.github.com/users/wence-","html_url":"https://github.com/wence-","followers_url":"https://api.github.com/users/wence-/followers","following_url":"https://api.github.com/users/wence-/following{/other_user}","gists_url":"https://api.github.com/users/wence-/gists{/gist_id}","starred_url":"https://api.github.com/users/wence-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wence-/subscriptions","organizations_url":"https://api.github.com/users/wence-/orgs","repos_url":"https://api.github.com/users/wence-/repos","events_url":"https://api.github.com/users/wence-/events{/privacy}","received_events_url":"https://api.github.com/users/wence-/received_events","type":"User","site_admin":false},"body":"More commented code.","created_at":"2019-04-04T10:03:45Z","updated_at":"2019-04-04T10:14:22Z","html_url":"https://github.com/firedrakeproject/firedrake/pull/1408#discussion_r272107298","pull_request_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/1408","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments/272107298"},"html":{"href":"https://github.com/firedrakeproject/firedrake/pull/1408#discussion_r272107298"},"pull_request":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/1408"}}},"pull_request":{"url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/1408","id":267359362,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3MzU5MzYy","html_url":"https://github.com/firedrakeproject/firedrake/pull/1408","diff_url":"https://github.com/firedrakeproject/firedrake/pull/1408.diff","patch_url":"https://github.com/firedrakeproject/firedrake/pull/1408.patch","issue_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/1408","number":1408,"state":"open","locked":false,"title":"loopy codegen","user":{"login":"wence-","id":1126981,"node_id":"MDQ6VXNlcjExMjY5ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/1126981?v=4","gravatar_id":"","url":"https://api.github.com/users/wence-","html_url":"https://github.com/wence-","followers_url":"https://api.github.com/users/wence-/followers","following_url":"https://api.github.com/users/wence-/following{/other_user}","gists_url":"https://api.github.com/users/wence-/gists{/gist_id}","starred_url":"https://api.github.com/users/wence-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wence-/subscriptions","organizations_url":"https://api.github.com/users/wence-/orgs","repos_url":"https://api.github.com/users/wence-/repos","events_url":"https://api.github.com/users/wence-/events{/privacy}","received_events_url":"https://api.github.com/users/wence-/received_events","type":"User","site_admin":false},"body":"The firedrake side of the migration to loopy code generation. Again, I have squashed things so we have a chance of stuff being bisectable. Supersedes #1186.","created_at":"2019-04-04T09:14:15Z","updated_at":"2019-04-04T10:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27bc6a5f0956289f6fe91132dd771f5eceb4a732","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/1408/commits","review_comments_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/1408/comments","review_comment_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/1408/comments","statuses_url":"https://api.github.com/repos/firedrakeproject/firedrake/statuses/ba7d54e99b6f271928bb02fa55b6a5fadf268e9c","head":{"label":"firedrakeproject:tj/loopy-codegen","ref":"tj/loopy-codegen","sha":"ba7d54e99b6f271928bb02fa55b6a5fadf268e9c","user":{"login":"firedrakeproject","id":5558005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTgwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":13384052,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM4NDA1Mg==","name":"firedrake","full_name":"firedrakeproject/firedrake","private":false,"owner":{"login":"firedrakeproject","id":5558005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTgwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firedrakeproject/firedrake","description":"Firedrake is an automated system for the portable solution of partial differential equations using the finite element method (FEM)","fork":false,"url":"https://api.github.com/repos/firedrakeproject/firedrake","forks_url":"https://api.github.com/repos/firedrakeproject/firedrake/forks","keys_url":"https://api.github.com/repos/firedrakeproject/firedrake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firedrakeproject/firedrake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firedrakeproject/firedrake/teams","hooks_url":"https://api.github.com/repos/firedrakeproject/firedrake/hooks","issue_events_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/events{/number}","events_url":"https://api.github.com/repos/firedrakeproject/firedrake/events","assignees_url":"https://api.github.com/repos/firedrakeproject/firedrake/assignees{/user}","branches_url":"https://api.github.com/repos/firedrakeproject/firedrake/branches{/branch}","tags_url":"https://api.github.com/repos/firedrakeproject/firedrake/tags","blobs_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/refs{/sha}","trees_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firedrakeproject/firedrake/statuses/{sha}","languages_url":"https://api.github.com/repos/firedrakeproject/firedrake/languages","stargazers_url":"https://api.github.com/repos/firedrakeproject/firedrake/stargazers","contributors_url":"https://api.github.com/repos/firedrakeproject/firedrake/contributors","subscribers_url":"https://api.github.com/repos/firedrakeproject/firedrake/subscribers","subscription_url":"https://api.github.com/repos/firedrakeproject/firedrake/subscription","commits_url":"https://api.github.com/repos/firedrakeproject/firedrake/commits{/sha}","git_commits_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/commits{/sha}","comments_url":"https://api.github.com/repos/firedrakeproject/firedrake/comments{/number}","issue_comment_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/comments{/number}","contents_url":"https://api.github.com/repos/firedrakeproject/firedrake/contents/{+path}","compare_url":"https://api.github.com/repos/firedrakeproject/firedrake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firedrakeproject/firedrake/merges","archive_url":"https://api.github.com/repos/firedrakeproject/firedrake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firedrakeproject/firedrake/downloads","issues_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues{/number}","pulls_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls{/number}","milestones_url":"https://api.github.com/repos/firedrakeproject/firedrake/milestones{/number}","notifications_url":"https://api.github.com/repos/firedrakeproject/firedrake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firedrakeproject/firedrake/labels{/name}","releases_url":"https://api.github.com/repos/firedrakeproject/firedrake/releases{/id}","deployments_url":"https://api.github.com/repos/firedrakeproject/firedrake/deployments","created_at":"2013-10-07T13:07:44Z","updated_at":"2019-04-04T09:39:40Z","pushed_at":"2019-04-04T09:39:47Z","git_url":"git://github.com/firedrakeproject/firedrake.git","ssh_url":"git@github.com:firedrakeproject/firedrake.git","clone_url":"https://github.com/firedrakeproject/firedrake.git","svn_url":"https://github.com/firedrakeproject/firedrake","homepage":"https://www.firedrakeproject.org","size":25693,"stargazers_count":138,"watchers_count":138,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":55,"open_issues":97,"watchers":138,"default_branch":"master"}},"base":{"label":"firedrakeproject:master","ref":"master","sha":"4e26ee45758f9ea83718b9f25fc892e1397608a6","user":{"login":"firedrakeproject","id":5558005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTgwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":13384052,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM4NDA1Mg==","name":"firedrake","full_name":"firedrakeproject/firedrake","private":false,"owner":{"login":"firedrakeproject","id":5558005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTgwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firedrakeproject/firedrake","description":"Firedrake is an automated system for the portable solution of partial differential equations using the finite element method (FEM)","fork":false,"url":"https://api.github.com/repos/firedrakeproject/firedrake","forks_url":"https://api.github.com/repos/firedrakeproject/firedrake/forks","keys_url":"https://api.github.com/repos/firedrakeproject/firedrake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firedrakeproject/firedrake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firedrakeproject/firedrake/teams","hooks_url":"https://api.github.com/repos/firedrakeproject/firedrake/hooks","issue_events_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/events{/number}","events_url":"https://api.github.com/repos/firedrakeproject/firedrake/events","assignees_url":"https://api.github.com/repos/firedrakeproject/firedrake/assignees{/user}","branches_url":"https://api.github.com/repos/firedrakeproject/firedrake/branches{/branch}","tags_url":"https://api.github.com/repos/firedrakeproject/firedrake/tags","blobs_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/refs{/sha}","trees_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firedrakeproject/firedrake/statuses/{sha}","languages_url":"https://api.github.com/repos/firedrakeproject/firedrake/languages","stargazers_url":"https://api.github.com/repos/firedrakeproject/firedrake/stargazers","contributors_url":"https://api.github.com/repos/firedrakeproject/firedrake/contributors","subscribers_url":"https://api.github.com/repos/firedrakeproject/firedrake/subscribers","subscription_url":"https://api.github.com/repos/firedrakeproject/firedrake/subscription","commits_url":"https://api.github.com/repos/firedrakeproject/firedrake/commits{/sha}","git_commits_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/commits{/sha}","comments_url":"https://api.github.com/repos/firedrakeproject/firedrake/comments{/number}","issue_comment_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/comments{/number}","contents_url":"https://api.github.com/repos/firedrakeproject/firedrake/contents/{+path}","compare_url":"https://api.github.com/repos/firedrakeproject/firedrake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firedrakeproject/firedrake/merges","archive_url":"https://api.github.com/repos/firedrakeproject/firedrake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firedrakeproject/firedrake/downloads","issues_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues{/number}","pulls_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls{/number}","milestones_url":"https://api.github.com/repos/firedrakeproject/firedrake/milestones{/number}","notifications_url":"https://api.github.com/repos/firedrakeproject/firedrake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firedrakeproject/firedrake/labels{/name}","releases_url":"https://api.github.com/repos/firedrakeproject/firedrake/releases{/id}","deployments_url":"https://api.github.com/repos/firedrakeproject/firedrake/deployments","created_at":"2013-10-07T13:07:44Z","updated_at":"2019-04-04T09:39:40Z","pushed_at":"2019-04-04T09:39:47Z","git_url":"git://github.com/firedrakeproject/firedrake.git","ssh_url":"git@github.com:firedrakeproject/firedrake.git","clone_url":"https://github.com/firedrakeproject/firedrake.git","svn_url":"https://github.com/firedrakeproject/firedrake","homepage":"https://www.firedrakeproject.org","size":25693,"stargazers_count":138,"watchers_count":138,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":55,"open_issues":97,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/1408"},"html":{"href":"https://github.com/firedrakeproject/firedrake/pull/1408"},"issue":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/issues/1408"},"comments":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/issues/1408/comments"},"review_comments":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/1408/comments"},"review_comment":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/1408/commits"},"statuses":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/statuses/ba7d54e99b6f271928bb02fa55b6a5fadf268e9c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 13384052,
"name": "firedrakeproject/firedrake",
"url": "https://api.github.com/repos/firedrakeproject/firedrake"
}
|
{
"id": 1126981,
"login": "wence-",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1126981?",
"url": "https://api.github.com/users/wence-"
}
|
{
"id": 5558005,
"login": "firedrakeproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5558005?",
"url": "https://api.github.com/orgs/firedrakeproject"
}
| 2019-04-04T10:03:45 |
9377406430
|
{"actor":{"display_login":"wence-"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/comments/322656702","pull_request_review_id":286039513,"id":322656702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjY1NjcwMg==","diff_hunk":"@@ -1,27 +1,5 @@\n ---\n-- name: remove old installed version\n+- name: Install VirtualBox\n apt:\n- name: \"{{ item }}\"\n- state: absent\n- with_items:\n- - virtualbox\n-\n-- name: Configure the Oracle APT key\n- apt_key:\n- url: https://www.virtualbox.org/download/oracle_vbox_2016.asc","path":"roles/virtualbox/tasks/main.yml","position":12,"original_position":12,"commit_id":"06ba187ed3415ca78479eeabaf25db1b4f9ad7be","original_commit_id":"06ba187ed3415ca78479eeabaf25db1b4f9ad7be","user":{"login":"inss-mark","id":48918680,"node_id":"MDQ6VXNlcjQ4OTE4Njgw","avatar_url":"https://avatars1.githubusercontent.com/u/48918680?v=4","gravatar_id":"","url":"https://api.github.com/users/inss-mark","html_url":"https://github.com/inss-mark","followers_url":"https://api.github.com/users/inss-mark/followers","following_url":"https://api.github.com/users/inss-mark/following{/other_user}","gists_url":"https://api.github.com/users/inss-mark/gists{/gist_id}","starred_url":"https://api.github.com/users/inss-mark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inss-mark/subscriptions","organizations_url":"https://api.github.com/users/inss-mark/orgs","repos_url":"https://api.github.com/users/inss-mark/repos","events_url":"https://api.github.com/users/inss-mark/events{/privacy}","received_events_url":"https://api.github.com/users/inss-mark/received_events","type":"User","site_admin":false},"body":"Full details are in the commit message body.","created_at":"2019-09-10T10:03:05Z","updated_at":"2019-09-10T10:03:05Z","html_url":"https://github.com/InsolvencyService/LaptopToolKit/pull/20#discussion_r322656702","pull_request_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/20","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/comments/322656702"},"html":{"href":"https://github.com/InsolvencyService/LaptopToolKit/pull/20#discussion_r322656702"},"pull_request":{"href":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/20"}},"in_reply_to_id":322643311},"pull_request":{"url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/20","id":315900128,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1OTAwMTI4","html_url":"https://github.com/InsolvencyService/LaptopToolKit/pull/20","diff_url":"https://github.com/InsolvencyService/LaptopToolKit/pull/20.diff","patch_url":"https://github.com/InsolvencyService/LaptopToolKit/pull/20.patch","issue_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues/20","number":20,"state":"open","locked":false,"title":"Feature/virtualboxfixsb","user":{"login":"inss-mark","id":48918680,"node_id":"MDQ6VXNlcjQ4OTE4Njgw","avatar_url":"https://avatars1.githubusercontent.com/u/48918680?v=4","gravatar_id":"","url":"https://api.github.com/users/inss-mark","html_url":"https://github.com/inss-mark","followers_url":"https://api.github.com/users/inss-mark/followers","following_url":"https://api.github.com/users/inss-mark/following{/other_user}","gists_url":"https://api.github.com/users/inss-mark/gists{/gist_id}","starred_url":"https://api.github.com/users/inss-mark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inss-mark/subscriptions","organizations_url":"https://api.github.com/users/inss-mark/orgs","repos_url":"https://api.github.com/users/inss-mark/repos","events_url":"https://api.github.com/users/inss-mark/events{/privacy}","received_events_url":"https://api.github.com/users/inss-mark/received_events","type":"User","site_admin":false},"body":"Revert to upsteam ubuntu packaged virtualbox to avoid issues with secureboot","created_at":"2019-09-10T09:29:08Z","updated_at":"2019-09-10T10:03:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ee017982c80dfe9b2cada7710ae8f9ac9192f09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/20/commits","review_comments_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/20/comments","review_comment_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues/20/comments","statuses_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/statuses/06ba187ed3415ca78479eeabaf25db1b4f9ad7be","head":{"label":"InsolvencyService:feature/virtualboxfixsb","ref":"feature/virtualboxfixsb","sha":"06ba187ed3415ca78479eeabaf25db1b4f9ad7be","user":{"login":"InsolvencyService","id":5759639,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTk2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5759639?v=4","gravatar_id":"","url":"https://api.github.com/users/InsolvencyService","html_url":"https://github.com/InsolvencyService","followers_url":"https://api.github.com/users/InsolvencyService/followers","following_url":"https://api.github.com/users/InsolvencyService/following{/other_user}","gists_url":"https://api.github.com/users/InsolvencyService/gists{/gist_id}","starred_url":"https://api.github.com/users/InsolvencyService/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InsolvencyService/subscriptions","organizations_url":"https://api.github.com/users/InsolvencyService/orgs","repos_url":"https://api.github.com/users/InsolvencyService/repos","events_url":"https://api.github.com/users/InsolvencyService/events{/privacy}","received_events_url":"https://api.github.com/users/InsolvencyService/received_events","type":"Organization","site_admin":false},"repo":{"id":78105305,"node_id":"MDEwOlJlcG9zaXRvcnk3ODEwNTMwNQ==","name":"LaptopToolKit","full_name":"InsolvencyService/LaptopToolKit","private":false,"owner":{"login":"InsolvencyService","id":5759639,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTk2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5759639?v=4","gravatar_id":"","url":"https://api.github.com/users/InsolvencyService","html_url":"https://github.com/InsolvencyService","followers_url":"https://api.github.com/users/InsolvencyService/followers","following_url":"https://api.github.com/users/InsolvencyService/following{/other_user}","gists_url":"https://api.github.com/users/InsolvencyService/gists{/gist_id}","starred_url":"https://api.github.com/users/InsolvencyService/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InsolvencyService/subscriptions","organizations_url":"https://api.github.com/users/InsolvencyService/orgs","repos_url":"https://api.github.com/users/InsolvencyService/repos","events_url":"https://api.github.com/users/InsolvencyService/events{/privacy}","received_events_url":"https://api.github.com/users/InsolvencyService/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/InsolvencyService/LaptopToolKit","description":"Install basic software onto a fresh ubuntu install","fork":false,"url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit","forks_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/forks","keys_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/teams","hooks_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/hooks","issue_events_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues/events{/number}","events_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/events","assignees_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/assignees{/user}","branches_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/branches{/branch}","tags_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/tags","blobs_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/statuses/{sha}","languages_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/languages","stargazers_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/stargazers","contributors_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/contributors","subscribers_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/subscribers","subscription_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/subscription","commits_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/contents/{+path}","compare_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/merges","archive_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/downloads","issues_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues{/number}","pulls_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls{/number}","milestones_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/milestones{/number}","notifications_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/labels{/name}","releases_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/releases{/id}","deployments_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/deployments","created_at":"2017-01-05T10:55:07Z","updated_at":"2017-07-21T12:10:08Z","pushed_at":"2019-09-10T09:29:08Z","git_url":"git://github.com/InsolvencyService/LaptopToolKit.git","ssh_url":"git@github.com:InsolvencyService/LaptopToolKit.git","clone_url":"https://github.com/InsolvencyService/LaptopToolKit.git","svn_url":"https://github.com/InsolvencyService/LaptopToolKit","homepage":null,"size":49,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"InsolvencyService:master","ref":"master","sha":"c8504a59819bbcba6f863baae467bccef6517d27","user":{"login":"InsolvencyService","id":5759639,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTk2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5759639?v=4","gravatar_id":"","url":"https://api.github.com/users/InsolvencyService","html_url":"https://github.com/InsolvencyService","followers_url":"https://api.github.com/users/InsolvencyService/followers","following_url":"https://api.github.com/users/InsolvencyService/following{/other_user}","gists_url":"https://api.github.com/users/InsolvencyService/gists{/gist_id}","starred_url":"https://api.github.com/users/InsolvencyService/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InsolvencyService/subscriptions","organizations_url":"https://api.github.com/users/InsolvencyService/orgs","repos_url":"https://api.github.com/users/InsolvencyService/repos","events_url":"https://api.github.com/users/InsolvencyService/events{/privacy}","received_events_url":"https://api.github.com/users/InsolvencyService/received_events","type":"Organization","site_admin":false},"repo":{"id":78105305,"node_id":"MDEwOlJlcG9zaXRvcnk3ODEwNTMwNQ==","name":"LaptopToolKit","full_name":"InsolvencyService/LaptopToolKit","private":false,"owner":{"login":"InsolvencyService","id":5759639,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTk2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5759639?v=4","gravatar_id":"","url":"https://api.github.com/users/InsolvencyService","html_url":"https://github.com/InsolvencyService","followers_url":"https://api.github.com/users/InsolvencyService/followers","following_url":"https://api.github.com/users/InsolvencyService/following{/other_user}","gists_url":"https://api.github.com/users/InsolvencyService/gists{/gist_id}","starred_url":"https://api.github.com/users/InsolvencyService/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InsolvencyService/subscriptions","organizations_url":"https://api.github.com/users/InsolvencyService/orgs","repos_url":"https://api.github.com/users/InsolvencyService/repos","events_url":"https://api.github.com/users/InsolvencyService/events{/privacy}","received_events_url":"https://api.github.com/users/InsolvencyService/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/InsolvencyService/LaptopToolKit","description":"Install basic software onto a fresh ubuntu install","fork":false,"url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit","forks_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/forks","keys_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/teams","hooks_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/hooks","issue_events_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues/events{/number}","events_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/events","assignees_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/assignees{/user}","branches_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/branches{/branch}","tags_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/tags","blobs_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/statuses/{sha}","languages_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/languages","stargazers_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/stargazers","contributors_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/contributors","subscribers_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/subscribers","subscription_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/subscription","commits_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/contents/{+path}","compare_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/merges","archive_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/downloads","issues_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues{/number}","pulls_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls{/number}","milestones_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/milestones{/number}","notifications_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/labels{/name}","releases_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/releases{/id}","deployments_url":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/deployments","created_at":"2017-01-05T10:55:07Z","updated_at":"2017-07-21T12:10:08Z","pushed_at":"2019-09-10T09:29:08Z","git_url":"git://github.com/InsolvencyService/LaptopToolKit.git","ssh_url":"git@github.com:InsolvencyService/LaptopToolKit.git","clone_url":"https://github.com/InsolvencyService/LaptopToolKit.git","svn_url":"https://github.com/InsolvencyService/LaptopToolKit","homepage":null,"size":49,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/20"},"html":{"href":"https://github.com/InsolvencyService/LaptopToolKit/pull/20"},"issue":{"href":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues/20"},"comments":{"href":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/InsolvencyService/LaptopToolKit/statuses/06ba187ed3415ca78479eeabaf25db1b4f9ad7be"}},"author_association":"NONE"}}
|
{
"id": 78105305,
"name": "InsolvencyService/LaptopToolKit",
"url": "https://api.github.com/repos/InsolvencyService/LaptopToolKit"
}
|
{
"id": 48918680,
"login": "inss-mark",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48918680?",
"url": "https://api.github.com/users/inss-mark"
}
|
{
"id": 5759639,
"login": "InsolvencyService",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5759639?",
"url": "https://api.github.com/orgs/InsolvencyService"
}
| 2019-09-10T10:03:05 |
10383626158
|
{"actor":{"display_login":"inss-mark"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/comments/302408504","pull_request_review_id":260525135,"id":302408504,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjQwODUwNA==","diff_hunk":"@@ -1,26 +1,39 @@\n # VirtoCommerce Samples\n+\n This repository is the official storage for VirtoCommerce samples source code. Each folder represents an individual sample.\n \n-# Current samples\n-* CustomerReviews - an example of a custom module with best coding practices, recommended code structure and styleguides applied. Includes DAL, web API and custom Platform web UI. \n-* IntegrationOrders - sample <a href=\"https://azure.microsoft.com/en-us/services/logic-apps/\" target=\"_blank\">Microsoft Logic Apps</a> application to show how to integrate VirtoCommerce platform with external services and how to handle Logic Apps exeptions\n-* ManagedModule - source code for \"Sample Managed Module\" in <a href=\"https://virtocommerce.com/docs/vc2devguide/working-with-platform-manager/extending-functionality/creating-new-module\" target=\"_blank\">Creating new module</a> tutorial\n+## Current samples\n+\n+* CustomerReviews - an example of a custom module with best coding practices, recommended code structure and styleguides applied. Includes DAL, web API and custom Platform web UI \n+\n+* IntegrationOrders - sample [Microsoft Logic Apps](https://azure.microsoft.com/en-us/services/logic-apps/) application to show how to integrate VirtoCommerce platform with external services and how to handle Logic Apps exeptions\n+\n+* ManagedModule - source code for \"Sample Managed Module\" in [Creating new module](https://virtocommerce.com/docs/vc2devguide/working-with-platform-manager/extending-functionality/creating-new-module) tutorial\n \n-* MemberExtensionSampleModule - source code for <a href=\"https://virtocommerce.com/docs/vc2devguide/extending-commerce/extending-members-domain-types\" target=\"_blank\">Extending Members domain types</a> tutorial\n+* MemberExtensionSampleModule - source code for [Extending Members domain types](https://virtocommerce.com/docs/vc2devguide/extending-commerce/extending-members-domain-types) tutorial\n \n-* OrderModule2 - sample project demonstrated how to extend API, UI and Domain types in <a href=\"https://github.com/VirtoCommerce/vc-module-order\" target=\"_blank\">Order module</a>\n+* OrderModule2 - sample project demonstrated how to extend API, UI and Domain types in [Order module](https://github.com/VirtoCommerce/vc-module-order)\n \n-* ProgressiveWebAppPrototype - sample PWA application to show Service Worker and IndexedDB API features as well as offline mode.\n+* ProgressiveWebAppPrototype - sample PWA application to show Service Worker and IndexedDB API features as well as offline mode\n+\n+* UnmanagedModule - source code for \"Sample Unmanaged Module\" in [Creating new module](https://virtocommerce.com/docs/vc2devguide/working-with-platform-manager/extending-functionality/creating-new-module) tutorial","path":"README.md","position":26,"original_position":26,"commit_id":"ee111261fd3295dfb6b1997de47abdcae60bad40","original_commit_id":"ee111261fd3295dfb6b1997de47abdcae60bad40","user":{"login":"eMazeika","id":5801549,"node_id":"MDQ6VXNlcjU4MDE1NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/5801549?v=4","gravatar_id":"","url":"https://api.github.com/users/eMazeika","html_url":"https://github.com/eMazeika","followers_url":"https://api.github.com/users/eMazeika/followers","following_url":"https://api.github.com/users/eMazeika/following{/other_user}","gists_url":"https://api.github.com/users/eMazeika/gists{/gist_id}","starred_url":"https://api.github.com/users/eMazeika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eMazeika/subscriptions","organizations_url":"https://api.github.com/users/eMazeika/orgs","repos_url":"https://api.github.com/users/eMazeika/repos","events_url":"https://api.github.com/users/eMazeika/events{/privacy}","received_events_url":"https://api.github.com/users/eMazeika/received_events","type":"User","site_admin":false},"body":"1 sentence description is enough here. Move all other to subfolder readme","created_at":"2019-07-11T07:55:48Z","updated_at":"2019-07-11T07:55:48Z","html_url":"https://github.com/VirtoCommerce/vc-samples/pull/16#discussion_r302408504","pull_request_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/16","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/comments/302408504"},"html":{"href":"https://github.com/VirtoCommerce/vc-samples/pull/16#discussion_r302408504"},"pull_request":{"href":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/16","id":296033861,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MDMzODYx","html_url":"https://github.com/VirtoCommerce/vc-samples/pull/16","diff_url":"https://github.com/VirtoCommerce/vc-samples/pull/16.diff","patch_url":"https://github.com/VirtoCommerce/vc-samples/pull/16.patch","issue_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/issues/16","number":16,"state":"open","locked":false,"title":"VC SAP LA example added","user":{"login":"mvktsk","id":44946644,"node_id":"MDQ6VXNlcjQ0OTQ2NjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/44946644?v=4","gravatar_id":"","url":"https://api.github.com/users/mvktsk","html_url":"https://github.com/mvktsk","followers_url":"https://api.github.com/users/mvktsk/followers","following_url":"https://api.github.com/users/mvktsk/following{/other_user}","gists_url":"https://api.github.com/users/mvktsk/gists{/gist_id}","starred_url":"https://api.github.com/users/mvktsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvktsk/subscriptions","organizations_url":"https://api.github.com/users/mvktsk/orgs","repos_url":"https://api.github.com/users/mvktsk/repos","events_url":"https://api.github.com/users/mvktsk/events{/privacy}","received_events_url":"https://api.github.com/users/mvktsk/received_events","type":"User","site_admin":false},"body":"LogicApps VC vs SAP integration example added.\r\nNew LogicApps short description to readme.md added.\r\nIn readme.md external links styled as md links.\r\n","created_at":"2019-07-10T06:55:21Z","updated_at":"2019-07-11T07:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"409816f2cdcb38fb6f75b61b449e31b0aaed893c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"OlegoO","id":7639413,"node_id":"MDQ6VXNlcjc2Mzk0MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7639413?v=4","gravatar_id":"","url":"https://api.github.com/users/OlegoO","html_url":"https://github.com/OlegoO","followers_url":"https://api.github.com/users/OlegoO/followers","following_url":"https://api.github.com/users/OlegoO/following{/other_user}","gists_url":"https://api.github.com/users/OlegoO/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegoO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegoO/subscriptions","organizations_url":"https://api.github.com/users/OlegoO/orgs","repos_url":"https://api.github.com/users/OlegoO/repos","events_url":"https://api.github.com/users/OlegoO/events{/privacy}","received_events_url":"https://api.github.com/users/OlegoO/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/16/commits","review_comments_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/16/comments","review_comment_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/issues/16/comments","statuses_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/statuses/ee111261fd3295dfb6b1997de47abdcae60bad40","head":{"label":"mvktsk:master","ref":"master","sha":"ee111261fd3295dfb6b1997de47abdcae60bad40","user":{"login":"mvktsk","id":44946644,"node_id":"MDQ6VXNlcjQ0OTQ2NjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/44946644?v=4","gravatar_id":"","url":"https://api.github.com/users/mvktsk","html_url":"https://github.com/mvktsk","followers_url":"https://api.github.com/users/mvktsk/followers","following_url":"https://api.github.com/users/mvktsk/following{/other_user}","gists_url":"https://api.github.com/users/mvktsk/gists{/gist_id}","starred_url":"https://api.github.com/users/mvktsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvktsk/subscriptions","organizations_url":"https://api.github.com/users/mvktsk/orgs","repos_url":"https://api.github.com/users/mvktsk/repos","events_url":"https://api.github.com/users/mvktsk/events{/privacy}","received_events_url":"https://api.github.com/users/mvktsk/received_events","type":"User","site_admin":false},"repo":{"id":196145130,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYxNDUxMzA=","name":"vc-samples","full_name":"mvktsk/vc-samples","private":false,"owner":{"login":"mvktsk","id":44946644,"node_id":"MDQ6VXNlcjQ0OTQ2NjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/44946644?v=4","gravatar_id":"","url":"https://api.github.com/users/mvktsk","html_url":"https://github.com/mvktsk","followers_url":"https://api.github.com/users/mvktsk/followers","following_url":"https://api.github.com/users/mvktsk/following{/other_user}","gists_url":"https://api.github.com/users/mvktsk/gists{/gist_id}","starred_url":"https://api.github.com/users/mvktsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvktsk/subscriptions","organizations_url":"https://api.github.com/users/mvktsk/orgs","repos_url":"https://api.github.com/users/mvktsk/repos","events_url":"https://api.github.com/users/mvktsk/events{/privacy}","received_events_url":"https://api.github.com/users/mvktsk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mvktsk/vc-samples","description":"VirtoCommerce samples","fork":true,"url":"https://api.github.com/repos/mvktsk/vc-samples","forks_url":"https://api.github.com/repos/mvktsk/vc-samples/forks","keys_url":"https://api.github.com/repos/mvktsk/vc-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvktsk/vc-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvktsk/vc-samples/teams","hooks_url":"https://api.github.com/repos/mvktsk/vc-samples/hooks","issue_events_url":"https://api.github.com/repos/mvktsk/vc-samples/issues/events{/number}","events_url":"https://api.github.com/repos/mvktsk/vc-samples/events","assignees_url":"https://api.github.com/repos/mvktsk/vc-samples/assignees{/user}","branches_url":"https://api.github.com/repos/mvktsk/vc-samples/branches{/branch}","tags_url":"https://api.github.com/repos/mvktsk/vc-samples/tags","blobs_url":"https://api.github.com/repos/mvktsk/vc-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvktsk/vc-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvktsk/vc-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvktsk/vc-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvktsk/vc-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/mvktsk/vc-samples/languages","stargazers_url":"https://api.github.com/repos/mvktsk/vc-samples/stargazers","contributors_url":"https://api.github.com/repos/mvktsk/vc-samples/contributors","subscribers_url":"https://api.github.com/repos/mvktsk/vc-samples/subscribers","subscription_url":"https://api.github.com/repos/mvktsk/vc-samples/subscription","commits_url":"https://api.github.com/repos/mvktsk/vc-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvktsk/vc-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvktsk/vc-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvktsk/vc-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvktsk/vc-samples/contents/{+path}","compare_url":"https://api.github.com/repos/mvktsk/vc-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvktsk/vc-samples/merges","archive_url":"https://api.github.com/repos/mvktsk/vc-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvktsk/vc-samples/downloads","issues_url":"https://api.github.com/repos/mvktsk/vc-samples/issues{/number}","pulls_url":"https://api.github.com/repos/mvktsk/vc-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/mvktsk/vc-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/mvktsk/vc-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvktsk/vc-samples/labels{/name}","releases_url":"https://api.github.com/repos/mvktsk/vc-samples/releases{/id}","deployments_url":"https://api.github.com/repos/mvktsk/vc-samples/deployments","created_at":"2019-07-10T06:28:00Z","updated_at":"2019-07-11T03:02:42Z","pushed_at":"2019-07-11T03:02:40Z","git_url":"git://github.com/mvktsk/vc-samples.git","ssh_url":"git@github.com:mvktsk/vc-samples.git","clone_url":"https://github.com/mvktsk/vc-samples.git","svn_url":"https://github.com/mvktsk/vc-samples","homepage":null,"size":1706,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VirtoCommerce:master","ref":"master","sha":"afccf28554784decf22a1cd7f908f40a1a0a19c4","user":{"login":"VirtoCommerce","id":5762443,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjI0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5762443?v=4","gravatar_id":"","url":"https://api.github.com/users/VirtoCommerce","html_url":"https://github.com/VirtoCommerce","followers_url":"https://api.github.com/users/VirtoCommerce/followers","following_url":"https://api.github.com/users/VirtoCommerce/following{/other_user}","gists_url":"https://api.github.com/users/VirtoCommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/VirtoCommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VirtoCommerce/subscriptions","organizations_url":"https://api.github.com/users/VirtoCommerce/orgs","repos_url":"https://api.github.com/users/VirtoCommerce/repos","events_url":"https://api.github.com/users/VirtoCommerce/events{/privacy}","received_events_url":"https://api.github.com/users/VirtoCommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":60090354,"node_id":"MDEwOlJlcG9zaXRvcnk2MDA5MDM1NA==","name":"vc-samples","full_name":"VirtoCommerce/vc-samples","private":false,"owner":{"login":"VirtoCommerce","id":5762443,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjI0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5762443?v=4","gravatar_id":"","url":"https://api.github.com/users/VirtoCommerce","html_url":"https://github.com/VirtoCommerce","followers_url":"https://api.github.com/users/VirtoCommerce/followers","following_url":"https://api.github.com/users/VirtoCommerce/following{/other_user}","gists_url":"https://api.github.com/users/VirtoCommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/VirtoCommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VirtoCommerce/subscriptions","organizations_url":"https://api.github.com/users/VirtoCommerce/orgs","repos_url":"https://api.github.com/users/VirtoCommerce/repos","events_url":"https://api.github.com/users/VirtoCommerce/events{/privacy}","received_events_url":"https://api.github.com/users/VirtoCommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VirtoCommerce/vc-samples","description":"VirtoCommerce samples","fork":false,"url":"https://api.github.com/repos/VirtoCommerce/vc-samples","forks_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/forks","keys_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/teams","hooks_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/hooks","issue_events_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/issues/events{/number}","events_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/events","assignees_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/assignees{/user}","branches_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/branches{/branch}","tags_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/tags","blobs_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/languages","stargazers_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/stargazers","contributors_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/contributors","subscribers_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/subscribers","subscription_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/subscription","commits_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/contents/{+path}","compare_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/merges","archive_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/downloads","issues_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/issues{/number}","pulls_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/labels{/name}","releases_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/releases{/id}","deployments_url":"https://api.github.com/repos/VirtoCommerce/vc-samples/deployments","created_at":"2016-05-31T13:09:35Z","updated_at":"2019-07-03T20:49:11Z","pushed_at":"2019-07-11T03:02:42Z","git_url":"git://github.com/VirtoCommerce/vc-samples.git","ssh_url":"git@github.com:VirtoCommerce/vc-samples.git","clone_url":"https://github.com/VirtoCommerce/vc-samples.git","svn_url":"https://github.com/VirtoCommerce/vc-samples","homepage":null,"size":1698,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":15,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/16"},"html":{"href":"https://github.com/VirtoCommerce/vc-samples/pull/16"},"issue":{"href":"https://api.github.com/repos/VirtoCommerce/vc-samples/issues/16"},"comments":{"href":"https://api.github.com/repos/VirtoCommerce/vc-samples/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VirtoCommerce/vc-samples/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/VirtoCommerce/vc-samples/statuses/ee111261fd3295dfb6b1997de47abdcae60bad40"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 60090354,
"name": "VirtoCommerce/vc-samples",
"url": "https://api.github.com/repos/VirtoCommerce/vc-samples"
}
|
{
"id": 5801549,
"login": "eMazeika",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5801549?",
"url": "https://api.github.com/users/eMazeika"
}
|
{
"id": 5762443,
"login": "VirtoCommerce",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5762443?",
"url": "https://api.github.com/orgs/VirtoCommerce"
}
| 2019-07-11T07:55:48 |
9990040616
|
{"actor":{"display_login":"eMazeika"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/comments/271371504","pull_request_review_id":221743004,"id":271371504,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTM3MTUwNA==","diff_hunk":"@@ -0,0 +1,130 @@\n+import { UUID } from '../components/ItemContext';\n+\n+export interface InjectedPanelAttributes {\n+ role: string | undefined;\n+ 'aria-hidden': boolean | undefined;\n+ 'aria-labelledby': string;\n+ id: string;\n+ hidden: boolean | undefined;\n+}\n+\n+export interface InjectedHeadingAttributes {\n+ role: string;\n+}\n+\n+export interface InjectedButtonAttributes {\n+ id: string;\n+ 'aria-controls': string;\n+ 'aria-expanded': boolean;\n+ 'aria-disabled': boolean;\n+ role: string;\n+ tabIndex: number;\n+}\n+\n+export default class AccordionStore {\n+ public readonly expanded: UUID[];\n+ public readonly allowMultipleExpanded: boolean;\n+ public readonly allowZeroExpanded: boolean;\n+\n+ constructor({\n+ expanded = [],\n+ allowMultipleExpanded = false,\n+ allowZeroExpanded = false\n+ }: {\n+ expanded?: UUID[];\n+ allowMultipleExpanded?: boolean;\n+ allowZeroExpanded?: boolean;\n+ }) {\n+ this.expanded = expanded;\n+ this.allowMultipleExpanded = allowMultipleExpanded;\n+ this.allowZeroExpanded = allowZeroExpanded;\n+ }\n+\n+ public readonly toggleExpanded = (uuid: UUID): AccordionStore => {\n+ if (this.isItemDisabled(uuid)) {\n+ return this;\n+ }\n+ const isExpanded = this.isItemExpanded(uuid);\n+\n+ if (!isExpanded) {\n+ return this.augment({\n+ expanded: this.allowMultipleExpanded ? [...this.expanded, uuid] : [uuid]\n+ });\n+ } else {\n+ return this.augment({\n+ expanded: this.expanded.filter(\n+ (expandedUuid: UUID): boolean => expandedUuid !== uuid\n+ )\n+ });\n+ }\n+ };\n+\n+ public readonly isItemDisabled = (uuid: UUID): boolean => {\n+ const isExpanded = this.isItemExpanded(uuid);\n+ const isOnlyOneExpanded = this.expanded.length === 1;\n+\n+ return Boolean(isExpanded && !this.allowZeroExpanded && isOnlyOneExpanded);\n+ };\n+\n+ public readonly isItemExpanded = (uuid: UUID): boolean => {\n+ return (\n+ this.expanded.findIndex((expandedUuid: UUID) => expandedUuid === uuid) !==\n+ -1","path":"src/ensembl/src/shared/accordion/helpers/AccordionStore.ts","position":72,"original_position":72,"commit_id":"8f10967add22c5ee568df683d11e98bafdae2362","original_commit_id":"3bd4e091aa37f5c0569a29dabf3d7980844bbaaf","user":{"login":"azangru","id":6834224,"node_id":"MDQ6VXNlcjY4MzQyMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6834224?v=4","gravatar_id":"","url":"https://api.github.com/users/azangru","html_url":"https://github.com/azangru","followers_url":"https://api.github.com/users/azangru/followers","following_url":"https://api.github.com/users/azangru/following{/other_user}","gists_url":"https://api.github.com/users/azangru/gists{/gist_id}","starred_url":"https://api.github.com/users/azangru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azangru/subscriptions","organizations_url":"https://api.github.com/users/azangru/orgs","repos_url":"https://api.github.com/users/azangru/repos","events_url":"https://api.github.com/users/azangru/events{/privacy}","received_events_url":"https://api.github.com/users/azangru/received_events","type":"User","site_admin":false},"body":"`return this.expanded.includes(uuid)`?","created_at":"2019-04-02T15:41:41Z","updated_at":"2019-04-02T15:41:41Z","html_url":"https://github.com/Ensembl/ensembl-client/pull/17#discussion_r271371504","pull_request_url":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/17","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/comments/271371504"},"html":{"href":"https://github.com/Ensembl/ensembl-client/pull/17#discussion_r271371504"},"pull_request":{"href":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/17","id":262980713,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyOTgwNzEz","html_url":"https://github.com/Ensembl/ensembl-client/pull/17","diff_url":"https://github.com/Ensembl/ensembl-client/pull/17.diff","patch_url":"https://github.com/Ensembl/ensembl-client/pull/17.patch","issue_url":"https://api.github.com/repos/Ensembl/ensembl-client/issues/17","number":17,"state":"open","locked":false,"title":"Accordion shared component","user":{"login":"msmanoj","id":3085815,"node_id":"MDQ6VXNlcjMwODU4MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3085815?v=4","gravatar_id":"","url":"https://api.github.com/users/msmanoj","html_url":"https://github.com/msmanoj","followers_url":"https://api.github.com/users/msmanoj/followers","following_url":"https://api.github.com/users/msmanoj/following{/other_user}","gists_url":"https://api.github.com/users/msmanoj/gists{/gist_id}","starred_url":"https://api.github.com/users/msmanoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmanoj/subscriptions","organizations_url":"https://api.github.com/users/msmanoj/orgs","repos_url":"https://api.github.com/users/msmanoj/repos","events_url":"https://api.github.com/users/msmanoj/events{/privacy}","received_events_url":"https://api.github.com/users/msmanoj/received_events","type":"User","site_admin":false},"body":"Added the shared accordion component that's based on [react-accessible-accordion ](https://github.com/springload/react-accessible-accordion)\r\n\r\nI have made very less modifications compared to the original repo, such as fixing the linter errors and using sass instead of css. ","created_at":"2019-03-20T18:11:14Z","updated_at":"2019-04-02T15:41:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c86c828089f9c1dead176252dc84adb04b24920","assignee":{"login":"msmanoj","id":3085815,"node_id":"MDQ6VXNlcjMwODU4MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3085815?v=4","gravatar_id":"","url":"https://api.github.com/users/msmanoj","html_url":"https://github.com/msmanoj","followers_url":"https://api.github.com/users/msmanoj/followers","following_url":"https://api.github.com/users/msmanoj/following{/other_user}","gists_url":"https://api.github.com/users/msmanoj/gists{/gist_id}","starred_url":"https://api.github.com/users/msmanoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmanoj/subscriptions","organizations_url":"https://api.github.com/users/msmanoj/orgs","repos_url":"https://api.github.com/users/msmanoj/repos","events_url":"https://api.github.com/users/msmanoj/events{/privacy}","received_events_url":"https://api.github.com/users/msmanoj/received_events","type":"User","site_admin":false},"assignees":[{"login":"msmanoj","id":3085815,"node_id":"MDQ6VXNlcjMwODU4MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3085815?v=4","gravatar_id":"","url":"https://api.github.com/users/msmanoj","html_url":"https://github.com/msmanoj","followers_url":"https://api.github.com/users/msmanoj/followers","following_url":"https://api.github.com/users/msmanoj/following{/other_user}","gists_url":"https://api.github.com/users/msmanoj/gists{/gist_id}","starred_url":"https://api.github.com/users/msmanoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmanoj/subscriptions","organizations_url":"https://api.github.com/users/msmanoj/orgs","repos_url":"https://api.github.com/users/msmanoj/repos","events_url":"https://api.github.com/users/msmanoj/events{/privacy}","received_events_url":"https://api.github.com/users/msmanoj/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"imran-ebi","id":32512909,"node_id":"MDQ6VXNlcjMyNTEyOTA5","avatar_url":"https://avatars1.githubusercontent.com/u/32512909?v=4","gravatar_id":"","url":"https://api.github.com/users/imran-ebi","html_url":"https://github.com/imran-ebi","followers_url":"https://api.github.com/users/imran-ebi/followers","following_url":"https://api.github.com/users/imran-ebi/following{/other_user}","gists_url":"https://api.github.com/users/imran-ebi/gists{/gist_id}","starred_url":"https://api.github.com/users/imran-ebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imran-ebi/subscriptions","organizations_url":"https://api.github.com/users/imran-ebi/orgs","repos_url":"https://api.github.com/users/imran-ebi/repos","events_url":"https://api.github.com/users/imran-ebi/events{/privacy}","received_events_url":"https://api.github.com/users/imran-ebi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/17/commits","review_comments_url":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/17/comments","review_comment_url":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ensembl/ensembl-client/issues/17/comments","statuses_url":"https://api.github.com/repos/Ensembl/ensembl-client/statuses/8f10967add22c5ee568df683d11e98bafdae2362","head":{"label":"Ensembl:feature/accordion-panel","ref":"feature/accordion-panel","sha":"8f10967add22c5ee568df683d11e98bafdae2362","user":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"repo":{"id":167968079,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc5NjgwNzk=","name":"ensembl-client","full_name":"Ensembl/ensembl-client","private":false,"owner":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ensembl/ensembl-client","description":"Ensembl 2020 client","fork":false,"url":"https://api.github.com/repos/Ensembl/ensembl-client","forks_url":"https://api.github.com/repos/Ensembl/ensembl-client/forks","keys_url":"https://api.github.com/repos/Ensembl/ensembl-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ensembl/ensembl-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ensembl/ensembl-client/teams","hooks_url":"https://api.github.com/repos/Ensembl/ensembl-client/hooks","issue_events_url":"https://api.github.com/repos/Ensembl/ensembl-client/issues/events{/number}","events_url":"https://api.github.com/repos/Ensembl/ensembl-client/events","assignees_url":"https://api.github.com/repos/Ensembl/ensembl-client/assignees{/user}","branches_url":"https://api.github.com/repos/Ensembl/ensembl-client/branches{/branch}","tags_url":"https://api.github.com/repos/Ensembl/ensembl-client/tags","blobs_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ensembl/ensembl-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Ensembl/ensembl-client/languages","stargazers_url":"https://api.github.com/repos/Ensembl/ensembl-client/stargazers","contributors_url":"https://api.github.com/repos/Ensembl/ensembl-client/contributors","subscribers_url":"https://api.github.com/repos/Ensembl/ensembl-client/subscribers","subscription_url":"https://api.github.com/repos/Ensembl/ensembl-client/subscription","commits_url":"https://api.github.com/repos/Ensembl/ensembl-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ensembl/ensembl-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ensembl/ensembl-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ensembl/ensembl-client/contents/{+path}","compare_url":"https://api.github.com/repos/Ensembl/ensembl-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ensembl/ensembl-client/merges","archive_url":"https://api.github.com/repos/Ensembl/ensembl-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ensembl/ensembl-client/downloads","issues_url":"https://api.github.com/repos/Ensembl/ensembl-client/issues{/number}","pulls_url":"https://api.github.com/repos/Ensembl/ensembl-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Ensembl/ensembl-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Ensembl/ensembl-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ensembl/ensembl-client/labels{/name}","releases_url":"https://api.github.com/repos/Ensembl/ensembl-client/releases{/id}","deployments_url":"https://api.github.com/repos/Ensembl/ensembl-client/deployments","created_at":"2019-01-28T13:36:49Z","updated_at":"2019-04-02T14:25:26Z","pushed_at":"2019-04-02T15:37:04Z","git_url":"git://github.com/Ensembl/ensembl-client.git","ssh_url":"git@github.com:Ensembl/ensembl-client.git","clone_url":"https://github.com/Ensembl/ensembl-client.git","svn_url":"https://github.com/Ensembl/ensembl-client","homepage":null,"size":30076,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":2,"default_branch":"dev"}},"base":{"label":"Ensembl:dev","ref":"dev","sha":"2f2ca04c1aaff5b0705751bcfa5b3d126431f45f","user":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"repo":{"id":167968079,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc5NjgwNzk=","name":"ensembl-client","full_name":"Ensembl/ensembl-client","private":false,"owner":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ensembl/ensembl-client","description":"Ensembl 2020 client","fork":false,"url":"https://api.github.com/repos/Ensembl/ensembl-client","forks_url":"https://api.github.com/repos/Ensembl/ensembl-client/forks","keys_url":"https://api.github.com/repos/Ensembl/ensembl-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ensembl/ensembl-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ensembl/ensembl-client/teams","hooks_url":"https://api.github.com/repos/Ensembl/ensembl-client/hooks","issue_events_url":"https://api.github.com/repos/Ensembl/ensembl-client/issues/events{/number}","events_url":"https://api.github.com/repos/Ensembl/ensembl-client/events","assignees_url":"https://api.github.com/repos/Ensembl/ensembl-client/assignees{/user}","branches_url":"https://api.github.com/repos/Ensembl/ensembl-client/branches{/branch}","tags_url":"https://api.github.com/repos/Ensembl/ensembl-client/tags","blobs_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ensembl/ensembl-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Ensembl/ensembl-client/languages","stargazers_url":"https://api.github.com/repos/Ensembl/ensembl-client/stargazers","contributors_url":"https://api.github.com/repos/Ensembl/ensembl-client/contributors","subscribers_url":"https://api.github.com/repos/Ensembl/ensembl-client/subscribers","subscription_url":"https://api.github.com/repos/Ensembl/ensembl-client/subscription","commits_url":"https://api.github.com/repos/Ensembl/ensembl-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ensembl/ensembl-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ensembl/ensembl-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ensembl/ensembl-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ensembl/ensembl-client/contents/{+path}","compare_url":"https://api.github.com/repos/Ensembl/ensembl-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ensembl/ensembl-client/merges","archive_url":"https://api.github.com/repos/Ensembl/ensembl-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ensembl/ensembl-client/downloads","issues_url":"https://api.github.com/repos/Ensembl/ensembl-client/issues{/number}","pulls_url":"https://api.github.com/repos/Ensembl/ensembl-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Ensembl/ensembl-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Ensembl/ensembl-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ensembl/ensembl-client/labels{/name}","releases_url":"https://api.github.com/repos/Ensembl/ensembl-client/releases{/id}","deployments_url":"https://api.github.com/repos/Ensembl/ensembl-client/deployments","created_at":"2019-01-28T13:36:49Z","updated_at":"2019-04-02T14:25:26Z","pushed_at":"2019-04-02T15:37:04Z","git_url":"git://github.com/Ensembl/ensembl-client.git","ssh_url":"git@github.com:Ensembl/ensembl-client.git","clone_url":"https://github.com/Ensembl/ensembl-client.git","svn_url":"https://github.com/Ensembl/ensembl-client","homepage":null,"size":30076,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/17"},"html":{"href":"https://github.com/Ensembl/ensembl-client/pull/17"},"issue":{"href":"https://api.github.com/repos/Ensembl/ensembl-client/issues/17"},"comments":{"href":"https://api.github.com/repos/Ensembl/ensembl-client/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ensembl/ensembl-client/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/Ensembl/ensembl-client/statuses/8f10967add22c5ee568df683d11e98bafdae2362"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 167968079,
"name": "Ensembl/ensembl-client",
"url": "https://api.github.com/repos/Ensembl/ensembl-client"
}
|
{
"id": 6834224,
"login": "azangru",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6834224?",
"url": "https://api.github.com/users/azangru"
}
|
{
"id": 5832463,
"login": "Ensembl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5832463?",
"url": "https://api.github.com/orgs/Ensembl"
}
| 2019-04-02T15:41:41 |
9363291276
|
{"actor":{"display_login":"azangru"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/comments/301603378","pull_request_review_id":259522622,"id":301603378,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTYwMzM3OA==","diff_hunk":"@@ -0,0 +1,229 @@\n+=head1 LICENSE\n+\n+Copyright [1999-2015] Wellcome Trust Sanger Institute and the EMBL-European Bioinformatics Institute\n+Copyright [2016-2019] EMBL-European Bioinformatics Institute\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+\n+=cut\n+\n+\n+=head1 CONTACT\n+\n+ Please email comments or questions to the public Ensembl\n+ developers list at <http://lists.ensembl.org/mailman/listinfo/dev>.\n+\n+ Questions may also be sent to the Ensembl help desk at\n+ <http://www.ensembl.org/Help/Contact>.\n+\n+=head1 NAME\n+\n+Bio::EnsEMBL::Compara::PipeConfig::BuildNewMasterDatabase_conf\n+\n+=head1 DESCRIPTION\n+\n+ Create a new master database from scratch via a predefined registry\n+ configuration file with the desired core database(s) from where the species/\n+ genome information will be copied.\n+\n+ WARNING: the previous reports and backups will be removed if the pipeline is\n+ initialised again for the same division and release.\n+\n+=head1 SYNOPSIS\n+\n+ Usage for non-test divisions:\n+ init_pipeline.pl Bio::EnsEMBL::Compara::PipeConfig::BuildNewMasterDatabase_conf -division <division>\n+\n+ #1. Create a new master database\n+ #2. Populate it through PrepareMasterDatabaseForRelease pipeline\n+\n+ For test divisions see Bio::EnsEMBL::Compara::PipeConfig::EBI::Test::BuildTestMasterDatabase_conf\n+\n+=head1 AUTHORSHIP\n+\n+Ensembl Team. Individual contributions can be found in the GIT log.\n+\n+=head1 APPENDIX\n+\n+=cut\n+\n+package Bio::EnsEMBL::Compara::PipeConfig::BuildNewMasterDatabase_conf;\n+\n+use strict;\n+use warnings;\n+\n+use Bio::EnsEMBL::Hive::Version 2.4;\n+\n+use Bio::EnsEMBL::Hive::PipeConfig::HiveGeneric_conf;\n+use base ('Bio::EnsEMBL::Compara::PipeConfig::ComparaGeneric_conf');\n+\n+use Bio::EnsEMBL::Compara::PipeConfig::Parts::PrepareMasterDatabaseForRelease;\n+\n+sub no_compara_schema {};\n+\n+sub default_options {\n+ my ($self) = @_;\n+ return {\n+ # Inherit the generic default options\n+ %{$self->SUPER::default_options},\n+\n+ 'pipeline_name' => 'build_new_master_for_' . $self->o('division'),\n+ 'work_dir' => $self->o('pipeline_dir'),\n+ 'backups_dir' => $self->o('work_dir') . '/backups/',\n+\n+ 'master_db' => 'compara_master',\n+ 'schema_file' => $self->check_file_in_ensembl('ensembl-compara/sql/table.sql'),\n+ 'method_link_dump' => $self->check_file_in_ensembl('ensembl-compara/sql/method_link.txt'),\n+ 'clone_core_db' => $self->check_exe_in_ensembl('ensembl-test/scripts/clone_core_database.pl'),\n+\n+ 'java_hc_dir' => $self->check_dir_in_ensembl('ensj-healthcheck/'),\n+ 'java_hc_db_prop' => $self->check_file_in_ensembl('ensj-healthcheck/database.defaults.properties'),\n+\n+ 'init_reg_conf' => $self->o('reg_conf'), # needed to create the new master database\n+ # Parameters required for 'test' division only\n+ 'config_dir' => undef,\n+ 'reg_conf_tmpl' => undef,\n+ 'dst_host' => undef,\n+ 'dst_port' => undef,\n+\n+ # PrepareMasterDatabaseForRelease pipeline configuration:\n+ 'taxonomy_db' => 'ncbi_taxonomy',\n+ 'incl_components' => 1, # let's default this to 1 - will have no real effect if there are no component genomes (e.g. in vertebrates)\n+ 'create_all_mlss_exe' => $self->check_exe_in_ensembl('ensembl-compara/scripts/pipeline/create_all_mlss.pl'),\n+ 'xml_file' => $self->o('config_dir') . '/compara_' . $self->o('division') . '.xml',\n+ 'report_file' => $self->o('work_dir') . '/mlss_ids_' . $self->o('division') . '.list',\n+ 'master_backup_file' => $self->o('backups_dir') . '/new_master_' . $self->o('division') . '.sql',\n+ 'patch_dir' => $self->check_dir_in_ensembl('ensembl-compara/sql/'),\n+ 'alias_file' => $self->check_file_in_ensembl('ensembl-compara/scripts/taxonomy/ensembl_aliases.sql'),\n+ 'list_genomes_script' => undef, # required but not used: do_update_from_metadata = 0\n+ 'report_genomes_script' => undef, # required but not used: do_update_from_metadata = 0\n+ 'update_metadata_script' => $self->check_exe_in_ensembl('ensembl-compara/scripts/pipeline/update_master_db.pl'),\n+ 'assembly_patch_species' => [], # by default, skip this step\n+ 'additional_species' => {}, # by default, skip this step\n+ 'do_update_from_metadata' => 0,\n+ 'do_load_lrg_dnafrags' => 0,\n+ 'do_load_timetree' => 0,\n+ };\n+}\n+\n+sub pipeline_create_commands {\n+ my ($self) = @_;\n+ return [\n+ # Inherit creation of database, hive tables and compara tables\n+ @{$self->SUPER::pipeline_create_commands},\n+\n+ $self->pipeline_create_commands_rm_mkdir(['work_dir', 'backups_dir']),\n+ ];\n+}\n+\n+sub pipeline_wide_parameters {\n+ # These parameter values are visible to all analyses, can be overridden by parameters{} and input_id{}\n+ my ($self) = @_;\n+ return {\n+ # Inherit anything from the base class\n+ %{$self->SUPER::pipeline_wide_parameters},\n+\n+ 'master_db' => $self->o('master_db'),\n+ 'division' => $self->o('division'),\n+ 'release' => $self->o('ensembl_release'),\n+ 'hc_version' => 1,\n+ # Define the flags so they can be seen by Parts::PrepareMasterDatabaseForRelease\n+ 'do_update_from_metadata' => $self->o('do_update_from_metadata'),\n+ 'do_load_lrg_dnafrags' => $self->o('do_load_lrg_dnafrags'),\n+ 'do_load_timetree' => $self->o('do_load_timetree'),\n+ };\n+}\n+\n+sub pipeline_analyses {\n+ my ($self) = @_;\n+ return [\n+ { -logic_name => 'create_new_master',\n+ -module => 'Bio::EnsEMBL::Hive::RunnableDB::SystemCmd',","path":"modules/Bio/EnsEMBL/Compara/PipeConfig/BuildNewMasterDatabase_conf.pm","position":151,"original_position":151,"commit_id":"0c1b6590b0215bcdacec851a8a68a4ea306b8942","original_commit_id":"36cc589adca2f7455278e14d28ea3471c952d57c","user":{"login":"JAlvarezJarreta","id":13499999,"node_id":"MDQ6VXNlcjEzNDk5OTk5","avatar_url":"https://avatars2.githubusercontent.com/u/13499999?v=4","gravatar_id":"","url":"https://api.github.com/users/JAlvarezJarreta","html_url":"https://github.com/JAlvarezJarreta","followers_url":"https://api.github.com/users/JAlvarezJarreta/followers","following_url":"https://api.github.com/users/JAlvarezJarreta/following{/other_user}","gists_url":"https://api.github.com/users/JAlvarezJarreta/gists{/gist_id}","starred_url":"https://api.github.com/users/JAlvarezJarreta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JAlvarezJarreta/subscriptions","organizations_url":"https://api.github.com/users/JAlvarezJarreta/orgs","repos_url":"https://api.github.com/users/JAlvarezJarreta/repos","events_url":"https://api.github.com/users/JAlvarezJarreta/events{/privacy}","received_events_url":"https://api.github.com/users/JAlvarezJarreta/received_events","type":"User","site_admin":false},"body":"Yes, that is why I chose this option.","created_at":"2019-07-09T14:02:20Z","updated_at":"2019-07-09T14:02:21Z","html_url":"https://github.com/Ensembl/ensembl-compara/pull/104#discussion_r301603378","pull_request_url":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/104","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/comments/301603378"},"html":{"href":"https://github.com/Ensembl/ensembl-compara/pull/104#discussion_r301603378"},"pull_request":{"href":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/104"}},"in_reply_to_id":300006195},"pull_request":{"url":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/104","id":292459242,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyNDU5MjQy","html_url":"https://github.com/Ensembl/ensembl-compara/pull/104","diff_url":"https://github.com/Ensembl/ensembl-compara/pull/104.diff","patch_url":"https://github.com/Ensembl/ensembl-compara/pull/104.patch","issue_url":"https://api.github.com/repos/Ensembl/ensembl-compara/issues/104","number":104,"state":"open","locked":false,"title":"New pipeline to build master databases from scratch","user":{"login":"JAlvarezJarreta","id":13499999,"node_id":"MDQ6VXNlcjEzNDk5OTk5","avatar_url":"https://avatars2.githubusercontent.com/u/13499999?v=4","gravatar_id":"","url":"https://api.github.com/users/JAlvarezJarreta","html_url":"https://github.com/JAlvarezJarreta","followers_url":"https://api.github.com/users/JAlvarezJarreta/followers","following_url":"https://api.github.com/users/JAlvarezJarreta/following{/other_user}","gists_url":"https://api.github.com/users/JAlvarezJarreta/gists{/gist_id}","starred_url":"https://api.github.com/users/JAlvarezJarreta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JAlvarezJarreta/subscriptions","organizations_url":"https://api.github.com/users/JAlvarezJarreta/orgs","repos_url":"https://api.github.com/users/JAlvarezJarreta/repos","events_url":"https://api.github.com/users/JAlvarezJarreta/events{/privacy}","received_events_url":"https://api.github.com/users/JAlvarezJarreta/received_events","type":"User","site_admin":false},"body":"Created a new pipeline to build a new Compara master database from scratch, and a specialised version to build a master database for the new \"test\" division (cloning required species' regions from core databases to populate the new master database).\r\n\r\n_Reference:_ Continuous testing of Compara pipelines [[link](https://www.ebi.ac.uk/seqdb/confluence/display/EnsCom/Continuous+testing+of+Compara+pipelines)]: tickets [ENSCOMPARASW-2262](https://www.ebi.ac.uk/panda/jira/browse/ENSCOMPARASW-2262) and [ENSCOMPARASW-2277](https://www.ebi.ac.uk/panda/jira/browse/ENSCOMPARASW-2277).","created_at":"2019-06-27T14:21:26Z","updated_at":"2019-07-09T14:02:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81d718cc273884e809eebdc6182f9783b1465011","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/104/commits","review_comments_url":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/104/comments","review_comment_url":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ensembl/ensembl-compara/issues/104/comments","statuses_url":"https://api.github.com/repos/Ensembl/ensembl-compara/statuses/0c1b6590b0215bcdacec851a8a68a4ea306b8942","head":{"label":"JAlvarezJarreta:master","ref":"master","sha":"0c1b6590b0215bcdacec851a8a68a4ea306b8942","user":{"login":"JAlvarezJarreta","id":13499999,"node_id":"MDQ6VXNlcjEzNDk5OTk5","avatar_url":"https://avatars2.githubusercontent.com/u/13499999?v=4","gravatar_id":"","url":"https://api.github.com/users/JAlvarezJarreta","html_url":"https://github.com/JAlvarezJarreta","followers_url":"https://api.github.com/users/JAlvarezJarreta/followers","following_url":"https://api.github.com/users/JAlvarezJarreta/following{/other_user}","gists_url":"https://api.github.com/users/JAlvarezJarreta/gists{/gist_id}","starred_url":"https://api.github.com/users/JAlvarezJarreta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JAlvarezJarreta/subscriptions","organizations_url":"https://api.github.com/users/JAlvarezJarreta/orgs","repos_url":"https://api.github.com/users/JAlvarezJarreta/repos","events_url":"https://api.github.com/users/JAlvarezJarreta/events{/privacy}","received_events_url":"https://api.github.com/users/JAlvarezJarreta/received_events","type":"User","site_admin":false},"repo":{"id":187677443,"node_id":"MDEwOlJlcG9zaXRvcnkxODc2Nzc0NDM=","name":"ensembl-compara","full_name":"JAlvarezJarreta/ensembl-compara","private":false,"owner":{"login":"JAlvarezJarreta","id":13499999,"node_id":"MDQ6VXNlcjEzNDk5OTk5","avatar_url":"https://avatars2.githubusercontent.com/u/13499999?v=4","gravatar_id":"","url":"https://api.github.com/users/JAlvarezJarreta","html_url":"https://github.com/JAlvarezJarreta","followers_url":"https://api.github.com/users/JAlvarezJarreta/followers","following_url":"https://api.github.com/users/JAlvarezJarreta/following{/other_user}","gists_url":"https://api.github.com/users/JAlvarezJarreta/gists{/gist_id}","starred_url":"https://api.github.com/users/JAlvarezJarreta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JAlvarezJarreta/subscriptions","organizations_url":"https://api.github.com/users/JAlvarezJarreta/orgs","repos_url":"https://api.github.com/users/JAlvarezJarreta/repos","events_url":"https://api.github.com/users/JAlvarezJarreta/events{/privacy}","received_events_url":"https://api.github.com/users/JAlvarezJarreta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JAlvarezJarreta/ensembl-compara","description":"The Ensembl Compara Perl API and SQL schema","fork":true,"url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara","forks_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/forks","keys_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/teams","hooks_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/hooks","issue_events_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/issues/events{/number}","events_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/events","assignees_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/assignees{/user}","branches_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/branches{/branch}","tags_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/tags","blobs_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/git/refs{/sha}","trees_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/statuses/{sha}","languages_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/languages","stargazers_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/stargazers","contributors_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/contributors","subscribers_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/subscribers","subscription_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/subscription","commits_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/commits{/sha}","git_commits_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/git/commits{/sha}","comments_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/comments{/number}","issue_comment_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/issues/comments{/number}","contents_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/contents/{+path}","compare_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/merges","archive_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/downloads","issues_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/issues{/number}","pulls_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/pulls{/number}","milestones_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/milestones{/number}","notifications_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/labels{/name}","releases_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/releases{/id}","deployments_url":"https://api.github.com/repos/JAlvarezJarreta/ensembl-compara/deployments","created_at":"2019-05-20T16:32:37Z","updated_at":"2019-05-20T16:32:45Z","pushed_at":"2019-07-03T09:06:58Z","git_url":"git://github.com/JAlvarezJarreta/ensembl-compara.git","ssh_url":"git@github.com:JAlvarezJarreta/ensembl-compara.git","clone_url":"https://github.com/JAlvarezJarreta/ensembl-compara.git","svn_url":"https://github.com/JAlvarezJarreta/ensembl-compara","homepage":"http://www.ensembl.org/info/docs/api/compara/","size":231630,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"release/96"}},"base":{"label":"Ensembl:master","ref":"master","sha":"49f1edc710f88b128ec955640ec1e0a06f2a9945","user":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"repo":{"id":14689025,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4OTAyNQ==","name":"ensembl-compara","full_name":"Ensembl/ensembl-compara","private":false,"owner":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ensembl/ensembl-compara","description":"The Ensembl Compara Perl API and SQL schema","fork":false,"url":"https://api.github.com/repos/Ensembl/ensembl-compara","forks_url":"https://api.github.com/repos/Ensembl/ensembl-compara/forks","keys_url":"https://api.github.com/repos/Ensembl/ensembl-compara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ensembl/ensembl-compara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ensembl/ensembl-compara/teams","hooks_url":"https://api.github.com/repos/Ensembl/ensembl-compara/hooks","issue_events_url":"https://api.github.com/repos/Ensembl/ensembl-compara/issues/events{/number}","events_url":"https://api.github.com/repos/Ensembl/ensembl-compara/events","assignees_url":"https://api.github.com/repos/Ensembl/ensembl-compara/assignees{/user}","branches_url":"https://api.github.com/repos/Ensembl/ensembl-compara/branches{/branch}","tags_url":"https://api.github.com/repos/Ensembl/ensembl-compara/tags","blobs_url":"https://api.github.com/repos/Ensembl/ensembl-compara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ensembl/ensembl-compara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ensembl/ensembl-compara/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ensembl/ensembl-compara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ensembl/ensembl-compara/statuses/{sha}","languages_url":"https://api.github.com/repos/Ensembl/ensembl-compara/languages","stargazers_url":"https://api.github.com/repos/Ensembl/ensembl-compara/stargazers","contributors_url":"https://api.github.com/repos/Ensembl/ensembl-compara/contributors","subscribers_url":"https://api.github.com/repos/Ensembl/ensembl-compara/subscribers","subscription_url":"https://api.github.com/repos/Ensembl/ensembl-compara/subscription","commits_url":"https://api.github.com/repos/Ensembl/ensembl-compara/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ensembl/ensembl-compara/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ensembl/ensembl-compara/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ensembl/ensembl-compara/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ensembl/ensembl-compara/contents/{+path}","compare_url":"https://api.github.com/repos/Ensembl/ensembl-compara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ensembl/ensembl-compara/merges","archive_url":"https://api.github.com/repos/Ensembl/ensembl-compara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ensembl/ensembl-compara/downloads","issues_url":"https://api.github.com/repos/Ensembl/ensembl-compara/issues{/number}","pulls_url":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls{/number}","milestones_url":"https://api.github.com/repos/Ensembl/ensembl-compara/milestones{/number}","notifications_url":"https://api.github.com/repos/Ensembl/ensembl-compara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ensembl/ensembl-compara/labels{/name}","releases_url":"https://api.github.com/repos/Ensembl/ensembl-compara/releases{/id}","deployments_url":"https://api.github.com/repos/Ensembl/ensembl-compara/deployments","created_at":"2013-11-25T15:18:17Z","updated_at":"2019-07-04T10:20:12Z","pushed_at":"2019-07-09T10:54:39Z","git_url":"git://github.com/Ensembl/ensembl-compara.git","ssh_url":"git@github.com:Ensembl/ensembl-compara.git","clone_url":"https://github.com/Ensembl/ensembl-compara.git","svn_url":"https://github.com/Ensembl/ensembl-compara","homepage":"http://www.ensembl.org/info/docs/api/compara/","size":231619,"stargazers_count":26,"watchers_count":26,"language":"Perl","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":3,"watchers":26,"default_branch":"release/97"}},"_links":{"self":{"href":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/104"},"html":{"href":"https://github.com/Ensembl/ensembl-compara/pull/104"},"issue":{"href":"https://api.github.com/repos/Ensembl/ensembl-compara/issues/104"},"comments":{"href":"https://api.github.com/repos/Ensembl/ensembl-compara/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ensembl/ensembl-compara/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/Ensembl/ensembl-compara/statuses/0c1b6590b0215bcdacec851a8a68a4ea306b8942"}},"author_association":"NONE"}}
|
{
"id": 14689025,
"name": "Ensembl/ensembl-compara",
"url": "https://api.github.com/repos/Ensembl/ensembl-compara"
}
|
{
"id": 13499999,
"login": "JAlvarezJarreta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13499999?",
"url": "https://api.github.com/users/JAlvarezJarreta"
}
|
{
"id": 5832463,
"login": "Ensembl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5832463?",
"url": "https://api.github.com/orgs/Ensembl"
}
| 2019-07-09T14:02:20 |
9975904658
|
{"actor":{"display_login":"JAlvarezJarreta"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/containers/image/pulls/comments/268157780","pull_request_review_id":217739764,"id":268157780,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODE1Nzc4MA==","diff_hunk":"@@ -664,30 +689,123 @@ func (ic *imageCopier) copyLayer(ctx context.Context, srcInfo types.BlobInfo, po\n \tcachedDiffID := ic.c.blobInfoCache.UncompressedDigest(srcInfo.Digest) // May be \"\"\n \tdiffIDIsNeeded := ic.diffIDsAreNeeded && cachedDiffID == \"\"\n \n+\t// Create the initial placeholder bar which is later being replaced by\n+\t// another one.\n+\tbar := ic.c.createProgressBar(pool, srcInfo, \"blob\", \" \", mpb.BarRemoveOnComplete())\n+\n \t// If we already have the blob, and we don't need to compute the diffID, then we don't need to read it from the source.\n \tif !diffIDIsNeeded {\n-\t\treused, blobInfo, err := ic.c.dest.TryReusingBlob(ctx, srcInfo, ic.c.blobInfoCache, ic.canSubstituteBlobs)\n+\t\t// tryReusingBlob is an anonymous function to avoid adding\n+\t\t// another method with a complex parameter list and semantics.\n+\t\t// It's sole purpose is to simplify the control with an early\n+\t\t// return if the image destination does not blob locking.\n+\t\ttryReusingBlob := func() (bool, types.BlobInfo, digest.Digest, error) {\n+\t\t\treused, blobInfo, err := ic.c.dest.TryReusingBlob(ctx, srcInfo, ic.c.blobInfoCache, ic.canSubstituteBlobs)\n+\t\t\tif err != nil {\n+\t\t\t\treturn false, types.BlobInfo{}, \"\", errors.Wrapf(err, \"Error trying to reuse blob %s at destination\", srcInfo.Digest)\n+\t\t\t}\n+\t\t\tif reused {\n+\t\t\t\tlogrus.Debugf(\"Skipping blob %s (already present):\", srcInfo.Digest)\n+\t\t\t\tbar.SetTotal(0, true)\n+\t\t\t\tic.c.createProgressBar(pool, srcInfo, \"blob\", \"skipped: already exists\", mpb.BarReplaceOnComplete(bar))\n+\t\t\t\treturn true, blobInfo, cachedDiffID, nil\n+\t\t\t}\n+\n+\t\t\tif !ic.c.dest.SupportsBlobLocks() {\n+\t\t\t\treturn false, types.BlobInfo{}, \"\", nil\n+\t\t\t}\n+\n+\t\t\t// Check if another process might be copying the layer at the\n+\t\t\t// moment. If so, wait for it's completion and try to reuse\n+\t\t\t// the blob again.\n+\t\t\t//\n+\t\t\tlogrus.Debugf(\"Checking if blob %s is already being copied by another process\", srcInfo.Digest)\n+\n+\t\t\t// LockBlob() does not support try-lock semantics which would\n+\t\t\t// be a straight-forward mechanism to detect if another process\n+\t\t\t// is currently copying a specific layer. However, with\n+\t\t\t// LockBlob() we are constrained by the file locks in\n+\t\t\t// containers/storage which cannot support try-lock semantics\n+\t\t\t// as fcntl(2) does not support that.\n+\t\t\t//\n+\t\t\t// The trick we are using here is to acquire the lock in a\n+\t\t\t// separate goroutine. The main routine first sleeps for\n+\t\t\t// the progressBarRefreshRate amount of time and will be\n+\t\t\t// signaled via a semaphore if and when the blob lock has\n+\t\t\t// been acquired.\n+\t\t\tblobLockSem := semaphore.NewWeighted(1)\n+\t\t\tblobLockSem.Acquire(ctx, 1)\n+\t\t\tvar lockError error\n+\t\t\tgo func() {\n+\t\t\t\tlockError = ic.c.dest.LockBlob(srcInfo)\n+\t\t\t\tblobLockSem.Release(1)\n+\t\t\t}()\n+\n+\t\t\tif !blobLockSem.TryAcquire(1) {\n+\t\t\t\t// The initial sleep time is `progressBarRefreshRate`\n+\t\t\t\t// to make sure the bar is properly rendered before\n+\t\t\t\t// replacing it.\n+\t\t\t\ttime.Sleep(progressBarRefreshRate)\n+\t\t\t\tif !blobLockSem.TryAcquire(1) {\n+\t\t\t\t\tlogrus.Debugf(\"Blob %s is already being copied by another process\", srcInfo.Digest)\n+\t\t\t\t\t// If we still don't have the lock, replace the\n+\t\t\t\t\t// initial progress bar with a new one\n+\t\t\t\t\t// indicating that the blob is copied by\n+\t\t\t\t\t// another process.\n+\t\t\t\t\t//\n+\t\t\t\t\t// Note that we call SetTotal() after the new\n+\t\t\t\t\t// bar is created to avoid potential flickering\n+\t\t\t\t\t// if the bar removal and replacement happens\n+\t\t\t\t\t// across refresh rates.\n+\t\t\t\t\ttoReplaceBar := bar\n+\t\t\t\t\tbar = ic.c.createProgressBar(pool, srcInfo, \"blob\", \"paused: being copied by another process\", mpb.BarRemoveOnComplete(), mpb.BarReplaceOnComplete(bar))\n+\t\t\t\t\ttoReplaceBar.SetTotal(0, true)\n+\t\t\t\t\t// block until we acquired the blob lock\n+\t\t\t\t\tblobLockSem.Acquire(ctx, 1)\n+\t\t\t\t}\n+\t\t\t}\n+\n+\t\t\tif lockError != nil {\n+\t\t\t\treturn false, types.BlobInfo{}, \"\", errors.Wrapf(err, \"Error acquiring lock for blob %s\", srcInfo.Digest)\n+\t\t\t}\n+\n+\t\t\treused, blobInfo, err = ic.c.dest.TryReusingBlob(ctx, srcInfo, ic.c.blobInfoCache, ic.canSubstituteBlobs)","path":"copy/copy.go","position":261,"original_position":166,"commit_id":"071c9f98767c48db6141234b6af7618ec191b091","original_commit_id":"071c9f98767c48db6141234b6af7618ec191b091","user":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"body":"Add another comment why we're calling `TryReusingBlob()` again.","created_at":"2019-03-22T13:05:36Z","updated_at":"2019-03-22T13:08:36Z","html_url":"https://github.com/containers/image/pull/607#discussion_r268157780","pull_request_url":"https://api.github.com/repos/containers/image/pulls/607","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/containers/image/pulls/comments/268157780"},"html":{"href":"https://github.com/containers/image/pull/607#discussion_r268157780"},"pull_request":{"href":"https://api.github.com/repos/containers/image/pulls/607"}}},"pull_request":{"url":"https://api.github.com/repos/containers/image/pulls/607","id":262962108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyOTYyMTA4","html_url":"https://github.com/containers/image/pull/607","diff_url":"https://github.com/containers/image/pull/607.diff","patch_url":"https://github.com/containers/image/pull/607.patch","issue_url":"https://api.github.com/repos/containers/image/issues/607","number":607,"state":"open","locked":false,"title":"WIP - Copy detection","user":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"body":"https://github.com/containers/storage/pull/307 must be merged before. Then we can update this PR and merge.\r\n\r\nThis PR is rather big and complex but I tried to cut it into easier to digest commits where possible (the final commit being the big chunk I couldn't figure out to split).\r\n\r\nFYI @rhatdan @wking @mtrmac \r\n\r\nI will open a PR over a Skopeo that you can you use to play around.","created_at":"2019-03-20T17:19:58Z","updated_at":"2019-03-22T13:08:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41f8e4fd67eb7c2cbc40eb5c9a5cbc975dbff106","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nalind","id":1200159,"node_id":"MDQ6VXNlcjEyMDAxNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1200159?v=4","gravatar_id":"","url":"https://api.github.com/users/nalind","html_url":"https://github.com/nalind","followers_url":"https://api.github.com/users/nalind/followers","following_url":"https://api.github.com/users/nalind/following{/other_user}","gists_url":"https://api.github.com/users/nalind/gists{/gist_id}","starred_url":"https://api.github.com/users/nalind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalind/subscriptions","organizations_url":"https://api.github.com/users/nalind/orgs","repos_url":"https://api.github.com/users/nalind/repos","events_url":"https://api.github.com/users/nalind/events{/privacy}","received_events_url":"https://api.github.com/users/nalind/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/containers/image/pulls/607/commits","review_comments_url":"https://api.github.com/repos/containers/image/pulls/607/comments","review_comment_url":"https://api.github.com/repos/containers/image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containers/image/issues/607/comments","statuses_url":"https://api.github.com/repos/containers/image/statuses/071c9f98767c48db6141234b6af7618ec191b091","head":{"label":"vrothberg:copy-detection","ref":"copy-detection","sha":"071c9f98767c48db6141234b6af7618ec191b091","user":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"repo":{"id":116376947,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYzNzY5NDc=","name":"image","full_name":"vrothberg/image","private":false,"owner":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vrothberg/image","description":"Work with containers' images","fork":true,"url":"https://api.github.com/repos/vrothberg/image","forks_url":"https://api.github.com/repos/vrothberg/image/forks","keys_url":"https://api.github.com/repos/vrothberg/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrothberg/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrothberg/image/teams","hooks_url":"https://api.github.com/repos/vrothberg/image/hooks","issue_events_url":"https://api.github.com/repos/vrothberg/image/issues/events{/number}","events_url":"https://api.github.com/repos/vrothberg/image/events","assignees_url":"https://api.github.com/repos/vrothberg/image/assignees{/user}","branches_url":"https://api.github.com/repos/vrothberg/image/branches{/branch}","tags_url":"https://api.github.com/repos/vrothberg/image/tags","blobs_url":"https://api.github.com/repos/vrothberg/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrothberg/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrothberg/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrothberg/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrothberg/image/statuses/{sha}","languages_url":"https://api.github.com/repos/vrothberg/image/languages","stargazers_url":"https://api.github.com/repos/vrothberg/image/stargazers","contributors_url":"https://api.github.com/repos/vrothberg/image/contributors","subscribers_url":"https://api.github.com/repos/vrothberg/image/subscribers","subscription_url":"https://api.github.com/repos/vrothberg/image/subscription","commits_url":"https://api.github.com/repos/vrothberg/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrothberg/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrothberg/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrothberg/image/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrothberg/image/contents/{+path}","compare_url":"https://api.github.com/repos/vrothberg/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrothberg/image/merges","archive_url":"https://api.github.com/repos/vrothberg/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrothberg/image/downloads","issues_url":"https://api.github.com/repos/vrothberg/image/issues{/number}","pulls_url":"https://api.github.com/repos/vrothberg/image/pulls{/number}","milestones_url":"https://api.github.com/repos/vrothberg/image/milestones{/number}","notifications_url":"https://api.github.com/repos/vrothberg/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrothberg/image/labels{/name}","releases_url":"https://api.github.com/repos/vrothberg/image/releases{/id}","deployments_url":"https://api.github.com/repos/vrothberg/image/deployments","created_at":"2018-01-05T11:14:25Z","updated_at":"2019-02-16T11:37:52Z","pushed_at":"2019-03-22T12:52:41Z","git_url":"git://github.com/vrothberg/image.git","ssh_url":"git@github.com:vrothberg/image.git","clone_url":"https://github.com/vrothberg/image.git","svn_url":"https://github.com/vrothberg/image","homepage":"","size":4699,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containers:master","ref":"master","sha":"f52cf78ebfa1916da406f8b6210d8f7764ec1185","user":{"login":"containers","id":5874934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NzQ5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5874934?v=4","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"repo":{"id":61739430,"node_id":"MDEwOlJlcG9zaXRvcnk2MTczOTQzMA==","name":"image","full_name":"containers/image","private":false,"owner":{"login":"containers","id":5874934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NzQ5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5874934?v=4","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/containers/image","description":"Work with containers' images","fork":false,"url":"https://api.github.com/repos/containers/image","forks_url":"https://api.github.com/repos/containers/image/forks","keys_url":"https://api.github.com/repos/containers/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containers/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containers/image/teams","hooks_url":"https://api.github.com/repos/containers/image/hooks","issue_events_url":"https://api.github.com/repos/containers/image/issues/events{/number}","events_url":"https://api.github.com/repos/containers/image/events","assignees_url":"https://api.github.com/repos/containers/image/assignees{/user}","branches_url":"https://api.github.com/repos/containers/image/branches{/branch}","tags_url":"https://api.github.com/repos/containers/image/tags","blobs_url":"https://api.github.com/repos/containers/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containers/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containers/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/containers/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containers/image/statuses/{sha}","languages_url":"https://api.github.com/repos/containers/image/languages","stargazers_url":"https://api.github.com/repos/containers/image/stargazers","contributors_url":"https://api.github.com/repos/containers/image/contributors","subscribers_url":"https://api.github.com/repos/containers/image/subscribers","subscription_url":"https://api.github.com/repos/containers/image/subscription","commits_url":"https://api.github.com/repos/containers/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/containers/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/containers/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/containers/image/issues/comments{/number}","contents_url":"https://api.github.com/repos/containers/image/contents/{+path}","compare_url":"https://api.github.com/repos/containers/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containers/image/merges","archive_url":"https://api.github.com/repos/containers/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containers/image/downloads","issues_url":"https://api.github.com/repos/containers/image/issues{/number}","pulls_url":"https://api.github.com/repos/containers/image/pulls{/number}","milestones_url":"https://api.github.com/repos/containers/image/milestones{/number}","notifications_url":"https://api.github.com/repos/containers/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containers/image/labels{/name}","releases_url":"https://api.github.com/repos/containers/image/releases{/id}","deployments_url":"https://api.github.com/repos/containers/image/deployments","created_at":"2016-06-22T17:46:41Z","updated_at":"2019-03-21T20:26:23Z","pushed_at":"2019-03-22T12:52:43Z","git_url":"git://github.com/containers/image.git","ssh_url":"git@github.com:containers/image.git","clone_url":"https://github.com/containers/image.git","svn_url":"https://github.com/containers/image","homepage":"","size":4679,"stargazers_count":235,"watchers_count":235,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":108,"open_issues":79,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containers/image/pulls/607"},"html":{"href":"https://github.com/containers/image/pull/607"},"issue":{"href":"https://api.github.com/repos/containers/image/issues/607"},"comments":{"href":"https://api.github.com/repos/containers/image/issues/607/comments"},"review_comments":{"href":"https://api.github.com/repos/containers/image/pulls/607/comments"},"review_comment":{"href":"https://api.github.com/repos/containers/image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containers/image/pulls/607/commits"},"statuses":{"href":"https://api.github.com/repos/containers/image/statuses/071c9f98767c48db6141234b6af7618ec191b091"}},"author_association":"MEMBER"}}
|
{
"id": 61739430,
"name": "containers/image",
"url": "https://api.github.com/repos/containers/image"
}
|
{
"id": 11679875,
"login": "vrothberg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11679875?",
"url": "https://api.github.com/users/vrothberg"
}
|
{
"id": 5874934,
"login": "containers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5874934?",
"url": "https://api.github.com/orgs/containers"
}
| 2019-03-22T13:05:36 |
9295233153
|
{"actor":{"display_login":"vrothberg"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/containers/libpod/pulls/comments/316099488","pull_request_review_id":277684747,"id":316099488,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjA5OTQ4OA==","diff_hunk":"@@ -28,41 +31,66 @@ Set the systemd restart policy. The restart-policy must be one of: \"no\", \"on-su\n \"on-watchdog\", \"on-abort\", or \"always\". The default policy is *on-failure*.\n \n ## Examples\n-Create a systemd unit file for a container running nginx:\n \n+Create a systemd unit file for a container running nginx with an *always* restart policy and 1-second timeout on stdout.\n ```\n-$ sudo podman generate systemd nginx\n+$ podman create --name nginx nginx:latest\n+$ podman generate systemd --restart-policy=always -t 1 nginx\n+# container-de1e3223b1b888bc02d0962dd6cb5855eb00734061013ffdd3479d225abacdc6.service\n+# autogenerated by Podman 1.5.2\n+# Wed Aug 21 09:46:45 CEST 2019\n+\n [Unit]\n-Description=c21da63c4783be2ac2cd3487ef8d2ec15ee2a28f63dd8f145e3b05607f31cffc Podman Container\n+Description=Podman container-de1e3223b1b888bc02d0962dd6cb5855eb00734061013ffdd3479d225abacdc6.service\n+Documentation=man:podman-generate-systemd(1)\n+\n [Service]\n-Restart=on-failure\n-ExecStart=/usr/bin/podman start c21da63c4783be2ac2cd3487ef8d2ec15ee2a28f63dd8f145e3b05607f31cffc\n-ExecStop=/usr/bin/podman stop -t 10 c21da63c4783be2ac2cd3487ef8d2ec15ee2a28f63dd8f145e3b05607f31cffc\n+Restart=always\n+ExecStart=/home/valentin/go/src/github.com/containers/libpod/bin/podman start de1e3223b1b888bc02d0962dd6cb5855eb00734061013ffdd3479d225abacdc6","path":"docs/podman-generate-systemd.1.md","position":50,"original_position":50,"commit_id":"c0b9c16bebcc9066a5dd72c93d9620972eca97a6","original_commit_id":"c0b9c16bebcc9066a5dd72c93d9620972eca97a6","user":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"body":"Thanks for checking!","created_at":"2019-08-21T09:54:51Z","updated_at":"2019-08-21T09:54:51Z","html_url":"https://github.com/containers/libpod/pull/3800#discussion_r316099488","pull_request_url":"https://api.github.com/repos/containers/libpod/pulls/3800","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/containers/libpod/pulls/comments/316099488"},"html":{"href":"https://github.com/containers/libpod/pull/3800#discussion_r316099488"},"pull_request":{"href":"https://api.github.com/repos/containers/libpod/pulls/3800"}},"in_reply_to_id":316092782},"pull_request":{"url":"https://api.github.com/repos/containers/libpod/pulls/3800","id":306860252,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2ODYwMjUy","html_url":"https://github.com/containers/libpod/pull/3800","diff_url":"https://github.com/containers/libpod/pull/3800.diff","patch_url":"https://github.com/containers/libpod/pull/3800.patch","issue_url":"https://api.github.com/repos/containers/libpod/issues/3800","number":3800,"state":"open","locked":false,"title":"generate systemd pod","user":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"body":" generate systemd: support pods\r\n\r\nSupport generating systemd unit files for a pod. Podman generates one\r\nunit file for the pod including the PID file for the infra container's\r\nconmon process and one unit file for each container (excluding the infra\r\ncontainer).\r\n\r\nNote that this change implies refactorings in the `pkg/systemdgen` API.\r\n\r\nThe output of a simple pod with an alpine container looks as follows:\r\n```\r\n[Unit]\r\nDescription=5d85e91228e02b0fca3982e6db9a0458a381eeffca7951d06f415d6a6495fa29 Podman Pod\r\nDocumentation=man:podman-generate-systemd(1)\r\nRequires=container-63202b5664827c0922807cb62ea7ec5c931faabca2c730e5baa29f201bab3596.service\r\nBefore=container-63202b5664827c0922807cb62ea7ec5c931faabca2c730e5baa29f201bab3596.service\r\n\r\n[Service]\r\nRestart=on-failure\r\nExecStart=/home/valentin/go/src/github.com/containers/libpod/bin/podman pod start 5d85e91228e02b0fca3982e6db9a0458a381eeffca7951d06f415d6a6495fa29\r\nExecStop=/home/valentin/go/src/github.com/containers/libpod/bin/podman pod stop 5d85e91228e02b0fca3982e6db9a0458a381eeffca7951d06f415d6a6495fa29\r\nKillMode=none\r\nType=forking\r\nPIDFile=/tmp/1000/overlay-containers/ae2965240e1ed93064d7145373346d0461c9474215837d364b830bafc7106006/userdata/conmon.pid\r\n\r\n[Install]\r\nWantedBy=multi-user.target\r\n\r\n[Unit]\r\nDescription=63202b5664827c0922807cb62ea7ec5c931faabca2c730e5baa29f201bab3596 Podman Container\r\nDocumentation=man:podman-generate-systemd(1)\r\nPartOf=pod-5d85e91228e02b0fca3982e6db9a0458a381eeffca7951d06f415d6a6495fa29.service.service\r\n\r\n[Service]\r\nRestart=on-failure\r\nExecStart=/home/valentin/go/src/github.com/containers/libpod/bin/podman start 63202b5664827c0922807cb62ea7ec5c931faabca2c730e5baa29f201bab3596\r\nExecStop=/home/valentin/go/src/github.com/containers/libpod/bin/podman -t 10 63202b5664827c0922807cb62ea7ec5c931faabca2c730e5baa29f201bab3596\r\nKillMode=none\r\nType=forking\r\nPIDFile=/tmp/1000/overlay-containers/63202b5664827c0922807cb62ea7ec5c931faabca2c730e5baa29f201bab3596/userdata/conmon.pid\r\n\r\n[Install]\r\nWantedBy=multi-user.target\r\n```\r\n\r\nSigned-off-by: Valentin Rothberg <rothberg@redhat.com>","created_at":"2019-08-13T11:17:56Z","updated_at":"2019-08-21T09:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e9802419808844bf053546fba2c7f37bd8c0fa3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"umohnani8","id":29377163,"node_id":"MDQ6VXNlcjI5Mzc3MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1070348377,"node_id":"MDU6TGFiZWwxMDcwMzQ4Mzc3","url":"https://api.github.com/repos/containers/libpod/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1069163964,"node_id":"MDU6TGFiZWwxMDY5MTYzOTY0","url":"https://api.github.com/repos/containers/libpod/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/containers/libpod/pulls/3800/commits","review_comments_url":"https://api.github.com/repos/containers/libpod/pulls/3800/comments","review_comment_url":"https://api.github.com/repos/containers/libpod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containers/libpod/issues/3800/comments","statuses_url":"https://api.github.com/repos/containers/libpod/statuses/c0b9c16bebcc9066a5dd72c93d9620972eca97a6","head":{"label":"vrothberg:generate-pod","ref":"generate-pod","sha":"c0b9c16bebcc9066a5dd72c93d9620972eca97a6","user":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"repo":{"id":117082247,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwODIyNDc=","name":"libpod","full_name":"vrothberg/libpod","private":false,"owner":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vrothberg/libpod","description":"libpod is a library used to create container pods.","fork":true,"url":"https://api.github.com/repos/vrothberg/libpod","forks_url":"https://api.github.com/repos/vrothberg/libpod/forks","keys_url":"https://api.github.com/repos/vrothberg/libpod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrothberg/libpod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrothberg/libpod/teams","hooks_url":"https://api.github.com/repos/vrothberg/libpod/hooks","issue_events_url":"https://api.github.com/repos/vrothberg/libpod/issues/events{/number}","events_url":"https://api.github.com/repos/vrothberg/libpod/events","assignees_url":"https://api.github.com/repos/vrothberg/libpod/assignees{/user}","branches_url":"https://api.github.com/repos/vrothberg/libpod/branches{/branch}","tags_url":"https://api.github.com/repos/vrothberg/libpod/tags","blobs_url":"https://api.github.com/repos/vrothberg/libpod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrothberg/libpod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrothberg/libpod/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrothberg/libpod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrothberg/libpod/statuses/{sha}","languages_url":"https://api.github.com/repos/vrothberg/libpod/languages","stargazers_url":"https://api.github.com/repos/vrothberg/libpod/stargazers","contributors_url":"https://api.github.com/repos/vrothberg/libpod/contributors","subscribers_url":"https://api.github.com/repos/vrothberg/libpod/subscribers","subscription_url":"https://api.github.com/repos/vrothberg/libpod/subscription","commits_url":"https://api.github.com/repos/vrothberg/libpod/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrothberg/libpod/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrothberg/libpod/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrothberg/libpod/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrothberg/libpod/contents/{+path}","compare_url":"https://api.github.com/repos/vrothberg/libpod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrothberg/libpod/merges","archive_url":"https://api.github.com/repos/vrothberg/libpod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrothberg/libpod/downloads","issues_url":"https://api.github.com/repos/vrothberg/libpod/issues{/number}","pulls_url":"https://api.github.com/repos/vrothberg/libpod/pulls{/number}","milestones_url":"https://api.github.com/repos/vrothberg/libpod/milestones{/number}","notifications_url":"https://api.github.com/repos/vrothberg/libpod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrothberg/libpod/labels{/name}","releases_url":"https://api.github.com/repos/vrothberg/libpod/releases{/id}","deployments_url":"https://api.github.com/repos/vrothberg/libpod/deployments","created_at":"2018-01-11T09:57:36Z","updated_at":"2019-06-25T08:07:25Z","pushed_at":"2019-08-21T08:01:39Z","git_url":"git://github.com/vrothberg/libpod.git","ssh_url":"git@github.com:vrothberg/libpod.git","clone_url":"https://github.com/vrothberg/libpod.git","svn_url":"https://github.com/vrothberg/libpod","homepage":null,"size":27646,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containers:master","ref":"master","sha":"1ad8fe52412c8cef215e5a5af312e5db680c3916","user":{"login":"containers","id":5874934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NzQ5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5874934?v=4","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"repo":{"id":109145553,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkxNDU1NTM=","name":"libpod","full_name":"containers/libpod","private":false,"owner":{"login":"containers","id":5874934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NzQ5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5874934?v=4","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/containers/libpod","description":"libpod is a library used to create container pods. Home of Podman.","fork":false,"url":"https://api.github.com/repos/containers/libpod","forks_url":"https://api.github.com/repos/containers/libpod/forks","keys_url":"https://api.github.com/repos/containers/libpod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containers/libpod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containers/libpod/teams","hooks_url":"https://api.github.com/repos/containers/libpod/hooks","issue_events_url":"https://api.github.com/repos/containers/libpod/issues/events{/number}","events_url":"https://api.github.com/repos/containers/libpod/events","assignees_url":"https://api.github.com/repos/containers/libpod/assignees{/user}","branches_url":"https://api.github.com/repos/containers/libpod/branches{/branch}","tags_url":"https://api.github.com/repos/containers/libpod/tags","blobs_url":"https://api.github.com/repos/containers/libpod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containers/libpod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containers/libpod/git/refs{/sha}","trees_url":"https://api.github.com/repos/containers/libpod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containers/libpod/statuses/{sha}","languages_url":"https://api.github.com/repos/containers/libpod/languages","stargazers_url":"https://api.github.com/repos/containers/libpod/stargazers","contributors_url":"https://api.github.com/repos/containers/libpod/contributors","subscribers_url":"https://api.github.com/repos/containers/libpod/subscribers","subscription_url":"https://api.github.com/repos/containers/libpod/subscription","commits_url":"https://api.github.com/repos/containers/libpod/commits{/sha}","git_commits_url":"https://api.github.com/repos/containers/libpod/git/commits{/sha}","comments_url":"https://api.github.com/repos/containers/libpod/comments{/number}","issue_comment_url":"https://api.github.com/repos/containers/libpod/issues/comments{/number}","contents_url":"https://api.github.com/repos/containers/libpod/contents/{+path}","compare_url":"https://api.github.com/repos/containers/libpod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containers/libpod/merges","archive_url":"https://api.github.com/repos/containers/libpod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containers/libpod/downloads","issues_url":"https://api.github.com/repos/containers/libpod/issues{/number}","pulls_url":"https://api.github.com/repos/containers/libpod/pulls{/number}","milestones_url":"https://api.github.com/repos/containers/libpod/milestones{/number}","notifications_url":"https://api.github.com/repos/containers/libpod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containers/libpod/labels{/name}","releases_url":"https://api.github.com/repos/containers/libpod/releases{/id}","deployments_url":"https://api.github.com/repos/containers/libpod/deployments","created_at":"2017-11-01T15:01:27Z","updated_at":"2019-08-21T07:58:31Z","pushed_at":"2019-08-21T08:01:41Z","git_url":"git://github.com/containers/libpod.git","ssh_url":"git@github.com:containers/libpod.git","clone_url":"https://github.com/containers/libpod.git","svn_url":"https://github.com/containers/libpod","homepage":"","size":27736,"stargazers_count":2406,"watchers_count":2406,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":137,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":290,"open_issues":137,"watchers":2406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containers/libpod/pulls/3800"},"html":{"href":"https://github.com/containers/libpod/pull/3800"},"issue":{"href":"https://api.github.com/repos/containers/libpod/issues/3800"},"comments":{"href":"https://api.github.com/repos/containers/libpod/issues/3800/comments"},"review_comments":{"href":"https://api.github.com/repos/containers/libpod/pulls/3800/comments"},"review_comment":{"href":"https://api.github.com/repos/containers/libpod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containers/libpod/pulls/3800/commits"},"statuses":{"href":"https://api.github.com/repos/containers/libpod/statuses/c0b9c16bebcc9066a5dd72c93d9620972eca97a6"}},"author_association":"MEMBER"}}
|
{
"id": 109145553,
"name": "containers/libpod",
"url": "https://api.github.com/repos/containers/libpod"
}
|
{
"id": 11679875,
"login": "vrothberg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11679875?",
"url": "https://api.github.com/users/vrothberg"
}
|
{
"id": 5874934,
"login": "containers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5874934?",
"url": "https://api.github.com/orgs/containers"
}
| 2019-08-21T09:54:51 |
10252867586
|
{"actor":{"display_login":"vrothberg"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/302275161","pull_request_review_id":260360822,"id":302275161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjI3NTE2MQ==","diff_hunk":"@@ -121,9 +152,21 @@ public void SynchronizeProxy(StorageProxy storageProxy, Consumer<PortableJson> c\n postMessage(message);\n }\n \n+ @Override\n+ public void Render(NativeParticle particle, String slotName, PortableJson content) {\n+ PortableJson message = jsonParser.parse(\"{}\");\n+ message.put(MESSAGE_TYPE_FIELD, RENDER_MSG);\n+ PortableJson body = jsonParser.parse(\"{}\");\n+ body.put(PARTICLE_FIELD, mapper.identifierForThing(new Thing<NativeParticle>(particle)));\n+ body.put(SLOT_NAME_FIELD, slotName);\n+ body.put(CONTENT_FIELD, content);\n+ message.put(MESSAGE_BODY_FIELD, body);\n+ postMessage(message);\n+ }\n+\n private void postMessage(PortableJson message) {\n- // TODO: add support for PEC messages in pipes-shell-2 bus.\n- // message.put(MESSAGE_PEC_ID_FIELD, this.id);\n- // shellApi.postMessage(jsonParser.stringify(message));\n+ environment.sendMessageToArcs(\n+ \"{\\\"message\\\": \\\"pec\\\", \\\"id\\\": \\\"\" + this.id +","path":"src/javaharness/java/arcs/api/PECInnerPortImpl.java","position":null,"original_position":118,"commit_id":"39938db496bef6797c39abc1fe99c31e6daebfc7","original_commit_id":"6ce6642e8af1e4d82e905197d9fe807428da8a3f","user":{"login":"yuangu-google","id":27301600,"node_id":"MDQ6VXNlcjI3MzAxNjAw","avatar_url":"https://avatars3.githubusercontent.com/u/27301600?v=4","gravatar_id":"","url":"https://api.github.com/users/yuangu-google","html_url":"https://github.com/yuangu-google","followers_url":"https://api.github.com/users/yuangu-google/followers","following_url":"https://api.github.com/users/yuangu-google/following{/other_user}","gists_url":"https://api.github.com/users/yuangu-google/gists{/gist_id}","starred_url":"https://api.github.com/users/yuangu-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuangu-google/subscriptions","organizations_url":"https://api.github.com/users/yuangu-google/orgs","repos_url":"https://api.github.com/users/yuangu-google/repos","events_url":"https://api.github.com/users/yuangu-google/events{/privacy}","received_events_url":"https://api.github.com/users/yuangu-google/received_events","type":"User","site_admin":false},"body":"Hmm, at this moment I am not sure what fields would be used in the message. So maybe we can wait until we have more insights on the shared part of the messages contents.","created_at":"2019-07-10T21:14:54Z","updated_at":"2019-07-10T21:14:55Z","html_url":"https://github.com/PolymerLabs/arcs/pull/3306#discussion_r302275161","pull_request_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/3306","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/302275161"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/3306#discussion_r302275161"},"pull_request":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/3306"}},"in_reply_to_id":301891007},"pull_request":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/3306","id":295922884,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1OTIyODg0","html_url":"https://github.com/PolymerLabs/arcs/pull/3306","diff_url":"https://github.com/PolymerLabs/arcs/pull/3306.diff","patch_url":"https://github.com/PolymerLabs/arcs/pull/3306.patch","issue_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/3306","number":3306,"state":"closed","locked":false,"title":"Basic particle rendering APIs","user":{"login":"mmandlis","id":25067830,"node_id":"MDQ6VXNlcjI1MDY3ODMw","avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"body":"still lots of missing pieces shortcuts with regards to crdts, data model and updates, but getting closer to the primitive e2e demo i showed yesterday.\r\n\r\nthe code of the sample particle i was using:\r\n```\r\npublic class EchoParticle extends NativeParticleImpl {\r\n private PortableJson entity = null;\r\n\r\n @Override\r\n public void onHandleSync(Handle handle, PortableJson model) {\r\n super.onHandleSync(handle, model);\r\n updateEntity();\r\n }\r\n\r\n @Override\r\n public void onHandleUpdate(Handle handle, PortableJson data) {\r\n super.onHandleUpdate(handle, data);\r\n updateEntity();\r\n }\r\n\r\n private void updateEntity() {\r\n Handle handle = this.handles.get(\"recentEntities\");\r\n if (entity == null) {\r\n PortableJson entities = ((CollectionProxy) handle.storage).toList();\r\n for (int i = entities == null ? -1 : entities.getLength() - 1; i >= 0; --i) {\r\n PortableJson rawData = entities.getObject(i).getObject(\"value\").getObject(\"rawData\");\r\n if (rawData.getString(\"type\") == \"artist\") {\r\n entity = rawData;\r\n break;\r\n }\r\n }\r\n }\r\n renderSlot(\"content\", Arrays.asList(\"model\"));\r\n }\r\n\r\n @Override\r\n public boolean shouldRender(String slotName) {\r\n return entity != null;\r\n }\r\n\r\n @Override\r\n public String getTemplate(String slotName) {\r\n return \"<span style='border:1px solid red'><span>{{name}}</span><span style='color: grey; font-style: italic; font-size: 13px;'> (from <span>{{source}}</span>)</span></span>\";\r\n }\r\n\r\n @Override\r\n public String getModel() {\r\n return \"{\\\"name\\\": \\\"\" + (entity == null ? \"unknown\" : entity.getString(\"name\")) +\r\n \"\\\", \\\"source\\\": \\\"\" + (entity == null ? \"unknown\" : entity.getString(\"source\")) +\"\\\"}\";\r\n }\r\n```","created_at":"2019-07-09T21:17:27Z","updated_at":"2019-07-10T21:14:55Z","closed_at":"2019-07-10T17:26:34Z","merged_at":"2019-07-10T17:26:34Z","merge_commit_sha":"5acf17e9478981736feec62d71a02766dd969a3f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yuangu-google","id":27301600,"node_id":"MDQ6VXNlcjI3MzAxNjAw","avatar_url":"https://avatars3.githubusercontent.com/u/27301600?v=4","gravatar_id":"","url":"https://api.github.com/users/yuangu-google","html_url":"https://github.com/yuangu-google","followers_url":"https://api.github.com/users/yuangu-google/followers","following_url":"https://api.github.com/users/yuangu-google/following{/other_user}","gists_url":"https://api.github.com/users/yuangu-google/gists{/gist_id}","starred_url":"https://api.github.com/users/yuangu-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuangu-google/subscriptions","organizations_url":"https://api.github.com/users/yuangu-google/orgs","repos_url":"https://api.github.com/users/yuangu-google/repos","events_url":"https://api.github.com/users/yuangu-google/events{/privacy}","received_events_url":"https://api.github.com/users/yuangu-google/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/3306/commits","review_comments_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/3306/comments","review_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/3306/comments","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/39938db496bef6797c39abc1fe99c31e6daebfc7","head":{"label":"mmandlis:javapec-particle-render-pr","ref":"javapec-particle-render-pr","sha":"39938db496bef6797c39abc1fe99c31e6daebfc7","user":{"login":"mmandlis","id":25067830,"node_id":"MDQ6VXNlcjI1MDY3ODMw","avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"repo":{"id":156921642,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5MjE2NDI=","name":"arcs-1","full_name":"mmandlis/arcs-1","private":false,"owner":{"login":"mmandlis","id":25067830,"node_id":"MDQ6VXNlcjI1MDY3ODMw","avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mmandlis/arcs-1","description":"Arcs","fork":true,"url":"https://api.github.com/repos/mmandlis/arcs-1","forks_url":"https://api.github.com/repos/mmandlis/arcs-1/forks","keys_url":"https://api.github.com/repos/mmandlis/arcs-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmandlis/arcs-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmandlis/arcs-1/teams","hooks_url":"https://api.github.com/repos/mmandlis/arcs-1/hooks","issue_events_url":"https://api.github.com/repos/mmandlis/arcs-1/issues/events{/number}","events_url":"https://api.github.com/repos/mmandlis/arcs-1/events","assignees_url":"https://api.github.com/repos/mmandlis/arcs-1/assignees{/user}","branches_url":"https://api.github.com/repos/mmandlis/arcs-1/branches{/branch}","tags_url":"https://api.github.com/repos/mmandlis/arcs-1/tags","blobs_url":"https://api.github.com/repos/mmandlis/arcs-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmandlis/arcs-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmandlis/arcs-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmandlis/arcs-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmandlis/arcs-1/statuses/{sha}","languages_url":"https://api.github.com/repos/mmandlis/arcs-1/languages","stargazers_url":"https://api.github.com/repos/mmandlis/arcs-1/stargazers","contributors_url":"https://api.github.com/repos/mmandlis/arcs-1/contributors","subscribers_url":"https://api.github.com/repos/mmandlis/arcs-1/subscribers","subscription_url":"https://api.github.com/repos/mmandlis/arcs-1/subscription","commits_url":"https://api.github.com/repos/mmandlis/arcs-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmandlis/arcs-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmandlis/arcs-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmandlis/arcs-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmandlis/arcs-1/contents/{+path}","compare_url":"https://api.github.com/repos/mmandlis/arcs-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmandlis/arcs-1/merges","archive_url":"https://api.github.com/repos/mmandlis/arcs-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmandlis/arcs-1/downloads","issues_url":"https://api.github.com/repos/mmandlis/arcs-1/issues{/number}","pulls_url":"https://api.github.com/repos/mmandlis/arcs-1/pulls{/number}","milestones_url":"https://api.github.com/repos/mmandlis/arcs-1/milestones{/number}","notifications_url":"https://api.github.com/repos/mmandlis/arcs-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmandlis/arcs-1/labels{/name}","releases_url":"https://api.github.com/repos/mmandlis/arcs-1/releases{/id}","deployments_url":"https://api.github.com/repos/mmandlis/arcs-1/deployments","created_at":"2018-11-09T21:46:48Z","updated_at":"2018-12-07T17:33:55Z","pushed_at":"2019-07-10T20:45:57Z","git_url":"git://github.com/mmandlis/arcs-1.git","ssh_url":"git@github.com:mmandlis/arcs-1.git","clone_url":"https://github.com/mmandlis/arcs-1.git","svn_url":"https://github.com/mmandlis/arcs-1","homepage":"","size":63706,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerLabs:master","ref":"master","sha":"0aa47385624208afbfb9fb97f6e55a9abd9b3b4c","user":{"login":"PolymerLabs","id":5912903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTI5MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":80783122,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc4MzEyMg==","name":"arcs","full_name":"PolymerLabs/arcs","private":false,"owner":{"login":"PolymerLabs","id":5912903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTI5MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolymerLabs/arcs","description":"Arcs","fork":false,"url":"https://api.github.com/repos/PolymerLabs/arcs","forks_url":"https://api.github.com/repos/PolymerLabs/arcs/forks","keys_url":"https://api.github.com/repos/PolymerLabs/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/arcs/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/arcs/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/arcs/events","assignees_url":"https://api.github.com/repos/PolymerLabs/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/arcs/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/arcs/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/arcs/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/arcs/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/arcs/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/arcs/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/arcs/merges","archive_url":"https://api.github.com/repos/PolymerLabs/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/arcs/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/arcs/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerLabs/arcs/deployments","created_at":"2017-02-03T00:32:19Z","updated_at":"2019-07-10T20:02:38Z","pushed_at":"2019-07-10T20:02:33Z","git_url":"git://github.com/PolymerLabs/arcs.git","ssh_url":"git@github.com:PolymerLabs/arcs.git","clone_url":"https://github.com/PolymerLabs/arcs.git","svn_url":"https://github.com/PolymerLabs/arcs","homepage":"","size":63775,"stargazers_count":41,"watchers_count":41,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":237,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":237,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/3306"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/3306"},"issue":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/3306"},"comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/3306/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/3306/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/3306/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerLabs/arcs/statuses/39938db496bef6797c39abc1fe99c31e6daebfc7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 80783122,
"name": "PolymerLabs/arcs",
"url": "https://api.github.com/repos/PolymerLabs/arcs"
}
|
{
"id": 27301600,
"login": "yuangu-google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27301600?",
"url": "https://api.github.com/users/yuangu-google"
}
|
{
"id": 5912903,
"login": "PolymerLabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5912903?",
"url": "https://api.github.com/orgs/PolymerLabs"
}
| 2019-07-10T21:14:54 |
9987260224
|
{"actor":{"display_login":"yuangu-google"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/heetch/flamingo/pulls/comments/344170412","pull_request_review_id":314190381,"id":344170412,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDE3MDQxMg==","diff_hunk":"@@ -0,0 +1,130 @@\n+import React, { useState } from 'react';\n+import PropTypes from 'prop-types';\n+import cx from 'classnames';\n+import ReactSelect from 'react-select';\n+import Icon from '../Icon';\n+import UiText from '../UiText';\n+import { safeInvoke } from '../../utils';\n+\n+const customStyles = {\n+ control: () => ({\n+ border: 0,\n+ backgroundColor: 'transparent',\n+ minHeight: 'initial',\n+ display: 'flex',\n+ justifyContent: 'space-between',\n+ }),\n+ indicatorSeparator: provided => ({\n+ ...provided,\n+ display: 'none',\n+ }),\n+ indicatorContainer: provided => ({\n+ ...provided,\n+ marginRight: '1rem',\n+ padding: 0,\n+ }),\n+ valueContainer: provided => ({\n+ ...provided,\n+ padding: 0,\n+ marginLeft: '1rem',\n+ minHeight: 38,\n+ }),\n+};\n+\n+const CustomDropdownIndicator = ({ innerRef, innerProps }) => (\n+ <Icon\n+ ref={innerRef}\n+ {...innerProps}\n+ icon={Icon.ICONS.IconChevronUpDown}\n+ className='f-FormEl-icon'\n+ size={Icon.SIZES.L}\n+ />\n+);\n+\n+const CustomSingleValue = ({ children }) => (\n+ <UiText as='span' type={UiText.VARIANTS.content}>\n+ {children}\n+ </UiText>\n+);\n+\n+const buildCustomOption = (onChange, isSelectable) => ({\n+ data,\n+ innerProps,\n+ isFocused,\n+ setValue,\n+}) => ({\n+ ...data.labelComponent,\n+ props: {\n+ ...innerProps,\n+ ...data.labelComponent.props,\n+ focused: isFocused,\n+ onClick: e => {\n+ safeInvoke(onChange, data.value);\n+ safeInvoke(data.labelComponent.props.onClick, e);\n+ isSelectable ? innerProps.onClick(e) : setValue(null);\n+ },\n+ },\n+});\n+\n+const parseListItemObjectsIntoOptionObjects = objects =>\n+ [].concat(objects).map(object => ({\n+ label: object.props.children,\n+ value: object.props.optionValue || object.props.children,\n+ labelComponent: object,\n+ }));\n+\n+const Dropdown = React.forwardRef(\n+ (\n+ { className, onChange, children, placeholder, isSelectable, ...props },","path":"packages/react/src/components/Dropdown/index.js","position":78,"original_position":78,"commit_id":"541c0b806f6767e594e724b04827efbd9d723fa3","original_commit_id":"541c0b806f6767e594e724b04827efbd9d723fa3","user":{"login":"ugogo","id":5040476,"node_id":"MDQ6VXNlcjUwNDA0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5040476?v=4","gravatar_id":"","url":"https://api.github.com/users/ugogo","html_url":"https://github.com/ugogo","followers_url":"https://api.github.com/users/ugogo/followers","following_url":"https://api.github.com/users/ugogo/following{/other_user}","gists_url":"https://api.github.com/users/ugogo/gists{/gist_id}","starred_url":"https://api.github.com/users/ugogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ugogo/subscriptions","organizations_url":"https://api.github.com/users/ugogo/orgs","repos_url":"https://api.github.com/users/ugogo/repos","events_url":"https://api.github.com/users/ugogo/events{/privacy}","received_events_url":"https://api.github.com/users/ugogo/received_events","type":"User","site_admin":false},"body":"Can an option not be selectable?","created_at":"2019-11-08T13:23:01Z","updated_at":"2019-11-08T13:35:56Z","html_url":"https://github.com/heetch/flamingo/pull/77#discussion_r344170412","pull_request_url":"https://api.github.com/repos/heetch/flamingo/pulls/77","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/heetch/flamingo/pulls/comments/344170412"},"html":{"href":"https://github.com/heetch/flamingo/pull/77#discussion_r344170412"},"pull_request":{"href":"https://api.github.com/repos/heetch/flamingo/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/heetch/flamingo/pulls/77","id":338154762,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4MTU0NzYy","html_url":"https://github.com/heetch/flamingo/pull/77","diff_url":"https://github.com/heetch/flamingo/pull/77.diff","patch_url":"https://github.com/heetch/flamingo/pull/77.patch","issue_url":"https://api.github.com/repos/heetch/flamingo/issues/77","number":77,"state":"open","locked":false,"title":"Feature/component/rich select","user":{"login":"pppemo","id":15340486,"node_id":"MDQ6VXNlcjE1MzQwNDg2","avatar_url":"https://avatars0.githubusercontent.com/u/15340486?v=4","gravatar_id":"","url":"https://api.github.com/users/pppemo","html_url":"https://github.com/pppemo","followers_url":"https://api.github.com/users/pppemo/followers","following_url":"https://api.github.com/users/pppemo/following{/other_user}","gists_url":"https://api.github.com/users/pppemo/gists{/gist_id}","starred_url":"https://api.github.com/users/pppemo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pppemo/subscriptions","organizations_url":"https://api.github.com/users/pppemo/orgs","repos_url":"https://api.github.com/users/pppemo/repos","events_url":"https://api.github.com/users/pppemo/events{/privacy}","received_events_url":"https://api.github.com/users/pppemo/received_events","type":"User","site_admin":false},"body":"@ugogo I've only got the Readme pending, but it's now good for review","created_at":"2019-11-07T17:25:12Z","updated_at":"2019-11-08T13:35:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2eb7c10d8fbf88e0d168833c96e31b2630a021b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heetch/flamingo/pulls/77/commits","review_comments_url":"https://api.github.com/repos/heetch/flamingo/pulls/77/comments","review_comment_url":"https://api.github.com/repos/heetch/flamingo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heetch/flamingo/issues/77/comments","statuses_url":"https://api.github.com/repos/heetch/flamingo/statuses/541c0b806f6767e594e724b04827efbd9d723fa3","head":{"label":"heetch:feature/component/rich-select","ref":"feature/component/rich-select","sha":"541c0b806f6767e594e724b04827efbd9d723fa3","user":{"login":"heetch","id":5992314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTIzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5992314?v=4","gravatar_id":"","url":"https://api.github.com/users/heetch","html_url":"https://github.com/heetch","followers_url":"https://api.github.com/users/heetch/followers","following_url":"https://api.github.com/users/heetch/following{/other_user}","gists_url":"https://api.github.com/users/heetch/gists{/gist_id}","starred_url":"https://api.github.com/users/heetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heetch/subscriptions","organizations_url":"https://api.github.com/users/heetch/orgs","repos_url":"https://api.github.com/users/heetch/repos","events_url":"https://api.github.com/users/heetch/events{/privacy}","received_events_url":"https://api.github.com/users/heetch/received_events","type":"Organization","site_admin":false},"repo":{"id":153104904,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMxMDQ5MDQ=","name":"flamingo","full_name":"heetch/flamingo","private":false,"owner":{"login":"heetch","id":5992314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTIzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5992314?v=4","gravatar_id":"","url":"https://api.github.com/users/heetch","html_url":"https://github.com/heetch","followers_url":"https://api.github.com/users/heetch/followers","following_url":"https://api.github.com/users/heetch/following{/other_user}","gists_url":"https://api.github.com/users/heetch/gists{/gist_id}","starred_url":"https://api.github.com/users/heetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heetch/subscriptions","organizations_url":"https://api.github.com/users/heetch/orgs","repos_url":"https://api.github.com/users/heetch/repos","events_url":"https://api.github.com/users/heetch/events{/privacy}","received_events_url":"https://api.github.com/users/heetch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heetch/flamingo","description":"React Components Library","fork":false,"url":"https://api.github.com/repos/heetch/flamingo","forks_url":"https://api.github.com/repos/heetch/flamingo/forks","keys_url":"https://api.github.com/repos/heetch/flamingo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heetch/flamingo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heetch/flamingo/teams","hooks_url":"https://api.github.com/repos/heetch/flamingo/hooks","issue_events_url":"https://api.github.com/repos/heetch/flamingo/issues/events{/number}","events_url":"https://api.github.com/repos/heetch/flamingo/events","assignees_url":"https://api.github.com/repos/heetch/flamingo/assignees{/user}","branches_url":"https://api.github.com/repos/heetch/flamingo/branches{/branch}","tags_url":"https://api.github.com/repos/heetch/flamingo/tags","blobs_url":"https://api.github.com/repos/heetch/flamingo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heetch/flamingo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heetch/flamingo/git/refs{/sha}","trees_url":"https://api.github.com/repos/heetch/flamingo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heetch/flamingo/statuses/{sha}","languages_url":"https://api.github.com/repos/heetch/flamingo/languages","stargazers_url":"https://api.github.com/repos/heetch/flamingo/stargazers","contributors_url":"https://api.github.com/repos/heetch/flamingo/contributors","subscribers_url":"https://api.github.com/repos/heetch/flamingo/subscribers","subscription_url":"https://api.github.com/repos/heetch/flamingo/subscription","commits_url":"https://api.github.com/repos/heetch/flamingo/commits{/sha}","git_commits_url":"https://api.github.com/repos/heetch/flamingo/git/commits{/sha}","comments_url":"https://api.github.com/repos/heetch/flamingo/comments{/number}","issue_comment_url":"https://api.github.com/repos/heetch/flamingo/issues/comments{/number}","contents_url":"https://api.github.com/repos/heetch/flamingo/contents/{+path}","compare_url":"https://api.github.com/repos/heetch/flamingo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heetch/flamingo/merges","archive_url":"https://api.github.com/repos/heetch/flamingo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heetch/flamingo/downloads","issues_url":"https://api.github.com/repos/heetch/flamingo/issues{/number}","pulls_url":"https://api.github.com/repos/heetch/flamingo/pulls{/number}","milestones_url":"https://api.github.com/repos/heetch/flamingo/milestones{/number}","notifications_url":"https://api.github.com/repos/heetch/flamingo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heetch/flamingo/labels{/name}","releases_url":"https://api.github.com/repos/heetch/flamingo/releases{/id}","deployments_url":"https://api.github.com/repos/heetch/flamingo/deployments","created_at":"2018-10-15T11:57:28Z","updated_at":"2019-11-08T12:43:56Z","pushed_at":"2019-11-08T12:47:59Z","git_url":"git://github.com/heetch/flamingo.git","ssh_url":"git@github.com:heetch/flamingo.git","clone_url":"https://github.com/heetch/flamingo.git","svn_url":"https://github.com/heetch/flamingo","homepage":"https://flamingo.heetch-eng.now.sh","size":1772,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"base":{"label":"heetch:master","ref":"master","sha":"1919988683326f21a099908636b1988c53746aa5","user":{"login":"heetch","id":5992314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTIzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5992314?v=4","gravatar_id":"","url":"https://api.github.com/users/heetch","html_url":"https://github.com/heetch","followers_url":"https://api.github.com/users/heetch/followers","following_url":"https://api.github.com/users/heetch/following{/other_user}","gists_url":"https://api.github.com/users/heetch/gists{/gist_id}","starred_url":"https://api.github.com/users/heetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heetch/subscriptions","organizations_url":"https://api.github.com/users/heetch/orgs","repos_url":"https://api.github.com/users/heetch/repos","events_url":"https://api.github.com/users/heetch/events{/privacy}","received_events_url":"https://api.github.com/users/heetch/received_events","type":"Organization","site_admin":false},"repo":{"id":153104904,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMxMDQ5MDQ=","name":"flamingo","full_name":"heetch/flamingo","private":false,"owner":{"login":"heetch","id":5992314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTIzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5992314?v=4","gravatar_id":"","url":"https://api.github.com/users/heetch","html_url":"https://github.com/heetch","followers_url":"https://api.github.com/users/heetch/followers","following_url":"https://api.github.com/users/heetch/following{/other_user}","gists_url":"https://api.github.com/users/heetch/gists{/gist_id}","starred_url":"https://api.github.com/users/heetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heetch/subscriptions","organizations_url":"https://api.github.com/users/heetch/orgs","repos_url":"https://api.github.com/users/heetch/repos","events_url":"https://api.github.com/users/heetch/events{/privacy}","received_events_url":"https://api.github.com/users/heetch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heetch/flamingo","description":"React Components Library","fork":false,"url":"https://api.github.com/repos/heetch/flamingo","forks_url":"https://api.github.com/repos/heetch/flamingo/forks","keys_url":"https://api.github.com/repos/heetch/flamingo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heetch/flamingo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heetch/flamingo/teams","hooks_url":"https://api.github.com/repos/heetch/flamingo/hooks","issue_events_url":"https://api.github.com/repos/heetch/flamingo/issues/events{/number}","events_url":"https://api.github.com/repos/heetch/flamingo/events","assignees_url":"https://api.github.com/repos/heetch/flamingo/assignees{/user}","branches_url":"https://api.github.com/repos/heetch/flamingo/branches{/branch}","tags_url":"https://api.github.com/repos/heetch/flamingo/tags","blobs_url":"https://api.github.com/repos/heetch/flamingo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heetch/flamingo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heetch/flamingo/git/refs{/sha}","trees_url":"https://api.github.com/repos/heetch/flamingo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heetch/flamingo/statuses/{sha}","languages_url":"https://api.github.com/repos/heetch/flamingo/languages","stargazers_url":"https://api.github.com/repos/heetch/flamingo/stargazers","contributors_url":"https://api.github.com/repos/heetch/flamingo/contributors","subscribers_url":"https://api.github.com/repos/heetch/flamingo/subscribers","subscription_url":"https://api.github.com/repos/heetch/flamingo/subscription","commits_url":"https://api.github.com/repos/heetch/flamingo/commits{/sha}","git_commits_url":"https://api.github.com/repos/heetch/flamingo/git/commits{/sha}","comments_url":"https://api.github.com/repos/heetch/flamingo/comments{/number}","issue_comment_url":"https://api.github.com/repos/heetch/flamingo/issues/comments{/number}","contents_url":"https://api.github.com/repos/heetch/flamingo/contents/{+path}","compare_url":"https://api.github.com/repos/heetch/flamingo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heetch/flamingo/merges","archive_url":"https://api.github.com/repos/heetch/flamingo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heetch/flamingo/downloads","issues_url":"https://api.github.com/repos/heetch/flamingo/issues{/number}","pulls_url":"https://api.github.com/repos/heetch/flamingo/pulls{/number}","milestones_url":"https://api.github.com/repos/heetch/flamingo/milestones{/number}","notifications_url":"https://api.github.com/repos/heetch/flamingo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heetch/flamingo/labels{/name}","releases_url":"https://api.github.com/repos/heetch/flamingo/releases{/id}","deployments_url":"https://api.github.com/repos/heetch/flamingo/deployments","created_at":"2018-10-15T11:57:28Z","updated_at":"2019-11-08T12:43:56Z","pushed_at":"2019-11-08T12:47:59Z","git_url":"git://github.com/heetch/flamingo.git","ssh_url":"git@github.com:heetch/flamingo.git","clone_url":"https://github.com/heetch/flamingo.git","svn_url":"https://github.com/heetch/flamingo","homepage":"https://flamingo.heetch-eng.now.sh","size":1772,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heetch/flamingo/pulls/77"},"html":{"href":"https://github.com/heetch/flamingo/pull/77"},"issue":{"href":"https://api.github.com/repos/heetch/flamingo/issues/77"},"comments":{"href":"https://api.github.com/repos/heetch/flamingo/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/heetch/flamingo/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/heetch/flamingo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heetch/flamingo/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/heetch/flamingo/statuses/541c0b806f6767e594e724b04827efbd9d723fa3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 153104904,
"name": "heetch/flamingo",
"url": "https://api.github.com/repos/heetch/flamingo"
}
|
{
"id": 5040476,
"login": "ugogo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5040476?",
"url": "https://api.github.com/users/ugogo"
}
|
{
"id": 5992314,
"login": "heetch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5992314?",
"url": "https://api.github.com/orgs/heetch"
}
| 2019-11-08T13:23:01 |
10819061645
|
{"actor":{"display_login":"ugogo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/comments/334446439","pull_request_review_id":301258922,"id":334446439,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDQ0NjQzOQ==","diff_hunk":"@@ -0,0 +1,52 @@\n+var versions;\n+\n+if (window.location.hostname === 'assets.ctl.io') {\n+ var xmlhttp = new XMLHttpRequest();\n+\n+ xmlhttp.onreadystatechange = function() {\n+ if (xmlhttp.readyState == XMLHttpRequest.DONE) {\n+ if (xmlhttp.status == 200) {\n+ versions = JSON.parse(xmlhttp.responseText);\n+ if (localStorage.getItem(\"chiVersions\") !== JSON.stringify(versions)) {\n+ localStorage.setItem(\"chiVersions\", JSON.stringify(versions));\n+ checkChiCurrentVersion(versions[0]);\n+ }\n+ }\n+ }\n+ };\n+\n+ xmlhttp.open(\"GET\", \"https://assets.ctl.io/chi/versions.json\", true);\n+ xmlhttp.send();\n+}\n+\n+function fillDropdown() {\n+ var drop = document.getElementById('versionDropdown');\n+ \n+ while (drop.childNodes.length > 0) {\n+ drop.removeChild(drop.firstChild);\n+ }\n+\n+ for (let version in versions) {","path":"src/website/assets/scripts/chiVersionCheck.js","position":29,"original_position":29,"commit_id":"35578b2971438233dbab6a44e39b501cfbed2d56","original_commit_id":"35578b2971438233dbab6a44e39b501cfbed2d56","user":{"login":"dani-cl-madrid","id":43439749,"node_id":"MDQ6VXNlcjQzNDM5NzQ5","avatar_url":"https://avatars3.githubusercontent.com/u/43439749?v=4","gravatar_id":"","url":"https://api.github.com/users/dani-cl-madrid","html_url":"https://github.com/dani-cl-madrid","followers_url":"https://api.github.com/users/dani-cl-madrid/followers","following_url":"https://api.github.com/users/dani-cl-madrid/following{/other_user}","gists_url":"https://api.github.com/users/dani-cl-madrid/gists{/gist_id}","starred_url":"https://api.github.com/users/dani-cl-madrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dani-cl-madrid/subscriptions","organizations_url":"https://api.github.com/users/dani-cl-madrid/orgs","repos_url":"https://api.github.com/users/dani-cl-madrid/repos","events_url":"https://api.github.com/users/dani-cl-madrid/events{/privacy}","received_events_url":"https://api.github.com/users/dani-cl-madrid/received_events","type":"User","site_admin":false},"body":"Please don't use ES6 code in this files (let)","created_at":"2019-10-14T12:00:02Z","updated_at":"2019-10-14T12:08:26Z","html_url":"https://github.com/CenturyLinkCloud/ux-chi/pull/389#discussion_r334446439","pull_request_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/389","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/comments/334446439"},"html":{"href":"https://github.com/CenturyLinkCloud/ux-chi/pull/389#discussion_r334446439"},"pull_request":{"href":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/389","id":324737818,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0NzM3ODE4","html_url":"https://github.com/CenturyLinkCloud/ux-chi/pull/389","diff_url":"https://github.com/CenturyLinkCloud/ux-chi/pull/389.diff","patch_url":"https://github.com/CenturyLinkCloud/ux-chi/pull/389.patch","issue_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/issues/389","number":389,"state":"open","locked":false,"title":"[CHI-381] Improved behaviour of new version alert banner of header","user":{"login":"janibolkvadze","id":25136131,"node_id":"MDQ6VXNlcjI1MTM2MTMx","avatar_url":"https://avatars3.githubusercontent.com/u/25136131?v=4","gravatar_id":"","url":"https://api.github.com/users/janibolkvadze","html_url":"https://github.com/janibolkvadze","followers_url":"https://api.github.com/users/janibolkvadze/followers","following_url":"https://api.github.com/users/janibolkvadze/following{/other_user}","gists_url":"https://api.github.com/users/janibolkvadze/gists{/gist_id}","starred_url":"https://api.github.com/users/janibolkvadze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janibolkvadze/subscriptions","organizations_url":"https://api.github.com/users/janibolkvadze/orgs","repos_url":"https://api.github.com/users/janibolkvadze/repos","events_url":"https://api.github.com/users/janibolkvadze/events{/privacy}","received_events_url":"https://api.github.com/users/janibolkvadze/received_events","type":"User","site_admin":false},"body":"@jllr @mattnickles @dani-cl-madrid @SergioQCL \r\n\r\nhttps://ctl.atlassian.net/browse/CHI-381","created_at":"2019-10-04T15:36:30Z","updated_at":"2019-10-14T12:08:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e173c89eb9515adabdfe7236a3b7866bfd70b757","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/389/commits","review_comments_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/389/comments","review_comment_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/issues/389/comments","statuses_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/statuses/35578b2971438233dbab6a44e39b501cfbed2d56","head":{"label":"janibolkvadze:fix/CHI-381-Improve-behavior-in-header-banner-to-old-versions-of-Chi","ref":"fix/CHI-381-Improve-behavior-in-header-banner-to-old-versions-of-Chi","sha":"35578b2971438233dbab6a44e39b501cfbed2d56","user":{"login":"janibolkvadze","id":25136131,"node_id":"MDQ6VXNlcjI1MTM2MTMx","avatar_url":"https://avatars3.githubusercontent.com/u/25136131?v=4","gravatar_id":"","url":"https://api.github.com/users/janibolkvadze","html_url":"https://github.com/janibolkvadze","followers_url":"https://api.github.com/users/janibolkvadze/followers","following_url":"https://api.github.com/users/janibolkvadze/following{/other_user}","gists_url":"https://api.github.com/users/janibolkvadze/gists{/gist_id}","starred_url":"https://api.github.com/users/janibolkvadze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janibolkvadze/subscriptions","organizations_url":"https://api.github.com/users/janibolkvadze/orgs","repos_url":"https://api.github.com/users/janibolkvadze/repos","events_url":"https://api.github.com/users/janibolkvadze/events{/privacy}","received_events_url":"https://api.github.com/users/janibolkvadze/received_events","type":"User","site_admin":false},"repo":{"id":209761426,"node_id":"MDEwOlJlcG9zaXRvcnkyMDk3NjE0MjY=","name":"ux-chi","full_name":"janibolkvadze/ux-chi","private":false,"owner":{"login":"janibolkvadze","id":25136131,"node_id":"MDQ6VXNlcjI1MTM2MTMx","avatar_url":"https://avatars3.githubusercontent.com/u/25136131?v=4","gravatar_id":"","url":"https://api.github.com/users/janibolkvadze","html_url":"https://github.com/janibolkvadze","followers_url":"https://api.github.com/users/janibolkvadze/followers","following_url":"https://api.github.com/users/janibolkvadze/following{/other_user}","gists_url":"https://api.github.com/users/janibolkvadze/gists{/gist_id}","starred_url":"https://api.github.com/users/janibolkvadze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janibolkvadze/subscriptions","organizations_url":"https://api.github.com/users/janibolkvadze/orgs","repos_url":"https://api.github.com/users/janibolkvadze/repos","events_url":"https://api.github.com/users/janibolkvadze/events{/privacy}","received_events_url":"https://api.github.com/users/janibolkvadze/received_events","type":"User","site_admin":false},"html_url":"https://github.com/janibolkvadze/ux-chi","description":null,"fork":true,"url":"https://api.github.com/repos/janibolkvadze/ux-chi","forks_url":"https://api.github.com/repos/janibolkvadze/ux-chi/forks","keys_url":"https://api.github.com/repos/janibolkvadze/ux-chi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janibolkvadze/ux-chi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janibolkvadze/ux-chi/teams","hooks_url":"https://api.github.com/repos/janibolkvadze/ux-chi/hooks","issue_events_url":"https://api.github.com/repos/janibolkvadze/ux-chi/issues/events{/number}","events_url":"https://api.github.com/repos/janibolkvadze/ux-chi/events","assignees_url":"https://api.github.com/repos/janibolkvadze/ux-chi/assignees{/user}","branches_url":"https://api.github.com/repos/janibolkvadze/ux-chi/branches{/branch}","tags_url":"https://api.github.com/repos/janibolkvadze/ux-chi/tags","blobs_url":"https://api.github.com/repos/janibolkvadze/ux-chi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janibolkvadze/ux-chi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janibolkvadze/ux-chi/git/refs{/sha}","trees_url":"https://api.github.com/repos/janibolkvadze/ux-chi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janibolkvadze/ux-chi/statuses/{sha}","languages_url":"https://api.github.com/repos/janibolkvadze/ux-chi/languages","stargazers_url":"https://api.github.com/repos/janibolkvadze/ux-chi/stargazers","contributors_url":"https://api.github.com/repos/janibolkvadze/ux-chi/contributors","subscribers_url":"https://api.github.com/repos/janibolkvadze/ux-chi/subscribers","subscription_url":"https://api.github.com/repos/janibolkvadze/ux-chi/subscription","commits_url":"https://api.github.com/repos/janibolkvadze/ux-chi/commits{/sha}","git_commits_url":"https://api.github.com/repos/janibolkvadze/ux-chi/git/commits{/sha}","comments_url":"https://api.github.com/repos/janibolkvadze/ux-chi/comments{/number}","issue_comment_url":"https://api.github.com/repos/janibolkvadze/ux-chi/issues/comments{/number}","contents_url":"https://api.github.com/repos/janibolkvadze/ux-chi/contents/{+path}","compare_url":"https://api.github.com/repos/janibolkvadze/ux-chi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janibolkvadze/ux-chi/merges","archive_url":"https://api.github.com/repos/janibolkvadze/ux-chi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janibolkvadze/ux-chi/downloads","issues_url":"https://api.github.com/repos/janibolkvadze/ux-chi/issues{/number}","pulls_url":"https://api.github.com/repos/janibolkvadze/ux-chi/pulls{/number}","milestones_url":"https://api.github.com/repos/janibolkvadze/ux-chi/milestones{/number}","notifications_url":"https://api.github.com/repos/janibolkvadze/ux-chi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janibolkvadze/ux-chi/labels{/name}","releases_url":"https://api.github.com/repos/janibolkvadze/ux-chi/releases{/id}","deployments_url":"https://api.github.com/repos/janibolkvadze/ux-chi/deployments","created_at":"2019-09-20T10:05:10Z","updated_at":"2019-09-20T10:05:12Z","pushed_at":"2019-10-14T11:18:53Z","git_url":"git://github.com/janibolkvadze/ux-chi.git","ssh_url":"git@github.com:janibolkvadze/ux-chi.git","clone_url":"https://github.com/janibolkvadze/ux-chi.git","svn_url":"https://github.com/janibolkvadze/ux-chi","homepage":null,"size":171476,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CenturyLinkCloud:master","ref":"master","sha":"a001b1edf57f2743360fbd3949f7fa49e0f1ca39","user":{"login":"CenturyLinkCloud","id":5995824,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTU4MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5995824?v=4","gravatar_id":"","url":"https://api.github.com/users/CenturyLinkCloud","html_url":"https://github.com/CenturyLinkCloud","followers_url":"https://api.github.com/users/CenturyLinkCloud/followers","following_url":"https://api.github.com/users/CenturyLinkCloud/following{/other_user}","gists_url":"https://api.github.com/users/CenturyLinkCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/CenturyLinkCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenturyLinkCloud/subscriptions","organizations_url":"https://api.github.com/users/CenturyLinkCloud/orgs","repos_url":"https://api.github.com/users/CenturyLinkCloud/repos","events_url":"https://api.github.com/users/CenturyLinkCloud/events{/privacy}","received_events_url":"https://api.github.com/users/CenturyLinkCloud/received_events","type":"Organization","site_admin":false},"repo":{"id":106332422,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMzI0MjI=","name":"ux-chi","full_name":"CenturyLinkCloud/ux-chi","private":false,"owner":{"login":"CenturyLinkCloud","id":5995824,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTU4MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5995824?v=4","gravatar_id":"","url":"https://api.github.com/users/CenturyLinkCloud","html_url":"https://github.com/CenturyLinkCloud","followers_url":"https://api.github.com/users/CenturyLinkCloud/followers","following_url":"https://api.github.com/users/CenturyLinkCloud/following{/other_user}","gists_url":"https://api.github.com/users/CenturyLinkCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/CenturyLinkCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenturyLinkCloud/subscriptions","organizations_url":"https://api.github.com/users/CenturyLinkCloud/orgs","repos_url":"https://api.github.com/users/CenturyLinkCloud/repos","events_url":"https://api.github.com/users/CenturyLinkCloud/events{/privacy}","received_events_url":"https://api.github.com/users/CenturyLinkCloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CenturyLinkCloud/ux-chi","description":null,"fork":false,"url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi","forks_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/forks","keys_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/teams","hooks_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/hooks","issue_events_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/issues/events{/number}","events_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/events","assignees_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/assignees{/user}","branches_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/branches{/branch}","tags_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/tags","blobs_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/statuses/{sha}","languages_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/languages","stargazers_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/stargazers","contributors_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/contributors","subscribers_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/subscribers","subscription_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/subscription","commits_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/contents/{+path}","compare_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/merges","archive_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/downloads","issues_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/issues{/number}","pulls_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls{/number}","milestones_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/milestones{/number}","notifications_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/labels{/name}","releases_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/releases{/id}","deployments_url":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/deployments","created_at":"2017-10-09T20:33:19Z","updated_at":"2019-10-03T14:49:07Z","pushed_at":"2019-10-14T11:18:55Z","git_url":"git://github.com/CenturyLinkCloud/ux-chi.git","ssh_url":"git@github.com:CenturyLinkCloud/ux-chi.git","clone_url":"https://github.com/CenturyLinkCloud/ux-chi.git","svn_url":"https://github.com/CenturyLinkCloud/ux-chi","homepage":null,"size":171311,"stargazers_count":7,"watchers_count":7,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/389"},"html":{"href":"https://github.com/CenturyLinkCloud/ux-chi/pull/389"},"issue":{"href":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/issues/389"},"comments":{"href":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/CenturyLinkCloud/ux-chi/statuses/35578b2971438233dbab6a44e39b501cfbed2d56"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 106332422,
"name": "CenturyLinkCloud/ux-chi",
"url": "https://api.github.com/repos/CenturyLinkCloud/ux-chi"
}
|
{
"id": 43439749,
"login": "dani-cl-madrid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43439749?",
"url": "https://api.github.com/users/dani-cl-madrid"
}
|
{
"id": 5995824,
"login": "CenturyLinkCloud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5995824?",
"url": "https://api.github.com/orgs/CenturyLinkCloud"
}
| 2019-10-14T12:00:02 |
10624291218
|
{"actor":{"display_login":"dani-cl-madrid"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/plotly/dash-docs/pulls/comments/310854827","pull_request_review_id":271081968,"id":310854827,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDg1NDgyNw==","diff_hunk":"@@ -8,6 +8,8 @@\n \n *New in Dash v1.0*\n \n+ *support Dash for R testing in v1.1.0*","path":"tutorial/testing.py","position":4,"original_position":4,"commit_id":"19bd8b387fd8cc5c4c179e24f780bf15c9a89f61","original_commit_id":"19bd8b387fd8cc5c4c179e24f780bf15c9a89f61","user":{"login":"alexcjohnson","id":2678795,"node_id":"MDQ6VXNlcjI2Nzg3OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/2678795?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcjohnson","html_url":"https://github.com/alexcjohnson","followers_url":"https://api.github.com/users/alexcjohnson/followers","following_url":"https://api.github.com/users/alexcjohnson/following{/other_user}","gists_url":"https://api.github.com/users/alexcjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcjohnson/subscriptions","organizations_url":"https://api.github.com/users/alexcjohnson/orgs","repos_url":"https://api.github.com/users/alexcjohnson/repos","events_url":"https://api.github.com/users/alexcjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/alexcjohnson/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n *support Dash for R testing added in v1.1.0*\r\n```","created_at":"2019-08-06T01:55:48Z","updated_at":"2019-08-06T01:55:49Z","html_url":"https://github.com/plotly/dash-docs/pull/610#discussion_r310854827","pull_request_url":"https://api.github.com/repos/plotly/dash-docs/pulls/610","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/plotly/dash-docs/pulls/comments/310854827"},"html":{"href":"https://github.com/plotly/dash-docs/pull/610#discussion_r310854827"},"pull_request":{"href":"https://api.github.com/repos/plotly/dash-docs/pulls/610"}}},"pull_request":{"url":"https://api.github.com/repos/plotly/dash-docs/pulls/610","id":300121430,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMTIxNDMw","html_url":"https://github.com/plotly/dash-docs/pull/610","diff_url":"https://github.com/plotly/dash-docs/pull/610.diff","patch_url":"https://github.com/plotly/dash-docs/pull/610.patch","issue_url":"https://api.github.com/repos/plotly/dash-docs/issues/610","number":610,"state":"open","locked":false,"title":":pencil: add section for dashR testing","user":{"login":"byronz","id":1394467,"node_id":"MDQ6VXNlcjEzOTQ0Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1394467?v=4","gravatar_id":"","url":"https://api.github.com/users/byronz","html_url":"https://github.com/byronz","followers_url":"https://api.github.com/users/byronz/followers","following_url":"https://api.github.com/users/byronz/following{/other_user}","gists_url":"https://api.github.com/users/byronz/gists{/gist_id}","starred_url":"https://api.github.com/users/byronz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byronz/subscriptions","organizations_url":"https://api.github.com/users/byronz/orgs","repos_url":"https://api.github.com/users/byronz/repos","events_url":"https://api.github.com/users/byronz/events{/privacy}","received_events_url":"https://api.github.com/users/byronz/received_events","type":"User","site_admin":false},"body":"Closes #609 \r\n\r\nPost-merge checklist:\r\n\r\nThe master branch is auto-deployed to `dash.plot.ly`.\r\nOnce you have merged your PR, wait 5-10 minutes and check dash.plot.ly \r\nto verify that your changes have been made.\r\n\r\n- [x] I understand\r\n","created_at":"2019-07-23T04:14:38Z","updated_at":"2019-08-06T01:55:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"312a1c9271f6cea87377fc8b753079774eccb4f1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rpkyle","id":9809798,"node_id":"MDQ6VXNlcjk4MDk3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9809798?v=4","gravatar_id":"","url":"https://api.github.com/users/rpkyle","html_url":"https://github.com/rpkyle","followers_url":"https://api.github.com/users/rpkyle/followers","following_url":"https://api.github.com/users/rpkyle/following{/other_user}","gists_url":"https://api.github.com/users/rpkyle/gists{/gist_id}","starred_url":"https://api.github.com/users/rpkyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpkyle/subscriptions","organizations_url":"https://api.github.com/users/rpkyle/orgs","repos_url":"https://api.github.com/users/rpkyle/repos","events_url":"https://api.github.com/users/rpkyle/events{/privacy}","received_events_url":"https://api.github.com/users/rpkyle/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/plotly/dash-docs/pulls/610/commits","review_comments_url":"https://api.github.com/repos/plotly/dash-docs/pulls/610/comments","review_comment_url":"https://api.github.com/repos/plotly/dash-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plotly/dash-docs/issues/610/comments","statuses_url":"https://api.github.com/repos/plotly/dash-docs/statuses/19bd8b387fd8cc5c4c179e24f780bf15c9a89f61","head":{"label":"plotly:dashr-testing","ref":"dashr-testing","sha":"19bd8b387fd8cc5c4c179e24f780bf15c9a89f61","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":84095619,"node_id":"MDEwOlJlcG9zaXRvcnk4NDA5NTYxOQ==","name":"dash-docs","full_name":"plotly/dash-docs","private":false,"owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/plotly/dash-docs","description":":book: The Official Dash Userguide","fork":false,"url":"https://api.github.com/repos/plotly/dash-docs","forks_url":"https://api.github.com/repos/plotly/dash-docs/forks","keys_url":"https://api.github.com/repos/plotly/dash-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/dash-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/dash-docs/teams","hooks_url":"https://api.github.com/repos/plotly/dash-docs/hooks","issue_events_url":"https://api.github.com/repos/plotly/dash-docs/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/dash-docs/events","assignees_url":"https://api.github.com/repos/plotly/dash-docs/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/dash-docs/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/dash-docs/tags","blobs_url":"https://api.github.com/repos/plotly/dash-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/dash-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/dash-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/dash-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/dash-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/dash-docs/languages","stargazers_url":"https://api.github.com/repos/plotly/dash-docs/stargazers","contributors_url":"https://api.github.com/repos/plotly/dash-docs/contributors","subscribers_url":"https://api.github.com/repos/plotly/dash-docs/subscribers","subscription_url":"https://api.github.com/repos/plotly/dash-docs/subscription","commits_url":"https://api.github.com/repos/plotly/dash-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/dash-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/dash-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/dash-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/dash-docs/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/dash-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/dash-docs/merges","archive_url":"https://api.github.com/repos/plotly/dash-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/dash-docs/downloads","issues_url":"https://api.github.com/repos/plotly/dash-docs/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/dash-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/dash-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/dash-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/dash-docs/labels{/name}","releases_url":"https://api.github.com/repos/plotly/dash-docs/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/dash-docs/deployments","created_at":"2017-03-06T16:30:08Z","updated_at":"2019-08-05T23:00:35Z","pushed_at":"2019-08-05T23:51:55Z","git_url":"git://github.com/plotly/dash-docs.git","ssh_url":"git@github.com:plotly/dash-docs.git","clone_url":"https://github.com/plotly/dash-docs.git","svn_url":"https://github.com/plotly/dash-docs","homepage":"https://dash.plot.ly","size":209943,"stargazers_count":226,"watchers_count":226,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":100,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":92,"open_issues":100,"watchers":226,"default_branch":"master"}},"base":{"label":"plotly:master","ref":"master","sha":"f7639538520589a4dc117082905352e678de33d2","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":84095619,"node_id":"MDEwOlJlcG9zaXRvcnk4NDA5NTYxOQ==","name":"dash-docs","full_name":"plotly/dash-docs","private":false,"owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/plotly/dash-docs","description":":book: The Official Dash Userguide","fork":false,"url":"https://api.github.com/repos/plotly/dash-docs","forks_url":"https://api.github.com/repos/plotly/dash-docs/forks","keys_url":"https://api.github.com/repos/plotly/dash-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/dash-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/dash-docs/teams","hooks_url":"https://api.github.com/repos/plotly/dash-docs/hooks","issue_events_url":"https://api.github.com/repos/plotly/dash-docs/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/dash-docs/events","assignees_url":"https://api.github.com/repos/plotly/dash-docs/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/dash-docs/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/dash-docs/tags","blobs_url":"https://api.github.com/repos/plotly/dash-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/dash-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/dash-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/dash-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/dash-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/dash-docs/languages","stargazers_url":"https://api.github.com/repos/plotly/dash-docs/stargazers","contributors_url":"https://api.github.com/repos/plotly/dash-docs/contributors","subscribers_url":"https://api.github.com/repos/plotly/dash-docs/subscribers","subscription_url":"https://api.github.com/repos/plotly/dash-docs/subscription","commits_url":"https://api.github.com/repos/plotly/dash-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/dash-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/dash-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/dash-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/dash-docs/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/dash-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/dash-docs/merges","archive_url":"https://api.github.com/repos/plotly/dash-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/dash-docs/downloads","issues_url":"https://api.github.com/repos/plotly/dash-docs/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/dash-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/dash-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/dash-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/dash-docs/labels{/name}","releases_url":"https://api.github.com/repos/plotly/dash-docs/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/dash-docs/deployments","created_at":"2017-03-06T16:30:08Z","updated_at":"2019-08-05T23:00:35Z","pushed_at":"2019-08-05T23:51:55Z","git_url":"git://github.com/plotly/dash-docs.git","ssh_url":"git@github.com:plotly/dash-docs.git","clone_url":"https://github.com/plotly/dash-docs.git","svn_url":"https://github.com/plotly/dash-docs","homepage":"https://dash.plot.ly","size":209943,"stargazers_count":226,"watchers_count":226,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":100,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":92,"open_issues":100,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plotly/dash-docs/pulls/610"},"html":{"href":"https://github.com/plotly/dash-docs/pull/610"},"issue":{"href":"https://api.github.com/repos/plotly/dash-docs/issues/610"},"comments":{"href":"https://api.github.com/repos/plotly/dash-docs/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/plotly/dash-docs/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/plotly/dash-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plotly/dash-docs/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/plotly/dash-docs/statuses/19bd8b387fd8cc5c4c179e24f780bf15c9a89f61"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 84095619,
"name": "plotly/dash-docs",
"url": "https://api.github.com/repos/plotly/dash-docs"
}
|
{
"id": 2678795,
"login": "alexcjohnson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2678795?",
"url": "https://api.github.com/users/alexcjohnson"
}
|
{
"id": 5997976,
"login": "plotly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5997976?",
"url": "https://api.github.com/orgs/plotly"
}
| 2019-08-06T01:55:48 |
10152880254
|
{"actor":{"display_login":"alexcjohnson"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/comments/344445068","pull_request_review_id":314559385,"id":344445068,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDQ0NTA2OA==","diff_hunk":"@@ -207,6 +207,24 @@ def length(self, value):\n >>> i1.end\n 17\n \n+.. note:: When defining an setter for a hybrid property or method, the","path":"lib/sqlalchemy/ext/hybrid.py","position":4,"original_position":4,"commit_id":"e57d63ab96bccac77c549771ab60fecd6d1bb770","original_commit_id":"e57d63ab96bccac77c549771ab60fecd6d1bb770","user":{"login":"zzzeek","id":128223,"node_id":"MDQ6VXNlcjEyODIyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/128223?v=4","gravatar_id":"","url":"https://api.github.com/users/zzzeek","html_url":"https://github.com/zzzeek","followers_url":"https://api.github.com/users/zzzeek/followers","following_url":"https://api.github.com/users/zzzeek/following{/other_user}","gists_url":"https://api.github.com/users/zzzeek/gists{/gist_id}","starred_url":"https://api.github.com/users/zzzeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzzeek/subscriptions","organizations_url":"https://api.github.com/users/zzzeek/orgs","repos_url":"https://api.github.com/users/zzzeek/repos","events_url":"https://api.github.com/users/zzzeek/events{/privacy}","received_events_url":"https://api.github.com/users/zzzeek/received_events","type":"User","site_admin":false},"body":"\"defining a setter\"","created_at":"2019-11-09T13:54:01Z","updated_at":"2019-11-09T13:58:23Z","html_url":"https://github.com/sqlalchemy/sqlalchemy/pull/4970#discussion_r344445068","pull_request_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/4970","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/comments/344445068"},"html":{"href":"https://github.com/sqlalchemy/sqlalchemy/pull/4970#discussion_r344445068"},"pull_request":{"href":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/4970"}}},"pull_request":{"url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/4970","id":338943538,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4OTQzNTM4","html_url":"https://github.com/sqlalchemy/sqlalchemy/pull/4970","diff_url":"https://github.com/sqlalchemy/sqlalchemy/pull/4970.diff","patch_url":"https://github.com/sqlalchemy/sqlalchemy/pull/4970.patch","issue_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/issues/4970","number":4970,"state":"open","locked":false,"title":"Add note to hybrid.py setter documentation","user":{"login":"AllanDaemon","id":607994,"node_id":"MDQ6VXNlcjYwNzk5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/607994?v=4","gravatar_id":"","url":"https://api.github.com/users/AllanDaemon","html_url":"https://github.com/AllanDaemon","followers_url":"https://api.github.com/users/AllanDaemon/followers","following_url":"https://api.github.com/users/AllanDaemon/following{/other_user}","gists_url":"https://api.github.com/users/AllanDaemon/gists{/gist_id}","starred_url":"https://api.github.com/users/AllanDaemon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllanDaemon/subscriptions","organizations_url":"https://api.github.com/users/AllanDaemon/orgs","repos_url":"https://api.github.com/users/AllanDaemon/repos","events_url":"https://api.github.com/users/AllanDaemon/events{/privacy}","received_events_url":"https://api.github.com/users/AllanDaemon/received_events","type":"User","site_admin":false},"body":"<!-- Provide a general summary of your proposed changes in the Title field above -->\r\n\r\n### Description\r\nAlmost the same note of the defining expression. Although it's already said implicitly in the note of the session before, one searching about getters and setters for hybrid properties may skip it, so it's better redundancy and beeing explicitly about it to avoid headaches.\r\n\r\n### Motivation\r\n\r\nI had a lot of pain with this issue, and I rechecked the documentation many times trying to solve it but I missed the note on the defining expression because I wasn't interested in using it. I was kind of expecting something like this note.\r\n\r\nThe redaction here is a suggestion based on the previous note.\r\n\r\n### Checklist\r\n<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)\r\n\r\n-->\r\n\r\nThis pull request is:\r\n\r\n- [X] A documentation / typographical error fix\r\n\t- Good to go, no issue or tests are needed\r\n- [ ] A short code fix\r\n\t- please include the issue number, and create an issue if none exists, which\r\n\t must include a complete example of the issue. one line code fixes without an\r\n\t issue and demonstration will not be accepted.\r\n\t- Please include: `Fixes: #<issue number>` in the commit message\r\n\t- please include tests. one line code fixes without tests will not be accepted.\r\n- [ ] A new feature implementation\r\n\t- please include the issue number, and create an issue if none exists, which must\r\n\t include a complete example of how the feature would look.\r\n\t- Please include: `Fixes: #<issue number>` in the commit message\r\n\t- please include tests.\r\n\r\n**Have a nice day!**\r\n","created_at":"2019-11-09T05:36:16Z","updated_at":"2019-11-09T13:58:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b92d0aa3dd647ab055ae80c06cd162b223baf89f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/4970/commits","review_comments_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/4970/comments","review_comment_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/issues/4970/comments","statuses_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/statuses/e57d63ab96bccac77c549771ab60fecd6d1bb770","head":{"label":"AllanDaemon:master","ref":"master","sha":"e57d63ab96bccac77c549771ab60fecd6d1bb770","user":{"login":"AllanDaemon","id":607994,"node_id":"MDQ6VXNlcjYwNzk5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/607994?v=4","gravatar_id":"","url":"https://api.github.com/users/AllanDaemon","html_url":"https://github.com/AllanDaemon","followers_url":"https://api.github.com/users/AllanDaemon/followers","following_url":"https://api.github.com/users/AllanDaemon/following{/other_user}","gists_url":"https://api.github.com/users/AllanDaemon/gists{/gist_id}","starred_url":"https://api.github.com/users/AllanDaemon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllanDaemon/subscriptions","organizations_url":"https://api.github.com/users/AllanDaemon/orgs","repos_url":"https://api.github.com/users/AllanDaemon/repos","events_url":"https://api.github.com/users/AllanDaemon/events{/privacy}","received_events_url":"https://api.github.com/users/AllanDaemon/received_events","type":"User","site_admin":false},"repo":{"id":220593802,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA1OTM4MDI=","name":"sqlalchemy","full_name":"AllanDaemon/sqlalchemy","private":false,"owner":{"login":"AllanDaemon","id":607994,"node_id":"MDQ6VXNlcjYwNzk5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/607994?v=4","gravatar_id":"","url":"https://api.github.com/users/AllanDaemon","html_url":"https://github.com/AllanDaemon","followers_url":"https://api.github.com/users/AllanDaemon/followers","following_url":"https://api.github.com/users/AllanDaemon/following{/other_user}","gists_url":"https://api.github.com/users/AllanDaemon/gists{/gist_id}","starred_url":"https://api.github.com/users/AllanDaemon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllanDaemon/subscriptions","organizations_url":"https://api.github.com/users/AllanDaemon/orgs","repos_url":"https://api.github.com/users/AllanDaemon/repos","events_url":"https://api.github.com/users/AllanDaemon/events{/privacy}","received_events_url":"https://api.github.com/users/AllanDaemon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AllanDaemon/sqlalchemy","description":"The Database Toolkit for Python","fork":true,"url":"https://api.github.com/repos/AllanDaemon/sqlalchemy","forks_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/forks","keys_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/teams","hooks_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/hooks","issue_events_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/issues/events{/number}","events_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/events","assignees_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/assignees{/user}","branches_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/branches{/branch}","tags_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/tags","blobs_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/git/refs{/sha}","trees_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/statuses/{sha}","languages_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/languages","stargazers_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/stargazers","contributors_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/contributors","subscribers_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/subscribers","subscription_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/subscription","commits_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/commits{/sha}","git_commits_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/git/commits{/sha}","comments_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/comments{/number}","issue_comment_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/issues/comments{/number}","contents_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/contents/{+path}","compare_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/merges","archive_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/downloads","issues_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/issues{/number}","pulls_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/pulls{/number}","milestones_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/milestones{/number}","notifications_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/labels{/name}","releases_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/releases{/id}","deployments_url":"https://api.github.com/repos/AllanDaemon/sqlalchemy/deployments","created_at":"2019-11-09T05:01:28Z","updated_at":"2019-11-09T05:28:53Z","pushed_at":"2019-11-09T05:28:49Z","git_url":"git://github.com/AllanDaemon/sqlalchemy.git","ssh_url":"git@github.com:AllanDaemon/sqlalchemy.git","clone_url":"https://github.com/AllanDaemon/sqlalchemy.git","svn_url":"https://github.com/AllanDaemon/sqlalchemy","homepage":"https://www.sqlalchemy.org","size":39437,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sqlalchemy:master","ref":"master","sha":"4a2dd4902a1168234f14bdd0634728086d53c406","user":{"login":"sqlalchemy","id":6043126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNDMxMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/6043126?v=4","gravatar_id":"","url":"https://api.github.com/users/sqlalchemy","html_url":"https://github.com/sqlalchemy","followers_url":"https://api.github.com/users/sqlalchemy/followers","following_url":"https://api.github.com/users/sqlalchemy/following{/other_user}","gists_url":"https://api.github.com/users/sqlalchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/sqlalchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqlalchemy/subscriptions","organizations_url":"https://api.github.com/users/sqlalchemy/orgs","repos_url":"https://api.github.com/users/sqlalchemy/repos","events_url":"https://api.github.com/users/sqlalchemy/events{/privacy}","received_events_url":"https://api.github.com/users/sqlalchemy/received_events","type":"Organization","site_admin":false},"repo":{"id":159271175,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkyNzExNzU=","name":"sqlalchemy","full_name":"sqlalchemy/sqlalchemy","private":false,"owner":{"login":"sqlalchemy","id":6043126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNDMxMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/6043126?v=4","gravatar_id":"","url":"https://api.github.com/users/sqlalchemy","html_url":"https://github.com/sqlalchemy","followers_url":"https://api.github.com/users/sqlalchemy/followers","following_url":"https://api.github.com/users/sqlalchemy/following{/other_user}","gists_url":"https://api.github.com/users/sqlalchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/sqlalchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqlalchemy/subscriptions","organizations_url":"https://api.github.com/users/sqlalchemy/orgs","repos_url":"https://api.github.com/users/sqlalchemy/repos","events_url":"https://api.github.com/users/sqlalchemy/events{/privacy}","received_events_url":"https://api.github.com/users/sqlalchemy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sqlalchemy/sqlalchemy","description":"The Database Toolkit for Python","fork":false,"url":"https://api.github.com/repos/sqlalchemy/sqlalchemy","forks_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/forks","keys_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/teams","hooks_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/hooks","issue_events_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/issues/events{/number}","events_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/events","assignees_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/assignees{/user}","branches_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/branches{/branch}","tags_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/tags","blobs_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/statuses/{sha}","languages_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/languages","stargazers_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/stargazers","contributors_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/contributors","subscribers_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/subscribers","subscription_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/subscription","commits_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/contents/{+path}","compare_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/merges","archive_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/downloads","issues_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/issues{/number}","pulls_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls{/number}","milestones_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/milestones{/number}","notifications_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/labels{/name}","releases_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/releases{/id}","deployments_url":"https://api.github.com/repos/sqlalchemy/sqlalchemy/deployments","created_at":"2018-11-27T03:35:03Z","updated_at":"2019-11-09T07:38:45Z","pushed_at":"2019-11-09T05:36:17Z","git_url":"git://github.com/sqlalchemy/sqlalchemy.git","ssh_url":"git@github.com:sqlalchemy/sqlalchemy.git","clone_url":"https://github.com/sqlalchemy/sqlalchemy.git","svn_url":"https://github.com/sqlalchemy/sqlalchemy","homepage":"https://www.sqlalchemy.org","size":39422,"stargazers_count":1565,"watchers_count":1565,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":232,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":179,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":232,"open_issues":179,"watchers":1565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/4970"},"html":{"href":"https://github.com/sqlalchemy/sqlalchemy/pull/4970"},"issue":{"href":"https://api.github.com/repos/sqlalchemy/sqlalchemy/issues/4970"},"comments":{"href":"https://api.github.com/repos/sqlalchemy/sqlalchemy/issues/4970/comments"},"review_comments":{"href":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/4970/comments"},"review_comment":{"href":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sqlalchemy/sqlalchemy/pulls/4970/commits"},"statuses":{"href":"https://api.github.com/repos/sqlalchemy/sqlalchemy/statuses/e57d63ab96bccac77c549771ab60fecd6d1bb770"}},"author_association":"NONE"}}
|
{
"id": 159271175,
"name": "sqlalchemy/sqlalchemy",
"url": "https://api.github.com/repos/sqlalchemy/sqlalchemy"
}
|
{
"id": 128223,
"login": "zzzeek",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/128223?",
"url": "https://api.github.com/users/zzzeek"
}
|
{
"id": 6043126,
"login": "sqlalchemy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6043126?",
"url": "https://api.github.com/orgs/sqlalchemy"
}
| 2019-11-09T13:54:01 |
10825122818
|
{"actor":{"display_login":"zzzeek"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/comments/359618329","pull_request_review_id":334326294,"id":359618329,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTYxODMyOQ==","diff_hunk":"@@ -72,50 +64,60 @@ depending on whether it has become read-only, due to terms having been tagged to\n * SilverStripe 4.x\n * PHP 7.x\n \n-\n ## Installation\n \n ```composer\n composer require chrometoaster/silverstripe-advanced-taxonomies\n ```\n-## Configure\n \n-By default, the module adds extension `DataObjectTaxonomiesDataExtension` to `SiteTree` and `File` by\n-[config.yml](_config/config.yml). To add the extension to your project-specific DataObject, please refer to\n-[config.yml](_config/config.yml) as code sample and make another YML file under your app/_config folder, add some config\n-like the following:\n+## Configuration\n+\n+By default, the module applies the `DataObjectTaxonomiesDataExtension` extension to `SiteTree` and `File` classes\n+in the [config.yml](_config/config.yml).\n+\n+To add the extension to your project-specific data models, create a yaml config file similar to the example below:\n \n ```yaml\n App\\Models\\YourDataModel:\n extensions:\n - Chrometoaster\\AdvancedTaxonomies\\Extensions\\DataObjectTaxonomiesDataExtension\n-SilverStripe\\Security\\Member:\n+App\\Models\\YourOtherCustomDataModel:\n extensions:\n - Chrometoaster\\AdvancedTaxonomies\\Extensions\\DataObjectTaxonomiesDataExtension\n ```\n \n There are some settings that can be modified in this module, depending on requirements. These are listed below.\n \n-### disable ModelTagLogicValidator to output its error message in HTML\n+## Developer's notes\n \n-```yaml\n-Chrometoaster\\AdvancedTaxonomies\\Validators\\ModelTagLogicValidator:\n- - output_html_enabled: false\n+#### HTML in validation messages\n+\n+The `Chrometoaster\\AdvancedTaxonomies\\Validators\\TaxonomyRulesValidator` produces error messages in a HTML format.\n+This behaviour can be sometimes problematic, espacially in a React-like parts of the CMS, e.g. the assets admin.","path":"README.md","position":164,"original_position":164,"commit_id":"8b1a34a30edfd423ade833f493e5cdaa842b2b1c","original_commit_id":"8b1a34a30edfd423ade833f493e5cdaa842b2b1c","user":{"login":"DrDave","id":391779,"node_id":"MDQ6VXNlcjM5MTc3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/391779?v=4","gravatar_id":"","url":"https://api.github.com/users/DrDave","html_url":"https://github.com/DrDave","followers_url":"https://api.github.com/users/DrDave/followers","following_url":"https://api.github.com/users/DrDave/following{/other_user}","gists_url":"https://api.github.com/users/DrDave/gists{/gist_id}","starred_url":"https://api.github.com/users/DrDave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrDave/subscriptions","organizations_url":"https://api.github.com/users/DrDave/orgs","repos_url":"https://api.github.com/users/DrDave/repos","events_url":"https://api.github.com/users/DrDave/events{/privacy}","received_events_url":"https://api.github.com/users/DrDave/received_events","type":"User","site_admin":false},"body":"especially, rather than espacially ","created_at":"2019-12-18T23:22:30Z","updated_at":"2019-12-18T23:22:30Z","html_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies/pull/11#discussion_r359618329","pull_request_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/11","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/comments/359618329"},"html":{"href":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies/pull/11#discussion_r359618329"},"pull_request":{"href":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/11","id":354836743,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0ODM2NzQz","html_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies/pull/11","diff_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies/pull/11.diff","patch_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies/pull/11.patch","issue_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues/11","number":11,"state":"open","locked":false,"title":"Refactor and simplify","user":{"login":"michalkleiner","id":233342,"node_id":"MDQ6VXNlcjIzMzM0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/233342?v=4","gravatar_id":"","url":"https://api.github.com/users/michalkleiner","html_url":"https://github.com/michalkleiner","followers_url":"https://api.github.com/users/michalkleiner/followers","following_url":"https://api.github.com/users/michalkleiner/following{/other_user}","gists_url":"https://api.github.com/users/michalkleiner/gists{/gist_id}","starred_url":"https://api.github.com/users/michalkleiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalkleiner/subscriptions","organizations_url":"https://api.github.com/users/michalkleiner/orgs","repos_url":"https://api.github.com/users/michalkleiner/repos","events_url":"https://api.github.com/users/michalkleiner/events{/privacy}","received_events_url":"https://api.github.com/users/michalkleiner/received_events","type":"User","site_admin":false},"body":"A bunch of updates mainly around the code structure, variables naming, methods reusability.\r\n\r\nThe core functionality hasn't changed, though one of the notable changes is using InternalOnly instead of public display preference.\r\n\r\nNew test for the recently added feature 'List of tagged objects'.","created_at":"2019-12-18T21:57:34Z","updated_at":"2019-12-18T23:22:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdc9351a5eb98a5c2ac56ad22a9afd331df23ebf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"normann","id":556224,"node_id":"MDQ6VXNlcjU1NjIyNA==","avatar_url":"https://avatars1.githubusercontent.com/u/556224?v=4","gravatar_id":"","url":"https://api.github.com/users/normann","html_url":"https://github.com/normann","followers_url":"https://api.github.com/users/normann/followers","following_url":"https://api.github.com/users/normann/following{/other_user}","gists_url":"https://api.github.com/users/normann/gists{/gist_id}","starred_url":"https://api.github.com/users/normann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normann/subscriptions","organizations_url":"https://api.github.com/users/normann/orgs","repos_url":"https://api.github.com/users/normann/repos","events_url":"https://api.github.com/users/normann/events{/privacy}","received_events_url":"https://api.github.com/users/normann/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/11/commits","review_comments_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/11/comments","review_comment_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues/11/comments","statuses_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/statuses/8b1a34a30edfd423ade833f493e5cdaa842b2b1c","head":{"label":"chrometoasters:pulls/refactoring-for-version-2","ref":"pulls/refactoring-for-version-2","sha":"8b1a34a30edfd423ade833f493e5cdaa842b2b1c","user":{"login":"chrometoasters","id":6063837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNjM4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6063837?v=4","gravatar_id":"","url":"https://api.github.com/users/chrometoasters","html_url":"https://github.com/chrometoasters","followers_url":"https://api.github.com/users/chrometoasters/followers","following_url":"https://api.github.com/users/chrometoasters/following{/other_user}","gists_url":"https://api.github.com/users/chrometoasters/gists{/gist_id}","starred_url":"https://api.github.com/users/chrometoasters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrometoasters/subscriptions","organizations_url":"https://api.github.com/users/chrometoasters/orgs","repos_url":"https://api.github.com/users/chrometoasters/repos","events_url":"https://api.github.com/users/chrometoasters/events{/privacy}","received_events_url":"https://api.github.com/users/chrometoasters/received_events","type":"Organization","site_admin":false},"repo":{"id":209679918,"node_id":"MDEwOlJlcG9zaXRvcnkyMDk2Nzk5MTg=","name":"silverstripe-advanced-taxonomies","full_name":"chrometoasters/silverstripe-advanced-taxonomies","private":false,"owner":{"login":"chrometoasters","id":6063837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNjM4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6063837?v=4","gravatar_id":"","url":"https://api.github.com/users/chrometoasters","html_url":"https://github.com/chrometoasters","followers_url":"https://api.github.com/users/chrometoasters/followers","following_url":"https://api.github.com/users/chrometoasters/following{/other_user}","gists_url":"https://api.github.com/users/chrometoasters/gists{/gist_id}","starred_url":"https://api.github.com/users/chrometoasters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrometoasters/subscriptions","organizations_url":"https://api.github.com/users/chrometoasters/orgs","repos_url":"https://api.github.com/users/chrometoasters/repos","events_url":"https://api.github.com/users/chrometoasters/events{/privacy}","received_events_url":"https://api.github.com/users/chrometoasters/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies","description":"A SilverStripe module providing functionality to manage taxonomies with advanced features, e.g. a taxonomy requiring another taxonomy, singular/plural titles and similar.","fork":false,"url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies","forks_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/forks","keys_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/teams","hooks_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/hooks","issue_events_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues/events{/number}","events_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/events","assignees_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/assignees{/user}","branches_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/branches{/branch}","tags_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/tags","blobs_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/statuses/{sha}","languages_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/languages","stargazers_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/stargazers","contributors_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/contributors","subscribers_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/subscribers","subscription_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/subscription","commits_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/contents/{+path}","compare_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/merges","archive_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/downloads","issues_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues{/number}","pulls_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls{/number}","milestones_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/milestones{/number}","notifications_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/labels{/name}","releases_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/releases{/id}","deployments_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/deployments","created_at":"2019-09-20T01:32:26Z","updated_at":"2019-12-17T22:48:05Z","pushed_at":"2019-12-18T22:01:26Z","git_url":"git://github.com/chrometoasters/silverstripe-advanced-taxonomies.git","ssh_url":"git@github.com:chrometoasters/silverstripe-advanced-taxonomies.git","clone_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies.git","svn_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies","homepage":null,"size":71,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"chrometoasters:master","ref":"master","sha":"f98b82f062cdd950a4dc6b8019b561d3f93d94dd","user":{"login":"chrometoasters","id":6063837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNjM4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6063837?v=4","gravatar_id":"","url":"https://api.github.com/users/chrometoasters","html_url":"https://github.com/chrometoasters","followers_url":"https://api.github.com/users/chrometoasters/followers","following_url":"https://api.github.com/users/chrometoasters/following{/other_user}","gists_url":"https://api.github.com/users/chrometoasters/gists{/gist_id}","starred_url":"https://api.github.com/users/chrometoasters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrometoasters/subscriptions","organizations_url":"https://api.github.com/users/chrometoasters/orgs","repos_url":"https://api.github.com/users/chrometoasters/repos","events_url":"https://api.github.com/users/chrometoasters/events{/privacy}","received_events_url":"https://api.github.com/users/chrometoasters/received_events","type":"Organization","site_admin":false},"repo":{"id":209679918,"node_id":"MDEwOlJlcG9zaXRvcnkyMDk2Nzk5MTg=","name":"silverstripe-advanced-taxonomies","full_name":"chrometoasters/silverstripe-advanced-taxonomies","private":false,"owner":{"login":"chrometoasters","id":6063837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNjM4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6063837?v=4","gravatar_id":"","url":"https://api.github.com/users/chrometoasters","html_url":"https://github.com/chrometoasters","followers_url":"https://api.github.com/users/chrometoasters/followers","following_url":"https://api.github.com/users/chrometoasters/following{/other_user}","gists_url":"https://api.github.com/users/chrometoasters/gists{/gist_id}","starred_url":"https://api.github.com/users/chrometoasters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrometoasters/subscriptions","organizations_url":"https://api.github.com/users/chrometoasters/orgs","repos_url":"https://api.github.com/users/chrometoasters/repos","events_url":"https://api.github.com/users/chrometoasters/events{/privacy}","received_events_url":"https://api.github.com/users/chrometoasters/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies","description":"A SilverStripe module providing functionality to manage taxonomies with advanced features, e.g. a taxonomy requiring another taxonomy, singular/plural titles and similar.","fork":false,"url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies","forks_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/forks","keys_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/teams","hooks_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/hooks","issue_events_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues/events{/number}","events_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/events","assignees_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/assignees{/user}","branches_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/branches{/branch}","tags_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/tags","blobs_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/statuses/{sha}","languages_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/languages","stargazers_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/stargazers","contributors_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/contributors","subscribers_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/subscribers","subscription_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/subscription","commits_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/contents/{+path}","compare_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/merges","archive_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/downloads","issues_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues{/number}","pulls_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls{/number}","milestones_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/milestones{/number}","notifications_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/labels{/name}","releases_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/releases{/id}","deployments_url":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/deployments","created_at":"2019-09-20T01:32:26Z","updated_at":"2019-12-17T22:48:05Z","pushed_at":"2019-12-18T22:01:26Z","git_url":"git://github.com/chrometoasters/silverstripe-advanced-taxonomies.git","ssh_url":"git@github.com:chrometoasters/silverstripe-advanced-taxonomies.git","clone_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies.git","svn_url":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies","homepage":null,"size":71,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/11"},"html":{"href":"https://github.com/chrometoasters/silverstripe-advanced-taxonomies/pull/11"},"issue":{"href":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues/11"},"comments":{"href":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies/statuses/8b1a34a30edfd423ade833f493e5cdaa842b2b1c"}},"author_association":"MEMBER"}}
|
{
"id": 209679918,
"name": "chrometoasters/silverstripe-advanced-taxonomies",
"url": "https://api.github.com/repos/chrometoasters/silverstripe-advanced-taxonomies"
}
|
{
"id": 391779,
"login": "DrDave",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/391779?",
"url": "https://api.github.com/users/DrDave"
}
|
{
"id": 6063837,
"login": "chrometoasters",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6063837?",
"url": "https://api.github.com/orgs/chrometoasters"
}
| 2019-12-18T23:22:30 |
11121237334
|
{"actor":{"display_login":"DrDave"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments/350934848","pull_request_review_id":323225741,"id":350934848,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MDkzNDg0OA==","diff_hunk":"@@ -55,6 +56,11 @@ export class EditorReplacementContribution implements IWorkbenchContribution {\n \t\t\tlanguage = this.modeService.getModeIdByFilepathOrFirstLine(editor.getResource());\n \t\t}\n \n+\t\tif (!language) {","path":"src/sql/workbench/common/editorReplacerContribution.ts","position":12,"original_position":12,"commit_id":"4d31df11dd5a39bc50674f1f0de2123f38198d05","original_commit_id":"4d31df11dd5a39bc50674f1f0de2123f38198d05","user":{"login":"anthonydresser","id":4324725,"node_id":"MDQ6VXNlcjQzMjQ3MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4324725?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonydresser","html_url":"https://github.com/anthonydresser","followers_url":"https://api.github.com/users/anthonydresser/followers","following_url":"https://api.github.com/users/anthonydresser/following{/other_user}","gists_url":"https://api.github.com/users/anthonydresser/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydresser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydresser/subscriptions","organizations_url":"https://api.github.com/users/anthonydresser/orgs","repos_url":"https://api.github.com/users/anthonydresser/repos","events_url":"https://api.github.com/users/anthonydresser/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydresser/received_events","type":"User","site_admin":false},"body":"What do you mean?","created_at":"2019-11-26T19:19:53Z","updated_at":"2019-11-26T19:19:53Z","html_url":"https://github.com/microsoft/azuredatastudio/pull/8482#discussion_r350934848","pull_request_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/8482","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments/350934848"},"html":{"href":"https://github.com/microsoft/azuredatastudio/pull/8482#discussion_r350934848"},"pull_request":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/8482"}},"in_reply_to_id":350925633},"pull_request":{"url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/8482","id":345491290,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1NDkxMjkw","html_url":"https://github.com/microsoft/azuredatastudio/pull/8482","diff_url":"https://github.com/microsoft/azuredatastudio/pull/8482.diff","patch_url":"https://github.com/microsoft/azuredatastudio/pull/8482.patch","issue_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/8482","number":8482,"state":"open","locked":false,"title":"Default to using extension of the file for editor replacement","user":{"login":"anthonydresser","id":4324725,"node_id":"MDQ6VXNlcjQzMjQ3MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4324725?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonydresser","html_url":"https://github.com/anthonydresser","followers_url":"https://api.github.com/users/anthonydresser/followers","following_url":"https://api.github.com/users/anthonydresser/following{/other_user}","gists_url":"https://api.github.com/users/anthonydresser/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydresser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydresser/subscriptions","organizations_url":"https://api.github.com/users/anthonydresser/orgs","repos_url":"https://api.github.com/users/anthonydresser/repos","events_url":"https://api.github.com/users/anthonydresser/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydresser/received_events","type":"User","site_admin":false},"body":"\r\nThis PR fixes #8479\r\n","created_at":"2019-11-26T01:09:38Z","updated_at":"2019-11-26T19:19:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0779eeae3a84f67282737cd8803f4ec8654a0c87","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/8482/commits","review_comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/8482/comments","review_comment_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/8482/comments","statuses_url":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/4d31df11dd5a39bc50674f1f0de2123f38198d05","head":{"label":"microsoft:bug/showplan","ref":"bug/showplan","sha":"4d31df11dd5a39bc50674f1f0de2123f38198d05","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":109200851,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMDA4NTE=","name":"azuredatastudio","full_name":"microsoft/azuredatastudio","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azuredatastudio","description":"Azure Data Studio is a data management tool that enables working with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.","fork":false,"url":"https://api.github.com/repos/microsoft/azuredatastudio","forks_url":"https://api.github.com/repos/microsoft/azuredatastudio/forks","keys_url":"https://api.github.com/repos/microsoft/azuredatastudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azuredatastudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azuredatastudio/teams","hooks_url":"https://api.github.com/repos/microsoft/azuredatastudio/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azuredatastudio/events","assignees_url":"https://api.github.com/repos/microsoft/azuredatastudio/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azuredatastudio/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/tags","blobs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azuredatastudio/languages","stargazers_url":"https://api.github.com/repos/microsoft/azuredatastudio/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azuredatastudio/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscription","commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azuredatastudio/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azuredatastudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azuredatastudio/merges","archive_url":"https://api.github.com/repos/microsoft/azuredatastudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azuredatastudio/downloads","issues_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azuredatastudio/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azuredatastudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azuredatastudio/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azuredatastudio/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azuredatastudio/deployments","created_at":"2017-11-02T01:00:13Z","updated_at":"2019-11-26T18:40:27Z","pushed_at":"2019-11-26T19:18:01Z","git_url":"git://github.com/microsoft/azuredatastudio.git","ssh_url":"git@github.com:microsoft/azuredatastudio.git","clone_url":"https://github.com/microsoft/azuredatastudio.git","svn_url":"https://github.com/microsoft/azuredatastudio","homepage":"","size":67005,"stargazers_count":5436,"watchers_count":5436,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1719,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":444,"open_issues":1719,"watchers":5436,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"7a389434123a39348326fba756a3954993ec2b4f","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":109200851,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMDA4NTE=","name":"azuredatastudio","full_name":"microsoft/azuredatastudio","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azuredatastudio","description":"Azure Data Studio is a data management tool that enables working with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.","fork":false,"url":"https://api.github.com/repos/microsoft/azuredatastudio","forks_url":"https://api.github.com/repos/microsoft/azuredatastudio/forks","keys_url":"https://api.github.com/repos/microsoft/azuredatastudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azuredatastudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azuredatastudio/teams","hooks_url":"https://api.github.com/repos/microsoft/azuredatastudio/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azuredatastudio/events","assignees_url":"https://api.github.com/repos/microsoft/azuredatastudio/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azuredatastudio/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/tags","blobs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azuredatastudio/languages","stargazers_url":"https://api.github.com/repos/microsoft/azuredatastudio/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azuredatastudio/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscription","commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azuredatastudio/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azuredatastudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azuredatastudio/merges","archive_url":"https://api.github.com/repos/microsoft/azuredatastudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azuredatastudio/downloads","issues_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azuredatastudio/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azuredatastudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azuredatastudio/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azuredatastudio/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azuredatastudio/deployments","created_at":"2017-11-02T01:00:13Z","updated_at":"2019-11-26T18:40:27Z","pushed_at":"2019-11-26T19:18:01Z","git_url":"git://github.com/microsoft/azuredatastudio.git","ssh_url":"git@github.com:microsoft/azuredatastudio.git","clone_url":"https://github.com/microsoft/azuredatastudio.git","svn_url":"https://github.com/microsoft/azuredatastudio","homepage":"","size":67005,"stargazers_count":5436,"watchers_count":5436,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1719,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":444,"open_issues":1719,"watchers":5436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/8482"},"html":{"href":"https://github.com/microsoft/azuredatastudio/pull/8482"},"issue":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/issues/8482"},"comments":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/issues/8482/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/8482/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/8482/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/4d31df11dd5a39bc50674f1f0de2123f38198d05"}},"author_association":"MEMBER"}}
|
{
"id": 109200851,
"name": "microsoft/azuredatastudio",
"url": "https://api.github.com/repos/microsoft/azuredatastudio"
}
|
{
"id": 4324725,
"login": "anthonydresser",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4324725?",
"url": "https://api.github.com/users/anthonydresser"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-11-26T19:19:53 |
10953824815
|
{"actor":{"display_login":"anthonydresser"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/comments/331739485","pull_request_review_id":297782931,"id":331739485,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMTczOTQ4NQ==","diff_hunk":"@@ -134,6 +134,23 @@ Windows, not just the most recent version. Your tests may need version or\n [IsApiPresent](https://docs.microsoft.com/en-us/uwp/api/windows.foundation.metadata.apiinformation.istypepresent) \n checks in order to pass on all versions.\n \n+#### Updating visual tree masters\n+Visual tree dumps are stored [here](https://github.com/microsoft/microsoft-ui-xaml/tree/master/test/MUXControlsTestApp/master) and we use them as the baseline (master) for visual tree verifications. If you make UI changes, visual tree verification tests may fail since the new dump no longer matches with masters. The master files need to be updated to include your latest changes. Visual verification test automatically captures the new visual tree and uploads the dump to test pipeline artifacts. Here are the steps to replace existing masters with the new ones.\n+\n+1. Find your test build.\n+\n+ \n+ \n+\n+2. Download new masters.\n+\n+ \n+ ","path":"docs/developer_guide.md","position":15,"original_position":15,"commit_id":"918a896e59a641e972aa5e795126c515a33c04ed","original_commit_id":"918a896e59a641e972aa5e795126c515a33c04ed","user":{"login":"chingucoding","id":16122379,"node_id":"MDQ6VXNlcjE2MTIyMzc5","avatar_url":"https://avatars1.githubusercontent.com/u/16122379?v=4","gravatar_id":"","url":"https://api.github.com/users/chingucoding","html_url":"https://github.com/chingucoding","followers_url":"https://api.github.com/users/chingucoding/followers","following_url":"https://api.github.com/users/chingucoding/following{/other_user}","gists_url":"https://api.github.com/users/chingucoding/gists{/gist_id}","starred_url":"https://api.github.com/users/chingucoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chingucoding/subscriptions","organizations_url":"https://api.github.com/users/chingucoding/orgs","repos_url":"https://api.github.com/users/chingucoding/repos","events_url":"https://api.github.com/users/chingucoding/events{/privacy}","received_events_url":"https://api.github.com/users/chingucoding/received_events","type":"User","site_admin":false},"body":"How does one get to the artifact explorer? When I used the guide, selecting Artifacts->drop, it just started downloading the whole drop as a zip file. Was I missing something or is this expected to happen ?","created_at":"2019-10-05T09:00:05Z","updated_at":"2019-10-05T09:00:05Z","html_url":"https://github.com/microsoft/microsoft-ui-xaml/pull/1409#discussion_r331739485","pull_request_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/1409","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/comments/331739485"},"html":{"href":"https://github.com/microsoft/microsoft-ui-xaml/pull/1409#discussion_r331739485"},"pull_request":{"href":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/1409"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/1409","id":324842671,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0ODQyNjcx","html_url":"https://github.com/microsoft/microsoft-ui-xaml/pull/1409","diff_url":"https://github.com/microsoft/microsoft-ui-xaml/pull/1409.diff","patch_url":"https://github.com/microsoft/microsoft-ui-xaml/pull/1409.patch","issue_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/1409","number":1409,"state":"open","locked":false,"title":"Doc for updating visual tree masters","user":{"login":"kaiguo","id":4424330,"node_id":"MDQ6VXNlcjQ0MjQzMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/4424330?v=4","gravatar_id":"","url":"https://api.github.com/users/kaiguo","html_url":"https://github.com/kaiguo","followers_url":"https://api.github.com/users/kaiguo/followers","following_url":"https://api.github.com/users/kaiguo/following{/other_user}","gists_url":"https://api.github.com/users/kaiguo/gists{/gist_id}","starred_url":"https://api.github.com/users/kaiguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaiguo/subscriptions","organizations_url":"https://api.github.com/users/kaiguo/orgs","repos_url":"https://api.github.com/users/kaiguo/repos","events_url":"https://api.github.com/users/kaiguo/events{/privacy}","received_events_url":"https://api.github.com/users/kaiguo/received_events","type":"User","site_admin":false},"body":"We recently added bunch of visual tree verification tests. Adding doc about how to update masters for outside contributors.","created_at":"2019-10-04T20:43:04Z","updated_at":"2019-10-05T09:00:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"800d0c8f347bc892ebd7463bc0f42f02426e908d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"microsoft-ui-xaml-codereviews","id":3029824,"node_id":"MDQ6VGVhbTMwMjk4MjQ=","slug":"microsoft-ui-xaml-codereviews","description":"Primary reviewers for the microsoft-ui-xaml repo","privacy":"closed","url":"https://api.github.com/teams/3029824","html_url":"https://github.com/orgs/microsoft/teams/microsoft-ui-xaml-codereviews","members_url":"https://api.github.com/teams/3029824/members{/member}","repositories_url":"https://api.github.com/teams/3029824/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/1409/commits","review_comments_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/1409/comments","review_comment_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/1409/comments","statuses_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/statuses/918a896e59a641e972aa5e795126c515a33c04ed","head":{"label":"microsoft:user/kaiguo/visual-tree-test-doc","ref":"user/kaiguo/visual-tree-test-doc","sha":"918a896e59a641e972aa5e795126c515a33c04ed","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":142480903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0ODA5MDM=","name":"microsoft-ui-xaml","full_name":"microsoft/microsoft-ui-xaml","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/microsoft-ui-xaml","description":"Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications","fork":false,"url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml","forks_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/forks","keys_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/teams","hooks_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/hooks","issue_events_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/events","assignees_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/tags","blobs_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/languages","stargazers_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/stargazers","contributors_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/contributors","subscribers_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/subscribers","subscription_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/subscription","commits_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/merges","archive_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/downloads","issues_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/deployments","created_at":"2018-07-26T18:45:29Z","updated_at":"2019-10-05T03:39:47Z","pushed_at":"2019-10-05T03:39:45Z","git_url":"git://github.com/microsoft/microsoft-ui-xaml.git","ssh_url":"git@github.com:microsoft/microsoft-ui-xaml.git","clone_url":"https://github.com/microsoft/microsoft-ui-xaml.git","svn_url":"https://github.com/microsoft/microsoft-ui-xaml","homepage":"","size":71615,"stargazers_count":1695,"watchers_count":1695,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":434,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":168,"open_issues":434,"watchers":1695,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"45c12e55326c7d88d22e715a46ef84c7daa458f8","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":142480903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0ODA5MDM=","name":"microsoft-ui-xaml","full_name":"microsoft/microsoft-ui-xaml","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/microsoft-ui-xaml","description":"Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications","fork":false,"url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml","forks_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/forks","keys_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/teams","hooks_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/hooks","issue_events_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/events","assignees_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/tags","blobs_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/languages","stargazers_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/stargazers","contributors_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/contributors","subscribers_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/subscribers","subscription_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/subscription","commits_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/merges","archive_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/downloads","issues_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/deployments","created_at":"2018-07-26T18:45:29Z","updated_at":"2019-10-05T03:39:47Z","pushed_at":"2019-10-05T03:39:45Z","git_url":"git://github.com/microsoft/microsoft-ui-xaml.git","ssh_url":"git@github.com:microsoft/microsoft-ui-xaml.git","clone_url":"https://github.com/microsoft/microsoft-ui-xaml.git","svn_url":"https://github.com/microsoft/microsoft-ui-xaml","homepage":"","size":71615,"stargazers_count":1695,"watchers_count":1695,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":434,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":168,"open_issues":434,"watchers":1695,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/1409"},"html":{"href":"https://github.com/microsoft/microsoft-ui-xaml/pull/1409"},"issue":{"href":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/1409"},"comments":{"href":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/1409/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/1409/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/1409/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/statuses/918a896e59a641e972aa5e795126c515a33c04ed"}},"author_association":"MEMBER"}}
|
{
"id": 142480903,
"name": "microsoft/microsoft-ui-xaml",
"url": "https://api.github.com/repos/microsoft/microsoft-ui-xaml"
}
|
{
"id": 16122379,
"login": "chingucoding",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16122379?",
"url": "https://api.github.com/users/chingucoding"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-10-05T09:00:05 |
10565162079
|
{"actor":{"display_login":"chingucoding"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/comments/320503817","pull_request_review_id":283292263,"id":320503817,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDUwMzgxNw==","diff_hunk":"@@ -41,17 +86,44 @@ public static AppCenterTask<bool> IsEnabledAsync()\n return AppCenterTask<bool>.FromCompleted(isEnabled);\n }\n \n+ public static UserInformation GetUserInformationFromIntPtr(IntPtr userInformationPtr)\n+ {\n+ if (userInformationPtr == IntPtr.Zero)\n+ {\n+ return null;\n+ }\n+ var accountId = app_center_unity_auth_user_information_account_id(userInformationPtr);\n+ var accessToken = app_center_unity_auth_user_information_access_token(userInformationPtr);\n+ var idToken = app_center_unity_auth_user_information_id_token(userInformationPtr);\n+ return new UserInformation(accountId, accessToken, idToken);\n+ }\n+\n #region External\n \n [DllImport(\"__Internal\")]\n private static extern IntPtr appcenter_unity_auth_get_type();\n \n+ [DllImport(\"__Internal\")]\n+ private static extern void appcenter_unity_auth_sign_in_with_completion_handler(NativeSignInCompletionHandler functionPtr);","path":"Assets/AppCenter/Plugins/AppCenterSDK/Auth/iOS/AuthInternal.cs","position":98,"original_position":98,"commit_id":"7c8f48f09f484f9768ee69d212dcf030e8b87105","original_commit_id":"7c8f48f09f484f9768ee69d212dcf030e8b87105","user":{"login":"jaelim-ms","id":19935783,"node_id":"MDQ6VXNlcjE5OTM1Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/19935783?v=4","gravatar_id":"","url":"https://api.github.com/users/jaelim-ms","html_url":"https://github.com/jaelim-ms","followers_url":"https://api.github.com/users/jaelim-ms/followers","following_url":"https://api.github.com/users/jaelim-ms/following{/other_user}","gists_url":"https://api.github.com/users/jaelim-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/jaelim-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaelim-ms/subscriptions","organizations_url":"https://api.github.com/users/jaelim-ms/orgs","repos_url":"https://api.github.com/users/jaelim-ms/repos","events_url":"https://api.github.com/users/jaelim-ms/events{/privacy}","received_events_url":"https://api.github.com/users/jaelim-ms/received_events","type":"User","site_admin":false},"body":"Consider this one and sign_out methods below is_enabled method. Just an order.","created_at":"2019-09-03T22:25:26Z","updated_at":"2019-09-03T22:33:06Z","html_url":"https://github.com/microsoft/appcenter-sdk-unity/pull/307#discussion_r320503817","pull_request_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/307","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/comments/320503817"},"html":{"href":"https://github.com/microsoft/appcenter-sdk-unity/pull/307#discussion_r320503817"},"pull_request":{"href":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/307"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/307","id":312034138,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyMDM0MTM4","html_url":"https://github.com/microsoft/appcenter-sdk-unity/pull/307","diff_url":"https://github.com/microsoft/appcenter-sdk-unity/pull/307.diff","patch_url":"https://github.com/microsoft/appcenter-sdk-unity/pull/307.patch","issue_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues/307","number":307,"state":"open","locked":false,"title":"Add iOS Auth binding","user":{"login":"yuqche","id":53840625,"node_id":"MDQ6VXNlcjUzODQwNjI1","avatar_url":"https://avatars0.githubusercontent.com/u/53840625?v=4","gravatar_id":"","url":"https://api.github.com/users/yuqche","html_url":"https://github.com/yuqche","followers_url":"https://api.github.com/users/yuqche/followers","following_url":"https://api.github.com/users/yuqche/following{/other_user}","gists_url":"https://api.github.com/users/yuqche/gists{/gist_id}","starred_url":"https://api.github.com/users/yuqche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuqche/subscriptions","organizations_url":"https://api.github.com/users/yuqche/orgs","repos_url":"https://api.github.com/users/yuqche/repos","events_url":"https://api.github.com/users/yuqche/events{/privacy}","received_events_url":"https://api.github.com/users/yuqche/received_events","type":"User","site_admin":false},"body":"Add Auth binding in Unity for iOS.\r\n\r\nModify AppCenterTask to handle exception properly when sign in encounters an exception\r\n\r\nMove NSErrorHelper from Crashes to Core as both Crashes and Auth use NSErrorHelper\r\n\r\n[AB#66423](https://dev.azure.com/msmobilecenter/454a20a9-dfe6-4c1f-8ae8-417f76adb472/_workitems/edit/66423)","created_at":"2019-08-28T21:00:43Z","updated_at":"2019-09-03T22:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb441e0307f6a95ad1cfe5ff956c50eeed32f109","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/307/commits","review_comments_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/307/comments","review_comment_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues/307/comments","statuses_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/statuses/7c8f48f09f484f9768ee69d212dcf030e8b87105","head":{"label":"microsoft:feature/auth-binding-ios","ref":"feature/auth-binding-ios","sha":"7c8f48f09f484f9768ee69d212dcf030e8b87105","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":96920930,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkyMDkzMA==","name":"appcenter-sdk-unity","full_name":"microsoft/appcenter-sdk-unity","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/appcenter-sdk-unity","description":"Development repository for the App Center SDK for Unity platforms, including Android, iOS, and UWP","fork":false,"url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity","forks_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/forks","keys_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/teams","hooks_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/hooks","issue_events_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/events","assignees_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/tags","blobs_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/languages","stargazers_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/stargazers","contributors_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/contributors","subscribers_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/subscribers","subscription_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/subscription","commits_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/merges","archive_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/downloads","issues_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/deployments","created_at":"2017-07-11T17:49:15Z","updated_at":"2019-09-03T18:44:09Z","pushed_at":"2019-09-03T20:55:51Z","git_url":"git://github.com/microsoft/appcenter-sdk-unity.git","ssh_url":"git@github.com:microsoft/appcenter-sdk-unity.git","clone_url":"https://github.com/microsoft/appcenter-sdk-unity.git","svn_url":"https://github.com/microsoft/appcenter-sdk-unity","homepage":"","size":16258,"stargazers_count":30,"watchers_count":30,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":12,"watchers":30,"default_branch":"develop"}},"base":{"label":"microsoft:feature/auth","ref":"feature/auth","sha":"f642f773caa3e0f2ec2f46ce05d7dbfdf9c1c720","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":96920930,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkyMDkzMA==","name":"appcenter-sdk-unity","full_name":"microsoft/appcenter-sdk-unity","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/appcenter-sdk-unity","description":"Development repository for the App Center SDK for Unity platforms, including Android, iOS, and UWP","fork":false,"url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity","forks_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/forks","keys_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/teams","hooks_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/hooks","issue_events_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/events","assignees_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/tags","blobs_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/languages","stargazers_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/stargazers","contributors_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/contributors","subscribers_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/subscribers","subscription_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/subscription","commits_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/merges","archive_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/downloads","issues_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/deployments","created_at":"2017-07-11T17:49:15Z","updated_at":"2019-09-03T18:44:09Z","pushed_at":"2019-09-03T20:55:51Z","git_url":"git://github.com/microsoft/appcenter-sdk-unity.git","ssh_url":"git@github.com:microsoft/appcenter-sdk-unity.git","clone_url":"https://github.com/microsoft/appcenter-sdk-unity.git","svn_url":"https://github.com/microsoft/appcenter-sdk-unity","homepage":"","size":16258,"stargazers_count":30,"watchers_count":30,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":12,"watchers":30,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/307"},"html":{"href":"https://github.com/microsoft/appcenter-sdk-unity/pull/307"},"issue":{"href":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues/307"},"comments":{"href":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/issues/307/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/307/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/pulls/307/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/appcenter-sdk-unity/statuses/7c8f48f09f484f9768ee69d212dcf030e8b87105"}},"author_association":"NONE"}}
|
{
"id": 96920930,
"name": "microsoft/appcenter-sdk-unity",
"url": "https://api.github.com/repos/microsoft/appcenter-sdk-unity"
}
|
{
"id": 19935783,
"login": "jaelim-ms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19935783?",
"url": "https://api.github.com/users/jaelim-ms"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-09-03T22:25:26 |
10340605784
|
{"actor":{"display_login":"jaelim-ms"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/STL/pulls/comments/340952717","pull_request_review_id":309633444,"id":340952717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDk1MjcxNw==","diff_hunk":"@@ -1571,6 +1575,18 @@ template <class _Iter, class _Alloc = allocator<_Iter_value_t<_Iter>>,\n deque(_Iter, _Iter, _Alloc = _Alloc())->deque<_Iter_value_t<_Iter>, _Alloc>;\r\n #endif // _HAS_CXX17\r\n \r\n+#if _HAS_CXX20\r\n+template <class _Ty, class _Alloc, class _Pr>\r\n+void erase_if(deque<_Ty, _Alloc>& _Cont, _Pr _Pred) {\r\n+ _Erase_remove_if(_Cont, _Pass_fn(_Pred));\r\n+}\r\n+\r\n+template <class _Ty, class _Alloc, class _Uty>\r\n+void erase(deque<_Ty, _Alloc>& _Cont, const _Uty& _Val) {\r","path":"stl/inc/deque","position":22,"original_position":22,"commit_id":"87684a602a91f6380c873ad31ce84718fa3169ef","original_commit_id":"87684a602a91f6380c873ad31ce84718fa3169ef","user":{"login":"StephanTLavavej","id":4231088,"node_id":"MDQ6VXNlcjQyMzEwODg=","avatar_url":"https://avatars3.githubusercontent.com/u/4231088?v=4","gravatar_id":"","url":"https://api.github.com/users/StephanTLavavej","html_url":"https://github.com/StephanTLavavej","followers_url":"https://api.github.com/users/StephanTLavavej/followers","following_url":"https://api.github.com/users/StephanTLavavej/following{/other_user}","gists_url":"https://api.github.com/users/StephanTLavavej/gists{/gist_id}","starred_url":"https://api.github.com/users/StephanTLavavej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephanTLavavej/subscriptions","organizations_url":"https://api.github.com/users/StephanTLavavej/orgs","repos_url":"https://api.github.com/users/StephanTLavavej/repos","events_url":"https://api.github.com/users/StephanTLavavej/events{/privacy}","received_events_url":"https://api.github.com/users/StephanTLavavej/received_events","type":"User","site_admin":false},"body":"Archaeology: This was reordered between the Library Fundamentals v2 TS and the Standard. I liked having `erase_if()` first because it's the \"more fundamental\" form, but Casey's right about our general convention.","created_at":"2019-10-31T04:05:13Z","updated_at":"2019-10-31T04:15:00Z","html_url":"https://github.com/microsoft/STL/pull/236#discussion_r340952717","pull_request_url":"https://api.github.com/repos/microsoft/STL/pulls/236","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/STL/pulls/comments/340952717"},"html":{"href":"https://github.com/microsoft/STL/pull/236#discussion_r340952717"},"pull_request":{"href":"https://api.github.com/repos/microsoft/STL/pulls/236"}},"in_reply_to_id":340857309},"pull_request":{"url":"https://api.github.com/repos/microsoft/STL/pulls/236","id":334424864,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0NDI0ODY0","html_url":"https://github.com/microsoft/STL/pull/236","diff_url":"https://github.com/microsoft/STL/pull/236.diff","patch_url":"https://github.com/microsoft/STL/pull/236.patch","issue_url":"https://api.github.com/repos/microsoft/STL/issues/236","number":236,"state":"open","locked":false,"title":"P1209R0 erase_if(), erase()","user":{"login":"SuperWig","id":2692096,"node_id":"MDQ6VXNlcjI2OTIwOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2692096?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperWig","html_url":"https://github.com/SuperWig","followers_url":"https://api.github.com/users/SuperWig/followers","following_url":"https://api.github.com/users/SuperWig/following{/other_user}","gists_url":"https://api.github.com/users/SuperWig/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperWig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperWig/subscriptions","organizations_url":"https://api.github.com/users/SuperWig/orgs","repos_url":"https://api.github.com/users/SuperWig/repos","events_url":"https://api.github.com/users/SuperWig/events{/privacy}","received_events_url":"https://api.github.com/users/SuperWig/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nResolves #55.\r\n\r\n# Checklist\r\n\r\nIf you're unsure about a box, leave it unchecked. A maintainer will help you.\r\n\r\n- [x] I understand README.md. I also understand that acceptance of\r\n community PRs will be delayed until the test and CI systems are online.\r\n- [x] Identifiers in product code changes are properly `_Ugly` as per\r\n https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.\r\n- [ ] The STL builds successfully and all tests have passed (must be manually\r\n verified by an STL maintainer before CI is online, leave this unchecked for\r\n initial submission).\r\n- [x] These changes introduce no known ABI breaks (adding members, renaming\r\n members, adding virtual functions, changing whether a type is an aggregate\r\n or trivially copyable, etc.).\r\n- [x] These changes were written from scratch using only this repository and\r\n the C++ Working Draft as a reference (and any other cited standards).\r\n If they were derived from a project that's already listed in NOTICE.txt,\r\n that's fine, but please mention it. If they were derived from any other\r\n project (including Boost and libc++, which are not yet listed in\r\n NOTICE.txt), you *must* mention it here, so we can determine whether the\r\n license is compatible and what else needs to be done.\r\n","created_at":"2019-10-30T17:58:54Z","updated_at":"2019-10-31T04:14:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3327ae5b98d48a5fc29c9181bbd6ce7125db554","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/STL/pulls/236/commits","review_comments_url":"https://api.github.com/repos/microsoft/STL/pulls/236/comments","review_comment_url":"https://api.github.com/repos/microsoft/STL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/STL/issues/236/comments","statuses_url":"https://api.github.com/repos/microsoft/STL/statuses/87684a602a91f6380c873ad31ce84718fa3169ef","head":{"label":"SuperWig:erase","ref":"erase","sha":"87684a602a91f6380c873ad31ce84718fa3169ef","user":{"login":"SuperWig","id":2692096,"node_id":"MDQ6VXNlcjI2OTIwOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2692096?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperWig","html_url":"https://github.com/SuperWig","followers_url":"https://api.github.com/users/SuperWig/followers","following_url":"https://api.github.com/users/SuperWig/following{/other_user}","gists_url":"https://api.github.com/users/SuperWig/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperWig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperWig/subscriptions","organizations_url":"https://api.github.com/users/SuperWig/orgs","repos_url":"https://api.github.com/users/SuperWig/repos","events_url":"https://api.github.com/users/SuperWig/events{/privacy}","received_events_url":"https://api.github.com/users/SuperWig/received_events","type":"User","site_admin":false},"repo":{"id":218587370,"node_id":"MDEwOlJlcG9zaXRvcnkyMTg1ODczNzA=","name":"STL","full_name":"SuperWig/STL","private":false,"owner":{"login":"SuperWig","id":2692096,"node_id":"MDQ6VXNlcjI2OTIwOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2692096?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperWig","html_url":"https://github.com/SuperWig","followers_url":"https://api.github.com/users/SuperWig/followers","following_url":"https://api.github.com/users/SuperWig/following{/other_user}","gists_url":"https://api.github.com/users/SuperWig/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperWig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperWig/subscriptions","organizations_url":"https://api.github.com/users/SuperWig/orgs","repos_url":"https://api.github.com/users/SuperWig/repos","events_url":"https://api.github.com/users/SuperWig/events{/privacy}","received_events_url":"https://api.github.com/users/SuperWig/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SuperWig/STL","description":"MSVC's implementation of the C++ Standard Library.","fork":true,"url":"https://api.github.com/repos/SuperWig/STL","forks_url":"https://api.github.com/repos/SuperWig/STL/forks","keys_url":"https://api.github.com/repos/SuperWig/STL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperWig/STL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperWig/STL/teams","hooks_url":"https://api.github.com/repos/SuperWig/STL/hooks","issue_events_url":"https://api.github.com/repos/SuperWig/STL/issues/events{/number}","events_url":"https://api.github.com/repos/SuperWig/STL/events","assignees_url":"https://api.github.com/repos/SuperWig/STL/assignees{/user}","branches_url":"https://api.github.com/repos/SuperWig/STL/branches{/branch}","tags_url":"https://api.github.com/repos/SuperWig/STL/tags","blobs_url":"https://api.github.com/repos/SuperWig/STL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperWig/STL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperWig/STL/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperWig/STL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperWig/STL/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperWig/STL/languages","stargazers_url":"https://api.github.com/repos/SuperWig/STL/stargazers","contributors_url":"https://api.github.com/repos/SuperWig/STL/contributors","subscribers_url":"https://api.github.com/repos/SuperWig/STL/subscribers","subscription_url":"https://api.github.com/repos/SuperWig/STL/subscription","commits_url":"https://api.github.com/repos/SuperWig/STL/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperWig/STL/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperWig/STL/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperWig/STL/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperWig/STL/contents/{+path}","compare_url":"https://api.github.com/repos/SuperWig/STL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperWig/STL/merges","archive_url":"https://api.github.com/repos/SuperWig/STL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperWig/STL/downloads","issues_url":"https://api.github.com/repos/SuperWig/STL/issues{/number}","pulls_url":"https://api.github.com/repos/SuperWig/STL/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperWig/STL/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperWig/STL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperWig/STL/labels{/name}","releases_url":"https://api.github.com/repos/SuperWig/STL/releases{/id}","deployments_url":"https://api.github.com/repos/SuperWig/STL/deployments","created_at":"2019-10-30T17:43:39Z","updated_at":"2019-10-30T17:43:40Z","pushed_at":"2019-10-30T17:48:51Z","git_url":"git://github.com/SuperWig/STL.git","ssh_url":"git@github.com:SuperWig/STL.git","clone_url":"https://github.com/SuperWig/STL.git","svn_url":"https://github.com/SuperWig/STL","homepage":null,"size":2242,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"b9eb3209402d701287e755358d159d763201e96c","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":204593825,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ1OTM4MjU=","name":"STL","full_name":"microsoft/STL","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/STL","description":"MSVC's implementation of the C++ Standard Library.","fork":false,"url":"https://api.github.com/repos/microsoft/STL","forks_url":"https://api.github.com/repos/microsoft/STL/forks","keys_url":"https://api.github.com/repos/microsoft/STL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/STL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/STL/teams","hooks_url":"https://api.github.com/repos/microsoft/STL/hooks","issue_events_url":"https://api.github.com/repos/microsoft/STL/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/STL/events","assignees_url":"https://api.github.com/repos/microsoft/STL/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/STL/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/STL/tags","blobs_url":"https://api.github.com/repos/microsoft/STL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/STL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/STL/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/STL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/STL/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/STL/languages","stargazers_url":"https://api.github.com/repos/microsoft/STL/stargazers","contributors_url":"https://api.github.com/repos/microsoft/STL/contributors","subscribers_url":"https://api.github.com/repos/microsoft/STL/subscribers","subscription_url":"https://api.github.com/repos/microsoft/STL/subscription","commits_url":"https://api.github.com/repos/microsoft/STL/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/STL/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/STL/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/STL/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/STL/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/STL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/STL/merges","archive_url":"https://api.github.com/repos/microsoft/STL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/STL/downloads","issues_url":"https://api.github.com/repos/microsoft/STL/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/STL/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/STL/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/STL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/STL/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/STL/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/STL/deployments","created_at":"2019-08-27T01:31:18Z","updated_at":"2019-10-31T03:13:24Z","pushed_at":"2019-10-31T02:06:29Z","git_url":"git://github.com/microsoft/STL.git","ssh_url":"git@github.com:microsoft/STL.git","clone_url":"https://github.com/microsoft/STL.git","svn_url":"https://github.com/microsoft/STL","homepage":null,"size":2241,"stargazers_count":4256,"watchers_count":4256,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":404,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":123,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":404,"open_issues":123,"watchers":4256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/STL/pulls/236"},"html":{"href":"https://github.com/microsoft/STL/pull/236"},"issue":{"href":"https://api.github.com/repos/microsoft/STL/issues/236"},"comments":{"href":"https://api.github.com/repos/microsoft/STL/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/STL/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/STL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/STL/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/STL/statuses/87684a602a91f6380c873ad31ce84718fa3169ef"}},"author_association":"NONE"}}
|
{
"id": 204593825,
"name": "microsoft/STL",
"url": "https://api.github.com/repos/microsoft/STL"
}
|
{
"id": 4231088,
"login": "StephanTLavavej",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4231088?",
"url": "https://api.github.com/users/StephanTLavavej"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-10-31T04:05:13 |
10753925476
|
{"actor":{"display_login":"StephanTLavavej"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/comments/327147427","pull_request_review_id":291820102,"id":327147427,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNzE0NzQyNw==","diff_hunk":"@@ -0,0 +1,45 @@\n+import tl = require(\"azure-pipelines-task-lib/task\");\n+import path = require(\"path\");\n+\n+import armDeployTaskParameters = require(\"./models/ARMDeployTaskParameters\");\n+import resourceGroup = require(\"./operations/ResourceGroup\");\n+import armResource = require(\"azure-arm-rest-v2/azure-arm-resource\");\n+import armManagementGroup = require(\"azure-arm-rest-v2/azure-arm-management-group\");\n+import armSubscription = require(\"azure-arm-rest-v2/azure-arm-subscription\");\n+import { DeploymentParameters } from \"./operations/DeploymentParameters\";\n+import { DeploymentScopeBase } from \"./operations/DeploymentScopeBase\";\n+\n+function run(): Promise<void> {\n+ var armTemplateDeploymentTaskParameters = new armDeployTaskParameters.ARMDeployTaskParameters();\n+ return armTemplateDeploymentTaskParameters.getARMTemplateDeploymentTaskParameters().then((taskParameters) => {\n+ if(taskParameters.deploymentScope === \"Management Group\"){\n+ var deploymentParameters = new DeploymentParameters({}, taskParameters.location);\n+ var managementGroupOperationsController = new DeploymentScopeBase(new armManagementGroup.ManagementGroupManagementClient(taskParameters.credentials, taskParameters.managementGroupId), taskParameters, deploymentParameters);","path":"Tasks/AzureResourceManagerTemplateDeploymentV3/main.ts","position":17,"original_position":17,"commit_id":"8c310f29651ab8db277e1d78a6b909dd4f9ee752","original_commit_id":"8c310f29651ab8db277e1d78a6b909dd4f9ee752","user":{"login":"vinodkumar3","id":49094312,"node_id":"MDQ6VXNlcjQ5MDk0MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/49094312?v=4","gravatar_id":"","url":"https://api.github.com/users/vinodkumar3","html_url":"https://github.com/vinodkumar3","followers_url":"https://api.github.com/users/vinodkumar3/followers","following_url":"https://api.github.com/users/vinodkumar3/following{/other_user}","gists_url":"https://api.github.com/users/vinodkumar3/gists{/gist_id}","starred_url":"https://api.github.com/users/vinodkumar3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinodkumar3/subscriptions","organizations_url":"https://api.github.com/users/vinodkumar3/orgs","repos_url":"https://api.github.com/users/vinodkumar3/repos","events_url":"https://api.github.com/users/vinodkumar3/events{/privacy}","received_events_url":"https://api.github.com/users/vinodkumar3/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-09-23T14:30:21Z","updated_at":"2019-09-23T14:30:22Z","html_url":"https://github.com/microsoft/azure-pipelines-tasks/pull/11404#discussion_r327147427","pull_request_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/11404","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/comments/327147427"},"html":{"href":"https://github.com/microsoft/azure-pipelines-tasks/pull/11404#discussion_r327147427"},"pull_request":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/11404"}},"in_reply_to_id":327118998},"pull_request":{"url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/11404","id":320290711,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwMjkwNzEx","html_url":"https://github.com/microsoft/azure-pipelines-tasks/pull/11404","diff_url":"https://github.com/microsoft/azure-pipelines-tasks/pull/11404.diff","patch_url":"https://github.com/microsoft/azure-pipelines-tasks/pull/11404.patch","issue_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/11404","number":11404,"state":"open","locked":false,"title":"Implemented ARM Deployment task","user":{"login":"vinodkumar3","id":49094312,"node_id":"MDQ6VXNlcjQ5MDk0MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/49094312?v=4","gravatar_id":"","url":"https://api.github.com/users/vinodkumar3","html_url":"https://github.com/vinodkumar3","followers_url":"https://api.github.com/users/vinodkumar3/followers","following_url":"https://api.github.com/users/vinodkumar3/following{/other_user}","gists_url":"https://api.github.com/users/vinodkumar3/gists{/gist_id}","starred_url":"https://api.github.com/users/vinodkumar3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinodkumar3/subscriptions","organizations_url":"https://api.github.com/users/vinodkumar3/orgs","repos_url":"https://api.github.com/users/vinodkumar3/repos","events_url":"https://api.github.com/users/vinodkumar3/events{/privacy}","received_events_url":"https://api.github.com/users/vinodkumar3/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-09-23T13:19:53Z","updated_at":"2019-09-23T14:30:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b17d322d0782ee04103883deaa57a5f3abc6e5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/11404/commits","review_comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/11404/comments","review_comment_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/11404/comments","statuses_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/statuses/8c310f29651ab8db277e1d78a6b909dd4f9ee752","head":{"label":"microsoft:users/kuvinod-armdeploytask","ref":"users/kuvinod-armdeploytask","sha":"8c310f29651ab8db277e1d78a6b909dd4f9ee752","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYzMTY3Mw==","name":"azure-pipelines-tasks","full_name":"microsoft/azure-pipelines-tasks","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azure-pipelines-tasks","description":"Tasks for Azure Pipelines","fork":false,"url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks","forks_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/forks","keys_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/teams","hooks_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/events","assignees_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/tags","blobs_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/languages","stargazers_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/subscription","commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/merges","archive_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/downloads","issues_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2019-09-23T10:01:47Z","pushed_at":"2019-09-23T13:19:54Z","git_url":"git://github.com/microsoft/azure-pipelines-tasks.git","ssh_url":"git@github.com:microsoft/azure-pipelines-tasks.git","clone_url":"https://github.com/microsoft/azure-pipelines-tasks.git","svn_url":"https://github.com/microsoft/azure-pipelines-tasks","homepage":"https://aka.ms/tfbuild","size":413075,"stargazers_count":1658,"watchers_count":1658,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1288,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":705,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1288,"open_issues":705,"watchers":1658,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"349e8abebc499eeef5a2a3d3d930d18988007622","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYzMTY3Mw==","name":"azure-pipelines-tasks","full_name":"microsoft/azure-pipelines-tasks","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azure-pipelines-tasks","description":"Tasks for Azure Pipelines","fork":false,"url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks","forks_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/forks","keys_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/teams","hooks_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/events","assignees_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/tags","blobs_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/languages","stargazers_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/subscription","commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/merges","archive_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/downloads","issues_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2019-09-23T10:01:47Z","pushed_at":"2019-09-23T13:19:54Z","git_url":"git://github.com/microsoft/azure-pipelines-tasks.git","ssh_url":"git@github.com:microsoft/azure-pipelines-tasks.git","clone_url":"https://github.com/microsoft/azure-pipelines-tasks.git","svn_url":"https://github.com/microsoft/azure-pipelines-tasks","homepage":"https://aka.ms/tfbuild","size":413075,"stargazers_count":1658,"watchers_count":1658,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1288,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":705,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1288,"open_issues":705,"watchers":1658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/11404"},"html":{"href":"https://github.com/microsoft/azure-pipelines-tasks/pull/11404"},"issue":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/11404"},"comments":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/11404/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/11404/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/11404/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/statuses/8c310f29651ab8db277e1d78a6b909dd4f9ee752"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27631673,
"name": "microsoft/azure-pipelines-tasks",
"url": "https://api.github.com/repos/microsoft/azure-pipelines-tasks"
}
|
{
"id": 49094312,
"login": "vinodkumar3",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49094312?",
"url": "https://api.github.com/users/vinodkumar3"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-09-23T14:30:21 |
10474435753
|
{"actor":{"display_login":"vinodkumar3"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/nni/pulls/comments/271112760","pull_request_review_id":221423248,"id":271112760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTExMjc2MA==","diff_hunk":"@@ -97,4 +97,7 @@ Trial configuration in frameworkcontroller mode have the following configuration\n * frameworkAttemptCompletionPolicy: the policy to run framework, please refer the [user-manual](https://github.com/Microsoft/frameworkcontroller/blob/master/doc/user-manual.md#frameworkattemptcompletionpolicy) to get the specific information. Users could use the policy to control the pod, for example, if ps does not stop, only worker stops, this completionpolicy could helps stop ps.\n \n ## How to run example\n-After you prepare a config file, you could run your experiment by nnictl. The way to start an experiment on frameworkcontroller is similar to kubeflow, please refer the [document](./KubeflowMode.md) for more information.\n\\ No newline at end of file\n+After you prepare a config file, you could run your experiment by nnictl. The way to start an experiment on frameworkcontroller is similar to kubeflow, please refer the [document](./KubeflowMode.md) for more information.\n+\n+## version check","path":"docs/en_US/FrameworkControllerMode.md","position":8,"original_position":8,"commit_id":"d70481a2e104acc86ccc2fbf798aff71472ae753","original_commit_id":"acb29b5b0766ad38010456be3c5bb8e6cd6d5917","user":{"login":"SparkSnail","id":22682999,"node_id":"MDQ6VXNlcjIyNjgyOTk5","avatar_url":"https://avatars2.githubusercontent.com/u/22682999?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkSnail","html_url":"https://github.com/SparkSnail","followers_url":"https://api.github.com/users/SparkSnail/followers","following_url":"https://api.github.com/users/SparkSnail/following{/other_user}","gists_url":"https://api.github.com/users/SparkSnail/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkSnail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkSnail/subscriptions","organizations_url":"https://api.github.com/users/SparkSnail/orgs","repos_url":"https://api.github.com/users/SparkSnail/repos","events_url":"https://api.github.com/users/SparkSnail/events{/privacy}","received_events_url":"https://api.github.com/users/SparkSnail/received_events","type":"User","site_admin":false},"body":"added version information.","created_at":"2019-04-02T02:17:46Z","updated_at":"2019-04-02T02:17:46Z","html_url":"https://github.com/Microsoft/nni/pull/947#discussion_r271112760","pull_request_url":"https://api.github.com/repos/Microsoft/nni/pulls/947","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nni/pulls/comments/271112760"},"html":{"href":"https://github.com/Microsoft/nni/pull/947#discussion_r271112760"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/nni/pulls/947"}},"in_reply_to_id":270821890},"pull_request":{"url":"https://api.github.com/repos/Microsoft/nni/pulls/947","id":266194469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2MTk0NDY5","html_url":"https://github.com/Microsoft/nni/pull/947","diff_url":"https://github.com/Microsoft/nni/pull/947.diff","patch_url":"https://github.com/Microsoft/nni/pull/947.patch","issue_url":"https://api.github.com/repos/Microsoft/nni/issues/947","number":947,"state":"open","locked":false,"title":"Add version check document in PAI, remote, kubeflow and frameworkcontroller","user":{"login":"SparkSnail","id":22682999,"node_id":"MDQ6VXNlcjIyNjgyOTk5","avatar_url":"https://avatars2.githubusercontent.com/u/22682999?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkSnail","html_url":"https://github.com/SparkSnail","followers_url":"https://api.github.com/users/SparkSnail/followers","following_url":"https://api.github.com/users/SparkSnail/following{/other_user}","gists_url":"https://api.github.com/users/SparkSnail/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkSnail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkSnail/subscriptions","organizations_url":"https://api.github.com/users/SparkSnail/orgs","repos_url":"https://api.github.com/users/SparkSnail/repos","events_url":"https://api.github.com/users/SparkSnail/events{/privacy}","received_events_url":"https://api.github.com/users/SparkSnail/received_events","type":"User","site_admin":false},"body":"1. Add version check document\r\n2. Add try catch in gpu scheduler to fix UT","created_at":"2019-04-01T11:10:14Z","updated_at":"2019-04-02T02:17:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"206cd5fe0a7704f7c6b36b10ab189c70ca55cbf9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/nni/pulls/947/commits","review_comments_url":"https://api.github.com/repos/Microsoft/nni/pulls/947/comments","review_comment_url":"https://api.github.com/repos/Microsoft/nni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/nni/issues/947/comments","statuses_url":"https://api.github.com/repos/Microsoft/nni/statuses/d70481a2e104acc86ccc2fbf798aff71472ae753","head":{"label":"SparkSnail:v0.6","ref":"v0.6","sha":"d70481a2e104acc86ccc2fbf798aff71472ae753","user":{"login":"SparkSnail","id":22682999,"node_id":"MDQ6VXNlcjIyNjgyOTk5","avatar_url":"https://avatars2.githubusercontent.com/u/22682999?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkSnail","html_url":"https://github.com/SparkSnail","followers_url":"https://api.github.com/users/SparkSnail/followers","following_url":"https://api.github.com/users/SparkSnail/following{/other_user}","gists_url":"https://api.github.com/users/SparkSnail/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkSnail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkSnail/subscriptions","organizations_url":"https://api.github.com/users/SparkSnail/orgs","repos_url":"https://api.github.com/users/SparkSnail/repos","events_url":"https://api.github.com/users/SparkSnail/events{/privacy}","received_events_url":"https://api.github.com/users/SparkSnail/received_events","type":"User","site_admin":false},"repo":{"id":148134337,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxMzQzMzc=","name":"nni","full_name":"SparkSnail/nni","private":false,"owner":{"login":"SparkSnail","id":22682999,"node_id":"MDQ6VXNlcjIyNjgyOTk5","avatar_url":"https://avatars2.githubusercontent.com/u/22682999?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkSnail","html_url":"https://github.com/SparkSnail","followers_url":"https://api.github.com/users/SparkSnail/followers","following_url":"https://api.github.com/users/SparkSnail/following{/other_user}","gists_url":"https://api.github.com/users/SparkSnail/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkSnail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkSnail/subscriptions","organizations_url":"https://api.github.com/users/SparkSnail/orgs","repos_url":"https://api.github.com/users/SparkSnail/repos","events_url":"https://api.github.com/users/SparkSnail/events{/privacy}","received_events_url":"https://api.github.com/users/SparkSnail/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SparkSnail/nni","description":"An open source toolkit for neural architecture search, hyper-parameter optimization and optimizer design.","fork":true,"url":"https://api.github.com/repos/SparkSnail/nni","forks_url":"https://api.github.com/repos/SparkSnail/nni/forks","keys_url":"https://api.github.com/repos/SparkSnail/nni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SparkSnail/nni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SparkSnail/nni/teams","hooks_url":"https://api.github.com/repos/SparkSnail/nni/hooks","issue_events_url":"https://api.github.com/repos/SparkSnail/nni/issues/events{/number}","events_url":"https://api.github.com/repos/SparkSnail/nni/events","assignees_url":"https://api.github.com/repos/SparkSnail/nni/assignees{/user}","branches_url":"https://api.github.com/repos/SparkSnail/nni/branches{/branch}","tags_url":"https://api.github.com/repos/SparkSnail/nni/tags","blobs_url":"https://api.github.com/repos/SparkSnail/nni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SparkSnail/nni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SparkSnail/nni/git/refs{/sha}","trees_url":"https://api.github.com/repos/SparkSnail/nni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SparkSnail/nni/statuses/{sha}","languages_url":"https://api.github.com/repos/SparkSnail/nni/languages","stargazers_url":"https://api.github.com/repos/SparkSnail/nni/stargazers","contributors_url":"https://api.github.com/repos/SparkSnail/nni/contributors","subscribers_url":"https://api.github.com/repos/SparkSnail/nni/subscribers","subscription_url":"https://api.github.com/repos/SparkSnail/nni/subscription","commits_url":"https://api.github.com/repos/SparkSnail/nni/commits{/sha}","git_commits_url":"https://api.github.com/repos/SparkSnail/nni/git/commits{/sha}","comments_url":"https://api.github.com/repos/SparkSnail/nni/comments{/number}","issue_comment_url":"https://api.github.com/repos/SparkSnail/nni/issues/comments{/number}","contents_url":"https://api.github.com/repos/SparkSnail/nni/contents/{+path}","compare_url":"https://api.github.com/repos/SparkSnail/nni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SparkSnail/nni/merges","archive_url":"https://api.github.com/repos/SparkSnail/nni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SparkSnail/nni/downloads","issues_url":"https://api.github.com/repos/SparkSnail/nni/issues{/number}","pulls_url":"https://api.github.com/repos/SparkSnail/nni/pulls{/number}","milestones_url":"https://api.github.com/repos/SparkSnail/nni/milestones{/number}","notifications_url":"https://api.github.com/repos/SparkSnail/nni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SparkSnail/nni/labels{/name}","releases_url":"https://api.github.com/repos/SparkSnail/nni/releases{/id}","deployments_url":"https://api.github.com/repos/SparkSnail/nni/deployments","created_at":"2018-09-10T09:51:55Z","updated_at":"2019-04-01T03:38:10Z","pushed_at":"2019-04-01T16:56:17Z","git_url":"git://github.com/SparkSnail/nni.git","ssh_url":"git@github.com:SparkSnail/nni.git","clone_url":"https://github.com/SparkSnail/nni.git","svn_url":"https://github.com/SparkSnail/nni","homepage":"","size":9251,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:v0.6","ref":"v0.6","sha":"c49c24c483f42bb45ffa67e2955f730bbc99ad02","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":135673451,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2NzM0NTE=","name":"nni","full_name":"Microsoft/nni","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/nni","description":"An open source AutoML toolkit for neural architecture search and hyper-parameter tuning.","fork":false,"url":"https://api.github.com/repos/Microsoft/nni","forks_url":"https://api.github.com/repos/Microsoft/nni/forks","keys_url":"https://api.github.com/repos/Microsoft/nni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/nni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/nni/teams","hooks_url":"https://api.github.com/repos/Microsoft/nni/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/nni/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/nni/events","assignees_url":"https://api.github.com/repos/Microsoft/nni/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/nni/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/nni/tags","blobs_url":"https://api.github.com/repos/Microsoft/nni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/nni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/nni/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/nni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/nni/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/nni/languages","stargazers_url":"https://api.github.com/repos/Microsoft/nni/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/nni/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/nni/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/nni/subscription","commits_url":"https://api.github.com/repos/Microsoft/nni/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/nni/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/nni/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/nni/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/nni/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/nni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/nni/merges","archive_url":"https://api.github.com/repos/Microsoft/nni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/nni/downloads","issues_url":"https://api.github.com/repos/Microsoft/nni/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/nni/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/nni/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/nni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/nni/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/nni/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/nni/deployments","created_at":"2018-06-01T05:51:44Z","updated_at":"2019-04-01T08:42:14Z","pushed_at":"2019-04-01T16:56:18Z","git_url":"git://github.com/Microsoft/nni.git","ssh_url":"git@github.com:Microsoft/nni.git","clone_url":"https://github.com/Microsoft/nni.git","svn_url":"https://github.com/Microsoft/nni","homepage":"https://nni.readthedocs.io/en/latest/","size":8572,"stargazers_count":2187,"watchers_count":2187,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":269,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":269,"open_issues":91,"watchers":2187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nni/pulls/947"},"html":{"href":"https://github.com/Microsoft/nni/pull/947"},"issue":{"href":"https://api.github.com/repos/Microsoft/nni/issues/947"},"comments":{"href":"https://api.github.com/repos/Microsoft/nni/issues/947/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/nni/pulls/947/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/nni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/nni/pulls/947/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/nni/statuses/d70481a2e104acc86ccc2fbf798aff71472ae753"}},"author_association":"MEMBER"}}
|
{
"id": 135673451,
"name": "Microsoft/nni",
"url": "https://api.github.com/repos/Microsoft/nni"
}
|
{
"id": 22682999,
"login": "SparkSnail",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22682999?",
"url": "https://api.github.com/users/SparkSnail"
}
|
{
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
}
| 2019-04-02T02:17:46 |
9358408425
|
{"actor":{"display_login":"SparkSnail"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/calculator/pulls/comments/303107678","pull_request_review_id":261421831,"id":303107678,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzEwNzY3OA==","diff_hunk":"@@ -167,4 +175,88 @@ namespace CalculatorApp\n VisualStateManager::GoToState(\n this, e->WindowActivationState == CoreWindowActivationState::Deactivated ? WindowNotFocused->Name : WindowFocused->Name, false);\n }\n+\n+ void TitleBar::AlwaysOnTopButtonClick(Platform::Object ^ sender, Windows::UI::Xaml::RoutedEventArgs ^ e)\n+ {\n+ auto avm = safe_cast<CalculatorApp::ViewModel::ApplicationViewModel ^>(this->DataContext);\n+ if (ApplicationView::GetForCurrentView()->GetForCurrentView()->ViewMode == ApplicationViewMode::CompactOverlay)\n+ {\n+ avm->Mode = m_beforeAlwaysOnTopMode;\n+ if (avm->Mode == CalculatorApp::Common::ViewMode::Standard)\n+ {\n+ avm->CalculatorViewModel->AreHistoryShortcutsEnabled = true;\n+ avm->CalculatorViewModel->HistoryVM->AreHistoryShortcutsEnabled = true;\n+ }\n+ IAsyncOperation<bool> ^ result = ApplicationView::GetForCurrentView()->TryEnterViewModeAsync(ApplicationViewMode::Default);\n+ auto changeModeTask = Concurrency::create_task(result);\n+ changeModeTask.then([this](bool success) {\n+ auto avm = safe_cast<CalculatorApp::ViewModel::ApplicationViewModel ^>(this->DataContext);\n+ avm->CalculatorViewModel->IsAlwaysOnTop = !success;\n+ if (!success)\n+ {\n+ AlwaysOnTopButton->HorizontalAlignment = ::HorizontalAlignment::Left;\n+ AlwaysOnTopButton->Content = L\"\\uEE47\";\n+ AppName->Text = \"\";\n+ ToolTipService::SetToolTip(AlwaysOnTopButton, \"Exit always-on-top\");\n+ }\n+ else\n+ {\n+ AlwaysOnTopButton->HorizontalAlignment = ::HorizontalAlignment::Right;\n+ AlwaysOnTopButton->Content = L\"\\uEE49\";\n+ AppName->Text = AppResourceProvider::GetInstance().GetResourceString(L\"AppName\");\n+ ToolTipService::SetToolTip(AlwaysOnTopButton, \"Always on top\");\n+ }\n+ this->Focus(::FocusState::Programmatic);\n+ });\n+ }\n+ else\n+ {\n+ m_beforeAlwaysOnTopMode = avm->Mode;\n+ avm->Mode = CalculatorApp::Common::ViewMode::Standard;\n+ avm->CalculatorViewModel->AreHistoryShortcutsEnabled = false;\n+ avm->CalculatorViewModel->HistoryVM->AreHistoryShortcutsEnabled = false;\n+\n+ Windows::Storage::ApplicationDataContainer ^ localSettings = Windows::Storage::ApplicationData::Current->LocalSettings;\n+ ViewModePreferences ^ compactOptions = ViewModePreferences::CreateDefault(ApplicationViewMode::CompactOverlay);\n+ if (!localSettings->Values->GetView()->HasKey(\"calculatorAlwaysOnTopLaunched\"))\n+ {\n+ compactOptions->CustomSize = Windows::Foundation::Size(320, 394);\n+ localSettings->Values->Insert(\"calculatorAlwaysOnTopLaunched\", true);\n+ }\n+ else\n+ {\n+ if (localSettings->Values->GetView()->HasKey(\"calculatorAlwaysOnTopLastWidth\") && localSettings->Values->GetView()->HasKey(\"calculatorAlwaysOnTopLastHeight\"))\n+ {\n+ float width = safe_cast<IPropertyValue ^>(localSettings->Values->GetView()->Lookup(\"calculatorAlwaysOnTopLastWidth\"))->GetSingle();\n+ float height = safe_cast<IPropertyValue ^>(localSettings->Values->GetView()->Lookup(\"calculatorAlwaysOnTopLastHeight\"))->GetSingle();\n+ compactOptions->CustomSize = Windows::Foundation::Size(width, height);\n+ }\n+ else\n+ {\n+ compactOptions->CustomSize = Windows::Foundation::Size(320, 394);\n+ }\n+ }\n+ IAsyncOperation<bool> ^ result = ApplicationView::GetForCurrentView()->TryEnterViewModeAsync(ApplicationViewMode::CompactOverlay, compactOptions);\n+ auto changeModeTask = Concurrency::create_task(result);\n+ changeModeTask.then([this](bool success) {\n+ auto avm = safe_cast<CalculatorApp::ViewModel::ApplicationViewModel ^>(this->DataContext);\n+ avm->CalculatorViewModel->IsAlwaysOnTop = success;\n+ if (success)\n+ {\n+ AlwaysOnTopButton->HorizontalAlignment = ::HorizontalAlignment::Left;\n+ AlwaysOnTopButton->Content = L\"\\uEE47\";\n+ AppName->Text = \"\";\n+ ToolTipService::SetToolTip(AlwaysOnTopButton, \"Exit always-on-top\");","path":"src/Calculator/Views/TitleBar.xaml.cpp","position":119,"original_position":119,"commit_id":"9f57f8db4e3404bdac69dcf5502443ba79b9c583","original_commit_id":"9f57f8db4e3404bdac69dcf5502443ba79b9c583","user":{"login":"joshkoon","id":45607479,"node_id":"MDQ6VXNlcjQ1NjA3NDc5","avatar_url":"https://avatars1.githubusercontent.com/u/45607479?v=4","gravatar_id":"","url":"https://api.github.com/users/joshkoon","html_url":"https://github.com/joshkoon","followers_url":"https://api.github.com/users/joshkoon/followers","following_url":"https://api.github.com/users/joshkoon/following{/other_user}","gists_url":"https://api.github.com/users/joshkoon/gists{/gist_id}","starred_url":"https://api.github.com/users/joshkoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshkoon/subscriptions","organizations_url":"https://api.github.com/users/joshkoon/orgs","repos_url":"https://api.github.com/users/joshkoon/repos","events_url":"https://api.github.com/users/joshkoon/events{/privacy}","received_events_url":"https://api.github.com/users/joshkoon/received_events","type":"User","site_admin":false},"body":"Strings need to be checked into the .resw file so they can be localized.","created_at":"2019-07-12T18:52:00Z","updated_at":"2019-07-12T18:52:01Z","html_url":"https://github.com/microsoft/calculator/pull/579#discussion_r303107678","pull_request_url":"https://api.github.com/repos/microsoft/calculator/pulls/579","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/calculator/pulls/comments/303107678"},"html":{"href":"https://github.com/microsoft/calculator/pull/579#discussion_r303107678"},"pull_request":{"href":"https://api.github.com/repos/microsoft/calculator/pulls/579"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/calculator/pulls/579","id":295997450,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1OTk3NDUw","html_url":"https://github.com/microsoft/calculator/pull/579","diff_url":"https://github.com/microsoft/calculator/pull/579.diff","patch_url":"https://github.com/microsoft/calculator/pull/579.patch","issue_url":"https://api.github.com/repos/microsoft/calculator/issues/579","number":579,"state":"open","locked":false,"title":"Always-on-Top mode implemented","user":{"login":"greedyAI","id":25124520,"node_id":"MDQ6VXNlcjI1MTI0NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/25124520?v=4","gravatar_id":"","url":"https://api.github.com/users/greedyAI","html_url":"https://github.com/greedyAI","followers_url":"https://api.github.com/users/greedyAI/followers","following_url":"https://api.github.com/users/greedyAI/following{/other_user}","gists_url":"https://api.github.com/users/greedyAI/gists{/gist_id}","starred_url":"https://api.github.com/users/greedyAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greedyAI/subscriptions","organizations_url":"https://api.github.com/users/greedyAI/orgs","repos_url":"https://api.github.com/users/greedyAI/repos","events_url":"https://api.github.com/users/greedyAI/events{/privacy}","received_events_url":"https://api.github.com/users/greedyAI/received_events","type":"User","site_admin":false},"body":"Implemented the 2nd most user requested new feature: the ability for users to pin Calculator on top of other windows.\r\n\r\n### Description of the changes:\r\n- A `Button` has been added to `TitleBar` and styled identical to the other `TitleBar` buttons. This button only appears in Standard calculator mode. Clicking on this button calls `ViewModePreferences` API to switch the window into `CompactOverlay` mode (and back, when exiting from Always-on-Top mode).\r\n- The `ViewModel` is updated accordingly when the button is pressed. These updates propagate dependency properties and observable variables back to the UI to show/hide and enable/disable certain UI elements (eg. buttons) and keyboard shortcuts.\r\n- The screen size is stored in `LocalSettings` whenever the user resizes the screen in Always-on-Top mode. This is used for restoring the last used screen size when the user enters Always-on-Top mode.\r\n- `AdaptiveTriggers` and `SizedChanged` event handlers are used to implement a responsive UI: certain buttons are hidden when the screen shrinks and the font sizes vary based on the screen size as well.\r\n- The main expression in the Always-on-Top mode combines an `ItemsControl` and a `TextBlock` to render the desired mathematical result/expression. This scrollable expression shows the full mathematical expression when edited. When the user presses the \"=\" button, it shows the final computed result.\r\n- The resulting functionality matches that as specified in the PM spec [here](https://github.com/microsoft/calculator-specs/blob/master/active/Always-on-top/README.md).\r\n\r\n### How changes were validated:\r\n- Manual testing.\r\n\r\n","created_at":"2019-07-10T04:02:42Z","updated_at":"2019-07-12T18:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3d7db0b92f4ef5f18998c1c3661f20f0ea48448","assignee":{"login":"joseartrivera","id":6334170,"node_id":"MDQ6VXNlcjYzMzQxNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6334170?v=4","gravatar_id":"","url":"https://api.github.com/users/joseartrivera","html_url":"https://github.com/joseartrivera","followers_url":"https://api.github.com/users/joseartrivera/followers","following_url":"https://api.github.com/users/joseartrivera/following{/other_user}","gists_url":"https://api.github.com/users/joseartrivera/gists{/gist_id}","starred_url":"https://api.github.com/users/joseartrivera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseartrivera/subscriptions","organizations_url":"https://api.github.com/users/joseartrivera/orgs","repos_url":"https://api.github.com/users/joseartrivera/repos","events_url":"https://api.github.com/users/joseartrivera/events{/privacy}","received_events_url":"https://api.github.com/users/joseartrivera/received_events","type":"User","site_admin":false},"assignees":[{"login":"joseartrivera","id":6334170,"node_id":"MDQ6VXNlcjYzMzQxNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6334170?v=4","gravatar_id":"","url":"https://api.github.com/users/joseartrivera","html_url":"https://github.com/joseartrivera","followers_url":"https://api.github.com/users/joseartrivera/followers","following_url":"https://api.github.com/users/joseartrivera/following{/other_user}","gists_url":"https://api.github.com/users/joseartrivera/gists{/gist_id}","starred_url":"https://api.github.com/users/joseartrivera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseartrivera/subscriptions","organizations_url":"https://api.github.com/users/joseartrivera/orgs","repos_url":"https://api.github.com/users/joseartrivera/repos","events_url":"https://api.github.com/users/joseartrivera/events{/privacy}","received_events_url":"https://api.github.com/users/joseartrivera/received_events","type":"User","site_admin":false},{"login":"sanderl","id":46726333,"node_id":"MDQ6VXNlcjQ2NzI2MzMz","avatar_url":"https://avatars3.githubusercontent.com/u/46726333?v=4","gravatar_id":"","url":"https://api.github.com/users/sanderl","html_url":"https://github.com/sanderl","followers_url":"https://api.github.com/users/sanderl/followers","following_url":"https://api.github.com/users/sanderl/following{/other_user}","gists_url":"https://api.github.com/users/sanderl/gists{/gist_id}","starred_url":"https://api.github.com/users/sanderl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanderl/subscriptions","organizations_url":"https://api.github.com/users/sanderl/orgs","repos_url":"https://api.github.com/users/sanderl/repos","events_url":"https://api.github.com/users/sanderl/events{/privacy}","received_events_url":"https://api.github.com/users/sanderl/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"grochocki","id":1414423,"node_id":"MDQ6VXNlcjE0MTQ0MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1414423?v=4","gravatar_id":"","url":"https://api.github.com/users/grochocki","html_url":"https://github.com/grochocki","followers_url":"https://api.github.com/users/grochocki/followers","following_url":"https://api.github.com/users/grochocki/following{/other_user}","gists_url":"https://api.github.com/users/grochocki/gists{/gist_id}","starred_url":"https://api.github.com/users/grochocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grochocki/subscriptions","organizations_url":"https://api.github.com/users/grochocki/orgs","repos_url":"https://api.github.com/users/grochocki/repos","events_url":"https://api.github.com/users/grochocki/events{/privacy}","received_events_url":"https://api.github.com/users/grochocki/received_events","type":"User","site_admin":false},{"login":"joseartrivera","id":6334170,"node_id":"MDQ6VXNlcjYzMzQxNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6334170?v=4","gravatar_id":"","url":"https://api.github.com/users/joseartrivera","html_url":"https://github.com/joseartrivera","followers_url":"https://api.github.com/users/joseartrivera/followers","following_url":"https://api.github.com/users/joseartrivera/following{/other_user}","gists_url":"https://api.github.com/users/joseartrivera/gists{/gist_id}","starred_url":"https://api.github.com/users/joseartrivera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseartrivera/subscriptions","organizations_url":"https://api.github.com/users/joseartrivera/orgs","repos_url":"https://api.github.com/users/joseartrivera/repos","events_url":"https://api.github.com/users/joseartrivera/events{/privacy}","received_events_url":"https://api.github.com/users/joseartrivera/received_events","type":"User","site_admin":false},{"login":"liangchen07","id":50078611,"node_id":"MDQ6VXNlcjUwMDc4NjEx","avatar_url":"https://avatars3.githubusercontent.com/u/50078611?v=4","gravatar_id":"","url":"https://api.github.com/users/liangchen07","html_url":"https://github.com/liangchen07","followers_url":"https://api.github.com/users/liangchen07/followers","following_url":"https://api.github.com/users/liangchen07/following{/other_user}","gists_url":"https://api.github.com/users/liangchen07/gists{/gist_id}","starred_url":"https://api.github.com/users/liangchen07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangchen07/subscriptions","organizations_url":"https://api.github.com/users/liangchen07/orgs","repos_url":"https://api.github.com/users/liangchen07/repos","events_url":"https://api.github.com/users/liangchen07/events{/privacy}","received_events_url":"https://api.github.com/users/liangchen07/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1243469398,"node_id":"MDU6TGFiZWwxMjQzNDY5Mzk4","url":"https://api.github.com/repos/microsoft/calculator/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false},{"id":1265286666,"node_id":"MDU6TGFiZWwxMjY1Mjg2NjY2","url":"https://api.github.com/repos/microsoft/calculator/labels/fixing%20approved%20issue","name":"fixing approved issue","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/calculator/pulls/579/commits","review_comments_url":"https://api.github.com/repos/microsoft/calculator/pulls/579/comments","review_comment_url":"https://api.github.com/repos/microsoft/calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/calculator/issues/579/comments","statuses_url":"https://api.github.com/repos/microsoft/calculator/statuses/9f57f8db4e3404bdac69dcf5502443ba79b9c583","head":{"label":"greedyAI:always-on-top","ref":"always-on-top","sha":"9f57f8db4e3404bdac69dcf5502443ba79b9c583","user":{"login":"greedyAI","id":25124520,"node_id":"MDQ6VXNlcjI1MTI0NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/25124520?v=4","gravatar_id":"","url":"https://api.github.com/users/greedyAI","html_url":"https://github.com/greedyAI","followers_url":"https://api.github.com/users/greedyAI/followers","following_url":"https://api.github.com/users/greedyAI/following{/other_user}","gists_url":"https://api.github.com/users/greedyAI/gists{/gist_id}","starred_url":"https://api.github.com/users/greedyAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greedyAI/subscriptions","organizations_url":"https://api.github.com/users/greedyAI/orgs","repos_url":"https://api.github.com/users/greedyAI/repos","events_url":"https://api.github.com/users/greedyAI/events{/privacy}","received_events_url":"https://api.github.com/users/greedyAI/received_events","type":"User","site_admin":false},"repo":{"id":189639662,"node_id":"MDEwOlJlcG9zaXRvcnkxODk2Mzk2NjI=","name":"calculator","full_name":"greedyAI/calculator","private":false,"owner":{"login":"greedyAI","id":25124520,"node_id":"MDQ6VXNlcjI1MTI0NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/25124520?v=4","gravatar_id":"","url":"https://api.github.com/users/greedyAI","html_url":"https://github.com/greedyAI","followers_url":"https://api.github.com/users/greedyAI/followers","following_url":"https://api.github.com/users/greedyAI/following{/other_user}","gists_url":"https://api.github.com/users/greedyAI/gists{/gist_id}","starred_url":"https://api.github.com/users/greedyAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greedyAI/subscriptions","organizations_url":"https://api.github.com/users/greedyAI/orgs","repos_url":"https://api.github.com/users/greedyAI/repos","events_url":"https://api.github.com/users/greedyAI/events{/privacy}","received_events_url":"https://api.github.com/users/greedyAI/received_events","type":"User","site_admin":false},"html_url":"https://github.com/greedyAI/calculator","description":"Windows Calculator: A simple yet powerful calculator that ships with Windows","fork":true,"url":"https://api.github.com/repos/greedyAI/calculator","forks_url":"https://api.github.com/repos/greedyAI/calculator/forks","keys_url":"https://api.github.com/repos/greedyAI/calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greedyAI/calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greedyAI/calculator/teams","hooks_url":"https://api.github.com/repos/greedyAI/calculator/hooks","issue_events_url":"https://api.github.com/repos/greedyAI/calculator/issues/events{/number}","events_url":"https://api.github.com/repos/greedyAI/calculator/events","assignees_url":"https://api.github.com/repos/greedyAI/calculator/assignees{/user}","branches_url":"https://api.github.com/repos/greedyAI/calculator/branches{/branch}","tags_url":"https://api.github.com/repos/greedyAI/calculator/tags","blobs_url":"https://api.github.com/repos/greedyAI/calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greedyAI/calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greedyAI/calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/greedyAI/calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greedyAI/calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/greedyAI/calculator/languages","stargazers_url":"https://api.github.com/repos/greedyAI/calculator/stargazers","contributors_url":"https://api.github.com/repos/greedyAI/calculator/contributors","subscribers_url":"https://api.github.com/repos/greedyAI/calculator/subscribers","subscription_url":"https://api.github.com/repos/greedyAI/calculator/subscription","commits_url":"https://api.github.com/repos/greedyAI/calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/greedyAI/calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/greedyAI/calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/greedyAI/calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/greedyAI/calculator/contents/{+path}","compare_url":"https://api.github.com/repos/greedyAI/calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greedyAI/calculator/merges","archive_url":"https://api.github.com/repos/greedyAI/calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greedyAI/calculator/downloads","issues_url":"https://api.github.com/repos/greedyAI/calculator/issues{/number}","pulls_url":"https://api.github.com/repos/greedyAI/calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/greedyAI/calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/greedyAI/calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greedyAI/calculator/labels{/name}","releases_url":"https://api.github.com/repos/greedyAI/calculator/releases{/id}","deployments_url":"https://api.github.com/repos/greedyAI/calculator/deployments","created_at":"2019-05-31T18:21:47Z","updated_at":"2019-06-05T23:13:03Z","pushed_at":"2019-07-12T03:16:56Z","git_url":"git://github.com/greedyAI/calculator.git","ssh_url":"git@github.com:greedyAI/calculator.git","clone_url":"https://github.com/greedyAI/calculator.git","svn_url":"https://github.com/greedyAI/calculator","homepage":"","size":22782,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"2a5a52d44d67b0ebf28a3638d28d156008d41133","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":168008797,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgwMDg3OTc=","name":"calculator","full_name":"microsoft/calculator","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/calculator","description":"Windows Calculator: A simple yet powerful calculator that ships with Windows","fork":false,"url":"https://api.github.com/repos/microsoft/calculator","forks_url":"https://api.github.com/repos/microsoft/calculator/forks","keys_url":"https://api.github.com/repos/microsoft/calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/calculator/teams","hooks_url":"https://api.github.com/repos/microsoft/calculator/hooks","issue_events_url":"https://api.github.com/repos/microsoft/calculator/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/calculator/events","assignees_url":"https://api.github.com/repos/microsoft/calculator/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/calculator/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/calculator/tags","blobs_url":"https://api.github.com/repos/microsoft/calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/calculator/languages","stargazers_url":"https://api.github.com/repos/microsoft/calculator/stargazers","contributors_url":"https://api.github.com/repos/microsoft/calculator/contributors","subscribers_url":"https://api.github.com/repos/microsoft/calculator/subscribers","subscription_url":"https://api.github.com/repos/microsoft/calculator/subscription","commits_url":"https://api.github.com/repos/microsoft/calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/calculator/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/calculator/merges","archive_url":"https://api.github.com/repos/microsoft/calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/calculator/downloads","issues_url":"https://api.github.com/repos/microsoft/calculator/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/calculator/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/calculator/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/calculator/deployments","created_at":"2019-01-28T17:55:49Z","updated_at":"2019-07-12T16:57:58Z","pushed_at":"2019-07-12T03:17:03Z","git_url":"git://github.com/microsoft/calculator.git","ssh_url":"git@github.com:microsoft/calculator.git","clone_url":"https://github.com/microsoft/calculator.git","svn_url":"https://github.com/microsoft/calculator","homepage":"","size":23021,"stargazers_count":17683,"watchers_count":17683,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2765,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":130,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2765,"open_issues":130,"watchers":17683,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/calculator/pulls/579"},"html":{"href":"https://github.com/microsoft/calculator/pull/579"},"issue":{"href":"https://api.github.com/repos/microsoft/calculator/issues/579"},"comments":{"href":"https://api.github.com/repos/microsoft/calculator/issues/579/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/calculator/pulls/579/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/calculator/pulls/579/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/calculator/statuses/9f57f8db4e3404bdac69dcf5502443ba79b9c583"}},"author_association":"MEMBER"}}
|
{
"id": 168008797,
"name": "microsoft/calculator",
"url": "https://api.github.com/repos/microsoft/calculator"
}
|
{
"id": 45607479,
"login": "joshkoon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45607479?",
"url": "https://api.github.com/users/joshkoon"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-07-12T18:52:00 |
10002621341
|
{"actor":{"display_login":"joshkoon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/BuildXL/pulls/comments/347660296","pull_request_review_id":318694627,"id":347660296,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzY2MDI5Ng==","diff_hunk":"@@ -286,16 +293,81 @@ public async Task<BoolResult> ExecuteBatchOperationAsync(Context context, IRedis\n },\r\n cancellationToken);\r\n await batch.NotifyConsumersOfSuccess();\r\n+\r\n+ RedisOperationSucceeded();\r\n return BoolResult.Success;\r\n }\r\n catch (Exception ex)\r\n {\r\n batch.NotifyConsumersOfFailure(ex);\r\n+ HandleRedisExceptionAndResetMultiplexerIfNeeded(context, ex);\r\n return new BoolResult(ex);\r\n }\r\n }\r\n }\r\n \r\n+ private void RedisOperationSucceeded()\r\n+ {\r\n+ // If the operation is successful, then reset the error count to 0.\r\n+ Interlocked.Exchange(ref _connectionErrorCount, 0);\r\n+ }\r\n+\r\n+ /// <summary>\r\n+ /// This method \"handles\" redis connectivity errors and reset the connection multiplexer if there are no successful operations happening.\r\n+ /// </summary>\r\n+ private void HandleRedisExceptionAndResetMultiplexerIfNeeded(Context context, Exception exception)\r\n+ {\r\n+ if (IsRedisConnectionException(exception))\r\n+ {\r\n+ // Using double-checked locking approach to reset the connection multiplexer only once.\r\n+ if (Interlocked.Increment(ref _connectionErrorCount) >= _redisConnectionErrorLimit)\r\n+ {\r\n+ lock (_resetConnectionsLock)\r\n+ {\r\n+ // The second read of _connectionErrorCount is a non-interlocked read, but it should be fine because it is happening under the lock.\r\n+ if (_connectionErrorCount >= _redisConnectionErrorLimit)\r\n+ {\r\n+ // This means that there is no successful operations happening, and all the errors that we're seeing are redis connectivity issues.\r\n+ // This is, effectively, a work-around for the issue in StackExchange.Redis library (https://github.com/StackExchange/StackExchange.Redis/issues/559).\r\n+ context.Warning($\"Reset redis connection due to connectivity issues. ConnectionErrorCount={_connectionErrorCount}, RedisConnectionErrorLimit={_redisConnectionErrorLimit}.\");\r\n+ Interlocked.Exchange(ref _connectionErrorCount, 0);\r\n+ _databaseFactory.ResetConnectionMultiplexer();\r\n+ }\r\n+ }\r\n+ }\r\n+ }\r\n+ }\r\n+\r\n+ /// <summary>\r\n+ /// The call back that is called by the redis retry strategy.\r\n+ /// </summary>\r\n+ /// <remarks>\r\n+ /// There are two very similar methods: <see cref=\"OnRedisException\"/> and <see cref=\"HandleRedisExceptionAndResetMultiplexerIfNeeded\"/>. The first one (the current method) is called\r\n+ /// by the retry strategy to track and increment the failure count for all the retries not only for the final ones.\r\n+ /// The later is called manually after each failed operation and that method takes a context that allows us to trace and actually may reset the connection mutliplexer\r\n+ /// due to a number of redis connection exceptions.\r\n+ /// </remarks>\r\n+ private void OnRedisException(Exception exception)\r\n+ {\r\n+ // Lets be very pessimistic here: reset the connectivity errors every time when the operation succeed or any other exception\r\n+ // but redis connection exception occurs.\r\n+ if (IsRedisConnectionException(exception))\r\n+ {\r\n+ Interlocked.Increment(ref _connectionErrorCount);\r\n+ }\r\n+ else\r\n+ {\r\n+ Interlocked.Exchange(ref _connectionErrorCount, 0);\r","path":"Public/Src/Cache/ContentStore/Distributed/Redis/RedisDatabaseAdapter.cs","position":92,"original_position":92,"commit_id":"a9fe451083fbbfbc3262636dffdc542a3b6d4313","original_commit_id":"a9fe451083fbbfbc3262636dffdc542a3b6d4313","user":{"login":"SergeyTeplyakov","id":726448,"node_id":"MDQ6VXNlcjcyNjQ0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/726448?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyTeplyakov","html_url":"https://github.com/SergeyTeplyakov","followers_url":"https://api.github.com/users/SergeyTeplyakov/followers","following_url":"https://api.github.com/users/SergeyTeplyakov/following{/other_user}","gists_url":"https://api.github.com/users/SergeyTeplyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyTeplyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyTeplyakov/subscriptions","organizations_url":"https://api.github.com/users/SergeyTeplyakov/orgs","repos_url":"https://api.github.com/users/SergeyTeplyakov/repos","events_url":"https://api.github.com/users/SergeyTeplyakov/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyTeplyakov/received_events","type":"User","site_admin":false},"body":"I wanted to be safe here. My idea is that if the error is sticky, then there is no other errors happening besides this one, so it is ok to reset the multiplexer when 10 (or even 5) connectivity issues happened.\r\n\r\nIf another exception does not reset the count, then the overall connection reset counter should be higher.\r\n\r\nOn the other hand, successful operation should definitely reset it anyways, so maybe reset is just fine after lets say 20 connectivity issues even if another issues were happening in the process.\r\n\r\n---\r\nIn reply to: [347642715](https://github.com/microsoft/BuildXL/pull/1229#discussion_r347642715) [](ancestors = 347642715,347636933)","created_at":"2019-11-18T23:17:43Z","updated_at":"2019-11-18T23:17:44Z","html_url":"https://github.com/microsoft/BuildXL/pull/1229#discussion_r347660296","pull_request_url":"https://api.github.com/repos/microsoft/BuildXL/pulls/1229","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/BuildXL/pulls/comments/347660296"},"html":{"href":"https://github.com/microsoft/BuildXL/pull/1229#discussion_r347660296"},"pull_request":{"href":"https://api.github.com/repos/microsoft/BuildXL/pulls/1229"}},"in_reply_to_id":347636933},"pull_request":{"url":"https://api.github.com/repos/microsoft/BuildXL/pulls/1229","id":342308354,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyMzA4MzU0","html_url":"https://github.com/microsoft/BuildXL/pull/1229","diff_url":"https://github.com/microsoft/BuildXL/pull/1229.diff","patch_url":"https://github.com/microsoft/BuildXL/pull/1229.patch","issue_url":"https://api.github.com/repos/microsoft/BuildXL/issues/1229","number":1229,"state":"open","locked":false,"title":"Reset Redis connection multiplexer due to connectivity issues.","user":{"login":"SergeyTeplyakov","id":726448,"node_id":"MDQ6VXNlcjcyNjQ0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/726448?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyTeplyakov","html_url":"https://github.com/SergeyTeplyakov","followers_url":"https://api.github.com/users/SergeyTeplyakov/followers","following_url":"https://api.github.com/users/SergeyTeplyakov/following{/other_user}","gists_url":"https://api.github.com/users/SergeyTeplyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyTeplyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyTeplyakov/subscriptions","organizations_url":"https://api.github.com/users/SergeyTeplyakov/orgs","repos_url":"https://api.github.com/users/SergeyTeplyakov/repos","events_url":"https://api.github.com/users/SergeyTeplyakov/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyTeplyakov/received_events","type":"User","site_admin":false},"body":"This is a bit of WIP code review to show the idea. The remaining part is to configure and enable this feature.","created_at":"2019-11-18T18:59:25Z","updated_at":"2019-11-18T23:17:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d7dda24199e1d30354ec1593fafbd0a0414e806","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JuanCarlosGI","id":10591075,"node_id":"MDQ6VXNlcjEwNTkxMDc1","avatar_url":"https://avatars2.githubusercontent.com/u/10591075?v=4","gravatar_id":"","url":"https://api.github.com/users/JuanCarlosGI","html_url":"https://github.com/JuanCarlosGI","followers_url":"https://api.github.com/users/JuanCarlosGI/followers","following_url":"https://api.github.com/users/JuanCarlosGI/following{/other_user}","gists_url":"https://api.github.com/users/JuanCarlosGI/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanCarlosGI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanCarlosGI/subscriptions","organizations_url":"https://api.github.com/users/JuanCarlosGI/orgs","repos_url":"https://api.github.com/users/JuanCarlosGI/repos","events_url":"https://api.github.com/users/JuanCarlosGI/events{/privacy}","received_events_url":"https://api.github.com/users/JuanCarlosGI/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/BuildXL/pulls/1229/commits","review_comments_url":"https://api.github.com/repos/microsoft/BuildXL/pulls/1229/comments","review_comment_url":"https://api.github.com/repos/microsoft/BuildXL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/BuildXL/issues/1229/comments","statuses_url":"https://api.github.com/repos/microsoft/BuildXL/statuses/a9fe451083fbbfbc3262636dffdc542a3b6d4313","head":{"label":"SergeyTeplyakov:redisreconnect","ref":"redisreconnect","sha":"a9fe451083fbbfbc3262636dffdc542a3b6d4313","user":{"login":"SergeyTeplyakov","id":726448,"node_id":"MDQ6VXNlcjcyNjQ0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/726448?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyTeplyakov","html_url":"https://github.com/SergeyTeplyakov","followers_url":"https://api.github.com/users/SergeyTeplyakov/followers","following_url":"https://api.github.com/users/SergeyTeplyakov/following{/other_user}","gists_url":"https://api.github.com/users/SergeyTeplyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyTeplyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyTeplyakov/subscriptions","organizations_url":"https://api.github.com/users/SergeyTeplyakov/orgs","repos_url":"https://api.github.com/users/SergeyTeplyakov/repos","events_url":"https://api.github.com/users/SergeyTeplyakov/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyTeplyakov/received_events","type":"User","site_admin":false},"repo":{"id":178297235,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyOTcyMzU=","name":"BuildXL","full_name":"SergeyTeplyakov/BuildXL","private":false,"owner":{"login":"SergeyTeplyakov","id":726448,"node_id":"MDQ6VXNlcjcyNjQ0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/726448?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyTeplyakov","html_url":"https://github.com/SergeyTeplyakov","followers_url":"https://api.github.com/users/SergeyTeplyakov/followers","following_url":"https://api.github.com/users/SergeyTeplyakov/following{/other_user}","gists_url":"https://api.github.com/users/SergeyTeplyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyTeplyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyTeplyakov/subscriptions","organizations_url":"https://api.github.com/users/SergeyTeplyakov/orgs","repos_url":"https://api.github.com/users/SergeyTeplyakov/repos","events_url":"https://api.github.com/users/SergeyTeplyakov/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyTeplyakov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SergeyTeplyakov/BuildXL","description":"Microsoft Build Accelerator","fork":true,"url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL","forks_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/forks","keys_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/teams","hooks_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/hooks","issue_events_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/issues/events{/number}","events_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/events","assignees_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/assignees{/user}","branches_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/branches{/branch}","tags_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/tags","blobs_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/git/refs{/sha}","trees_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/statuses/{sha}","languages_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/languages","stargazers_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/stargazers","contributors_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/contributors","subscribers_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/subscribers","subscription_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/subscription","commits_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/commits{/sha}","git_commits_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/git/commits{/sha}","comments_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/comments{/number}","issue_comment_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/issues/comments{/number}","contents_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/contents/{+path}","compare_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/merges","archive_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/downloads","issues_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/issues{/number}","pulls_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/pulls{/number}","milestones_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/milestones{/number}","notifications_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/labels{/name}","releases_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/releases{/id}","deployments_url":"https://api.github.com/repos/SergeyTeplyakov/BuildXL/deployments","created_at":"2019-03-28T23:26:22Z","updated_at":"2019-07-02T03:20:50Z","pushed_at":"2019-11-18T22:02:30Z","git_url":"git://github.com/SergeyTeplyakov/BuildXL.git","ssh_url":"git@github.com:SergeyTeplyakov/BuildXL.git","clone_url":"https://github.com/SergeyTeplyakov/BuildXL.git","svn_url":"https://github.com/SergeyTeplyakov/BuildXL","homepage":"","size":48955,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"619c42e6a3cf51bb3355478bb33248451e98f3e6","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":152813045,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MTMwNDU=","name":"BuildXL","full_name":"microsoft/BuildXL","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/BuildXL","description":"Microsoft Build Accelerator","fork":false,"url":"https://api.github.com/repos/microsoft/BuildXL","forks_url":"https://api.github.com/repos/microsoft/BuildXL/forks","keys_url":"https://api.github.com/repos/microsoft/BuildXL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/BuildXL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/BuildXL/teams","hooks_url":"https://api.github.com/repos/microsoft/BuildXL/hooks","issue_events_url":"https://api.github.com/repos/microsoft/BuildXL/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/BuildXL/events","assignees_url":"https://api.github.com/repos/microsoft/BuildXL/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/BuildXL/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/BuildXL/tags","blobs_url":"https://api.github.com/repos/microsoft/BuildXL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/BuildXL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/BuildXL/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/BuildXL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/BuildXL/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/BuildXL/languages","stargazers_url":"https://api.github.com/repos/microsoft/BuildXL/stargazers","contributors_url":"https://api.github.com/repos/microsoft/BuildXL/contributors","subscribers_url":"https://api.github.com/repos/microsoft/BuildXL/subscribers","subscription_url":"https://api.github.com/repos/microsoft/BuildXL/subscription","commits_url":"https://api.github.com/repos/microsoft/BuildXL/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/BuildXL/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/BuildXL/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/BuildXL/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/BuildXL/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/BuildXL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/BuildXL/merges","archive_url":"https://api.github.com/repos/microsoft/BuildXL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/BuildXL/downloads","issues_url":"https://api.github.com/repos/microsoft/BuildXL/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/BuildXL/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/BuildXL/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/BuildXL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/BuildXL/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/BuildXL/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/BuildXL/deployments","created_at":"2018-10-12T22:16:45Z","updated_at":"2019-11-18T22:27:17Z","pushed_at":"2019-11-18T22:27:14Z","git_url":"git://github.com/microsoft/BuildXL.git","ssh_url":"git@github.com:microsoft/BuildXL.git","clone_url":"https://github.com/microsoft/BuildXL.git","svn_url":"https://github.com/microsoft/BuildXL","homepage":"","size":48722,"stargazers_count":586,"watchers_count":586,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":82,"open_issues":29,"watchers":586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/BuildXL/pulls/1229"},"html":{"href":"https://github.com/microsoft/BuildXL/pull/1229"},"issue":{"href":"https://api.github.com/repos/microsoft/BuildXL/issues/1229"},"comments":{"href":"https://api.github.com/repos/microsoft/BuildXL/issues/1229/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/BuildXL/pulls/1229/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/BuildXL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/BuildXL/pulls/1229/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/BuildXL/statuses/a9fe451083fbbfbc3262636dffdc542a3b6d4313"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 152813045,
"name": "microsoft/BuildXL",
"url": "https://api.github.com/repos/microsoft/BuildXL"
}
|
{
"id": 726448,
"login": "SergeyTeplyakov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/726448?",
"url": "https://api.github.com/users/SergeyTeplyakov"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-11-18T23:17:43 |
10891639671
|
{"actor":{"display_login":"SergeyTeplyakov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/fsharplu/pulls/comments/260493397","pull_request_review_id":208215449,"id":260493397,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDQ5MzM5Nw==","diff_hunk":"@@ -148,7 +148,7 @@ type CompactUnionJsonConverter(?tupleAsHeterogeneousArray:bool) =\n \n match fields with\n // Field-less union case\n- | [||] -> writer.WriteValue(convertName case.Name)\n+ | [||] -> writer.WriteValue(case.Name)","path":"FSharpLu.Json/Compact.fs","position":5,"original_position":5,"commit_id":"497a8409ef0d2767148911c8c5c2601e4626ac43","original_commit_id":"497a8409ef0d2767148911c8c5c2601e4626ac43","user":{"login":"blumu","id":3913258,"node_id":"MDQ6VXNlcjM5MTMyNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3913258?v=4","gravatar_id":"","url":"https://api.github.com/users/blumu","html_url":"https://github.com/blumu","followers_url":"https://api.github.com/users/blumu/followers","following_url":"https://api.github.com/users/blumu/following{/other_user}","gists_url":"https://api.github.com/users/blumu/gists{/gist_id}","starred_url":"https://api.github.com/users/blumu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blumu/subscriptions","organizations_url":"https://api.github.com/users/blumu/orgs","repos_url":"https://api.github.com/users/blumu/repos","events_url":"https://api.github.com/users/blumu/events{/privacy}","received_events_url":"https://api.github.com/users/blumu/received_events","type":"User","site_admin":false},"body":"I would recommend adding an optional parameter to the type `CompactUnionJsonConverter` to indicate the casing behaviour for values:\r\nFor example:\r\n```fs\r\ntype CompactUnionJsonConverter(?tupleAsHeterogeneousArray:bool, ?camelCaseValues:bool) =\r\n let tupleAsHeterogeneousArray:bool= defaultArg tupleAsHeterogeneousArray false\r\n ...\r\n | [||] when tupleAsHeterogeneousArray -> writer.WriteValue(case.Name)\r\n | [||] when not tupleAsHeterogeneousArray -> writer.WriteValue(convertName case.Name)\r\n ...\r\n```\r\n","created_at":"2019-02-26T21:23:37Z","updated_at":"2019-02-26T21:23:37Z","html_url":"https://github.com/Microsoft/fsharplu/pull/60#discussion_r260493397","pull_request_url":"https://api.github.com/repos/Microsoft/fsharplu/pulls/60","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/fsharplu/pulls/comments/260493397"},"html":{"href":"https://github.com/Microsoft/fsharplu/pull/60#discussion_r260493397"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/fsharplu/pulls/60"}},"in_reply_to_id":253276791},"pull_request":{"url":"https://api.github.com/repos/Microsoft/fsharplu/pulls/60","id":249529994,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5NTI5OTk0","html_url":"https://github.com/Microsoft/fsharplu/pull/60","diff_url":"https://github.com/Microsoft/fsharplu/pull/60.diff","patch_url":"https://github.com/Microsoft/fsharplu/pull/60.patch","issue_url":"https://api.github.com/repos/Microsoft/fsharplu/issues/60","number":60,"state":"open","locked":false,"title":"Write field-less union case name without formatting","user":{"login":"erik-lundgren","id":3606275,"node_id":"MDQ6VXNlcjM2MDYyNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3606275?v=4","gravatar_id":"","url":"https://api.github.com/users/erik-lundgren","html_url":"https://github.com/erik-lundgren","followers_url":"https://api.github.com/users/erik-lundgren/followers","following_url":"https://api.github.com/users/erik-lundgren/following{/other_user}","gists_url":"https://api.github.com/users/erik-lundgren/gists{/gist_id}","starred_url":"https://api.github.com/users/erik-lundgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erik-lundgren/subscriptions","organizations_url":"https://api.github.com/users/erik-lundgren/orgs","repos_url":"https://api.github.com/users/erik-lundgren/repos","events_url":"https://api.github.com/users/erik-lundgren/events{/privacy}","received_events_url":"https://api.github.com/users/erik-lundgren/received_events","type":"User","site_admin":false},"body":"Resolves #58 \r\n\r\nSorry about opening two PRs, got the wrong author in there accidentally.","created_at":"2019-02-01T08:59:02Z","updated_at":"2019-02-26T21:23:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d589d4f99cffc25b10b9cf4d2eb81e3fe450f86","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/fsharplu/pulls/60/commits","review_comments_url":"https://api.github.com/repos/Microsoft/fsharplu/pulls/60/comments","review_comment_url":"https://api.github.com/repos/Microsoft/fsharplu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/fsharplu/issues/60/comments","statuses_url":"https://api.github.com/repos/Microsoft/fsharplu/statuses/497a8409ef0d2767148911c8c5c2601e4626ac43","head":{"label":"erik-lundgren:master","ref":"master","sha":"497a8409ef0d2767148911c8c5c2601e4626ac43","user":{"login":"erik-lundgren","id":3606275,"node_id":"MDQ6VXNlcjM2MDYyNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3606275?v=4","gravatar_id":"","url":"https://api.github.com/users/erik-lundgren","html_url":"https://github.com/erik-lundgren","followers_url":"https://api.github.com/users/erik-lundgren/followers","following_url":"https://api.github.com/users/erik-lundgren/following{/other_user}","gists_url":"https://api.github.com/users/erik-lundgren/gists{/gist_id}","starred_url":"https://api.github.com/users/erik-lundgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erik-lundgren/subscriptions","organizations_url":"https://api.github.com/users/erik-lundgren/orgs","repos_url":"https://api.github.com/users/erik-lundgren/repos","events_url":"https://api.github.com/users/erik-lundgren/events{/privacy}","received_events_url":"https://api.github.com/users/erik-lundgren/received_events","type":"User","site_admin":false},"repo":{"id":168585854,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg1ODU4NTQ=","name":"fsharplu","full_name":"erik-lundgren/fsharplu","private":false,"owner":{"login":"erik-lundgren","id":3606275,"node_id":"MDQ6VXNlcjM2MDYyNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3606275?v=4","gravatar_id":"","url":"https://api.github.com/users/erik-lundgren","html_url":"https://github.com/erik-lundgren","followers_url":"https://api.github.com/users/erik-lundgren/followers","following_url":"https://api.github.com/users/erik-lundgren/following{/other_user}","gists_url":"https://api.github.com/users/erik-lundgren/gists{/gist_id}","starred_url":"https://api.github.com/users/erik-lundgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erik-lundgren/subscriptions","organizations_url":"https://api.github.com/users/erik-lundgren/orgs","repos_url":"https://api.github.com/users/erik-lundgren/repos","events_url":"https://api.github.com/users/erik-lundgren/events{/privacy}","received_events_url":"https://api.github.com/users/erik-lundgren/received_events","type":"User","site_admin":false},"html_url":"https://github.com/erik-lundgren/fsharplu","description":"This library provides a set of F# helpers for string manipulations, logging, collection data structures, file operations, text processing, security, async, parsing, diagnostics, configuration files and Json serialization.","fork":true,"url":"https://api.github.com/repos/erik-lundgren/fsharplu","forks_url":"https://api.github.com/repos/erik-lundgren/fsharplu/forks","keys_url":"https://api.github.com/repos/erik-lundgren/fsharplu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erik-lundgren/fsharplu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erik-lundgren/fsharplu/teams","hooks_url":"https://api.github.com/repos/erik-lundgren/fsharplu/hooks","issue_events_url":"https://api.github.com/repos/erik-lundgren/fsharplu/issues/events{/number}","events_url":"https://api.github.com/repos/erik-lundgren/fsharplu/events","assignees_url":"https://api.github.com/repos/erik-lundgren/fsharplu/assignees{/user}","branches_url":"https://api.github.com/repos/erik-lundgren/fsharplu/branches{/branch}","tags_url":"https://api.github.com/repos/erik-lundgren/fsharplu/tags","blobs_url":"https://api.github.com/repos/erik-lundgren/fsharplu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erik-lundgren/fsharplu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erik-lundgren/fsharplu/git/refs{/sha}","trees_url":"https://api.github.com/repos/erik-lundgren/fsharplu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erik-lundgren/fsharplu/statuses/{sha}","languages_url":"https://api.github.com/repos/erik-lundgren/fsharplu/languages","stargazers_url":"https://api.github.com/repos/erik-lundgren/fsharplu/stargazers","contributors_url":"https://api.github.com/repos/erik-lundgren/fsharplu/contributors","subscribers_url":"https://api.github.com/repos/erik-lundgren/fsharplu/subscribers","subscription_url":"https://api.github.com/repos/erik-lundgren/fsharplu/subscription","commits_url":"https://api.github.com/repos/erik-lundgren/fsharplu/commits{/sha}","git_commits_url":"https://api.github.com/repos/erik-lundgren/fsharplu/git/commits{/sha}","comments_url":"https://api.github.com/repos/erik-lundgren/fsharplu/comments{/number}","issue_comment_url":"https://api.github.com/repos/erik-lundgren/fsharplu/issues/comments{/number}","contents_url":"https://api.github.com/repos/erik-lundgren/fsharplu/contents/{+path}","compare_url":"https://api.github.com/repos/erik-lundgren/fsharplu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erik-lundgren/fsharplu/merges","archive_url":"https://api.github.com/repos/erik-lundgren/fsharplu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erik-lundgren/fsharplu/downloads","issues_url":"https://api.github.com/repos/erik-lundgren/fsharplu/issues{/number}","pulls_url":"https://api.github.com/repos/erik-lundgren/fsharplu/pulls{/number}","milestones_url":"https://api.github.com/repos/erik-lundgren/fsharplu/milestones{/number}","notifications_url":"https://api.github.com/repos/erik-lundgren/fsharplu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erik-lundgren/fsharplu/labels{/name}","releases_url":"https://api.github.com/repos/erik-lundgren/fsharplu/releases{/id}","deployments_url":"https://api.github.com/repos/erik-lundgren/fsharplu/deployments","created_at":"2019-01-31T19:46:23Z","updated_at":"2019-02-01T08:57:53Z","pushed_at":"2019-02-01T08:57:51Z","git_url":"git://github.com/erik-lundgren/fsharplu.git","ssh_url":"git@github.com:erik-lundgren/fsharplu.git","clone_url":"https://github.com/erik-lundgren/fsharplu.git","svn_url":"https://github.com/erik-lundgren/fsharplu","homepage":"https://www.nuget.org/packages/Microsoft.FSharpLu/","size":174,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"3963628368de03e57c4634b08bf8b033e128a1d7","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":61918361,"node_id":"MDEwOlJlcG9zaXRvcnk2MTkxODM2MQ==","name":"fsharplu","full_name":"Microsoft/fsharplu","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/fsharplu","description":"This library provides a set of F# helpers for string manipulations, logging, collection data structures, file operations, text processing, security, async, parsing, diagnostics, configuration files and Json serialization.","fork":false,"url":"https://api.github.com/repos/Microsoft/fsharplu","forks_url":"https://api.github.com/repos/Microsoft/fsharplu/forks","keys_url":"https://api.github.com/repos/Microsoft/fsharplu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/fsharplu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/fsharplu/teams","hooks_url":"https://api.github.com/repos/Microsoft/fsharplu/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/fsharplu/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/fsharplu/events","assignees_url":"https://api.github.com/repos/Microsoft/fsharplu/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/fsharplu/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/fsharplu/tags","blobs_url":"https://api.github.com/repos/Microsoft/fsharplu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/fsharplu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/fsharplu/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/fsharplu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/fsharplu/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/fsharplu/languages","stargazers_url":"https://api.github.com/repos/Microsoft/fsharplu/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/fsharplu/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/fsharplu/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/fsharplu/subscription","commits_url":"https://api.github.com/repos/Microsoft/fsharplu/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/fsharplu/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/fsharplu/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/fsharplu/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/fsharplu/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/fsharplu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/fsharplu/merges","archive_url":"https://api.github.com/repos/Microsoft/fsharplu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/fsharplu/downloads","issues_url":"https://api.github.com/repos/Microsoft/fsharplu/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/fsharplu/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/fsharplu/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/fsharplu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/fsharplu/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/fsharplu/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/fsharplu/deployments","created_at":"2016-06-24T23:47:02Z","updated_at":"2019-02-25T16:24:00Z","pushed_at":"2019-02-04T22:54:27Z","git_url":"git://github.com/Microsoft/fsharplu.git","ssh_url":"git@github.com:Microsoft/fsharplu.git","clone_url":"https://github.com/Microsoft/fsharplu.git","svn_url":"https://github.com/Microsoft/fsharplu","homepage":"https://www.nuget.org/packages/Microsoft.FSharpLu/","size":173,"stargazers_count":226,"watchers_count":226,"language":"F#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":11,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/fsharplu/pulls/60"},"html":{"href":"https://github.com/Microsoft/fsharplu/pull/60"},"issue":{"href":"https://api.github.com/repos/Microsoft/fsharplu/issues/60"},"comments":{"href":"https://api.github.com/repos/Microsoft/fsharplu/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/fsharplu/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/fsharplu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/fsharplu/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/fsharplu/statuses/497a8409ef0d2767148911c8c5c2601e4626ac43"}},"author_association":"NONE"}}
|
{
"id": 61918361,
"name": "Microsoft/fsharplu",
"url": "https://api.github.com/repos/Microsoft/fsharplu"
}
|
{
"id": 3913258,
"login": "blumu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3913258?",
"url": "https://api.github.com/users/blumu"
}
|
{
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
}
| 2019-02-26T21:23:37 |
9141915711
|
{"actor":{"display_login":"blumu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/comments/365920354","pull_request_review_id":341998593,"id":365920354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTkyMDM1NA==","diff_hunk":"@@ -81,99 +81,86 @@ def set_seed(seed, cuda=True):\n if cuda and torch.cuda.is_available():\n torch.cuda.manual_seed_all(seed)\n \n+ @staticmethod\n+ def get_default_optimizer(model, weight_decay, learning_rate, adam_epsilon):\n+ no_decay = [\"bias\", \"LayerNorm.weight\"]\n+ optimizer_grouped_parameters = [\n+ {\n+ \"params\": [\n+ p for n, p in model.named_parameters() if not any(nd in n for nd in no_decay)\n+ ],\n+ \"weight_decay\": weight_decay,\n+ },\n+ {\n+ \"params\": [\n+ p for n, p in model.named_parameters() if any(nd in n for nd in no_decay)\n+ ],\n+ \"weight_decay\": 0.0,\n+ },\n+ ]\n+ optimizer = AdamW(optimizer_grouped_parameters, lr=learning_rate, eps=adam_epsilon)\n+ return optimizer\n+\n+ @staticmethod\n+ def get_default_scheduler(\n+ optimizer, warmup_steps, data_loader, max_steps, num_epochs, gradient_accumulation_steps\n+ ):","path":"utils_nlp/models/transformers/common.py","position":36,"original_position":36,"commit_id":"8242bcf767aa7f1d2357c8d5ccbdeb5806b0bb84","original_commit_id":"8242bcf767aa7f1d2357c8d5ccbdeb5806b0bb84","user":{"login":"daden-ms","id":19354140,"node_id":"MDQ6VXNlcjE5MzU0MTQw","avatar_url":"https://avatars2.githubusercontent.com/u/19354140?v=4","gravatar_id":"","url":"https://api.github.com/users/daden-ms","html_url":"https://github.com/daden-ms","followers_url":"https://api.github.com/users/daden-ms/followers","following_url":"https://api.github.com/users/daden-ms/following{/other_user}","gists_url":"https://api.github.com/users/daden-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/daden-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daden-ms/subscriptions","organizations_url":"https://api.github.com/users/daden-ms/orgs","repos_url":"https://api.github.com/users/daden-ms/repos","events_url":"https://api.github.com/users/daden-ms/events{/privacy}","received_events_url":"https://api.github.com/users/daden-ms/received_events","type":"User","site_admin":false},"body":"we can wrap the logic of determining the max_steps as a function too.","created_at":"2020-01-13T17:07:43Z","updated_at":"2020-01-13T17:07:43Z","html_url":"https://github.com/microsoft/nlp-recipes/pull/529#discussion_r365920354","pull_request_url":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/529","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/comments/365920354"},"html":{"href":"https://github.com/microsoft/nlp-recipes/pull/529#discussion_r365920354"},"pull_request":{"href":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/529"}},"in_reply_to_id":365918386},"pull_request":{"url":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/529","id":359682746,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5NjgyNzQ2","html_url":"https://github.com/microsoft/nlp-recipes/pull/529","diff_url":"https://github.com/microsoft/nlp-recipes/pull/529.diff","patch_url":"https://github.com/microsoft/nlp-recipes/pull/529.patch","issue_url":"https://api.github.com/repos/microsoft/nlp-recipes/issues/529","number":529,"state":"open","locked":false,"title":"bleik/common transformers utils update","user":{"login":"saidbleik","id":6117893,"node_id":"MDQ6VXNlcjYxMTc4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6117893?v=4","gravatar_id":"","url":"https://api.github.com/users/saidbleik","html_url":"https://github.com/saidbleik","followers_url":"https://api.github.com/users/saidbleik/followers","following_url":"https://api.github.com/users/saidbleik/following{/other_user}","gists_url":"https://api.github.com/users/saidbleik/gists{/gist_id}","starred_url":"https://api.github.com/users/saidbleik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saidbleik/subscriptions","organizations_url":"https://api.github.com/users/saidbleik/orgs","repos_url":"https://api.github.com/users/saidbleik/repos","events_url":"https://api.github.com/users/saidbleik/events{/privacy}","received_events_url":"https://api.github.com/users/saidbleik/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nChanged the order of moving a model to a device and constructing the optimizer.\r\nref: https://pytorch.org/docs/master/optim.html\r\n\r\n### Related Issues\r\n#532 \r\n\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project, as detailed in our [contribution guidelines](../CONTRIBUTING.md).\r\n- [x] I have added tests.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\n\r\n\r\n","created_at":"2020-01-06T19:38:37Z","updated_at":"2020-01-13T17:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9841a0da07b7528e4f19ee7752b36266a1d0b090","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/529/commits","review_comments_url":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/529/comments","review_comment_url":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/nlp-recipes/issues/529/comments","statuses_url":"https://api.github.com/repos/microsoft/nlp-recipes/statuses/8242bcf767aa7f1d2357c8d5ccbdeb5806b0bb84","head":{"label":"microsoft:bleik/optim-patch","ref":"bleik/optim-patch","sha":"8242bcf767aa7f1d2357c8d5ccbdeb5806b0bb84","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":179728393,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk3MjgzOTM=","name":"nlp-recipes","full_name":"microsoft/nlp-recipes","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/nlp-recipes","description":"Natural Language Processing Best Practices & Examples","fork":false,"url":"https://api.github.com/repos/microsoft/nlp-recipes","forks_url":"https://api.github.com/repos/microsoft/nlp-recipes/forks","keys_url":"https://api.github.com/repos/microsoft/nlp-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/nlp-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/nlp-recipes/teams","hooks_url":"https://api.github.com/repos/microsoft/nlp-recipes/hooks","issue_events_url":"https://api.github.com/repos/microsoft/nlp-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/nlp-recipes/events","assignees_url":"https://api.github.com/repos/microsoft/nlp-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/nlp-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/nlp-recipes/tags","blobs_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/nlp-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/nlp-recipes/languages","stargazers_url":"https://api.github.com/repos/microsoft/nlp-recipes/stargazers","contributors_url":"https://api.github.com/repos/microsoft/nlp-recipes/contributors","subscribers_url":"https://api.github.com/repos/microsoft/nlp-recipes/subscribers","subscription_url":"https://api.github.com/repos/microsoft/nlp-recipes/subscription","commits_url":"https://api.github.com/repos/microsoft/nlp-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/nlp-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/nlp-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/nlp-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/nlp-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/nlp-recipes/merges","archive_url":"https://api.github.com/repos/microsoft/nlp-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/nlp-recipes/downloads","issues_url":"https://api.github.com/repos/microsoft/nlp-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/nlp-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/nlp-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/nlp-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/nlp-recipes/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/nlp-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/nlp-recipes/deployments","created_at":"2019-04-05T17:42:41Z","updated_at":"2020-01-13T14:43:41Z","pushed_at":"2020-01-13T16:40:16Z","git_url":"git://github.com/microsoft/nlp-recipes.git","ssh_url":"git@github.com:microsoft/nlp-recipes.git","clone_url":"https://github.com/microsoft/nlp-recipes.git","svn_url":"https://github.com/microsoft/nlp-recipes","homepage":null,"size":46664,"stargazers_count":3322,"watchers_count":3322,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":332,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":332,"open_issues":49,"watchers":3322,"default_branch":"master"}},"base":{"label":"microsoft:staging","ref":"staging","sha":"22448d17b4a7af7af0a18059fb963383bfb43b77","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":179728393,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk3MjgzOTM=","name":"nlp-recipes","full_name":"microsoft/nlp-recipes","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/nlp-recipes","description":"Natural Language Processing Best Practices & Examples","fork":false,"url":"https://api.github.com/repos/microsoft/nlp-recipes","forks_url":"https://api.github.com/repos/microsoft/nlp-recipes/forks","keys_url":"https://api.github.com/repos/microsoft/nlp-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/nlp-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/nlp-recipes/teams","hooks_url":"https://api.github.com/repos/microsoft/nlp-recipes/hooks","issue_events_url":"https://api.github.com/repos/microsoft/nlp-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/nlp-recipes/events","assignees_url":"https://api.github.com/repos/microsoft/nlp-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/nlp-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/nlp-recipes/tags","blobs_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/nlp-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/nlp-recipes/languages","stargazers_url":"https://api.github.com/repos/microsoft/nlp-recipes/stargazers","contributors_url":"https://api.github.com/repos/microsoft/nlp-recipes/contributors","subscribers_url":"https://api.github.com/repos/microsoft/nlp-recipes/subscribers","subscription_url":"https://api.github.com/repos/microsoft/nlp-recipes/subscription","commits_url":"https://api.github.com/repos/microsoft/nlp-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/nlp-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/nlp-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/nlp-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/nlp-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/nlp-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/nlp-recipes/merges","archive_url":"https://api.github.com/repos/microsoft/nlp-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/nlp-recipes/downloads","issues_url":"https://api.github.com/repos/microsoft/nlp-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/nlp-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/nlp-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/nlp-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/nlp-recipes/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/nlp-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/nlp-recipes/deployments","created_at":"2019-04-05T17:42:41Z","updated_at":"2020-01-13T14:43:41Z","pushed_at":"2020-01-13T16:40:16Z","git_url":"git://github.com/microsoft/nlp-recipes.git","ssh_url":"git@github.com:microsoft/nlp-recipes.git","clone_url":"https://github.com/microsoft/nlp-recipes.git","svn_url":"https://github.com/microsoft/nlp-recipes","homepage":null,"size":46664,"stargazers_count":3322,"watchers_count":3322,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":332,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":332,"open_issues":49,"watchers":3322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/529"},"html":{"href":"https://github.com/microsoft/nlp-recipes/pull/529"},"issue":{"href":"https://api.github.com/repos/microsoft/nlp-recipes/issues/529"},"comments":{"href":"https://api.github.com/repos/microsoft/nlp-recipes/issues/529/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/529/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/nlp-recipes/pulls/529/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/nlp-recipes/statuses/8242bcf767aa7f1d2357c8d5ccbdeb5806b0bb84"}},"author_association":"COLLABORATOR"}}
|
{
"id": 179728393,
"name": "microsoft/nlp-recipes",
"url": "https://api.github.com/repos/microsoft/nlp-recipes"
}
|
{
"id": 19354140,
"login": "daden-ms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19354140?",
"url": "https://api.github.com/users/daden-ms"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2020-01-13T17:07:43 |
11263845504
|
{"actor":{"display_login":"daden-ms"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/264382798","pull_request_review_id":213026644,"id":264382798,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDM4Mjc5OA==","diff_hunk":"@@ -120,11 +120,14 @@ export class UnitTestManagementService implements IUnitTestManagementService, Di\n if (!this.workspaceService.hasWorkspaceFolders || this.workspaceService.workspaceFolders!.length > 1) {\n return;\n }\n-\n- const workspaceUri = this.workspaceService.workspaceFolders![0].uri;\n- if (!e.affectsConfiguration('python.unitTest', workspaceUri)) {\n+ if (!Array.isArray(this.workspaceService.workspaceFolders)) {\n+ return;\n+ }\n+ const workspaceFolderUri = this.workspaceService.workspaceFolders.find(w => e.affectsConfiguration('python.unitTest', w.uri));","path":"src/client/unittests/main.ts","position":28,"original_position":28,"commit_id":"f6b85ff9a30287f6f4509afd6210b56108d9b6cc","original_commit_id":"f6b85ff9a30287f6f4509afd6210b56108d9b6cc","user":{"login":"ericsnowcurrently","id":1152074,"node_id":"MDQ6VXNlcjExNTIwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1152074?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"body":"What is `e` here and what does `e.affectsConfiguration()` do?","created_at":"2019-03-11T19:00:20Z","updated_at":"2019-03-11T19:01:13Z","html_url":"https://github.com/Microsoft/vscode-python/pull/4667#discussion_r264382798","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/4667","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/264382798"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/4667#discussion_r264382798"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/4667"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/4667","id":259207088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MjA3MDg4","html_url":"https://github.com/Microsoft/vscode-python/pull/4667","diff_url":"https://github.com/Microsoft/vscode-python/pull/4667.diff","patch_url":"https://github.com/Microsoft/vscode-python/pull/4667.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/4667","number":4667,"state":"open","locked":false,"title":"Fixes related to multi-root support for tests","user":{"login":"DonJayamanne","id":1948812,"node_id":"MDQ6VXNlcjE5NDg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"body":"For #4268\r\n\r\n<!--\r\n If an item below does not apply to you, then go ahead and check it off as \"done\" and strikethrough the text, e.g.:\r\n - [x] ~Has unit tests & system/integration tests~\r\n-->\r\n- [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)\r\n- [x] Title summarizes what is changing\r\n- [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)\r\n- [n/a] Has sufficient logging.\r\n- [x] Has telemetry for enhancements.\r\n- [n/a] Unit tests & system/integration tests are added/updated\r\n- [n/a] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate\r\n- [n/a] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)\r\n- [n/a] The wiki is updated with any design decisions/details.\r\n","created_at":"2019-03-07T17:38:51Z","updated_at":"2019-03-11T19:01:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0aab8b399b1aaec6cf3760036e093bfa122b742b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/4667/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/4667/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/4667/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/f6b85ff9a30287f6f4509afd6210b56108d9b6cc","head":{"label":"DonJayamanne:issue4268MultiRoot","ref":"issue4268MultiRoot","sha":"f6b85ff9a30287f6f4509afd6210b56108d9b6cc","user":{"login":"DonJayamanne","id":1948812,"node_id":"MDQ6VXNlcjE5NDg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"repo":{"id":49946255,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk0NjI1NQ==","name":"pythonVSCode","full_name":"DonJayamanne/pythonVSCode","private":false,"owner":{"login":"DonJayamanne","id":1948812,"node_id":"MDQ6VXNlcjE5NDg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DonJayamanne/pythonVSCode","description":"This extension is now maintained in the Microsoft fork.","fork":false,"url":"https://api.github.com/repos/DonJayamanne/pythonVSCode","forks_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/forks","keys_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/teams","hooks_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/hooks","issue_events_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/issues/events{/number}","events_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/events","assignees_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/assignees{/user}","branches_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/branches{/branch}","tags_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/tags","blobs_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/refs{/sha}","trees_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/statuses/{sha}","languages_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/languages","stargazers_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/stargazers","contributors_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/contributors","subscribers_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/subscribers","subscription_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/subscription","commits_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/commits{/sha}","git_commits_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/commits{/sha}","comments_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/comments{/number}","issue_comment_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/issues/comments{/number}","contents_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/contents/{+path}","compare_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/merges","archive_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/downloads","issues_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/issues{/number}","pulls_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/pulls{/number}","milestones_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/milestones{/number}","notifications_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/labels{/name}","releases_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/releases{/id}","deployments_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/deployments","created_at":"2016-01-19T10:50:01Z","updated_at":"2019-03-11T18:45:09Z","pushed_at":"2019-03-11T18:52:52Z","git_url":"git://github.com/DonJayamanne/pythonVSCode.git","ssh_url":"git@github.com:DonJayamanne/pythonVSCode.git","clone_url":"https://github.com/DonJayamanne/pythonVSCode.git","svn_url":"https://github.com/DonJayamanne/pythonVSCode","homepage":"https://github.com/Microsoft/vscode-python","size":161234,"stargazers_count":1885,"watchers_count":1885,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":478,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":478,"open_issues":48,"watchers":1885,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"1fb0799e12a7d54787993a6529e5046f3124f9fb","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106462765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NjI3NjU=","name":"vscode-python","full_name":"Microsoft/vscode-python","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/Microsoft/vscode-python","forks_url":"https://api.github.com/repos/Microsoft/vscode-python/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-python/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-python/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-python/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-python/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-python/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-python/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-python/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-python/deployments","created_at":"2017-10-10T19:37:29Z","updated_at":"2019-03-11T10:34:43Z","pushed_at":"2019-03-11T18:57:45Z","git_url":"git://github.com/Microsoft/vscode-python.git","ssh_url":"git@github.com:Microsoft/vscode-python.git","clone_url":"https://github.com/Microsoft/vscode-python.git","svn_url":"https://github.com/Microsoft/vscode-python","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-python.python","size":63530,"stargazers_count":1203,"watchers_count":1203,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":248,"mirror_url":null,"archived":false,"open_issues_count":786,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":248,"open_issues":786,"watchers":1203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/4667"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/4667"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/4667"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/4667/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/4667/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/4667/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-python/statuses/f6b85ff9a30287f6f4509afd6210b56108d9b6cc"}},"author_association":"NONE"}}
|
{
"id": 106462765,
"name": "Microsoft/vscode-python",
"url": "https://api.github.com/repos/Microsoft/vscode-python"
}
|
{
"id": 1152074,
"login": "ericsnowcurrently",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1152074?",
"url": "https://api.github.com/users/ericsnowcurrently"
}
|
{
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
}
| 2019-03-11T19:00:20 |
9221065990
|
{"actor":{"display_login":"ericsnowcurrently"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/comments/288787134","pull_request_review_id":243539270,"id":288787134,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODc4NzEzNA==","diff_hunk":"@@ -0,0 +1,23 @@\n+ },\n+//{[{\n+ \"eslintConfig\": {\n+ \"root\": true,\n+ \"env\": {\n+ \"node\": true\n+ },\n+ \"extends\": [\n+ \"plugin:vue/essential\",\n+ \"eslint:recommended\"\n+ ],\n+ \"rules\": {},\n+ \"parserOptions\": {\n+ \"parser\": \"babel-eslint\"\n+ }\n+ },\n+ \"postcss\": {\n+ \"plugins\": {\n+ \"autoprefixer\": {}\n+ }\n+ },\n+//}]}\n+ \"browserslist\": [","path":"templates/Web/Projects/VueDefault/package_postaction.json","position":23,"original_position":23,"commit_id":"da8481749c72a09a71cbc23bf7bce2c23ec3ff02","original_commit_id":"da8481749c72a09a71cbc23bf7bce2c23ec3ff02","user":{"login":"SahilTara","id":32103099,"node_id":"MDQ6VXNlcjMyMTAzMDk5","avatar_url":"https://avatars1.githubusercontent.com/u/32103099?v=4","gravatar_id":"","url":"https://api.github.com/users/SahilTara","html_url":"https://github.com/SahilTara","followers_url":"https://api.github.com/users/SahilTara/followers","following_url":"https://api.github.com/users/SahilTara/following{/other_user}","gists_url":"https://api.github.com/users/SahilTara/gists{/gist_id}","starred_url":"https://api.github.com/users/SahilTara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SahilTara/subscriptions","organizations_url":"https://api.github.com/users/SahilTara/orgs","repos_url":"https://api.github.com/users/SahilTara/repos","events_url":"https://api.github.com/users/SahilTara/events{/privacy}","received_events_url":"https://api.github.com/users/SahilTara/received_events","type":"User","site_admin":false},"body":"it seems messed up but this gets inserted properly, try hitting generate post packaging. The red markers are there because json doesn't support comments. is there anything specific you're refering to?","created_at":"2019-05-29T22:02:45Z","updated_at":"2019-05-29T22:03:35Z","html_url":"https://github.com/microsoft/WebTemplateStudio/pull/631#discussion_r288787134","pull_request_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/631","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/comments/288787134"},"html":{"href":"https://github.com/microsoft/WebTemplateStudio/pull/631#discussion_r288787134"},"pull_request":{"href":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/631"}},"in_reply_to_id":288783734},"pull_request":{"url":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/631","id":282665230,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyNjY1MjMw","html_url":"https://github.com/microsoft/WebTemplateStudio/pull/631","diff_url":"https://github.com/microsoft/WebTemplateStudio/pull/631.diff","patch_url":"https://github.com/microsoft/WebTemplateStudio/pull/631.patch","issue_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/issues/631","number":631,"state":"open","locked":false,"title":"Base templates for vue","user":{"login":"SahilTara","id":32103099,"node_id":"MDQ6VXNlcjMyMTAzMDk5","avatar_url":"https://avatars1.githubusercontent.com/u/32103099?v=4","gravatar_id":"","url":"https://api.github.com/users/SahilTara","html_url":"https://github.com/SahilTara","followers_url":"https://api.github.com/users/SahilTara/followers","following_url":"https://api.github.com/users/SahilTara/following{/other_user}","gists_url":"https://api.github.com/users/SahilTara/gists{/gist_id}","starred_url":"https://api.github.com/users/SahilTara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SahilTara/subscriptions","organizations_url":"https://api.github.com/users/SahilTara/orgs","repos_url":"https://api.github.com/users/SahilTara/repos","events_url":"https://api.github.com/users/SahilTara/events{/privacy}","received_events_url":"https://api.github.com/users/SahilTara/received_events","type":"User","site_admin":false},"body":"Summary of changes:\r\nImplements the base of Vue templates. Vue is set under a preview flag. This is what is always generated no matter what is selected.\r\n\r\nTo test PR will need to package locally.\r\n\r\nRelated issue:\r\n#199 \r\n","created_at":"2019-05-28T04:37:21Z","updated_at":"2019-05-29T22:03:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a96caa5ee67034591f80cead9169d70d58f4e37","assignee":null,"assignees":[],"requested_reviewers":[{"login":"crutkas","id":1462282,"node_id":"MDQ6VXNlcjE0NjIyODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1462282?v=4","gravatar_id":"","url":"https://api.github.com/users/crutkas","html_url":"https://github.com/crutkas","followers_url":"https://api.github.com/users/crutkas/followers","following_url":"https://api.github.com/users/crutkas/following{/other_user}","gists_url":"https://api.github.com/users/crutkas/gists{/gist_id}","starred_url":"https://api.github.com/users/crutkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crutkas/subscriptions","organizations_url":"https://api.github.com/users/crutkas/orgs","repos_url":"https://api.github.com/users/crutkas/repos","events_url":"https://api.github.com/users/crutkas/events{/privacy}","received_events_url":"https://api.github.com/users/crutkas/received_events","type":"User","site_admin":false},{"login":"tejbirsingh","id":2815284,"node_id":"MDQ6VXNlcjI4MTUyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2815284?v=4","gravatar_id":"","url":"https://api.github.com/users/tejbirsingh","html_url":"https://github.com/tejbirsingh","followers_url":"https://api.github.com/users/tejbirsingh/followers","following_url":"https://api.github.com/users/tejbirsingh/following{/other_user}","gists_url":"https://api.github.com/users/tejbirsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/tejbirsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejbirsingh/subscriptions","organizations_url":"https://api.github.com/users/tejbirsingh/orgs","repos_url":"https://api.github.com/users/tejbirsingh/repos","events_url":"https://api.github.com/users/tejbirsingh/events{/privacy}","received_events_url":"https://api.github.com/users/tejbirsingh/received_events","type":"User","site_admin":false},{"login":"smmatte","id":3877456,"node_id":"MDQ6VXNlcjM4Nzc0NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3877456?v=4","gravatar_id":"","url":"https://api.github.com/users/smmatte","html_url":"https://github.com/smmatte","followers_url":"https://api.github.com/users/smmatte/followers","following_url":"https://api.github.com/users/smmatte/following{/other_user}","gists_url":"https://api.github.com/users/smmatte/gists{/gist_id}","starred_url":"https://api.github.com/users/smmatte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smmatte/subscriptions","organizations_url":"https://api.github.com/users/smmatte/orgs","repos_url":"https://api.github.com/users/smmatte/repos","events_url":"https://api.github.com/users/smmatte/events{/privacy}","received_events_url":"https://api.github.com/users/smmatte/received_events","type":"User","site_admin":false},{"login":"mvegaca","id":5556784,"node_id":"MDQ6VXNlcjU1NTY3ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5556784?v=4","gravatar_id":"","url":"https://api.github.com/users/mvegaca","html_url":"https://github.com/mvegaca","followers_url":"https://api.github.com/users/mvegaca/followers","following_url":"https://api.github.com/users/mvegaca/following{/other_user}","gists_url":"https://api.github.com/users/mvegaca/gists{/gist_id}","starred_url":"https://api.github.com/users/mvegaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvegaca/subscriptions","organizations_url":"https://api.github.com/users/mvegaca/orgs","repos_url":"https://api.github.com/users/mvegaca/repos","events_url":"https://api.github.com/users/mvegaca/events{/privacy}","received_events_url":"https://api.github.com/users/mvegaca/received_events","type":"User","site_admin":false},{"login":"dgomezc","id":12777039,"node_id":"MDQ6VXNlcjEyNzc3MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/12777039?v=4","gravatar_id":"","url":"https://api.github.com/users/dgomezc","html_url":"https://github.com/dgomezc","followers_url":"https://api.github.com/users/dgomezc/followers","following_url":"https://api.github.com/users/dgomezc/following{/other_user}","gists_url":"https://api.github.com/users/dgomezc/gists{/gist_id}","starred_url":"https://api.github.com/users/dgomezc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgomezc/subscriptions","organizations_url":"https://api.github.com/users/dgomezc/orgs","repos_url":"https://api.github.com/users/dgomezc/repos","events_url":"https://api.github.com/users/dgomezc/events{/privacy}","received_events_url":"https://api.github.com/users/dgomezc/received_events","type":"User","site_admin":false},{"login":"KirillShchetinin","id":13061871,"node_id":"MDQ6VXNlcjEzMDYxODcx","avatar_url":"https://avatars1.githubusercontent.com/u/13061871?v=4","gravatar_id":"","url":"https://api.github.com/users/KirillShchetinin","html_url":"https://github.com/KirillShchetinin","followers_url":"https://api.github.com/users/KirillShchetinin/followers","following_url":"https://api.github.com/users/KirillShchetinin/following{/other_user}","gists_url":"https://api.github.com/users/KirillShchetinin/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillShchetinin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillShchetinin/subscriptions","organizations_url":"https://api.github.com/users/KirillShchetinin/orgs","repos_url":"https://api.github.com/users/KirillShchetinin/repos","events_url":"https://api.github.com/users/KirillShchetinin/events{/privacy}","received_events_url":"https://api.github.com/users/KirillShchetinin/received_events","type":"User","site_admin":false},{"login":"sibille","id":24698018,"node_id":"MDQ6VXNlcjI0Njk4MDE4","avatar_url":"https://avatars0.githubusercontent.com/u/24698018?v=4","gravatar_id":"","url":"https://api.github.com/users/sibille","html_url":"https://github.com/sibille","followers_url":"https://api.github.com/users/sibille/followers","following_url":"https://api.github.com/users/sibille/following{/other_user}","gists_url":"https://api.github.com/users/sibille/gists{/gist_id}","starred_url":"https://api.github.com/users/sibille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sibille/subscriptions","organizations_url":"https://api.github.com/users/sibille/orgs","repos_url":"https://api.github.com/users/sibille/repos","events_url":"https://api.github.com/users/sibille/events{/privacy}","received_events_url":"https://api.github.com/users/sibille/received_events","type":"User","site_admin":false},{"login":"markAtMicrosoft","id":34253371,"node_id":"MDQ6VXNlcjM0MjUzMzcx","avatar_url":"https://avatars2.githubusercontent.com/u/34253371?v=4","gravatar_id":"","url":"https://api.github.com/users/markAtMicrosoft","html_url":"https://github.com/markAtMicrosoft","followers_url":"https://api.github.com/users/markAtMicrosoft/followers","following_url":"https://api.github.com/users/markAtMicrosoft/following{/other_user}","gists_url":"https://api.github.com/users/markAtMicrosoft/gists{/gist_id}","starred_url":"https://api.github.com/users/markAtMicrosoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markAtMicrosoft/subscriptions","organizations_url":"https://api.github.com/users/markAtMicrosoft/orgs","repos_url":"https://api.github.com/users/markAtMicrosoft/repos","events_url":"https://api.github.com/users/markAtMicrosoft/events{/privacy}","received_events_url":"https://api.github.com/users/markAtMicrosoft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/631/commits","review_comments_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/631/comments","review_comment_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/issues/631/comments","statuses_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/statuses/da8481749c72a09a71cbc23bf7bce2c23ec3ff02","head":{"label":"SahilTara:SahilTara/vue-base","ref":"SahilTara/vue-base","sha":"da8481749c72a09a71cbc23bf7bce2c23ec3ff02","user":{"login":"SahilTara","id":32103099,"node_id":"MDQ6VXNlcjMyMTAzMDk5","avatar_url":"https://avatars1.githubusercontent.com/u/32103099?v=4","gravatar_id":"","url":"https://api.github.com/users/SahilTara","html_url":"https://github.com/SahilTara","followers_url":"https://api.github.com/users/SahilTara/followers","following_url":"https://api.github.com/users/SahilTara/following{/other_user}","gists_url":"https://api.github.com/users/SahilTara/gists{/gist_id}","starred_url":"https://api.github.com/users/SahilTara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SahilTara/subscriptions","organizations_url":"https://api.github.com/users/SahilTara/orgs","repos_url":"https://api.github.com/users/SahilTara/repos","events_url":"https://api.github.com/users/SahilTara/events{/privacy}","received_events_url":"https://api.github.com/users/SahilTara/received_events","type":"User","site_admin":false},"repo":{"id":186071039,"node_id":"MDEwOlJlcG9zaXRvcnkxODYwNzEwMzk=","name":"WebTemplateStudio","full_name":"SahilTara/WebTemplateStudio","private":false,"owner":{"login":"SahilTara","id":32103099,"node_id":"MDQ6VXNlcjMyMTAzMDk5","avatar_url":"https://avatars1.githubusercontent.com/u/32103099?v=4","gravatar_id":"","url":"https://api.github.com/users/SahilTara","html_url":"https://github.com/SahilTara","followers_url":"https://api.github.com/users/SahilTara/followers","following_url":"https://api.github.com/users/SahilTara/following{/other_user}","gists_url":"https://api.github.com/users/SahilTara/gists{/gist_id}","starred_url":"https://api.github.com/users/SahilTara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SahilTara/subscriptions","organizations_url":"https://api.github.com/users/SahilTara/orgs","repos_url":"https://api.github.com/users/SahilTara/repos","events_url":"https://api.github.com/users/SahilTara/events{/privacy}","received_events_url":"https://api.github.com/users/SahilTara/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SahilTara/WebTemplateStudio","description":"Microsoft Web Template Studio quickly builds web applications using a wizard-based UI to turn your needs into a foundation of best patterns and practices","fork":true,"url":"https://api.github.com/repos/SahilTara/WebTemplateStudio","forks_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/forks","keys_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/teams","hooks_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/hooks","issue_events_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/issues/events{/number}","events_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/events","assignees_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/assignees{/user}","branches_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/branches{/branch}","tags_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/tags","blobs_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/languages","stargazers_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/stargazers","contributors_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/contributors","subscribers_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/subscribers","subscription_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/subscription","commits_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/contents/{+path}","compare_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/merges","archive_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/downloads","issues_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/issues{/number}","pulls_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/labels{/name}","releases_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/releases{/id}","deployments_url":"https://api.github.com/repos/SahilTara/WebTemplateStudio/deployments","created_at":"2019-05-11T00:43:18Z","updated_at":"2019-05-11T00:43:26Z","pushed_at":"2019-05-29T03:10:21Z","git_url":"git://github.com/SahilTara/WebTemplateStudio.git","ssh_url":"git@github.com:SahilTara/WebTemplateStudio.git","clone_url":"https://github.com/SahilTara/WebTemplateStudio.git","svn_url":"https://github.com/SahilTara/WebTemplateStudio","homepage":"","size":110358,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"microsoft:dev","ref":"dev","sha":"28759f22376ae8b25401fb8591d13dcb7148d168","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":168244151,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgyNDQxNTE=","name":"WebTemplateStudio","full_name":"microsoft/WebTemplateStudio","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/WebTemplateStudio","description":"Microsoft Web Template Studio quickly builds web applications using a wizard-based UI to turn your needs into a foundation of best patterns and practices","fork":false,"url":"https://api.github.com/repos/microsoft/WebTemplateStudio","forks_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/forks","keys_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/teams","hooks_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/hooks","issue_events_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/events","assignees_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/tags","blobs_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/languages","stargazers_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/stargazers","contributors_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/contributors","subscribers_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/subscribers","subscription_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/subscription","commits_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/merges","archive_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/downloads","issues_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/WebTemplateStudio/deployments","created_at":"2019-01-29T23:08:41Z","updated_at":"2019-05-29T21:59:58Z","pushed_at":"2019-05-29T21:38:39Z","git_url":"git://github.com/microsoft/WebTemplateStudio.git","ssh_url":"git@github.com:microsoft/WebTemplateStudio.git","clone_url":"https://github.com/microsoft/WebTemplateStudio.git","svn_url":"https://github.com/microsoft/WebTemplateStudio","homepage":"https://aka.ms/webtsinstall","size":135452,"stargazers_count":491,"watchers_count":491,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":89,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":89,"watchers":491,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/631"},"html":{"href":"https://github.com/microsoft/WebTemplateStudio/pull/631"},"issue":{"href":"https://api.github.com/repos/microsoft/WebTemplateStudio/issues/631"},"comments":{"href":"https://api.github.com/repos/microsoft/WebTemplateStudio/issues/631/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/631/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/WebTemplateStudio/pulls/631/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/WebTemplateStudio/statuses/da8481749c72a09a71cbc23bf7bce2c23ec3ff02"}},"author_association":"COLLABORATOR"}}
|
{
"id": 168244151,
"name": "microsoft/WebTemplateStudio",
"url": "https://api.github.com/repos/microsoft/WebTemplateStudio"
}
|
{
"id": 32103099,
"login": "SahilTara",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32103099?",
"url": "https://api.github.com/users/SahilTara"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-05-29T22:02:45 |
9722914794
|
{"actor":{"display_login":"SahilTara"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/comments/304621334","pull_request_review_id":263291054,"id":304621334,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNDYyMTMzNA==","diff_hunk":"@@ -0,0 +1,238 @@\n+using Agent.Sdk;\n+using BuildXL.Cache.ContentStore.Interfaces.Utils;\n+using Microsoft.VisualStudio.Services.PipelineCache.WebApi;\n+using Minimatch;\n+using System;\n+using System.Collections.Generic;\n+using System.IO;\n+using System.Linq;\n+using System.Runtime.CompilerServices;\n+using System.Runtime.InteropServices;\n+using System.Security.Cryptography;\n+using System.Text;\n+\n+[assembly: InternalsVisibleTo(\"Test\")]\n+\n+namespace Agent.Plugins.PipelineCache\n+{\n+ public static class FingerprintCreator\n+ {\n+ private static readonly bool isWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);\n+ private static readonly bool isCaseSensitive = RuntimeInformation.IsOSPlatform(OSPlatform.Linux);\n+\n+ // https://github.com/Microsoft/azure-pipelines-task-lib/blob/master/node/docs/findingfiles.md#matchoptions\n+ private static readonly Options minimatchOptions = new Options\n+ {\n+ Dot = true,\n+ NoBrace = true,\n+ NoCase = !isCaseSensitive,\n+ AllowWindowsPaths = isWindows,\n+ };\n+\n+ private static readonly char[] GlobChars = new [] { '*', '?', '[', ']' };\n+\n+ private static bool IsPathyChar(char c)\n+ {\n+ if (GlobChars.Contains(c)) return true;\n+ if (c == Path.DirectorySeparatorChar) return true;\n+ if (c == Path.AltDirectorySeparatorChar) return true;\n+ if (c == Path.VolumeSeparatorChar) return true;\n+ return !Path.GetInvalidFileNameChars().Contains(c);\n+ }\n+\n+ internal static bool IsPathy(string keySegment)\n+ {\n+ if (keySegment.First() == '\\'' && keySegment.Last() == '\\'') return false;\n+ if (keySegment.First() == '\"' && keySegment.Last() == '\"') return false;\n+ if (keySegment.Any(c => !IsPathyChar(c))) return false;\n+ if (!keySegment.Contains(\".\")) return false;\n+ if (keySegment.Last() == '.') return false;\n+ return true;\n+ }\n+\n+ internal static Func<string,bool> CreateMinimatchFilter(AgentTaskPluginExecutionContext context, string rule, bool invert)\n+ {\n+ Func<string,bool> filter = Minimatcher.CreateFilter(rule, minimatchOptions);\n+ Func<string,bool> tracedFilter = (path) => {\n+ bool filterResult = filter(path);\n+ context.Verbose($\"Path `{path}` is {(filterResult ? \"included\" : \"excluded\")} because of pattern `{(invert ? \"!\" : \"\")}{rule}`.\");\n+ bool result = invert ^ filterResult;\n+ return result;\n+ };\n+\n+ return tracedFilter;\n+ }\n+\n+ internal static string MakePathAbsolute(string workingDirectory, string path)\n+ {\n+ // Normalize to some extent, let minimatch worry about casing\n+ if (workingDirectory == null)\n+ {\n+ return Path.GetFullPath(path);\n+ }\n+ else\n+ {\n+ return Path.GetFullPath(path, workingDirectory);\n+ }\n+ }\n+\n+ internal static Func<string,bool> CreateFilter(\n+ AgentTaskPluginExecutionContext context,\n+ string workingDirectory,\n+ string includeRule,\n+ IEnumerable<string> excludeRules)\n+ {\n+ Func<string,bool> includeFilter = CreateMinimatchFilter(context, includeRule, invert: false);\n+ Func<string,bool>[] excludeFilters = excludeRules.Select(excludeRule => \n+ CreateMinimatchFilter(context, excludeRule, invert: true)).ToArray();\n+ Func<string,bool> filter = (path) => includeFilter(path) && excludeFilters.All(f => f(path));\n+ return filter;\n+ }\n+\n+\n+ // Given a globby path, figure out where to start enumerating.\n+ // Room for optimization here e.g. \n+ // includeGlobPath = /dir/*foo* \n+ // should map to \n+ // enumerateRootPath = /dir/\n+ // enumeratePattern = *foo*\n+ // enumerateDepth = SearchOption.TopDirectoryOnly\n+ //\n+ // It's ok to come up with a file-enumeration that includes too much as the glob filter\n+ // will filter out the extra, but it's not ok to include too little in the enumeration.\n+ internal static void DetermineFileEnumerationFromGlob(\n+ string includeGlobPathAbsolute,\n+ out string enumerateRootPath,\n+ out string enumeratePattern,\n+ out SearchOption enumerateDepth)\n+ {\n+ int firstGlob = includeGlobPathAbsolute.IndexOfAny(GlobChars);\n+ bool hasRecursive = includeGlobPathAbsolute.Contains(\"**\", StringComparison.Ordinal);\n+\n+ // no globbing\n+ if (firstGlob < 0)\n+ {\n+ enumerateRootPath = Path.GetDirectoryName(includeGlobPathAbsolute);\n+ enumeratePattern = Path.GetFileName(includeGlobPathAbsolute);\n+ enumerateDepth = SearchOption.TopDirectoryOnly;\n+ }\n+ else\n+ {\n+ int rootDirLength = includeGlobPathAbsolute.Substring(0,firstGlob).LastIndexOfAny( new [] { Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar});\n+ enumerateRootPath = includeGlobPathAbsolute.Substring(0,rootDirLength);\n+ enumeratePattern = \"*\";\n+ enumerateDepth = hasRecursive ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly;\n+ }\n+ }\n+\n+ public static Fingerprint EvaluateKeyToFingerprint(\n+ AgentTaskPluginExecutionContext context,\n+ string filePathRoot,\n+ IEnumerable<string> keySegments,\n+ bool addWildcard)\n+ {\n+ var sha256 = new SHA256Managed();\n+\n+ string workingDirectoryValue = context.Variables.GetValueOrDefault(\n+ \"system.defaultworkingdirectory\" // Constants.Variables.System.DefaultWorkingDirectory\n+ )?.Value;\n+\n+ var resolvedSegments = new List<string>();\n+\n+ foreach (string keySegment in keySegments)\n+ {\n+ if (keySegment.Equals(\"*\", StringComparison.Ordinal))\n+ {\n+ throw new ArgumentException(\"`*` is a reserved key segment. For path glob, use `./*`.\");\n+ }\n+ else if (keySegment.Equals(Fingerprint.Wildcard, StringComparison.Ordinal))\n+ {\n+ throw new ArgumentException(\"`**` is a reserved key segment. For path glob, use `./**`.\");\n+ }\n+ else if (IsPathy(keySegment))\n+ {\n+ context.Verbose($\"Interpretting `{keySegment}` as a path.\");\n+\n+ var segment = new StringBuilder();\n+ bool foundFile = false;\n+\n+ string[] pathRules = keySegment.Split(new []{','}, StringSplitOptions.RemoveEmptyEntries);","path":"src/Agent.Plugins/PipelineCache/FingerprintCreator.cs","position":159,"original_position":159,"commit_id":"742643a976441200016856f69346c91a463793fa","original_commit_id":"742643a976441200016856f69346c91a463793fa","user":{"login":"willsmythe","id":2503052,"node_id":"MDQ6VXNlcjI1MDMwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2503052?v=4","gravatar_id":"","url":"https://api.github.com/users/willsmythe","html_url":"https://github.com/willsmythe","followers_url":"https://api.github.com/users/willsmythe/followers","following_url":"https://api.github.com/users/willsmythe/following{/other_user}","gists_url":"https://api.github.com/users/willsmythe/gists{/gist_id}","starred_url":"https://api.github.com/users/willsmythe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willsmythe/subscriptions","organizations_url":"https://api.github.com/users/willsmythe/orgs","repos_url":"https://api.github.com/users/willsmythe/repos","events_url":"https://api.github.com/users/willsmythe/events{/privacy}","received_events_url":"https://api.github.com/users/willsmythe/received_events","type":"User","site_admin":false},"body":"probably should trim each pathrule ... `.Select(s => s.Trim()).ToArray()`","created_at":"2019-07-17T20:14:23Z","updated_at":"2019-07-17T20:14:23Z","html_url":"https://github.com/microsoft/azure-pipelines-agent/pull/2340#discussion_r304621334","pull_request_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/2340","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/comments/304621334"},"html":{"href":"https://github.com/microsoft/azure-pipelines-agent/pull/2340#discussion_r304621334"},"pull_request":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/2340"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/2340","id":294991955,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0OTkxOTU1","html_url":"https://github.com/microsoft/azure-pipelines-agent/pull/2340","diff_url":"https://github.com/microsoft/azure-pipelines-agent/pull/2340.diff","patch_url":"https://github.com/microsoft/azure-pipelines-agent/pull/2340.patch","issue_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/issues/2340","number":2340,"state":"open","locked":false,"title":"Add fallback keys to caching","user":{"login":"johnterickson","id":10488772,"node_id":"MDQ6VXNlcjEwNDg4Nzcy","avatar_url":"https://avatars2.githubusercontent.com/u/10488772?v=4","gravatar_id":"","url":"https://api.github.com/users/johnterickson","html_url":"https://github.com/johnterickson","followers_url":"https://api.github.com/users/johnterickson/followers","following_url":"https://api.github.com/users/johnterickson/following{/other_user}","gists_url":"https://api.github.com/users/johnterickson/gists{/gist_id}","starred_url":"https://api.github.com/users/johnterickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnterickson/subscriptions","organizations_url":"https://api.github.com/users/johnterickson/orgs","repos_url":"https://api.github.com/users/johnterickson/repos","events_url":"https://api.github.com/users/johnterickson/events{/privacy}","received_events_url":"https://api.github.com/users/johnterickson/received_events","type":"User","site_admin":false},"body":"https://github.com/microsoft/azure-pipelines-tasks/issues/10842\r\nalso\r\nhttps://github.com/microsoft/azure-pipelines-tasks/issues/10859","created_at":"2019-07-05T22:13:45Z","updated_at":"2019-07-17T20:14:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e873b7da8dcaf5524b0bb89cfcd61e43631a07cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/2340/commits","review_comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/2340/comments","review_comment_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/issues/2340/comments","statuses_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/statuses/742643a976441200016856f69346c91a463793fa","head":{"label":"johnterickson:users/jerick/fallback","ref":"users/jerick/fallback","sha":"742643a976441200016856f69346c91a463793fa","user":{"login":"johnterickson","id":10488772,"node_id":"MDQ6VXNlcjEwNDg4Nzcy","avatar_url":"https://avatars2.githubusercontent.com/u/10488772?v=4","gravatar_id":"","url":"https://api.github.com/users/johnterickson","html_url":"https://github.com/johnterickson","followers_url":"https://api.github.com/users/johnterickson/followers","following_url":"https://api.github.com/users/johnterickson/following{/other_user}","gists_url":"https://api.github.com/users/johnterickson/gists{/gist_id}","starred_url":"https://api.github.com/users/johnterickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnterickson/subscriptions","organizations_url":"https://api.github.com/users/johnterickson/orgs","repos_url":"https://api.github.com/users/johnterickson/repos","events_url":"https://api.github.com/users/johnterickson/events{/privacy}","received_events_url":"https://api.github.com/users/johnterickson/received_events","type":"User","site_admin":false},"repo":{"id":190080957,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAwODA5NTc=","name":"azure-pipelines-agent","full_name":"johnterickson/azure-pipelines-agent","private":false,"owner":{"login":"johnterickson","id":10488772,"node_id":"MDQ6VXNlcjEwNDg4Nzcy","avatar_url":"https://avatars2.githubusercontent.com/u/10488772?v=4","gravatar_id":"","url":"https://api.github.com/users/johnterickson","html_url":"https://github.com/johnterickson","followers_url":"https://api.github.com/users/johnterickson/followers","following_url":"https://api.github.com/users/johnterickson/following{/other_user}","gists_url":"https://api.github.com/users/johnterickson/gists{/gist_id}","starred_url":"https://api.github.com/users/johnterickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnterickson/subscriptions","organizations_url":"https://api.github.com/users/johnterickson/orgs","repos_url":"https://api.github.com/users/johnterickson/repos","events_url":"https://api.github.com/users/johnterickson/events{/privacy}","received_events_url":"https://api.github.com/users/johnterickson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johnterickson/azure-pipelines-agent","description":"Azure Pipelines Agent","fork":true,"url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent","forks_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/forks","keys_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/teams","hooks_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/hooks","issue_events_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/issues/events{/number}","events_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/events","assignees_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/assignees{/user}","branches_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/branches{/branch}","tags_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/tags","blobs_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/languages","stargazers_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/stargazers","contributors_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/contributors","subscribers_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/subscribers","subscription_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/subscription","commits_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/contents/{+path}","compare_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/merges","archive_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/downloads","issues_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/issues{/number}","pulls_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/labels{/name}","releases_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/releases{/id}","deployments_url":"https://api.github.com/repos/johnterickson/azure-pipelines-agent/deployments","created_at":"2019-06-03T20:55:33Z","updated_at":"2019-06-03T20:55:37Z","pushed_at":"2019-07-17T18:30:33Z","git_url":"git://github.com/johnterickson/azure-pipelines-agent.git","ssh_url":"git@github.com:johnterickson/azure-pipelines-agent.git","clone_url":"https://github.com/johnterickson/azure-pipelines-agent.git","svn_url":"https://github.com/johnterickson/azure-pipelines-agent","homepage":"","size":7639,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"c78bd4a61c87ca2ad723611da449f3d460d79306","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":53052789,"node_id":"MDEwOlJlcG9zaXRvcnk1MzA1Mjc4OQ==","name":"azure-pipelines-agent","full_name":"microsoft/azure-pipelines-agent","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azure-pipelines-agent","description":"Azure Pipelines Agent","fork":false,"url":"https://api.github.com/repos/microsoft/azure-pipelines-agent","forks_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/forks","keys_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/teams","hooks_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/events","assignees_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/tags","blobs_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/languages","stargazers_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/subscription","commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/merges","archive_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/downloads","issues_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azure-pipelines-agent/deployments","created_at":"2016-03-03T13:36:48Z","updated_at":"2019-07-16T22:12:48Z","pushed_at":"2019-07-17T18:30:36Z","git_url":"git://github.com/microsoft/azure-pipelines-agent.git","ssh_url":"git@github.com:microsoft/azure-pipelines-agent.git","clone_url":"https://github.com/microsoft/azure-pipelines-agent.git","svn_url":"https://github.com/microsoft/azure-pipelines-agent","homepage":"","size":7588,"stargazers_count":730,"watchers_count":730,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":445,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":445,"open_issues":104,"watchers":730,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/2340"},"html":{"href":"https://github.com/microsoft/azure-pipelines-agent/pull/2340"},"issue":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-agent/issues/2340"},"comments":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-agent/issues/2340/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/2340/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-agent/pulls/2340/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-agent/statuses/742643a976441200016856f69346c91a463793fa"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 53052789,
"name": "microsoft/azure-pipelines-agent",
"url": "https://api.github.com/repos/microsoft/azure-pipelines-agent"
}
|
{
"id": 2503052,
"login": "willsmythe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2503052?",
"url": "https://api.github.com/users/willsmythe"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-07-17T20:14:23 |
10032232556
|
{"actor":{"display_login":"willsmythe"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/comments/255277687","pull_request_review_id":201839382,"id":255277687,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTI3NzY4Nw==","diff_hunk":"@@ -365,14 +365,23 @@ void NavigationView::OnApplyTemplate()\n if (SharedHelpers::IsThemeShadowAvailable())\n {\n #ifdef USE_INSIDER_SDK\n- if (auto splitView = m_rootSplitView.get())\n+ // Shadow will get clipped if casting on the splitView.Content directly\n+ // Creating a canvas with negative margins as receiver to allow shadow to be drawn outside the content grid \n+ winrt::Canvas shadowReceiver;\n+ winrt::Thickness shadowReceiverMargin = { -OpenPaneLength(), -c_paneElevationTranslationZ, -c_paneElevationTranslationZ, -c_paneElevationTranslationZ };\n+ shadowReceiver.Margin(shadowReceiverMargin);","path":"dev/NavigationView/NavigationView.cpp","position":9,"original_position":9,"commit_id":"69bc5be73d3474e125a02735ae907c0a8cc6f0cb","original_commit_id":"69bc5be73d3474e125a02735ae907c0a8cc6f0cb","user":{"login":"kaiguo","id":4424330,"node_id":"MDQ6VXNlcjQ0MjQzMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/4424330?v=4","gravatar_id":"","url":"https://api.github.com/users/kaiguo","html_url":"https://github.com/kaiguo","followers_url":"https://api.github.com/users/kaiguo/followers","following_url":"https://api.github.com/users/kaiguo/following{/other_user}","gists_url":"https://api.github.com/users/kaiguo/gists{/gist_id}","starred_url":"https://api.github.com/users/kaiguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaiguo/subscriptions","organizations_url":"https://api.github.com/users/kaiguo/orgs","repos_url":"https://api.github.com/users/kaiguo/repos","events_url":"https://api.github.com/users/kaiguo/events{/privacy}","received_events_url":"https://api.github.com/users/kaiguo/received_events","type":"User","site_admin":false},"body":"Asked Dmitriy and seems like it's not straight forward to get the actual values...","created_at":"2019-02-09T00:53:53Z","updated_at":"2019-02-09T00:53:54Z","html_url":"https://github.com/Microsoft/microsoft-ui-xaml/pull/286#discussion_r255277687","pull_request_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/286","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/comments/255277687"},"html":{"href":"https://github.com/Microsoft/microsoft-ui-xaml/pull/286#discussion_r255277687"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/286"}},"in_reply_to_id":255263765},"pull_request":{"url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/286","id":251595908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNTk1OTA4","html_url":"https://github.com/Microsoft/microsoft-ui-xaml/pull/286","diff_url":"https://github.com/Microsoft/microsoft-ui-xaml/pull/286.diff","patch_url":"https://github.com/Microsoft/microsoft-ui-xaml/pull/286.patch","issue_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues/286","number":286,"state":"open","locked":false,"title":"Fix NavigationViewPane shadow","user":{"login":"kaiguo","id":4424330,"node_id":"MDQ6VXNlcjQ0MjQzMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/4424330?v=4","gravatar_id":"","url":"https://api.github.com/users/kaiguo","html_url":"https://github.com/kaiguo","followers_url":"https://api.github.com/users/kaiguo/followers","following_url":"https://api.github.com/users/kaiguo/following{/other_user}","gists_url":"https://api.github.com/users/kaiguo/gists{/gist_id}","starred_url":"https://api.github.com/users/kaiguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaiguo/subscriptions","organizations_url":"https://api.github.com/users/kaiguo/orgs","repos_url":"https://api.github.com/users/kaiguo/repos","events_url":"https://api.github.com/users/kaiguo/events{/privacy}","received_events_url":"https://api.github.com/users/kaiguo/received_events","type":"User","site_admin":false},"body":"[Internal Issue](https://microsoft.visualstudio.com/OS/_workitems/edit/20386041)\r\n\r\nNavigationView was casting shadow on SplitView.Content, which makes the shadow gets clipped by the content grid.\r\n\r\nInserted a canvas with negative margin in content grid to let shadow be drawn out of the grid.","created_at":"2019-02-08T20:58:37Z","updated_at":"2019-02-09T00:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"778f8451dff9c7ca1abf125c733b3d20ee50676e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/286/commits","review_comments_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/286/comments","review_comment_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues/286/comments","statuses_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/statuses/69bc5be73d3474e125a02735ae907c0a8cc6f0cb","head":{"label":"Microsoft:user/kaiguo/fix-navigationviewpane-shadow","ref":"user/kaiguo/fix-navigationviewpane-shadow","sha":"69bc5be73d3474e125a02735ae907c0a8cc6f0cb","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":142480903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0ODA5MDM=","name":"microsoft-ui-xaml","full_name":"Microsoft/microsoft-ui-xaml","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/microsoft-ui-xaml","description":"Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications","fork":false,"url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml","forks_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/forks","keys_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/teams","hooks_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/events","assignees_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/tags","blobs_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/languages","stargazers_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/subscription","commits_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/merges","archive_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/downloads","issues_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/deployments","created_at":"2018-07-26T18:45:29Z","updated_at":"2019-02-08T19:50:48Z","pushed_at":"2019-02-08T23:41:30Z","git_url":"git://github.com/Microsoft/microsoft-ui-xaml.git","ssh_url":"git@github.com:Microsoft/microsoft-ui-xaml.git","clone_url":"https://github.com/Microsoft/microsoft-ui-xaml.git","svn_url":"https://github.com/Microsoft/microsoft-ui-xaml","homepage":"","size":50265,"stargazers_count":1075,"watchers_count":1075,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":77,"open_issues":113,"watchers":1075,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"49c3e7e0b52d939239d9a2e44d4d210c68380406","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":142480903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0ODA5MDM=","name":"microsoft-ui-xaml","full_name":"Microsoft/microsoft-ui-xaml","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/microsoft-ui-xaml","description":"Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications","fork":false,"url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml","forks_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/forks","keys_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/teams","hooks_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/events","assignees_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/tags","blobs_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/languages","stargazers_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/subscription","commits_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/merges","archive_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/downloads","issues_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/deployments","created_at":"2018-07-26T18:45:29Z","updated_at":"2019-02-08T19:50:48Z","pushed_at":"2019-02-08T23:41:30Z","git_url":"git://github.com/Microsoft/microsoft-ui-xaml.git","ssh_url":"git@github.com:Microsoft/microsoft-ui-xaml.git","clone_url":"https://github.com/Microsoft/microsoft-ui-xaml.git","svn_url":"https://github.com/Microsoft/microsoft-ui-xaml","homepage":"","size":50265,"stargazers_count":1075,"watchers_count":1075,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":77,"open_issues":113,"watchers":1075,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/286"},"html":{"href":"https://github.com/Microsoft/microsoft-ui-xaml/pull/286"},"issue":{"href":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues/286"},"comments":{"href":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/microsoft-ui-xaml/statuses/69bc5be73d3474e125a02735ae907c0a8cc6f0cb"}},"author_association":"MEMBER"}}
|
{
"id": 142480903,
"name": "Microsoft/microsoft-ui-xaml",
"url": "https://api.github.com/repos/Microsoft/microsoft-ui-xaml"
}
|
{
"id": 4424330,
"login": "kaiguo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4424330?",
"url": "https://api.github.com/users/kaiguo"
}
|
{
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
}
| 2019-02-09T00:53:53 |
9036528949
|
{"actor":{"display_login":"kaiguo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/vcpkg/pulls/comments/326757049","pull_request_review_id":291335354,"id":326757049,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjc1NzA0OQ==","diff_hunk":"@@ -0,0 +1,3 @@\n+Source: libsoundio\r\n+Version: 2.0.0\r\n+Description:\r","path":"ports/libsoundio/CONTROL","position":null,"original_position":3,"commit_id":"5efe5e5767c67a7cebd7af7e69d35f146a0c1be4","original_commit_id":"d5c6c944138c00b64b76ffd071d5ef249b8cf4dd","user":{"login":"UnaNancyOwen","id":816705,"node_id":"MDQ6VXNlcjgxNjcwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/816705?v=4","gravatar_id":"","url":"https://api.github.com/users/UnaNancyOwen","html_url":"https://github.com/UnaNancyOwen","followers_url":"https://api.github.com/users/UnaNancyOwen/followers","following_url":"https://api.github.com/users/UnaNancyOwen/following{/other_user}","gists_url":"https://api.github.com/users/UnaNancyOwen/gists{/gist_id}","starred_url":"https://api.github.com/users/UnaNancyOwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnaNancyOwen/subscriptions","organizations_url":"https://api.github.com/users/UnaNancyOwen/orgs","repos_url":"https://api.github.com/users/UnaNancyOwen/repos","events_url":"https://api.github.com/users/UnaNancyOwen/events{/privacy}","received_events_url":"https://api.github.com/users/UnaNancyOwen/received_events","type":"User","site_admin":false},"body":"Thanks, I was add them.","created_at":"2019-09-20T18:43:32Z","updated_at":"2019-09-20T18:43:32Z","html_url":"https://github.com/microsoft/vcpkg/pull/8273#discussion_r326757049","pull_request_url":"https://api.github.com/repos/microsoft/vcpkg/pulls/8273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/vcpkg/pulls/comments/326757049"},"html":{"href":"https://github.com/microsoft/vcpkg/pull/8273#discussion_r326757049"},"pull_request":{"href":"https://api.github.com/repos/microsoft/vcpkg/pulls/8273"}},"in_reply_to_id":326754071},"pull_request":{"url":"https://api.github.com/repos/microsoft/vcpkg/pulls/8273","id":319794707,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5Nzk0NzA3","html_url":"https://github.com/microsoft/vcpkg/pull/8273","diff_url":"https://github.com/microsoft/vcpkg/pull/8273.diff","patch_url":"https://github.com/microsoft/vcpkg/pull/8273.patch","issue_url":"https://api.github.com/repos/microsoft/vcpkg/issues/8273","number":8273,"state":"open","locked":false,"title":"[libsoundio] Add libsoundio port","user":{"login":"UnaNancyOwen","id":816705,"node_id":"MDQ6VXNlcjgxNjcwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/816705?v=4","gravatar_id":"","url":"https://api.github.com/users/UnaNancyOwen","html_url":"https://github.com/UnaNancyOwen","followers_url":"https://api.github.com/users/UnaNancyOwen/followers","following_url":"https://api.github.com/users/UnaNancyOwen/following{/other_user}","gists_url":"https://api.github.com/users/UnaNancyOwen/gists{/gist_id}","starred_url":"https://api.github.com/users/UnaNancyOwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnaNancyOwen/subscriptions","organizations_url":"https://api.github.com/users/UnaNancyOwen/orgs","repos_url":"https://api.github.com/users/UnaNancyOwen/repos","events_url":"https://api.github.com/users/UnaNancyOwen/events{/privacy}","received_events_url":"https://api.github.com/users/UnaNancyOwen/received_events","type":"User","site_admin":false},"body":"This pull request will add [libsoundio](https://github.com/andrewrk/libsoundio).","created_at":"2019-09-20T16:26:11Z","updated_at":"2019-09-20T18:43:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61e09f60bbf850819ef00997c28a82c11f9452a2","assignee":{"login":"vicroms","id":3526662,"node_id":"MDQ6VXNlcjM1MjY2NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3526662?v=4","gravatar_id":"","url":"https://api.github.com/users/vicroms","html_url":"https://github.com/vicroms","followers_url":"https://api.github.com/users/vicroms/followers","following_url":"https://api.github.com/users/vicroms/following{/other_user}","gists_url":"https://api.github.com/users/vicroms/gists{/gist_id}","starred_url":"https://api.github.com/users/vicroms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicroms/subscriptions","organizations_url":"https://api.github.com/users/vicroms/orgs","repos_url":"https://api.github.com/users/vicroms/repos","events_url":"https://api.github.com/users/vicroms/events{/privacy}","received_events_url":"https://api.github.com/users/vicroms/received_events","type":"User","site_admin":false},"assignees":[{"login":"vicroms","id":3526662,"node_id":"MDQ6VXNlcjM1MjY2NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3526662?v=4","gravatar_id":"","url":"https://api.github.com/users/vicroms","html_url":"https://github.com/vicroms","followers_url":"https://api.github.com/users/vicroms/followers","following_url":"https://api.github.com/users/vicroms/following{/other_user}","gists_url":"https://api.github.com/users/vicroms/gists{/gist_id}","starred_url":"https://api.github.com/users/vicroms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicroms/subscriptions","organizations_url":"https://api.github.com/users/vicroms/orgs","repos_url":"https://api.github.com/users/vicroms/repos","events_url":"https://api.github.com/users/vicroms/events{/privacy}","received_events_url":"https://api.github.com/users/vicroms/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/vcpkg/pulls/8273/commits","review_comments_url":"https://api.github.com/repos/microsoft/vcpkg/pulls/8273/comments","review_comment_url":"https://api.github.com/repos/microsoft/vcpkg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/vcpkg/issues/8273/comments","statuses_url":"https://api.github.com/repos/microsoft/vcpkg/statuses/5efe5e5767c67a7cebd7af7e69d35f146a0c1be4","head":{"label":"UnaNancyOwen:add_libsoundio","ref":"add_libsoundio","sha":"5efe5e5767c67a7cebd7af7e69d35f146a0c1be4","user":{"login":"UnaNancyOwen","id":816705,"node_id":"MDQ6VXNlcjgxNjcwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/816705?v=4","gravatar_id":"","url":"https://api.github.com/users/UnaNancyOwen","html_url":"https://github.com/UnaNancyOwen","followers_url":"https://api.github.com/users/UnaNancyOwen/followers","following_url":"https://api.github.com/users/UnaNancyOwen/following{/other_user}","gists_url":"https://api.github.com/users/UnaNancyOwen/gists{/gist_id}","starred_url":"https://api.github.com/users/UnaNancyOwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnaNancyOwen/subscriptions","organizations_url":"https://api.github.com/users/UnaNancyOwen/orgs","repos_url":"https://api.github.com/users/UnaNancyOwen/repos","events_url":"https://api.github.com/users/UnaNancyOwen/events{/privacy}","received_events_url":"https://api.github.com/users/UnaNancyOwen/received_events","type":"User","site_admin":false},"repo":{"id":154327517,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzMjc1MTc=","name":"vcpkg","full_name":"UnaNancyOwen/vcpkg","private":false,"owner":{"login":"UnaNancyOwen","id":816705,"node_id":"MDQ6VXNlcjgxNjcwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/816705?v=4","gravatar_id":"","url":"https://api.github.com/users/UnaNancyOwen","html_url":"https://github.com/UnaNancyOwen","followers_url":"https://api.github.com/users/UnaNancyOwen/followers","following_url":"https://api.github.com/users/UnaNancyOwen/following{/other_user}","gists_url":"https://api.github.com/users/UnaNancyOwen/gists{/gist_id}","starred_url":"https://api.github.com/users/UnaNancyOwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnaNancyOwen/subscriptions","organizations_url":"https://api.github.com/users/UnaNancyOwen/orgs","repos_url":"https://api.github.com/users/UnaNancyOwen/repos","events_url":"https://api.github.com/users/UnaNancyOwen/events{/privacy}","received_events_url":"https://api.github.com/users/UnaNancyOwen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/UnaNancyOwen/vcpkg","description":"C++ Library Manager for Windows, Linux, and MacOS","fork":true,"url":"https://api.github.com/repos/UnaNancyOwen/vcpkg","forks_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/forks","keys_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/teams","hooks_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/hooks","issue_events_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/issues/events{/number}","events_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/events","assignees_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/assignees{/user}","branches_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/branches{/branch}","tags_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/tags","blobs_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/statuses/{sha}","languages_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/languages","stargazers_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/stargazers","contributors_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/contributors","subscribers_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/subscribers","subscription_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/subscription","commits_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/contents/{+path}","compare_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/merges","archive_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/downloads","issues_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/issues{/number}","pulls_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/pulls{/number}","milestones_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/milestones{/number}","notifications_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/labels{/name}","releases_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/releases{/id}","deployments_url":"https://api.github.com/repos/UnaNancyOwen/vcpkg/deployments","created_at":"2018-10-23T12:52:25Z","updated_at":"2019-09-20T16:22:03Z","pushed_at":"2019-09-20T18:42:27Z","git_url":"git://github.com/UnaNancyOwen/vcpkg.git","ssh_url":"git@github.com:UnaNancyOwen/vcpkg.git","clone_url":"https://github.com/UnaNancyOwen/vcpkg.git","svn_url":"https://github.com/UnaNancyOwen/vcpkg","homepage":"","size":17800,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"358ec0954d9b71b0def4fd4b4dbafdd0b8478d81","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":68312233,"node_id":"MDEwOlJlcG9zaXRvcnk2ODMxMjIzMw==","name":"vcpkg","full_name":"microsoft/vcpkg","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/vcpkg","description":"C++ Library Manager for Windows, Linux, and MacOS","fork":false,"url":"https://api.github.com/repos/microsoft/vcpkg","forks_url":"https://api.github.com/repos/microsoft/vcpkg/forks","keys_url":"https://api.github.com/repos/microsoft/vcpkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/vcpkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/vcpkg/teams","hooks_url":"https://api.github.com/repos/microsoft/vcpkg/hooks","issue_events_url":"https://api.github.com/repos/microsoft/vcpkg/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/vcpkg/events","assignees_url":"https://api.github.com/repos/microsoft/vcpkg/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/vcpkg/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/vcpkg/tags","blobs_url":"https://api.github.com/repos/microsoft/vcpkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/vcpkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/vcpkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/vcpkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/vcpkg/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/vcpkg/languages","stargazers_url":"https://api.github.com/repos/microsoft/vcpkg/stargazers","contributors_url":"https://api.github.com/repos/microsoft/vcpkg/contributors","subscribers_url":"https://api.github.com/repos/microsoft/vcpkg/subscribers","subscription_url":"https://api.github.com/repos/microsoft/vcpkg/subscription","commits_url":"https://api.github.com/repos/microsoft/vcpkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/vcpkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/vcpkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/vcpkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/vcpkg/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/vcpkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/vcpkg/merges","archive_url":"https://api.github.com/repos/microsoft/vcpkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/vcpkg/downloads","issues_url":"https://api.github.com/repos/microsoft/vcpkg/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/vcpkg/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/vcpkg/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/vcpkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/vcpkg/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/vcpkg/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/vcpkg/deployments","created_at":"2016-09-15T16:40:50Z","updated_at":"2019-09-20T18:29:14Z","pushed_at":"2019-09-20T18:42:29Z","git_url":"git://github.com/microsoft/vcpkg.git","ssh_url":"git@github.com:microsoft/vcpkg.git","clone_url":"https://github.com/microsoft/vcpkg.git","svn_url":"https://github.com/microsoft/vcpkg","homepage":"","size":17597,"stargazers_count":6665,"watchers_count":6665,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1677,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1129,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1677,"open_issues":1129,"watchers":6665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/vcpkg/pulls/8273"},"html":{"href":"https://github.com/microsoft/vcpkg/pull/8273"},"issue":{"href":"https://api.github.com/repos/microsoft/vcpkg/issues/8273"},"comments":{"href":"https://api.github.com/repos/microsoft/vcpkg/issues/8273/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/vcpkg/pulls/8273/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/vcpkg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/vcpkg/pulls/8273/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/vcpkg/statuses/5efe5e5767c67a7cebd7af7e69d35f146a0c1be4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 68312233,
"name": "microsoft/vcpkg",
"url": "https://api.github.com/repos/microsoft/vcpkg"
}
|
{
"id": 816705,
"login": "UnaNancyOwen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/816705?",
"url": "https://api.github.com/users/UnaNancyOwen"
}
|
{
"id": 6154722,
"login": "microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/microsoft"
}
| 2019-09-20T18:43:32 |
10462721371
|
{"actor":{"display_login":"UnaNancyOwen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/opendatakit/javarosa/pulls/comments/301873111","pull_request_review_id":247354018,"id":301873111,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTg3MzExMQ==","diff_hunk":"@@ -55,10 +63,83 @@ public TreeElement parse() throws InvalidStructureException, IOException,\n break;\n default:\n throw new InvalidStructureException(\n- \"Exception while trying to parse an XML Tree, got something other than tags and text\", parser);\n+ \"Exception while trying to parse an XML Tree, got something other than tags and text\", parser);\n }\n }\n \n return element;\n }\n+\n+ /**\n+ * Returns the internal secondary instance with the instance ID created\n+ * Used for deserializing\n+ * @return The TreeElement node of the internal instance\n+ * @throws IOException\n+ * @throws InvalidReferenceException\n+ * @throws InvalidStructureException\n+ * @throws XmlPullParserException\n+ * @throws UnfullfilledRequirementsException\n+ */\n+ public TreeElement parseInternalSecondaryInstance() throws IOException, InvalidReferenceException, InvalidStructureException, XmlPullParserException, UnfullfilledRequirementsException {","path":"src/main/java/org/javarosa/xml/TreeElementParser.java","position":62,"original_position":62,"commit_id":"e51af7b5b96d4e821c5f53fcc37d0cff569e339f","original_commit_id":"e51af7b5b96d4e821c5f53fcc37d0cff569e339f","user":{"login":"lognaturel","id":967540,"node_id":"MDQ6VXNlcjk2NzU0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/967540?v=4","gravatar_id":"","url":"https://api.github.com/users/lognaturel","html_url":"https://github.com/lognaturel","followers_url":"https://api.github.com/users/lognaturel/followers","following_url":"https://api.github.com/users/lognaturel/following{/other_user}","gists_url":"https://api.github.com/users/lognaturel/gists{/gist_id}","starred_url":"https://api.github.com/users/lognaturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lognaturel/subscriptions","organizations_url":"https://api.github.com/users/lognaturel/orgs","repos_url":"https://api.github.com/users/lognaturel/repos","events_url":"https://api.github.com/users/lognaturel/events{/privacy}","received_events_url":"https://api.github.com/users/lognaturel/received_events","type":"User","site_admin":false},"body":"This is no longer used, right?","created_at":"2019-07-10T03:26:54Z","updated_at":"2019-07-10T03:55:46Z","html_url":"https://github.com/opendatakit/javarosa/pull/445#discussion_r301873111","pull_request_url":"https://api.github.com/repos/opendatakit/javarosa/pulls/445","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/comments/301873111"},"html":{"href":"https://github.com/opendatakit/javarosa/pull/445#discussion_r301873111"},"pull_request":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/opendatakit/javarosa/pulls/445","id":286342180,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2MzQyMTgw","html_url":"https://github.com/opendatakit/javarosa/pull/445","diff_url":"https://github.com/opendatakit/javarosa/pull/445.diff","patch_url":"https://github.com/opendatakit/javarosa/pull/445.patch","issue_url":"https://api.github.com/repos/opendatakit/javarosa/issues/445","number":445,"state":"open","locked":false,"title":"File and data instance parsing improvement","user":{"login":"JohnTheBeloved","id":7778212,"node_id":"MDQ6VXNlcjc3NzgyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7778212?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnTheBeloved","html_url":"https://github.com/JohnTheBeloved","followers_url":"https://api.github.com/users/JohnTheBeloved/followers","following_url":"https://api.github.com/users/JohnTheBeloved/following{/other_user}","gists_url":"https://api.github.com/users/JohnTheBeloved/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnTheBeloved/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnTheBeloved/subscriptions","organizations_url":"https://api.github.com/users/JohnTheBeloved/orgs","repos_url":"https://api.github.com/users/JohnTheBeloved/repos","events_url":"https://api.github.com/users/JohnTheBeloved/events{/privacy}","received_events_url":"https://api.github.com/users/JohnTheBeloved/received_events","type":"User","site_admin":false},"body":"Closes #\r\nIssue with large time difference between loading forms with only Internal secondary instances(ISIs) and forms with External secondary instances(ESIs), ISI forms are significantly slower [(~5times slower)](https://docs.google.com/spreadsheets/d/1N2QjEoClxJEf-xZX9CvjzK-UYOggq83ZvReIxgsrocM/edit?disco=AAAADHf6lHw)\r\n\r\nI have created three different approaches to solve this issue, in order to compare speeds. The approach in this PR is “Approach 2”. “Approach 3\" and “Approach 4” are described below\r\n\r\nCompare profiling for [master branch](https://docs.google.com/spreadsheets/d/1N2QjEoClxJEf-xZX9CvjzK-UYOggq83ZvReIxgsrocM/edit#gid=0) and [this branch(`approach-2`)](https://docs.google.com/spreadsheets/d/1N2QjEoClxJEf-xZX9CvjzK-UYOggq83ZvReIxgsrocM/edit#gid=1200603691)\r\n\r\n### Major updates \r\n**Approach 2**\r\n- Serialising xform file path instead of whole TreeElement (due to the fact that ESI forms load faster than ISI forms) so that at each subsequent loading of the Formdef from the cache, the ISIs are parsed from the XForm. This is because re-parsing the XML file(containing the ISI) is faster than caching the TreeElement and deserialising it which may be due to IO performance on android.\r\n\r\n\r\n#### What has been done to verify that this works as intended?\r\n\r\n- Profiled on Android studio and Tested on Android device\r\n- Unit tests and Benchmarks created for methods\r\n\r\n#### Why is this the best possible solution? Were any other approaches considered?\r\n\r\nTwo other approaches apart from this were tried and results of the manual timing of the form load can be found [here](https://docs.google.com/spreadsheets/d/1N2QjEoClxJEf-xZX9CvjzK-UYOggq83ZvReIxgsrocM/edit#gid=876410270)\r\n \r\n**Approach 3**\r\n - Serialising the ISI strings to the FormDef cache i.e. rather than the xform path(approach-2), or the TreeElement(master branch).\r\nIn this case, the whole String is serialised as bytes to the FormDef cache\r\n\r\n**Approach 4**\r\n- Storing the ISI strings to separate files and then serializing the paths to each file in the FormDef cache so they can be re-parsed on subsequent Form loads for each ISI\r\n\r\n#### How does this change affect users? \r\n\r\n1. Forms with many small ISIs are now on average 2x faster on first load and 2X faster on subsequent loads (10 secondary instances, each containing 50 elements)\r\n\r\n2. Forms with many larger ISIs are now on average 4x faster on first load and 3X faster on subsequent loads (10 secondary instance, each containing 500 elements)\r\n\r\n3. Forms with very large ISIs are now on average 12x faster on first load and 15X faster on subsequent loads (1 secondary instance containing 50,000 elements)\r\n\r\nThese results are based on profiling tests with three different Android devices.\r\n\r\nSee more detailed result [here](https://docs.google.com/spreadsheets/d/1N2QjEoClxJEf-xZX9CvjzK-UYOggq83ZvReIxgsrocM/edit#gid=1200603691) \r\n\r\n#### Describe intentional changes to behaviour and behaviour that could have accidentally been affected by code changes. In other words, what are the regression risks?\r\n\r\nNo user facing behaviour was changed apart from faster form loading,\r\n\r\nAfter application update, Loading a cached form might break Form loading due to a different structure of the FormDef cache in this PR update (Xform Path are serialized instead of the TreeElement).\r\n\r\nIt might be necessary to come up with a way of deleting older form caches after this update is installed.","created_at":"2019-06-07T21:42:48Z","updated_at":"2019-07-10T03:55:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d10badeb14635a2e53f05767d7166d11b8f1f778","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opendatakit/javarosa/pulls/445/commits","review_comments_url":"https://api.github.com/repos/opendatakit/javarosa/pulls/445/comments","review_comment_url":"https://api.github.com/repos/opendatakit/javarosa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opendatakit/javarosa/issues/445/comments","statuses_url":"https://api.github.com/repos/opendatakit/javarosa/statuses/e51af7b5b96d4e821c5f53fcc37d0cff569e339f","head":{"label":"eHealthAfrica:parsing_improvement","ref":"parsing_improvement","sha":"e51af7b5b96d4e821c5f53fcc37d0cff569e339f","user":{"login":"eHealthAfrica","id":3214042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTQwNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3214042?v=4","gravatar_id":"","url":"https://api.github.com/users/eHealthAfrica","html_url":"https://github.com/eHealthAfrica","followers_url":"https://api.github.com/users/eHealthAfrica/followers","following_url":"https://api.github.com/users/eHealthAfrica/following{/other_user}","gists_url":"https://api.github.com/users/eHealthAfrica/gists{/gist_id}","starred_url":"https://api.github.com/users/eHealthAfrica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eHealthAfrica/subscriptions","organizations_url":"https://api.github.com/users/eHealthAfrica/orgs","repos_url":"https://api.github.com/users/eHealthAfrica/repos","events_url":"https://api.github.com/users/eHealthAfrica/events{/privacy}","received_events_url":"https://api.github.com/users/eHealthAfrica/received_events","type":"Organization","site_admin":false},"repo":{"id":180322055,"node_id":"MDEwOlJlcG9zaXRvcnkxODAzMjIwNTU=","name":"javarosa","full_name":"eHealthAfrica/javarosa","private":false,"owner":{"login":"eHealthAfrica","id":3214042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTQwNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3214042?v=4","gravatar_id":"","url":"https://api.github.com/users/eHealthAfrica","html_url":"https://github.com/eHealthAfrica","followers_url":"https://api.github.com/users/eHealthAfrica/followers","following_url":"https://api.github.com/users/eHealthAfrica/following{/other_user}","gists_url":"https://api.github.com/users/eHealthAfrica/gists{/gist_id}","starred_url":"https://api.github.com/users/eHealthAfrica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eHealthAfrica/subscriptions","organizations_url":"https://api.github.com/users/eHealthAfrica/orgs","repos_url":"https://api.github.com/users/eHealthAfrica/repos","events_url":"https://api.github.com/users/eHealthAfrica/events{/privacy}","received_events_url":"https://api.github.com/users/eHealthAfrica/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eHealthAfrica/javarosa","description":"The core library that many of the ODK tools are built around. It's written in Java, implements the ODK XForms spec, and runs on mobile devices and cloud servers. ✨🏗✨","fork":true,"url":"https://api.github.com/repos/eHealthAfrica/javarosa","forks_url":"https://api.github.com/repos/eHealthAfrica/javarosa/forks","keys_url":"https://api.github.com/repos/eHealthAfrica/javarosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eHealthAfrica/javarosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eHealthAfrica/javarosa/teams","hooks_url":"https://api.github.com/repos/eHealthAfrica/javarosa/hooks","issue_events_url":"https://api.github.com/repos/eHealthAfrica/javarosa/issues/events{/number}","events_url":"https://api.github.com/repos/eHealthAfrica/javarosa/events","assignees_url":"https://api.github.com/repos/eHealthAfrica/javarosa/assignees{/user}","branches_url":"https://api.github.com/repos/eHealthAfrica/javarosa/branches{/branch}","tags_url":"https://api.github.com/repos/eHealthAfrica/javarosa/tags","blobs_url":"https://api.github.com/repos/eHealthAfrica/javarosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eHealthAfrica/javarosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eHealthAfrica/javarosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/eHealthAfrica/javarosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eHealthAfrica/javarosa/statuses/{sha}","languages_url":"https://api.github.com/repos/eHealthAfrica/javarosa/languages","stargazers_url":"https://api.github.com/repos/eHealthAfrica/javarosa/stargazers","contributors_url":"https://api.github.com/repos/eHealthAfrica/javarosa/contributors","subscribers_url":"https://api.github.com/repos/eHealthAfrica/javarosa/subscribers","subscription_url":"https://api.github.com/repos/eHealthAfrica/javarosa/subscription","commits_url":"https://api.github.com/repos/eHealthAfrica/javarosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/eHealthAfrica/javarosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/eHealthAfrica/javarosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/eHealthAfrica/javarosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/eHealthAfrica/javarosa/contents/{+path}","compare_url":"https://api.github.com/repos/eHealthAfrica/javarosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eHealthAfrica/javarosa/merges","archive_url":"https://api.github.com/repos/eHealthAfrica/javarosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eHealthAfrica/javarosa/downloads","issues_url":"https://api.github.com/repos/eHealthAfrica/javarosa/issues{/number}","pulls_url":"https://api.github.com/repos/eHealthAfrica/javarosa/pulls{/number}","milestones_url":"https://api.github.com/repos/eHealthAfrica/javarosa/milestones{/number}","notifications_url":"https://api.github.com/repos/eHealthAfrica/javarosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eHealthAfrica/javarosa/labels{/name}","releases_url":"https://api.github.com/repos/eHealthAfrica/javarosa/releases{/id}","deployments_url":"https://api.github.com/repos/eHealthAfrica/javarosa/deployments","created_at":"2019-04-09T08:35:28Z","updated_at":"2019-06-07T12:09:45Z","pushed_at":"2019-07-09T23:47:23Z","git_url":"git://github.com/eHealthAfrica/javarosa.git","ssh_url":"git@github.com:eHealthAfrica/javarosa.git","clone_url":"https://github.com/eHealthAfrica/javarosa.git","svn_url":"https://github.com/eHealthAfrica/javarosa","homepage":"","size":13702,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"opendatakit:master","ref":"master","sha":"196cd1808e8f983c5642a8f7617fc1b5812cef1f","user":{"login":"opendatakit","id":6222985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjI5ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"repo":{"id":66836598,"node_id":"MDEwOlJlcG9zaXRvcnk2NjgzNjU5OA==","name":"javarosa","full_name":"opendatakit/javarosa","private":false,"owner":{"login":"opendatakit","id":6222985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjI5ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opendatakit/javarosa","description":"The core library that many of the ODK tools are built around. It's written in Java, implements the ODK XForms spec, and runs on mobile devices and cloud servers. ✨🏗✨","fork":false,"url":"https://api.github.com/repos/opendatakit/javarosa","forks_url":"https://api.github.com/repos/opendatakit/javarosa/forks","keys_url":"https://api.github.com/repos/opendatakit/javarosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opendatakit/javarosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opendatakit/javarosa/teams","hooks_url":"https://api.github.com/repos/opendatakit/javarosa/hooks","issue_events_url":"https://api.github.com/repos/opendatakit/javarosa/issues/events{/number}","events_url":"https://api.github.com/repos/opendatakit/javarosa/events","assignees_url":"https://api.github.com/repos/opendatakit/javarosa/assignees{/user}","branches_url":"https://api.github.com/repos/opendatakit/javarosa/branches{/branch}","tags_url":"https://api.github.com/repos/opendatakit/javarosa/tags","blobs_url":"https://api.github.com/repos/opendatakit/javarosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opendatakit/javarosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opendatakit/javarosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/opendatakit/javarosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opendatakit/javarosa/statuses/{sha}","languages_url":"https://api.github.com/repos/opendatakit/javarosa/languages","stargazers_url":"https://api.github.com/repos/opendatakit/javarosa/stargazers","contributors_url":"https://api.github.com/repos/opendatakit/javarosa/contributors","subscribers_url":"https://api.github.com/repos/opendatakit/javarosa/subscribers","subscription_url":"https://api.github.com/repos/opendatakit/javarosa/subscription","commits_url":"https://api.github.com/repos/opendatakit/javarosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/opendatakit/javarosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/opendatakit/javarosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/opendatakit/javarosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/opendatakit/javarosa/contents/{+path}","compare_url":"https://api.github.com/repos/opendatakit/javarosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opendatakit/javarosa/merges","archive_url":"https://api.github.com/repos/opendatakit/javarosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opendatakit/javarosa/downloads","issues_url":"https://api.github.com/repos/opendatakit/javarosa/issues{/number}","pulls_url":"https://api.github.com/repos/opendatakit/javarosa/pulls{/number}","milestones_url":"https://api.github.com/repos/opendatakit/javarosa/milestones{/number}","notifications_url":"https://api.github.com/repos/opendatakit/javarosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opendatakit/javarosa/labels{/name}","releases_url":"https://api.github.com/repos/opendatakit/javarosa/releases{/id}","deployments_url":"https://api.github.com/repos/opendatakit/javarosa/deployments","created_at":"2016-08-29T11:08:59Z","updated_at":"2019-07-09T06:26:23Z","pushed_at":"2019-07-09T23:47:25Z","git_url":"git://github.com/opendatakit/javarosa.git","ssh_url":"git@github.com:opendatakit/javarosa.git","clone_url":"https://github.com/opendatakit/javarosa.git","svn_url":"https://github.com/opendatakit/javarosa","homepage":"","size":11380,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":63,"open_issues":92,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/445"},"html":{"href":"https://github.com/opendatakit/javarosa/pull/445"},"issue":{"href":"https://api.github.com/repos/opendatakit/javarosa/issues/445"},"comments":{"href":"https://api.github.com/repos/opendatakit/javarosa/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opendatakit/javarosa/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/opendatakit/javarosa/statuses/e51af7b5b96d4e821c5f53fcc37d0cff569e339f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 66836598,
"name": "opendatakit/javarosa",
"url": "https://api.github.com/repos/opendatakit/javarosa"
}
|
{
"id": 967540,
"login": "lognaturel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/967540?",
"url": "https://api.github.com/users/lognaturel"
}
|
{
"id": 6222985,
"login": "opendatakit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6222985?",
"url": "https://api.github.com/orgs/opendatakit"
}
| 2019-07-10T03:26:54 |
9980520956
|
{"actor":{"display_login":"lognaturel"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ndoit/fenrir/pulls/comments/268741692","pull_request_review_id":218452020,"id":268741692,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODc0MTY5Mg==","diff_hunk":"@@ -0,0 +1,92 @@\n+/ =================================================\n+/ HEADER\n+/ =================================================\n+-# Define Header Links:\n+- @breadcrumbs = [[\"\", \"/admin\", \"pli-home\", false],[\"Table List\", \"\", \"\", true]]\n+= render partial: 'shared/admin/header',\n+ locals: { item_type: \"database\", collection: nil, name: \"ETL Tables\", icon: \"pli-data-cloud\"}, \n+ layout: false \n+/ =================================================\n+\n+\n+.modal#import-metadata-modal{ role: 'dialog' }\n+ .modal-dialog.import-metadata-dialog{ role: 'document' }\n+ .modal-content{ style: 'padding: 5px;' }\n+ .modal-header\n+ %h4.modal-title Import Metadata\n+ %button.close.modal-x-button{ type: 'button', 'data-dismiss' => 'modal', 'aria-label' => 'close' }\n+ ×\n+ .modal-body\n+ Select a table metadata file to import:\n+ %input#table-metadata-import-file{ type: 'file' }\n+ .modal-footer\n+ %button.btn.btn-secondary#cancel-import-button{ type: 'button', 'data-dismiss' => 'modal', 'aria-label' => 'cancel' } Cancel\n+ %button.btn.btn-mint#table-metadata-import-button{ type: 'button', 'data-dismiss' => 'modal', 'aria-label' => 'cancel' } Import\n+\n+.row\n+ .col-lg-10.col-lg-offset-1\n+ .panel.panel-body \n+ .table-responsive\n+ %table#foo-filtering.footable.table.table-striped.table-vcenter{\"data-page-size\" => \"40\"}\n+ %thead.mar-top\n+ %tr\n+ %th{\"data-sort-ignore\" => \"true\"}\n+ -# %input#selectAll{type: \"checkbox\"}\n+ -# This will add a \"select all\" checkbox...but I dont think we need it....\n+ %th{\"data-toggle\" => \"true\"} Name\n+ %th DB Type\n+ %th SOC Type \n+ %th Map To UND\n+ %th Modified Date\n+ %th Modified User\n+ -# %th \n+ .form-inline\n+ .row.mar-top\n+ .col-md-6\n+ %input#foo-search.mar-lft.form-control.clearable{style:'width:100%',autocomplete: 'off', placeholder: 'Search', type: 'text'}\n+ %span.form-control-clear.form-control-feedback.glyphicon.glyphicon-remove.hidden\n+ .col-md-3.mar-btm.text-center\n+ %a.btn.btn-default#export-btn\n+ Export...\n+ %a.btn.btn-default#import-btn{ 'data-toggle' => 'modal', 'data-target' => '#import-metadata-modal' } ","path":"app/views/admin/a_etl_tables/index.html.haml","position":51,"original_position":51,"commit_id":"1b19e88f0fbe5c1741e3fee04da399c4867f998b","original_commit_id":"1b19e88f0fbe5c1741e3fee04da399c4867f998b","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line contains trailing whitespace","created_at":"2019-03-25T16:44:43Z","updated_at":"2019-03-25T16:44:45Z","html_url":"https://github.com/ndoit/fenrir/pull/941#discussion_r268741692","pull_request_url":"https://api.github.com/repos/ndoit/fenrir/pulls/941","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/comments/268741692"},"html":{"href":"https://github.com/ndoit/fenrir/pull/941#discussion_r268741692"},"pull_request":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/941"}}},"pull_request":{"url":"https://api.github.com/repos/ndoit/fenrir/pulls/941","id":254406600,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NDA2NjAw","html_url":"https://github.com/ndoit/fenrir/pull/941","diff_url":"https://github.com/ndoit/fenrir/pull/941.diff","patch_url":"https://github.com/ndoit/fenrir/pull/941.patch","issue_url":"https://api.github.com/repos/ndoit/fenrir/issues/941","number":941,"state":"open","locked":false,"title":"v4.2.0","user":{"login":"EvanGranthamBrown","id":4096134,"node_id":"MDQ6VXNlcjQwOTYxMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4096134?v=4","gravatar_id":"","url":"https://api.github.com/users/EvanGranthamBrown","html_url":"https://github.com/EvanGranthamBrown","followers_url":"https://api.github.com/users/EvanGranthamBrown/followers","following_url":"https://api.github.com/users/EvanGranthamBrown/following{/other_user}","gists_url":"https://api.github.com/users/EvanGranthamBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanGranthamBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanGranthamBrown/subscriptions","organizations_url":"https://api.github.com/users/EvanGranthamBrown/orgs","repos_url":"https://api.github.com/users/EvanGranthamBrown/repos","events_url":"https://api.github.com/users/EvanGranthamBrown/events{/privacy}","received_events_url":"https://api.github.com/users/EvanGranthamBrown/received_events","type":"User","site_admin":false},"body":"- Added \"serialize reports\" and \"serialize terms\" jobs\r\n- Sync jobs now have delete capability\r\n- User/position and position syncs use that delete capability\r\n- Sync jobs no longer mention changes they do not intend to make\r\n- When table preview gets 0 rows, it now provides a message indicating that the table has no unrestricted data (which is true; presumably in most cases there _is_ some restricted data, though we have no way to be sure)\r\n- New database diagram displays the entire DB\r\n- New UI for managing Iron Man settings and relationships\r\n- Add working_title to user/position relationship\r\n- Governance flow page: Informational page describes the governance process\r\n- Export/import graph DB between environments\r\n- Export/import term-column mappings\r\n- Fixed a bug in the admin editor for column joins which prevents creating a join\r\n\r\nSTILL TO DO\r\n- Table preview: Use the new security metadata to distinguish between 0 rows and 0 unrestricted rows\r\n- Clean up all pre-Snowflake table/column nodes\r\n- Delete FundOrg and OrgHIerarchy nodes\r\n- Add manager relationships to user/position nodes NDHRPYADMIN.something\r\n\r\n\r\nCHANGES TO TALEND/CREATE TABLE JOBS\r\n- Automatically link newly created table nodes to the DW database node\r\n- Automatically apply UUIDs to new table nodes\r\n\r\n","created_at":"2019-02-19T20:59:20Z","updated_at":"2019-03-25T16:44:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf791cb4d3dfd5e8b2f9ec7d278288bd921bd489","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ndoit/fenrir/pulls/941/commits","review_comments_url":"https://api.github.com/repos/ndoit/fenrir/pulls/941/comments","review_comment_url":"https://api.github.com/repos/ndoit/fenrir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndoit/fenrir/issues/941/comments","statuses_url":"https://api.github.com/repos/ndoit/fenrir/statuses/1b19e88f0fbe5c1741e3fee04da399c4867f998b","head":{"label":"ndoit:ui-admin-changes","ref":"ui-admin-changes","sha":"1b19e88f0fbe5c1741e3fee04da399c4867f998b","user":{"login":"ndoit","id":6223716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjM3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6223716?v=4","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"repo":{"id":39837938,"node_id":"MDEwOlJlcG9zaXRvcnkzOTgzNzkzOA==","name":"fenrir","full_name":"ndoit/fenrir","private":false,"owner":{"login":"ndoit","id":6223716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjM3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6223716?v=4","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ndoit/fenrir","description":"BI Portal","fork":false,"url":"https://api.github.com/repos/ndoit/fenrir","forks_url":"https://api.github.com/repos/ndoit/fenrir/forks","keys_url":"https://api.github.com/repos/ndoit/fenrir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndoit/fenrir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndoit/fenrir/teams","hooks_url":"https://api.github.com/repos/ndoit/fenrir/hooks","issue_events_url":"https://api.github.com/repos/ndoit/fenrir/issues/events{/number}","events_url":"https://api.github.com/repos/ndoit/fenrir/events","assignees_url":"https://api.github.com/repos/ndoit/fenrir/assignees{/user}","branches_url":"https://api.github.com/repos/ndoit/fenrir/branches{/branch}","tags_url":"https://api.github.com/repos/ndoit/fenrir/tags","blobs_url":"https://api.github.com/repos/ndoit/fenrir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndoit/fenrir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndoit/fenrir/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndoit/fenrir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndoit/fenrir/statuses/{sha}","languages_url":"https://api.github.com/repos/ndoit/fenrir/languages","stargazers_url":"https://api.github.com/repos/ndoit/fenrir/stargazers","contributors_url":"https://api.github.com/repos/ndoit/fenrir/contributors","subscribers_url":"https://api.github.com/repos/ndoit/fenrir/subscribers","subscription_url":"https://api.github.com/repos/ndoit/fenrir/subscription","commits_url":"https://api.github.com/repos/ndoit/fenrir/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndoit/fenrir/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndoit/fenrir/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndoit/fenrir/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndoit/fenrir/contents/{+path}","compare_url":"https://api.github.com/repos/ndoit/fenrir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndoit/fenrir/merges","archive_url":"https://api.github.com/repos/ndoit/fenrir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndoit/fenrir/downloads","issues_url":"https://api.github.com/repos/ndoit/fenrir/issues{/number}","pulls_url":"https://api.github.com/repos/ndoit/fenrir/pulls{/number}","milestones_url":"https://api.github.com/repos/ndoit/fenrir/milestones{/number}","notifications_url":"https://api.github.com/repos/ndoit/fenrir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndoit/fenrir/labels{/name}","releases_url":"https://api.github.com/repos/ndoit/fenrir/releases{/id}","deployments_url":"https://api.github.com/repos/ndoit/fenrir/deployments","created_at":"2015-07-28T14:14:01Z","updated_at":"2019-02-01T15:12:07Z","pushed_at":"2019-03-25T16:43:09Z","git_url":"git://github.com/ndoit/fenrir.git","ssh_url":"git@github.com:ndoit/fenrir.git","clone_url":"https://github.com/ndoit/fenrir.git","svn_url":"https://github.com/ndoit/fenrir","homepage":"https://data.nd.edu","size":34567,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":29,"watchers":6,"default_branch":"master"}},"base":{"label":"ndoit:master","ref":"master","sha":"fc3957536325b897b638016a6a83b7da80794d62","user":{"login":"ndoit","id":6223716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjM3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6223716?v=4","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"repo":{"id":39837938,"node_id":"MDEwOlJlcG9zaXRvcnkzOTgzNzkzOA==","name":"fenrir","full_name":"ndoit/fenrir","private":false,"owner":{"login":"ndoit","id":6223716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjM3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6223716?v=4","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ndoit/fenrir","description":"BI Portal","fork":false,"url":"https://api.github.com/repos/ndoit/fenrir","forks_url":"https://api.github.com/repos/ndoit/fenrir/forks","keys_url":"https://api.github.com/repos/ndoit/fenrir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndoit/fenrir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndoit/fenrir/teams","hooks_url":"https://api.github.com/repos/ndoit/fenrir/hooks","issue_events_url":"https://api.github.com/repos/ndoit/fenrir/issues/events{/number}","events_url":"https://api.github.com/repos/ndoit/fenrir/events","assignees_url":"https://api.github.com/repos/ndoit/fenrir/assignees{/user}","branches_url":"https://api.github.com/repos/ndoit/fenrir/branches{/branch}","tags_url":"https://api.github.com/repos/ndoit/fenrir/tags","blobs_url":"https://api.github.com/repos/ndoit/fenrir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndoit/fenrir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndoit/fenrir/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndoit/fenrir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndoit/fenrir/statuses/{sha}","languages_url":"https://api.github.com/repos/ndoit/fenrir/languages","stargazers_url":"https://api.github.com/repos/ndoit/fenrir/stargazers","contributors_url":"https://api.github.com/repos/ndoit/fenrir/contributors","subscribers_url":"https://api.github.com/repos/ndoit/fenrir/subscribers","subscription_url":"https://api.github.com/repos/ndoit/fenrir/subscription","commits_url":"https://api.github.com/repos/ndoit/fenrir/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndoit/fenrir/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndoit/fenrir/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndoit/fenrir/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndoit/fenrir/contents/{+path}","compare_url":"https://api.github.com/repos/ndoit/fenrir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndoit/fenrir/merges","archive_url":"https://api.github.com/repos/ndoit/fenrir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndoit/fenrir/downloads","issues_url":"https://api.github.com/repos/ndoit/fenrir/issues{/number}","pulls_url":"https://api.github.com/repos/ndoit/fenrir/pulls{/number}","milestones_url":"https://api.github.com/repos/ndoit/fenrir/milestones{/number}","notifications_url":"https://api.github.com/repos/ndoit/fenrir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndoit/fenrir/labels{/name}","releases_url":"https://api.github.com/repos/ndoit/fenrir/releases{/id}","deployments_url":"https://api.github.com/repos/ndoit/fenrir/deployments","created_at":"2015-07-28T14:14:01Z","updated_at":"2019-02-01T15:12:07Z","pushed_at":"2019-03-25T16:43:09Z","git_url":"git://github.com/ndoit/fenrir.git","ssh_url":"git@github.com:ndoit/fenrir.git","clone_url":"https://github.com/ndoit/fenrir.git","svn_url":"https://github.com/ndoit/fenrir","homepage":"https://data.nd.edu","size":34567,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":29,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/941"},"html":{"href":"https://github.com/ndoit/fenrir/pull/941"},"issue":{"href":"https://api.github.com/repos/ndoit/fenrir/issues/941"},"comments":{"href":"https://api.github.com/repos/ndoit/fenrir/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/ndoit/fenrir/statuses/1b19e88f0fbe5c1741e3fee04da399c4867f998b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 39837938,
"name": "ndoit/fenrir",
"url": "https://api.github.com/repos/ndoit/fenrir"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 6223716,
"login": "ndoit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6223716?",
"url": "https://api.github.com/orgs/ndoit"
}
| 2019-03-25T16:44:43 |
9309563029
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/267271229","pull_request_review_id":216634437,"id":267271229,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzI3MTIyOQ==","diff_hunk":"@@ -2143,47 +2142,84 @@ TypeResult StructType::interfaceType(bool _inLibrary) const\n \tif (!_inLibrary && m_interfaceType.is_initialized())\n \t\treturn *m_interfaceType;\n \n-\tTypePointer result = TypePointer{};\n+\tbool recursion = false;\n+\tTypeResult result{TypePointer{}};\n \n-\tif (_inLibrary && location() == DataLocation::Storage)\n-\t\tresult = shared_from_this();\n-\telse if (recursive())\n-\t\tresult = TypePointer{};\n-\telse\n+\tauto visitor = [&](\n+\t\tStructDefinition const& _struct,\n+\t\tCycleDetector<StructDefinition>& _cycleDetector,\n+\t\tsize_t /*_depth*/\n+\t)\n \t{\n \t\t// Check that all members have interface types.\n-\t\t// We pass \"false\" to canBeUsedExternally (_inLibrary), because this struct will be\n-\t\t// passed by value and thus the encoding does not differ, but it will disallow\n-\t\t// mappings.\n-\t\t// Also return false if at least one struct member does not have a type.\n+\t\t// Return false if at least one struct member does not have a type.\n \t\t// This might happen, for example, if the type of the member does not exist,\n \t\t// which is reported as an error.\n-\t\tbool allOkay = true;\n-\t\tfor (auto const& var: m_struct.members())\n+\t\tfor (ASTPointer<VariableDeclaration> const& variable: _struct.members())\n \t\t{\n \t\t\t// If the struct member does not have a type return false.\n \t\t\t// A TypeError is expected in this case.\n-\t\t\tif (!var->annotation().type)\n+\t\t\tif (!variable->annotation().type)\n \t\t\t{\n-\t\t\t\tallOkay = false;\n-\t\t\t\tbreak;\n+\t\t\t\tresult = TypeResult::err(\"Invalid type!\");\n+\t\t\t\treturn;\n \t\t\t}\n-\t\t\tif (!var->annotation().type->interfaceType(false).get())\n+\n+\t\t\tType const* memberType = variable->annotation().type.get();\n+\n+\t\t\twhile (dynamic_cast<ArrayType const*>(memberType))\n+\t\t\t\tmemberType = dynamic_cast<ArrayType const*>(memberType)->baseType().get();\n+\n+\t\t\tif (StructType const* innerStruct = dynamic_cast<StructType const*>(memberType))\n+\t\t\t\tif (_cycleDetector.run(innerStruct->structDefinition()))\n+\t\t\t\t{\n+\t\t\t\t\trecursion = true;\n+\t\t\t\t\tif (_inLibrary && location() == DataLocation::Storage)\n+\t\t\t\t\t\tcontinue;\n+\t\t\t\t\telse\n+\t\t\t\t\t{\n+\t\t\t\t\t\tresult = TypeResult::err(\"Recursive struct are required to have storage data location.\");\n+\t\t\t\t\t\treturn;\n+\t\t\t\t\t}\n+\t\t\t\t}\n+\n+\t\t\tauto iType = memberType->interfaceType(_inLibrary);\n+\t\t\tif (!iType.get())\n \t\t\t{\n-\t\t\t\tallOkay = false;\n-\t\t\t\tbreak;\n+\t\t\t\tsolAssert(!iType.message().empty(), \"Expected detailed error message!\");\n+\t\t\t\tresult = iType;\n+\t\t\t\treturn;\n \t\t\t}\n \t\t}\n-\t\tif (allOkay)\n-\t\t\tresult = copyForLocation(DataLocation::Memory, true);\n-\t}\n+\t};\n+\n+\trecursion = recursion || (CycleDetector<StructDefinition>(visitor).run(structDefinition()) != nullptr);","path":"libsolidity/ast/Types.cpp","position":null,"original_position":120,"commit_id":"e2db7e0b1b50cf8d44741e87c70d86741f6d377d","original_commit_id":"fe38c526929deb2d1d5ba3f81794f04ca0b51b39","user":{"login":"Marenz","id":424752,"node_id":"MDQ6VXNlcjQyNDc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/424752?v=4","gravatar_id":"","url":"https://api.github.com/users/Marenz","html_url":"https://github.com/Marenz","followers_url":"https://api.github.com/users/Marenz/followers","following_url":"https://api.github.com/users/Marenz/following{/other_user}","gists_url":"https://api.github.com/users/Marenz/gists{/gist_id}","starred_url":"https://api.github.com/users/Marenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marenz/subscriptions","organizations_url":"https://api.github.com/users/Marenz/orgs","repos_url":"https://api.github.com/users/Marenz/repos","events_url":"https://api.github.com/users/Marenz/events{/privacy}","received_events_url":"https://api.github.com/users/Marenz/received_events","type":"User","site_admin":false},"body":"it's also assigned to in line 2176","created_at":"2019-03-20T10:27:19Z","updated_at":"2019-03-20T10:27:19Z","html_url":"https://github.com/ethereum/solidity/pull/6222#discussion_r267271229","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/6222","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/267271229"},"html":{"href":"https://github.com/ethereum/solidity/pull/6222#discussion_r267271229"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/6222"}},"in_reply_to_id":267264470},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/6222","id":259176272,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MTc2Mjcy","html_url":"https://github.com/ethereum/solidity/pull/6222","diff_url":"https://github.com/ethereum/solidity/pull/6222.diff","patch_url":"https://github.com/ethereum/solidity/pull/6222.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/6222","number":6222,"state":"open","locked":false,"title":"Disallow internal function types as parameters for public/external library function","user":{"login":"Marenz","id":424752,"node_id":"MDQ6VXNlcjQyNDc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/424752?v=4","gravatar_id":"","url":"https://api.github.com/users/Marenz","html_url":"https://github.com/Marenz","followers_url":"https://api.github.com/users/Marenz/followers","following_url":"https://api.github.com/users/Marenz/following{/other_user}","gists_url":"https://api.github.com/users/Marenz/gists{/gist_id}","starred_url":"https://api.github.com/users/Marenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marenz/subscriptions","organizations_url":"https://api.github.com/users/Marenz/orgs","repos_url":"https://api.github.com/users/Marenz/repos","events_url":"https://api.github.com/users/Marenz/events{/privacy}","received_events_url":"https://api.github.com/users/Marenz/received_events","type":"User","site_admin":false},"body":"I am not very sure about my changes here, but the tests all work, so.. yeah.\r\n\r\nFixes #6215 and fixes #6151","created_at":"2019-03-07T16:13:53Z","updated_at":"2019-03-20T10:27:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43ba12ee08d76b420cbdf7843e66f1da76dc7eef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/6222/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/6222/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/6222/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/e2db7e0b1b50cf8d44741e87c70d86741f6d377d","head":{"label":"ethereum:internal-error-maybe","ref":"internal-error-maybe","sha":"e2db7e0b1b50cf8d44741e87c70d86741f6d377d","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2019-03-20T09:51:56Z","pushed_at":"2019-03-20T09:51:50Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":26973,"stargazers_count":6763,"watchers_count":6763,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1825,"mirror_url":null,"archived":false,"open_issues_count":624,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1825,"open_issues":624,"watchers":6763,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"c7824932a456cbc8ce11d3cc5a0b0f54563f57b8","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2019-03-20T09:51:56Z","pushed_at":"2019-03-20T09:51:50Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":26973,"stargazers_count":6763,"watchers_count":6763,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1825,"mirror_url":null,"archived":false,"open_issues_count":624,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1825,"open_issues":624,"watchers":6763,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/6222"},"html":{"href":"https://github.com/ethereum/solidity/pull/6222"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/6222"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/6222/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/6222/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/6222/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/e2db7e0b1b50cf8d44741e87c70d86741f6d377d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 40892817,
"name": "ethereum/solidity",
"url": "https://api.github.com/repos/ethereum/solidity"
}
|
{
"id": 424752,
"login": "Marenz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/424752?",
"url": "https://api.github.com/users/Marenz"
}
|
{
"id": 6250754,
"login": "ethereum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6250754?",
"url": "https://api.github.com/orgs/ethereum"
}
| 2019-03-20T10:27:19 |
9278564051
|
{"actor":{"display_login":"Marenz"}}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.