type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
428k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
11
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/comments/264045140","pull_request_review_id":212608752,"id":264045140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDA0NTE0MA==","diff_hunk":"@@ -1,102 +1,81 @@\n ---\n title: C++\n ---\n-# Hello World! - Your First C++ Program\n+# C++\n \n ## What is C++?\n \n-* C++ is a general purpose programming [Object-Oriented](https://en.wikipedia.org/wiki/Object-oriented_programming) language which has been used since the 1990's\n-* It was designed as a thesis paper by [Bjarne Stroustrup](https://en.wikipedia.org/wiki/Bjarne_Stroustrup) under the name \"C with Classes\", which later became C++.\n-* It is a version of C that includes Object-Oriented elements, including classes and functions.\n-\n-* It is considered one of the biggest programming languages, as you can see in the following image:\n-\n+- C++ is a general purpose programming [object-oriented programming](https://en.wikipedia.org/wiki/Object-oriented_programming) (OOP) language which has been used since the 1990's\n+- It was designed as a thesis paper by [Bjarne Stroustrup](https://en.wikipedia.org/wiki/Bjarne_Stroustrup) under the name \"C with classes\", which later became C++.\n+- It is a version of C that includes OOP elements, including classes and functions.\n+- It is considered one of the biggest programming languages, as you can see in the following image:\n+","path":"guide/english/cplusplus/index.md","position":19,"original_position":19,"commit_id":"4775929c70fd15d7f6d4381500c4a56e5f1c3597","original_commit_id":"4775929c70fd15d7f6d4381500c4a56e5f1c3597","user":{"login":"cmccormack","id":3016919,"node_id":"MDQ6VXNlcjMwMTY5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3016919?v=4","gravatar_id":"","url":"https://api.github.com/users/cmccormack","html_url":"https://github.com/cmccormack","followers_url":"https://api.github.com/users/cmccormack/followers","following_url":"https://api.github.com/users/cmccormack/following{/other_user}","gists_url":"https://api.github.com/users/cmccormack/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccormack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccormack/subscriptions","organizations_url":"https://api.github.com/users/cmccormack/orgs","repos_url":"https://api.github.com/users/cmccormack/repos","events_url":"https://api.github.com/users/cmccormack/events{/privacy}","received_events_url":"https://api.github.com/users/cmccormack/received_events","type":"User","site_admin":false},"body":"Are you referring to the last bullet only or the entire section?","created_at":"2019-03-10T15:44:11Z","updated_at":"2019-03-10T15:44:11Z","html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/35519#discussion_r264045140","pull_request_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/35519","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/comments/264045140"},"html":{"href":"https://github.com/freeCodeCamp/freeCodeCamp/pull/35519#discussion_r264045140"},"pull_request":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/35519"}},"in_reply_to_id":263836259},"pull_request":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/35519","id":258453776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4NDUzNzc2","html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/35519","diff_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/35519.diff","patch_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/35519.patch","issue_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/35519","number":35519,"state":"open","locked":false,"title":"feat/cleaned up formatting, added clarity, removed unnecessary parts","user":{"login":"cmccormack","id":3016919,"node_id":"MDQ6VXNlcjMwMTY5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3016919?v=4","gravatar_id":"","url":"https://api.github.com/users/cmccormack","html_url":"https://github.com/cmccormack","followers_url":"https://api.github.com/users/cmccormack/followers","following_url":"https://api.github.com/users/cmccormack/following{/other_user}","gists_url":"https://api.github.com/users/cmccormack/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccormack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccormack/subscriptions","organizations_url":"https://api.github.com/users/cmccormack/orgs","repos_url":"https://api.github.com/users/cmccormack/repos","events_url":"https://api.github.com/users/cmccormack/events{/privacy}","received_events_url":"https://api.github.com/users/cmccormack/received_events","type":"User","site_admin":false},"body":"- [X] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).\r\n- [X] My pull request has a descriptive title (not a vague title like `Update index.md`)\r\n- [X] My pull request targets the `master` branch of freeCodeCamp.\r\n- [X] None of my changes are plagiarized from another source without proper attribution.\r\n- [X] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)\r\n- [X] My changes do not use shortened URLs or affiliate links.","created_at":"2019-03-05T19:19:43Z","updated_at":"2019-03-10T15:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e4e013ae3f910501ca59f4ca2af9212113a9fce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1130338882,"node_id":"MDU6TGFiZWwxMTMwMzM4ODgy","url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/labels/language:%20English","name":"language: English","color":"8ed9e2","default":false},{"id":1088400742,"node_id":"MDU6TGFiZWwxMDg4NDAwNzQy","url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/labels/scope:%20guide","name":"scope: guide","color":"9631e2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/35519/commits","review_comments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/35519/comments","review_comment_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/35519/comments","statuses_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/statuses/4775929c70fd15d7f6d4381500c4a56e5f1c3597","head":{"label":"cmccormack:feat/cleanup-cplusplus-index","ref":"feat/cleanup-cplusplus-index","sha":"4775929c70fd15d7f6d4381500c4a56e5f1c3597","user":{"login":"cmccormack","id":3016919,"node_id":"MDQ6VXNlcjMwMTY5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3016919?v=4","gravatar_id":"","url":"https://api.github.com/users/cmccormack","html_url":"https://github.com/cmccormack","followers_url":"https://api.github.com/users/cmccormack/followers","following_url":"https://api.github.com/users/cmccormack/following{/other_user}","gists_url":"https://api.github.com/users/cmccormack/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccormack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccormack/subscriptions","organizations_url":"https://api.github.com/users/cmccormack/orgs","repos_url":"https://api.github.com/users/cmccormack/repos","events_url":"https://api.github.com/users/cmccormack/events{/privacy}","received_events_url":"https://api.github.com/users/cmccormack/received_events","type":"User","site_admin":false},"repo":{"id":153968161,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM5NjgxNjE=","name":"freeCodeCamp-1","full_name":"cmccormack/freeCodeCamp-1","private":false,"owner":{"login":"cmccormack","id":3016919,"node_id":"MDQ6VXNlcjMwMTY5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3016919?v=4","gravatar_id":"","url":"https://api.github.com/users/cmccormack","html_url":"https://github.com/cmccormack","followers_url":"https://api.github.com/users/cmccormack/followers","following_url":"https://api.github.com/users/cmccormack/following{/other_user}","gists_url":"https://api.github.com/users/cmccormack/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccormack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccormack/subscriptions","organizations_url":"https://api.github.com/users/cmccormack/orgs","repos_url":"https://api.github.com/users/cmccormack/repos","events_url":"https://api.github.com/users/cmccormack/events{/privacy}","received_events_url":"https://api.github.com/users/cmccormack/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cmccormack/freeCodeCamp-1","description":"The https://freeCodeCamp.org open source codebase and curriculum. Learn to code for free together with millions of people.","fork":true,"url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1","forks_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/forks","keys_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/teams","hooks_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/hooks","issue_events_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/issues/events{/number}","events_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/events","assignees_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/assignees{/user}","branches_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/branches{/branch}","tags_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/tags","blobs_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/statuses/{sha}","languages_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/languages","stargazers_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/stargazers","contributors_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/contributors","subscribers_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/subscribers","subscription_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/subscription","commits_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/contents/{+path}","compare_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/merges","archive_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/downloads","issues_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/issues{/number}","pulls_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/pulls{/number}","milestones_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/milestones{/number}","notifications_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/labels{/name}","releases_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/releases{/id}","deployments_url":"https://api.github.com/repos/cmccormack/freeCodeCamp-1/deployments","created_at":"2018-10-21T02:57:31Z","updated_at":"2019-02-27T15:34:16Z","pushed_at":"2019-03-05T19:18:37Z","git_url":"git://github.com/cmccormack/freeCodeCamp-1.git","ssh_url":"git@github.com:cmccormack/freeCodeCamp-1.git","clone_url":"https://github.com/cmccormack/freeCodeCamp-1.git","svn_url":"https://github.com/cmccormack/freeCodeCamp-1","homepage":"","size":112712,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeCodeCamp:master","ref":"master","sha":"44445fec7225cac66040db17960a92e95a4e9d08","user":{"login":"freeCodeCamp","id":9892522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4OTI1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/9892522?v=4","gravatar_id":"","url":"https://api.github.com/users/freeCodeCamp","html_url":"https://github.com/freeCodeCamp","followers_url":"https://api.github.com/users/freeCodeCamp/followers","following_url":"https://api.github.com/users/freeCodeCamp/following{/other_user}","gists_url":"https://api.github.com/users/freeCodeCamp/gists{/gist_id}","starred_url":"https://api.github.com/users/freeCodeCamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeCodeCamp/subscriptions","organizations_url":"https://api.github.com/users/freeCodeCamp/orgs","repos_url":"https://api.github.com/users/freeCodeCamp/repos","events_url":"https://api.github.com/users/freeCodeCamp/events{/privacy}","received_events_url":"https://api.github.com/users/freeCodeCamp/received_events","type":"Organization","site_admin":false},"repo":{"id":28457823,"node_id":"MDEwOlJlcG9zaXRvcnkyODQ1NzgyMw==","name":"freeCodeCamp","full_name":"freeCodeCamp/freeCodeCamp","private":false,"owner":{"login":"freeCodeCamp","id":9892522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4OTI1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/9892522?v=4","gravatar_id":"","url":"https://api.github.com/users/freeCodeCamp","html_url":"https://github.com/freeCodeCamp","followers_url":"https://api.github.com/users/freeCodeCamp/followers","following_url":"https://api.github.com/users/freeCodeCamp/following{/other_user}","gists_url":"https://api.github.com/users/freeCodeCamp/gists{/gist_id}","starred_url":"https://api.github.com/users/freeCodeCamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeCodeCamp/subscriptions","organizations_url":"https://api.github.com/users/freeCodeCamp/orgs","repos_url":"https://api.github.com/users/freeCodeCamp/repos","events_url":"https://api.github.com/users/freeCodeCamp/events{/privacy}","received_events_url":"https://api.github.com/users/freeCodeCamp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freeCodeCamp/freeCodeCamp","description":"The https://www.freeCodeCamp.org open source codebase and curriculum. Learn to code for free together with millions of people.","fork":false,"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp","forks_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/forks","keys_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/teams","hooks_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/hooks","issue_events_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/events{/number}","events_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/events","assignees_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/assignees{/user}","branches_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/branches{/branch}","tags_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/tags","blobs_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/statuses/{sha}","languages_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/languages","stargazers_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/stargazers","contributors_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/contributors","subscribers_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/subscribers","subscription_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/subscription","commits_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/contents/{+path}","compare_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/merges","archive_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/downloads","issues_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues{/number}","pulls_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls{/number}","milestones_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/milestones{/number}","notifications_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/labels{/name}","releases_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/releases{/id}","deployments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/deployments","created_at":"2014-12-24T17:49:19Z","updated_at":"2019-03-10T15:37:47Z","pushed_at":"2019-03-10T15:38:50Z","git_url":"git://github.com/freeCodeCamp/freeCodeCamp.git","ssh_url":"git@github.com:freeCodeCamp/freeCodeCamp.git","clone_url":"https://github.com/freeCodeCamp/freeCodeCamp.git","svn_url":"https://github.com/freeCodeCamp/freeCodeCamp","homepage":"","size":112940,"stargazers_count":298087,"watchers_count":298087,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21094,"mirror_url":null,"archived":false,"open_issues_count":3735,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":21094,"open_issues":3735,"watchers":298087,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/35519"},"html":{"href":"https://github.com/freeCodeCamp/freeCodeCamp/pull/35519"},"issue":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/35519"},"comments":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/35519/comments"},"review_comments":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/35519/comments"},"review_comment":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/35519/commits"},"statuses":{"href":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/statuses/4775929c70fd15d7f6d4381500c4a56e5f1c3597"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 28457823,
"name": "freeCodeCamp/freeCodeCamp",
"url": "https://api.github.com/repos/freeCodeCamp/freeCodeCamp"
}
|
{
"id": 3016919,
"login": "cmccormack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3016919?",
"url": "https://api.github.com/users/cmccormack"
}
|
{
"id": 9892522,
"login": "freeCodeCamp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9892522?",
"url": "https://api.github.com/orgs/freeCodeCamp"
}
| 2019-03-10T15:44:11 |
9213896582
|
{"actor":{"display_login":"cmccormack"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/comments/347333029","pull_request_review_id":318268734,"id":347333029,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzMzMzAyOQ==","diff_hunk":"@@ -67,38 +65,68 @@ <h3 class=\"top-week-product__subtitile\">Товар недели</h3>\n </tr>\n </table>\n <img class=\"top-week-product__image\" src=\"#\" alt=\"#\">\n- <p>Цена: 990 руб.</p>\n+ <p class=\"to-week-product__price\">Цена: 990 руб.</p>\n <button class=\"top-week-product__button top-week-product__button--to-order\" type=\"button\" aria-label=\"Выбрать размеры\">Заказать</button>\n </section>\n <section class=\"about-us\">\n <h2 class=\"about-us__title\">Коротко о нас:</h2>\n <ul class=\"about-us__list reset-list\">\n- <li class=\"about-us-list__about-us-list-item about-us-list__about-us-list-item--eco\">Экологически чистые материалы</li>\n- <li class=\"about-us-list__about-us-list-item about-us-list__about-us-list-item--saving\">Скандинавский стиль по российской цене</li>\n- <li class=\"about-us-list__about-us-list-item about-us-list__about-us-list-item--like\">Увеличивает лайки на фотографиях</li>\n- <li class=\"about-us-list__about-us-list-item about-us-list__about-us-list-item--knitting\">Связано в ручную с любовью и умилением</li>\n- <li class=\"about-us-list__about-us-list-item about-us-list__about-us-list-item--patriotism\">Поддержка отечественного производителя</li>\n- <li class=\"about-us-list__about-us-list-item about-us-list__about-us-list-item--present\">Поставляется в подарочной упаковке</li>\n+ <li class=\"about-us__item about-us__item--eco\">Экологически чистые материалы</li>\n+ <li class=\"about-us__item about-us__item--saving\">Скандинавский стиль по российской цене</li>\n+ <li class=\"about-us__item about-us__item--like\">Увеличивает лайки на фотографиях</li>\n+ <li class=\"about-us__item about-us__item--knitting\">Связано в ручную с любовью и умилением</li>\n+ <li class=\"about-us__item about-us__item--patriotism\">Поддержка отечественного производителя</li>\n+ <li class=\"about-us__item about-us__item--present\">Поставляется в подарочной упаковке</li>\n </ul>\n </section>\n+ <section class=\"reviews reviews-card\">","path":"source/index.html","position":99,"original_position":81,"commit_id":"c56aafb5121643524264b4e5f4adbc59cedb117a","original_commit_id":"b4162335f442a46fbce81878db805b8dc4b9277b","user":{"login":"AnnaVasilchenko878","id":54268958,"node_id":"MDQ6VXNlcjU0MjY4OTU4","avatar_url":"https://avatars1.githubusercontent.com/u/54268958?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnaVasilchenko878","html_url":"https://github.com/AnnaVasilchenko878","followers_url":"https://api.github.com/users/AnnaVasilchenko878/followers","following_url":"https://api.github.com/users/AnnaVasilchenko878/following{/other_user}","gists_url":"https://api.github.com/users/AnnaVasilchenko878/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaVasilchenko878/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaVasilchenko878/subscriptions","organizations_url":"https://api.github.com/users/AnnaVasilchenko878/orgs","repos_url":"https://api.github.com/users/AnnaVasilchenko878/repos","events_url":"https://api.github.com/users/AnnaVasilchenko878/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaVasilchenko878/received_events","type":"User","site_admin":false},"body":"> reviews-card и reviews не могут миксоваться. Представь, что у тебя 3 слайда з коментами. Как в этом случае оформишь содержимое?\r\nВопрос просто про обертки, можно ли давать обертке модификатор?\r\nНапример\r\n\"card__wrapper card__wrapper--apple\"\r\n\"card__wrapper card__wrapper--banana\"\r\nЯ поняла, здесь нужно создать обертку\r\n","created_at":"2019-11-18T11:37:52Z","updated_at":"2019-11-18T11:37:52Z","html_url":"https://github.com/htmlacademy-adaptive/1112313-mishka-18/pull/4#discussion_r347333029","pull_request_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/comments/347333029"},"html":{"href":"https://github.com/htmlacademy-adaptive/1112313-mishka-18/pull/4#discussion_r347333029"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/4"}},"in_reply_to_id":346981401},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/4","id":340946510,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQwOTQ2NTEw","html_url":"https://github.com/htmlacademy-adaptive/1112313-mishka-18/pull/4","diff_url":"https://github.com/htmlacademy-adaptive/1112313-mishka-18/pull/4.diff","patch_url":"https://github.com/htmlacademy-adaptive/1112313-mishka-18/pull/4.patch","issue_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/issues/4","number":4,"state":"open","locked":false,"title":"Завершаем методичную разметку личного проекта","user":{"login":"AnnaVasilchenko878","id":54268958,"node_id":"MDQ6VXNlcjU0MjY4OTU4","avatar_url":"https://avatars1.githubusercontent.com/u/54268958?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnaVasilchenko878","html_url":"https://github.com/AnnaVasilchenko878","followers_url":"https://api.github.com/users/AnnaVasilchenko878/followers","following_url":"https://api.github.com/users/AnnaVasilchenko878/following{/other_user}","gists_url":"https://api.github.com/users/AnnaVasilchenko878/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaVasilchenko878/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaVasilchenko878/subscriptions","organizations_url":"https://api.github.com/users/AnnaVasilchenko878/orgs","repos_url":"https://api.github.com/users/AnnaVasilchenko878/repos","events_url":"https://api.github.com/users/AnnaVasilchenko878/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaVasilchenko878/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Завершаем методичную разметку личного проекта](https://up.htmlacademy.ru/adaptive/18/user/1112313/tasks/3)\n\n:boom: https://htmlacademy-adaptive.github.io/1112313-mishka-18/4/","created_at":"2019-11-14T12:26:35Z","updated_at":"2019-11-18T11:37:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea696adbbdb1e47cad75c91ee87a94dbc2aafadd","assignee":{"login":"ad0v0","id":9592349,"node_id":"MDQ6VXNlcjk1OTIzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/9592349?v=4","gravatar_id":"","url":"https://api.github.com/users/ad0v0","html_url":"https://github.com/ad0v0","followers_url":"https://api.github.com/users/ad0v0/followers","following_url":"https://api.github.com/users/ad0v0/following{/other_user}","gists_url":"https://api.github.com/users/ad0v0/gists{/gist_id}","starred_url":"https://api.github.com/users/ad0v0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ad0v0/subscriptions","organizations_url":"https://api.github.com/users/ad0v0/orgs","repos_url":"https://api.github.com/users/ad0v0/repos","events_url":"https://api.github.com/users/ad0v0/events{/privacy}","received_events_url":"https://api.github.com/users/ad0v0/received_events","type":"User","site_admin":false},"assignees":[{"login":"ad0v0","id":9592349,"node_id":"MDQ6VXNlcjk1OTIzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/9592349?v=4","gravatar_id":"","url":"https://api.github.com/users/ad0v0","html_url":"https://github.com/ad0v0","followers_url":"https://api.github.com/users/ad0v0/followers","following_url":"https://api.github.com/users/ad0v0/following{/other_user}","gists_url":"https://api.github.com/users/ad0v0/gists{/gist_id}","starred_url":"https://api.github.com/users/ad0v0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ad0v0/subscriptions","organizations_url":"https://api.github.com/users/ad0v0/orgs","repos_url":"https://api.github.com/users/ad0v0/repos","events_url":"https://api.github.com/users/ad0v0/events{/privacy}","received_events_url":"https://api.github.com/users/ad0v0/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ad0v0","id":9592349,"node_id":"MDQ6VXNlcjk1OTIzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/9592349?v=4","gravatar_id":"","url":"https://api.github.com/users/ad0v0","html_url":"https://github.com/ad0v0","followers_url":"https://api.github.com/users/ad0v0/followers","following_url":"https://api.github.com/users/ad0v0/following{/other_user}","gists_url":"https://api.github.com/users/ad0v0/gists{/gist_id}","starred_url":"https://api.github.com/users/ad0v0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ad0v0/subscriptions","organizations_url":"https://api.github.com/users/ad0v0/orgs","repos_url":"https://api.github.com/users/ad0v0/repos","events_url":"https://api.github.com/users/ad0v0/events{/privacy}","received_events_url":"https://api.github.com/users/ad0v0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/4/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/4/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/issues/4/comments","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/statuses/c56aafb5121643524264b4e5f4adbc59cedb117a","head":{"label":"AnnaVasilchenko878:module2-task2","ref":"module2-task2","sha":"c56aafb5121643524264b4e5f4adbc59cedb117a","user":{"login":"AnnaVasilchenko878","id":54268958,"node_id":"MDQ6VXNlcjU0MjY4OTU4","avatar_url":"https://avatars1.githubusercontent.com/u/54268958?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnaVasilchenko878","html_url":"https://github.com/AnnaVasilchenko878","followers_url":"https://api.github.com/users/AnnaVasilchenko878/followers","following_url":"https://api.github.com/users/AnnaVasilchenko878/following{/other_user}","gists_url":"https://api.github.com/users/AnnaVasilchenko878/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaVasilchenko878/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaVasilchenko878/subscriptions","organizations_url":"https://api.github.com/users/AnnaVasilchenko878/orgs","repos_url":"https://api.github.com/users/AnnaVasilchenko878/repos","events_url":"https://api.github.com/users/AnnaVasilchenko878/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaVasilchenko878/received_events","type":"User","site_admin":false},"repo":{"id":219571389,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk1NzEzODk=","name":"1112313-mishka-18","full_name":"AnnaVasilchenko878/1112313-mishka-18","private":false,"owner":{"login":"AnnaVasilchenko878","id":54268958,"node_id":"MDQ6VXNlcjU0MjY4OTU4","avatar_url":"https://avatars1.githubusercontent.com/u/54268958?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnaVasilchenko878","html_url":"https://github.com/AnnaVasilchenko878","followers_url":"https://api.github.com/users/AnnaVasilchenko878/followers","following_url":"https://api.github.com/users/AnnaVasilchenko878/following{/other_user}","gists_url":"https://api.github.com/users/AnnaVasilchenko878/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaVasilchenko878/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaVasilchenko878/subscriptions","organizations_url":"https://api.github.com/users/AnnaVasilchenko878/orgs","repos_url":"https://api.github.com/users/AnnaVasilchenko878/repos","events_url":"https://api.github.com/users/AnnaVasilchenko878/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaVasilchenko878/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AnnaVasilchenko878/1112313-mishka-18","description":"Анна Васильченко","fork":true,"url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18","forks_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/forks","keys_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/teams","hooks_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/hooks","issue_events_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/issues/events{/number}","events_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/events","assignees_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/assignees{/user}","branches_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/branches{/branch}","tags_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/tags","blobs_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/statuses/{sha}","languages_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/languages","stargazers_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/stargazers","contributors_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/contributors","subscribers_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/subscribers","subscription_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/subscription","commits_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/contents/{+path}","compare_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/merges","archive_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/downloads","issues_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/issues{/number}","pulls_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/pulls{/number}","milestones_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/milestones{/number}","notifications_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/labels{/name}","releases_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/releases{/id}","deployments_url":"https://api.github.com/repos/AnnaVasilchenko878/1112313-mishka-18/deployments","created_at":"2019-11-04T18:39:58Z","updated_at":"2019-11-04T18:39:59Z","pushed_at":"2019-11-18T04:38:20Z","git_url":"git://github.com/AnnaVasilchenko878/1112313-mishka-18.git","ssh_url":"git@github.com:AnnaVasilchenko878/1112313-mishka-18.git","clone_url":"https://github.com/AnnaVasilchenko878/1112313-mishka-18.git","svn_url":"https://github.com/AnnaVasilchenko878/1112313-mishka-18","homepage":null,"size":113,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-adaptive:master","ref":"master","sha":"a06bfa43d05b4449739901e304ef3b8a6d10c1b4","user":{"login":"htmlacademy-adaptive","id":9918669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTg2Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"repo":{"id":219565201,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk1NjUyMDE=","name":"1112313-mishka-18","full_name":"htmlacademy-adaptive/1112313-mishka-18","private":false,"owner":{"login":"htmlacademy-adaptive","id":9918669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTg2Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-adaptive/1112313-mishka-18","description":"Анна Васильченко","fork":false,"url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18","forks_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/forks","keys_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/teams","hooks_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/events","assignees_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/tags","blobs_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/subscription","commits_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/merges","archive_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/downloads","issues_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/deployments","created_at":"2019-11-04T18:07:40Z","updated_at":"2019-11-12T16:22:18Z","pushed_at":"2019-11-18T04:38:22Z","git_url":"git://github.com/htmlacademy-adaptive/1112313-mishka-18.git","ssh_url":"git@github.com:htmlacademy-adaptive/1112313-mishka-18.git","clone_url":"https://github.com/htmlacademy-adaptive/1112313-mishka-18.git","svn_url":"https://github.com/htmlacademy-adaptive/1112313-mishka-18","homepage":"https://github.com/AnnaVasilchenko878/1112313-mishka-18","size":114,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/4"},"html":{"href":"https://github.com/htmlacademy-adaptive/1112313-mishka-18/pull/4"},"issue":{"href":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/issues/4"},"comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18/statuses/c56aafb5121643524264b4e5f4adbc59cedb117a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 219565201,
"name": "htmlacademy-adaptive/1112313-mishka-18",
"url": "https://api.github.com/repos/htmlacademy-adaptive/1112313-mishka-18"
}
|
{
"id": 54268958,
"login": "AnnaVasilchenko878",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/54268958?",
"url": "https://api.github.com/users/AnnaVasilchenko878"
}
|
{
"id": 9918669,
"login": "htmlacademy-adaptive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9918669?",
"url": "https://api.github.com/orgs/htmlacademy-adaptive"
}
| 2019-11-18T11:37:52 |
10886019929
|
{"actor":{"display_login":"AnnaVasilchenko878"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/comments/303193579","pull_request_review_id":261529176,"id":303193579,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzE5MzU3OQ==","diff_hunk":"@@ -1,11 +1,214 @@\n <!DOCTYPE html>\n <html lang=\"ru\">\n- <head>\n- <meta charset=\"utf-8\">\n- <title>HTML Academy: Пинк</title>\n- </head>\n- <body>\n+<head>\n+ <meta charset=\"utf-8\">\n+ <title>HTML Academy: Пинк</title>\n+</head>\n+<body>\n+<header class=\"header\">\n+ <div class=\"header-logo\">\n+ <img src=\"http://placehold.it/75x22\" alt=\"Логотип\" class=\"logo header-logo__image\">\n+ <button class=\"btn-close header-logo__btn\" title=\"Закрыть\">\n+ <img src=\"http://placehold.it/23x23\" alt=\"Закрыть\">\n+ </button>\n+ </div>\n+ <nav class=\"main-navigation\">\n+ <ul class=\"navigation-list\">\n+ <li class=\"main-navigation__item\">\n+ <a class=\"main-navigation__item-link\">Главная</a>\n+ </li>\n+ <li class=\"main-navigation__item\">\n+ <a href=\"photo.html\" class=\"main-navigation__item-link\">Фотографии</a>\n+ </li>\n+ <li class=\"main-navigation__item\">\n+ <a href=\"form.html\" class=\"main-navigation__item-link\">Конкурс</a>\n+ </li>\n+ <li class=\"main-navigation__item\">\n+ <a href=\"https://htmlacademy.ru/intensive/adaptive\" class=\"main-navigation__item-link\">Htmlacademy</a>\n+ </li>\n+ </ul>\n+ </nav>\n+</header>\n+<main class=\"main-page\">\n+ <h1 class=\"visually-hidden\">Приложение Пинк</h1>\n+ <section class=\"pink-app\">\n+ <h2 class=\"visually-hidden\">Скачать приложение</h2>\n+ <img src=\"http://placehold.it/320x434\" alt=\"Рука с iphone\" class=\"pink-app__pic\">\n+ <div class=\"download\">\n+ <a href=\"https://www.apple.com/ru/itunes/\" class=\"btn download__btn\" title=\"Загрузить приложение\"></a>\n+ <ul class=\"icons-list download__icons\">\n+ <li class=\"icons-list__item\">\n+ <a href=\"https://www.apple.com/ru/\" class=\"icons-list__item-link\" aria-label=\"Apple\">\n+ <img src=\"http://placehold.it/45x35\" alt=\"Apple\">\n+ </a>\n+ </li>\n+ <li class=\"icons-list__item\">\n+ <a href=\"https://www.android.com/\" class=\"icons-list__item-link\" aria-label=\"Android\">\n+ <img src=\"http://placehold.it/45x35\" alt=\"Android\">\n+ </a>\n+ </li>\n+ <li class=\"icons-list__item\">\n+ <a href=\"https://www.microsoft.com/ru-ru/\" class=\"icons-list__item-link\" aria-label=\"Windows\">\n+ <img src=\"http://placehold.it/45x35\" alt=\"Windows\">\n+ </a>\n+ </li>\n+ </ul>\n+ <p class=\"download__text\">\n+ Доступно для iPhone, iPad, Android, Windows Phone, OS X, Windows 8\n+ </p>\n+ </div>\n+ </section>\n \n+ <section class=\"features\">\n+ <p class=\"slogan features__slogan\">Устали от серости мегаполиса?</p>","path":"source/index.html","position":69,"original_position":68,"commit_id":"dfb060f08633d4c797277382d03d7381dfacccc1","original_commit_id":"cdd82d87df6527b096d3de11ce2379a530e80475","user":{"login":"tati-simonenko","id":5658115,"node_id":"MDQ6VXNlcjU2NTgxMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5658115?v=4","gravatar_id":"","url":"https://api.github.com/users/tati-simonenko","html_url":"https://github.com/tati-simonenko","followers_url":"https://api.github.com/users/tati-simonenko/followers","following_url":"https://api.github.com/users/tati-simonenko/following{/other_user}","gists_url":"https://api.github.com/users/tati-simonenko/gists{/gist_id}","starred_url":"https://api.github.com/users/tati-simonenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tati-simonenko/subscriptions","organizations_url":"https://api.github.com/users/tati-simonenko/orgs","repos_url":"https://api.github.com/users/tati-simonenko/repos","events_url":"https://api.github.com/users/tati-simonenko/events{/privacy}","received_events_url":"https://api.github.com/users/tati-simonenko/received_events","type":"User","site_admin":false},"body":"Пока выглядит так, что класс slogan не понадобится","created_at":"2019-07-13T06:11:05Z","updated_at":"2019-07-13T06:11:06Z","html_url":"https://github.com/htmlacademy-adaptive/985489-pink-17/pull/3#discussion_r303193579","pull_request_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/comments/303193579"},"html":{"href":"https://github.com/htmlacademy-adaptive/985489-pink-17/pull/3#discussion_r303193579"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/3","id":297235298,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MjM1Mjk4","html_url":"https://github.com/htmlacademy-adaptive/985489-pink-17/pull/3","diff_url":"https://github.com/htmlacademy-adaptive/985489-pink-17/pull/3.diff","patch_url":"https://github.com/htmlacademy-adaptive/985489-pink-17/pull/3.patch","issue_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/issues/3","number":3,"state":"open","locked":false,"title":"Основное задание: начинаем методичную разметку личного проекта","user":{"login":"Griefman","id":24597900,"node_id":"MDQ6VXNlcjI0NTk3OTAw","avatar_url":"https://avatars0.githubusercontent.com/u/24597900?v=4","gravatar_id":"","url":"https://api.github.com/users/Griefman","html_url":"https://github.com/Griefman","followers_url":"https://api.github.com/users/Griefman/followers","following_url":"https://api.github.com/users/Griefman/following{/other_user}","gists_url":"https://api.github.com/users/Griefman/gists{/gist_id}","starred_url":"https://api.github.com/users/Griefman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Griefman/subscriptions","organizations_url":"https://api.github.com/users/Griefman/orgs","repos_url":"https://api.github.com/users/Griefman/repos","events_url":"https://api.github.com/users/Griefman/events{/privacy}","received_events_url":"https://api.github.com/users/Griefman/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Основное задание: начинаем методичную разметку личного проекта](https://up.htmlacademy.ru/adaptive/17/user/985489/tasks/2)","created_at":"2019-07-12T21:53:07Z","updated_at":"2019-07-13T06:11:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c32d0112f5d7c2fab6f640e290cdcea3c22eff75","assignee":{"login":"tati-simonenko","id":5658115,"node_id":"MDQ6VXNlcjU2NTgxMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5658115?v=4","gravatar_id":"","url":"https://api.github.com/users/tati-simonenko","html_url":"https://github.com/tati-simonenko","followers_url":"https://api.github.com/users/tati-simonenko/followers","following_url":"https://api.github.com/users/tati-simonenko/following{/other_user}","gists_url":"https://api.github.com/users/tati-simonenko/gists{/gist_id}","starred_url":"https://api.github.com/users/tati-simonenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tati-simonenko/subscriptions","organizations_url":"https://api.github.com/users/tati-simonenko/orgs","repos_url":"https://api.github.com/users/tati-simonenko/repos","events_url":"https://api.github.com/users/tati-simonenko/events{/privacy}","received_events_url":"https://api.github.com/users/tati-simonenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"tati-simonenko","id":5658115,"node_id":"MDQ6VXNlcjU2NTgxMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5658115?v=4","gravatar_id":"","url":"https://api.github.com/users/tati-simonenko","html_url":"https://github.com/tati-simonenko","followers_url":"https://api.github.com/users/tati-simonenko/followers","following_url":"https://api.github.com/users/tati-simonenko/following{/other_user}","gists_url":"https://api.github.com/users/tati-simonenko/gists{/gist_id}","starred_url":"https://api.github.com/users/tati-simonenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tati-simonenko/subscriptions","organizations_url":"https://api.github.com/users/tati-simonenko/orgs","repos_url":"https://api.github.com/users/tati-simonenko/repos","events_url":"https://api.github.com/users/tati-simonenko/events{/privacy}","received_events_url":"https://api.github.com/users/tati-simonenko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/3/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/3/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/issues/3/comments","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/statuses/dfb060f08633d4c797277382d03d7381dfacccc1","head":{"label":"Griefman:module2-task1","ref":"module2-task1","sha":"dfb060f08633d4c797277382d03d7381dfacccc1","user":{"login":"Griefman","id":24597900,"node_id":"MDQ6VXNlcjI0NTk3OTAw","avatar_url":"https://avatars0.githubusercontent.com/u/24597900?v=4","gravatar_id":"","url":"https://api.github.com/users/Griefman","html_url":"https://github.com/Griefman","followers_url":"https://api.github.com/users/Griefman/followers","following_url":"https://api.github.com/users/Griefman/following{/other_user}","gists_url":"https://api.github.com/users/Griefman/gists{/gist_id}","starred_url":"https://api.github.com/users/Griefman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Griefman/subscriptions","organizations_url":"https://api.github.com/users/Griefman/orgs","repos_url":"https://api.github.com/users/Griefman/repos","events_url":"https://api.github.com/users/Griefman/events{/privacy}","received_events_url":"https://api.github.com/users/Griefman/received_events","type":"User","site_admin":false},"repo":{"id":196562578,"node_id":"MDEwOlJlcG9zaXRvcnkxOTY1NjI1Nzg=","name":"985489-pink-17","full_name":"Griefman/985489-pink-17","private":false,"owner":{"login":"Griefman","id":24597900,"node_id":"MDQ6VXNlcjI0NTk3OTAw","avatar_url":"https://avatars0.githubusercontent.com/u/24597900?v=4","gravatar_id":"","url":"https://api.github.com/users/Griefman","html_url":"https://github.com/Griefman","followers_url":"https://api.github.com/users/Griefman/followers","following_url":"https://api.github.com/users/Griefman/following{/other_user}","gists_url":"https://api.github.com/users/Griefman/gists{/gist_id}","starred_url":"https://api.github.com/users/Griefman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Griefman/subscriptions","organizations_url":"https://api.github.com/users/Griefman/orgs","repos_url":"https://api.github.com/users/Griefman/repos","events_url":"https://api.github.com/users/Griefman/events{/privacy}","received_events_url":"https://api.github.com/users/Griefman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Griefman/985489-pink-17","description":"Станислав Паршин","fork":true,"url":"https://api.github.com/repos/Griefman/985489-pink-17","forks_url":"https://api.github.com/repos/Griefman/985489-pink-17/forks","keys_url":"https://api.github.com/repos/Griefman/985489-pink-17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Griefman/985489-pink-17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Griefman/985489-pink-17/teams","hooks_url":"https://api.github.com/repos/Griefman/985489-pink-17/hooks","issue_events_url":"https://api.github.com/repos/Griefman/985489-pink-17/issues/events{/number}","events_url":"https://api.github.com/repos/Griefman/985489-pink-17/events","assignees_url":"https://api.github.com/repos/Griefman/985489-pink-17/assignees{/user}","branches_url":"https://api.github.com/repos/Griefman/985489-pink-17/branches{/branch}","tags_url":"https://api.github.com/repos/Griefman/985489-pink-17/tags","blobs_url":"https://api.github.com/repos/Griefman/985489-pink-17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Griefman/985489-pink-17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Griefman/985489-pink-17/git/refs{/sha}","trees_url":"https://api.github.com/repos/Griefman/985489-pink-17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Griefman/985489-pink-17/statuses/{sha}","languages_url":"https://api.github.com/repos/Griefman/985489-pink-17/languages","stargazers_url":"https://api.github.com/repos/Griefman/985489-pink-17/stargazers","contributors_url":"https://api.github.com/repos/Griefman/985489-pink-17/contributors","subscribers_url":"https://api.github.com/repos/Griefman/985489-pink-17/subscribers","subscription_url":"https://api.github.com/repos/Griefman/985489-pink-17/subscription","commits_url":"https://api.github.com/repos/Griefman/985489-pink-17/commits{/sha}","git_commits_url":"https://api.github.com/repos/Griefman/985489-pink-17/git/commits{/sha}","comments_url":"https://api.github.com/repos/Griefman/985489-pink-17/comments{/number}","issue_comment_url":"https://api.github.com/repos/Griefman/985489-pink-17/issues/comments{/number}","contents_url":"https://api.github.com/repos/Griefman/985489-pink-17/contents/{+path}","compare_url":"https://api.github.com/repos/Griefman/985489-pink-17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Griefman/985489-pink-17/merges","archive_url":"https://api.github.com/repos/Griefman/985489-pink-17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Griefman/985489-pink-17/downloads","issues_url":"https://api.github.com/repos/Griefman/985489-pink-17/issues{/number}","pulls_url":"https://api.github.com/repos/Griefman/985489-pink-17/pulls{/number}","milestones_url":"https://api.github.com/repos/Griefman/985489-pink-17/milestones{/number}","notifications_url":"https://api.github.com/repos/Griefman/985489-pink-17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Griefman/985489-pink-17/labels{/name}","releases_url":"https://api.github.com/repos/Griefman/985489-pink-17/releases{/id}","deployments_url":"https://api.github.com/repos/Griefman/985489-pink-17/deployments","created_at":"2019-07-12T10:48:44Z","updated_at":"2019-07-12T10:48:47Z","pushed_at":"2019-07-12T21:52:29Z","git_url":"git://github.com/Griefman/985489-pink-17.git","ssh_url":"git@github.com:Griefman/985489-pink-17.git","clone_url":"https://github.com/Griefman/985489-pink-17.git","svn_url":"https://github.com/Griefman/985489-pink-17","homepage":"https://github.com/Griefman/985489-pink-17","size":49,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-adaptive:master","ref":"master","sha":"833ed909c00e38f29bcae8ddeba579e521be79b6","user":{"login":"htmlacademy-adaptive","id":9918669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTg2Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"repo":{"id":195894348,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU4OTQzNDg=","name":"985489-pink-17","full_name":"htmlacademy-adaptive/985489-pink-17","private":false,"owner":{"login":"htmlacademy-adaptive","id":9918669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTg2Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-adaptive/985489-pink-17","description":"Станислав Паршин","fork":false,"url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17","forks_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/forks","keys_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/teams","hooks_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/events","assignees_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/tags","blobs_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/subscription","commits_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/merges","archive_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/downloads","issues_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/deployments","created_at":"2019-07-08T22:29:20Z","updated_at":"2019-07-09T05:57:55Z","pushed_at":"2019-07-12T21:53:08Z","git_url":"git://github.com/htmlacademy-adaptive/985489-pink-17.git","ssh_url":"git@github.com:htmlacademy-adaptive/985489-pink-17.git","clone_url":"https://github.com/htmlacademy-adaptive/985489-pink-17.git","svn_url":"https://github.com/htmlacademy-adaptive/985489-pink-17","homepage":"https://github.com/Griefman/985489-pink-17","size":38,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/3"},"html":{"href":"https://github.com/htmlacademy-adaptive/985489-pink-17/pull/3"},"issue":{"href":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/issues/3"},"comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17/statuses/dfb060f08633d4c797277382d03d7381dfacccc1"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 195894348,
"name": "htmlacademy-adaptive/985489-pink-17",
"url": "https://api.github.com/repos/htmlacademy-adaptive/985489-pink-17"
}
|
{
"id": 5658115,
"login": "tati-simonenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5658115?",
"url": "https://api.github.com/users/tati-simonenko"
}
|
{
"id": 9918669,
"login": "htmlacademy-adaptive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9918669?",
"url": "https://api.github.com/orgs/htmlacademy-adaptive"
}
| 2019-07-13T06:11:05 |
10004631938
|
{"actor":{"display_login":"tati-simonenko"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/nodejs.org/pulls/comments/303237433","pull_request_review_id":261575790,"id":303237433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzIzNzQzMw==","diff_hunk":"@@ -0,0 +1,48 @@\n+---\n+title: الواجهة الثنائية للتطبيق\n+layout: docs.hbs\n+---\n+\n+# ثبات الواجهة الثنائية للتطبيق\n+\n+## مقدمة\n+تعتبر الواجهة الثنائية للتطبيق طريقة يمكن للبرامج من خلالها أن تستدعي دوال و تستعمل هياكل بيانات من برامج مفسرة أخرى. \n+فهي تعتبر النسخة المفسرة لواجهة برمجة تطبيق الخاصة برنامج ما. بعبارة أخرى، هي ترويسات الملفات التي تصف الكلاسات و الدوال \n+و هياكل البيانات و التعدادات إضافة إلى الثوابت التي تسمح لتطبيق بأن ينفذ مهمة مرغوبة استجابة لطريقة تفسير مجموعة من العناوين و قيم الإعدادات المتوقعة سلفاُ\n+إضافة إلى احجام هياكل الذاكرة و الأنساق التي بواسطتها تم تفسير مزود الواجهة الثنائية للتطبيق.\n+ \n+يجب على التطبيق الذي يستعمل الواجهة الثنائية للتطبيق أن يُفسر بطريقة تجعل العناوين و الإعدادات المتوقعة و أحجام هياكل الذاكرة و الأنساق متوافقة مع\n+تلك التي تم بواسطتها تفسير مزود الواجهة الثنئاية للتطبيق، ويتم تحقيق هذا عادة عبر التفسير باستخدام الترويس التي تم توفيرها من طرف مزود الواجهة الثنائية للتطبيق.\n+\n+\n+بما أن مزود الواجهة الثنائية للتطبيق و مستخدم الواجهة الثنائية للتطبيق قد يتم تفسيرهما في أوقات مختلفة باستعمال نسخ مفسرات مختلفة، فإن القطعة المسؤولة عن","path":"locale/ar/docs/guides/abi-stability.md","position":18,"original_position":18,"commit_id":"65bdaff855916993da2f3f4e4ab0636649bde6f1","original_commit_id":"8ed0e114f1eb1e2512e43ba9ff0296553ee23692","user":{"login":"Aissaoui-Ahmed","id":20658625,"node_id":"MDQ6VXNlcjIwNjU4NjI1","avatar_url":"https://avatars3.githubusercontent.com/u/20658625?v=4","gravatar_id":"","url":"https://api.github.com/users/Aissaoui-Ahmed","html_url":"https://github.com/Aissaoui-Ahmed","followers_url":"https://api.github.com/users/Aissaoui-Ahmed/followers","following_url":"https://api.github.com/users/Aissaoui-Ahmed/following{/other_user}","gists_url":"https://api.github.com/users/Aissaoui-Ahmed/gists{/gist_id}","starred_url":"https://api.github.com/users/Aissaoui-Ahmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aissaoui-Ahmed/subscriptions","organizations_url":"https://api.github.com/users/Aissaoui-Ahmed/orgs","repos_url":"https://api.github.com/users/Aissaoui-Ahmed/repos","events_url":"https://api.github.com/users/Aissaoui-Ahmed/events{/privacy}","received_events_url":"https://api.github.com/users/Aissaoui-Ahmed/received_events","type":"User","site_admin":false},"body":"ABI ?","created_at":"2019-07-14T10:29:21Z","updated_at":"2019-07-14T10:29:21Z","html_url":"https://github.com/nodejs/nodejs.org/pull/2330#discussion_r303237433","pull_request_url":"https://api.github.com/repos/nodejs/nodejs.org/pulls/2330","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/nodejs.org/pulls/comments/303237433"},"html":{"href":"https://github.com/nodejs/nodejs.org/pull/2330#discussion_r303237433"},"pull_request":{"href":"https://api.github.com/repos/nodejs/nodejs.org/pulls/2330"}},"in_reply_to_id":303013287},"pull_request":{"url":"https://api.github.com/repos/nodejs/nodejs.org/pulls/2330","id":297087112,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MDg3MTEy","html_url":"https://github.com/nodejs/nodejs.org/pull/2330","diff_url":"https://github.com/nodejs/nodejs.org/pull/2330.diff","patch_url":"https://github.com/nodejs/nodejs.org/pull/2330.patch","issue_url":"https://api.github.com/repos/nodejs/nodejs.org/issues/2330","number":2330,"state":"open","locked":false,"title":"AR : docs/guides/abi-stability.md","user":{"login":"celyes","id":21331907,"node_id":"MDQ6VXNlcjIxMzMxOTA3","avatar_url":"https://avatars0.githubusercontent.com/u/21331907?v=4","gravatar_id":"","url":"https://api.github.com/users/celyes","html_url":"https://github.com/celyes","followers_url":"https://api.github.com/users/celyes/followers","following_url":"https://api.github.com/users/celyes/following{/other_user}","gists_url":"https://api.github.com/users/celyes/gists{/gist_id}","starred_url":"https://api.github.com/users/celyes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celyes/subscriptions","organizations_url":"https://api.github.com/users/celyes/orgs","repos_url":"https://api.github.com/users/celyes/repos","events_url":"https://api.github.com/users/celyes/events{/privacy}","received_events_url":"https://api.github.com/users/celyes/received_events","type":"User","site_admin":false},"body":"Translated file: `abi-stability.md` found in `ar/docs/guides/abi-stability.md`\r\n\r\n@Aissaoui-Ahmed \r\n@MaledongGit\r\n@Softvenue","created_at":"2019-07-12T14:08:05Z","updated_at":"2019-07-14T10:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e5bd33245f3befa0e1d643c633ba4f478fac686","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":226550950,"node_id":"MDU6TGFiZWwyMjY1NTA5NTA=","url":"https://api.github.com/repos/nodejs/nodejs.org/labels/i18n","name":"i18n","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/nodejs.org/pulls/2330/commits","review_comments_url":"https://api.github.com/repos/nodejs/nodejs.org/pulls/2330/comments","review_comment_url":"https://api.github.com/repos/nodejs/nodejs.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/nodejs.org/issues/2330/comments","statuses_url":"https://api.github.com/repos/nodejs/nodejs.org/statuses/65bdaff855916993da2f3f4e4ab0636649bde6f1","head":{"label":"softvenue:master","ref":"master","sha":"65bdaff855916993da2f3f4e4ab0636649bde6f1","user":{"login":"softvenue","id":46533767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NTMzNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/46533767?v=4","gravatar_id":"","url":"https://api.github.com/users/softvenue","html_url":"https://github.com/softvenue","followers_url":"https://api.github.com/users/softvenue/followers","following_url":"https://api.github.com/users/softvenue/following{/other_user}","gists_url":"https://api.github.com/users/softvenue/gists{/gist_id}","starred_url":"https://api.github.com/users/softvenue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softvenue/subscriptions","organizations_url":"https://api.github.com/users/softvenue/orgs","repos_url":"https://api.github.com/users/softvenue/repos","events_url":"https://api.github.com/users/softvenue/events{/privacy}","received_events_url":"https://api.github.com/users/softvenue/received_events","type":"Organization","site_admin":false},"repo":{"id":162502255,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI1MDIyNTU=","name":"nodejs","full_name":"softvenue/nodejs","private":false,"owner":{"login":"softvenue","id":46533767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NTMzNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/46533767?v=4","gravatar_id":"","url":"https://api.github.com/users/softvenue","html_url":"https://github.com/softvenue","followers_url":"https://api.github.com/users/softvenue/followers","following_url":"https://api.github.com/users/softvenue/following{/other_user}","gists_url":"https://api.github.com/users/softvenue/gists{/gist_id}","starred_url":"https://api.github.com/users/softvenue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softvenue/subscriptions","organizations_url":"https://api.github.com/users/softvenue/orgs","repos_url":"https://api.github.com/users/softvenue/repos","events_url":"https://api.github.com/users/softvenue/events{/privacy}","received_events_url":"https://api.github.com/users/softvenue/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/softvenue/nodejs","description":"The Node.js website in Arabic","fork":true,"url":"https://api.github.com/repos/softvenue/nodejs","forks_url":"https://api.github.com/repos/softvenue/nodejs/forks","keys_url":"https://api.github.com/repos/softvenue/nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softvenue/nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softvenue/nodejs/teams","hooks_url":"https://api.github.com/repos/softvenue/nodejs/hooks","issue_events_url":"https://api.github.com/repos/softvenue/nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/softvenue/nodejs/events","assignees_url":"https://api.github.com/repos/softvenue/nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/softvenue/nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/softvenue/nodejs/tags","blobs_url":"https://api.github.com/repos/softvenue/nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softvenue/nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softvenue/nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/softvenue/nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softvenue/nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/softvenue/nodejs/languages","stargazers_url":"https://api.github.com/repos/softvenue/nodejs/stargazers","contributors_url":"https://api.github.com/repos/softvenue/nodejs/contributors","subscribers_url":"https://api.github.com/repos/softvenue/nodejs/subscribers","subscription_url":"https://api.github.com/repos/softvenue/nodejs/subscription","commits_url":"https://api.github.com/repos/softvenue/nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/softvenue/nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/softvenue/nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/softvenue/nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/softvenue/nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/softvenue/nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softvenue/nodejs/merges","archive_url":"https://api.github.com/repos/softvenue/nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softvenue/nodejs/downloads","issues_url":"https://api.github.com/repos/softvenue/nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/softvenue/nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/softvenue/nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/softvenue/nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softvenue/nodejs/labels{/name}","releases_url":"https://api.github.com/repos/softvenue/nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/softvenue/nodejs/deployments","created_at":"2018-12-19T23:35:30Z","updated_at":"2019-07-13T19:16:59Z","pushed_at":"2019-07-14T08:39:32Z","git_url":"git://github.com/softvenue/nodejs.git","ssh_url":"git@github.com:softvenue/nodejs.git","clone_url":"https://github.com/softvenue/nodejs.git","svn_url":"https://github.com/softvenue/nodejs","homepage":"https://nodejs.org/ar","size":54793,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"f7a6bfd3498d7e58af8d8f546ec7d536772791f5","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":37717474,"node_id":"MDEwOlJlcG9zaXRvcnkzNzcxNzQ3NA==","name":"nodejs.org","full_name":"nodejs/nodejs.org","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/nodejs.org","description":"The Node.js website.","fork":false,"url":"https://api.github.com/repos/nodejs/nodejs.org","forks_url":"https://api.github.com/repos/nodejs/nodejs.org/forks","keys_url":"https://api.github.com/repos/nodejs/nodejs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/nodejs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/nodejs.org/teams","hooks_url":"https://api.github.com/repos/nodejs/nodejs.org/hooks","issue_events_url":"https://api.github.com/repos/nodejs/nodejs.org/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/nodejs.org/events","assignees_url":"https://api.github.com/repos/nodejs/nodejs.org/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/nodejs.org/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/nodejs.org/tags","blobs_url":"https://api.github.com/repos/nodejs/nodejs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/nodejs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/nodejs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/nodejs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/nodejs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/nodejs.org/languages","stargazers_url":"https://api.github.com/repos/nodejs/nodejs.org/stargazers","contributors_url":"https://api.github.com/repos/nodejs/nodejs.org/contributors","subscribers_url":"https://api.github.com/repos/nodejs/nodejs.org/subscribers","subscription_url":"https://api.github.com/repos/nodejs/nodejs.org/subscription","commits_url":"https://api.github.com/repos/nodejs/nodejs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/nodejs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/nodejs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/nodejs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/nodejs.org/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/nodejs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/nodejs.org/merges","archive_url":"https://api.github.com/repos/nodejs/nodejs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/nodejs.org/downloads","issues_url":"https://api.github.com/repos/nodejs/nodejs.org/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/nodejs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/nodejs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/nodejs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/nodejs.org/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/nodejs.org/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/nodejs.org/deployments","created_at":"2015-06-19T11:05:10Z","updated_at":"2019-07-14T03:27:40Z","pushed_at":"2019-07-14T08:18:05Z","git_url":"git://github.com/nodejs/nodejs.org.git","ssh_url":"git@github.com:nodejs/nodejs.org.git","clone_url":"https://github.com/nodejs/nodejs.org.git","svn_url":"https://github.com/nodejs/nodejs.org","homepage":"https://nodejs.org","size":54650,"stargazers_count":1217,"watchers_count":1217,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1938,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1938,"open_issues":41,"watchers":1217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/nodejs.org/pulls/2330"},"html":{"href":"https://github.com/nodejs/nodejs.org/pull/2330"},"issue":{"href":"https://api.github.com/repos/nodejs/nodejs.org/issues/2330"},"comments":{"href":"https://api.github.com/repos/nodejs/nodejs.org/issues/2330/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/nodejs.org/pulls/2330/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/nodejs.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/nodejs.org/pulls/2330/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/nodejs.org/statuses/65bdaff855916993da2f3f4e4ab0636649bde6f1"}},"author_association":"MEMBER"}}
|
{
"id": 37717474,
"name": "nodejs/nodejs.org",
"url": "https://api.github.com/repos/nodejs/nodejs.org"
}
|
{
"id": 20658625,
"login": "Aissaoui-Ahmed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20658625?",
"url": "https://api.github.com/users/Aissaoui-Ahmed"
}
|
{
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
}
| 2019-07-14T10:29:21 |
10007400954
|
{"actor":{"display_login":"Aissaoui-Ahmed"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/341869901","pull_request_review_id":310836698,"id":341869901,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTg2OTkwMQ==","diff_hunk":"@@ -146,7 +146,11 @@ platforms. This is true regardless of entries in the table below.\n systems. Issues that only reproduce on WSL should be reported in the\n [WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the\n Windows binary (`node.exe`) in WSL is not recommended. It will not work\n- without workarounds such as stdio redirection.\n+ without workarounds such as stdio redirection. \n+ If you run into a `No module named 'distutils.spawn'` error when executing\n+ `./configure`, please try `python3 -m pip install --upgrade setuptools` or\n+ `sudo apt install python3-distutils -y`.\n+ For more information, see https://github.com/nodejs/node/issues/30189.","path":"BUILDING.md","position":9,"original_position":9,"commit_id":"a62ac2838671bc85894f71cc6d5319a8f08af396","original_commit_id":"a62ac2838671bc85894f71cc6d5319a8f08af396","user":{"login":"richardlau","id":5445507,"node_id":"MDQ6VXNlcjU0NDU1MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5445507?v=4","gravatar_id":"","url":"https://api.github.com/users/richardlau","html_url":"https://github.com/richardlau","followers_url":"https://api.github.com/users/richardlau/followers","following_url":"https://api.github.com/users/richardlau/following{/other_user}","gists_url":"https://api.github.com/users/richardlau/gists{/gist_id}","starred_url":"https://api.github.com/users/richardlau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardlau/subscriptions","organizations_url":"https://api.github.com/users/richardlau/orgs","repos_url":"https://api.github.com/users/richardlau/repos","events_url":"https://api.github.com/users/richardlau/events{/privacy}","received_events_url":"https://api.github.com/users/richardlau/received_events","type":"User","site_admin":false},"body":"Right, but this change is currently in the WSL notes. Maybe it should be moved to either the section about Python 2 and 3 or moved into its own section.","created_at":"2019-11-03T20:10:57Z","updated_at":"2019-11-03T20:10:57Z","html_url":"https://github.com/nodejs/node/pull/30221#discussion_r341869901","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/30221","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/341869901"},"html":{"href":"https://github.com/nodejs/node/pull/30221#discussion_r341869901"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/30221"}},"in_reply_to_id":341865512},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/30221","id":335853585,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM1ODUzNTg1","html_url":"https://github.com/nodejs/node/pull/30221","diff_url":"https://github.com/nodejs/node/pull/30221.diff","patch_url":"https://github.com/nodejs/node/pull/30221.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/30221","number":30221,"state":"open","locked":false,"title":"build: add workaround for No module named 'distutils.spawn'","user":{"login":"gengjiawen","id":3759816,"node_id":"MDQ6VXNlcjM3NTk4MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3759816?v=4","gravatar_id":"","url":"https://api.github.com/users/gengjiawen","html_url":"https://github.com/gengjiawen","followers_url":"https://api.github.com/users/gengjiawen/followers","following_url":"https://api.github.com/users/gengjiawen/following{/other_user}","gists_url":"https://api.github.com/users/gengjiawen/gists{/gist_id}","starred_url":"https://api.github.com/users/gengjiawen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gengjiawen/subscriptions","organizations_url":"https://api.github.com/users/gengjiawen/orgs","repos_url":"https://api.github.com/users/gengjiawen/repos","events_url":"https://api.github.com/users/gengjiawen/events{/privacy}","received_events_url":"https://api.github.com/users/gengjiawen/received_events","type":"User","site_admin":false},"body":"Fix: #30189 \r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n<!--\r\nDeveloper's Certificate of Origin 1.1\r\n\r\nBy making a contribution to this project, I certify that:\r\n\r\n(a) The contribution was created in whole or in part by me and I\r\n have the right to submit it under the open source license\r\n indicated in the file; or\r\n\r\n(b) The contribution is based upon previous work that, to the best\r\n of my knowledge, is covered under an appropriate open source\r\n license and I have the right under that license to submit that\r\n work with modifications, whether created in whole or in part\r\n by me, under the same open source license (unless I am\r\n permitted to submit under a different license), as indicated\r\n in the file; or\r\n\r\n(c) The contribution was provided directly to me by some other\r\n person who certified (a), (b) or (c) and I have not modified\r\n it.\r\n\r\n(d) I understand and agree that this project and the contribution\r\n are public and that a record of the contribution (including all\r\n personal information I submit with it, including my sign-off) is\r\n maintained indefinitely and may be redistributed consistent with\r\n this project or the open source license(s) involved.\r\n-->\r\n","created_at":"2019-11-02T14:54:35Z","updated_at":"2019-11-03T20:10:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bf35b9204993d5cfcb8d2c579f5476c9c07d16f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"guybedford","id":598730,"node_id":"MDQ6VXNlcjU5ODczMA==","avatar_url":"https://avatars1.githubusercontent.com/u/598730?v=4","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":654000151,"node_id":"MDU6TGFiZWw2NTQwMDAxNTE=","url":"https://api.github.com/repos/nodejs/node/labels/Python","name":"Python","color":"c2e0c6","default":false},{"id":171787391,"node_id":"MDU6TGFiZWwxNzE3ODczOTE=","url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/30221/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/30221/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/30221/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/a62ac2838671bc85894f71cc6d5319a8f08af396","head":{"label":"gengjiawen:doc/wsl","ref":"doc/wsl","sha":"a62ac2838671bc85894f71cc6d5319a8f08af396","user":{"login":"gengjiawen","id":3759816,"node_id":"MDQ6VXNlcjM3NTk4MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3759816?v=4","gravatar_id":"","url":"https://api.github.com/users/gengjiawen","html_url":"https://github.com/gengjiawen","followers_url":"https://api.github.com/users/gengjiawen/followers","following_url":"https://api.github.com/users/gengjiawen/following{/other_user}","gists_url":"https://api.github.com/users/gengjiawen/gists{/gist_id}","starred_url":"https://api.github.com/users/gengjiawen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gengjiawen/subscriptions","organizations_url":"https://api.github.com/users/gengjiawen/orgs","repos_url":"https://api.github.com/users/gengjiawen/repos","events_url":"https://api.github.com/users/gengjiawen/events{/privacy}","received_events_url":"https://api.github.com/users/gengjiawen/received_events","type":"User","site_admin":false},"repo":{"id":118342954,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgzNDI5NTQ=","name":"node","full_name":"gengjiawen/node","private":false,"owner":{"login":"gengjiawen","id":3759816,"node_id":"MDQ6VXNlcjM3NTk4MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3759816?v=4","gravatar_id":"","url":"https://api.github.com/users/gengjiawen","html_url":"https://github.com/gengjiawen","followers_url":"https://api.github.com/users/gengjiawen/followers","following_url":"https://api.github.com/users/gengjiawen/following{/other_user}","gists_url":"https://api.github.com/users/gengjiawen/gists{/gist_id}","starred_url":"https://api.github.com/users/gengjiawen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gengjiawen/subscriptions","organizations_url":"https://api.github.com/users/gengjiawen/orgs","repos_url":"https://api.github.com/users/gengjiawen/repos","events_url":"https://api.github.com/users/gengjiawen/events{/privacy}","received_events_url":"https://api.github.com/users/gengjiawen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gengjiawen/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/gengjiawen/node","forks_url":"https://api.github.com/repos/gengjiawen/node/forks","keys_url":"https://api.github.com/repos/gengjiawen/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gengjiawen/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gengjiawen/node/teams","hooks_url":"https://api.github.com/repos/gengjiawen/node/hooks","issue_events_url":"https://api.github.com/repos/gengjiawen/node/issues/events{/number}","events_url":"https://api.github.com/repos/gengjiawen/node/events","assignees_url":"https://api.github.com/repos/gengjiawen/node/assignees{/user}","branches_url":"https://api.github.com/repos/gengjiawen/node/branches{/branch}","tags_url":"https://api.github.com/repos/gengjiawen/node/tags","blobs_url":"https://api.github.com/repos/gengjiawen/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gengjiawen/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gengjiawen/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/gengjiawen/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gengjiawen/node/statuses/{sha}","languages_url":"https://api.github.com/repos/gengjiawen/node/languages","stargazers_url":"https://api.github.com/repos/gengjiawen/node/stargazers","contributors_url":"https://api.github.com/repos/gengjiawen/node/contributors","subscribers_url":"https://api.github.com/repos/gengjiawen/node/subscribers","subscription_url":"https://api.github.com/repos/gengjiawen/node/subscription","commits_url":"https://api.github.com/repos/gengjiawen/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/gengjiawen/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/gengjiawen/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/gengjiawen/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/gengjiawen/node/contents/{+path}","compare_url":"https://api.github.com/repos/gengjiawen/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gengjiawen/node/merges","archive_url":"https://api.github.com/repos/gengjiawen/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gengjiawen/node/downloads","issues_url":"https://api.github.com/repos/gengjiawen/node/issues{/number}","pulls_url":"https://api.github.com/repos/gengjiawen/node/pulls{/number}","milestones_url":"https://api.github.com/repos/gengjiawen/node/milestones{/number}","notifications_url":"https://api.github.com/repos/gengjiawen/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gengjiawen/node/labels{/name}","releases_url":"https://api.github.com/repos/gengjiawen/node/releases{/id}","deployments_url":"https://api.github.com/repos/gengjiawen/node/deployments","created_at":"2018-01-21T14:38:59Z","updated_at":"2019-02-15T14:10:25Z","pushed_at":"2019-11-03T17:23:54Z","git_url":"git://github.com/gengjiawen/node.git","ssh_url":"git@github.com:gengjiawen/node.git","clone_url":"https://github.com/gengjiawen/node.git","svn_url":"https://github.com/gengjiawen/node","homepage":"https://nodejs.org","size":475794,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"3a076bae9c256a830353cf47170599d30baa6c1b","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2019-11-03T19:38:07Z","pushed_at":"2019-11-03T19:49:09Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org/","size":508958,"stargazers_count":65394,"watchers_count":65394,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15247,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1141,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15247,"open_issues":1141,"watchers":65394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/30221"},"html":{"href":"https://github.com/nodejs/node/pull/30221"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/30221"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/30221/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/30221/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/30221/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/a62ac2838671bc85894f71cc6d5319a8f08af396"}},"author_association":"MEMBER"}}
|
{
"id": 27193779,
"name": "nodejs/node",
"url": "https://api.github.com/repos/nodejs/node"
}
|
{
"id": 5445507,
"login": "richardlau",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5445507?",
"url": "https://api.github.com/users/richardlau"
}
|
{
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
}
| 2019-11-03T20:10:57 |
10776342357
|
{"actor":{"display_login":"richardlau"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/mesh/pulls/comments/330571674","pull_request_review_id":296267946,"id":330571674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMDU3MTY3NA==","diff_hunk":"@@ -229,14 +229,19 @@ func (router *Router) sendPendingGossip() bool {\n \treturn sentSomething\n }\n \n-// BroadcastTopologyUpdate is invoked whenever there is a change to the mesh\n-// topology, and broadcasts the new set of peers to the mesh.\n-func (router *Router) broadcastTopologyUpdate(update []*Peer) {\n-\tnames := make(peerNameSet)\n-\tfor _, p := range update {\n-\t\tnames[p.Name] = struct{}{}\n+// BroadcastTopologyUpdate is invoked whenever there is one or more changes to the mesh\n+// topology, and broadcasts the new set of peers to the mesh after coalescing updates.\n+func (router *Router) broadcastTopologyUpdate(updates ...[]*Peer) {\n+\tvar gossipData GossipData\n+\tgossipData = &topologyGossipData{peers: router.Peers, update: nil}\n+\tfor _, update := range updates {\n+\t\tnames := make(peerNameSet)\n+\t\tfor _, p := range update {\n+\t\t\tnames[p.Name] = struct{}{}\n+\t\t}\n+\t\tgossipData = gossipData.Merge(&topologyGossipData{peers: router.Peers, update: names})","path":"router.go","position":20,"original_position":20,"commit_id":"fcec563094330b8960bc714f8151a0baaf930906","original_commit_id":"fcec563094330b8960bc714f8151a0baaf930906","user":{"login":"bboreham","id":8125524,"node_id":"MDQ6VXNlcjgxMjU1MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8125524?v=4","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"body":"This seems unnecessary - all this `Merge` does is union the two maps, so we can just build up one set then send that at the end.\r\n\r\n","created_at":"2019-10-02T14:10:32Z","updated_at":"2019-10-02T14:24:23Z","html_url":"https://github.com/weaveworks/mesh/pull/117#discussion_r330571674","pull_request_url":"https://api.github.com/repos/weaveworks/mesh/pulls/117","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/mesh/pulls/comments/330571674"},"html":{"href":"https://github.com/weaveworks/mesh/pull/117#discussion_r330571674"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/mesh/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/mesh/pulls/117","id":318619828,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4NjE5ODI4","html_url":"https://github.com/weaveworks/mesh/pull/117","diff_url":"https://github.com/weaveworks/mesh/pull/117.diff","patch_url":"https://github.com/weaveworks/mesh/pull/117.patch","issue_url":"https://api.github.com/repos/weaveworks/mesh/issues/117","number":117,"state":"open","locked":false,"title":"serialize broadcast topology updates and coalesce updates","user":{"login":"murali-reddy","id":2202956,"node_id":"MDQ6VXNlcjIyMDI5NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2202956?v=4","gravatar_id":"","url":"https://api.github.com/users/murali-reddy","html_url":"https://github.com/murali-reddy","followers_url":"https://api.github.com/users/murali-reddy/followers","following_url":"https://api.github.com/users/murali-reddy/following{/other_user}","gists_url":"https://api.github.com/users/murali-reddy/gists{/gist_id}","starred_url":"https://api.github.com/users/murali-reddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murali-reddy/subscriptions","organizations_url":"https://api.github.com/users/murali-reddy/orgs","repos_url":"https://api.github.com/users/murali-reddy/repos","events_url":"https://api.github.com/users/murali-reddy/events{/privacy}","received_events_url":"https://api.github.com/users/murali-reddy/received_events","type":"User","site_admin":false},"body":"This PR is an attempt to address high topology updates gossip's that can result in certain use-cases.\r\n\r\n- minimizes the concurrent topology gossip broadcast updates\r\n- coalesce the topology updates when possible before sending gossip broadcast\r\n\r\nFixes #116","created_at":"2019-09-18T04:16:30Z","updated_at":"2019-10-02T14:24:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"144585b5ffd464a139f0080164740ea32ad1d046","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/mesh/pulls/117/commits","review_comments_url":"https://api.github.com/repos/weaveworks/mesh/pulls/117/comments","review_comment_url":"https://api.github.com/repos/weaveworks/mesh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/mesh/issues/117/comments","statuses_url":"https://api.github.com/repos/weaveworks/mesh/statuses/fcec563094330b8960bc714f8151a0baaf930906","head":{"label":"weaveworks:coalesce-topology-updates","ref":"coalesce-topology-updates","sha":"fcec563094330b8960bc714f8151a0baaf930906","user":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":49562556,"node_id":"MDEwOlJlcG9zaXRvcnk0OTU2MjU1Ng==","name":"mesh","full_name":"weaveworks/mesh","private":false,"owner":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/weaveworks/mesh","description":"A tool for building distributed applications.","fork":false,"url":"https://api.github.com/repos/weaveworks/mesh","forks_url":"https://api.github.com/repos/weaveworks/mesh/forks","keys_url":"https://api.github.com/repos/weaveworks/mesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/mesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/mesh/teams","hooks_url":"https://api.github.com/repos/weaveworks/mesh/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/mesh/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/mesh/events","assignees_url":"https://api.github.com/repos/weaveworks/mesh/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/mesh/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/mesh/tags","blobs_url":"https://api.github.com/repos/weaveworks/mesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/mesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/mesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/mesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/mesh/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/mesh/languages","stargazers_url":"https://api.github.com/repos/weaveworks/mesh/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/mesh/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/mesh/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/mesh/subscription","commits_url":"https://api.github.com/repos/weaveworks/mesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/mesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/mesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/mesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/mesh/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/mesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/mesh/merges","archive_url":"https://api.github.com/repos/weaveworks/mesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/mesh/downloads","issues_url":"https://api.github.com/repos/weaveworks/mesh/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/mesh/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/mesh/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/mesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/mesh/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/mesh/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/mesh/deployments","created_at":"2016-01-13T09:10:24Z","updated_at":"2019-09-30T02:32:20Z","pushed_at":"2019-10-02T08:03:17Z","git_url":"git://github.com/weaveworks/mesh.git","ssh_url":"git@github.com:weaveworks/mesh.git","clone_url":"https://github.com/weaveworks/mesh.git","svn_url":"https://github.com/weaveworks/mesh","homepage":null,"size":302,"stargazers_count":553,"watchers_count":553,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":34,"watchers":553,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"b7aea39ecc405bc9a791f96312eca9fd0f328513","user":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":49562556,"node_id":"MDEwOlJlcG9zaXRvcnk0OTU2MjU1Ng==","name":"mesh","full_name":"weaveworks/mesh","private":false,"owner":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/weaveworks/mesh","description":"A tool for building distributed applications.","fork":false,"url":"https://api.github.com/repos/weaveworks/mesh","forks_url":"https://api.github.com/repos/weaveworks/mesh/forks","keys_url":"https://api.github.com/repos/weaveworks/mesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/mesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/mesh/teams","hooks_url":"https://api.github.com/repos/weaveworks/mesh/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/mesh/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/mesh/events","assignees_url":"https://api.github.com/repos/weaveworks/mesh/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/mesh/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/mesh/tags","blobs_url":"https://api.github.com/repos/weaveworks/mesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/mesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/mesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/mesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/mesh/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/mesh/languages","stargazers_url":"https://api.github.com/repos/weaveworks/mesh/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/mesh/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/mesh/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/mesh/subscription","commits_url":"https://api.github.com/repos/weaveworks/mesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/mesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/mesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/mesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/mesh/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/mesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/mesh/merges","archive_url":"https://api.github.com/repos/weaveworks/mesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/mesh/downloads","issues_url":"https://api.github.com/repos/weaveworks/mesh/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/mesh/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/mesh/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/mesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/mesh/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/mesh/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/mesh/deployments","created_at":"2016-01-13T09:10:24Z","updated_at":"2019-09-30T02:32:20Z","pushed_at":"2019-10-02T08:03:17Z","git_url":"git://github.com/weaveworks/mesh.git","ssh_url":"git@github.com:weaveworks/mesh.git","clone_url":"https://github.com/weaveworks/mesh.git","svn_url":"https://github.com/weaveworks/mesh","homepage":null,"size":302,"stargazers_count":553,"watchers_count":553,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":34,"watchers":553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/mesh/pulls/117"},"html":{"href":"https://github.com/weaveworks/mesh/pull/117"},"issue":{"href":"https://api.github.com/repos/weaveworks/mesh/issues/117"},"comments":{"href":"https://api.github.com/repos/weaveworks/mesh/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/mesh/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/mesh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/mesh/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/mesh/statuses/fcec563094330b8960bc714f8151a0baaf930906"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 49562556,
"name": "weaveworks/mesh",
"url": "https://api.github.com/repos/weaveworks/mesh"
}
|
{
"id": 8125524,
"login": "bboreham",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8125524?",
"url": "https://api.github.com/users/bboreham"
}
|
{
"id": 9976052,
"login": "weaveworks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9976052?",
"url": "https://api.github.com/orgs/weaveworks"
}
| 2019-10-02T14:10:32 |
10543101903
|
{"actor":{"display_login":"bboreham"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/256644565","pull_request_review_id":203514806,"id":256644565,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjY0NDU2NQ==","diff_hunk":"@@ -102,6 +102,22 @@\n \tfor(var/i = 1, i <= created_volume, i++)\n \t\tnew /obj/item/reagent_containers/food/snacks/dough(location)\n \n+///Cookies by Ume\n+\n+/datum/chemical_reaction/cookiedough\n+\tname = \"Dough\"\n+\tid = \"dough\"\n+\tresult = null\n+\trequired_reagents = list(\"milk\" = 10, \"flour\" = 10, \"sugar\" = 5)","path":"code/modules/reagents/chemistry/recipes/food.dm","position":10,"original_position":10,"commit_id":"c72a623ec604840a1a1cd53f757c9d14084ce428","original_commit_id":"a77ca7dd5c4d7f144560b262faf395ccf731c832","user":{"login":"UmeFuu","id":35434208,"node_id":"MDQ6VXNlcjM1NDM0MjA4","avatar_url":"https://avatars3.githubusercontent.com/u/35434208?v=4","gravatar_id":"","url":"https://api.github.com/users/UmeFuu","html_url":"https://github.com/UmeFuu","followers_url":"https://api.github.com/users/UmeFuu/followers","following_url":"https://api.github.com/users/UmeFuu/following{/other_user}","gists_url":"https://api.github.com/users/UmeFuu/gists{/gist_id}","starred_url":"https://api.github.com/users/UmeFuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmeFuu/subscriptions","organizations_url":"https://api.github.com/users/UmeFuu/orgs","repos_url":"https://api.github.com/users/UmeFuu/repos","events_url":"https://api.github.com/users/UmeFuu/events{/privacy}","received_events_url":"https://api.github.com/users/UmeFuu/received_events","type":"User","site_admin":false},"body":"\"Bake 10u Flour, 1 Egg, 5u Sugar, 5u Milk, 1 Golden Apple\" the quantities are below the pastry dough reaction, and the apple tart as a baked recipe, none of them interfere with the other. I was thinking about adding the 5u egg, but if I want to make a chocolate flavored pastry dough, it would interfere with the chocolate pudding recipe. I'll think about it later on.\r\n\r\n\r\n\r\n","created_at":"2019-02-14T00:14:00Z","updated_at":"2019-02-14T00:14:01Z","html_url":"https://github.com/ParadiseSS13/Paradise/pull/10892#discussion_r256644565","pull_request_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/10892","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/256644565"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/10892#discussion_r256644565"},"pull_request":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/10892"}},"in_reply_to_id":256431806},"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/10892","id":252550766,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyNTUwNzY2","html_url":"https://github.com/ParadiseSS13/Paradise/pull/10892","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/10892.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/10892.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/10892","number":10892,"state":"open","locked":false,"title":"New cookies recipe (previous one was a bit silly)","user":{"login":"UmeFuu","id":35434208,"node_id":"MDQ6VXNlcjM1NDM0MjA4","avatar_url":"https://avatars3.githubusercontent.com/u/35434208?v=4","gravatar_id":"","url":"https://api.github.com/users/UmeFuu","html_url":"https://github.com/UmeFuu","followers_url":"https://api.github.com/users/UmeFuu/followers","following_url":"https://api.github.com/users/UmeFuu/following{/other_user}","gists_url":"https://api.github.com/users/UmeFuu/gists{/gist_id}","starred_url":"https://api.github.com/users/UmeFuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmeFuu/subscriptions","organizations_url":"https://api.github.com/users/UmeFuu/orgs","repos_url":"https://api.github.com/users/UmeFuu/repos","events_url":"https://api.github.com/users/UmeFuu/events{/privacy}","received_events_url":"https://api.github.com/users/UmeFuu/received_events","type":"User","site_admin":false},"body":"**What does this PR do:**\r\nThe previous cookie recipe was 1 dough + 1 chocolate bar, throw that in the oven and voilá!\r\nThis one adds a new dough specially made for cookies (yum) and some more simple steps before the oven.\r\n\r\nChocolate crumbles/pile of chocolate: Just cut a chocolate bar into pieces.\r\nCreate the dough: mix 10u of milk, 10u of flour and 5u of sugar. You'll get cookie dough!\r\nFlatten the dough using the rolling pin (duh) and then cut perfect circles with the new circular cutter™.\r\nAdd the unbaked cookies to the oven, and you'll get six perfect sugar cookies.\r\nOptionally, if you add a chocolate pile to the cookies before putting them into the oven, you'll get six chocolate chips cookies! (Just the regular cookies)\r\n\r\n**I illustrated this really complex process just for you:**\r\n\r\n---------------------\r\nEdit: Now with (optional) choco chips \r\n\r\n\r\n\r\n**Changelog:**\r\n:cl:\r\nadd: New recipe for cookies and sugar cookies, new ingredients such as cookie dough, flat cookie dough, unbaked cookies and a new tool called circular cutter (Added to the dinnerware vendor). New chem mix to create a specific type of dough for cookies,\r\n\r\ndel: Removed old cookie/sugarcookie recipe\r\n\r\ntweak: added reagents of the cookies (They now actually taste like sugar and chocolate):\r\n- sugar = 3\r\n- hot_coco = 5\r\n\r\nAlso adjusted the sugar cookies nutriment from 3 to 1, just like chocolate cookies (They're made of the same dough after all)\r\nChocolate bar can now be cutted into pieces/chocolate pile\r\n\r\nimageadd: added cookie dough, flat cookie dough, unbaked cookies/choco and circular cutter sprites. \r\n(Disclaimer: The cookie dough and flat cookie dough are edits of the normal doughs, pretty obvious but credits to who sprited them. Same with the tray with the unbaked cookies)\r\n/:cl:\r\n\r\n","created_at":"2019-02-13T03:37:20Z","updated_at":"2019-02-14T00:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de4c30ed72ed5eba06bd276d55915978ef45ca39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":176235380,"node_id":"MDU6TGFiZWwxNzYyMzUzODA=","url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels/Feature","name":"Feature","color":"26A726","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/10892/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/10892/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/10892/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/c72a623ec604840a1a1cd53f757c9d14084ce428","head":{"label":"UmeFuu:master","ref":"master","sha":"c72a623ec604840a1a1cd53f757c9d14084ce428","user":{"login":"UmeFuu","id":35434208,"node_id":"MDQ6VXNlcjM1NDM0MjA4","avatar_url":"https://avatars3.githubusercontent.com/u/35434208?v=4","gravatar_id":"","url":"https://api.github.com/users/UmeFuu","html_url":"https://github.com/UmeFuu","followers_url":"https://api.github.com/users/UmeFuu/followers","following_url":"https://api.github.com/users/UmeFuu/following{/other_user}","gists_url":"https://api.github.com/users/UmeFuu/gists{/gist_id}","starred_url":"https://api.github.com/users/UmeFuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmeFuu/subscriptions","organizations_url":"https://api.github.com/users/UmeFuu/orgs","repos_url":"https://api.github.com/users/UmeFuu/repos","events_url":"https://api.github.com/users/UmeFuu/events{/privacy}","received_events_url":"https://api.github.com/users/UmeFuu/received_events","type":"User","site_admin":false},"repo":{"id":170168808,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAxNjg4MDg=","name":"Paradise","full_name":"UmeFuu/Paradise","private":false,"owner":{"login":"UmeFuu","id":35434208,"node_id":"MDQ6VXNlcjM1NDM0MjA4","avatar_url":"https://avatars3.githubusercontent.com/u/35434208?v=4","gravatar_id":"","url":"https://api.github.com/users/UmeFuu","html_url":"https://github.com/UmeFuu","followers_url":"https://api.github.com/users/UmeFuu/followers","following_url":"https://api.github.com/users/UmeFuu/following{/other_user}","gists_url":"https://api.github.com/users/UmeFuu/gists{/gist_id}","starred_url":"https://api.github.com/users/UmeFuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmeFuu/subscriptions","organizations_url":"https://api.github.com/users/UmeFuu/orgs","repos_url":"https://api.github.com/users/UmeFuu/repos","events_url":"https://api.github.com/users/UmeFuu/events{/privacy}","received_events_url":"https://api.github.com/users/UmeFuu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/UmeFuu/Paradise","description":"Paradise Station's GitHub main repository.","fork":true,"url":"https://api.github.com/repos/UmeFuu/Paradise","forks_url":"https://api.github.com/repos/UmeFuu/Paradise/forks","keys_url":"https://api.github.com/repos/UmeFuu/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UmeFuu/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UmeFuu/Paradise/teams","hooks_url":"https://api.github.com/repos/UmeFuu/Paradise/hooks","issue_events_url":"https://api.github.com/repos/UmeFuu/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/UmeFuu/Paradise/events","assignees_url":"https://api.github.com/repos/UmeFuu/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/UmeFuu/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/UmeFuu/Paradise/tags","blobs_url":"https://api.github.com/repos/UmeFuu/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UmeFuu/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UmeFuu/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/UmeFuu/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UmeFuu/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/UmeFuu/Paradise/languages","stargazers_url":"https://api.github.com/repos/UmeFuu/Paradise/stargazers","contributors_url":"https://api.github.com/repos/UmeFuu/Paradise/contributors","subscribers_url":"https://api.github.com/repos/UmeFuu/Paradise/subscribers","subscription_url":"https://api.github.com/repos/UmeFuu/Paradise/subscription","commits_url":"https://api.github.com/repos/UmeFuu/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/UmeFuu/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/UmeFuu/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/UmeFuu/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/UmeFuu/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/UmeFuu/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UmeFuu/Paradise/merges","archive_url":"https://api.github.com/repos/UmeFuu/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UmeFuu/Paradise/downloads","issues_url":"https://api.github.com/repos/UmeFuu/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/UmeFuu/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/UmeFuu/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/UmeFuu/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UmeFuu/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/UmeFuu/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/UmeFuu/Paradise/deployments","created_at":"2019-02-11T17:11:50Z","updated_at":"2019-02-13T20:37:57Z","pushed_at":"2019-02-13T20:37:55Z","git_url":"git://github.com/UmeFuu/Paradise.git","ssh_url":"git@github.com:UmeFuu/Paradise.git","clone_url":"https://github.com/UmeFuu/Paradise.git","svn_url":"https://github.com/UmeFuu/Paradise","homepage":"https://nanotrasen.se/forum/","size":1117641,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"67f0a145be0b10f778de155c01d9b41ee5132eaa","user":{"login":"ParadiseSS13","id":9994901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5OTQ5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"repo":{"id":27286452,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI4NjQ1Mg==","name":"Paradise","full_name":"ParadiseSS13/Paradise","private":false,"owner":{"login":"ParadiseSS13","id":9994901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5OTQ5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub main repository.","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/deployments","created_at":"2014-11-29T00:16:54Z","updated_at":"2019-02-13T23:46:46Z","pushed_at":"2019-02-14T00:07:04Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"git@github.com:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"https://nanotrasen.se/forum/","size":1117433,"stargazers_count":168,"watchers_count":168,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":499,"mirror_url":null,"archived":false,"open_issues_count":511,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":499,"open_issues":511,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/10892"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/10892"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/10892"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/10892/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/10892/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/10892/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/c72a623ec604840a1a1cd53f757c9d14084ce428"}},"author_association":"NONE"}}
|
{
"id": 27286452,
"name": "ParadiseSS13/Paradise",
"url": "https://api.github.com/repos/ParadiseSS13/Paradise"
}
|
{
"id": 35434208,
"login": "UmeFuu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35434208?",
"url": "https://api.github.com/users/UmeFuu"
}
|
{
"id": 9994901,
"login": "ParadiseSS13",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9994901?",
"url": "https://api.github.com/orgs/ParadiseSS13"
}
| 2019-02-14T00:14:00 |
9064247765
|
{"actor":{"display_login":"UmeFuu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/326443532","pull_request_review_id":290919423,"id":326443532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjQ0MzUzMg==","diff_hunk":"@@ -29,4 +29,5 @@ Absolutely nothing unusual will happen this shift. Promise.\n Send help. Trapped in tip writing factory.\n There is no such thing as a cow level.\n HONK.\n-Solars probably gives radiation poisoning or something, considering the other power sources are deadly in their own ways.\n\\ No newline at end of file\n+Solars probably gives radiation poisoning or something, considering the other power sources are deadly in their own ways.\n+Some people are unable to read text on a game where half of it is based on text.","path":"strings/sillytips.txt","position":7,"original_position":7,"commit_id":"348ba41d70ace450de317d2b8081b553cbb51e64","original_commit_id":"348ba41d70ace450de317d2b8081b553cbb51e64","user":{"login":"Ty-Omaha","id":20497797,"node_id":"MDQ6VXNlcjIwNDk3Nzk3","avatar_url":"https://avatars1.githubusercontent.com/u/20497797?v=4","gravatar_id":"","url":"https://api.github.com/users/Ty-Omaha","html_url":"https://github.com/Ty-Omaha","followers_url":"https://api.github.com/users/Ty-Omaha/followers","following_url":"https://api.github.com/users/Ty-Omaha/following{/other_user}","gists_url":"https://api.github.com/users/Ty-Omaha/gists{/gist_id}","starred_url":"https://api.github.com/users/Ty-Omaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ty-Omaha/subscriptions","organizations_url":"https://api.github.com/users/Ty-Omaha/orgs","repos_url":"https://api.github.com/users/Ty-Omaha/repos","events_url":"https://api.github.com/users/Ty-Omaha/events{/privacy}","received_events_url":"https://api.github.com/users/Ty-Omaha/received_events","type":"User","site_admin":false},"body":"This is already in the code on line 21 as @Lunaimon pointed out","created_at":"2019-09-20T01:40:26Z","updated_at":"2019-09-20T01:40:45Z","html_url":"https://github.com/ParadiseSS13/Paradise/pull/12356#discussion_r326443532","pull_request_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/12356","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/326443532"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/12356#discussion_r326443532"},"pull_request":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/12356"}}},"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/12356","id":319500687,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5NTAwNjg3","html_url":"https://github.com/ParadiseSS13/Paradise/pull/12356","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/12356.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/12356.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/12356","number":12356,"state":"open","locked":false,"title":"The Tip Not For You","user":{"login":"Shadow-Quill","id":44811257,"node_id":"MDQ6VXNlcjQ0ODExMjU3","avatar_url":"https://avatars2.githubusercontent.com/u/44811257?v=4","gravatar_id":"","url":"https://api.github.com/users/Shadow-Quill","html_url":"https://github.com/Shadow-Quill","followers_url":"https://api.github.com/users/Shadow-Quill/followers","following_url":"https://api.github.com/users/Shadow-Quill/following{/other_user}","gists_url":"https://api.github.com/users/Shadow-Quill/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadow-Quill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadow-Quill/subscriptions","organizations_url":"https://api.github.com/users/Shadow-Quill/orgs","repos_url":"https://api.github.com/users/Shadow-Quill/repos","events_url":"https://api.github.com/users/Shadow-Quill/events{/privacy}","received_events_url":"https://api.github.com/users/Shadow-Quill/received_events","type":"User","site_admin":false},"body":"Adds a silly tip:\r\n`Some people are unable to read text on a game where half of it is based on text.`","created_at":"2019-09-19T23:37:14Z","updated_at":"2019-09-20T01:40:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9163fe10d68d1e75ce863e828fa08ddcd6194f23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":226896146,"node_id":"MDU6TGFiZWwyMjY4OTYxNDY=","url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels/Grammar%20and%20Formatting","name":"Grammar and Formatting","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/12356/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/12356/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/12356/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/348ba41d70ace450de317d2b8081b553cbb51e64","head":{"label":"Shadow-Quill:A-Singular-Tip","ref":"A-Singular-Tip","sha":"348ba41d70ace450de317d2b8081b553cbb51e64","user":{"login":"Shadow-Quill","id":44811257,"node_id":"MDQ6VXNlcjQ0ODExMjU3","avatar_url":"https://avatars2.githubusercontent.com/u/44811257?v=4","gravatar_id":"","url":"https://api.github.com/users/Shadow-Quill","html_url":"https://github.com/Shadow-Quill","followers_url":"https://api.github.com/users/Shadow-Quill/followers","following_url":"https://api.github.com/users/Shadow-Quill/following{/other_user}","gists_url":"https://api.github.com/users/Shadow-Quill/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadow-Quill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadow-Quill/subscriptions","organizations_url":"https://api.github.com/users/Shadow-Quill/orgs","repos_url":"https://api.github.com/users/Shadow-Quill/repos","events_url":"https://api.github.com/users/Shadow-Quill/events{/privacy}","received_events_url":"https://api.github.com/users/Shadow-Quill/received_events","type":"User","site_admin":false},"repo":{"id":165453459,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU0NTM0NTk=","name":"Paradise","full_name":"Shadow-Quill/Paradise","private":false,"owner":{"login":"Shadow-Quill","id":44811257,"node_id":"MDQ6VXNlcjQ0ODExMjU3","avatar_url":"https://avatars2.githubusercontent.com/u/44811257?v=4","gravatar_id":"","url":"https://api.github.com/users/Shadow-Quill","html_url":"https://github.com/Shadow-Quill","followers_url":"https://api.github.com/users/Shadow-Quill/followers","following_url":"https://api.github.com/users/Shadow-Quill/following{/other_user}","gists_url":"https://api.github.com/users/Shadow-Quill/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadow-Quill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadow-Quill/subscriptions","organizations_url":"https://api.github.com/users/Shadow-Quill/orgs","repos_url":"https://api.github.com/users/Shadow-Quill/repos","events_url":"https://api.github.com/users/Shadow-Quill/events{/privacy}","received_events_url":"https://api.github.com/users/Shadow-Quill/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Shadow-Quill/Paradise","description":"Paradise Station's GitHub main repository.","fork":true,"url":"https://api.github.com/repos/Shadow-Quill/Paradise","forks_url":"https://api.github.com/repos/Shadow-Quill/Paradise/forks","keys_url":"https://api.github.com/repos/Shadow-Quill/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shadow-Quill/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shadow-Quill/Paradise/teams","hooks_url":"https://api.github.com/repos/Shadow-Quill/Paradise/hooks","issue_events_url":"https://api.github.com/repos/Shadow-Quill/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/Shadow-Quill/Paradise/events","assignees_url":"https://api.github.com/repos/Shadow-Quill/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/Shadow-Quill/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/Shadow-Quill/Paradise/tags","blobs_url":"https://api.github.com/repos/Shadow-Quill/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shadow-Quill/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shadow-Quill/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shadow-Quill/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shadow-Quill/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/Shadow-Quill/Paradise/languages","stargazers_url":"https://api.github.com/repos/Shadow-Quill/Paradise/stargazers","contributors_url":"https://api.github.com/repos/Shadow-Quill/Paradise/contributors","subscribers_url":"https://api.github.com/repos/Shadow-Quill/Paradise/subscribers","subscription_url":"https://api.github.com/repos/Shadow-Quill/Paradise/subscription","commits_url":"https://api.github.com/repos/Shadow-Quill/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shadow-Quill/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shadow-Quill/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shadow-Quill/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shadow-Quill/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/Shadow-Quill/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shadow-Quill/Paradise/merges","archive_url":"https://api.github.com/repos/Shadow-Quill/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shadow-Quill/Paradise/downloads","issues_url":"https://api.github.com/repos/Shadow-Quill/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/Shadow-Quill/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/Shadow-Quill/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/Shadow-Quill/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shadow-Quill/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/Shadow-Quill/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/Shadow-Quill/Paradise/deployments","created_at":"2019-01-13T01:22:08Z","updated_at":"2019-09-20T01:13:41Z","pushed_at":"2019-09-20T01:13:39Z","git_url":"git://github.com/Shadow-Quill/Paradise.git","ssh_url":"git@github.com:Shadow-Quill/Paradise.git","clone_url":"https://github.com/Shadow-Quill/Paradise.git","svn_url":"https://github.com/Shadow-Quill/Paradise","homepage":"https://nanotrasen.se/forum/","size":1168459,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"f0f7472c50a4cc09a25b7db284c0ad7370b1126e","user":{"login":"ParadiseSS13","id":9994901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5OTQ5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"repo":{"id":27286452,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI4NjQ1Mg==","name":"Paradise","full_name":"ParadiseSS13/Paradise","private":false,"owner":{"login":"ParadiseSS13","id":9994901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5OTQ5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub main repository.","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/deployments","created_at":"2014-11-29T00:16:54Z","updated_at":"2019-09-20T01:00:55Z","pushed_at":"2019-09-20T01:04:00Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"git@github.com:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"https://nanotrasen.se/forum/","size":1168458,"stargazers_count":196,"watchers_count":196,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":554,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":681,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":554,"open_issues":681,"watchers":196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/12356"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/12356"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/12356"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/12356/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/12356/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/12356/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/348ba41d70ace450de317d2b8081b553cbb51e64"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27286452,
"name": "ParadiseSS13/Paradise",
"url": "https://api.github.com/repos/ParadiseSS13/Paradise"
}
|
{
"id": 20497797,
"login": "Ty-Omaha",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20497797?",
"url": "https://api.github.com/users/Ty-Omaha"
}
|
{
"id": 9994901,
"login": "ParadiseSS13",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9994901?",
"url": "https://api.github.com/orgs/ParadiseSS13"
}
| 2019-09-20T01:40:26 |
10456561097
|
{"actor":{"display_login":"Ty-Omaha"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/WollMux/WollMux/pulls/comments/353629902","pull_request_review_id":326702627,"id":353629902,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzYyOTkwMg==","diff_hunk":"@@ -0,0 +1,787 @@\n+/*\n+ * Dateiname: UIElementFactory.java\n+ * Projekt : WollMux\n+ * Funktion : Erzeugt zu ConfigThingys passende UI Elemente.\n+ * \n+ * Copyright (c) 2010-2015 Landeshauptstadt München\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the European Union Public Licence (EUPL),\n+ * version 1.0 (or any later version).\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * European Union Public Licence for more details.\n+ *\n+ * You should have received a copy of the European Union Public Licence\n+ * along with this program. If not, see\n+ * http://ec.europa.eu/idabc/en/document/7330\n+ *\n+ * Änderungshistorie:\n+ * Datum | Wer | Änderungsgrund\n+ * -------------------------------------------------------------------\n+ * 05.01.2006 | BNK | Erstellung\n+ * 21.04.2006 | BNK | +Set supportedActions zum Angeben welche ACTIONs akzeptiert werden\n+ * | +TYPE \"menuitem\"\n+ * | +ACTION \"openTemplate\" und \"openDocument\"\n+ * | null-Werte in den Maps unterstützt\n+ * 24.04.2006 | BNK | Qualitätssicherung\n+ * 29.05.2006 | BNK | ordentliche Context-Klasse\n+ * 31.05.2006 | BNK | +funcDialog\n+ * 16.06.2006 | BNK | Beim Ändern eines Checkbox-Werts holt sich die Checkbox jetzt den Fokus\n+ * 13.09.2006 | BNK | Bei glues werden jetzt MINSIZE, MAXSIZE und PREFSIZE unterstützt.\n+ * 08.01.2007 | BNK | [R4698]WRAP-Attribut bei textareas\n+ * | [R4296]Wenn READONLY, dann nicht fokussierbar\n+ * 09.01.2007 | BNK | ENTER kann jetzt auch Checkboxen und Buttons aktivieren\n+ * 07.02.2007 | BNK | +ACTION \"open\"\n+ * 23.03.2007 | BNK | openExt implementiert\n+ * 02.06.2010 | BED | Unterstützung von ACTION \"saveTempAndOpenExt\"\n+ * -------------------------------------------------------------------\n+ *\n+ * @author Matthias Benkmann (D-III-ITD 5.1)\n+ * \n+ */\n+package de.muenchen.allg.itd51.wollmux.core.dialog;\n+\n+import java.awt.AWTKeyStroke;\n+import java.awt.Dimension;\n+import java.awt.GridLayout;\n+import java.awt.KeyboardFocusManager;\n+import java.awt.Point;\n+import java.awt.Rectangle;\n+import java.awt.event.ActionEvent;\n+import java.awt.event.ActionListener;\n+import java.awt.event.FocusEvent;\n+import java.awt.event.FocusListener;\n+import java.awt.event.InputEvent;\n+import java.awt.event.ItemEvent;\n+import java.awt.event.ItemListener;\n+import java.awt.event.KeyEvent;\n+import java.awt.event.MouseAdapter;\n+import java.awt.event.MouseEvent;\n+import java.util.HashSet;\n+import java.util.Set;\n+\n+import javax.swing.AbstractButton;\n+import javax.swing.DefaultListModel;\n+import javax.swing.InputMap;\n+import javax.swing.JButton;\n+import javax.swing.JCheckBox;\n+import javax.swing.JComboBox;\n+import javax.swing.JComponent;\n+import javax.swing.JList;\n+import javax.swing.JMenuItem;\n+import javax.swing.JPanel;\n+import javax.swing.JScrollPane;\n+import javax.swing.JSeparator;\n+import javax.swing.JTextArea;\n+import javax.swing.JTextField;\n+import javax.swing.KeyStroke;\n+import javax.swing.ListSelectionModel;\n+import javax.swing.ScrollPaneConstants;\n+import javax.swing.SwingConstants;\n+import javax.swing.event.DocumentEvent;\n+import javax.swing.event.DocumentListener;\n+import javax.swing.event.ListSelectionEvent;\n+import javax.swing.event.ListSelectionListener;\n+import javax.swing.text.JTextComponent;\n+\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.Box;\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.Button;\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.Checkbox;\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.Combobox;\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.Label;\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.Listbox;\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.Separator;\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.Textarea;\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.Textfield;\n+import de.muenchen.allg.itd51.wollmux.core.dialog.controls.UIElement;\n+import de.muenchen.allg.itd51.wollmux.core.form.model.Control;\n+import de.muenchen.allg.itd51.wollmux.core.form.model.FormType;\n+import de.muenchen.allg.itd51.wollmux.core.parser.ConfigurationErrorException;\n+import de.muenchen.allg.itd51.wollmux.core.util.L;\n+\n+/**\n+ * Erzeugt zu ConfigThingys passende UI Elemente.\n+ */\n+public class UIElementFactory\n+{\n+\n+ private static final Logger LOGGER = LoggerFactory\n+ .getLogger(UIElementFactory.class);\n+\n+ /**\n+ * Standardbreite für Textfelder und Textareas. Wird verwendet, wenn nicht mit\n+ * setTextfieldWidth() ein anderer Wert gesetzt wurde.\n+ */\n+ private static final int TEXTFIELD_DEFAULT_WIDTH = 22;\n+\n+ /**\n+ * Die Breite (in Zeichen) für Textfields und Textareas. Kann mit\n+ * {@link #setTextfieldWidth(int)} gesetzt werden.\n+ */\n+ private int textfieldWidth = TEXTFIELD_DEFAULT_WIDTH;\n+\n+ /**\n+ * Erzeugt eine Factory.\n+ */\n+ public UIElementFactory()\n+ {\n+ // nothing to initialize\n+ }\n+\n+ /**\n+ * Setzt die Breite für erzeugte Textfields und Textareas auf anzahlZeichen.\n+ */\n+ public void setTextfieldWidth(int anzahlZeichen)\n+ {\n+ textfieldWidth = anzahlZeichen;\n+ }\n+\n+ /**\n+ * Erzeugt aus der Spezifikation in conf (muss als Kind einen TYPE-Knoten haben) ein passendes\n+ * {@link UIElement}. Die folgenden TYPES werden unterstützt\n+ * <dl>\n+ * <dt>button</dt>\n+ * <dd>Ein normaler Button.</dd>\n+ * \n+ * <dt>menuitem</dt>\n+ * <dd>Erzeugt ein JMenuItem, ist aber ansonsten genau wie ein \"button\".</dd>\n+ * \n+ * <dt>textfield</dt>\n+ * <dd>Ein einzeiliges Textfeld.</dd>\n+ * \n+ * <dt>textarea</dt>\n+ * <dd>Ein mehrzeiliger Texteingabebereich.</dd>\n+ * \n+ * <dt>combobox</dt>\n+ * <dd>Eine Combobox.</dd>\n+ * \n+ * <dt>checkbox</dt>\n+ * <dd>Eine Checkbox mit integriertem Label das immer rechts ist.</dd>\n+ * \n+ * <dt>listbox</dt>\n+ * <dd>Eine Liste von Einträgen.</dd>\n+ * \n+ * <dt>v-separator</dt>\n+ * <dd>Ein separator mit <b>vertikaler</b> Ausdehnung (z.B. ein senkrechter Strich). Diese Art\n+ * Separator wir benutzt, um horizontal angeordnete Elemente zu trennen.</dd>\n+ * \n+ * <dt>h-separator</dt>\n+ * <dd>Ein separator mit <b>horizontaler</b> Ausdehnung (z.B. ein horizontaler Strich). Diese Art\n+ * Separator wir benutzt, um vertikal angeordnete Elemente zu trennen (z.B. in einem\n+ * Pull-Down-Menü).</dd>\n+ * \n+ * <dt>h-glue</dt>\n+ * <dd>Leerraum mit <b>horizontaler</b> Ausdehnung. Wird verwendet, um Abstand zwischen horizontal\n+ * angeordneten Elementen zu schaffen.</dd>\n+ * \n+ * <dt>v-glue</dt>\n+ * <dd>Leerraum mit <b>vertikaler</b> Ausdehnung. Wird verwendet, um Abstand zwischen vertikal\n+ * angeordneten Elementen zu schaffen (z.B. in Pull-Down-Menüs).</dd>\n+ * \n+ * <dt>default</dt>\n+ * <dd>Dieser TYPE wird als Fallback verwendet, wenn in einer der an den Konstruktor übergebenen\n+ * Maps ein TYPE nicht gefunden wird.</dd>\n+ * </dl>\n+ * \n+ * @param context\n+ * Liefert Informationen für die Erstellung der UI Elemente. Ist für einen TYPE in einer\n+ * Map kein Mapping angegeben (auch kein null-Wert), so wird erst geschaut, ob ein\n+ * Mapping für \"default\" vorhanden ist. Falls ja, so wird dieses der entsprechenden\n+ * Eigenschaft des erzeugten UIElements zugewiesen, ansonsten null.\n+ * \n+ * @return niemals null.\n+ * @throws ConfigurationErrorException\n+ * falls irgendein Fehler in der Beschreibung des UI Elements gefunden wird.\n+ */\n+ public UIElement createUIElement(UIElementContext context, Control control)\n+ {\n+ /*\n+ * Den richtigen type aus dem context bestimmen.\n+ */\n+ FormType type = context.getMappedType(control.getType());\n+\n+ Object layoutConstraints = context.getLayoutConstraints(type);\n+ Object labelLayoutConstraints = context.getLabelLayoutConstraints(type);\n+ UIElement.LabelPosition labelType = context.getLabelType(type);\n+\n+ switch (type)\n+ {\n+ case BUTTON:\n+ case MENUITEM:\n+ return createButton(context, control, layoutConstraints);\n+ case LABEL:\n+ return createLabel(control, layoutConstraints);\n+ case TEXTFIELD:\n+ return createTextfield(context, control, layoutConstraints, labelLayoutConstraints,\n+ labelType);\n+ case TEXTAREA:\n+ return createTextarea(context, control, layoutConstraints, labelLayoutConstraints, labelType);\n+ case COMBOBOX:\n+ return createCombobox(context, control, layoutConstraints, labelLayoutConstraints, labelType);\n+ case CHECKBOX:\n+ return createCheckbox(context, control, layoutConstraints);\n+ case H_SEPARATOR:\n+ JSeparator wurzelSepp = new JSeparator(SwingConstants.HORIZONTAL);\n+ return new Separator(control.getId(), wurzelSepp, layoutConstraints);\n+ case V_SEPARATOR:\n+ JSeparator sepp = new JSeparator(SwingConstants.VERTICAL);\n+ return new Separator(control.getId(), sepp, layoutConstraints);\n+ case H_GLUE:\n+ return new Box(control.getId(),\n+ new javax.swing.Box.Filler(new Dimension(control.getMinsize(), 0),\n+ new Dimension(control.getPrefsize(), 0),\n+ new Dimension(control.getMaxsize(), Integer.MAX_VALUE)),\n+ layoutConstraints);\n+ case V_GLUE:\n+ return new Box(control.getId(),\n+ new javax.swing.Box.Filler(new Dimension(0, control.getMinsize()),\n+ new Dimension(0, control.getPrefsize()),\n+ new Dimension(Integer.MAX_VALUE, control.getMaxsize())),\n+ layoutConstraints);\n+ case LISTBOX:\n+ return createListbox(context, control, layoutConstraints, labelLayoutConstraints, labelType);\n+ default:\n+ throw new ConfigurationErrorException(\n+ L.m(\"Ununterstützter TYPE für GUI Element: \\\"%1\\\"\", type));\n+ }\n+ }\n+\n+ private UIElement createListbox(UIElementContext context, Control control,\n+ Object layoutConstraints, Object labelLayoutConstraints,\n+ UIElement.LabelPosition labelType)\n+ {\n+ UIElement uiElement;\n+\n+ JList<Object> list = new JList<>(new DefaultListModel<>());\n+\n+ list.setVisibleRowCount(control.getLines());\n+ list.setSelectionMode(ListSelectionModel.MULTIPLE_INTERVAL_SELECTION);\n+ list.setLayoutOrientation(JList.VERTICAL);\n+ list.setPrototypeCellValue(\n+ \"Al-chman hemnal ulhillim el-WollMux(W-OLL-MUX-5.1)\");\n+\n+ JScrollPane scrollPane = new JScrollPane(list);\n+ scrollPane.setHorizontalScrollBarPolicy(\n+ ScrollPaneConstants.HORIZONTAL_SCROLLBAR_AS_NEEDED);\n+ scrollPane.setVerticalScrollBarPolicy(\n+ ScrollPaneConstants.VERTICAL_SCROLLBAR_AS_NEEDED);\n+\n+ uiElement = new Listbox(control.getId(), scrollPane, list, layoutConstraints,\n+ labelType,\n+ control.getLabel(), labelLayoutConstraints);\n+\n+ list.addListSelectionListener(new UIElementListSelectionListener(\n+ context.getUiElementEventHandler(), uiElement, \"listSelectionChanged\",\n+ new Object[] {}));\n+\n+ ActionListener actionL = getAction(uiElement, control,\n+ context.getUiElementEventHandler(), context.getSupportedActions());\n+ if (actionL != null)\n+ list.addMouseListener(new MyActionMouseListener(list, actionL));\n+\n+ return uiElement;\n+ }\n+\n+ private UIElement createCheckbox(UIElementContext context, Control control,\n+ Object layoutConstraints)\n+ {\n+ UIElement uiElement;\n+ /*\n+ * ACHTUNG! Diese checkbox hat ihr Label fest integriert auf der rechten Seite\n+ * und liefert als Zusatzlabel immer LABEL_NONE.\n+ */\n+ final JCheckBox boxBruceleitner = new JCheckBox(control.getLabel());\n+ copySpaceBindingToEnter(boxBruceleitner);\n+ boxBruceleitner.setEnabled(!control.isReadonly());\n+ boxBruceleitner.setFocusable(!control.isReadonly());\n+ if (!control.getTip().isEmpty())\n+ {\n+ boxBruceleitner.setToolTipText(control.getTip());\n+ }\n+ uiElement = new Checkbox(control.getId(), boxBruceleitner, layoutConstraints);\n+ boxBruceleitner.addActionListener(new UIElementActionListener(\n+ context.getUiElementEventHandler(), uiElement, true, \"valueChanged\",\n+ new Object[] {}));\n+ boxBruceleitner.addFocusListener(new UIElementFocusListener(\n+ context.getUiElementEventHandler(), uiElement));\n+ return uiElement;\n+ }\n+\n+ private UIElement createCombobox(UIElementContext context, Control control,\n+ Object layoutConstraints, Object labelLayoutConstraints, UIElement.LabelPosition labelType)\n+ {\n+ UIElement uiElement;\n+ JComboBox<Object> combo = new JComboBox<>();\n+ combo.setEnabled(!control.isReadonly());\n+ combo.setFocusable(!control.isReadonly());\n+ combo.setEditable(control.isEditable());\n+ if (!control.getTip().isEmpty())\n+ {\n+ combo.setToolTipText(control.getTip());\n+ }\n+ control.getOptions().forEach(combo::addItem);\n+\n+ uiElement = new Combobox(control.getId(), combo, layoutConstraints, labelType,\n+ control.getLabel(), labelLayoutConstraints);\n+\n+ if (control.isEditable())\n+ {\n+ JTextComponent tc = ((JTextComponent) combo.getEditor()\n+ .getEditorComponent());\n+ tc.addFocusListener(new UIElementFocusListener(\n+ context.getUiElementEventHandler(), uiElement));\n+ tc.getDocument().addDocumentListener(\n+ new UIElementDocumentListener(context.getUiElementEventHandler(),\n+ uiElement,\n+ \"valueChanged\", new Object[] {}));\n+ }\n+ else\n+ {\n+ combo.addItemListener(new UIElementItemListener(\n+ context.getUiElementEventHandler(), uiElement, \"valueChanged\",\n+ new Object[] {}));\n+ combo.addFocusListener(new UIElementFocusListener(\n+ context.getUiElementEventHandler(), uiElement));\n+ }\n+ return uiElement;\n+ }\n+\n+ private UIElement createTextarea(UIElementContext context, Control control,\n+ Object layoutConstraints, Object labelLayoutConstraints, UIElement.LabelPosition labelType)\n+ {\n+ UIElement uiElement;\n+ JTextArea textarea = new JTextArea(control.getLines(), textfieldWidth);\n+ textarea.setEditable(!control.isReadonly());\n+ textarea.setFocusable(!control.isReadonly());\n+ if (control.isWrap())\n+ {\n+ textarea.setLineWrap(true);\n+ textarea.setWrapStyleWord(true);\n+ }\n+ textarea.setFont(new JTextField().getFont());\n+ if (!control.getTip().isEmpty())\n+ {\n+ textarea.setToolTipText(control.getTip());\n+ }\n+\n+ // Tab auch zum Weiterschalten und Shift-Tab zum Zurückschalten erlauben\n+ Set<AWTKeyStroke> focusKeys = textarea\n+ .getFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS);\n+ focusKeys = new HashSet<>(focusKeys);\n+ focusKeys.add(KeyStroke.getKeyStroke(KeyEvent.VK_TAB, 0));\n+ textarea.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS, focusKeys);\n+ focusKeys = textarea.getFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS);\n+ focusKeys = new HashSet<>(focusKeys);\n+ focusKeys.add(KeyStroke.getKeyStroke(KeyEvent.VK_TAB, InputEvent.SHIFT_DOWN_MASK));\n+ textarea.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS, focusKeys);\n+\n+ JPanel panel = new JPanel(new GridLayout(1, 1));\n+ JScrollPane scrollPane = new JScrollPane(textarea);\n+ scrollPane.setHorizontalScrollBarPolicy(ScrollPaneConstants.HORIZONTAL_SCROLLBAR_NEVER);\n+ scrollPane.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS);\n+ panel.add(scrollPane);\n+ uiElement = new Textarea(control.getId(), textarea, panel, layoutConstraints, labelType,\n+ control.getLabel(), labelLayoutConstraints);\n+ textarea.getDocument().addDocumentListener(new UIElementDocumentListener(\n+ context.getUiElementEventHandler(), uiElement, \"valueChanged\", new Object[] {}));\n+ textarea.addFocusListener(\n+ new UIElementFocusListener(context.getUiElementEventHandler(), uiElement));\n+ return uiElement;\n+ }\n+\n+ private UIElement createTextfield(UIElementContext context, Control control, \n+ Object layoutConstraints, Object labelLayoutConstraints, UIElement.LabelPosition labelType)\n+ {\n+ UIElement uiElement;\n+ JTextField tf = new JTextField(textfieldWidth);\n+ tf.setEditable(!control.isReadonly());\n+ tf.setFocusable(!control.isReadonly());\n+ if (!control.getTip().isEmpty())\n+ {\n+ tf.setToolTipText(control.getTip());\n+ }\n+ uiElement = new Textfield(control.getId(), tf, layoutConstraints, labelType, control.getLabel(),\n+ labelLayoutConstraints);\n+ tf.getDocument().addDocumentListener(new UIElementDocumentListener(\n+ context.getUiElementEventHandler(), uiElement, \"valueChanged\", new Object[] {}));\n+ tf.addFocusListener(new UIElementFocusListener(context.getUiElementEventHandler(), uiElement));\n+ if (control.getAction() != null && control.getAction().length() > 0)\n+ {\n+ ActionListener actionL = getAction(uiElement, control, context.getUiElementEventHandler(),\n+ context.getSupportedActions());\n+ if (actionL != null)\n+ {\n+ ((JTextField) uiElement.getComponent()).addActionListener(actionL);\n+ }\n+ }\n+ return uiElement;\n+ }\n+\n+ private UIElement createLabel(Control control, Object layoutConstraints)\n+ {\n+ UIElement uiElement;\n+ uiElement = new Label(control.getId(), control.getLabel(), layoutConstraints);\n+ return uiElement;\n+ }\n+\n+ private UIElement createButton(UIElementContext context, Control control,\n+ Object layoutConstraints)\n+ {\n+ UIElement uiElement;\n+ AbstractButton button;\n+ if (FormType.BUTTON == context.getMappedType(control.getType()))\n+ {\n+ button = new JButton(control.getLabel());\n+ copySpaceBindingToEnter(button);\n+ } else\n+ {\n+ button = new JMenuItem(control.getLabel());\n+ }\n+\n+ button.setMnemonic(control.getHotkey());\n+ if (!control.getTip().isEmpty())\n+ {\n+ button.setToolTipText(control.getTip());\n+ }\n+ uiElement = new Button(control.getId(), button, layoutConstraints);\n+\n+ button.addFocusListener(\n+ new UIElementFocusListener(context.getUiElementEventHandler(), uiElement));\n+ ActionListener actionL = getAction(uiElement, control, context.getUiElementEventHandler(),\n+ context.getSupportedActions());\n+ if (actionL != null)\n+ {\n+ ((AbstractButton) uiElement.getComponent()).addActionListener(actionL);\n+ }\n+ return uiElement;\n+ }\n+\n+ private void copySpaceBindingToEnter(AbstractButton button)\n+ {\n+ InputMap imap = button.getInputMap(JComponent.WHEN_FOCUSED);\n+\n+ Object binding = imap\n+ .get(KeyStroke.getKeyStroke(KeyEvent.VK_SPACE, 0, true));\n+ if (binding != null)\n+ imap.put(KeyStroke.getKeyStroke(KeyEvent.VK_ENTER, 0, true), binding);\n+\n+ binding = imap.get(KeyStroke.getKeyStroke(KeyEvent.VK_SPACE, 0, false));\n+ if (binding != null)\n+ imap.put(KeyStroke.getKeyStroke(KeyEvent.VK_ENTER, 0, false), binding);\n+ }\n+\n+ /**\n+ * Liefert einen {@link UIElementActionListener} zurück, der ActionEvents von uiElement an handler\n+ * weitergibt, wobei der eventType \"action\" ist.\n+ * \n+ * @param uiElement\n+ * das uiElement zu dem der ActionListener gehört. Achtung! der ActionListener wird durch\n+ * diese Methode nicht auf uiElement registriert!\n+ * @param action\n+ * wird als erstes Element des args Arrays an die Funktion\n+ * {@link UIElementEventHandler#processUiElementEvent(UIElement, String, Object[])}\n+ * übergeben.\n+ * @param handler\n+ * der {@link UIElementEventHandler} an den die Events weitergereicht werden sollen.\n+ * @param supportedActions\n+ * Ist action nicht in dieser Menge enthalten gibt es einen Fehler.\n+ * @return einen ActionListener, den man auf uiElement registrieren kann, damit er dessen Actions\n+ * an handler weiterreicht. Im Falle eines Fehlers (z.B. fehlende Zusatzangaben für ACTION\n+ * die dieses erfordert) wird null geliefert.\n+ */\n+ private ActionListener getAction(UIElement uiElement, Control control,\n+ UIElementEventHandler handler, Set<String> supportedActions)\n+ {\n+ if (!supportedActions.contains(control.getAction()))\n+ {\n+ LOGGER.error(L.m(\"Ununterstützte ACTION \\\"%1\\\"\", control.getAction()));\n+ return null;\n+ }\n+\n+ if (\"switchWindow\".equals(control.getAction()))\n+ {\n+ if (control.getWindow() != null)\n+ {\n+ return new UIElementActionListener(handler, uiElement, false, \"action\",\n+ new Object[] { control.getAction(), control.getWindow() });\n+ } else\n+ {\n+ LOGGER.error(L.m(\"ACTION \\\"switchWindow\\\" erfordert WINDOW-Attribut\"));","path":"src/main/java/de/muenchen/allg/itd51/wollmux/core/dialog/UIElementFactory.java","position":515,"original_position":515,"commit_id":"a2efd94a8ea62e3e76070229bedadb63ef3580e7","original_commit_id":"a2efd94a8ea62e3e76070229bedadb63ef3580e7","user":{"login":"lhm-jenkins","id":35487075,"node_id":"MDQ6VXNlcjM1NDg3MDc1","avatar_url":"https://avatars1.githubusercontent.com/u/35487075?v=4","gravatar_id":"","url":"https://api.github.com/users/lhm-jenkins","html_url":"https://github.com/lhm-jenkins","followers_url":"https://api.github.com/users/lhm-jenkins/followers","following_url":"https://api.github.com/users/lhm-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/lhm-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/lhm-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhm-jenkins/subscriptions","organizations_url":"https://api.github.com/users/lhm-jenkins/orgs","repos_url":"https://api.github.com/users/lhm-jenkins/repos","events_url":"https://api.github.com/users/lhm-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/lhm-jenkins/received_events","type":"User","site_admin":false},"body":" Invoke method(s) only conditionally. [](http://kvm-javabuild/sonar/coding_rules#rule_key=squid%3AS2629)\n","created_at":"2019-12-04T09:27:20Z","updated_at":"2019-12-04T09:27:20Z","html_url":"https://github.com/WollMux/WollMux/pull/163#discussion_r353629902","pull_request_url":"https://api.github.com/repos/WollMux/WollMux/pulls/163","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/WollMux/WollMux/pulls/comments/353629902"},"html":{"href":"https://github.com/WollMux/WollMux/pull/163#discussion_r353629902"},"pull_request":{"href":"https://api.github.com/repos/WollMux/WollMux/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/WollMux/WollMux/pulls/163","id":348776937,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4Nzc2OTM3","html_url":"https://github.com/WollMux/WollMux/pull/163","diff_url":"https://github.com/WollMux/WollMux/pull/163.diff","patch_url":"https://github.com/WollMux/WollMux/pull/163.patch","issue_url":"https://api.github.com/repos/WollMux/WollMux/issues/163","number":163,"state":"open","locked":false,"title":"Auflösen von wollmux-core","user":{"login":"sikelerd","id":19220590,"node_id":"MDQ6VXNlcjE5MjIwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/19220590?v=4","gravatar_id":"","url":"https://api.github.com/users/sikelerd","html_url":"https://github.com/sikelerd","followers_url":"https://api.github.com/users/sikelerd/followers","following_url":"https://api.github.com/users/sikelerd/following{/other_user}","gists_url":"https://api.github.com/users/sikelerd/gists{/gist_id}","starred_url":"https://api.github.com/users/sikelerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikelerd/subscriptions","organizations_url":"https://api.github.com/users/sikelerd/orgs","repos_url":"https://api.github.com/users/sikelerd/repos","events_url":"https://api.github.com/users/sikelerd/events{/privacy}","received_events_url":"https://api.github.com/users/sikelerd/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-04T09:21:15Z","updated_at":"2019-12-04T09:27:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9393324a4cca1f40e7f4bbebec57c38032b39bf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bjoernranft","id":29572154,"node_id":"MDQ6VXNlcjI5NTcyMTU0","avatar_url":"https://avatars1.githubusercontent.com/u/29572154?v=4","gravatar_id":"","url":"https://api.github.com/users/bjoernranft","html_url":"https://github.com/bjoernranft","followers_url":"https://api.github.com/users/bjoernranft/followers","following_url":"https://api.github.com/users/bjoernranft/following{/other_user}","gists_url":"https://api.github.com/users/bjoernranft/gists{/gist_id}","starred_url":"https://api.github.com/users/bjoernranft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjoernranft/subscriptions","organizations_url":"https://api.github.com/users/bjoernranft/orgs","repos_url":"https://api.github.com/users/bjoernranft/repos","events_url":"https://api.github.com/users/bjoernranft/events{/privacy}","received_events_url":"https://api.github.com/users/bjoernranft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WollMux/WollMux/pulls/163/commits","review_comments_url":"https://api.github.com/repos/WollMux/WollMux/pulls/163/comments","review_comment_url":"https://api.github.com/repos/WollMux/WollMux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WollMux/WollMux/issues/163/comments","statuses_url":"https://api.github.com/repos/WollMux/WollMux/statuses/a2efd94a8ea62e3e76070229bedadb63ef3580e7","head":{"label":"sikelerd:versions","ref":"versions","sha":"a2efd94a8ea62e3e76070229bedadb63ef3580e7","user":{"login":"sikelerd","id":19220590,"node_id":"MDQ6VXNlcjE5MjIwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/19220590?v=4","gravatar_id":"","url":"https://api.github.com/users/sikelerd","html_url":"https://github.com/sikelerd","followers_url":"https://api.github.com/users/sikelerd/followers","following_url":"https://api.github.com/users/sikelerd/following{/other_user}","gists_url":"https://api.github.com/users/sikelerd/gists{/gist_id}","starred_url":"https://api.github.com/users/sikelerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikelerd/subscriptions","organizations_url":"https://api.github.com/users/sikelerd/orgs","repos_url":"https://api.github.com/users/sikelerd/repos","events_url":"https://api.github.com/users/sikelerd/events{/privacy}","received_events_url":"https://api.github.com/users/sikelerd/received_events","type":"User","site_admin":false},"repo":{"id":151094707,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwOTQ3MDc=","name":"WollMux","full_name":"sikelerd/WollMux","private":false,"owner":{"login":"sikelerd","id":19220590,"node_id":"MDQ6VXNlcjE5MjIwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/19220590?v=4","gravatar_id":"","url":"https://api.github.com/users/sikelerd","html_url":"https://github.com/sikelerd","followers_url":"https://api.github.com/users/sikelerd/followers","following_url":"https://api.github.com/users/sikelerd/following{/other_user}","gists_url":"https://api.github.com/users/sikelerd/gists{/gist_id}","starred_url":"https://api.github.com/users/sikelerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikelerd/subscriptions","organizations_url":"https://api.github.com/users/sikelerd/orgs","repos_url":"https://api.github.com/users/sikelerd/repos","events_url":"https://api.github.com/users/sikelerd/events{/privacy}","received_events_url":"https://api.github.com/users/sikelerd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sikelerd/WollMux","description":" letterhead, template, form, autotext, mail merge,... extension for OpenOffice and LibreOffice","fork":true,"url":"https://api.github.com/repos/sikelerd/WollMux","forks_url":"https://api.github.com/repos/sikelerd/WollMux/forks","keys_url":"https://api.github.com/repos/sikelerd/WollMux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sikelerd/WollMux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sikelerd/WollMux/teams","hooks_url":"https://api.github.com/repos/sikelerd/WollMux/hooks","issue_events_url":"https://api.github.com/repos/sikelerd/WollMux/issues/events{/number}","events_url":"https://api.github.com/repos/sikelerd/WollMux/events","assignees_url":"https://api.github.com/repos/sikelerd/WollMux/assignees{/user}","branches_url":"https://api.github.com/repos/sikelerd/WollMux/branches{/branch}","tags_url":"https://api.github.com/repos/sikelerd/WollMux/tags","blobs_url":"https://api.github.com/repos/sikelerd/WollMux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sikelerd/WollMux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sikelerd/WollMux/git/refs{/sha}","trees_url":"https://api.github.com/repos/sikelerd/WollMux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sikelerd/WollMux/statuses/{sha}","languages_url":"https://api.github.com/repos/sikelerd/WollMux/languages","stargazers_url":"https://api.github.com/repos/sikelerd/WollMux/stargazers","contributors_url":"https://api.github.com/repos/sikelerd/WollMux/contributors","subscribers_url":"https://api.github.com/repos/sikelerd/WollMux/subscribers","subscription_url":"https://api.github.com/repos/sikelerd/WollMux/subscription","commits_url":"https://api.github.com/repos/sikelerd/WollMux/commits{/sha}","git_commits_url":"https://api.github.com/repos/sikelerd/WollMux/git/commits{/sha}","comments_url":"https://api.github.com/repos/sikelerd/WollMux/comments{/number}","issue_comment_url":"https://api.github.com/repos/sikelerd/WollMux/issues/comments{/number}","contents_url":"https://api.github.com/repos/sikelerd/WollMux/contents/{+path}","compare_url":"https://api.github.com/repos/sikelerd/WollMux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sikelerd/WollMux/merges","archive_url":"https://api.github.com/repos/sikelerd/WollMux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sikelerd/WollMux/downloads","issues_url":"https://api.github.com/repos/sikelerd/WollMux/issues{/number}","pulls_url":"https://api.github.com/repos/sikelerd/WollMux/pulls{/number}","milestones_url":"https://api.github.com/repos/sikelerd/WollMux/milestones{/number}","notifications_url":"https://api.github.com/repos/sikelerd/WollMux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sikelerd/WollMux/labels{/name}","releases_url":"https://api.github.com/repos/sikelerd/WollMux/releases{/id}","deployments_url":"https://api.github.com/repos/sikelerd/WollMux/deployments","created_at":"2018-10-01T13:38:35Z","updated_at":"2019-11-20T08:46:04Z","pushed_at":"2019-12-04T09:20:00Z","git_url":"git://github.com/sikelerd/WollMux.git","ssh_url":"git@github.com:sikelerd/WollMux.git","clone_url":"https://github.com/sikelerd/WollMux.git","svn_url":"https://github.com/sikelerd/WollMux","homepage":"","size":39577,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"eupl-1.1","name":"European Union Public License 1.1","spdx_id":"EUPL-1.1","url":"https://api.github.com/licenses/eupl-1.1","node_id":"MDc6TGljZW5zZTI0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WollMux:WollMux_18.2","ref":"WollMux_18.2","sha":"f6bc82aea39f65bc051a0a4c471a10a04d5fb32b","user":{"login":"WollMux","id":10096468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDk2NDY4","avatar_url":"https://avatars0.githubusercontent.com/u/10096468?v=4","gravatar_id":"","url":"https://api.github.com/users/WollMux","html_url":"https://github.com/WollMux","followers_url":"https://api.github.com/users/WollMux/followers","following_url":"https://api.github.com/users/WollMux/following{/other_user}","gists_url":"https://api.github.com/users/WollMux/gists{/gist_id}","starred_url":"https://api.github.com/users/WollMux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WollMux/subscriptions","organizations_url":"https://api.github.com/users/WollMux/orgs","repos_url":"https://api.github.com/users/WollMux/repos","events_url":"https://api.github.com/users/WollMux/events{/privacy}","received_events_url":"https://api.github.com/users/WollMux/received_events","type":"Organization","site_admin":false},"repo":{"id":27683112,"node_id":"MDEwOlJlcG9zaXRvcnkyNzY4MzExMg==","name":"WollMux","full_name":"WollMux/WollMux","private":false,"owner":{"login":"WollMux","id":10096468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDk2NDY4","avatar_url":"https://avatars0.githubusercontent.com/u/10096468?v=4","gravatar_id":"","url":"https://api.github.com/users/WollMux","html_url":"https://github.com/WollMux","followers_url":"https://api.github.com/users/WollMux/followers","following_url":"https://api.github.com/users/WollMux/following{/other_user}","gists_url":"https://api.github.com/users/WollMux/gists{/gist_id}","starred_url":"https://api.github.com/users/WollMux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WollMux/subscriptions","organizations_url":"https://api.github.com/users/WollMux/orgs","repos_url":"https://api.github.com/users/WollMux/repos","events_url":"https://api.github.com/users/WollMux/events{/privacy}","received_events_url":"https://api.github.com/users/WollMux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WollMux/WollMux","description":" letterhead, template, form, autotext, mail merge,... extension for OpenOffice and LibreOffice","fork":false,"url":"https://api.github.com/repos/WollMux/WollMux","forks_url":"https://api.github.com/repos/WollMux/WollMux/forks","keys_url":"https://api.github.com/repos/WollMux/WollMux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WollMux/WollMux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WollMux/WollMux/teams","hooks_url":"https://api.github.com/repos/WollMux/WollMux/hooks","issue_events_url":"https://api.github.com/repos/WollMux/WollMux/issues/events{/number}","events_url":"https://api.github.com/repos/WollMux/WollMux/events","assignees_url":"https://api.github.com/repos/WollMux/WollMux/assignees{/user}","branches_url":"https://api.github.com/repos/WollMux/WollMux/branches{/branch}","tags_url":"https://api.github.com/repos/WollMux/WollMux/tags","blobs_url":"https://api.github.com/repos/WollMux/WollMux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WollMux/WollMux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WollMux/WollMux/git/refs{/sha}","trees_url":"https://api.github.com/repos/WollMux/WollMux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WollMux/WollMux/statuses/{sha}","languages_url":"https://api.github.com/repos/WollMux/WollMux/languages","stargazers_url":"https://api.github.com/repos/WollMux/WollMux/stargazers","contributors_url":"https://api.github.com/repos/WollMux/WollMux/contributors","subscribers_url":"https://api.github.com/repos/WollMux/WollMux/subscribers","subscription_url":"https://api.github.com/repos/WollMux/WollMux/subscription","commits_url":"https://api.github.com/repos/WollMux/WollMux/commits{/sha}","git_commits_url":"https://api.github.com/repos/WollMux/WollMux/git/commits{/sha}","comments_url":"https://api.github.com/repos/WollMux/WollMux/comments{/number}","issue_comment_url":"https://api.github.com/repos/WollMux/WollMux/issues/comments{/number}","contents_url":"https://api.github.com/repos/WollMux/WollMux/contents/{+path}","compare_url":"https://api.github.com/repos/WollMux/WollMux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WollMux/WollMux/merges","archive_url":"https://api.github.com/repos/WollMux/WollMux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WollMux/WollMux/downloads","issues_url":"https://api.github.com/repos/WollMux/WollMux/issues{/number}","pulls_url":"https://api.github.com/repos/WollMux/WollMux/pulls{/number}","milestones_url":"https://api.github.com/repos/WollMux/WollMux/milestones{/number}","notifications_url":"https://api.github.com/repos/WollMux/WollMux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WollMux/WollMux/labels{/name}","releases_url":"https://api.github.com/repos/WollMux/WollMux/releases{/id}","deployments_url":"https://api.github.com/repos/WollMux/WollMux/deployments","created_at":"2014-12-07T20:11:29Z","updated_at":"2019-12-03T09:13:30Z","pushed_at":"2019-12-04T09:21:16Z","git_url":"git://github.com/WollMux/WollMux.git","ssh_url":"git@github.com:WollMux/WollMux.git","clone_url":"https://github.com/WollMux/WollMux.git","svn_url":"https://github.com/WollMux/WollMux","homepage":"","size":39570,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":{"key":"eupl-1.1","name":"European Union Public License 1.1","spdx_id":"EUPL-1.1","url":"https://api.github.com/licenses/eupl-1.1","node_id":"MDc6TGljZW5zZTI0"},"forks":12,"open_issues":19,"watchers":28,"default_branch":"WollMux_18.1"}},"_links":{"self":{"href":"https://api.github.com/repos/WollMux/WollMux/pulls/163"},"html":{"href":"https://github.com/WollMux/WollMux/pull/163"},"issue":{"href":"https://api.github.com/repos/WollMux/WollMux/issues/163"},"comments":{"href":"https://api.github.com/repos/WollMux/WollMux/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/WollMux/WollMux/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/WollMux/WollMux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WollMux/WollMux/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/WollMux/WollMux/statuses/a2efd94a8ea62e3e76070229bedadb63ef3580e7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27683112,
"name": "WollMux/WollMux",
"url": "https://api.github.com/repos/WollMux/WollMux"
}
|
{
"id": 35487075,
"login": "lhm-jenkins",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35487075?",
"url": "https://api.github.com/users/lhm-jenkins"
}
|
{
"id": 10096468,
"login": "WollMux",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10096468?",
"url": "https://api.github.com/orgs/WollMux"
}
| 2019-12-04T09:27:20 |
11007886966
|
{"actor":{"display_login":"lhm-jenkins"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/comments/299629612","pull_request_review_id":257079547,"id":299629612,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTYyOTYxMg==","diff_hunk":"@@ -0,0 +1,16 @@\n+<?xml version=\"1.0\"?>\n+<jboss-deployment-structure xmlns=\"urn:jboss:deployment-structure:1.2\">\n+\t<deployment>\n+\t\t<exclude-subsystems>\n+\t\t\t<!-- disable the resource-adapters subsystem to prevent the application's HSQLDB driver\n+\t\t\tfrom being included in application server JDBC drivers -->\n+ <subsystem name=\"resource-adapters\" />","path":"powerauth-webflow-client/src/main/webapp/WEB-INF/jboss-deployment-structure.xml","position":7,"original_position":7,"commit_id":"f3e7ed68c03efe2ebb0a7c4bcb2520c38e31787e","original_commit_id":"f3e7ed68c03efe2ebb0a7c4bcb2520c38e31787e","user":{"login":"romanstrobl","id":26658588,"node_id":"MDQ6VXNlcjI2NjU4NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/26658588?v=4","gravatar_id":"","url":"https://api.github.com/users/romanstrobl","html_url":"https://github.com/romanstrobl","followers_url":"https://api.github.com/users/romanstrobl/followers","following_url":"https://api.github.com/users/romanstrobl/following{/other_user}","gists_url":"https://api.github.com/users/romanstrobl/gists{/gist_id}","starred_url":"https://api.github.com/users/romanstrobl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanstrobl/subscriptions","organizations_url":"https://api.github.com/users/romanstrobl/orgs","repos_url":"https://api.github.com/users/romanstrobl/repos","events_url":"https://api.github.com/users/romanstrobl/events{/privacy}","received_events_url":"https://api.github.com/users/romanstrobl/received_events","type":"User","site_admin":false},"body":"The formatting seems a bit off.","created_at":"2019-07-02T18:41:39Z","updated_at":"2019-07-02T18:42:13Z","html_url":"https://github.com/wultra/powerauth-webflow/pull/538#discussion_r299629612","pull_request_url":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/538","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/comments/299629612"},"html":{"href":"https://github.com/wultra/powerauth-webflow/pull/538#discussion_r299629612"},"pull_request":{"href":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/538"}}},"pull_request":{"url":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/538","id":293861559,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzODYxNTU5","html_url":"https://github.com/wultra/powerauth-webflow/pull/538","diff_url":"https://github.com/wultra/powerauth-webflow/pull/538.diff","patch_url":"https://github.com/wultra/powerauth-webflow/pull/538.patch","issue_url":"https://api.github.com/repos/wultra/powerauth-webflow/issues/538","number":538,"state":"open","locked":false,"title":"Configure properly powerauth-webflow-client for JBoss / Wildfly","user":{"login":"saalistaja","id":937429,"node_id":"MDQ6VXNlcjkzNzQyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/937429?v=4","gravatar_id":"","url":"https://api.github.com/users/saalistaja","html_url":"https://github.com/saalistaja","followers_url":"https://api.github.com/users/saalistaja/followers","following_url":"https://api.github.com/users/saalistaja/following{/other_user}","gists_url":"https://api.github.com/users/saalistaja/gists{/gist_id}","starred_url":"https://api.github.com/users/saalistaja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saalistaja/subscriptions","organizations_url":"https://api.github.com/users/saalistaja/orgs","repos_url":"https://api.github.com/users/saalistaja/repos","events_url":"https://api.github.com/users/saalistaja/events{/privacy}","received_events_url":"https://api.github.com/users/saalistaja/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-02T18:15:57Z","updated_at":"2019-07-02T18:42:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4d17ef271b4444ba1044f9c42eea3d6f5351711","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":569080040,"node_id":"MDU6TGFiZWw1NjkwODAwNDA=","url":"https://api.github.com/repos/wultra/powerauth-webflow/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/538/commits","review_comments_url":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/538/comments","review_comment_url":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wultra/powerauth-webflow/issues/538/comments","statuses_url":"https://api.github.com/repos/wultra/powerauth-webflow/statuses/f3e7ed68c03efe2ebb0a7c4bcb2520c38e31787e","head":{"label":"wultra:configure-properly-powerauth-webflow-client-for-wildfly","ref":"configure-properly-powerauth-webflow-client-for-wildfly","sha":"f3e7ed68c03efe2ebb0a7c4bcb2520c38e31787e","user":{"login":"wultra","id":10101099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTAxMDk5","avatar_url":"https://avatars2.githubusercontent.com/u/10101099?v=4","gravatar_id":"","url":"https://api.github.com/users/wultra","html_url":"https://github.com/wultra","followers_url":"https://api.github.com/users/wultra/followers","following_url":"https://api.github.com/users/wultra/following{/other_user}","gists_url":"https://api.github.com/users/wultra/gists{/gist_id}","starred_url":"https://api.github.com/users/wultra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wultra/subscriptions","organizations_url":"https://api.github.com/users/wultra/orgs","repos_url":"https://api.github.com/users/wultra/repos","events_url":"https://api.github.com/users/wultra/events{/privacy}","received_events_url":"https://api.github.com/users/wultra/received_events","type":"Organization","site_admin":false},"repo":{"id":86171619,"node_id":"MDEwOlJlcG9zaXRvcnk4NjE3MTYxOQ==","name":"powerauth-webflow","full_name":"wultra/powerauth-webflow","private":false,"owner":{"login":"wultra","id":10101099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTAxMDk5","avatar_url":"https://avatars2.githubusercontent.com/u/10101099?v=4","gravatar_id":"","url":"https://api.github.com/users/wultra","html_url":"https://github.com/wultra","followers_url":"https://api.github.com/users/wultra/followers","following_url":"https://api.github.com/users/wultra/following{/other_user}","gists_url":"https://api.github.com/users/wultra/gists{/gist_id}","starred_url":"https://api.github.com/users/wultra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wultra/subscriptions","organizations_url":"https://api.github.com/users/wultra/orgs","repos_url":"https://api.github.com/users/wultra/repos","events_url":"https://api.github.com/users/wultra/events{/privacy}","received_events_url":"https://api.github.com/users/wultra/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wultra/powerauth-webflow","description":"PowerAuth Web Authentication - Federated Authentication and Authorization Server for Web","fork":false,"url":"https://api.github.com/repos/wultra/powerauth-webflow","forks_url":"https://api.github.com/repos/wultra/powerauth-webflow/forks","keys_url":"https://api.github.com/repos/wultra/powerauth-webflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wultra/powerauth-webflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wultra/powerauth-webflow/teams","hooks_url":"https://api.github.com/repos/wultra/powerauth-webflow/hooks","issue_events_url":"https://api.github.com/repos/wultra/powerauth-webflow/issues/events{/number}","events_url":"https://api.github.com/repos/wultra/powerauth-webflow/events","assignees_url":"https://api.github.com/repos/wultra/powerauth-webflow/assignees{/user}","branches_url":"https://api.github.com/repos/wultra/powerauth-webflow/branches{/branch}","tags_url":"https://api.github.com/repos/wultra/powerauth-webflow/tags","blobs_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wultra/powerauth-webflow/statuses/{sha}","languages_url":"https://api.github.com/repos/wultra/powerauth-webflow/languages","stargazers_url":"https://api.github.com/repos/wultra/powerauth-webflow/stargazers","contributors_url":"https://api.github.com/repos/wultra/powerauth-webflow/contributors","subscribers_url":"https://api.github.com/repos/wultra/powerauth-webflow/subscribers","subscription_url":"https://api.github.com/repos/wultra/powerauth-webflow/subscription","commits_url":"https://api.github.com/repos/wultra/powerauth-webflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/wultra/powerauth-webflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/wultra/powerauth-webflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/wultra/powerauth-webflow/contents/{+path}","compare_url":"https://api.github.com/repos/wultra/powerauth-webflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wultra/powerauth-webflow/merges","archive_url":"https://api.github.com/repos/wultra/powerauth-webflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wultra/powerauth-webflow/downloads","issues_url":"https://api.github.com/repos/wultra/powerauth-webflow/issues{/number}","pulls_url":"https://api.github.com/repos/wultra/powerauth-webflow/pulls{/number}","milestones_url":"https://api.github.com/repos/wultra/powerauth-webflow/milestones{/number}","notifications_url":"https://api.github.com/repos/wultra/powerauth-webflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wultra/powerauth-webflow/labels{/name}","releases_url":"https://api.github.com/repos/wultra/powerauth-webflow/releases{/id}","deployments_url":"https://api.github.com/repos/wultra/powerauth-webflow/deployments","created_at":"2017-03-25T16:29:41Z","updated_at":"2019-07-02T14:43:48Z","pushed_at":"2019-07-02T18:15:57Z","git_url":"git://github.com/wultra/powerauth-webflow.git","ssh_url":"git@github.com:wultra/powerauth-webflow.git","clone_url":"https://github.com/wultra/powerauth-webflow.git","svn_url":"https://github.com/wultra/powerauth-webflow","homepage":"","size":4057,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":25,"watchers":3,"default_branch":"develop"}},"base":{"label":"wultra:develop","ref":"develop","sha":"ca973aabe53cf69421b792a5cada13478fd2b91b","user":{"login":"wultra","id":10101099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTAxMDk5","avatar_url":"https://avatars2.githubusercontent.com/u/10101099?v=4","gravatar_id":"","url":"https://api.github.com/users/wultra","html_url":"https://github.com/wultra","followers_url":"https://api.github.com/users/wultra/followers","following_url":"https://api.github.com/users/wultra/following{/other_user}","gists_url":"https://api.github.com/users/wultra/gists{/gist_id}","starred_url":"https://api.github.com/users/wultra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wultra/subscriptions","organizations_url":"https://api.github.com/users/wultra/orgs","repos_url":"https://api.github.com/users/wultra/repos","events_url":"https://api.github.com/users/wultra/events{/privacy}","received_events_url":"https://api.github.com/users/wultra/received_events","type":"Organization","site_admin":false},"repo":{"id":86171619,"node_id":"MDEwOlJlcG9zaXRvcnk4NjE3MTYxOQ==","name":"powerauth-webflow","full_name":"wultra/powerauth-webflow","private":false,"owner":{"login":"wultra","id":10101099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTAxMDk5","avatar_url":"https://avatars2.githubusercontent.com/u/10101099?v=4","gravatar_id":"","url":"https://api.github.com/users/wultra","html_url":"https://github.com/wultra","followers_url":"https://api.github.com/users/wultra/followers","following_url":"https://api.github.com/users/wultra/following{/other_user}","gists_url":"https://api.github.com/users/wultra/gists{/gist_id}","starred_url":"https://api.github.com/users/wultra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wultra/subscriptions","organizations_url":"https://api.github.com/users/wultra/orgs","repos_url":"https://api.github.com/users/wultra/repos","events_url":"https://api.github.com/users/wultra/events{/privacy}","received_events_url":"https://api.github.com/users/wultra/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wultra/powerauth-webflow","description":"PowerAuth Web Authentication - Federated Authentication and Authorization Server for Web","fork":false,"url":"https://api.github.com/repos/wultra/powerauth-webflow","forks_url":"https://api.github.com/repos/wultra/powerauth-webflow/forks","keys_url":"https://api.github.com/repos/wultra/powerauth-webflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wultra/powerauth-webflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wultra/powerauth-webflow/teams","hooks_url":"https://api.github.com/repos/wultra/powerauth-webflow/hooks","issue_events_url":"https://api.github.com/repos/wultra/powerauth-webflow/issues/events{/number}","events_url":"https://api.github.com/repos/wultra/powerauth-webflow/events","assignees_url":"https://api.github.com/repos/wultra/powerauth-webflow/assignees{/user}","branches_url":"https://api.github.com/repos/wultra/powerauth-webflow/branches{/branch}","tags_url":"https://api.github.com/repos/wultra/powerauth-webflow/tags","blobs_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wultra/powerauth-webflow/statuses/{sha}","languages_url":"https://api.github.com/repos/wultra/powerauth-webflow/languages","stargazers_url":"https://api.github.com/repos/wultra/powerauth-webflow/stargazers","contributors_url":"https://api.github.com/repos/wultra/powerauth-webflow/contributors","subscribers_url":"https://api.github.com/repos/wultra/powerauth-webflow/subscribers","subscription_url":"https://api.github.com/repos/wultra/powerauth-webflow/subscription","commits_url":"https://api.github.com/repos/wultra/powerauth-webflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/wultra/powerauth-webflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/wultra/powerauth-webflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/wultra/powerauth-webflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/wultra/powerauth-webflow/contents/{+path}","compare_url":"https://api.github.com/repos/wultra/powerauth-webflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wultra/powerauth-webflow/merges","archive_url":"https://api.github.com/repos/wultra/powerauth-webflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wultra/powerauth-webflow/downloads","issues_url":"https://api.github.com/repos/wultra/powerauth-webflow/issues{/number}","pulls_url":"https://api.github.com/repos/wultra/powerauth-webflow/pulls{/number}","milestones_url":"https://api.github.com/repos/wultra/powerauth-webflow/milestones{/number}","notifications_url":"https://api.github.com/repos/wultra/powerauth-webflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wultra/powerauth-webflow/labels{/name}","releases_url":"https://api.github.com/repos/wultra/powerauth-webflow/releases{/id}","deployments_url":"https://api.github.com/repos/wultra/powerauth-webflow/deployments","created_at":"2017-03-25T16:29:41Z","updated_at":"2019-07-02T14:43:48Z","pushed_at":"2019-07-02T18:15:57Z","git_url":"git://github.com/wultra/powerauth-webflow.git","ssh_url":"git@github.com:wultra/powerauth-webflow.git","clone_url":"https://github.com/wultra/powerauth-webflow.git","svn_url":"https://github.com/wultra/powerauth-webflow","homepage":"","size":4057,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":25,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/538"},"html":{"href":"https://github.com/wultra/powerauth-webflow/pull/538"},"issue":{"href":"https://api.github.com/repos/wultra/powerauth-webflow/issues/538"},"comments":{"href":"https://api.github.com/repos/wultra/powerauth-webflow/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wultra/powerauth-webflow/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/wultra/powerauth-webflow/statuses/f3e7ed68c03efe2ebb0a7c4bcb2520c38e31787e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 86171619,
"name": "wultra/powerauth-webflow",
"url": "https://api.github.com/repos/wultra/powerauth-webflow"
}
|
{
"id": 26658588,
"login": "romanstrobl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26658588?",
"url": "https://api.github.com/users/romanstrobl"
}
|
{
"id": 10101099,
"login": "wultra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10101099?",
"url": "https://api.github.com/orgs/wultra"
}
| 2019-07-02T18:41:39 |
9936276522
|
{"actor":{"display_login":"romanstrobl"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/comments/342484332","pull_request_review_id":311632338,"id":342484332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MjQ4NDMzMg==","diff_hunk":"@@ -184,6 +196,17 @@ public function modifyTable()\n }\n }\n \n+ if (!$table->hasColumn('alias_keys')) {","path":"src/Spryker/Zed/SynchronizationBehavior/Persistence/Propel/Behavior/SynchronizationBehavior.php","position":58,"original_position":58,"commit_id":"004a0fcf38c5f3db22150a1254f88a97559495da","original_commit_id":"004a0fcf38c5f3db22150a1254f88a97559495da","user":{"login":"ehsanmx","id":7711957,"node_id":"MDQ6VXNlcjc3MTE5NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7711957?v=4","gravatar_id":"","url":"https://api.github.com/users/ehsanmx","html_url":"https://github.com/ehsanmx","followers_url":"https://api.github.com/users/ehsanmx/followers","following_url":"https://api.github.com/users/ehsanmx/following{/other_user}","gists_url":"https://api.github.com/users/ehsanmx/gists{/gist_id}","starred_url":"https://api.github.com/users/ehsanmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehsanmx/subscriptions","organizations_url":"https://api.github.com/users/ehsanmx/orgs","repos_url":"https://api.github.com/users/ehsanmx/repos","events_url":"https://api.github.com/users/ehsanmx/events{/privacy}","received_events_url":"https://api.github.com/users/ehsanmx/received_events","type":"User","site_admin":false},"body":"This is a major","created_at":"2019-11-05T10:24:21Z","updated_at":"2019-11-05T10:24:26Z","html_url":"https://github.com/spryker/synchronization-behavior/pull/12#discussion_r342484332","pull_request_url":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/12","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/comments/342484332"},"html":{"href":"https://github.com/spryker/synchronization-behavior/pull/12#discussion_r342484332"},"pull_request":{"href":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/12","id":291101839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMTAxODM5","html_url":"https://github.com/spryker/synchronization-behavior/pull/12","diff_url":"https://github.com/spryker/synchronization-behavior/pull/12.diff","patch_url":"https://github.com/spryker/synchronization-behavior/pull/12.patch","issue_url":"https://api.github.com/repos/spryker/synchronization-behavior/issues/12","number":12,"state":"open","locked":false,"title":"Feature/te 663/dev pass by kv storage","user":{"login":"asaulenko","id":20285714,"node_id":"MDQ6VXNlcjIwMjg1NzE0","avatar_url":"https://avatars1.githubusercontent.com/u/20285714?v=4","gravatar_id":"","url":"https://api.github.com/users/asaulenko","html_url":"https://github.com/asaulenko","followers_url":"https://api.github.com/users/asaulenko/followers","following_url":"https://api.github.com/users/asaulenko/following{/other_user}","gists_url":"https://api.github.com/users/asaulenko/gists{/gist_id}","starred_url":"https://api.github.com/users/asaulenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaulenko/subscriptions","organizations_url":"https://api.github.com/users/asaulenko/orgs","repos_url":"https://api.github.com/users/asaulenko/repos","events_url":"https://api.github.com/users/asaulenko/events{/privacy}","received_events_url":"https://api.github.com/users/asaulenko/received_events","type":"User","site_admin":false},"body":"- Developer(s): @asaulenko\r\n\r\n- Ticket: https://spryker.atlassian.net/browse/TE-663\r\n\r\n- Academy PR: ACADEMY_URL_HERE\r\n\r\n- Release Group: https://release.spryker.com/release-groups/view/1547\r\n\r\n\r\n#### Please confirm\r\n\r\n- [ ] No new OS components - or they have been approved by legal department\r\n\r\n#### Documentation\r\n\r\n- [ ] Functional documentation provided or in progress?\r\n- [ ] Integration guide for projects provided or not needed?\r\n- [ ] Migration guides for all contained majors provided or not needed?\r\n\r\n#### Release Table\r\n\r\n Module | Release Type | Constraint Updates |\r\n :--------------------- | :------------------------ | :--------------------- |\r\n SynchronizationBehavior | minor | |\r\n\r\n#### Release Notes\r\n\r\nMade the adjustments to store key mappings in storage/search tables.\r\n\r\n-----------------------------------------\r\n\r\n#### Module SynchronizationBehavior\r\n\r\n##### Change log\r\n\r\nImprovements\r\n\r\n- Adjusted `SynchronizartionBehavior` to add `alias_keys` to each storage table and to build key mappings to be stored in that field.\r\n\r\n","created_at":"2019-06-24T12:05:30Z","updated_at":"2019-11-05T10:24:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0797db7d912d6110d070733e9df8d70b71cfbf2e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":724601127,"node_id":"MDU6TGFiZWw3MjQ2MDExMjc=","url":"https://api.github.com/repos/spryker/synchronization-behavior/labels/improvement","name":"improvement","color":"0052cc","default":false},{"id":996719265,"node_id":"MDU6TGFiZWw5OTY3MTkyNjU=","url":"https://api.github.com/repos/spryker/synchronization-behavior/labels/ready-for-release","name":"ready-for-release","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/12/commits","review_comments_url":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/12/comments","review_comment_url":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spryker/synchronization-behavior/issues/12/comments","statuses_url":"https://api.github.com/repos/spryker/synchronization-behavior/statuses/004a0fcf38c5f3db22150a1254f88a97559495da","head":{"label":"spryker:feature/te-663/dev-pass-by-kv-storage","ref":"feature/te-663/dev-pass-by-kv-storage","sha":"004a0fcf38c5f3db22150a1254f88a97559495da","user":{"login":"spryker","id":10156234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU2MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/10156234?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker","html_url":"https://github.com/spryker","followers_url":"https://api.github.com/users/spryker/followers","following_url":"https://api.github.com/users/spryker/following{/other_user}","gists_url":"https://api.github.com/users/spryker/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker/subscriptions","organizations_url":"https://api.github.com/users/spryker/orgs","repos_url":"https://api.github.com/users/spryker/repos","events_url":"https://api.github.com/users/spryker/events{/privacy}","received_events_url":"https://api.github.com/users/spryker/received_events","type":"Organization","site_admin":false},"repo":{"id":107528654,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1Mjg2NTQ=","name":"synchronization-behavior","full_name":"spryker/synchronization-behavior","private":false,"owner":{"login":"spryker","id":10156234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU2MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/10156234?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker","html_url":"https://github.com/spryker","followers_url":"https://api.github.com/users/spryker/followers","following_url":"https://api.github.com/users/spryker/following{/other_user}","gists_url":"https://api.github.com/users/spryker/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker/subscriptions","organizations_url":"https://api.github.com/users/spryker/orgs","repos_url":"https://api.github.com/users/spryker/repos","events_url":"https://api.github.com/users/spryker/events{/privacy}","received_events_url":"https://api.github.com/users/spryker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spryker/synchronization-behavior","description":"Subtree split of the SynchronizationBehavior module.","fork":false,"url":"https://api.github.com/repos/spryker/synchronization-behavior","forks_url":"https://api.github.com/repos/spryker/synchronization-behavior/forks","keys_url":"https://api.github.com/repos/spryker/synchronization-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spryker/synchronization-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spryker/synchronization-behavior/teams","hooks_url":"https://api.github.com/repos/spryker/synchronization-behavior/hooks","issue_events_url":"https://api.github.com/repos/spryker/synchronization-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/spryker/synchronization-behavior/events","assignees_url":"https://api.github.com/repos/spryker/synchronization-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/spryker/synchronization-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/spryker/synchronization-behavior/tags","blobs_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spryker/synchronization-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/spryker/synchronization-behavior/languages","stargazers_url":"https://api.github.com/repos/spryker/synchronization-behavior/stargazers","contributors_url":"https://api.github.com/repos/spryker/synchronization-behavior/contributors","subscribers_url":"https://api.github.com/repos/spryker/synchronization-behavior/subscribers","subscription_url":"https://api.github.com/repos/spryker/synchronization-behavior/subscription","commits_url":"https://api.github.com/repos/spryker/synchronization-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/spryker/synchronization-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/spryker/synchronization-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/spryker/synchronization-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/spryker/synchronization-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spryker/synchronization-behavior/merges","archive_url":"https://api.github.com/repos/spryker/synchronization-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spryker/synchronization-behavior/downloads","issues_url":"https://api.github.com/repos/spryker/synchronization-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/spryker/synchronization-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/spryker/synchronization-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/spryker/synchronization-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spryker/synchronization-behavior/labels{/name}","releases_url":"https://api.github.com/repos/spryker/synchronization-behavior/releases{/id}","deployments_url":"https://api.github.com/repos/spryker/synchronization-behavior/deployments","created_at":"2017-10-19T09:51:50Z","updated_at":"2019-10-07T20:54:25Z","pushed_at":"2019-11-04T13:04:49Z","git_url":"git://github.com/spryker/synchronization-behavior.git","ssh_url":"git@github.com:spryker/synchronization-behavior.git","clone_url":"https://github.com/spryker/synchronization-behavior.git","svn_url":"https://github.com/spryker/synchronization-behavior","homepage":"https://spryker.com","size":61,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"spryker:master","ref":"master","sha":"a595249fbbec4cae4a45da8f2fa20aaff7440276","user":{"login":"spryker","id":10156234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU2MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/10156234?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker","html_url":"https://github.com/spryker","followers_url":"https://api.github.com/users/spryker/followers","following_url":"https://api.github.com/users/spryker/following{/other_user}","gists_url":"https://api.github.com/users/spryker/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker/subscriptions","organizations_url":"https://api.github.com/users/spryker/orgs","repos_url":"https://api.github.com/users/spryker/repos","events_url":"https://api.github.com/users/spryker/events{/privacy}","received_events_url":"https://api.github.com/users/spryker/received_events","type":"Organization","site_admin":false},"repo":{"id":107528654,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1Mjg2NTQ=","name":"synchronization-behavior","full_name":"spryker/synchronization-behavior","private":false,"owner":{"login":"spryker","id":10156234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU2MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/10156234?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker","html_url":"https://github.com/spryker","followers_url":"https://api.github.com/users/spryker/followers","following_url":"https://api.github.com/users/spryker/following{/other_user}","gists_url":"https://api.github.com/users/spryker/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker/subscriptions","organizations_url":"https://api.github.com/users/spryker/orgs","repos_url":"https://api.github.com/users/spryker/repos","events_url":"https://api.github.com/users/spryker/events{/privacy}","received_events_url":"https://api.github.com/users/spryker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spryker/synchronization-behavior","description":"Subtree split of the SynchronizationBehavior module.","fork":false,"url":"https://api.github.com/repos/spryker/synchronization-behavior","forks_url":"https://api.github.com/repos/spryker/synchronization-behavior/forks","keys_url":"https://api.github.com/repos/spryker/synchronization-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spryker/synchronization-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spryker/synchronization-behavior/teams","hooks_url":"https://api.github.com/repos/spryker/synchronization-behavior/hooks","issue_events_url":"https://api.github.com/repos/spryker/synchronization-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/spryker/synchronization-behavior/events","assignees_url":"https://api.github.com/repos/spryker/synchronization-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/spryker/synchronization-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/spryker/synchronization-behavior/tags","blobs_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spryker/synchronization-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/spryker/synchronization-behavior/languages","stargazers_url":"https://api.github.com/repos/spryker/synchronization-behavior/stargazers","contributors_url":"https://api.github.com/repos/spryker/synchronization-behavior/contributors","subscribers_url":"https://api.github.com/repos/spryker/synchronization-behavior/subscribers","subscription_url":"https://api.github.com/repos/spryker/synchronization-behavior/subscription","commits_url":"https://api.github.com/repos/spryker/synchronization-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/spryker/synchronization-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/spryker/synchronization-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/spryker/synchronization-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/spryker/synchronization-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/spryker/synchronization-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spryker/synchronization-behavior/merges","archive_url":"https://api.github.com/repos/spryker/synchronization-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spryker/synchronization-behavior/downloads","issues_url":"https://api.github.com/repos/spryker/synchronization-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/spryker/synchronization-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/spryker/synchronization-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/spryker/synchronization-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spryker/synchronization-behavior/labels{/name}","releases_url":"https://api.github.com/repos/spryker/synchronization-behavior/releases{/id}","deployments_url":"https://api.github.com/repos/spryker/synchronization-behavior/deployments","created_at":"2017-10-19T09:51:50Z","updated_at":"2019-10-07T20:54:25Z","pushed_at":"2019-11-04T13:04:49Z","git_url":"git://github.com/spryker/synchronization-behavior.git","ssh_url":"git@github.com:spryker/synchronization-behavior.git","clone_url":"https://github.com/spryker/synchronization-behavior.git","svn_url":"https://github.com/spryker/synchronization-behavior","homepage":"https://spryker.com","size":61,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/12"},"html":{"href":"https://github.com/spryker/synchronization-behavior/pull/12"},"issue":{"href":"https://api.github.com/repos/spryker/synchronization-behavior/issues/12"},"comments":{"href":"https://api.github.com/repos/spryker/synchronization-behavior/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spryker/synchronization-behavior/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/spryker/synchronization-behavior/statuses/004a0fcf38c5f3db22150a1254f88a97559495da"}},"author_association":"NONE"}}
|
{
"id": 107528654,
"name": "spryker/synchronization-behavior",
"url": "https://api.github.com/repos/spryker/synchronization-behavior"
}
|
{
"id": 7711957,
"login": "ehsanmx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7711957?",
"url": "https://api.github.com/users/ehsanmx"
}
|
{
"id": 10156234,
"login": "spryker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10156234?",
"url": "https://api.github.com/orgs/spryker"
}
| 2019-11-05T10:24:21 |
10788750467
|
{"actor":{"display_login":"ehsanmx"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/comments/273797341","pull_request_review_id":224767822,"id":273797341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Mzc5NzM0MQ==","diff_hunk":"@@ -260,5 +260,42 @@ window.App.Fields = {\n \t\t\t\t}\n \t\t\t});\n \t\t}\n+\t},\n+\t'Tree':\tclass {\n+\t\tconstructor(treeContainer = $('.js-tree-container')) {\n+\t\t\tif( treeContainer.length > 0 ){\n+\t\t\t\tthis.treeInstance = treeContainer;\n+\t\t\t\tthis.loadTree();\n+\t\t\t}\n+\t\t}\n+\t\t/**\n+\t\t * Get instance of Tree.\n+\t\t * @returns {Tree}\n+\t\t */\n+\t\tstatic getInstance(container = $('.js-tree-container')) {\n+\t\t\tif (typeof window.App.Fields.Tree.instance === 'undefined') {\n+\t\t\t\twindow.App.Fields.Tree.instance = new window.App.Fields.Tree(container);\n+\t\t\t}\n+\t\t\treturn window.App.Fields.Tree.instance;\n+\t\t}\n+\t\tloadTree() {\n+\t\t\tthis.generateTree(JSON.parse(this.treeInstance.find('.js-tree-data').val()));\n+\t\t}\n+\t\tgenerateTree(treeData) {\n+\t\t\tthis.treeInstance.jstree({\n+\t\t\t\t'core' : {\n+\t\t\t\t\tdata: treeData,\n+\t\t\t\t\tthemes: {\n+\t\t\t\t\t\tname: 'proton',\n+\t\t\t\t\t\tresponsive: true\n+\t\t\t\t\t},\n+\t\t\t\t},\n+\t\t\t\t/*'checkbox': {\n+\t\t\t\t\tthree_state: false,\n+\t\t\t\t\tcascade: 'up'","path":"public_html/layouts/Default/resources/Fields.js","position":36,"original_position":36,"commit_id":"ed5d31cebcbb04444828707779802bae415b61c7","original_commit_id":"ed5d31cebcbb04444828707779802bae415b61c7","user":{"login":"mariuszkrzaczkowski","id":10198654,"node_id":"MDQ6VXNlcjEwMTk4NjU0","avatar_url":"https://avatars2.githubusercontent.com/u/10198654?v=4","gravatar_id":"","url":"https://api.github.com/users/mariuszkrzaczkowski","html_url":"https://github.com/mariuszkrzaczkowski","followers_url":"https://api.github.com/users/mariuszkrzaczkowski/followers","following_url":"https://api.github.com/users/mariuszkrzaczkowski/following{/other_user}","gists_url":"https://api.github.com/users/mariuszkrzaczkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mariuszkrzaczkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariuszkrzaczkowski/subscriptions","organizations_url":"https://api.github.com/users/mariuszkrzaczkowski/orgs","repos_url":"https://api.github.com/users/mariuszkrzaczkowski/repos","events_url":"https://api.github.com/users/mariuszkrzaczkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mariuszkrzaczkowski/received_events","type":"User","site_admin":false},"body":"?","created_at":"2019-04-10T05:48:24Z","updated_at":"2019-04-10T05:49:18Z","html_url":"https://github.com/YetiForceCompany/YetiForcePortal2/pull/37#discussion_r273797341","pull_request_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/37","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/comments/273797341"},"html":{"href":"https://github.com/YetiForceCompany/YetiForcePortal2/pull/37#discussion_r273797341"},"pull_request":{"href":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/37","id":267396335,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3Mzk2MzM1","html_url":"https://github.com/YetiForceCompany/YetiForcePortal2/pull/37","diff_url":"https://github.com/YetiForceCompany/YetiForcePortal2/pull/37.diff","patch_url":"https://github.com/YetiForceCompany/YetiForcePortal2/pull/37.patch","issue_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/issues/37","number":37,"state":"closed","locked":false,"title":"Product, category and jstree","user":{"login":"arek1-618","id":32322851,"node_id":"MDQ6VXNlcjMyMzIyODUx","avatar_url":"https://avatars1.githubusercontent.com/u/32322851?v=4","gravatar_id":"","url":"https://api.github.com/users/arek1-618","html_url":"https://github.com/arek1-618","followers_url":"https://api.github.com/users/arek1-618/followers","following_url":"https://api.github.com/users/arek1-618/following{/other_user}","gists_url":"https://api.github.com/users/arek1-618/gists{/gist_id}","starred_url":"https://api.github.com/users/arek1-618/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arek1-618/subscriptions","organizations_url":"https://api.github.com/users/arek1-618/orgs","repos_url":"https://api.github.com/users/arek1-618/repos","events_url":"https://api.github.com/users/arek1-618/events{/privacy}","received_events_url":"https://api.github.com/users/arek1-618/received_events","type":"User","site_admin":false},"body":"Product, category and jstree","created_at":"2019-04-04T10:56:54Z","updated_at":"2019-04-10T05:49:17Z","closed_at":"2019-04-09T11:57:06Z","merged_at":"2019-04-09T11:57:06Z","merge_commit_sha":"534fd10129ff089322b772d2226c121130fce99e","assignee":{"login":"mariuszkrzaczkowski","id":10198654,"node_id":"MDQ6VXNlcjEwMTk4NjU0","avatar_url":"https://avatars2.githubusercontent.com/u/10198654?v=4","gravatar_id":"","url":"https://api.github.com/users/mariuszkrzaczkowski","html_url":"https://github.com/mariuszkrzaczkowski","followers_url":"https://api.github.com/users/mariuszkrzaczkowski/followers","following_url":"https://api.github.com/users/mariuszkrzaczkowski/following{/other_user}","gists_url":"https://api.github.com/users/mariuszkrzaczkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mariuszkrzaczkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariuszkrzaczkowski/subscriptions","organizations_url":"https://api.github.com/users/mariuszkrzaczkowski/orgs","repos_url":"https://api.github.com/users/mariuszkrzaczkowski/repos","events_url":"https://api.github.com/users/mariuszkrzaczkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mariuszkrzaczkowski/received_events","type":"User","site_admin":false},"assignees":[{"login":"mariuszkrzaczkowski","id":10198654,"node_id":"MDQ6VXNlcjEwMTk4NjU0","avatar_url":"https://avatars2.githubusercontent.com/u/10198654?v=4","gravatar_id":"","url":"https://api.github.com/users/mariuszkrzaczkowski","html_url":"https://github.com/mariuszkrzaczkowski","followers_url":"https://api.github.com/users/mariuszkrzaczkowski/followers","following_url":"https://api.github.com/users/mariuszkrzaczkowski/following{/other_user}","gists_url":"https://api.github.com/users/mariuszkrzaczkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mariuszkrzaczkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariuszkrzaczkowski/subscriptions","organizations_url":"https://api.github.com/users/mariuszkrzaczkowski/orgs","repos_url":"https://api.github.com/users/mariuszkrzaczkowski/repos","events_url":"https://api.github.com/users/mariuszkrzaczkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mariuszkrzaczkowski/received_events","type":"User","site_admin":false},{"login":"TomaszQr","id":14273211,"node_id":"MDQ6VXNlcjE0MjczMjEx","avatar_url":"https://avatars2.githubusercontent.com/u/14273211?v=4","gravatar_id":"","url":"https://api.github.com/users/TomaszQr","html_url":"https://github.com/TomaszQr","followers_url":"https://api.github.com/users/TomaszQr/followers","following_url":"https://api.github.com/users/TomaszQr/following{/other_user}","gists_url":"https://api.github.com/users/TomaszQr/gists{/gist_id}","starred_url":"https://api.github.com/users/TomaszQr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomaszQr/subscriptions","organizations_url":"https://api.github.com/users/TomaszQr/orgs","repos_url":"https://api.github.com/users/TomaszQr/repos","events_url":"https://api.github.com/users/TomaszQr/events{/privacy}","received_events_url":"https://api.github.com/users/TomaszQr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1037835927,"node_id":"MDU6TGFiZWwxMDM3ODM1OTI3","url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/labels/finished","name":"finished","color":"e0ef92","default":false}],"milestone":{"url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/milestones/1","html_url":"https://github.com/YetiForceCompany/YetiForcePortal2/milestone/1","labels_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/milestones/1/labels","id":3600601,"node_id":"MDk6TWlsZXN0b25lMzYwMDYwMQ==","number":1,"title":"0.1.0","description":"","creator":{"login":"mariuszkrzaczkowski","id":10198654,"node_id":"MDQ6VXNlcjEwMTk4NjU0","avatar_url":"https://avatars2.githubusercontent.com/u/10198654?v=4","gravatar_id":"","url":"https://api.github.com/users/mariuszkrzaczkowski","html_url":"https://github.com/mariuszkrzaczkowski","followers_url":"https://api.github.com/users/mariuszkrzaczkowski/followers","following_url":"https://api.github.com/users/mariuszkrzaczkowski/following{/other_user}","gists_url":"https://api.github.com/users/mariuszkrzaczkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mariuszkrzaczkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariuszkrzaczkowski/subscriptions","organizations_url":"https://api.github.com/users/mariuszkrzaczkowski/orgs","repos_url":"https://api.github.com/users/mariuszkrzaczkowski/repos","events_url":"https://api.github.com/users/mariuszkrzaczkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mariuszkrzaczkowski/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":22,"state":"open","created_at":"2018-08-27T12:28:20Z","updated_at":"2019-04-09T14:00:27Z","due_on":"2018-09-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/37/commits","review_comments_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/37/comments","review_comment_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/issues/37/comments","statuses_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/statuses/ed5d31cebcbb04444828707779802bae415b61c7","head":{"label":"arek1-618:2019/04/04/01","ref":"2019/04/04/01","sha":"ed5d31cebcbb04444828707779802bae415b61c7","user":{"login":"arek1-618","id":32322851,"node_id":"MDQ6VXNlcjMyMzIyODUx","avatar_url":"https://avatars1.githubusercontent.com/u/32322851?v=4","gravatar_id":"","url":"https://api.github.com/users/arek1-618","html_url":"https://github.com/arek1-618","followers_url":"https://api.github.com/users/arek1-618/followers","following_url":"https://api.github.com/users/arek1-618/following{/other_user}","gists_url":"https://api.github.com/users/arek1-618/gists{/gist_id}","starred_url":"https://api.github.com/users/arek1-618/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arek1-618/subscriptions","organizations_url":"https://api.github.com/users/arek1-618/orgs","repos_url":"https://api.github.com/users/arek1-618/repos","events_url":"https://api.github.com/users/arek1-618/events{/privacy}","received_events_url":"https://api.github.com/users/arek1-618/received_events","type":"User","site_admin":false},"repo":{"id":178806592,"node_id":"MDEwOlJlcG9zaXRvcnkxNzg4MDY1OTI=","name":"YetiForcePortal2","full_name":"arek1-618/YetiForcePortal2","private":false,"owner":{"login":"arek1-618","id":32322851,"node_id":"MDQ6VXNlcjMyMzIyODUx","avatar_url":"https://avatars1.githubusercontent.com/u/32322851?v=4","gravatar_id":"","url":"https://api.github.com/users/arek1-618","html_url":"https://github.com/arek1-618","followers_url":"https://api.github.com/users/arek1-618/followers","following_url":"https://api.github.com/users/arek1-618/following{/other_user}","gists_url":"https://api.github.com/users/arek1-618/gists{/gist_id}","starred_url":"https://api.github.com/users/arek1-618/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arek1-618/subscriptions","organizations_url":"https://api.github.com/users/arek1-618/orgs","repos_url":"https://api.github.com/users/arek1-618/repos","events_url":"https://api.github.com/users/arek1-618/events{/privacy}","received_events_url":"https://api.github.com/users/arek1-618/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arek1-618/YetiForcePortal2","description":null,"fork":true,"url":"https://api.github.com/repos/arek1-618/YetiForcePortal2","forks_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/forks","keys_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/teams","hooks_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/hooks","issue_events_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/issues/events{/number}","events_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/events","assignees_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/assignees{/user}","branches_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/branches{/branch}","tags_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/tags","blobs_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/git/refs{/sha}","trees_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/statuses/{sha}","languages_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/languages","stargazers_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/stargazers","contributors_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/contributors","subscribers_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/subscribers","subscription_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/subscription","commits_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/commits{/sha}","git_commits_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/git/commits{/sha}","comments_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/comments{/number}","issue_comment_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/issues/comments{/number}","contents_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/contents/{+path}","compare_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/merges","archive_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/downloads","issues_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/issues{/number}","pulls_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/pulls{/number}","milestones_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/milestones{/number}","notifications_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/labels{/name}","releases_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/releases{/id}","deployments_url":"https://api.github.com/repos/arek1-618/YetiForcePortal2/deployments","created_at":"2019-04-01T07:14:01Z","updated_at":"2019-04-01T07:14:04Z","pushed_at":"2019-04-09T13:56:41Z","git_url":"git://github.com/arek1-618/YetiForcePortal2.git","ssh_url":"git@github.com:arek1-618/YetiForcePortal2.git","clone_url":"https://github.com/arek1-618/YetiForcePortal2.git","svn_url":"https://github.com/arek1-618/YetiForcePortal2","homepage":null,"size":6197,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"developer"}},"base":{"label":"YetiForceCompany:developer","ref":"developer","sha":"b8da25bb1e0f204e69115f8c24fb53c3b80ad4bd","user":{"login":"YetiForceCompany","id":10201412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjAxNDEy","avatar_url":"https://avatars2.githubusercontent.com/u/10201412?v=4","gravatar_id":"","url":"https://api.github.com/users/YetiForceCompany","html_url":"https://github.com/YetiForceCompany","followers_url":"https://api.github.com/users/YetiForceCompany/followers","following_url":"https://api.github.com/users/YetiForceCompany/following{/other_user}","gists_url":"https://api.github.com/users/YetiForceCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/YetiForceCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YetiForceCompany/subscriptions","organizations_url":"https://api.github.com/users/YetiForceCompany/orgs","repos_url":"https://api.github.com/users/YetiForceCompany/repos","events_url":"https://api.github.com/users/YetiForceCompany/events{/privacy}","received_events_url":"https://api.github.com/users/YetiForceCompany/received_events","type":"Organization","site_admin":false},"repo":{"id":38607163,"node_id":"MDEwOlJlcG9zaXRvcnkzODYwNzE2Mw==","name":"YetiForcePortal2","full_name":"YetiForceCompany/YetiForcePortal2","private":false,"owner":{"login":"YetiForceCompany","id":10201412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjAxNDEy","avatar_url":"https://avatars2.githubusercontent.com/u/10201412?v=4","gravatar_id":"","url":"https://api.github.com/users/YetiForceCompany","html_url":"https://github.com/YetiForceCompany","followers_url":"https://api.github.com/users/YetiForceCompany/followers","following_url":"https://api.github.com/users/YetiForceCompany/following{/other_user}","gists_url":"https://api.github.com/users/YetiForceCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/YetiForceCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YetiForceCompany/subscriptions","organizations_url":"https://api.github.com/users/YetiForceCompany/orgs","repos_url":"https://api.github.com/users/YetiForceCompany/repos","events_url":"https://api.github.com/users/YetiForceCompany/events{/privacy}","received_events_url":"https://api.github.com/users/YetiForceCompany/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/YetiForceCompany/YetiForcePortal2","description":null,"fork":false,"url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2","forks_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/forks","keys_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/teams","hooks_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/hooks","issue_events_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/issues/events{/number}","events_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/events","assignees_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/assignees{/user}","branches_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/branches{/branch}","tags_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/tags","blobs_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/git/refs{/sha}","trees_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/statuses/{sha}","languages_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/languages","stargazers_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/stargazers","contributors_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/contributors","subscribers_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/subscribers","subscription_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/subscription","commits_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/commits{/sha}","git_commits_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/git/commits{/sha}","comments_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/comments{/number}","issue_comment_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/issues/comments{/number}","contents_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/contents/{+path}","compare_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/merges","archive_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/downloads","issues_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/issues{/number}","pulls_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls{/number}","milestones_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/milestones{/number}","notifications_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/labels{/name}","releases_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/releases{/id}","deployments_url":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/deployments","created_at":"2015-07-06T08:39:13Z","updated_at":"2019-04-09T11:57:08Z","pushed_at":"2019-04-09T14:00:28Z","git_url":"git://github.com/YetiForceCompany/YetiForcePortal2.git","ssh_url":"git@github.com:YetiForceCompany/YetiForcePortal2.git","clone_url":"https://github.com/YetiForceCompany/YetiForcePortal2.git","svn_url":"https://github.com/YetiForceCompany/YetiForcePortal2","homepage":null,"size":6145,"stargazers_count":20,"watchers_count":20,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":3,"watchers":20,"default_branch":"developer"}},"_links":{"self":{"href":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/37"},"html":{"href":"https://github.com/YetiForceCompany/YetiForcePortal2/pull/37"},"issue":{"href":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/issues/37"},"comments":{"href":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/YetiForceCompany/YetiForcePortal2/statuses/ed5d31cebcbb04444828707779802bae415b61c7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 38607163,
"name": "YetiForceCompany/YetiForcePortal2",
"url": "https://api.github.com/repos/YetiForceCompany/YetiForcePortal2"
}
|
{
"id": 10198654,
"login": "mariuszkrzaczkowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10198654?",
"url": "https://api.github.com/users/mariuszkrzaczkowski"
}
|
{
"id": 10201412,
"login": "YetiForceCompany",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10201412?",
"url": "https://api.github.com/orgs/YetiForceCompany"
}
| 2019-04-10T05:48:24 |
9412807396
|
{"actor":{"display_login":"mariuszkrzaczkowski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pachyderm/pachyderm/pulls/comments/253605379","pull_request_review_id":199757915,"id":253605379,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzYwNTM3OQ==","diff_hunk":"@@ -30,6 +31,13 @@ message CancelResponse {\n service Worker {\n rpc Status(google.protobuf.Empty) returns (pps.WorkerStatus) {}\n rpc Cancel(CancelRequest) returns (CancelResponse) {}\n+ rpc CollectChunk(CollectChunkRequest) returns (stream google.protobuf.BytesValue) {}","path":"src/server/worker/worker_service.proto","position":12,"original_position":12,"commit_id":"3d38346f6e9c9493b43ad23745a54e0809fc9eac","original_commit_id":"3d38346f6e9c9493b43ad23745a54e0809fc9eac","user":{"login":"brycemcanally","id":34780592,"node_id":"MDQ6VXNlcjM0NzgwNTky","avatar_url":"https://avatars0.githubusercontent.com/u/34780592?v=4","gravatar_id":"","url":"https://api.github.com/users/brycemcanally","html_url":"https://github.com/brycemcanally","followers_url":"https://api.github.com/users/brycemcanally/followers","following_url":"https://api.github.com/users/brycemcanally/following{/other_user}","gists_url":"https://api.github.com/users/brycemcanally/gists{/gist_id}","starred_url":"https://api.github.com/users/brycemcanally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brycemcanally/subscriptions","organizations_url":"https://api.github.com/users/brycemcanally/orgs","repos_url":"https://api.github.com/users/brycemcanally/repos","events_url":"https://api.github.com/users/brycemcanally/events{/privacy}","received_events_url":"https://api.github.com/users/brycemcanally/received_events","type":"User","site_admin":false},"body":"Sure.","created_at":"2019-02-04T19:14:40Z","updated_at":"2019-02-04T19:14:40Z","html_url":"https://github.com/pachyderm/pachyderm/pull/3349#discussion_r253605379","pull_request_url":"https://api.github.com/repos/pachyderm/pachyderm/pulls/3349","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pachyderm/pachyderm/pulls/comments/253605379"},"html":{"href":"https://github.com/pachyderm/pachyderm/pull/3349#discussion_r253605379"},"pull_request":{"href":"https://api.github.com/repos/pachyderm/pachyderm/pulls/3349"}},"in_reply_to_id":253240791},"pull_request":{"url":"https://api.github.com/repos/pachyderm/pachyderm/pulls/3349","id":243807731,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQzODA3NzMx","html_url":"https://github.com/pachyderm/pachyderm/pull/3349","diff_url":"https://github.com/pachyderm/pachyderm/pull/3349.diff","patch_url":"https://github.com/pachyderm/pachyderm/pull/3349.patch","issue_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/3349","number":3349,"state":"open","locked":false,"title":"Shuffle Step","user":{"login":"brycemcanally","id":34780592,"node_id":"MDQ6VXNlcjM0NzgwNTky","avatar_url":"https://avatars0.githubusercontent.com/u/34780592?v=4","gravatar_id":"","url":"https://api.github.com/users/brycemcanally","html_url":"https://github.com/brycemcanally","followers_url":"https://api.github.com/users/brycemcanally/followers","following_url":"https://api.github.com/users/brycemcanally/following{/other_user}","gists_url":"https://api.github.com/users/brycemcanally/gists{/gist_id}","starred_url":"https://api.github.com/users/brycemcanally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brycemcanally/subscriptions","organizations_url":"https://api.github.com/users/brycemcanally/orgs","repos_url":"https://api.github.com/users/brycemcanally/repos","events_url":"https://api.github.com/users/brycemcanally/events{/privacy}","received_events_url":"https://api.github.com/users/brycemcanally/received_events","type":"User","site_admin":false},"body":"This PR is intended for tracking the first pass implementation of the shuffle-step in Pachyderm. This implementation should not need migration because we will have the workers fall back on the previous model in the case where the shuffle data is not available. ","created_at":"2019-01-10T19:45:50Z","updated_at":"2019-02-04T19:14:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72c69e5a03ca4d1769c54e185919f15fcc24af95","assignee":{"login":"jdoliner","id":43867,"node_id":"MDQ6VXNlcjQzODY3","avatar_url":"https://avatars3.githubusercontent.com/u/43867?v=4","gravatar_id":"","url":"https://api.github.com/users/jdoliner","html_url":"https://github.com/jdoliner","followers_url":"https://api.github.com/users/jdoliner/followers","following_url":"https://api.github.com/users/jdoliner/following{/other_user}","gists_url":"https://api.github.com/users/jdoliner/gists{/gist_id}","starred_url":"https://api.github.com/users/jdoliner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdoliner/subscriptions","organizations_url":"https://api.github.com/users/jdoliner/orgs","repos_url":"https://api.github.com/users/jdoliner/repos","events_url":"https://api.github.com/users/jdoliner/events{/privacy}","received_events_url":"https://api.github.com/users/jdoliner/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdoliner","id":43867,"node_id":"MDQ6VXNlcjQzODY3","avatar_url":"https://avatars3.githubusercontent.com/u/43867?v=4","gravatar_id":"","url":"https://api.github.com/users/jdoliner","html_url":"https://github.com/jdoliner","followers_url":"https://api.github.com/users/jdoliner/followers","following_url":"https://api.github.com/users/jdoliner/following{/other_user}","gists_url":"https://api.github.com/users/jdoliner/gists{/gist_id}","starred_url":"https://api.github.com/users/jdoliner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdoliner/subscriptions","organizations_url":"https://api.github.com/users/jdoliner/orgs","repos_url":"https://api.github.com/users/jdoliner/repos","events_url":"https://api.github.com/users/jdoliner/events{/privacy}","received_events_url":"https://api.github.com/users/jdoliner/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pachyderm/pachyderm/pulls/3349/commits","review_comments_url":"https://api.github.com/repos/pachyderm/pachyderm/pulls/3349/comments","review_comment_url":"https://api.github.com/repos/pachyderm/pachyderm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/3349/comments","statuses_url":"https://api.github.com/repos/pachyderm/pachyderm/statuses/3d38346f6e9c9493b43ad23745a54e0809fc9eac","head":{"label":"pachyderm:shuffle-step","ref":"shuffle-step","sha":"3d38346f6e9c9493b43ad23745a54e0809fc9eac","user":{"login":"pachyderm","id":10432478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDMyNDc4","avatar_url":"https://avatars3.githubusercontent.com/u/10432478?v=4","gravatar_id":"","url":"https://api.github.com/users/pachyderm","html_url":"https://github.com/pachyderm","followers_url":"https://api.github.com/users/pachyderm/followers","following_url":"https://api.github.com/users/pachyderm/following{/other_user}","gists_url":"https://api.github.com/users/pachyderm/gists{/gist_id}","starred_url":"https://api.github.com/users/pachyderm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pachyderm/subscriptions","organizations_url":"https://api.github.com/users/pachyderm/orgs","repos_url":"https://api.github.com/users/pachyderm/repos","events_url":"https://api.github.com/users/pachyderm/events{/privacy}","received_events_url":"https://api.github.com/users/pachyderm/received_events","type":"Organization","site_admin":false},"repo":{"id":23653453,"node_id":"MDEwOlJlcG9zaXRvcnkyMzY1MzQ1Mw==","name":"pachyderm","full_name":"pachyderm/pachyderm","private":false,"owner":{"login":"pachyderm","id":10432478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDMyNDc4","avatar_url":"https://avatars3.githubusercontent.com/u/10432478?v=4","gravatar_id":"","url":"https://api.github.com/users/pachyderm","html_url":"https://github.com/pachyderm","followers_url":"https://api.github.com/users/pachyderm/followers","following_url":"https://api.github.com/users/pachyderm/following{/other_user}","gists_url":"https://api.github.com/users/pachyderm/gists{/gist_id}","starred_url":"https://api.github.com/users/pachyderm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pachyderm/subscriptions","organizations_url":"https://api.github.com/users/pachyderm/orgs","repos_url":"https://api.github.com/users/pachyderm/repos","events_url":"https://api.github.com/users/pachyderm/events{/privacy}","received_events_url":"https://api.github.com/users/pachyderm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pachyderm/pachyderm","description":"Reproducible Data Science at Scale!","fork":false,"url":"https://api.github.com/repos/pachyderm/pachyderm","forks_url":"https://api.github.com/repos/pachyderm/pachyderm/forks","keys_url":"https://api.github.com/repos/pachyderm/pachyderm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pachyderm/pachyderm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pachyderm/pachyderm/teams","hooks_url":"https://api.github.com/repos/pachyderm/pachyderm/hooks","issue_events_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/events{/number}","events_url":"https://api.github.com/repos/pachyderm/pachyderm/events","assignees_url":"https://api.github.com/repos/pachyderm/pachyderm/assignees{/user}","branches_url":"https://api.github.com/repos/pachyderm/pachyderm/branches{/branch}","tags_url":"https://api.github.com/repos/pachyderm/pachyderm/tags","blobs_url":"https://api.github.com/repos/pachyderm/pachyderm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pachyderm/pachyderm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pachyderm/pachyderm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pachyderm/pachyderm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pachyderm/pachyderm/statuses/{sha}","languages_url":"https://api.github.com/repos/pachyderm/pachyderm/languages","stargazers_url":"https://api.github.com/repos/pachyderm/pachyderm/stargazers","contributors_url":"https://api.github.com/repos/pachyderm/pachyderm/contributors","subscribers_url":"https://api.github.com/repos/pachyderm/pachyderm/subscribers","subscription_url":"https://api.github.com/repos/pachyderm/pachyderm/subscription","commits_url":"https://api.github.com/repos/pachyderm/pachyderm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pachyderm/pachyderm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pachyderm/pachyderm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pachyderm/pachyderm/contents/{+path}","compare_url":"https://api.github.com/repos/pachyderm/pachyderm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pachyderm/pachyderm/merges","archive_url":"https://api.github.com/repos/pachyderm/pachyderm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pachyderm/pachyderm/downloads","issues_url":"https://api.github.com/repos/pachyderm/pachyderm/issues{/number}","pulls_url":"https://api.github.com/repos/pachyderm/pachyderm/pulls{/number}","milestones_url":"https://api.github.com/repos/pachyderm/pachyderm/milestones{/number}","notifications_url":"https://api.github.com/repos/pachyderm/pachyderm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pachyderm/pachyderm/labels{/name}","releases_url":"https://api.github.com/repos/pachyderm/pachyderm/releases{/id}","deployments_url":"https://api.github.com/repos/pachyderm/pachyderm/deployments","created_at":"2014-09-04T07:50:02Z","updated_at":"2019-02-04T19:03:18Z","pushed_at":"2019-02-04T18:50:56Z","git_url":"git://github.com/pachyderm/pachyderm.git","ssh_url":"git@github.com:pachyderm/pachyderm.git","clone_url":"https://github.com/pachyderm/pachyderm.git","svn_url":"https://github.com/pachyderm/pachyderm","homepage":"http://pachyderm.io","size":126290,"stargazers_count":3426,"watchers_count":3426,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"archived":false,"open_issues_count":494,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":331,"open_issues":494,"watchers":3426,"default_branch":"master"}},"base":{"label":"pachyderm:master","ref":"master","sha":"985cf6c635410235d674bbfbc56d993e2536f3a7","user":{"login":"pachyderm","id":10432478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDMyNDc4","avatar_url":"https://avatars3.githubusercontent.com/u/10432478?v=4","gravatar_id":"","url":"https://api.github.com/users/pachyderm","html_url":"https://github.com/pachyderm","followers_url":"https://api.github.com/users/pachyderm/followers","following_url":"https://api.github.com/users/pachyderm/following{/other_user}","gists_url":"https://api.github.com/users/pachyderm/gists{/gist_id}","starred_url":"https://api.github.com/users/pachyderm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pachyderm/subscriptions","organizations_url":"https://api.github.com/users/pachyderm/orgs","repos_url":"https://api.github.com/users/pachyderm/repos","events_url":"https://api.github.com/users/pachyderm/events{/privacy}","received_events_url":"https://api.github.com/users/pachyderm/received_events","type":"Organization","site_admin":false},"repo":{"id":23653453,"node_id":"MDEwOlJlcG9zaXRvcnkyMzY1MzQ1Mw==","name":"pachyderm","full_name":"pachyderm/pachyderm","private":false,"owner":{"login":"pachyderm","id":10432478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDMyNDc4","avatar_url":"https://avatars3.githubusercontent.com/u/10432478?v=4","gravatar_id":"","url":"https://api.github.com/users/pachyderm","html_url":"https://github.com/pachyderm","followers_url":"https://api.github.com/users/pachyderm/followers","following_url":"https://api.github.com/users/pachyderm/following{/other_user}","gists_url":"https://api.github.com/users/pachyderm/gists{/gist_id}","starred_url":"https://api.github.com/users/pachyderm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pachyderm/subscriptions","organizations_url":"https://api.github.com/users/pachyderm/orgs","repos_url":"https://api.github.com/users/pachyderm/repos","events_url":"https://api.github.com/users/pachyderm/events{/privacy}","received_events_url":"https://api.github.com/users/pachyderm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pachyderm/pachyderm","description":"Reproducible Data Science at Scale!","fork":false,"url":"https://api.github.com/repos/pachyderm/pachyderm","forks_url":"https://api.github.com/repos/pachyderm/pachyderm/forks","keys_url":"https://api.github.com/repos/pachyderm/pachyderm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pachyderm/pachyderm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pachyderm/pachyderm/teams","hooks_url":"https://api.github.com/repos/pachyderm/pachyderm/hooks","issue_events_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/events{/number}","events_url":"https://api.github.com/repos/pachyderm/pachyderm/events","assignees_url":"https://api.github.com/repos/pachyderm/pachyderm/assignees{/user}","branches_url":"https://api.github.com/repos/pachyderm/pachyderm/branches{/branch}","tags_url":"https://api.github.com/repos/pachyderm/pachyderm/tags","blobs_url":"https://api.github.com/repos/pachyderm/pachyderm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pachyderm/pachyderm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pachyderm/pachyderm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pachyderm/pachyderm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pachyderm/pachyderm/statuses/{sha}","languages_url":"https://api.github.com/repos/pachyderm/pachyderm/languages","stargazers_url":"https://api.github.com/repos/pachyderm/pachyderm/stargazers","contributors_url":"https://api.github.com/repos/pachyderm/pachyderm/contributors","subscribers_url":"https://api.github.com/repos/pachyderm/pachyderm/subscribers","subscription_url":"https://api.github.com/repos/pachyderm/pachyderm/subscription","commits_url":"https://api.github.com/repos/pachyderm/pachyderm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pachyderm/pachyderm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pachyderm/pachyderm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pachyderm/pachyderm/contents/{+path}","compare_url":"https://api.github.com/repos/pachyderm/pachyderm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pachyderm/pachyderm/merges","archive_url":"https://api.github.com/repos/pachyderm/pachyderm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pachyderm/pachyderm/downloads","issues_url":"https://api.github.com/repos/pachyderm/pachyderm/issues{/number}","pulls_url":"https://api.github.com/repos/pachyderm/pachyderm/pulls{/number}","milestones_url":"https://api.github.com/repos/pachyderm/pachyderm/milestones{/number}","notifications_url":"https://api.github.com/repos/pachyderm/pachyderm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pachyderm/pachyderm/labels{/name}","releases_url":"https://api.github.com/repos/pachyderm/pachyderm/releases{/id}","deployments_url":"https://api.github.com/repos/pachyderm/pachyderm/deployments","created_at":"2014-09-04T07:50:02Z","updated_at":"2019-02-04T19:03:18Z","pushed_at":"2019-02-04T18:50:56Z","git_url":"git://github.com/pachyderm/pachyderm.git","ssh_url":"git@github.com:pachyderm/pachyderm.git","clone_url":"https://github.com/pachyderm/pachyderm.git","svn_url":"https://github.com/pachyderm/pachyderm","homepage":"http://pachyderm.io","size":126290,"stargazers_count":3426,"watchers_count":3426,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"archived":false,"open_issues_count":494,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":331,"open_issues":494,"watchers":3426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pachyderm/pachyderm/pulls/3349"},"html":{"href":"https://github.com/pachyderm/pachyderm/pull/3349"},"issue":{"href":"https://api.github.com/repos/pachyderm/pachyderm/issues/3349"},"comments":{"href":"https://api.github.com/repos/pachyderm/pachyderm/issues/3349/comments"},"review_comments":{"href":"https://api.github.com/repos/pachyderm/pachyderm/pulls/3349/comments"},"review_comment":{"href":"https://api.github.com/repos/pachyderm/pachyderm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pachyderm/pachyderm/pulls/3349/commits"},"statuses":{"href":"https://api.github.com/repos/pachyderm/pachyderm/statuses/3d38346f6e9c9493b43ad23745a54e0809fc9eac"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 23653453,
"name": "pachyderm/pachyderm",
"url": "https://api.github.com/repos/pachyderm/pachyderm"
}
|
{
"id": 34780592,
"login": "brycemcanally",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34780592?",
"url": "https://api.github.com/users/brycemcanally"
}
|
{
"id": 10432478,
"login": "pachyderm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10432478?",
"url": "https://api.github.com/orgs/pachyderm"
}
| 2019-02-04T19:14:40 |
9006134678
|
{"actor":{"display_login":"brycemcanally"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/305216538","pull_request_review_id":264032614,"id":305216538,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTIxNjUzOA==","diff_hunk":"@@ -190,16 +190,8 @@ Bug: N/A\n \n We need an easy way to edit the Package.swift manifest from automated tools, for\n cases where you don't want users to have to update the Swift code directly. We\n-think that it's possible to provide API to allow this, probably using","path":"Documentation/EvolutionIdeas.md","position":88,"original_position":88,"commit_id":"df833814f9f95d338a7443d6f26207c090515512","original_commit_id":"f20145122b7065dc70e94d3e31dee21f6078705a","user":{"login":"HaydenMcCabe","id":27537409,"node_id":"MDQ6VXNlcjI3NTM3NDA5","avatar_url":"https://avatars2.githubusercontent.com/u/27537409?v=4","gravatar_id":"","url":"https://api.github.com/users/HaydenMcCabe","html_url":"https://github.com/HaydenMcCabe","followers_url":"https://api.github.com/users/HaydenMcCabe/followers","following_url":"https://api.github.com/users/HaydenMcCabe/following{/other_user}","gists_url":"https://api.github.com/users/HaydenMcCabe/gists{/gist_id}","starred_url":"https://api.github.com/users/HaydenMcCabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaydenMcCabe/subscriptions","organizations_url":"https://api.github.com/users/HaydenMcCabe/orgs","repos_url":"https://api.github.com/users/HaydenMcCabe/repos","events_url":"https://api.github.com/users/HaydenMcCabe/events{/privacy}","received_events_url":"https://api.github.com/users/HaydenMcCabe/received_events","type":"User","site_admin":false},"body":"I've generally heard API used with an article, although that may be a regional usage; I generally refer to freeways using \"the\" like a good citizen of the American West.","created_at":"2019-07-19T06:28:01Z","updated_at":"2019-07-19T06:28:01Z","html_url":"https://github.com/apple/swift-package-manager/pull/2242#discussion_r305216538","pull_request_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/2242","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/305216538"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/2242#discussion_r305216538"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/2242"}},"in_reply_to_id":305185829},"pull_request":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/2242","id":298742598,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4NzQyNTk4","html_url":"https://github.com/apple/swift-package-manager/pull/2242","diff_url":"https://github.com/apple/swift-package-manager/pull/2242.diff","patch_url":"https://github.com/apple/swift-package-manager/pull/2242.patch","issue_url":"https://api.github.com/repos/apple/swift-package-manager/issues/2242","number":2242,"state":"open","locked":false,"title":"Grammar, spelling, and formatting edits for SwiftPM documentation","user":{"login":"HaydenMcCabe","id":27537409,"node_id":"MDQ6VXNlcjI3NTM3NDA5","avatar_url":"https://avatars2.githubusercontent.com/u/27537409?v=4","gravatar_id":"","url":"https://api.github.com/users/HaydenMcCabe","html_url":"https://github.com/HaydenMcCabe","followers_url":"https://api.github.com/users/HaydenMcCabe/followers","following_url":"https://api.github.com/users/HaydenMcCabe/following{/other_user}","gists_url":"https://api.github.com/users/HaydenMcCabe/gists{/gist_id}","starred_url":"https://api.github.com/users/HaydenMcCabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaydenMcCabe/subscriptions","organizations_url":"https://api.github.com/users/HaydenMcCabe/orgs","repos_url":"https://api.github.com/users/HaydenMcCabe/repos","events_url":"https://api.github.com/users/HaydenMcCabe/events{/privacy}","received_events_url":"https://api.github.com/users/HaydenMcCabe/received_events","type":"User","site_admin":false},"body":"Howdy,\r\n\r\nIn this fork, I made a number of edits to the documentation files in an effort to fix grammatical mistakes (most often, these were omitted articles) and spelling errors, and to make the capitalization and formatting consistent across the various files. The only aspect of the documentation that was otherwise edited was the removal of Xcode integration as a proposed feature for future development, as that is currently in beta testing. Please feel free to ask if you have any questions about these amendments.","created_at":"2019-07-18T03:27:33Z","updated_at":"2019-07-19T06:28:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9979f829cd1daee270662aa7539c17db9a1fb544","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/2242/commits","review_comments_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/2242/comments","review_comment_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/issues/2242/comments","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/df833814f9f95d338a7443d6f26207c090515512","head":{"label":"HaydenMcCabe:master","ref":"master","sha":"df833814f9f95d338a7443d6f26207c090515512","user":{"login":"HaydenMcCabe","id":27537409,"node_id":"MDQ6VXNlcjI3NTM3NDA5","avatar_url":"https://avatars2.githubusercontent.com/u/27537409?v=4","gravatar_id":"","url":"https://api.github.com/users/HaydenMcCabe","html_url":"https://github.com/HaydenMcCabe","followers_url":"https://api.github.com/users/HaydenMcCabe/followers","following_url":"https://api.github.com/users/HaydenMcCabe/following{/other_user}","gists_url":"https://api.github.com/users/HaydenMcCabe/gists{/gist_id}","starred_url":"https://api.github.com/users/HaydenMcCabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaydenMcCabe/subscriptions","organizations_url":"https://api.github.com/users/HaydenMcCabe/orgs","repos_url":"https://api.github.com/users/HaydenMcCabe/repos","events_url":"https://api.github.com/users/HaydenMcCabe/events{/privacy}","received_events_url":"https://api.github.com/users/HaydenMcCabe/received_events","type":"User","site_admin":false},"repo":{"id":194417351,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ0MTczNTE=","name":"swift-package-manager","full_name":"HaydenMcCabe/swift-package-manager","private":false,"owner":{"login":"HaydenMcCabe","id":27537409,"node_id":"MDQ6VXNlcjI3NTM3NDA5","avatar_url":"https://avatars2.githubusercontent.com/u/27537409?v=4","gravatar_id":"","url":"https://api.github.com/users/HaydenMcCabe","html_url":"https://github.com/HaydenMcCabe","followers_url":"https://api.github.com/users/HaydenMcCabe/followers","following_url":"https://api.github.com/users/HaydenMcCabe/following{/other_user}","gists_url":"https://api.github.com/users/HaydenMcCabe/gists{/gist_id}","starred_url":"https://api.github.com/users/HaydenMcCabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaydenMcCabe/subscriptions","organizations_url":"https://api.github.com/users/HaydenMcCabe/orgs","repos_url":"https://api.github.com/users/HaydenMcCabe/repos","events_url":"https://api.github.com/users/HaydenMcCabe/events{/privacy}","received_events_url":"https://api.github.com/users/HaydenMcCabe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HaydenMcCabe/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":true,"url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager","forks_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/forks","keys_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/events","assignees_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/merges","archive_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/releases{/id}","deployments_url":"https://api.github.com/repos/HaydenMcCabe/swift-package-manager/deployments","created_at":"2019-06-29T14:57:18Z","updated_at":"2019-07-19T06:17:23Z","pushed_at":"2019-07-19T06:17:21Z","git_url":"git://github.com/HaydenMcCabe/swift-package-manager.git","ssh_url":"git@github.com:HaydenMcCabe/swift-package-manager.git","clone_url":"https://github.com/HaydenMcCabe/swift-package-manager.git","svn_url":"https://github.com/HaydenMcCabe/swift-package-manager","homepage":"","size":9514,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"293103285898fdc54bfcc12896e55161cf75e9ff","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44840041,"node_id":"MDEwOlJlcG9zaXRvcnk0NDg0MDA0MQ==","name":"swift-package-manager","full_name":"apple/swift-package-manager","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift-package-manager","forks_url":"https://api.github.com/repos/apple/swift-package-manager/forks","keys_url":"https://api.github.com/repos/apple/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/apple/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-package-manager/events","assignees_url":"https://api.github.com/repos/apple/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/apple/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/apple/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/apple/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-package-manager/merges","archive_url":"https://api.github.com/repos/apple/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/apple/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-package-manager/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-package-manager/deployments","created_at":"2015-10-23T21:41:12Z","updated_at":"2019-07-19T04:19:08Z","pushed_at":"2019-07-19T06:17:23Z","git_url":"git://github.com/apple/swift-package-manager.git","ssh_url":"git@github.com:apple/swift-package-manager.git","clone_url":"https://github.com/apple/swift-package-manager.git","svn_url":"https://github.com/apple/swift-package-manager","homepage":"","size":9532,"stargazers_count":7099,"watchers_count":7099,"language":"Swift","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":860,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":860,"open_issues":34,"watchers":7099,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/2242"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/2242"},"issue":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/2242"},"comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/2242/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/2242/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/2242/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-package-manager/statuses/df833814f9f95d338a7443d6f26207c090515512"}},"author_association":"NONE"}}
|
{
"id": 44840041,
"name": "apple/swift-package-manager",
"url": "https://api.github.com/repos/apple/swift-package-manager"
}
|
{
"id": 27537409,
"login": "HaydenMcCabe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27537409?",
"url": "https://api.github.com/users/HaydenMcCabe"
}
|
{
"id": 10639145,
"login": "apple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10639145?",
"url": "https://api.github.com/orgs/apple"
}
| 2019-07-19T06:28:01 |
10043125499
|
{"actor":{"display_login":"HaydenMcCabe"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apple/turicreate/pulls/comments/337106020","pull_request_review_id":304677880,"id":337106020,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzEwNjAyMA==","diff_hunk":"@@ -58,9 +58,10 @@ class data_iterator {\n */\n std::vector<std::string> class_labels;\n \n- /**\n- * Whether to traverse the data more than once.\n- */\n+ /** Whether this is training data or not. */","path":"src/toolkits/drawing_classifier/dc_data_iterator.hpp","position":7,"original_position":7,"commit_id":"e93f32ebf97f6029f7ead7b9abe5bcd94065cce3","original_commit_id":"85b8ec46ad4aa37ffb8a40c27538dd27b3703014","user":{"login":"Jarvi-Izana","id":14238915,"node_id":"MDQ6VXNlcjE0MjM4OTE1","avatar_url":"https://avatars2.githubusercontent.com/u/14238915?v=4","gravatar_id":"","url":"https://api.github.com/users/Jarvi-Izana","html_url":"https://github.com/Jarvi-Izana","followers_url":"https://api.github.com/users/Jarvi-Izana/followers","following_url":"https://api.github.com/users/Jarvi-Izana/following{/other_user}","gists_url":"https://api.github.com/users/Jarvi-Izana/gists{/gist_id}","starred_url":"https://api.github.com/users/Jarvi-Izana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jarvi-Izana/subscriptions","organizations_url":"https://api.github.com/users/Jarvi-Izana/orgs","repos_url":"https://api.github.com/users/Jarvi-Izana/repos","events_url":"https://api.github.com/users/Jarvi-Izana/events{/privacy}","received_events_url":"https://api.github.com/users/Jarvi-Izana/received_events","type":"User","site_admin":false},"body":"yeah, that's it.","created_at":"2019-10-21T16:07:57Z","updated_at":"2019-10-21T16:07:57Z","html_url":"https://github.com/apple/turicreate/pull/2468#discussion_r337106020","pull_request_url":"https://api.github.com/repos/apple/turicreate/pulls/2468","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/turicreate/pulls/comments/337106020"},"html":{"href":"https://github.com/apple/turicreate/pull/2468#discussion_r337106020"},"pull_request":{"href":"https://api.github.com/repos/apple/turicreate/pulls/2468"}},"in_reply_to_id":336711511},"pull_request":{"url":"https://api.github.com/repos/apple/turicreate/pulls/2468","id":329898724,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5ODk4NzI0","html_url":"https://github.com/apple/turicreate/pull/2468","diff_url":"https://github.com/apple/turicreate/pull/2468.diff","patch_url":"https://github.com/apple/turicreate/pull/2468.patch","issue_url":"https://api.github.com/repos/apple/turicreate/issues/2468","number":2468,"state":"open","locked":false,"title":"Train functionality for DC along with unit tests","user":{"login":"shantanuchhabra","id":14062641,"node_id":"MDQ6VXNlcjE0MDYyNjQx","avatar_url":"https://avatars2.githubusercontent.com/u/14062641?v=4","gravatar_id":"","url":"https://api.github.com/users/shantanuchhabra","html_url":"https://github.com/shantanuchhabra","followers_url":"https://api.github.com/users/shantanuchhabra/followers","following_url":"https://api.github.com/users/shantanuchhabra/following{/other_user}","gists_url":"https://api.github.com/users/shantanuchhabra/gists{/gist_id}","starred_url":"https://api.github.com/users/shantanuchhabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantanuchhabra/subscriptions","organizations_url":"https://api.github.com/users/shantanuchhabra/orgs","repos_url":"https://api.github.com/users/shantanuchhabra/repos","events_url":"https://api.github.com/users/shantanuchhabra/events{/privacy}","received_events_url":"https://api.github.com/users/shantanuchhabra/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-18T19:49:27Z","updated_at":"2019-10-21T16:07:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8fce73a786bef46b047fcb36e5815a24ab92f8c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TobyRoseman","id":5420744,"node_id":"MDQ6VXNlcjU0MjA3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5420744?v=4","gravatar_id":"","url":"https://api.github.com/users/TobyRoseman","html_url":"https://github.com/TobyRoseman","followers_url":"https://api.github.com/users/TobyRoseman/followers","following_url":"https://api.github.com/users/TobyRoseman/following{/other_user}","gists_url":"https://api.github.com/users/TobyRoseman/gists{/gist_id}","starred_url":"https://api.github.com/users/TobyRoseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobyRoseman/subscriptions","organizations_url":"https://api.github.com/users/TobyRoseman/orgs","repos_url":"https://api.github.com/users/TobyRoseman/repos","events_url":"https://api.github.com/users/TobyRoseman/events{/privacy}","received_events_url":"https://api.github.com/users/TobyRoseman/received_events","type":"User","site_admin":false},{"login":"nickjong","id":17018249,"node_id":"MDQ6VXNlcjE3MDE4MjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/17018249?v=4","gravatar_id":"","url":"https://api.github.com/users/nickjong","html_url":"https://github.com/nickjong","followers_url":"https://api.github.com/users/nickjong/followers","following_url":"https://api.github.com/users/nickjong/following{/other_user}","gists_url":"https://api.github.com/users/nickjong/gists{/gist_id}","starred_url":"https://api.github.com/users/nickjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickjong/subscriptions","organizations_url":"https://api.github.com/users/nickjong/orgs","repos_url":"https://api.github.com/users/nickjong/repos","events_url":"https://api.github.com/users/nickjong/events{/privacy}","received_events_url":"https://api.github.com/users/nickjong/received_events","type":"User","site_admin":false},{"login":"shreyajain17","id":47830614,"node_id":"MDQ6VXNlcjQ3ODMwNjE0","avatar_url":"https://avatars2.githubusercontent.com/u/47830614?v=4","gravatar_id":"","url":"https://api.github.com/users/shreyajain17","html_url":"https://github.com/shreyajain17","followers_url":"https://api.github.com/users/shreyajain17/followers","following_url":"https://api.github.com/users/shreyajain17/following{/other_user}","gists_url":"https://api.github.com/users/shreyajain17/gists{/gist_id}","starred_url":"https://api.github.com/users/shreyajain17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreyajain17/subscriptions","organizations_url":"https://api.github.com/users/shreyajain17/orgs","repos_url":"https://api.github.com/users/shreyajain17/repos","events_url":"https://api.github.com/users/shreyajain17/events{/privacy}","received_events_url":"https://api.github.com/users/shreyajain17/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/turicreate/pulls/2468/commits","review_comments_url":"https://api.github.com/repos/apple/turicreate/pulls/2468/comments","review_comment_url":"https://api.github.com/repos/apple/turicreate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/turicreate/issues/2468/comments","statuses_url":"https://api.github.com/repos/apple/turicreate/statuses/e93f32ebf97f6029f7ead7b9abe5bcd94065cce3","head":{"label":"shantanuchhabra:drawing_train_cpp","ref":"drawing_train_cpp","sha":"e93f32ebf97f6029f7ead7b9abe5bcd94065cce3","user":{"login":"shantanuchhabra","id":14062641,"node_id":"MDQ6VXNlcjE0MDYyNjQx","avatar_url":"https://avatars2.githubusercontent.com/u/14062641?v=4","gravatar_id":"","url":"https://api.github.com/users/shantanuchhabra","html_url":"https://github.com/shantanuchhabra","followers_url":"https://api.github.com/users/shantanuchhabra/followers","following_url":"https://api.github.com/users/shantanuchhabra/following{/other_user}","gists_url":"https://api.github.com/users/shantanuchhabra/gists{/gist_id}","starred_url":"https://api.github.com/users/shantanuchhabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantanuchhabra/subscriptions","organizations_url":"https://api.github.com/users/shantanuchhabra/orgs","repos_url":"https://api.github.com/users/shantanuchhabra/repos","events_url":"https://api.github.com/users/shantanuchhabra/events{/privacy}","received_events_url":"https://api.github.com/users/shantanuchhabra/received_events","type":"User","site_admin":false},"repo":{"id":125091981,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwOTE5ODE=","name":"turicreate","full_name":"shantanuchhabra/turicreate","private":false,"owner":{"login":"shantanuchhabra","id":14062641,"node_id":"MDQ6VXNlcjE0MDYyNjQx","avatar_url":"https://avatars2.githubusercontent.com/u/14062641?v=4","gravatar_id":"","url":"https://api.github.com/users/shantanuchhabra","html_url":"https://github.com/shantanuchhabra","followers_url":"https://api.github.com/users/shantanuchhabra/followers","following_url":"https://api.github.com/users/shantanuchhabra/following{/other_user}","gists_url":"https://api.github.com/users/shantanuchhabra/gists{/gist_id}","starred_url":"https://api.github.com/users/shantanuchhabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantanuchhabra/subscriptions","organizations_url":"https://api.github.com/users/shantanuchhabra/orgs","repos_url":"https://api.github.com/users/shantanuchhabra/repos","events_url":"https://api.github.com/users/shantanuchhabra/events{/privacy}","received_events_url":"https://api.github.com/users/shantanuchhabra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shantanuchhabra/turicreate","description":"Turi Create simplifies the development of custom machine learning models.","fork":true,"url":"https://api.github.com/repos/shantanuchhabra/turicreate","forks_url":"https://api.github.com/repos/shantanuchhabra/turicreate/forks","keys_url":"https://api.github.com/repos/shantanuchhabra/turicreate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shantanuchhabra/turicreate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shantanuchhabra/turicreate/teams","hooks_url":"https://api.github.com/repos/shantanuchhabra/turicreate/hooks","issue_events_url":"https://api.github.com/repos/shantanuchhabra/turicreate/issues/events{/number}","events_url":"https://api.github.com/repos/shantanuchhabra/turicreate/events","assignees_url":"https://api.github.com/repos/shantanuchhabra/turicreate/assignees{/user}","branches_url":"https://api.github.com/repos/shantanuchhabra/turicreate/branches{/branch}","tags_url":"https://api.github.com/repos/shantanuchhabra/turicreate/tags","blobs_url":"https://api.github.com/repos/shantanuchhabra/turicreate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shantanuchhabra/turicreate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shantanuchhabra/turicreate/git/refs{/sha}","trees_url":"https://api.github.com/repos/shantanuchhabra/turicreate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shantanuchhabra/turicreate/statuses/{sha}","languages_url":"https://api.github.com/repos/shantanuchhabra/turicreate/languages","stargazers_url":"https://api.github.com/repos/shantanuchhabra/turicreate/stargazers","contributors_url":"https://api.github.com/repos/shantanuchhabra/turicreate/contributors","subscribers_url":"https://api.github.com/repos/shantanuchhabra/turicreate/subscribers","subscription_url":"https://api.github.com/repos/shantanuchhabra/turicreate/subscription","commits_url":"https://api.github.com/repos/shantanuchhabra/turicreate/commits{/sha}","git_commits_url":"https://api.github.com/repos/shantanuchhabra/turicreate/git/commits{/sha}","comments_url":"https://api.github.com/repos/shantanuchhabra/turicreate/comments{/number}","issue_comment_url":"https://api.github.com/repos/shantanuchhabra/turicreate/issues/comments{/number}","contents_url":"https://api.github.com/repos/shantanuchhabra/turicreate/contents/{+path}","compare_url":"https://api.github.com/repos/shantanuchhabra/turicreate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shantanuchhabra/turicreate/merges","archive_url":"https://api.github.com/repos/shantanuchhabra/turicreate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shantanuchhabra/turicreate/downloads","issues_url":"https://api.github.com/repos/shantanuchhabra/turicreate/issues{/number}","pulls_url":"https://api.github.com/repos/shantanuchhabra/turicreate/pulls{/number}","milestones_url":"https://api.github.com/repos/shantanuchhabra/turicreate/milestones{/number}","notifications_url":"https://api.github.com/repos/shantanuchhabra/turicreate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shantanuchhabra/turicreate/labels{/name}","releases_url":"https://api.github.com/repos/shantanuchhabra/turicreate/releases{/id}","deployments_url":"https://api.github.com/repos/shantanuchhabra/turicreate/deployments","created_at":"2018-03-13T17:48:09Z","updated_at":"2018-06-15T20:48:30Z","pushed_at":"2019-10-21T08:07:52Z","git_url":"git://github.com/shantanuchhabra/turicreate.git","ssh_url":"git@github.com:shantanuchhabra/turicreate.git","clone_url":"https://github.com/shantanuchhabra/turicreate.git","svn_url":"https://github.com/shantanuchhabra/turicreate","homepage":"","size":281671,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"d06876920a172e41aa95341f0d2392d26e01d85b","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":112676803,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2NzY4MDM=","name":"turicreate","full_name":"apple/turicreate","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/turicreate","description":"Turi Create simplifies the development of custom machine learning models.","fork":false,"url":"https://api.github.com/repos/apple/turicreate","forks_url":"https://api.github.com/repos/apple/turicreate/forks","keys_url":"https://api.github.com/repos/apple/turicreate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/turicreate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/turicreate/teams","hooks_url":"https://api.github.com/repos/apple/turicreate/hooks","issue_events_url":"https://api.github.com/repos/apple/turicreate/issues/events{/number}","events_url":"https://api.github.com/repos/apple/turicreate/events","assignees_url":"https://api.github.com/repos/apple/turicreate/assignees{/user}","branches_url":"https://api.github.com/repos/apple/turicreate/branches{/branch}","tags_url":"https://api.github.com/repos/apple/turicreate/tags","blobs_url":"https://api.github.com/repos/apple/turicreate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/turicreate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/turicreate/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/turicreate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/turicreate/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/turicreate/languages","stargazers_url":"https://api.github.com/repos/apple/turicreate/stargazers","contributors_url":"https://api.github.com/repos/apple/turicreate/contributors","subscribers_url":"https://api.github.com/repos/apple/turicreate/subscribers","subscription_url":"https://api.github.com/repos/apple/turicreate/subscription","commits_url":"https://api.github.com/repos/apple/turicreate/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/turicreate/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/turicreate/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/turicreate/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/turicreate/contents/{+path}","compare_url":"https://api.github.com/repos/apple/turicreate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/turicreate/merges","archive_url":"https://api.github.com/repos/apple/turicreate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/turicreate/downloads","issues_url":"https://api.github.com/repos/apple/turicreate/issues{/number}","pulls_url":"https://api.github.com/repos/apple/turicreate/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/turicreate/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/turicreate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/turicreate/labels{/name}","releases_url":"https://api.github.com/repos/apple/turicreate/releases{/id}","deployments_url":"https://api.github.com/repos/apple/turicreate/deployments","created_at":"2017-12-01T00:42:04Z","updated_at":"2019-10-21T11:37:27Z","pushed_at":"2019-10-21T11:13:31Z","git_url":"git://github.com/apple/turicreate.git","ssh_url":"git@github.com:apple/turicreate.git","clone_url":"https://github.com/apple/turicreate.git","svn_url":"https://github.com/apple/turicreate","homepage":"","size":302968,"stargazers_count":9077,"watchers_count":9077,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":910,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":465,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":910,"open_issues":465,"watchers":9077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/turicreate/pulls/2468"},"html":{"href":"https://github.com/apple/turicreate/pull/2468"},"issue":{"href":"https://api.github.com/repos/apple/turicreate/issues/2468"},"comments":{"href":"https://api.github.com/repos/apple/turicreate/issues/2468/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/turicreate/pulls/2468/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/turicreate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/turicreate/pulls/2468/commits"},"statuses":{"href":"https://api.github.com/repos/apple/turicreate/statuses/e93f32ebf97f6029f7ead7b9abe5bcd94065cce3"}},"author_association":"COLLABORATOR"}}
|
{
"id": 112676803,
"name": "apple/turicreate",
"url": "https://api.github.com/repos/apple/turicreate"
}
|
{
"id": 14238915,
"login": "Jarvi-Izana",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14238915?",
"url": "https://api.github.com/users/Jarvi-Izana"
}
|
{
"id": 10639145,
"login": "apple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10639145?",
"url": "https://api.github.com/orgs/apple"
}
| 2019-10-21T16:07:57 |
10677850838
|
{"actor":{"display_login":"Jarvi-Izana"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apple/turicreate/pulls/comments/333114411","pull_request_review_id":299543689,"id":333114411,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMzExNDQxMQ==","diff_hunk":"@@ -40,28 +40,51 @@ xavier_weight_initializer::xavier_weight_initializer(\n lstm_weight_initializers lstm_weight_initializers::create_with_xavier_method(\n size_t input_size, size_t state_size, std::mt19937* random_engine)\n {\n- xavier_weight_initializer i2h_init_fn(input_size, state_size, random_engine);\n- xavier_weight_initializer h2h_init_fn(state_size, state_size, random_engine);\n+ xavier_weight_initializer i2h_init_fn(input_size, state_size,\n+ random_engine);\n+ xavier_weight_initializer h2h_init_fn(state_size, state_size,\n+ random_engine);\n \n- lstm_weight_initializers result;\n+ lstm_weight_initializers result;\n \n- result.input_gate_weight_fn = i2h_init_fn;\n- result.forget_gate_weight_fn = i2h_init_fn;\n- result.block_input_weight_fn = i2h_init_fn;\n- result.output_gate_weight_fn = i2h_init_fn;\n+ result.input_gate_weight_fn = i2h_init_fn;\n+ result.forget_gate_weight_fn = i2h_init_fn;\n+ result.block_input_weight_fn = i2h_init_fn;\n+ result.output_gate_weight_fn = i2h_init_fn;\n \n- result.input_gate_recursion_fn = h2h_init_fn;\n- result.forget_gate_recursion_fn = h2h_init_fn;\n- result.block_input_recursion_fn = h2h_init_fn;\n- result.output_gate_recursion_fn = h2h_init_fn;\n+ result.input_gate_recursion_fn = h2h_init_fn;\n+ result.forget_gate_recursion_fn = h2h_init_fn;\n+ result.block_input_recursion_fn = h2h_init_fn;\n+ result.output_gate_recursion_fn = h2h_init_fn;\n \n- result.input_gate_bias_fn = zero_weight_initializer();\n- result.forget_gate_bias_fn = zero_weight_initializer();\n- result.block_input_bias_fn = zero_weight_initializer();\n- result.output_gate_bias_fn = zero_weight_initializer();\n+ result.input_gate_bias_fn = zero_weight_initializer();\n+ result.forget_gate_bias_fn = zero_weight_initializer();\n+ result.block_input_bias_fn = zero_weight_initializer();\n+ result.output_gate_bias_fn = zero_weight_initializer();","path":"src/ml/neural_net/weight_init.cpp","position":39,"original_position":39,"commit_id":"19e2f634daae5da233798a775a6ff38b1af0e9c2","original_commit_id":"19e2f634daae5da233798a775a6ff38b1af0e9c2","user":{"login":"nickjong","id":17018249,"node_id":"MDQ6VXNlcjE3MDE4MjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/17018249?v=4","gravatar_id":"","url":"https://api.github.com/users/nickjong","html_url":"https://github.com/nickjong","followers_url":"https://api.github.com/users/nickjong/followers","following_url":"https://api.github.com/users/nickjong/following{/other_user}","gists_url":"https://api.github.com/users/nickjong/gists{/gist_id}","starred_url":"https://api.github.com/users/nickjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickjong/subscriptions","organizations_url":"https://api.github.com/users/nickjong/orgs","repos_url":"https://api.github.com/users/nickjong/repos","events_url":"https://api.github.com/users/nickjong/events{/privacy}","received_events_url":"https://api.github.com/users/nickjong/received_events","type":"User","site_admin":false},"body":"Why are we changing the indent level here? Didn't we already address this in the last PR?","created_at":"2019-10-09T16:33:04Z","updated_at":"2019-10-09T16:41:17Z","html_url":"https://github.com/apple/turicreate/pull/2419#discussion_r333114411","pull_request_url":"https://api.github.com/repos/apple/turicreate/pulls/2419","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/turicreate/pulls/comments/333114411"},"html":{"href":"https://github.com/apple/turicreate/pull/2419#discussion_r333114411"},"pull_request":{"href":"https://api.github.com/repos/apple/turicreate/pulls/2419"}}},"pull_request":{"url":"https://api.github.com/repos/apple/turicreate/pulls/2419","id":326011986,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2MDExOTg2","html_url":"https://github.com/apple/turicreate/pull/2419","diff_url":"https://github.com/apple/turicreate/pull/2419.diff","patch_url":"https://github.com/apple/turicreate/pull/2419.patch","issue_url":"https://api.github.com/repos/apple/turicreate/issues/2419","number":2419,"state":"open","locked":false,"title":"Fix \"random_seed\" state not found\" bug for AC import for python model","user":{"login":"jakesabathia2","id":55294647,"node_id":"MDQ6VXNlcjU1Mjk0NjQ3","avatar_url":"https://avatars2.githubusercontent.com/u/55294647?v=4","gravatar_id":"","url":"https://api.github.com/users/jakesabathia2","html_url":"https://github.com/jakesabathia2","followers_url":"https://api.github.com/users/jakesabathia2/followers","following_url":"https://api.github.com/users/jakesabathia2/following{/other_user}","gists_url":"https://api.github.com/users/jakesabathia2/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesabathia2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesabathia2/subscriptions","organizations_url":"https://api.github.com/users/jakesabathia2/orgs","repos_url":"https://api.github.com/users/jakesabathia2/repos","events_url":"https://api.github.com/users/jakesabathia2/events{/privacy}","received_events_url":"https://api.github.com/users/jakesabathia2/received_events","type":"User","site_admin":false},"body":"#2378 \r\nFix the import function for python model.","created_at":"2019-10-09T00:04:28Z","updated_at":"2019-10-09T16:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f919ffb0c587b6ef23c28dc739623e6dc414accc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fareeha","id":6214406,"node_id":"MDQ6VXNlcjYyMTQ0MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/6214406?v=4","gravatar_id":"","url":"https://api.github.com/users/fareeha","html_url":"https://github.com/fareeha","followers_url":"https://api.github.com/users/fareeha/followers","following_url":"https://api.github.com/users/fareeha/following{/other_user}","gists_url":"https://api.github.com/users/fareeha/gists{/gist_id}","starred_url":"https://api.github.com/users/fareeha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fareeha/subscriptions","organizations_url":"https://api.github.com/users/fareeha/orgs","repos_url":"https://api.github.com/users/fareeha/repos","events_url":"https://api.github.com/users/fareeha/events{/privacy}","received_events_url":"https://api.github.com/users/fareeha/received_events","type":"User","site_admin":false},{"login":"shreyajain17","id":47830614,"node_id":"MDQ6VXNlcjQ3ODMwNjE0","avatar_url":"https://avatars2.githubusercontent.com/u/47830614?v=4","gravatar_id":"","url":"https://api.github.com/users/shreyajain17","html_url":"https://github.com/shreyajain17","followers_url":"https://api.github.com/users/shreyajain17/followers","following_url":"https://api.github.com/users/shreyajain17/following{/other_user}","gists_url":"https://api.github.com/users/shreyajain17/gists{/gist_id}","starred_url":"https://api.github.com/users/shreyajain17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreyajain17/subscriptions","organizations_url":"https://api.github.com/users/shreyajain17/orgs","repos_url":"https://api.github.com/users/shreyajain17/repos","events_url":"https://api.github.com/users/shreyajain17/events{/privacy}","received_events_url":"https://api.github.com/users/shreyajain17/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/turicreate/pulls/2419/commits","review_comments_url":"https://api.github.com/repos/apple/turicreate/pulls/2419/comments","review_comment_url":"https://api.github.com/repos/apple/turicreate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/turicreate/issues/2419/comments","statuses_url":"https://api.github.com/repos/apple/turicreate/statuses/19e2f634daae5da233798a775a6ff38b1af0e9c2","head":{"label":"jakesabathia2:AC_import","ref":"AC_import","sha":"19e2f634daae5da233798a775a6ff38b1af0e9c2","user":{"login":"jakesabathia2","id":55294647,"node_id":"MDQ6VXNlcjU1Mjk0NjQ3","avatar_url":"https://avatars2.githubusercontent.com/u/55294647?v=4","gravatar_id":"","url":"https://api.github.com/users/jakesabathia2","html_url":"https://github.com/jakesabathia2","followers_url":"https://api.github.com/users/jakesabathia2/followers","following_url":"https://api.github.com/users/jakesabathia2/following{/other_user}","gists_url":"https://api.github.com/users/jakesabathia2/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesabathia2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesabathia2/subscriptions","organizations_url":"https://api.github.com/users/jakesabathia2/orgs","repos_url":"https://api.github.com/users/jakesabathia2/repos","events_url":"https://api.github.com/users/jakesabathia2/events{/privacy}","received_events_url":"https://api.github.com/users/jakesabathia2/received_events","type":"User","site_admin":false},"repo":{"id":212866324,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI4NjYzMjQ=","name":"turicreate","full_name":"jakesabathia2/turicreate","private":false,"owner":{"login":"jakesabathia2","id":55294647,"node_id":"MDQ6VXNlcjU1Mjk0NjQ3","avatar_url":"https://avatars2.githubusercontent.com/u/55294647?v=4","gravatar_id":"","url":"https://api.github.com/users/jakesabathia2","html_url":"https://github.com/jakesabathia2","followers_url":"https://api.github.com/users/jakesabathia2/followers","following_url":"https://api.github.com/users/jakesabathia2/following{/other_user}","gists_url":"https://api.github.com/users/jakesabathia2/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesabathia2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesabathia2/subscriptions","organizations_url":"https://api.github.com/users/jakesabathia2/orgs","repos_url":"https://api.github.com/users/jakesabathia2/repos","events_url":"https://api.github.com/users/jakesabathia2/events{/privacy}","received_events_url":"https://api.github.com/users/jakesabathia2/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jakesabathia2/turicreate","description":"Turi Create simplifies the development of custom machine learning models.","fork":true,"url":"https://api.github.com/repos/jakesabathia2/turicreate","forks_url":"https://api.github.com/repos/jakesabathia2/turicreate/forks","keys_url":"https://api.github.com/repos/jakesabathia2/turicreate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakesabathia2/turicreate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakesabathia2/turicreate/teams","hooks_url":"https://api.github.com/repos/jakesabathia2/turicreate/hooks","issue_events_url":"https://api.github.com/repos/jakesabathia2/turicreate/issues/events{/number}","events_url":"https://api.github.com/repos/jakesabathia2/turicreate/events","assignees_url":"https://api.github.com/repos/jakesabathia2/turicreate/assignees{/user}","branches_url":"https://api.github.com/repos/jakesabathia2/turicreate/branches{/branch}","tags_url":"https://api.github.com/repos/jakesabathia2/turicreate/tags","blobs_url":"https://api.github.com/repos/jakesabathia2/turicreate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakesabathia2/turicreate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakesabathia2/turicreate/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakesabathia2/turicreate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakesabathia2/turicreate/statuses/{sha}","languages_url":"https://api.github.com/repos/jakesabathia2/turicreate/languages","stargazers_url":"https://api.github.com/repos/jakesabathia2/turicreate/stargazers","contributors_url":"https://api.github.com/repos/jakesabathia2/turicreate/contributors","subscribers_url":"https://api.github.com/repos/jakesabathia2/turicreate/subscribers","subscription_url":"https://api.github.com/repos/jakesabathia2/turicreate/subscription","commits_url":"https://api.github.com/repos/jakesabathia2/turicreate/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakesabathia2/turicreate/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakesabathia2/turicreate/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakesabathia2/turicreate/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakesabathia2/turicreate/contents/{+path}","compare_url":"https://api.github.com/repos/jakesabathia2/turicreate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakesabathia2/turicreate/merges","archive_url":"https://api.github.com/repos/jakesabathia2/turicreate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakesabathia2/turicreate/downloads","issues_url":"https://api.github.com/repos/jakesabathia2/turicreate/issues{/number}","pulls_url":"https://api.github.com/repos/jakesabathia2/turicreate/pulls{/number}","milestones_url":"https://api.github.com/repos/jakesabathia2/turicreate/milestones{/number}","notifications_url":"https://api.github.com/repos/jakesabathia2/turicreate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakesabathia2/turicreate/labels{/name}","releases_url":"https://api.github.com/repos/jakesabathia2/turicreate/releases{/id}","deployments_url":"https://api.github.com/repos/jakesabathia2/turicreate/deployments","created_at":"2019-10-04T17:14:12Z","updated_at":"2019-10-08T21:09:22Z","pushed_at":"2019-10-09T00:01:33Z","git_url":"git://github.com/jakesabathia2/turicreate.git","ssh_url":"git@github.com:jakesabathia2/turicreate.git","clone_url":"https://github.com/jakesabathia2/turicreate.git","svn_url":"https://github.com/jakesabathia2/turicreate","homepage":"","size":302092,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"26b718e5401ed47ff5e44f37b6acb2875a86e44d","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":112676803,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2NzY4MDM=","name":"turicreate","full_name":"apple/turicreate","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/turicreate","description":"Turi Create simplifies the development of custom machine learning models.","fork":false,"url":"https://api.github.com/repos/apple/turicreate","forks_url":"https://api.github.com/repos/apple/turicreate/forks","keys_url":"https://api.github.com/repos/apple/turicreate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/turicreate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/turicreate/teams","hooks_url":"https://api.github.com/repos/apple/turicreate/hooks","issue_events_url":"https://api.github.com/repos/apple/turicreate/issues/events{/number}","events_url":"https://api.github.com/repos/apple/turicreate/events","assignees_url":"https://api.github.com/repos/apple/turicreate/assignees{/user}","branches_url":"https://api.github.com/repos/apple/turicreate/branches{/branch}","tags_url":"https://api.github.com/repos/apple/turicreate/tags","blobs_url":"https://api.github.com/repos/apple/turicreate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/turicreate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/turicreate/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/turicreate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/turicreate/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/turicreate/languages","stargazers_url":"https://api.github.com/repos/apple/turicreate/stargazers","contributors_url":"https://api.github.com/repos/apple/turicreate/contributors","subscribers_url":"https://api.github.com/repos/apple/turicreate/subscribers","subscription_url":"https://api.github.com/repos/apple/turicreate/subscription","commits_url":"https://api.github.com/repos/apple/turicreate/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/turicreate/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/turicreate/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/turicreate/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/turicreate/contents/{+path}","compare_url":"https://api.github.com/repos/apple/turicreate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/turicreate/merges","archive_url":"https://api.github.com/repos/apple/turicreate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/turicreate/downloads","issues_url":"https://api.github.com/repos/apple/turicreate/issues{/number}","pulls_url":"https://api.github.com/repos/apple/turicreate/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/turicreate/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/turicreate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/turicreate/labels{/name}","releases_url":"https://api.github.com/repos/apple/turicreate/releases{/id}","deployments_url":"https://api.github.com/repos/apple/turicreate/deployments","created_at":"2017-12-01T00:42:04Z","updated_at":"2019-10-09T13:39:27Z","pushed_at":"2019-10-09T07:06:22Z","git_url":"git://github.com/apple/turicreate.git","ssh_url":"git@github.com:apple/turicreate.git","clone_url":"https://github.com/apple/turicreate.git","svn_url":"https://github.com/apple/turicreate","homepage":"","size":302909,"stargazers_count":9039,"watchers_count":9039,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":902,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":466,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":902,"open_issues":466,"watchers":9039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/turicreate/pulls/2419"},"html":{"href":"https://github.com/apple/turicreate/pull/2419"},"issue":{"href":"https://api.github.com/repos/apple/turicreate/issues/2419"},"comments":{"href":"https://api.github.com/repos/apple/turicreate/issues/2419/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/turicreate/pulls/2419/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/turicreate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/turicreate/pulls/2419/commits"},"statuses":{"href":"https://api.github.com/repos/apple/turicreate/statuses/19e2f634daae5da233798a775a6ff38b1af0e9c2"}},"author_association":"COLLABORATOR"}}
|
{
"id": 112676803,
"name": "apple/turicreate",
"url": "https://api.github.com/repos/apple/turicreate"
}
|
{
"id": 17018249,
"login": "nickjong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17018249?",
"url": "https://api.github.com/users/nickjong"
}
|
{
"id": 10639145,
"login": "apple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10639145?",
"url": "https://api.github.com/orgs/apple"
}
| 2019-10-09T16:33:04 |
10594402267
|
{"actor":{"display_login":"nickjong"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/281360635","pull_request_review_id":234202070,"id":281360635,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTM2MDYzNQ==","diff_hunk":"@@ -261,6 +265,41 @@ public func spawnChild(_ args: [String])\n \n // Close the pipe when we're done writing the error.\n close(childToParentPipe.writeFD)\n+ } else {\n+ close(childToParentPipe.writeFD)\n+\n+ // Figure out if the child was execve correctly or not.\n+ var readfds = _stdlib_fd_set()\n+ readfds.set(childToParentPipe.readFD)\n+ var writefds = _stdlib_fd_set()\n+ var errorfds = _stdlib_fd_set()\n+ errorfds.set(childToParentPipe.readFD)\n+\n+ var ret: CInt\n+ repeat {\n+ ret = _stdlib_select(&readfds, &writefds, &errorfds, nil)\n+ } while ret == -1 && errno == EINTR\n+ if ret <= 0 {\n+ fatalError(\"select() returned an error\")\n+ }\n+\n+ if readfds.isset(childToParentPipe.readFD) || errorfds.isset(childToParentPipe.readFD) {\n+ var childErrno: CInt = 0\n+ let readResult: ssize_t = withUnsafeMutablePointer(to: &childErrno) {\n+ return read(childToParentPipe.readFD, $0, MemoryLayout<CInt>.size)\n+ }\n+ if readResult == 0 {\n+ // We found EOF, which happens when child execve is successful.","path":"stdlib/private/SwiftPrivateLibcExtras/Subprocess.swift","position":39,"original_position":39,"commit_id":"094ad6e2d81fa6e00fbeb5cc2270c311c5033d94","original_commit_id":"094ad6e2d81fa6e00fbeb5cc2270c311c5033d94","user":{"login":"compnerd","id":63311,"node_id":"MDQ6VXNlcjYzMzEx","avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"body":"I think you missed some word here.\r\n\r\n`We read an `EOF` indicating that the child was exec'ed successfully.`","created_at":"2019-05-06T21:07:47Z","updated_at":"2019-05-06T21:09:45Z","html_url":"https://github.com/apple/swift/pull/24521#discussion_r281360635","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/24521","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/281360635"},"html":{"href":"https://github.com/apple/swift/pull/24521#discussion_r281360635"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/24521"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/24521","id":276283419,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MjgzNDE5","html_url":"https://github.com/apple/swift/pull/24521","diff_url":"https://github.com/apple/swift/pull/24521.diff","patch_url":"https://github.com/apple/swift/pull/24521.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/24521","number":24521,"state":"open","locked":false,"title":"[android] Stop leaking FDs in parent test process.","user":{"login":"drodriguez","id":6338,"node_id":"MDQ6VXNlcjYzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/6338?v=4","gravatar_id":"","url":"https://api.github.com/users/drodriguez","html_url":"https://github.com/drodriguez","followers_url":"https://api.github.com/users/drodriguez/followers","following_url":"https://api.github.com/users/drodriguez/following{/other_user}","gists_url":"https://api.github.com/users/drodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/drodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drodriguez/subscriptions","organizations_url":"https://api.github.com/users/drodriguez/orgs","repos_url":"https://api.github.com/users/drodriguez/repos","events_url":"https://api.github.com/users/drodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/drodriguez/received_events","type":"User","site_admin":false},"body":"In the Android paths of the spawnChild function, the parent was creating\r\na pipe that was never closed, which led to FD starvation. In some tests\r\nwith a lots of expected crashes, the childs will not spawn anymore since\r\nthe linker would not have enough descriptors to open the shared\r\nlibraries, while in other tests which closed the child descriptors as\r\npart of the last test, the parent process will hang waiting those\r\ndescriptors to be closed, which will never had happened.\r\n\r\nThe solution is implement the missing parts of the code, which tried to\r\nread from the pipe in the parent side (using select and read, taking\r\npieces from other parts of the code). This should match the fork/execv\r\npath used by Android and Haiku to the spawn code used by the rest of the\r\nplatforms.\r\n\r\nThis change fixes StdlibUnittest/Stdin.swift,\r\nstdlib/InputStream.swift.gyb,\r\nstdlib/Collection/FlattenCollection.swift.gyb and\r\nstdlib/Collection/LazyFilterCollection.swift.gyb, which were the last 4\r\ntests failing in Android AArch64.\r\n\r\n/cc @zhuowei which wrote the original code and @return since this code might affect Haiku","created_at":"2019-05-06T18:21:18Z","updated_at":"2019-05-06T21:09:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e9791abeab0409c44af210481d8a3e38fede006","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/24521/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/24521/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/24521/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/094ad6e2d81fa6e00fbeb5cc2270c311c5033d94","head":{"label":"drodriguez:android-stop-leaking-fds","ref":"android-stop-leaking-fds","sha":"094ad6e2d81fa6e00fbeb5cc2270c311c5033d94","user":{"login":"drodriguez","id":6338,"node_id":"MDQ6VXNlcjYzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/6338?v=4","gravatar_id":"","url":"https://api.github.com/users/drodriguez","html_url":"https://github.com/drodriguez","followers_url":"https://api.github.com/users/drodriguez/followers","following_url":"https://api.github.com/users/drodriguez/following{/other_user}","gists_url":"https://api.github.com/users/drodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/drodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drodriguez/subscriptions","organizations_url":"https://api.github.com/users/drodriguez/orgs","repos_url":"https://api.github.com/users/drodriguez/repos","events_url":"https://api.github.com/users/drodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/drodriguez/received_events","type":"User","site_admin":false},"repo":{"id":149670806,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NzA4MDY=","name":"swift","full_name":"drodriguez/swift","private":false,"owner":{"login":"drodriguez","id":6338,"node_id":"MDQ6VXNlcjYzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/6338?v=4","gravatar_id":"","url":"https://api.github.com/users/drodriguez","html_url":"https://github.com/drodriguez","followers_url":"https://api.github.com/users/drodriguez/followers","following_url":"https://api.github.com/users/drodriguez/following{/other_user}","gists_url":"https://api.github.com/users/drodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/drodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drodriguez/subscriptions","organizations_url":"https://api.github.com/users/drodriguez/orgs","repos_url":"https://api.github.com/users/drodriguez/repos","events_url":"https://api.github.com/users/drodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/drodriguez/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drodriguez/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/drodriguez/swift","forks_url":"https://api.github.com/repos/drodriguez/swift/forks","keys_url":"https://api.github.com/repos/drodriguez/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drodriguez/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drodriguez/swift/teams","hooks_url":"https://api.github.com/repos/drodriguez/swift/hooks","issue_events_url":"https://api.github.com/repos/drodriguez/swift/issues/events{/number}","events_url":"https://api.github.com/repos/drodriguez/swift/events","assignees_url":"https://api.github.com/repos/drodriguez/swift/assignees{/user}","branches_url":"https://api.github.com/repos/drodriguez/swift/branches{/branch}","tags_url":"https://api.github.com/repos/drodriguez/swift/tags","blobs_url":"https://api.github.com/repos/drodriguez/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drodriguez/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drodriguez/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/drodriguez/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drodriguez/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/drodriguez/swift/languages","stargazers_url":"https://api.github.com/repos/drodriguez/swift/stargazers","contributors_url":"https://api.github.com/repos/drodriguez/swift/contributors","subscribers_url":"https://api.github.com/repos/drodriguez/swift/subscribers","subscription_url":"https://api.github.com/repos/drodriguez/swift/subscription","commits_url":"https://api.github.com/repos/drodriguez/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/drodriguez/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/drodriguez/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/drodriguez/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/drodriguez/swift/contents/{+path}","compare_url":"https://api.github.com/repos/drodriguez/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drodriguez/swift/merges","archive_url":"https://api.github.com/repos/drodriguez/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drodriguez/swift/downloads","issues_url":"https://api.github.com/repos/drodriguez/swift/issues{/number}","pulls_url":"https://api.github.com/repos/drodriguez/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/drodriguez/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/drodriguez/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drodriguez/swift/labels{/name}","releases_url":"https://api.github.com/repos/drodriguez/swift/releases{/id}","deployments_url":"https://api.github.com/repos/drodriguez/swift/deployments","created_at":"2018-09-20T21:07:07Z","updated_at":"2019-04-10T01:13:10Z","pushed_at":"2019-05-06T18:35:00Z","git_url":"git://github.com/drodriguez/swift.git","ssh_url":"git@github.com:drodriguez/swift.git","clone_url":"https://github.com/drodriguez/swift.git","svn_url":"https://github.com/drodriguez/swift","homepage":"https://swift.org","size":393250,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"7311886219a5c636b27d913654b3d47bac918a4c","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2019-05-06T20:57:28Z","pushed_at":"2019-05-06T20:56:05Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":418133,"stargazers_count":47590,"watchers_count":47590,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7560,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":530,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7560,"open_issues":530,"watchers":47590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/24521"},"html":{"href":"https://github.com/apple/swift/pull/24521"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/24521"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/24521/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/24521/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/24521/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/094ad6e2d81fa6e00fbeb5cc2270c311c5033d94"}},"author_association":"COLLABORATOR"}}
|
{
"id": 44838949,
"name": "apple/swift",
"url": "https://api.github.com/repos/apple/swift"
}
|
{
"id": 63311,
"login": "compnerd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/63311?",
"url": "https://api.github.com/users/compnerd"
}
|
{
"id": 10639145,
"login": "apple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10639145?",
"url": "https://api.github.com/orgs/apple"
}
| 2019-05-06T21:07:47 |
9573301814
|
{"actor":{"display_login":"compnerd"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/311164766","pull_request_review_id":271475455,"id":311164766,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTE2NDc2Ng==","diff_hunk":"@@ -100,25 +519,31 @@ StringRef ASTGen::copyAndStripUnderscores(StringRef Orig, ASTContext &Context) {\n return StringRef(start, p - start);\n }\n \n-StringRef ASTGen::copyAndStripUnderscores(StringRef Orig) {\n- return copyAndStripUnderscores(Orig, Context);\n+SourceLoc ASTGen::advanceLocBegin(const SourceLoc &Loc, const Syntax &Node) {\n+ return Loc.getAdvancedLoc(Node.getAbsolutePosition().getOffset());","path":"lib/Parse/ASTGen.cpp","position":536,"original_position":536,"commit_id":"1ccc21c176c39ea7e02129479dbf88338d3304c1","original_commit_id":"10ef5df221c343a0fc695803ac985ebbdc798d6d","user":{"login":"rintaro","id":142081,"node_id":"MDQ6VXNlcjE0MjA4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"body":"> `Loc` always points to the start of leading trivia of the tree where `Node` is.\r\n\r\nAh, I see. Thanks for explanation 👍 ","created_at":"2019-08-06T16:43:53Z","updated_at":"2019-08-06T16:43:54Z","html_url":"https://github.com/apple/swift/pull/26478#discussion_r311164766","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/26478","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/311164766"},"html":{"href":"https://github.com/apple/swift/pull/26478#discussion_r311164766"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/26478"}},"in_reply_to_id":310840784},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/26478","id":304006017,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0MDA2MDE3","html_url":"https://github.com/apple/swift/pull/26478","diff_url":"https://github.com/apple/swift/pull/26478.diff","patch_url":"https://github.com/apple/swift/pull/26478.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/26478","number":26478,"state":"open","locked":false,"title":"[Parser] Decouple the parser from AST creation (part 2)","user":{"login":"jansvoboda11","id":11258894,"node_id":"MDQ6VXNlcjExMjU4ODk0","avatar_url":"https://avatars3.githubusercontent.com/u/11258894?v=4","gravatar_id":"","url":"https://api.github.com/users/jansvoboda11","html_url":"https://github.com/jansvoboda11","followers_url":"https://api.github.com/users/jansvoboda11/followers","following_url":"https://api.github.com/users/jansvoboda11/following{/other_user}","gists_url":"https://api.github.com/users/jansvoboda11/gists{/gist_id}","starred_url":"https://api.github.com/users/jansvoboda11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansvoboda11/subscriptions","organizations_url":"https://api.github.com/users/jansvoboda11/orgs","repos_url":"https://api.github.com/users/jansvoboda11/repos","events_url":"https://api.github.com/users/jansvoboda11/events{/privacy}","received_events_url":"https://api.github.com/users/jansvoboda11/received_events","type":"User","site_admin":false},"body":"Instead of creating the AST directly in the parser (and libSyntax or SwiftSyntax via SyntaxParsingContext), make Parser to explicitly create a tree of ParsedSyntaxNodes. Their OpaqueSyntaxNodes can be either libSyntax or SwiftSyntax. If AST is needed, it can be generated from the libSyntax tree.\r\nThis PR contains refactored type parsing.\r\n\r\nThis PR is a part of a Google Summer of Code 2019 [project](https://swift.org/gsoc2019/#integration-of-libsyntax-with-the-rest-of-the-compiler-pipeline).","created_at":"2019-08-03T15:08:28Z","updated_at":"2019-08-06T16:43:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5da3843ff888fcbf3af6671aa81b26905dc12c1","assignee":{"login":"rintaro","id":142081,"node_id":"MDQ6VXNlcjE0MjA4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"assignees":[{"login":"rintaro","id":142081,"node_id":"MDQ6VXNlcjE0MjA4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/26478/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/26478/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/26478/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/1ccc21c176c39ea7e02129479dbf88338d3304c1","head":{"label":"jansvoboda11:gsoc-2019-parser-types","ref":"gsoc-2019-parser-types","sha":"1ccc21c176c39ea7e02129479dbf88338d3304c1","user":{"login":"jansvoboda11","id":11258894,"node_id":"MDQ6VXNlcjExMjU4ODk0","avatar_url":"https://avatars3.githubusercontent.com/u/11258894?v=4","gravatar_id":"","url":"https://api.github.com/users/jansvoboda11","html_url":"https://github.com/jansvoboda11","followers_url":"https://api.github.com/users/jansvoboda11/followers","following_url":"https://api.github.com/users/jansvoboda11/following{/other_user}","gists_url":"https://api.github.com/users/jansvoboda11/gists{/gist_id}","starred_url":"https://api.github.com/users/jansvoboda11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansvoboda11/subscriptions","organizations_url":"https://api.github.com/users/jansvoboda11/orgs","repos_url":"https://api.github.com/users/jansvoboda11/repos","events_url":"https://api.github.com/users/jansvoboda11/events{/privacy}","received_events_url":"https://api.github.com/users/jansvoboda11/received_events","type":"User","site_admin":false},"repo":{"id":185461774,"node_id":"MDEwOlJlcG9zaXRvcnkxODU0NjE3NzQ=","name":"swift","full_name":"jansvoboda11/swift","private":false,"owner":{"login":"jansvoboda11","id":11258894,"node_id":"MDQ6VXNlcjExMjU4ODk0","avatar_url":"https://avatars3.githubusercontent.com/u/11258894?v=4","gravatar_id":"","url":"https://api.github.com/users/jansvoboda11","html_url":"https://github.com/jansvoboda11","followers_url":"https://api.github.com/users/jansvoboda11/followers","following_url":"https://api.github.com/users/jansvoboda11/following{/other_user}","gists_url":"https://api.github.com/users/jansvoboda11/gists{/gist_id}","starred_url":"https://api.github.com/users/jansvoboda11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansvoboda11/subscriptions","organizations_url":"https://api.github.com/users/jansvoboda11/orgs","repos_url":"https://api.github.com/users/jansvoboda11/repos","events_url":"https://api.github.com/users/jansvoboda11/events{/privacy}","received_events_url":"https://api.github.com/users/jansvoboda11/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jansvoboda11/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/jansvoboda11/swift","forks_url":"https://api.github.com/repos/jansvoboda11/swift/forks","keys_url":"https://api.github.com/repos/jansvoboda11/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jansvoboda11/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jansvoboda11/swift/teams","hooks_url":"https://api.github.com/repos/jansvoboda11/swift/hooks","issue_events_url":"https://api.github.com/repos/jansvoboda11/swift/issues/events{/number}","events_url":"https://api.github.com/repos/jansvoboda11/swift/events","assignees_url":"https://api.github.com/repos/jansvoboda11/swift/assignees{/user}","branches_url":"https://api.github.com/repos/jansvoboda11/swift/branches{/branch}","tags_url":"https://api.github.com/repos/jansvoboda11/swift/tags","blobs_url":"https://api.github.com/repos/jansvoboda11/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jansvoboda11/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jansvoboda11/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jansvoboda11/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jansvoboda11/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/jansvoboda11/swift/languages","stargazers_url":"https://api.github.com/repos/jansvoboda11/swift/stargazers","contributors_url":"https://api.github.com/repos/jansvoboda11/swift/contributors","subscribers_url":"https://api.github.com/repos/jansvoboda11/swift/subscribers","subscription_url":"https://api.github.com/repos/jansvoboda11/swift/subscription","commits_url":"https://api.github.com/repos/jansvoboda11/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jansvoboda11/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jansvoboda11/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jansvoboda11/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jansvoboda11/swift/contents/{+path}","compare_url":"https://api.github.com/repos/jansvoboda11/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jansvoboda11/swift/merges","archive_url":"https://api.github.com/repos/jansvoboda11/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jansvoboda11/swift/downloads","issues_url":"https://api.github.com/repos/jansvoboda11/swift/issues{/number}","pulls_url":"https://api.github.com/repos/jansvoboda11/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/jansvoboda11/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/jansvoboda11/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jansvoboda11/swift/labels{/name}","releases_url":"https://api.github.com/repos/jansvoboda11/swift/releases{/id}","deployments_url":"https://api.github.com/repos/jansvoboda11/swift/deployments","created_at":"2019-05-07T19:00:28Z","updated_at":"2019-08-03T12:18:56Z","pushed_at":"2019-08-06T09:21:37Z","git_url":"git://github.com/jansvoboda11/swift.git","ssh_url":"git@github.com:jansvoboda11/swift.git","clone_url":"https://github.com/jansvoboda11/swift.git","svn_url":"https://github.com/jansvoboda11/swift","homepage":"https://swift.org","size":439385,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"6ddfd1506fbca4b8b284c6b19b3b6568146ef274","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2019-08-06T15:34:42Z","pushed_at":"2019-08-06T16:43:15Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":453882,"stargazers_count":48741,"watchers_count":48741,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7818,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":566,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7818,"open_issues":566,"watchers":48741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/26478"},"html":{"href":"https://github.com/apple/swift/pull/26478"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/26478"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/26478/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/26478/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/26478/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/1ccc21c176c39ea7e02129479dbf88338d3304c1"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 44838949,
"name": "apple/swift",
"url": "https://api.github.com/repos/apple/swift"
}
|
{
"id": 142081,
"login": "rintaro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/142081?",
"url": "https://api.github.com/users/rintaro"
}
|
{
"id": 10639145,
"login": "apple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10639145?",
"url": "https://api.github.com/orgs/apple"
}
| 2019-08-06T16:43:53 |
10158365150
|
{"actor":{"display_login":"rintaro"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/demisto/content/pulls/comments/279198813","pull_request_review_id":231472717,"id":279198813,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTE5ODgxMw==","diff_hunk":"@@ -0,0 +1,342 @@\n+commonfields:\n+ id: OPSWAT-Metadefender V2\n+ version: -1\n+name: OPSWAT-Metadefender V2\n+display: OPSWAT-Metadefender V2\n+category: Data Enrichment & Threat Intelligence\n+image: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAHgAAAANCAYAAABii6qgAAAHSklEQVR42r1Ya2wUVRS+s1AgAgE0aKsEDEgkGnwEAV/ID+wfjTEQq4lEEDRNTFqJMdBtod3Zmd1td5eqrcEA/kBa9sG0SMBUHv4oiAYjCKK0QLe7s9vSFgLIu2ApjN+ZnS3b7c7ubAtOcjI7955z7t3znde9rP+jcKWlwjyeF78pKxNay8qsAbxb6LfFIh61Wu2fmc38EyzFA/lZPG+rguxXRshqtS0tLi5+KJVO6JtjtYoW8Fen02exCFWiKE6PEzYxf3gxq+86yLzyfDaYpyb4Bqvv/JV5A28NSn5LcDar6zjAagMfp2JzOp1jLRbeDjJsPyLiLy3lnTzPP0h6MPYmvjcVF/NP9Slfs0Z8EgDuBil2e4Vis5UnEsadiiDYL8EBKgoLC0cm2ySUf1BR4Vb5HQ6nIYLOk3CM5xN15eXlDcPm3aLo6DGqi9a2Wsty+5TUNudwPvk69/0Zhdva9g/ztM7KCBw4BSe1X+O2dSl4dwOsBRnKz+C2RrpU+brTd5g3uEyP1eVyZSOQbpSXuxL/VwwTeg+YI35gchsAT3a73aMBrghHd0LXrhi40wGs7HC4SAExX+F5IYD3yTgKg3qjC6gKa6Bw+MBoE96njdCCoC5Qpz4JmLfdwSaJ/7fq6up+ToOxRTZbhQKAtT1BJg3BWUDCK31KGpXhJm/oWxXg+g6F84ebmNQ10RA4ntAU8Ie5ug5yDgII8pE25mmZakh+kzye84UPcds6SZ4cBHT6KqsJJM0kDodjIoBpQlZL9t+6MQ7nFW8mzmn8LatX2x7Lz8/PQrAUINAAj7CGSZI0DEp3EWhgvIVBO2amgh4gg+M9it6rVjnH4veLAGRPzJOgaHkygDXAzoL/cbO5fIIeUUopKxM/B4C0di/0zUwAuIYiEmueICckmVRUXh7VOcDxas6M5vzyfooiFWivvJ2AT52Wj41G5O8jGUSgwvlCbfSmb4z/zNY1jUkpzysmk0/2YD0ClmQ6oEPRnCXCPJGpA0RQTkDj6T/Qf9FIs5VQT7YAVo30HT9P/Gazmd4m0lNYWD2ypKQkJ1YzZyN6b0cj12pjaR4oGQOD/6GlhSP4HpEMYPKqxIjUSekLNYAV2kv8HFLM1ijA4kF8cno6jEdjRFYNvO2Mgm8hFbvJG1wPcGKA7tFS/Y80RmTyhTemSc3Fqmw9otcv/8W2BCZhLKaTxg4yKTjO6PZhA4/TuZZssYdl8sAj7FrEXaQQN7aYkB8FUexGZE1LBFhL8zdpM6CGFLQL61+I8gtyUVHFuARdBeRIBD54f0+lC6l5BxyP8tIk3Y3XhuYhmq5qqbKXeQJ5Os5QgHRO4FD0BpjUHrWLr+1RpOxTNE7zzCN/mlw+8DbW6FGdSWo7j3WfTZZJKMIZMqhBgL1RgIW9GQGMDnmfZuAApWNjMtZcrS7eKS0tnZWsBhMoFH3YlB5hfq3aIEBXN+TeTdZVYo2fwJNeF+ajzmDH/yjX7/R9weXU7IAAHozvDT2T0PEuoGaK5vG+wnytL/eXl+dC7nJUvv0G5HP7R27gaU6KnAW4JN/LfKF3EjMJnEYmByGgmSfIDw1g4xF8ibzfIMCfaDLXqV7rRPC/BA6oIXXk2dZRbU9VEpApCuEw9Wl0NYJ6tNLxXZp07UYEaekz/CfbfEI9plFdhPHbyfgASL/j3dK6lJyE+AB2O/MHpmnyE9BUHaGmisCDM1jU8Q2Hs1h1YCSTlBFRvpbX4BzXKJOAbgPkxfcNYBjwBRhPrcEAzmANFo9qhjycn78hS6fJOkfNAPsfH6y5XqvZzdRN6jJKTSOQKnf21VOv7GObmrIBzoFY+mT+0NrUNTrkulujQ7+gY86GHm9cjZYo/QLk9+BIf6N+N3NSRzNq+5eak32kZQmFMgLzhl+6HwBrZ02hgbpo1LEeKBJQi6dQuo4RdWUELJqgufFdNDrgZSm66PMlJfZHhgQY1ox1lOk6aKyVg6bsB3I8vI9BLk2X3Pow54scpygGsCA5AkOr4FAzpUYcnpRO4pUbtPM1yYShJzErkCNs5HZ3K9yOCwrXcIX4WtkGJUubqyR5NZ37I0FK3/ca4IRzsFOhcyc1XFB0KuEcHIo/B8OIm8mI9xdgYQOcST1LG6DzcFBFO0qIxjpr+TlqgjhJrcexc/IpVhvOMSQvydkA5gSBSvKannOo4zPv8gQno0krYH55BW7DViC9953RyYnISeI66/3UWd9zgOnBtdYMGGgvSP8mC+OYv5zuJsvlqiSAr61cyWcPEeCdbvcXhm/E0KyR420vKioaZ/z4FF4EYG5plxGXEEVzMtqkPzgbTnKR5EkP84UXZiSP0oC63xRL7aj7r+oAXFdZWUUA7xtKSjQJgmM+0nANoiBI99AatYKOY9xM0Z7uLhrZoJqaN7ocGQrA0PUh9lNl5P6ZnA7r5lLJyXghNDmIrkN4vz7Iu+YFrK7zMK5BlwxKHk0aorwRGYVHLR+V3Bb8EgTZ19TgZqL6PzsxIZF8cW5MAAAAAElFTkSuQmCC\n+description: multi-scanning engine uses 30+ anti-malware engines to scan files for\n+ threats, significantly increasing malware detection.\n+configuration:\n+- display: Server URL (e.g. http://localhost:8008/metascan_rest/)\n+ name: url\n+ defaultvalue: http://localhost:8008/metascan_rest/\n+ type: 0\n+ required: true\n+- display: API Key - Needed in cloud based solutions\n+ name: api_key\n+ defaultvalue: \"\"\n+ type: 4\n+ required: false\n+- display: Cloud based\n+ name: cloud\n+ defaultvalue: \"false\"\n+ type: 8\n+ required: false\n+- display: Trust any certificate (unsecure)\n+ name: insecure\n+ defaultvalue: \"true\"\n+ type: 8\n+ required: false\n+- display: Use system proxy settings\n+ name: proxy\n+ defaultvalue: \"false\"\n+ type: 8\n+ required: false\n+- display: The high threshold\n+ name: highPercnt\n+ defaultvalue: \"66\"\n+ type: 0\n+ required: false\n+- display: 'The low threshold '\n+ name: lowPercnt\n+ defaultvalue: \"34\"\n+ type: 0\n+ required: false\n+script:\n+ script: |\n+ import os\n+ import requests\n+ import json\n+ import shutil\n+\n+\n+ # disable insecure warnings\n+ requests.packages.urllib3.disable_warnings()\n+\n+ ''' GLOBAL VARS '''\n+ PARAMS = demisto.params()\n+ BASE_URL = PARAMS['url'] + '/' if PARAMS['url'][-1] != '/' else PARAMS['url']\n+ USE_SSL = not PARAMS.get('insecure', False)\n+ API_KEY = PARAMS.get('api_key', '')\n+ USE_CLOUD = PARAMS.get('cloud', False)\n+ HIGH_THRESHOLD = int(PARAMS.get('highPercnt', 66))\n+ LOW_THRESHOLD = int(PARAMS.get('lowPercnt', 34))\n+\n+\n+\n+\n+ if not demisto.params()['proxy']:\n+ del os.environ['HTTP_PROXY']\n+ del os.environ['HTTPS_PROXY']\n+ del os.environ['http_proxy']\n+ del os.environ['https_proxy']\n+\n+ DEFAULT_HEADERS = {\n+ 'Accept': 'application/json'\n+ }\n+\n+ HTTP_ERROR_CODES = {\n+ '400': 'Request failed, got status 400: bad request. Check command parameters',\n+ '401': 'Request failed, got status 401: unauthorized. Check your API Key',\n+ '404': 'Request failed, got status 404: not found. Check integration URL Address',\n+ }\n+\n+ ''' HELPER FUNCTIONS '''\n+ def http_req(method='GET', url_suffix='', file=None, parse_json=True):\n+ files = None\n+ url = BASE_URL + url_suffix\n+ headers = DEFAULT_HEADERS\n+ if USE_CLOUD:\n+ headers['apikey'] = API_KEY\n+ if file:\n+ headers['filename'] = file['file_name']\n+ files = {file['file_name']:file['file']}\n+ LOG(f'running request with url={url}\\n\\tfiles={files}')\n+ if method.upper() == 'GET':\n+ res = requests.get(url, verify=USE_SSL, headers=headers)\n+ elif method.upper() == 'POST':\n+ res = requests.post(url, verify=USE_SSL, files=files, headers=headers)\n+ else:\n+ return_error(f'Got unsupporthed http method: {method}')\n+ return ''\n+ status = res.status_code\n+ if status != 200:\n+ if str(status) in HTTP_ERROR_CODES:\n+ return_error(HTTP_ERROR_CODES[str(status)])\n+ return ''","path":"Integrations/integration-opswat-metadefender-v2.yml","position":107,"original_position":107,"commit_id":"8214771f931be01c60e4a0a13e21b42b87261b6e","original_commit_id":"8214771f931be01c60e4a0a13e21b42b87261b6e","user":{"login":"Itay4","id":31018228,"node_id":"MDQ6VXNlcjMxMDE4MjI4","avatar_url":"https://avatars1.githubusercontent.com/u/31018228?v=4","gravatar_id":"","url":"https://api.github.com/users/Itay4","html_url":"https://github.com/Itay4","followers_url":"https://api.github.com/users/Itay4/followers","following_url":"https://api.github.com/users/Itay4/following{/other_user}","gists_url":"https://api.github.com/users/Itay4/gists{/gist_id}","starred_url":"https://api.github.com/users/Itay4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itay4/subscriptions","organizations_url":"https://api.github.com/users/Itay4/orgs","repos_url":"https://api.github.com/users/Itay4/repos","events_url":"https://api.github.com/users/Itay4/events{/privacy}","received_events_url":"https://api.github.com/users/Itay4/received_events","type":"User","site_admin":false},"body":"remove this","created_at":"2019-04-28T15:05:20Z","updated_at":"2019-04-28T15:27:55Z","html_url":"https://github.com/demisto/content/pull/3439#discussion_r279198813","pull_request_url":"https://api.github.com/repos/demisto/content/pulls/3439","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/demisto/content/pulls/comments/279198813"},"html":{"href":"https://github.com/demisto/content/pull/3439#discussion_r279198813"},"pull_request":{"href":"https://api.github.com/repos/demisto/content/pulls/3439"}}},"pull_request":{"url":"https://api.github.com/repos/demisto/content/pulls/3439","id":274185350,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0MTg1MzUw","html_url":"https://github.com/demisto/content/pull/3439","diff_url":"https://github.com/demisto/content/pull/3439.diff","patch_url":"https://github.com/demisto/content/pull/3439.patch","issue_url":"https://api.github.com/repos/demisto/content/issues/3439","number":3439,"state":"open","locked":false,"title":"opswat v2 integration","user":{"login":"yuvalbenshalom","id":19407287,"node_id":"MDQ6VXNlcjE5NDA3Mjg3","avatar_url":"https://avatars1.githubusercontent.com/u/19407287?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalbenshalom","html_url":"https://github.com/yuvalbenshalom","followers_url":"https://api.github.com/users/yuvalbenshalom/followers","following_url":"https://api.github.com/users/yuvalbenshalom/following{/other_user}","gists_url":"https://api.github.com/users/yuvalbenshalom/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalbenshalom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalbenshalom/subscriptions","organizations_url":"https://api.github.com/users/yuvalbenshalom/orgs","repos_url":"https://api.github.com/users/yuvalbenshalom/repos","events_url":"https://api.github.com/users/yuvalbenshalom/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalbenshalom/received_events","type":"User","site_admin":false},"body":"since we do not have an instance for opswat yet, this is just a short fix.\r\n## Status\r\nReady\r\n\r\n## Related Issues\r\nfixes: https://github.com/demisto/etc/issues/16301\r\n\r\n## Description\r\nA few sentences describing the overall goals of the pull request's commits.\r\n\r\n\r\n## Does it break backward compatibility?\r\n - No - version 2\r\n\r\n## Must have\r\n- [x] Tests - no instance\r\n- [ ] Documentation (with link to it)\r\n- [ ] Code Review\r\n\r\n","created_at":"2019-04-28T14:50:31Z","updated_at":"2019-04-28T15:27:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e24ed66c3ffdb5db52cf3a71c3e78ba573b5696","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/demisto/content/pulls/3439/commits","review_comments_url":"https://api.github.com/repos/demisto/content/pulls/3439/comments","review_comment_url":"https://api.github.com/repos/demisto/content/pulls/comments{/number}","comments_url":"https://api.github.com/repos/demisto/content/issues/3439/comments","statuses_url":"https://api.github.com/repos/demisto/content/statuses/8214771f931be01c60e4a0a13e21b42b87261b6e","head":{"label":"demisto:opswatv2","ref":"opswatv2","sha":"8214771f931be01c60e4a0a13e21b42b87261b6e","user":{"login":"demisto","id":11011767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDExNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/11011767?v=4","gravatar_id":"","url":"https://api.github.com/users/demisto","html_url":"https://github.com/demisto","followers_url":"https://api.github.com/users/demisto/followers","following_url":"https://api.github.com/users/demisto/following{/other_user}","gists_url":"https://api.github.com/users/demisto/gists{/gist_id}","starred_url":"https://api.github.com/users/demisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demisto/subscriptions","organizations_url":"https://api.github.com/users/demisto/orgs","repos_url":"https://api.github.com/users/demisto/repos","events_url":"https://api.github.com/users/demisto/events{/privacy}","received_events_url":"https://api.github.com/users/demisto/received_events","type":"Organization","site_admin":false},"repo":{"id":60525392,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUyNTM5Mg==","name":"content","full_name":"demisto/content","private":false,"owner":{"login":"demisto","id":11011767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDExNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/11011767?v=4","gravatar_id":"","url":"https://api.github.com/users/demisto","html_url":"https://github.com/demisto","followers_url":"https://api.github.com/users/demisto/followers","following_url":"https://api.github.com/users/demisto/following{/other_user}","gists_url":"https://api.github.com/users/demisto/gists{/gist_id}","starred_url":"https://api.github.com/users/demisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demisto/subscriptions","organizations_url":"https://api.github.com/users/demisto/orgs","repos_url":"https://api.github.com/users/demisto/repos","events_url":"https://api.github.com/users/demisto/events{/privacy}","received_events_url":"https://api.github.com/users/demisto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/demisto/content","description":"This repository contains all Demisto content and from here we share content updates","fork":false,"url":"https://api.github.com/repos/demisto/content","forks_url":"https://api.github.com/repos/demisto/content/forks","keys_url":"https://api.github.com/repos/demisto/content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/demisto/content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/demisto/content/teams","hooks_url":"https://api.github.com/repos/demisto/content/hooks","issue_events_url":"https://api.github.com/repos/demisto/content/issues/events{/number}","events_url":"https://api.github.com/repos/demisto/content/events","assignees_url":"https://api.github.com/repos/demisto/content/assignees{/user}","branches_url":"https://api.github.com/repos/demisto/content/branches{/branch}","tags_url":"https://api.github.com/repos/demisto/content/tags","blobs_url":"https://api.github.com/repos/demisto/content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/demisto/content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/demisto/content/git/refs{/sha}","trees_url":"https://api.github.com/repos/demisto/content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/demisto/content/statuses/{sha}","languages_url":"https://api.github.com/repos/demisto/content/languages","stargazers_url":"https://api.github.com/repos/demisto/content/stargazers","contributors_url":"https://api.github.com/repos/demisto/content/contributors","subscribers_url":"https://api.github.com/repos/demisto/content/subscribers","subscription_url":"https://api.github.com/repos/demisto/content/subscription","commits_url":"https://api.github.com/repos/demisto/content/commits{/sha}","git_commits_url":"https://api.github.com/repos/demisto/content/git/commits{/sha}","comments_url":"https://api.github.com/repos/demisto/content/comments{/number}","issue_comment_url":"https://api.github.com/repos/demisto/content/issues/comments{/number}","contents_url":"https://api.github.com/repos/demisto/content/contents/{+path}","compare_url":"https://api.github.com/repos/demisto/content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/demisto/content/merges","archive_url":"https://api.github.com/repos/demisto/content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/demisto/content/downloads","issues_url":"https://api.github.com/repos/demisto/content/issues{/number}","pulls_url":"https://api.github.com/repos/demisto/content/pulls{/number}","milestones_url":"https://api.github.com/repos/demisto/content/milestones{/number}","notifications_url":"https://api.github.com/repos/demisto/content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/demisto/content/labels{/name}","releases_url":"https://api.github.com/repos/demisto/content/releases{/id}","deployments_url":"https://api.github.com/repos/demisto/content/deployments","created_at":"2016-06-06T12:17:02Z","updated_at":"2019-04-28T15:14:23Z","pushed_at":"2019-04-28T15:20:05Z","git_url":"git://github.com/demisto/content.git","ssh_url":"git@github.com:demisto/content.git","clone_url":"https://github.com/demisto/content.git","svn_url":"https://github.com/demisto/content","homepage":"","size":68112,"stargazers_count":249,"watchers_count":249,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":144,"open_issues":55,"watchers":249,"default_branch":"master"}},"base":{"label":"demisto:master","ref":"master","sha":"c3c4c113e31f5a77d37a9312e3c11a39f1401f4b","user":{"login":"demisto","id":11011767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDExNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/11011767?v=4","gravatar_id":"","url":"https://api.github.com/users/demisto","html_url":"https://github.com/demisto","followers_url":"https://api.github.com/users/demisto/followers","following_url":"https://api.github.com/users/demisto/following{/other_user}","gists_url":"https://api.github.com/users/demisto/gists{/gist_id}","starred_url":"https://api.github.com/users/demisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demisto/subscriptions","organizations_url":"https://api.github.com/users/demisto/orgs","repos_url":"https://api.github.com/users/demisto/repos","events_url":"https://api.github.com/users/demisto/events{/privacy}","received_events_url":"https://api.github.com/users/demisto/received_events","type":"Organization","site_admin":false},"repo":{"id":60525392,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUyNTM5Mg==","name":"content","full_name":"demisto/content","private":false,"owner":{"login":"demisto","id":11011767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDExNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/11011767?v=4","gravatar_id":"","url":"https://api.github.com/users/demisto","html_url":"https://github.com/demisto","followers_url":"https://api.github.com/users/demisto/followers","following_url":"https://api.github.com/users/demisto/following{/other_user}","gists_url":"https://api.github.com/users/demisto/gists{/gist_id}","starred_url":"https://api.github.com/users/demisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demisto/subscriptions","organizations_url":"https://api.github.com/users/demisto/orgs","repos_url":"https://api.github.com/users/demisto/repos","events_url":"https://api.github.com/users/demisto/events{/privacy}","received_events_url":"https://api.github.com/users/demisto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/demisto/content","description":"This repository contains all Demisto content and from here we share content updates","fork":false,"url":"https://api.github.com/repos/demisto/content","forks_url":"https://api.github.com/repos/demisto/content/forks","keys_url":"https://api.github.com/repos/demisto/content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/demisto/content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/demisto/content/teams","hooks_url":"https://api.github.com/repos/demisto/content/hooks","issue_events_url":"https://api.github.com/repos/demisto/content/issues/events{/number}","events_url":"https://api.github.com/repos/demisto/content/events","assignees_url":"https://api.github.com/repos/demisto/content/assignees{/user}","branches_url":"https://api.github.com/repos/demisto/content/branches{/branch}","tags_url":"https://api.github.com/repos/demisto/content/tags","blobs_url":"https://api.github.com/repos/demisto/content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/demisto/content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/demisto/content/git/refs{/sha}","trees_url":"https://api.github.com/repos/demisto/content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/demisto/content/statuses/{sha}","languages_url":"https://api.github.com/repos/demisto/content/languages","stargazers_url":"https://api.github.com/repos/demisto/content/stargazers","contributors_url":"https://api.github.com/repos/demisto/content/contributors","subscribers_url":"https://api.github.com/repos/demisto/content/subscribers","subscription_url":"https://api.github.com/repos/demisto/content/subscription","commits_url":"https://api.github.com/repos/demisto/content/commits{/sha}","git_commits_url":"https://api.github.com/repos/demisto/content/git/commits{/sha}","comments_url":"https://api.github.com/repos/demisto/content/comments{/number}","issue_comment_url":"https://api.github.com/repos/demisto/content/issues/comments{/number}","contents_url":"https://api.github.com/repos/demisto/content/contents/{+path}","compare_url":"https://api.github.com/repos/demisto/content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/demisto/content/merges","archive_url":"https://api.github.com/repos/demisto/content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/demisto/content/downloads","issues_url":"https://api.github.com/repos/demisto/content/issues{/number}","pulls_url":"https://api.github.com/repos/demisto/content/pulls{/number}","milestones_url":"https://api.github.com/repos/demisto/content/milestones{/number}","notifications_url":"https://api.github.com/repos/demisto/content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/demisto/content/labels{/name}","releases_url":"https://api.github.com/repos/demisto/content/releases{/id}","deployments_url":"https://api.github.com/repos/demisto/content/deployments","created_at":"2016-06-06T12:17:02Z","updated_at":"2019-04-28T15:14:23Z","pushed_at":"2019-04-28T15:20:05Z","git_url":"git://github.com/demisto/content.git","ssh_url":"git@github.com:demisto/content.git","clone_url":"https://github.com/demisto/content.git","svn_url":"https://github.com/demisto/content","homepage":"","size":68112,"stargazers_count":249,"watchers_count":249,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":144,"open_issues":55,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/demisto/content/pulls/3439"},"html":{"href":"https://github.com/demisto/content/pull/3439"},"issue":{"href":"https://api.github.com/repos/demisto/content/issues/3439"},"comments":{"href":"https://api.github.com/repos/demisto/content/issues/3439/comments"},"review_comments":{"href":"https://api.github.com/repos/demisto/content/pulls/3439/comments"},"review_comment":{"href":"https://api.github.com/repos/demisto/content/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/demisto/content/pulls/3439/commits"},"statuses":{"href":"https://api.github.com/repos/demisto/content/statuses/8214771f931be01c60e4a0a13e21b42b87261b6e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 60525392,
"name": "demisto/content",
"url": "https://api.github.com/repos/demisto/content"
}
|
{
"id": 31018228,
"login": "Itay4",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31018228?",
"url": "https://api.github.com/users/Itay4"
}
|
{
"id": 11011767,
"login": "demisto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11011767?",
"url": "https://api.github.com/orgs/demisto"
}
| 2019-04-28T15:05:20 |
9525847194
|
{"actor":{"display_login":"Itay4"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/github-actions/pulls/comments/334242559","pull_request_review_id":301010332,"id":334242559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDI0MjU1OQ==","diff_hunk":"@@ -1 +1,24 @@\n-# actions\n\\ No newline at end of file\n+## GitHub Actions Maintainer \n+\n+The GitHub Actions Maintainer provides a set of GitHub Actions to make maitaining project easier.\n+\n+## Actions\n+\n+🌏 [@github-actions/fastlane-env-reminder](fastlane-env-reminder) \n+\n+\n+Adds a comment to include fastlane environment in an issue description if it is missing. Read more [here](fastlane-env-reminder).\n+\n+## Versioning \n+\n+All the actions are released in one batch. We do not support semantic versioning. Reference a `latest` branch in your workflow:\n+\n+```yaml\n+...\n+ - uses: fastlane/github-actions/fastlane-env-reminder@latest\n+...\n+```\n+\n+## Contributing\n+\n+We welcome contributions. See [how to contribute](CONTRIBUTING.md).","path":"README.md","position":26,"original_position":26,"commit_id":"8dfdeb13f81ed44318d7b7413a386612e208e200","original_commit_id":"8dfdeb13f81ed44318d7b7413a386612e208e200","user":{"login":"janpio","id":183673,"node_id":"MDQ6VXNlcjE4MzY3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/183673?v=4","gravatar_id":"","url":"https://api.github.com/users/janpio","html_url":"https://github.com/janpio","followers_url":"https://api.github.com/users/janpio/followers","following_url":"https://api.github.com/users/janpio/following{/other_user}","gists_url":"https://api.github.com/users/janpio/gists{/gist_id}","starred_url":"https://api.github.com/users/janpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janpio/subscriptions","organizations_url":"https://api.github.com/users/janpio/orgs","repos_url":"https://api.github.com/users/janpio/repos","events_url":"https://api.github.com/users/janpio/events{/privacy}","received_events_url":"https://api.github.com/users/janpio/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nWe welcome contributions. See [how to contribute](CONTRIBUTING.md).\r\n```","created_at":"2019-10-12T15:30:23Z","updated_at":"2019-10-12T15:30:23Z","html_url":"https://github.com/fastlane/github-actions/pull/15#discussion_r334242559","pull_request_url":"https://api.github.com/repos/fastlane/github-actions/pulls/15","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/fastlane/github-actions/pulls/comments/334242559"},"html":{"href":"https://github.com/fastlane/github-actions/pull/15#discussion_r334242559"},"pull_request":{"href":"https://api.github.com/repos/fastlane/github-actions/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/github-actions/pulls/15","id":327055723,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3MDU1NzIz","html_url":"https://github.com/fastlane/github-actions/pull/15","diff_url":"https://github.com/fastlane/github-actions/pull/15.diff","patch_url":"https://github.com/fastlane/github-actions/pull/15.patch","issue_url":"https://api.github.com/repos/fastlane/github-actions/issues/15","number":15,"state":"open","locked":false,"title":"Update the documentation","user":{"login":"mollyIV","id":10795657,"node_id":"MDQ6VXNlcjEwNzk1NjU3","avatar_url":"https://avatars0.githubusercontent.com/u/10795657?v=4","gravatar_id":"","url":"https://api.github.com/users/mollyIV","html_url":"https://github.com/mollyIV","followers_url":"https://api.github.com/users/mollyIV/followers","following_url":"https://api.github.com/users/mollyIV/following{/other_user}","gists_url":"https://api.github.com/users/mollyIV/gists{/gist_id}","starred_url":"https://api.github.com/users/mollyIV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mollyIV/subscriptions","organizations_url":"https://api.github.com/users/mollyIV/orgs","repos_url":"https://api.github.com/users/mollyIV/repos","events_url":"https://api.github.com/users/mollyIV/events{/privacy}","received_events_url":"https://api.github.com/users/mollyIV/received_events","type":"User","site_admin":false},"body":"Updated the documentation:\r\n- README.md ([rendered version](https://github.com/fastlane/github-actions/blob/update-documentation/README.md))\r\n- CONTRIBUTING.md ([rendered version](https://github.com/fastlane/github-actions/blob/update-documentation/CONTRIBUTING.md))\r\n\r\ncloses: https://github.com/fastlane/github-actions/issues/7","created_at":"2019-10-11T06:51:02Z","updated_at":"2019-10-12T15:30:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd00ef42e39f5b4e76a025d577ea7afdb95ecad2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/github-actions/pulls/15/commits","review_comments_url":"https://api.github.com/repos/fastlane/github-actions/pulls/15/comments","review_comment_url":"https://api.github.com/repos/fastlane/github-actions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/github-actions/issues/15/comments","statuses_url":"https://api.github.com/repos/fastlane/github-actions/statuses/8dfdeb13f81ed44318d7b7413a386612e208e200","head":{"label":"fastlane:update-documentation","ref":"update-documentation","sha":"8dfdeb13f81ed44318d7b7413a386612e208e200","user":{"login":"fastlane","id":11098337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDk4MzM3","avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":205684528,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU2ODQ1Mjg=","name":"github-actions","full_name":"fastlane/github-actions","private":false,"owner":{"login":"fastlane","id":11098337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDk4MzM3","avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fastlane/github-actions","description":null,"fork":false,"url":"https://api.github.com/repos/fastlane/github-actions","forks_url":"https://api.github.com/repos/fastlane/github-actions/forks","keys_url":"https://api.github.com/repos/fastlane/github-actions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/github-actions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/github-actions/teams","hooks_url":"https://api.github.com/repos/fastlane/github-actions/hooks","issue_events_url":"https://api.github.com/repos/fastlane/github-actions/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/github-actions/events","assignees_url":"https://api.github.com/repos/fastlane/github-actions/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/github-actions/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/github-actions/tags","blobs_url":"https://api.github.com/repos/fastlane/github-actions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/github-actions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/github-actions/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/github-actions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/github-actions/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/github-actions/languages","stargazers_url":"https://api.github.com/repos/fastlane/github-actions/stargazers","contributors_url":"https://api.github.com/repos/fastlane/github-actions/contributors","subscribers_url":"https://api.github.com/repos/fastlane/github-actions/subscribers","subscription_url":"https://api.github.com/repos/fastlane/github-actions/subscription","commits_url":"https://api.github.com/repos/fastlane/github-actions/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/github-actions/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/github-actions/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/github-actions/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/github-actions/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/github-actions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/github-actions/merges","archive_url":"https://api.github.com/repos/fastlane/github-actions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/github-actions/downloads","issues_url":"https://api.github.com/repos/fastlane/github-actions/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/github-actions/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/github-actions/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/github-actions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/github-actions/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/github-actions/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/github-actions/deployments","created_at":"2019-09-01T14:02:52Z","updated_at":"2019-10-04T15:26:17Z","pushed_at":"2019-10-12T09:41:09Z","git_url":"git://github.com/fastlane/github-actions.git","ssh_url":"git@github.com:fastlane/github-actions.git","clone_url":"https://github.com/fastlane/github-actions.git","svn_url":"https://github.com/fastlane/github-actions","homepage":null,"size":430,"stargazers_count":12,"watchers_count":12,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":null,"forks":1,"open_issues":8,"watchers":12,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"737ac379df0c36d5fcf6c8ab99f5555a0f0a18a1","user":{"login":"fastlane","id":11098337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDk4MzM3","avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":205684528,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU2ODQ1Mjg=","name":"github-actions","full_name":"fastlane/github-actions","private":false,"owner":{"login":"fastlane","id":11098337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDk4MzM3","avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fastlane/github-actions","description":null,"fork":false,"url":"https://api.github.com/repos/fastlane/github-actions","forks_url":"https://api.github.com/repos/fastlane/github-actions/forks","keys_url":"https://api.github.com/repos/fastlane/github-actions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/github-actions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/github-actions/teams","hooks_url":"https://api.github.com/repos/fastlane/github-actions/hooks","issue_events_url":"https://api.github.com/repos/fastlane/github-actions/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/github-actions/events","assignees_url":"https://api.github.com/repos/fastlane/github-actions/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/github-actions/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/github-actions/tags","blobs_url":"https://api.github.com/repos/fastlane/github-actions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/github-actions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/github-actions/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/github-actions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/github-actions/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/github-actions/languages","stargazers_url":"https://api.github.com/repos/fastlane/github-actions/stargazers","contributors_url":"https://api.github.com/repos/fastlane/github-actions/contributors","subscribers_url":"https://api.github.com/repos/fastlane/github-actions/subscribers","subscription_url":"https://api.github.com/repos/fastlane/github-actions/subscription","commits_url":"https://api.github.com/repos/fastlane/github-actions/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/github-actions/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/github-actions/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/github-actions/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/github-actions/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/github-actions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/github-actions/merges","archive_url":"https://api.github.com/repos/fastlane/github-actions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/github-actions/downloads","issues_url":"https://api.github.com/repos/fastlane/github-actions/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/github-actions/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/github-actions/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/github-actions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/github-actions/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/github-actions/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/github-actions/deployments","created_at":"2019-09-01T14:02:52Z","updated_at":"2019-10-04T15:26:17Z","pushed_at":"2019-10-12T09:41:09Z","git_url":"git://github.com/fastlane/github-actions.git","ssh_url":"git@github.com:fastlane/github-actions.git","clone_url":"https://github.com/fastlane/github-actions.git","svn_url":"https://github.com/fastlane/github-actions","homepage":null,"size":430,"stargazers_count":12,"watchers_count":12,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":null,"forks":1,"open_issues":8,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/github-actions/pulls/15"},"html":{"href":"https://github.com/fastlane/github-actions/pull/15"},"issue":{"href":"https://api.github.com/repos/fastlane/github-actions/issues/15"},"comments":{"href":"https://api.github.com/repos/fastlane/github-actions/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/github-actions/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/github-actions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/github-actions/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/github-actions/statuses/8dfdeb13f81ed44318d7b7413a386612e208e200"}},"author_association":"MEMBER"}}
|
{
"id": 205684528,
"name": "fastlane/github-actions",
"url": "https://api.github.com/repos/fastlane/github-actions"
}
|
{
"id": 183673,
"login": "janpio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/183673?",
"url": "https://api.github.com/users/janpio"
}
|
{
"id": 11098337,
"login": "fastlane",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11098337?",
"url": "https://api.github.com/orgs/fastlane"
}
| 2019-10-12T15:30:23 |
10616941767
|
{"actor":{"display_login":"janpio"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/comments/323265913","pull_request_review_id":286823309,"id":323265913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMzI2NTkxMw==","diff_hunk":"@@ -182,6 +198,12 @@ class MemberAdmin(admin.ModelAdmin):\n })\n )\n \n+ def save_model(self, request, obj, form, change):\n+ if 'username' in form.changed_data and change:","path":"stregsystem/admin.py","position":35,"original_position":35,"commit_id":"8c218101745d7f037362c864b6e8d5e41528199c","original_commit_id":"8c218101745d7f037362c864b6e8d5e41528199c","user":{"login":"hrjakobsen","id":3295293,"node_id":"MDQ6VXNlcjMyOTUyOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3295293?v=4","gravatar_id":"","url":"https://api.github.com/users/hrjakobsen","html_url":"https://github.com/hrjakobsen","followers_url":"https://api.github.com/users/hrjakobsen/followers","following_url":"https://api.github.com/users/hrjakobsen/following{/other_user}","gists_url":"https://api.github.com/users/hrjakobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/hrjakobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrjakobsen/subscriptions","organizations_url":"https://api.github.com/users/hrjakobsen/orgs","repos_url":"https://api.github.com/users/hrjakobsen/repos","events_url":"https://api.github.com/users/hrjakobsen/events{/privacy}","received_events_url":"https://api.github.com/users/hrjakobsen/received_events","type":"User","site_admin":false},"body":"Because the form cannot send messages, since it has no access to request, so it can only invalidate the form, and cancel the creation/update. So only in the save_model can we access the request and send a warning message.\r\n\r\nThis is for when a member is updated, and the username is duplicate. If we don't allow this, old data cannot be updated without errors. ","created_at":"2019-09-11T14:14:37Z","updated_at":"2019-09-11T14:14:37Z","html_url":"https://github.com/f-klubben/stregsystemet/pull/178#discussion_r323265913","pull_request_url":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/178","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/comments/323265913"},"html":{"href":"https://github.com/f-klubben/stregsystemet/pull/178#discussion_r323265913"},"pull_request":{"href":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/178"}},"in_reply_to_id":323250399},"pull_request":{"url":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/178","id":315985380,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1OTg1Mzgw","html_url":"https://github.com/f-klubben/stregsystemet/pull/178","diff_url":"https://github.com/f-klubben/stregsystemet/pull/178.diff","patch_url":"https://github.com/f-klubben/stregsystemet/pull/178.patch","issue_url":"https://api.github.com/repos/f-klubben/stregsystemet/issues/178","number":178,"state":"open","locked":false,"title":"Avoid duplicate member usernames","user":{"login":"hrjakobsen","id":3295293,"node_id":"MDQ6VXNlcjMyOTUyOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3295293?v=4","gravatar_id":"","url":"https://api.github.com/users/hrjakobsen","html_url":"https://github.com/hrjakobsen","followers_url":"https://api.github.com/users/hrjakobsen/followers","following_url":"https://api.github.com/users/hrjakobsen/following{/other_user}","gists_url":"https://api.github.com/users/hrjakobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/hrjakobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrjakobsen/subscriptions","organizations_url":"https://api.github.com/users/hrjakobsen/orgs","repos_url":"https://api.github.com/users/hrjakobsen/repos","events_url":"https://api.github.com/users/hrjakobsen/events{/privacy}","received_events_url":"https://api.github.com/users/hrjakobsen/received_events","type":"User","site_admin":false},"body":"This PR adds error messages when new fembers are created with usernames that already exists. If an existing member is updated with a duplicate username, a warning message is shown for backwards compatibility with duplicate usernames. \r\n\r\nThis feature was requested by TREO'en.","created_at":"2019-09-10T13:06:37Z","updated_at":"2019-09-11T14:14:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"416d5313fb0e9d914b5ccbc9087a57ee66142cea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/178/commits","review_comments_url":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/178/comments","review_comment_url":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/f-klubben/stregsystemet/issues/178/comments","statuses_url":"https://api.github.com/repos/f-klubben/stregsystemet/statuses/8c218101745d7f037362c864b6e8d5e41528199c","head":{"label":"f-klubben:feature-unique-usernames","ref":"feature-unique-usernames","sha":"8c218101745d7f037362c864b6e8d5e41528199c","user":{"login":"f-klubben","id":11196981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTk2OTgx","avatar_url":"https://avatars3.githubusercontent.com/u/11196981?v=4","gravatar_id":"","url":"https://api.github.com/users/f-klubben","html_url":"https://github.com/f-klubben","followers_url":"https://api.github.com/users/f-klubben/followers","following_url":"https://api.github.com/users/f-klubben/following{/other_user}","gists_url":"https://api.github.com/users/f-klubben/gists{/gist_id}","starred_url":"https://api.github.com/users/f-klubben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f-klubben/subscriptions","organizations_url":"https://api.github.com/users/f-klubben/orgs","repos_url":"https://api.github.com/users/f-klubben/repos","events_url":"https://api.github.com/users/f-klubben/events{/privacy}","received_events_url":"https://api.github.com/users/f-klubben/received_events","type":"Organization","site_admin":false},"repo":{"id":84310208,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMxMDIwOA==","name":"stregsystemet","full_name":"f-klubben/stregsystemet","private":false,"owner":{"login":"f-klubben","id":11196981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTk2OTgx","avatar_url":"https://avatars3.githubusercontent.com/u/11196981?v=4","gravatar_id":"","url":"https://api.github.com/users/f-klubben","html_url":"https://github.com/f-klubben","followers_url":"https://api.github.com/users/f-klubben/followers","following_url":"https://api.github.com/users/f-klubben/following{/other_user}","gists_url":"https://api.github.com/users/f-klubben/gists{/gist_id}","starred_url":"https://api.github.com/users/f-klubben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f-klubben/subscriptions","organizations_url":"https://api.github.com/users/f-klubben/orgs","repos_url":"https://api.github.com/users/f-klubben/repos","events_url":"https://api.github.com/users/f-klubben/events{/privacy}","received_events_url":"https://api.github.com/users/f-klubben/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/f-klubben/stregsystemet","description":"The very public stregsystem repo","fork":false,"url":"https://api.github.com/repos/f-klubben/stregsystemet","forks_url":"https://api.github.com/repos/f-klubben/stregsystemet/forks","keys_url":"https://api.github.com/repos/f-klubben/stregsystemet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/f-klubben/stregsystemet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/f-klubben/stregsystemet/teams","hooks_url":"https://api.github.com/repos/f-klubben/stregsystemet/hooks","issue_events_url":"https://api.github.com/repos/f-klubben/stregsystemet/issues/events{/number}","events_url":"https://api.github.com/repos/f-klubben/stregsystemet/events","assignees_url":"https://api.github.com/repos/f-klubben/stregsystemet/assignees{/user}","branches_url":"https://api.github.com/repos/f-klubben/stregsystemet/branches{/branch}","tags_url":"https://api.github.com/repos/f-klubben/stregsystemet/tags","blobs_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/refs{/sha}","trees_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/f-klubben/stregsystemet/statuses/{sha}","languages_url":"https://api.github.com/repos/f-klubben/stregsystemet/languages","stargazers_url":"https://api.github.com/repos/f-klubben/stregsystemet/stargazers","contributors_url":"https://api.github.com/repos/f-klubben/stregsystemet/contributors","subscribers_url":"https://api.github.com/repos/f-klubben/stregsystemet/subscribers","subscription_url":"https://api.github.com/repos/f-klubben/stregsystemet/subscription","commits_url":"https://api.github.com/repos/f-klubben/stregsystemet/commits{/sha}","git_commits_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/commits{/sha}","comments_url":"https://api.github.com/repos/f-klubben/stregsystemet/comments{/number}","issue_comment_url":"https://api.github.com/repos/f-klubben/stregsystemet/issues/comments{/number}","contents_url":"https://api.github.com/repos/f-klubben/stregsystemet/contents/{+path}","compare_url":"https://api.github.com/repos/f-klubben/stregsystemet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/f-klubben/stregsystemet/merges","archive_url":"https://api.github.com/repos/f-klubben/stregsystemet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/f-klubben/stregsystemet/downloads","issues_url":"https://api.github.com/repos/f-klubben/stregsystemet/issues{/number}","pulls_url":"https://api.github.com/repos/f-klubben/stregsystemet/pulls{/number}","milestones_url":"https://api.github.com/repos/f-klubben/stregsystemet/milestones{/number}","notifications_url":"https://api.github.com/repos/f-klubben/stregsystemet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/f-klubben/stregsystemet/labels{/name}","releases_url":"https://api.github.com/repos/f-klubben/stregsystemet/releases{/id}","deployments_url":"https://api.github.com/repos/f-klubben/stregsystemet/deployments","created_at":"2017-03-08T10:51:12Z","updated_at":"2019-08-18T06:27:50Z","pushed_at":"2019-09-10T13:06:38Z","git_url":"git://github.com/f-klubben/stregsystemet.git","ssh_url":"git@github.com:f-klubben/stregsystemet.git","clone_url":"https://github.com/f-klubben/stregsystemet.git","svn_url":"https://github.com/f-klubben/stregsystemet","homepage":"","size":451,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":32,"watchers":12,"default_branch":"next"}},"base":{"label":"f-klubben:next","ref":"next","sha":"e5a5b084c4fa3b61d02f87f03a0c185c76fb26e7","user":{"login":"f-klubben","id":11196981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTk2OTgx","avatar_url":"https://avatars3.githubusercontent.com/u/11196981?v=4","gravatar_id":"","url":"https://api.github.com/users/f-klubben","html_url":"https://github.com/f-klubben","followers_url":"https://api.github.com/users/f-klubben/followers","following_url":"https://api.github.com/users/f-klubben/following{/other_user}","gists_url":"https://api.github.com/users/f-klubben/gists{/gist_id}","starred_url":"https://api.github.com/users/f-klubben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f-klubben/subscriptions","organizations_url":"https://api.github.com/users/f-klubben/orgs","repos_url":"https://api.github.com/users/f-klubben/repos","events_url":"https://api.github.com/users/f-klubben/events{/privacy}","received_events_url":"https://api.github.com/users/f-klubben/received_events","type":"Organization","site_admin":false},"repo":{"id":84310208,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMxMDIwOA==","name":"stregsystemet","full_name":"f-klubben/stregsystemet","private":false,"owner":{"login":"f-klubben","id":11196981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTk2OTgx","avatar_url":"https://avatars3.githubusercontent.com/u/11196981?v=4","gravatar_id":"","url":"https://api.github.com/users/f-klubben","html_url":"https://github.com/f-klubben","followers_url":"https://api.github.com/users/f-klubben/followers","following_url":"https://api.github.com/users/f-klubben/following{/other_user}","gists_url":"https://api.github.com/users/f-klubben/gists{/gist_id}","starred_url":"https://api.github.com/users/f-klubben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f-klubben/subscriptions","organizations_url":"https://api.github.com/users/f-klubben/orgs","repos_url":"https://api.github.com/users/f-klubben/repos","events_url":"https://api.github.com/users/f-klubben/events{/privacy}","received_events_url":"https://api.github.com/users/f-klubben/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/f-klubben/stregsystemet","description":"The very public stregsystem repo","fork":false,"url":"https://api.github.com/repos/f-klubben/stregsystemet","forks_url":"https://api.github.com/repos/f-klubben/stregsystemet/forks","keys_url":"https://api.github.com/repos/f-klubben/stregsystemet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/f-klubben/stregsystemet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/f-klubben/stregsystemet/teams","hooks_url":"https://api.github.com/repos/f-klubben/stregsystemet/hooks","issue_events_url":"https://api.github.com/repos/f-klubben/stregsystemet/issues/events{/number}","events_url":"https://api.github.com/repos/f-klubben/stregsystemet/events","assignees_url":"https://api.github.com/repos/f-klubben/stregsystemet/assignees{/user}","branches_url":"https://api.github.com/repos/f-klubben/stregsystemet/branches{/branch}","tags_url":"https://api.github.com/repos/f-klubben/stregsystemet/tags","blobs_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/refs{/sha}","trees_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/f-klubben/stregsystemet/statuses/{sha}","languages_url":"https://api.github.com/repos/f-klubben/stregsystemet/languages","stargazers_url":"https://api.github.com/repos/f-klubben/stregsystemet/stargazers","contributors_url":"https://api.github.com/repos/f-klubben/stregsystemet/contributors","subscribers_url":"https://api.github.com/repos/f-klubben/stregsystemet/subscribers","subscription_url":"https://api.github.com/repos/f-klubben/stregsystemet/subscription","commits_url":"https://api.github.com/repos/f-klubben/stregsystemet/commits{/sha}","git_commits_url":"https://api.github.com/repos/f-klubben/stregsystemet/git/commits{/sha}","comments_url":"https://api.github.com/repos/f-klubben/stregsystemet/comments{/number}","issue_comment_url":"https://api.github.com/repos/f-klubben/stregsystemet/issues/comments{/number}","contents_url":"https://api.github.com/repos/f-klubben/stregsystemet/contents/{+path}","compare_url":"https://api.github.com/repos/f-klubben/stregsystemet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/f-klubben/stregsystemet/merges","archive_url":"https://api.github.com/repos/f-klubben/stregsystemet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/f-klubben/stregsystemet/downloads","issues_url":"https://api.github.com/repos/f-klubben/stregsystemet/issues{/number}","pulls_url":"https://api.github.com/repos/f-klubben/stregsystemet/pulls{/number}","milestones_url":"https://api.github.com/repos/f-klubben/stregsystemet/milestones{/number}","notifications_url":"https://api.github.com/repos/f-klubben/stregsystemet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/f-klubben/stregsystemet/labels{/name}","releases_url":"https://api.github.com/repos/f-klubben/stregsystemet/releases{/id}","deployments_url":"https://api.github.com/repos/f-klubben/stregsystemet/deployments","created_at":"2017-03-08T10:51:12Z","updated_at":"2019-08-18T06:27:50Z","pushed_at":"2019-09-10T13:06:38Z","git_url":"git://github.com/f-klubben/stregsystemet.git","ssh_url":"git@github.com:f-klubben/stregsystemet.git","clone_url":"https://github.com/f-klubben/stregsystemet.git","svn_url":"https://github.com/f-klubben/stregsystemet","homepage":"","size":451,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":32,"watchers":12,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/178"},"html":{"href":"https://github.com/f-klubben/stregsystemet/pull/178"},"issue":{"href":"https://api.github.com/repos/f-klubben/stregsystemet/issues/178"},"comments":{"href":"https://api.github.com/repos/f-klubben/stregsystemet/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/f-klubben/stregsystemet/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/f-klubben/stregsystemet/statuses/8c218101745d7f037362c864b6e8d5e41528199c"}},"author_association":"MEMBER"}}
|
{
"id": 84310208,
"name": "f-klubben/stregsystemet",
"url": "https://api.github.com/repos/f-klubben/stregsystemet"
}
|
{
"id": 3295293,
"login": "hrjakobsen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3295293?",
"url": "https://api.github.com/users/hrjakobsen"
}
|
{
"id": 11196981,
"login": "f-klubben",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11196981?",
"url": "https://api.github.com/orgs/f-klubben"
}
| 2019-09-11T14:14:37 |
10394497646
|
{"actor":{"display_login":"hrjakobsen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/comments/341919005","pull_request_review_id":310898887,"id":341919005,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTkxOTAwNQ==","diff_hunk":"@@ -7,6 +7,8 @@ openio_oioswift_definition_file: >\n {{ openio_oioswift_servicename }}/{{ openio_oioswift_servicename }}.conf\"\n openio_oioswift_gridinit_dir: \"/etc/gridinit.d/{{ openio_oioswift_namespace }}\"\n \n+default_openio_redis_keys_format: \"v2\"","path":"vars/main.yml","position":4,"original_position":4,"commit_id":"8f664dbf23bf4bb28a6811ff88609ca7bb97f527","original_commit_id":"8f664dbf23bf4bb28a6811ff88609ca7bb97f527","user":{"login":"cdelgehier","id":9511687,"node_id":"MDQ6VXNlcjk1MTE2ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/9511687?v=4","gravatar_id":"","url":"https://api.github.com/users/cdelgehier","html_url":"https://github.com/cdelgehier","followers_url":"https://api.github.com/users/cdelgehier/followers","following_url":"https://api.github.com/users/cdelgehier/following{/other_user}","gists_url":"https://api.github.com/users/cdelgehier/gists{/gist_id}","starred_url":"https://api.github.com/users/cdelgehier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdelgehier/subscriptions","organizations_url":"https://api.github.com/users/cdelgehier/orgs","repos_url":"https://api.github.com/users/cdelgehier/repos","events_url":"https://api.github.com/users/cdelgehier/events{/privacy}","received_events_url":"https://api.github.com/users/cdelgehier/received_events","type":"User","site_admin":false},"body":"NO\r\nThis is not a default.","created_at":"2019-11-04T07:04:24Z","updated_at":"2019-11-04T07:05:45Z","html_url":"https://github.com/open-io/ansible-role-openio-oioswift/pull/53#discussion_r341919005","pull_request_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/53","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/comments/341919005"},"html":{"href":"https://github.com/open-io/ansible-role-openio-oioswift/pull/53#discussion_r341919005"},"pull_request":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/53","id":334144865,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0MTQ0ODY1","html_url":"https://github.com/open-io/ansible-role-openio-oioswift/pull/53","diff_url":"https://github.com/open-io/ansible-role-openio-oioswift/pull/53.diff","patch_url":"https://github.com/open-io/ansible-role-openio-oioswift/pull/53.patch","issue_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/issues/53","number":53,"state":"open","locked":false,"title":"CHANGE(oioswift): add max_upload_part_num on swift3 filter","user":{"login":"GeoffreyTien","id":34062538,"node_id":"MDQ6VXNlcjM0MDYyNTM4","avatar_url":"https://avatars1.githubusercontent.com/u/34062538?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyTien","html_url":"https://github.com/GeoffreyTien","followers_url":"https://api.github.com/users/GeoffreyTien/followers","following_url":"https://api.github.com/users/GeoffreyTien/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyTien/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyTien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyTien/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyTien/orgs","repos_url":"https://api.github.com/users/GeoffreyTien/repos","events_url":"https://api.github.com/users/GeoffreyTien/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyTien/received_events","type":"User","site_admin":false},"body":" ##### SUMMARY\r\n\r\nThis Fix is ref on QA-17 ticket.\r\n\r\n- max_upload_part_num` is misplaced in `container_hierarchy`, it should be in `swift3\r\n- add default_openio_redis_keys_format.\r\n\r\n ##### IMPACT\r\nN/A\r\n\r\n ##### ADDITIONAL INFORMATION","created_at":"2019-10-30T10:18:43Z","updated_at":"2019-11-04T07:05:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8509c04d3b5650534567b431175f98912c311927","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/53/commits","review_comments_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/53/comments","review_comment_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/issues/53/comments","statuses_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/statuses/8f664dbf23bf4bb28a6811ff88609ca7bb97f527","head":{"label":"GeoffreyTien:19.04","ref":"19.04","sha":"8f664dbf23bf4bb28a6811ff88609ca7bb97f527","user":{"login":"GeoffreyTien","id":34062538,"node_id":"MDQ6VXNlcjM0MDYyNTM4","avatar_url":"https://avatars1.githubusercontent.com/u/34062538?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyTien","html_url":"https://github.com/GeoffreyTien","followers_url":"https://api.github.com/users/GeoffreyTien/followers","following_url":"https://api.github.com/users/GeoffreyTien/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyTien/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyTien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyTien/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyTien/orgs","repos_url":"https://api.github.com/users/GeoffreyTien/repos","events_url":"https://api.github.com/users/GeoffreyTien/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyTien/received_events","type":"User","site_admin":false},"repo":{"id":218498495,"node_id":"MDEwOlJlcG9zaXRvcnkyMTg0OTg0OTU=","name":"ansible-role-openio-oioswift","full_name":"GeoffreyTien/ansible-role-openio-oioswift","private":false,"owner":{"login":"GeoffreyTien","id":34062538,"node_id":"MDQ6VXNlcjM0MDYyNTM4","avatar_url":"https://avatars1.githubusercontent.com/u/34062538?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyTien","html_url":"https://github.com/GeoffreyTien","followers_url":"https://api.github.com/users/GeoffreyTien/followers","following_url":"https://api.github.com/users/GeoffreyTien/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyTien/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyTien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyTien/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyTien/orgs","repos_url":"https://api.github.com/users/GeoffreyTien/repos","events_url":"https://api.github.com/users/GeoffreyTien/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyTien/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GeoffreyTien/ansible-role-openio-oioswift","description":null,"fork":true,"url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift","forks_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/forks","keys_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/teams","hooks_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/hooks","issue_events_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/issues/events{/number}","events_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/events","assignees_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/assignees{/user}","branches_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/branches{/branch}","tags_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/tags","blobs_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/languages","stargazers_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/stargazers","contributors_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/contributors","subscribers_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/subscribers","subscription_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/subscription","commits_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/contents/{+path}","compare_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/merges","archive_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/downloads","issues_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/issues{/number}","pulls_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/labels{/name}","releases_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/releases{/id}","deployments_url":"https://api.github.com/repos/GeoffreyTien/ansible-role-openio-oioswift/deployments","created_at":"2019-10-30T10:12:12Z","updated_at":"2019-10-30T10:12:13Z","pushed_at":"2019-10-30T10:18:14Z","git_url":"git://github.com/GeoffreyTien/ansible-role-openio-oioswift.git","ssh_url":"git@github.com:GeoffreyTien/ansible-role-openio-oioswift.git","clone_url":"https://github.com/GeoffreyTien/ansible-role-openio-oioswift.git","svn_url":"https://github.com/GeoffreyTien/ansible-role-openio-oioswift","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"19.10"}},"base":{"label":"open-io:19.04","ref":"19.04","sha":"0cdfdc69e4a482a37394031bb1b352d88e539c75","user":{"login":"open-io","id":11300184,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzAwMTg0","avatar_url":"https://avatars1.githubusercontent.com/u/11300184?v=4","gravatar_id":"","url":"https://api.github.com/users/open-io","html_url":"https://github.com/open-io","followers_url":"https://api.github.com/users/open-io/followers","following_url":"https://api.github.com/users/open-io/following{/other_user}","gists_url":"https://api.github.com/users/open-io/gists{/gist_id}","starred_url":"https://api.github.com/users/open-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-io/subscriptions","organizations_url":"https://api.github.com/users/open-io/orgs","repos_url":"https://api.github.com/users/open-io/repos","events_url":"https://api.github.com/users/open-io/events{/privacy}","received_events_url":"https://api.github.com/users/open-io/received_events","type":"Organization","site_admin":false},"repo":{"id":136852547,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY4NTI1NDc=","name":"ansible-role-openio-oioswift","full_name":"open-io/ansible-role-openio-oioswift","private":false,"owner":{"login":"open-io","id":11300184,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzAwMTg0","avatar_url":"https://avatars1.githubusercontent.com/u/11300184?v=4","gravatar_id":"","url":"https://api.github.com/users/open-io","html_url":"https://github.com/open-io","followers_url":"https://api.github.com/users/open-io/followers","following_url":"https://api.github.com/users/open-io/following{/other_user}","gists_url":"https://api.github.com/users/open-io/gists{/gist_id}","starred_url":"https://api.github.com/users/open-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-io/subscriptions","organizations_url":"https://api.github.com/users/open-io/orgs","repos_url":"https://api.github.com/users/open-io/repos","events_url":"https://api.github.com/users/open-io/events{/privacy}","received_events_url":"https://api.github.com/users/open-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-io/ansible-role-openio-oioswift","description":null,"fork":false,"url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift","forks_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/forks","keys_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/teams","hooks_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/hooks","issue_events_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/issues/events{/number}","events_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/events","assignees_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/assignees{/user}","branches_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/branches{/branch}","tags_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/tags","blobs_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/statuses/{sha}","languages_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/languages","stargazers_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/stargazers","contributors_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/contributors","subscribers_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/subscribers","subscription_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/subscription","commits_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/contents/{+path}","compare_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/merges","archive_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/downloads","issues_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/issues{/number}","pulls_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls{/number}","milestones_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/milestones{/number}","notifications_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/labels{/name}","releases_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/releases{/id}","deployments_url":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/deployments","created_at":"2018-06-10T23:28:32Z","updated_at":"2019-09-24T15:42:29Z","pushed_at":"2019-10-30T10:18:44Z","git_url":"git://github.com/open-io/ansible-role-openio-oioswift.git","ssh_url":"git@github.com:open-io/ansible-role-openio-oioswift.git","clone_url":"https://github.com/open-io/ansible-role-openio-oioswift.git","svn_url":"https://github.com/open-io/ansible-role-openio-oioswift","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":9,"open_issues":3,"watchers":0,"default_branch":"19.10"}},"_links":{"self":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/53"},"html":{"href":"https://github.com/open-io/ansible-role-openio-oioswift/pull/53"},"issue":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/issues/53"},"comments":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/open-io/ansible-role-openio-oioswift/statuses/8f664dbf23bf4bb28a6811ff88609ca7bb97f527"}},"author_association":"NONE"}}
|
{
"id": 136852547,
"name": "open-io/ansible-role-openio-oioswift",
"url": "https://api.github.com/repos/open-io/ansible-role-openio-oioswift"
}
|
{
"id": 9511687,
"login": "cdelgehier",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9511687?",
"url": "https://api.github.com/users/cdelgehier"
}
|
{
"id": 11300184,
"login": "open-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11300184?",
"url": "https://api.github.com/orgs/open-io"
}
| 2019-11-04T07:04:24 |
10778169502
|
{"actor":{"display_login":"cdelgehier"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/PrimerAI/undercoat/pulls/comments/347058886","pull_request_review_id":317931430,"id":347058886,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzA1ODg4Ng==","diff_hunk":"@@ -1,3 +1,4 @@\n+log","path":".gitignore","position":1,"original_position":1,"commit_id":"42e02e80447ff0a9ee0be23d150cae2c98ff987f","original_commit_id":"42e02e80447ff0a9ee0be23d150cae2c98ff987f","user":{"login":"mandx","id":535282,"node_id":"MDQ6VXNlcjUzNTI4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/535282?v=4","gravatar_id":"","url":"https://api.github.com/users/mandx","html_url":"https://github.com/mandx","followers_url":"https://api.github.com/users/mandx/followers","following_url":"https://api.github.com/users/mandx/following{/other_user}","gists_url":"https://api.github.com/users/mandx/gists{/gist_id}","starred_url":"https://api.github.com/users/mandx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandx/subscriptions","organizations_url":"https://api.github.com/users/mandx/orgs","repos_url":"https://api.github.com/users/mandx/repos","events_url":"https://api.github.com/users/mandx/events{/privacy}","received_events_url":"https://api.github.com/users/mandx/received_events","type":"User","site_admin":false},"body":"This one shouldn't be needed, right? The `yarn-error.log` file should be already covered by the `.log` pattern below.","created_at":"2019-11-16T00:12:07Z","updated_at":"2019-11-16T00:12:08Z","html_url":"https://github.com/PrimerAI/undercoat/pull/2#discussion_r347058886","pull_request_url":"https://api.github.com/repos/PrimerAI/undercoat/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/PrimerAI/undercoat/pulls/comments/347058886"},"html":{"href":"https://github.com/PrimerAI/undercoat/pull/2#discussion_r347058886"},"pull_request":{"href":"https://api.github.com/repos/PrimerAI/undercoat/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/PrimerAI/undercoat/pulls/2","id":341636609,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxNjM2NjA5","html_url":"https://github.com/PrimerAI/undercoat/pull/2","diff_url":"https://github.com/PrimerAI/undercoat/pull/2.diff","patch_url":"https://github.com/PrimerAI/undercoat/pull/2.patch","issue_url":"https://api.github.com/repos/PrimerAI/undercoat/issues/2","number":2,"state":"open","locked":false,"title":"Theme and knobs","user":{"login":"duncanbb","id":13302094,"node_id":"MDQ6VXNlcjEzMzAyMDk0","avatar_url":"https://avatars0.githubusercontent.com/u/13302094?v=4","gravatar_id":"","url":"https://api.github.com/users/duncanbb","html_url":"https://github.com/duncanbb","followers_url":"https://api.github.com/users/duncanbb/followers","following_url":"https://api.github.com/users/duncanbb/following{/other_user}","gists_url":"https://api.github.com/users/duncanbb/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanbb/subscriptions","organizations_url":"https://api.github.com/users/duncanbb/orgs","repos_url":"https://api.github.com/users/duncanbb/repos","events_url":"https://api.github.com/users/duncanbb/events{/privacy}","received_events_url":"https://api.github.com/users/duncanbb/received_events","type":"User","site_admin":false},"body":"add theme and base knobs - swapped textStyle (deprecated) -> fontStyle","created_at":"2019-11-15T20:58:00Z","updated_at":"2019-11-16T00:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99d85b716de52d487f582e04c3ca21c1d4ee06ea","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ElmoJones3","id":3802246,"node_id":"MDQ6VXNlcjM4MDIyNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3802246?v=4","gravatar_id":"","url":"https://api.github.com/users/ElmoJones3","html_url":"https://github.com/ElmoJones3","followers_url":"https://api.github.com/users/ElmoJones3/followers","following_url":"https://api.github.com/users/ElmoJones3/following{/other_user}","gists_url":"https://api.github.com/users/ElmoJones3/gists{/gist_id}","starred_url":"https://api.github.com/users/ElmoJones3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElmoJones3/subscriptions","organizations_url":"https://api.github.com/users/ElmoJones3/orgs","repos_url":"https://api.github.com/users/ElmoJones3/repos","events_url":"https://api.github.com/users/ElmoJones3/events{/privacy}","received_events_url":"https://api.github.com/users/ElmoJones3/received_events","type":"User","site_admin":false},{"login":"christiancho","id":13627157,"node_id":"MDQ6VXNlcjEzNjI3MTU3","avatar_url":"https://avatars1.githubusercontent.com/u/13627157?v=4","gravatar_id":"","url":"https://api.github.com/users/christiancho","html_url":"https://github.com/christiancho","followers_url":"https://api.github.com/users/christiancho/followers","following_url":"https://api.github.com/users/christiancho/following{/other_user}","gists_url":"https://api.github.com/users/christiancho/gists{/gist_id}","starred_url":"https://api.github.com/users/christiancho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiancho/subscriptions","organizations_url":"https://api.github.com/users/christiancho/orgs","repos_url":"https://api.github.com/users/christiancho/repos","events_url":"https://api.github.com/users/christiancho/events{/privacy}","received_events_url":"https://api.github.com/users/christiancho/received_events","type":"User","site_admin":false},{"login":"indiaderrick","id":42939592,"node_id":"MDQ6VXNlcjQyOTM5NTky","avatar_url":"https://avatars1.githubusercontent.com/u/42939592?v=4","gravatar_id":"","url":"https://api.github.com/users/indiaderrick","html_url":"https://github.com/indiaderrick","followers_url":"https://api.github.com/users/indiaderrick/followers","following_url":"https://api.github.com/users/indiaderrick/following{/other_user}","gists_url":"https://api.github.com/users/indiaderrick/gists{/gist_id}","starred_url":"https://api.github.com/users/indiaderrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiaderrick/subscriptions","organizations_url":"https://api.github.com/users/indiaderrick/orgs","repos_url":"https://api.github.com/users/indiaderrick/repos","events_url":"https://api.github.com/users/indiaderrick/events{/privacy}","received_events_url":"https://api.github.com/users/indiaderrick/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PrimerAI/undercoat/pulls/2/commits","review_comments_url":"https://api.github.com/repos/PrimerAI/undercoat/pulls/2/comments","review_comment_url":"https://api.github.com/repos/PrimerAI/undercoat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrimerAI/undercoat/issues/2/comments","statuses_url":"https://api.github.com/repos/PrimerAI/undercoat/statuses/42e02e80447ff0a9ee0be23d150cae2c98ff987f","head":{"label":"PrimerAI:theme-and-knobs","ref":"theme-and-knobs","sha":"42e02e80447ff0a9ee0be23d150cae2c98ff987f","user":{"login":"PrimerAI","id":11340478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQwNDc4","avatar_url":"https://avatars2.githubusercontent.com/u/11340478?v=4","gravatar_id":"","url":"https://api.github.com/users/PrimerAI","html_url":"https://github.com/PrimerAI","followers_url":"https://api.github.com/users/PrimerAI/followers","following_url":"https://api.github.com/users/PrimerAI/following{/other_user}","gists_url":"https://api.github.com/users/PrimerAI/gists{/gist_id}","starred_url":"https://api.github.com/users/PrimerAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrimerAI/subscriptions","organizations_url":"https://api.github.com/users/PrimerAI/orgs","repos_url":"https://api.github.com/users/PrimerAI/repos","events_url":"https://api.github.com/users/PrimerAI/events{/privacy}","received_events_url":"https://api.github.com/users/PrimerAI/received_events","type":"Organization","site_admin":false},"repo":{"id":217659173,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc2NTkxNzM=","name":"undercoat","full_name":"PrimerAI/undercoat","private":false,"owner":{"login":"PrimerAI","id":11340478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQwNDc4","avatar_url":"https://avatars2.githubusercontent.com/u/11340478?v=4","gravatar_id":"","url":"https://api.github.com/users/PrimerAI","html_url":"https://github.com/PrimerAI","followers_url":"https://api.github.com/users/PrimerAI/followers","following_url":"https://api.github.com/users/PrimerAI/following{/other_user}","gists_url":"https://api.github.com/users/PrimerAI/gists{/gist_id}","starred_url":"https://api.github.com/users/PrimerAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrimerAI/subscriptions","organizations_url":"https://api.github.com/users/PrimerAI/orgs","repos_url":"https://api.github.com/users/PrimerAI/repos","events_url":"https://api.github.com/users/PrimerAI/events{/privacy}","received_events_url":"https://api.github.com/users/PrimerAI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrimerAI/undercoat","description":"Primer Design System","fork":false,"url":"https://api.github.com/repos/PrimerAI/undercoat","forks_url":"https://api.github.com/repos/PrimerAI/undercoat/forks","keys_url":"https://api.github.com/repos/PrimerAI/undercoat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrimerAI/undercoat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrimerAI/undercoat/teams","hooks_url":"https://api.github.com/repos/PrimerAI/undercoat/hooks","issue_events_url":"https://api.github.com/repos/PrimerAI/undercoat/issues/events{/number}","events_url":"https://api.github.com/repos/PrimerAI/undercoat/events","assignees_url":"https://api.github.com/repos/PrimerAI/undercoat/assignees{/user}","branches_url":"https://api.github.com/repos/PrimerAI/undercoat/branches{/branch}","tags_url":"https://api.github.com/repos/PrimerAI/undercoat/tags","blobs_url":"https://api.github.com/repos/PrimerAI/undercoat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrimerAI/undercoat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrimerAI/undercoat/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrimerAI/undercoat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrimerAI/undercoat/statuses/{sha}","languages_url":"https://api.github.com/repos/PrimerAI/undercoat/languages","stargazers_url":"https://api.github.com/repos/PrimerAI/undercoat/stargazers","contributors_url":"https://api.github.com/repos/PrimerAI/undercoat/contributors","subscribers_url":"https://api.github.com/repos/PrimerAI/undercoat/subscribers","subscription_url":"https://api.github.com/repos/PrimerAI/undercoat/subscription","commits_url":"https://api.github.com/repos/PrimerAI/undercoat/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrimerAI/undercoat/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrimerAI/undercoat/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrimerAI/undercoat/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrimerAI/undercoat/contents/{+path}","compare_url":"https://api.github.com/repos/PrimerAI/undercoat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrimerAI/undercoat/merges","archive_url":"https://api.github.com/repos/PrimerAI/undercoat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrimerAI/undercoat/downloads","issues_url":"https://api.github.com/repos/PrimerAI/undercoat/issues{/number}","pulls_url":"https://api.github.com/repos/PrimerAI/undercoat/pulls{/number}","milestones_url":"https://api.github.com/repos/PrimerAI/undercoat/milestones{/number}","notifications_url":"https://api.github.com/repos/PrimerAI/undercoat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrimerAI/undercoat/labels{/name}","releases_url":"https://api.github.com/repos/PrimerAI/undercoat/releases{/id}","deployments_url":"https://api.github.com/repos/PrimerAI/undercoat/deployments","created_at":"2019-10-26T05:10:08Z","updated_at":"2019-11-14T01:58:17Z","pushed_at":"2019-11-16T00:04:26Z","git_url":"git://github.com/PrimerAI/undercoat.git","ssh_url":"git@github.com:PrimerAI/undercoat.git","clone_url":"https://github.com/PrimerAI/undercoat.git","svn_url":"https://github.com/PrimerAI/undercoat","homepage":null,"size":540,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"PrimerAI:master","ref":"master","sha":"8eb0bd836eea1e421864865810d3fb0a2d8902dd","user":{"login":"PrimerAI","id":11340478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQwNDc4","avatar_url":"https://avatars2.githubusercontent.com/u/11340478?v=4","gravatar_id":"","url":"https://api.github.com/users/PrimerAI","html_url":"https://github.com/PrimerAI","followers_url":"https://api.github.com/users/PrimerAI/followers","following_url":"https://api.github.com/users/PrimerAI/following{/other_user}","gists_url":"https://api.github.com/users/PrimerAI/gists{/gist_id}","starred_url":"https://api.github.com/users/PrimerAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrimerAI/subscriptions","organizations_url":"https://api.github.com/users/PrimerAI/orgs","repos_url":"https://api.github.com/users/PrimerAI/repos","events_url":"https://api.github.com/users/PrimerAI/events{/privacy}","received_events_url":"https://api.github.com/users/PrimerAI/received_events","type":"Organization","site_admin":false},"repo":{"id":217659173,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc2NTkxNzM=","name":"undercoat","full_name":"PrimerAI/undercoat","private":false,"owner":{"login":"PrimerAI","id":11340478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQwNDc4","avatar_url":"https://avatars2.githubusercontent.com/u/11340478?v=4","gravatar_id":"","url":"https://api.github.com/users/PrimerAI","html_url":"https://github.com/PrimerAI","followers_url":"https://api.github.com/users/PrimerAI/followers","following_url":"https://api.github.com/users/PrimerAI/following{/other_user}","gists_url":"https://api.github.com/users/PrimerAI/gists{/gist_id}","starred_url":"https://api.github.com/users/PrimerAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrimerAI/subscriptions","organizations_url":"https://api.github.com/users/PrimerAI/orgs","repos_url":"https://api.github.com/users/PrimerAI/repos","events_url":"https://api.github.com/users/PrimerAI/events{/privacy}","received_events_url":"https://api.github.com/users/PrimerAI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrimerAI/undercoat","description":"Primer Design System","fork":false,"url":"https://api.github.com/repos/PrimerAI/undercoat","forks_url":"https://api.github.com/repos/PrimerAI/undercoat/forks","keys_url":"https://api.github.com/repos/PrimerAI/undercoat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrimerAI/undercoat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrimerAI/undercoat/teams","hooks_url":"https://api.github.com/repos/PrimerAI/undercoat/hooks","issue_events_url":"https://api.github.com/repos/PrimerAI/undercoat/issues/events{/number}","events_url":"https://api.github.com/repos/PrimerAI/undercoat/events","assignees_url":"https://api.github.com/repos/PrimerAI/undercoat/assignees{/user}","branches_url":"https://api.github.com/repos/PrimerAI/undercoat/branches{/branch}","tags_url":"https://api.github.com/repos/PrimerAI/undercoat/tags","blobs_url":"https://api.github.com/repos/PrimerAI/undercoat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrimerAI/undercoat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrimerAI/undercoat/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrimerAI/undercoat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrimerAI/undercoat/statuses/{sha}","languages_url":"https://api.github.com/repos/PrimerAI/undercoat/languages","stargazers_url":"https://api.github.com/repos/PrimerAI/undercoat/stargazers","contributors_url":"https://api.github.com/repos/PrimerAI/undercoat/contributors","subscribers_url":"https://api.github.com/repos/PrimerAI/undercoat/subscribers","subscription_url":"https://api.github.com/repos/PrimerAI/undercoat/subscription","commits_url":"https://api.github.com/repos/PrimerAI/undercoat/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrimerAI/undercoat/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrimerAI/undercoat/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrimerAI/undercoat/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrimerAI/undercoat/contents/{+path}","compare_url":"https://api.github.com/repos/PrimerAI/undercoat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrimerAI/undercoat/merges","archive_url":"https://api.github.com/repos/PrimerAI/undercoat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrimerAI/undercoat/downloads","issues_url":"https://api.github.com/repos/PrimerAI/undercoat/issues{/number}","pulls_url":"https://api.github.com/repos/PrimerAI/undercoat/pulls{/number}","milestones_url":"https://api.github.com/repos/PrimerAI/undercoat/milestones{/number}","notifications_url":"https://api.github.com/repos/PrimerAI/undercoat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrimerAI/undercoat/labels{/name}","releases_url":"https://api.github.com/repos/PrimerAI/undercoat/releases{/id}","deployments_url":"https://api.github.com/repos/PrimerAI/undercoat/deployments","created_at":"2019-10-26T05:10:08Z","updated_at":"2019-11-14T01:58:17Z","pushed_at":"2019-11-16T00:04:26Z","git_url":"git://github.com/PrimerAI/undercoat.git","ssh_url":"git@github.com:PrimerAI/undercoat.git","clone_url":"https://github.com/PrimerAI/undercoat.git","svn_url":"https://github.com/PrimerAI/undercoat","homepage":null,"size":540,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrimerAI/undercoat/pulls/2"},"html":{"href":"https://github.com/PrimerAI/undercoat/pull/2"},"issue":{"href":"https://api.github.com/repos/PrimerAI/undercoat/issues/2"},"comments":{"href":"https://api.github.com/repos/PrimerAI/undercoat/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/PrimerAI/undercoat/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/PrimerAI/undercoat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrimerAI/undercoat/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/PrimerAI/undercoat/statuses/42e02e80447ff0a9ee0be23d150cae2c98ff987f"}},"author_association":"COLLABORATOR"}}
|
{
"id": 217659173,
"name": "PrimerAI/undercoat",
"url": "https://api.github.com/repos/PrimerAI/undercoat"
}
|
{
"id": 535282,
"login": "mandx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/535282?",
"url": "https://api.github.com/users/mandx"
}
|
{
"id": 11340478,
"login": "PrimerAI",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11340478?",
"url": "https://api.github.com/orgs/PrimerAI"
}
| 2019-11-16T00:12:07 |
10876205235
|
{"actor":{"display_login":"mandx"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/raccoongang/edx-platform/pulls/comments/308224515","pull_request_review_id":267772219,"id":308224515,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODIyNDUxNQ==","diff_hunk":"@@ -120,3 +124,74 @@ def learner_profile_context(request, profile_username, user_is_staff):\n context['data']['badges_api_url'] = reverse(\"badges_api:user_assertions\", kwargs={'username': profile_username})\n \n return context\n+\n+def learner_profile_statistics_context(profile_username, profile_statistics):\n+ \"\"\"Context for the learner student_profile/profile_statistics.html page.\n+\n+ Args:\n+ profile_username (str): username of user whose profile is requested.\n+ profile_statistics (str): html in string \n+\n+ Returns:\n+ dict\n+ \"\"\"\n+ context = {\n+ 'data': {\n+ 'error_message': '',\n+ 'profile_statistics': profile_statistics,\n+ 'username': profile_username,\n+ },\n+ }\n+","path":"lms/djangoapps/student_profile/views.py","position":96,"original_position":96,"commit_id":"f714c23887490dee4510472385d8a5c6a1223d30","original_commit_id":"f714c23887490dee4510472385d8a5c6a1223d30","user":{"login":"oleksandra-martyntseva","id":25817760,"node_id":"MDQ6VXNlcjI1ODE3NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/25817760?v=4","gravatar_id":"","url":"https://api.github.com/users/oleksandra-martyntseva","html_url":"https://github.com/oleksandra-martyntseva","followers_url":"https://api.github.com/users/oleksandra-martyntseva/followers","following_url":"https://api.github.com/users/oleksandra-martyntseva/following{/other_user}","gists_url":"https://api.github.com/users/oleksandra-martyntseva/gists{/gist_id}","starred_url":"https://api.github.com/users/oleksandra-martyntseva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleksandra-martyntseva/subscriptions","organizations_url":"https://api.github.com/users/oleksandra-martyntseva/orgs","repos_url":"https://api.github.com/users/oleksandra-martyntseva/repos","events_url":"https://api.github.com/users/oleksandra-martyntseva/events{/privacy}","received_events_url":"https://api.github.com/users/oleksandra-martyntseva/received_events","type":"User","site_admin":false},"body":"Too many blank lines here","created_at":"2019-07-29T13:19:19Z","updated_at":"2019-07-29T13:34:00Z","html_url":"https://github.com/raccoongang/edx-platform/pull/1403#discussion_r308224515","pull_request_url":"https://api.github.com/repos/raccoongang/edx-platform/pulls/1403","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/raccoongang/edx-platform/pulls/comments/308224515"},"html":{"href":"https://github.com/raccoongang/edx-platform/pull/1403#discussion_r308224515"},"pull_request":{"href":"https://api.github.com/repos/raccoongang/edx-platform/pulls/1403"}}},"pull_request":{"url":"https://api.github.com/repos/raccoongang/edx-platform/pulls/1403","id":301520937,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNTIwOTM3","html_url":"https://github.com/raccoongang/edx-platform/pull/1403","diff_url":"https://github.com/raccoongang/edx-platform/pull/1403.diff","patch_url":"https://github.com/raccoongang/edx-platform/pull/1403.patch","issue_url":"https://api.github.com/repos/raccoongang/edx-platform/issues/1403","number":1403,"state":"open","locked":false,"title":"Skillonomy 58","user":{"login":"RuslanSkiraRaccoongang","id":48920645,"node_id":"MDQ6VXNlcjQ4OTIwNjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/48920645?v=4","gravatar_id":"","url":"https://api.github.com/users/RuslanSkiraRaccoongang","html_url":"https://github.com/RuslanSkiraRaccoongang","followers_url":"https://api.github.com/users/RuslanSkiraRaccoongang/followers","following_url":"https://api.github.com/users/RuslanSkiraRaccoongang/following{/other_user}","gists_url":"https://api.github.com/users/RuslanSkiraRaccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/RuslanSkiraRaccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RuslanSkiraRaccoongang/subscriptions","organizations_url":"https://api.github.com/users/RuslanSkiraRaccoongang/orgs","repos_url":"https://api.github.com/users/RuslanSkiraRaccoongang/repos","events_url":"https://api.github.com/users/RuslanSkiraRaccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/RuslanSkiraRaccoongang/received_events","type":"User","site_admin":false},"body":" **DO NOT MERGE I WILL SQUASH COMMITS**\r\n**Description:** Add user stats fetched from customer's platform\r\n\r\n[**Youtrack SKILLONOMY-58:**](https://youtrack.raccoongang.com/issue/SKILLONOMY-58)\r\n\r\n**Reviewers:**\r\n- [ ] @oleksandra-martyntseva\r\n- [ ] @OPersian \r\n\r\n**Merge checklist:**\r\n- [ ] All reviewers approved\r\n- [ ] CI build is green\r\n- [ ] Documentation in source code updated\r\n- [ ] All related Confluence documentation is updated (including deployment documentation)\r\n- [ ] Commits are squashed","created_at":"2019-07-26T12:28:10Z","updated_at":"2019-07-29T13:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9733ad0d321ee3c969e9907ee5be0428b4bca8b4","assignee":{"login":"RuslanSkiraRaccoongang","id":48920645,"node_id":"MDQ6VXNlcjQ4OTIwNjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/48920645?v=4","gravatar_id":"","url":"https://api.github.com/users/RuslanSkiraRaccoongang","html_url":"https://github.com/RuslanSkiraRaccoongang","followers_url":"https://api.github.com/users/RuslanSkiraRaccoongang/followers","following_url":"https://api.github.com/users/RuslanSkiraRaccoongang/following{/other_user}","gists_url":"https://api.github.com/users/RuslanSkiraRaccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/RuslanSkiraRaccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RuslanSkiraRaccoongang/subscriptions","organizations_url":"https://api.github.com/users/RuslanSkiraRaccoongang/orgs","repos_url":"https://api.github.com/users/RuslanSkiraRaccoongang/repos","events_url":"https://api.github.com/users/RuslanSkiraRaccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/RuslanSkiraRaccoongang/received_events","type":"User","site_admin":false},"assignees":[{"login":"RuslanSkiraRaccoongang","id":48920645,"node_id":"MDQ6VXNlcjQ4OTIwNjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/48920645?v=4","gravatar_id":"","url":"https://api.github.com/users/RuslanSkiraRaccoongang","html_url":"https://github.com/RuslanSkiraRaccoongang","followers_url":"https://api.github.com/users/RuslanSkiraRaccoongang/followers","following_url":"https://api.github.com/users/RuslanSkiraRaccoongang/following{/other_user}","gists_url":"https://api.github.com/users/RuslanSkiraRaccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/RuslanSkiraRaccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RuslanSkiraRaccoongang/subscriptions","organizations_url":"https://api.github.com/users/RuslanSkiraRaccoongang/orgs","repos_url":"https://api.github.com/users/RuslanSkiraRaccoongang/repos","events_url":"https://api.github.com/users/RuslanSkiraRaccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/RuslanSkiraRaccoongang/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/raccoongang/edx-platform/pulls/1403/commits","review_comments_url":"https://api.github.com/repos/raccoongang/edx-platform/pulls/1403/comments","review_comment_url":"https://api.github.com/repos/raccoongang/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raccoongang/edx-platform/issues/1403/comments","statuses_url":"https://api.github.com/repos/raccoongang/edx-platform/statuses/f714c23887490dee4510472385d8a5c6a1223d30","head":{"label":"raccoongang:skillonomy-58","ref":"skillonomy-58","sha":"f714c23887490dee4510472385d8a5c6a1223d30","user":{"login":"raccoongang","id":11388447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg4NDQ3","avatar_url":"https://avatars0.githubusercontent.com/u/11388447?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoongang","html_url":"https://github.com/raccoongang","followers_url":"https://api.github.com/users/raccoongang/followers","following_url":"https://api.github.com/users/raccoongang/following{/other_user}","gists_url":"https://api.github.com/users/raccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoongang/subscriptions","organizations_url":"https://api.github.com/users/raccoongang/orgs","repos_url":"https://api.github.com/users/raccoongang/repos","events_url":"https://api.github.com/users/raccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/raccoongang/received_events","type":"Organization","site_admin":false},"repo":{"id":26811891,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgxMTg5MQ==","name":"edx-platform","full_name":"raccoongang/edx-platform","private":false,"owner":{"login":"raccoongang","id":11388447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg4NDQ3","avatar_url":"https://avatars0.githubusercontent.com/u/11388447?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoongang","html_url":"https://github.com/raccoongang","followers_url":"https://api.github.com/users/raccoongang/followers","following_url":"https://api.github.com/users/raccoongang/following{/other_user}","gists_url":"https://api.github.com/users/raccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoongang/subscriptions","organizations_url":"https://api.github.com/users/raccoongang/orgs","repos_url":"https://api.github.com/users/raccoongang/repos","events_url":"https://api.github.com/users/raccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/raccoongang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/raccoongang/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":true,"url":"https://api.github.com/repos/raccoongang/edx-platform","forks_url":"https://api.github.com/repos/raccoongang/edx-platform/forks","keys_url":"https://api.github.com/repos/raccoongang/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raccoongang/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raccoongang/edx-platform/teams","hooks_url":"https://api.github.com/repos/raccoongang/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/raccoongang/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/raccoongang/edx-platform/events","assignees_url":"https://api.github.com/repos/raccoongang/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/raccoongang/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/raccoongang/edx-platform/tags","blobs_url":"https://api.github.com/repos/raccoongang/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raccoongang/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raccoongang/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/raccoongang/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raccoongang/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/raccoongang/edx-platform/languages","stargazers_url":"https://api.github.com/repos/raccoongang/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/raccoongang/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/raccoongang/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/raccoongang/edx-platform/subscription","commits_url":"https://api.github.com/repos/raccoongang/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/raccoongang/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/raccoongang/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/raccoongang/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/raccoongang/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/raccoongang/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raccoongang/edx-platform/merges","archive_url":"https://api.github.com/repos/raccoongang/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raccoongang/edx-platform/downloads","issues_url":"https://api.github.com/repos/raccoongang/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/raccoongang/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/raccoongang/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/raccoongang/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raccoongang/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/raccoongang/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/raccoongang/edx-platform/deployments","created_at":"2014-11-18T14:05:58Z","updated_at":"2019-07-24T13:24:18Z","pushed_at":"2019-07-29T13:33:12Z","git_url":"git://github.com/raccoongang/edx-platform.git","ssh_url":"git@github.com:raccoongang/edx-platform.git","clone_url":"https://github.com/raccoongang/edx-platform.git","svn_url":"https://github.com/raccoongang/edx-platform","homepage":"http://openedx.org/","size":1185119,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":15,"open_issues":30,"watchers":10,"default_branch":"ginkgo-rg"}},"base":{"label":"raccoongang:skillonomy-dev","ref":"skillonomy-dev","sha":"4870bef3de1ebb2bc2d38d63bc324695b9c0d918","user":{"login":"raccoongang","id":11388447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg4NDQ3","avatar_url":"https://avatars0.githubusercontent.com/u/11388447?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoongang","html_url":"https://github.com/raccoongang","followers_url":"https://api.github.com/users/raccoongang/followers","following_url":"https://api.github.com/users/raccoongang/following{/other_user}","gists_url":"https://api.github.com/users/raccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoongang/subscriptions","organizations_url":"https://api.github.com/users/raccoongang/orgs","repos_url":"https://api.github.com/users/raccoongang/repos","events_url":"https://api.github.com/users/raccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/raccoongang/received_events","type":"Organization","site_admin":false},"repo":{"id":26811891,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgxMTg5MQ==","name":"edx-platform","full_name":"raccoongang/edx-platform","private":false,"owner":{"login":"raccoongang","id":11388447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg4NDQ3","avatar_url":"https://avatars0.githubusercontent.com/u/11388447?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoongang","html_url":"https://github.com/raccoongang","followers_url":"https://api.github.com/users/raccoongang/followers","following_url":"https://api.github.com/users/raccoongang/following{/other_user}","gists_url":"https://api.github.com/users/raccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoongang/subscriptions","organizations_url":"https://api.github.com/users/raccoongang/orgs","repos_url":"https://api.github.com/users/raccoongang/repos","events_url":"https://api.github.com/users/raccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/raccoongang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/raccoongang/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":true,"url":"https://api.github.com/repos/raccoongang/edx-platform","forks_url":"https://api.github.com/repos/raccoongang/edx-platform/forks","keys_url":"https://api.github.com/repos/raccoongang/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raccoongang/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raccoongang/edx-platform/teams","hooks_url":"https://api.github.com/repos/raccoongang/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/raccoongang/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/raccoongang/edx-platform/events","assignees_url":"https://api.github.com/repos/raccoongang/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/raccoongang/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/raccoongang/edx-platform/tags","blobs_url":"https://api.github.com/repos/raccoongang/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raccoongang/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raccoongang/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/raccoongang/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raccoongang/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/raccoongang/edx-platform/languages","stargazers_url":"https://api.github.com/repos/raccoongang/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/raccoongang/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/raccoongang/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/raccoongang/edx-platform/subscription","commits_url":"https://api.github.com/repos/raccoongang/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/raccoongang/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/raccoongang/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/raccoongang/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/raccoongang/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/raccoongang/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raccoongang/edx-platform/merges","archive_url":"https://api.github.com/repos/raccoongang/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raccoongang/edx-platform/downloads","issues_url":"https://api.github.com/repos/raccoongang/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/raccoongang/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/raccoongang/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/raccoongang/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raccoongang/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/raccoongang/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/raccoongang/edx-platform/deployments","created_at":"2014-11-18T14:05:58Z","updated_at":"2019-07-24T13:24:18Z","pushed_at":"2019-07-29T13:33:12Z","git_url":"git://github.com/raccoongang/edx-platform.git","ssh_url":"git@github.com:raccoongang/edx-platform.git","clone_url":"https://github.com/raccoongang/edx-platform.git","svn_url":"https://github.com/raccoongang/edx-platform","homepage":"http://openedx.org/","size":1185119,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":15,"open_issues":30,"watchers":10,"default_branch":"ginkgo-rg"}},"_links":{"self":{"href":"https://api.github.com/repos/raccoongang/edx-platform/pulls/1403"},"html":{"href":"https://github.com/raccoongang/edx-platform/pull/1403"},"issue":{"href":"https://api.github.com/repos/raccoongang/edx-platform/issues/1403"},"comments":{"href":"https://api.github.com/repos/raccoongang/edx-platform/issues/1403/comments"},"review_comments":{"href":"https://api.github.com/repos/raccoongang/edx-platform/pulls/1403/comments"},"review_comment":{"href":"https://api.github.com/repos/raccoongang/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raccoongang/edx-platform/pulls/1403/commits"},"statuses":{"href":"https://api.github.com/repos/raccoongang/edx-platform/statuses/f714c23887490dee4510472385d8a5c6a1223d30"}},"author_association":"NONE"}}
|
{
"id": 26811891,
"name": "raccoongang/edx-platform",
"url": "https://api.github.com/repos/raccoongang/edx-platform"
}
|
{
"id": 25817760,
"login": "oleksandra-martyntseva",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25817760?",
"url": "https://api.github.com/users/oleksandra-martyntseva"
}
|
{
"id": 11388447,
"login": "raccoongang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11388447?",
"url": "https://api.github.com/orgs/raccoongang"
}
| 2019-07-29T13:19:19 |
10103416091
|
{"actor":{"display_login":"oleksandra-martyntseva"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/aja-video/contra/pulls/comments/278661547","pull_request_review_id":230793743,"id":278661547,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODY2MTU0Nw==","diff_hunk":"@@ -13,7 +13,12 @@ type Collector interface {\n \tParseResult(string) (string, error)\n }\n \n-// CollectorSpecial is special.\n-type CollectorSpecial interface {\n+// CollectorSpecialSSH is special.\n+type CollectorSpecialSSH interface {\n \tModifySSHConfig(config *utils.SSHConfig)\n }\n+\n+// CollectorTerminalSpecial is also special\n+type CollectorTerminalSpecial interface {","path":"src/collectors/collector.go","position":null,"original_position":12,"commit_id":"0ea39b2081be003e1f39730ceca654b208663708","original_commit_id":"93e92a0fffff3e23473ad344b6fff6b42f20f26d","user":{"login":"slarti5191","id":10604975,"node_id":"MDQ6VXNlcjEwNjA0OTc1","avatar_url":"https://avatars1.githubusercontent.com/u/10604975?v=4","gravatar_id":"","url":"https://api.github.com/users/slarti5191","html_url":"https://github.com/slarti5191","followers_url":"https://api.github.com/users/slarti5191/followers","following_url":"https://api.github.com/users/slarti5191/following{/other_user}","gists_url":"https://api.github.com/users/slarti5191/gists{/gist_id}","starred_url":"https://api.github.com/users/slarti5191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slarti5191/subscriptions","organizations_url":"https://api.github.com/users/slarti5191/orgs","repos_url":"https://api.github.com/users/slarti5191/repos","events_url":"https://api.github.com/users/slarti5191/events{/privacy}","received_events_url":"https://api.github.com/users/slarti5191/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2019-04-25T17:47:42Z","updated_at":"2019-04-25T17:47:43Z","html_url":"https://github.com/aja-video/contra/pull/36#discussion_r278661547","pull_request_url":"https://api.github.com/repos/aja-video/contra/pulls/36","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aja-video/contra/pulls/comments/278661547"},"html":{"href":"https://github.com/aja-video/contra/pull/36#discussion_r278661547"},"pull_request":{"href":"https://api.github.com/repos/aja-video/contra/pulls/36"}},"in_reply_to_id":278633437},"pull_request":{"url":"https://api.github.com/repos/aja-video/contra/pulls/36","id":273336047,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczMzM2MDQ3","html_url":"https://github.com/aja-video/contra/pull/36","diff_url":"https://github.com/aja-video/contra/pull/36.diff","patch_url":"https://github.com/aja-video/contra/pull/36.patch","issue_url":"https://api.github.com/repos/aja-video/contra/issues/36","number":36,"state":"open","locked":false,"title":"Add mikrotrik support, correct error handling for ssh auth failure","user":{"login":"slarti5191","id":10604975,"node_id":"MDQ6VXNlcjEwNjA0OTc1","avatar_url":"https://avatars1.githubusercontent.com/u/10604975?v=4","gravatar_id":"","url":"https://api.github.com/users/slarti5191","html_url":"https://github.com/slarti5191","followers_url":"https://api.github.com/users/slarti5191/followers","following_url":"https://api.github.com/users/slarti5191/following{/other_user}","gists_url":"https://api.github.com/users/slarti5191/gists{/gist_id}","starred_url":"https://api.github.com/users/slarti5191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slarti5191/subscriptions","organizations_url":"https://api.github.com/users/slarti5191/orgs","repos_url":"https://api.github.com/users/slarti5191/repos","events_url":"https://api.github.com/users/slarti5191/events{/privacy}","received_events_url":"https://api.github.com/users/slarti5191/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-24T23:53:28Z","updated_at":"2019-04-25T17:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da34f0d6a6010ba4f972a7e5817a59337f6d5c6e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aja-video/contra/pulls/36/commits","review_comments_url":"https://api.github.com/repos/aja-video/contra/pulls/36/comments","review_comment_url":"https://api.github.com/repos/aja-video/contra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aja-video/contra/issues/36/comments","statuses_url":"https://api.github.com/repos/aja-video/contra/statuses/0ea39b2081be003e1f39730ceca654b208663708","head":{"label":"aja-video:mikrotrik_support","ref":"mikrotrik_support","sha":"0ea39b2081be003e1f39730ceca654b208663708","user":{"login":"aja-video","id":11395039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzk1MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/11395039?v=4","gravatar_id":"","url":"https://api.github.com/users/aja-video","html_url":"https://github.com/aja-video","followers_url":"https://api.github.com/users/aja-video/followers","following_url":"https://api.github.com/users/aja-video/following{/other_user}","gists_url":"https://api.github.com/users/aja-video/gists{/gist_id}","starred_url":"https://api.github.com/users/aja-video/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aja-video/subscriptions","organizations_url":"https://api.github.com/users/aja-video/orgs","repos_url":"https://api.github.com/users/aja-video/repos","events_url":"https://api.github.com/users/aja-video/events{/privacy}","received_events_url":"https://api.github.com/users/aja-video/received_events","type":"Organization","site_admin":false},"repo":{"id":161707326,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE3MDczMjY=","name":"contra","full_name":"aja-video/contra","private":false,"owner":{"login":"aja-video","id":11395039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzk1MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/11395039?v=4","gravatar_id":"","url":"https://api.github.com/users/aja-video","html_url":"https://github.com/aja-video","followers_url":"https://api.github.com/users/aja-video/followers","following_url":"https://api.github.com/users/aja-video/following{/other_user}","gists_url":"https://api.github.com/users/aja-video/gists{/gist_id}","starred_url":"https://api.github.com/users/aja-video/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aja-video/subscriptions","organizations_url":"https://api.github.com/users/aja-video/orgs","repos_url":"https://api.github.com/users/aja-video/repos","events_url":"https://api.github.com/users/aja-video/events{/privacy}","received_events_url":"https://api.github.com/users/aja-video/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aja-video/contra","description":"Network device configuration tracker built using GoLang with a focus on routers and switches.","fork":false,"url":"https://api.github.com/repos/aja-video/contra","forks_url":"https://api.github.com/repos/aja-video/contra/forks","keys_url":"https://api.github.com/repos/aja-video/contra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aja-video/contra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aja-video/contra/teams","hooks_url":"https://api.github.com/repos/aja-video/contra/hooks","issue_events_url":"https://api.github.com/repos/aja-video/contra/issues/events{/number}","events_url":"https://api.github.com/repos/aja-video/contra/events","assignees_url":"https://api.github.com/repos/aja-video/contra/assignees{/user}","branches_url":"https://api.github.com/repos/aja-video/contra/branches{/branch}","tags_url":"https://api.github.com/repos/aja-video/contra/tags","blobs_url":"https://api.github.com/repos/aja-video/contra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aja-video/contra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aja-video/contra/git/refs{/sha}","trees_url":"https://api.github.com/repos/aja-video/contra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aja-video/contra/statuses/{sha}","languages_url":"https://api.github.com/repos/aja-video/contra/languages","stargazers_url":"https://api.github.com/repos/aja-video/contra/stargazers","contributors_url":"https://api.github.com/repos/aja-video/contra/contributors","subscribers_url":"https://api.github.com/repos/aja-video/contra/subscribers","subscription_url":"https://api.github.com/repos/aja-video/contra/subscription","commits_url":"https://api.github.com/repos/aja-video/contra/commits{/sha}","git_commits_url":"https://api.github.com/repos/aja-video/contra/git/commits{/sha}","comments_url":"https://api.github.com/repos/aja-video/contra/comments{/number}","issue_comment_url":"https://api.github.com/repos/aja-video/contra/issues/comments{/number}","contents_url":"https://api.github.com/repos/aja-video/contra/contents/{+path}","compare_url":"https://api.github.com/repos/aja-video/contra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aja-video/contra/merges","archive_url":"https://api.github.com/repos/aja-video/contra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aja-video/contra/downloads","issues_url":"https://api.github.com/repos/aja-video/contra/issues{/number}","pulls_url":"https://api.github.com/repos/aja-video/contra/pulls{/number}","milestones_url":"https://api.github.com/repos/aja-video/contra/milestones{/number}","notifications_url":"https://api.github.com/repos/aja-video/contra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aja-video/contra/labels{/name}","releases_url":"https://api.github.com/repos/aja-video/contra/releases{/id}","deployments_url":"https://api.github.com/repos/aja-video/contra/deployments","created_at":"2018-12-13T23:35:55Z","updated_at":"2019-01-22T23:36:05Z","pushed_at":"2019-04-25T17:47:30Z","git_url":"git://github.com/aja-video/contra.git","ssh_url":"git@github.com:aja-video/contra.git","clone_url":"https://github.com/aja-video/contra.git","svn_url":"https://github.com/aja-video/contra","homepage":null,"size":216,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"aja-video:master","ref":"master","sha":"41f4963a85cbe4395b3dd7e23446e58da83a2faa","user":{"login":"aja-video","id":11395039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzk1MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/11395039?v=4","gravatar_id":"","url":"https://api.github.com/users/aja-video","html_url":"https://github.com/aja-video","followers_url":"https://api.github.com/users/aja-video/followers","following_url":"https://api.github.com/users/aja-video/following{/other_user}","gists_url":"https://api.github.com/users/aja-video/gists{/gist_id}","starred_url":"https://api.github.com/users/aja-video/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aja-video/subscriptions","organizations_url":"https://api.github.com/users/aja-video/orgs","repos_url":"https://api.github.com/users/aja-video/repos","events_url":"https://api.github.com/users/aja-video/events{/privacy}","received_events_url":"https://api.github.com/users/aja-video/received_events","type":"Organization","site_admin":false},"repo":{"id":161707326,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE3MDczMjY=","name":"contra","full_name":"aja-video/contra","private":false,"owner":{"login":"aja-video","id":11395039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzk1MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/11395039?v=4","gravatar_id":"","url":"https://api.github.com/users/aja-video","html_url":"https://github.com/aja-video","followers_url":"https://api.github.com/users/aja-video/followers","following_url":"https://api.github.com/users/aja-video/following{/other_user}","gists_url":"https://api.github.com/users/aja-video/gists{/gist_id}","starred_url":"https://api.github.com/users/aja-video/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aja-video/subscriptions","organizations_url":"https://api.github.com/users/aja-video/orgs","repos_url":"https://api.github.com/users/aja-video/repos","events_url":"https://api.github.com/users/aja-video/events{/privacy}","received_events_url":"https://api.github.com/users/aja-video/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aja-video/contra","description":"Network device configuration tracker built using GoLang with a focus on routers and switches.","fork":false,"url":"https://api.github.com/repos/aja-video/contra","forks_url":"https://api.github.com/repos/aja-video/contra/forks","keys_url":"https://api.github.com/repos/aja-video/contra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aja-video/contra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aja-video/contra/teams","hooks_url":"https://api.github.com/repos/aja-video/contra/hooks","issue_events_url":"https://api.github.com/repos/aja-video/contra/issues/events{/number}","events_url":"https://api.github.com/repos/aja-video/contra/events","assignees_url":"https://api.github.com/repos/aja-video/contra/assignees{/user}","branches_url":"https://api.github.com/repos/aja-video/contra/branches{/branch}","tags_url":"https://api.github.com/repos/aja-video/contra/tags","blobs_url":"https://api.github.com/repos/aja-video/contra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aja-video/contra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aja-video/contra/git/refs{/sha}","trees_url":"https://api.github.com/repos/aja-video/contra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aja-video/contra/statuses/{sha}","languages_url":"https://api.github.com/repos/aja-video/contra/languages","stargazers_url":"https://api.github.com/repos/aja-video/contra/stargazers","contributors_url":"https://api.github.com/repos/aja-video/contra/contributors","subscribers_url":"https://api.github.com/repos/aja-video/contra/subscribers","subscription_url":"https://api.github.com/repos/aja-video/contra/subscription","commits_url":"https://api.github.com/repos/aja-video/contra/commits{/sha}","git_commits_url":"https://api.github.com/repos/aja-video/contra/git/commits{/sha}","comments_url":"https://api.github.com/repos/aja-video/contra/comments{/number}","issue_comment_url":"https://api.github.com/repos/aja-video/contra/issues/comments{/number}","contents_url":"https://api.github.com/repos/aja-video/contra/contents/{+path}","compare_url":"https://api.github.com/repos/aja-video/contra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aja-video/contra/merges","archive_url":"https://api.github.com/repos/aja-video/contra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aja-video/contra/downloads","issues_url":"https://api.github.com/repos/aja-video/contra/issues{/number}","pulls_url":"https://api.github.com/repos/aja-video/contra/pulls{/number}","milestones_url":"https://api.github.com/repos/aja-video/contra/milestones{/number}","notifications_url":"https://api.github.com/repos/aja-video/contra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aja-video/contra/labels{/name}","releases_url":"https://api.github.com/repos/aja-video/contra/releases{/id}","deployments_url":"https://api.github.com/repos/aja-video/contra/deployments","created_at":"2018-12-13T23:35:55Z","updated_at":"2019-01-22T23:36:05Z","pushed_at":"2019-04-25T17:47:30Z","git_url":"git://github.com/aja-video/contra.git","ssh_url":"git@github.com:aja-video/contra.git","clone_url":"https://github.com/aja-video/contra.git","svn_url":"https://github.com/aja-video/contra","homepage":null,"size":216,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aja-video/contra/pulls/36"},"html":{"href":"https://github.com/aja-video/contra/pull/36"},"issue":{"href":"https://api.github.com/repos/aja-video/contra/issues/36"},"comments":{"href":"https://api.github.com/repos/aja-video/contra/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/aja-video/contra/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/aja-video/contra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aja-video/contra/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/aja-video/contra/statuses/0ea39b2081be003e1f39730ceca654b208663708"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 161707326,
"name": "aja-video/contra",
"url": "https://api.github.com/repos/aja-video/contra"
}
|
{
"id": 10604975,
"login": "slarti5191",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10604975?",
"url": "https://api.github.com/users/slarti5191"
}
|
{
"id": 11395039,
"login": "aja-video",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11395039?",
"url": "https://api.github.com/orgs/aja-video"
}
| 2019-04-25T17:47:42 |
9512342861
|
{"actor":{"display_login":"slarti5191"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/comments/299009858","pull_request_review_id":256294102,"id":299009858,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTAwOTg1OA==","diff_hunk":"@@ -197,7 +197,16 @@ private function parse_master_response($data, &$index, &$count, &$servers)\n {\n $ip = [];\n foreach ( range(0, 3) as $i )\n+ {\n $ip[] = (string)ord($nextbyte());\n+ // ipv4 address field starts with '\\'\n+ // but serverResponse packet also ends with '\\'\n+ // if end of packet is reached, do not parse ipv4\n+ if ( feof($buffer) )\n+ break;\n+ }\n+ if ( feof($buffer) )\n+ break;\n $port = ord($nextbyte()) << 8;\n $port |= ord($nextbyte());\n $ip = implode(\".\", $ip);","path":"engine.php","position":16,"original_position":16,"commit_id":"dd4e4770b8dff6db3b86056d483e3fec382bd2d3","original_commit_id":"dd4e4770b8dff6db3b86056d483e3fec382bd2d3","user":{"login":"illwieckz","id":2311649,"node_id":"MDQ6VXNlcjIzMTE2NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2311649?v=4","gravatar_id":"","url":"https://api.github.com/users/illwieckz","html_url":"https://github.com/illwieckz","followers_url":"https://api.github.com/users/illwieckz/followers","following_url":"https://api.github.com/users/illwieckz/following{/other_user}","gists_url":"https://api.github.com/users/illwieckz/gists{/gist_id}","starred_url":"https://api.github.com/users/illwieckz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illwieckz/subscriptions","organizations_url":"https://api.github.com/users/illwieckz/orgs","repos_url":"https://api.github.com/users/illwieckz/repos","events_url":"https://api.github.com/users/illwieckz/events{/privacy}","received_events_url":"https://api.github.com/users/illwieckz/received_events","type":"User","site_admin":false},"body":"We may remove this test as it looks to have been an ugly workaround.\r\n\r\nIn any way I wonder why php7 introduced a regression in that code.","created_at":"2019-07-01T12:03:28Z","updated_at":"2019-07-01T12:03:28Z","html_url":"https://github.com/DaemonEngine/Xonpress/pull/1#discussion_r299009858","pull_request_url":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/comments/299009858"},"html":{"href":"https://github.com/DaemonEngine/Xonpress/pull/1#discussion_r299009858"},"pull_request":{"href":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/1"}},"in_reply_to_id":298917691},"pull_request":{"url":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/1","id":293145088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzMTQ1MDg4","html_url":"https://github.com/DaemonEngine/Xonpress/pull/1","diff_url":"https://github.com/DaemonEngine/Xonpress/pull/1.diff","patch_url":"https://github.com/DaemonEngine/Xonpress/pull/1.patch","issue_url":"https://api.github.com/repos/DaemonEngine/Xonpress/issues/1","number":1,"state":"open","locked":false,"title":"some fixes","user":{"login":"illwieckz","id":2311649,"node_id":"MDQ6VXNlcjIzMTE2NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2311649?v=4","gravatar_id":"","url":"https://api.github.com/users/illwieckz","html_url":"https://github.com/illwieckz","followers_url":"https://api.github.com/users/illwieckz/followers","following_url":"https://api.github.com/users/illwieckz/following{/other_user}","gists_url":"https://api.github.com/users/illwieckz/gists{/gist_id}","starred_url":"https://api.github.com/users/illwieckz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illwieckz/subscriptions","organizations_url":"https://api.github.com/users/illwieckz/orgs","repos_url":"https://api.github.com/users/illwieckz/repos","events_url":"https://api.github.com/users/illwieckz/events{/privacy}","received_events_url":"https://api.github.com/users/illwieckz/received_events","type":"User","site_admin":false},"body":"- rename String to MyString since php7 defines String (@DolceTriade's fix)\r\n- do not parse master server response EOF as an ipv4","created_at":"2019-07-01T00:30:33Z","updated_at":"2019-07-01T12:03:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcd69d58965d2098e715c8403a9c7ac171af3e6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/1/commits","review_comments_url":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/1/comments","review_comment_url":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DaemonEngine/Xonpress/issues/1/comments","statuses_url":"https://api.github.com/repos/DaemonEngine/Xonpress/statuses/dd4e4770b8dff6db3b86056d483e3fec382bd2d3","head":{"label":"illwieckz:fix","ref":"fix","sha":"dd4e4770b8dff6db3b86056d483e3fec382bd2d3","user":{"login":"illwieckz","id":2311649,"node_id":"MDQ6VXNlcjIzMTE2NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2311649?v=4","gravatar_id":"","url":"https://api.github.com/users/illwieckz","html_url":"https://github.com/illwieckz","followers_url":"https://api.github.com/users/illwieckz/followers","following_url":"https://api.github.com/users/illwieckz/following{/other_user}","gists_url":"https://api.github.com/users/illwieckz/gists{/gist_id}","starred_url":"https://api.github.com/users/illwieckz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illwieckz/subscriptions","organizations_url":"https://api.github.com/users/illwieckz/orgs","repos_url":"https://api.github.com/users/illwieckz/repos","events_url":"https://api.github.com/users/illwieckz/events{/privacy}","received_events_url":"https://api.github.com/users/illwieckz/received_events","type":"User","site_admin":false},"repo":{"id":194573521,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ1NzM1MjE=","name":"Xonpress","full_name":"illwieckz/Xonpress","private":false,"owner":{"login":"illwieckz","id":2311649,"node_id":"MDQ6VXNlcjIzMTE2NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2311649?v=4","gravatar_id":"","url":"https://api.github.com/users/illwieckz","html_url":"https://github.com/illwieckz","followers_url":"https://api.github.com/users/illwieckz/followers","following_url":"https://api.github.com/users/illwieckz/following{/other_user}","gists_url":"https://api.github.com/users/illwieckz/gists{/gist_id}","starred_url":"https://api.github.com/users/illwieckz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illwieckz/subscriptions","organizations_url":"https://api.github.com/users/illwieckz/orgs","repos_url":"https://api.github.com/users/illwieckz/repos","events_url":"https://api.github.com/users/illwieckz/events{/privacy}","received_events_url":"https://api.github.com/users/illwieckz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/illwieckz/Xonpress","description":"Wordpress server browser plugin (forked from https://gitlab.com/mattia.basaglia/Xonpress)","fork":true,"url":"https://api.github.com/repos/illwieckz/Xonpress","forks_url":"https://api.github.com/repos/illwieckz/Xonpress/forks","keys_url":"https://api.github.com/repos/illwieckz/Xonpress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/illwieckz/Xonpress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/illwieckz/Xonpress/teams","hooks_url":"https://api.github.com/repos/illwieckz/Xonpress/hooks","issue_events_url":"https://api.github.com/repos/illwieckz/Xonpress/issues/events{/number}","events_url":"https://api.github.com/repos/illwieckz/Xonpress/events","assignees_url":"https://api.github.com/repos/illwieckz/Xonpress/assignees{/user}","branches_url":"https://api.github.com/repos/illwieckz/Xonpress/branches{/branch}","tags_url":"https://api.github.com/repos/illwieckz/Xonpress/tags","blobs_url":"https://api.github.com/repos/illwieckz/Xonpress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/illwieckz/Xonpress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/illwieckz/Xonpress/git/refs{/sha}","trees_url":"https://api.github.com/repos/illwieckz/Xonpress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/illwieckz/Xonpress/statuses/{sha}","languages_url":"https://api.github.com/repos/illwieckz/Xonpress/languages","stargazers_url":"https://api.github.com/repos/illwieckz/Xonpress/stargazers","contributors_url":"https://api.github.com/repos/illwieckz/Xonpress/contributors","subscribers_url":"https://api.github.com/repos/illwieckz/Xonpress/subscribers","subscription_url":"https://api.github.com/repos/illwieckz/Xonpress/subscription","commits_url":"https://api.github.com/repos/illwieckz/Xonpress/commits{/sha}","git_commits_url":"https://api.github.com/repos/illwieckz/Xonpress/git/commits{/sha}","comments_url":"https://api.github.com/repos/illwieckz/Xonpress/comments{/number}","issue_comment_url":"https://api.github.com/repos/illwieckz/Xonpress/issues/comments{/number}","contents_url":"https://api.github.com/repos/illwieckz/Xonpress/contents/{+path}","compare_url":"https://api.github.com/repos/illwieckz/Xonpress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/illwieckz/Xonpress/merges","archive_url":"https://api.github.com/repos/illwieckz/Xonpress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/illwieckz/Xonpress/downloads","issues_url":"https://api.github.com/repos/illwieckz/Xonpress/issues{/number}","pulls_url":"https://api.github.com/repos/illwieckz/Xonpress/pulls{/number}","milestones_url":"https://api.github.com/repos/illwieckz/Xonpress/milestones{/number}","notifications_url":"https://api.github.com/repos/illwieckz/Xonpress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/illwieckz/Xonpress/labels{/name}","releases_url":"https://api.github.com/repos/illwieckz/Xonpress/releases{/id}","deployments_url":"https://api.github.com/repos/illwieckz/Xonpress/deployments","created_at":"2019-07-01T00:13:52Z","updated_at":"2019-07-01T00:15:24Z","pushed_at":"2019-07-01T00:28:32Z","git_url":"git://github.com/illwieckz/Xonpress.git","ssh_url":"git@github.com:illwieckz/Xonpress.git","clone_url":"https://github.com/illwieckz/Xonpress.git","svn_url":"https://github.com/illwieckz/Xonpress","homepage":null,"size":76,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DaemonEngine:master","ref":"master","sha":"7588d33daf5371965b29dc7f58e7949380d555c8","user":{"login":"DaemonEngine","id":11440075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDQwMDc1","avatar_url":"https://avatars1.githubusercontent.com/u/11440075?v=4","gravatar_id":"","url":"https://api.github.com/users/DaemonEngine","html_url":"https://github.com/DaemonEngine","followers_url":"https://api.github.com/users/DaemonEngine/followers","following_url":"https://api.github.com/users/DaemonEngine/following{/other_user}","gists_url":"https://api.github.com/users/DaemonEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/DaemonEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaemonEngine/subscriptions","organizations_url":"https://api.github.com/users/DaemonEngine/orgs","repos_url":"https://api.github.com/users/DaemonEngine/repos","events_url":"https://api.github.com/users/DaemonEngine/events{/privacy}","received_events_url":"https://api.github.com/users/DaemonEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":186349704,"node_id":"MDEwOlJlcG9zaXRvcnkxODYzNDk3MDQ=","name":"Xonpress","full_name":"DaemonEngine/Xonpress","private":false,"owner":{"login":"DaemonEngine","id":11440075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDQwMDc1","avatar_url":"https://avatars1.githubusercontent.com/u/11440075?v=4","gravatar_id":"","url":"https://api.github.com/users/DaemonEngine","html_url":"https://github.com/DaemonEngine","followers_url":"https://api.github.com/users/DaemonEngine/followers","following_url":"https://api.github.com/users/DaemonEngine/following{/other_user}","gists_url":"https://api.github.com/users/DaemonEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/DaemonEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaemonEngine/subscriptions","organizations_url":"https://api.github.com/users/DaemonEngine/orgs","repos_url":"https://api.github.com/users/DaemonEngine/repos","events_url":"https://api.github.com/users/DaemonEngine/events{/privacy}","received_events_url":"https://api.github.com/users/DaemonEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DaemonEngine/Xonpress","description":"Wordpress server browser plugin (forked from https://gitlab.com/mattia.basaglia/Xonpress)","fork":false,"url":"https://api.github.com/repos/DaemonEngine/Xonpress","forks_url":"https://api.github.com/repos/DaemonEngine/Xonpress/forks","keys_url":"https://api.github.com/repos/DaemonEngine/Xonpress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaemonEngine/Xonpress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaemonEngine/Xonpress/teams","hooks_url":"https://api.github.com/repos/DaemonEngine/Xonpress/hooks","issue_events_url":"https://api.github.com/repos/DaemonEngine/Xonpress/issues/events{/number}","events_url":"https://api.github.com/repos/DaemonEngine/Xonpress/events","assignees_url":"https://api.github.com/repos/DaemonEngine/Xonpress/assignees{/user}","branches_url":"https://api.github.com/repos/DaemonEngine/Xonpress/branches{/branch}","tags_url":"https://api.github.com/repos/DaemonEngine/Xonpress/tags","blobs_url":"https://api.github.com/repos/DaemonEngine/Xonpress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaemonEngine/Xonpress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaemonEngine/Xonpress/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaemonEngine/Xonpress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaemonEngine/Xonpress/statuses/{sha}","languages_url":"https://api.github.com/repos/DaemonEngine/Xonpress/languages","stargazers_url":"https://api.github.com/repos/DaemonEngine/Xonpress/stargazers","contributors_url":"https://api.github.com/repos/DaemonEngine/Xonpress/contributors","subscribers_url":"https://api.github.com/repos/DaemonEngine/Xonpress/subscribers","subscription_url":"https://api.github.com/repos/DaemonEngine/Xonpress/subscription","commits_url":"https://api.github.com/repos/DaemonEngine/Xonpress/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaemonEngine/Xonpress/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaemonEngine/Xonpress/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaemonEngine/Xonpress/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaemonEngine/Xonpress/contents/{+path}","compare_url":"https://api.github.com/repos/DaemonEngine/Xonpress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaemonEngine/Xonpress/merges","archive_url":"https://api.github.com/repos/DaemonEngine/Xonpress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaemonEngine/Xonpress/downloads","issues_url":"https://api.github.com/repos/DaemonEngine/Xonpress/issues{/number}","pulls_url":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls{/number}","milestones_url":"https://api.github.com/repos/DaemonEngine/Xonpress/milestones{/number}","notifications_url":"https://api.github.com/repos/DaemonEngine/Xonpress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaemonEngine/Xonpress/labels{/name}","releases_url":"https://api.github.com/repos/DaemonEngine/Xonpress/releases{/id}","deployments_url":"https://api.github.com/repos/DaemonEngine/Xonpress/deployments","created_at":"2019-05-13T05:14:44Z","updated_at":"2019-05-13T05:17:21Z","pushed_at":"2019-07-01T00:30:34Z","git_url":"git://github.com/DaemonEngine/Xonpress.git","ssh_url":"git@github.com:DaemonEngine/Xonpress.git","clone_url":"https://github.com/DaemonEngine/Xonpress.git","svn_url":"https://github.com/DaemonEngine/Xonpress","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/1"},"html":{"href":"https://github.com/DaemonEngine/Xonpress/pull/1"},"issue":{"href":"https://api.github.com/repos/DaemonEngine/Xonpress/issues/1"},"comments":{"href":"https://api.github.com/repos/DaemonEngine/Xonpress/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DaemonEngine/Xonpress/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/DaemonEngine/Xonpress/statuses/dd4e4770b8dff6db3b86056d483e3fec382bd2d3"}},"author_association":"MEMBER"}}
|
{
"id": 186349704,
"name": "DaemonEngine/Xonpress",
"url": "https://api.github.com/repos/DaemonEngine/Xonpress"
}
|
{
"id": 2311649,
"login": "illwieckz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2311649?",
"url": "https://api.github.com/users/illwieckz"
}
|
{
"id": 11440075,
"login": "DaemonEngine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11440075?",
"url": "https://api.github.com/orgs/DaemonEngine"
}
| 2019-07-01T12:03:28 |
9925350275
|
{"actor":{"display_login":"illwieckz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/comments/337742673","pull_request_review_id":305498642,"id":337742673,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzc0MjY3Mw==","diff_hunk":"@@ -117,8 +117,12 @@\n <SfProductCard\n v-for=\"(product, i) in products\"\n :key=\"i\"\n- :title=\"product.name\"\n- image=\"/img/product_thumb.png\"\n+ :title=\"product.name || ''\"\n+ :image=\"\n+ product.media && product.media.length\n+ ? product.media[0].media.url\n+ : '/img/product_thumb.png'","path":"test-page/src/views/Category.vue","position":10,"original_position":10,"commit_id":"0382f7cfc05c62f1e911b80626d3baeba7cd3e85","original_commit_id":"0382f7cfc05c62f1e911b80626d3baeba7cd3e85","user":{"login":"rmakara","id":1880231,"node_id":"MDQ6VXNlcjE4ODAyMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1880231?v=4","gravatar_id":"","url":"https://api.github.com/users/rmakara","html_url":"https://github.com/rmakara","followers_url":"https://api.github.com/users/rmakara/followers","following_url":"https://api.github.com/users/rmakara/following{/other_user}","gists_url":"https://api.github.com/users/rmakara/gists{/gist_id}","starred_url":"https://api.github.com/users/rmakara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmakara/subscriptions","organizations_url":"https://api.github.com/users/rmakara/orgs","repos_url":"https://api.github.com/users/rmakara/repos","events_url":"https://api.github.com/users/rmakara/events{/privacy}","received_events_url":"https://api.github.com/users/rmakara/received_events","type":"User","site_admin":false},"body":"Not required right now but maybe we may extract getting a default thumbnail to some method? We will use that in product and cms pages also. :)\r\n\r\nEdit:\r\nAfter a quick look, I am not sure if there is a default thumbnail for products with no cover in Shopware. I guess Shopware paints default one with polygons. I did not find that in admin panel. In the SW6 codebase I found only lines for throwing an exception in case of not image found.\r\n\r\n\r\n","created_at":"2019-10-22T20:48:57Z","updated_at":"2019-10-22T20:48:58Z","html_url":"https://github.com/DivanteLtd/shopware-pwa/pull/102#discussion_r337742673","pull_request_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/102","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/comments/337742673"},"html":{"href":"https://github.com/DivanteLtd/shopware-pwa/pull/102#discussion_r337742673"},"pull_request":{"href":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/102","id":331046833,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxMDQ2ODMz","html_url":"https://github.com/DivanteLtd/shopware-pwa/pull/102","diff_url":"https://github.com/DivanteLtd/shopware-pwa/pull/102.diff","patch_url":"https://github.com/DivanteLtd/shopware-pwa/pull/102.patch","issue_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues/102","number":102,"state":"open","locked":false,"title":"Feature/client use on category page","user":{"login":"patzick","id":13100280,"node_id":"MDQ6VXNlcjEzMTAwMjgw","avatar_url":"https://avatars0.githubusercontent.com/u/13100280?v=4","gravatar_id":"","url":"https://api.github.com/users/patzick","html_url":"https://github.com/patzick","followers_url":"https://api.github.com/users/patzick/followers","following_url":"https://api.github.com/users/patzick/following{/other_user}","gists_url":"https://api.github.com/users/patzick/gists{/gist_id}","starred_url":"https://api.github.com/users/patzick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patzick/subscriptions","organizations_url":"https://api.github.com/users/patzick/orgs","repos_url":"https://api.github.com/users/patzick/repos","events_url":"https://api.github.com/users/patzick/events{/privacy}","received_events_url":"https://api.github.com/users/patzick/received_events","type":"User","site_admin":false},"body":"1. availability to use `yarn dev:client` to develop locally and refresh page\r\n2. added defaultPaginationLimit to config and using it when no limit is provided\r\n3. changed getProducts to post\r\n4. added associations in searchQuery\r\n5. show product images on category page\r\n\r\nBefore merge: update readme.md to adjust for local coding","created_at":"2019-10-22T15:07:02Z","updated_at":"2019-10-22T20:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d35f208d4fbea84420bb1186ae01ac74a8c707ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/102/commits","review_comments_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/102/comments","review_comment_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues/102/comments","statuses_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/statuses/0382f7cfc05c62f1e911b80626d3baeba7cd3e85","head":{"label":"DivanteLtd:feature/client-use-on-category-page","ref":"feature/client-use-on-category-page","sha":"0382f7cfc05c62f1e911b80626d3baeba7cd3e85","user":{"login":"DivanteLtd","id":11463761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDYzNzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11463761?v=4","gravatar_id":"","url":"https://api.github.com/users/DivanteLtd","html_url":"https://github.com/DivanteLtd","followers_url":"https://api.github.com/users/DivanteLtd/followers","following_url":"https://api.github.com/users/DivanteLtd/following{/other_user}","gists_url":"https://api.github.com/users/DivanteLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/DivanteLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DivanteLtd/subscriptions","organizations_url":"https://api.github.com/users/DivanteLtd/orgs","repos_url":"https://api.github.com/users/DivanteLtd/repos","events_url":"https://api.github.com/users/DivanteLtd/events{/privacy}","received_events_url":"https://api.github.com/users/DivanteLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":211038815,"node_id":"MDEwOlJlcG9zaXRvcnkyMTEwMzg4MTU=","name":"shopware-pwa","full_name":"DivanteLtd/shopware-pwa","private":false,"owner":{"login":"DivanteLtd","id":11463761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDYzNzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11463761?v=4","gravatar_id":"","url":"https://api.github.com/users/DivanteLtd","html_url":"https://github.com/DivanteLtd","followers_url":"https://api.github.com/users/DivanteLtd/followers","following_url":"https://api.github.com/users/DivanteLtd/following{/other_user}","gists_url":"https://api.github.com/users/DivanteLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/DivanteLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DivanteLtd/subscriptions","organizations_url":"https://api.github.com/users/DivanteLtd/orgs","repos_url":"https://api.github.com/users/DivanteLtd/repos","events_url":"https://api.github.com/users/DivanteLtd/events{/privacy}","received_events_url":"https://api.github.com/users/DivanteLtd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DivanteLtd/shopware-pwa","description":null,"fork":false,"url":"https://api.github.com/repos/DivanteLtd/shopware-pwa","forks_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/forks","keys_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/teams","hooks_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/hooks","issue_events_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues/events{/number}","events_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/events","assignees_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/assignees{/user}","branches_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/branches{/branch}","tags_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/tags","blobs_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/refs{/sha}","trees_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/statuses/{sha}","languages_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/languages","stargazers_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/stargazers","contributors_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/contributors","subscribers_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/subscribers","subscription_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/subscription","commits_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/commits{/sha}","git_commits_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/commits{/sha}","comments_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/comments{/number}","issue_comment_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues/comments{/number}","contents_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/contents/{+path}","compare_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/merges","archive_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/downloads","issues_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues{/number}","pulls_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls{/number}","milestones_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/milestones{/number}","notifications_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/labels{/name}","releases_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/releases{/id}","deployments_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/deployments","created_at":"2019-09-26T08:26:52Z","updated_at":"2019-10-22T14:03:10Z","pushed_at":"2019-10-22T19:04:35Z","git_url":"git://github.com/DivanteLtd/shopware-pwa.git","ssh_url":"git@github.com:DivanteLtd/shopware-pwa.git","clone_url":"https://github.com/DivanteLtd/shopware-pwa.git","svn_url":"https://github.com/DivanteLtd/shopware-pwa","homepage":null,"size":6797,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":62,"license":null,"forks":0,"open_issues":62,"watchers":7,"default_branch":"master"}},"base":{"label":"DivanteLtd:master","ref":"master","sha":"f7ad2a9b803140429c2d6ff14ea4784ef9f98508","user":{"login":"DivanteLtd","id":11463761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDYzNzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11463761?v=4","gravatar_id":"","url":"https://api.github.com/users/DivanteLtd","html_url":"https://github.com/DivanteLtd","followers_url":"https://api.github.com/users/DivanteLtd/followers","following_url":"https://api.github.com/users/DivanteLtd/following{/other_user}","gists_url":"https://api.github.com/users/DivanteLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/DivanteLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DivanteLtd/subscriptions","organizations_url":"https://api.github.com/users/DivanteLtd/orgs","repos_url":"https://api.github.com/users/DivanteLtd/repos","events_url":"https://api.github.com/users/DivanteLtd/events{/privacy}","received_events_url":"https://api.github.com/users/DivanteLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":211038815,"node_id":"MDEwOlJlcG9zaXRvcnkyMTEwMzg4MTU=","name":"shopware-pwa","full_name":"DivanteLtd/shopware-pwa","private":false,"owner":{"login":"DivanteLtd","id":11463761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDYzNzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11463761?v=4","gravatar_id":"","url":"https://api.github.com/users/DivanteLtd","html_url":"https://github.com/DivanteLtd","followers_url":"https://api.github.com/users/DivanteLtd/followers","following_url":"https://api.github.com/users/DivanteLtd/following{/other_user}","gists_url":"https://api.github.com/users/DivanteLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/DivanteLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DivanteLtd/subscriptions","organizations_url":"https://api.github.com/users/DivanteLtd/orgs","repos_url":"https://api.github.com/users/DivanteLtd/repos","events_url":"https://api.github.com/users/DivanteLtd/events{/privacy}","received_events_url":"https://api.github.com/users/DivanteLtd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DivanteLtd/shopware-pwa","description":null,"fork":false,"url":"https://api.github.com/repos/DivanteLtd/shopware-pwa","forks_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/forks","keys_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/teams","hooks_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/hooks","issue_events_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues/events{/number}","events_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/events","assignees_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/assignees{/user}","branches_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/branches{/branch}","tags_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/tags","blobs_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/refs{/sha}","trees_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/statuses/{sha}","languages_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/languages","stargazers_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/stargazers","contributors_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/contributors","subscribers_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/subscribers","subscription_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/subscription","commits_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/commits{/sha}","git_commits_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/git/commits{/sha}","comments_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/comments{/number}","issue_comment_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues/comments{/number}","contents_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/contents/{+path}","compare_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/merges","archive_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/downloads","issues_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues{/number}","pulls_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls{/number}","milestones_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/milestones{/number}","notifications_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/labels{/name}","releases_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/releases{/id}","deployments_url":"https://api.github.com/repos/DivanteLtd/shopware-pwa/deployments","created_at":"2019-09-26T08:26:52Z","updated_at":"2019-10-22T14:03:10Z","pushed_at":"2019-10-22T19:04:35Z","git_url":"git://github.com/DivanteLtd/shopware-pwa.git","ssh_url":"git@github.com:DivanteLtd/shopware-pwa.git","clone_url":"https://github.com/DivanteLtd/shopware-pwa.git","svn_url":"https://github.com/DivanteLtd/shopware-pwa","homepage":null,"size":6797,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":62,"license":null,"forks":0,"open_issues":62,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/102"},"html":{"href":"https://github.com/DivanteLtd/shopware-pwa/pull/102"},"issue":{"href":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues/102"},"comments":{"href":"https://api.github.com/repos/DivanteLtd/shopware-pwa/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DivanteLtd/shopware-pwa/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/DivanteLtd/shopware-pwa/statuses/0382f7cfc05c62f1e911b80626d3baeba7cd3e85"}},"author_association":"COLLABORATOR"}}
|
{
"id": 211038815,
"name": "DivanteLtd/shopware-pwa",
"url": "https://api.github.com/repos/DivanteLtd/shopware-pwa"
}
|
{
"id": 1880231,
"login": "rmakara",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1880231?",
"url": "https://api.github.com/users/rmakara"
}
|
{
"id": 11463761,
"login": "DivanteLtd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11463761?",
"url": "https://api.github.com/orgs/DivanteLtd"
}
| 2019-10-22T20:48:57 |
10689629022
|
{"actor":{"display_login":"rmakara"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/tvm/pulls/comments/307093226","pull_request_review_id":266373524,"id":307093226,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzA5MzIyNg==","diff_hunk":"@@ -129,19 +129,26 @@ inline Tensor pool_impl(const Tensor& x,\n return tvm::max(temp(indices), { dheight, dwidth });\n }, \"tensor\", \"pool_max\");\n } else if (pool_type == kAvgPool) {\n+ // Pad the inputs\n auto temp = do_pad ? pad(x, pad_before, pad_after, 0, \"pad_temp\") : x;\n- auto tavg = [&](const Array<Var>& output, Expr divide_factor) {\n+\n+ // TVM compute for summing the pooling window.\n+ auto pool_sum = tvm::compute(out_shape,\n+ [&](const Array<Var>& output) {\n Array<Expr> indices;\n for (const Var& var : output) indices.push_back(var);\n indices.Set(height_axis, output[height_axis] * stride_height + dheight);\n indices.Set(width_axis, output[width_axis] * stride_width + dwidth);\n- return tvm::sum(temp(indices) / divide_factor, { dheight, dwidth });\n- };\n+ return tvm::sum(temp(indices), { dheight, dwidth });","path":"topi/include/topi/nn/pooling.h","position":17,"original_position":17,"commit_id":"2c9dcbaa11580051244f5658d00f80ef0db41a6c","original_commit_id":"2c9dcbaa11580051244f5658d00f80ef0db41a6c","user":{"login":"FrozenGene","id":7287321,"node_id":"MDQ6VXNlcjcyODczMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7287321?v=4","gravatar_id":"","url":"https://api.github.com/users/FrozenGene","html_url":"https://github.com/FrozenGene","followers_url":"https://api.github.com/users/FrozenGene/followers","following_url":"https://api.github.com/users/FrozenGene/following{/other_user}","gists_url":"https://api.github.com/users/FrozenGene/gists{/gist_id}","starred_url":"https://api.github.com/users/FrozenGene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrozenGene/subscriptions","organizations_url":"https://api.github.com/users/FrozenGene/orgs","repos_url":"https://api.github.com/users/FrozenGene/repos","events_url":"https://api.github.com/users/FrozenGene/events{/privacy}","received_events_url":"https://api.github.com/users/FrozenGene/received_events","type":"User","site_admin":false},"body":"I understand the way you want to do. Even the output dtype is \"int32\", you also want to do `avg_pool2d(int_8_value.astype(\"int32\")).astype(\"int8\")` in frontend. ","created_at":"2019-07-25T02:32:34Z","updated_at":"2019-07-25T02:32:34Z","html_url":"https://github.com/dmlc/tvm/pull/3607#discussion_r307093226","pull_request_url":"https://api.github.com/repos/dmlc/tvm/pulls/3607","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/comments/307093226"},"html":{"href":"https://github.com/dmlc/tvm/pull/3607#discussion_r307093226"},"pull_request":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/3607"}},"in_reply_to_id":306709350},"pull_request":{"url":"https://api.github.com/repos/dmlc/tvm/pulls/3607","id":300523562,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNTIzNTYy","html_url":"https://github.com/dmlc/tvm/pull/3607","diff_url":"https://github.com/dmlc/tvm/pull/3607.diff","patch_url":"https://github.com/dmlc/tvm/pull/3607.patch","issue_url":"https://api.github.com/repos/dmlc/tvm/issues/3607","number":3607,"state":"closed","locked":false,"title":"[TOPI] Average Pool2D Bug.","user":{"login":"anijain2305","id":13822661,"node_id":"MDQ6VXNlcjEzODIyNjYx","avatar_url":"https://avatars2.githubusercontent.com/u/13822661?v=4","gravatar_id":"","url":"https://api.github.com/users/anijain2305","html_url":"https://github.com/anijain2305","followers_url":"https://api.github.com/users/anijain2305/followers","following_url":"https://api.github.com/users/anijain2305/following{/other_user}","gists_url":"https://api.github.com/users/anijain2305/gists{/gist_id}","starred_url":"https://api.github.com/users/anijain2305/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anijain2305/subscriptions","organizations_url":"https://api.github.com/users/anijain2305/orgs","repos_url":"https://api.github.com/users/anijain2305/repos","events_url":"https://api.github.com/users/anijain2305/events{/privacy}","received_events_url":"https://api.github.com/users/anijain2305/received_events","type":"User","site_admin":false},"body":"Issue - https://github.com/dmlc/tvm/issues/3581\r\n\r\n@yzhliu @tqchen @FrozenGene @shoubhik @rankyung","created_at":"2019-07-24T01:05:28Z","updated_at":"2019-07-25T02:32:34Z","closed_at":"2019-07-25T01:06:37Z","merged_at":"2019-07-25T01:06:37Z","merge_commit_sha":"3aa2eaed5ca93f0e06079b75e34fcee03c62417a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":858776587,"node_id":"MDU6TGFiZWw4NTg3NzY1ODc=","url":"https://api.github.com/repos/dmlc/tvm/labels/status:%20accepted","name":"status: accepted","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/tvm/pulls/3607/commits","review_comments_url":"https://api.github.com/repos/dmlc/tvm/pulls/3607/comments","review_comment_url":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/tvm/issues/3607/comments","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/2c9dcbaa11580051244f5658d00f80ef0db41a6c","head":{"label":"anijain2305:pool_int8","ref":"pool_int8","sha":"2c9dcbaa11580051244f5658d00f80ef0db41a6c","user":{"login":"anijain2305","id":13822661,"node_id":"MDQ6VXNlcjEzODIyNjYx","avatar_url":"https://avatars2.githubusercontent.com/u/13822661?v=4","gravatar_id":"","url":"https://api.github.com/users/anijain2305","html_url":"https://github.com/anijain2305","followers_url":"https://api.github.com/users/anijain2305/followers","following_url":"https://api.github.com/users/anijain2305/following{/other_user}","gists_url":"https://api.github.com/users/anijain2305/gists{/gist_id}","starred_url":"https://api.github.com/users/anijain2305/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anijain2305/subscriptions","organizations_url":"https://api.github.com/users/anijain2305/orgs","repos_url":"https://api.github.com/users/anijain2305/repos","events_url":"https://api.github.com/users/anijain2305/events{/privacy}","received_events_url":"https://api.github.com/users/anijain2305/received_events","type":"User","site_admin":false},"repo":{"id":150320249,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMjAyNDk=","name":"tvm","full_name":"anijain2305/tvm","private":false,"owner":{"login":"anijain2305","id":13822661,"node_id":"MDQ6VXNlcjEzODIyNjYx","avatar_url":"https://avatars2.githubusercontent.com/u/13822661?v=4","gravatar_id":"","url":"https://api.github.com/users/anijain2305","html_url":"https://github.com/anijain2305","followers_url":"https://api.github.com/users/anijain2305/followers","following_url":"https://api.github.com/users/anijain2305/following{/other_user}","gists_url":"https://api.github.com/users/anijain2305/gists{/gist_id}","starred_url":"https://api.github.com/users/anijain2305/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anijain2305/subscriptions","organizations_url":"https://api.github.com/users/anijain2305/orgs","repos_url":"https://api.github.com/users/anijain2305/repos","events_url":"https://api.github.com/users/anijain2305/events{/privacy}","received_events_url":"https://api.github.com/users/anijain2305/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anijain2305/tvm","description":"Open deep learning compiler stack for cpu, gpu and specialized accelerators","fork":true,"url":"https://api.github.com/repos/anijain2305/tvm","forks_url":"https://api.github.com/repos/anijain2305/tvm/forks","keys_url":"https://api.github.com/repos/anijain2305/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anijain2305/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anijain2305/tvm/teams","hooks_url":"https://api.github.com/repos/anijain2305/tvm/hooks","issue_events_url":"https://api.github.com/repos/anijain2305/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/anijain2305/tvm/events","assignees_url":"https://api.github.com/repos/anijain2305/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/anijain2305/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/anijain2305/tvm/tags","blobs_url":"https://api.github.com/repos/anijain2305/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anijain2305/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anijain2305/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/anijain2305/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anijain2305/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/anijain2305/tvm/languages","stargazers_url":"https://api.github.com/repos/anijain2305/tvm/stargazers","contributors_url":"https://api.github.com/repos/anijain2305/tvm/contributors","subscribers_url":"https://api.github.com/repos/anijain2305/tvm/subscribers","subscription_url":"https://api.github.com/repos/anijain2305/tvm/subscription","commits_url":"https://api.github.com/repos/anijain2305/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/anijain2305/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/anijain2305/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/anijain2305/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/anijain2305/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/anijain2305/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anijain2305/tvm/merges","archive_url":"https://api.github.com/repos/anijain2305/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anijain2305/tvm/downloads","issues_url":"https://api.github.com/repos/anijain2305/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/anijain2305/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/anijain2305/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/anijain2305/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anijain2305/tvm/labels{/name}","releases_url":"https://api.github.com/repos/anijain2305/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/anijain2305/tvm/deployments","created_at":"2018-09-25T19:41:40Z","updated_at":"2019-07-15T15:40:05Z","pushed_at":"2019-07-24T21:49:13Z","git_url":"git://github.com/anijain2305/tvm.git","ssh_url":"git@github.com:anijain2305/tvm.git","clone_url":"https://github.com/anijain2305/tvm.git","svn_url":"https://github.com/anijain2305/tvm","homepage":"https://tvm.ai","size":15707,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"d6dcd6c56febfbb12efe67884c188f045f435893","user":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":70746484,"node_id":"MDEwOlJlcG9zaXRvcnk3MDc0NjQ4NA==","name":"tvm","full_name":"dmlc/tvm","private":false,"owner":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dmlc/tvm","description":"Open deep learning compiler stack for cpu, gpu and specialized accelerators","fork":false,"url":"https://api.github.com/repos/dmlc/tvm","forks_url":"https://api.github.com/repos/dmlc/tvm/forks","keys_url":"https://api.github.com/repos/dmlc/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/tvm/teams","hooks_url":"https://api.github.com/repos/dmlc/tvm/hooks","issue_events_url":"https://api.github.com/repos/dmlc/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/tvm/events","assignees_url":"https://api.github.com/repos/dmlc/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/tvm/tags","blobs_url":"https://api.github.com/repos/dmlc/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/tvm/languages","stargazers_url":"https://api.github.com/repos/dmlc/tvm/stargazers","contributors_url":"https://api.github.com/repos/dmlc/tvm/contributors","subscribers_url":"https://api.github.com/repos/dmlc/tvm/subscribers","subscription_url":"https://api.github.com/repos/dmlc/tvm/subscription","commits_url":"https://api.github.com/repos/dmlc/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/tvm/merges","archive_url":"https://api.github.com/repos/dmlc/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/tvm/downloads","issues_url":"https://api.github.com/repos/dmlc/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/tvm/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/tvm/deployments","created_at":"2016-10-12T22:20:28Z","updated_at":"2019-07-25T01:08:03Z","pushed_at":"2019-07-25T01:45:41Z","git_url":"git://github.com/dmlc/tvm.git","ssh_url":"git@github.com:dmlc/tvm.git","clone_url":"https://github.com/dmlc/tvm.git","svn_url":"https://github.com/dmlc/tvm","homepage":"https://tvm.ai","size":15500,"stargazers_count":3905,"watchers_count":3905,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":973,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":111,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":973,"open_issues":111,"watchers":3905,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/3607"},"html":{"href":"https://github.com/dmlc/tvm/pull/3607"},"issue":{"href":"https://api.github.com/repos/dmlc/tvm/issues/3607"},"comments":{"href":"https://api.github.com/repos/dmlc/tvm/issues/3607/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/3607/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/3607/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/tvm/statuses/2c9dcbaa11580051244f5658d00f80ef0db41a6c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 70746484,
"name": "dmlc/tvm",
"url": "https://api.github.com/repos/dmlc/tvm"
}
|
{
"id": 7287321,
"login": "FrozenGene",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7287321?",
"url": "https://api.github.com/users/FrozenGene"
}
|
{
"id": 11508361,
"login": "dmlc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11508361?",
"url": "https://api.github.com/orgs/dmlc"
}
| 2019-07-25T02:32:34 |
10079719547
|
{"actor":{"display_login":"FrozenGene"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/tvm/pulls/comments/307042719","pull_request_review_id":266312664,"id":307042719,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzA0MjcxOQ==","diff_hunk":"@@ -129,19 +129,26 @@ inline Tensor pool_impl(const Tensor& x,\n return tvm::max(temp(indices), { dheight, dwidth });\n }, \"tensor\", \"pool_max\");\n } else if (pool_type == kAvgPool) {\n+ // Pad the inputs\n auto temp = do_pad ? pad(x, pad_before, pad_after, 0, \"pad_temp\") : x;\n- auto tavg = [&](const Array<Var>& output, Expr divide_factor) {\n+\n+ // TVM compute for summing the pooling window.\n+ auto pool_sum = tvm::compute(out_shape,\n+ [&](const Array<Var>& output) {\n Array<Expr> indices;\n for (const Var& var : output) indices.push_back(var);\n indices.Set(height_axis, output[height_axis] * stride_height + dheight);\n indices.Set(width_axis, output[width_axis] * stride_width + dwidth);\n- return tvm::sum(temp(indices) / divide_factor, { dheight, dwidth });\n- };\n+ return tvm::sum(temp(indices), { dheight, dwidth });","path":"topi/include/topi/nn/pooling.h","position":17,"original_position":17,"commit_id":"2c9dcbaa11580051244f5658d00f80ef0db41a6c","original_commit_id":"2c9dcbaa11580051244f5658d00f80ef0db41a6c","user":{"login":"anijain2305","id":13822661,"node_id":"MDQ6VXNlcjEzODIyNjYx","avatar_url":"https://avatars2.githubusercontent.com/u/13822661?v=4","gravatar_id":"","url":"https://api.github.com/users/anijain2305","html_url":"https://github.com/anijain2305","followers_url":"https://api.github.com/users/anijain2305/followers","following_url":"https://api.github.com/users/anijain2305/following{/other_user}","gists_url":"https://api.github.com/users/anijain2305/gists{/gist_id}","starred_url":"https://api.github.com/users/anijain2305/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anijain2305/subscriptions","organizations_url":"https://api.github.com/users/anijain2305/orgs","repos_url":"https://api.github.com/users/anijain2305/repos","events_url":"https://api.github.com/users/anijain2305/events{/privacy}","received_events_url":"https://api.github.com/users/anijain2305/received_events","type":"User","site_admin":false},"body":"For TFLite adaptation, we can `cast` the input to `uint16` and then pass the casted input to `avg_pool2d`. This is purely the job of framework parser. It does not need any code in the TOPI layer.","created_at":"2019-07-24T22:09:58Z","updated_at":"2019-07-24T22:09:58Z","html_url":"https://github.com/dmlc/tvm/pull/3607#discussion_r307042719","pull_request_url":"https://api.github.com/repos/dmlc/tvm/pulls/3607","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/comments/307042719"},"html":{"href":"https://github.com/dmlc/tvm/pull/3607#discussion_r307042719"},"pull_request":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/3607"}},"in_reply_to_id":306709350},"pull_request":{"url":"https://api.github.com/repos/dmlc/tvm/pulls/3607","id":300523562,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNTIzNTYy","html_url":"https://github.com/dmlc/tvm/pull/3607","diff_url":"https://github.com/dmlc/tvm/pull/3607.diff","patch_url":"https://github.com/dmlc/tvm/pull/3607.patch","issue_url":"https://api.github.com/repos/dmlc/tvm/issues/3607","number":3607,"state":"open","locked":false,"title":"[TOPI] Average Pool2D Bug.","user":{"login":"anijain2305","id":13822661,"node_id":"MDQ6VXNlcjEzODIyNjYx","avatar_url":"https://avatars2.githubusercontent.com/u/13822661?v=4","gravatar_id":"","url":"https://api.github.com/users/anijain2305","html_url":"https://github.com/anijain2305","followers_url":"https://api.github.com/users/anijain2305/followers","following_url":"https://api.github.com/users/anijain2305/following{/other_user}","gists_url":"https://api.github.com/users/anijain2305/gists{/gist_id}","starred_url":"https://api.github.com/users/anijain2305/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anijain2305/subscriptions","organizations_url":"https://api.github.com/users/anijain2305/orgs","repos_url":"https://api.github.com/users/anijain2305/repos","events_url":"https://api.github.com/users/anijain2305/events{/privacy}","received_events_url":"https://api.github.com/users/anijain2305/received_events","type":"User","site_admin":false},"body":"Issue - https://github.com/dmlc/tvm/issues/3581\r\n\r\n@yzhliu @tqchen @FrozenGene @shoubhik @rankyung","created_at":"2019-07-24T01:05:28Z","updated_at":"2019-07-24T22:09:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"459e03b34cabf217c37217d42b84aa192d70a5fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/tvm/pulls/3607/commits","review_comments_url":"https://api.github.com/repos/dmlc/tvm/pulls/3607/comments","review_comment_url":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/tvm/issues/3607/comments","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/2c9dcbaa11580051244f5658d00f80ef0db41a6c","head":{"label":"anijain2305:pool_int8","ref":"pool_int8","sha":"2c9dcbaa11580051244f5658d00f80ef0db41a6c","user":{"login":"anijain2305","id":13822661,"node_id":"MDQ6VXNlcjEzODIyNjYx","avatar_url":"https://avatars2.githubusercontent.com/u/13822661?v=4","gravatar_id":"","url":"https://api.github.com/users/anijain2305","html_url":"https://github.com/anijain2305","followers_url":"https://api.github.com/users/anijain2305/followers","following_url":"https://api.github.com/users/anijain2305/following{/other_user}","gists_url":"https://api.github.com/users/anijain2305/gists{/gist_id}","starred_url":"https://api.github.com/users/anijain2305/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anijain2305/subscriptions","organizations_url":"https://api.github.com/users/anijain2305/orgs","repos_url":"https://api.github.com/users/anijain2305/repos","events_url":"https://api.github.com/users/anijain2305/events{/privacy}","received_events_url":"https://api.github.com/users/anijain2305/received_events","type":"User","site_admin":false},"repo":{"id":150320249,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMjAyNDk=","name":"tvm","full_name":"anijain2305/tvm","private":false,"owner":{"login":"anijain2305","id":13822661,"node_id":"MDQ6VXNlcjEzODIyNjYx","avatar_url":"https://avatars2.githubusercontent.com/u/13822661?v=4","gravatar_id":"","url":"https://api.github.com/users/anijain2305","html_url":"https://github.com/anijain2305","followers_url":"https://api.github.com/users/anijain2305/followers","following_url":"https://api.github.com/users/anijain2305/following{/other_user}","gists_url":"https://api.github.com/users/anijain2305/gists{/gist_id}","starred_url":"https://api.github.com/users/anijain2305/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anijain2305/subscriptions","organizations_url":"https://api.github.com/users/anijain2305/orgs","repos_url":"https://api.github.com/users/anijain2305/repos","events_url":"https://api.github.com/users/anijain2305/events{/privacy}","received_events_url":"https://api.github.com/users/anijain2305/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anijain2305/tvm","description":"Open deep learning compiler stack for cpu, gpu and specialized accelerators","fork":true,"url":"https://api.github.com/repos/anijain2305/tvm","forks_url":"https://api.github.com/repos/anijain2305/tvm/forks","keys_url":"https://api.github.com/repos/anijain2305/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anijain2305/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anijain2305/tvm/teams","hooks_url":"https://api.github.com/repos/anijain2305/tvm/hooks","issue_events_url":"https://api.github.com/repos/anijain2305/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/anijain2305/tvm/events","assignees_url":"https://api.github.com/repos/anijain2305/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/anijain2305/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/anijain2305/tvm/tags","blobs_url":"https://api.github.com/repos/anijain2305/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anijain2305/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anijain2305/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/anijain2305/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anijain2305/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/anijain2305/tvm/languages","stargazers_url":"https://api.github.com/repos/anijain2305/tvm/stargazers","contributors_url":"https://api.github.com/repos/anijain2305/tvm/contributors","subscribers_url":"https://api.github.com/repos/anijain2305/tvm/subscribers","subscription_url":"https://api.github.com/repos/anijain2305/tvm/subscription","commits_url":"https://api.github.com/repos/anijain2305/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/anijain2305/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/anijain2305/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/anijain2305/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/anijain2305/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/anijain2305/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anijain2305/tvm/merges","archive_url":"https://api.github.com/repos/anijain2305/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anijain2305/tvm/downloads","issues_url":"https://api.github.com/repos/anijain2305/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/anijain2305/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/anijain2305/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/anijain2305/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anijain2305/tvm/labels{/name}","releases_url":"https://api.github.com/repos/anijain2305/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/anijain2305/tvm/deployments","created_at":"2018-09-25T19:41:40Z","updated_at":"2019-07-15T15:40:05Z","pushed_at":"2019-07-24T21:49:13Z","git_url":"git://github.com/anijain2305/tvm.git","ssh_url":"git@github.com:anijain2305/tvm.git","clone_url":"https://github.com/anijain2305/tvm.git","svn_url":"https://github.com/anijain2305/tvm","homepage":"https://tvm.ai","size":15424,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"d6dcd6c56febfbb12efe67884c188f045f435893","user":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":70746484,"node_id":"MDEwOlJlcG9zaXRvcnk3MDc0NjQ4NA==","name":"tvm","full_name":"dmlc/tvm","private":false,"owner":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dmlc/tvm","description":"Open deep learning compiler stack for cpu, gpu and specialized accelerators","fork":false,"url":"https://api.github.com/repos/dmlc/tvm","forks_url":"https://api.github.com/repos/dmlc/tvm/forks","keys_url":"https://api.github.com/repos/dmlc/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/tvm/teams","hooks_url":"https://api.github.com/repos/dmlc/tvm/hooks","issue_events_url":"https://api.github.com/repos/dmlc/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/tvm/events","assignees_url":"https://api.github.com/repos/dmlc/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/tvm/tags","blobs_url":"https://api.github.com/repos/dmlc/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/tvm/languages","stargazers_url":"https://api.github.com/repos/dmlc/tvm/stargazers","contributors_url":"https://api.github.com/repos/dmlc/tvm/contributors","subscribers_url":"https://api.github.com/repos/dmlc/tvm/subscribers","subscription_url":"https://api.github.com/repos/dmlc/tvm/subscription","commits_url":"https://api.github.com/repos/dmlc/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/tvm/merges","archive_url":"https://api.github.com/repos/dmlc/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/tvm/downloads","issues_url":"https://api.github.com/repos/dmlc/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/tvm/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/tvm/deployments","created_at":"2016-10-12T22:20:28Z","updated_at":"2019-07-24T20:53:33Z","pushed_at":"2019-07-24T21:49:16Z","git_url":"git://github.com/dmlc/tvm.git","ssh_url":"git@github.com:dmlc/tvm.git","clone_url":"https://github.com/dmlc/tvm.git","svn_url":"https://github.com/dmlc/tvm","homepage":"https://tvm.ai","size":15502,"stargazers_count":3904,"watchers_count":3904,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":973,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":111,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":973,"open_issues":111,"watchers":3904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/3607"},"html":{"href":"https://github.com/dmlc/tvm/pull/3607"},"issue":{"href":"https://api.github.com/repos/dmlc/tvm/issues/3607"},"comments":{"href":"https://api.github.com/repos/dmlc/tvm/issues/3607/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/3607/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/3607/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/tvm/statuses/2c9dcbaa11580051244f5658d00f80ef0db41a6c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 70746484,
"name": "dmlc/tvm",
"url": "https://api.github.com/repos/dmlc/tvm"
}
|
{
"id": 13822661,
"login": "anijain2305",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13822661?",
"url": "https://api.github.com/users/anijain2305"
}
|
{
"id": 11508361,
"login": "dmlc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11508361?",
"url": "https://api.github.com/orgs/dmlc"
}
| 2019-07-24T22:09:58 |
10078739365
|
{"actor":{"display_login":"anijain2305"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/comments/362982779","pull_request_review_id":338298444,"id":362982779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2Mjk4Mjc3OQ==","diff_hunk":"@@ -0,0 +1,68 @@\n+Describe \"ReviewUnusedParameter\" {\n+ BeforeAll {\n+ $RuleName = 'PSReviewUnusedParameter'\n+ $RuleSeverity = \"Warning\"\n+ }\n+\n+ Context \"When there are violations\" {\n+ $Cases = @(\n+ @{\n+ ScriptDefinition = 'function BadFunc1 { param ($Param1, $Param2) $Param1}'\n+ Name = \"function with 1 unused parameter\"\n+ NumberOfViolations = 1\n+ }\n+ @{\n+ ScriptDefinition = 'function BadFunc1 { param ($Param1, $Param2) }'\n+ Name = \"function with 2 unused parameters\"\n+ NumberOfViolations = 2\n+ }\n+ @{\n+ ScriptDefinition = '{ param ($Param1) }'\n+ Name = \"scriptblock with unused parameter\"\n+ NumberOfViolations = 1\n+ }\n+ @{\n+ ScriptDefinition = '{ param ($Param1) }; { $Param1 }'\n+ Name = \"parameter with same name in different scope\"\n+ NumberOfViolations = 1\n+ }\n+ )","path":"Tests/Rules/ReviewUnusedParameter.tests.ps1","position":29,"original_position":29,"commit_id":"cdbce04fdc5a4758f45d9d2ea367903bc1af7888","original_commit_id":"cdbce04fdc5a4758f45d9d2ea367903bc1af7888","user":{"login":"rjmholt","id":7009879,"node_id":"MDQ6VXNlcjcwMDk4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/7009879?v=4","gravatar_id":"","url":"https://api.github.com/users/rjmholt","html_url":"https://github.com/rjmholt","followers_url":"https://api.github.com/users/rjmholt/followers","following_url":"https://api.github.com/users/rjmholt/following{/other_user}","gists_url":"https://api.github.com/users/rjmholt/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmholt/subscriptions","organizations_url":"https://api.github.com/users/rjmholt/orgs","repos_url":"https://api.github.com/users/rjmholt/repos","events_url":"https://api.github.com/users/rjmholt/events{/privacy}","received_events_url":"https://api.github.com/users/rjmholt/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n )\r\n\r\n```","created_at":"2020-01-03T22:30:57Z","updated_at":"2020-01-03T22:31:24Z","html_url":"https://github.com/PowerShell/PSScriptAnalyzer/pull/1382#discussion_r362982779","pull_request_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1382","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/comments/362982779"},"html":{"href":"https://github.com/PowerShell/PSScriptAnalyzer/pull/1382#discussion_r362982779"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1382"}}},"pull_request":{"url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1382","id":351207710,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxMjA3NzEw","html_url":"https://github.com/PowerShell/PSScriptAnalyzer/pull/1382","diff_url":"https://github.com/PowerShell/PSScriptAnalyzer/pull/1382.diff","patch_url":"https://github.com/PowerShell/PSScriptAnalyzer/pull/1382.patch","issue_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/issues/1382","number":1382,"state":"open","locked":false,"title":"New rule - ReviewUnusedParameter","user":{"login":"mattmcnabb","id":6998507,"node_id":"MDQ6VXNlcjY5OTg1MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/6998507?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcnabb","html_url":"https://github.com/mattmcnabb","followers_url":"https://api.github.com/users/mattmcnabb/followers","following_url":"https://api.github.com/users/mattmcnabb/following{/other_user}","gists_url":"https://api.github.com/users/mattmcnabb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcnabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcnabb/subscriptions","organizations_url":"https://api.github.com/users/mattmcnabb/orgs","repos_url":"https://api.github.com/users/mattmcnabb/repos","events_url":"https://api.github.com/users/mattmcnabb/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcnabb/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nThis PR adds a new rule to detect declared parameters that are not used in the body of the script, function or scriptblock where they are declared. Conversation around this is in #1381.\r\n\r\nI've added tests to cover the basic scenarios this will cover, but there may be some cases not covered yet. Some issues to discuss are:\r\n\r\n1. This currently looks only in the same scope for usages of the parameter and not in child scopes. Not sure if that's worth looking into as calling the parameter in a child scope may not be good practice. I included a skipped test for future reference.\r\n2. This doesn't look for instances of Get-Variable referencing the parameter.\r\n3. This will not flag parameters in a scriptblock where `$PSBoundParameters` is called.\r\n\r\nIf these are not major issues then this may be ready for merge.\r\n\r\n## PR Checklist\r\n\r\n- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n - Use the present tense and imperative mood when describing your changes\r\n- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n- [x] [Change is not breaking](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)\r\n- [x] [Make sure all `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)\r\n- [x] Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation\r\n- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).\r\n - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready.","created_at":"2019-12-10T05:32:53Z","updated_at":"2020-01-03T22:31:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1d71bb7342d0065b70ac040b944b5f6070c528c","assignee":{"login":"bergmeister","id":9250262,"node_id":"MDQ6VXNlcjkyNTAyNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/9250262?v=4","gravatar_id":"","url":"https://api.github.com/users/bergmeister","html_url":"https://github.com/bergmeister","followers_url":"https://api.github.com/users/bergmeister/followers","following_url":"https://api.github.com/users/bergmeister/following{/other_user}","gists_url":"https://api.github.com/users/bergmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/bergmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergmeister/subscriptions","organizations_url":"https://api.github.com/users/bergmeister/orgs","repos_url":"https://api.github.com/users/bergmeister/repos","events_url":"https://api.github.com/users/bergmeister/events{/privacy}","received_events_url":"https://api.github.com/users/bergmeister/received_events","type":"User","site_admin":false},"assignees":[{"login":"bergmeister","id":9250262,"node_id":"MDQ6VXNlcjkyNTAyNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/9250262?v=4","gravatar_id":"","url":"https://api.github.com/users/bergmeister","html_url":"https://github.com/bergmeister","followers_url":"https://api.github.com/users/bergmeister/followers","following_url":"https://api.github.com/users/bergmeister/following{/other_user}","gists_url":"https://api.github.com/users/bergmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/bergmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergmeister/subscriptions","organizations_url":"https://api.github.com/users/bergmeister/orgs","repos_url":"https://api.github.com/users/bergmeister/repos","events_url":"https://api.github.com/users/bergmeister/events{/privacy}","received_events_url":"https://api.github.com/users/bergmeister/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"JamesWTruher","id":10214008,"node_id":"MDQ6VXNlcjEwMjE0MDA4","avatar_url":"https://avatars2.githubusercontent.com/u/10214008?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesWTruher","html_url":"https://github.com/JamesWTruher","followers_url":"https://api.github.com/users/JamesWTruher/followers","following_url":"https://api.github.com/users/JamesWTruher/following{/other_user}","gists_url":"https://api.github.com/users/JamesWTruher/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesWTruher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesWTruher/subscriptions","organizations_url":"https://api.github.com/users/JamesWTruher/orgs","repos_url":"https://api.github.com/users/JamesWTruher/repos","events_url":"https://api.github.com/users/JamesWTruher/events{/privacy}","received_events_url":"https://api.github.com/users/JamesWTruher/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":200952719,"node_id":"MDU6TGFiZWwyMDA5NTI3MTk=","url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/labels/Issue%20-%20New%20Rule","name":"Issue - New Rule","color":"fad8c7","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1382/commits","review_comments_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1382/comments","review_comment_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/issues/1382/comments","statuses_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/statuses/cdbce04fdc5a4758f45d9d2ea367903bc1af7888","head":{"label":"mattmcnabb:master","ref":"master","sha":"cdbce04fdc5a4758f45d9d2ea367903bc1af7888","user":{"login":"mattmcnabb","id":6998507,"node_id":"MDQ6VXNlcjY5OTg1MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/6998507?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcnabb","html_url":"https://github.com/mattmcnabb","followers_url":"https://api.github.com/users/mattmcnabb/followers","following_url":"https://api.github.com/users/mattmcnabb/following{/other_user}","gists_url":"https://api.github.com/users/mattmcnabb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcnabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcnabb/subscriptions","organizations_url":"https://api.github.com/users/mattmcnabb/orgs","repos_url":"https://api.github.com/users/mattmcnabb/repos","events_url":"https://api.github.com/users/mattmcnabb/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcnabb/received_events","type":"User","site_admin":false},"repo":{"id":227025856,"node_id":"MDEwOlJlcG9zaXRvcnkyMjcwMjU4NTY=","name":"PSScriptAnalyzer","full_name":"mattmcnabb/PSScriptAnalyzer","private":false,"owner":{"login":"mattmcnabb","id":6998507,"node_id":"MDQ6VXNlcjY5OTg1MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/6998507?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcnabb","html_url":"https://github.com/mattmcnabb","followers_url":"https://api.github.com/users/mattmcnabb/followers","following_url":"https://api.github.com/users/mattmcnabb/following{/other_user}","gists_url":"https://api.github.com/users/mattmcnabb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcnabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcnabb/subscriptions","organizations_url":"https://api.github.com/users/mattmcnabb/orgs","repos_url":"https://api.github.com/users/mattmcnabb/repos","events_url":"https://api.github.com/users/mattmcnabb/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcnabb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mattmcnabb/PSScriptAnalyzer","description":"Download ScriptAnalyzer from PowerShellGallery","fork":true,"url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer","forks_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/forks","keys_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/teams","hooks_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/events","assignees_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/tags","blobs_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/languages","stargazers_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/subscription","commits_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/merges","archive_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/downloads","issues_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/releases{/id}","deployments_url":"https://api.github.com/repos/mattmcnabb/PSScriptAnalyzer/deployments","created_at":"2019-12-10T04:02:18Z","updated_at":"2020-01-03T21:52:37Z","pushed_at":"2020-01-03T21:52:35Z","git_url":"git://github.com/mattmcnabb/PSScriptAnalyzer.git","ssh_url":"git@github.com:mattmcnabb/PSScriptAnalyzer.git","clone_url":"https://github.com/mattmcnabb/PSScriptAnalyzer.git","svn_url":"https://github.com/mattmcnabb/PSScriptAnalyzer","homepage":"https://www.powershellgallery.com/packages/PSScriptAnalyzer/","size":22921,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerShell:master","ref":"master","sha":"18d0f0308085efc9f1a9b47e0cd7f11e2eeaf105","user":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":33149177,"node_id":"MDEwOlJlcG9zaXRvcnkzMzE0OTE3Nw==","name":"PSScriptAnalyzer","full_name":"PowerShell/PSScriptAnalyzer","private":false,"owner":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PowerShell/PSScriptAnalyzer","description":"Download ScriptAnalyzer from PowerShellGallery","fork":false,"url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer","forks_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/forks","keys_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/teams","hooks_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/events","assignees_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/tags","blobs_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/subscription","commits_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/merges","archive_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/downloads","issues_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/deployments","created_at":"2015-03-30T21:26:25Z","updated_at":"2020-01-03T22:10:22Z","pushed_at":"2020-01-03T22:10:19Z","git_url":"git://github.com/PowerShell/PSScriptAnalyzer.git","ssh_url":"git@github.com:PowerShell/PSScriptAnalyzer.git","clone_url":"https://github.com/PowerShell/PSScriptAnalyzer.git","svn_url":"https://github.com/PowerShell/PSScriptAnalyzer","homepage":"https://www.powershellgallery.com/packages/PSScriptAnalyzer/","size":22942,"stargazers_count":865,"watchers_count":865,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":210,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":267,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":210,"open_issues":267,"watchers":865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1382"},"html":{"href":"https://github.com/PowerShell/PSScriptAnalyzer/pull/1382"},"issue":{"href":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/issues/1382"},"comments":{"href":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/issues/1382/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1382/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1382/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/PSScriptAnalyzer/statuses/cdbce04fdc5a4758f45d9d2ea367903bc1af7888"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 33149177,
"name": "PowerShell/PSScriptAnalyzer",
"url": "https://api.github.com/repos/PowerShell/PSScriptAnalyzer"
}
|
{
"id": 7009879,
"login": "rjmholt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7009879?",
"url": "https://api.github.com/users/rjmholt"
}
|
{
"id": 11524380,
"login": "PowerShell",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11524380?",
"url": "https://api.github.com/orgs/PowerShell"
}
| 2020-01-03T22:30:57 |
11200646884
|
{"actor":{"display_login":"rjmholt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/weareleaf/leaf-site/pulls/comments/355392776","pull_request_review_id":328836070,"id":355392776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTM5Mjc3Ng==","diff_hunk":"@@ -114,17 +113,17 @@\n transform: translateY(-53%);\n width: 18px;","path":"src/components/form/_form.scss","position":82,"original_position":82,"commit_id":"05d5b17dc1ccad5cf97d3b78ce3aec9b4fc73dae","original_commit_id":"05d5b17dc1ccad5cf97d3b78ce3aec9b4fc73dae","user":{"login":"chrisannetts","id":7361435,"node_id":"MDQ6VXNlcjczNjE0MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/7361435?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisannetts","html_url":"https://github.com/chrisannetts","followers_url":"https://api.github.com/users/chrisannetts/followers","following_url":"https://api.github.com/users/chrisannetts/following{/other_user}","gists_url":"https://api.github.com/users/chrisannetts/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisannetts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisannetts/subscriptions","organizations_url":"https://api.github.com/users/chrisannetts/orgs","repos_url":"https://api.github.com/users/chrisannetts/repos","events_url":"https://api.github.com/users/chrisannetts/events{/privacy}","received_events_url":"https://api.github.com/users/chrisannetts/received_events","type":"User","site_admin":false},"body":"Not you, but `px`?","created_at":"2019-12-09T11:17:35Z","updated_at":"2019-12-09T11:27:40Z","html_url":"https://github.com/weareleaf/leaf-site/pull/27#discussion_r355392776","pull_request_url":"https://api.github.com/repos/weareleaf/leaf-site/pulls/27","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/weareleaf/leaf-site/pulls/comments/355392776"},"html":{"href":"https://github.com/weareleaf/leaf-site/pull/27#discussion_r355392776"},"pull_request":{"href":"https://api.github.com/repos/weareleaf/leaf-site/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/weareleaf/leaf-site/pulls/27","id":349328958,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5MzI4OTU4","html_url":"https://github.com/weareleaf/leaf-site/pull/27","diff_url":"https://github.com/weareleaf/leaf-site/pull/27.diff","patch_url":"https://github.com/weareleaf/leaf-site/pull/27.patch","issue_url":"https://api.github.com/repos/weareleaf/leaf-site/issues/27","number":27,"state":"open","locked":false,"title":"Scss refactor","user":{"login":"CurtisALee","id":22593005,"node_id":"MDQ6VXNlcjIyNTkzMDA1","avatar_url":"https://avatars2.githubusercontent.com/u/22593005?v=4","gravatar_id":"","url":"https://api.github.com/users/CurtisALee","html_url":"https://github.com/CurtisALee","followers_url":"https://api.github.com/users/CurtisALee/followers","following_url":"https://api.github.com/users/CurtisALee/following{/other_user}","gists_url":"https://api.github.com/users/CurtisALee/gists{/gist_id}","starred_url":"https://api.github.com/users/CurtisALee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CurtisALee/subscriptions","organizations_url":"https://api.github.com/users/CurtisALee/orgs","repos_url":"https://api.github.com/users/CurtisALee/repos","events_url":"https://api.github.com/users/CurtisALee/events{/privacy}","received_events_url":"https://api.github.com/users/CurtisALee/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-05T09:07:24Z","updated_at":"2019-12-09T11:27:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b56804eb9f6e3d109411c6c29977dc2ebcc11ea3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/weareleaf/leaf-site/pulls/27/commits","review_comments_url":"https://api.github.com/repos/weareleaf/leaf-site/pulls/27/comments","review_comment_url":"https://api.github.com/repos/weareleaf/leaf-site/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weareleaf/leaf-site/issues/27/comments","statuses_url":"https://api.github.com/repos/weareleaf/leaf-site/statuses/05d5b17dc1ccad5cf97d3b78ce3aec9b4fc73dae","head":{"label":"weareleaf:scss-refactor","ref":"scss-refactor","sha":"05d5b17dc1ccad5cf97d3b78ce3aec9b4fc73dae","user":{"login":"weareleaf","id":11577222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTc3MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/11577222?v=4","gravatar_id":"","url":"https://api.github.com/users/weareleaf","html_url":"https://github.com/weareleaf","followers_url":"https://api.github.com/users/weareleaf/followers","following_url":"https://api.github.com/users/weareleaf/following{/other_user}","gists_url":"https://api.github.com/users/weareleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/weareleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weareleaf/subscriptions","organizations_url":"https://api.github.com/users/weareleaf/orgs","repos_url":"https://api.github.com/users/weareleaf/repos","events_url":"https://api.github.com/users/weareleaf/events{/privacy}","received_events_url":"https://api.github.com/users/weareleaf/received_events","type":"Organization","site_admin":false},"repo":{"id":33088158,"node_id":"MDEwOlJlcG9zaXRvcnkzMzA4ODE1OA==","name":"leaf-site","full_name":"weareleaf/leaf-site","private":false,"owner":{"login":"weareleaf","id":11577222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTc3MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/11577222?v=4","gravatar_id":"","url":"https://api.github.com/users/weareleaf","html_url":"https://github.com/weareleaf","followers_url":"https://api.github.com/users/weareleaf/followers","following_url":"https://api.github.com/users/weareleaf/following{/other_user}","gists_url":"https://api.github.com/users/weareleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/weareleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weareleaf/subscriptions","organizations_url":"https://api.github.com/users/weareleaf/orgs","repos_url":"https://api.github.com/users/weareleaf/repos","events_url":"https://api.github.com/users/weareleaf/events{/privacy}","received_events_url":"https://api.github.com/users/weareleaf/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/weareleaf/leaf-site","description":"Leaf Website","fork":false,"url":"https://api.github.com/repos/weareleaf/leaf-site","forks_url":"https://api.github.com/repos/weareleaf/leaf-site/forks","keys_url":"https://api.github.com/repos/weareleaf/leaf-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weareleaf/leaf-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weareleaf/leaf-site/teams","hooks_url":"https://api.github.com/repos/weareleaf/leaf-site/hooks","issue_events_url":"https://api.github.com/repos/weareleaf/leaf-site/issues/events{/number}","events_url":"https://api.github.com/repos/weareleaf/leaf-site/events","assignees_url":"https://api.github.com/repos/weareleaf/leaf-site/assignees{/user}","branches_url":"https://api.github.com/repos/weareleaf/leaf-site/branches{/branch}","tags_url":"https://api.github.com/repos/weareleaf/leaf-site/tags","blobs_url":"https://api.github.com/repos/weareleaf/leaf-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weareleaf/leaf-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weareleaf/leaf-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/weareleaf/leaf-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weareleaf/leaf-site/statuses/{sha}","languages_url":"https://api.github.com/repos/weareleaf/leaf-site/languages","stargazers_url":"https://api.github.com/repos/weareleaf/leaf-site/stargazers","contributors_url":"https://api.github.com/repos/weareleaf/leaf-site/contributors","subscribers_url":"https://api.github.com/repos/weareleaf/leaf-site/subscribers","subscription_url":"https://api.github.com/repos/weareleaf/leaf-site/subscription","commits_url":"https://api.github.com/repos/weareleaf/leaf-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/weareleaf/leaf-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/weareleaf/leaf-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/weareleaf/leaf-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/weareleaf/leaf-site/contents/{+path}","compare_url":"https://api.github.com/repos/weareleaf/leaf-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weareleaf/leaf-site/merges","archive_url":"https://api.github.com/repos/weareleaf/leaf-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weareleaf/leaf-site/downloads","issues_url":"https://api.github.com/repos/weareleaf/leaf-site/issues{/number}","pulls_url":"https://api.github.com/repos/weareleaf/leaf-site/pulls{/number}","milestones_url":"https://api.github.com/repos/weareleaf/leaf-site/milestones{/number}","notifications_url":"https://api.github.com/repos/weareleaf/leaf-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weareleaf/leaf-site/labels{/name}","releases_url":"https://api.github.com/repos/weareleaf/leaf-site/releases{/id}","deployments_url":"https://api.github.com/repos/weareleaf/leaf-site/deployments","created_at":"2015-03-29T20:29:08Z","updated_at":"2019-11-27T10:38:48Z","pushed_at":"2019-12-05T09:07:25Z","git_url":"git://github.com/weareleaf/leaf-site.git","ssh_url":"git@github.com:weareleaf/leaf-site.git","clone_url":"https://github.com/weareleaf/leaf-site.git","svn_url":"https://github.com/weareleaf/leaf-site","homepage":null,"size":255150,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"weareleaf:master","ref":"master","sha":"475197d5c4f04b055478d4c44f64ed6b1a505ba7","user":{"login":"weareleaf","id":11577222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTc3MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/11577222?v=4","gravatar_id":"","url":"https://api.github.com/users/weareleaf","html_url":"https://github.com/weareleaf","followers_url":"https://api.github.com/users/weareleaf/followers","following_url":"https://api.github.com/users/weareleaf/following{/other_user}","gists_url":"https://api.github.com/users/weareleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/weareleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weareleaf/subscriptions","organizations_url":"https://api.github.com/users/weareleaf/orgs","repos_url":"https://api.github.com/users/weareleaf/repos","events_url":"https://api.github.com/users/weareleaf/events{/privacy}","received_events_url":"https://api.github.com/users/weareleaf/received_events","type":"Organization","site_admin":false},"repo":{"id":33088158,"node_id":"MDEwOlJlcG9zaXRvcnkzMzA4ODE1OA==","name":"leaf-site","full_name":"weareleaf/leaf-site","private":false,"owner":{"login":"weareleaf","id":11577222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTc3MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/11577222?v=4","gravatar_id":"","url":"https://api.github.com/users/weareleaf","html_url":"https://github.com/weareleaf","followers_url":"https://api.github.com/users/weareleaf/followers","following_url":"https://api.github.com/users/weareleaf/following{/other_user}","gists_url":"https://api.github.com/users/weareleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/weareleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weareleaf/subscriptions","organizations_url":"https://api.github.com/users/weareleaf/orgs","repos_url":"https://api.github.com/users/weareleaf/repos","events_url":"https://api.github.com/users/weareleaf/events{/privacy}","received_events_url":"https://api.github.com/users/weareleaf/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/weareleaf/leaf-site","description":"Leaf Website","fork":false,"url":"https://api.github.com/repos/weareleaf/leaf-site","forks_url":"https://api.github.com/repos/weareleaf/leaf-site/forks","keys_url":"https://api.github.com/repos/weareleaf/leaf-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weareleaf/leaf-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weareleaf/leaf-site/teams","hooks_url":"https://api.github.com/repos/weareleaf/leaf-site/hooks","issue_events_url":"https://api.github.com/repos/weareleaf/leaf-site/issues/events{/number}","events_url":"https://api.github.com/repos/weareleaf/leaf-site/events","assignees_url":"https://api.github.com/repos/weareleaf/leaf-site/assignees{/user}","branches_url":"https://api.github.com/repos/weareleaf/leaf-site/branches{/branch}","tags_url":"https://api.github.com/repos/weareleaf/leaf-site/tags","blobs_url":"https://api.github.com/repos/weareleaf/leaf-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weareleaf/leaf-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weareleaf/leaf-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/weareleaf/leaf-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weareleaf/leaf-site/statuses/{sha}","languages_url":"https://api.github.com/repos/weareleaf/leaf-site/languages","stargazers_url":"https://api.github.com/repos/weareleaf/leaf-site/stargazers","contributors_url":"https://api.github.com/repos/weareleaf/leaf-site/contributors","subscribers_url":"https://api.github.com/repos/weareleaf/leaf-site/subscribers","subscription_url":"https://api.github.com/repos/weareleaf/leaf-site/subscription","commits_url":"https://api.github.com/repos/weareleaf/leaf-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/weareleaf/leaf-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/weareleaf/leaf-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/weareleaf/leaf-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/weareleaf/leaf-site/contents/{+path}","compare_url":"https://api.github.com/repos/weareleaf/leaf-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weareleaf/leaf-site/merges","archive_url":"https://api.github.com/repos/weareleaf/leaf-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weareleaf/leaf-site/downloads","issues_url":"https://api.github.com/repos/weareleaf/leaf-site/issues{/number}","pulls_url":"https://api.github.com/repos/weareleaf/leaf-site/pulls{/number}","milestones_url":"https://api.github.com/repos/weareleaf/leaf-site/milestones{/number}","notifications_url":"https://api.github.com/repos/weareleaf/leaf-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weareleaf/leaf-site/labels{/name}","releases_url":"https://api.github.com/repos/weareleaf/leaf-site/releases{/id}","deployments_url":"https://api.github.com/repos/weareleaf/leaf-site/deployments","created_at":"2015-03-29T20:29:08Z","updated_at":"2019-11-27T10:38:48Z","pushed_at":"2019-12-05T09:07:25Z","git_url":"git://github.com/weareleaf/leaf-site.git","ssh_url":"git@github.com:weareleaf/leaf-site.git","clone_url":"https://github.com/weareleaf/leaf-site.git","svn_url":"https://github.com/weareleaf/leaf-site","homepage":null,"size":255150,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weareleaf/leaf-site/pulls/27"},"html":{"href":"https://github.com/weareleaf/leaf-site/pull/27"},"issue":{"href":"https://api.github.com/repos/weareleaf/leaf-site/issues/27"},"comments":{"href":"https://api.github.com/repos/weareleaf/leaf-site/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/weareleaf/leaf-site/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/weareleaf/leaf-site/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weareleaf/leaf-site/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/weareleaf/leaf-site/statuses/05d5b17dc1ccad5cf97d3b78ce3aec9b4fc73dae"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 33088158,
"name": "weareleaf/leaf-site",
"url": "https://api.github.com/repos/weareleaf/leaf-site"
}
|
{
"id": 7361435,
"login": "chrisannetts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7361435?",
"url": "https://api.github.com/users/chrisannetts"
}
|
{
"id": 11577222,
"login": "weareleaf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11577222?",
"url": "https://api.github.com/orgs/weareleaf"
}
| 2019-12-09T11:17:35 |
11043568001
|
{"actor":{"display_login":"chrisannetts"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia-android/pulls/comments/350472533","pull_request_review_id":322641202,"id":350472533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MDQ3MjUzMw==","diff_hunk":"@@ -146,4 +147,38 @@ class HomeFragmentPresenter @Inject constructor(\n fun onTopicSummaryClicked(topicSummary: TopicSummary) {\n routeToTopicListener.routeToTopic(topicSummary.topicId)\n }\n+\n+ private val ongoingStoryListSummaryResultLiveData: LiveData<AsyncResult<OngoingStoryList>> by lazy {\n+ topicListController.getOngoingStoryList()\n+ }\n+\n+ private fun subscribeToPromotedStoryList() {\n+ getAssumedSuccessfulOngoingStoryList().observe(fragment, Observer<OngoingStoryList> {\n+ if (it.recentStoryCount > 0) {","path":"app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt","position":109,"original_position":109,"commit_id":"73c9f5432cb428293bdcee5358f2fddb23dbd5fa","original_commit_id":"73c9f5432cb428293bdcee5358f2fddb23dbd5fa","user":{"login":"jamesxu0","id":40580399,"node_id":"MDQ6VXNlcjQwNTgwMzk5","avatar_url":"https://avatars3.githubusercontent.com/u/40580399?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesxu0","html_url":"https://github.com/jamesxu0","followers_url":"https://api.github.com/users/jamesxu0/followers","following_url":"https://api.github.com/users/jamesxu0/following{/other_user}","gists_url":"https://api.github.com/users/jamesxu0/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesxu0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesxu0/subscriptions","organizations_url":"https://api.github.com/users/jamesxu0/orgs","repos_url":"https://api.github.com/users/jamesxu0/repos","events_url":"https://api.github.com/users/jamesxu0/events{/privacy}","received_events_url":"https://api.github.com/users/jamesxu0/received_events","type":"User","site_admin":false},"body":"Is this \"if\" check necessary? If recentStoryCount is empty, the for loop shouldn't do anything right? Same for below.","created_at":"2019-11-25T23:17:21Z","updated_at":"2019-11-25T23:25:40Z","html_url":"https://github.com/oppia/oppia-android/pull/473#discussion_r350472533","pull_request_url":"https://api.github.com/repos/oppia/oppia-android/pulls/473","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/comments/350472533"},"html":{"href":"https://github.com/oppia/oppia-android/pull/473#discussion_r350472533"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/473"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia-android/pulls/473","id":345313137,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1MzEzMTM3","html_url":"https://github.com/oppia/oppia-android/pull/473","diff_url":"https://github.com/oppia/oppia-android/pull/473.diff","patch_url":"https://github.com/oppia/oppia-android/pull/473.patch","issue_url":"https://api.github.com/repos/oppia/oppia-android/issues/473","number":473,"state":"open","locked":false,"title":"Fix #389: Home Fragment Carousel [DO NOT MERGE]","user":{"login":"rt4914","id":9396084,"node_id":"MDQ6VXNlcjkzOTYwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9396084?v=4","gravatar_id":"","url":"https://api.github.com/users/rt4914","html_url":"https://github.com/rt4914","followers_url":"https://api.github.com/users/rt4914/followers","following_url":"https://api.github.com/users/rt4914/following{/other_user}","gists_url":"https://api.github.com/users/rt4914/gists{/gist_id}","starred_url":"https://api.github.com/users/rt4914/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rt4914/subscriptions","organizations_url":"https://api.github.com/users/rt4914/orgs","repos_url":"https://api.github.com/users/rt4914/repos","events_url":"https://api.github.com/users/rt4914/events{/privacy}","received_events_url":"https://api.github.com/users/rt4914/received_events","type":"User","site_admin":false},"body":"<!--\r\n - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n - your pull request so we can review your code more easily.\r\n -->\r\n\r\n## Explanation\r\n<!--\r\n - Explain what your PR does. If this PR fixes an existing bug, please include\r\n - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue\r\n - when this PR is merged.\r\n -->\r\n\r\nThis is just a rough implementation of Home Fragment Carousel. Do not check the code quality just focus on the working on HomeFragment.\r\n\r\n\r\n\r\n\r\n## Checklist\r\n<!-- Please tick the relevant boxes by putting an \"x\" in them. -->\r\n- [x] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with \"Fix part of #bugnum: ...\".)\r\n- [x] The PR explanation includes the words \"Fixes #bugnum: ...\" (or \"Fixes part of #bugnum\" if the PR only partially fixes an issue).\r\n- [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).\r\n- [x] The PR does not contain any unnecessary auto-generated code from Android Studio.\r\n- [x] The PR is made from a branch that's **not** called \"develop\".\r\n- [x] The PR is made from a branch that is up-to-date with \"develop\".\r\n- [x] The PR's branch is based on \"develop\" and not on any other branch.\r\n- [x] The PR is **assigned** to an appropriate reviewer in both the **Assignees** and the **Reviewers** sections.\r\n","created_at":"2019-11-25T16:43:08Z","updated_at":"2019-11-25T23:25:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cfb7834156cc6236348bf45a4683b35e10b2b15","assignee":{"login":"seanlip","id":10575562,"node_id":"MDQ6VXNlcjEwNTc1NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"assignees":[{"login":"seanlip","id":10575562,"node_id":"MDQ6VXNlcjEwNTc1NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},{"login":"BenHenning","id":12983742,"node_id":"MDQ6VXNlcjEyOTgzNzQy","avatar_url":"https://avatars3.githubusercontent.com/u/12983742?v=4","gravatar_id":"","url":"https://api.github.com/users/BenHenning","html_url":"https://github.com/BenHenning","followers_url":"https://api.github.com/users/BenHenning/followers","following_url":"https://api.github.com/users/BenHenning/following{/other_user}","gists_url":"https://api.github.com/users/BenHenning/gists{/gist_id}","starred_url":"https://api.github.com/users/BenHenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenHenning/subscriptions","organizations_url":"https://api.github.com/users/BenHenning/orgs","repos_url":"https://api.github.com/users/BenHenning/repos","events_url":"https://api.github.com/users/BenHenning/events{/privacy}","received_events_url":"https://api.github.com/users/BenHenning/received_events","type":"User","site_admin":false},{"login":"veena14cs","id":16301028,"node_id":"MDQ6VXNlcjE2MzAxMDI4","avatar_url":"https://avatars3.githubusercontent.com/u/16301028?v=4","gravatar_id":"","url":"https://api.github.com/users/veena14cs","html_url":"https://github.com/veena14cs","followers_url":"https://api.github.com/users/veena14cs/followers","following_url":"https://api.github.com/users/veena14cs/following{/other_user}","gists_url":"https://api.github.com/users/veena14cs/gists{/gist_id}","starred_url":"https://api.github.com/users/veena14cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veena14cs/subscriptions","organizations_url":"https://api.github.com/users/veena14cs/orgs","repos_url":"https://api.github.com/users/veena14cs/repos","events_url":"https://api.github.com/users/veena14cs/events{/privacy}","received_events_url":"https://api.github.com/users/veena14cs/received_events","type":"User","site_admin":false},{"login":"jamesxu0","id":40580399,"node_id":"MDQ6VXNlcjQwNTgwMzk5","avatar_url":"https://avatars3.githubusercontent.com/u/40580399?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesxu0","html_url":"https://github.com/jamesxu0","followers_url":"https://api.github.com/users/jamesxu0/followers","following_url":"https://api.github.com/users/jamesxu0/following{/other_user}","gists_url":"https://api.github.com/users/jamesxu0/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesxu0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesxu0/subscriptions","organizations_url":"https://api.github.com/users/jamesxu0/orgs","repos_url":"https://api.github.com/users/jamesxu0/repos","events_url":"https://api.github.com/users/jamesxu0/events{/privacy}","received_events_url":"https://api.github.com/users/jamesxu0/received_events","type":"User","site_admin":false},{"login":"nikitamarysolomanpvt","id":54615666,"node_id":"MDQ6VXNlcjU0NjE1NjY2","avatar_url":"https://avatars1.githubusercontent.com/u/54615666?v=4","gravatar_id":"","url":"https://api.github.com/users/nikitamarysolomanpvt","html_url":"https://github.com/nikitamarysolomanpvt","followers_url":"https://api.github.com/users/nikitamarysolomanpvt/followers","following_url":"https://api.github.com/users/nikitamarysolomanpvt/following{/other_user}","gists_url":"https://api.github.com/users/nikitamarysolomanpvt/gists{/gist_id}","starred_url":"https://api.github.com/users/nikitamarysolomanpvt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikitamarysolomanpvt/subscriptions","organizations_url":"https://api.github.com/users/nikitamarysolomanpvt/orgs","repos_url":"https://api.github.com/users/nikitamarysolomanpvt/repos","events_url":"https://api.github.com/users/nikitamarysolomanpvt/events{/privacy}","received_events_url":"https://api.github.com/users/nikitamarysolomanpvt/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"seanlip","id":10575562,"node_id":"MDQ6VXNlcjEwNTc1NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},{"login":"BenHenning","id":12983742,"node_id":"MDQ6VXNlcjEyOTgzNzQy","avatar_url":"https://avatars3.githubusercontent.com/u/12983742?v=4","gravatar_id":"","url":"https://api.github.com/users/BenHenning","html_url":"https://github.com/BenHenning","followers_url":"https://api.github.com/users/BenHenning/followers","following_url":"https://api.github.com/users/BenHenning/following{/other_user}","gists_url":"https://api.github.com/users/BenHenning/gists{/gist_id}","starred_url":"https://api.github.com/users/BenHenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenHenning/subscriptions","organizations_url":"https://api.github.com/users/BenHenning/orgs","repos_url":"https://api.github.com/users/BenHenning/repos","events_url":"https://api.github.com/users/BenHenning/events{/privacy}","received_events_url":"https://api.github.com/users/BenHenning/received_events","type":"User","site_admin":false},{"login":"veena14cs","id":16301028,"node_id":"MDQ6VXNlcjE2MzAxMDI4","avatar_url":"https://avatars3.githubusercontent.com/u/16301028?v=4","gravatar_id":"","url":"https://api.github.com/users/veena14cs","html_url":"https://github.com/veena14cs","followers_url":"https://api.github.com/users/veena14cs/followers","following_url":"https://api.github.com/users/veena14cs/following{/other_user}","gists_url":"https://api.github.com/users/veena14cs/gists{/gist_id}","starred_url":"https://api.github.com/users/veena14cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veena14cs/subscriptions","organizations_url":"https://api.github.com/users/veena14cs/orgs","repos_url":"https://api.github.com/users/veena14cs/repos","events_url":"https://api.github.com/users/veena14cs/events{/privacy}","received_events_url":"https://api.github.com/users/veena14cs/received_events","type":"User","site_admin":false},{"login":"nikitamarysolomanpvt","id":54615666,"node_id":"MDQ6VXNlcjU0NjE1NjY2","avatar_url":"https://avatars1.githubusercontent.com/u/54615666?v=4","gravatar_id":"","url":"https://api.github.com/users/nikitamarysolomanpvt","html_url":"https://github.com/nikitamarysolomanpvt","followers_url":"https://api.github.com/users/nikitamarysolomanpvt/followers","following_url":"https://api.github.com/users/nikitamarysolomanpvt/following{/other_user}","gists_url":"https://api.github.com/users/nikitamarysolomanpvt/gists{/gist_id}","starred_url":"https://api.github.com/users/nikitamarysolomanpvt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikitamarysolomanpvt/subscriptions","organizations_url":"https://api.github.com/users/nikitamarysolomanpvt/orgs","repos_url":"https://api.github.com/users/nikitamarysolomanpvt/repos","events_url":"https://api.github.com/users/nikitamarysolomanpvt/events{/privacy}","received_events_url":"https://api.github.com/users/nikitamarysolomanpvt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia-android/pulls/473/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia-android/pulls/473/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia-android/issues/473/comments","statuses_url":"https://api.github.com/repos/oppia/oppia-android/statuses/73c9f5432cb428293bdcee5358f2fddb23dbd5fa","head":{"label":"oppia:home-low-fi","ref":"home-low-fi","sha":"73c9f5432cb428293bdcee5358f2fddb23dbd5fa","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":148093817,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgwOTM4MTc=","name":"oppia-android","full_name":"oppia/oppia-android","private":false,"owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oppia/oppia-android","description":null,"fork":false,"url":"https://api.github.com/repos/oppia/oppia-android","forks_url":"https://api.github.com/repos/oppia/oppia-android/forks","keys_url":"https://api.github.com/repos/oppia/oppia-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia-android/teams","hooks_url":"https://api.github.com/repos/oppia/oppia-android/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia-android/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia-android/events","assignees_url":"https://api.github.com/repos/oppia/oppia-android/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia-android/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia-android/tags","blobs_url":"https://api.github.com/repos/oppia/oppia-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia-android/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia-android/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia-android/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia-android/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia-android/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia-android/subscription","commits_url":"https://api.github.com/repos/oppia/oppia-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia-android/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia-android/merges","archive_url":"https://api.github.com/repos/oppia/oppia-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia-android/downloads","issues_url":"https://api.github.com/repos/oppia/oppia-android/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia-android/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia-android/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia-android/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia-android/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia-android/deployments","created_at":"2018-09-10T03:25:11Z","updated_at":"2019-11-25T16:00:34Z","pushed_at":"2019-11-25T21:41:42Z","git_url":"git://github.com/oppia/oppia-android.git","ssh_url":"git@github.com:oppia/oppia-android.git","clone_url":"https://github.com/oppia/oppia-android.git","svn_url":"https://github.com/oppia/oppia-android","homepage":null,"size":7020,"stargazers_count":6,"watchers_count":6,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":161,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":161,"watchers":6,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"e3ed84aa46e215a44cb5a785949b89736b53a4bd","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":148093817,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgwOTM4MTc=","name":"oppia-android","full_name":"oppia/oppia-android","private":false,"owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oppia/oppia-android","description":null,"fork":false,"url":"https://api.github.com/repos/oppia/oppia-android","forks_url":"https://api.github.com/repos/oppia/oppia-android/forks","keys_url":"https://api.github.com/repos/oppia/oppia-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia-android/teams","hooks_url":"https://api.github.com/repos/oppia/oppia-android/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia-android/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia-android/events","assignees_url":"https://api.github.com/repos/oppia/oppia-android/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia-android/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia-android/tags","blobs_url":"https://api.github.com/repos/oppia/oppia-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia-android/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia-android/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia-android/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia-android/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia-android/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia-android/subscription","commits_url":"https://api.github.com/repos/oppia/oppia-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia-android/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia-android/merges","archive_url":"https://api.github.com/repos/oppia/oppia-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia-android/downloads","issues_url":"https://api.github.com/repos/oppia/oppia-android/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia-android/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia-android/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia-android/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia-android/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia-android/deployments","created_at":"2018-09-10T03:25:11Z","updated_at":"2019-11-25T16:00:34Z","pushed_at":"2019-11-25T21:41:42Z","git_url":"git://github.com/oppia/oppia-android.git","ssh_url":"git@github.com:oppia/oppia-android.git","clone_url":"https://github.com/oppia/oppia-android.git","svn_url":"https://github.com/oppia/oppia-android","homepage":null,"size":7020,"stargazers_count":6,"watchers_count":6,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":161,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":161,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/473"},"html":{"href":"https://github.com/oppia/oppia-android/pull/473"},"issue":{"href":"https://api.github.com/repos/oppia/oppia-android/issues/473"},"comments":{"href":"https://api.github.com/repos/oppia/oppia-android/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia-android/statuses/73c9f5432cb428293bdcee5358f2fddb23dbd5fa"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 148093817,
"name": "oppia/oppia-android",
"url": "https://api.github.com/repos/oppia/oppia-android"
}
|
{
"id": 40580399,
"login": "jamesxu0",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/40580399?",
"url": "https://api.github.com/users/jamesxu0"
}
|
{
"id": 11620230,
"login": "oppia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11620230?",
"url": "https://api.github.com/orgs/oppia"
}
| 2019-11-25T23:17:21 |
10945625601
|
{"actor":{"display_login":"jamesxu0"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia-android/pulls/comments/326448732","pull_request_review_id":290924610,"id":326448732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjQ0ODczMg==","diff_hunk":"@@ -3,5 +3,8 @@\n <color name=\"colorPrimary\">#008577</color>\n <color name=\"colorPrimaryDark\">#00574B</color>\n <color name=\"colorAccent\">#D81B60</color>\n+ <color name=\"colorIvory\">#FFFFF0</color>","path":"app/src/main/res/values/colors.xml","position":4,"original_position":4,"commit_id":"2cf0ac5edbbcdd574a6c8a0afd28a86add18d69f","original_commit_id":"2cf0ac5edbbcdd574a6c8a0afd28a86add18d69f","user":{"login":"BenHenning","id":12983742,"node_id":"MDQ6VXNlcjEyOTgzNzQy","avatar_url":"https://avatars3.githubusercontent.com/u/12983742?v=4","gravatar_id":"","url":"https://api.github.com/users/BenHenning","html_url":"https://github.com/BenHenning","followers_url":"https://api.github.com/users/BenHenning/followers","following_url":"https://api.github.com/users/BenHenning/following{/other_user}","gists_url":"https://api.github.com/users/BenHenning/gists{/gist_id}","starred_url":"https://api.github.com/users/BenHenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenHenning/subscriptions","organizations_url":"https://api.github.com/users/BenHenning/orgs","repos_url":"https://api.github.com/users/BenHenning/repos","events_url":"https://api.github.com/users/BenHenning/events{/privacy}","received_events_url":"https://api.github.com/users/BenHenning/received_events","type":"User","site_admin":false},"body":"Let's keep colors contextual. I believe we're using this as the concept card dialog background color.","created_at":"2019-09-20T02:14:55Z","updated_at":"2019-09-20T02:24:09Z","html_url":"https://github.com/oppia/oppia-android/pull/148#discussion_r326448732","pull_request_url":"https://api.github.com/repos/oppia/oppia-android/pulls/148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/comments/326448732"},"html":{"href":"https://github.com/oppia/oppia-android/pull/148#discussion_r326448732"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/148"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia-android/pulls/148","id":319458888,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5NDU4ODg4","html_url":"https://github.com/oppia/oppia-android/pull/148","diff_url":"https://github.com/oppia/oppia-android/pull/148.diff","patch_url":"https://github.com/oppia/oppia-android/pull/148.patch","issue_url":"https://api.github.com/repos/oppia/oppia-android/issues/148","number":148,"state":"open","locked":false,"title":"Fixes part 1 of #24: initial structure for Concept Card","user":{"login":"jamesxu0","id":40580399,"node_id":"MDQ6VXNlcjQwNTgwMzk5","avatar_url":"https://avatars3.githubusercontent.com/u/40580399?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesxu0","html_url":"https://github.com/jamesxu0","followers_url":"https://api.github.com/users/jamesxu0/followers","following_url":"https://api.github.com/users/jamesxu0/following{/other_user}","gists_url":"https://api.github.com/users/jamesxu0/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesxu0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesxu0/subscriptions","organizations_url":"https://api.github.com/users/jamesxu0/orgs","repos_url":"https://api.github.com/users/jamesxu0/repos","events_url":"https://api.github.com/users/jamesxu0/events{/privacy}","received_events_url":"https://api.github.com/users/jamesxu0/received_events","type":"User","site_admin":false},"body":"<!--\r\n - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n - your pull request so we can review your code more easily.\r\n -->\r\n\r\n## Explanation\r\n<!--\r\n - Explain what your PR does. If this PR fixes an existing bug, please include\r\n - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue\r\n - when this PR is merged.\r\n -->\r\n\r\nIntroduces the initial structure of the concept card with correct sliding animations.\r\n\r\n## Checklist\r\n<!-- Please tick the relevant boxes by putting an \"x\" in them. -->\r\n- [x] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with \"Fix part of #bugnum: ...\".)\r\n- [x] The PR explanation includes the words \"Fixes #bugnum: ...\" (or \"Fixes part of #bugnum\" if the PR only partially fixes an issue).\r\n- [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).\r\n- [x] The PR does not contain any unnecessary auto-generated code from Android Studio.\r\n- [x] The PR is made from a branch that's **not** called \"develop\".\r\n- [x] The PR is **assigned** to an appropriate reviewer.\r\n","created_at":"2019-09-19T20:54:58Z","updated_at":"2019-09-20T02:24:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"BenHenning","id":12983742,"node_id":"MDQ6VXNlcjEyOTgzNzQy","avatar_url":"https://avatars3.githubusercontent.com/u/12983742?v=4","gravatar_id":"","url":"https://api.github.com/users/BenHenning","html_url":"https://github.com/BenHenning","followers_url":"https://api.github.com/users/BenHenning/followers","following_url":"https://api.github.com/users/BenHenning/following{/other_user}","gists_url":"https://api.github.com/users/BenHenning/gists{/gist_id}","starred_url":"https://api.github.com/users/BenHenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenHenning/subscriptions","organizations_url":"https://api.github.com/users/BenHenning/orgs","repos_url":"https://api.github.com/users/BenHenning/repos","events_url":"https://api.github.com/users/BenHenning/events{/privacy}","received_events_url":"https://api.github.com/users/BenHenning/received_events","type":"User","site_admin":false},"assignees":[{"login":"BenHenning","id":12983742,"node_id":"MDQ6VXNlcjEyOTgzNzQy","avatar_url":"https://avatars3.githubusercontent.com/u/12983742?v=4","gravatar_id":"","url":"https://api.github.com/users/BenHenning","html_url":"https://github.com/BenHenning","followers_url":"https://api.github.com/users/BenHenning/followers","following_url":"https://api.github.com/users/BenHenning/following{/other_user}","gists_url":"https://api.github.com/users/BenHenning/gists{/gist_id}","starred_url":"https://api.github.com/users/BenHenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenHenning/subscriptions","organizations_url":"https://api.github.com/users/BenHenning/orgs","repos_url":"https://api.github.com/users/BenHenning/repos","events_url":"https://api.github.com/users/BenHenning/events{/privacy}","received_events_url":"https://api.github.com/users/BenHenning/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia-android/pulls/148/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia-android/pulls/148/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia-android/issues/148/comments","statuses_url":"https://api.github.com/repos/oppia/oppia-android/statuses/2cf0ac5edbbcdd574a6c8a0afd28a86add18d69f","head":{"label":"oppia:concept-card","ref":"concept-card","sha":"2cf0ac5edbbcdd574a6c8a0afd28a86add18d69f","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":148093817,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgwOTM4MTc=","name":"oppia-android","full_name":"oppia/oppia-android","private":false,"owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oppia/oppia-android","description":null,"fork":false,"url":"https://api.github.com/repos/oppia/oppia-android","forks_url":"https://api.github.com/repos/oppia/oppia-android/forks","keys_url":"https://api.github.com/repos/oppia/oppia-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia-android/teams","hooks_url":"https://api.github.com/repos/oppia/oppia-android/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia-android/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia-android/events","assignees_url":"https://api.github.com/repos/oppia/oppia-android/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia-android/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia-android/tags","blobs_url":"https://api.github.com/repos/oppia/oppia-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia-android/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia-android/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia-android/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia-android/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia-android/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia-android/subscription","commits_url":"https://api.github.com/repos/oppia/oppia-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia-android/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia-android/merges","archive_url":"https://api.github.com/repos/oppia/oppia-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia-android/downloads","issues_url":"https://api.github.com/repos/oppia/oppia-android/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia-android/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia-android/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia-android/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia-android/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia-android/deployments","created_at":"2018-09-10T03:25:11Z","updated_at":"2019-09-19T09:36:18Z","pushed_at":"2019-09-19T23:53:33Z","git_url":"git://github.com/oppia/oppia-android.git","ssh_url":"git@github.com:oppia/oppia-android.git","clone_url":"https://github.com/oppia/oppia-android.git","svn_url":"https://github.com/oppia/oppia-android","homepage":null,"size":4700,"stargazers_count":2,"watchers_count":2,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":99,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":99,"watchers":2,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"6f7b14645cb12d9e298c5e9355186fe4dcb5e7d2","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":148093817,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgwOTM4MTc=","name":"oppia-android","full_name":"oppia/oppia-android","private":false,"owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oppia/oppia-android","description":null,"fork":false,"url":"https://api.github.com/repos/oppia/oppia-android","forks_url":"https://api.github.com/repos/oppia/oppia-android/forks","keys_url":"https://api.github.com/repos/oppia/oppia-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia-android/teams","hooks_url":"https://api.github.com/repos/oppia/oppia-android/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia-android/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia-android/events","assignees_url":"https://api.github.com/repos/oppia/oppia-android/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia-android/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia-android/tags","blobs_url":"https://api.github.com/repos/oppia/oppia-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia-android/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia-android/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia-android/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia-android/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia-android/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia-android/subscription","commits_url":"https://api.github.com/repos/oppia/oppia-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia-android/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia-android/merges","archive_url":"https://api.github.com/repos/oppia/oppia-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia-android/downloads","issues_url":"https://api.github.com/repos/oppia/oppia-android/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia-android/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia-android/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia-android/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia-android/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia-android/deployments","created_at":"2018-09-10T03:25:11Z","updated_at":"2019-09-19T09:36:18Z","pushed_at":"2019-09-19T23:53:33Z","git_url":"git://github.com/oppia/oppia-android.git","ssh_url":"git@github.com:oppia/oppia-android.git","clone_url":"https://github.com/oppia/oppia-android.git","svn_url":"https://github.com/oppia/oppia-android","homepage":null,"size":4700,"stargazers_count":2,"watchers_count":2,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":99,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":99,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/148"},"html":{"href":"https://github.com/oppia/oppia-android/pull/148"},"issue":{"href":"https://api.github.com/repos/oppia/oppia-android/issues/148"},"comments":{"href":"https://api.github.com/repos/oppia/oppia-android/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia-android/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia-android/statuses/2cf0ac5edbbcdd574a6c8a0afd28a86add18d69f"}},"author_association":"NONE"}}
|
{
"id": 148093817,
"name": "oppia/oppia-android",
"url": "https://api.github.com/repos/oppia/oppia-android"
}
|
{
"id": 12983742,
"login": "BenHenning",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12983742?",
"url": "https://api.github.com/users/BenHenning"
}
|
{
"id": 11620230,
"login": "oppia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11620230?",
"url": "https://api.github.com/orgs/oppia"
}
| 2019-09-20T02:14:55 |
10456728620
|
{"actor":{"display_login":"BenHenning"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gtk-rs/examples/pulls/comments/296449943","pull_request_review_id":253099906,"id":296449943,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjQ0OTk0Mw==","diff_hunk":"@@ -7,24 +7,45 @@ autobins = false\n [dependencies]\n chrono = \"0.4\"\n url = \"1.4\"\n-futures-preview = { version = \"0.2\", optional = true }\n-atk = \"^0\"\n-glib-sys = \"^0\"\n-gobject-sys = \"^0\"\n-glib = \"^0\"\n-gio = \"^0\"\n-gdk = \"^0\"\n-gdk-pixbuf = \"^0\"\n-gtk = \"^0\"\n-pango = \"^0\"\n-cairo-rs = { version = \"^0\", features = [\"png\"] }\n+futures-preview = { version = \"0.3.0-alpha.15\", optional = true}","path":"Cargo.toml","position":15,"original_position":15,"commit_id":"d773d14dc2a094ae8eb500f73f5d48a83262dc87","original_commit_id":"d773d14dc2a094ae8eb500f73f5d48a83262dc87","user":{"login":"GuillaumeGomez","id":3050060,"node_id":"MDQ6VXNlcjMwNTAwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3050060?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"body":"Don't worry, I got it. ;)","created_at":"2019-06-22T16:05:16Z","updated_at":"2019-06-22T16:05:16Z","html_url":"https://github.com/gtk-rs/examples/pull/251#discussion_r296449943","pull_request_url":"https://api.github.com/repos/gtk-rs/examples/pulls/251","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gtk-rs/examples/pulls/comments/296449943"},"html":{"href":"https://github.com/gtk-rs/examples/pull/251#discussion_r296449943"},"pull_request":{"href":"https://api.github.com/repos/gtk-rs/examples/pulls/251"}},"in_reply_to_id":296449866},"pull_request":{"url":"https://api.github.com/repos/gtk-rs/examples/pulls/251","id":290832001,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwODMyMDAx","html_url":"https://github.com/gtk-rs/examples/pull/251","diff_url":"https://github.com/gtk-rs/examples/pull/251.diff","patch_url":"https://github.com/gtk-rs/examples/pull/251.patch","issue_url":"https://api.github.com/repos/gtk-rs/examples/issues/251","number":251,"state":"open","locked":false,"title":"[release] merging pending into master","user":{"login":"GuillaumeGomez","id":3050060,"node_id":"MDQ6VXNlcjMwNTAwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3050060?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"body":"cc @GuillaumeGomez @EPashkin @sdroege","created_at":"2019-06-22T15:57:49Z","updated_at":"2019-06-22T16:05:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45c6186f673c2574b327ddc2f1d0eecbfd8ff6be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gtk-rs/examples/pulls/251/commits","review_comments_url":"https://api.github.com/repos/gtk-rs/examples/pulls/251/comments","review_comment_url":"https://api.github.com/repos/gtk-rs/examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gtk-rs/examples/issues/251/comments","statuses_url":"https://api.github.com/repos/gtk-rs/examples/statuses/d773d14dc2a094ae8eb500f73f5d48a83262dc87","head":{"label":"gtk-rs:pending","ref":"pending","sha":"d773d14dc2a094ae8eb500f73f5d48a83262dc87","user":{"login":"gtk-rs","id":11757045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzU3MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/11757045?v=4","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":34350235,"node_id":"MDEwOlJlcG9zaXRvcnkzNDM1MDIzNQ==","name":"examples","full_name":"gtk-rs/examples","private":false,"owner":{"login":"gtk-rs","id":11757045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzU3MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/11757045?v=4","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gtk-rs/examples","description":"gtk-rs examples","fork":false,"url":"https://api.github.com/repos/gtk-rs/examples","forks_url":"https://api.github.com/repos/gtk-rs/examples/forks","keys_url":"https://api.github.com/repos/gtk-rs/examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtk-rs/examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtk-rs/examples/teams","hooks_url":"https://api.github.com/repos/gtk-rs/examples/hooks","issue_events_url":"https://api.github.com/repos/gtk-rs/examples/issues/events{/number}","events_url":"https://api.github.com/repos/gtk-rs/examples/events","assignees_url":"https://api.github.com/repos/gtk-rs/examples/assignees{/user}","branches_url":"https://api.github.com/repos/gtk-rs/examples/branches{/branch}","tags_url":"https://api.github.com/repos/gtk-rs/examples/tags","blobs_url":"https://api.github.com/repos/gtk-rs/examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtk-rs/examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtk-rs/examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtk-rs/examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtk-rs/examples/statuses/{sha}","languages_url":"https://api.github.com/repos/gtk-rs/examples/languages","stargazers_url":"https://api.github.com/repos/gtk-rs/examples/stargazers","contributors_url":"https://api.github.com/repos/gtk-rs/examples/contributors","subscribers_url":"https://api.github.com/repos/gtk-rs/examples/subscribers","subscription_url":"https://api.github.com/repos/gtk-rs/examples/subscription","commits_url":"https://api.github.com/repos/gtk-rs/examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtk-rs/examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtk-rs/examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtk-rs/examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtk-rs/examples/contents/{+path}","compare_url":"https://api.github.com/repos/gtk-rs/examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtk-rs/examples/merges","archive_url":"https://api.github.com/repos/gtk-rs/examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtk-rs/examples/downloads","issues_url":"https://api.github.com/repos/gtk-rs/examples/issues{/number}","pulls_url":"https://api.github.com/repos/gtk-rs/examples/pulls{/number}","milestones_url":"https://api.github.com/repos/gtk-rs/examples/milestones{/number}","notifications_url":"https://api.github.com/repos/gtk-rs/examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtk-rs/examples/labels{/name}","releases_url":"https://api.github.com/repos/gtk-rs/examples/releases{/id}","deployments_url":"https://api.github.com/repos/gtk-rs/examples/deployments","created_at":"2015-04-21T20:21:37Z","updated_at":"2019-06-20T20:22:52Z","pushed_at":"2019-06-22T15:57:49Z","git_url":"git://github.com/gtk-rs/examples.git","ssh_url":"git@github.com:gtk-rs/examples.git","clone_url":"https://github.com/gtk-rs/examples.git","svn_url":"https://github.com/gtk-rs/examples","homepage":"","size":352,"stargazers_count":171,"watchers_count":171,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":40,"open_issues":20,"watchers":171,"default_branch":"master"}},"base":{"label":"gtk-rs:master","ref":"master","sha":"e36340da8ab7a879493bb6493689540b83123a25","user":{"login":"gtk-rs","id":11757045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzU3MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/11757045?v=4","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":34350235,"node_id":"MDEwOlJlcG9zaXRvcnkzNDM1MDIzNQ==","name":"examples","full_name":"gtk-rs/examples","private":false,"owner":{"login":"gtk-rs","id":11757045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzU3MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/11757045?v=4","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gtk-rs/examples","description":"gtk-rs examples","fork":false,"url":"https://api.github.com/repos/gtk-rs/examples","forks_url":"https://api.github.com/repos/gtk-rs/examples/forks","keys_url":"https://api.github.com/repos/gtk-rs/examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtk-rs/examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtk-rs/examples/teams","hooks_url":"https://api.github.com/repos/gtk-rs/examples/hooks","issue_events_url":"https://api.github.com/repos/gtk-rs/examples/issues/events{/number}","events_url":"https://api.github.com/repos/gtk-rs/examples/events","assignees_url":"https://api.github.com/repos/gtk-rs/examples/assignees{/user}","branches_url":"https://api.github.com/repos/gtk-rs/examples/branches{/branch}","tags_url":"https://api.github.com/repos/gtk-rs/examples/tags","blobs_url":"https://api.github.com/repos/gtk-rs/examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtk-rs/examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtk-rs/examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtk-rs/examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtk-rs/examples/statuses/{sha}","languages_url":"https://api.github.com/repos/gtk-rs/examples/languages","stargazers_url":"https://api.github.com/repos/gtk-rs/examples/stargazers","contributors_url":"https://api.github.com/repos/gtk-rs/examples/contributors","subscribers_url":"https://api.github.com/repos/gtk-rs/examples/subscribers","subscription_url":"https://api.github.com/repos/gtk-rs/examples/subscription","commits_url":"https://api.github.com/repos/gtk-rs/examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtk-rs/examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtk-rs/examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtk-rs/examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtk-rs/examples/contents/{+path}","compare_url":"https://api.github.com/repos/gtk-rs/examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtk-rs/examples/merges","archive_url":"https://api.github.com/repos/gtk-rs/examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtk-rs/examples/downloads","issues_url":"https://api.github.com/repos/gtk-rs/examples/issues{/number}","pulls_url":"https://api.github.com/repos/gtk-rs/examples/pulls{/number}","milestones_url":"https://api.github.com/repos/gtk-rs/examples/milestones{/number}","notifications_url":"https://api.github.com/repos/gtk-rs/examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtk-rs/examples/labels{/name}","releases_url":"https://api.github.com/repos/gtk-rs/examples/releases{/id}","deployments_url":"https://api.github.com/repos/gtk-rs/examples/deployments","created_at":"2015-04-21T20:21:37Z","updated_at":"2019-06-20T20:22:52Z","pushed_at":"2019-06-22T15:57:49Z","git_url":"git://github.com/gtk-rs/examples.git","ssh_url":"git@github.com:gtk-rs/examples.git","clone_url":"https://github.com/gtk-rs/examples.git","svn_url":"https://github.com/gtk-rs/examples","homepage":"","size":352,"stargazers_count":171,"watchers_count":171,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":40,"open_issues":20,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gtk-rs/examples/pulls/251"},"html":{"href":"https://github.com/gtk-rs/examples/pull/251"},"issue":{"href":"https://api.github.com/repos/gtk-rs/examples/issues/251"},"comments":{"href":"https://api.github.com/repos/gtk-rs/examples/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/gtk-rs/examples/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/gtk-rs/examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gtk-rs/examples/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/gtk-rs/examples/statuses/d773d14dc2a094ae8eb500f73f5d48a83262dc87"}},"author_association":"MEMBER"}}
|
{
"id": 34350235,
"name": "gtk-rs/examples",
"url": "https://api.github.com/repos/gtk-rs/examples"
}
|
{
"id": 3050060,
"login": "GuillaumeGomez",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3050060?",
"url": "https://api.github.com/users/GuillaumeGomez"
}
|
{
"id": 11757045,
"login": "gtk-rs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11757045?",
"url": "https://api.github.com/orgs/gtk-rs"
}
| 2019-06-22T16:05:16 |
9873624051
|
{"actor":{"display_login":"GuillaumeGomez"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/297032427","pull_request_review_id":253802972,"id":297032427,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzAzMjQyNw==","diff_hunk":"@@ -163,32 +163,114 @@ func checkPartitionNameUnique(tbInfo *model.TableInfo, pi *model.PartitionInfo)\n \treturn nil\n }\n \n+// For partition tables, mysql do not support Constant, random or timezone-dependent expressions\n+// Based on mysql code to check whether field is valid, every time related type has check_valid_arguments_processor function.\n+// See https://github.com/mysql/mysql-server/blob/5.7/sql/item_timefunc\n+type isTimezoneDependentProcessor func(columns []*expression.Column) bool\n+\n+// See https://github.com/mysql/mysql-server/blob/5.7/sql/item_func.h#L387\n+func hasTimestampField(columns []*expression.Column) bool {\n+\tfor _, c := range columns {\n+\t\tif c.GetType().Tp == mysql.TypeTimestamp {\n+\t\t\treturn true\n+\t\t}\n+\t}\n+\n+\treturn false\n+}\n+\n+// See https://github.com/mysql/mysql-server/blob/5.7/sql/item_func.h#L399\n+func hasDateField(columns []*expression.Column) bool {\n+\tfor _, c := range columns {\n+\t\tif c.GetType().Tp == mysql.TypeDate || c.GetType().Tp == mysql.TypeDatetime {\n+\t\t\treturn true\n+\t\t}\n+\t}\n+\n+\treturn false\n+}\n+\n+// See https://github.com/mysql/mysql-server/blob/5.7/sql/item_func.h#L412\n+func hasTimeField(columns []*expression.Column) bool {\n+\tfor _, c := range columns {\n+\t\tif c.GetType().Tp == mysql.TypeDatetime {","path":"ddl/partition.go","position":34,"original_position":34,"commit_id":"07b8672dc68f0bb3c7685ceae27b551e06462ffd","original_commit_id":"07b8672dc68f0bb3c7685ceae27b551e06462ffd","user":{"login":"qiffang","id":7285248,"node_id":"MDQ6VXNlcjcyODUyNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7285248?v=4","gravatar_id":"","url":"https://api.github.com/users/qiffang","html_url":"https://github.com/qiffang","followers_url":"https://api.github.com/users/qiffang/followers","following_url":"https://api.github.com/users/qiffang/following{/other_user}","gists_url":"https://api.github.com/users/qiffang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiffang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiffang/subscriptions","organizations_url":"https://api.github.com/users/qiffang/orgs","repos_url":"https://api.github.com/users/qiffang/repos","events_url":"https://api.github.com/users/qiffang/events{/privacy}","received_events_url":"https://api.github.com/users/qiffang/received_events","type":"User","site_admin":false},"body":"Got it, thanks.","created_at":"2019-06-25T06:57:46Z","updated_at":"2019-06-25T06:57:47Z","html_url":"https://github.com/pingcap/tidb/pull/10655#discussion_r297032427","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/10655","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/297032427"},"html":{"href":"https://github.com/pingcap/tidb/pull/10655#discussion_r297032427"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/10655"}},"in_reply_to_id":296440833},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/10655","id":283611554,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzNjExNTU0","html_url":"https://github.com/pingcap/tidb/pull/10655","diff_url":"https://github.com/pingcap/tidb/pull/10655.diff","patch_url":"https://github.com/pingcap/tidb/pull/10655.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/10655","number":10655,"state":"open","locked":false,"title":"ddl: constant or timezone-dependent expressions in partition should not be allowed","user":{"login":"qiffang","id":7285248,"node_id":"MDQ6VXNlcjcyODUyNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7285248?v=4","gravatar_id":"","url":"https://api.github.com/users/qiffang","html_url":"https://github.com/qiffang","followers_url":"https://api.github.com/users/qiffang/followers","following_url":"https://api.github.com/users/qiffang/following{/other_user}","gists_url":"https://api.github.com/users/qiffang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiffang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiffang/subscriptions","organizations_url":"https://api.github.com/users/qiffang/orgs","repos_url":"https://api.github.com/users/qiffang/repos","events_url":"https://api.github.com/users/qiffang/events{/privacy}","received_events_url":"https://api.github.com/users/qiffang/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\nMysql do not allow Constant, random or timezone-dependent expressions in partitioning function.\r\nBut TiDB do not check whether the field is legal \r\nIf TiDB do not check the field, there will be the same bug - https://bugs.mysql.com/bug.php?id=50036 (MySQL has fixed long before)\r\n\r\n```\r\ncreate table t1(time_recorded timestamp) PARTITION BY RANGE ( TO_DAYS(time_recorded) ) (PARTITION P0 VALUES LESS THAN (1559192604))\r\n\r\ncreate table t2(id int) partition by range(DAY(id)) (partition p1 values less than (10));\r\n\r\ncreate table t3(id int) partition by range(4) (partition p1 values less than (10));\r\n\r\ncreate table t4(id int) partition by hash(4) partitions 4;\r\n....\r\n``` \r\nThe above statements can not be executed in Mysql because of **Constant, random or timezone-dependent expressions in (sub)partitioning function are not allowed**, but they can be executed in TiDB.\r\n\r\n### What is changed and how it works?\r\nTranslate MySQL code to TiDB\r\nhttps://github.com/mysql/mysql-server/blob/5.7/sql/sql_partition.cc#L1072\r\nhttps://github.com/mysql/mysql-server/blob/5.7/sql/item_timefunc.h#L343\r\nhttps://github.com/mysql/mysql-server/blob/5.7/sql/item_func.h#L445\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test\r\n partition_test.go which is existed works well\r\n - Manual test (add detailed scripts or steps below)\r\n TiDB has the same action with MySQL.When I execute the above statements, they can not be executed because of Constant, random or timezone-dependent expressions in (sub)partitioning function are not allowed\r\n","created_at":"2019-05-30T11:04:36Z","updated_at":"2019-06-25T06:57:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"686d3995ba7a835263a74f9ade126b6d7cc62294","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":770872605,"node_id":"MDU6TGFiZWw3NzA4NzI2MDU=","url":"https://api.github.com/repos/pingcap/tidb/labels/status/all%20tests%20passed","name":"status/all tests passed","color":"2cbe4e","default":false},{"id":630229257,"node_id":"MDU6TGFiZWw2MzAyMjkyNTc=","url":"https://api.github.com/repos/pingcap/tidb/labels/type/bug-fix","name":"type/bug-fix","color":"fc2929","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/10655/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/10655/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/10655/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/07b8672dc68f0bb3c7685ceae27b551e06462ffd","head":{"label":"pingcap:Table-Partition-Issue-AS-MYSQL-BUG/42849","ref":"Table-Partition-Issue-AS-MYSQL-BUG/42849","sha":"07b8672dc68f0bb3c7685ceae27b551e06462ffd","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2019-06-25T06:54:02Z","pushed_at":"2019-06-25T06:38:37Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":134317,"stargazers_count":19290,"watchers_count":19290,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2805,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":904,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2805,"open_issues":904,"watchers":19290,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"ae58fd01f11117c6a8ad3489c825665afa79ccce","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2019-06-25T06:54:02Z","pushed_at":"2019-06-25T06:38:37Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":134317,"stargazers_count":19290,"watchers_count":19290,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2805,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":904,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2805,"open_issues":904,"watchers":19290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/10655"},"html":{"href":"https://github.com/pingcap/tidb/pull/10655"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/10655"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/10655/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/10655/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/10655/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/07b8672dc68f0bb3c7685ceae27b551e06462ffd"}},"author_association":"NONE"}}
|
{
"id": 41986369,
"name": "pingcap/tidb",
"url": "https://api.github.com/repos/pingcap/tidb"
}
|
{
"id": 7285248,
"login": "qiffang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7285248?",
"url": "https://api.github.com/users/qiffang"
}
|
{
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
}
| 2019-06-25T06:57:46 |
9886517808
|
{"actor":{"display_login":"qiffang"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/dm/pulls/comments/352067461","pull_request_review_id":324632465,"id":352067461,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjA2NzQ2MQ==","diff_hunk":"@@ -516,3 +529,21 @@ func (c *TaskConfig) SubTaskConfigs(sources map[string]DBConfig) ([]*SubTaskConf\n \t}\n \treturn cfgs, nil\n }\n+\n+// checkDuplicateString checks whether the given string array has duplicate string item\n+// if there is duplicate, it will return **all** the duplicate strings\n+func checkDuplicateString(ruleNames []string) []string {\n+\tmp := make(map[string]bool, len(ruleNames))\n+\tdupeArray := make([]string, 0)\n+\tfor _, name := range ruleNames {\n+\t\tif added, ok := mp[name]; ok {\n+\t\t\tif !added {","path":"dm/config/task.go","position":47,"original_position":47,"commit_id":"e29a9152217086d0f4de6c6ef58546084e073954","original_commit_id":"e29a9152217086d0f4de6c6ef58546084e073954","user":{"login":"WangXiangUSTC","id":5793595,"node_id":"MDQ6VXNlcjU3OTM1OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5793595?v=4","gravatar_id":"","url":"https://api.github.com/users/WangXiangUSTC","html_url":"https://github.com/WangXiangUSTC","followers_url":"https://api.github.com/users/WangXiangUSTC/followers","following_url":"https://api.github.com/users/WangXiangUSTC/following{/other_user}","gists_url":"https://api.github.com/users/WangXiangUSTC/gists{/gist_id}","starred_url":"https://api.github.com/users/WangXiangUSTC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WangXiangUSTC/subscriptions","organizations_url":"https://api.github.com/users/WangXiangUSTC/orgs","repos_url":"https://api.github.com/users/WangXiangUSTC/repos","events_url":"https://api.github.com/users/WangXiangUSTC/events{/privacy}","received_events_url":"https://api.github.com/users/WangXiangUSTC/received_events","type":"User","site_admin":false},"body":"seems that don't need judge `added`, if `ok` is true means this `ruleName` is duplicate ","created_at":"2019-11-29T10:21:41Z","updated_at":"2019-11-29T10:21:41Z","html_url":"https://github.com/pingcap/dm/pull/380#discussion_r352067461","pull_request_url":"https://api.github.com/repos/pingcap/dm/pulls/380","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/dm/pulls/comments/352067461"},"html":{"href":"https://github.com/pingcap/dm/pull/380#discussion_r352067461"},"pull_request":{"href":"https://api.github.com/repos/pingcap/dm/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/dm/pulls/380","id":346566044,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2NTY2MDQ0","html_url":"https://github.com/pingcap/dm/pull/380","diff_url":"https://github.com/pingcap/dm/pull/380.diff","patch_url":"https://github.com/pingcap/dm/pull/380.patch","issue_url":"https://api.github.com/repos/pingcap/dm/issues/380","number":380,"state":"open","locked":false,"title":"config/task: add check for duplicate config items","user":{"login":"lichunzhu","id":21104942,"node_id":"MDQ6VXNlcjIxMTA0OTQy","avatar_url":"https://avatars2.githubusercontent.com/u/21104942?v=4","gravatar_id":"","url":"https://api.github.com/users/lichunzhu","html_url":"https://github.com/lichunzhu","followers_url":"https://api.github.com/users/lichunzhu/followers","following_url":"https://api.github.com/users/lichunzhu/following{/other_user}","gists_url":"https://api.github.com/users/lichunzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/lichunzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichunzhu/subscriptions","organizations_url":"https://api.github.com/users/lichunzhu/orgs","repos_url":"https://api.github.com/users/lichunzhu/repos","events_url":"https://api.github.com/users/lichunzhu/events{/privacy}","received_events_url":"https://api.github.com/users/lichunzhu/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to DM! Please read MD's [CONTRIBUTING](https://github.com/pingcap/dm/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\nThe user may add duplicate route-rules or filter-rules by mistake which will cause failure while building router or event-filter.\r\ne.g.: route-rules: [\"route-rule-1\", \"route-rule-1\"]\r\n\r\n### What is changed and how it works?\r\nAdd check in `TaskConfig.adjust` and returns error if route-rules/filter-rules are duplicate.\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test\r\n - Integration test\r\n\r\nRelated changes\r\n\r\n - Need to cherry-pick to the release branch\r\n","created_at":"2019-11-28T07:53:33Z","updated_at":"2019-11-29T10:21:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45e7a073e0758fb971f68920d1809bac959c4a59","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1195099890,"node_id":"MDU6TGFiZWwxMTk1MDk5ODkw","url":"https://api.github.com/repos/pingcap/dm/labels/priority/normal","name":"priority/normal","color":"FF7F50","default":false,"description":"Minor change, requires approval from ≥1 primary reviewer"},{"id":1540156461,"node_id":"MDU6TGFiZWwxNTQwMTU2NDYx","url":"https://api.github.com/repos/pingcap/dm/labels/should-cherry-pick-1.0","name":"should-cherry-pick-1.0","color":"d93f0b","default":false,"description":"This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0"},{"id":1544576032,"node_id":"MDU6TGFiZWwxNTQ0NTc2MDMy","url":"https://api.github.com/repos/pingcap/dm/labels/should-update-release-note","name":"should-update-release-note","color":"b60205","default":false,"description":"This PR should be added into release notes. Remove this label once the release notes are updated"},{"id":1195099895,"node_id":"MDU6TGFiZWwxMTk1MDk5ODk1","url":"https://api.github.com/repos/pingcap/dm/labels/status/LGT1","name":"status/LGT1","color":"d4c5f9","default":false,"description":"One reviewer already commented LGTM"}],"milestone":{"url":"https://api.github.com/repos/pingcap/dm/milestones/1","html_url":"https://github.com/pingcap/dm/milestone/1","labels_url":"https://api.github.com/repos/pingcap/dm/milestones/1/labels","id":4869678,"node_id":"MDk6TWlsZXN0b25lNDg2OTY3OA==","number":1,"title":"v1.0.3","description":"","creator":{"login":"ericsyh","id":10498732,"node_id":"MDQ6VXNlcjEwNDk4NzMy","avatar_url":"https://avatars3.githubusercontent.com/u/10498732?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsyh","html_url":"https://github.com/ericsyh","followers_url":"https://api.github.com/users/ericsyh/followers","following_url":"https://api.github.com/users/ericsyh/following{/other_user}","gists_url":"https://api.github.com/users/ericsyh/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsyh/subscriptions","organizations_url":"https://api.github.com/users/ericsyh/orgs","repos_url":"https://api.github.com/users/ericsyh/repos","events_url":"https://api.github.com/users/ericsyh/events{/privacy}","received_events_url":"https://api.github.com/users/ericsyh/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":14,"state":"open","created_at":"2019-11-22T13:10:29Z","updated_at":"2019-11-29T09:56:19Z","due_on":"2019-12-06T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pingcap/dm/pulls/380/commits","review_comments_url":"https://api.github.com/repos/pingcap/dm/pulls/380/comments","review_comment_url":"https://api.github.com/repos/pingcap/dm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/dm/issues/380/comments","statuses_url":"https://api.github.com/repos/pingcap/dm/statuses/e29a9152217086d0f4de6c6ef58546084e073954","head":{"label":"lichunzhu:czli/addCheckDuplicateConfigItem","ref":"czli/addCheckDuplicateConfigItem","sha":"e29a9152217086d0f4de6c6ef58546084e073954","user":{"login":"lichunzhu","id":21104942,"node_id":"MDQ6VXNlcjIxMTA0OTQy","avatar_url":"https://avatars2.githubusercontent.com/u/21104942?v=4","gravatar_id":"","url":"https://api.github.com/users/lichunzhu","html_url":"https://github.com/lichunzhu","followers_url":"https://api.github.com/users/lichunzhu/followers","following_url":"https://api.github.com/users/lichunzhu/following{/other_user}","gists_url":"https://api.github.com/users/lichunzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/lichunzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichunzhu/subscriptions","organizations_url":"https://api.github.com/users/lichunzhu/orgs","repos_url":"https://api.github.com/users/lichunzhu/repos","events_url":"https://api.github.com/users/lichunzhu/events{/privacy}","received_events_url":"https://api.github.com/users/lichunzhu/received_events","type":"User","site_admin":false},"repo":{"id":210590939,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA1OTA5Mzk=","name":"dm","full_name":"lichunzhu/dm","private":false,"owner":{"login":"lichunzhu","id":21104942,"node_id":"MDQ6VXNlcjIxMTA0OTQy","avatar_url":"https://avatars2.githubusercontent.com/u/21104942?v=4","gravatar_id":"","url":"https://api.github.com/users/lichunzhu","html_url":"https://github.com/lichunzhu","followers_url":"https://api.github.com/users/lichunzhu/followers","following_url":"https://api.github.com/users/lichunzhu/following{/other_user}","gists_url":"https://api.github.com/users/lichunzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/lichunzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichunzhu/subscriptions","organizations_url":"https://api.github.com/users/lichunzhu/orgs","repos_url":"https://api.github.com/users/lichunzhu/repos","events_url":"https://api.github.com/users/lichunzhu/events{/privacy}","received_events_url":"https://api.github.com/users/lichunzhu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lichunzhu/dm","description":"Data Migration Platform","fork":true,"url":"https://api.github.com/repos/lichunzhu/dm","forks_url":"https://api.github.com/repos/lichunzhu/dm/forks","keys_url":"https://api.github.com/repos/lichunzhu/dm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lichunzhu/dm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lichunzhu/dm/teams","hooks_url":"https://api.github.com/repos/lichunzhu/dm/hooks","issue_events_url":"https://api.github.com/repos/lichunzhu/dm/issues/events{/number}","events_url":"https://api.github.com/repos/lichunzhu/dm/events","assignees_url":"https://api.github.com/repos/lichunzhu/dm/assignees{/user}","branches_url":"https://api.github.com/repos/lichunzhu/dm/branches{/branch}","tags_url":"https://api.github.com/repos/lichunzhu/dm/tags","blobs_url":"https://api.github.com/repos/lichunzhu/dm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lichunzhu/dm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lichunzhu/dm/git/refs{/sha}","trees_url":"https://api.github.com/repos/lichunzhu/dm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lichunzhu/dm/statuses/{sha}","languages_url":"https://api.github.com/repos/lichunzhu/dm/languages","stargazers_url":"https://api.github.com/repos/lichunzhu/dm/stargazers","contributors_url":"https://api.github.com/repos/lichunzhu/dm/contributors","subscribers_url":"https://api.github.com/repos/lichunzhu/dm/subscribers","subscription_url":"https://api.github.com/repos/lichunzhu/dm/subscription","commits_url":"https://api.github.com/repos/lichunzhu/dm/commits{/sha}","git_commits_url":"https://api.github.com/repos/lichunzhu/dm/git/commits{/sha}","comments_url":"https://api.github.com/repos/lichunzhu/dm/comments{/number}","issue_comment_url":"https://api.github.com/repos/lichunzhu/dm/issues/comments{/number}","contents_url":"https://api.github.com/repos/lichunzhu/dm/contents/{+path}","compare_url":"https://api.github.com/repos/lichunzhu/dm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lichunzhu/dm/merges","archive_url":"https://api.github.com/repos/lichunzhu/dm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lichunzhu/dm/downloads","issues_url":"https://api.github.com/repos/lichunzhu/dm/issues{/number}","pulls_url":"https://api.github.com/repos/lichunzhu/dm/pulls{/number}","milestones_url":"https://api.github.com/repos/lichunzhu/dm/milestones{/number}","notifications_url":"https://api.github.com/repos/lichunzhu/dm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lichunzhu/dm/labels{/name}","releases_url":"https://api.github.com/repos/lichunzhu/dm/releases{/id}","deployments_url":"https://api.github.com/repos/lichunzhu/dm/deployments","created_at":"2019-09-24T11:55:09Z","updated_at":"2019-11-29T09:03:57Z","pushed_at":"2019-11-29T09:50:53Z","git_url":"git://github.com/lichunzhu/dm.git","ssh_url":"git@github.com:lichunzhu/dm.git","clone_url":"https://github.com/lichunzhu/dm.git","svn_url":"https://github.com/lichunzhu/dm","homepage":"","size":7974,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"7f1e8e22c39a715ff5b9728b7acd8d6a7c3450df","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":165957180,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU5NTcxODA=","name":"dm","full_name":"pingcap/dm","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/dm","description":"Data Migration Platform","fork":false,"url":"https://api.github.com/repos/pingcap/dm","forks_url":"https://api.github.com/repos/pingcap/dm/forks","keys_url":"https://api.github.com/repos/pingcap/dm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/dm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/dm/teams","hooks_url":"https://api.github.com/repos/pingcap/dm/hooks","issue_events_url":"https://api.github.com/repos/pingcap/dm/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/dm/events","assignees_url":"https://api.github.com/repos/pingcap/dm/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/dm/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/dm/tags","blobs_url":"https://api.github.com/repos/pingcap/dm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/dm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/dm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/dm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/dm/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/dm/languages","stargazers_url":"https://api.github.com/repos/pingcap/dm/stargazers","contributors_url":"https://api.github.com/repos/pingcap/dm/contributors","subscribers_url":"https://api.github.com/repos/pingcap/dm/subscribers","subscription_url":"https://api.github.com/repos/pingcap/dm/subscription","commits_url":"https://api.github.com/repos/pingcap/dm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/dm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/dm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/dm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/dm/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/dm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/dm/merges","archive_url":"https://api.github.com/repos/pingcap/dm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/dm/downloads","issues_url":"https://api.github.com/repos/pingcap/dm/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/dm/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/dm/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/dm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/dm/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/dm/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/dm/deployments","created_at":"2019-01-16T02:13:45Z","updated_at":"2019-11-29T08:31:10Z","pushed_at":"2019-11-29T09:50:55Z","git_url":"git://github.com/pingcap/dm.git","ssh_url":"git@github.com:pingcap/dm.git","clone_url":"https://github.com/pingcap/dm.git","svn_url":"https://github.com/pingcap/dm","homepage":"","size":8035,"stargazers_count":272,"watchers_count":272,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":87,"open_issues":45,"watchers":272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/dm/pulls/380"},"html":{"href":"https://github.com/pingcap/dm/pull/380"},"issue":{"href":"https://api.github.com/repos/pingcap/dm/issues/380"},"comments":{"href":"https://api.github.com/repos/pingcap/dm/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/dm/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/dm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/dm/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/dm/statuses/e29a9152217086d0f4de6c6ef58546084e073954"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 165957180,
"name": "pingcap/dm",
"url": "https://api.github.com/repos/pingcap/dm"
}
|
{
"id": 5793595,
"login": "WangXiangUSTC",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5793595?",
"url": "https://api.github.com/users/WangXiangUSTC"
}
|
{
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
}
| 2019-11-29T10:21:41 |
10974977752
|
{"actor":{"display_login":"WangXiangUSTC"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/community/pulls/comments/345043336","pull_request_review_id":315327593,"id":345043336,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NTA0MzMzNg==","diff_hunk":"@@ -1,127 +1,98 @@\n-## TiDB Community\n+# TiDB Community\n \n-Welcome to the TiDB Community! The main objective is to help members of the TiDB community who share similar interests to learn from and collaborate with each other.\n+Welcome to the TiDB Community! The main objective is to help members of the\n+TiDB community who share similar interests to learn from and collaborate with\n+each other.\n \n-Your journey of becoming a contributor and committer starts from here: improving docs, improving code, giving talks, organizing meetups, etc.\n+Your journey of becoming a contributor and committer starts from here:\n+improving docs, improving code, giving talks, organizing meetups, etc.\n \n-## Communicating\n+## Architecture\n \n-You can reach out to the community members via any one of the following ways: \n+\n \n-+ Slack: [https://pingcap.com/tidbslack/](https://pingcap.com/tidbslack/)\n+## TiDB User Group\n \n-+ Google Groups: [https://groups.google.com/forum/#!forum/tidb-user](https://groups.google.com/forum/#!forum/tidb-user)\n+The TiDB User Groups are groups for facilitating communication and discovery of\n+information related to topics that have long term relevance to large groups of\n+TiDB users.\n \n-+ Stack Overflow: [https://stackoverflow.com/questions/tagged/tidb](https://stackoverflow.com/questions/tagged/tidb)\n+See [docs](https://pingcap.com/docs/) or\n+[docs-cn](https://pingcap.com/docs-cn/) for user documents. Also you can get\n+help in [AskTUG](https://asktug.com/) if you met any problem.\n \n-+ Twitter: [https://twitter.com/PingCAP](https://twitter.com/PingCAP)\n+## TiDB Developer Group\n \n-+ Facebook: [https://www.facebook.com/pingcap2015](https://www.facebook.com/pingcap2015)\n+### Communicating\n \n+The [communication](./communicating.md) page lists communication channels like\n+chat, social medias, etc.\n \n-+ Reddit: [https://www.reddit.com/r/TiDB](https://www.reddit.com/r/TiDB)\n+For more specific topics, try to join\n+[https://pingcap.com/tidbslack](https://pingcap.com/tidbslack) and discuss with others.\n \n-## How Can I Help?\n+### Governance\n \n-+ Try [TiDB](https://github.com/pingcap/tidb)! If you like it, star, share, and recommend it. \n+TiDB has the following types of groups that are officially supported:\n \n-+ To dig deeper, read a design doc, e.g. [architecture](https://www.pingcap.com/blog/2017-05-23-perconalive17/), [How we build TiDB](https://www.pingcap.com/blog/2016-10-17-how-we-build-tidb/)\n+* **Special Interest Groups (SIGs)** are persistent open groups that focus on a\n+ part of the TiDB. SIGs must have open and transparent proceedings. Anyone is\n+ welcome to participate and contribute provided they follow the TiDB [Code of\n+ Conduct](./CODE_OF_CONDUCT.md). The purpose of a SIG is to own and develop a\n+ part of TiDB.\n \n-+ Start with improving the documentation. You can search [open issues](https://github.com/pingcap/docs/issues) to find inspiration for what to work on.\n+* **Working Groups (WGs)** are temporary groups that are formed to address\n+ issues that cross SIG boundaries. Working groups do not own any code or other\n+ long term artifacts. Working groups can report back and act through involved\n+ SIGs.\n \n-+ There's always code that can be clarified and variables or functions that can be renamed or commented.\n+### How to contribute\n \n-+ There's always a need for more test coverage. You can start with an area that has [low coverage](https://codecov.io/gh/pingcap/tidb).\n+Contributions are welcomed and greatly appreciated. See\n+[CONTRIBUTING.md](./CONTRIBUTING.md)\n+for details on submitting patches and the contribution workflow.\n \n-+ Give a talk at a local meetup or conference.\n+You can start by finding an existing issue with the\n+[help-wanted](https://github.com/pingcap/tidb/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22)\n+label in the tidb repo. These issues are well suited for new contributors. BTW,\n+there's always a need for more test coverage. You can also start with an area\n+that has [low coverage](https://codecov.io/gh/pingcap/tidb).\n \n-## Learn to Use TiDB\n+You can also join one of the [active working groups](./working-groups) to\n+participate in a community activity. Start attending working group meetings and\n+join the slack channel.\n \n-Links in [https://pingcap.com/docs](https://pingcap.com/docs) lead to many relevant topics, including:\n+Some useful documents:\n \n-+ TiDB Introduction\n+* [Github Workflow](./contributors/workflow.md)\n+* [SRE-BOT Command Help](./contributors/command-help.md)\n+* [Become a Committer](./become-a-committer.md)\n \n-+ TiDB Quick Start Guide\n+## Learning Resources\n \n-+ TiDB Operations Guide\n+* [How we build TiDB](https://www.pingcap.com/blog/2016-10-17-how-we-build-tidb/)\n+* [A Brief Introduction of TiDB](https://www.pingcap.com/blog/2017-05-23-perconalive17/)\n+* [https://pingcap.com/docs](https://pingcap.com/docs)\n+* [TiDB 源码阅读系列文章](https://pingcap.com/blog-cn/#TiDB-%E6%BA%90%E7%A0%81%E9%98%85%E8%AF%BB), in chinese","path":"README.md","position":99,"original_position":99,"commit_id":"c63d6713f274aa8e352817c0c2acc754bef229ee","original_commit_id":"0e9d18e7c9952a2ad21a38fe17a191df07d0c58e","user":{"login":"zz-jason","id":5268763,"node_id":"MDQ6VXNlcjUyNjg3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"body":"They're focused on the tidb architecture, while these Chinese articles are focused on the source code reading, they're different for the developers. I think both of them should be added to the learning resources.","created_at":"2019-11-12T07:07:25Z","updated_at":"2019-11-12T07:07:25Z","html_url":"https://github.com/pingcap/community/pull/53#discussion_r345043336","pull_request_url":"https://api.github.com/repos/pingcap/community/pulls/53","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/community/pulls/comments/345043336"},"html":{"href":"https://github.com/pingcap/community/pull/53#discussion_r345043336"},"pull_request":{"href":"https://api.github.com/repos/pingcap/community/pulls/53"}},"in_reply_to_id":344694479},"pull_request":{"url":"https://api.github.com/repos/pingcap/community/pulls/53","id":330112093,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwMTEyMDkz","html_url":"https://github.com/pingcap/community/pull/53","diff_url":"https://github.com/pingcap/community/pull/53.diff","patch_url":"https://github.com/pingcap/community/pull/53.patch","issue_url":"https://api.github.com/repos/pingcap/community/issues/53","number":53,"state":"open","locked":false,"title":"README.md: reorg the content in README.md","user":{"login":"zz-jason","id":5268763,"node_id":"MDQ6VXNlcjUyNjg3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-20T12:21:56Z","updated_at":"2019-11-12T07:07:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b091b245025af473ae57c820d170f9dc8f15789","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shenli","id":1192573,"node_id":"MDQ6VXNlcjExOTI1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1192573?v=4","gravatar_id":"","url":"https://api.github.com/users/shenli","html_url":"https://github.com/shenli","followers_url":"https://api.github.com/users/shenli/followers","following_url":"https://api.github.com/users/shenli/following{/other_user}","gists_url":"https://api.github.com/users/shenli/gists{/gist_id}","starred_url":"https://api.github.com/users/shenli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenli/subscriptions","organizations_url":"https://api.github.com/users/shenli/orgs","repos_url":"https://api.github.com/users/shenli/repos","events_url":"https://api.github.com/users/shenli/events{/privacy}","received_events_url":"https://api.github.com/users/shenli/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1660402666,"node_id":"MDU6TGFiZWwxNjYwNDAyNjY2","url":"https://api.github.com/repos/pingcap/community/labels/status/DNM","name":"status/DNM","color":"ef4845","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/community/pulls/53/commits","review_comments_url":"https://api.github.com/repos/pingcap/community/pulls/53/comments","review_comment_url":"https://api.github.com/repos/pingcap/community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/community/issues/53/comments","statuses_url":"https://api.github.com/repos/pingcap/community/statuses/c63d6713f274aa8e352817c0c2acc754bef229ee","head":{"label":"zz-jason:dev/refine-readme","ref":"dev/refine-readme","sha":"c63d6713f274aa8e352817c0c2acc754bef229ee","user":{"login":"zz-jason","id":5268763,"node_id":"MDQ6VXNlcjUyNjg3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"repo":{"id":202476862,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI0NzY4NjI=","name":"community","full_name":"zz-jason/community","private":false,"owner":{"login":"zz-jason","id":5268763,"node_id":"MDQ6VXNlcjUyNjg3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zz-jason/community","description":"TiDB community content","fork":true,"url":"https://api.github.com/repos/zz-jason/community","forks_url":"https://api.github.com/repos/zz-jason/community/forks","keys_url":"https://api.github.com/repos/zz-jason/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zz-jason/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zz-jason/community/teams","hooks_url":"https://api.github.com/repos/zz-jason/community/hooks","issue_events_url":"https://api.github.com/repos/zz-jason/community/issues/events{/number}","events_url":"https://api.github.com/repos/zz-jason/community/events","assignees_url":"https://api.github.com/repos/zz-jason/community/assignees{/user}","branches_url":"https://api.github.com/repos/zz-jason/community/branches{/branch}","tags_url":"https://api.github.com/repos/zz-jason/community/tags","blobs_url":"https://api.github.com/repos/zz-jason/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zz-jason/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zz-jason/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/zz-jason/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zz-jason/community/statuses/{sha}","languages_url":"https://api.github.com/repos/zz-jason/community/languages","stargazers_url":"https://api.github.com/repos/zz-jason/community/stargazers","contributors_url":"https://api.github.com/repos/zz-jason/community/contributors","subscribers_url":"https://api.github.com/repos/zz-jason/community/subscribers","subscription_url":"https://api.github.com/repos/zz-jason/community/subscription","commits_url":"https://api.github.com/repos/zz-jason/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/zz-jason/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/zz-jason/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/zz-jason/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/zz-jason/community/contents/{+path}","compare_url":"https://api.github.com/repos/zz-jason/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zz-jason/community/merges","archive_url":"https://api.github.com/repos/zz-jason/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zz-jason/community/downloads","issues_url":"https://api.github.com/repos/zz-jason/community/issues{/number}","pulls_url":"https://api.github.com/repos/zz-jason/community/pulls{/number}","milestones_url":"https://api.github.com/repos/zz-jason/community/milestones{/number}","notifications_url":"https://api.github.com/repos/zz-jason/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zz-jason/community/labels{/name}","releases_url":"https://api.github.com/repos/zz-jason/community/releases{/id}","deployments_url":"https://api.github.com/repos/zz-jason/community/deployments","created_at":"2019-08-15T05:00:24Z","updated_at":"2019-08-15T05:00:27Z","pushed_at":"2019-11-12T05:18:10Z","git_url":"git://github.com/zz-jason/community.git","ssh_url":"git@github.com:zz-jason/community.git","clone_url":"https://github.com/zz-jason/community.git","svn_url":"https://github.com/zz-jason/community","homepage":null,"size":685,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"9f36e367a6293c6273f7dd9db18568e117e651ed","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":110772190,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA3NzIxOTA=","name":"community","full_name":"pingcap/community","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/community","description":"TiDB community content","fork":false,"url":"https://api.github.com/repos/pingcap/community","forks_url":"https://api.github.com/repos/pingcap/community/forks","keys_url":"https://api.github.com/repos/pingcap/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/community/teams","hooks_url":"https://api.github.com/repos/pingcap/community/hooks","issue_events_url":"https://api.github.com/repos/pingcap/community/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/community/events","assignees_url":"https://api.github.com/repos/pingcap/community/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/community/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/community/tags","blobs_url":"https://api.github.com/repos/pingcap/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/community/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/community/languages","stargazers_url":"https://api.github.com/repos/pingcap/community/stargazers","contributors_url":"https://api.github.com/repos/pingcap/community/contributors","subscribers_url":"https://api.github.com/repos/pingcap/community/subscribers","subscription_url":"https://api.github.com/repos/pingcap/community/subscription","commits_url":"https://api.github.com/repos/pingcap/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/community/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/community/merges","archive_url":"https://api.github.com/repos/pingcap/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/community/downloads","issues_url":"https://api.github.com/repos/pingcap/community/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/community/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/community/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/community/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/community/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/community/deployments","created_at":"2017-11-15T02:22:40Z","updated_at":"2019-11-12T03:13:29Z","pushed_at":"2019-11-12T05:18:11Z","git_url":"git://github.com/pingcap/community.git","ssh_url":"git@github.com:pingcap/community.git","clone_url":"https://github.com/pingcap/community.git","svn_url":"https://github.com/pingcap/community","homepage":null,"size":703,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":29,"open_issues":6,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/community/pulls/53"},"html":{"href":"https://github.com/pingcap/community/pull/53"},"issue":{"href":"https://api.github.com/repos/pingcap/community/issues/53"},"comments":{"href":"https://api.github.com/repos/pingcap/community/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/community/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/community/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/community/statuses/c63d6713f274aa8e352817c0c2acc754bef229ee"}},"author_association":"MEMBER"}}
|
{
"id": 110772190,
"name": "pingcap/community",
"url": "https://api.github.com/repos/pingcap/community"
}
|
{
"id": 5268763,
"login": "zz-jason",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5268763?",
"url": "https://api.github.com/users/zz-jason"
}
|
{
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
}
| 2019-11-12T07:07:25 |
10840014359
|
{"actor":{"display_login":"zz-jason"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/310464934","pull_request_review_id":270591956,"id":310464934,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDQ2NDkzNA==","diff_hunk":"@@ -417,6 +424,43 @@ func (s *testSuiteP1) TestAdmin(c *C) {\n \tc.Assert(historyJobs, DeepEquals, historyJobs2)\n }\n \n+func (s *testSuite) TestAdminShowDDLJobs(c *C) {\n+\ttk := testkit.NewTestKit(c, s.store)\n+\ttk.MustExec(\"create database if not exists test_admin_show_ddl_jobs\")\n+\ttk.MustExec(\"use test_admin_show_ddl_jobs\")\n+\ttk.MustExec(\"create table t (a int);\")\n+\n+\tre := tk.MustQuery(\"admin show ddl jobs 1\")\n+\trow := re.Rows()[0]\n+\tc.Assert(row[1], Equals, \"test_admin_show_ddl_jobs\")\n+\tjobID, err := strconv.Atoi(row[0].(string))\n+\tc.Assert(err, IsNil)\n+\n+\tc.Assert(tk.Se.NewTxn(context.Background()), IsNil)\n+\ttxn, err := tk.Se.Txn(true)\n+\tc.Assert(err, IsNil)\n+\tt := meta.NewMeta(txn)\n+\tjob, err := t.GetHistoryDDLJob(int64(jobID))\n+\tc.Assert(err, IsNil)\n+\tc.Assert(job, NotNil)\n+\t// Test for compatibility. Old TiDB version doesn't have SchemaName field, and the BinlogInfo maybe nil.\n+\t// See PR: 11561.\n+\tjob.BinlogInfo = nil\n+\tjob.SchemaName = \"\"\n+\terr = t.AddHistoryDDLJob(job)\n+\tc.Assert(err, IsNil)\n+\terr = tk.Se.StmtCommit()\n+\tc.Assert(err, IsNil)\n+\terr = tk.Se.CommitTxn(context.Background())\n+\tc.Assert(err, IsNil)\n+\n+\t//err = txn.Commit(context.Background())\n+\t//c.Assert(err, IsNil)","path":"executor/executor_test.go","position":null,"original_position":67,"commit_id":"817b53fc421b07fc23daf1259dffd86899ac6e6b","original_commit_id":"befa4bc07bed8889dfb0de57bd8bbe13a476f3cf","user":{"login":"crazycs520","id":26020263,"node_id":"MDQ6VXNlcjI2MDIwMjYz","avatar_url":"https://avatars2.githubusercontent.com/u/26020263?v=4","gravatar_id":"","url":"https://api.github.com/users/crazycs520","html_url":"https://github.com/crazycs520","followers_url":"https://api.github.com/users/crazycs520/followers","following_url":"https://api.github.com/users/crazycs520/following{/other_user}","gists_url":"https://api.github.com/users/crazycs520/gists{/gist_id}","starred_url":"https://api.github.com/users/crazycs520/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazycs520/subscriptions","organizations_url":"https://api.github.com/users/crazycs520/orgs","repos_url":"https://api.github.com/users/crazycs520/repos","events_url":"https://api.github.com/users/crazycs520/events{/privacy}","received_events_url":"https://api.github.com/users/crazycs520/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2019-08-05T07:16:30Z","updated_at":"2019-08-05T07:16:30Z","html_url":"https://github.com/pingcap/tidb/pull/11561#discussion_r310464934","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/11561","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/310464934"},"html":{"href":"https://github.com/pingcap/tidb/pull/11561#discussion_r310464934"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/11561"}},"in_reply_to_id":310431849},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/11561","id":303228610,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzMjI4NjEw","html_url":"https://github.com/pingcap/tidb/pull/11561","diff_url":"https://github.com/pingcap/tidb/pull/11561.diff","patch_url":"https://github.com/pingcap/tidb/pull/11561.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/11561","number":11561,"state":"open","locked":false,"title":"model: add schema name, table name to ddl job.","user":{"login":"crazycs520","id":26020263,"node_id":"MDQ6VXNlcjI2MDIwMjYz","avatar_url":"https://avatars2.githubusercontent.com/u/26020263?v=4","gravatar_id":"","url":"https://api.github.com/users/crazycs520","html_url":"https://github.com/crazycs520","followers_url":"https://api.github.com/users/crazycs520/followers","following_url":"https://api.github.com/users/crazycs520/following{/other_user}","gists_url":"https://api.github.com/users/crazycs520/gists{/gist_id}","starred_url":"https://api.github.com/users/crazycs520/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazycs520/subscriptions","organizations_url":"https://api.github.com/users/crazycs520/orgs","repos_url":"https://api.github.com/users/crazycs520/repos","events_url":"https://api.github.com/users/crazycs520/events{/privacy}","received_events_url":"https://api.github.com/users/crazycs520/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\n* add schema name, table name, end_ts to ddl job.\r\n\r\nRelated parser PR: https://github.com/pingcap/parser/pull/422\r\n\r\nBefore:\r\nThe schema name and table name maybe \"\" after the database or table droped.\r\n```sql\r\nmysql>admin show ddl jobs\r\n+--------+---------+------------+---------------+--------------+-----------+----------+-----------+-----------------------------------+--------+\r\n| JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT | START_TIME | STATE |\r\n+--------+---------+------------+---------------+--------------+-----------+----------+-----------+-----------------------------------+--------+\r\n| 105 | | | drop schema | none | 100 | 0 | 0 | 2019-08-01 14:01:31.355 +0800 CST | synced |\r\n| 104 | | | drop table | none | 100 | 102 | 0 | 2019-08-01 14:00:40.406 +0800 CST | synced |\r\n| 103 | | | create table | public | 100 | 102 | 0 | 2019-08-01 14:00:37.955 +0800 CST | synced |\r\n| 101 | | | create schema | public | 100 | 0 | 0 | 2019-08-01 14:00:32.953 +0800 CST | synced |\r\n| 99 | | | drop schema | none | 95 | 0 | 0 | 2019-08-01 14:00:23.752 +0800 CST | synced |\r\n| 98 | | | create table | public | 95 | 97 | 0 | 2019-08-01 14:00:12.502 +0800 CST | synced |\r\n| 96 | | | create schema | public | 95 | 0 | 0 | 2019-08-01 14:00:00.304 +0800 CST | synced |\r\n| 94 | | | drop schema | none | 90 | 0 | 0 | 2019-08-01 13:59:57.807 +0800 CST | synced |\r\n| 93 | | | create table | public | 90 | 92 | 0 | 2019-08-01 13:54:00.504 +0800 CST | synced |\r\n| 91 | | | create schema | public | 90 | 0 | 0 | 2019-08-01 13:53:53.553 +0800 CST | synced |\r\n+--------+---------+------------+---------------+--------------+-----------+----------+-----------+-----------------------------------+--------+\r\n```\r\nThis PR\r\n(DDL 93 and 91 don't have name because it is the old version ddl job.)\r\n```sql\r\nmysql>admin show ddl jobs │| synced |\r\n+--------+---------+------------+---------------+--------------+-----------+----------+-----------+-----------------------------------+-----------------------------------+--------+ │| 104 | | | drop table | none | 10\r\n| JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT | START_TIME | END_TIME | STATE | │0 | 102 | 0 | 2019-08-01 14:00:40.406 +0800 CST\r\n+--------+---------+------------+---------------+--------------+-----------+----------+-----------+-----------------------------------+-----------------------------------+--------+ │| synced |\r\n| 105 | test | | drop schema | none | 100 | 0 | 0 | 2019-08-01 14:01:31.355 +0800 CST | 2019-08-01 14:01:31.556 +0800 CST | synced | │| 103 | | | create table | public | 10\r\n| 104 | test | t1 | drop table | none | 100 | 102 | 0 | 2019-08-01 14:00:40.406 +0800 CST | 2019-08-01 14:00:40.606 +0800 CST | synced | │0 | 102 | 0 | 2019-08-01 14:00:37.955 +0800 CST\r\n| 103 | test | t1 | create table | public | 100 | 102 | 0 | 2019-08-01 14:00:37.955 +0800 CST | 2019-08-01 14:00:38.005 +0800 CST | synced | │| synced |\r\n| 101 | test | | create schema | public | 100 | 0 | 0 | 2019-08-01 14:00:32.953 +0800 CST | 2019-08-01 14:00:33.004 +0800 CST | synced | │| 101 | | | create schema | public | 10\r\n| 99 | test | | drop schema | none | 95 | 0 | 0 | 2019-08-01 14:00:23.752 +0800 CST | 2019-08-01 14:00:23.952 +0800 CST | synced | │0 | 0 | 0 | 2019-08-01 14:00:32.953 +0800 CST\r\n| 98 | test | t1 | create table | public | 95 | 97 | 0 | 2019-08-01 14:00:12.502 +0800 CST | 2019-08-01 14:00:12.557 +0800 CST | synced | │| synced |\r\n| 96 | test | | create schema | public | 95 | 0 | 0 | 2019-08-01 14:00:00.304 +0800 CST | 2019-08-01 14:00:00.356 +0800 CST | synced | │| 99 | | | drop schema | none | 95\r\n| 94 | test | | drop schema | none | 90 | 0 | 0 | 2019-08-01 13:59:57.807 +0800 CST | 2019-08-01 13:59:57.952 +0800 CST | synced | │ | 0 | 0 | 2019-08-01 14:00:23.752 +0800 CST\r\n| 93 | | | create table | public | 90 | 92 | 0 | 2019-08-01 13:54:00.504 +0800 CST | 2019-08-01 13:54:00.554 +0800 CST | synced | │| synced |\r\n| 91 | | | create schema | public | 90 | 0 | 0 | 2019-08-01 13:53:53.553 +0800 CST | 2019-08-01 13:53:53.601 +0800 CST | synced | │| 98 | | | create table | public | 95\r\n+--------+---------+------------+---------------+--------------+-----------+----------+-----------+-----------------------------------+-----------------------------------+--------+\r\n```\r\n\r\nTiDB used to only store the schema ID and table ID in DDL job info, When executing `admin show ddl jobs`, TiDB use `infoschema` to find schema/table name by the schema ID and table ID. But after we drop the database or table, this does not work any more. \r\n\r\n### What is changed and how it works?\r\n* add schema name, table name to the DDL job info.\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test\r\nCode changes\r\n\r\n - Has exported function/method change\r\n\r\nSide effects\r\n\r\n\r\nRelated changes\r\n","created_at":"2019-08-01T05:56:26Z","updated_at":"2019-08-05T07:16:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39df26a77d812b1412971cda939692ec0ca7951e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":745133021,"node_id":"MDU6TGFiZWw3NDUxMzMwMjE=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/DDL-need-LGT3","name":"component/DDL-need-LGT3","color":"00bff4","default":false},{"id":1204650617,"node_id":"MDU6TGFiZWwxMjA0NjUwNjE3","url":"https://api.github.com/repos/pingcap/tidb/labels/component/usability","name":"component/usability","color":"0ad8bd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/11561/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/11561/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/11561/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/817b53fc421b07fc23daf1259dffd86899ac6e6b","head":{"label":"crazycs520:ddl-job","ref":"ddl-job","sha":"817b53fc421b07fc23daf1259dffd86899ac6e6b","user":{"login":"crazycs520","id":26020263,"node_id":"MDQ6VXNlcjI2MDIwMjYz","avatar_url":"https://avatars2.githubusercontent.com/u/26020263?v=4","gravatar_id":"","url":"https://api.github.com/users/crazycs520","html_url":"https://github.com/crazycs520","followers_url":"https://api.github.com/users/crazycs520/followers","following_url":"https://api.github.com/users/crazycs520/following{/other_user}","gists_url":"https://api.github.com/users/crazycs520/gists{/gist_id}","starred_url":"https://api.github.com/users/crazycs520/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazycs520/subscriptions","organizations_url":"https://api.github.com/users/crazycs520/orgs","repos_url":"https://api.github.com/users/crazycs520/repos","events_url":"https://api.github.com/users/crazycs520/events{/privacy}","received_events_url":"https://api.github.com/users/crazycs520/received_events","type":"User","site_admin":false},"repo":{"id":136926865,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MjY4NjU=","name":"tidb","full_name":"crazycs520/tidb","private":false,"owner":{"login":"crazycs520","id":26020263,"node_id":"MDQ6VXNlcjI2MDIwMjYz","avatar_url":"https://avatars2.githubusercontent.com/u/26020263?v=4","gravatar_id":"","url":"https://api.github.com/users/crazycs520","html_url":"https://github.com/crazycs520","followers_url":"https://api.github.com/users/crazycs520/followers","following_url":"https://api.github.com/users/crazycs520/following{/other_user}","gists_url":"https://api.github.com/users/crazycs520/gists{/gist_id}","starred_url":"https://api.github.com/users/crazycs520/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazycs520/subscriptions","organizations_url":"https://api.github.com/users/crazycs520/orgs","repos_url":"https://api.github.com/users/crazycs520/repos","events_url":"https://api.github.com/users/crazycs520/events{/privacy}","received_events_url":"https://api.github.com/users/crazycs520/received_events","type":"User","site_admin":false},"html_url":"https://github.com/crazycs520/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":true,"url":"https://api.github.com/repos/crazycs520/tidb","forks_url":"https://api.github.com/repos/crazycs520/tidb/forks","keys_url":"https://api.github.com/repos/crazycs520/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crazycs520/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crazycs520/tidb/teams","hooks_url":"https://api.github.com/repos/crazycs520/tidb/hooks","issue_events_url":"https://api.github.com/repos/crazycs520/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/crazycs520/tidb/events","assignees_url":"https://api.github.com/repos/crazycs520/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/crazycs520/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/crazycs520/tidb/tags","blobs_url":"https://api.github.com/repos/crazycs520/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crazycs520/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crazycs520/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/crazycs520/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crazycs520/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/crazycs520/tidb/languages","stargazers_url":"https://api.github.com/repos/crazycs520/tidb/stargazers","contributors_url":"https://api.github.com/repos/crazycs520/tidb/contributors","subscribers_url":"https://api.github.com/repos/crazycs520/tidb/subscribers","subscription_url":"https://api.github.com/repos/crazycs520/tidb/subscription","commits_url":"https://api.github.com/repos/crazycs520/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/crazycs520/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/crazycs520/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/crazycs520/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/crazycs520/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/crazycs520/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crazycs520/tidb/merges","archive_url":"https://api.github.com/repos/crazycs520/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crazycs520/tidb/downloads","issues_url":"https://api.github.com/repos/crazycs520/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/crazycs520/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/crazycs520/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/crazycs520/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crazycs520/tidb/labels{/name}","releases_url":"https://api.github.com/repos/crazycs520/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/crazycs520/tidb/deployments","created_at":"2018-06-11T13:00:28Z","updated_at":"2019-07-12T17:55:00Z","pushed_at":"2019-08-05T07:15:09Z","git_url":"git://github.com/crazycs520/tidb.git","ssh_url":"git@github.com:crazycs520/tidb.git","clone_url":"https://github.com/crazycs520/tidb.git","svn_url":"https://github.com/crazycs520/tidb","homepage":"https://pingcap.com","size":85322,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"03bb8d7818b85996d6a85664223857a4b395030e","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2019-08-05T07:01:51Z","pushed_at":"2019-08-05T07:15:12Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":137797,"stargazers_count":20035,"watchers_count":20035,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2912,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":964,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2912,"open_issues":964,"watchers":20035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/11561"},"html":{"href":"https://github.com/pingcap/tidb/pull/11561"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/11561"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/11561/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/11561/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/11561/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/817b53fc421b07fc23daf1259dffd86899ac6e6b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 41986369,
"name": "pingcap/tidb",
"url": "https://api.github.com/repos/pingcap/tidb"
}
|
{
"id": 26020263,
"login": "crazycs520",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26020263?",
"url": "https://api.github.com/users/crazycs520"
}
|
{
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
}
| 2019-08-05T07:16:30 |
10146127105
|
{"actor":{"display_login":"crazycs520"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/pd/pulls/comments/306144313","pull_request_review_id":265190732,"id":306144313,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjE0NDMxMw==","diff_hunk":"@@ -0,0 +1,36 @@\n+package typeutil","path":"pkg/typeutil/time_test.go","position":1,"original_position":1,"commit_id":"a1c4ecd5a1617a67a9a80a5018028a98d61e3637","original_commit_id":"a1c4ecd5a1617a67a9a80a5018028a98d61e3637","user":{"login":"nolouch","id":6428910,"node_id":"MDQ6VXNlcjY0Mjg5MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6428910?v=4","gravatar_id":"","url":"https://api.github.com/users/nolouch","html_url":"https://github.com/nolouch","followers_url":"https://api.github.com/users/nolouch/followers","following_url":"https://api.github.com/users/nolouch/following{/other_user}","gists_url":"https://api.github.com/users/nolouch/gists{/gist_id}","starred_url":"https://api.github.com/users/nolouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolouch/subscriptions","organizations_url":"https://api.github.com/users/nolouch/orgs","repos_url":"https://api.github.com/users/nolouch/repos","events_url":"https://api.github.com/users/nolouch/events{/privacy}","received_events_url":"https://api.github.com/users/nolouch/received_events","type":"User","site_admin":false},"body":"License.","created_at":"2019-07-23T06:19:44Z","updated_at":"2019-07-23T06:23:16Z","html_url":"https://github.com/pingcap/pd/pull/1628#discussion_r306144313","pull_request_url":"https://api.github.com/repos/pingcap/pd/pulls/1628","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/pd/pulls/comments/306144313"},"html":{"href":"https://github.com/pingcap/pd/pull/1628#discussion_r306144313"},"pull_request":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1628"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/pd/pulls/1628","id":296147156,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MTQ3MTU2","html_url":"https://github.com/pingcap/pd/pull/1628","diff_url":"https://github.com/pingcap/pd/pull/1628.diff","patch_url":"https://github.com/pingcap/pd/pull/1628.patch","issue_url":"https://api.github.com/repos/pingcap/pd/issues/1628","number":1628,"state":"open","locked":false,"title":"server: use an individual package for tso","user":{"login":"rleungx","id":35896542,"node_id":"MDQ6VXNlcjM1ODk2NTQy","avatar_url":"https://avatars3.githubusercontent.com/u/35896542?v=4","gravatar_id":"","url":"https://api.github.com/users/rleungx","html_url":"https://github.com/rleungx","followers_url":"https://api.github.com/users/rleungx/followers","following_url":"https://api.github.com/users/rleungx/following{/other_user}","gists_url":"https://api.github.com/users/rleungx/gists{/gist_id}","starred_url":"https://api.github.com/users/rleungx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleungx/subscriptions","organizations_url":"https://api.github.com/users/rleungx/orgs","repos_url":"https://api.github.com/users/rleungx/repos","events_url":"https://api.github.com/users/rleungx/events{/privacy}","received_events_url":"https://api.github.com/users/rleungx/received_events","type":"User","site_admin":false},"body":"### What problem does this PR solve? <!--add the issue link with summary if it exists-->\r\nPart of modularizing PD. It can be reviewed after the following PRs are merged.\r\n- [x] #1622\r\n- [x] #1623 \r\n\r\n### What is changed and how it works?\r\nThis PR uses an individual package for tso.\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test","created_at":"2019-07-10T12:18:43Z","updated_at":"2019-07-23T06:23:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74abe59e5ead630c6d55dcacf512576be547b2a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/pd/pulls/1628/commits","review_comments_url":"https://api.github.com/repos/pingcap/pd/pulls/1628/comments","review_comment_url":"https://api.github.com/repos/pingcap/pd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/pd/issues/1628/comments","statuses_url":"https://api.github.com/repos/pingcap/pd/statuses/a1c4ecd5a1617a67a9a80a5018028a98d61e3637","head":{"label":"rleungx:split-tso","ref":"split-tso","sha":"a1c4ecd5a1617a67a9a80a5018028a98d61e3637","user":{"login":"rleungx","id":35896542,"node_id":"MDQ6VXNlcjM1ODk2NTQy","avatar_url":"https://avatars3.githubusercontent.com/u/35896542?v=4","gravatar_id":"","url":"https://api.github.com/users/rleungx","html_url":"https://github.com/rleungx","followers_url":"https://api.github.com/users/rleungx/followers","following_url":"https://api.github.com/users/rleungx/following{/other_user}","gists_url":"https://api.github.com/users/rleungx/gists{/gist_id}","starred_url":"https://api.github.com/users/rleungx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleungx/subscriptions","organizations_url":"https://api.github.com/users/rleungx/orgs","repos_url":"https://api.github.com/users/rleungx/repos","events_url":"https://api.github.com/users/rleungx/events{/privacy}","received_events_url":"https://api.github.com/users/rleungx/received_events","type":"User","site_admin":false},"repo":{"id":140550848,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1NTA4NDg=","name":"pd","full_name":"rleungx/pd","private":false,"owner":{"login":"rleungx","id":35896542,"node_id":"MDQ6VXNlcjM1ODk2NTQy","avatar_url":"https://avatars3.githubusercontent.com/u/35896542?v=4","gravatar_id":"","url":"https://api.github.com/users/rleungx","html_url":"https://github.com/rleungx","followers_url":"https://api.github.com/users/rleungx/followers","following_url":"https://api.github.com/users/rleungx/following{/other_user}","gists_url":"https://api.github.com/users/rleungx/gists{/gist_id}","starred_url":"https://api.github.com/users/rleungx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleungx/subscriptions","organizations_url":"https://api.github.com/users/rleungx/orgs","repos_url":"https://api.github.com/users/rleungx/repos","events_url":"https://api.github.com/users/rleungx/events{/privacy}","received_events_url":"https://api.github.com/users/rleungx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rleungx/pd","description":"Placement driver for TiKV","fork":true,"url":"https://api.github.com/repos/rleungx/pd","forks_url":"https://api.github.com/repos/rleungx/pd/forks","keys_url":"https://api.github.com/repos/rleungx/pd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rleungx/pd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rleungx/pd/teams","hooks_url":"https://api.github.com/repos/rleungx/pd/hooks","issue_events_url":"https://api.github.com/repos/rleungx/pd/issues/events{/number}","events_url":"https://api.github.com/repos/rleungx/pd/events","assignees_url":"https://api.github.com/repos/rleungx/pd/assignees{/user}","branches_url":"https://api.github.com/repos/rleungx/pd/branches{/branch}","tags_url":"https://api.github.com/repos/rleungx/pd/tags","blobs_url":"https://api.github.com/repos/rleungx/pd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rleungx/pd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rleungx/pd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rleungx/pd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rleungx/pd/statuses/{sha}","languages_url":"https://api.github.com/repos/rleungx/pd/languages","stargazers_url":"https://api.github.com/repos/rleungx/pd/stargazers","contributors_url":"https://api.github.com/repos/rleungx/pd/contributors","subscribers_url":"https://api.github.com/repos/rleungx/pd/subscribers","subscription_url":"https://api.github.com/repos/rleungx/pd/subscription","commits_url":"https://api.github.com/repos/rleungx/pd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rleungx/pd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rleungx/pd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rleungx/pd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rleungx/pd/contents/{+path}","compare_url":"https://api.github.com/repos/rleungx/pd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rleungx/pd/merges","archive_url":"https://api.github.com/repos/rleungx/pd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rleungx/pd/downloads","issues_url":"https://api.github.com/repos/rleungx/pd/issues{/number}","pulls_url":"https://api.github.com/repos/rleungx/pd/pulls{/number}","milestones_url":"https://api.github.com/repos/rleungx/pd/milestones{/number}","notifications_url":"https://api.github.com/repos/rleungx/pd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rleungx/pd/labels{/name}","releases_url":"https://api.github.com/repos/rleungx/pd/releases{/id}","deployments_url":"https://api.github.com/repos/rleungx/pd/deployments","created_at":"2018-07-11T09:14:04Z","updated_at":"2019-06-24T07:10:17Z","pushed_at":"2019-07-23T05:34:53Z","git_url":"git://github.com/rleungx/pd.git","ssh_url":"git@github.com:rleungx/pd.git","clone_url":"https://github.com/rleungx/pd.git","svn_url":"https://github.com/rleungx/pd","homepage":"","size":14706,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"fe2abb1931c41f499a5d9afcb9a5bf16e1d8aa85","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53311716,"node_id":"MDEwOlJlcG9zaXRvcnk1MzMxMTcxNg==","name":"pd","full_name":"pingcap/pd","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/pd","description":"Placement driver for TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/pd","forks_url":"https://api.github.com/repos/pingcap/pd/forks","keys_url":"https://api.github.com/repos/pingcap/pd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/pd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/pd/teams","hooks_url":"https://api.github.com/repos/pingcap/pd/hooks","issue_events_url":"https://api.github.com/repos/pingcap/pd/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/pd/events","assignees_url":"https://api.github.com/repos/pingcap/pd/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/pd/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/pd/tags","blobs_url":"https://api.github.com/repos/pingcap/pd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/pd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/pd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/pd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/pd/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/pd/languages","stargazers_url":"https://api.github.com/repos/pingcap/pd/stargazers","contributors_url":"https://api.github.com/repos/pingcap/pd/contributors","subscribers_url":"https://api.github.com/repos/pingcap/pd/subscribers","subscription_url":"https://api.github.com/repos/pingcap/pd/subscription","commits_url":"https://api.github.com/repos/pingcap/pd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/pd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/pd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/pd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/pd/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/pd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/pd/merges","archive_url":"https://api.github.com/repos/pingcap/pd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/pd/downloads","issues_url":"https://api.github.com/repos/pingcap/pd/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/pd/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/pd/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/pd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/pd/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/pd/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/pd/deployments","created_at":"2016-03-07T09:13:06Z","updated_at":"2019-07-22T09:39:14Z","pushed_at":"2019-07-23T05:34:55Z","git_url":"git://github.com/pingcap/pd.git","ssh_url":"git@github.com:pingcap/pd.git","clone_url":"https://github.com/pingcap/pd.git","svn_url":"https://github.com/pingcap/pd","homepage":"","size":14329,"stargazers_count":415,"watchers_count":415,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":235,"open_issues":64,"watchers":415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1628"},"html":{"href":"https://github.com/pingcap/pd/pull/1628"},"issue":{"href":"https://api.github.com/repos/pingcap/pd/issues/1628"},"comments":{"href":"https://api.github.com/repos/pingcap/pd/issues/1628/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1628/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/pd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1628/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/pd/statuses/a1c4ecd5a1617a67a9a80a5018028a98d61e3637"}},"author_association":"MEMBER"}}
|
{
"id": 53311716,
"name": "pingcap/pd",
"url": "https://api.github.com/repos/pingcap/pd"
}
|
{
"id": 6428910,
"login": "nolouch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6428910?",
"url": "https://api.github.com/users/nolouch"
}
|
{
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
}
| 2019-07-23T06:19:44 |
10063580394
|
{"actor":{"display_login":"nolouch"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments/309017164","pull_request_review_id":268757129,"id":309017164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTAxNzE2NA==","diff_hunk":"@@ -0,0 +1,28 @@\n+const {option: {Some, None}, Instrumentation} = require('zipkin');\n+\n+module.exports = function zipkinMiddleware({tracer, serviceName = 'unknown', port = 0}) {\n+ const instrumentation = new Instrumentation.HttpServer({tracer, serviceName, port});\n+\n+ return async function zipkinKoaMiddleware(ctx, next) {\n+ function readHeader(header) {\n+ const val = ctx.request.headers[header.toLowerCase()];\n+ if (val != null) {\n+ return new Some(val);\n+ } else {\n+ return None;\n+ }\n+ }\n+ tracer.scoped(async() => {\n+ const method = ctx.request.method.toUpperCase();\n+ const id = instrumentation.recordRequest(method, ctx.request.href, readHeader);\n+\n+ try {\n+ await next();\n+ } finally {","path":"packages/zipkin-instrumentation-koa/src/koaMiddleware.js","position":21,"original_position":21,"commit_id":"d2d1f0f436085e72dee0f4f58b1ff3d0aff34ca0","original_commit_id":"d2d1f0f436085e72dee0f4f58b1ff3d0aff34ca0","user":{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"error handling? is there a hook for it?","created_at":"2019-07-31T02:30:34Z","updated_at":"2019-07-31T02:33:18Z","html_url":"https://github.com/openzipkin/zipkin-js/pull/434#discussion_r309017164","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/434","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments/309017164"},"html":{"href":"https://github.com/openzipkin/zipkin-js/pull/434#discussion_r309017164"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/434"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/434","id":302718407,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAyNzE4NDA3","html_url":"https://github.com/openzipkin/zipkin-js/pull/434","diff_url":"https://github.com/openzipkin/zipkin-js/pull/434.diff","patch_url":"https://github.com/openzipkin/zipkin-js/pull/434.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/434","number":434,"state":"open","locked":false,"title":"[WIP] Zipkin middleware for Koa 2.x","user":{"login":"shumsky","id":1389769,"node_id":"MDQ6VXNlcjEzODk3Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1389769?v=4","gravatar_id":"","url":"https://api.github.com/users/shumsky","html_url":"https://github.com/shumsky","followers_url":"https://api.github.com/users/shumsky/followers","following_url":"https://api.github.com/users/shumsky/following{/other_user}","gists_url":"https://api.github.com/users/shumsky/gists{/gist_id}","starred_url":"https://api.github.com/users/shumsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shumsky/subscriptions","organizations_url":"https://api.github.com/users/shumsky/orgs","repos_url":"https://api.github.com/users/shumsky/repos","events_url":"https://api.github.com/users/shumsky/events{/privacy}","received_events_url":"https://api.github.com/users/shumsky/received_events","type":"User","site_admin":false},"body":"Addresses #112 ","created_at":"2019-07-30T22:22:31Z","updated_at":"2019-07-31T02:33:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df2728aacc51a9a2dd3f49a2826b203f76176ce7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/434/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/434/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/434/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/d2d1f0f436085e72dee0f4f58b1ff3d0aff34ca0","head":{"label":"shumsky:master","ref":"master","sha":"d2d1f0f436085e72dee0f4f58b1ff3d0aff34ca0","user":{"login":"shumsky","id":1389769,"node_id":"MDQ6VXNlcjEzODk3Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1389769?v=4","gravatar_id":"","url":"https://api.github.com/users/shumsky","html_url":"https://github.com/shumsky","followers_url":"https://api.github.com/users/shumsky/followers","following_url":"https://api.github.com/users/shumsky/following{/other_user}","gists_url":"https://api.github.com/users/shumsky/gists{/gist_id}","starred_url":"https://api.github.com/users/shumsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shumsky/subscriptions","organizations_url":"https://api.github.com/users/shumsky/orgs","repos_url":"https://api.github.com/users/shumsky/repos","events_url":"https://api.github.com/users/shumsky/events{/privacy}","received_events_url":"https://api.github.com/users/shumsky/received_events","type":"User","site_admin":false},"repo":{"id":104402682,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ0MDI2ODI=","name":"zipkin-js","full_name":"shumsky/zipkin-js","private":false,"owner":{"login":"shumsky","id":1389769,"node_id":"MDQ6VXNlcjEzODk3Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1389769?v=4","gravatar_id":"","url":"https://api.github.com/users/shumsky","html_url":"https://github.com/shumsky","followers_url":"https://api.github.com/users/shumsky/followers","following_url":"https://api.github.com/users/shumsky/following{/other_user}","gists_url":"https://api.github.com/users/shumsky/gists{/gist_id}","starred_url":"https://api.github.com/users/shumsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shumsky/subscriptions","organizations_url":"https://api.github.com/users/shumsky/orgs","repos_url":"https://api.github.com/users/shumsky/repos","events_url":"https://api.github.com/users/shumsky/events{/privacy}","received_events_url":"https://api.github.com/users/shumsky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shumsky/zipkin-js","description":"Zipkin instrumentation for Node.js and browsers","fork":true,"url":"https://api.github.com/repos/shumsky/zipkin-js","forks_url":"https://api.github.com/repos/shumsky/zipkin-js/forks","keys_url":"https://api.github.com/repos/shumsky/zipkin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shumsky/zipkin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shumsky/zipkin-js/teams","hooks_url":"https://api.github.com/repos/shumsky/zipkin-js/hooks","issue_events_url":"https://api.github.com/repos/shumsky/zipkin-js/issues/events{/number}","events_url":"https://api.github.com/repos/shumsky/zipkin-js/events","assignees_url":"https://api.github.com/repos/shumsky/zipkin-js/assignees{/user}","branches_url":"https://api.github.com/repos/shumsky/zipkin-js/branches{/branch}","tags_url":"https://api.github.com/repos/shumsky/zipkin-js/tags","blobs_url":"https://api.github.com/repos/shumsky/zipkin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shumsky/zipkin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shumsky/zipkin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/shumsky/zipkin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shumsky/zipkin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/shumsky/zipkin-js/languages","stargazers_url":"https://api.github.com/repos/shumsky/zipkin-js/stargazers","contributors_url":"https://api.github.com/repos/shumsky/zipkin-js/contributors","subscribers_url":"https://api.github.com/repos/shumsky/zipkin-js/subscribers","subscription_url":"https://api.github.com/repos/shumsky/zipkin-js/subscription","commits_url":"https://api.github.com/repos/shumsky/zipkin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/shumsky/zipkin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/shumsky/zipkin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/shumsky/zipkin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/shumsky/zipkin-js/contents/{+path}","compare_url":"https://api.github.com/repos/shumsky/zipkin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shumsky/zipkin-js/merges","archive_url":"https://api.github.com/repos/shumsky/zipkin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shumsky/zipkin-js/downloads","issues_url":"https://api.github.com/repos/shumsky/zipkin-js/issues{/number}","pulls_url":"https://api.github.com/repos/shumsky/zipkin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/shumsky/zipkin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/shumsky/zipkin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shumsky/zipkin-js/labels{/name}","releases_url":"https://api.github.com/repos/shumsky/zipkin-js/releases{/id}","deployments_url":"https://api.github.com/repos/shumsky/zipkin-js/deployments","created_at":"2017-09-21T21:54:05Z","updated_at":"2019-07-30T22:58:25Z","pushed_at":"2019-07-30T22:58:23Z","git_url":"git://github.com/shumsky/zipkin-js.git","ssh_url":"git@github.com:shumsky/zipkin-js.git","clone_url":"https://github.com/shumsky/zipkin-js.git","svn_url":"https://github.com/shumsky/zipkin-js","homepage":"","size":2321,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"664096fcdae2828936ef434f5b767179e640447e","user":{"login":"openzipkin","id":11860887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":58535548,"node_id":"MDEwOlJlcG9zaXRvcnk1ODUzNTU0OA==","name":"zipkin-js","full_name":"openzipkin/zipkin-js","private":false,"owner":{"login":"openzipkin","id":11860887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openzipkin/zipkin-js","description":"Zipkin instrumentation for Node.js and browsers","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-js","forks_url":"https://api.github.com/repos/openzipkin/zipkin-js/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-js/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-js/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-js/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-js/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-js/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-js/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-js/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-js/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-js/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-js/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-js/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-js/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-js/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-js/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-js/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-js/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-js/deployments","created_at":"2016-05-11T10:28:12Z","updated_at":"2019-07-30T04:39:36Z","pushed_at":"2019-07-30T22:58:24Z","git_url":"git://github.com/openzipkin/zipkin-js.git","ssh_url":"git@github.com:openzipkin/zipkin-js.git","clone_url":"https://github.com/openzipkin/zipkin-js.git","svn_url":"https://github.com/openzipkin/zipkin-js","homepage":"","size":2335,"stargazers_count":356,"watchers_count":356,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":66,"license":null,"forks":143,"open_issues":66,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/434"},"html":{"href":"https://github.com/openzipkin/zipkin-js/pull/434"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/issues/434"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/d2d1f0f436085e72dee0f4f58b1ff3d0aff34ca0"}},"author_association":"NONE"}}
|
{
"id": 58535548,
"name": "openzipkin/zipkin-js",
"url": "https://api.github.com/repos/openzipkin/zipkin-js"
}
|
{
"id": 64215,
"login": "adriancole",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/64215?",
"url": "https://api.github.com/users/adriancole"
}
|
{
"id": 11860887,
"login": "openzipkin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11860887?",
"url": "https://api.github.com/orgs/openzipkin"
}
| 2019-07-31T02:30:34 |
10116564305
|
{"actor":{"display_login":"adriancole"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/comments/307981031","pull_request_review_id":267485721,"id":307981031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzk4MTAzMQ==","diff_hunk":"@@ -0,0 +1,49 @@\n+{% set name = \"rospkg\" %}\n+{% set version = \"1.1.9\" %}\n+{% set sha256 = \"26a06e5ee07f305bc5e5ac2855fb779fc1207797bc4f9ce303f6d88e4c568fcc\" %}\n+\n+package:\n+ name: {{ name|lower }}\n+ version: {{ version }}\n+\n+source:\n+ fn: {{ name }}-{{ version }}.tar.gz\n+ url: https://github.com/ros-infrastructure/{{ name }}/archive/{{ version }}.tar.gz\n+ sha256: {{ sha256 }}\n+\n+build:\n+ number: 0\n+ script: {{ PYTHON }} -m pip install . --no-deps -vv\n+ noarch: python\n+ entry_points:\n+ - rosversion = rospkg.rosversion:main\n+\n+requirements:\n+ host:\n+ - python\n+ - pip\n+ - catkin_pkg","path":"recipes/rospkg/recipe/meta.yaml","position":null,"original_position":25,"commit_id":"f5e4d5ca944b26cdaf8eb2081890aa8e8bac27e4","original_commit_id":"cda48d1205f7ecfd754a791757cd939fe7a90e2b","user":{"login":"wolfv","id":885054,"node_id":"MDQ6VXNlcjg4NTA1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/885054?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfv","html_url":"https://github.com/wolfv","followers_url":"https://api.github.com/users/wolfv/followers","following_url":"https://api.github.com/users/wolfv/following{/other_user}","gists_url":"https://api.github.com/users/wolfv/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfv/subscriptions","organizations_url":"https://api.github.com/users/wolfv/orgs","repos_url":"https://api.github.com/users/wolfv/repos","events_url":"https://api.github.com/users/wolfv/events{/privacy}","received_events_url":"https://api.github.com/users/wolfv/received_events","type":"User","site_admin":false},"body":"removed them from host. let's see if it builds fine.","created_at":"2019-07-28T00:05:38Z","updated_at":"2019-07-28T00:05:38Z","html_url":"https://github.com/conda-forge/staged-recipes/pull/8952#discussion_r307981031","pull_request_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/8952","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/comments/307981031"},"html":{"href":"https://github.com/conda-forge/staged-recipes/pull/8952#discussion_r307981031"},"pull_request":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/8952"}},"in_reply_to_id":307971014},"pull_request":{"url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/8952","id":301769632,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNzY5NjMy","html_url":"https://github.com/conda-forge/staged-recipes/pull/8952","diff_url":"https://github.com/conda-forge/staged-recipes/pull/8952.diff","patch_url":"https://github.com/conda-forge/staged-recipes/pull/8952.patch","issue_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues/8952","number":8952,"state":"open","locked":false,"title":"add rospkg [ROS]","user":{"login":"wolfv","id":885054,"node_id":"MDQ6VXNlcjg4NTA1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/885054?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfv","html_url":"https://github.com/wolfv","followers_url":"https://api.github.com/users/wolfv/followers","following_url":"https://api.github.com/users/wolfv/following{/other_user}","gists_url":"https://api.github.com/users/wolfv/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfv/subscriptions","organizations_url":"https://api.github.com/users/wolfv/orgs","repos_url":"https://api.github.com/users/wolfv/repos","events_url":"https://api.github.com/users/wolfv/events{/privacy}","received_events_url":"https://api.github.com/users/wolfv/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you very much for putting in this recipe PR!\r\n\r\nThis repository is very active, so if you need help with\r\na PR or once it's ready for review, please let the right people know.\r\nThere are language-specific teams for reviewing recipes.\r\n\r\nCurrently available teams are:\r\n- python `@conda-forge/help-python`\r\n- python/c hybrid `@conda-forge/help-python-c`\r\n- r `@conda-forge/help-r`\r\n- java `@conda-forge/help-java`\r\n- nodejs `@conda-forge/help-nodejs`\r\n- c/c++ `@conda-forge/help-c-cpp`\r\n- perl `@conda-forge/help-perl`\r\n- Julia `@conda-forge/help-julia`\r\n\r\nIf your PR doesn't fall into those categories please contact\r\nthe full review team `@conda-forge/staged-recipes`.\r\n\r\nDue to GitHub limitations first time contributors to conda-forge are unable\r\nto ping these teams.\r\nConsider asking on our [Gitter channel](https://gitter.im/conda-forge/conda-forge.github.io)\r\nif your recipe isn't reviewed promptly.\r\n-->\r\n\r\nChecklist\r\n\r\n- [ ] License file is packaged (see [here](https://github.com/conda-forge/staged-recipes/blob/master/recipes/example/meta.yaml#L57-L66) for an example)\r\n- [ ] Source is from official source\r\n- [ ] Package does not vend other packages\r\n- [ ] Build number is 0\r\n- [ ] A tarball (`url`) rather than a repo (e.g. `git_url`) is used in your\r\n recipe (see\r\n [here](https://conda-forge.org/docs/maintainer/adding_pkgs.html#build-from-tarballs-not-repos)\r\n for more details)\r\n- [ ] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there\r\n","created_at":"2019-07-27T16:21:35Z","updated_at":"2019-07-28T00:05:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5762c6fc2d8ba8e0c160aef7d3af30ff3067f51f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/8952/commits","review_comments_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/8952/comments","review_comment_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues/8952/comments","statuses_url":"https://api.github.com/repos/conda-forge/staged-recipes/statuses/f5e4d5ca944b26cdaf8eb2081890aa8e8bac27e4","head":{"label":"wolfv:add_rospkg","ref":"add_rospkg","sha":"f5e4d5ca944b26cdaf8eb2081890aa8e8bac27e4","user":{"login":"wolfv","id":885054,"node_id":"MDQ6VXNlcjg4NTA1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/885054?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfv","html_url":"https://github.com/wolfv","followers_url":"https://api.github.com/users/wolfv/followers","following_url":"https://api.github.com/users/wolfv/following{/other_user}","gists_url":"https://api.github.com/users/wolfv/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfv/subscriptions","organizations_url":"https://api.github.com/users/wolfv/orgs","repos_url":"https://api.github.com/users/wolfv/repos","events_url":"https://api.github.com/users/wolfv/events{/privacy}","received_events_url":"https://api.github.com/users/wolfv/received_events","type":"User","site_admin":false},"repo":{"id":175261968,"node_id":"MDEwOlJlcG9zaXRvcnkxNzUyNjE5Njg=","name":"staged-recipes","full_name":"wolfv/staged-recipes","private":false,"owner":{"login":"wolfv","id":885054,"node_id":"MDQ6VXNlcjg4NTA1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/885054?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfv","html_url":"https://github.com/wolfv","followers_url":"https://api.github.com/users/wolfv/followers","following_url":"https://api.github.com/users/wolfv/following{/other_user}","gists_url":"https://api.github.com/users/wolfv/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfv/subscriptions","organizations_url":"https://api.github.com/users/wolfv/orgs","repos_url":"https://api.github.com/users/wolfv/repos","events_url":"https://api.github.com/users/wolfv/events{/privacy}","received_events_url":"https://api.github.com/users/wolfv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wolfv/staged-recipes","description":"A place to submit conda recipes before they become fully fledged conda-forge feedstocks","fork":true,"url":"https://api.github.com/repos/wolfv/staged-recipes","forks_url":"https://api.github.com/repos/wolfv/staged-recipes/forks","keys_url":"https://api.github.com/repos/wolfv/staged-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolfv/staged-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolfv/staged-recipes/teams","hooks_url":"https://api.github.com/repos/wolfv/staged-recipes/hooks","issue_events_url":"https://api.github.com/repos/wolfv/staged-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/wolfv/staged-recipes/events","assignees_url":"https://api.github.com/repos/wolfv/staged-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/wolfv/staged-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/wolfv/staged-recipes/tags","blobs_url":"https://api.github.com/repos/wolfv/staged-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolfv/staged-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolfv/staged-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolfv/staged-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolfv/staged-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/wolfv/staged-recipes/languages","stargazers_url":"https://api.github.com/repos/wolfv/staged-recipes/stargazers","contributors_url":"https://api.github.com/repos/wolfv/staged-recipes/contributors","subscribers_url":"https://api.github.com/repos/wolfv/staged-recipes/subscribers","subscription_url":"https://api.github.com/repos/wolfv/staged-recipes/subscription","commits_url":"https://api.github.com/repos/wolfv/staged-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolfv/staged-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolfv/staged-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolfv/staged-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolfv/staged-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/wolfv/staged-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolfv/staged-recipes/merges","archive_url":"https://api.github.com/repos/wolfv/staged-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolfv/staged-recipes/downloads","issues_url":"https://api.github.com/repos/wolfv/staged-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/wolfv/staged-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/wolfv/staged-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/wolfv/staged-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolfv/staged-recipes/labels{/name}","releases_url":"https://api.github.com/repos/wolfv/staged-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/wolfv/staged-recipes/deployments","created_at":"2019-03-12T17:15:02Z","updated_at":"2019-07-27T09:21:54Z","pushed_at":"2019-07-28T00:04:37Z","git_url":"git://github.com/wolfv/staged-recipes.git","ssh_url":"git@github.com:wolfv/staged-recipes.git","clone_url":"https://github.com/wolfv/staged-recipes.git","svn_url":"https://github.com/wolfv/staged-recipes","homepage":"https://conda-forge.org","size":30506,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"conda-forge:master","ref":"master","sha":"158b1af6f933320b0fa8ff619746429a3ff73891","user":{"login":"conda-forge","id":11897326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODk3MzI2","avatar_url":"https://avatars3.githubusercontent.com/u/11897326?v=4","gravatar_id":"","url":"https://api.github.com/users/conda-forge","html_url":"https://github.com/conda-forge","followers_url":"https://api.github.com/users/conda-forge/followers","following_url":"https://api.github.com/users/conda-forge/following{/other_user}","gists_url":"https://api.github.com/users/conda-forge/gists{/gist_id}","starred_url":"https://api.github.com/users/conda-forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda-forge/subscriptions","organizations_url":"https://api.github.com/users/conda-forge/orgs","repos_url":"https://api.github.com/users/conda-forge/repos","events_url":"https://api.github.com/users/conda-forge/events{/privacy}","received_events_url":"https://api.github.com/users/conda-forge/received_events","type":"Organization","site_admin":false},"repo":{"id":41829476,"node_id":"MDEwOlJlcG9zaXRvcnk0MTgyOTQ3Ng==","name":"staged-recipes","full_name":"conda-forge/staged-recipes","private":false,"owner":{"login":"conda-forge","id":11897326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODk3MzI2","avatar_url":"https://avatars3.githubusercontent.com/u/11897326?v=4","gravatar_id":"","url":"https://api.github.com/users/conda-forge","html_url":"https://github.com/conda-forge","followers_url":"https://api.github.com/users/conda-forge/followers","following_url":"https://api.github.com/users/conda-forge/following{/other_user}","gists_url":"https://api.github.com/users/conda-forge/gists{/gist_id}","starred_url":"https://api.github.com/users/conda-forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda-forge/subscriptions","organizations_url":"https://api.github.com/users/conda-forge/orgs","repos_url":"https://api.github.com/users/conda-forge/repos","events_url":"https://api.github.com/users/conda-forge/events{/privacy}","received_events_url":"https://api.github.com/users/conda-forge/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/conda-forge/staged-recipes","description":"A place to submit conda recipes before they become fully fledged conda-forge feedstocks","fork":false,"url":"https://api.github.com/repos/conda-forge/staged-recipes","forks_url":"https://api.github.com/repos/conda-forge/staged-recipes/forks","keys_url":"https://api.github.com/repos/conda-forge/staged-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conda-forge/staged-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conda-forge/staged-recipes/teams","hooks_url":"https://api.github.com/repos/conda-forge/staged-recipes/hooks","issue_events_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/conda-forge/staged-recipes/events","assignees_url":"https://api.github.com/repos/conda-forge/staged-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/conda-forge/staged-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/conda-forge/staged-recipes/tags","blobs_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conda-forge/staged-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/conda-forge/staged-recipes/languages","stargazers_url":"https://api.github.com/repos/conda-forge/staged-recipes/stargazers","contributors_url":"https://api.github.com/repos/conda-forge/staged-recipes/contributors","subscribers_url":"https://api.github.com/repos/conda-forge/staged-recipes/subscribers","subscription_url":"https://api.github.com/repos/conda-forge/staged-recipes/subscription","commits_url":"https://api.github.com/repos/conda-forge/staged-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/conda-forge/staged-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/conda-forge/staged-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/conda-forge/staged-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conda-forge/staged-recipes/merges","archive_url":"https://api.github.com/repos/conda-forge/staged-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conda-forge/staged-recipes/downloads","issues_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/conda-forge/staged-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/conda-forge/staged-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conda-forge/staged-recipes/labels{/name}","releases_url":"https://api.github.com/repos/conda-forge/staged-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/conda-forge/staged-recipes/deployments","created_at":"2015-09-02T21:49:20Z","updated_at":"2019-07-27T22:16:41Z","pushed_at":"2019-07-28T00:04:39Z","git_url":"git://github.com/conda-forge/staged-recipes.git","ssh_url":"git@github.com:conda-forge/staged-recipes.git","clone_url":"https://github.com/conda-forge/staged-recipes.git","svn_url":"https://github.com/conda-forge/staged-recipes","homepage":"https://conda-forge.org","size":30538,"stargazers_count":262,"watchers_count":262,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1384,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":640,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1384,"open_issues":640,"watchers":262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/8952"},"html":{"href":"https://github.com/conda-forge/staged-recipes/pull/8952"},"issue":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/issues/8952"},"comments":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/issues/8952/comments"},"review_comments":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/8952/comments"},"review_comment":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/8952/commits"},"statuses":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/statuses/f5e4d5ca944b26cdaf8eb2081890aa8e8bac27e4"}},"author_association":"MEMBER"}}
|
{
"id": 41829476,
"name": "conda-forge/staged-recipes",
"url": "https://api.github.com/repos/conda-forge/staged-recipes"
}
|
{
"id": 885054,
"login": "wolfv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/885054?",
"url": "https://api.github.com/users/wolfv"
}
|
{
"id": 11897326,
"login": "conda-forge",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11897326?",
"url": "https://api.github.com/orgs/conda-forge"
}
| 2019-07-28T00:05:38 |
10096995506
|
{"actor":{"display_login":"wolfv"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/comments/276316645","pull_request_review_id":227849224,"id":276316645,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NjMxNjY0NQ==","diff_hunk":"@@ -82,12 +82,30 @@ export class WMSDataSource extends DataSource {\n options.sourceFields = [];\n }\n \n+ if (sourceParams.layers.split(',').length > 1 && this.options\n+ && (this.options as OgcFilterableDataSourceOptions).ogcFilters\n+ && (this.options as OgcFilterableDataSourceOptions).ogcFilters.enabled) {\n+ console.log('*******************************');\n+ console.log('BE CAREFULL, YOUR WMS LAYERS (' + sourceParams.layers\n+ + ') MUST SHARE THE SAME FIELDS TO ALLOW ogcFilters TO WORK !! ');\n+ console.log('*******************************');\n+ }\n+\n if (this.options\n && (this.options as OgcFilterableDataSourceOptions).ogcFilters\n && (this.options as OgcFilterableDataSourceOptions).ogcFilters.enabled\n && (this.options as OgcFilterableDataSourceOptions).ogcFilters.filters) {\n const filters = (this.options as OgcFilterableDataSourceOptions).ogcFilters.filters;\n- this.ol.updateParams({ filter: this.ogcFilterWriter.buildFilter(filters) });\n+ const rebuildFilter = this.ogcFilterWriter.buildFilter(filters);\n+ let appliedFilter = '';\n+ if (rebuildFilter.length > 0 && sourceParams.layers.indexOf(',') !== -1) {\n+ sourceParams.layers.split(',').forEach(element => {","path":"packages/geo/src/lib/datasource/shared/datasources/wms-datasource.ts","position":22,"original_position":22,"commit_id":"94faf9cadc41fd07661946b1bced372bcfb00456","original_commit_id":"94faf9cadc41fd07661946b1bced372bcfb00456","user":{"login":"pelord","id":7397743,"node_id":"MDQ6VXNlcjczOTc3NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7397743?v=4","gravatar_id":"","url":"https://api.github.com/users/pelord","html_url":"https://github.com/pelord","followers_url":"https://api.github.com/users/pelord/followers","following_url":"https://api.github.com/users/pelord/following{/other_user}","gists_url":"https://api.github.com/users/pelord/gists{/gist_id}","starred_url":"https://api.github.com/users/pelord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelord/subscriptions","organizations_url":"https://api.github.com/users/pelord/orgs","repos_url":"https://api.github.com/users/pelord/repos","events_url":"https://api.github.com/users/pelord/events{/privacy}","received_events_url":"https://api.github.com/users/pelord/received_events","type":"User","site_admin":false},"body":"Yes.","created_at":"2019-04-17T15:59:20Z","updated_at":"2019-04-17T15:59:21Z","html_url":"https://github.com/infra-geo-ouverte/igo2-lib/pull/296#discussion_r276316645","pull_request_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/296","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/comments/276316645"},"html":{"href":"https://github.com/infra-geo-ouverte/igo2-lib/pull/296#discussion_r276316645"},"pull_request":{"href":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/296"}},"in_reply_to_id":276304398},"pull_request":{"url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/296","id":271308324,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxMzA4MzI0","html_url":"https://github.com/infra-geo-ouverte/igo2-lib/pull/296","diff_url":"https://github.com/infra-geo-ouverte/igo2-lib/pull/296.diff","patch_url":"https://github.com/infra-geo-ouverte/igo2-lib/pull/296.patch","issue_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues/296","number":296,"state":"open","locked":false,"title":"Apply same filter on WMS layer with grouped layers (comma separated) ","user":{"login":"pelord","id":7397743,"node_id":"MDQ6VXNlcjczOTc3NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7397743?v=4","gravatar_id":"","url":"https://api.github.com/users/pelord","html_url":"https://github.com/pelord","followers_url":"https://api.github.com/users/pelord/followers","following_url":"https://api.github.com/users/pelord/following{/other_user}","gists_url":"https://api.github.com/users/pelord/gists{/gist_id}","starred_url":"https://api.github.com/users/pelord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelord/subscriptions","organizations_url":"https://api.github.com/users/pelord/orgs","repos_url":"https://api.github.com/users/pelord/repos","events_url":"https://api.github.com/users/pelord/events{/privacy}","received_events_url":"https://api.github.com/users/pelord/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines:https://github.com/infra-geo-ouverte/igo2/blob/master/.github/CONTRIBUTING.md#git-commit-guidelines\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\nWhen you filter a wms layer built from 2 layers\r\n\r\n, filter do not work because you try to apply a single filter on 2 layers...\r\n\r\n**What is the new behavior?**\r\nRepeating the filter into the url for every filter.\r\nEx:\r\n\r\n```\r\n \"params\": {\r\n \"layers\": \"layerA,layerB\"\r\n },\r\n```\r\n\r\nwill build a url like : ...&filter=(...filterforlayerA...)(...filterforlayerB...)\r\n\r\nYour layers MUST share the same fields. You can control the fields by this property\r\n\r\n```\r\n \"sourceFields\": [\r\n {\"alias\":\"Alias1\",\"name\": \"name1\", \"values\": [\"value1\",\"value2\",\"value3\"]},\r\n {\"alias\":\"Alias2\",\"name\": \"name2\", \"values\": [1,2,3,4,5,6,7,8]},\r\n ]\r\n```\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications:\r\n\r\n\r\n**Other information**:\r\n","created_at":"2019-04-17T13:29:06Z","updated_at":"2019-04-17T15:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f031cca7780736c21abba18eb516eb800a356be6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/296/commits","review_comments_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/296/comments","review_comment_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues/296/comments","statuses_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/statuses/94faf9cadc41fd07661946b1bced372bcfb00456","head":{"label":"infra-geo-ouverte:multipleLayersFilterAlpha","ref":"multipleLayersFilterAlpha","sha":"94faf9cadc41fd07661946b1bced372bcfb00456","user":{"login":"infra-geo-ouverte","id":11967037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTY3MDM3","avatar_url":"https://avatars0.githubusercontent.com/u/11967037?v=4","gravatar_id":"","url":"https://api.github.com/users/infra-geo-ouverte","html_url":"https://github.com/infra-geo-ouverte","followers_url":"https://api.github.com/users/infra-geo-ouverte/followers","following_url":"https://api.github.com/users/infra-geo-ouverte/following{/other_user}","gists_url":"https://api.github.com/users/infra-geo-ouverte/gists{/gist_id}","starred_url":"https://api.github.com/users/infra-geo-ouverte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infra-geo-ouverte/subscriptions","organizations_url":"https://api.github.com/users/infra-geo-ouverte/orgs","repos_url":"https://api.github.com/users/infra-geo-ouverte/repos","events_url":"https://api.github.com/users/infra-geo-ouverte/events{/privacy}","received_events_url":"https://api.github.com/users/infra-geo-ouverte/received_events","type":"Organization","site_admin":false},"repo":{"id":87442996,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQ0Mjk5Ng==","name":"igo2-lib","full_name":"infra-geo-ouverte/igo2-lib","private":false,"owner":{"login":"infra-geo-ouverte","id":11967037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTY3MDM3","avatar_url":"https://avatars0.githubusercontent.com/u/11967037?v=4","gravatar_id":"","url":"https://api.github.com/users/infra-geo-ouverte","html_url":"https://github.com/infra-geo-ouverte","followers_url":"https://api.github.com/users/infra-geo-ouverte/followers","following_url":"https://api.github.com/users/infra-geo-ouverte/following{/other_user}","gists_url":"https://api.github.com/users/infra-geo-ouverte/gists{/gist_id}","starred_url":"https://api.github.com/users/infra-geo-ouverte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infra-geo-ouverte/subscriptions","organizations_url":"https://api.github.com/users/infra-geo-ouverte/orgs","repos_url":"https://api.github.com/users/infra-geo-ouverte/repos","events_url":"https://api.github.com/users/infra-geo-ouverte/events{/privacy}","received_events_url":"https://api.github.com/users/infra-geo-ouverte/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/infra-geo-ouverte/igo2-lib","description":"Librairie Infrastructure Géomatique Ouverte 2.0 (IGO-2) / Open GIS Infrastructure 2.0 Library","fork":false,"url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib","forks_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/forks","keys_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/teams","hooks_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/hooks","issue_events_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues/events{/number}","events_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/events","assignees_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/assignees{/user}","branches_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/branches{/branch}","tags_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/tags","blobs_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/languages","stargazers_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/stargazers","contributors_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/contributors","subscribers_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/subscribers","subscription_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/subscription","commits_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/contents/{+path}","compare_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/merges","archive_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/downloads","issues_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues{/number}","pulls_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/labels{/name}","releases_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/releases{/id}","deployments_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/deployments","created_at":"2017-04-06T15:07:50Z","updated_at":"2019-03-19T20:15:21Z","pushed_at":"2019-04-17T13:29:07Z","git_url":"git://github.com/infra-geo-ouverte/igo2-lib.git","ssh_url":"git@github.com:infra-geo-ouverte/igo2-lib.git","clone_url":"https://github.com/infra-geo-ouverte/igo2-lib.git","svn_url":"https://github.com/infra-geo-ouverte/igo2-lib","homepage":"","size":8582,"stargazers_count":16,"watchers_count":16,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":33,"license":null,"forks":14,"open_issues":33,"watchers":16,"default_branch":"master"}},"base":{"label":"infra-geo-ouverte:1.0.0-alpha.1","ref":"1.0.0-alpha.1","sha":"b74f9aa4bc0dc9f60d63f70c5ec2a5c680c15b10","user":{"login":"infra-geo-ouverte","id":11967037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTY3MDM3","avatar_url":"https://avatars0.githubusercontent.com/u/11967037?v=4","gravatar_id":"","url":"https://api.github.com/users/infra-geo-ouverte","html_url":"https://github.com/infra-geo-ouverte","followers_url":"https://api.github.com/users/infra-geo-ouverte/followers","following_url":"https://api.github.com/users/infra-geo-ouverte/following{/other_user}","gists_url":"https://api.github.com/users/infra-geo-ouverte/gists{/gist_id}","starred_url":"https://api.github.com/users/infra-geo-ouverte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infra-geo-ouverte/subscriptions","organizations_url":"https://api.github.com/users/infra-geo-ouverte/orgs","repos_url":"https://api.github.com/users/infra-geo-ouverte/repos","events_url":"https://api.github.com/users/infra-geo-ouverte/events{/privacy}","received_events_url":"https://api.github.com/users/infra-geo-ouverte/received_events","type":"Organization","site_admin":false},"repo":{"id":87442996,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQ0Mjk5Ng==","name":"igo2-lib","full_name":"infra-geo-ouverte/igo2-lib","private":false,"owner":{"login":"infra-geo-ouverte","id":11967037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTY3MDM3","avatar_url":"https://avatars0.githubusercontent.com/u/11967037?v=4","gravatar_id":"","url":"https://api.github.com/users/infra-geo-ouverte","html_url":"https://github.com/infra-geo-ouverte","followers_url":"https://api.github.com/users/infra-geo-ouverte/followers","following_url":"https://api.github.com/users/infra-geo-ouverte/following{/other_user}","gists_url":"https://api.github.com/users/infra-geo-ouverte/gists{/gist_id}","starred_url":"https://api.github.com/users/infra-geo-ouverte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infra-geo-ouverte/subscriptions","organizations_url":"https://api.github.com/users/infra-geo-ouverte/orgs","repos_url":"https://api.github.com/users/infra-geo-ouverte/repos","events_url":"https://api.github.com/users/infra-geo-ouverte/events{/privacy}","received_events_url":"https://api.github.com/users/infra-geo-ouverte/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/infra-geo-ouverte/igo2-lib","description":"Librairie Infrastructure Géomatique Ouverte 2.0 (IGO-2) / Open GIS Infrastructure 2.0 Library","fork":false,"url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib","forks_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/forks","keys_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/teams","hooks_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/hooks","issue_events_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues/events{/number}","events_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/events","assignees_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/assignees{/user}","branches_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/branches{/branch}","tags_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/tags","blobs_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/languages","stargazers_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/stargazers","contributors_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/contributors","subscribers_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/subscribers","subscription_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/subscription","commits_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/contents/{+path}","compare_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/merges","archive_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/downloads","issues_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues{/number}","pulls_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/labels{/name}","releases_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/releases{/id}","deployments_url":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/deployments","created_at":"2017-04-06T15:07:50Z","updated_at":"2019-03-19T20:15:21Z","pushed_at":"2019-04-17T13:29:07Z","git_url":"git://github.com/infra-geo-ouverte/igo2-lib.git","ssh_url":"git@github.com:infra-geo-ouverte/igo2-lib.git","clone_url":"https://github.com/infra-geo-ouverte/igo2-lib.git","svn_url":"https://github.com/infra-geo-ouverte/igo2-lib","homepage":"","size":8582,"stargazers_count":16,"watchers_count":16,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":33,"license":null,"forks":14,"open_issues":33,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/296"},"html":{"href":"https://github.com/infra-geo-ouverte/igo2-lib/pull/296"},"issue":{"href":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues/296"},"comments":{"href":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/infra-geo-ouverte/igo2-lib/statuses/94faf9cadc41fd07661946b1bced372bcfb00456"}},"author_association":"MEMBER"}}
|
{
"id": 87442996,
"name": "infra-geo-ouverte/igo2-lib",
"url": "https://api.github.com/repos/infra-geo-ouverte/igo2-lib"
}
|
{
"id": 7397743,
"login": "pelord",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7397743?",
"url": "https://api.github.com/users/pelord"
}
|
{
"id": 11967037,
"login": "infra-geo-ouverte",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11967037?",
"url": "https://api.github.com/orgs/infra-geo-ouverte"
}
| 2019-04-17T15:59:20 |
9462706831
|
{"actor":{"display_login":"pelord"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/portworx/dcos-commons/pulls/comments/253169991","pull_request_review_id":199229782,"id":253169991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzE2OTk5MQ==","diff_hunk":"@@ -11,25 +11,25 @@ network.publish_host:\n - _local_\n cluster.name: {{CLUSTER_NAME}}\n node.name: {{TASK_NAME}}\n-path.data: \"${MESOS_SANDBOX}/container-path/data\"\n-path.logs: \"${MESOS_SANDBOX}/container-path/logs\"\n+path.data: \"{MESOS_SANDBOX}/container-path/data\"\n+path.logs: \"{MESOS_SANDBOX}/container-path/logs\"","path":"frameworks/elastic/src/main/dist/elasticsearch.yml","position":7,"original_position":7,"commit_id":"9f6fa23b1ddb8f43a0b866b77eba422bc506fb77","original_commit_id":"9f6fa23b1ddb8f43a0b866b77eba422bc506fb77","user":{"login":"piyush-nimbalkar","id":313758,"node_id":"MDQ6VXNlcjMxMzc1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/313758?v=4","gravatar_id":"","url":"https://api.github.com/users/piyush-nimbalkar","html_url":"https://github.com/piyush-nimbalkar","followers_url":"https://api.github.com/users/piyush-nimbalkar/followers","following_url":"https://api.github.com/users/piyush-nimbalkar/following{/other_user}","gists_url":"https://api.github.com/users/piyush-nimbalkar/gists{/gist_id}","starred_url":"https://api.github.com/users/piyush-nimbalkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyush-nimbalkar/subscriptions","organizations_url":"https://api.github.com/users/piyush-nimbalkar/orgs","repos_url":"https://api.github.com/users/piyush-nimbalkar/repos","events_url":"https://api.github.com/users/piyush-nimbalkar/events{/privacy}","received_events_url":"https://api.github.com/users/piyush-nimbalkar/received_events","type":"User","site_admin":false},"body":"Same here","created_at":"2019-02-01T19:24:00Z","updated_at":"2019-02-01T19:39:51Z","html_url":"https://github.com/portworx/dcos-commons/pull/97#discussion_r253169991","pull_request_url":"https://api.github.com/repos/portworx/dcos-commons/pulls/97","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/portworx/dcos-commons/pulls/comments/253169991"},"html":{"href":"https://github.com/portworx/dcos-commons/pull/97#discussion_r253169991"},"pull_request":{"href":"https://api.github.com/repos/portworx/dcos-commons/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/portworx/dcos-commons/pulls/97","id":248638368,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ4NjM4MzY4","html_url":"https://github.com/portworx/dcos-commons/pull/97","diff_url":"https://github.com/portworx/dcos-commons/pull/97.diff","patch_url":"https://github.com/portworx/dcos-commons/pull/97.patch","issue_url":"https://api.github.com/repos/portworx/dcos-commons/issues/97","number":97,"state":"open","locked":false,"title":"Elaticsearch 6.3.2 framework with portworx support for DCOS","user":{"login":"tusharraut1994","id":8976460,"node_id":"MDQ6VXNlcjg5NzY0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8976460?v=4","gravatar_id":"","url":"https://api.github.com/users/tusharraut1994","html_url":"https://github.com/tusharraut1994","followers_url":"https://api.github.com/users/tusharraut1994/followers","following_url":"https://api.github.com/users/tusharraut1994/following{/other_user}","gists_url":"https://api.github.com/users/tusharraut1994/gists{/gist_id}","starred_url":"https://api.github.com/users/tusharraut1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tusharraut1994/subscriptions","organizations_url":"https://api.github.com/users/tusharraut1994/orgs","repos_url":"https://api.github.com/users/tusharraut1994/repos","events_url":"https://api.github.com/users/tusharraut1994/events{/privacy}","received_events_url":"https://api.github.com/users/tusharraut1994/received_events","type":"User","site_admin":false},"body":"Initial commit.\r\nVerified the changes on my DCOS cluster.","created_at":"2019-01-29T19:58:41Z","updated_at":"2019-02-01T19:39:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14d3d65e85c565db4fd7274e728757495a615d44","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hrishipx","id":34462127,"node_id":"MDQ6VXNlcjM0NDYyMTI3","avatar_url":"https://avatars0.githubusercontent.com/u/34462127?v=4","gravatar_id":"","url":"https://api.github.com/users/hrishipx","html_url":"https://github.com/hrishipx","followers_url":"https://api.github.com/users/hrishipx/followers","following_url":"https://api.github.com/users/hrishipx/following{/other_user}","gists_url":"https://api.github.com/users/hrishipx/gists{/gist_id}","starred_url":"https://api.github.com/users/hrishipx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrishipx/subscriptions","organizations_url":"https://api.github.com/users/hrishipx/orgs","repos_url":"https://api.github.com/users/hrishipx/repos","events_url":"https://api.github.com/users/hrishipx/events{/privacy}","received_events_url":"https://api.github.com/users/hrishipx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/portworx/dcos-commons/pulls/97/commits","review_comments_url":"https://api.github.com/repos/portworx/dcos-commons/pulls/97/comments","review_comment_url":"https://api.github.com/repos/portworx/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/portworx/dcos-commons/issues/97/comments","statuses_url":"https://api.github.com/repos/portworx/dcos-commons/statuses/9f6fa23b1ddb8f43a0b866b77eba422bc506fb77","head":{"label":"portworx:tushar-es6x","ref":"tushar-es6x","sha":"9f6fa23b1ddb8f43a0b866b77eba422bc506fb77","user":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"repo":{"id":88918662,"node_id":"MDEwOlJlcG9zaXRvcnk4ODkxODY2Mg==","name":"dcos-commons","full_name":"portworx/dcos-commons","private":false,"owner":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/portworx/dcos-commons","description":null,"fork":true,"url":"https://api.github.com/repos/portworx/dcos-commons","forks_url":"https://api.github.com/repos/portworx/dcos-commons/forks","keys_url":"https://api.github.com/repos/portworx/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portworx/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portworx/dcos-commons/teams","hooks_url":"https://api.github.com/repos/portworx/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/portworx/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/portworx/dcos-commons/events","assignees_url":"https://api.github.com/repos/portworx/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/portworx/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/portworx/dcos-commons/tags","blobs_url":"https://api.github.com/repos/portworx/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portworx/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portworx/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/portworx/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portworx/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/portworx/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/portworx/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/portworx/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/portworx/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/portworx/dcos-commons/subscription","commits_url":"https://api.github.com/repos/portworx/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/portworx/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/portworx/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/portworx/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/portworx/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/portworx/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portworx/dcos-commons/merges","archive_url":"https://api.github.com/repos/portworx/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portworx/dcos-commons/downloads","issues_url":"https://api.github.com/repos/portworx/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/portworx/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/portworx/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/portworx/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portworx/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/portworx/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/portworx/dcos-commons/deployments","created_at":"2017-04-20T23:17:22Z","updated_at":"2018-03-27T05:56:23Z","pushed_at":"2019-01-30T01:13:03Z","git_url":"git://github.com/portworx/dcos-commons.git","ssh_url":"git@github.com:portworx/dcos-commons.git","clone_url":"https://github.com/portworx/dcos-commons.git","svn_url":"https://github.com/portworx/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":62142,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"portworx:px_1.3_0.40.5","ref":"px_1.3_0.40.5","sha":"17bb8c03c9874140e29b2e7f6797c3275210d680","user":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"repo":{"id":88918662,"node_id":"MDEwOlJlcG9zaXRvcnk4ODkxODY2Mg==","name":"dcos-commons","full_name":"portworx/dcos-commons","private":false,"owner":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/portworx/dcos-commons","description":null,"fork":true,"url":"https://api.github.com/repos/portworx/dcos-commons","forks_url":"https://api.github.com/repos/portworx/dcos-commons/forks","keys_url":"https://api.github.com/repos/portworx/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portworx/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portworx/dcos-commons/teams","hooks_url":"https://api.github.com/repos/portworx/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/portworx/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/portworx/dcos-commons/events","assignees_url":"https://api.github.com/repos/portworx/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/portworx/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/portworx/dcos-commons/tags","blobs_url":"https://api.github.com/repos/portworx/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portworx/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portworx/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/portworx/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portworx/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/portworx/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/portworx/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/portworx/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/portworx/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/portworx/dcos-commons/subscription","commits_url":"https://api.github.com/repos/portworx/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/portworx/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/portworx/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/portworx/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/portworx/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/portworx/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portworx/dcos-commons/merges","archive_url":"https://api.github.com/repos/portworx/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portworx/dcos-commons/downloads","issues_url":"https://api.github.com/repos/portworx/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/portworx/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/portworx/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/portworx/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portworx/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/portworx/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/portworx/dcos-commons/deployments","created_at":"2017-04-20T23:17:22Z","updated_at":"2018-03-27T05:56:23Z","pushed_at":"2019-01-30T01:13:03Z","git_url":"git://github.com/portworx/dcos-commons.git","ssh_url":"git@github.com:portworx/dcos-commons.git","clone_url":"https://github.com/portworx/dcos-commons.git","svn_url":"https://github.com/portworx/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":62142,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/portworx/dcos-commons/pulls/97"},"html":{"href":"https://github.com/portworx/dcos-commons/pull/97"},"issue":{"href":"https://api.github.com/repos/portworx/dcos-commons/issues/97"},"comments":{"href":"https://api.github.com/repos/portworx/dcos-commons/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/portworx/dcos-commons/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/portworx/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/portworx/dcos-commons/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/portworx/dcos-commons/statuses/9f6fa23b1ddb8f43a0b866b77eba422bc506fb77"}},"author_association":"NONE"}}
|
{
"id": 88918662,
"name": "portworx/dcos-commons",
"url": "https://api.github.com/repos/portworx/dcos-commons"
}
|
{
"id": 313758,
"login": "piyush-nimbalkar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/313758?",
"url": "https://api.github.com/users/piyush-nimbalkar"
}
|
{
"id": 12014092,
"login": "portworx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12014092?",
"url": "https://api.github.com/orgs/portworx"
}
| 2019-02-01T19:24:00 |
8995021383
|
{"actor":{"display_login":"piyush-nimbalkar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/portworx/torpedo/pulls/comments/365022846","pull_request_review_id":340893843,"id":365022846,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTAyMjg0Ng==","diff_hunk":"@@ -0,0 +1,26 @@\n+##### Portworx storage class\n+kind: StorageClass\n+apiVersion: storage.k8s.io/v1\n+metadata:\n+ name: px-postgres-sc\n+provisioner: kubernetes.io/portworx-volume\n+parameters:\n+ repl: \"3\"\n+ priority_io: \"high\"\n+ shared: \"true\"\n+allowVolumeExpansion: true\n+---\n+##### Portworx persistent volume claim\n+kind: PersistentVolumeClaim\n+apiVersion: v1\n+metadata:\n+ name: postgres-data\n+ annotations:\n+ volume.beta.kubernetes.io/storage-class: px-postgres-sc","path":"drivers/scheduler/k8s/specs/aut-postgres/aut-postgres-storage.yaml","position":19,"original_position":19,"commit_id":"f5a09d2316011c10228476f2eb5f40a6d6a5a7ab","original_commit_id":"f5a09d2316011c10228476f2eb5f40a6d6a5a7ab","user":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"body":"instead of the annotation, use storageClassName in the spec.","created_at":"2020-01-10T00:20:58Z","updated_at":"2020-01-10T00:37:24Z","html_url":"https://github.com/portworx/torpedo/pull/390#discussion_r365022846","pull_request_url":"https://api.github.com/repos/portworx/torpedo/pulls/390","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/portworx/torpedo/pulls/comments/365022846"},"html":{"href":"https://github.com/portworx/torpedo/pull/390#discussion_r365022846"},"pull_request":{"href":"https://api.github.com/repos/portworx/torpedo/pulls/390"}}},"pull_request":{"url":"https://api.github.com/repos/portworx/torpedo/pulls/390","id":359122843,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5MTIyODQz","html_url":"https://github.com/portworx/torpedo/pull/390","diff_url":"https://github.com/portworx/torpedo/pull/390.diff","patch_url":"https://github.com/portworx/torpedo/pull/390.patch","issue_url":"https://api.github.com/repos/portworx/torpedo/issues/390","number":390,"state":"open","locked":false,"title":"PTX-2097 Implement calculation of Storage Pool sizes","user":{"login":"mborodin-px","id":49766650,"node_id":"MDQ6VXNlcjQ5NzY2NjUw","avatar_url":"https://avatars3.githubusercontent.com/u/49766650?v=4","gravatar_id":"","url":"https://api.github.com/users/mborodin-px","html_url":"https://github.com/mborodin-px","followers_url":"https://api.github.com/users/mborodin-px/followers","following_url":"https://api.github.com/users/mborodin-px/following{/other_user}","gists_url":"https://api.github.com/users/mborodin-px/gists{/gist_id}","starred_url":"https://api.github.com/users/mborodin-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mborodin-px/subscriptions","organizations_url":"https://api.github.com/users/mborodin-px/orgs","repos_url":"https://api.github.com/users/mborodin-px/repos","events_url":"https://api.github.com/users/mborodin-px/events{/privacy}","received_events_url":"https://api.github.com/users/mborodin-px/received_events","type":"User","site_admin":false},"body":"Implementation of Storage Pools size calculation based on app workload and autopilot rule\r\n\r\nPlease don't review createAutopilotRule method in drivers/scheduler/k8s/k8s.go as I'm still working on calculation of PVC size which is PTX-2096.\r\n\r\nSigned-off-by: Maksym Borodin <maksym@portworx.com>","created_at":"2020-01-03T21:05:11Z","updated_at":"2020-01-10T00:37:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db9362db2d85fe61e3d119b4d9eb70273aafed91","assignee":{"login":"mborodin-px","id":49766650,"node_id":"MDQ6VXNlcjQ5NzY2NjUw","avatar_url":"https://avatars3.githubusercontent.com/u/49766650?v=4","gravatar_id":"","url":"https://api.github.com/users/mborodin-px","html_url":"https://github.com/mborodin-px","followers_url":"https://api.github.com/users/mborodin-px/followers","following_url":"https://api.github.com/users/mborodin-px/following{/other_user}","gists_url":"https://api.github.com/users/mborodin-px/gists{/gist_id}","starred_url":"https://api.github.com/users/mborodin-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mborodin-px/subscriptions","organizations_url":"https://api.github.com/users/mborodin-px/orgs","repos_url":"https://api.github.com/users/mborodin-px/repos","events_url":"https://api.github.com/users/mborodin-px/events{/privacy}","received_events_url":"https://api.github.com/users/mborodin-px/received_events","type":"User","site_admin":false},"assignees":[{"login":"mborodin-px","id":49766650,"node_id":"MDQ6VXNlcjQ5NzY2NjUw","avatar_url":"https://avatars3.githubusercontent.com/u/49766650?v=4","gravatar_id":"","url":"https://api.github.com/users/mborodin-px","html_url":"https://github.com/mborodin-px","followers_url":"https://api.github.com/users/mborodin-px/followers","following_url":"https://api.github.com/users/mborodin-px/following{/other_user}","gists_url":"https://api.github.com/users/mborodin-px/gists{/gist_id}","starred_url":"https://api.github.com/users/mborodin-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mborodin-px/subscriptions","organizations_url":"https://api.github.com/users/mborodin-px/orgs","repos_url":"https://api.github.com/users/mborodin-px/repos","events_url":"https://api.github.com/users/mborodin-px/events{/privacy}","received_events_url":"https://api.github.com/users/mborodin-px/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"thiguetta","id":2332561,"node_id":"MDQ6VXNlcjIzMzI1NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2332561?v=4","gravatar_id":"","url":"https://api.github.com/users/thiguetta","html_url":"https://github.com/thiguetta","followers_url":"https://api.github.com/users/thiguetta/followers","following_url":"https://api.github.com/users/thiguetta/following{/other_user}","gists_url":"https://api.github.com/users/thiguetta/gists{/gist_id}","starred_url":"https://api.github.com/users/thiguetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiguetta/subscriptions","organizations_url":"https://api.github.com/users/thiguetta/orgs","repos_url":"https://api.github.com/users/thiguetta/repos","events_url":"https://api.github.com/users/thiguetta/events{/privacy}","received_events_url":"https://api.github.com/users/thiguetta/received_events","type":"User","site_admin":false},{"login":"vilasd","id":14971467,"node_id":"MDQ6VXNlcjE0OTcxNDY3","avatar_url":"https://avatars2.githubusercontent.com/u/14971467?v=4","gravatar_id":"","url":"https://api.github.com/users/vilasd","html_url":"https://github.com/vilasd","followers_url":"https://api.github.com/users/vilasd/followers","following_url":"https://api.github.com/users/vilasd/following{/other_user}","gists_url":"https://api.github.com/users/vilasd/gists{/gist_id}","starred_url":"https://api.github.com/users/vilasd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilasd/subscriptions","organizations_url":"https://api.github.com/users/vilasd/orgs","repos_url":"https://api.github.com/users/vilasd/repos","events_url":"https://api.github.com/users/vilasd/events{/privacy}","received_events_url":"https://api.github.com/users/vilasd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1643288849,"node_id":"MDU6TGFiZWwxNjQzMjg4ODQ5","url":"https://api.github.com/repos/portworx/torpedo/labels/ready-for-review","name":"ready-for-review","color":"0e8a16","default":false,"description":"PR is ready for review"}],"milestone":null,"commits_url":"https://api.github.com/repos/portworx/torpedo/pulls/390/commits","review_comments_url":"https://api.github.com/repos/portworx/torpedo/pulls/390/comments","review_comment_url":"https://api.github.com/repos/portworx/torpedo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/portworx/torpedo/issues/390/comments","statuses_url":"https://api.github.com/repos/portworx/torpedo/statuses/f5a09d2316011c10228476f2eb5f40a6d6a5a7ab","head":{"label":"portworx:PTX-2097","ref":"PTX-2097","sha":"f5a09d2316011c10228476f2eb5f40a6d6a5a7ab","user":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"repo":{"id":92557685,"node_id":"MDEwOlJlcG9zaXRvcnk5MjU1NzY4NQ==","name":"torpedo","full_name":"portworx/torpedo","private":false,"owner":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/portworx/torpedo","description":"A test suite to qualify storage providers for stateful containers running in a cluster.","fork":false,"url":"https://api.github.com/repos/portworx/torpedo","forks_url":"https://api.github.com/repos/portworx/torpedo/forks","keys_url":"https://api.github.com/repos/portworx/torpedo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portworx/torpedo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portworx/torpedo/teams","hooks_url":"https://api.github.com/repos/portworx/torpedo/hooks","issue_events_url":"https://api.github.com/repos/portworx/torpedo/issues/events{/number}","events_url":"https://api.github.com/repos/portworx/torpedo/events","assignees_url":"https://api.github.com/repos/portworx/torpedo/assignees{/user}","branches_url":"https://api.github.com/repos/portworx/torpedo/branches{/branch}","tags_url":"https://api.github.com/repos/portworx/torpedo/tags","blobs_url":"https://api.github.com/repos/portworx/torpedo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portworx/torpedo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portworx/torpedo/git/refs{/sha}","trees_url":"https://api.github.com/repos/portworx/torpedo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portworx/torpedo/statuses/{sha}","languages_url":"https://api.github.com/repos/portworx/torpedo/languages","stargazers_url":"https://api.github.com/repos/portworx/torpedo/stargazers","contributors_url":"https://api.github.com/repos/portworx/torpedo/contributors","subscribers_url":"https://api.github.com/repos/portworx/torpedo/subscribers","subscription_url":"https://api.github.com/repos/portworx/torpedo/subscription","commits_url":"https://api.github.com/repos/portworx/torpedo/commits{/sha}","git_commits_url":"https://api.github.com/repos/portworx/torpedo/git/commits{/sha}","comments_url":"https://api.github.com/repos/portworx/torpedo/comments{/number}","issue_comment_url":"https://api.github.com/repos/portworx/torpedo/issues/comments{/number}","contents_url":"https://api.github.com/repos/portworx/torpedo/contents/{+path}","compare_url":"https://api.github.com/repos/portworx/torpedo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portworx/torpedo/merges","archive_url":"https://api.github.com/repos/portworx/torpedo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portworx/torpedo/downloads","issues_url":"https://api.github.com/repos/portworx/torpedo/issues{/number}","pulls_url":"https://api.github.com/repos/portworx/torpedo/pulls{/number}","milestones_url":"https://api.github.com/repos/portworx/torpedo/milestones{/number}","notifications_url":"https://api.github.com/repos/portworx/torpedo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portworx/torpedo/labels{/name}","releases_url":"https://api.github.com/repos/portworx/torpedo/releases{/id}","deployments_url":"https://api.github.com/repos/portworx/torpedo/deployments","created_at":"2017-05-27T00:15:29Z","updated_at":"2020-01-09T17:16:14Z","pushed_at":"2020-01-09T23:59:05Z","git_url":"git://github.com/portworx/torpedo.git","ssh_url":"git@github.com:portworx/torpedo.git","clone_url":"https://github.com/portworx/torpedo.git","svn_url":"https://github.com/portworx/torpedo","homepage":null,"size":101950,"stargazers_count":63,"watchers_count":63,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":30,"watchers":63,"default_branch":"master"}},"base":{"label":"portworx:master","ref":"master","sha":"f90100685b701711e6e485a98028ef06edd7a41b","user":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"repo":{"id":92557685,"node_id":"MDEwOlJlcG9zaXRvcnk5MjU1NzY4NQ==","name":"torpedo","full_name":"portworx/torpedo","private":false,"owner":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/portworx/torpedo","description":"A test suite to qualify storage providers for stateful containers running in a cluster.","fork":false,"url":"https://api.github.com/repos/portworx/torpedo","forks_url":"https://api.github.com/repos/portworx/torpedo/forks","keys_url":"https://api.github.com/repos/portworx/torpedo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portworx/torpedo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portworx/torpedo/teams","hooks_url":"https://api.github.com/repos/portworx/torpedo/hooks","issue_events_url":"https://api.github.com/repos/portworx/torpedo/issues/events{/number}","events_url":"https://api.github.com/repos/portworx/torpedo/events","assignees_url":"https://api.github.com/repos/portworx/torpedo/assignees{/user}","branches_url":"https://api.github.com/repos/portworx/torpedo/branches{/branch}","tags_url":"https://api.github.com/repos/portworx/torpedo/tags","blobs_url":"https://api.github.com/repos/portworx/torpedo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portworx/torpedo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portworx/torpedo/git/refs{/sha}","trees_url":"https://api.github.com/repos/portworx/torpedo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portworx/torpedo/statuses/{sha}","languages_url":"https://api.github.com/repos/portworx/torpedo/languages","stargazers_url":"https://api.github.com/repos/portworx/torpedo/stargazers","contributors_url":"https://api.github.com/repos/portworx/torpedo/contributors","subscribers_url":"https://api.github.com/repos/portworx/torpedo/subscribers","subscription_url":"https://api.github.com/repos/portworx/torpedo/subscription","commits_url":"https://api.github.com/repos/portworx/torpedo/commits{/sha}","git_commits_url":"https://api.github.com/repos/portworx/torpedo/git/commits{/sha}","comments_url":"https://api.github.com/repos/portworx/torpedo/comments{/number}","issue_comment_url":"https://api.github.com/repos/portworx/torpedo/issues/comments{/number}","contents_url":"https://api.github.com/repos/portworx/torpedo/contents/{+path}","compare_url":"https://api.github.com/repos/portworx/torpedo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portworx/torpedo/merges","archive_url":"https://api.github.com/repos/portworx/torpedo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portworx/torpedo/downloads","issues_url":"https://api.github.com/repos/portworx/torpedo/issues{/number}","pulls_url":"https://api.github.com/repos/portworx/torpedo/pulls{/number}","milestones_url":"https://api.github.com/repos/portworx/torpedo/milestones{/number}","notifications_url":"https://api.github.com/repos/portworx/torpedo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portworx/torpedo/labels{/name}","releases_url":"https://api.github.com/repos/portworx/torpedo/releases{/id}","deployments_url":"https://api.github.com/repos/portworx/torpedo/deployments","created_at":"2017-05-27T00:15:29Z","updated_at":"2020-01-09T17:16:14Z","pushed_at":"2020-01-09T23:59:05Z","git_url":"git://github.com/portworx/torpedo.git","ssh_url":"git@github.com:portworx/torpedo.git","clone_url":"https://github.com/portworx/torpedo.git","svn_url":"https://github.com/portworx/torpedo","homepage":null,"size":101950,"stargazers_count":63,"watchers_count":63,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":30,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/portworx/torpedo/pulls/390"},"html":{"href":"https://github.com/portworx/torpedo/pull/390"},"issue":{"href":"https://api.github.com/repos/portworx/torpedo/issues/390"},"comments":{"href":"https://api.github.com/repos/portworx/torpedo/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/portworx/torpedo/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/portworx/torpedo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/portworx/torpedo/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/portworx/torpedo/statuses/f5a09d2316011c10228476f2eb5f40a6d6a5a7ab"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 92557685,
"name": "portworx/torpedo",
"url": "https://api.github.com/repos/portworx/torpedo"
}
|
{
"id": 26801153,
"login": "harsh-px",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26801153?",
"url": "https://api.github.com/users/harsh-px"
}
|
{
"id": 12014092,
"login": "portworx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12014092?",
"url": "https://api.github.com/orgs/portworx"
}
| 2020-01-10T00:20:58 |
11242810841
|
{"actor":{"display_login":"harsh-px"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/comments/336984089","pull_request_review_id":304517803,"id":336984089,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjk4NDA4OQ==","diff_hunk":"@@ -8,6 +8,11 @@\n // Screaming Udder! https://esss.se\n \n #include \"Source.h\"\n+#include \"helper.h\"\n+#include \"logger.h\"\n+#include <chrono>\n+#include <fstream>\n+#include <thread>","path":"src/Source.cpp","position":8,"original_position":8,"commit_id":"064b0edc03e2bc4922728404590d06c7a58d3a07","original_commit_id":"064b0edc03e2bc4922728404590d06c7a58d3a07","user":{"login":"SkyToGround","id":58835,"node_id":"MDQ6VXNlcjU4ODM1","avatar_url":"https://avatars1.githubusercontent.com/u/58835?v=4","gravatar_id":"","url":"https://api.github.com/users/SkyToGround","html_url":"https://github.com/SkyToGround","followers_url":"https://api.github.com/users/SkyToGround/followers","following_url":"https://api.github.com/users/SkyToGround/following{/other_user}","gists_url":"https://api.github.com/users/SkyToGround/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyToGround/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyToGround/subscriptions","organizations_url":"https://api.github.com/users/SkyToGround/orgs","repos_url":"https://api.github.com/users/SkyToGround/repos","events_url":"https://api.github.com/users/SkyToGround/events{/privacy}","received_events_url":"https://api.github.com/users/SkyToGround/received_events","type":"User","site_admin":false},"body":"I do not know but it is not entirely unlikely that the reason is something similar to the comment above this one. It has now been fixed.","created_at":"2019-10-21T12:19:20Z","updated_at":"2019-10-21T12:19:20Z","html_url":"https://github.com/ess-dmsc/kafka-to-nexus/pull/479#discussion_r336984089","pull_request_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/479","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/comments/336984089"},"html":{"href":"https://github.com/ess-dmsc/kafka-to-nexus/pull/479#discussion_r336984089"},"pull_request":{"href":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/479"}},"in_reply_to_id":336452079},"pull_request":{"url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/479","id":326828252,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2ODI4MjUy","html_url":"https://github.com/ess-dmsc/kafka-to-nexus/pull/479","diff_url":"https://github.com/ess-dmsc/kafka-to-nexus/pull/479.diff","patch_url":"https://github.com/ess-dmsc/kafka-to-nexus/pull/479.patch","issue_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/479","number":479,"state":"open","locked":false,"title":"DM-1718, refactor file writing code. Part 2","user":{"login":"SkyToGround","id":58835,"node_id":"MDQ6VXNlcjU4ODM1","avatar_url":"https://avatars1.githubusercontent.com/u/58835?v=4","gravatar_id":"","url":"https://api.github.com/users/SkyToGround","html_url":"https://github.com/SkyToGround","followers_url":"https://api.github.com/users/SkyToGround/followers","following_url":"https://api.github.com/users/SkyToGround/following{/other_user}","gists_url":"https://api.github.com/users/SkyToGround/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyToGround/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyToGround/subscriptions","organizations_url":"https://api.github.com/users/SkyToGround/orgs","repos_url":"https://api.github.com/users/SkyToGround/repos","events_url":"https://api.github.com/users/SkyToGround/events{/privacy}","received_events_url":"https://api.github.com/users/SkyToGround/received_events","type":"User","site_admin":false},"body":"### Issue\r\n\r\nDM-1718\r\n\r\n### Description of work\r\n\r\n*Add a description of the work done. The aim is provide information to help the reviewer review the PR efficiently.\r\nSee [CONTRIBUTING.MD](CONTRIBUTING.MD) for more information on code standards etc.*\r\n\r\n### Nominate for Group Code Review\r\n\r\n- [ ] Nominate for code review \r\n\r\n","created_at":"2019-10-10T16:35:00Z","updated_at":"2019-10-21T12:19:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b76fc84f1273c65459d20acfee800c5826860b7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/479/commits","review_comments_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/479/comments","review_comment_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/479/comments","statuses_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/statuses/064b0edc03e2bc4922728404590d06c7a58d3a07","head":{"label":"ess-dmsc:DM-1718_part_2","ref":"DM-1718_part_2","sha":"064b0edc03e2bc4922728404590d06c7a58d3a07","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":81435658,"node_id":"MDEwOlJlcG9zaXRvcnk4MTQzNTY1OA==","name":"kafka-to-nexus","full_name":"ess-dmsc/kafka-to-nexus","private":false,"owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ess-dmsc/kafka-to-nexus","description":"Writes NeXus files from experiment data streamed through Apache Kafka.","fork":false,"url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus","forks_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/forks","keys_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/events","assignees_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/merges","archive_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/deployments","created_at":"2017-02-09T09:55:55Z","updated_at":"2019-10-21T07:24:16Z","pushed_at":"2019-10-21T12:05:27Z","git_url":"git://github.com/ess-dmsc/kafka-to-nexus.git","ssh_url":"git@github.com:ess-dmsc/kafka-to-nexus.git","clone_url":"https://github.com/ess-dmsc/kafka-to-nexus.git","svn_url":"https://github.com/ess-dmsc/kafka-to-nexus","homepage":"","size":6030,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"ess-dmsc:master","ref":"master","sha":"0a9d1390c0da3cf077012960c3ec4a9dae989013","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":81435658,"node_id":"MDEwOlJlcG9zaXRvcnk4MTQzNTY1OA==","name":"kafka-to-nexus","full_name":"ess-dmsc/kafka-to-nexus","private":false,"owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ess-dmsc/kafka-to-nexus","description":"Writes NeXus files from experiment data streamed through Apache Kafka.","fork":false,"url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus","forks_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/forks","keys_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/events","assignees_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/merges","archive_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/deployments","created_at":"2017-02-09T09:55:55Z","updated_at":"2019-10-21T07:24:16Z","pushed_at":"2019-10-21T12:05:27Z","git_url":"git://github.com/ess-dmsc/kafka-to-nexus.git","ssh_url":"git@github.com:ess-dmsc/kafka-to-nexus.git","clone_url":"https://github.com/ess-dmsc/kafka-to-nexus.git","svn_url":"https://github.com/ess-dmsc/kafka-to-nexus","homepage":"","size":6030,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/479"},"html":{"href":"https://github.com/ess-dmsc/kafka-to-nexus/pull/479"},"issue":{"href":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/479"},"comments":{"href":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/479/comments"},"review_comments":{"href":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/479/comments"},"review_comment":{"href":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/479/commits"},"statuses":{"href":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/statuses/064b0edc03e2bc4922728404590d06c7a58d3a07"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 81435658,
"name": "ess-dmsc/kafka-to-nexus",
"url": "https://api.github.com/repos/ess-dmsc/kafka-to-nexus"
}
|
{
"id": 58835,
"login": "SkyToGround",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/58835?",
"url": "https://api.github.com/users/SkyToGround"
}
|
{
"id": 12100833,
"login": "ess-dmsc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12100833?",
"url": "https://api.github.com/orgs/ess-dmsc"
}
| 2019-10-21T12:19:20 |
10675711260
|
{"actor":{"display_login":"SkyToGround"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments/285939658","pull_request_review_id":239935493,"id":285939658,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTkzOTY1OA==","diff_hunk":"@@ -0,0 +1,101 @@\n+---\n+order: 2\n+title:\n+ zh-CN: 卡片模式\n+ en-US: Card","path":"components/calendar/demo/card-with-custom-header-api.md","position":5,"original_position":5,"commit_id":"8fc248b80383daa31945abcd01143a9a09164db8","original_commit_id":"8fc248b80383daa31945abcd01143a9a09164db8","user":{"login":"zombieJ","id":5378891,"node_id":"MDQ6VXNlcjUzNzg4OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5378891?v=4","gravatar_id":"","url":"https://api.github.com/users/zombieJ","html_url":"https://github.com/zombieJ","followers_url":"https://api.github.com/users/zombieJ/followers","following_url":"https://api.github.com/users/zombieJ/following{/other_user}","gists_url":"https://api.github.com/users/zombieJ/gists{/gist_id}","starred_url":"https://api.github.com/users/zombieJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombieJ/subscriptions","organizations_url":"https://api.github.com/users/zombieJ/orgs","repos_url":"https://api.github.com/users/zombieJ/repos","events_url":"https://api.github.com/users/zombieJ/events{/privacy}","received_events_url":"https://api.github.com/users/zombieJ/received_events","type":"User","site_admin":false},"body":"Customize Header","created_at":"2019-05-21T09:43:07Z","updated_at":"2019-05-21T09:43:08Z","html_url":"https://github.com/ant-design/ant-design/pull/16535#discussion_r285939658","pull_request_url":"https://api.github.com/repos/ant-design/ant-design/pulls/16535","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments/285939658"},"html":{"href":"https://github.com/ant-design/ant-design/pull/16535#discussion_r285939658"},"pull_request":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/16535"}}},"pull_request":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/16535","id":278054669,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4MDU0NjY5","html_url":"https://github.com/ant-design/ant-design/pull/16535","diff_url":"https://github.com/ant-design/ant-design/pull/16535.diff","patch_url":"https://github.com/ant-design/ant-design/pull/16535.patch","issue_url":"https://api.github.com/repos/ant-design/ant-design/issues/16535","number":16535,"state":"open","locked":false,"title":"feat: New calendar apis, renderHeader and small prop","user":{"login":"abgaryanharutyun","id":5097588,"node_id":"MDQ6VXNlcjUwOTc1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5097588?v=4","gravatar_id":"","url":"https://api.github.com/users/abgaryanharutyun","html_url":"https://github.com/abgaryanharutyun","followers_url":"https://api.github.com/users/abgaryanharutyun/followers","following_url":"https://api.github.com/users/abgaryanharutyun/following{/other_user}","gists_url":"https://api.github.com/users/abgaryanharutyun/gists{/gist_id}","starred_url":"https://api.github.com/users/abgaryanharutyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abgaryanharutyun/subscriptions","organizations_url":"https://api.github.com/users/abgaryanharutyun/orgs","repos_url":"https://api.github.com/users/abgaryanharutyun/repos","events_url":"https://api.github.com/users/abgaryanharutyun/events{/privacy}","received_events_url":"https://api.github.com/users/abgaryanharutyun/received_events","type":"User","site_admin":false},"body":"Added new calendar APIs`renderHeader`\r\n - With `renderHeader` API now we can render custom header with all functionalities.\r\n\r\nThank you guys for creating an awesome UI for React. I am using ant for many years and I will be very happy to join to Ant team.\r\n\r\nI will wait for feedbacks.\r\n\r\nThanks.\r\n<!--\r\nFirst of all, thank you for your contribution! 😄\r\n\r\nNew feature please send pull request to feature branch, and rest to master branch.\r\nPull request will be merged after one of collaborators approve.\r\nPlease makes sure that these form are filled before submitting your pull request, thank you!\r\n\r\n[[中文版模板 / Chinese template](https://github.com/ant-design/ant-design/blob/master/.github/PULL_REQUEST_TEMPLATE/pr_cn.md)]\r\n-->\r\n\r\n### 🤔 This is a ...\r\n\r\n- [X] New feature\r\n- [ ] Bug fix\r\n- [X] Site / document update\r\n- [ ] Component style update\r\n- [ ] TypeScript definition update\r\n- [ ] Refactoring\r\n- [ ] Code style optimization\r\n- [ ] Test Case\r\n- [ ] Branch merge\r\n- [ ] Other (about what?)\r\n\r\n### 👻 What's the background?\r\n\r\n<!--\r\n1. Describe the source of requirement, like related issue link.\r\nWe are using ant design for our project, and we are also using calendar but our design system calendar header other comparing with ant for that I decided to add additional option for ant.design\r\n-->\r\n\r\n### 💡 Solution\r\n\r\n<!--\r\n1. How to fix the problem, and list final API implementation and usage sample if that is a new feature.\r\nAdded new calendar APIs`renderHeader` and `size`,\r\n - With render API now we can render custom header with all functionality.\r\n - With size we can change calendar font size and margins I was use ant template small size.\r\n2. GIF or snapshot should be provided if includes UI/interactive modification.\r\n-->\r\n<img width=\"800\" alt=\"Screen Shot 2019-05-12 at 5 38 32 PM\" src=\"https://user-images.githubusercontent.com/5097588/57582988-d19f0e80-74dc-11e9-8295-e6677109622e.png\">\r\n### 📝 Changelog\r\n\r\n<!--\r\nDescribe changes from userside, and list all potential break changes or other risks.\r\n--->\r\n\r\n- English Changelog:\r\n Not added yet\r\n- Chinese Changelog (optional):\r\n\r\n### ☑️ Self Check before Merge\r\n\r\n- [X] Doc is updated/provided or not needed\r\n- [X] Demo is updated/provided or not needed\r\n- [ ] TypeScript definition is updated/provided or not needed\r\n- [ ] Changelog is provided or not needed\r\n\r\n\r\n-----\r\n[View rendered components/calendar/demo/card-with-custom-header-api.md](https://github.com/abgaryanharutyun/ant-design/blob/calendar-custome-header-and-small-size/components/calendar/demo/card-with-custom-header-api.md)\r\n[View rendered components/calendar/index.en-US.md](https://github.com/abgaryanharutyun/ant-design/blob/calendar-custome-header-and-small-size/components/calendar/index.en-US.md)","created_at":"2019-05-12T13:45:42Z","updated_at":"2019-05-21T09:43:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9675b837154e1116e779829b985fbf23397dc873","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1310631527,"node_id":"MDU6TGFiZWwxMzEwNjMxNTI3","url":"https://api.github.com/repos/ant-design/ant-design/labels/PR:%20unreviewed","name":"PR: unreviewed","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ant-design/ant-design/pulls/16535/commits","review_comments_url":"https://api.github.com/repos/ant-design/ant-design/pulls/16535/comments","review_comment_url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ant-design/ant-design/issues/16535/comments","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/8fc248b80383daa31945abcd01143a9a09164db8","head":{"label":"abgaryanharutyun:calendar-custome-header-and-small-size","ref":"calendar-custome-header-and-small-size","sha":"8fc248b80383daa31945abcd01143a9a09164db8","user":{"login":"abgaryanharutyun","id":5097588,"node_id":"MDQ6VXNlcjUwOTc1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5097588?v=4","gravatar_id":"","url":"https://api.github.com/users/abgaryanharutyun","html_url":"https://github.com/abgaryanharutyun","followers_url":"https://api.github.com/users/abgaryanharutyun/followers","following_url":"https://api.github.com/users/abgaryanharutyun/following{/other_user}","gists_url":"https://api.github.com/users/abgaryanharutyun/gists{/gist_id}","starred_url":"https://api.github.com/users/abgaryanharutyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abgaryanharutyun/subscriptions","organizations_url":"https://api.github.com/users/abgaryanharutyun/orgs","repos_url":"https://api.github.com/users/abgaryanharutyun/repos","events_url":"https://api.github.com/users/abgaryanharutyun/events{/privacy}","received_events_url":"https://api.github.com/users/abgaryanharutyun/received_events","type":"User","site_admin":false},"repo":{"id":186186843,"node_id":"MDEwOlJlcG9zaXRvcnkxODYxODY4NDM=","name":"ant-design","full_name":"abgaryanharutyun/ant-design","private":false,"owner":{"login":"abgaryanharutyun","id":5097588,"node_id":"MDQ6VXNlcjUwOTc1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5097588?v=4","gravatar_id":"","url":"https://api.github.com/users/abgaryanharutyun","html_url":"https://github.com/abgaryanharutyun","followers_url":"https://api.github.com/users/abgaryanharutyun/followers","following_url":"https://api.github.com/users/abgaryanharutyun/following{/other_user}","gists_url":"https://api.github.com/users/abgaryanharutyun/gists{/gist_id}","starred_url":"https://api.github.com/users/abgaryanharutyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abgaryanharutyun/subscriptions","organizations_url":"https://api.github.com/users/abgaryanharutyun/orgs","repos_url":"https://api.github.com/users/abgaryanharutyun/repos","events_url":"https://api.github.com/users/abgaryanharutyun/events{/privacy}","received_events_url":"https://api.github.com/users/abgaryanharutyun/received_events","type":"User","site_admin":false},"html_url":"https://github.com/abgaryanharutyun/ant-design","description":"🌈 A UI Design Language","fork":true,"url":"https://api.github.com/repos/abgaryanharutyun/ant-design","forks_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/forks","keys_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/teams","hooks_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/hooks","issue_events_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/events","assignees_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/tags","blobs_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/languages","stargazers_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/stargazers","contributors_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/contributors","subscribers_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/subscribers","subscription_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/subscription","commits_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/merges","archive_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/downloads","issues_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/abgaryanharutyun/ant-design/deployments","created_at":"2019-05-11T22:25:34Z","updated_at":"2019-05-11T22:25:43Z","pushed_at":"2019-05-20T19:40:55Z","git_url":"git://github.com/abgaryanharutyun/ant-design.git","ssh_url":"git@github.com:abgaryanharutyun/ant-design.git","clone_url":"https://github.com/abgaryanharutyun/ant-design.git","svn_url":"https://github.com/abgaryanharutyun/ant-design","homepage":"https://ant.design","size":385719,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ant-design:feature","ref":"feature","sha":"ecb2eb6ede92b0830cb83d5f0fe580d942ab312d","user":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"repo":{"id":34526884,"node_id":"MDEwOlJlcG9zaXRvcnkzNDUyNjg4NA==","name":"ant-design","full_name":"ant-design/ant-design","private":false,"owner":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ant-design/ant-design","description":"🌈 A UI Design Language","fork":false,"url":"https://api.github.com/repos/ant-design/ant-design","forks_url":"https://api.github.com/repos/ant-design/ant-design/forks","keys_url":"https://api.github.com/repos/ant-design/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-design/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-design/ant-design/teams","hooks_url":"https://api.github.com/repos/ant-design/ant-design/hooks","issue_events_url":"https://api.github.com/repos/ant-design/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/ant-design/ant-design/events","assignees_url":"https://api.github.com/repos/ant-design/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/ant-design/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/ant-design/ant-design/tags","blobs_url":"https://api.github.com/repos/ant-design/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-design/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-design/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-design/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-design/ant-design/languages","stargazers_url":"https://api.github.com/repos/ant-design/ant-design/stargazers","contributors_url":"https://api.github.com/repos/ant-design/ant-design/contributors","subscribers_url":"https://api.github.com/repos/ant-design/ant-design/subscribers","subscription_url":"https://api.github.com/repos/ant-design/ant-design/subscription","commits_url":"https://api.github.com/repos/ant-design/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-design/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-design/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-design/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-design/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/ant-design/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-design/ant-design/merges","archive_url":"https://api.github.com/repos/ant-design/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-design/ant-design/downloads","issues_url":"https://api.github.com/repos/ant-design/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/ant-design/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-design/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-design/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-design/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/ant-design/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/ant-design/ant-design/deployments","created_at":"2015-04-24T15:37:24Z","updated_at":"2019-05-21T09:34:26Z","pushed_at":"2019-05-21T08:03:09Z","git_url":"git://github.com/ant-design/ant-design.git","ssh_url":"git@github.com:ant-design/ant-design.git","clone_url":"https://github.com/ant-design/ant-design.git","svn_url":"https://github.com/ant-design/ant-design","homepage":"https://ant.design","size":391125,"stargazers_count":46610,"watchers_count":46610,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16303,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":322,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16303,"open_issues":322,"watchers":46610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/16535"},"html":{"href":"https://github.com/ant-design/ant-design/pull/16535"},"issue":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/16535"},"comments":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/16535/comments"},"review_comments":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/16535/comments"},"review_comment":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/16535/commits"},"statuses":{"href":"https://api.github.com/repos/ant-design/ant-design/statuses/8fc248b80383daa31945abcd01143a9a09164db8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 34526884,
"name": "ant-design/ant-design",
"url": "https://api.github.com/repos/ant-design/ant-design"
}
|
{
"id": 5378891,
"login": "zombieJ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5378891?",
"url": "https://api.github.com/users/zombieJ"
}
|
{
"id": 12101536,
"login": "ant-design",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12101536?",
"url": "https://api.github.com/orgs/ant-design"
}
| 2019-05-21T09:43:07 |
9665974572
|
{"actor":{"display_login":"zombieJ"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/astronomer/astronomer/pulls/comments/309774727","pull_request_review_id":269718963,"id":309774727,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTc3NDcyNw==","diff_hunk":"@@ -0,0 +1,26 @@\n+#!/bin/sh\n+#\n+# Copyright 2016 Astronomer Inc.","path":"docker/vendor/fluentd/clean-apt","position":3,"original_position":3,"commit_id":"9179a29b341c854073c670630615036545466438","original_commit_id":"9179a29b341c854073c670630615036545466438","user":{"login":"ashb","id":34150,"node_id":"MDQ6VXNlcjM0MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/34150?v=4","gravatar_id":"","url":"https://api.github.com/users/ashb","html_url":"https://github.com/ashb","followers_url":"https://api.github.com/users/ashb/followers","following_url":"https://api.github.com/users/ashb/following{/other_user}","gists_url":"https://api.github.com/users/ashb/gists{/gist_id}","starred_url":"https://api.github.com/users/ashb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashb/subscriptions","organizations_url":"https://api.github.com/users/ashb/orgs","repos_url":"https://api.github.com/users/ashb/repos","events_url":"https://api.github.com/users/ashb/events{/privacy}","received_events_url":"https://api.github.com/users/ashb/received_events","type":"User","site_admin":false},"body":"Given this was taken from kube protect we should maintain their copy right I think - especially when we don't change the file.\r\n\r\nOr at least add an attribution/source in a comment","created_at":"2019-08-01T15:57:48Z","updated_at":"2019-08-01T15:57:57Z","html_url":"https://github.com/astronomer/astronomer/pull/395#discussion_r309774727","pull_request_url":"https://api.github.com/repos/astronomer/astronomer/pulls/395","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/astronomer/astronomer/pulls/comments/309774727"},"html":{"href":"https://github.com/astronomer/astronomer/pull/395#discussion_r309774727"},"pull_request":{"href":"https://api.github.com/repos/astronomer/astronomer/pulls/395"}}},"pull_request":{"url":"https://api.github.com/repos/astronomer/astronomer/pulls/395","id":303449811,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzNDQ5ODEx","html_url":"https://github.com/astronomer/astronomer/pull/395","diff_url":"https://github.com/astronomer/astronomer/pull/395.diff","patch_url":"https://github.com/astronomer/astronomer/pull/395.patch","issue_url":"https://api.github.com/repos/astronomer/astronomer/issues/395","number":395,"state":"open","locked":false,"title":"change base image for fluentd-es","user":{"login":"andriisoldatenko","id":1374633,"node_id":"MDQ6VXNlcjEzNzQ2MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1374633?v=4","gravatar_id":"","url":"https://api.github.com/users/andriisoldatenko","html_url":"https://github.com/andriisoldatenko","followers_url":"https://api.github.com/users/andriisoldatenko/followers","following_url":"https://api.github.com/users/andriisoldatenko/following{/other_user}","gists_url":"https://api.github.com/users/andriisoldatenko/gists{/gist_id}","starred_url":"https://api.github.com/users/andriisoldatenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andriisoldatenko/subscriptions","organizations_url":"https://api.github.com/users/andriisoldatenko/orgs","repos_url":"https://api.github.com/users/andriisoldatenko/repos","events_url":"https://api.github.com/users/andriisoldatenko/events{/privacy}","received_events_url":"https://api.github.com/users/andriisoldatenko/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-01T15:54:14Z","updated_at":"2019-08-01T15:57:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"172cbd51e16d020c2e69e9398cf0a2c2cf73cb28","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/astronomer/astronomer/pulls/395/commits","review_comments_url":"https://api.github.com/repos/astronomer/astronomer/pulls/395/comments","review_comment_url":"https://api.github.com/repos/astronomer/astronomer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astronomer/astronomer/issues/395/comments","statuses_url":"https://api.github.com/repos/astronomer/astronomer/statuses/9179a29b341c854073c670630615036545466438","head":{"label":"astronomer:change-base-image-for-fluentd-es","ref":"change-base-image-for-fluentd-es","sha":"9179a29b341c854073c670630615036545466438","user":{"login":"astronomer","id":12449437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDQ5NDM3","avatar_url":"https://avatars2.githubusercontent.com/u/12449437?v=4","gravatar_id":"","url":"https://api.github.com/users/astronomer","html_url":"https://github.com/astronomer","followers_url":"https://api.github.com/users/astronomer/followers","following_url":"https://api.github.com/users/astronomer/following{/other_user}","gists_url":"https://api.github.com/users/astronomer/gists{/gist_id}","starred_url":"https://api.github.com/users/astronomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astronomer/subscriptions","organizations_url":"https://api.github.com/users/astronomer/orgs","repos_url":"https://api.github.com/users/astronomer/repos","events_url":"https://api.github.com/users/astronomer/events{/privacy}","received_events_url":"https://api.github.com/users/astronomer/received_events","type":"Organization","site_admin":false},"repo":{"id":117595674,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1OTU2NzQ=","name":"astronomer","full_name":"astronomer/astronomer","private":false,"owner":{"login":"astronomer","id":12449437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDQ5NDM3","avatar_url":"https://avatars2.githubusercontent.com/u/12449437?v=4","gravatar_id":"","url":"https://api.github.com/users/astronomer","html_url":"https://github.com/astronomer","followers_url":"https://api.github.com/users/astronomer/followers","following_url":"https://api.github.com/users/astronomer/following{/other_user}","gists_url":"https://api.github.com/users/astronomer/gists{/gist_id}","starred_url":"https://api.github.com/users/astronomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astronomer/subscriptions","organizations_url":"https://api.github.com/users/astronomer/orgs","repos_url":"https://api.github.com/users/astronomer/repos","events_url":"https://api.github.com/users/astronomer/events{/privacy}","received_events_url":"https://api.github.com/users/astronomer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astronomer/astronomer","description":"Apache Airflow as a Service on Kubernetes","fork":false,"url":"https://api.github.com/repos/astronomer/astronomer","forks_url":"https://api.github.com/repos/astronomer/astronomer/forks","keys_url":"https://api.github.com/repos/astronomer/astronomer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astronomer/astronomer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astronomer/astronomer/teams","hooks_url":"https://api.github.com/repos/astronomer/astronomer/hooks","issue_events_url":"https://api.github.com/repos/astronomer/astronomer/issues/events{/number}","events_url":"https://api.github.com/repos/astronomer/astronomer/events","assignees_url":"https://api.github.com/repos/astronomer/astronomer/assignees{/user}","branches_url":"https://api.github.com/repos/astronomer/astronomer/branches{/branch}","tags_url":"https://api.github.com/repos/astronomer/astronomer/tags","blobs_url":"https://api.github.com/repos/astronomer/astronomer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astronomer/astronomer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astronomer/astronomer/git/refs{/sha}","trees_url":"https://api.github.com/repos/astronomer/astronomer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astronomer/astronomer/statuses/{sha}","languages_url":"https://api.github.com/repos/astronomer/astronomer/languages","stargazers_url":"https://api.github.com/repos/astronomer/astronomer/stargazers","contributors_url":"https://api.github.com/repos/astronomer/astronomer/contributors","subscribers_url":"https://api.github.com/repos/astronomer/astronomer/subscribers","subscription_url":"https://api.github.com/repos/astronomer/astronomer/subscription","commits_url":"https://api.github.com/repos/astronomer/astronomer/commits{/sha}","git_commits_url":"https://api.github.com/repos/astronomer/astronomer/git/commits{/sha}","comments_url":"https://api.github.com/repos/astronomer/astronomer/comments{/number}","issue_comment_url":"https://api.github.com/repos/astronomer/astronomer/issues/comments{/number}","contents_url":"https://api.github.com/repos/astronomer/astronomer/contents/{+path}","compare_url":"https://api.github.com/repos/astronomer/astronomer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astronomer/astronomer/merges","archive_url":"https://api.github.com/repos/astronomer/astronomer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astronomer/astronomer/downloads","issues_url":"https://api.github.com/repos/astronomer/astronomer/issues{/number}","pulls_url":"https://api.github.com/repos/astronomer/astronomer/pulls{/number}","milestones_url":"https://api.github.com/repos/astronomer/astronomer/milestones{/number}","notifications_url":"https://api.github.com/repos/astronomer/astronomer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astronomer/astronomer/labels{/name}","releases_url":"https://api.github.com/repos/astronomer/astronomer/releases{/id}","deployments_url":"https://api.github.com/repos/astronomer/astronomer/deployments","created_at":"2018-01-15T21:09:14Z","updated_at":"2019-08-01T04:31:32Z","pushed_at":"2019-08-01T15:54:15Z","git_url":"git://github.com/astronomer/astronomer.git","ssh_url":"git@github.com:astronomer/astronomer.git","clone_url":"https://github.com/astronomer/astronomer.git","svn_url":"https://github.com/astronomer/astronomer","homepage":"https://www.astronomer.io","size":1819,"stargazers_count":191,"watchers_count":191,"language":"Dockerfile","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":96,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":27,"open_issues":96,"watchers":191,"default_branch":"master"}},"base":{"label":"astronomer:master","ref":"master","sha":"d1f033f3c28cf8614892ade643f2c1178deb84eb","user":{"login":"astronomer","id":12449437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDQ5NDM3","avatar_url":"https://avatars2.githubusercontent.com/u/12449437?v=4","gravatar_id":"","url":"https://api.github.com/users/astronomer","html_url":"https://github.com/astronomer","followers_url":"https://api.github.com/users/astronomer/followers","following_url":"https://api.github.com/users/astronomer/following{/other_user}","gists_url":"https://api.github.com/users/astronomer/gists{/gist_id}","starred_url":"https://api.github.com/users/astronomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astronomer/subscriptions","organizations_url":"https://api.github.com/users/astronomer/orgs","repos_url":"https://api.github.com/users/astronomer/repos","events_url":"https://api.github.com/users/astronomer/events{/privacy}","received_events_url":"https://api.github.com/users/astronomer/received_events","type":"Organization","site_admin":false},"repo":{"id":117595674,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1OTU2NzQ=","name":"astronomer","full_name":"astronomer/astronomer","private":false,"owner":{"login":"astronomer","id":12449437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDQ5NDM3","avatar_url":"https://avatars2.githubusercontent.com/u/12449437?v=4","gravatar_id":"","url":"https://api.github.com/users/astronomer","html_url":"https://github.com/astronomer","followers_url":"https://api.github.com/users/astronomer/followers","following_url":"https://api.github.com/users/astronomer/following{/other_user}","gists_url":"https://api.github.com/users/astronomer/gists{/gist_id}","starred_url":"https://api.github.com/users/astronomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astronomer/subscriptions","organizations_url":"https://api.github.com/users/astronomer/orgs","repos_url":"https://api.github.com/users/astronomer/repos","events_url":"https://api.github.com/users/astronomer/events{/privacy}","received_events_url":"https://api.github.com/users/astronomer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astronomer/astronomer","description":"Apache Airflow as a Service on Kubernetes","fork":false,"url":"https://api.github.com/repos/astronomer/astronomer","forks_url":"https://api.github.com/repos/astronomer/astronomer/forks","keys_url":"https://api.github.com/repos/astronomer/astronomer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astronomer/astronomer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astronomer/astronomer/teams","hooks_url":"https://api.github.com/repos/astronomer/astronomer/hooks","issue_events_url":"https://api.github.com/repos/astronomer/astronomer/issues/events{/number}","events_url":"https://api.github.com/repos/astronomer/astronomer/events","assignees_url":"https://api.github.com/repos/astronomer/astronomer/assignees{/user}","branches_url":"https://api.github.com/repos/astronomer/astronomer/branches{/branch}","tags_url":"https://api.github.com/repos/astronomer/astronomer/tags","blobs_url":"https://api.github.com/repos/astronomer/astronomer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astronomer/astronomer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astronomer/astronomer/git/refs{/sha}","trees_url":"https://api.github.com/repos/astronomer/astronomer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astronomer/astronomer/statuses/{sha}","languages_url":"https://api.github.com/repos/astronomer/astronomer/languages","stargazers_url":"https://api.github.com/repos/astronomer/astronomer/stargazers","contributors_url":"https://api.github.com/repos/astronomer/astronomer/contributors","subscribers_url":"https://api.github.com/repos/astronomer/astronomer/subscribers","subscription_url":"https://api.github.com/repos/astronomer/astronomer/subscription","commits_url":"https://api.github.com/repos/astronomer/astronomer/commits{/sha}","git_commits_url":"https://api.github.com/repos/astronomer/astronomer/git/commits{/sha}","comments_url":"https://api.github.com/repos/astronomer/astronomer/comments{/number}","issue_comment_url":"https://api.github.com/repos/astronomer/astronomer/issues/comments{/number}","contents_url":"https://api.github.com/repos/astronomer/astronomer/contents/{+path}","compare_url":"https://api.github.com/repos/astronomer/astronomer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astronomer/astronomer/merges","archive_url":"https://api.github.com/repos/astronomer/astronomer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astronomer/astronomer/downloads","issues_url":"https://api.github.com/repos/astronomer/astronomer/issues{/number}","pulls_url":"https://api.github.com/repos/astronomer/astronomer/pulls{/number}","milestones_url":"https://api.github.com/repos/astronomer/astronomer/milestones{/number}","notifications_url":"https://api.github.com/repos/astronomer/astronomer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astronomer/astronomer/labels{/name}","releases_url":"https://api.github.com/repos/astronomer/astronomer/releases{/id}","deployments_url":"https://api.github.com/repos/astronomer/astronomer/deployments","created_at":"2018-01-15T21:09:14Z","updated_at":"2019-08-01T04:31:32Z","pushed_at":"2019-08-01T15:54:15Z","git_url":"git://github.com/astronomer/astronomer.git","ssh_url":"git@github.com:astronomer/astronomer.git","clone_url":"https://github.com/astronomer/astronomer.git","svn_url":"https://github.com/astronomer/astronomer","homepage":"https://www.astronomer.io","size":1819,"stargazers_count":191,"watchers_count":191,"language":"Dockerfile","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":96,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":27,"open_issues":96,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astronomer/astronomer/pulls/395"},"html":{"href":"https://github.com/astronomer/astronomer/pull/395"},"issue":{"href":"https://api.github.com/repos/astronomer/astronomer/issues/395"},"comments":{"href":"https://api.github.com/repos/astronomer/astronomer/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/astronomer/astronomer/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/astronomer/astronomer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astronomer/astronomer/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/astronomer/astronomer/statuses/9179a29b341c854073c670630615036545466438"}},"author_association":"MEMBER"}}
|
{
"id": 117595674,
"name": "astronomer/astronomer",
"url": "https://api.github.com/repos/astronomer/astronomer"
}
|
{
"id": 34150,
"login": "ashb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34150?",
"url": "https://api.github.com/users/ashb"
}
|
{
"id": 12449437,
"login": "astronomer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12449437?",
"url": "https://api.github.com/orgs/astronomer"
}
| 2019-08-01T15:57:48 |
10130020391
|
{"actor":{"display_login":"ashb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/expo/expo/pulls/comments/290531783","pull_request_review_id":245747166,"id":290531783,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDUzMTc4Mw==","diff_hunk":"@@ -0,0 +1,346 @@\n+// Copyright 2018-present 650 Industries. All rights reserved.\n+\n+#import <EXInAppPurchases/EXInAppPurchasesModule.h>\n+\n+#define QUERY_HISTORY_KEY @\"QUERY_HISTORY\"\n+#define QUERY_PURCHASABLE_KEY @\"QUERY_PURCHASABLE\"\n+#define SERVICE_DISCONNECTED -1\n+#define OK 0\n+#define ERROR 1\n+#define USER_CANCELED 2\n+\n+@implementation EXInAppPurchasesModule\n+\n+UM_EXPORT_MODULE(ExpoInAppPurchases);\n+\n+- (void)setModuleRegistry:(UMModuleRegistry *)moduleRegistry\n+{\n+ _moduleRegistry = moduleRegistry;\n+}\n+\n+- (NSDictionary *)constantsToExport\n+{\n+ return @{\n+ @\"responseCodes\": @{\n+ @\"OK\": @OK,\n+ @\"USER_CANCELED\": @USER_CANCELED,\n+ @\"ERROR\": @ERROR,\n+ @\"SERVICE_DISCONNECTED\": @SERVICE_DISCONNECTED","path":"packages/expo-in-app-purchases/ios/EXInAppPurchases/EXInAppPurchasesModule.m","position":28,"original_position":28,"commit_id":"90f967988758a0f3c7687f3726d279b66a269445","original_commit_id":"90f967988758a0f3c7687f3726d279b66a269445","user":{"login":"sergeichestakov","id":24947334,"node_id":"MDQ6VXNlcjI0OTQ3MzM0","avatar_url":"https://avatars1.githubusercontent.com/u/24947334?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeichestakov","html_url":"https://github.com/sergeichestakov","followers_url":"https://api.github.com/users/sergeichestakov/followers","following_url":"https://api.github.com/users/sergeichestakov/following{/other_user}","gists_url":"https://api.github.com/users/sergeichestakov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeichestakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeichestakov/subscriptions","organizations_url":"https://api.github.com/users/sergeichestakov/orgs","repos_url":"https://api.github.com/users/sergeichestakov/repos","events_url":"https://api.github.com/users/sergeichestakov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeichestakov/received_events","type":"User","site_admin":false},"body":"That would be a good idea, however the caveat here is that iOS and Android return different codes for the same thing.\r\n\r\nFor instance, if a user cancels a payment Android returns [USER_CANCELED](https://developer.android.com/reference/com/android/billingclient/api/BillingClient.BillingResponseCode.html#USER_CANCELED) (enum value 1), but iOS will return [SKErrorPaymentCancelled](https://developer.apple.com/documentation/storekit/skerror/code/paymentcancelled) which is an enum value for 2. They even spell \"Canceled\" differently which I discovered the hard way 😄\r\n\r\nLikewise, a successful purchase returns \"OK\" (enum value 0) on Android and \"SKPaymentTransactionStatePurchased\" (enum value 1) on iOS. That's why I wanted to return different values on the Native side just be consistent with the keys I use so that it surfaces the same on the TS layer.","created_at":"2019-06-04T23:15:19Z","updated_at":"2019-06-04T23:15:19Z","html_url":"https://github.com/expo/expo/pull/4416#discussion_r290531783","pull_request_url":"https://api.github.com/repos/expo/expo/pulls/4416","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/expo/expo/pulls/comments/290531783"},"html":{"href":"https://github.com/expo/expo/pull/4416#discussion_r290531783"},"pull_request":{"href":"https://api.github.com/repos/expo/expo/pulls/4416"}},"in_reply_to_id":290501671},"pull_request":{"url":"https://api.github.com/repos/expo/expo/pulls/4416","id":285088107,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1MDg4MTA3","html_url":"https://github.com/expo/expo/pull/4416","diff_url":"https://github.com/expo/expo/pull/4416.diff","patch_url":"https://github.com/expo/expo/pull/4416.patch","issue_url":"https://api.github.com/repos/expo/expo/issues/4416","number":4416,"state":"open","locked":false,"title":"Expo In App Purchases","user":{"login":"sergeichestakov","id":24947334,"node_id":"MDQ6VXNlcjI0OTQ3MzM0","avatar_url":"https://avatars1.githubusercontent.com/u/24947334?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeichestakov","html_url":"https://github.com/sergeichestakov","followers_url":"https://api.github.com/users/sergeichestakov/followers","following_url":"https://api.github.com/users/sergeichestakov/following{/other_user}","gists_url":"https://api.github.com/users/sergeichestakov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeichestakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeichestakov/subscriptions","organizations_url":"https://api.github.com/users/sergeichestakov/orgs","repos_url":"https://api.github.com/users/sergeichestakov/repos","events_url":"https://api.github.com/users/sergeichestakov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeichestakov/received_events","type":"User","site_admin":false},"body":"# Why\r\n\r\nThis PR adds the [highly requested](https://expo.canny.io/feature-requests/p/in-app-purchases) In-App Purchases module to allow Expo apps to be monetized.\r\n\r\n# How\r\n\r\nUsing the [Google Play Billing](https://developer.android.com/google/play/billing/billing_library_overview) library on Android and [Storekit](https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/StoreKitGuide/Introduction.html#//apple_ref/doc/uid/TP40008267-CH1-SW1) API on iOS.\r\n\r\nI had to make some changes in order to get started including adding `expo-in-app-purchases` as a dependency to Sandbox, adding the EXInAppPurchases pod as a dependency in the podfile, and changing the Bundle Identifier of the Expo Client from `host.exp.Exponent` to `dev.expo.Payments`on iOS and the Application ID from `host.exp.exponent` to `com.expo.payments` on Android. This was necessary to match the entries in the Google Play Console and App Store Connect respectively so that I can safely add purchases to test against without putting the Expo client at risk of being removed. \r\n\r\nThis is because in order to test In App Purchases on both platforms you have to create an entry for the app and add the purchases yourself along with the necessary details (title, price, description, etc). On Android, you also have to upload an apk and publish the app as an alpha or beta release.\r\n\r\nObviously, we do not want the changes to be permanent so those commits **HAVE TO BE REVERTED** before merging this PR into master. This was just the fastest and easiest way to start prototyping.\r\n\r\n# Test Plan\r\n\r\nCurrently, I am building the Expo client from source (after making the aforementioned changes) and testing using the sandbox app under the `apps/` directory as I'm developing.\r\n\r\nIn the future, we will need a more reliable way to test this feature and we can do one of the following:\r\n1. Change the Application ID/Bundle Identifier of Standalone NCL to match the above, reupload them to Google Play Console/App Store Connect, and add a screen that uses the API.\r\n2. Add a new standalone app in the `apps/` directory with the above App/Bundle IDs.\r\n3. Keep using sandbox or another simple Expo app and add instructions in the README for how to get started testing such as changing the Expo clients App IDs (obviously this is less ideal).\r\n\r\nAs of now, you should be able to just pull down this branch, build the client, and test the API in sandbox.\r\n\r\nPlease note that in order to test the Google Play Billing and Storekit libraries you have to be using a real device so this will not work on simulators.\r\n\r\n","created_at":"2019-06-04T18:17:48Z","updated_at":"2019-06-04T23:15:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"900384c10d095a19832c72d7a0981d43f02e76d4","assignee":{"login":"sergeichestakov","id":24947334,"node_id":"MDQ6VXNlcjI0OTQ3MzM0","avatar_url":"https://avatars1.githubusercontent.com/u/24947334?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeichestakov","html_url":"https://github.com/sergeichestakov","followers_url":"https://api.github.com/users/sergeichestakov/followers","following_url":"https://api.github.com/users/sergeichestakov/following{/other_user}","gists_url":"https://api.github.com/users/sergeichestakov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeichestakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeichestakov/subscriptions","organizations_url":"https://api.github.com/users/sergeichestakov/orgs","repos_url":"https://api.github.com/users/sergeichestakov/repos","events_url":"https://api.github.com/users/sergeichestakov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeichestakov/received_events","type":"User","site_admin":false},"assignees":[{"login":"sergeichestakov","id":24947334,"node_id":"MDQ6VXNlcjI0OTQ3MzM0","avatar_url":"https://avatars1.githubusercontent.com/u/24947334?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeichestakov","html_url":"https://github.com/sergeichestakov","followers_url":"https://api.github.com/users/sergeichestakov/followers","following_url":"https://api.github.com/users/sergeichestakov/following{/other_user}","gists_url":"https://api.github.com/users/sergeichestakov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeichestakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeichestakov/subscriptions","organizations_url":"https://api.github.com/users/sergeichestakov/orgs","repos_url":"https://api.github.com/users/sergeichestakov/repos","events_url":"https://api.github.com/users/sergeichestakov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeichestakov/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ide","id":379606,"node_id":"MDQ6VXNlcjM3OTYwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/379606?v=4","gravatar_id":"","url":"https://api.github.com/users/ide","html_url":"https://github.com/ide","followers_url":"https://api.github.com/users/ide/followers","following_url":"https://api.github.com/users/ide/following{/other_user}","gists_url":"https://api.github.com/users/ide/gists{/gist_id}","starred_url":"https://api.github.com/users/ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ide/subscriptions","organizations_url":"https://api.github.com/users/ide/orgs","repos_url":"https://api.github.com/users/ide/repos","events_url":"https://api.github.com/users/ide/events{/privacy}","received_events_url":"https://api.github.com/users/ide/received_events","type":"User","site_admin":false},{"login":"esamelson","id":19958240,"node_id":"MDQ6VXNlcjE5OTU4MjQw","avatar_url":"https://avatars1.githubusercontent.com/u/19958240?v=4","gravatar_id":"","url":"https://api.github.com/users/esamelson","html_url":"https://github.com/esamelson","followers_url":"https://api.github.com/users/esamelson/followers","following_url":"https://api.github.com/users/esamelson/following{/other_user}","gists_url":"https://api.github.com/users/esamelson/gists{/gist_id}","starred_url":"https://api.github.com/users/esamelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esamelson/subscriptions","organizations_url":"https://api.github.com/users/esamelson/orgs","repos_url":"https://api.github.com/users/esamelson/repos","events_url":"https://api.github.com/users/esamelson/events{/privacy}","received_events_url":"https://api.github.com/users/esamelson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1390965376,"node_id":"MDU6TGFiZWwxMzkwOTY1Mzc2","url":"https://api.github.com/repos/expo/expo/labels/InAppPurchases","name":"InAppPurchases","color":"41C1C1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/expo/expo/pulls/4416/commits","review_comments_url":"https://api.github.com/repos/expo/expo/pulls/4416/comments","review_comment_url":"https://api.github.com/repos/expo/expo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/expo/expo/issues/4416/comments","statuses_url":"https://api.github.com/repos/expo/expo/statuses/90f967988758a0f3c7687f3726d279b66a269445","head":{"label":"expo:@sergeichestakov/in-app-payments","ref":"@sergeichestakov/in-app-payments","sha":"90f967988758a0f3c7687f3726d279b66a269445","user":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"repo":{"id":65750241,"node_id":"MDEwOlJlcG9zaXRvcnk2NTc1MDI0MQ==","name":"expo","full_name":"expo/expo","private":false,"owner":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/expo/expo","description":"The Expo platform for making cross-platform mobile apps","fork":false,"url":"https://api.github.com/repos/expo/expo","forks_url":"https://api.github.com/repos/expo/expo/forks","keys_url":"https://api.github.com/repos/expo/expo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expo/expo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expo/expo/teams","hooks_url":"https://api.github.com/repos/expo/expo/hooks","issue_events_url":"https://api.github.com/repos/expo/expo/issues/events{/number}","events_url":"https://api.github.com/repos/expo/expo/events","assignees_url":"https://api.github.com/repos/expo/expo/assignees{/user}","branches_url":"https://api.github.com/repos/expo/expo/branches{/branch}","tags_url":"https://api.github.com/repos/expo/expo/tags","blobs_url":"https://api.github.com/repos/expo/expo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expo/expo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expo/expo/git/refs{/sha}","trees_url":"https://api.github.com/repos/expo/expo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expo/expo/statuses/{sha}","languages_url":"https://api.github.com/repos/expo/expo/languages","stargazers_url":"https://api.github.com/repos/expo/expo/stargazers","contributors_url":"https://api.github.com/repos/expo/expo/contributors","subscribers_url":"https://api.github.com/repos/expo/expo/subscribers","subscription_url":"https://api.github.com/repos/expo/expo/subscription","commits_url":"https://api.github.com/repos/expo/expo/commits{/sha}","git_commits_url":"https://api.github.com/repos/expo/expo/git/commits{/sha}","comments_url":"https://api.github.com/repos/expo/expo/comments{/number}","issue_comment_url":"https://api.github.com/repos/expo/expo/issues/comments{/number}","contents_url":"https://api.github.com/repos/expo/expo/contents/{+path}","compare_url":"https://api.github.com/repos/expo/expo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expo/expo/merges","archive_url":"https://api.github.com/repos/expo/expo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expo/expo/downloads","issues_url":"https://api.github.com/repos/expo/expo/issues{/number}","pulls_url":"https://api.github.com/repos/expo/expo/pulls{/number}","milestones_url":"https://api.github.com/repos/expo/expo/milestones{/number}","notifications_url":"https://api.github.com/repos/expo/expo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expo/expo/labels{/name}","releases_url":"https://api.github.com/repos/expo/expo/releases{/id}","deployments_url":"https://api.github.com/repos/expo/expo/deployments","created_at":"2016-08-15T17:14:25Z","updated_at":"2019-06-04T22:47:47Z","pushed_at":"2019-06-04T22:49:39Z","git_url":"git://github.com/expo/expo.git","ssh_url":"git@github.com:expo/expo.git","clone_url":"https://github.com/expo/expo.git","svn_url":"https://github.com/expo/expo","homepage":"https://docs.expo.io/","size":1251055,"stargazers_count":6380,"watchers_count":6380,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":707,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":601,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":707,"open_issues":601,"watchers":6380,"default_branch":"master"}},"base":{"label":"expo:master","ref":"master","sha":"390df817495a59b0f8705f8beb949e0ed43cf402","user":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"repo":{"id":65750241,"node_id":"MDEwOlJlcG9zaXRvcnk2NTc1MDI0MQ==","name":"expo","full_name":"expo/expo","private":false,"owner":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/expo/expo","description":"The Expo platform for making cross-platform mobile apps","fork":false,"url":"https://api.github.com/repos/expo/expo","forks_url":"https://api.github.com/repos/expo/expo/forks","keys_url":"https://api.github.com/repos/expo/expo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expo/expo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expo/expo/teams","hooks_url":"https://api.github.com/repos/expo/expo/hooks","issue_events_url":"https://api.github.com/repos/expo/expo/issues/events{/number}","events_url":"https://api.github.com/repos/expo/expo/events","assignees_url":"https://api.github.com/repos/expo/expo/assignees{/user}","branches_url":"https://api.github.com/repos/expo/expo/branches{/branch}","tags_url":"https://api.github.com/repos/expo/expo/tags","blobs_url":"https://api.github.com/repos/expo/expo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expo/expo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expo/expo/git/refs{/sha}","trees_url":"https://api.github.com/repos/expo/expo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expo/expo/statuses/{sha}","languages_url":"https://api.github.com/repos/expo/expo/languages","stargazers_url":"https://api.github.com/repos/expo/expo/stargazers","contributors_url":"https://api.github.com/repos/expo/expo/contributors","subscribers_url":"https://api.github.com/repos/expo/expo/subscribers","subscription_url":"https://api.github.com/repos/expo/expo/subscription","commits_url":"https://api.github.com/repos/expo/expo/commits{/sha}","git_commits_url":"https://api.github.com/repos/expo/expo/git/commits{/sha}","comments_url":"https://api.github.com/repos/expo/expo/comments{/number}","issue_comment_url":"https://api.github.com/repos/expo/expo/issues/comments{/number}","contents_url":"https://api.github.com/repos/expo/expo/contents/{+path}","compare_url":"https://api.github.com/repos/expo/expo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expo/expo/merges","archive_url":"https://api.github.com/repos/expo/expo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expo/expo/downloads","issues_url":"https://api.github.com/repos/expo/expo/issues{/number}","pulls_url":"https://api.github.com/repos/expo/expo/pulls{/number}","milestones_url":"https://api.github.com/repos/expo/expo/milestones{/number}","notifications_url":"https://api.github.com/repos/expo/expo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expo/expo/labels{/name}","releases_url":"https://api.github.com/repos/expo/expo/releases{/id}","deployments_url":"https://api.github.com/repos/expo/expo/deployments","created_at":"2016-08-15T17:14:25Z","updated_at":"2019-06-04T22:47:47Z","pushed_at":"2019-06-04T22:49:39Z","git_url":"git://github.com/expo/expo.git","ssh_url":"git@github.com:expo/expo.git","clone_url":"https://github.com/expo/expo.git","svn_url":"https://github.com/expo/expo","homepage":"https://docs.expo.io/","size":1251055,"stargazers_count":6380,"watchers_count":6380,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":707,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":601,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":707,"open_issues":601,"watchers":6380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/expo/expo/pulls/4416"},"html":{"href":"https://github.com/expo/expo/pull/4416"},"issue":{"href":"https://api.github.com/repos/expo/expo/issues/4416"},"comments":{"href":"https://api.github.com/repos/expo/expo/issues/4416/comments"},"review_comments":{"href":"https://api.github.com/repos/expo/expo/pulls/4416/comments"},"review_comment":{"href":"https://api.github.com/repos/expo/expo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/expo/expo/pulls/4416/commits"},"statuses":{"href":"https://api.github.com/repos/expo/expo/statuses/90f967988758a0f3c7687f3726d279b66a269445"}},"author_association":"MEMBER"}}
|
{
"id": 65750241,
"name": "expo/expo",
"url": "https://api.github.com/repos/expo/expo"
}
|
{
"id": 24947334,
"login": "sergeichestakov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24947334?",
"url": "https://api.github.com/users/sergeichestakov"
}
|
{
"id": 12504344,
"login": "expo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12504344?",
"url": "https://api.github.com/orgs/expo"
}
| 2019-06-04T23:15:19 |
9759202118
|
{"actor":{"display_login":"sergeichestakov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments/328659736","pull_request_review_id":293783392,"id":328659736,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODY1OTczNg==","diff_hunk":"@@ -599,15 +610,26 @@ const createApi = function _createApi(enableCors) {\n \t\t\tdefaultOptionsEndpoint,\n \t\t\tauth: getUserAuth(),\n \t\t});\n+\t} else {\n+\t\tAPI.default._config.enableCors = enableCors;\n+\t\tif (enableCors) {\n+\t\t\tif (settings.get('API_CORS_Origin')) {\n+\t\t\t\tAPI.default._config.defaultHeaders['Access-Control-Allow-Origin'] = settings.get('API_CORS_Origin');\n+\t\t\t}\n+\t\t\tAPI.default._config.defaultHeaders['Access-Control-Allow-Headers'] = 'Origin, X-Requested-With, Content-Type, Accept, X-User-Id, X-Auth-Token';\n+\t\t} else {\n+\t\t\tdelete API.default._config.defaultHeaders['Access-Control-Allow-Origin'];\n+\t\t\tdelete API.default._config.defaultHeaders['Access-Control-Allow-Headers'];\n+\t\t}\n \t}\n };\n \n // also create the API immediately\n createApi(!!settings.get('API_Enable_CORS'));\n \n // register the API to be re-created once the CORS-setting changes.\n-settings.get('API_Enable_CORS', (key, value) => {\n-\tcreateApi(value);\n+settings.get(/^(API_Enable_CORS|API_CORS_Origin)$/, () => {\n+\tcreateApi(settings.get('API_Enable_CORS'));","path":"app/api/server/api.js","position":56,"original_position":56,"commit_id":"d64c2c54cec947cc96427a4628d509d57391a332","original_commit_id":"d64c2c54cec947cc96427a4628d509d57391a332","user":{"login":"sampaiodiego","id":8591547,"node_id":"MDQ6VXNlcjg1OTE1NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/8591547?v=4","gravatar_id":"","url":"https://api.github.com/users/sampaiodiego","html_url":"https://github.com/sampaiodiego","followers_url":"https://api.github.com/users/sampaiodiego/followers","following_url":"https://api.github.com/users/sampaiodiego/following{/other_user}","gists_url":"https://api.github.com/users/sampaiodiego/gists{/gist_id}","starred_url":"https://api.github.com/users/sampaiodiego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sampaiodiego/subscriptions","organizations_url":"https://api.github.com/users/sampaiodiego/orgs","repos_url":"https://api.github.com/users/sampaiodiego/repos","events_url":"https://api.github.com/users/sampaiodiego/events{/privacy}","received_events_url":"https://api.github.com/users/sampaiodiego/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\tcreateApi(value);\r\n```","created_at":"2019-09-26T14:51:24Z","updated_at":"2019-09-26T14:51:56Z","html_url":"https://github.com/RocketChat/Rocket.Chat/pull/15443#discussion_r328659736","pull_request_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/15443","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments/328659736"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat/pull/15443#discussion_r328659736"},"pull_request":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/15443"}}},"pull_request":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/15443","id":321393591,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxMzkzNTkx","html_url":"https://github.com/RocketChat/Rocket.Chat/pull/15443","diff_url":"https://github.com/RocketChat/Rocket.Chat/pull/15443.diff","patch_url":"https://github.com/RocketChat/Rocket.Chat/pull/15443.patch","issue_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/15443","number":15443,"state":"open","locked":false,"title":"[FIX] API CORS not working after Cordova being disabled by default","user":{"login":"rodrigok","id":234261,"node_id":"MDQ6VXNlcjIzNDI2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/234261?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigok","html_url":"https://github.com/rodrigok","followers_url":"https://api.github.com/users/rodrigok/followers","following_url":"https://api.github.com/users/rodrigok/following{/other_user}","gists_url":"https://api.github.com/users/rodrigok/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigok/subscriptions","organizations_url":"https://api.github.com/users/rodrigok/orgs","repos_url":"https://api.github.com/users/rodrigok/repos","events_url":"https://api.github.com/users/rodrigok/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigok/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-09-25T19:04:28Z","updated_at":"2019-09-26T14:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c19c7b643c3a42f481cf0f8a6b9af88f4c3c3354","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat/milestones/162","html_url":"https://github.com/RocketChat/Rocket.Chat/milestone/162","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/milestones/162/labels","id":4481509,"node_id":"MDk6TWlsZXN0b25lNDQ4MTUwOQ==","number":162,"title":"2.1.0","description":"","creator":{"login":"engelgabriel","id":1000217,"node_id":"MDQ6VXNlcjEwMDAyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1000217?v=4","gravatar_id":"","url":"https://api.github.com/users/engelgabriel","html_url":"https://github.com/engelgabriel","followers_url":"https://api.github.com/users/engelgabriel/followers","following_url":"https://api.github.com/users/engelgabriel/following{/other_user}","gists_url":"https://api.github.com/users/engelgabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/engelgabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engelgabriel/subscriptions","organizations_url":"https://api.github.com/users/engelgabriel/orgs","repos_url":"https://api.github.com/users/engelgabriel/repos","events_url":"https://api.github.com/users/engelgabriel/events{/privacy}","received_events_url":"https://api.github.com/users/engelgabriel/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":69,"state":"open","created_at":"2019-07-10T17:32:20Z","updated_at":"2019-09-25T23:13:41Z","due_on":"2019-09-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/15443/commits","review_comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/15443/comments","review_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/15443/comments","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/d64c2c54cec947cc96427a4628d509d57391a332","head":{"label":"RocketChat:fix-api-cors","ref":"fix-api-cors","sha":"d64c2c54cec947cc96427a4628d509d57391a332","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":35866694,"node_id":"MDEwOlJlcG9zaXRvcnkzNTg2NjY5NA==","name":"Rocket.Chat","full_name":"RocketChat/Rocket.Chat","private":false,"owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RocketChat/Rocket.Chat","description":"The ultimate Free Open Source Solution for team communications.","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/deployments","created_at":"2015-05-19T07:36:09Z","updated_at":"2019-09-26T14:39:06Z","pushed_at":"2019-09-26T13:52:31Z","git_url":"git://github.com/RocketChat/Rocket.Chat.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.git","svn_url":"https://github.com/RocketChat/Rocket.Chat","homepage":"https://rocket.chat/","size":136434,"stargazers_count":24111,"watchers_count":24111,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5211,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2289,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5211,"open_issues":2289,"watchers":24111,"default_branch":"develop"}},"base":{"label":"RocketChat:develop","ref":"develop","sha":"a9b8fba19746b15bd6029e258c468431abc95c80","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":35866694,"node_id":"MDEwOlJlcG9zaXRvcnkzNTg2NjY5NA==","name":"Rocket.Chat","full_name":"RocketChat/Rocket.Chat","private":false,"owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RocketChat/Rocket.Chat","description":"The ultimate Free Open Source Solution for team communications.","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/deployments","created_at":"2015-05-19T07:36:09Z","updated_at":"2019-09-26T14:39:06Z","pushed_at":"2019-09-26T13:52:31Z","git_url":"git://github.com/RocketChat/Rocket.Chat.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.git","svn_url":"https://github.com/RocketChat/Rocket.Chat","homepage":"https://rocket.chat/","size":136434,"stargazers_count":24111,"watchers_count":24111,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5211,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2289,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5211,"open_issues":2289,"watchers":24111,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/15443"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat/pull/15443"},"issue":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/15443"},"comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/15443/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/15443/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/15443/commits"},"statuses":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/d64c2c54cec947cc96427a4628d509d57391a332"}},"author_association":"MEMBER"}}
|
{
"id": 35866694,
"name": "RocketChat/Rocket.Chat",
"url": "https://api.github.com/repos/RocketChat/Rocket.Chat"
}
|
{
"id": 8591547,
"login": "sampaiodiego",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8591547?",
"url": "https://api.github.com/users/sampaiodiego"
}
|
{
"id": 12508788,
"login": "RocketChat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12508788?",
"url": "https://api.github.com/orgs/RocketChat"
}
| 2019-09-26T14:51:24 |
10502558328
|
{"actor":{"display_login":"sampaiodiego"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments/339138319","pull_request_review_id":307318975,"id":339138319,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTEzODMxOQ==","diff_hunk":"@@ -0,0 +1,61 @@\n+// TODO: Ensure this is not persisted to disk since tasks are ephemeral\n+const initialState = {\n+ tasks: new Map(),\n+}\n+\n+const runTask = task => {","path":"packages/gatsby/src/redux/reducers/tasks.js","position":6,"original_position":6,"commit_id":"218c4bcc106801010787c87f2df5a7170399b67e","original_commit_id":"218c4bcc106801010787c87f2df5a7170399b67e","user":{"login":"pieh","id":419821,"node_id":"MDQ6VXNlcjQxOTgyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/419821?v=4","gravatar_id":"","url":"https://api.github.com/users/pieh","html_url":"https://github.com/pieh","followers_url":"https://api.github.com/users/pieh/followers","following_url":"https://api.github.com/users/pieh/following{/other_user}","gists_url":"https://api.github.com/users/pieh/gists{/gist_id}","starred_url":"https://api.github.com/users/pieh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieh/subscriptions","organizations_url":"https://api.github.com/users/pieh/orgs","repos_url":"https://api.github.com/users/pieh/repos","events_url":"https://api.github.com/users/pieh/events{/privacy}","received_events_url":"https://api.github.com/users/pieh/received_events","type":"User","site_admin":false},"body":"I initially was thinking of queue in core, but came around - core won't have enough context to know what are optimal params for queue for given task type (concurrency etc), unless this will be part of jobs/tasks api (which would complicate things without much gain)","created_at":"2019-10-25T16:31:26Z","updated_at":"2019-10-25T16:31:26Z","html_url":"https://github.com/gatsbyjs/gatsby/pull/19016#discussion_r339138319","pull_request_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/19016","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments/339138319"},"html":{"href":"https://github.com/gatsbyjs/gatsby/pull/19016#discussion_r339138319"},"pull_request":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/19016"}},"in_reply_to_id":339131451},"pull_request":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/19016","id":332581454,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyNTgxNDU0","html_url":"https://github.com/gatsbyjs/gatsby/pull/19016","diff_url":"https://github.com/gatsbyjs/gatsby/pull/19016.diff","patch_url":"https://github.com/gatsbyjs/gatsby/pull/19016.patch","issue_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/19016","number":19016,"state":"open","locked":false,"title":"feat(gatsby): Jobs","user":{"login":"sidharthachatterjee","id":7701981,"node_id":"MDQ6VXNlcjc3MDE5ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7701981?v=4","gravatar_id":"","url":"https://api.github.com/users/sidharthachatterjee","html_url":"https://github.com/sidharthachatterjee","followers_url":"https://api.github.com/users/sidharthachatterjee/followers","following_url":"https://api.github.com/users/sidharthachatterjee/following{/other_user}","gists_url":"https://api.github.com/users/sidharthachatterjee/gists{/gist_id}","starred_url":"https://api.github.com/users/sidharthachatterjee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidharthachatterjee/subscriptions","organizations_url":"https://api.github.com/users/sidharthachatterjee/orgs","repos_url":"https://api.github.com/users/sidharthachatterjee/repos","events_url":"https://api.github.com/users/sidharthachatterjee/events{/privacy}","received_events_url":"https://api.github.com/users/sidharthachatterjee/received_events","type":"User","site_admin":false},"body":"Heavily work in progress","created_at":"2019-10-25T16:08:54Z","updated_at":"2019-10-25T16:31:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7336b50b62329c13fc0f92fa6b9e9b3e4080f78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1030072314,"node_id":"MDU6TGFiZWwxMDMwMDcyMzE0","url":"https://api.github.com/repos/gatsbyjs/gatsby/labels/status:%20WIP","name":"status: WIP","color":"daf282","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/19016/commits","review_comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/19016/comments","review_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/19016/comments","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/218c4bcc106801010787c87f2df5a7170399b67e","head":{"label":"gatsbyjs:feat/jobs","ref":"feat/jobs","sha":"218c4bcc106801010787c87f2df5a7170399b67e","user":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":36040894,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA0MDg5NA==","name":"gatsby","full_name":"gatsbyjs/gatsby","private":false,"owner":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gatsbyjs/gatsby","description":"Build blazing fast, modern apps and websites with React","fork":false,"url":"https://api.github.com/repos/gatsbyjs/gatsby","forks_url":"https://api.github.com/repos/gatsbyjs/gatsby/forks","keys_url":"https://api.github.com/repos/gatsbyjs/gatsby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gatsbyjs/gatsby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gatsbyjs/gatsby/teams","hooks_url":"https://api.github.com/repos/gatsbyjs/gatsby/hooks","issue_events_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/events{/number}","events_url":"https://api.github.com/repos/gatsbyjs/gatsby/events","assignees_url":"https://api.github.com/repos/gatsbyjs/gatsby/assignees{/user}","branches_url":"https://api.github.com/repos/gatsbyjs/gatsby/branches{/branch}","tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/tags","blobs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/refs{/sha}","trees_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/{sha}","languages_url":"https://api.github.com/repos/gatsbyjs/gatsby/languages","stargazers_url":"https://api.github.com/repos/gatsbyjs/gatsby/stargazers","contributors_url":"https://api.github.com/repos/gatsbyjs/gatsby/contributors","subscribers_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscribers","subscription_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscription","commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/commits{/sha}","git_commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/commits{/sha}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/comments{/number}","issue_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/comments{/number}","contents_url":"https://api.github.com/repos/gatsbyjs/gatsby/contents/{+path}","compare_url":"https://api.github.com/repos/gatsbyjs/gatsby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gatsbyjs/gatsby/merges","archive_url":"https://api.github.com/repos/gatsbyjs/gatsby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gatsbyjs/gatsby/downloads","issues_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues{/number}","pulls_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls{/number}","milestones_url":"https://api.github.com/repos/gatsbyjs/gatsby/milestones{/number}","notifications_url":"https://api.github.com/repos/gatsbyjs/gatsby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gatsbyjs/gatsby/labels{/name}","releases_url":"https://api.github.com/repos/gatsbyjs/gatsby/releases{/id}","deployments_url":"https://api.github.com/repos/gatsbyjs/gatsby/deployments","created_at":"2015-05-21T22:43:05Z","updated_at":"2019-10-25T16:07:44Z","pushed_at":"2019-10-25T16:19:47Z","git_url":"git://github.com/gatsbyjs/gatsby.git","ssh_url":"git@github.com:gatsbyjs/gatsby.git","clone_url":"https://github.com/gatsbyjs/gatsby.git","svn_url":"https://github.com/gatsbyjs/gatsby","homepage":"https://www.gatsbyjs.org","size":654723,"stargazers_count":39464,"watchers_count":39464,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6489,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":723,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6489,"open_issues":723,"watchers":39464,"default_branch":"master"}},"base":{"label":"gatsbyjs:master","ref":"master","sha":"16f95ef0d1a8d7d9a63b4d107a7e2497ffceeb8e","user":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":36040894,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA0MDg5NA==","name":"gatsby","full_name":"gatsbyjs/gatsby","private":false,"owner":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gatsbyjs/gatsby","description":"Build blazing fast, modern apps and websites with React","fork":false,"url":"https://api.github.com/repos/gatsbyjs/gatsby","forks_url":"https://api.github.com/repos/gatsbyjs/gatsby/forks","keys_url":"https://api.github.com/repos/gatsbyjs/gatsby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gatsbyjs/gatsby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gatsbyjs/gatsby/teams","hooks_url":"https://api.github.com/repos/gatsbyjs/gatsby/hooks","issue_events_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/events{/number}","events_url":"https://api.github.com/repos/gatsbyjs/gatsby/events","assignees_url":"https://api.github.com/repos/gatsbyjs/gatsby/assignees{/user}","branches_url":"https://api.github.com/repos/gatsbyjs/gatsby/branches{/branch}","tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/tags","blobs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/refs{/sha}","trees_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/{sha}","languages_url":"https://api.github.com/repos/gatsbyjs/gatsby/languages","stargazers_url":"https://api.github.com/repos/gatsbyjs/gatsby/stargazers","contributors_url":"https://api.github.com/repos/gatsbyjs/gatsby/contributors","subscribers_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscribers","subscription_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscription","commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/commits{/sha}","git_commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/commits{/sha}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/comments{/number}","issue_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/comments{/number}","contents_url":"https://api.github.com/repos/gatsbyjs/gatsby/contents/{+path}","compare_url":"https://api.github.com/repos/gatsbyjs/gatsby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gatsbyjs/gatsby/merges","archive_url":"https://api.github.com/repos/gatsbyjs/gatsby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gatsbyjs/gatsby/downloads","issues_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues{/number}","pulls_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls{/number}","milestones_url":"https://api.github.com/repos/gatsbyjs/gatsby/milestones{/number}","notifications_url":"https://api.github.com/repos/gatsbyjs/gatsby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gatsbyjs/gatsby/labels{/name}","releases_url":"https://api.github.com/repos/gatsbyjs/gatsby/releases{/id}","deployments_url":"https://api.github.com/repos/gatsbyjs/gatsby/deployments","created_at":"2015-05-21T22:43:05Z","updated_at":"2019-10-25T16:07:44Z","pushed_at":"2019-10-25T16:19:47Z","git_url":"git://github.com/gatsbyjs/gatsby.git","ssh_url":"git@github.com:gatsbyjs/gatsby.git","clone_url":"https://github.com/gatsbyjs/gatsby.git","svn_url":"https://github.com/gatsbyjs/gatsby","homepage":"https://www.gatsbyjs.org","size":654723,"stargazers_count":39464,"watchers_count":39464,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6489,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":723,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6489,"open_issues":723,"watchers":39464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/19016"},"html":{"href":"https://github.com/gatsbyjs/gatsby/pull/19016"},"issue":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/issues/19016"},"comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/issues/19016/comments"},"review_comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/19016/comments"},"review_comment":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/19016/commits"},"statuses":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/218c4bcc106801010787c87f2df5a7170399b67e"}},"author_association":"MEMBER"}}
|
{
"id": 36040894,
"name": "gatsbyjs/gatsby",
"url": "https://api.github.com/repos/gatsbyjs/gatsby"
}
|
{
"id": 419821,
"login": "pieh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/419821?",
"url": "https://api.github.com/users/pieh"
}
|
{
"id": 12551863,
"login": "gatsbyjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12551863?",
"url": "https://api.github.com/orgs/gatsbyjs"
}
| 2019-10-25T16:31:26 |
10715856785
|
{"actor":{"display_login":"pieh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/comments/340890974","pull_request_review_id":309563008,"id":340890974,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDg5MDk3NA==","diff_hunk":"@@ -250,24 +250,24 @@ export default function Search({ indices, collapse, hitsAsGrid }) {\n }\n ```\n \n-At the top, you import `InstantSearch` from [`react-instantsearch-dom`](https://community.algolia.com/react-instantsearch) which is the root component that allows your whole search experience to connect to Algolia's service. As the name suggests, `Index` allows you to tap into an individual index and `Hits` provides you with the data returned for a user's search input. Finally [`connectStateResults`](https://community.algolia.com/react-instantsearch/connectors/connectStateResults.html) wraps around custom React components and provides them with high-level stats about the current search state such as the query, the number of results and how long it took to fetch them.\n+En la parte superior, importas `InstantSearch` de [`react-instantsearch-dom`](https://community.algolia.com/react-instantsearch) el cual es el componente raíz que permite conectar toda tu experiencia de búsqueda con el servicio de Algolia. Como el nombre lo indica, `Index` te permite acceder a un índice individual y `Hits` te provee de la información retornada, relacionada a la búsqueda del usuario. Finalmente [`connectStateResults`](https://community.algolia.com/react-instantsearch/connectors/connectStateResults.html) envuelve a componentes personalizados de React y los provee con estadísticas de alto nivel sobre la búsqueda actual como: la consulta, el número de resultados y cuánto tiempo tomó obtenerlas.\n \n-You then import the styled components that make up the UI and the `Input` component into which the user enters the query.\n+Luego importas los componentes estilizados que componen la interfaz de usuario y el componente `Input` en el cual el usuario ingresa la consulta.","path":"docs/docs/adding-search-with-algolia.md","position":158,"original_position":158,"commit_id":"b7f854613eacc723ae5da64bab1e17a3878f9137","original_commit_id":"9ab5e2d9f2c55fd9c47652be79699be3738f8804","user":{"login":"SerotoninaAbad","id":17627521,"node_id":"MDQ6VXNlcjE3NjI3NTIx","avatar_url":"https://avatars0.githubusercontent.com/u/17627521?v=4","gravatar_id":"","url":"https://api.github.com/users/SerotoninaAbad","html_url":"https://github.com/SerotoninaAbad","followers_url":"https://api.github.com/users/SerotoninaAbad/followers","following_url":"https://api.github.com/users/SerotoninaAbad/following{/other_user}","gists_url":"https://api.github.com/users/SerotoninaAbad/gists{/gist_id}","starred_url":"https://api.github.com/users/SerotoninaAbad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerotoninaAbad/subscriptions","organizations_url":"https://api.github.com/users/SerotoninaAbad/orgs","repos_url":"https://api.github.com/users/SerotoninaAbad/repos","events_url":"https://api.github.com/users/SerotoninaAbad/events{/privacy}","received_events_url":"https://api.github.com/users/SerotoninaAbad/received_events","type":"User","site_admin":false},"body":"Gracias @gusma por las correcciones. He realizado los cambios solicitados. Este aún no he cambiado, quedo pendiente.","created_at":"2019-10-30T22:38:42Z","updated_at":"2019-10-30T22:38:42Z","html_url":"https://github.com/gatsbyjs/gatsby-es/pull/135#discussion_r340890974","pull_request_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/135","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/comments/340890974"},"html":{"href":"https://github.com/gatsbyjs/gatsby-es/pull/135#discussion_r340890974"},"pull_request":{"href":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/135"}},"in_reply_to_id":340823244},"pull_request":{"url":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/135","id":334437156,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0NDM3MTU2","html_url":"https://github.com/gatsbyjs/gatsby-es/pull/135","diff_url":"https://github.com/gatsbyjs/gatsby-es/pull/135.diff","patch_url":"https://github.com/gatsbyjs/gatsby-es/pull/135.patch","issue_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/issues/135","number":135,"state":"open","locked":false,"title":"Translation of adding-search-with-algolia completed","user":{"login":"SerotoninaAbad","id":17627521,"node_id":"MDQ6VXNlcjE3NjI3NTIx","avatar_url":"https://avatars0.githubusercontent.com/u/17627521?v=4","gravatar_id":"","url":"https://api.github.com/users/SerotoninaAbad","html_url":"https://github.com/SerotoninaAbad","followers_url":"https://api.github.com/users/SerotoninaAbad/followers","following_url":"https://api.github.com/users/SerotoninaAbad/following{/other_user}","gists_url":"https://api.github.com/users/SerotoninaAbad/gists{/gist_id}","starred_url":"https://api.github.com/users/SerotoninaAbad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerotoninaAbad/subscriptions","organizations_url":"https://api.github.com/users/SerotoninaAbad/orgs","repos_url":"https://api.github.com/users/SerotoninaAbad/repos","events_url":"https://api.github.com/users/SerotoninaAbad/events{/privacy}","received_events_url":"https://api.github.com/users/SerotoninaAbad/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-30T18:21:42Z","updated_at":"2019-10-30T22:38:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57720d863344fea63643725be318e8720e206f57","assignee":{"login":"SerotoninaAbad","id":17627521,"node_id":"MDQ6VXNlcjE3NjI3NTIx","avatar_url":"https://avatars0.githubusercontent.com/u/17627521?v=4","gravatar_id":"","url":"https://api.github.com/users/SerotoninaAbad","html_url":"https://github.com/SerotoninaAbad","followers_url":"https://api.github.com/users/SerotoninaAbad/followers","following_url":"https://api.github.com/users/SerotoninaAbad/following{/other_user}","gists_url":"https://api.github.com/users/SerotoninaAbad/gists{/gist_id}","starred_url":"https://api.github.com/users/SerotoninaAbad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerotoninaAbad/subscriptions","organizations_url":"https://api.github.com/users/SerotoninaAbad/orgs","repos_url":"https://api.github.com/users/SerotoninaAbad/repos","events_url":"https://api.github.com/users/SerotoninaAbad/events{/privacy}","received_events_url":"https://api.github.com/users/SerotoninaAbad/received_events","type":"User","site_admin":false},"assignees":[{"login":"SerotoninaAbad","id":17627521,"node_id":"MDQ6VXNlcjE3NjI3NTIx","avatar_url":"https://avatars0.githubusercontent.com/u/17627521?v=4","gravatar_id":"","url":"https://api.github.com/users/SerotoninaAbad","html_url":"https://github.com/SerotoninaAbad","followers_url":"https://api.github.com/users/SerotoninaAbad/followers","following_url":"https://api.github.com/users/SerotoninaAbad/following{/other_user}","gists_url":"https://api.github.com/users/SerotoninaAbad/gists{/gist_id}","starred_url":"https://api.github.com/users/SerotoninaAbad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerotoninaAbad/subscriptions","organizations_url":"https://api.github.com/users/SerotoninaAbad/orgs","repos_url":"https://api.github.com/users/SerotoninaAbad/repos","events_url":"https://api.github.com/users/SerotoninaAbad/events{/privacy}","received_events_url":"https://api.github.com/users/SerotoninaAbad/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"horacioh","id":725120,"node_id":"MDQ6VXNlcjcyNTEyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/725120?v=4","gravatar_id":"","url":"https://api.github.com/users/horacioh","html_url":"https://github.com/horacioh","followers_url":"https://api.github.com/users/horacioh/followers","following_url":"https://api.github.com/users/horacioh/following{/other_user}","gists_url":"https://api.github.com/users/horacioh/gists{/gist_id}","starred_url":"https://api.github.com/users/horacioh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/horacioh/subscriptions","organizations_url":"https://api.github.com/users/horacioh/orgs","repos_url":"https://api.github.com/users/horacioh/repos","events_url":"https://api.github.com/users/horacioh/events{/privacy}","received_events_url":"https://api.github.com/users/horacioh/received_events","type":"User","site_admin":false},{"login":"nucliweb","id":1307927,"node_id":"MDQ6VXNlcjEzMDc5Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1307927?v=4","gravatar_id":"","url":"https://api.github.com/users/nucliweb","html_url":"https://github.com/nucliweb","followers_url":"https://api.github.com/users/nucliweb/followers","following_url":"https://api.github.com/users/nucliweb/following{/other_user}","gists_url":"https://api.github.com/users/nucliweb/gists{/gist_id}","starred_url":"https://api.github.com/users/nucliweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nucliweb/subscriptions","organizations_url":"https://api.github.com/users/nucliweb/orgs","repos_url":"https://api.github.com/users/nucliweb/repos","events_url":"https://api.github.com/users/nucliweb/events{/privacy}","received_events_url":"https://api.github.com/users/nucliweb/received_events","type":"User","site_admin":false},{"login":"Darking360","id":4975574,"node_id":"MDQ6VXNlcjQ5NzU1NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4975574?v=4","gravatar_id":"","url":"https://api.github.com/users/Darking360","html_url":"https://github.com/Darking360","followers_url":"https://api.github.com/users/Darking360/followers","following_url":"https://api.github.com/users/Darking360/following{/other_user}","gists_url":"https://api.github.com/users/Darking360/gists{/gist_id}","starred_url":"https://api.github.com/users/Darking360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darking360/subscriptions","organizations_url":"https://api.github.com/users/Darking360/orgs","repos_url":"https://api.github.com/users/Darking360/repos","events_url":"https://api.github.com/users/Darking360/events{/privacy}","received_events_url":"https://api.github.com/users/Darking360/received_events","type":"User","site_admin":false},{"login":"xmartinezpujol","id":15030492,"node_id":"MDQ6VXNlcjE1MDMwNDky","avatar_url":"https://avatars3.githubusercontent.com/u/15030492?v=4","gravatar_id":"","url":"https://api.github.com/users/xmartinezpujol","html_url":"https://github.com/xmartinezpujol","followers_url":"https://api.github.com/users/xmartinezpujol/followers","following_url":"https://api.github.com/users/xmartinezpujol/following{/other_user}","gists_url":"https://api.github.com/users/xmartinezpujol/gists{/gist_id}","starred_url":"https://api.github.com/users/xmartinezpujol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmartinezpujol/subscriptions","organizations_url":"https://api.github.com/users/xmartinezpujol/orgs","repos_url":"https://api.github.com/users/xmartinezpujol/repos","events_url":"https://api.github.com/users/xmartinezpujol/events{/privacy}","received_events_url":"https://api.github.com/users/xmartinezpujol/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1596290982,"node_id":"MDU6TGFiZWwxNTk2MjkwOTgy","url":"https://api.github.com/repos/gatsbyjs/gatsby-es/labels/in%20review","name":"in review","color":"c7f282","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/135/commits","review_comments_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/135/comments","review_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/issues/135/comments","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/statuses/b7f854613eacc723ae5da64bab1e17a3878f9137","head":{"label":"SerotoninaAbad:adding-search-with-algolia","ref":"adding-search-with-algolia","sha":"b7f854613eacc723ae5da64bab1e17a3878f9137","user":{"login":"SerotoninaAbad","id":17627521,"node_id":"MDQ6VXNlcjE3NjI3NTIx","avatar_url":"https://avatars0.githubusercontent.com/u/17627521?v=4","gravatar_id":"","url":"https://api.github.com/users/SerotoninaAbad","html_url":"https://github.com/SerotoninaAbad","followers_url":"https://api.github.com/users/SerotoninaAbad/followers","following_url":"https://api.github.com/users/SerotoninaAbad/following{/other_user}","gists_url":"https://api.github.com/users/SerotoninaAbad/gists{/gist_id}","starred_url":"https://api.github.com/users/SerotoninaAbad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerotoninaAbad/subscriptions","organizations_url":"https://api.github.com/users/SerotoninaAbad/orgs","repos_url":"https://api.github.com/users/SerotoninaAbad/repos","events_url":"https://api.github.com/users/SerotoninaAbad/events{/privacy}","received_events_url":"https://api.github.com/users/SerotoninaAbad/received_events","type":"User","site_admin":false},"repo":{"id":215668081,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU2NjgwODE=","name":"gatsby-es","full_name":"SerotoninaAbad/gatsby-es","private":false,"owner":{"login":"SerotoninaAbad","id":17627521,"node_id":"MDQ6VXNlcjE3NjI3NTIx","avatar_url":"https://avatars0.githubusercontent.com/u/17627521?v=4","gravatar_id":"","url":"https://api.github.com/users/SerotoninaAbad","html_url":"https://github.com/SerotoninaAbad","followers_url":"https://api.github.com/users/SerotoninaAbad/followers","following_url":"https://api.github.com/users/SerotoninaAbad/following{/other_user}","gists_url":"https://api.github.com/users/SerotoninaAbad/gists{/gist_id}","starred_url":"https://api.github.com/users/SerotoninaAbad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerotoninaAbad/subscriptions","organizations_url":"https://api.github.com/users/SerotoninaAbad/orgs","repos_url":"https://api.github.com/users/SerotoninaAbad/repos","events_url":"https://api.github.com/users/SerotoninaAbad/events{/privacy}","received_events_url":"https://api.github.com/users/SerotoninaAbad/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SerotoninaAbad/gatsby-es","description":"Gatsby documentation in Spanish","fork":true,"url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es","forks_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/forks","keys_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/teams","hooks_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/hooks","issue_events_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/issues/events{/number}","events_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/events","assignees_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/assignees{/user}","branches_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/branches{/branch}","tags_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/tags","blobs_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/git/refs{/sha}","trees_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/statuses/{sha}","languages_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/languages","stargazers_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/stargazers","contributors_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/contributors","subscribers_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/subscribers","subscription_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/subscription","commits_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/commits{/sha}","git_commits_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/git/commits{/sha}","comments_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/comments{/number}","issue_comment_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/issues/comments{/number}","contents_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/contents/{+path}","compare_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/merges","archive_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/downloads","issues_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/issues{/number}","pulls_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/pulls{/number}","milestones_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/milestones{/number}","notifications_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/labels{/name}","releases_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/releases{/id}","deployments_url":"https://api.github.com/repos/SerotoninaAbad/gatsby-es/deployments","created_at":"2019-10-17T00:17:05Z","updated_at":"2019-10-17T00:17:07Z","pushed_at":"2019-10-30T21:59:38Z","git_url":"git://github.com/SerotoninaAbad/gatsby-es.git","ssh_url":"git@github.com:SerotoninaAbad/gatsby-es.git","clone_url":"https://github.com/SerotoninaAbad/gatsby-es.git","svn_url":"https://github.com/SerotoninaAbad/gatsby-es","homepage":null,"size":229685,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gatsbyjs:master","ref":"master","sha":"2e3fe2ccac68e47cbd8acb39aa1e7654a5748ea8","user":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":211447802,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE0NDc4MDI=","name":"gatsby-es","full_name":"gatsbyjs/gatsby-es","private":false,"owner":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gatsbyjs/gatsby-es","description":"Gatsby documentation in Spanish","fork":false,"url":"https://api.github.com/repos/gatsbyjs/gatsby-es","forks_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/forks","keys_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/teams","hooks_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/hooks","issue_events_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/issues/events{/number}","events_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/events","assignees_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/assignees{/user}","branches_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/branches{/branch}","tags_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/tags","blobs_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/git/refs{/sha}","trees_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/statuses/{sha}","languages_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/languages","stargazers_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/stargazers","contributors_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/contributors","subscribers_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/subscribers","subscription_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/subscription","commits_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/commits{/sha}","git_commits_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/git/commits{/sha}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/comments{/number}","issue_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/issues/comments{/number}","contents_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/contents/{+path}","compare_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/merges","archive_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/downloads","issues_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/issues{/number}","pulls_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls{/number}","milestones_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/milestones{/number}","notifications_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/labels{/name}","releases_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/releases{/id}","deployments_url":"https://api.github.com/repos/gatsbyjs/gatsby-es/deployments","created_at":"2019-09-28T05:14:18Z","updated_at":"2019-10-30T21:54:41Z","pushed_at":"2019-10-30T21:59:39Z","git_url":"git://github.com/gatsbyjs/gatsby-es.git","ssh_url":"git@github.com:gatsbyjs/gatsby-es.git","clone_url":"https://github.com/gatsbyjs/gatsby-es.git","svn_url":"https://github.com/gatsbyjs/gatsby-es","homepage":null,"size":230122,"stargazers_count":18,"watchers_count":18,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":null,"forks":56,"open_issues":21,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/135"},"html":{"href":"https://github.com/gatsbyjs/gatsby-es/pull/135"},"issue":{"href":"https://api.github.com/repos/gatsbyjs/gatsby-es/issues/135"},"comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby-es/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gatsbyjs/gatsby-es/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/gatsbyjs/gatsby-es/statuses/b7f854613eacc723ae5da64bab1e17a3878f9137"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 211447802,
"name": "gatsbyjs/gatsby-es",
"url": "https://api.github.com/repos/gatsbyjs/gatsby-es"
}
|
{
"id": 17627521,
"login": "SerotoninaAbad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17627521?",
"url": "https://api.github.com/users/SerotoninaAbad"
}
|
{
"id": 12551863,
"login": "gatsbyjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12551863?",
"url": "https://api.github.com/orgs/gatsbyjs"
}
| 2019-10-30T22:38:42 |
10752429077
|
{"actor":{"display_login":"SerotoninaAbad"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rollup/plugins/pulls/comments/349929910","pull_request_review_id":321967784,"id":349929910,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0OTkyOTkxMA==","diff_hunk":"@@ -0,0 +1,94 @@\n+[npm]: https://img.shields.io/npm/v/@rollup/plugin-legacy\n+[npm-url]: https://www.npmjs.com/package/@rollup/plugin-legacy\n+[size]: https://packagephobia.now.sh/badge?p=@rollup/plugin-legacy\n+[size-url]: https://packagephobia.now.sh/result?p=@rollup/plugin-legacy\n+\n+[![npm][npm]][npm-url]\n+[![size][size]][size-url]\n+[](https://liberamanifesto.com)\n+\n+# @rollup/plugin-legacy\n+\n+Add `export` declarations to legacy non-module scripts.\n+\n+## Installation\n+\n+```bash\n+npm install --save-dev rollup-plugin-legacy\n+```\n+\n+## Motivation\n+\n+Occasionally you'll find a useful snippet of code from the Old Days, before newfangled technology like npm. These scripts will typically expose themselves as `var someLibrary = ...` or `window.someLibrary = ...`, the expectation being that other scripts will grab a reference to the library from the global namespace.\n+\n+It's usually easy enough to convert these to modules. But why bother? You can just add the `legacy` plugin, configure it accordingly, and it will be turned into a module automatically. With the example config below, the following code...\n+\n+```js\n+// vendor/some-library.js\n+var someLibrary = {\n+ square: function(n) {\n+ return n * n;\n+ },\n+ cube: function(n) {\n+ return n * n * n;\n+ }\n+};\n+```\n+\n+...will have a default export appended to it, allowing other modules to access it:\n+\n+```js\n+export default someLibrary;\n+```\n+\n+It can also handle named exports. Using the same config, this...\n+\n+```js\n+// vendor/another-library.js\n+var anotherLibrary = {\n+ foo: ...,\n+ bar: ...,\n+ baz: ...\n+};\n+```\n+\n+...will get the following appended:\n+\n+```js\n+var __export0 = anotherLibrary.foo;\n+export { __export0 as foo };\n+var __export0 = anotherLibrary.bar;\n+export { __export0 as bar };\n+var __export0 = anotherLibrary.baz;\n+export { __export0 as baz };\n+```\n+\n+## Usage\n+\n+```js\n+// rollup.config.js\n+import legacy from \"rollup-plugin-legacy\";\n+\n+export default {\n+ entry: \"src/main.js\",\n+ dest: \"bundle.js\",\n+ format: \"iife\",\n+ plugins: [\n+ legacy({\n+ // add a default export, corresponding to `someLibrary`\n+ \"vendor/some-library.js\": \"someLibrary\",","path":"packages/legacy/README.md","position":79,"original_position":79,"commit_id":"85d23b53da8d2e4f522aba1adfc6b9b81289d518","original_commit_id":"85d23b53da8d2e4f522aba1adfc6b9b81289d518","user":{"login":"shellscape","id":76371,"node_id":"MDQ6VXNlcjc2Mzcx","avatar_url":"https://avatars1.githubusercontent.com/u/76371?v=4","gravatar_id":"","url":"https://api.github.com/users/shellscape","html_url":"https://github.com/shellscape","followers_url":"https://api.github.com/users/shellscape/followers","following_url":"https://api.github.com/users/shellscape/following{/other_user}","gists_url":"https://api.github.com/users/shellscape/gists{/gist_id}","starred_url":"https://api.github.com/users/shellscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shellscape/subscriptions","organizations_url":"https://api.github.com/users/shellscape/orgs","repos_url":"https://api.github.com/users/shellscape/repos","events_url":"https://api.github.com/users/shellscape/events{/privacy}","received_events_url":"https://api.github.com/users/shellscape/received_events","type":"User","site_admin":false},"body":"Leverage the `Options` section to talk about the plugin's options. We do this even if options are pass-through to a dependency. ","created_at":"2019-11-24T15:20:56Z","updated_at":"2019-11-24T15:27:54Z","html_url":"https://github.com/rollup/plugins/pull/47#discussion_r349929910","pull_request_url":"https://api.github.com/repos/rollup/plugins/pulls/47","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rollup/plugins/pulls/comments/349929910"},"html":{"href":"https://github.com/rollup/plugins/pull/47#discussion_r349929910"},"pull_request":{"href":"https://api.github.com/repos/rollup/plugins/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/rollup/plugins/pulls/47","id":343185262,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzMTg1MjYy","html_url":"https://github.com/rollup/plugins/pull/47","diff_url":"https://github.com/rollup/plugins/pull/47.diff","patch_url":"https://github.com/rollup/plugins/pull/47.patch","issue_url":"https://api.github.com/repos/rollup/plugins/issues/47","number":47,"state":"open","locked":false,"title":"chore: migrate rollup-plugin-legacy","user":{"login":"NotWoods","id":1782266,"node_id":"MDQ6VXNlcjE3ODIyNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1782266?v=4","gravatar_id":"","url":"https://api.github.com/users/NotWoods","html_url":"https://github.com/NotWoods","followers_url":"https://api.github.com/users/NotWoods/followers","following_url":"https://api.github.com/users/NotWoods/following{/other_user}","gists_url":"https://api.github.com/users/NotWoods/gists{/gist_id}","starred_url":"https://api.github.com/users/NotWoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotWoods/subscriptions","organizations_url":"https://api.github.com/users/NotWoods/orgs","repos_url":"https://api.github.com/users/NotWoods/repos","events_url":"https://api.github.com/users/NotWoods/events{/privacy}","received_events_url":"https://api.github.com/users/NotWoods/received_events","type":"User","site_admin":false},"body":"<!--\r\n ⚡️ katchow! We ❤️ Pull Requests!\r\n\r\n If you remove or skip this template, you'll make the 🐼 sad and the mighty god\r\n of Github will appear and pile-drive the close button from a great height\r\n while making animal noises.\r\n\r\n Pull Request Requirements:\r\n * Please include tests to illustrate the problem this PR resolves.\r\n * Please lint your changes by running `npm run lint` before creating a PR.\r\n * Please update the documentation in `/docs` where necessary\r\n\r\n Please place an x (no spaces - [x]) in all [ ] that apply.\r\n-->\r\n\r\n<!-- the plugin(s) this PR is for -->\r\n## Rollup Plugin Name: `@rollup/plugin-legacy`\r\n\r\nThis PR contains:\r\n- [ ] bugfix\r\n- [ ] feature\r\n- [ ] refactor\r\n- [ ] documentation\r\n- [x] other\r\n\r\nAre tests included?\r\n- [x] yes (*bugfixes and features will not be merged without tests*)\r\n- [ ] no\r\n\r\nBreaking Changes?\r\n- [x] yes (*breaking changes will not be merged unless absolutely necessary*)\r\n- [ ] no\r\n\r\nList any relevant issue numbers:\r\n\r\n### Description\r\n\r\n<!--\r\n Please be thorough and clearly explain the problem being solved.\r\n * If this PR adds a feature, look for previous discussion on the feature by searching the issues first.\r\n * Is this PR related to an issue?\r\n-->\r\n\r\nThis PR migrates the rollup-plugin-legacy plugin.\r\n","created_at":"2019-11-20T06:00:22Z","updated_at":"2019-11-24T15:27:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e1449a89b8a39fd415e03e1a33ee5c7df156e92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rollup/plugins/pulls/47/commits","review_comments_url":"https://api.github.com/repos/rollup/plugins/pulls/47/comments","review_comment_url":"https://api.github.com/repos/rollup/plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rollup/plugins/issues/47/comments","statuses_url":"https://api.github.com/repos/rollup/plugins/statuses/85d23b53da8d2e4f522aba1adfc6b9b81289d518","head":{"label":"NotWoods:add/legacy","ref":"add/legacy","sha":"85d23b53da8d2e4f522aba1adfc6b9b81289d518","user":{"login":"NotWoods","id":1782266,"node_id":"MDQ6VXNlcjE3ODIyNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1782266?v=4","gravatar_id":"","url":"https://api.github.com/users/NotWoods","html_url":"https://github.com/NotWoods","followers_url":"https://api.github.com/users/NotWoods/followers","following_url":"https://api.github.com/users/NotWoods/following{/other_user}","gists_url":"https://api.github.com/users/NotWoods/gists{/gist_id}","starred_url":"https://api.github.com/users/NotWoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotWoods/subscriptions","organizations_url":"https://api.github.com/users/NotWoods/orgs","repos_url":"https://api.github.com/users/NotWoods/repos","events_url":"https://api.github.com/users/NotWoods/events{/privacy}","received_events_url":"https://api.github.com/users/NotWoods/received_events","type":"User","site_admin":false},"repo":{"id":222861788,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI4NjE3ODg=","name":"plugins","full_name":"NotWoods/plugins","private":false,"owner":{"login":"NotWoods","id":1782266,"node_id":"MDQ6VXNlcjE3ODIyNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1782266?v=4","gravatar_id":"","url":"https://api.github.com/users/NotWoods","html_url":"https://github.com/NotWoods","followers_url":"https://api.github.com/users/NotWoods/followers","following_url":"https://api.github.com/users/NotWoods/following{/other_user}","gists_url":"https://api.github.com/users/NotWoods/gists{/gist_id}","starred_url":"https://api.github.com/users/NotWoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotWoods/subscriptions","organizations_url":"https://api.github.com/users/NotWoods/orgs","repos_url":"https://api.github.com/users/NotWoods/repos","events_url":"https://api.github.com/users/NotWoods/events{/privacy}","received_events_url":"https://api.github.com/users/NotWoods/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NotWoods/plugins","description":"🍣 The one-stop shop for official Rollup plugins","fork":true,"url":"https://api.github.com/repos/NotWoods/plugins","forks_url":"https://api.github.com/repos/NotWoods/plugins/forks","keys_url":"https://api.github.com/repos/NotWoods/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NotWoods/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NotWoods/plugins/teams","hooks_url":"https://api.github.com/repos/NotWoods/plugins/hooks","issue_events_url":"https://api.github.com/repos/NotWoods/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/NotWoods/plugins/events","assignees_url":"https://api.github.com/repos/NotWoods/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/NotWoods/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/NotWoods/plugins/tags","blobs_url":"https://api.github.com/repos/NotWoods/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NotWoods/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NotWoods/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/NotWoods/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NotWoods/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/NotWoods/plugins/languages","stargazers_url":"https://api.github.com/repos/NotWoods/plugins/stargazers","contributors_url":"https://api.github.com/repos/NotWoods/plugins/contributors","subscribers_url":"https://api.github.com/repos/NotWoods/plugins/subscribers","subscription_url":"https://api.github.com/repos/NotWoods/plugins/subscription","commits_url":"https://api.github.com/repos/NotWoods/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/NotWoods/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/NotWoods/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/NotWoods/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/NotWoods/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/NotWoods/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NotWoods/plugins/merges","archive_url":"https://api.github.com/repos/NotWoods/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NotWoods/plugins/downloads","issues_url":"https://api.github.com/repos/NotWoods/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/NotWoods/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/NotWoods/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/NotWoods/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NotWoods/plugins/labels{/name}","releases_url":"https://api.github.com/repos/NotWoods/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/NotWoods/plugins/deployments","created_at":"2019-11-20T05:56:02Z","updated_at":"2019-11-20T05:56:04Z","pushed_at":"2019-11-20T05:56:22Z","git_url":"git://github.com/NotWoods/plugins.git","ssh_url":"git@github.com:NotWoods/plugins.git","clone_url":"https://github.com/NotWoods/plugins.git","svn_url":"https://github.com/NotWoods/plugins","homepage":null,"size":554,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rollup:master","ref":"master","sha":"af4ebe3741ba342dd8e7fd994fa91b65d12a1123","user":{"login":"rollup","id":12554859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTU0ODU5","avatar_url":"https://avatars2.githubusercontent.com/u/12554859?v=4","gravatar_id":"","url":"https://api.github.com/users/rollup","html_url":"https://github.com/rollup","followers_url":"https://api.github.com/users/rollup/followers","following_url":"https://api.github.com/users/rollup/following{/other_user}","gists_url":"https://api.github.com/users/rollup/gists{/gist_id}","starred_url":"https://api.github.com/users/rollup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollup/subscriptions","organizations_url":"https://api.github.com/users/rollup/orgs","repos_url":"https://api.github.com/users/rollup/repos","events_url":"https://api.github.com/users/rollup/events{/privacy}","received_events_url":"https://api.github.com/users/rollup/received_events","type":"Organization","site_admin":false},"repo":{"id":203607977,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM2MDc5Nzc=","name":"plugins","full_name":"rollup/plugins","private":false,"owner":{"login":"rollup","id":12554859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTU0ODU5","avatar_url":"https://avatars2.githubusercontent.com/u/12554859?v=4","gravatar_id":"","url":"https://api.github.com/users/rollup","html_url":"https://github.com/rollup","followers_url":"https://api.github.com/users/rollup/followers","following_url":"https://api.github.com/users/rollup/following{/other_user}","gists_url":"https://api.github.com/users/rollup/gists{/gist_id}","starred_url":"https://api.github.com/users/rollup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollup/subscriptions","organizations_url":"https://api.github.com/users/rollup/orgs","repos_url":"https://api.github.com/users/rollup/repos","events_url":"https://api.github.com/users/rollup/events{/privacy}","received_events_url":"https://api.github.com/users/rollup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rollup/plugins","description":"🍣 The one-stop shop for official Rollup plugins","fork":false,"url":"https://api.github.com/repos/rollup/plugins","forks_url":"https://api.github.com/repos/rollup/plugins/forks","keys_url":"https://api.github.com/repos/rollup/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rollup/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rollup/plugins/teams","hooks_url":"https://api.github.com/repos/rollup/plugins/hooks","issue_events_url":"https://api.github.com/repos/rollup/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/rollup/plugins/events","assignees_url":"https://api.github.com/repos/rollup/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/rollup/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/rollup/plugins/tags","blobs_url":"https://api.github.com/repos/rollup/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rollup/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rollup/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/rollup/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rollup/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/rollup/plugins/languages","stargazers_url":"https://api.github.com/repos/rollup/plugins/stargazers","contributors_url":"https://api.github.com/repos/rollup/plugins/contributors","subscribers_url":"https://api.github.com/repos/rollup/plugins/subscribers","subscription_url":"https://api.github.com/repos/rollup/plugins/subscription","commits_url":"https://api.github.com/repos/rollup/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/rollup/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/rollup/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/rollup/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/rollup/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/rollup/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rollup/plugins/merges","archive_url":"https://api.github.com/repos/rollup/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rollup/plugins/downloads","issues_url":"https://api.github.com/repos/rollup/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/rollup/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/rollup/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/rollup/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rollup/plugins/labels{/name}","releases_url":"https://api.github.com/repos/rollup/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/rollup/plugins/deployments","created_at":"2019-08-21T15:02:50Z","updated_at":"2019-11-23T11:25:20Z","pushed_at":"2019-11-24T07:28:07Z","git_url":"git://github.com/rollup/plugins.git","ssh_url":"git@github.com:rollup/plugins.git","clone_url":"https://github.com/rollup/plugins.git","svn_url":"https://github.com/rollup/plugins","homepage":null,"size":441,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":18,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rollup/plugins/pulls/47"},"html":{"href":"https://github.com/rollup/plugins/pull/47"},"issue":{"href":"https://api.github.com/repos/rollup/plugins/issues/47"},"comments":{"href":"https://api.github.com/repos/rollup/plugins/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/rollup/plugins/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/rollup/plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rollup/plugins/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/rollup/plugins/statuses/85d23b53da8d2e4f522aba1adfc6b9b81289d518"}},"author_association":"MEMBER"}}
|
{
"id": 203607977,
"name": "rollup/plugins",
"url": "https://api.github.com/repos/rollup/plugins"
}
|
{
"id": 76371,
"login": "shellscape",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/76371?",
"url": "https://api.github.com/users/shellscape"
}
|
{
"id": 12554859,
"login": "rollup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12554859?",
"url": "https://api.github.com/orgs/rollup"
}
| 2019-11-24T15:20:56 |
10934999304
|
{"actor":{"display_login":"shellscape"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/comments/268811137","pull_request_review_id":218535130,"id":268811137,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODgxMTEzNw==","diff_hunk":"@@ -0,0 +1,52 @@\n+# Testing Student Exercise API\n+\n+## Practice\n+\n+You need to create integration tests for the following features of your Student Exercises API.\n+\n+1. Basic CRUD for Exercises\n+1. Basic CRUD for Cohorts\n+1. Basic CRUD for Instructors\n+1. Basic CRUD for Exercises","path":"book-2-platform-api/chapters/STUDENT_EXERCISES_TESTING.md","position":10,"original_position":10,"commit_id":"70daf3aa7de92cf50e034e0bec5788fff85c2ba8","original_commit_id":"70daf3aa7de92cf50e034e0bec5788fff85c2ba8","user":{"login":"stevebrownlee","id":218592,"node_id":"MDQ6VXNlcjIxODU5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/218592?v=4","gravatar_id":"","url":"https://api.github.com/users/stevebrownlee","html_url":"https://github.com/stevebrownlee","followers_url":"https://api.github.com/users/stevebrownlee/followers","following_url":"https://api.github.com/users/stevebrownlee/following{/other_user}","gists_url":"https://api.github.com/users/stevebrownlee/gists{/gist_id}","starred_url":"https://api.github.com/users/stevebrownlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevebrownlee/subscriptions","organizations_url":"https://api.github.com/users/stevebrownlee/orgs","repos_url":"https://api.github.com/users/stevebrownlee/repos","events_url":"https://api.github.com/users/stevebrownlee/events{/privacy}","received_events_url":"https://api.github.com/users/stevebrownlee/received_events","type":"User","site_admin":false},"body":"Changed","created_at":"2019-03-25T19:19:27Z","updated_at":"2019-03-25T19:19:27Z","html_url":"https://github.com/nashville-software-school/bangazon-inc/pull/114#discussion_r268811137","pull_request_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/114","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/comments/268811137"},"html":{"href":"https://github.com/nashville-software-school/bangazon-inc/pull/114#discussion_r268811137"},"pull_request":{"href":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/114"}},"in_reply_to_id":268780355},"pull_request":{"url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/114","id":263018822,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzMDE4ODIy","html_url":"https://github.com/nashville-software-school/bangazon-inc/pull/114","diff_url":"https://github.com/nashville-software-school/bangazon-inc/pull/114.diff","patch_url":"https://github.com/nashville-software-school/bangazon-inc/pull/114.patch","issue_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues/114","number":114,"state":"open","locked":false,"title":"Initial content for API integration testing and exercise","user":{"login":"stevebrownlee","id":218592,"node_id":"MDQ6VXNlcjIxODU5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/218592?v=4","gravatar_id":"","url":"https://api.github.com/users/stevebrownlee","html_url":"https://github.com/stevebrownlee","followers_url":"https://api.github.com/users/stevebrownlee/followers","following_url":"https://api.github.com/users/stevebrownlee/following{/other_user}","gists_url":"https://api.github.com/users/stevebrownlee/gists{/gist_id}","starred_url":"https://api.github.com/users/stevebrownlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevebrownlee/subscriptions","organizations_url":"https://api.github.com/users/stevebrownlee/orgs","repos_url":"https://api.github.com/users/stevebrownlee/repos","events_url":"https://api.github.com/users/stevebrownlee/events{/privacy}","received_events_url":"https://api.github.com/users/stevebrownlee/received_events","type":"User","site_admin":false},"body":"Pulled main content from Andy's integration testing chapter in Book 3 and modifying it for use in API integration testing. Built the Student Exercises exercise they should work on for integration testing - along with a challenge.","created_at":"2019-03-20T20:08:00Z","updated_at":"2019-03-25T19:19:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c6f6641bec7116b10152e64ec8bc6e49b322798","assignee":null,"assignees":[],"requested_reviewers":[{"login":"copypastedeveloper","id":672401,"node_id":"MDQ6VXNlcjY3MjQwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/672401?v=4","gravatar_id":"","url":"https://api.github.com/users/copypastedeveloper","html_url":"https://github.com/copypastedeveloper","followers_url":"https://api.github.com/users/copypastedeveloper/followers","following_url":"https://api.github.com/users/copypastedeveloper/following{/other_user}","gists_url":"https://api.github.com/users/copypastedeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/copypastedeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copypastedeveloper/subscriptions","organizations_url":"https://api.github.com/users/copypastedeveloper/orgs","repos_url":"https://api.github.com/users/copypastedeveloper/repos","events_url":"https://api.github.com/users/copypastedeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/copypastedeveloper/received_events","type":"User","site_admin":false},{"login":"MissPeperr","id":26916172,"node_id":"MDQ6VXNlcjI2OTE2MTcy","avatar_url":"https://avatars2.githubusercontent.com/u/26916172?v=4","gravatar_id":"","url":"https://api.github.com/users/MissPeperr","html_url":"https://github.com/MissPeperr","followers_url":"https://api.github.com/users/MissPeperr/followers","following_url":"https://api.github.com/users/MissPeperr/following{/other_user}","gists_url":"https://api.github.com/users/MissPeperr/gists{/gist_id}","starred_url":"https://api.github.com/users/MissPeperr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MissPeperr/subscriptions","organizations_url":"https://api.github.com/users/MissPeperr/orgs","repos_url":"https://api.github.com/users/MissPeperr/repos","events_url":"https://api.github.com/users/MissPeperr/events{/privacy}","received_events_url":"https://api.github.com/users/MissPeperr/received_events","type":"User","site_admin":false},{"login":"leahhoefling","id":39492952,"node_id":"MDQ6VXNlcjM5NDkyOTUy","avatar_url":"https://avatars1.githubusercontent.com/u/39492952?v=4","gravatar_id":"","url":"https://api.github.com/users/leahhoefling","html_url":"https://github.com/leahhoefling","followers_url":"https://api.github.com/users/leahhoefling/followers","following_url":"https://api.github.com/users/leahhoefling/following{/other_user}","gists_url":"https://api.github.com/users/leahhoefling/gists{/gist_id}","starred_url":"https://api.github.com/users/leahhoefling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leahhoefling/subscriptions","organizations_url":"https://api.github.com/users/leahhoefling/orgs","repos_url":"https://api.github.com/users/leahhoefling/repos","events_url":"https://api.github.com/users/leahhoefling/events{/privacy}","received_events_url":"https://api.github.com/users/leahhoefling/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/114/commits","review_comments_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/114/comments","review_comment_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues/114/comments","statuses_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/statuses/70daf3aa7de92cf50e034e0bec5788fff85c2ba8","head":{"label":"nashville-software-school:api-integration-testing","ref":"api-integration-testing","sha":"70daf3aa7de92cf50e034e0bec5788fff85c2ba8","user":{"login":"nashville-software-school","id":12634274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM0Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/12634274?v=4","gravatar_id":"","url":"https://api.github.com/users/nashville-software-school","html_url":"https://github.com/nashville-software-school","followers_url":"https://api.github.com/users/nashville-software-school/followers","following_url":"https://api.github.com/users/nashville-software-school/following{/other_user}","gists_url":"https://api.github.com/users/nashville-software-school/gists{/gist_id}","starred_url":"https://api.github.com/users/nashville-software-school/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashville-software-school/subscriptions","organizations_url":"https://api.github.com/users/nashville-software-school/orgs","repos_url":"https://api.github.com/users/nashville-software-school/repos","events_url":"https://api.github.com/users/nashville-software-school/events{/privacy}","received_events_url":"https://api.github.com/users/nashville-software-school/received_events","type":"Organization","site_admin":false},"repo":{"id":69049383,"node_id":"MDEwOlJlcG9zaXRvcnk2OTA0OTM4Mw==","name":"bangazon-inc","full_name":"nashville-software-school/bangazon-inc","private":false,"owner":{"login":"nashville-software-school","id":12634274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM0Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/12634274?v=4","gravatar_id":"","url":"https://api.github.com/users/nashville-software-school","html_url":"https://github.com/nashville-software-school","followers_url":"https://api.github.com/users/nashville-software-school/followers","following_url":"https://api.github.com/users/nashville-software-school/following{/other_user}","gists_url":"https://api.github.com/users/nashville-software-school/gists{/gist_id}","starred_url":"https://api.github.com/users/nashville-software-school/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashville-software-school/subscriptions","organizations_url":"https://api.github.com/users/nashville-software-school/orgs","repos_url":"https://api.github.com/users/nashville-software-school/repos","events_url":"https://api.github.com/users/nashville-software-school/events{/privacy}","received_events_url":"https://api.github.com/users/nashville-software-school/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nashville-software-school/bangazon-inc","description":"Bangazon Inc. is an NSS subsidiary company that employs students for C# project work","fork":false,"url":"https://api.github.com/repos/nashville-software-school/bangazon-inc","forks_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/forks","keys_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/teams","hooks_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/hooks","issue_events_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues/events{/number}","events_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/events","assignees_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/assignees{/user}","branches_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/branches{/branch}","tags_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/tags","blobs_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/refs{/sha}","trees_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/statuses/{sha}","languages_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/languages","stargazers_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/stargazers","contributors_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/contributors","subscribers_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/subscribers","subscription_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/subscription","commits_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/commits{/sha}","git_commits_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/commits{/sha}","comments_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/comments{/number}","issue_comment_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues/comments{/number}","contents_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/contents/{+path}","compare_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/merges","archive_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/downloads","issues_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues{/number}","pulls_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls{/number}","milestones_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/milestones{/number}","notifications_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/labels{/name}","releases_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/releases{/id}","deployments_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/deployments","created_at":"2016-09-23T18:10:15Z","updated_at":"2019-03-21T19:39:36Z","pushed_at":"2019-03-25T14:06:17Z","git_url":"git://github.com/nashville-software-school/bangazon-inc.git","ssh_url":"git@github.com:nashville-software-school/bangazon-inc.git","clone_url":"https://github.com/nashville-software-school/bangazon-inc.git","svn_url":"https://github.com/nashville-software-school/bangazon-inc","homepage":"","size":23246,"stargazers_count":32,"watchers_count":32,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":43,"open_issues":10,"watchers":32,"default_branch":"master"}},"base":{"label":"nashville-software-school:master","ref":"master","sha":"4e0a359bd489f2be587ee3d59d2149a782100c96","user":{"login":"nashville-software-school","id":12634274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM0Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/12634274?v=4","gravatar_id":"","url":"https://api.github.com/users/nashville-software-school","html_url":"https://github.com/nashville-software-school","followers_url":"https://api.github.com/users/nashville-software-school/followers","following_url":"https://api.github.com/users/nashville-software-school/following{/other_user}","gists_url":"https://api.github.com/users/nashville-software-school/gists{/gist_id}","starred_url":"https://api.github.com/users/nashville-software-school/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashville-software-school/subscriptions","organizations_url":"https://api.github.com/users/nashville-software-school/orgs","repos_url":"https://api.github.com/users/nashville-software-school/repos","events_url":"https://api.github.com/users/nashville-software-school/events{/privacy}","received_events_url":"https://api.github.com/users/nashville-software-school/received_events","type":"Organization","site_admin":false},"repo":{"id":69049383,"node_id":"MDEwOlJlcG9zaXRvcnk2OTA0OTM4Mw==","name":"bangazon-inc","full_name":"nashville-software-school/bangazon-inc","private":false,"owner":{"login":"nashville-software-school","id":12634274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM0Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/12634274?v=4","gravatar_id":"","url":"https://api.github.com/users/nashville-software-school","html_url":"https://github.com/nashville-software-school","followers_url":"https://api.github.com/users/nashville-software-school/followers","following_url":"https://api.github.com/users/nashville-software-school/following{/other_user}","gists_url":"https://api.github.com/users/nashville-software-school/gists{/gist_id}","starred_url":"https://api.github.com/users/nashville-software-school/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashville-software-school/subscriptions","organizations_url":"https://api.github.com/users/nashville-software-school/orgs","repos_url":"https://api.github.com/users/nashville-software-school/repos","events_url":"https://api.github.com/users/nashville-software-school/events{/privacy}","received_events_url":"https://api.github.com/users/nashville-software-school/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nashville-software-school/bangazon-inc","description":"Bangazon Inc. is an NSS subsidiary company that employs students for C# project work","fork":false,"url":"https://api.github.com/repos/nashville-software-school/bangazon-inc","forks_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/forks","keys_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/teams","hooks_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/hooks","issue_events_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues/events{/number}","events_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/events","assignees_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/assignees{/user}","branches_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/branches{/branch}","tags_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/tags","blobs_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/refs{/sha}","trees_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/statuses/{sha}","languages_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/languages","stargazers_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/stargazers","contributors_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/contributors","subscribers_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/subscribers","subscription_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/subscription","commits_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/commits{/sha}","git_commits_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/git/commits{/sha}","comments_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/comments{/number}","issue_comment_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues/comments{/number}","contents_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/contents/{+path}","compare_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/merges","archive_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/downloads","issues_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues{/number}","pulls_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls{/number}","milestones_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/milestones{/number}","notifications_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/labels{/name}","releases_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/releases{/id}","deployments_url":"https://api.github.com/repos/nashville-software-school/bangazon-inc/deployments","created_at":"2016-09-23T18:10:15Z","updated_at":"2019-03-21T19:39:36Z","pushed_at":"2019-03-25T14:06:17Z","git_url":"git://github.com/nashville-software-school/bangazon-inc.git","ssh_url":"git@github.com:nashville-software-school/bangazon-inc.git","clone_url":"https://github.com/nashville-software-school/bangazon-inc.git","svn_url":"https://github.com/nashville-software-school/bangazon-inc","homepage":"","size":23246,"stargazers_count":32,"watchers_count":32,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":43,"open_issues":10,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/114"},"html":{"href":"https://github.com/nashville-software-school/bangazon-inc/pull/114"},"issue":{"href":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues/114"},"comments":{"href":"https://api.github.com/repos/nashville-software-school/bangazon-inc/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nashville-software-school/bangazon-inc/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/nashville-software-school/bangazon-inc/statuses/70daf3aa7de92cf50e034e0bec5788fff85c2ba8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 69049383,
"name": "nashville-software-school/bangazon-inc",
"url": "https://api.github.com/repos/nashville-software-school/bangazon-inc"
}
|
{
"id": 218592,
"login": "stevebrownlee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/218592?",
"url": "https://api.github.com/users/stevebrownlee"
}
|
{
"id": 12634274,
"login": "nashville-software-school",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12634274?",
"url": "https://api.github.com/orgs/nashville-software-school"
}
| 2019-03-25T19:19:27 |
9310652239
|
{"actor":{"display_login":"stevebrownlee"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/comments/255339220","pull_request_review_id":201905189,"id":255339220,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTMzOTIyMA==","diff_hunk":"@@ -29,6 +29,7 @@ class CfgPatches {\n \"cba_diagnostic\",\n \"cba_help\",\n \"cba_jr\",\n+ \"cba_jam\",","path":"addons/main/config.cpp","position":4,"original_position":4,"commit_id":"2a5a1d3095f545e20640b0576edeec41d543fe3d","original_commit_id":"2a5a1d3095f545e20640b0576edeec41d543fe3d","user":{"login":"dedmen","id":3768165,"node_id":"MDQ6VXNlcjM3NjgxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3768165?v=4","gravatar_id":"","url":"https://api.github.com/users/dedmen","html_url":"https://github.com/dedmen","followers_url":"https://api.github.com/users/dedmen/followers","following_url":"https://api.github.com/users/dedmen/following{/other_user}","gists_url":"https://api.github.com/users/dedmen/gists{/gist_id}","starred_url":"https://api.github.com/users/dedmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedmen/subscriptions","organizations_url":"https://api.github.com/users/dedmen/orgs","repos_url":"https://api.github.com/users/dedmen/repos","events_url":"https://api.github.com/users/dedmen/events{/privacy}","received_events_url":"https://api.github.com/users/dedmen/received_events","type":"User","site_admin":false},"body":"Are these sorted? ja < jr","created_at":"2019-02-10T14:11:16Z","updated_at":"2019-02-10T14:11:16Z","html_url":"https://github.com/CBATeam/CBA_A3/pull/1062#discussion_r255339220","pull_request_url":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/1062","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/comments/255339220"},"html":{"href":"https://github.com/CBATeam/CBA_A3/pull/1062#discussion_r255339220"},"pull_request":{"href":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/1062"}}},"pull_request":{"url":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/1062","id":251734291,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNzM0Mjkx","html_url":"https://github.com/CBATeam/CBA_A3/pull/1062","diff_url":"https://github.com/CBATeam/CBA_A3/pull/1062.diff","patch_url":"https://github.com/CBATeam/CBA_A3/pull/1062.patch","issue_url":"https://api.github.com/repos/CBATeam/CBA_A3/issues/1062","number":1062,"state":"open","locked":false,"title":"add cba_jam to requiredAddons in cba_main","user":{"login":"commy2","id":6576312,"node_id":"MDQ6VXNlcjY1NzYzMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6576312?v=4","gravatar_id":"","url":"https://api.github.com/users/commy2","html_url":"https://github.com/commy2","followers_url":"https://api.github.com/users/commy2/followers","following_url":"https://api.github.com/users/commy2/following{/other_user}","gists_url":"https://api.github.com/users/commy2/gists{/gist_id}","starred_url":"https://api.github.com/users/commy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commy2/subscriptions","organizations_url":"https://api.github.com/users/commy2/orgs","repos_url":"https://api.github.com/users/commy2/repos","events_url":"https://api.github.com/users/commy2/events{/privacy}","received_events_url":"https://api.github.com/users/commy2/received_events","type":"User","site_admin":false},"body":"**When merged this pull request will:**\r\n- makes sure main is loaded after jam\r\n- like all other cba components","created_at":"2019-02-10T12:05:49Z","updated_at":"2019-02-10T14:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73e072829f4d5b60efbb97eb7a44eab3f3169a81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":218243260,"node_id":"MDU6TGFiZWwyMTgyNDMyNjA=","url":"https://api.github.com/repos/CBATeam/CBA_A3/labels/Bug%20Fix","name":"Bug Fix","color":"009800","default":false},{"id":727463342,"node_id":"MDU6TGFiZWw3Mjc0NjMzNDI=","url":"https://api.github.com/repos/CBATeam/CBA_A3/labels/Cleanup","name":"Cleanup","color":"ff5566","default":false}],"milestone":{"url":"https://api.github.com/repos/CBATeam/CBA_A3/milestones/34","html_url":"https://github.com/CBATeam/CBA_A3/milestone/34","labels_url":"https://api.github.com/repos/CBATeam/CBA_A3/milestones/34/labels","id":3450473,"node_id":"MDk6TWlsZXN0b25lMzQ1MDQ3Mw==","number":34,"title":"3.10","description":"","creator":{"login":"commy2","id":6576312,"node_id":"MDQ6VXNlcjY1NzYzMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6576312?v=4","gravatar_id":"","url":"https://api.github.com/users/commy2","html_url":"https://github.com/commy2","followers_url":"https://api.github.com/users/commy2/followers","following_url":"https://api.github.com/users/commy2/following{/other_user}","gists_url":"https://api.github.com/users/commy2/gists{/gist_id}","starred_url":"https://api.github.com/users/commy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commy2/subscriptions","organizations_url":"https://api.github.com/users/commy2/orgs","repos_url":"https://api.github.com/users/commy2/repos","events_url":"https://api.github.com/users/commy2/events{/privacy}","received_events_url":"https://api.github.com/users/commy2/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":12,"state":"open","created_at":"2018-06-25T17:28:04Z","updated_at":"2019-02-10T12:05:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/1062/commits","review_comments_url":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/1062/comments","review_comment_url":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CBATeam/CBA_A3/issues/1062/comments","statuses_url":"https://api.github.com/repos/CBATeam/CBA_A3/statuses/2a5a1d3095f545e20640b0576edeec41d543fe3d","head":{"label":"CBATeam:jam-requiredAddons","ref":"jam-requiredAddons","sha":"2a5a1d3095f545e20640b0576edeec41d543fe3d","user":{"login":"CBATeam","id":12647545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjQ3NTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12647545?v=4","gravatar_id":"","url":"https://api.github.com/users/CBATeam","html_url":"https://github.com/CBATeam","followers_url":"https://api.github.com/users/CBATeam/followers","following_url":"https://api.github.com/users/CBATeam/following{/other_user}","gists_url":"https://api.github.com/users/CBATeam/gists{/gist_id}","starred_url":"https://api.github.com/users/CBATeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CBATeam/subscriptions","organizations_url":"https://api.github.com/users/CBATeam/orgs","repos_url":"https://api.github.com/users/CBATeam/repos","events_url":"https://api.github.com/users/CBATeam/events{/privacy}","received_events_url":"https://api.github.com/users/CBATeam/received_events","type":"Organization","site_admin":false},"repo":{"id":36454957,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQ1NDk1Nw==","name":"CBA_A3","full_name":"CBATeam/CBA_A3","private":false,"owner":{"login":"CBATeam","id":12647545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjQ3NTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12647545?v=4","gravatar_id":"","url":"https://api.github.com/users/CBATeam","html_url":"https://github.com/CBATeam","followers_url":"https://api.github.com/users/CBATeam/followers","following_url":"https://api.github.com/users/CBATeam/following{/other_user}","gists_url":"https://api.github.com/users/CBATeam/gists{/gist_id}","starred_url":"https://api.github.com/users/CBATeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CBATeam/subscriptions","organizations_url":"https://api.github.com/users/CBATeam/orgs","repos_url":"https://api.github.com/users/CBATeam/repos","events_url":"https://api.github.com/users/CBATeam/events{/privacy}","received_events_url":"https://api.github.com/users/CBATeam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CBATeam/CBA_A3","description":"Community Base Addons for Arma 3","fork":false,"url":"https://api.github.com/repos/CBATeam/CBA_A3","forks_url":"https://api.github.com/repos/CBATeam/CBA_A3/forks","keys_url":"https://api.github.com/repos/CBATeam/CBA_A3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CBATeam/CBA_A3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CBATeam/CBA_A3/teams","hooks_url":"https://api.github.com/repos/CBATeam/CBA_A3/hooks","issue_events_url":"https://api.github.com/repos/CBATeam/CBA_A3/issues/events{/number}","events_url":"https://api.github.com/repos/CBATeam/CBA_A3/events","assignees_url":"https://api.github.com/repos/CBATeam/CBA_A3/assignees{/user}","branches_url":"https://api.github.com/repos/CBATeam/CBA_A3/branches{/branch}","tags_url":"https://api.github.com/repos/CBATeam/CBA_A3/tags","blobs_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/refs{/sha}","trees_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CBATeam/CBA_A3/statuses/{sha}","languages_url":"https://api.github.com/repos/CBATeam/CBA_A3/languages","stargazers_url":"https://api.github.com/repos/CBATeam/CBA_A3/stargazers","contributors_url":"https://api.github.com/repos/CBATeam/CBA_A3/contributors","subscribers_url":"https://api.github.com/repos/CBATeam/CBA_A3/subscribers","subscription_url":"https://api.github.com/repos/CBATeam/CBA_A3/subscription","commits_url":"https://api.github.com/repos/CBATeam/CBA_A3/commits{/sha}","git_commits_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/commits{/sha}","comments_url":"https://api.github.com/repos/CBATeam/CBA_A3/comments{/number}","issue_comment_url":"https://api.github.com/repos/CBATeam/CBA_A3/issues/comments{/number}","contents_url":"https://api.github.com/repos/CBATeam/CBA_A3/contents/{+path}","compare_url":"https://api.github.com/repos/CBATeam/CBA_A3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CBATeam/CBA_A3/merges","archive_url":"https://api.github.com/repos/CBATeam/CBA_A3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CBATeam/CBA_A3/downloads","issues_url":"https://api.github.com/repos/CBATeam/CBA_A3/issues{/number}","pulls_url":"https://api.github.com/repos/CBATeam/CBA_A3/pulls{/number}","milestones_url":"https://api.github.com/repos/CBATeam/CBA_A3/milestones{/number}","notifications_url":"https://api.github.com/repos/CBATeam/CBA_A3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CBATeam/CBA_A3/labels{/name}","releases_url":"https://api.github.com/repos/CBATeam/CBA_A3/releases{/id}","deployments_url":"https://api.github.com/repos/CBATeam/CBA_A3/deployments","created_at":"2015-05-28T17:34:05Z","updated_at":"2019-02-09T14:47:36Z","pushed_at":"2019-02-10T12:05:50Z","git_url":"git://github.com/CBATeam/CBA_A3.git","ssh_url":"git@github.com:CBATeam/CBA_A3.git","clone_url":"https://github.com/CBATeam/CBA_A3.git","svn_url":"https://github.com/CBATeam/CBA_A3","homepage":"","size":20276,"stargazers_count":218,"watchers_count":218,"language":"SQF","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":89,"open_issues":19,"watchers":218,"default_branch":"master"}},"base":{"label":"CBATeam:master","ref":"master","sha":"61dd3325e17a512a9e40659ef68752c8c7b85e4d","user":{"login":"CBATeam","id":12647545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjQ3NTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12647545?v=4","gravatar_id":"","url":"https://api.github.com/users/CBATeam","html_url":"https://github.com/CBATeam","followers_url":"https://api.github.com/users/CBATeam/followers","following_url":"https://api.github.com/users/CBATeam/following{/other_user}","gists_url":"https://api.github.com/users/CBATeam/gists{/gist_id}","starred_url":"https://api.github.com/users/CBATeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CBATeam/subscriptions","organizations_url":"https://api.github.com/users/CBATeam/orgs","repos_url":"https://api.github.com/users/CBATeam/repos","events_url":"https://api.github.com/users/CBATeam/events{/privacy}","received_events_url":"https://api.github.com/users/CBATeam/received_events","type":"Organization","site_admin":false},"repo":{"id":36454957,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQ1NDk1Nw==","name":"CBA_A3","full_name":"CBATeam/CBA_A3","private":false,"owner":{"login":"CBATeam","id":12647545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjQ3NTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12647545?v=4","gravatar_id":"","url":"https://api.github.com/users/CBATeam","html_url":"https://github.com/CBATeam","followers_url":"https://api.github.com/users/CBATeam/followers","following_url":"https://api.github.com/users/CBATeam/following{/other_user}","gists_url":"https://api.github.com/users/CBATeam/gists{/gist_id}","starred_url":"https://api.github.com/users/CBATeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CBATeam/subscriptions","organizations_url":"https://api.github.com/users/CBATeam/orgs","repos_url":"https://api.github.com/users/CBATeam/repos","events_url":"https://api.github.com/users/CBATeam/events{/privacy}","received_events_url":"https://api.github.com/users/CBATeam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CBATeam/CBA_A3","description":"Community Base Addons for Arma 3","fork":false,"url":"https://api.github.com/repos/CBATeam/CBA_A3","forks_url":"https://api.github.com/repos/CBATeam/CBA_A3/forks","keys_url":"https://api.github.com/repos/CBATeam/CBA_A3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CBATeam/CBA_A3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CBATeam/CBA_A3/teams","hooks_url":"https://api.github.com/repos/CBATeam/CBA_A3/hooks","issue_events_url":"https://api.github.com/repos/CBATeam/CBA_A3/issues/events{/number}","events_url":"https://api.github.com/repos/CBATeam/CBA_A3/events","assignees_url":"https://api.github.com/repos/CBATeam/CBA_A3/assignees{/user}","branches_url":"https://api.github.com/repos/CBATeam/CBA_A3/branches{/branch}","tags_url":"https://api.github.com/repos/CBATeam/CBA_A3/tags","blobs_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/refs{/sha}","trees_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CBATeam/CBA_A3/statuses/{sha}","languages_url":"https://api.github.com/repos/CBATeam/CBA_A3/languages","stargazers_url":"https://api.github.com/repos/CBATeam/CBA_A3/stargazers","contributors_url":"https://api.github.com/repos/CBATeam/CBA_A3/contributors","subscribers_url":"https://api.github.com/repos/CBATeam/CBA_A3/subscribers","subscription_url":"https://api.github.com/repos/CBATeam/CBA_A3/subscription","commits_url":"https://api.github.com/repos/CBATeam/CBA_A3/commits{/sha}","git_commits_url":"https://api.github.com/repos/CBATeam/CBA_A3/git/commits{/sha}","comments_url":"https://api.github.com/repos/CBATeam/CBA_A3/comments{/number}","issue_comment_url":"https://api.github.com/repos/CBATeam/CBA_A3/issues/comments{/number}","contents_url":"https://api.github.com/repos/CBATeam/CBA_A3/contents/{+path}","compare_url":"https://api.github.com/repos/CBATeam/CBA_A3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CBATeam/CBA_A3/merges","archive_url":"https://api.github.com/repos/CBATeam/CBA_A3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CBATeam/CBA_A3/downloads","issues_url":"https://api.github.com/repos/CBATeam/CBA_A3/issues{/number}","pulls_url":"https://api.github.com/repos/CBATeam/CBA_A3/pulls{/number}","milestones_url":"https://api.github.com/repos/CBATeam/CBA_A3/milestones{/number}","notifications_url":"https://api.github.com/repos/CBATeam/CBA_A3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CBATeam/CBA_A3/labels{/name}","releases_url":"https://api.github.com/repos/CBATeam/CBA_A3/releases{/id}","deployments_url":"https://api.github.com/repos/CBATeam/CBA_A3/deployments","created_at":"2015-05-28T17:34:05Z","updated_at":"2019-02-09T14:47:36Z","pushed_at":"2019-02-10T12:05:50Z","git_url":"git://github.com/CBATeam/CBA_A3.git","ssh_url":"git@github.com:CBATeam/CBA_A3.git","clone_url":"https://github.com/CBATeam/CBA_A3.git","svn_url":"https://github.com/CBATeam/CBA_A3","homepage":"","size":20276,"stargazers_count":218,"watchers_count":218,"language":"SQF","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":89,"open_issues":19,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/1062"},"html":{"href":"https://github.com/CBATeam/CBA_A3/pull/1062"},"issue":{"href":"https://api.github.com/repos/CBATeam/CBA_A3/issues/1062"},"comments":{"href":"https://api.github.com/repos/CBATeam/CBA_A3/issues/1062/comments"},"review_comments":{"href":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/1062/comments"},"review_comment":{"href":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CBATeam/CBA_A3/pulls/1062/commits"},"statuses":{"href":"https://api.github.com/repos/CBATeam/CBA_A3/statuses/2a5a1d3095f545e20640b0576edeec41d543fe3d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 36454957,
"name": "CBATeam/CBA_A3",
"url": "https://api.github.com/repos/CBATeam/CBA_A3"
}
|
{
"id": 3768165,
"login": "dedmen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3768165?",
"url": "https://api.github.com/users/dedmen"
}
|
{
"id": 12647545,
"login": "CBATeam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12647545?",
"url": "https://api.github.com/orgs/CBATeam"
}
| 2019-02-10T14:11:16 |
9040174429
|
{"actor":{"display_login":"dedmen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/comments/314779357","pull_request_review_id":276026597,"id":314779357,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDc3OTM1Nw==","diff_hunk":"@@ -22,9 +22,37 @@ export default class HeaderPane extends PureComponent {\n return '0';\n }\n \n+ renderTitle = () => {\n+ const { title, titleAttr } = this.props;\n+ if (!title) return (<h1 />);\n+\n+ let attrTitle = titleAttr || title;\n+ let htmlTitleArr = title;\n+\n+ if (Array.isArray(title)) {\n+ if (!titleAttr) {\n+ attrTitle = title.length > 1 ? title.join(' / ') : title[0];\n+ }\n+ const titleSeparator = <span className={'header-pane__title-separator'}>/</span>;\n+ // add dashes...","path":"components/headerPane/headerPane.js","position":null,"original_position":16,"commit_id":"28d378cdfef0639669acce28889deb52bbd18d06","original_commit_id":"143b50fb80865f1f46f00fe75241804042e6186e","user":{"login":"jasonhale","id":3496073,"node_id":"MDQ6VXNlcjM0OTYwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3496073?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonhale","html_url":"https://github.com/jasonhale","followers_url":"https://api.github.com/users/jasonhale/followers","following_url":"https://api.github.com/users/jasonhale/following{/other_user}","gists_url":"https://api.github.com/users/jasonhale/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonhale/subscriptions","organizations_url":"https://api.github.com/users/jasonhale/orgs","repos_url":"https://api.github.com/users/jasonhale/repos","events_url":"https://api.github.com/users/jasonhale/events{/privacy}","received_events_url":"https://api.github.com/users/jasonhale/received_events","type":"User","site_admin":false},"body":"updated","created_at":"2019-08-16T15:45:03Z","updated_at":"2019-08-16T15:45:03Z","html_url":"https://github.com/topbox-rci/rci-components/pull/1383#discussion_r314779357","pull_request_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/1383","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/comments/314779357"},"html":{"href":"https://github.com/topbox-rci/rci-components/pull/1383#discussion_r314779357"},"pull_request":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/1383"}},"in_reply_to_id":314743981},"pull_request":{"url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/1383","id":308066652,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4MDY2NjUy","html_url":"https://github.com/topbox-rci/rci-components/pull/1383","diff_url":"https://github.com/topbox-rci/rci-components/pull/1383.diff","patch_url":"https://github.com/topbox-rci/rci-components/pull/1383.patch","issue_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/1383","number":1383,"state":"open","locked":false,"title":" TFW-4343 - Update Header styles","user":{"login":"jasonhale","id":3496073,"node_id":"MDQ6VXNlcjM0OTYwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3496073?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonhale","html_url":"https://github.com/jasonhale","followers_url":"https://api.github.com/users/jasonhale/followers","following_url":"https://api.github.com/users/jasonhale/following{/other_user}","gists_url":"https://api.github.com/users/jasonhale/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonhale/subscriptions","organizations_url":"https://api.github.com/users/jasonhale/orgs","repos_url":"https://api.github.com/users/jasonhale/repos","events_url":"https://api.github.com/users/jasonhale/events{/privacy}","received_events_url":"https://api.github.com/users/jasonhale/received_events","type":"User","site_admin":false},"body":"Applies the new header styles to HeaderPane for consistent page titles.\r\n\r\nThe design with the slash separating sections of the title is going to be used in more than just Search, so moved that feature introduced by `Title` into `HeaderPane`.","created_at":"2019-08-16T13:00:40Z","updated_at":"2019-08-16T15:45:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eff00a1e49cb84651c16f6f220a7a5737008721","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tVeratti","id":6993836,"node_id":"MDQ6VXNlcjY5OTM4MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/6993836?v=4","gravatar_id":"","url":"https://api.github.com/users/tVeratti","html_url":"https://github.com/tVeratti","followers_url":"https://api.github.com/users/tVeratti/followers","following_url":"https://api.github.com/users/tVeratti/following{/other_user}","gists_url":"https://api.github.com/users/tVeratti/gists{/gist_id}","starred_url":"https://api.github.com/users/tVeratti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tVeratti/subscriptions","organizations_url":"https://api.github.com/users/tVeratti/orgs","repos_url":"https://api.github.com/users/tVeratti/repos","events_url":"https://api.github.com/users/tVeratti/events{/privacy}","received_events_url":"https://api.github.com/users/tVeratti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/1383/commits","review_comments_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/1383/comments","review_comment_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/1383/comments","statuses_url":"https://api.github.com/repos/topbox-rci/rci-components/statuses/28d378cdfef0639669acce28889deb52bbd18d06","head":{"label":"topbox-rci:TFW-4343","ref":"TFW-4343","sha":"28d378cdfef0639669acce28889deb52bbd18d06","user":{"login":"topbox-rci","id":12717371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzE3Mzcx","avatar_url":"https://avatars0.githubusercontent.com/u/12717371?v=4","gravatar_id":"","url":"https://api.github.com/users/topbox-rci","html_url":"https://github.com/topbox-rci","followers_url":"https://api.github.com/users/topbox-rci/followers","following_url":"https://api.github.com/users/topbox-rci/following{/other_user}","gists_url":"https://api.github.com/users/topbox-rci/gists{/gist_id}","starred_url":"https://api.github.com/users/topbox-rci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topbox-rci/subscriptions","organizations_url":"https://api.github.com/users/topbox-rci/orgs","repos_url":"https://api.github.com/users/topbox-rci/repos","events_url":"https://api.github.com/users/topbox-rci/events{/privacy}","received_events_url":"https://api.github.com/users/topbox-rci/received_events","type":"Organization","site_admin":false},"repo":{"id":76394133,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM5NDEzMw==","name":"rci-components","full_name":"topbox-rci/rci-components","private":false,"owner":{"login":"topbox-rci","id":12717371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzE3Mzcx","avatar_url":"https://avatars0.githubusercontent.com/u/12717371?v=4","gravatar_id":"","url":"https://api.github.com/users/topbox-rci","html_url":"https://github.com/topbox-rci","followers_url":"https://api.github.com/users/topbox-rci/followers","following_url":"https://api.github.com/users/topbox-rci/following{/other_user}","gists_url":"https://api.github.com/users/topbox-rci/gists{/gist_id}","starred_url":"https://api.github.com/users/topbox-rci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topbox-rci/subscriptions","organizations_url":"https://api.github.com/users/topbox-rci/orgs","repos_url":"https://api.github.com/users/topbox-rci/repos","events_url":"https://api.github.com/users/topbox-rci/events{/privacy}","received_events_url":"https://api.github.com/users/topbox-rci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/topbox-rci/rci-components","description":"React components for the RCI project","fork":false,"url":"https://api.github.com/repos/topbox-rci/rci-components","forks_url":"https://api.github.com/repos/topbox-rci/rci-components/forks","keys_url":"https://api.github.com/repos/topbox-rci/rci-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topbox-rci/rci-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topbox-rci/rci-components/teams","hooks_url":"https://api.github.com/repos/topbox-rci/rci-components/hooks","issue_events_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/events{/number}","events_url":"https://api.github.com/repos/topbox-rci/rci-components/events","assignees_url":"https://api.github.com/repos/topbox-rci/rci-components/assignees{/user}","branches_url":"https://api.github.com/repos/topbox-rci/rci-components/branches{/branch}","tags_url":"https://api.github.com/repos/topbox-rci/rci-components/tags","blobs_url":"https://api.github.com/repos/topbox-rci/rci-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topbox-rci/rci-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topbox-rci/rci-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/topbox-rci/rci-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topbox-rci/rci-components/statuses/{sha}","languages_url":"https://api.github.com/repos/topbox-rci/rci-components/languages","stargazers_url":"https://api.github.com/repos/topbox-rci/rci-components/stargazers","contributors_url":"https://api.github.com/repos/topbox-rci/rci-components/contributors","subscribers_url":"https://api.github.com/repos/topbox-rci/rci-components/subscribers","subscription_url":"https://api.github.com/repos/topbox-rci/rci-components/subscription","commits_url":"https://api.github.com/repos/topbox-rci/rci-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/topbox-rci/rci-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/topbox-rci/rci-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/topbox-rci/rci-components/contents/{+path}","compare_url":"https://api.github.com/repos/topbox-rci/rci-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topbox-rci/rci-components/merges","archive_url":"https://api.github.com/repos/topbox-rci/rci-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topbox-rci/rci-components/downloads","issues_url":"https://api.github.com/repos/topbox-rci/rci-components/issues{/number}","pulls_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls{/number}","milestones_url":"https://api.github.com/repos/topbox-rci/rci-components/milestones{/number}","notifications_url":"https://api.github.com/repos/topbox-rci/rci-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topbox-rci/rci-components/labels{/name}","releases_url":"https://api.github.com/repos/topbox-rci/rci-components/releases{/id}","deployments_url":"https://api.github.com/repos/topbox-rci/rci-components/deployments","created_at":"2016-12-13T20:05:28Z","updated_at":"2019-08-15T14:21:31Z","pushed_at":"2019-08-16T15:44:16Z","git_url":"git://github.com/topbox-rci/rci-components.git","ssh_url":"git@github.com:topbox-rci/rci-components.git","clone_url":"https://github.com/topbox-rci/rci-components.git","svn_url":"https://github.com/topbox-rci/rci-components","homepage":null,"size":7597,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"develop"}},"base":{"label":"topbox-rci:release/5.44.1","ref":"release/5.44.1","sha":"bda859a25526d8f159dabfc71cf68aa876b85766","user":{"login":"topbox-rci","id":12717371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzE3Mzcx","avatar_url":"https://avatars0.githubusercontent.com/u/12717371?v=4","gravatar_id":"","url":"https://api.github.com/users/topbox-rci","html_url":"https://github.com/topbox-rci","followers_url":"https://api.github.com/users/topbox-rci/followers","following_url":"https://api.github.com/users/topbox-rci/following{/other_user}","gists_url":"https://api.github.com/users/topbox-rci/gists{/gist_id}","starred_url":"https://api.github.com/users/topbox-rci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topbox-rci/subscriptions","organizations_url":"https://api.github.com/users/topbox-rci/orgs","repos_url":"https://api.github.com/users/topbox-rci/repos","events_url":"https://api.github.com/users/topbox-rci/events{/privacy}","received_events_url":"https://api.github.com/users/topbox-rci/received_events","type":"Organization","site_admin":false},"repo":{"id":76394133,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM5NDEzMw==","name":"rci-components","full_name":"topbox-rci/rci-components","private":false,"owner":{"login":"topbox-rci","id":12717371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzE3Mzcx","avatar_url":"https://avatars0.githubusercontent.com/u/12717371?v=4","gravatar_id":"","url":"https://api.github.com/users/topbox-rci","html_url":"https://github.com/topbox-rci","followers_url":"https://api.github.com/users/topbox-rci/followers","following_url":"https://api.github.com/users/topbox-rci/following{/other_user}","gists_url":"https://api.github.com/users/topbox-rci/gists{/gist_id}","starred_url":"https://api.github.com/users/topbox-rci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topbox-rci/subscriptions","organizations_url":"https://api.github.com/users/topbox-rci/orgs","repos_url":"https://api.github.com/users/topbox-rci/repos","events_url":"https://api.github.com/users/topbox-rci/events{/privacy}","received_events_url":"https://api.github.com/users/topbox-rci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/topbox-rci/rci-components","description":"React components for the RCI project","fork":false,"url":"https://api.github.com/repos/topbox-rci/rci-components","forks_url":"https://api.github.com/repos/topbox-rci/rci-components/forks","keys_url":"https://api.github.com/repos/topbox-rci/rci-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topbox-rci/rci-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topbox-rci/rci-components/teams","hooks_url":"https://api.github.com/repos/topbox-rci/rci-components/hooks","issue_events_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/events{/number}","events_url":"https://api.github.com/repos/topbox-rci/rci-components/events","assignees_url":"https://api.github.com/repos/topbox-rci/rci-components/assignees{/user}","branches_url":"https://api.github.com/repos/topbox-rci/rci-components/branches{/branch}","tags_url":"https://api.github.com/repos/topbox-rci/rci-components/tags","blobs_url":"https://api.github.com/repos/topbox-rci/rci-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topbox-rci/rci-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topbox-rci/rci-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/topbox-rci/rci-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topbox-rci/rci-components/statuses/{sha}","languages_url":"https://api.github.com/repos/topbox-rci/rci-components/languages","stargazers_url":"https://api.github.com/repos/topbox-rci/rci-components/stargazers","contributors_url":"https://api.github.com/repos/topbox-rci/rci-components/contributors","subscribers_url":"https://api.github.com/repos/topbox-rci/rci-components/subscribers","subscription_url":"https://api.github.com/repos/topbox-rci/rci-components/subscription","commits_url":"https://api.github.com/repos/topbox-rci/rci-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/topbox-rci/rci-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/topbox-rci/rci-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/topbox-rci/rci-components/contents/{+path}","compare_url":"https://api.github.com/repos/topbox-rci/rci-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topbox-rci/rci-components/merges","archive_url":"https://api.github.com/repos/topbox-rci/rci-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topbox-rci/rci-components/downloads","issues_url":"https://api.github.com/repos/topbox-rci/rci-components/issues{/number}","pulls_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls{/number}","milestones_url":"https://api.github.com/repos/topbox-rci/rci-components/milestones{/number}","notifications_url":"https://api.github.com/repos/topbox-rci/rci-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topbox-rci/rci-components/labels{/name}","releases_url":"https://api.github.com/repos/topbox-rci/rci-components/releases{/id}","deployments_url":"https://api.github.com/repos/topbox-rci/rci-components/deployments","created_at":"2016-12-13T20:05:28Z","updated_at":"2019-08-15T14:21:31Z","pushed_at":"2019-08-16T15:44:16Z","git_url":"git://github.com/topbox-rci/rci-components.git","ssh_url":"git@github.com:topbox-rci/rci-components.git","clone_url":"https://github.com/topbox-rci/rci-components.git","svn_url":"https://github.com/topbox-rci/rci-components","homepage":null,"size":7597,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/1383"},"html":{"href":"https://github.com/topbox-rci/rci-components/pull/1383"},"issue":{"href":"https://api.github.com/repos/topbox-rci/rci-components/issues/1383"},"comments":{"href":"https://api.github.com/repos/topbox-rci/rci-components/issues/1383/comments"},"review_comments":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/1383/comments"},"review_comment":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/1383/commits"},"statuses":{"href":"https://api.github.com/repos/topbox-rci/rci-components/statuses/28d378cdfef0639669acce28889deb52bbd18d06"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 76394133,
"name": "topbox-rci/rci-components",
"url": "https://api.github.com/repos/topbox-rci/rci-components"
}
|
{
"id": 3496073,
"login": "jasonhale",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3496073?",
"url": "https://api.github.com/users/jasonhale"
}
|
{
"id": 12717371,
"login": "topbox-rci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12717371?",
"url": "https://api.github.com/orgs/topbox-rci"
}
| 2019-08-16T15:45:03 |
10225687863
|
{"actor":{"display_login":"jasonhale"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/300818797","pull_request_review_id":258575801,"id":300818797,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDgxODc5Nw==","diff_hunk":"@@ -0,0 +1,139 @@\n+import React from 'react';\n+import _ from 'lodash';\n+import { DestinyObjectiveDefinition } from 'bungie-api-ts/destiny2';\n+import BungieImage from '../dim-ui/BungieImage';\n+import { D2ManifestDefinitions } from '../destiny2/d2-definitions.service';\n+import { D1ManifestDefinitions } from '../destiny1/d1-definitions.service';\n+\n+import bow from '../../../destiny-icons/weapons/bow.svg';\n+import autoRifle from '../../../destiny-icons/weapons/auto_rifle.svg';\n+import pulseRifle from '../../../destiny-icons/weapons/pulse_rifle.svg';\n+import scoutRifle from '../../../destiny-icons/weapons/scout_rifle.svg';\n+import handCannon from '../../../destiny-icons/weapons/hand_cannon.svg';\n+import shotgun from '../../../destiny-icons/weapons/shotgun.svg';\n+import sniperRifle from '../../../destiny-icons/weapons/sniper_rifle.svg';\n+import fusionRifle from '../../../destiny-icons/weapons/fusion_rifle.svg';\n+import smg from '../../../destiny-icons/weapons/smg.svg';\n+import rocketLauncher from '../../../destiny-icons/weapons/rocket_launcher.svg';\n+import sidearm from '../../../destiny-icons/weapons/sidearm.svg';\n+import melee from '../../../destiny-icons/weapons/melee.svg';\n+import grenade from '../../../destiny-icons/weapons/grenade.svg';\n+import grenadeLauncher from '../../../destiny-icons/weapons/grenade_launcher.svg';\n+import beamWeapon from '../../../destiny-icons/weapons/beam_weapon.svg';\n+import damageSolar from '../../../destiny-icons/weapons/damage_solar.svg';\n+import damageKinetic from '../../../destiny-icons/weapons/damage_kinetic.svg';\n+import headshot from '../../../destiny-icons/weapons/headshot.svg';\n+import damageArc from '../../../destiny-icons/weapons/damage_arc.svg';\n+import damageVoid from '../../../destiny-icons/weapons/damage_void.svg';\n+import wireRifle from '../../../destiny-icons/weapons/wire_rifle.svg';\n+import swordHeavy from '../../../destiny-icons/weapons/sword_heavy.svg';\n+import machinegun from '../../../destiny-icons/weapons/machinegun.svg';\n+\n+// matches first bracketed thing in the string, or certain private unicode characters\n+const hashExtract = /^([^[\\]]*)(\\[[^[\\]]+?\\]|[\\uE099-\\uE154])(.*)$/u;\n+\n+function supplementedConversionTable(defs) {\n+ // conversionTable holds input & output rules for icon replacement. baseConversionTable is used to build it.\n+ const baseConversionTable = [\n+ { icon: bow, objectiveHash: 1242546978, substring: '' },\n+ { icon: autoRifle, objectiveHash: 532914921, substring: '' },\n+ { icon: pulseRifle, objectiveHash: 2161000034, substring: '' },\n+ { icon: scoutRifle, objectiveHash: 2062881933, substring: '' },\n+ { icon: handCannon, objectiveHash: 53304862, substring: '' },\n+ { icon: shotgun, objectiveHash: 635284441, substring: '' },\n+ { icon: sniperRifle, objectiveHash: 3527067345, substring: '' },\n+ { icon: fusionRifle, objectiveHash: 3296270292, substring: '' },\n+ { icon: smg, objectiveHash: 2722409947, substring: '' },\n+ { icon: rocketLauncher, objectiveHash: 2203404732, substring: '' },\n+ { icon: sidearm, objectiveHash: 299893109, substring: '' },\n+ { icon: melee, objectiveHash: 3951261483, substring: '' },\n+ { icon: grenade, objectiveHash: 3711356257, substring: '' },\n+ { icon: grenadeLauncher, objectiveHash: 2152699013, substring: '' },\n+ { icon: beamWeapon, objectiveHash: 3080184954, substring: '' },\n+ { icon: damageSolar, objectiveHash: 2994623161, substring: '' },\n+ { icon: damageKinetic, objectiveHash: 3924246227, substring: '' },\n+ { icon: headshot, objectiveHash: 3287913530, substring: '' },\n+ { icon: damageArc, objectiveHash: 2178780271, substring: '' },\n+ { icon: damageVoid, objectiveHash: 695106797, substring: '' },\n+ { icon: wireRifle, objectiveHash: 2923868331, substring: '' },\n+ { icon: swordHeavy, objectiveHash: 989767424, substring: '' },\n+ { icon: machinegun, objectiveHash: 1788114534, substring: '' }\n+ ];\n+\n+ // loop through conversionTable entries to update them with manifest string info\n+ baseConversionTable.forEach((iconEntry, index) => {\n+ const objectiveDef = defs.Objective.get(iconEntry.objectiveHash);\n+ if (!objectiveDef) {\n+ return;\n+ }\n+ delete baseConversionTable[index].objectiveHash;\n+\n+ // lookup this lang's string for the objective\n+ const progressDescription = objectiveDef.progressDescription;\n+\n+ // match the first bracketed item, or the first zh character, plus beforestuff and afterstuff\n+ const iconString = progressDescription.match(hashExtract)[2];\n+\n+ // the identified iconString is the manifest's replacement marker for this icon. put back into table\n+ baseConversionTable[index].substring = iconString;\n+ });\n+\n+ console.log(baseConversionTable);\n+ return baseConversionTable;\n+}\n+\n+// returns the string-to-svg conversion table\n+const conversionTable = _.once(supplementedConversionTable);\n+\n+// recurses progressDescription, looking for sequences to replace with icons\n+function replaceWithIcons(\n+ conversionRules: { icon: string; substring: string }[],\n+ remainingObjectiveString: string,\n+ alreadyProcessed: (string | React.ReactElement)[] = []\n+) {\n+ // check remainingObjectiveString for replaceable strings\n+ const matchResults = remainingObjectiveString.match(hashExtract);\n+\n+ // return immediately if there's nothing to try and replace\n+ if (!matchResults) {\n+ return alreadyProcessed.concat([remainingObjectiveString]);\n+ }\n+\n+ // set variables to do replacement\n+ const [beforeMatch, iconString, afterMatch] = matchResults.slice(1);","path":"src/app/progress/ObjectiveDescription.tsx","position":103,"original_position":103,"commit_id":"a10600f81afd1ce31a9bb82a8017a29ae31e8776","original_commit_id":"a10600f81afd1ce31a9bb82a8017a29ae31e8776","user":{"login":"delphiactual","id":4798491,"node_id":"MDQ6VXNlcjQ3OTg0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4798491?v=4","gravatar_id":"","url":"https://api.github.com/users/delphiactual","html_url":"https://github.com/delphiactual","followers_url":"https://api.github.com/users/delphiactual/followers","following_url":"https://api.github.com/users/delphiactual/following{/other_user}","gists_url":"https://api.github.com/users/delphiactual/gists{/gist_id}","starred_url":"https://api.github.com/users/delphiactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delphiactual/subscriptions","organizations_url":"https://api.github.com/users/delphiactual/orgs","repos_url":"https://api.github.com/users/delphiactual/repos","events_url":"https://api.github.com/users/delphiactual/events{/privacy}","received_events_url":"https://api.github.com/users/delphiactual/received_events","type":"User","site_admin":false},"body":"`const [, beforeMatch, iconString, afterMatch] = matchResults;`","created_at":"2019-07-06T03:45:04Z","updated_at":"2019-07-06T03:45:05Z","html_url":"https://github.com/DestinyItemManager/DIM/pull/3969#discussion_r300818797","pull_request_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3969","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/300818797"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/3969#discussion_r300818797"},"pull_request":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3969"}}},"pull_request":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3969","id":295011726,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1MDExNzI2","html_url":"https://github.com/DestinyItemManager/DIM/pull/3969","diff_url":"https://github.com/DestinyItemManager/DIM/pull/3969.diff","patch_url":"https://github.com/DestinyItemManager/DIM/pull/3969.patch","issue_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/3969","number":3969,"state":"open","locked":false,"title":"objective descriptions with icon replacement","user":{"login":"sundevour","id":31990469,"node_id":"MDQ6VXNlcjMxOTkwNDY5","avatar_url":"https://avatars2.githubusercontent.com/u/31990469?v=4","gravatar_id":"","url":"https://api.github.com/users/sundevour","html_url":"https://github.com/sundevour","followers_url":"https://api.github.com/users/sundevour/followers","following_url":"https://api.github.com/users/sundevour/following{/other_user}","gists_url":"https://api.github.com/users/sundevour/gists{/gist_id}","starred_url":"https://api.github.com/users/sundevour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sundevour/subscriptions","organizations_url":"https://api.github.com/users/sundevour/orgs","repos_url":"https://api.github.com/users/sundevour/repos","events_url":"https://api.github.com/users/sundevour/events{/privacy}","received_events_url":"https://api.github.com/users/sundevour/received_events","type":"User","site_admin":false},"body":"re-up of #3935 because a bad merge turned it into spaghetti\r\n\r\nmost review items done, did not solve the removal of `.slice`\r\n\r\nplease review\r\n- whether `_.once` is implemented better now\r\n- does this need an errorboundary somewhere?","created_at":"2019-07-06T03:33:36Z","updated_at":"2019-07-06T03:45:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdd0d60f70fb2772ea7dc2a283138f8129316766","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bhollis","id":313208,"node_id":"MDQ6VXNlcjMxMzIwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/313208?v=4","gravatar_id":"","url":"https://api.github.com/users/bhollis","html_url":"https://github.com/bhollis","followers_url":"https://api.github.com/users/bhollis/followers","following_url":"https://api.github.com/users/bhollis/following{/other_user}","gists_url":"https://api.github.com/users/bhollis/gists{/gist_id}","starred_url":"https://api.github.com/users/bhollis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhollis/subscriptions","organizations_url":"https://api.github.com/users/bhollis/orgs","repos_url":"https://api.github.com/users/bhollis/repos","events_url":"https://api.github.com/users/bhollis/events{/privacy}","received_events_url":"https://api.github.com/users/bhollis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3969/commits","review_comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3969/comments","review_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/3969/comments","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/a10600f81afd1ce31a9bb82a8017a29ae31e8776","head":{"label":"sundevour:objective-desc-icons-2","ref":"objective-desc-icons-2","sha":"a10600f81afd1ce31a9bb82a8017a29ae31e8776","user":{"login":"sundevour","id":31990469,"node_id":"MDQ6VXNlcjMxOTkwNDY5","avatar_url":"https://avatars2.githubusercontent.com/u/31990469?v=4","gravatar_id":"","url":"https://api.github.com/users/sundevour","html_url":"https://github.com/sundevour","followers_url":"https://api.github.com/users/sundevour/followers","following_url":"https://api.github.com/users/sundevour/following{/other_user}","gists_url":"https://api.github.com/users/sundevour/gists{/gist_id}","starred_url":"https://api.github.com/users/sundevour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sundevour/subscriptions","organizations_url":"https://api.github.com/users/sundevour/orgs","repos_url":"https://api.github.com/users/sundevour/repos","events_url":"https://api.github.com/users/sundevour/events{/privacy}","received_events_url":"https://api.github.com/users/sundevour/received_events","type":"User","site_admin":false},"repo":{"id":153771938,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3NzE5Mzg=","name":"DIM","full_name":"sundevour/DIM","private":false,"owner":{"login":"sundevour","id":31990469,"node_id":"MDQ6VXNlcjMxOTkwNDY5","avatar_url":"https://avatars2.githubusercontent.com/u/31990469?v=4","gravatar_id":"","url":"https://api.github.com/users/sundevour","html_url":"https://github.com/sundevour","followers_url":"https://api.github.com/users/sundevour/followers","following_url":"https://api.github.com/users/sundevour/following{/other_user}","gists_url":"https://api.github.com/users/sundevour/gists{/gist_id}","starred_url":"https://api.github.com/users/sundevour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sundevour/subscriptions","organizations_url":"https://api.github.com/users/sundevour/orgs","repos_url":"https://api.github.com/users/sundevour/repos","events_url":"https://api.github.com/users/sundevour/events{/privacy}","received_events_url":"https://api.github.com/users/sundevour/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sundevour/DIM","description":"Destiny Item Manager","fork":true,"url":"https://api.github.com/repos/sundevour/DIM","forks_url":"https://api.github.com/repos/sundevour/DIM/forks","keys_url":"https://api.github.com/repos/sundevour/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sundevour/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sundevour/DIM/teams","hooks_url":"https://api.github.com/repos/sundevour/DIM/hooks","issue_events_url":"https://api.github.com/repos/sundevour/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/sundevour/DIM/events","assignees_url":"https://api.github.com/repos/sundevour/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/sundevour/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/sundevour/DIM/tags","blobs_url":"https://api.github.com/repos/sundevour/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sundevour/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sundevour/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/sundevour/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sundevour/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/sundevour/DIM/languages","stargazers_url":"https://api.github.com/repos/sundevour/DIM/stargazers","contributors_url":"https://api.github.com/repos/sundevour/DIM/contributors","subscribers_url":"https://api.github.com/repos/sundevour/DIM/subscribers","subscription_url":"https://api.github.com/repos/sundevour/DIM/subscription","commits_url":"https://api.github.com/repos/sundevour/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/sundevour/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/sundevour/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/sundevour/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/sundevour/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/sundevour/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sundevour/DIM/merges","archive_url":"https://api.github.com/repos/sundevour/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sundevour/DIM/downloads","issues_url":"https://api.github.com/repos/sundevour/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/sundevour/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/sundevour/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/sundevour/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sundevour/DIM/labels{/name}","releases_url":"https://api.github.com/repos/sundevour/DIM/releases{/id}","deployments_url":"https://api.github.com/repos/sundevour/DIM/deployments","created_at":"2018-10-19T11:21:40Z","updated_at":"2019-07-06T01:10:05Z","pushed_at":"2019-07-06T03:02:24Z","git_url":"git://github.com/sundevour/DIM.git","ssh_url":"git@github.com:sundevour/DIM.git","clone_url":"https://github.com/sundevour/DIM.git","svn_url":"https://github.com/sundevour/DIM","homepage":"https://destinyitemmanager.com","size":325879,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DestinyItemManager:master","ref":"master","sha":"78782692a8d9f8335fed5245e58de9f558220d61","user":{"login":"DestinyItemManager","id":12777189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzc3MTg5","avatar_url":"https://avatars3.githubusercontent.com/u/12777189?v=4","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"repo":{"id":31681575,"node_id":"MDEwOlJlcG9zaXRvcnkzMTY4MTU3NQ==","name":"DIM","full_name":"DestinyItemManager/DIM","private":false,"owner":{"login":"DestinyItemManager","id":12777189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzc3MTg5","avatar_url":"https://avatars3.githubusercontent.com/u/12777189?v=4","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DestinyItemManager/DIM","description":"Destiny Item Manager","fork":false,"url":"https://api.github.com/repos/DestinyItemManager/DIM","forks_url":"https://api.github.com/repos/DestinyItemManager/DIM/forks","keys_url":"https://api.github.com/repos/DestinyItemManager/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DestinyItemManager/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DestinyItemManager/DIM/teams","hooks_url":"https://api.github.com/repos/DestinyItemManager/DIM/hooks","issue_events_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/DestinyItemManager/DIM/events","assignees_url":"https://api.github.com/repos/DestinyItemManager/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/DestinyItemManager/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/tags","blobs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/DestinyItemManager/DIM/languages","stargazers_url":"https://api.github.com/repos/DestinyItemManager/DIM/stargazers","contributors_url":"https://api.github.com/repos/DestinyItemManager/DIM/contributors","subscribers_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscribers","subscription_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscription","commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/DestinyItemManager/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/DestinyItemManager/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DestinyItemManager/DIM/merges","archive_url":"https://api.github.com/repos/DestinyItemManager/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DestinyItemManager/DIM/downloads","issues_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/DestinyItemManager/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/DestinyItemManager/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DestinyItemManager/DIM/labels{/name}","releases_url":"https://api.github.com/repos/DestinyItemManager/DIM/releases{/id}","deployments_url":"https://api.github.com/repos/DestinyItemManager/DIM/deployments","created_at":"2015-03-04T21:46:50Z","updated_at":"2019-07-06T02:52:11Z","pushed_at":"2019-07-06T03:37:59Z","git_url":"git://github.com/DestinyItemManager/DIM.git","ssh_url":"git@github.com:DestinyItemManager/DIM.git","clone_url":"https://github.com/DestinyItemManager/DIM.git","svn_url":"https://github.com/DestinyItemManager/DIM","homepage":"https://destinyitemmanager.com","size":325843,"stargazers_count":876,"watchers_count":876,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":68,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":293,"open_issues":68,"watchers":876,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3969"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/3969"},"issue":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/3969"},"comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/3969/comments"},"review_comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3969/comments"},"review_comment":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/3969/commits"},"statuses":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/a10600f81afd1ce31a9bb82a8017a29ae31e8776"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 31681575,
"name": "DestinyItemManager/DIM",
"url": "https://api.github.com/repos/DestinyItemManager/DIM"
}
|
{
"id": 4798491,
"login": "delphiactual",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4798491?",
"url": "https://api.github.com/users/delphiactual"
}
|
{
"id": 12777189,
"login": "DestinyItemManager",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12777189?",
"url": "https://api.github.com/orgs/DestinyItemManager"
}
| 2019-07-06T03:45:04 |
9959193881
|
{"actor":{"display_login":"delphiactual"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/comments/345623841","pull_request_review_id":316068106,"id":345623841,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NTYyMzg0MQ==","diff_hunk":"@@ -0,0 +1,192 @@\n+package oracle_test\n+\n+import (\n+\t\"encoding/xml\"\n+\t\"io/ioutil\"\n+\t\"testing\"\n+\n+\t\"github.com/aquasecurity/vuln-list-update/oval/oracle\"\n+\t\"github.com/kylelemons/godebug/pretty\"\n+\t\"github.com/stretchr/testify/assert\"\n+\t\"github.com/stretchr/testify/require\"\n+)\n+\n+func TestRedhatCVEJSON_UnmarshalJSON(t *testing.T) {\n+\ttests := map[string]struct {\n+\t\tin string\n+\t\twant *oracle.Oval\n+\t}{\n+\t\t\"nested_criterias_elsa_data\": {\n+\t\t\t// https://linux.oracle.com/oval/com.oracle.elsa-20070057.xml\n+\t\t\tin: \"testdata/ELSA-2007-0057.xml\",\n+\t\t\twant: &oracle.Oval{\n+\t\t\t\t[]oracle.Definition{\n+\t\t\t\t\toracle.Definition{\n+\t\t\t\t\t\tTitle: \"\\nELSA-2007-0057: Moderate: bind security update (MODERATE)\\n\",\n+\t\t\t\t\t\tDescription: \"\\n [30:9.3.3-8]\\n - added fix for #224445 - CVE-2007-0493 BIND might crash after\\n attempting to read free()-ed memory\\n - added fix for #225229 - CVE-2007-0494 BIND dnssec denial of service\\n - Resolves: rhbz#224445\\n - Resolves: rhbz#225229 \\n\",\n+\t\t\t\t\t\tPlatform: []string{\"Oracle Linux 5\"},\n+\t\t\t\t\t\tReferences: []oracle.Reference{\n+\t\t\t\t\t\t\toracle.Reference{","path":"oval/oracle/types_test.go","position":29,"original_position":29,"commit_id":"5f7e6fb73cf5eaf4aa9232ed8c02108592632441","original_commit_id":"5f7e6fb73cf5eaf4aa9232ed8c02108592632441","user":{"login":"knqyf263","id":2253692,"node_id":"MDQ6VXNlcjIyNTM2OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2253692?v=4","gravatar_id":"","url":"https://api.github.com/users/knqyf263","html_url":"https://github.com/knqyf263","followers_url":"https://api.github.com/users/knqyf263/followers","following_url":"https://api.github.com/users/knqyf263/following{/other_user}","gists_url":"https://api.github.com/users/knqyf263/gists{/gist_id}","starred_url":"https://api.github.com/users/knqyf263/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knqyf263/subscriptions","organizations_url":"https://api.github.com/users/knqyf263/orgs","repos_url":"https://api.github.com/users/knqyf263/repos","events_url":"https://api.github.com/users/knqyf263/events{/privacy}","received_events_url":"https://api.github.com/users/knqyf263/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\t\t\t\t\t\t\t{\r\n```","created_at":"2019-11-13T08:30:27Z","updated_at":"2019-11-13T08:34:11Z","html_url":"https://github.com/aquasecurity/vuln-list-update/pull/18#discussion_r345623841","pull_request_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/18","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/comments/345623841"},"html":{"href":"https://github.com/aquasecurity/vuln-list-update/pull/18#discussion_r345623841"},"pull_request":{"href":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/18","id":336049793,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2MDQ5Nzkz","html_url":"https://github.com/aquasecurity/vuln-list-update/pull/18","diff_url":"https://github.com/aquasecurity/vuln-list-update/pull/18.diff","patch_url":"https://github.com/aquasecurity/vuln-list-update/pull/18.patch","issue_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/issues/18","number":18,"state":"open","locked":false,"title":"Support Oracle Linux Security Advisory","user":{"login":"masahiro331","id":20438853,"node_id":"MDQ6VXNlcjIwNDM4ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20438853?v=4","gravatar_id":"","url":"https://api.github.com/users/masahiro331","html_url":"https://github.com/masahiro331","followers_url":"https://api.github.com/users/masahiro331/followers","following_url":"https://api.github.com/users/masahiro331/following{/other_user}","gists_url":"https://api.github.com/users/masahiro331/gists{/gist_id}","starred_url":"https://api.github.com/users/masahiro331/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masahiro331/subscriptions","organizations_url":"https://api.github.com/users/masahiro331/orgs","repos_url":"https://api.github.com/users/masahiro331/repos","events_url":"https://api.github.com/users/masahiro331/events{/privacy}","received_events_url":"https://api.github.com/users/masahiro331/received_events","type":"User","site_admin":false},"body":"Security Advisory: https://linux.oracle.com/security/\r\n- [x] Add unit test\r\n","created_at":"2019-11-03T17:31:29Z","updated_at":"2019-11-13T08:34:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4ae402cb66e5e4f912a2841748db32ec61df64e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/18/commits","review_comments_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/18/comments","review_comment_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/issues/18/comments","statuses_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/statuses/5f7e6fb73cf5eaf4aa9232ed8c02108592632441","head":{"label":"masahiro331:add_oracle","ref":"add_oracle","sha":"5f7e6fb73cf5eaf4aa9232ed8c02108592632441","user":{"login":"masahiro331","id":20438853,"node_id":"MDQ6VXNlcjIwNDM4ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20438853?v=4","gravatar_id":"","url":"https://api.github.com/users/masahiro331","html_url":"https://github.com/masahiro331","followers_url":"https://api.github.com/users/masahiro331/followers","following_url":"https://api.github.com/users/masahiro331/following{/other_user}","gists_url":"https://api.github.com/users/masahiro331/gists{/gist_id}","starred_url":"https://api.github.com/users/masahiro331/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masahiro331/subscriptions","organizations_url":"https://api.github.com/users/masahiro331/orgs","repos_url":"https://api.github.com/users/masahiro331/repos","events_url":"https://api.github.com/users/masahiro331/events{/privacy}","received_events_url":"https://api.github.com/users/masahiro331/received_events","type":"User","site_admin":false},"repo":{"id":193952704,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM5NTI3MDQ=","name":"vuln-list-update","full_name":"masahiro331/vuln-list-update","private":false,"owner":{"login":"masahiro331","id":20438853,"node_id":"MDQ6VXNlcjIwNDM4ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20438853?v=4","gravatar_id":"","url":"https://api.github.com/users/masahiro331","html_url":"https://github.com/masahiro331","followers_url":"https://api.github.com/users/masahiro331/followers","following_url":"https://api.github.com/users/masahiro331/following{/other_user}","gists_url":"https://api.github.com/users/masahiro331/gists{/gist_id}","starred_url":"https://api.github.com/users/masahiro331/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masahiro331/subscriptions","organizations_url":"https://api.github.com/users/masahiro331/orgs","repos_url":"https://api.github.com/users/masahiro331/repos","events_url":"https://api.github.com/users/masahiro331/events{/privacy}","received_events_url":"https://api.github.com/users/masahiro331/received_events","type":"User","site_admin":false},"html_url":"https://github.com/masahiro331/vuln-list-update","description":null,"fork":true,"url":"https://api.github.com/repos/masahiro331/vuln-list-update","forks_url":"https://api.github.com/repos/masahiro331/vuln-list-update/forks","keys_url":"https://api.github.com/repos/masahiro331/vuln-list-update/keys{/key_id}","collaborators_url":"https://api.github.com/repos/masahiro331/vuln-list-update/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/masahiro331/vuln-list-update/teams","hooks_url":"https://api.github.com/repos/masahiro331/vuln-list-update/hooks","issue_events_url":"https://api.github.com/repos/masahiro331/vuln-list-update/issues/events{/number}","events_url":"https://api.github.com/repos/masahiro331/vuln-list-update/events","assignees_url":"https://api.github.com/repos/masahiro331/vuln-list-update/assignees{/user}","branches_url":"https://api.github.com/repos/masahiro331/vuln-list-update/branches{/branch}","tags_url":"https://api.github.com/repos/masahiro331/vuln-list-update/tags","blobs_url":"https://api.github.com/repos/masahiro331/vuln-list-update/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/masahiro331/vuln-list-update/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/masahiro331/vuln-list-update/git/refs{/sha}","trees_url":"https://api.github.com/repos/masahiro331/vuln-list-update/git/trees{/sha}","statuses_url":"https://api.github.com/repos/masahiro331/vuln-list-update/statuses/{sha}","languages_url":"https://api.github.com/repos/masahiro331/vuln-list-update/languages","stargazers_url":"https://api.github.com/repos/masahiro331/vuln-list-update/stargazers","contributors_url":"https://api.github.com/repos/masahiro331/vuln-list-update/contributors","subscribers_url":"https://api.github.com/repos/masahiro331/vuln-list-update/subscribers","subscription_url":"https://api.github.com/repos/masahiro331/vuln-list-update/subscription","commits_url":"https://api.github.com/repos/masahiro331/vuln-list-update/commits{/sha}","git_commits_url":"https://api.github.com/repos/masahiro331/vuln-list-update/git/commits{/sha}","comments_url":"https://api.github.com/repos/masahiro331/vuln-list-update/comments{/number}","issue_comment_url":"https://api.github.com/repos/masahiro331/vuln-list-update/issues/comments{/number}","contents_url":"https://api.github.com/repos/masahiro331/vuln-list-update/contents/{+path}","compare_url":"https://api.github.com/repos/masahiro331/vuln-list-update/compare/{base}...{head}","merges_url":"https://api.github.com/repos/masahiro331/vuln-list-update/merges","archive_url":"https://api.github.com/repos/masahiro331/vuln-list-update/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/masahiro331/vuln-list-update/downloads","issues_url":"https://api.github.com/repos/masahiro331/vuln-list-update/issues{/number}","pulls_url":"https://api.github.com/repos/masahiro331/vuln-list-update/pulls{/number}","milestones_url":"https://api.github.com/repos/masahiro331/vuln-list-update/milestones{/number}","notifications_url":"https://api.github.com/repos/masahiro331/vuln-list-update/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/masahiro331/vuln-list-update/labels{/name}","releases_url":"https://api.github.com/repos/masahiro331/vuln-list-update/releases{/id}","deployments_url":"https://api.github.com/repos/masahiro331/vuln-list-update/deployments","created_at":"2019-06-26T17:50:33Z","updated_at":"2019-08-19T07:44:14Z","pushed_at":"2019-11-10T11:38:04Z","git_url":"git://github.com/masahiro331/vuln-list-update.git","ssh_url":"git@github.com:masahiro331/vuln-list-update.git","clone_url":"https://github.com/masahiro331/vuln-list-update.git","svn_url":"https://github.com/masahiro331/vuln-list-update","homepage":null,"size":180,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aquasecurity:master","ref":"master","sha":"99ce5d6c708447c72b845de2f0afabe4ee5475c0","user":{"login":"aquasecurity","id":12783832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzgzODMy","avatar_url":"https://avatars1.githubusercontent.com/u/12783832?v=4","gravatar_id":"","url":"https://api.github.com/users/aquasecurity","html_url":"https://github.com/aquasecurity","followers_url":"https://api.github.com/users/aquasecurity/followers","following_url":"https://api.github.com/users/aquasecurity/following{/other_user}","gists_url":"https://api.github.com/users/aquasecurity/gists{/gist_id}","starred_url":"https://api.github.com/users/aquasecurity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquasecurity/subscriptions","organizations_url":"https://api.github.com/users/aquasecurity/orgs","repos_url":"https://api.github.com/users/aquasecurity/repos","events_url":"https://api.github.com/users/aquasecurity/events{/privacy}","received_events_url":"https://api.github.com/users/aquasecurity/received_events","type":"Organization","site_admin":false},"repo":{"id":184168153,"node_id":"MDEwOlJlcG9zaXRvcnkxODQxNjgxNTM=","name":"vuln-list-update","full_name":"aquasecurity/vuln-list-update","private":false,"owner":{"login":"aquasecurity","id":12783832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzgzODMy","avatar_url":"https://avatars1.githubusercontent.com/u/12783832?v=4","gravatar_id":"","url":"https://api.github.com/users/aquasecurity","html_url":"https://github.com/aquasecurity","followers_url":"https://api.github.com/users/aquasecurity/followers","following_url":"https://api.github.com/users/aquasecurity/following{/other_user}","gists_url":"https://api.github.com/users/aquasecurity/gists{/gist_id}","starred_url":"https://api.github.com/users/aquasecurity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquasecurity/subscriptions","organizations_url":"https://api.github.com/users/aquasecurity/orgs","repos_url":"https://api.github.com/users/aquasecurity/repos","events_url":"https://api.github.com/users/aquasecurity/events{/privacy}","received_events_url":"https://api.github.com/users/aquasecurity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aquasecurity/vuln-list-update","description":null,"fork":false,"url":"https://api.github.com/repos/aquasecurity/vuln-list-update","forks_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/forks","keys_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/teams","hooks_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/hooks","issue_events_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/issues/events{/number}","events_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/events","assignees_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/assignees{/user}","branches_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/branches{/branch}","tags_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/tags","blobs_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/git/refs{/sha}","trees_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/statuses/{sha}","languages_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/languages","stargazers_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/stargazers","contributors_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/contributors","subscribers_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/subscribers","subscription_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/subscription","commits_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/commits{/sha}","git_commits_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/git/commits{/sha}","comments_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/comments{/number}","issue_comment_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/issues/comments{/number}","contents_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/contents/{+path}","compare_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/merges","archive_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/downloads","issues_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/issues{/number}","pulls_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls{/number}","milestones_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/milestones{/number}","notifications_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/labels{/name}","releases_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/releases{/id}","deployments_url":"https://api.github.com/repos/aquasecurity/vuln-list-update/deployments","created_at":"2019-04-30T01:15:05Z","updated_at":"2019-11-12T03:57:46Z","pushed_at":"2019-11-10T11:38:05Z","git_url":"git://github.com/aquasecurity/vuln-list-update.git","ssh_url":"git@github.com:aquasecurity/vuln-list-update.git","clone_url":"https://github.com/aquasecurity/vuln-list-update.git","svn_url":"https://github.com/aquasecurity/vuln-list-update","homepage":null,"size":135,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/18"},"html":{"href":"https://github.com/aquasecurity/vuln-list-update/pull/18"},"issue":{"href":"https://api.github.com/repos/aquasecurity/vuln-list-update/issues/18"},"comments":{"href":"https://api.github.com/repos/aquasecurity/vuln-list-update/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aquasecurity/vuln-list-update/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/aquasecurity/vuln-list-update/statuses/5f7e6fb73cf5eaf4aa9232ed8c02108592632441"}},"author_association":"NONE"}}
|
{
"id": 184168153,
"name": "aquasecurity/vuln-list-update",
"url": "https://api.github.com/repos/aquasecurity/vuln-list-update"
}
|
{
"id": 2253692,
"login": "knqyf263",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2253692?",
"url": "https://api.github.com/users/knqyf263"
}
|
{
"id": 12783832,
"login": "aquasecurity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12783832?",
"url": "https://api.github.com/orgs/aquasecurity"
}
| 2019-11-13T08:30:27 |
10850320990
|
{"actor":{"display_login":"knqyf263"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/haikuports/haikuports/pulls/comments/366376648","pull_request_review_id":342582466,"id":366376648,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NjM3NjY0OA==","diff_hunk":"@@ -0,0 +1,142 @@\n+SUMMARY=\"A light-weight text-to-speech engine\"\n+DESCRIPTION=\"Flite is a text-to-speech engine developed by the Carnegie \\\n+Mellon University. As a light-weight alternative to the Festival engine, it \\\n+is desinged to fit into small embedded machines as well as large-scale \\\n+servers. In addition to its native format flite supports voices generated by \\\n+the FestVox project as well.\"\n+HOMEPAGE=\"http://www.festvox.org/flite/\n+\thttps://github.com/festvox/flite\"\n+COPYRIGHT=\"1986 University of Toronto\n+\t1992, 1995 Markus Mummert\n+\t1996-2004 University of Edinburgh, UK\n+\t1999-2014 Language Technologies Institute, Carnegie Mellon University\n+\t2001 Cepstral, LLC\n+\t2001 Sun Microsystems, Inc.\n+\t2003-2004 Nagoya Institute of Technology\n+\t2003-2004 Nara Institute of Science and Technology\n+\t2008-2012 University of Illinois at Urbana-Champaign\"\n+# Although individually many files have different licenses, as a whole this\n+# license covers all the files.\n+LICENSE=\"Flite\"\n+REVISION=\"1\"\n+SOURCE_URI=\"http://www.festvox.org/${portName}/packed/${portName}-${portVersion}/${portName}-${portVersion}-release.tar.bz2\"\n+CHECKSUM_SHA256=\"c73c3f6a2ea764977d6eaf0a287722d1e2066b4697088c552e342c790f3d2b85\"\n+SOURCE_DIR=\"flite-${portVersion}-release\"\n+PATCHES=\"flite-$portVersion.patchset\"\n+\n+ARCHITECTURES=\"x86_gcc2 x86 x86_64\"\n+SECONDARY_ARCHITECTURES=\"x86_gcc2 x86\"\n+\n+commandBinDir=$binDir\n+commandSuffix=$secondaryArchSuffix\n+if [ \"$targetArchitecture\" = x86_gcc2 ]; then\n+\tcommandSuffix=\n+\tcommandBinDir=$prefix/bin\n+fi\n+\n+libVersion=\"2.1\"\n+libVersionCompat=\"$libVersion compat >= ${libVersion%%.*}\"\n+\n+PROVIDES=\"\n+\tflite$secondaryArchSuffix = $portVersion\n+\tflite_tools$secondaryArchSuffix = $portVersion\n+\tcmd:flite$commandSuffix = $portVersion\n+\tcmd:flite_cmu_time_awb$commandSuffix = $portVersion\n+\tcmd:flite_cmu_us_awb$commandSuffix = $portVersion\n+\tcmd:flite_cmu_us_kal$commandSuffix = $portVersion\n+\tcmd:flite_cmu_us_kal16$commandSuffix = $portVersion\n+\tcmd:flite_cmu_us_rms$commandSuffix = $portVersion\n+\tcmd:flite_cmu_us_slt$commandSuffix = $portVersion\n+\tcmd:flite_time$commandSuffix = $portVersion\n+\tlib:libflite$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_grapheme_lang$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_grapheme_lex$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_indic_lang$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_indic_lex$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_time_awb$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_us_awb$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_us_kal$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_us_kal16$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_us_rms$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmu_us_slt$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_cmulex$secondaryArchSuffix = $libVersionCompat\n+\tlib:libflite_usenglish$secondaryArchSuffix = $libVersionCompat\n+\t\"\n+REQUIRES=\"\n+\thaiku$secondaryArchSuffix\n+\t\"\n+\n+PROVIDES_devel=\"\n+\tflite${secondaryArchSuffix}_devel = $portVersion\n+\tdevel:libflite$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_grapheme_lang$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_grapheme_lex$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_indic_lang$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_indic_lex$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_time_awb$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_us_awb$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_us_kal$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_us_kal16$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_us_rms$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmu_us_slt$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_cmulex$secondaryArchSuffix = $libVersionCompat\n+\tdevel:libflite_usenglish$secondaryArchSuffix = $libVersionCompat\n+\t\"\n+REQUIRES_devel=\"\n+\tflite$secondaryArchSuffix == $portVersion base\n+\t\"\n+\n+BUILD_REQUIRES=\"\n+\thaiku${secondaryArchSuffix}_devel\n+\t\"\n+BUILD_PREREQUIRES=\"\n+\tcmd:autoconf\n+\tcmd:awk\n+\tcmd:gcc$secondaryArchSuffix\n+\tcmd:make\n+\t\"\n+\n+defineDebugInfoPackage flite$secondaryArchSuffix \\\n+\t$commandBinDir/flite_cmu_time_awb \\\n+\t$commandBinDir/flite_cmu_us_awb \\\n+\t$commandBinDir/flite_cmu_us_kal \\\n+\t$commandBinDir/flite_cmu_us_kal16 \\\n+\t$commandBinDir/flite_cmu_us_rms \\\n+\t$commandBinDir/flite_cmu_us_slt \\\n+\t$commandBinDir/flite_time \\\n+\t$libDir/libflite.so.$libVersion \\\n+\t$libDir/libflite_cmu_indic_lang.so.$libVersion \\\n+\t$libDir/libflite_cmu_indic_lex.so.$libVersion \\\n+\t$libDir/libflite_cmu_time_awb.so.$libVersion \\\n+\t$libDir/libflite_cmu_us_awb.so.$libVersion \\\n+\t$libDir/libflite_cmu_us_kal16.so.$libVersion \\\n+\t$libDir/libflite_cmu_us_slt.so.$libVersion \\\n+\t$libDir/libflite_cmulex.so.$libVersion \\\n+\t$libDir/libflite_usenglish.so.$libVersion\n+\n+BUILD()\n+{\n+\tautoconf\n+\trunConfigure ./configure --enable-shared\n+\tmake $jobArgs\n+}\n+\n+INSTALL()\n+{\n+\tmake $jobArgs install\n+\tprepareInstalledDevelLibs \\\n+\t\tlibflite \\\n+\t\tlibflite_cmu_grapheme_lang \\\n+\t\tlibflite_cmu_grapheme_lex \\\n+\t\tlibflite_cmu_indic_lang \\\n+\t\tlibflite_cmu_indic_lex \\\n+\t\tlibflite_cmu_time_awb \\\n+\t\tlibflite_cmu_us_awb \\\n+\t\tlibflite_cmu_us_kal \\\n+\t\tlibflite_cmu_us_kal16 \\\n+\t\tlibflite_cmu_us_rms \\\n+\t\tlibflite_cmu_us_slt \\\n+\t\tlibflite_cmulex \\\n+\t\tlibflite_usenglish\n+\tpackageEntries devel $developDir","path":"app-accessibility/flite/flite-2.1.recipe","position":141,"original_position":141,"commit_id":"9306b7415c3525a258225b14ed365ff3e9613267","original_commit_id":"9306b7415c3525a258225b14ed365ff3e9613267","user":{"login":"Begasus","id":16057090,"node_id":"MDQ6VXNlcjE2MDU3MDkw","avatar_url":"https://avatars2.githubusercontent.com/u/16057090?v=4","gravatar_id":"","url":"https://api.github.com/users/Begasus","html_url":"https://github.com/Begasus","followers_url":"https://api.github.com/users/Begasus/followers","following_url":"https://api.github.com/users/Begasus/following{/other_user}","gists_url":"https://api.github.com/users/Begasus/gists{/gist_id}","starred_url":"https://api.github.com/users/Begasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Begasus/subscriptions","organizations_url":"https://api.github.com/users/Begasus/orgs","repos_url":"https://api.github.com/users/Begasus/repos","events_url":"https://api.github.com/users/Begasus/events{/privacy}","received_events_url":"https://api.github.com/users/Begasus/received_events","type":"User","site_admin":false},"body":"I'm in favour of removing the binaries from secondary architecture here, they will probably collide as they are both installed in $prefix/bin for gcc2h ...","created_at":"2020-01-14T14:42:54Z","updated_at":"2020-01-14T14:42:54Z","html_url":"https://github.com/haikuports/haikuports/pull/4580#discussion_r366376648","pull_request_url":"https://api.github.com/repos/haikuports/haikuports/pulls/4580","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/comments/366376648"},"html":{"href":"https://github.com/haikuports/haikuports/pull/4580#discussion_r366376648"},"pull_request":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/4580"}}},"pull_request":{"url":"https://api.github.com/repos/haikuports/haikuports/pulls/4580","id":362258582,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYyMjU4NTgy","html_url":"https://github.com/haikuports/haikuports/pull/4580","diff_url":"https://github.com/haikuports/haikuports/pull/4580.diff","patch_url":"https://github.com/haikuports/haikuports/pull/4580.patch","issue_url":"https://api.github.com/repos/haikuports/haikuports/issues/4580","number":4580,"state":"open","locked":false,"title":"flite: bump to 2.1","user":{"login":"alwayslivid","id":30193966,"node_id":"MDQ6VXNlcjMwMTkzOTY2","avatar_url":"https://avatars0.githubusercontent.com/u/30193966?v=4","gravatar_id":"","url":"https://api.github.com/users/alwayslivid","html_url":"https://github.com/alwayslivid","followers_url":"https://api.github.com/users/alwayslivid/followers","following_url":"https://api.github.com/users/alwayslivid/following{/other_user}","gists_url":"https://api.github.com/users/alwayslivid/gists{/gist_id}","starred_url":"https://api.github.com/users/alwayslivid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alwayslivid/subscriptions","organizations_url":"https://api.github.com/users/alwayslivid/orgs","repos_url":"https://api.github.com/users/alwayslivid/repos","events_url":"https://api.github.com/users/alwayslivid/events{/privacy}","received_events_url":"https://api.github.com/users/alwayslivid/received_events","type":"User","site_admin":false},"body":"This is a continuation of #4525, as the branch that contained my modifications was accidentally deleted.","created_at":"2020-01-13T18:26:35Z","updated_at":"2020-01-14T14:42:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18ea6daf65780e4793e24b9b0abed4aa1383db82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haikuports/haikuports/pulls/4580/commits","review_comments_url":"https://api.github.com/repos/haikuports/haikuports/pulls/4580/comments","review_comment_url":"https://api.github.com/repos/haikuports/haikuports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haikuports/haikuports/issues/4580/comments","statuses_url":"https://api.github.com/repos/haikuports/haikuports/statuses/9306b7415c3525a258225b14ed365ff3e9613267","head":{"label":"alwayslivid:flite","ref":"flite","sha":"9306b7415c3525a258225b14ed365ff3e9613267","user":{"login":"alwayslivid","id":30193966,"node_id":"MDQ6VXNlcjMwMTkzOTY2","avatar_url":"https://avatars0.githubusercontent.com/u/30193966?v=4","gravatar_id":"","url":"https://api.github.com/users/alwayslivid","html_url":"https://github.com/alwayslivid","followers_url":"https://api.github.com/users/alwayslivid/followers","following_url":"https://api.github.com/users/alwayslivid/following{/other_user}","gists_url":"https://api.github.com/users/alwayslivid/gists{/gist_id}","starred_url":"https://api.github.com/users/alwayslivid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alwayslivid/subscriptions","organizations_url":"https://api.github.com/users/alwayslivid/orgs","repos_url":"https://api.github.com/users/alwayslivid/repos","events_url":"https://api.github.com/users/alwayslivid/events{/privacy}","received_events_url":"https://api.github.com/users/alwayslivid/received_events","type":"User","site_admin":false},"repo":{"id":233308779,"node_id":"MDEwOlJlcG9zaXRvcnkyMzMzMDg3Nzk=","name":"haikuports","full_name":"alwayslivid/haikuports","private":false,"owner":{"login":"alwayslivid","id":30193966,"node_id":"MDQ6VXNlcjMwMTkzOTY2","avatar_url":"https://avatars0.githubusercontent.com/u/30193966?v=4","gravatar_id":"","url":"https://api.github.com/users/alwayslivid","html_url":"https://github.com/alwayslivid","followers_url":"https://api.github.com/users/alwayslivid/followers","following_url":"https://api.github.com/users/alwayslivid/following{/other_user}","gists_url":"https://api.github.com/users/alwayslivid/gists{/gist_id}","starred_url":"https://api.github.com/users/alwayslivid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alwayslivid/subscriptions","organizations_url":"https://api.github.com/users/alwayslivid/orgs","repos_url":"https://api.github.com/users/alwayslivid/repos","events_url":"https://api.github.com/users/alwayslivid/events{/privacy}","received_events_url":"https://api.github.com/users/alwayslivid/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alwayslivid/haikuports","description":"Software ports for the Haiku operating system.","fork":true,"url":"https://api.github.com/repos/alwayslivid/haikuports","forks_url":"https://api.github.com/repos/alwayslivid/haikuports/forks","keys_url":"https://api.github.com/repos/alwayslivid/haikuports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alwayslivid/haikuports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alwayslivid/haikuports/teams","hooks_url":"https://api.github.com/repos/alwayslivid/haikuports/hooks","issue_events_url":"https://api.github.com/repos/alwayslivid/haikuports/issues/events{/number}","events_url":"https://api.github.com/repos/alwayslivid/haikuports/events","assignees_url":"https://api.github.com/repos/alwayslivid/haikuports/assignees{/user}","branches_url":"https://api.github.com/repos/alwayslivid/haikuports/branches{/branch}","tags_url":"https://api.github.com/repos/alwayslivid/haikuports/tags","blobs_url":"https://api.github.com/repos/alwayslivid/haikuports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alwayslivid/haikuports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alwayslivid/haikuports/git/refs{/sha}","trees_url":"https://api.github.com/repos/alwayslivid/haikuports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alwayslivid/haikuports/statuses/{sha}","languages_url":"https://api.github.com/repos/alwayslivid/haikuports/languages","stargazers_url":"https://api.github.com/repos/alwayslivid/haikuports/stargazers","contributors_url":"https://api.github.com/repos/alwayslivid/haikuports/contributors","subscribers_url":"https://api.github.com/repos/alwayslivid/haikuports/subscribers","subscription_url":"https://api.github.com/repos/alwayslivid/haikuports/subscription","commits_url":"https://api.github.com/repos/alwayslivid/haikuports/commits{/sha}","git_commits_url":"https://api.github.com/repos/alwayslivid/haikuports/git/commits{/sha}","comments_url":"https://api.github.com/repos/alwayslivid/haikuports/comments{/number}","issue_comment_url":"https://api.github.com/repos/alwayslivid/haikuports/issues/comments{/number}","contents_url":"https://api.github.com/repos/alwayslivid/haikuports/contents/{+path}","compare_url":"https://api.github.com/repos/alwayslivid/haikuports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alwayslivid/haikuports/merges","archive_url":"https://api.github.com/repos/alwayslivid/haikuports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alwayslivid/haikuports/downloads","issues_url":"https://api.github.com/repos/alwayslivid/haikuports/issues{/number}","pulls_url":"https://api.github.com/repos/alwayslivid/haikuports/pulls{/number}","milestones_url":"https://api.github.com/repos/alwayslivid/haikuports/milestones{/number}","notifications_url":"https://api.github.com/repos/alwayslivid/haikuports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alwayslivid/haikuports/labels{/name}","releases_url":"https://api.github.com/repos/alwayslivid/haikuports/releases{/id}","deployments_url":"https://api.github.com/repos/alwayslivid/haikuports/deployments","created_at":"2020-01-11T22:57:37Z","updated_at":"2020-01-12T15:54:54Z","pushed_at":"2020-01-14T13:08:19Z","git_url":"git://github.com/alwayslivid/haikuports.git","ssh_url":"git@github.com:alwayslivid/haikuports.git","clone_url":"https://github.com/alwayslivid/haikuports.git","svn_url":"https://github.com/alwayslivid/haikuports","homepage":"","size":42543,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haikuports:master","ref":"master","sha":"3666bd7c421da695183b7fb2523c83ffaa32238a","user":{"login":"haikuports","id":12898682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk4Njgy","avatar_url":"https://avatars3.githubusercontent.com/u/12898682?v=4","gravatar_id":"","url":"https://api.github.com/users/haikuports","html_url":"https://github.com/haikuports","followers_url":"https://api.github.com/users/haikuports/followers","following_url":"https://api.github.com/users/haikuports/following{/other_user}","gists_url":"https://api.github.com/users/haikuports/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuports/subscriptions","organizations_url":"https://api.github.com/users/haikuports/orgs","repos_url":"https://api.github.com/users/haikuports/repos","events_url":"https://api.github.com/users/haikuports/events{/privacy}","received_events_url":"https://api.github.com/users/haikuports/received_events","type":"Organization","site_admin":false},"repo":{"id":38278075,"node_id":"MDEwOlJlcG9zaXRvcnkzODI3ODA3NQ==","name":"haikuports","full_name":"haikuports/haikuports","private":false,"owner":{"login":"haikuports","id":12898682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk4Njgy","avatar_url":"https://avatars3.githubusercontent.com/u/12898682?v=4","gravatar_id":"","url":"https://api.github.com/users/haikuports","html_url":"https://github.com/haikuports","followers_url":"https://api.github.com/users/haikuports/followers","following_url":"https://api.github.com/users/haikuports/following{/other_user}","gists_url":"https://api.github.com/users/haikuports/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuports/subscriptions","organizations_url":"https://api.github.com/users/haikuports/orgs","repos_url":"https://api.github.com/users/haikuports/repos","events_url":"https://api.github.com/users/haikuports/events{/privacy}","received_events_url":"https://api.github.com/users/haikuports/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/haikuports/haikuports","description":"Software ports for the Haiku operating system.","fork":false,"url":"https://api.github.com/repos/haikuports/haikuports","forks_url":"https://api.github.com/repos/haikuports/haikuports/forks","keys_url":"https://api.github.com/repos/haikuports/haikuports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haikuports/haikuports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haikuports/haikuports/teams","hooks_url":"https://api.github.com/repos/haikuports/haikuports/hooks","issue_events_url":"https://api.github.com/repos/haikuports/haikuports/issues/events{/number}","events_url":"https://api.github.com/repos/haikuports/haikuports/events","assignees_url":"https://api.github.com/repos/haikuports/haikuports/assignees{/user}","branches_url":"https://api.github.com/repos/haikuports/haikuports/branches{/branch}","tags_url":"https://api.github.com/repos/haikuports/haikuports/tags","blobs_url":"https://api.github.com/repos/haikuports/haikuports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haikuports/haikuports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haikuports/haikuports/git/refs{/sha}","trees_url":"https://api.github.com/repos/haikuports/haikuports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haikuports/haikuports/statuses/{sha}","languages_url":"https://api.github.com/repos/haikuports/haikuports/languages","stargazers_url":"https://api.github.com/repos/haikuports/haikuports/stargazers","contributors_url":"https://api.github.com/repos/haikuports/haikuports/contributors","subscribers_url":"https://api.github.com/repos/haikuports/haikuports/subscribers","subscription_url":"https://api.github.com/repos/haikuports/haikuports/subscription","commits_url":"https://api.github.com/repos/haikuports/haikuports/commits{/sha}","git_commits_url":"https://api.github.com/repos/haikuports/haikuports/git/commits{/sha}","comments_url":"https://api.github.com/repos/haikuports/haikuports/comments{/number}","issue_comment_url":"https://api.github.com/repos/haikuports/haikuports/issues/comments{/number}","contents_url":"https://api.github.com/repos/haikuports/haikuports/contents/{+path}","compare_url":"https://api.github.com/repos/haikuports/haikuports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haikuports/haikuports/merges","archive_url":"https://api.github.com/repos/haikuports/haikuports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haikuports/haikuports/downloads","issues_url":"https://api.github.com/repos/haikuports/haikuports/issues{/number}","pulls_url":"https://api.github.com/repos/haikuports/haikuports/pulls{/number}","milestones_url":"https://api.github.com/repos/haikuports/haikuports/milestones{/number}","notifications_url":"https://api.github.com/repos/haikuports/haikuports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haikuports/haikuports/labels{/name}","releases_url":"https://api.github.com/repos/haikuports/haikuports/releases{/id}","deployments_url":"https://api.github.com/repos/haikuports/haikuports/deployments","created_at":"2015-06-30T00:15:33Z","updated_at":"2020-01-14T13:17:56Z","pushed_at":"2020-01-14T13:17:53Z","git_url":"git://github.com/haikuports/haikuports.git","ssh_url":"git@github.com:haikuports/haikuports.git","clone_url":"https://github.com/haikuports/haikuports.git","svn_url":"https://github.com/haikuports/haikuports","homepage":"","size":42497,"stargazers_count":171,"watchers_count":171,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":183,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":401,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":183,"open_issues":401,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/4580"},"html":{"href":"https://github.com/haikuports/haikuports/pull/4580"},"issue":{"href":"https://api.github.com/repos/haikuports/haikuports/issues/4580"},"comments":{"href":"https://api.github.com/repos/haikuports/haikuports/issues/4580/comments"},"review_comments":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/4580/comments"},"review_comment":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/4580/commits"},"statuses":{"href":"https://api.github.com/repos/haikuports/haikuports/statuses/9306b7415c3525a258225b14ed365ff3e9613267"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 38278075,
"name": "haikuports/haikuports",
"url": "https://api.github.com/repos/haikuports/haikuports"
}
|
{
"id": 16057090,
"login": "Begasus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16057090?",
"url": "https://api.github.com/users/Begasus"
}
|
{
"id": 12898682,
"login": "haikuports",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12898682?",
"url": "https://api.github.com/orgs/haikuports"
}
| 2020-01-14T14:42:54 |
11272337363
|
{"actor":{"display_login":"Begasus"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/comments/302377903","pull_request_review_id":260486776,"id":302377903,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjM3NzkwMw==","diff_hunk":"@@ -182,7 +186,12 @@ once xs = forM (Map.toList (Map.fromList xs))\n once_ :: (Ord k, Monad m) => [(k,v)] -> ((k,v) -> m a) -> m ()\n once_ xs = void . once xs\n \n-type TxHistory = Map (Hash \"Tx\") (Tx, TxMeta)\n+-- | Shorthand for the readTxHistory result type.\n+type TxHistory = [(Hash \"Tx\", (Tx, TxMeta))]\n+\n+-- | Apply the default sort order (descending on time) to a 'TxHistory'.\n+sortTxHistory :: TxHistory -> TxHistory\n+sortTxHistory = reverse . L.sortOn (slotId . snd . snd)","path":"lib/core/test/unit/Cardano/Wallet/DBSpec.hs","position":null,"original_position":48,"commit_id":"2119408cc647327dde5c2786162ca3f7fdb25be2","original_commit_id":"f25e30883304c0df2061d6160c2cba2564506ec6","user":{"login":"Anviking","id":304423,"node_id":"MDQ6VXNlcjMwNDQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/304423?v=4","gravatar_id":"","url":"https://api.github.com/users/Anviking","html_url":"https://github.com/Anviking","followers_url":"https://api.github.com/users/Anviking/followers","following_url":"https://api.github.com/users/Anviking/following{/other_user}","gists_url":"https://api.github.com/users/Anviking/gists{/gist_id}","starred_url":"https://api.github.com/users/Anviking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anviking/subscriptions","organizations_url":"https://api.github.com/users/Anviking/orgs","repos_url":"https://api.github.com/users/Anviking/repos","events_url":"https://api.github.com/users/Anviking/events{/privacy}","received_events_url":"https://api.github.com/users/Anviking/received_events","type":"User","site_admin":false},"body":"Pushed a small fix to satisty failing hlint preferring `Data.Ord.Down` here 2119408cc647327dde5c2786162ca3f7fdb25be2","created_at":"2019-07-11T06:16:54Z","updated_at":"2019-07-11T06:16:54Z","html_url":"https://github.com/input-output-hk/cardano-wallet/pull/524#discussion_r302377903","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/524","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/comments/302377903"},"html":{"href":"https://github.com/input-output-hk/cardano-wallet/pull/524#discussion_r302377903"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/524","id":296448147,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2NDQ4MTQ3","html_url":"https://github.com/input-output-hk/cardano-wallet/pull/524","diff_url":"https://github.com/input-output-hk/cardano-wallet/pull/524.diff","patch_url":"https://github.com/input-output-hk/cardano-wallet/pull/524.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/524","number":524,"state":"open","locked":false,"title":"DBLayer readTxHistory now returns a sorted list","user":{"login":"rvl","id":1019641,"node_id":"MDQ6VXNlcjEwMTk2NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1019641?v=4","gravatar_id":"","url":"https://api.github.com/users/rvl","html_url":"https://github.com/rvl","followers_url":"https://api.github.com/users/rvl/followers","following_url":"https://api.github.com/users/rvl/following{/other_user}","gists_url":"https://api.github.com/users/rvl/gists{/gist_id}","starred_url":"https://api.github.com/users/rvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvl/subscriptions","organizations_url":"https://api.github.com/users/rvl/orgs","repos_url":"https://api.github.com/users/rvl/repos","events_url":"https://api.github.com/users/rvl/events{/privacy}","received_events_url":"https://api.github.com/users/rvl/received_events","type":"User","site_admin":false},"body":"Relates to #465\r\n\r\n# Overview\r\n\r\n- Adjusts the DBLayer readTxHistory function to return transactions in descending order by slot.\r\n","created_at":"2019-07-11T03:38:58Z","updated_at":"2019-07-11T06:16:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8774be9763ce996423fb136891e485dbf485c2bf","assignee":{"login":"rvl","id":1019641,"node_id":"MDQ6VXNlcjEwMTk2NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1019641?v=4","gravatar_id":"","url":"https://api.github.com/users/rvl","html_url":"https://github.com/rvl","followers_url":"https://api.github.com/users/rvl/followers","following_url":"https://api.github.com/users/rvl/following{/other_user}","gists_url":"https://api.github.com/users/rvl/gists{/gist_id}","starred_url":"https://api.github.com/users/rvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvl/subscriptions","organizations_url":"https://api.github.com/users/rvl/orgs","repos_url":"https://api.github.com/users/rvl/repos","events_url":"https://api.github.com/users/rvl/events{/privacy}","received_events_url":"https://api.github.com/users/rvl/received_events","type":"User","site_admin":false},"assignees":[{"login":"rvl","id":1019641,"node_id":"MDQ6VXNlcjEwMTk2NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1019641?v=4","gravatar_id":"","url":"https://api.github.com/users/rvl","html_url":"https://github.com/rvl","followers_url":"https://api.github.com/users/rvl/followers","following_url":"https://api.github.com/users/rvl/following{/other_user}","gists_url":"https://api.github.com/users/rvl/gists{/gist_id}","starred_url":"https://api.github.com/users/rvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvl/subscriptions","organizations_url":"https://api.github.com/users/rvl/orgs","repos_url":"https://api.github.com/users/rvl/repos","events_url":"https://api.github.com/users/rvl/events{/privacy}","received_events_url":"https://api.github.com/users/rvl/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jonathanknowles","id":206319,"node_id":"MDQ6VXNlcjIwNjMxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/206319?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanknowles","html_url":"https://github.com/jonathanknowles","followers_url":"https://api.github.com/users/jonathanknowles/followers","following_url":"https://api.github.com/users/jonathanknowles/following{/other_user}","gists_url":"https://api.github.com/users/jonathanknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanknowles/subscriptions","organizations_url":"https://api.github.com/users/jonathanknowles/orgs","repos_url":"https://api.github.com/users/jonathanknowles/repos","events_url":"https://api.github.com/users/jonathanknowles/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanknowles/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/524/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/524/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/524/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/2119408cc647327dde5c2786162ca3f7fdb25be2","head":{"label":"input-output-hk:rvl/465/sort-tx-history","ref":"rvl/465/sort-tx-history","sha":"2119408cc647327dde5c2786162ca3f7fdb25be2","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":173286031,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMyODYwMzE=","name":"cardano-wallet","full_name":"input-output-hk/cardano-wallet","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/cardano-wallet","description":"Official Wallet Backend & API for Cardano decentralized","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-wallet","forks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/deployments","created_at":"2019-03-01T10:50:58Z","updated_at":"2019-07-10T19:37:06Z","pushed_at":"2019-07-11T06:14:17Z","git_url":"git://github.com/input-output-hk/cardano-wallet.git","ssh_url":"git@github.com:input-output-hk/cardano-wallet.git","clone_url":"https://github.com/input-output-hk/cardano-wallet.git","svn_url":"https://github.com/input-output-hk/cardano-wallet","homepage":null,"size":129485,"stargazers_count":33,"watchers_count":33,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":21,"watchers":33,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"d6b10f6a73841e2721eac04b2638b9b24391e7e7","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":173286031,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMyODYwMzE=","name":"cardano-wallet","full_name":"input-output-hk/cardano-wallet","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/cardano-wallet","description":"Official Wallet Backend & API for Cardano decentralized","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-wallet","forks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/deployments","created_at":"2019-03-01T10:50:58Z","updated_at":"2019-07-10T19:37:06Z","pushed_at":"2019-07-11T06:14:17Z","git_url":"git://github.com/input-output-hk/cardano-wallet.git","ssh_url":"git@github.com:input-output-hk/cardano-wallet.git","clone_url":"https://github.com/input-output-hk/cardano-wallet.git","svn_url":"https://github.com/input-output-hk/cardano-wallet","homepage":null,"size":129485,"stargazers_count":33,"watchers_count":33,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":21,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/524"},"html":{"href":"https://github.com/input-output-hk/cardano-wallet/pull/524"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/524"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/2119408cc647327dde5c2786162ca3f7fdb25be2"}},"author_association":"MEMBER"}}
|
{
"id": 173286031,
"name": "input-output-hk/cardano-wallet",
"url": "https://api.github.com/repos/input-output-hk/cardano-wallet"
}
|
{
"id": 304423,
"login": "Anviking",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/304423?",
"url": "https://api.github.com/users/Anviking"
}
|
{
"id": 12909177,
"login": "input-output-hk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12909177?",
"url": "https://api.github.com/orgs/input-output-hk"
}
| 2019-07-11T06:16:54 |
9989461202
|
{"actor":{"display_login":"Anviking"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/comments/296636370","pull_request_review_id":253303326,"id":296636370,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjYzNjM3MA==","diff_hunk":"@@ -0,0 +1,8 @@\n+;;; Directory Local Variables\n+;;; For more information see (info \"(emacs) Directory Variables\")\n+\n+((nil\n+ (haskell-mode-stylish-haskell-path . \"stylish-haskell\")\n+ )\n+ (haskell-mode\n+ (haskell-stylish-on-save . t)))","path":".dir-locals.el","position":8,"original_position":8,"commit_id":"d627c79c99575844166230f22514526b7e07b7e9","original_commit_id":"d627c79c99575844166230f22514526b7e07b7e9","user":{"login":"dnadales","id":175315,"node_id":"MDQ6VXNlcjE3NTMxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/175315?v=4","gravatar_id":"","url":"https://api.github.com/users/dnadales","html_url":"https://github.com/dnadales","followers_url":"https://api.github.com/users/dnadales/followers","following_url":"https://api.github.com/users/dnadales/following{/other_user}","gists_url":"https://api.github.com/users/dnadales/gists{/gist_id}","starred_url":"https://api.github.com/users/dnadales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnadales/subscriptions","organizations_url":"https://api.github.com/users/dnadales/orgs","repos_url":"https://api.github.com/users/dnadales/repos","events_url":"https://api.github.com/users/dnadales/events{/privacy}","received_events_url":"https://api.github.com/users/dnadales/received_events","type":"User","site_admin":false},"body":"That's a good question. By having this here we make sure that Emacs users don't have to setup anything extra (and if they don't use `stylish-haskell` for other projects, they don't have to set this up locally).\r\n\r\nAlternatively I could put this in the README, but then everyone who uses Emacs would have to copy and paste this.\r\n\r\nI don't know what's more sensible ...","created_at":"2019-06-24T09:40:24Z","updated_at":"2019-06-24T09:40:24Z","html_url":"https://github.com/input-output-hk/cardano-ledger-specs/pull/588#discussion_r296636370","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/588","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/comments/296636370"},"html":{"href":"https://github.com/input-output-hk/cardano-ledger-specs/pull/588#discussion_r296636370"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/588"}},"in_reply_to_id":296624431},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/588","id":289486855,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5NDg2ODU1","html_url":"https://github.com/input-output-hk/cardano-ledger-specs/pull/588","diff_url":"https://github.com/input-output-hk/cardano-ledger-specs/pull/588.diff","patch_url":"https://github.com/input-output-hk/cardano-ledger-specs/pull/588.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues/588","number":588,"state":"open","locked":false,"title":"Dnadales/538 create stylish haskell configuration and instructions","user":{"login":"dnadales","id":175315,"node_id":"MDQ6VXNlcjE3NTMxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/175315?v=4","gravatar_id":"","url":"https://api.github.com/users/dnadales","html_url":"https://github.com/dnadales","followers_url":"https://api.github.com/users/dnadales/followers","following_url":"https://api.github.com/users/dnadales/following{/other_user}","gists_url":"https://api.github.com/users/dnadales/gists{/gist_id}","starred_url":"https://api.github.com/users/dnadales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnadales/subscriptions","organizations_url":"https://api.github.com/users/dnadales/orgs","repos_url":"https://api.github.com/users/dnadales/repos","events_url":"https://api.github.com/users/dnadales/events{/privacy}","received_events_url":"https://api.github.com/users/dnadales/received_events","type":"User","site_admin":false},"body":"\r\n\r\nCloses #538 ","created_at":"2019-06-18T23:22:55Z","updated_at":"2019-06-24T09:40:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8165463a97c429f3107fa410775c99d587db0b0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"uroboros","id":8812,"node_id":"MDQ6VXNlcjg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8812?v=4","gravatar_id":"","url":"https://api.github.com/users/uroboros","html_url":"https://github.com/uroboros","followers_url":"https://api.github.com/users/uroboros/followers","following_url":"https://api.github.com/users/uroboros/following{/other_user}","gists_url":"https://api.github.com/users/uroboros/gists{/gist_id}","starred_url":"https://api.github.com/users/uroboros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uroboros/subscriptions","organizations_url":"https://api.github.com/users/uroboros/orgs","repos_url":"https://api.github.com/users/uroboros/repos","events_url":"https://api.github.com/users/uroboros/events{/privacy}","received_events_url":"https://api.github.com/users/uroboros/received_events","type":"User","site_admin":false},{"login":"mdimjasevic","id":6256391,"node_id":"MDQ6VXNlcjYyNTYzOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6256391?v=4","gravatar_id":"","url":"https://api.github.com/users/mdimjasevic","html_url":"https://github.com/mdimjasevic","followers_url":"https://api.github.com/users/mdimjasevic/followers","following_url":"https://api.github.com/users/mdimjasevic/following{/other_user}","gists_url":"https://api.github.com/users/mdimjasevic/gists{/gist_id}","starred_url":"https://api.github.com/users/mdimjasevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdimjasevic/subscriptions","organizations_url":"https://api.github.com/users/mdimjasevic/orgs","repos_url":"https://api.github.com/users/mdimjasevic/repos","events_url":"https://api.github.com/users/mdimjasevic/events{/privacy}","received_events_url":"https://api.github.com/users/mdimjasevic/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/588/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/588/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues/588/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/statuses/d627c79c99575844166230f22514526b7e07b7e9","head":{"label":"input-output-hk:dnadales/538-create-stylish-haskell-configuration-and-instructions","ref":"dnadales/538-create-stylish-haskell-configuration-and-instructions","sha":"d627c79c99575844166230f22514526b7e07b7e9","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":150113380,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMTMzODA=","name":"cardano-ledger-specs","full_name":"input-output-hk/cardano-ledger-specs","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/cardano-ledger-specs","description":"A formal specification and executable model of the ledger rules introduced by the Shelley release","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs","forks_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/deployments","created_at":"2018-09-24T14:14:10Z","updated_at":"2019-06-20T13:21:39Z","pushed_at":"2019-06-24T09:15:53Z","git_url":"git://github.com/input-output-hk/cardano-ledger-specs.git","ssh_url":"git@github.com:input-output-hk/cardano-ledger-specs.git","clone_url":"https://github.com/input-output-hk/cardano-ledger-specs.git","svn_url":"https://github.com/input-output-hk/cardano-ledger-specs","homepage":"","size":16367,"stargazers_count":16,"watchers_count":16,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":82,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":82,"watchers":16,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"5eba0285031286843c2f3c18dba1a96a636067b6","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":150113380,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMTMzODA=","name":"cardano-ledger-specs","full_name":"input-output-hk/cardano-ledger-specs","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/cardano-ledger-specs","description":"A formal specification and executable model of the ledger rules introduced by the Shelley release","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs","forks_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/deployments","created_at":"2018-09-24T14:14:10Z","updated_at":"2019-06-20T13:21:39Z","pushed_at":"2019-06-24T09:15:53Z","git_url":"git://github.com/input-output-hk/cardano-ledger-specs.git","ssh_url":"git@github.com:input-output-hk/cardano-ledger-specs.git","clone_url":"https://github.com/input-output-hk/cardano-ledger-specs.git","svn_url":"https://github.com/input-output-hk/cardano-ledger-specs","homepage":"","size":16367,"stargazers_count":16,"watchers_count":16,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":82,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":82,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/588"},"html":{"href":"https://github.com/input-output-hk/cardano-ledger-specs/pull/588"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues/588"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-ledger-specs/statuses/d627c79c99575844166230f22514526b7e07b7e9"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 150113380,
"name": "input-output-hk/cardano-ledger-specs",
"url": "https://api.github.com/repos/input-output-hk/cardano-ledger-specs"
}
|
{
"id": 175315,
"login": "dnadales",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/175315?",
"url": "https://api.github.com/users/dnadales"
}
|
{
"id": 12909177,
"login": "input-output-hk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12909177?",
"url": "https://api.github.com/orgs/input-output-hk"
}
| 2019-06-24T09:40:24 |
9879291647
|
{"actor":{"display_login":"dnadales"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/comments/355305164","pull_request_review_id":328739053,"id":355305164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTMwNTE2NA==","diff_hunk":"@@ -2,8 +2,11 @@ const log = require('skog')\n const isAllowed = require('../lib/is-allowed')\n const { ClientError } = require('../lib/errors')\n \n-module.exports = async function authorization (req, res, next) {\n- const accessData = req.accessData\n+async function authorize (req, res, next) {\n+ const accessData = req.accessData || req.signedCookies.access_data","path":"server/authorization.js","position":7,"original_position":7,"commit_id":"6ac04c365f799729fbf3ff77238ab0fc4b023a2b","original_commit_id":"6ac04c365f799729fbf3ff77238ab0fc4b023a2b","user":{"login":"exacs","id":6959359,"node_id":"MDQ6VXNlcjY5NTkzNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6959359?v=4","gravatar_id":"","url":"https://api.github.com/users/exacs","html_url":"https://github.com/exacs","followers_url":"https://api.github.com/users/exacs/followers","following_url":"https://api.github.com/users/exacs/following{/other_user}","gists_url":"https://api.github.com/users/exacs/gists{/gist_id}","starred_url":"https://api.github.com/users/exacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exacs/subscriptions","organizations_url":"https://api.github.com/users/exacs/orgs","repos_url":"https://api.github.com/users/exacs/repos","events_url":"https://api.github.com/users/exacs/events{/privacy}","received_events_url":"https://api.github.com/users/exacs/received_events","type":"User","site_admin":false},"body":"No. It means that, the first time you enter (after oauth redirect) you might not have the token set as cookie.\r\n\r\nIf you have better ideas on how to solve this, feel free to refactor!","created_at":"2019-12-09T08:04:10Z","updated_at":"2019-12-09T08:04:10Z","html_url":"https://github.com/KTH/lms-export-to-ladok-2/pull/2#discussion_r355305164","pull_request_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/comments/355305164"},"html":{"href":"https://github.com/KTH/lms-export-to-ladok-2/pull/2#discussion_r355305164"},"pull_request":{"href":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/2"}},"in_reply_to_id":355297581},"pull_request":{"url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/2","id":349845345,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5ODQ1MzQ1","html_url":"https://github.com/KTH/lms-export-to-ladok-2/pull/2","diff_url":"https://github.com/KTH/lms-export-to-ladok-2/pull/2.diff","patch_url":"https://github.com/KTH/lms-export-to-ladok-2/pull/2.patch","issue_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues/2","number":2,"state":"open","locked":false,"title":"Table (plus React, webpack, SCSS)","user":{"login":"exacs","id":6959359,"node_id":"MDQ6VXNlcjY5NTkzNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6959359?v=4","gravatar_id":"","url":"https://api.github.com/users/exacs","html_url":"https://github.com/exacs","followers_url":"https://api.github.com/users/exacs/followers","following_url":"https://api.github.com/users/exacs/following{/other_user}","gists_url":"https://api.github.com/users/exacs/gists{/gist_id}","starred_url":"https://api.github.com/users/exacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exacs/subscriptions","organizations_url":"https://api.github.com/users/exacs/orgs","repos_url":"https://api.github.com/users/exacs/repos","events_url":"https://api.github.com/users/exacs/events{/privacy}","received_events_url":"https://api.github.com/users/exacs/received_events","type":"User","site_admin":false},"body":"This PR contains\r\n\r\nA feature:\r\n\r\n- Show a table of grades in Ladok vs grades in Canvas when you choose an assignment & module\r\n\r\n The table is sorted by surname in the Swedish alphabetic order (A > Ö). The sorting is done in the browser\r\n\r\nTechnical changes:\r\n\r\n- Creates a toolchain based on webpack (including a SCSS transpiler, Babel…)\r\n- Adds a \"/test\" endpoint to bypass oauth (works only if `NODE_ENV = development`","created_at":"2019-12-06T09:28:18Z","updated_at":"2019-12-09T08:04:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c25e75694dfa2a2639af178a83a478faf9891ad1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/2/commits","review_comments_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/2/comments","review_comment_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues/2/comments","statuses_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/statuses/6ac04c365f799729fbf3ff77238ab0fc4b023a2b","head":{"label":"KTH:table","ref":"table","sha":"6ac04c365f799729fbf3ff77238ab0fc4b023a2b","user":{"login":"KTH","id":12915688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTE1Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/12915688?v=4","gravatar_id":"","url":"https://api.github.com/users/KTH","html_url":"https://github.com/KTH","followers_url":"https://api.github.com/users/KTH/followers","following_url":"https://api.github.com/users/KTH/following{/other_user}","gists_url":"https://api.github.com/users/KTH/gists{/gist_id}","starred_url":"https://api.github.com/users/KTH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KTH/subscriptions","organizations_url":"https://api.github.com/users/KTH/orgs","repos_url":"https://api.github.com/users/KTH/repos","events_url":"https://api.github.com/users/KTH/events{/privacy}","received_events_url":"https://api.github.com/users/KTH/received_events","type":"Organization","site_admin":false},"repo":{"id":225332791,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUzMzI3OTE=","name":"lms-export-to-ladok-2","full_name":"KTH/lms-export-to-ladok-2","private":false,"owner":{"login":"KTH","id":12915688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTE1Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/12915688?v=4","gravatar_id":"","url":"https://api.github.com/users/KTH","html_url":"https://github.com/KTH","followers_url":"https://api.github.com/users/KTH/followers","following_url":"https://api.github.com/users/KTH/following{/other_user}","gists_url":"https://api.github.com/users/KTH/gists{/gist_id}","starred_url":"https://api.github.com/users/KTH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KTH/subscriptions","organizations_url":"https://api.github.com/users/KTH/orgs","repos_url":"https://api.github.com/users/KTH/repos","events_url":"https://api.github.com/users/KTH/events{/privacy}","received_events_url":"https://api.github.com/users/KTH/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KTH/lms-export-to-ladok-2","description":"Send results of an assignment in Canvas LMS as module in Ladok","fork":false,"url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2","forks_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/forks","keys_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/teams","hooks_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/hooks","issue_events_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues/events{/number}","events_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/events","assignees_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/assignees{/user}","branches_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/branches{/branch}","tags_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/tags","blobs_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/statuses/{sha}","languages_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/languages","stargazers_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/stargazers","contributors_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/contributors","subscribers_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/subscribers","subscription_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/subscription","commits_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/contents/{+path}","compare_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/merges","archive_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/downloads","issues_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues{/number}","pulls_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls{/number}","milestones_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/milestones{/number}","notifications_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/labels{/name}","releases_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/releases{/id}","deployments_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/deployments","created_at":"2019-12-02T09:13:54Z","updated_at":"2019-12-06T07:23:28Z","pushed_at":"2019-12-06T09:28:18Z","git_url":"git://github.com/KTH/lms-export-to-ladok-2.git","ssh_url":"git@github.com:KTH/lms-export-to-ladok-2.git","clone_url":"https://github.com/KTH/lms-export-to-ladok-2.git","svn_url":"https://github.com/KTH/lms-export-to-ladok-2","homepage":null,"size":655,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"KTH:master","ref":"master","sha":"47762f908f2f0dabc444d0b4b27bc58d365a406b","user":{"login":"KTH","id":12915688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTE1Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/12915688?v=4","gravatar_id":"","url":"https://api.github.com/users/KTH","html_url":"https://github.com/KTH","followers_url":"https://api.github.com/users/KTH/followers","following_url":"https://api.github.com/users/KTH/following{/other_user}","gists_url":"https://api.github.com/users/KTH/gists{/gist_id}","starred_url":"https://api.github.com/users/KTH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KTH/subscriptions","organizations_url":"https://api.github.com/users/KTH/orgs","repos_url":"https://api.github.com/users/KTH/repos","events_url":"https://api.github.com/users/KTH/events{/privacy}","received_events_url":"https://api.github.com/users/KTH/received_events","type":"Organization","site_admin":false},"repo":{"id":225332791,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUzMzI3OTE=","name":"lms-export-to-ladok-2","full_name":"KTH/lms-export-to-ladok-2","private":false,"owner":{"login":"KTH","id":12915688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTE1Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/12915688?v=4","gravatar_id":"","url":"https://api.github.com/users/KTH","html_url":"https://github.com/KTH","followers_url":"https://api.github.com/users/KTH/followers","following_url":"https://api.github.com/users/KTH/following{/other_user}","gists_url":"https://api.github.com/users/KTH/gists{/gist_id}","starred_url":"https://api.github.com/users/KTH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KTH/subscriptions","organizations_url":"https://api.github.com/users/KTH/orgs","repos_url":"https://api.github.com/users/KTH/repos","events_url":"https://api.github.com/users/KTH/events{/privacy}","received_events_url":"https://api.github.com/users/KTH/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KTH/lms-export-to-ladok-2","description":"Send results of an assignment in Canvas LMS as module in Ladok","fork":false,"url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2","forks_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/forks","keys_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/teams","hooks_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/hooks","issue_events_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues/events{/number}","events_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/events","assignees_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/assignees{/user}","branches_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/branches{/branch}","tags_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/tags","blobs_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/statuses/{sha}","languages_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/languages","stargazers_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/stargazers","contributors_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/contributors","subscribers_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/subscribers","subscription_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/subscription","commits_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/contents/{+path}","compare_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/merges","archive_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/downloads","issues_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues{/number}","pulls_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls{/number}","milestones_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/milestones{/number}","notifications_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/labels{/name}","releases_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/releases{/id}","deployments_url":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/deployments","created_at":"2019-12-02T09:13:54Z","updated_at":"2019-12-06T07:23:28Z","pushed_at":"2019-12-06T09:28:18Z","git_url":"git://github.com/KTH/lms-export-to-ladok-2.git","ssh_url":"git@github.com:KTH/lms-export-to-ladok-2.git","clone_url":"https://github.com/KTH/lms-export-to-ladok-2.git","svn_url":"https://github.com/KTH/lms-export-to-ladok-2","homepage":null,"size":655,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/2"},"html":{"href":"https://github.com/KTH/lms-export-to-ladok-2/pull/2"},"issue":{"href":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues/2"},"comments":{"href":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/KTH/lms-export-to-ladok-2/statuses/6ac04c365f799729fbf3ff77238ab0fc4b023a2b"}},"author_association":"COLLABORATOR"}}
|
{
"id": 225332791,
"name": "KTH/lms-export-to-ladok-2",
"url": "https://api.github.com/repos/KTH/lms-export-to-ladok-2"
}
|
{
"id": 6959359,
"login": "exacs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6959359?",
"url": "https://api.github.com/users/exacs"
}
|
{
"id": 12915688,
"login": "KTH",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12915688?",
"url": "https://api.github.com/orgs/KTH"
}
| 2019-12-09T08:04:10 |
11041976784
|
{"actor":{"display_login":"exacs"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/comments/283067440","pull_request_review_id":236344865,"id":283067440,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzA2NzQ0MA==","diff_hunk":"@@ -323,20 +322,51 @@ def begin_disable(self, id_data):\n self.model.stop()\n self.detailed_state = LaserDetailedState(LaserDetailedState.ENABLEDSTATE)\n except TimeoutError as te:\n- self.fault()\n+ self.fault(code=LaserErrorCode.timeout_error,report=te.msg)\n+ self.model.set_output_energy_level(\"OFF\")\n+\n+ def end_start(self,id_data):\n+ try:\n+ self.model.connect()\n+ self.telemetry_task=asyncio.ensure_future(self.telemetry())\n+ except Exception as e:\n+ raise\n+\n+ def end_standby(self,id_data):\n+ try:\n+ if not self.telemetry_task.done():\n+ self.telemetry_task.set_result('done')\n+ self.model.disconnect()\n+ except Exception as e:\n+ raise\n+\n+ def configure(self,config):\n+ try:\n+ self.log.debug(config)\n+ self.model.set_configuration(config)\n+ except Exception as e:\n+ self.fault(code=LaserErrorCode.general_error,report=e.msg)\n+ raise\n+\n+ def get_config_pkg(self):","path":"lsst/ts/tunablelaser/csc.py","position":184,"original_position":184,"commit_id":"d10ea4fc1de65680f35ba726c918a587eb3ae01d","original_commit_id":"d10ea4fc1de65680f35ba726c918a587eb3ae01d","user":{"login":"tribeiro","id":2581045,"node_id":"MDQ6VXNlcjI1ODEwNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2581045?v=4","gravatar_id":"","url":"https://api.github.com/users/tribeiro","html_url":"https://github.com/tribeiro","followers_url":"https://api.github.com/users/tribeiro/followers","following_url":"https://api.github.com/users/tribeiro/following{/other_user}","gists_url":"https://api.github.com/users/tribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/tribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribeiro/subscriptions","organizations_url":"https://api.github.com/users/tribeiro/orgs","repos_url":"https://api.github.com/users/tribeiro/repos","events_url":"https://api.github.com/users/tribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/tribeiro/received_events","type":"User","site_admin":false},"body":"This should be \r\n\r\n```\r\n @staticmethod\r\n def get_config_pkg():\r\n ...\r\n```\r\n","created_at":"2019-05-10T23:20:35Z","updated_at":"2019-05-10T23:20:35Z","html_url":"https://github.com/lsst-ts/ts_TunableLaser/pull/11#discussion_r283067440","pull_request_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/11","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/comments/283067440"},"html":{"href":"https://github.com/lsst-ts/ts_TunableLaser/pull/11#discussion_r283067440"},"pull_request":{"href":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/11","id":277573218,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3NTczMjE4","html_url":"https://github.com/lsst-ts/ts_TunableLaser/pull/11","diff_url":"https://github.com/lsst-ts/ts_TunableLaser/pull/11.diff","patch_url":"https://github.com/lsst-ts/ts_TunableLaser/pull/11.patch","issue_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues/11","number":11,"state":"open","locked":false,"title":"Added in settings and configuration","user":{"login":"couger01","id":26975350,"node_id":"MDQ6VXNlcjI2OTc1MzUw","avatar_url":"https://avatars1.githubusercontent.com/u/26975350?v=4","gravatar_id":"","url":"https://api.github.com/users/couger01","html_url":"https://github.com/couger01","followers_url":"https://api.github.com/users/couger01/followers","following_url":"https://api.github.com/users/couger01/following{/other_user}","gists_url":"https://api.github.com/users/couger01/gists{/gist_id}","starred_url":"https://api.github.com/users/couger01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couger01/subscriptions","organizations_url":"https://api.github.com/users/couger01/orgs","repos_url":"https://api.github.com/users/couger01/repos","events_url":"https://api.github.com/users/couger01/events{/privacy}","received_events_url":"https://api.github.com/users/couger01/received_events","type":"User","site_admin":false},"body":"- Added v1 of schema\r\n- Added configuration to CSC\r\n- Changed namespace to match csc name from laser to tunablelaser\r\n- Changed doc hierarchy to match standard layout\r\n- Fixed setup.py in preparation for conda recipe","created_at":"2019-05-09T22:30:26Z","updated_at":"2019-05-10T23:20:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e5899121961fc1e13cd95b44b6616ae9b3971dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/11/commits","review_comments_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/11/comments","review_comment_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues/11/comments","statuses_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/statuses/d10ea4fc1de65680f35ba726c918a587eb3ae01d","head":{"label":"lsst-ts:feature/couger01/dm-17320","ref":"feature/couger01/dm-17320","sha":"d10ea4fc1de65680f35ba726c918a587eb3ae01d","user":{"login":"lsst-ts","id":13056264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU2MjY0","avatar_url":"https://avatars2.githubusercontent.com/u/13056264?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-ts","html_url":"https://github.com/lsst-ts","followers_url":"https://api.github.com/users/lsst-ts/followers","following_url":"https://api.github.com/users/lsst-ts/following{/other_user}","gists_url":"https://api.github.com/users/lsst-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-ts/subscriptions","organizations_url":"https://api.github.com/users/lsst-ts/orgs","repos_url":"https://api.github.com/users/lsst-ts/repos","events_url":"https://api.github.com/users/lsst-ts/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-ts/received_events","type":"Organization","site_admin":false},"repo":{"id":149669487,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2Njk0ODc=","name":"ts_TunableLaser","full_name":"lsst-ts/ts_TunableLaser","private":false,"owner":{"login":"lsst-ts","id":13056264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU2MjY0","avatar_url":"https://avatars2.githubusercontent.com/u/13056264?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-ts","html_url":"https://github.com/lsst-ts","followers_url":"https://api.github.com/users/lsst-ts/followers","following_url":"https://api.github.com/users/lsst-ts/following{/other_user}","gists_url":"https://api.github.com/users/lsst-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-ts/subscriptions","organizations_url":"https://api.github.com/users/lsst-ts/orgs","repos_url":"https://api.github.com/users/lsst-ts/repos","events_url":"https://api.github.com/users/lsst-ts/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-ts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst-ts/ts_TunableLaser","description":null,"fork":false,"url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser","forks_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/forks","keys_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/teams","hooks_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/hooks","issue_events_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/events","assignees_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/tags","blobs_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/languages","stargazers_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/stargazers","contributors_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/contributors","subscribers_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/subscribers","subscription_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/subscription","commits_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/merges","archive_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/downloads","issues_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/labels{/name}","releases_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/releases{/id}","deployments_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/deployments","created_at":"2018-09-20T20:54:32Z","updated_at":"2018-10-25T17:29:13Z","pushed_at":"2019-05-09T22:30:27Z","git_url":"git://github.com/lsst-ts/ts_TunableLaser.git","ssh_url":"git@github.com:lsst-ts/ts_TunableLaser.git","clone_url":"https://github.com/lsst-ts/ts_TunableLaser.git","svn_url":"https://github.com/lsst-ts/ts_TunableLaser","homepage":null,"size":122,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst-ts:develop","ref":"develop","sha":"5ddbc8c66f6f799a700d6f00b2a0d1983007c505","user":{"login":"lsst-ts","id":13056264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU2MjY0","avatar_url":"https://avatars2.githubusercontent.com/u/13056264?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-ts","html_url":"https://github.com/lsst-ts","followers_url":"https://api.github.com/users/lsst-ts/followers","following_url":"https://api.github.com/users/lsst-ts/following{/other_user}","gists_url":"https://api.github.com/users/lsst-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-ts/subscriptions","organizations_url":"https://api.github.com/users/lsst-ts/orgs","repos_url":"https://api.github.com/users/lsst-ts/repos","events_url":"https://api.github.com/users/lsst-ts/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-ts/received_events","type":"Organization","site_admin":false},"repo":{"id":149669487,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2Njk0ODc=","name":"ts_TunableLaser","full_name":"lsst-ts/ts_TunableLaser","private":false,"owner":{"login":"lsst-ts","id":13056264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU2MjY0","avatar_url":"https://avatars2.githubusercontent.com/u/13056264?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-ts","html_url":"https://github.com/lsst-ts","followers_url":"https://api.github.com/users/lsst-ts/followers","following_url":"https://api.github.com/users/lsst-ts/following{/other_user}","gists_url":"https://api.github.com/users/lsst-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-ts/subscriptions","organizations_url":"https://api.github.com/users/lsst-ts/orgs","repos_url":"https://api.github.com/users/lsst-ts/repos","events_url":"https://api.github.com/users/lsst-ts/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-ts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst-ts/ts_TunableLaser","description":null,"fork":false,"url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser","forks_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/forks","keys_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/teams","hooks_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/hooks","issue_events_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/events","assignees_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/tags","blobs_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/languages","stargazers_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/stargazers","contributors_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/contributors","subscribers_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/subscribers","subscription_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/subscription","commits_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/merges","archive_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/downloads","issues_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/labels{/name}","releases_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/releases{/id}","deployments_url":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/deployments","created_at":"2018-09-20T20:54:32Z","updated_at":"2018-10-25T17:29:13Z","pushed_at":"2019-05-09T22:30:27Z","git_url":"git://github.com/lsst-ts/ts_TunableLaser.git","ssh_url":"git@github.com:lsst-ts/ts_TunableLaser.git","clone_url":"https://github.com/lsst-ts/ts_TunableLaser.git","svn_url":"https://github.com/lsst-ts/ts_TunableLaser","homepage":null,"size":122,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/11"},"html":{"href":"https://github.com/lsst-ts/ts_TunableLaser/pull/11"},"issue":{"href":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues/11"},"comments":{"href":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/lsst-ts/ts_TunableLaser/statuses/d10ea4fc1de65680f35ba726c918a587eb3ae01d"}},"author_association":"COLLABORATOR"}}
|
{
"id": 149669487,
"name": "lsst-ts/ts_TunableLaser",
"url": "https://api.github.com/repos/lsst-ts/ts_TunableLaser"
}
|
{
"id": 2581045,
"login": "tribeiro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2581045?",
"url": "https://api.github.com/users/tribeiro"
}
|
{
"id": 13056264,
"login": "lsst-ts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13056264?",
"url": "https://api.github.com/orgs/lsst-ts"
}
| 2019-05-10T23:20:35 |
9605307138
|
{"actor":{"display_login":"tribeiro"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/305756046","pull_request_review_id":264702726,"id":305756046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTc1NjA0Ng==","diff_hunk":"@@ -1108,7 +1109,7 @@ static inline void ucs_debug_save_original_sighandler(int signum,\n kh_value(&ucs_signal_orig_action_map, hash_it) = oact_copy;\n \n out:\n- pthread_spin_unlock(&ucs_kh_lock);\n+ ucs_spin_unlock(&ucs_kh_lock);","path":"src/ucs/debug/debug.c","position":44,"original_position":44,"commit_id":"5c265bafc0a0f57620d1180ec7c3c75a1dcc0704","original_commit_id":"5c265bafc0a0f57620d1180ec7c3c75a1dcc0704","user":{"login":"dmitrygx","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygx","html_url":"https://github.com/dmitrygx","followers_url":"https://api.github.com/users/dmitrygx/followers","following_url":"https://api.github.com/users/dmitrygx/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygx/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygx/subscriptions","organizations_url":"https://api.github.com/users/dmitrygx/orgs","repos_url":"https://api.github.com/users/dmitrygx/repos","events_url":"https://api.github.com/users/dmitrygx/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygx/received_events","type":"User","site_admin":false},"body":"`ucs_spinlock_release`","created_at":"2019-07-22T09:39:06Z","updated_at":"2019-07-22T09:40:48Z","html_url":"https://github.com/openucx/ucx/pull/3931#discussion_r305756046","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/3931","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/305756046"},"html":{"href":"https://github.com/openucx/ucx/pull/3931#discussion_r305756046"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3931"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/3931","id":299795841,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5Nzk1ODQx","html_url":"https://github.com/openucx/ucx/pull/3931","diff_url":"https://github.com/openucx/ucx/pull/3931.diff","patch_url":"https://github.com/openucx/ucx/pull/3931.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/3931","number":3931,"state":"open","locked":false,"title":"UCS: Use ucs_spinlock instead of pthread_spinlock.","user":{"login":"hiroyuki-sato","id":767650,"node_id":"MDQ6VXNlcjc2NzY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/767650?v=4","gravatar_id":"","url":"https://api.github.com/users/hiroyuki-sato","html_url":"https://github.com/hiroyuki-sato","followers_url":"https://api.github.com/users/hiroyuki-sato/followers","following_url":"https://api.github.com/users/hiroyuki-sato/following{/other_user}","gists_url":"https://api.github.com/users/hiroyuki-sato/gists{/gist_id}","starred_url":"https://api.github.com/users/hiroyuki-sato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiroyuki-sato/subscriptions","organizations_url":"https://api.github.com/users/hiroyuki-sato/orgs","repos_url":"https://api.github.com/users/hiroyuki-sato/repos","events_url":"https://api.github.com/users/hiroyuki-sato/events{/privacy}","received_events_url":"https://api.github.com/users/hiroyuki-sato/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\nUse `ucs_spinlock` instead of `pthread_spinlock` for minimizing depndency.\r\nPlease see also #3928. This PR change UCS parts.\r\n\r\n## Why ?\r\n\r\nI want to minimize `ptread_spinlock` dependency because macOS doesn't have `pthread_spinlock`.\r\n","created_at":"2019-07-22T09:36:59Z","updated_at":"2019-07-22T09:40:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50f5de6e8a552c0f66672ecb63a0f95ffd204d25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/3931/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/3931/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/3931/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/5c265bafc0a0f57620d1180ec7c3c75a1dcc0704","head":{"label":"hiroyuki-sato:topic/use-ucs_spinlock","ref":"topic/use-ucs_spinlock","sha":"5c265bafc0a0f57620d1180ec7c3c75a1dcc0704","user":{"login":"hiroyuki-sato","id":767650,"node_id":"MDQ6VXNlcjc2NzY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/767650?v=4","gravatar_id":"","url":"https://api.github.com/users/hiroyuki-sato","html_url":"https://github.com/hiroyuki-sato","followers_url":"https://api.github.com/users/hiroyuki-sato/followers","following_url":"https://api.github.com/users/hiroyuki-sato/following{/other_user}","gists_url":"https://api.github.com/users/hiroyuki-sato/gists{/gist_id}","starred_url":"https://api.github.com/users/hiroyuki-sato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiroyuki-sato/subscriptions","organizations_url":"https://api.github.com/users/hiroyuki-sato/orgs","repos_url":"https://api.github.com/users/hiroyuki-sato/repos","events_url":"https://api.github.com/users/hiroyuki-sato/events{/privacy}","received_events_url":"https://api.github.com/users/hiroyuki-sato/received_events","type":"User","site_admin":false},"repo":{"id":177105194,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcxMDUxOTQ=","name":"ucx","full_name":"hiroyuki-sato/ucx","private":false,"owner":{"login":"hiroyuki-sato","id":767650,"node_id":"MDQ6VXNlcjc2NzY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/767650?v=4","gravatar_id":"","url":"https://api.github.com/users/hiroyuki-sato","html_url":"https://github.com/hiroyuki-sato","followers_url":"https://api.github.com/users/hiroyuki-sato/followers","following_url":"https://api.github.com/users/hiroyuki-sato/following{/other_user}","gists_url":"https://api.github.com/users/hiroyuki-sato/gists{/gist_id}","starred_url":"https://api.github.com/users/hiroyuki-sato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiroyuki-sato/subscriptions","organizations_url":"https://api.github.com/users/hiroyuki-sato/orgs","repos_url":"https://api.github.com/users/hiroyuki-sato/repos","events_url":"https://api.github.com/users/hiroyuki-sato/events{/privacy}","received_events_url":"https://api.github.com/users/hiroyuki-sato/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hiroyuki-sato/ucx","description":"Unified Communication X (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/hiroyuki-sato/ucx","forks_url":"https://api.github.com/repos/hiroyuki-sato/ucx/forks","keys_url":"https://api.github.com/repos/hiroyuki-sato/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiroyuki-sato/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiroyuki-sato/ucx/teams","hooks_url":"https://api.github.com/repos/hiroyuki-sato/ucx/hooks","issue_events_url":"https://api.github.com/repos/hiroyuki-sato/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/hiroyuki-sato/ucx/events","assignees_url":"https://api.github.com/repos/hiroyuki-sato/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/hiroyuki-sato/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/hiroyuki-sato/ucx/tags","blobs_url":"https://api.github.com/repos/hiroyuki-sato/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiroyuki-sato/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiroyuki-sato/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiroyuki-sato/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiroyuki-sato/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/hiroyuki-sato/ucx/languages","stargazers_url":"https://api.github.com/repos/hiroyuki-sato/ucx/stargazers","contributors_url":"https://api.github.com/repos/hiroyuki-sato/ucx/contributors","subscribers_url":"https://api.github.com/repos/hiroyuki-sato/ucx/subscribers","subscription_url":"https://api.github.com/repos/hiroyuki-sato/ucx/subscription","commits_url":"https://api.github.com/repos/hiroyuki-sato/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiroyuki-sato/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiroyuki-sato/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiroyuki-sato/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiroyuki-sato/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/hiroyuki-sato/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiroyuki-sato/ucx/merges","archive_url":"https://api.github.com/repos/hiroyuki-sato/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiroyuki-sato/ucx/downloads","issues_url":"https://api.github.com/repos/hiroyuki-sato/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/hiroyuki-sato/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/hiroyuki-sato/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/hiroyuki-sato/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiroyuki-sato/ucx/labels{/name}","releases_url":"https://api.github.com/repos/hiroyuki-sato/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/hiroyuki-sato/ucx/deployments","created_at":"2019-03-22T08:53:46Z","updated_at":"2019-07-18T14:01:03Z","pushed_at":"2019-07-22T09:33:52Z","git_url":"git://github.com/hiroyuki-sato/ucx.git","ssh_url":"git@github.com:hiroyuki-sato/ucx.git","clone_url":"https://github.com/hiroyuki-sato/ucx.git","svn_url":"https://github.com/hiroyuki-sato/ucx","homepage":"http://www.openucx.org","size":20103,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"c303724fd7bc85ef9609f92c1b5cd575b6a1e1f4","user":{"login":"openucx","id":13118737,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE4NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"node_id":"MDEwOlJlcG9zaXRvcnkyNTM3OTM5MA==","name":"ucx","full_name":"openucx/ucx","private":false,"owner":{"login":"openucx","id":13118737,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE4NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2019-07-21T17:16:28Z","pushed_at":"2019-07-22T09:37:00Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":21297,"stargazers_count":218,"watchers_count":218,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":109,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":213,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":109,"open_issues":213,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3931"},"html":{"href":"https://github.com/openucx/ucx/pull/3931"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/3931"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/3931/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3931/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3931/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/5c265bafc0a0f57620d1180ec7c3c75a1dcc0704"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 25379390,
"name": "openucx/ucx",
"url": "https://api.github.com/repos/openucx/ucx"
}
|
{
"id": 11650339,
"login": "dmitrygx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11650339?",
"url": "https://api.github.com/users/dmitrygx"
}
|
{
"id": 13118737,
"login": "openucx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13118737?",
"url": "https://api.github.com/orgs/openucx"
}
| 2019-07-22T09:39:06 |
10056667478
|
{"actor":{"display_login":"dmitrygx"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/comments/268392079","pull_request_review_id":218036557,"id":268392079,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODM5MjA3OQ==","diff_hunk":"@@ -283,7 +283,7 @@ public static function addUrlToken($sToken = \"\", $sURL = \"\") {\n */\r\n public static function doFilter($Content) {\r\n $result = I::getInstance()->doFilter($Content);\r\n- I::$oInstance = NULL;\r\n+ #I::$oInstance = NULL;\r\n return $result;\r","path":"wbce/framework/I.php","position":6,"original_position":6,"commit_id":"a2ee5bf590f4654ffa730a33eeb4a93e4dd4d956","original_commit_id":"a2ee5bf590f4654ffa730a33eeb4a93e4dd4d956","user":{"login":"WebDesignWorx","id":9767034,"node_id":"MDQ6VXNlcjk3NjcwMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9767034?v=4","gravatar_id":"","url":"https://api.github.com/users/WebDesignWorx","html_url":"https://github.com/WebDesignWorx","followers_url":"https://api.github.com/users/WebDesignWorx/followers","following_url":"https://api.github.com/users/WebDesignWorx/following{/other_user}","gists_url":"https://api.github.com/users/WebDesignWorx/gists{/gist_id}","starred_url":"https://api.github.com/users/WebDesignWorx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebDesignWorx/subscriptions","organizations_url":"https://api.github.com/users/WebDesignWorx/orgs","repos_url":"https://api.github.com/users/WebDesignWorx/repos","events_url":"https://api.github.com/users/WebDesignWorx/events{/privacy}","received_events_url":"https://api.github.com/users/WebDesignWorx/received_events","type":"User","site_admin":false},"body":"You're absolutely right, Martin.","created_at":"2019-03-23T11:51:03Z","updated_at":"2019-03-23T11:51:03Z","html_url":"https://github.com/WBCE/WBCE_CMS/pull/400#discussion_r268392079","pull_request_url":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/400","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/comments/268392079"},"html":{"href":"https://github.com/WBCE/WBCE_CMS/pull/400#discussion_r268392079"},"pull_request":{"href":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/400"}},"in_reply_to_id":268391585},"pull_request":{"url":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/400","id":263826094,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzODI2MDk0","html_url":"https://github.com/WBCE/WBCE_CMS/pull/400","diff_url":"https://github.com/WBCE/WBCE_CMS/pull/400.diff","patch_url":"https://github.com/WBCE/WBCE_CMS/pull/400.patch","issue_url":"https://api.github.com/repos/WBCE/WBCE_CMS/issues/400","number":400,"state":"open","locked":false,"title":"New Colorbox plugin & Insert class enhancements","user":{"login":"WebDesignWorx","id":9767034,"node_id":"MDQ6VXNlcjk3NjcwMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9767034?v=4","gravatar_id":"","url":"https://api.github.com/users/WebDesignWorx","html_url":"https://github.com/WebDesignWorx","followers_url":"https://api.github.com/users/WebDesignWorx/followers","following_url":"https://api.github.com/users/WebDesignWorx/following{/other_user}","gists_url":"https://api.github.com/users/WebDesignWorx/gists{/gist_id}","starred_url":"https://api.github.com/users/WebDesignWorx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebDesignWorx/subscriptions","organizations_url":"https://api.github.com/users/WebDesignWorx/orgs","repos_url":"https://api.github.com/users/WebDesignWorx/repos","events_url":"https://api.github.com/users/WebDesignWorx/events{/privacy}","received_events_url":"https://api.github.com/users/WebDesignWorx/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-23T11:13:17Z","updated_at":"2019-03-23T11:51:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdd849abf04249c840eb2357feed5e4028e3505c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/400/commits","review_comments_url":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/400/comments","review_comment_url":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WBCE/WBCE_CMS/issues/400/comments","statuses_url":"https://api.github.com/repos/WBCE/WBCE_CMS/statuses/a2ee5bf590f4654ffa730a33eeb4a93e4dd4d956","head":{"label":"WebDesignWorx:master","ref":"master","sha":"a2ee5bf590f4654ffa730a33eeb4a93e4dd4d956","user":{"login":"WebDesignWorx","id":9767034,"node_id":"MDQ6VXNlcjk3NjcwMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9767034?v=4","gravatar_id":"","url":"https://api.github.com/users/WebDesignWorx","html_url":"https://github.com/WebDesignWorx","followers_url":"https://api.github.com/users/WebDesignWorx/followers","following_url":"https://api.github.com/users/WebDesignWorx/following{/other_user}","gists_url":"https://api.github.com/users/WebDesignWorx/gists{/gist_id}","starred_url":"https://api.github.com/users/WebDesignWorx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebDesignWorx/subscriptions","organizations_url":"https://api.github.com/users/WebDesignWorx/orgs","repos_url":"https://api.github.com/users/WebDesignWorx/repos","events_url":"https://api.github.com/users/WebDesignWorx/events{/privacy}","received_events_url":"https://api.github.com/users/WebDesignWorx/received_events","type":"User","site_admin":false},"repo":{"id":177272212,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcyNzIyMTI=","name":"WBCE_CMS","full_name":"WebDesignWorx/WBCE_CMS","private":false,"owner":{"login":"WebDesignWorx","id":9767034,"node_id":"MDQ6VXNlcjk3NjcwMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9767034?v=4","gravatar_id":"","url":"https://api.github.com/users/WebDesignWorx","html_url":"https://github.com/WebDesignWorx","followers_url":"https://api.github.com/users/WebDesignWorx/followers","following_url":"https://api.github.com/users/WebDesignWorx/following{/other_user}","gists_url":"https://api.github.com/users/WebDesignWorx/gists{/gist_id}","starred_url":"https://api.github.com/users/WebDesignWorx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebDesignWorx/subscriptions","organizations_url":"https://api.github.com/users/WebDesignWorx/orgs","repos_url":"https://api.github.com/users/WebDesignWorx/repos","events_url":"https://api.github.com/users/WebDesignWorx/events{/privacy}","received_events_url":"https://api.github.com/users/WebDesignWorx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/WebDesignWorx/WBCE_CMS","description":"Core package of WBCE CMS. This package includes the core and the default addons. Visit https://wbce.org (DE) or https://wbce-cms.org (EN) to learn more or to join the WBCE CMS community. ","fork":true,"url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS","forks_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/forks","keys_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/teams","hooks_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/hooks","issue_events_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/issues/events{/number}","events_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/events","assignees_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/assignees{/user}","branches_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/branches{/branch}","tags_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/tags","blobs_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/languages","stargazers_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/stargazers","contributors_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/contributors","subscribers_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/subscribers","subscription_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/subscription","commits_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/contents/{+path}","compare_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/merges","archive_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/downloads","issues_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/issues{/number}","pulls_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/labels{/name}","releases_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/releases{/id}","deployments_url":"https://api.github.com/repos/WebDesignWorx/WBCE_CMS/deployments","created_at":"2019-03-23T09:56:26Z","updated_at":"2019-03-23T11:12:11Z","pushed_at":"2019-03-23T11:12:09Z","git_url":"git://github.com/WebDesignWorx/WBCE_CMS.git","ssh_url":"git@github.com:WebDesignWorx/WBCE_CMS.git","clone_url":"https://github.com/WebDesignWorx/WBCE_CMS.git","svn_url":"https://github.com/WebDesignWorx/WBCE_CMS","homepage":"https://wbce-cms.org","size":23718,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WBCE:master","ref":"master","sha":"537fb829b7979929c577da01ebd288a62760cf62","user":{"login":"WBCE","id":13151813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUxODEz","avatar_url":"https://avatars3.githubusercontent.com/u/13151813?v=4","gravatar_id":"","url":"https://api.github.com/users/WBCE","html_url":"https://github.com/WBCE","followers_url":"https://api.github.com/users/WBCE/followers","following_url":"https://api.github.com/users/WBCE/following{/other_user}","gists_url":"https://api.github.com/users/WBCE/gists{/gist_id}","starred_url":"https://api.github.com/users/WBCE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WBCE/subscriptions","organizations_url":"https://api.github.com/users/WBCE/orgs","repos_url":"https://api.github.com/users/WBCE/repos","events_url":"https://api.github.com/users/WBCE/events{/privacy}","received_events_url":"https://api.github.com/users/WBCE/received_events","type":"Organization","site_admin":false},"repo":{"id":38242821,"node_id":"MDEwOlJlcG9zaXRvcnkzODI0MjgyMQ==","name":"WBCE_CMS","full_name":"WBCE/WBCE_CMS","private":false,"owner":{"login":"WBCE","id":13151813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUxODEz","avatar_url":"https://avatars3.githubusercontent.com/u/13151813?v=4","gravatar_id":"","url":"https://api.github.com/users/WBCE","html_url":"https://github.com/WBCE","followers_url":"https://api.github.com/users/WBCE/followers","following_url":"https://api.github.com/users/WBCE/following{/other_user}","gists_url":"https://api.github.com/users/WBCE/gists{/gist_id}","starred_url":"https://api.github.com/users/WBCE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WBCE/subscriptions","organizations_url":"https://api.github.com/users/WBCE/orgs","repos_url":"https://api.github.com/users/WBCE/repos","events_url":"https://api.github.com/users/WBCE/events{/privacy}","received_events_url":"https://api.github.com/users/WBCE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WBCE/WBCE_CMS","description":"Core package of WBCE CMS. This package includes the core and the default addons. Visit https://wbce.org (DE) or https://wbce-cms.org (EN) to learn more or to join the WBCE CMS community. ","fork":false,"url":"https://api.github.com/repos/WBCE/WBCE_CMS","forks_url":"https://api.github.com/repos/WBCE/WBCE_CMS/forks","keys_url":"https://api.github.com/repos/WBCE/WBCE_CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WBCE/WBCE_CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WBCE/WBCE_CMS/teams","hooks_url":"https://api.github.com/repos/WBCE/WBCE_CMS/hooks","issue_events_url":"https://api.github.com/repos/WBCE/WBCE_CMS/issues/events{/number}","events_url":"https://api.github.com/repos/WBCE/WBCE_CMS/events","assignees_url":"https://api.github.com/repos/WBCE/WBCE_CMS/assignees{/user}","branches_url":"https://api.github.com/repos/WBCE/WBCE_CMS/branches{/branch}","tags_url":"https://api.github.com/repos/WBCE/WBCE_CMS/tags","blobs_url":"https://api.github.com/repos/WBCE/WBCE_CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WBCE/WBCE_CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WBCE/WBCE_CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/WBCE/WBCE_CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WBCE/WBCE_CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/WBCE/WBCE_CMS/languages","stargazers_url":"https://api.github.com/repos/WBCE/WBCE_CMS/stargazers","contributors_url":"https://api.github.com/repos/WBCE/WBCE_CMS/contributors","subscribers_url":"https://api.github.com/repos/WBCE/WBCE_CMS/subscribers","subscription_url":"https://api.github.com/repos/WBCE/WBCE_CMS/subscription","commits_url":"https://api.github.com/repos/WBCE/WBCE_CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/WBCE/WBCE_CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/WBCE/WBCE_CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/WBCE/WBCE_CMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/WBCE/WBCE_CMS/contents/{+path}","compare_url":"https://api.github.com/repos/WBCE/WBCE_CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WBCE/WBCE_CMS/merges","archive_url":"https://api.github.com/repos/WBCE/WBCE_CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WBCE/WBCE_CMS/downloads","issues_url":"https://api.github.com/repos/WBCE/WBCE_CMS/issues{/number}","pulls_url":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/WBCE/WBCE_CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/WBCE/WBCE_CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WBCE/WBCE_CMS/labels{/name}","releases_url":"https://api.github.com/repos/WBCE/WBCE_CMS/releases{/id}","deployments_url":"https://api.github.com/repos/WBCE/WBCE_CMS/deployments","created_at":"2015-06-29T10:51:58Z","updated_at":"2019-03-22T20:29:16Z","pushed_at":"2019-03-23T11:13:18Z","git_url":"git://github.com/WBCE/WBCE_CMS.git","ssh_url":"git@github.com:WBCE/WBCE_CMS.git","clone_url":"https://github.com/WBCE/WBCE_CMS.git","svn_url":"https://github.com/WBCE/WBCE_CMS","homepage":"https://wbce-cms.org","size":23718,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":11,"open_issues":5,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/400"},"html":{"href":"https://github.com/WBCE/WBCE_CMS/pull/400"},"issue":{"href":"https://api.github.com/repos/WBCE/WBCE_CMS/issues/400"},"comments":{"href":"https://api.github.com/repos/WBCE/WBCE_CMS/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WBCE/WBCE_CMS/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/WBCE/WBCE_CMS/statuses/a2ee5bf590f4654ffa730a33eeb4a93e4dd4d956"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 38242821,
"name": "WBCE/WBCE_CMS",
"url": "https://api.github.com/repos/WBCE/WBCE_CMS"
}
|
{
"id": 9767034,
"login": "WebDesignWorx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9767034?",
"url": "https://api.github.com/users/WebDesignWorx"
}
|
{
"id": 13151813,
"login": "WBCE",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13151813?",
"url": "https://api.github.com/orgs/WBCE"
}
| 2019-03-23T11:51:03 |
9300223327
|
{"actor":{"display_login":"WebDesignWorx"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/linkchecker/linkchecker/pulls/comments/329727858","pull_request_review_id":295173321,"id":329727858,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTcyNzg1OA==","diff_hunk":"@@ -131,9 +131,9 @@ def test_norm_quote (self):\n url = \"http://example.com/?u=http://example2.com?b=\"\n nurl = \"http://example.com/?u=http://example2.com?b=\"\n self.urlnormtest(url, nurl)\n- url = \"http://localhost:8001/?quoted=�\"\n- nurl = \"http://localhost:8001/?quoted=%FC\"\n- self.urlnormtest(url, nurl, encoding=\"iso-8859-1\")\n+ url = b\"http://localhost:8001/?quoted=\\xfc\".decode(\"iso-8859-1\")\n+ nurl = \"http://localhost:8001/?quoted=%C3%BC\"\n+ self.urlnormtest(url, nurl)","path":"tests/test_url.py","position":9,"original_position":9,"commit_id":"0d52f8ee48dc3c92e63b6b17faf78cf3a7e915b1","original_commit_id":"0d52f8ee48dc3c92e63b6b17faf78cf3a7e915b1","user":{"login":"cjmayo","id":921089,"node_id":"MDQ6VXNlcjkyMTA4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/921089?v=4","gravatar_id":"","url":"https://api.github.com/users/cjmayo","html_url":"https://github.com/cjmayo","followers_url":"https://api.github.com/users/cjmayo/followers","following_url":"https://api.github.com/users/cjmayo/following{/other_user}","gists_url":"https://api.github.com/users/cjmayo/gists{/gist_id}","starred_url":"https://api.github.com/users/cjmayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjmayo/subscriptions","organizations_url":"https://api.github.com/users/cjmayo/orgs","repos_url":"https://api.github.com/users/cjmayo/repos","events_url":"https://api.github.com/users/cjmayo/events{/privacy}","received_events_url":"https://api.github.com/users/cjmayo/received_events","type":"User","site_admin":false},"body":"It's a good policy not to break the existing tests. I hadn't understood quite what the quoting was about - thanks for the insight.","created_at":"2019-09-30T18:39:28Z","updated_at":"2019-09-30T18:39:28Z","html_url":"https://github.com/linkchecker/linkchecker/pull/309#discussion_r329727858","pull_request_url":"https://api.github.com/repos/linkchecker/linkchecker/pulls/309","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkchecker/linkchecker/pulls/comments/329727858"},"html":{"href":"https://github.com/linkchecker/linkchecker/pull/309#discussion_r329727858"},"pull_request":{"href":"https://api.github.com/repos/linkchecker/linkchecker/pulls/309"}},"in_reply_to_id":329208302},"pull_request":{"url":"https://api.github.com/repos/linkchecker/linkchecker/pulls/309","id":322277833,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyMjc3ODMz","html_url":"https://github.com/linkchecker/linkchecker/pull/309","diff_url":"https://github.com/linkchecker/linkchecker/pull/309.diff","patch_url":"https://github.com/linkchecker/linkchecker/pull/309.patch","issue_url":"https://api.github.com/repos/linkchecker/linkchecker/issues/309","number":309,"state":"open","locked":false,"title":"{python3_51_alt} Change TestUrl.test_norm_quote() to use UTF-8","user":{"login":"cjmayo","id":921089,"node_id":"MDQ6VXNlcjkyMTA4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/921089?v=4","gravatar_id":"","url":"https://api.github.com/users/cjmayo","html_url":"https://github.com/cjmayo","followers_url":"https://api.github.com/users/cjmayo/followers","following_url":"https://api.github.com/users/cjmayo/following{/other_user}","gists_url":"https://api.github.com/users/cjmayo/gists{/gist_id}","starred_url":"https://api.github.com/users/cjmayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjmayo/subscriptions","organizations_url":"https://api.github.com/users/cjmayo/orgs","repos_url":"https://api.github.com/users/cjmayo/repos","events_url":"https://api.github.com/users/cjmayo/events{/privacy}","received_events_url":"https://api.github.com/users/cjmayo/received_events","type":"User","site_admin":false},"body":"Latin 1 input will have now been converted to UTF-8 by the checker.\r\n\r\n---\r\n\r\nThis merges on top of #308 and replaces #296.\r\n","created_at":"2019-09-27T18:28:24Z","updated_at":"2019-09-30T18:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcbbb404a9af187fbdd9e93e88f7be7144b69db5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkchecker/linkchecker/pulls/309/commits","review_comments_url":"https://api.github.com/repos/linkchecker/linkchecker/pulls/309/comments","review_comment_url":"https://api.github.com/repos/linkchecker/linkchecker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkchecker/linkchecker/issues/309/comments","statuses_url":"https://api.github.com/repos/linkchecker/linkchecker/statuses/0d52f8ee48dc3c92e63b6b17faf78cf3a7e915b1","head":{"label":"cjmayo:python3_51_alt","ref":"python3_51_alt","sha":"0d52f8ee48dc3c92e63b6b17faf78cf3a7e915b1","user":{"login":"cjmayo","id":921089,"node_id":"MDQ6VXNlcjkyMTA4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/921089?v=4","gravatar_id":"","url":"https://api.github.com/users/cjmayo","html_url":"https://github.com/cjmayo","followers_url":"https://api.github.com/users/cjmayo/followers","following_url":"https://api.github.com/users/cjmayo/following{/other_user}","gists_url":"https://api.github.com/users/cjmayo/gists{/gist_id}","starred_url":"https://api.github.com/users/cjmayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjmayo/subscriptions","organizations_url":"https://api.github.com/users/cjmayo/orgs","repos_url":"https://api.github.com/users/cjmayo/repos","events_url":"https://api.github.com/users/cjmayo/events{/privacy}","received_events_url":"https://api.github.com/users/cjmayo/received_events","type":"User","site_admin":false},"repo":{"id":180206369,"node_id":"MDEwOlJlcG9zaXRvcnkxODAyMDYzNjk=","name":"linkchecker","full_name":"cjmayo/linkchecker","private":false,"owner":{"login":"cjmayo","id":921089,"node_id":"MDQ6VXNlcjkyMTA4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/921089?v=4","gravatar_id":"","url":"https://api.github.com/users/cjmayo","html_url":"https://github.com/cjmayo","followers_url":"https://api.github.com/users/cjmayo/followers","following_url":"https://api.github.com/users/cjmayo/following{/other_user}","gists_url":"https://api.github.com/users/cjmayo/gists{/gist_id}","starred_url":"https://api.github.com/users/cjmayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjmayo/subscriptions","organizations_url":"https://api.github.com/users/cjmayo/orgs","repos_url":"https://api.github.com/users/cjmayo/repos","events_url":"https://api.github.com/users/cjmayo/events{/privacy}","received_events_url":"https://api.github.com/users/cjmayo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cjmayo/linkchecker","description":" check links in web documents or full websites","fork":true,"url":"https://api.github.com/repos/cjmayo/linkchecker","forks_url":"https://api.github.com/repos/cjmayo/linkchecker/forks","keys_url":"https://api.github.com/repos/cjmayo/linkchecker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjmayo/linkchecker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjmayo/linkchecker/teams","hooks_url":"https://api.github.com/repos/cjmayo/linkchecker/hooks","issue_events_url":"https://api.github.com/repos/cjmayo/linkchecker/issues/events{/number}","events_url":"https://api.github.com/repos/cjmayo/linkchecker/events","assignees_url":"https://api.github.com/repos/cjmayo/linkchecker/assignees{/user}","branches_url":"https://api.github.com/repos/cjmayo/linkchecker/branches{/branch}","tags_url":"https://api.github.com/repos/cjmayo/linkchecker/tags","blobs_url":"https://api.github.com/repos/cjmayo/linkchecker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjmayo/linkchecker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjmayo/linkchecker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjmayo/linkchecker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjmayo/linkchecker/statuses/{sha}","languages_url":"https://api.github.com/repos/cjmayo/linkchecker/languages","stargazers_url":"https://api.github.com/repos/cjmayo/linkchecker/stargazers","contributors_url":"https://api.github.com/repos/cjmayo/linkchecker/contributors","subscribers_url":"https://api.github.com/repos/cjmayo/linkchecker/subscribers","subscription_url":"https://api.github.com/repos/cjmayo/linkchecker/subscription","commits_url":"https://api.github.com/repos/cjmayo/linkchecker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjmayo/linkchecker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjmayo/linkchecker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjmayo/linkchecker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjmayo/linkchecker/contents/{+path}","compare_url":"https://api.github.com/repos/cjmayo/linkchecker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjmayo/linkchecker/merges","archive_url":"https://api.github.com/repos/cjmayo/linkchecker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjmayo/linkchecker/downloads","issues_url":"https://api.github.com/repos/cjmayo/linkchecker/issues{/number}","pulls_url":"https://api.github.com/repos/cjmayo/linkchecker/pulls{/number}","milestones_url":"https://api.github.com/repos/cjmayo/linkchecker/milestones{/number}","notifications_url":"https://api.github.com/repos/cjmayo/linkchecker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjmayo/linkchecker/labels{/name}","releases_url":"https://api.github.com/repos/cjmayo/linkchecker/releases{/id}","deployments_url":"https://api.github.com/repos/cjmayo/linkchecker/deployments","created_at":"2019-04-08T18:10:44Z","updated_at":"2019-04-08T18:10:48Z","pushed_at":"2019-09-27T18:26:39Z","git_url":"git://github.com/cjmayo/linkchecker.git","ssh_url":"git@github.com:cjmayo/linkchecker.git","clone_url":"https://github.com/cjmayo/linkchecker.git","svn_url":"https://github.com/cjmayo/linkchecker","homepage":"https://linkcheck.github.io/linkchecker/","size":67532,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkchecker:master","ref":"master","sha":"bae4282c92036724e5e5a931d8257652ddbd15f0","user":{"login":"linkchecker","id":13207335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjA3MzM1","avatar_url":"https://avatars1.githubusercontent.com/u/13207335?v=4","gravatar_id":"","url":"https://api.github.com/users/linkchecker","html_url":"https://github.com/linkchecker","followers_url":"https://api.github.com/users/linkchecker/followers","following_url":"https://api.github.com/users/linkchecker/following{/other_user}","gists_url":"https://api.github.com/users/linkchecker/gists{/gist_id}","starred_url":"https://api.github.com/users/linkchecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkchecker/subscriptions","organizations_url":"https://api.github.com/users/linkchecker/orgs","repos_url":"https://api.github.com/users/linkchecker/repos","events_url":"https://api.github.com/users/linkchecker/events{/privacy}","received_events_url":"https://api.github.com/users/linkchecker/received_events","type":"Organization","site_admin":false},"repo":{"id":80534589,"node_id":"MDEwOlJlcG9zaXRvcnk4MDUzNDU4OQ==","name":"linkchecker","full_name":"linkchecker/linkchecker","private":false,"owner":{"login":"linkchecker","id":13207335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjA3MzM1","avatar_url":"https://avatars1.githubusercontent.com/u/13207335?v=4","gravatar_id":"","url":"https://api.github.com/users/linkchecker","html_url":"https://github.com/linkchecker","followers_url":"https://api.github.com/users/linkchecker/followers","following_url":"https://api.github.com/users/linkchecker/following{/other_user}","gists_url":"https://api.github.com/users/linkchecker/gists{/gist_id}","starred_url":"https://api.github.com/users/linkchecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkchecker/subscriptions","organizations_url":"https://api.github.com/users/linkchecker/orgs","repos_url":"https://api.github.com/users/linkchecker/repos","events_url":"https://api.github.com/users/linkchecker/events{/privacy}","received_events_url":"https://api.github.com/users/linkchecker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkchecker/linkchecker","description":" check links in web documents or full websites","fork":false,"url":"https://api.github.com/repos/linkchecker/linkchecker","forks_url":"https://api.github.com/repos/linkchecker/linkchecker/forks","keys_url":"https://api.github.com/repos/linkchecker/linkchecker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkchecker/linkchecker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkchecker/linkchecker/teams","hooks_url":"https://api.github.com/repos/linkchecker/linkchecker/hooks","issue_events_url":"https://api.github.com/repos/linkchecker/linkchecker/issues/events{/number}","events_url":"https://api.github.com/repos/linkchecker/linkchecker/events","assignees_url":"https://api.github.com/repos/linkchecker/linkchecker/assignees{/user}","branches_url":"https://api.github.com/repos/linkchecker/linkchecker/branches{/branch}","tags_url":"https://api.github.com/repos/linkchecker/linkchecker/tags","blobs_url":"https://api.github.com/repos/linkchecker/linkchecker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkchecker/linkchecker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkchecker/linkchecker/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkchecker/linkchecker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkchecker/linkchecker/statuses/{sha}","languages_url":"https://api.github.com/repos/linkchecker/linkchecker/languages","stargazers_url":"https://api.github.com/repos/linkchecker/linkchecker/stargazers","contributors_url":"https://api.github.com/repos/linkchecker/linkchecker/contributors","subscribers_url":"https://api.github.com/repos/linkchecker/linkchecker/subscribers","subscription_url":"https://api.github.com/repos/linkchecker/linkchecker/subscription","commits_url":"https://api.github.com/repos/linkchecker/linkchecker/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkchecker/linkchecker/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkchecker/linkchecker/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkchecker/linkchecker/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkchecker/linkchecker/contents/{+path}","compare_url":"https://api.github.com/repos/linkchecker/linkchecker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkchecker/linkchecker/merges","archive_url":"https://api.github.com/repos/linkchecker/linkchecker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkchecker/linkchecker/downloads","issues_url":"https://api.github.com/repos/linkchecker/linkchecker/issues{/number}","pulls_url":"https://api.github.com/repos/linkchecker/linkchecker/pulls{/number}","milestones_url":"https://api.github.com/repos/linkchecker/linkchecker/milestones{/number}","notifications_url":"https://api.github.com/repos/linkchecker/linkchecker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkchecker/linkchecker/labels{/name}","releases_url":"https://api.github.com/repos/linkchecker/linkchecker/releases{/id}","deployments_url":"https://api.github.com/repos/linkchecker/linkchecker/deployments","created_at":"2017-01-31T15:46:03Z","updated_at":"2019-09-25T16:56:10Z","pushed_at":"2019-09-27T18:28:25Z","git_url":"git://github.com/linkchecker/linkchecker.git","ssh_url":"git@github.com:linkchecker/linkchecker.git","clone_url":"https://github.com/linkchecker/linkchecker.git","svn_url":"https://github.com/linkchecker/linkchecker","homepage":"https://linkcheck.github.io/linkchecker/","size":67442,"stargazers_count":221,"watchers_count":221,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":100,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":64,"open_issues":100,"watchers":221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkchecker/linkchecker/pulls/309"},"html":{"href":"https://github.com/linkchecker/linkchecker/pull/309"},"issue":{"href":"https://api.github.com/repos/linkchecker/linkchecker/issues/309"},"comments":{"href":"https://api.github.com/repos/linkchecker/linkchecker/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/linkchecker/linkchecker/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/linkchecker/linkchecker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkchecker/linkchecker/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/linkchecker/linkchecker/statuses/0d52f8ee48dc3c92e63b6b17faf78cf3a7e915b1"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 80534589,
"name": "linkchecker/linkchecker",
"url": "https://api.github.com/repos/linkchecker/linkchecker"
}
|
{
"id": 921089,
"login": "cjmayo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/921089?",
"url": "https://api.github.com/users/cjmayo"
}
|
{
"id": 13207335,
"login": "linkchecker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13207335?",
"url": "https://api.github.com/orgs/linkchecker"
}
| 2019-09-30T18:39:28 |
10527148388
|
{"actor":{"display_login":"cjmayo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cloudwan/gohan/pulls/comments/312396736","pull_request_review_id":273023650,"id":312396736,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjM5NjczNg==","diff_hunk":"@@ -458,25 +464,38 @@ func (schema *Schema) DbStateUpdateRaw(rawResource interface{}, requestContext g\n \n // DeleteRaw deletes resource by ID\n func (schema *Schema) DeleteRaw(id string, context goext.Context) error {\n-\treturn schema.delete(goext.Filter{\"id\": id}, context, true)\n+\treturn schema.delete(goext.Filter{\"id\": id}, context)\n }\n \n // DeleteFilterRaw deletes resource by filter\n func (schema *Schema) DeleteFilterRaw(filter goext.Filter, context goext.Context) error {\n-\treturn schema.delete(filter, context, true)\n+\treturn schema.delete(filter, context)\n }\n \n // DbDeleteRaw deletes resource by ID without triggering events\n func (schema *Schema) DbDeleteRaw(id string, context goext.Context) error {\n-\treturn schema.delete(goext.Filter{\"id\": id}, context, false)\n+\treturn schema.dbDeleteFilter(goext.Filter{\"id\": id}, context)\n }\n \n // DbDeleteFilterRaw deletes resource by filter without triggering events\n func (schema *Schema) DbDeleteFilterRaw(filter goext.Filter, context goext.Context) error {\n-\treturn schema.delete(filter, context, false)\n+\treturn schema.dbDeleteFilter(filter, context)\n+}\n+\n+func (schema *Schema) dbDeleteFilter(filter goext.Filter, ctx goext.Context) error {","path":"extension/goplugin/schemas.go","position":39,"original_position":39,"commit_id":"f2053e0e0df66b9111d05f6227a8e2ec7cab0cb2","original_commit_id":"f2053e0e0df66b9111d05f6227a8e2ec7cab0cb2","user":{"login":"tomasz-michalski","id":42138403,"node_id":"MDQ6VXNlcjQyMTM4NDAz","avatar_url":"https://avatars3.githubusercontent.com/u/42138403?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasz-michalski","html_url":"https://github.com/tomasz-michalski","followers_url":"https://api.github.com/users/tomasz-michalski/followers","following_url":"https://api.github.com/users/tomasz-michalski/following{/other_user}","gists_url":"https://api.github.com/users/tomasz-michalski/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasz-michalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasz-michalski/subscriptions","organizations_url":"https://api.github.com/users/tomasz-michalski/orgs","repos_url":"https://api.github.com/users/tomasz-michalski/repos","events_url":"https://api.github.com/users/tomasz-michalski/events{/privacy}","received_events_url":"https://api.github.com/users/tomasz-michalski/received_events","type":"User","site_admin":false},"body":"Please rename `dbDeleteFilter` to `dbDelete` or rename `delete` to `deleteFilter`, because now these names are inconsistent.","created_at":"2019-08-09T09:20:12Z","updated_at":"2019-08-09T09:46:56Z","html_url":"https://github.com/cloudwan/gohan/pull/760#discussion_r312396736","pull_request_url":"https://api.github.com/repos/cloudwan/gohan/pulls/760","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/comments/312396736"},"html":{"href":"https://github.com/cloudwan/gohan/pull/760#discussion_r312396736"},"pull_request":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/760"}}},"pull_request":{"url":"https://api.github.com/repos/cloudwan/gohan/pulls/760","id":305615375,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1NjE1Mzc1","html_url":"https://github.com/cloudwan/gohan/pull/760","diff_url":"https://github.com/cloudwan/gohan/pull/760.diff","patch_url":"https://github.com/cloudwan/gohan/pull/760.patch","issue_url":"https://api.github.com/repos/cloudwan/gohan/issues/760","number":760,"state":"open","locked":false,"title":"[CW-1625] Added DeleteFilter to Tx interfaces","user":{"login":"zimnx","id":3951334,"node_id":"MDQ6VXNlcjM5NTEzMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3951334?v=4","gravatar_id":"","url":"https://api.github.com/users/zimnx","html_url":"https://github.com/zimnx","followers_url":"https://api.github.com/users/zimnx/followers","following_url":"https://api.github.com/users/zimnx/following{/other_user}","gists_url":"https://api.github.com/users/zimnx/gists{/gist_id}","starred_url":"https://api.github.com/users/zimnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimnx/subscriptions","organizations_url":"https://api.github.com/users/zimnx/orgs","repos_url":"https://api.github.com/users/zimnx/repos","events_url":"https://api.github.com/users/zimnx/events{/privacy}","received_events_url":"https://api.github.com/users/zimnx/received_events","type":"User","site_admin":false},"body":"- Added StateList to Tx interface\r\n- ResourceState contains information about ID of resource it points to\r\n- Added unit tests to transaction_event_logger\r\n- fixed failing test on SQLite","created_at":"2019-08-08T14:50:32Z","updated_at":"2019-08-09T09:46:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52f92264c0f5414ded6deb781782c308035464eb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kuba2","id":5136636,"node_id":"MDQ6VXNlcjUxMzY2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5136636?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba2","html_url":"https://github.com/kuba2","followers_url":"https://api.github.com/users/kuba2/followers","following_url":"https://api.github.com/users/kuba2/following{/other_user}","gists_url":"https://api.github.com/users/kuba2/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba2/subscriptions","organizations_url":"https://api.github.com/users/kuba2/orgs","repos_url":"https://api.github.com/users/kuba2/repos","events_url":"https://api.github.com/users/kuba2/events{/privacy}","received_events_url":"https://api.github.com/users/kuba2/received_events","type":"User","site_admin":false},{"login":"cierpuchaw","id":11045598,"node_id":"MDQ6VXNlcjExMDQ1NTk4","avatar_url":"https://avatars1.githubusercontent.com/u/11045598?v=4","gravatar_id":"","url":"https://api.github.com/users/cierpuchaw","html_url":"https://github.com/cierpuchaw","followers_url":"https://api.github.com/users/cierpuchaw/followers","following_url":"https://api.github.com/users/cierpuchaw/following{/other_user}","gists_url":"https://api.github.com/users/cierpuchaw/gists{/gist_id}","starred_url":"https://api.github.com/users/cierpuchaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cierpuchaw/subscriptions","organizations_url":"https://api.github.com/users/cierpuchaw/orgs","repos_url":"https://api.github.com/users/cierpuchaw/repos","events_url":"https://api.github.com/users/cierpuchaw/events{/privacy}","received_events_url":"https://api.github.com/users/cierpuchaw/received_events","type":"User","site_admin":false},{"login":"gryxon","id":11094671,"node_id":"MDQ6VXNlcjExMDk0Njcx","avatar_url":"https://avatars0.githubusercontent.com/u/11094671?v=4","gravatar_id":"","url":"https://api.github.com/users/gryxon","html_url":"https://github.com/gryxon","followers_url":"https://api.github.com/users/gryxon/followers","following_url":"https://api.github.com/users/gryxon/following{/other_user}","gists_url":"https://api.github.com/users/gryxon/gists{/gist_id}","starred_url":"https://api.github.com/users/gryxon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gryxon/subscriptions","organizations_url":"https://api.github.com/users/gryxon/orgs","repos_url":"https://api.github.com/users/gryxon/repos","events_url":"https://api.github.com/users/gryxon/events{/privacy}","received_events_url":"https://api.github.com/users/gryxon/received_events","type":"User","site_admin":false},{"login":"giyyanan","id":16669112,"node_id":"MDQ6VXNlcjE2NjY5MTEy","avatar_url":"https://avatars3.githubusercontent.com/u/16669112?v=4","gravatar_id":"","url":"https://api.github.com/users/giyyanan","html_url":"https://github.com/giyyanan","followers_url":"https://api.github.com/users/giyyanan/followers","following_url":"https://api.github.com/users/giyyanan/following{/other_user}","gists_url":"https://api.github.com/users/giyyanan/gists{/gist_id}","starred_url":"https://api.github.com/users/giyyanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giyyanan/subscriptions","organizations_url":"https://api.github.com/users/giyyanan/orgs","repos_url":"https://api.github.com/users/giyyanan/repos","events_url":"https://api.github.com/users/giyyanan/events{/privacy}","received_events_url":"https://api.github.com/users/giyyanan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudwan/gohan/pulls/760/commits","review_comments_url":"https://api.github.com/repos/cloudwan/gohan/pulls/760/comments","review_comment_url":"https://api.github.com/repos/cloudwan/gohan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudwan/gohan/issues/760/comments","statuses_url":"https://api.github.com/repos/cloudwan/gohan/statuses/f2053e0e0df66b9111d05f6227a8e2ec7cab0cb2","head":{"label":"cloudwan:CW-1625","ref":"CW-1625","sha":"f2053e0e0df66b9111d05f6227a8e2ec7cab0cb2","user":{"login":"cloudwan","id":13223939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjIzOTM5","avatar_url":"https://avatars2.githubusercontent.com/u/13223939?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudwan","html_url":"https://github.com/cloudwan","followers_url":"https://api.github.com/users/cloudwan/followers","following_url":"https://api.github.com/users/cloudwan/following{/other_user}","gists_url":"https://api.github.com/users/cloudwan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudwan/subscriptions","organizations_url":"https://api.github.com/users/cloudwan/orgs","repos_url":"https://api.github.com/users/cloudwan/repos","events_url":"https://api.github.com/users/cloudwan/events{/privacy}","received_events_url":"https://api.github.com/users/cloudwan/received_events","type":"Organization","site_admin":false},"repo":{"id":43838360,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgzODM2MA==","name":"gohan","full_name":"cloudwan/gohan","private":false,"owner":{"login":"cloudwan","id":13223939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjIzOTM5","avatar_url":"https://avatars2.githubusercontent.com/u/13223939?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudwan","html_url":"https://github.com/cloudwan","followers_url":"https://api.github.com/users/cloudwan/followers","following_url":"https://api.github.com/users/cloudwan/following{/other_user}","gists_url":"https://api.github.com/users/cloudwan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudwan/subscriptions","organizations_url":"https://api.github.com/users/cloudwan/orgs","repos_url":"https://api.github.com/users/cloudwan/repos","events_url":"https://api.github.com/users/cloudwan/events{/privacy}","received_events_url":"https://api.github.com/users/cloudwan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudwan/gohan","description":"Gohan is an API Gateway Server written by Go that makes it easy for developers to create and maintain REST-style API","fork":false,"url":"https://api.github.com/repos/cloudwan/gohan","forks_url":"https://api.github.com/repos/cloudwan/gohan/forks","keys_url":"https://api.github.com/repos/cloudwan/gohan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudwan/gohan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudwan/gohan/teams","hooks_url":"https://api.github.com/repos/cloudwan/gohan/hooks","issue_events_url":"https://api.github.com/repos/cloudwan/gohan/issues/events{/number}","events_url":"https://api.github.com/repos/cloudwan/gohan/events","assignees_url":"https://api.github.com/repos/cloudwan/gohan/assignees{/user}","branches_url":"https://api.github.com/repos/cloudwan/gohan/branches{/branch}","tags_url":"https://api.github.com/repos/cloudwan/gohan/tags","blobs_url":"https://api.github.com/repos/cloudwan/gohan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudwan/gohan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudwan/gohan/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudwan/gohan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudwan/gohan/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudwan/gohan/languages","stargazers_url":"https://api.github.com/repos/cloudwan/gohan/stargazers","contributors_url":"https://api.github.com/repos/cloudwan/gohan/contributors","subscribers_url":"https://api.github.com/repos/cloudwan/gohan/subscribers","subscription_url":"https://api.github.com/repos/cloudwan/gohan/subscription","commits_url":"https://api.github.com/repos/cloudwan/gohan/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudwan/gohan/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudwan/gohan/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudwan/gohan/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudwan/gohan/contents/{+path}","compare_url":"https://api.github.com/repos/cloudwan/gohan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudwan/gohan/merges","archive_url":"https://api.github.com/repos/cloudwan/gohan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudwan/gohan/downloads","issues_url":"https://api.github.com/repos/cloudwan/gohan/issues{/number}","pulls_url":"https://api.github.com/repos/cloudwan/gohan/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudwan/gohan/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudwan/gohan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudwan/gohan/labels{/name}","releases_url":"https://api.github.com/repos/cloudwan/gohan/releases{/id}","deployments_url":"https://api.github.com/repos/cloudwan/gohan/deployments","created_at":"2015-10-07T19:01:47Z","updated_at":"2019-07-25T14:46:36Z","pushed_at":"2019-08-08T16:38:04Z","git_url":"git://github.com/cloudwan/gohan.git","ssh_url":"git@github.com:cloudwan/gohan.git","clone_url":"https://github.com/cloudwan/gohan.git","svn_url":"https://github.com/cloudwan/gohan","homepage":"http://www.slideshare.net/natiueno/gohan-61170476","size":52741,"stargazers_count":101,"watchers_count":101,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":50,"open_issues":52,"watchers":101,"default_branch":"master"}},"base":{"label":"cloudwan:master","ref":"master","sha":"63ffd06d7f0fb065e0723375cf9a8fb9d98663c6","user":{"login":"cloudwan","id":13223939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjIzOTM5","avatar_url":"https://avatars2.githubusercontent.com/u/13223939?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudwan","html_url":"https://github.com/cloudwan","followers_url":"https://api.github.com/users/cloudwan/followers","following_url":"https://api.github.com/users/cloudwan/following{/other_user}","gists_url":"https://api.github.com/users/cloudwan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudwan/subscriptions","organizations_url":"https://api.github.com/users/cloudwan/orgs","repos_url":"https://api.github.com/users/cloudwan/repos","events_url":"https://api.github.com/users/cloudwan/events{/privacy}","received_events_url":"https://api.github.com/users/cloudwan/received_events","type":"Organization","site_admin":false},"repo":{"id":43838360,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgzODM2MA==","name":"gohan","full_name":"cloudwan/gohan","private":false,"owner":{"login":"cloudwan","id":13223939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjIzOTM5","avatar_url":"https://avatars2.githubusercontent.com/u/13223939?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudwan","html_url":"https://github.com/cloudwan","followers_url":"https://api.github.com/users/cloudwan/followers","following_url":"https://api.github.com/users/cloudwan/following{/other_user}","gists_url":"https://api.github.com/users/cloudwan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudwan/subscriptions","organizations_url":"https://api.github.com/users/cloudwan/orgs","repos_url":"https://api.github.com/users/cloudwan/repos","events_url":"https://api.github.com/users/cloudwan/events{/privacy}","received_events_url":"https://api.github.com/users/cloudwan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudwan/gohan","description":"Gohan is an API Gateway Server written by Go that makes it easy for developers to create and maintain REST-style API","fork":false,"url":"https://api.github.com/repos/cloudwan/gohan","forks_url":"https://api.github.com/repos/cloudwan/gohan/forks","keys_url":"https://api.github.com/repos/cloudwan/gohan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudwan/gohan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudwan/gohan/teams","hooks_url":"https://api.github.com/repos/cloudwan/gohan/hooks","issue_events_url":"https://api.github.com/repos/cloudwan/gohan/issues/events{/number}","events_url":"https://api.github.com/repos/cloudwan/gohan/events","assignees_url":"https://api.github.com/repos/cloudwan/gohan/assignees{/user}","branches_url":"https://api.github.com/repos/cloudwan/gohan/branches{/branch}","tags_url":"https://api.github.com/repos/cloudwan/gohan/tags","blobs_url":"https://api.github.com/repos/cloudwan/gohan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudwan/gohan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudwan/gohan/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudwan/gohan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudwan/gohan/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudwan/gohan/languages","stargazers_url":"https://api.github.com/repos/cloudwan/gohan/stargazers","contributors_url":"https://api.github.com/repos/cloudwan/gohan/contributors","subscribers_url":"https://api.github.com/repos/cloudwan/gohan/subscribers","subscription_url":"https://api.github.com/repos/cloudwan/gohan/subscription","commits_url":"https://api.github.com/repos/cloudwan/gohan/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudwan/gohan/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudwan/gohan/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudwan/gohan/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudwan/gohan/contents/{+path}","compare_url":"https://api.github.com/repos/cloudwan/gohan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudwan/gohan/merges","archive_url":"https://api.github.com/repos/cloudwan/gohan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudwan/gohan/downloads","issues_url":"https://api.github.com/repos/cloudwan/gohan/issues{/number}","pulls_url":"https://api.github.com/repos/cloudwan/gohan/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudwan/gohan/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudwan/gohan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudwan/gohan/labels{/name}","releases_url":"https://api.github.com/repos/cloudwan/gohan/releases{/id}","deployments_url":"https://api.github.com/repos/cloudwan/gohan/deployments","created_at":"2015-10-07T19:01:47Z","updated_at":"2019-07-25T14:46:36Z","pushed_at":"2019-08-08T16:38:04Z","git_url":"git://github.com/cloudwan/gohan.git","ssh_url":"git@github.com:cloudwan/gohan.git","clone_url":"https://github.com/cloudwan/gohan.git","svn_url":"https://github.com/cloudwan/gohan","homepage":"http://www.slideshare.net/natiueno/gohan-61170476","size":52741,"stargazers_count":101,"watchers_count":101,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":50,"open_issues":52,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/760"},"html":{"href":"https://github.com/cloudwan/gohan/pull/760"},"issue":{"href":"https://api.github.com/repos/cloudwan/gohan/issues/760"},"comments":{"href":"https://api.github.com/repos/cloudwan/gohan/issues/760/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/760/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/760/commits"},"statuses":{"href":"https://api.github.com/repos/cloudwan/gohan/statuses/f2053e0e0df66b9111d05f6227a8e2ec7cab0cb2"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 43838360,
"name": "cloudwan/gohan",
"url": "https://api.github.com/repos/cloudwan/gohan"
}
|
{
"id": 42138403,
"login": "tomasz-michalski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42138403?",
"url": "https://api.github.com/users/tomasz-michalski"
}
|
{
"id": 13223939,
"login": "cloudwan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13223939?",
"url": "https://api.github.com/orgs/cloudwan"
}
| 2019-08-09T09:20:12 |
10180235089
|
{"actor":{"display_login":"tomasz-michalski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/comments/255048110","pull_request_review_id":201547038,"id":255048110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTA0ODExMA==","diff_hunk":"@@ -106,7 +106,7 @@ var goBuildConfigs = []goBuildConfig{\n \t{GOOS: \"darwin\", GOARCH: \"amd64\"},\n }\n \n-var releaseDir = \"release\"\n+var releaseDir = \"dist\"","path":".mage/go.go","position":null,"original_position":5,"commit_id":"2873ab6d4f6d5bc4ca88061282fd68bd5e5ac190","original_commit_id":"fb091ce279e5eb41093831e5b6e1c9bef2b0225e","user":{"login":"rvolosatovs","id":12877905,"node_id":"MDQ6VXNlcjEyODc3OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/12877905?v=4","gravatar_id":"","url":"https://api.github.com/users/rvolosatovs","html_url":"https://github.com/rvolosatovs","followers_url":"https://api.github.com/users/rvolosatovs/followers","following_url":"https://api.github.com/users/rvolosatovs/following{/other_user}","gists_url":"https://api.github.com/users/rvolosatovs/gists{/gist_id}","starred_url":"https://api.github.com/users/rvolosatovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvolosatovs/subscriptions","organizations_url":"https://api.github.com/users/rvolosatovs/orgs","repos_url":"https://api.github.com/users/rvolosatovs/repos","events_url":"https://api.github.com/users/rvolosatovs/events{/privacy}","received_events_url":"https://api.github.com/users/rvolosatovs/received_events","type":"User","site_admin":false},"body":"Removed the build logic and made `Makefile` just use vendored `goreleaser` for (test) builds.","created_at":"2019-02-08T12:03:09Z","updated_at":"2019-02-08T12:03:09Z","html_url":"https://github.com/TheThingsNetwork/lorawan-stack/pull/109#discussion_r255048110","pull_request_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/109","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/comments/255048110"},"html":{"href":"https://github.com/TheThingsNetwork/lorawan-stack/pull/109#discussion_r255048110"},"pull_request":{"href":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/109"}},"in_reply_to_id":254896855},"pull_request":{"url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/109","id":251158287,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxMTU4Mjg3","html_url":"https://github.com/TheThingsNetwork/lorawan-stack/pull/109","diff_url":"https://github.com/TheThingsNetwork/lorawan-stack/pull/109.diff","patch_url":"https://github.com/TheThingsNetwork/lorawan-stack/pull/109.patch","issue_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues/109","number":109,"state":"open","locked":false,"title":"Setup goreleaser and improve CI","user":{"login":"rvolosatovs","id":12877905,"node_id":"MDQ6VXNlcjEyODc3OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/12877905?v=4","gravatar_id":"","url":"https://api.github.com/users/rvolosatovs","html_url":"https://github.com/rvolosatovs","followers_url":"https://api.github.com/users/rvolosatovs/followers","following_url":"https://api.github.com/users/rvolosatovs/following{/other_user}","gists_url":"https://api.github.com/users/rvolosatovs/gists{/gist_id}","starred_url":"https://api.github.com/users/rvolosatovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvolosatovs/subscriptions","organizations_url":"https://api.github.com/users/rvolosatovs/orgs","repos_url":"https://api.github.com/users/rvolosatovs/repos","events_url":"https://api.github.com/users/rvolosatovs/events{/privacy}","received_events_url":"https://api.github.com/users/rvolosatovs/received_events","type":"User","site_admin":false},"body":"**Summary:**\r\n<!--\r\nA summary, always referencing related issues:\r\nCloses #0000, References #0000, etc.\r\n-->\r\n\r\nReferences #86 \r\n\r\n<!--\r\nPlease motivate briefly why it is implemented this way, if that deviates\r\nfrom the implementation proposal in the referenced issues.\r\n-->\r\n\r\n**Changes:**\r\n<!-- What are the changes made in this pull request? -->\r\n\r\n- Remove `ci` and go build-related `Makefile`/`mage` logic\r\n- Simpify `.travis.yml` and the matrix\r\n- Setup `goreleaser`\r\n- Vendor tools via Go modules(see https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module)\r\n\r\n**Notes for Reviewers:**\r\n<!--\r\nHow should your reviewers approach this pull request?\r\nAny special requests or questions for specific reviewers?\r\n-->\r\n\r\nThis is not a \"final\" version of `.goreleaser.yml`, more like a \"base\" to work with.\r\nI suppose we will gather feedback from actual users of the packages(maybe @proffalken ?) and improve them based on that. For starters, we probably need to create a wrapper for `ttn-lw-stack` to specify the actual frontend location, same as done for Brew. I will create an issue about it.(TODO: add ref)\r\nThis is what `goreleaser` does for now(the repositories in the PR are in `TheThingsNetwork` namespace `rvolosatovs` was used for testing):\r\n- Creates a release with changelog and references to Docker images: https://github.com/rvolosatovs/lorawan-stack/releases/tag/v3.0.1\r\n- Builds docker images and pushes to Docker Hub: https://cloud.docker.com/u/rvolosatovs/repository/docker/rvolosatovs/lorawan-stack\r\n- Creates a brew tap formula and pushes to tap repository:\r\nhttps://github.com/rvolosatovs/homebrew-lorawan-stack\r\nYou can try the Brew package by `brew install rvolosatovs/lorawan-stack/ttn-lw-stack`(it's going to be `brew install TheThingsNetwork/lorawan-stack/ttn-lw-stack` once we merge this and create a tag)\r\n(Thanks @bafonins for testing)\r\n\r\nI don't think we need any Go build logic in `make` or `mage` anymore, users should be able to just `go get` or `go build` as needed(cc @htdvisser ). The binary releases are build by goreleaser. The \"full package\" can be built by `goreleaser --skip-publish` locally if required.\r\n\r\n**Release Notes: _(optional)_**\r\n<!--\r\nAny notes that we need to include in the Release Notes for the next release.\r\nWhat are the functional or behavioral changes? API Changes? New features?\r\nAny changes in configuration? Added/changed/removed flags?\r\nAre there any database migrations required?\r\n-->\r\n\r\n- LoRaWAN stack and CLI are now available via `brew`: just do `brew install TheThingsNetwork/lorawan-stack/ttn-lw-stack`\r\n","created_at":"2019-02-07T15:30:30Z","updated_at":"2019-02-08T12:03:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9200960d216bbb844cc8e95250cb87fa99271c6","assignee":{"login":"rvolosatovs","id":12877905,"node_id":"MDQ6VXNlcjEyODc3OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/12877905?v=4","gravatar_id":"","url":"https://api.github.com/users/rvolosatovs","html_url":"https://github.com/rvolosatovs","followers_url":"https://api.github.com/users/rvolosatovs/followers","following_url":"https://api.github.com/users/rvolosatovs/following{/other_user}","gists_url":"https://api.github.com/users/rvolosatovs/gists{/gist_id}","starred_url":"https://api.github.com/users/rvolosatovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvolosatovs/subscriptions","organizations_url":"https://api.github.com/users/rvolosatovs/orgs","repos_url":"https://api.github.com/users/rvolosatovs/repos","events_url":"https://api.github.com/users/rvolosatovs/events{/privacy}","received_events_url":"https://api.github.com/users/rvolosatovs/received_events","type":"User","site_admin":false},"assignees":[{"login":"rvolosatovs","id":12877905,"node_id":"MDQ6VXNlcjEyODc3OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/12877905?v=4","gravatar_id":"","url":"https://api.github.com/users/rvolosatovs","html_url":"https://github.com/rvolosatovs","followers_url":"https://api.github.com/users/rvolosatovs/followers","following_url":"https://api.github.com/users/rvolosatovs/following{/other_user}","gists_url":"https://api.github.com/users/rvolosatovs/gists{/gist_id}","starred_url":"https://api.github.com/users/rvolosatovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvolosatovs/subscriptions","organizations_url":"https://api.github.com/users/rvolosatovs/orgs","repos_url":"https://api.github.com/users/rvolosatovs/repos","events_url":"https://api.github.com/users/rvolosatovs/events{/privacy}","received_events_url":"https://api.github.com/users/rvolosatovs/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"htdvisser","id":181308,"node_id":"MDQ6VXNlcjE4MTMwOA==","avatar_url":"https://avatars3.githubusercontent.com/u/181308?v=4","gravatar_id":"","url":"https://api.github.com/users/htdvisser","html_url":"https://github.com/htdvisser","followers_url":"https://api.github.com/users/htdvisser/followers","following_url":"https://api.github.com/users/htdvisser/following{/other_user}","gists_url":"https://api.github.com/users/htdvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/htdvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htdvisser/subscriptions","organizations_url":"https://api.github.com/users/htdvisser/orgs","repos_url":"https://api.github.com/users/htdvisser/repos","events_url":"https://api.github.com/users/htdvisser/events{/privacy}","received_events_url":"https://api.github.com/users/htdvisser/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1192686900,"node_id":"MDU6TGFiZWwxMTkyNjg2OTAw","url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/labels/doc","name":"doc","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/milestones/1","html_url":"https://github.com/TheThingsNetwork/lorawan-stack/milestone/1","labels_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/milestones/1/labels","id":4025573,"node_id":"MDk6TWlsZXN0b25lNDAyNTU3Mw==","number":1,"title":"February 2019","description":"","creator":{"login":"johanstokking","id":13334001,"node_id":"MDQ6VXNlcjEzMzM0MDAx","avatar_url":"https://avatars2.githubusercontent.com/u/13334001?v=4","gravatar_id":"","url":"https://api.github.com/users/johanstokking","html_url":"https://github.com/johanstokking","followers_url":"https://api.github.com/users/johanstokking/followers","following_url":"https://api.github.com/users/johanstokking/following{/other_user}","gists_url":"https://api.github.com/users/johanstokking/gists{/gist_id}","starred_url":"https://api.github.com/users/johanstokking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanstokking/subscriptions","organizations_url":"https://api.github.com/users/johanstokking/orgs","repos_url":"https://api.github.com/users/johanstokking/repos","events_url":"https://api.github.com/users/johanstokking/events{/privacy}","received_events_url":"https://api.github.com/users/johanstokking/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":9,"state":"open","created_at":"2019-02-04T01:30:56Z","updated_at":"2019-02-07T23:13:39Z","due_on":"2019-02-27T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/109/commits","review_comments_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/109/comments","review_comment_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues/109/comments","statuses_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/statuses/2873ab6d4f6d5bc4ca88061282fd68bd5e5ac190","head":{"label":"TheThingsNetwork:feature/goreleaser","ref":"feature/goreleaser","sha":"2873ab6d4f6d5bc4ca88061282fd68bd5e5ac190","user":{"login":"TheThingsNetwork","id":13333576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzMzNTc2","avatar_url":"https://avatars0.githubusercontent.com/u/13333576?v=4","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":165405689,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU0MDU2ODk=","name":"lorawan-stack","full_name":"TheThingsNetwork/lorawan-stack","private":false,"owner":{"login":"TheThingsNetwork","id":13333576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzMzNTc2","avatar_url":"https://avatars0.githubusercontent.com/u/13333576?v=4","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TheThingsNetwork/lorawan-stack","description":"The Things Network Stack for LoRaWAN V3","fork":false,"url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack","forks_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/forks","keys_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/teams","hooks_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/hooks","issue_events_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues/events{/number}","events_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/events","assignees_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/assignees{/user}","branches_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/branches{/branch}","tags_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/tags","blobs_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/languages","stargazers_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/stargazers","contributors_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/contributors","subscribers_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/subscribers","subscription_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/subscription","commits_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/contents/{+path}","compare_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/merges","archive_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/downloads","issues_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues{/number}","pulls_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/labels{/name}","releases_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/releases{/id}","deployments_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/deployments","created_at":"2019-01-12T15:52:34Z","updated_at":"2019-02-07T16:14:51Z","pushed_at":"2019-02-08T11:54:54Z","git_url":"git://github.com/TheThingsNetwork/lorawan-stack.git","ssh_url":"git@github.com:TheThingsNetwork/lorawan-stack.git","clone_url":"https://github.com/TheThingsNetwork/lorawan-stack.git","svn_url":"https://github.com/TheThingsNetwork/lorawan-stack","homepage":null,"size":14636,"stargazers_count":60,"watchers_count":60,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":99,"watchers":60,"default_branch":"master"}},"base":{"label":"TheThingsNetwork:master","ref":"master","sha":"62837b1e7a503f3b2007f5eb109256653846bd33","user":{"login":"TheThingsNetwork","id":13333576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzMzNTc2","avatar_url":"https://avatars0.githubusercontent.com/u/13333576?v=4","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":165405689,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU0MDU2ODk=","name":"lorawan-stack","full_name":"TheThingsNetwork/lorawan-stack","private":false,"owner":{"login":"TheThingsNetwork","id":13333576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzMzNTc2","avatar_url":"https://avatars0.githubusercontent.com/u/13333576?v=4","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TheThingsNetwork/lorawan-stack","description":"The Things Network Stack for LoRaWAN V3","fork":false,"url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack","forks_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/forks","keys_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/teams","hooks_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/hooks","issue_events_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues/events{/number}","events_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/events","assignees_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/assignees{/user}","branches_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/branches{/branch}","tags_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/tags","blobs_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/languages","stargazers_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/stargazers","contributors_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/contributors","subscribers_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/subscribers","subscription_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/subscription","commits_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/contents/{+path}","compare_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/merges","archive_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/downloads","issues_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues{/number}","pulls_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/labels{/name}","releases_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/releases{/id}","deployments_url":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/deployments","created_at":"2019-01-12T15:52:34Z","updated_at":"2019-02-07T16:14:51Z","pushed_at":"2019-02-08T11:54:54Z","git_url":"git://github.com/TheThingsNetwork/lorawan-stack.git","ssh_url":"git@github.com:TheThingsNetwork/lorawan-stack.git","clone_url":"https://github.com/TheThingsNetwork/lorawan-stack.git","svn_url":"https://github.com/TheThingsNetwork/lorawan-stack","homepage":null,"size":14636,"stargazers_count":60,"watchers_count":60,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":99,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/109"},"html":{"href":"https://github.com/TheThingsNetwork/lorawan-stack/pull/109"},"issue":{"href":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues/109"},"comments":{"href":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/TheThingsNetwork/lorawan-stack/statuses/2873ab6d4f6d5bc4ca88061282fd68bd5e5ac190"}},"author_association":"MEMBER"}}
|
{
"id": 165405689,
"name": "TheThingsNetwork/lorawan-stack",
"url": "https://api.github.com/repos/TheThingsNetwork/lorawan-stack"
}
|
{
"id": 12877905,
"login": "rvolosatovs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12877905?",
"url": "https://api.github.com/users/rvolosatovs"
}
|
{
"id": 13333576,
"login": "TheThingsNetwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13333576?",
"url": "https://api.github.com/orgs/TheThingsNetwork"
}
| 2019-02-08T12:03:09 |
9032394003
|
{"actor":{"display_login":"rvolosatovs"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments/260619713","pull_request_review_id":208366336,"id":260619713,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDYxOTcxMw==","diff_hunk":"@@ -0,0 +1,237 @@\n+package de.metas.dataentry.layout;\n+\n+import static io.github.jsonSnapshot.SnapshotMatcher.expect;\n+import static io.github.jsonSnapshot.SnapshotMatcher.start;\n+import static io.github.jsonSnapshot.SnapshotMatcher.validateSnapshots;\n+import static org.adempiere.model.InterfaceWrapperHelper.newInstance;\n+import static org.adempiere.model.InterfaceWrapperHelper.saveRecord;\n+\n+import java.util.List;\n+\n+import org.adempiere.ad.element.api.AdWindowId;\n+import org.adempiere.test.AdempiereTestHelper;\n+import org.compiere.model.I_AD_Tab;\n+import org.compiere.model.I_AD_Table;\n+import org.junit.AfterClass;\n+import org.junit.Before;\n+import org.junit.BeforeClass;\n+import org.junit.Test;\n+\n+import de.metas.dataentry.model.I_DataEntry_Field;\n+import de.metas.dataentry.model.I_DataEntry_Group;\n+import de.metas.dataentry.model.I_DataEntry_ListValue;\n+import de.metas.dataentry.model.I_DataEntry_Section;\n+import de.metas.dataentry.model.I_DataEntry_SubGroup;\n+import de.metas.dataentry.model.X_DataEntry_Field;\n+\n+/*\n+ * #%L\n+ * de.metas.adempiere.adempiere.base\n+ * %%\n+ * Copyright (C) 2019 metas GmbH\n+ * %%\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as\n+ * published by the Free Software Foundation, either version 2 of the\n+ * License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public\n+ * License along with this program. If not, see\n+ * <http://www.gnu.org/licenses/gpl-2.0.html>.\n+ * #L%\n+ */\n+\n+public class DataEntryLayoutRepositoryTest\n+{\n+\tprivate DataEntryLayoutRepository dataEntryLayoutRepository;\n+\n+\t@Before\n+\tpublic void init()\n+\t{\n+\t\tAdempiereTestHelper.get().init();\n+\t\tdataEntryLayoutRepository = new DataEntryLayoutRepository();\n+\t}\n+\n+\t@BeforeClass\n+\tpublic static void beforeAll()\n+\t{\n+\t\tstart(AdempiereTestHelper.SNAPSHOT_CONFIG);\n+\t}\n+\n+\t@AfterClass\n+\tpublic static void afterAll()\n+\t{\n+\t\tvalidateSnapshots();\n+\t}\n+\n+\t@Test\n+\tpublic void getByWindowId()\n+\t{\n+\t\tfinal I_DataEntry_Group groupRecord1 = createRecords();\n+\t\tfinal AdWindowId windowId_1 = AdWindowId.ofRepoId(groupRecord1.getDataEntry_TargetWindow_ID());\n+\n+\t\t// invoke the method under test\n+\t\tfinal List<DataEntryGroup> result = dataEntryLayoutRepository.getByWindowId(windowId_1);\n+\n+\t\texpect(result).toMatchSnapshot();\n+\t}\n+\n+\tprivate I_DataEntry_Group createRecords()","path":"de.metas.adempiere.adempiere/base/src/test/java/de/metas/dataentry/layout/DataEntryLayoutRepositoryTest.java","position":84,"original_position":84,"commit_id":"f9b0ec8b0a882a1e6895f79976dd8610c317af16","original_commit_id":"f9b0ec8b0a882a1e6895f79976dd8610c317af16","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Avoid really long methods.](https://app.codacy.com/app/metasfresh/metasfresh/pullRequest?prid=3172103)","created_at":"2019-02-27T07:25:07Z","updated_at":"2019-02-27T07:25:07Z","html_url":"https://github.com/metasfresh/metasfresh/pull/4992#discussion_r260619713","pull_request_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4992","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments/260619713"},"html":{"href":"https://github.com/metasfresh/metasfresh/pull/4992#discussion_r260619713"},"pull_request":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4992"}}},"pull_request":{"url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4992","id":256272327,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2MjcyMzI3","html_url":"https://github.com/metasfresh/metasfresh/pull/4992","diff_url":"https://github.com/metasfresh/metasfresh/pull/4992.diff","patch_url":"https://github.com/metasfresh/metasfresh/pull/4992.patch","issue_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4992","number":4992,"state":"open","locked":false,"title":"4959-app - data entry implementation","user":{"login":"metas-ts","id":1264789,"node_id":"MDQ6VXNlcjEyNjQ3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1264789?v=4","gravatar_id":"","url":"https://api.github.com/users/metas-ts","html_url":"https://github.com/metas-ts","followers_url":"https://api.github.com/users/metas-ts/followers","following_url":"https://api.github.com/users/metas-ts/following{/other_user}","gists_url":"https://api.github.com/users/metas-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/metas-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metas-ts/subscriptions","organizations_url":"https://api.github.com/users/metas-ts/orgs","repos_url":"https://api.github.com/users/metas-ts/repos","events_url":"https://api.github.com/users/metas-ts/events{/privacy}","received_events_url":"https://api.github.com/users/metas-ts/received_events","type":"User","site_admin":false},"body":"https://github.com/metasfresh/metasfresh/issues/4959","created_at":"2019-02-26T12:56:27Z","updated_at":"2019-02-27T07:25:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec5802e2241e35c930e9aeb24f83594e64c02269","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4992/commits","review_comments_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4992/comments","review_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4992/comments","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/f9b0ec8b0a882a1e6895f79976dd8610c317af16","head":{"label":"metasfresh:gh4959-app","ref":"gh4959-app","sha":"f9b0ec8b0a882a1e6895f79976dd8610c317af16","user":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":43760104,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc2MDEwNA==","name":"metasfresh","full_name":"metasfresh/metasfresh","private":false,"owner":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/metasfresh/metasfresh","description":"Fast, Flexible & Free ERP for your Business Growth.","fork":false,"url":"https://api.github.com/repos/metasfresh/metasfresh","forks_url":"https://api.github.com/repos/metasfresh/metasfresh/forks","keys_url":"https://api.github.com/repos/metasfresh/metasfresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metasfresh/metasfresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metasfresh/metasfresh/teams","hooks_url":"https://api.github.com/repos/metasfresh/metasfresh/hooks","issue_events_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/events{/number}","events_url":"https://api.github.com/repos/metasfresh/metasfresh/events","assignees_url":"https://api.github.com/repos/metasfresh/metasfresh/assignees{/user}","branches_url":"https://api.github.com/repos/metasfresh/metasfresh/branches{/branch}","tags_url":"https://api.github.com/repos/metasfresh/metasfresh/tags","blobs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metasfresh/metasfresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/metasfresh/metasfresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/{sha}","languages_url":"https://api.github.com/repos/metasfresh/metasfresh/languages","stargazers_url":"https://api.github.com/repos/metasfresh/metasfresh/stargazers","contributors_url":"https://api.github.com/repos/metasfresh/metasfresh/contributors","subscribers_url":"https://api.github.com/repos/metasfresh/metasfresh/subscribers","subscription_url":"https://api.github.com/repos/metasfresh/metasfresh/subscription","commits_url":"https://api.github.com/repos/metasfresh/metasfresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/metasfresh/metasfresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/metasfresh/metasfresh/contents/{+path}","compare_url":"https://api.github.com/repos/metasfresh/metasfresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metasfresh/metasfresh/merges","archive_url":"https://api.github.com/repos/metasfresh/metasfresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metasfresh/metasfresh/downloads","issues_url":"https://api.github.com/repos/metasfresh/metasfresh/issues{/number}","pulls_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls{/number}","milestones_url":"https://api.github.com/repos/metasfresh/metasfresh/milestones{/number}","notifications_url":"https://api.github.com/repos/metasfresh/metasfresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metasfresh/metasfresh/labels{/name}","releases_url":"https://api.github.com/repos/metasfresh/metasfresh/releases{/id}","deployments_url":"https://api.github.com/repos/metasfresh/metasfresh/deployments","created_at":"2015-10-06T15:38:11Z","updated_at":"2019-02-27T07:13:27Z","pushed_at":"2019-02-27T07:15:44Z","git_url":"git://github.com/metasfresh/metasfresh.git","ssh_url":"git@github.com:metasfresh/metasfresh.git","clone_url":"https://github.com/metasfresh/metasfresh.git","svn_url":"https://github.com/metasfresh/metasfresh","homepage":"http://metasfresh.com/en","size":96275,"stargazers_count":362,"watchers_count":362,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":963,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":158,"open_issues":963,"watchers":362,"default_branch":"master"}},"base":{"label":"metasfresh:master","ref":"master","sha":"fdda173913608015ca233f8f6167d3d68adec720","user":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":43760104,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc2MDEwNA==","name":"metasfresh","full_name":"metasfresh/metasfresh","private":false,"owner":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/metasfresh/metasfresh","description":"Fast, Flexible & Free ERP for your Business Growth.","fork":false,"url":"https://api.github.com/repos/metasfresh/metasfresh","forks_url":"https://api.github.com/repos/metasfresh/metasfresh/forks","keys_url":"https://api.github.com/repos/metasfresh/metasfresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metasfresh/metasfresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metasfresh/metasfresh/teams","hooks_url":"https://api.github.com/repos/metasfresh/metasfresh/hooks","issue_events_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/events{/number}","events_url":"https://api.github.com/repos/metasfresh/metasfresh/events","assignees_url":"https://api.github.com/repos/metasfresh/metasfresh/assignees{/user}","branches_url":"https://api.github.com/repos/metasfresh/metasfresh/branches{/branch}","tags_url":"https://api.github.com/repos/metasfresh/metasfresh/tags","blobs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metasfresh/metasfresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/metasfresh/metasfresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/{sha}","languages_url":"https://api.github.com/repos/metasfresh/metasfresh/languages","stargazers_url":"https://api.github.com/repos/metasfresh/metasfresh/stargazers","contributors_url":"https://api.github.com/repos/metasfresh/metasfresh/contributors","subscribers_url":"https://api.github.com/repos/metasfresh/metasfresh/subscribers","subscription_url":"https://api.github.com/repos/metasfresh/metasfresh/subscription","commits_url":"https://api.github.com/repos/metasfresh/metasfresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/metasfresh/metasfresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/metasfresh/metasfresh/contents/{+path}","compare_url":"https://api.github.com/repos/metasfresh/metasfresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metasfresh/metasfresh/merges","archive_url":"https://api.github.com/repos/metasfresh/metasfresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metasfresh/metasfresh/downloads","issues_url":"https://api.github.com/repos/metasfresh/metasfresh/issues{/number}","pulls_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls{/number}","milestones_url":"https://api.github.com/repos/metasfresh/metasfresh/milestones{/number}","notifications_url":"https://api.github.com/repos/metasfresh/metasfresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metasfresh/metasfresh/labels{/name}","releases_url":"https://api.github.com/repos/metasfresh/metasfresh/releases{/id}","deployments_url":"https://api.github.com/repos/metasfresh/metasfresh/deployments","created_at":"2015-10-06T15:38:11Z","updated_at":"2019-02-27T07:13:27Z","pushed_at":"2019-02-27T07:15:44Z","git_url":"git://github.com/metasfresh/metasfresh.git","ssh_url":"git@github.com:metasfresh/metasfresh.git","clone_url":"https://github.com/metasfresh/metasfresh.git","svn_url":"https://github.com/metasfresh/metasfresh","homepage":"http://metasfresh.com/en","size":96275,"stargazers_count":362,"watchers_count":362,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":963,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":158,"open_issues":963,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4992"},"html":{"href":"https://github.com/metasfresh/metasfresh/pull/4992"},"issue":{"href":"https://api.github.com/repos/metasfresh/metasfresh/issues/4992"},"comments":{"href":"https://api.github.com/repos/metasfresh/metasfresh/issues/4992/comments"},"review_comments":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4992/comments"},"review_comment":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4992/commits"},"statuses":{"href":"https://api.github.com/repos/metasfresh/metasfresh/statuses/f9b0ec8b0a882a1e6895f79976dd8610c317af16"}},"author_association":"MEMBER"}}
|
{
"id": 43760104,
"name": "metasfresh/metasfresh",
"url": "https://api.github.com/repos/metasfresh/metasfresh"
}
|
{
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
}
|
{
"id": 13364239,
"login": "metasfresh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13364239?",
"url": "https://api.github.com/orgs/metasfresh"
}
| 2019-02-27T07:25:07 |
9144444231
|
{"actor":{"display_login":"codacy-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/338977961","pull_request_review_id":307103652,"id":338977961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODk3Nzk2MQ==","diff_hunk":"@@ -0,0 +1,70 @@\n+// +build routerrpc\n+\n+package main\n+\n+import (\n+\t\"context\"\n+\t\"fmt\"\n+\t\"strconv\"\n+\n+\t\"github.com/btcsuite/btcutil\"\n+\t\"github.com/lightningnetwork/lnd/lnrpc/routerrpc\"\n+\t\"github.com/lightningnetwork/lnd/lnwire\"\n+\t\"github.com/lightningnetwork/lnd/routing/route\"\n+\t\"github.com/urfave/cli\"\n+)\n+\n+var queryMcProbCommand = cli.Command{\n+\tName: \"querymcprob\",","path":"cmd/lncli/cmd_query_mc_probability.go","position":18,"original_position":18,"commit_id":"8644ceb1aa0606f3f2b7d5463d2a4e8a31924c58","original_commit_id":"8644ceb1aa0606f3f2b7d5463d2a4e8a31924c58","user":{"login":"carlaKC","id":42311294,"node_id":"MDQ6VXNlcjQyMzExMjk0","avatar_url":"https://avatars1.githubusercontent.com/u/42311294?v=4","gravatar_id":"","url":"https://api.github.com/users/carlaKC","html_url":"https://github.com/carlaKC","followers_url":"https://api.github.com/users/carlaKC/followers","following_url":"https://api.github.com/users/carlaKC/following{/other_user}","gists_url":"https://api.github.com/users/carlaKC/gists{/gist_id}","starred_url":"https://api.github.com/users/carlaKC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlaKC/subscriptions","organizations_url":"https://api.github.com/users/carlaKC/orgs","repos_url":"https://api.github.com/users/carlaKC/repos","events_url":"https://api.github.com/users/carlaKC/events{/privacy}","received_events_url":"https://api.github.com/users/carlaKC/received_events","type":"User","site_admin":false},"body":"Wondering is it's necessary to include `mc` in the command name?\r\nMission control is an internal concept that users might not be familiar with, `queryPaymentProbability` or something more user suited may be more informative?","created_at":"2019-10-25T10:01:52Z","updated_at":"2019-10-25T10:18:41Z","html_url":"https://github.com/lightningnetwork/lnd/pull/3556#discussion_r338977961","pull_request_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3556","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/338977961"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/3556#discussion_r338977961"},"pull_request":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3556"}}},"pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3556","id":322723547,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyNzIzNTQ3","html_url":"https://github.com/lightningnetwork/lnd/pull/3556","diff_url":"https://github.com/lightningnetwork/lnd/pull/3556.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/3556.patch","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/3556","number":3556,"state":"open","locked":false,"title":"routerrpc: add querymcprob rpc","user":{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false},"body":"In #3462, we removed probability reporting for `querymc`. This PR brings it back as a separate rpc for which a specific amount needs to be given.\r\n\r\nIn addition to the probability, it also returns the raw data for the requested pair. An example use case for this is to get a sense for the freshness of a pair and use this to decide whether to do a prepay probe for a route.","created_at":"2019-09-30T11:06:39Z","updated_at":"2019-10-25T10:18:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f2bec33cb824247f310caf62c7ee49a240e6fa0","assignee":{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false},"assignees":[{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"halseth","id":3765732,"node_id":"MDQ6VXNlcjM3NjU3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3765732?v=4","gravatar_id":"","url":"https://api.github.com/users/halseth","html_url":"https://github.com/halseth","followers_url":"https://api.github.com/users/halseth/followers","following_url":"https://api.github.com/users/halseth/following{/other_user}","gists_url":"https://api.github.com/users/halseth/gists{/gist_id}","starred_url":"https://api.github.com/users/halseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halseth/subscriptions","organizations_url":"https://api.github.com/users/halseth/orgs","repos_url":"https://api.github.com/users/halseth/repos","events_url":"https://api.github.com/users/halseth/events{/privacy}","received_events_url":"https://api.github.com/users/halseth/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":312148187,"node_id":"MDU6TGFiZWwzMTIxNDgxODc=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":934410207,"node_id":"MDU6TGFiZWw5MzQ0MTAyMDc=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/mission%20control","name":"mission control","color":"bd2ed3","default":false},{"id":431182550,"node_id":"MDU6TGFiZWw0MzExODI1NTA=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/rpc","name":"rpc","color":"006b75","default":false},{"id":1477059160,"node_id":"MDU6TGFiZWwxNDc3MDU5MTYw","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/v0.9.0","name":"v0.9.0","color":"48f29d","default":false}],"milestone":{"url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/16","html_url":"https://github.com/lightningnetwork/lnd/milestone/16","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/16/labels","id":4535167,"node_id":"MDk6TWlsZXN0b25lNDUzNTE2Nw==","number":16,"title":"0.9.0","description":"","creator":{"login":"cfromknecht","id":2013993,"node_id":"MDQ6VXNlcjIwMTM5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":12,"state":"open","created_at":"2019-07-31T01:37:41Z","updated_at":"2019-10-25T08:54:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3556/commits","review_comments_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3556/comments","review_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/3556/comments","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/8644ceb1aa0606f3f2b7d5463d2a4e8a31924c58","head":{"label":"joostjager:query-mc-prob","ref":"query-mc-prob","sha":"8644ceb1aa0606f3f2b7d5463d2a4e8a31924c58","user":{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false},"repo":{"id":133927509,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Mjc1MDk=","name":"lnd","full_name":"joostjager/lnd","private":false,"owner":{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joostjager/lnd","description":"Lightning Network Daemon ⚡️","fork":true,"url":"https://api.github.com/repos/joostjager/lnd","forks_url":"https://api.github.com/repos/joostjager/lnd/forks","keys_url":"https://api.github.com/repos/joostjager/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joostjager/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joostjager/lnd/teams","hooks_url":"https://api.github.com/repos/joostjager/lnd/hooks","issue_events_url":"https://api.github.com/repos/joostjager/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/joostjager/lnd/events","assignees_url":"https://api.github.com/repos/joostjager/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/joostjager/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/joostjager/lnd/tags","blobs_url":"https://api.github.com/repos/joostjager/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joostjager/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joostjager/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/joostjager/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joostjager/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/joostjager/lnd/languages","stargazers_url":"https://api.github.com/repos/joostjager/lnd/stargazers","contributors_url":"https://api.github.com/repos/joostjager/lnd/contributors","subscribers_url":"https://api.github.com/repos/joostjager/lnd/subscribers","subscription_url":"https://api.github.com/repos/joostjager/lnd/subscription","commits_url":"https://api.github.com/repos/joostjager/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/joostjager/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/joostjager/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/joostjager/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/joostjager/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/joostjager/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joostjager/lnd/merges","archive_url":"https://api.github.com/repos/joostjager/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joostjager/lnd/downloads","issues_url":"https://api.github.com/repos/joostjager/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/joostjager/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/joostjager/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/joostjager/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joostjager/lnd/labels{/name}","releases_url":"https://api.github.com/repos/joostjager/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/joostjager/lnd/deployments","created_at":"2018-05-18T08:40:36Z","updated_at":"2018-10-08T12:26:51Z","pushed_at":"2019-10-25T09:24:16Z","git_url":"git://github.com/joostjager/lnd.git","ssh_url":"git@github.com:joostjager/lnd.git","clone_url":"https://github.com/joostjager/lnd.git","svn_url":"https://github.com/joostjager/lnd","homepage":"","size":37576,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightningnetwork:master","ref":"master","sha":"018737a80a81b242cbd4d34a88dc8297970b795d","user":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":49765480,"node_id":"MDEwOlJlcG9zaXRvcnk0OTc2NTQ4MA==","name":"lnd","full_name":"lightningnetwork/lnd","private":false,"owner":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightningnetwork/lnd","description":"Lightning Network Daemon ⚡️","fork":false,"url":"https://api.github.com/repos/lightningnetwork/lnd","forks_url":"https://api.github.com/repos/lightningnetwork/lnd/forks","keys_url":"https://api.github.com/repos/lightningnetwork/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightningnetwork/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightningnetwork/lnd/teams","hooks_url":"https://api.github.com/repos/lightningnetwork/lnd/hooks","issue_events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/lightningnetwork/lnd/events","assignees_url":"https://api.github.com/repos/lightningnetwork/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/lightningnetwork/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/lightningnetwork/lnd/tags","blobs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightningnetwork/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightningnetwork/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/lightningnetwork/lnd/languages","stargazers_url":"https://api.github.com/repos/lightningnetwork/lnd/stargazers","contributors_url":"https://api.github.com/repos/lightningnetwork/lnd/contributors","subscribers_url":"https://api.github.com/repos/lightningnetwork/lnd/subscribers","subscription_url":"https://api.github.com/repos/lightningnetwork/lnd/subscription","commits_url":"https://api.github.com/repos/lightningnetwork/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightningnetwork/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightningnetwork/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/lightningnetwork/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightningnetwork/lnd/merges","archive_url":"https://api.github.com/repos/lightningnetwork/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightningnetwork/lnd/downloads","issues_url":"https://api.github.com/repos/lightningnetwork/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/lightningnetwork/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/labels{/name}","releases_url":"https://api.github.com/repos/lightningnetwork/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/lightningnetwork/lnd/deployments","created_at":"2016-01-16T08:19:33Z","updated_at":"2019-10-25T08:54:49Z","pushed_at":"2019-10-25T09:41:32Z","git_url":"git://github.com/lightningnetwork/lnd.git","ssh_url":"git@github.com:lightningnetwork/lnd.git","clone_url":"https://github.com/lightningnetwork/lnd.git","svn_url":"https://github.com/lightningnetwork/lnd","homepage":"","size":32367,"stargazers_count":4186,"watchers_count":4186,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1163,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":347,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1163,"open_issues":347,"watchers":4186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3556"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/3556"},"issue":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/3556"},"comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/3556/comments"},"review_comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3556/comments"},"review_comment":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3556/commits"},"statuses":{"href":"https://api.github.com/repos/lightningnetwork/lnd/statuses/8644ceb1aa0606f3f2b7d5463d2a4e8a31924c58"}},"author_association":"COLLABORATOR"}}
|
{
"id": 49765480,
"name": "lightningnetwork/lnd",
"url": "https://api.github.com/repos/lightningnetwork/lnd"
}
|
{
"id": 42311294,
"login": "carlaKC",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42311294?",
"url": "https://api.github.com/users/carlaKC"
}
|
{
"id": 13424735,
"login": "lightningnetwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13424735?",
"url": "https://api.github.com/orgs/lightningnetwork"
}
| 2019-10-25T10:01:52 |
10713069933
|
{"actor":{"display_login":"carlaKC"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/338442709","pull_request_review_id":306397734,"id":338442709,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODQ0MjcwOQ==","diff_hunk":"@@ -1853,11 +1814,14 @@ func (l *channelLink) handleUpstreamMsg(msg lnwire.Message) {\n \t\t\treturn\n \t\t}\n \n-\t\t// If there are pending local updates, try to update the commit\n-\t\t// tx. Pending updates could already have been present because\n-\t\t// of a previously failed update to the commit tx or freshly\n-\t\t// added by processRemoteAdds.\n-\t\tif l.channel.PendingLocalUpdateCount() > 0 {\n+\t\t// The revocation window opened up. If there are pending local\n+\t\t// updates, try to update the commit tx. Pending updates could\n+\t\t// already have been present because of a previously failed\n+\t\t// update to the commit tx or freshly added in by\n+\t\t// processRemoteAdds. Also in case there are no local updates,\n+\t\t// but there are still remote updates that are not in the remote\n+\t\t// commit tx yet, send out an update.\n+\t\tif l.channel.OweCommitment() {","path":"htlcswitch/link.go","position":300,"original_position":95,"commit_id":"831dfc2a127f5a64dd1d91db598b1763e4b22504","original_commit_id":"831dfc2a127f5a64dd1d91db598b1763e4b22504","user":{"login":"halseth","id":3765732,"node_id":"MDQ6VXNlcjM3NjU3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3765732?v=4","gravatar_id":"","url":"https://api.github.com/users/halseth","html_url":"https://github.com/halseth","followers_url":"https://api.github.com/users/halseth/followers","following_url":"https://api.github.com/users/halseth/following{/other_user}","gists_url":"https://api.github.com/users/halseth/gists{/gist_id}","starred_url":"https://api.github.com/users/halseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halseth/subscriptions","organizations_url":"https://api.github.com/users/halseth/orgs","repos_url":"https://api.github.com/users/halseth/repos","events_url":"https://api.github.com/users/halseth/events{/privacy}","received_events_url":"https://api.github.com/users/halseth/received_events","type":"User","site_admin":false},"body":"Definitely not a blocker, was just curious.","created_at":"2019-10-24T08:25:42Z","updated_at":"2019-10-24T08:25:42Z","html_url":"https://github.com/lightningnetwork/lnd/pull/2927#discussion_r338442709","pull_request_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2927","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/338442709"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/2927#discussion_r338442709"},"pull_request":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2927"}},"in_reply_to_id":338424966},"pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2927","id":269296490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5Mjk2NDkw","html_url":"https://github.com/lightningnetwork/lnd/pull/2927","diff_url":"https://github.com/lightningnetwork/lnd/pull/2927.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/2927.patch","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/2927","number":2927,"state":"open","locked":false,"title":"htlcswitch: fix empty commit sig and no commit sig","user":{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false},"body":"Builds on top of #3564.\r\n\r\nThis PR fixes two known bugs in the commitment tx update sequence:\r\n* Sending an commit sig message that didn't sign any new updates (\"empty commit sig\")\r\n* Not sending a commit sig message when it is expected.\r\n\r\nIn addition to that, several simplifications are carried through where values were tracked in the link that can also be obtained from the channel.","created_at":"2019-04-10T19:25:34Z","updated_at":"2019-10-24T08:25:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe4d83937b2c899956a03ad7f32ebadd824c187b","assignee":{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false},"assignees":[{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Roasbeef","id":998190,"node_id":"MDQ6VXNlcjk5ODE5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/998190?v=4","gravatar_id":"","url":"https://api.github.com/users/Roasbeef","html_url":"https://github.com/Roasbeef","followers_url":"https://api.github.com/users/Roasbeef/followers","following_url":"https://api.github.com/users/Roasbeef/following{/other_user}","gists_url":"https://api.github.com/users/Roasbeef/gists{/gist_id}","starred_url":"https://api.github.com/users/Roasbeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roasbeef/subscriptions","organizations_url":"https://api.github.com/users/Roasbeef/orgs","repos_url":"https://api.github.com/users/Roasbeef/repos","events_url":"https://api.github.com/users/Roasbeef/events{/privacy}","received_events_url":"https://api.github.com/users/Roasbeef/received_events","type":"User","site_admin":false},{"login":"cfromknecht","id":2013993,"node_id":"MDQ6VXNlcjIwMTM5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":991321920,"node_id":"MDU6TGFiZWw5OTEzMjE5MjA=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/bug%20fix","name":"bug fix","color":"382d9b","default":false},{"id":465888460,"node_id":"MDU6TGFiZWw0NjU4ODg0NjA=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/commitments","name":"commitments","color":"d93f0b","default":false},{"id":886759955,"node_id":"MDU6TGFiZWw4ODY3NTk5NTU=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/htlcswitch","name":"htlcswitch","color":"92dd6c","default":false},{"id":1477059160,"node_id":"MDU6TGFiZWwxNDc3MDU5MTYw","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/v0.9.0","name":"v0.9.0","color":"48f29d","default":false}],"milestone":{"url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/16","html_url":"https://github.com/lightningnetwork/lnd/milestone/16","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/16/labels","id":4535167,"node_id":"MDk6TWlsZXN0b25lNDUzNTE2Nw==","number":16,"title":"0.9.0","description":"","creator":{"login":"cfromknecht","id":2013993,"node_id":"MDQ6VXNlcjIwMTM5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":8,"state":"open","created_at":"2019-07-31T01:37:41Z","updated_at":"2019-10-24T08:14:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2927/commits","review_comments_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2927/comments","review_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/2927/comments","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/831dfc2a127f5a64dd1d91db598b1763e4b22504","head":{"label":"joostjager:hodl-drop-fix-better","ref":"hodl-drop-fix-better","sha":"831dfc2a127f5a64dd1d91db598b1763e4b22504","user":{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false},"repo":{"id":133927509,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Mjc1MDk=","name":"lnd","full_name":"joostjager/lnd","private":false,"owner":{"login":"joostjager","id":4638168,"node_id":"MDQ6VXNlcjQ2MzgxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4638168?v=4","gravatar_id":"","url":"https://api.github.com/users/joostjager","html_url":"https://github.com/joostjager","followers_url":"https://api.github.com/users/joostjager/followers","following_url":"https://api.github.com/users/joostjager/following{/other_user}","gists_url":"https://api.github.com/users/joostjager/gists{/gist_id}","starred_url":"https://api.github.com/users/joostjager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostjager/subscriptions","organizations_url":"https://api.github.com/users/joostjager/orgs","repos_url":"https://api.github.com/users/joostjager/repos","events_url":"https://api.github.com/users/joostjager/events{/privacy}","received_events_url":"https://api.github.com/users/joostjager/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joostjager/lnd","description":"Lightning Network Daemon ⚡️","fork":true,"url":"https://api.github.com/repos/joostjager/lnd","forks_url":"https://api.github.com/repos/joostjager/lnd/forks","keys_url":"https://api.github.com/repos/joostjager/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joostjager/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joostjager/lnd/teams","hooks_url":"https://api.github.com/repos/joostjager/lnd/hooks","issue_events_url":"https://api.github.com/repos/joostjager/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/joostjager/lnd/events","assignees_url":"https://api.github.com/repos/joostjager/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/joostjager/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/joostjager/lnd/tags","blobs_url":"https://api.github.com/repos/joostjager/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joostjager/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joostjager/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/joostjager/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joostjager/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/joostjager/lnd/languages","stargazers_url":"https://api.github.com/repos/joostjager/lnd/stargazers","contributors_url":"https://api.github.com/repos/joostjager/lnd/contributors","subscribers_url":"https://api.github.com/repos/joostjager/lnd/subscribers","subscription_url":"https://api.github.com/repos/joostjager/lnd/subscription","commits_url":"https://api.github.com/repos/joostjager/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/joostjager/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/joostjager/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/joostjager/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/joostjager/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/joostjager/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joostjager/lnd/merges","archive_url":"https://api.github.com/repos/joostjager/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joostjager/lnd/downloads","issues_url":"https://api.github.com/repos/joostjager/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/joostjager/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/joostjager/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/joostjager/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joostjager/lnd/labels{/name}","releases_url":"https://api.github.com/repos/joostjager/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/joostjager/lnd/deployments","created_at":"2018-05-18T08:40:36Z","updated_at":"2018-10-08T12:26:51Z","pushed_at":"2019-10-24T07:18:32Z","git_url":"git://github.com/joostjager/lnd.git","ssh_url":"git@github.com:joostjager/lnd.git","clone_url":"https://github.com/joostjager/lnd.git","svn_url":"https://github.com/joostjager/lnd","homepage":"","size":37399,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightningnetwork:master","ref":"master","sha":"fd906475dd7a443b8287c5153132733c109c4e55","user":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":49765480,"node_id":"MDEwOlJlcG9zaXRvcnk0OTc2NTQ4MA==","name":"lnd","full_name":"lightningnetwork/lnd","private":false,"owner":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightningnetwork/lnd","description":"Lightning Network Daemon ⚡️","fork":false,"url":"https://api.github.com/repos/lightningnetwork/lnd","forks_url":"https://api.github.com/repos/lightningnetwork/lnd/forks","keys_url":"https://api.github.com/repos/lightningnetwork/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightningnetwork/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightningnetwork/lnd/teams","hooks_url":"https://api.github.com/repos/lightningnetwork/lnd/hooks","issue_events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/lightningnetwork/lnd/events","assignees_url":"https://api.github.com/repos/lightningnetwork/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/lightningnetwork/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/lightningnetwork/lnd/tags","blobs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightningnetwork/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightningnetwork/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/lightningnetwork/lnd/languages","stargazers_url":"https://api.github.com/repos/lightningnetwork/lnd/stargazers","contributors_url":"https://api.github.com/repos/lightningnetwork/lnd/contributors","subscribers_url":"https://api.github.com/repos/lightningnetwork/lnd/subscribers","subscription_url":"https://api.github.com/repos/lightningnetwork/lnd/subscription","commits_url":"https://api.github.com/repos/lightningnetwork/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightningnetwork/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightningnetwork/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/lightningnetwork/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightningnetwork/lnd/merges","archive_url":"https://api.github.com/repos/lightningnetwork/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightningnetwork/lnd/downloads","issues_url":"https://api.github.com/repos/lightningnetwork/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/lightningnetwork/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/labels{/name}","releases_url":"https://api.github.com/repos/lightningnetwork/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/lightningnetwork/lnd/deployments","created_at":"2016-01-16T08:19:33Z","updated_at":"2019-10-24T02:43:02Z","pushed_at":"2019-10-24T07:59:18Z","git_url":"git://github.com/lightningnetwork/lnd.git","ssh_url":"git@github.com:lightningnetwork/lnd.git","clone_url":"https://github.com/lightningnetwork/lnd.git","svn_url":"https://github.com/lightningnetwork/lnd","homepage":"","size":32318,"stargazers_count":4187,"watchers_count":4187,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1161,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":350,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1161,"open_issues":350,"watchers":4187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2927"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/2927"},"issue":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/2927"},"comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/2927/comments"},"review_comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2927/comments"},"review_comment":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2927/commits"},"statuses":{"href":"https://api.github.com/repos/lightningnetwork/lnd/statuses/831dfc2a127f5a64dd1d91db598b1763e4b22504"}},"author_association":"COLLABORATOR"}}
|
{
"id": 49765480,
"name": "lightningnetwork/lnd",
"url": "https://api.github.com/repos/lightningnetwork/lnd"
}
|
{
"id": 3765732,
"login": "halseth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3765732?",
"url": "https://api.github.com/users/halseth"
}
|
{
"id": 13424735,
"login": "lightningnetwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13424735?",
"url": "https://api.github.com/orgs/lightningnetwork"
}
| 2019-10-24T08:25:42 |
10702868374
|
{"actor":{"display_login":"halseth"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/vector-im/riotX-android/pulls/comments/357671516","pull_request_review_id":331903918,"id":357671516,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzY3MTUxNg==","diff_hunk":"@@ -180,6 +185,34 @@ abstract class VectorBaseActivity : AppCompatActivity(), HasScreenInjector {\n }\n }\n \n+ private fun handleGlobalError(globalError: GlobalError) {\n+ when (globalError) {\n+ is GlobalError.InvalidToken ->\n+ handleInvalidToken(globalError)\n+ is GlobalError.ConsentNotGivenError ->\n+ consentNotGivenHelper.displayDialog(globalError.consentUri,\n+ activeSessionHolder.getActiveSession().sessionParams.homeServerConnectionConfig.homeServerUri.host ?: \"\")\n+ }\n+ }\n+\n+ protected open fun handleInvalidToken(globalError: GlobalError.InvalidToken) {\n+ Timber.w(\"Invalid token event received\")\n+ if (mainActivityStarted) {\n+ return\n+ }\n+\n+ mainActivityStarted = true\n+\n+ MainActivity.restartApp(this,","path":"vector/src/main/java/im/vector/riotx/core/platform/VectorBaseActivity.kt","position":60,"original_position":60,"commit_id":"38b40efac3fc46543bffb8f281a8956c438161ce","original_commit_id":"12d54140e57296412d5a25c235cf1501a9edc4d5","user":{"login":"bmarty","id":3940906,"node_id":"MDQ6VXNlcjM5NDA5MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3940906?v=4","gravatar_id":"","url":"https://api.github.com/users/bmarty","html_url":"https://github.com/bmarty","followers_url":"https://api.github.com/users/bmarty/followers","following_url":"https://api.github.com/users/bmarty/following{/other_user}","gists_url":"https://api.github.com/users/bmarty/gists{/gist_id}","starred_url":"https://api.github.com/users/bmarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmarty/subscriptions","organizations_url":"https://api.github.com/users/bmarty/orgs","repos_url":"https://api.github.com/users/bmarty/repos","events_url":"https://api.github.com/users/bmarty/events{/privacy}","received_events_url":"https://api.github.com/users/bmarty/received_events","type":"User","site_admin":false},"body":"No exit(0) :)","created_at":"2019-12-13T14:31:03Z","updated_at":"2019-12-13T14:31:03Z","html_url":"https://github.com/vector-im/riotX-android/pull/768#discussion_r357671516","pull_request_url":"https://api.github.com/repos/vector-im/riotX-android/pulls/768","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vector-im/riotX-android/pulls/comments/357671516"},"html":{"href":"https://github.com/vector-im/riotX-android/pull/768#discussion_r357671516"},"pull_request":{"href":"https://api.github.com/repos/vector-im/riotX-android/pulls/768"}},"in_reply_to_id":357656645},"pull_request":{"url":"https://api.github.com/repos/vector-im/riotX-android/pulls/768","id":352670620,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyNjcwNjIw","html_url":"https://github.com/vector-im/riotX-android/pull/768","diff_url":"https://github.com/vector-im/riotX-android/pull/768.diff","patch_url":"https://github.com/vector-im/riotX-android/pull/768.patch","issue_url":"https://api.github.com/repos/vector-im/riotX-android/issues/768","number":768,"state":"open","locked":false,"title":"Handle invalid tokens gracefully - WIP","user":{"login":"bmarty","id":3940906,"node_id":"MDQ6VXNlcjM5NDA5MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3940906?v=4","gravatar_id":"","url":"https://api.github.com/users/bmarty","html_url":"https://github.com/bmarty","followers_url":"https://api.github.com/users/bmarty/followers","following_url":"https://api.github.com/users/bmarty/following{/other_user}","gists_url":"https://api.github.com/users/bmarty/gists{/gist_id}","starred_url":"https://api.github.com/users/bmarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmarty/subscriptions","organizations_url":"https://api.github.com/users/bmarty/orgs","repos_url":"https://api.github.com/users/bmarty/repos","events_url":"https://api.github.com/users/bmarty/events{/privacy}","received_events_url":"https://api.github.com/users/bmarty/received_events","type":"User","site_admin":false},"body":"Handle invalid token by cleaning local data.\r\n\r\nAlso handle the soft logout case (#281)\r\n\r\nThe login/registration flow has been touched, they have to be tested again.\r\n\r\nAlso we have open issues on Synapse which makes that all does not work properly:\r\n- https://github.com/matrix-org/synapse/issues/5755\r\n- https://github.com/matrix-org/synapse/issues/5756\r\n- https://github.com/matrix-org/synapse/issues/6525\r\n","created_at":"2019-12-13T00:28:53Z","updated_at":"2019-12-13T14:31:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e94a76ef59da0b9db9ff17963409847dc315a807","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ganfra","id":8754928,"node_id":"MDQ6VXNlcjg3NTQ5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/8754928?v=4","gravatar_id":"","url":"https://api.github.com/users/ganfra","html_url":"https://github.com/ganfra","followers_url":"https://api.github.com/users/ganfra/followers","following_url":"https://api.github.com/users/ganfra/following{/other_user}","gists_url":"https://api.github.com/users/ganfra/gists{/gist_id}","starred_url":"https://api.github.com/users/ganfra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganfra/subscriptions","organizations_url":"https://api.github.com/users/ganfra/orgs","repos_url":"https://api.github.com/users/ganfra/repos","events_url":"https://api.github.com/users/ganfra/events{/privacy}","received_events_url":"https://api.github.com/users/ganfra/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/vector-im/riotX-android/milestones/14","html_url":"https://github.com/vector-im/riotX-android/milestone/14","labels_url":"https://api.github.com/repos/vector-im/riotX-android/milestones/14/labels","id":4887017,"node_id":"MDk6TWlsZXN0b25lNDg4NzAxNw==","number":14,"title":"Sprint7","description":"","creator":{"login":"bmarty","id":3940906,"node_id":"MDQ6VXNlcjM5NDA5MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3940906?v=4","gravatar_id":"","url":"https://api.github.com/users/bmarty","html_url":"https://github.com/bmarty","followers_url":"https://api.github.com/users/bmarty/followers","following_url":"https://api.github.com/users/bmarty/following{/other_user}","gists_url":"https://api.github.com/users/bmarty/gists{/gist_id}","starred_url":"https://api.github.com/users/bmarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmarty/subscriptions","organizations_url":"https://api.github.com/users/bmarty/orgs","repos_url":"https://api.github.com/users/bmarty/repos","events_url":"https://api.github.com/users/bmarty/events{/privacy}","received_events_url":"https://api.github.com/users/bmarty/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":9,"state":"open","created_at":"2019-11-28T08:51:24Z","updated_at":"2019-12-13T00:30:46Z","due_on":"2019-12-10T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/vector-im/riotX-android/pulls/768/commits","review_comments_url":"https://api.github.com/repos/vector-im/riotX-android/pulls/768/comments","review_comment_url":"https://api.github.com/repos/vector-im/riotX-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vector-im/riotX-android/issues/768/comments","statuses_url":"https://api.github.com/repos/vector-im/riotX-android/statuses/38b40efac3fc46543bffb8f281a8956c438161ce","head":{"label":"vector-im:feature/soft_logout","ref":"feature/soft_logout","sha":"38b40efac3fc46543bffb8f281a8956c438161ce","user":{"login":"vector-im","id":13446337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDQ2MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"repo":{"id":151282063,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyODIwNjM=","name":"riotX-android","full_name":"vector-im/riotX-android","private":false,"owner":{"login":"vector-im","id":13446337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDQ2MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vector-im/riotX-android","description":"RiotX - Android Matrix SDK & Riot rewrites","fork":false,"url":"https://api.github.com/repos/vector-im/riotX-android","forks_url":"https://api.github.com/repos/vector-im/riotX-android/forks","keys_url":"https://api.github.com/repos/vector-im/riotX-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vector-im/riotX-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vector-im/riotX-android/teams","hooks_url":"https://api.github.com/repos/vector-im/riotX-android/hooks","issue_events_url":"https://api.github.com/repos/vector-im/riotX-android/issues/events{/number}","events_url":"https://api.github.com/repos/vector-im/riotX-android/events","assignees_url":"https://api.github.com/repos/vector-im/riotX-android/assignees{/user}","branches_url":"https://api.github.com/repos/vector-im/riotX-android/branches{/branch}","tags_url":"https://api.github.com/repos/vector-im/riotX-android/tags","blobs_url":"https://api.github.com/repos/vector-im/riotX-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vector-im/riotX-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vector-im/riotX-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/vector-im/riotX-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vector-im/riotX-android/statuses/{sha}","languages_url":"https://api.github.com/repos/vector-im/riotX-android/languages","stargazers_url":"https://api.github.com/repos/vector-im/riotX-android/stargazers","contributors_url":"https://api.github.com/repos/vector-im/riotX-android/contributors","subscribers_url":"https://api.github.com/repos/vector-im/riotX-android/subscribers","subscription_url":"https://api.github.com/repos/vector-im/riotX-android/subscription","commits_url":"https://api.github.com/repos/vector-im/riotX-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/vector-im/riotX-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/vector-im/riotX-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/vector-im/riotX-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/vector-im/riotX-android/contents/{+path}","compare_url":"https://api.github.com/repos/vector-im/riotX-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vector-im/riotX-android/merges","archive_url":"https://api.github.com/repos/vector-im/riotX-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vector-im/riotX-android/downloads","issues_url":"https://api.github.com/repos/vector-im/riotX-android/issues{/number}","pulls_url":"https://api.github.com/repos/vector-im/riotX-android/pulls{/number}","milestones_url":"https://api.github.com/repos/vector-im/riotX-android/milestones{/number}","notifications_url":"https://api.github.com/repos/vector-im/riotX-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vector-im/riotX-android/labels{/name}","releases_url":"https://api.github.com/repos/vector-im/riotX-android/releases{/id}","deployments_url":"https://api.github.com/repos/vector-im/riotX-android/deployments","created_at":"2018-10-02T15:56:15Z","updated_at":"2019-12-11T17:34:14Z","pushed_at":"2019-12-13T14:24:56Z","git_url":"git://github.com/vector-im/riotX-android.git","ssh_url":"git@github.com:vector-im/riotX-android.git","clone_url":"https://github.com/vector-im/riotX-android.git","svn_url":"https://github.com/vector-im/riotX-android","homepage":"","size":24917,"stargazers_count":235,"watchers_count":235,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":266,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":266,"watchers":235,"default_branch":"develop"}},"base":{"label":"vector-im:develop","ref":"develop","sha":"853518fbb261ea368cf5dbed4820427269ca946f","user":{"login":"vector-im","id":13446337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDQ2MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"repo":{"id":151282063,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyODIwNjM=","name":"riotX-android","full_name":"vector-im/riotX-android","private":false,"owner":{"login":"vector-im","id":13446337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDQ2MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vector-im/riotX-android","description":"RiotX - Android Matrix SDK & Riot rewrites","fork":false,"url":"https://api.github.com/repos/vector-im/riotX-android","forks_url":"https://api.github.com/repos/vector-im/riotX-android/forks","keys_url":"https://api.github.com/repos/vector-im/riotX-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vector-im/riotX-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vector-im/riotX-android/teams","hooks_url":"https://api.github.com/repos/vector-im/riotX-android/hooks","issue_events_url":"https://api.github.com/repos/vector-im/riotX-android/issues/events{/number}","events_url":"https://api.github.com/repos/vector-im/riotX-android/events","assignees_url":"https://api.github.com/repos/vector-im/riotX-android/assignees{/user}","branches_url":"https://api.github.com/repos/vector-im/riotX-android/branches{/branch}","tags_url":"https://api.github.com/repos/vector-im/riotX-android/tags","blobs_url":"https://api.github.com/repos/vector-im/riotX-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vector-im/riotX-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vector-im/riotX-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/vector-im/riotX-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vector-im/riotX-android/statuses/{sha}","languages_url":"https://api.github.com/repos/vector-im/riotX-android/languages","stargazers_url":"https://api.github.com/repos/vector-im/riotX-android/stargazers","contributors_url":"https://api.github.com/repos/vector-im/riotX-android/contributors","subscribers_url":"https://api.github.com/repos/vector-im/riotX-android/subscribers","subscription_url":"https://api.github.com/repos/vector-im/riotX-android/subscription","commits_url":"https://api.github.com/repos/vector-im/riotX-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/vector-im/riotX-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/vector-im/riotX-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/vector-im/riotX-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/vector-im/riotX-android/contents/{+path}","compare_url":"https://api.github.com/repos/vector-im/riotX-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vector-im/riotX-android/merges","archive_url":"https://api.github.com/repos/vector-im/riotX-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vector-im/riotX-android/downloads","issues_url":"https://api.github.com/repos/vector-im/riotX-android/issues{/number}","pulls_url":"https://api.github.com/repos/vector-im/riotX-android/pulls{/number}","milestones_url":"https://api.github.com/repos/vector-im/riotX-android/milestones{/number}","notifications_url":"https://api.github.com/repos/vector-im/riotX-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vector-im/riotX-android/labels{/name}","releases_url":"https://api.github.com/repos/vector-im/riotX-android/releases{/id}","deployments_url":"https://api.github.com/repos/vector-im/riotX-android/deployments","created_at":"2018-10-02T15:56:15Z","updated_at":"2019-12-11T17:34:14Z","pushed_at":"2019-12-13T14:24:56Z","git_url":"git://github.com/vector-im/riotX-android.git","ssh_url":"git@github.com:vector-im/riotX-android.git","clone_url":"https://github.com/vector-im/riotX-android.git","svn_url":"https://github.com/vector-im/riotX-android","homepage":"","size":24917,"stargazers_count":235,"watchers_count":235,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":266,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":266,"watchers":235,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/vector-im/riotX-android/pulls/768"},"html":{"href":"https://github.com/vector-im/riotX-android/pull/768"},"issue":{"href":"https://api.github.com/repos/vector-im/riotX-android/issues/768"},"comments":{"href":"https://api.github.com/repos/vector-im/riotX-android/issues/768/comments"},"review_comments":{"href":"https://api.github.com/repos/vector-im/riotX-android/pulls/768/comments"},"review_comment":{"href":"https://api.github.com/repos/vector-im/riotX-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vector-im/riotX-android/pulls/768/commits"},"statuses":{"href":"https://api.github.com/repos/vector-im/riotX-android/statuses/38b40efac3fc46543bffb8f281a8956c438161ce"}},"author_association":"MEMBER"}}
|
{
"id": 151282063,
"name": "vector-im/riotX-android",
"url": "https://api.github.com/repos/vector-im/riotX-android"
}
|
{
"id": 3940906,
"login": "bmarty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3940906?",
"url": "https://api.github.com/users/bmarty"
}
|
{
"id": 13446337,
"login": "vector-im",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13446337?",
"url": "https://api.github.com/orgs/vector-im"
}
| 2019-12-13T14:31:03 |
11083459423
|
{"actor":{"display_login":"bmarty"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cncf/sig-security/pulls/comments/282210199","pull_request_review_id":235241801,"id":282210199,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MjIxMDE5OQ==","diff_hunk":"@@ -1,10 +1,10 @@\n # Governance\n \n-The governance of the SAFE Working Group (WG) is facilited by\n-Chairs, Technical Leads, and an active group members (see [roles](roles.md)).\n-\n-Most of the work of the group is conducted by members outside of WG meetings\n-(see [process](process.md)). WG meetings serve as a forum for creating a shared\n-understanding of the cloud native security landscape with regular updates by\n-WG members on project progress and their own security-related, with on-going\n-discovery through guest presentations.\n\\ No newline at end of file\n+SIG-Security is a [CNCF Special Interest Group](https://github.com/cncf/toc/tree/master/sigs).\n+\n+* [Charter](charter.md) - mission and scope\n+* [Roles](roles.md) - the work of the group is facilited by Chairs, Technical Leads, and active group members\n+* [Process](process.md) - how projects are proposed and work is tracked\n+\n+General meetings are posted on the CNCF calendar and serve as a forum for creating a shared understanding of the cloud native security landscape with regular updates by members on project progress and their own security-related, with on-going discovery through guest presentations.","path":"governance/README.md","position":18,"original_position":18,"commit_id":"9630cac66fec6d2767004607cbe035881919cecb","original_commit_id":"9630cac66fec6d2767004607cbe035881919cecb","user":{"login":"ultrasaurus","id":41906,"node_id":"MDQ6VXNlcjQxOTA2","avatar_url":"https://avatars3.githubusercontent.com/u/41906?v=4","gravatar_id":"","url":"https://api.github.com/users/ultrasaurus","html_url":"https://github.com/ultrasaurus","followers_url":"https://api.github.com/users/ultrasaurus/followers","following_url":"https://api.github.com/users/ultrasaurus/following{/other_user}","gists_url":"https://api.github.com/users/ultrasaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrasaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrasaurus/subscriptions","organizations_url":"https://api.github.com/users/ultrasaurus/orgs","repos_url":"https://api.github.com/users/ultrasaurus/repos","events_url":"https://api.github.com/users/ultrasaurus/events{/privacy}","received_events_url":"https://api.github.com/users/ultrasaurus/received_events","type":"User","site_admin":false},"body":"asked Taylor to put on official calendar -- sorry thought that had already happened!","created_at":"2019-05-08T19:16:29Z","updated_at":"2019-05-08T19:16:30Z","html_url":"https://github.com/cncf/sig-security/pull/154#discussion_r282210199","pull_request_url":"https://api.github.com/repos/cncf/sig-security/pulls/154","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cncf/sig-security/pulls/comments/282210199"},"html":{"href":"https://github.com/cncf/sig-security/pull/154#discussion_r282210199"},"pull_request":{"href":"https://api.github.com/repos/cncf/sig-security/pulls/154"}},"in_reply_to_id":281891893},"pull_request":{"url":"https://api.github.com/repos/cncf/sig-security/pulls/154","id":272816027,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyODE2MDI3","html_url":"https://github.com/cncf/sig-security/pull/154","diff_url":"https://github.com/cncf/sig-security/pull/154.diff","patch_url":"https://github.com/cncf/sig-security/pull/154.patch","issue_url":"https://api.github.com/repos/cncf/sig-security/issues/154","number":154,"state":"open","locked":false,"title":"Charter => governance: add more details, scope, and CNCF SIG references","user":{"login":"ultrasaurus","id":41906,"node_id":"MDQ6VXNlcjQxOTA2","avatar_url":"https://avatars3.githubusercontent.com/u/41906?v=4","gravatar_id":"","url":"https://api.github.com/users/ultrasaurus","html_url":"https://github.com/ultrasaurus","followers_url":"https://api.github.com/users/ultrasaurus/followers","following_url":"https://api.github.com/users/ultrasaurus/following{/other_user}","gists_url":"https://api.github.com/users/ultrasaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrasaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrasaurus/subscriptions","organizations_url":"https://api.github.com/users/ultrasaurus/orgs","repos_url":"https://api.github.com/users/ultrasaurus/repos","events_url":"https://api.github.com/users/ultrasaurus/events{/privacy}","received_events_url":"https://api.github.com/users/ultrasaurus/received_events","type":"User","site_admin":false},"body":"The CNCF TOC SIG process include approval of the [charter](https://github.com/cncf/toc/blob/master/sigs/cncf-sigs.md#sig-charter).\r\nTo facilitate that, this PR is refactors original charter from README \r\ninto the governance folders. \r\n\r\nThen added:\r\n* some from the [Worked Example](https://docs.google.com/document/d/18ufx6TjPavfZubwrpyMwz6KkU-YA_aHaHmBBQkplnr0/edit) which SAFE WG members drafted in collaboration with TOC members\r\n* included scope from #23\r\n","created_at":"2019-04-23T17:01:57Z","updated_at":"2019-05-08T19:16:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a63071e3f8f956c6168301dd83b743a9a1439c5d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pragashj","id":31199168,"node_id":"MDQ6VXNlcjMxMTk5MTY4","avatar_url":"https://avatars2.githubusercontent.com/u/31199168?v=4","gravatar_id":"","url":"https://api.github.com/users/pragashj","html_url":"https://github.com/pragashj","followers_url":"https://api.github.com/users/pragashj/followers","following_url":"https://api.github.com/users/pragashj/following{/other_user}","gists_url":"https://api.github.com/users/pragashj/gists{/gist_id}","starred_url":"https://api.github.com/users/pragashj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pragashj/subscriptions","organizations_url":"https://api.github.com/users/pragashj/orgs","repos_url":"https://api.github.com/users/pragashj/repos","events_url":"https://api.github.com/users/pragashj/events{/privacy}","received_events_url":"https://api.github.com/users/pragashj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cncf/sig-security/pulls/154/commits","review_comments_url":"https://api.github.com/repos/cncf/sig-security/pulls/154/comments","review_comment_url":"https://api.github.com/repos/cncf/sig-security/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cncf/sig-security/issues/154/comments","statuses_url":"https://api.github.com/repos/cncf/sig-security/statuses/9630cac66fec6d2767004607cbe035881919cecb","head":{"label":"cncf:charter","ref":"charter","sha":"9630cac66fec6d2767004607cbe035881919cecb","user":{"login":"cncf","id":13455738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDU1NzM4","avatar_url":"https://avatars2.githubusercontent.com/u/13455738?v=4","gravatar_id":"","url":"https://api.github.com/users/cncf","html_url":"https://github.com/cncf","followers_url":"https://api.github.com/users/cncf/followers","following_url":"https://api.github.com/users/cncf/following{/other_user}","gists_url":"https://api.github.com/users/cncf/gists{/gist_id}","starred_url":"https://api.github.com/users/cncf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cncf/subscriptions","organizations_url":"https://api.github.com/users/cncf/orgs","repos_url":"https://api.github.com/users/cncf/repos","events_url":"https://api.github.com/users/cncf/events{/privacy}","received_events_url":"https://api.github.com/users/cncf/received_events","type":"Organization","site_admin":false},"repo":{"id":125122827,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUxMjI4Mjc=","name":"sig-security","full_name":"cncf/sig-security","private":false,"owner":{"login":"cncf","id":13455738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDU1NzM4","avatar_url":"https://avatars2.githubusercontent.com/u/13455738?v=4","gravatar_id":"","url":"https://api.github.com/users/cncf","html_url":"https://github.com/cncf","followers_url":"https://api.github.com/users/cncf/followers","following_url":"https://api.github.com/users/cncf/following{/other_user}","gists_url":"https://api.github.com/users/cncf/gists{/gist_id}","starred_url":"https://api.github.com/users/cncf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cncf/subscriptions","organizations_url":"https://api.github.com/users/cncf/orgs","repos_url":"https://api.github.com/users/cncf/repos","events_url":"https://api.github.com/users/cncf/events{/privacy}","received_events_url":"https://api.github.com/users/cncf/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cncf/sig-security","description":"CNCF SIG Security","fork":false,"url":"https://api.github.com/repos/cncf/sig-security","forks_url":"https://api.github.com/repos/cncf/sig-security/forks","keys_url":"https://api.github.com/repos/cncf/sig-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cncf/sig-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cncf/sig-security/teams","hooks_url":"https://api.github.com/repos/cncf/sig-security/hooks","issue_events_url":"https://api.github.com/repos/cncf/sig-security/issues/events{/number}","events_url":"https://api.github.com/repos/cncf/sig-security/events","assignees_url":"https://api.github.com/repos/cncf/sig-security/assignees{/user}","branches_url":"https://api.github.com/repos/cncf/sig-security/branches{/branch}","tags_url":"https://api.github.com/repos/cncf/sig-security/tags","blobs_url":"https://api.github.com/repos/cncf/sig-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cncf/sig-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cncf/sig-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/cncf/sig-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cncf/sig-security/statuses/{sha}","languages_url":"https://api.github.com/repos/cncf/sig-security/languages","stargazers_url":"https://api.github.com/repos/cncf/sig-security/stargazers","contributors_url":"https://api.github.com/repos/cncf/sig-security/contributors","subscribers_url":"https://api.github.com/repos/cncf/sig-security/subscribers","subscription_url":"https://api.github.com/repos/cncf/sig-security/subscription","commits_url":"https://api.github.com/repos/cncf/sig-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/cncf/sig-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/cncf/sig-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/cncf/sig-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/cncf/sig-security/contents/{+path}","compare_url":"https://api.github.com/repos/cncf/sig-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cncf/sig-security/merges","archive_url":"https://api.github.com/repos/cncf/sig-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cncf/sig-security/downloads","issues_url":"https://api.github.com/repos/cncf/sig-security/issues{/number}","pulls_url":"https://api.github.com/repos/cncf/sig-security/pulls{/number}","milestones_url":"https://api.github.com/repos/cncf/sig-security/milestones{/number}","notifications_url":"https://api.github.com/repos/cncf/sig-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cncf/sig-security/labels{/name}","releases_url":"https://api.github.com/repos/cncf/sig-security/releases{/id}","deployments_url":"https://api.github.com/repos/cncf/sig-security/deployments","created_at":"2018-03-13T22:30:42Z","updated_at":"2019-05-07T23:36:12Z","pushed_at":"2019-05-07T23:56:12Z","git_url":"git://github.com/cncf/sig-security.git","ssh_url":"git@github.com:cncf/sig-security.git","clone_url":"https://github.com/cncf/sig-security.git","svn_url":"https://github.com/cncf/sig-security","homepage":"https://cncf.io","size":208,"stargazers_count":25,"watchers_count":25,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":41,"open_issues":52,"watchers":25,"default_branch":"master"}},"base":{"label":"cncf:master","ref":"master","sha":"2181f79b6b61c17edb6584e23ca186f56f940d40","user":{"login":"cncf","id":13455738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDU1NzM4","avatar_url":"https://avatars2.githubusercontent.com/u/13455738?v=4","gravatar_id":"","url":"https://api.github.com/users/cncf","html_url":"https://github.com/cncf","followers_url":"https://api.github.com/users/cncf/followers","following_url":"https://api.github.com/users/cncf/following{/other_user}","gists_url":"https://api.github.com/users/cncf/gists{/gist_id}","starred_url":"https://api.github.com/users/cncf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cncf/subscriptions","organizations_url":"https://api.github.com/users/cncf/orgs","repos_url":"https://api.github.com/users/cncf/repos","events_url":"https://api.github.com/users/cncf/events{/privacy}","received_events_url":"https://api.github.com/users/cncf/received_events","type":"Organization","site_admin":false},"repo":{"id":125122827,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUxMjI4Mjc=","name":"sig-security","full_name":"cncf/sig-security","private":false,"owner":{"login":"cncf","id":13455738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDU1NzM4","avatar_url":"https://avatars2.githubusercontent.com/u/13455738?v=4","gravatar_id":"","url":"https://api.github.com/users/cncf","html_url":"https://github.com/cncf","followers_url":"https://api.github.com/users/cncf/followers","following_url":"https://api.github.com/users/cncf/following{/other_user}","gists_url":"https://api.github.com/users/cncf/gists{/gist_id}","starred_url":"https://api.github.com/users/cncf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cncf/subscriptions","organizations_url":"https://api.github.com/users/cncf/orgs","repos_url":"https://api.github.com/users/cncf/repos","events_url":"https://api.github.com/users/cncf/events{/privacy}","received_events_url":"https://api.github.com/users/cncf/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cncf/sig-security","description":"CNCF SIG Security","fork":false,"url":"https://api.github.com/repos/cncf/sig-security","forks_url":"https://api.github.com/repos/cncf/sig-security/forks","keys_url":"https://api.github.com/repos/cncf/sig-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cncf/sig-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cncf/sig-security/teams","hooks_url":"https://api.github.com/repos/cncf/sig-security/hooks","issue_events_url":"https://api.github.com/repos/cncf/sig-security/issues/events{/number}","events_url":"https://api.github.com/repos/cncf/sig-security/events","assignees_url":"https://api.github.com/repos/cncf/sig-security/assignees{/user}","branches_url":"https://api.github.com/repos/cncf/sig-security/branches{/branch}","tags_url":"https://api.github.com/repos/cncf/sig-security/tags","blobs_url":"https://api.github.com/repos/cncf/sig-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cncf/sig-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cncf/sig-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/cncf/sig-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cncf/sig-security/statuses/{sha}","languages_url":"https://api.github.com/repos/cncf/sig-security/languages","stargazers_url":"https://api.github.com/repos/cncf/sig-security/stargazers","contributors_url":"https://api.github.com/repos/cncf/sig-security/contributors","subscribers_url":"https://api.github.com/repos/cncf/sig-security/subscribers","subscription_url":"https://api.github.com/repos/cncf/sig-security/subscription","commits_url":"https://api.github.com/repos/cncf/sig-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/cncf/sig-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/cncf/sig-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/cncf/sig-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/cncf/sig-security/contents/{+path}","compare_url":"https://api.github.com/repos/cncf/sig-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cncf/sig-security/merges","archive_url":"https://api.github.com/repos/cncf/sig-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cncf/sig-security/downloads","issues_url":"https://api.github.com/repos/cncf/sig-security/issues{/number}","pulls_url":"https://api.github.com/repos/cncf/sig-security/pulls{/number}","milestones_url":"https://api.github.com/repos/cncf/sig-security/milestones{/number}","notifications_url":"https://api.github.com/repos/cncf/sig-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cncf/sig-security/labels{/name}","releases_url":"https://api.github.com/repos/cncf/sig-security/releases{/id}","deployments_url":"https://api.github.com/repos/cncf/sig-security/deployments","created_at":"2018-03-13T22:30:42Z","updated_at":"2019-05-07T23:36:12Z","pushed_at":"2019-05-07T23:56:12Z","git_url":"git://github.com/cncf/sig-security.git","ssh_url":"git@github.com:cncf/sig-security.git","clone_url":"https://github.com/cncf/sig-security.git","svn_url":"https://github.com/cncf/sig-security","homepage":"https://cncf.io","size":208,"stargazers_count":25,"watchers_count":25,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":41,"open_issues":52,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cncf/sig-security/pulls/154"},"html":{"href":"https://github.com/cncf/sig-security/pull/154"},"issue":{"href":"https://api.github.com/repos/cncf/sig-security/issues/154"},"comments":{"href":"https://api.github.com/repos/cncf/sig-security/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/cncf/sig-security/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/cncf/sig-security/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cncf/sig-security/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/cncf/sig-security/statuses/9630cac66fec6d2767004607cbe035881919cecb"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 125122827,
"name": "cncf/sig-security",
"url": "https://api.github.com/repos/cncf/sig-security"
}
|
{
"id": 41906,
"login": "ultrasaurus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41906?",
"url": "https://api.github.com/users/ultrasaurus"
}
|
{
"id": 13455738,
"login": "cncf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13455738?",
"url": "https://api.github.com/orgs/cncf"
}
| 2019-05-08T19:16:29 |
9588764306
|
{"actor":{"display_login":"ultrasaurus"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/comments/255815149","pull_request_review_id":202498835,"id":255815149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTgxNTE0OQ==","diff_hunk":"@@ -0,0 +1,28 @@\n+module Comments","path":"app/view_objects/comments/tree.rb","position":1,"original_position":1,"commit_id":"acf7b30f7cc747c413f1582b3e4aaa0328d31968","original_commit_id":"acf7b30f7cc747c413f1582b3e4aaa0328d31968","user":{"login":"lightalloy","id":30115,"node_id":"MDQ6VXNlcjMwMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/30115?v=4","gravatar_id":"","url":"https://api.github.com/users/lightalloy","html_url":"https://github.com/lightalloy","followers_url":"https://api.github.com/users/lightalloy/followers","following_url":"https://api.github.com/users/lightalloy/following{/other_user}","gists_url":"https://api.github.com/users/lightalloy/gists{/gist_id}","starred_url":"https://api.github.com/users/lightalloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightalloy/subscriptions","organizations_url":"https://api.github.com/users/lightalloy/orgs","repos_url":"https://api.github.com/users/lightalloy/repos","events_url":"https://api.github.com/users/lightalloy/events{/privacy}","received_events_url":"https://api.github.com/users/lightalloy/received_events","type":"User","site_admin":false},"body":"Probably I'll have to remove the view object from this pr, but I think this concept could be used for refactoring in other places.","created_at":"2019-02-12T06:15:49Z","updated_at":"2019-02-12T06:15:49Z","html_url":"https://github.com/thepracticaldev/dev.to/pull/1766#discussion_r255815149","pull_request_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1766","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/comments/255815149"},"html":{"href":"https://github.com/thepracticaldev/dev.to/pull/1766#discussion_r255815149"},"pull_request":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1766"}},"in_reply_to_id":255496677},"pull_request":{"url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1766","id":251433323,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNDMzMzIz","html_url":"https://github.com/thepracticaldev/dev.to/pull/1766","diff_url":"https://github.com/thepracticaldev/dev.to/pull/1766.diff","patch_url":"https://github.com/thepracticaldev/dev.to/pull/1766.patch","issue_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/1766","number":1766,"state":"open","locked":false,"title":"[WIP] Reduce the number of sql queries for articles comments #1606","user":{"login":"lightalloy","id":30115,"node_id":"MDQ6VXNlcjMwMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/30115?v=4","gravatar_id":"","url":"https://api.github.com/users/lightalloy","html_url":"https://github.com/lightalloy","followers_url":"https://api.github.com/users/lightalloy/followers","following_url":"https://api.github.com/users/lightalloy/following{/other_user}","gists_url":"https://api.github.com/users/lightalloy/gists{/gist_id}","starred_url":"https://api.github.com/users/lightalloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightalloy/subscriptions","organizations_url":"https://api.github.com/users/lightalloy/orgs","repos_url":"https://api.github.com/users/lightalloy/repos","events_url":"https://api.github.com/users/lightalloy/events{/privacy}","received_events_url":"https://api.github.com/users/lightalloy/received_events","type":"User","site_admin":false},"body":"## What type of PR is this? (check all applicable)\r\n- [x] Refactor\r\n\r\n## Description\r\nEliminate N+1 while loading articles comments.\r\nTODO: \r\n- refactor\r\n- explore the ways to limit the number of comments loaded from the database.\r\n\r\n## Related Tickets & Documents\r\n#1606 \r\n\r\n## Added to documentation?\r\n- [x] no documentation needed","created_at":"2019-02-08T11:29:12Z","updated_at":"2019-02-12T06:15:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05b8aff85c3ccd6d0726017767fdbcc9562fdbc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1766/commits","review_comments_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1766/comments","review_comment_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/1766/comments","statuses_url":"https://api.github.com/repos/thepracticaldev/dev.to/statuses/acf7b30f7cc747c413f1582b3e4aaa0328d31968","head":{"label":"lightalloy:reduce-comments-queries","ref":"reduce-comments-queries","sha":"acf7b30f7cc747c413f1582b3e4aaa0328d31968","user":{"login":"lightalloy","id":30115,"node_id":"MDQ6VXNlcjMwMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/30115?v=4","gravatar_id":"","url":"https://api.github.com/users/lightalloy","html_url":"https://github.com/lightalloy","followers_url":"https://api.github.com/users/lightalloy/followers","following_url":"https://api.github.com/users/lightalloy/following{/other_user}","gists_url":"https://api.github.com/users/lightalloy/gists{/gist_id}","starred_url":"https://api.github.com/users/lightalloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightalloy/subscriptions","organizations_url":"https://api.github.com/users/lightalloy/orgs","repos_url":"https://api.github.com/users/lightalloy/repos","events_url":"https://api.github.com/users/lightalloy/events{/privacy}","received_events_url":"https://api.github.com/users/lightalloy/received_events","type":"User","site_admin":false},"repo":{"id":157688051,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc2ODgwNTE=","name":"dev.to","full_name":"lightalloy/dev.to","private":false,"owner":{"login":"lightalloy","id":30115,"node_id":"MDQ6VXNlcjMwMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/30115?v=4","gravatar_id":"","url":"https://api.github.com/users/lightalloy","html_url":"https://github.com/lightalloy","followers_url":"https://api.github.com/users/lightalloy/followers","following_url":"https://api.github.com/users/lightalloy/following{/other_user}","gists_url":"https://api.github.com/users/lightalloy/gists{/gist_id}","starred_url":"https://api.github.com/users/lightalloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightalloy/subscriptions","organizations_url":"https://api.github.com/users/lightalloy/orgs","repos_url":"https://api.github.com/users/lightalloy/repos","events_url":"https://api.github.com/users/lightalloy/events{/privacy}","received_events_url":"https://api.github.com/users/lightalloy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lightalloy/dev.to","description":"Where programmers share ideas and help each other grow","fork":true,"url":"https://api.github.com/repos/lightalloy/dev.to","forks_url":"https://api.github.com/repos/lightalloy/dev.to/forks","keys_url":"https://api.github.com/repos/lightalloy/dev.to/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightalloy/dev.to/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightalloy/dev.to/teams","hooks_url":"https://api.github.com/repos/lightalloy/dev.to/hooks","issue_events_url":"https://api.github.com/repos/lightalloy/dev.to/issues/events{/number}","events_url":"https://api.github.com/repos/lightalloy/dev.to/events","assignees_url":"https://api.github.com/repos/lightalloy/dev.to/assignees{/user}","branches_url":"https://api.github.com/repos/lightalloy/dev.to/branches{/branch}","tags_url":"https://api.github.com/repos/lightalloy/dev.to/tags","blobs_url":"https://api.github.com/repos/lightalloy/dev.to/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightalloy/dev.to/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightalloy/dev.to/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightalloy/dev.to/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightalloy/dev.to/statuses/{sha}","languages_url":"https://api.github.com/repos/lightalloy/dev.to/languages","stargazers_url":"https://api.github.com/repos/lightalloy/dev.to/stargazers","contributors_url":"https://api.github.com/repos/lightalloy/dev.to/contributors","subscribers_url":"https://api.github.com/repos/lightalloy/dev.to/subscribers","subscription_url":"https://api.github.com/repos/lightalloy/dev.to/subscription","commits_url":"https://api.github.com/repos/lightalloy/dev.to/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightalloy/dev.to/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightalloy/dev.to/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightalloy/dev.to/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightalloy/dev.to/contents/{+path}","compare_url":"https://api.github.com/repos/lightalloy/dev.to/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightalloy/dev.to/merges","archive_url":"https://api.github.com/repos/lightalloy/dev.to/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightalloy/dev.to/downloads","issues_url":"https://api.github.com/repos/lightalloy/dev.to/issues{/number}","pulls_url":"https://api.github.com/repos/lightalloy/dev.to/pulls{/number}","milestones_url":"https://api.github.com/repos/lightalloy/dev.to/milestones{/number}","notifications_url":"https://api.github.com/repos/lightalloy/dev.to/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightalloy/dev.to/labels{/name}","releases_url":"https://api.github.com/repos/lightalloy/dev.to/releases{/id}","deployments_url":"https://api.github.com/repos/lightalloy/dev.to/deployments","created_at":"2018-11-15T09:46:39Z","updated_at":"2019-02-05T09:47:42Z","pushed_at":"2019-02-11T12:45:18Z","git_url":"git://github.com/lightalloy/dev.to.git","ssh_url":"git@github.com:lightalloy/dev.to.git","clone_url":"https://github.com/lightalloy/dev.to.git","svn_url":"https://github.com/lightalloy/dev.to","homepage":"https://dev.to","size":24059,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thepracticaldev:master","ref":"master","sha":"7f6e0cf185a2c51cc2c1d3198d0f9c57a5602db3","user":{"login":"thepracticaldev","id":13521919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTIxOTE5","avatar_url":"https://avatars1.githubusercontent.com/u/13521919?v=4","gravatar_id":"","url":"https://api.github.com/users/thepracticaldev","html_url":"https://github.com/thepracticaldev","followers_url":"https://api.github.com/users/thepracticaldev/followers","following_url":"https://api.github.com/users/thepracticaldev/following{/other_user}","gists_url":"https://api.github.com/users/thepracticaldev/gists{/gist_id}","starred_url":"https://api.github.com/users/thepracticaldev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepracticaldev/subscriptions","organizations_url":"https://api.github.com/users/thepracticaldev/orgs","repos_url":"https://api.github.com/users/thepracticaldev/repos","events_url":"https://api.github.com/users/thepracticaldev/events{/privacy}","received_events_url":"https://api.github.com/users/thepracticaldev/received_events","type":"Organization","site_admin":false},"repo":{"id":73648678,"node_id":"MDEwOlJlcG9zaXRvcnk3MzY0ODY3OA==","name":"dev.to","full_name":"thepracticaldev/dev.to","private":false,"owner":{"login":"thepracticaldev","id":13521919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTIxOTE5","avatar_url":"https://avatars1.githubusercontent.com/u/13521919?v=4","gravatar_id":"","url":"https://api.github.com/users/thepracticaldev","html_url":"https://github.com/thepracticaldev","followers_url":"https://api.github.com/users/thepracticaldev/followers","following_url":"https://api.github.com/users/thepracticaldev/following{/other_user}","gists_url":"https://api.github.com/users/thepracticaldev/gists{/gist_id}","starred_url":"https://api.github.com/users/thepracticaldev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepracticaldev/subscriptions","organizations_url":"https://api.github.com/users/thepracticaldev/orgs","repos_url":"https://api.github.com/users/thepracticaldev/repos","events_url":"https://api.github.com/users/thepracticaldev/events{/privacy}","received_events_url":"https://api.github.com/users/thepracticaldev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thepracticaldev/dev.to","description":"Where programmers share ideas and help each other grow","fork":false,"url":"https://api.github.com/repos/thepracticaldev/dev.to","forks_url":"https://api.github.com/repos/thepracticaldev/dev.to/forks","keys_url":"https://api.github.com/repos/thepracticaldev/dev.to/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thepracticaldev/dev.to/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thepracticaldev/dev.to/teams","hooks_url":"https://api.github.com/repos/thepracticaldev/dev.to/hooks","issue_events_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/events{/number}","events_url":"https://api.github.com/repos/thepracticaldev/dev.to/events","assignees_url":"https://api.github.com/repos/thepracticaldev/dev.to/assignees{/user}","branches_url":"https://api.github.com/repos/thepracticaldev/dev.to/branches{/branch}","tags_url":"https://api.github.com/repos/thepracticaldev/dev.to/tags","blobs_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/refs{/sha}","trees_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thepracticaldev/dev.to/statuses/{sha}","languages_url":"https://api.github.com/repos/thepracticaldev/dev.to/languages","stargazers_url":"https://api.github.com/repos/thepracticaldev/dev.to/stargazers","contributors_url":"https://api.github.com/repos/thepracticaldev/dev.to/contributors","subscribers_url":"https://api.github.com/repos/thepracticaldev/dev.to/subscribers","subscription_url":"https://api.github.com/repos/thepracticaldev/dev.to/subscription","commits_url":"https://api.github.com/repos/thepracticaldev/dev.to/commits{/sha}","git_commits_url":"https://api.github.com/repos/thepracticaldev/dev.to/git/commits{/sha}","comments_url":"https://api.github.com/repos/thepracticaldev/dev.to/comments{/number}","issue_comment_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/comments{/number}","contents_url":"https://api.github.com/repos/thepracticaldev/dev.to/contents/{+path}","compare_url":"https://api.github.com/repos/thepracticaldev/dev.to/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thepracticaldev/dev.to/merges","archive_url":"https://api.github.com/repos/thepracticaldev/dev.to/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thepracticaldev/dev.to/downloads","issues_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues{/number}","pulls_url":"https://api.github.com/repos/thepracticaldev/dev.to/pulls{/number}","milestones_url":"https://api.github.com/repos/thepracticaldev/dev.to/milestones{/number}","notifications_url":"https://api.github.com/repos/thepracticaldev/dev.to/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thepracticaldev/dev.to/labels{/name}","releases_url":"https://api.github.com/repos/thepracticaldev/dev.to/releases{/id}","deployments_url":"https://api.github.com/repos/thepracticaldev/dev.to/deployments","created_at":"2016-11-13T23:02:13Z","updated_at":"2019-02-12T02:03:55Z","pushed_at":"2019-02-12T03:24:02Z","git_url":"git://github.com/thepracticaldev/dev.to.git","ssh_url":"git@github.com:thepracticaldev/dev.to.git","clone_url":"https://github.com/thepracticaldev/dev.to.git","svn_url":"https://github.com/thepracticaldev/dev.to","homepage":"https://dev.to","size":24231,"stargazers_count":8260,"watchers_count":8260,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":847,"mirror_url":null,"archived":false,"open_issues_count":257,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":847,"open_issues":257,"watchers":8260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1766"},"html":{"href":"https://github.com/thepracticaldev/dev.to/pull/1766"},"issue":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/issues/1766"},"comments":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/issues/1766/comments"},"review_comments":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1766/comments"},"review_comment":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/pulls/1766/commits"},"statuses":{"href":"https://api.github.com/repos/thepracticaldev/dev.to/statuses/acf7b30f7cc747c413f1582b3e4aaa0328d31968"}},"author_association":"COLLABORATOR"}}
|
{
"id": 73648678,
"name": "thepracticaldev/dev.to",
"url": "https://api.github.com/repos/thepracticaldev/dev.to"
}
|
{
"id": 30115,
"login": "lightalloy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30115?",
"url": "https://api.github.com/users/lightalloy"
}
|
{
"id": 13521919,
"login": "thepracticaldev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13521919?",
"url": "https://api.github.com/orgs/thepracticaldev"
}
| 2019-02-12T06:15:49 |
9049761216
|
{"actor":{"display_login":"lightalloy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ruby-grape/grape/pulls/comments/337102575","pull_request_review_id":304673509,"id":337102575,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzEwMjU3NQ==","diff_hunk":"@@ -3121,6 +3132,8 @@ end\n \n Use [Doorkeeper](https://github.com/doorkeeper-gem/doorkeeper), [warden-oauth2](https://github.com/opperator/warden-oauth2) or [rack-oauth2](https://github.com/nov/rack-oauth2) for OAuth2 support.\n \n+You can access the controller context with the `#context` method inside any auth middleware inherited from `Grape::Middlware::Auth::Base`.","path":"README.md","position":22,"original_position":22,"commit_id":"8d5a85d9c98af2d21313ae7ab2c38132a575d2dc","original_commit_id":"8d5a85d9c98af2d21313ae7ab2c38132a575d2dc","user":{"login":"NikolayRys","id":2265459,"node_id":"MDQ6VXNlcjIyNjU0NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2265459?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolayRys","html_url":"https://github.com/NikolayRys","followers_url":"https://api.github.com/users/NikolayRys/followers","following_url":"https://api.github.com/users/NikolayRys/following{/other_user}","gists_url":"https://api.github.com/users/NikolayRys/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolayRys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolayRys/subscriptions","organizations_url":"https://api.github.com/users/NikolayRys/orgs","repos_url":"https://api.github.com/users/NikolayRys/repos","events_url":"https://api.github.com/users/NikolayRys/events{/privacy}","received_events_url":"https://api.github.com/users/NikolayRys/received_events","type":"User","site_admin":false},"body":"Yes, the helpers are accessible :) \r\nI'll improve the wording","created_at":"2019-10-21T16:01:22Z","updated_at":"2019-10-21T16:01:22Z","html_url":"https://github.com/ruby-grape/grape/pull/1918#discussion_r337102575","pull_request_url":"https://api.github.com/repos/ruby-grape/grape/pulls/1918","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ruby-grape/grape/pulls/comments/337102575"},"html":{"href":"https://github.com/ruby-grape/grape/pull/1918#discussion_r337102575"},"pull_request":{"href":"https://api.github.com/repos/ruby-grape/grape/pulls/1918"}},"in_reply_to_id":336991135},"pull_request":{"url":"https://api.github.com/repos/ruby-grape/grape/pulls/1918","id":328562895,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4NTYyODk1","html_url":"https://github.com/ruby-grape/grape/pull/1918","diff_url":"https://github.com/ruby-grape/grape/pull/1918.diff","patch_url":"https://github.com/ruby-grape/grape/pull/1918.patch","issue_url":"https://api.github.com/repos/ruby-grape/grape/issues/1918","number":1918,"state":"open","locked":false,"title":"Helper method to access controller context in middleware","user":{"login":"NikolayRys","id":2265459,"node_id":"MDQ6VXNlcjIyNjU0NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2265459?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolayRys","html_url":"https://github.com/NikolayRys","followers_url":"https://api.github.com/users/NikolayRys/followers","following_url":"https://api.github.com/users/NikolayRys/following{/other_user}","gists_url":"https://api.github.com/users/NikolayRys/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolayRys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolayRys/subscriptions","organizations_url":"https://api.github.com/users/NikolayRys/orgs","repos_url":"https://api.github.com/users/NikolayRys/repos","events_url":"https://api.github.com/users/NikolayRys/events{/privacy}","received_events_url":"https://api.github.com/users/NikolayRys/received_events","type":"User","site_admin":false},"body":"This is a feature suggestion.\r\n\r\nRecently, working with Grape and writing some `rescue_from` handlers, I've encountered a need to access the request params, headers, and some other stuff how it was in the original controller method.\r\n\r\nIt was possible, but there was no documented and elegant way to do it. And I needed to go through the Grape source code to figure out a way to reach it. \r\n\r\nWith this change, we can save effort and time for other clients by preventing the need to rediscover this. It is useful not only for the error handling, but also for every piece of the middleware, including formatters, and any custom middleware inherited from Grape::Middleware::Base.\r\n\r\nThis PR adds the actual helper method for accessing the context, tests, and documentation for it.","created_at":"2019-10-16T04:27:39Z","updated_at":"2019-10-21T16:01:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b5ecc7f78d7264d458cbeb18b13b2f5ccd2a8a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ruby-grape/grape/pulls/1918/commits","review_comments_url":"https://api.github.com/repos/ruby-grape/grape/pulls/1918/comments","review_comment_url":"https://api.github.com/repos/ruby-grape/grape/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruby-grape/grape/issues/1918/comments","statuses_url":"https://api.github.com/repos/ruby-grape/grape/statuses/8d5a85d9c98af2d21313ae7ab2c38132a575d2dc","head":{"label":"NikolayRys:convenient_env_access","ref":"convenient_env_access","sha":"8d5a85d9c98af2d21313ae7ab2c38132a575d2dc","user":{"login":"NikolayRys","id":2265459,"node_id":"MDQ6VXNlcjIyNjU0NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2265459?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolayRys","html_url":"https://github.com/NikolayRys","followers_url":"https://api.github.com/users/NikolayRys/followers","following_url":"https://api.github.com/users/NikolayRys/following{/other_user}","gists_url":"https://api.github.com/users/NikolayRys/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolayRys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolayRys/subscriptions","organizations_url":"https://api.github.com/users/NikolayRys/orgs","repos_url":"https://api.github.com/users/NikolayRys/repos","events_url":"https://api.github.com/users/NikolayRys/events{/privacy}","received_events_url":"https://api.github.com/users/NikolayRys/received_events","type":"User","site_admin":false},"repo":{"id":210970326,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA5NzAzMjY=","name":"grape","full_name":"NikolayRys/grape","private":false,"owner":{"login":"NikolayRys","id":2265459,"node_id":"MDQ6VXNlcjIyNjU0NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2265459?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolayRys","html_url":"https://github.com/NikolayRys","followers_url":"https://api.github.com/users/NikolayRys/followers","following_url":"https://api.github.com/users/NikolayRys/following{/other_user}","gists_url":"https://api.github.com/users/NikolayRys/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolayRys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolayRys/subscriptions","organizations_url":"https://api.github.com/users/NikolayRys/orgs","repos_url":"https://api.github.com/users/NikolayRys/repos","events_url":"https://api.github.com/users/NikolayRys/events{/privacy}","received_events_url":"https://api.github.com/users/NikolayRys/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NikolayRys/grape","description":"An opinionated framework for creating REST-like APIs in Ruby.","fork":true,"url":"https://api.github.com/repos/NikolayRys/grape","forks_url":"https://api.github.com/repos/NikolayRys/grape/forks","keys_url":"https://api.github.com/repos/NikolayRys/grape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NikolayRys/grape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NikolayRys/grape/teams","hooks_url":"https://api.github.com/repos/NikolayRys/grape/hooks","issue_events_url":"https://api.github.com/repos/NikolayRys/grape/issues/events{/number}","events_url":"https://api.github.com/repos/NikolayRys/grape/events","assignees_url":"https://api.github.com/repos/NikolayRys/grape/assignees{/user}","branches_url":"https://api.github.com/repos/NikolayRys/grape/branches{/branch}","tags_url":"https://api.github.com/repos/NikolayRys/grape/tags","blobs_url":"https://api.github.com/repos/NikolayRys/grape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NikolayRys/grape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NikolayRys/grape/git/refs{/sha}","trees_url":"https://api.github.com/repos/NikolayRys/grape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NikolayRys/grape/statuses/{sha}","languages_url":"https://api.github.com/repos/NikolayRys/grape/languages","stargazers_url":"https://api.github.com/repos/NikolayRys/grape/stargazers","contributors_url":"https://api.github.com/repos/NikolayRys/grape/contributors","subscribers_url":"https://api.github.com/repos/NikolayRys/grape/subscribers","subscription_url":"https://api.github.com/repos/NikolayRys/grape/subscription","commits_url":"https://api.github.com/repos/NikolayRys/grape/commits{/sha}","git_commits_url":"https://api.github.com/repos/NikolayRys/grape/git/commits{/sha}","comments_url":"https://api.github.com/repos/NikolayRys/grape/comments{/number}","issue_comment_url":"https://api.github.com/repos/NikolayRys/grape/issues/comments{/number}","contents_url":"https://api.github.com/repos/NikolayRys/grape/contents/{+path}","compare_url":"https://api.github.com/repos/NikolayRys/grape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NikolayRys/grape/merges","archive_url":"https://api.github.com/repos/NikolayRys/grape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NikolayRys/grape/downloads","issues_url":"https://api.github.com/repos/NikolayRys/grape/issues{/number}","pulls_url":"https://api.github.com/repos/NikolayRys/grape/pulls{/number}","milestones_url":"https://api.github.com/repos/NikolayRys/grape/milestones{/number}","notifications_url":"https://api.github.com/repos/NikolayRys/grape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NikolayRys/grape/labels{/name}","releases_url":"https://api.github.com/repos/NikolayRys/grape/releases{/id}","deployments_url":"https://api.github.com/repos/NikolayRys/grape/deployments","created_at":"2019-09-26T01:10:08Z","updated_at":"2019-09-26T01:10:10Z","pushed_at":"2019-10-20T17:48:39Z","git_url":"git://github.com/NikolayRys/grape.git","ssh_url":"git@github.com:NikolayRys/grape.git","clone_url":"https://github.com/NikolayRys/grape.git","svn_url":"https://github.com/NikolayRys/grape","homepage":"http://www.ruby-grape.org","size":4730,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruby-grape:master","ref":"master","sha":"f8b52e34099d9990937b3db6e9b1939b489ea1c2","user":{"login":"ruby-grape","id":13624553,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI0NTUz","avatar_url":"https://avatars1.githubusercontent.com/u/13624553?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby-grape","html_url":"https://github.com/ruby-grape","followers_url":"https://api.github.com/users/ruby-grape/followers","following_url":"https://api.github.com/users/ruby-grape/following{/other_user}","gists_url":"https://api.github.com/users/ruby-grape/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-grape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-grape/subscriptions","organizations_url":"https://api.github.com/users/ruby-grape/orgs","repos_url":"https://api.github.com/users/ruby-grape/repos","events_url":"https://api.github.com/users/ruby-grape/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-grape/received_events","type":"Organization","site_admin":false},"repo":{"id":812393,"node_id":"MDEwOlJlcG9zaXRvcnk4MTIzOTM=","name":"grape","full_name":"ruby-grape/grape","private":false,"owner":{"login":"ruby-grape","id":13624553,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI0NTUz","avatar_url":"https://avatars1.githubusercontent.com/u/13624553?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby-grape","html_url":"https://github.com/ruby-grape","followers_url":"https://api.github.com/users/ruby-grape/followers","following_url":"https://api.github.com/users/ruby-grape/following{/other_user}","gists_url":"https://api.github.com/users/ruby-grape/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-grape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-grape/subscriptions","organizations_url":"https://api.github.com/users/ruby-grape/orgs","repos_url":"https://api.github.com/users/ruby-grape/repos","events_url":"https://api.github.com/users/ruby-grape/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-grape/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ruby-grape/grape","description":"An opinionated framework for creating REST-like APIs in Ruby.","fork":false,"url":"https://api.github.com/repos/ruby-grape/grape","forks_url":"https://api.github.com/repos/ruby-grape/grape/forks","keys_url":"https://api.github.com/repos/ruby-grape/grape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby-grape/grape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby-grape/grape/teams","hooks_url":"https://api.github.com/repos/ruby-grape/grape/hooks","issue_events_url":"https://api.github.com/repos/ruby-grape/grape/issues/events{/number}","events_url":"https://api.github.com/repos/ruby-grape/grape/events","assignees_url":"https://api.github.com/repos/ruby-grape/grape/assignees{/user}","branches_url":"https://api.github.com/repos/ruby-grape/grape/branches{/branch}","tags_url":"https://api.github.com/repos/ruby-grape/grape/tags","blobs_url":"https://api.github.com/repos/ruby-grape/grape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby-grape/grape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby-grape/grape/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby-grape/grape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby-grape/grape/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby-grape/grape/languages","stargazers_url":"https://api.github.com/repos/ruby-grape/grape/stargazers","contributors_url":"https://api.github.com/repos/ruby-grape/grape/contributors","subscribers_url":"https://api.github.com/repos/ruby-grape/grape/subscribers","subscription_url":"https://api.github.com/repos/ruby-grape/grape/subscription","commits_url":"https://api.github.com/repos/ruby-grape/grape/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby-grape/grape/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby-grape/grape/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby-grape/grape/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruby-grape/grape/contents/{+path}","compare_url":"https://api.github.com/repos/ruby-grape/grape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby-grape/grape/merges","archive_url":"https://api.github.com/repos/ruby-grape/grape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby-grape/grape/downloads","issues_url":"https://api.github.com/repos/ruby-grape/grape/issues{/number}","pulls_url":"https://api.github.com/repos/ruby-grape/grape/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby-grape/grape/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby-grape/grape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby-grape/grape/labels{/name}","releases_url":"https://api.github.com/repos/ruby-grape/grape/releases{/id}","deployments_url":"https://api.github.com/repos/ruby-grape/grape/deployments","created_at":"2010-08-02T14:25:08Z","updated_at":"2019-10-21T06:07:56Z","pushed_at":"2019-10-20T17:48:42Z","git_url":"git://github.com/ruby-grape/grape.git","ssh_url":"git@github.com:ruby-grape/grape.git","clone_url":"https://github.com/ruby-grape/grape.git","svn_url":"https://github.com/ruby-grape/grape","homepage":"http://www.ruby-grape.org","size":4746,"stargazers_count":8935,"watchers_count":8935,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1100,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":218,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1100,"open_issues":218,"watchers":8935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby-grape/grape/pulls/1918"},"html":{"href":"https://github.com/ruby-grape/grape/pull/1918"},"issue":{"href":"https://api.github.com/repos/ruby-grape/grape/issues/1918"},"comments":{"href":"https://api.github.com/repos/ruby-grape/grape/issues/1918/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby-grape/grape/pulls/1918/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby-grape/grape/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruby-grape/grape/pulls/1918/commits"},"statuses":{"href":"https://api.github.com/repos/ruby-grape/grape/statuses/8d5a85d9c98af2d21313ae7ab2c38132a575d2dc"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 812393,
"name": "ruby-grape/grape",
"url": "https://api.github.com/repos/ruby-grape/grape"
}
|
{
"id": 2265459,
"login": "NikolayRys",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2265459?",
"url": "https://api.github.com/users/NikolayRys"
}
|
{
"id": 13624553,
"login": "ruby-grape",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13624553?",
"url": "https://api.github.com/orgs/ruby-grape"
}
| 2019-10-21T16:01:22 |
10677789524
|
{"actor":{"display_login":"NikolayRys"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/website/pulls/comments/334258148","pull_request_review_id":301027647,"id":334258148,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDI1ODE0OA==","diff_hunk":"@@ -0,0 +1,506 @@\n+---\n+title: Jobs - Dijalankan Hingga Selesai\n+content_template: templates/concept\n+feature:\n+ title: Eksekusi batch\n+ description: >\n+ Selain service, Kubernetes juga dapat melakukan manajemen workload batch dan CI, melakukan penggantian container-container yang gagal, jika diinginkan.\n+weight: 70\n+---\n+\n+{{% capture overview %}}\n+\n+Sebuah job membuat satu atau lebih Pod dan menjamin bahwa jumlah Pod yang telah dispesifikasikan sebelumnya \n+berhasil dijalankan. Pada saat Pod telah dihentikan, Job akan menandainya sebagai Job yang sudah berhasil dijalankan.\n+Ketika jumlah sukses yang dispesifikasikan sebelumnya sudah terpenuhi, maka Job tersebut dianggap selesai. \n+Menghapus sebuah Job akan menghapus semua Pod yang dibuat oleh Job tersebut.\n+\n+Sebuah kasus sederhana yang dapat diberikan adalah membuat sebuah objek Job untuk menjamin \n+sebuah Pod dijalankan hingga selesai. Objek Job ini akan membuat sebuah Pod baru apabila \n+Pod pertama gagal atau dihapus (salah satu contohnya adalah akibat adanya kegagalan pada \n+perangkat keras atau terjadinya _reboot_ pada node).\n+\n+Kamu juga dapat mnegggunakan Jon untuk menjalankan beberapa Pod secara paralel.\n+\n+{{% /capture %}}\n+\n+\n+{{% capture body %}}\n+\n+## Menjalankan Contoh Job\n+\n+Berikut merupakan contoh konfigurasi Job. Job ini melakukan komputasi π hingga \n+digit ke 2000 kemudian memberikan hasilnya sebagai keluaran. Job tersebut memerlukan \n+waktu 10 detik untuk dapat diselesaikan.\n+\n+{{< codenew file=\"controllers/job.yaml\" >}}\n+\n+Kamu dapat menjalankan contoh tersebut dengan menjalankan perintah berikut:\n+\n+```shell\n+kubectl apply -f https://k8s.io/examples/controllers/job.yaml\n+```\n+```\n+job \"pi\" created\n+```\n+\n+Perhatikan status dari Job yang baru dibuat dengan menggunakan perintah`kubectl`:\n+\n+```shell\n+kubectl describe jobs/pi\n+```\n+```\n+Name: pi\n+Namespace: default\n+Selector: controller-uid=b1db589a-2c8d-11e6-b324-0209dc45a495\n+Labels: controller-uid=b1db589a-2c8d-11e6-b324-0209dc45a495\n+ job-name=pi\n+Annotations: <none>\n+Parallelism: 1\n+Completions: 1\n+Start Time: Tue, 07 Jun 2016 10:56:16 +0200\n+Pods Statuses: 0 Running / 1 Succeeded / 0 Failed\n+Pod Template:\n+ Labels: controller-uid=b1db589a-2c8d-11e6-b324-0209dc45a495\n+ job-name=pi\n+ Containers:\n+ pi:\n+ Image: perl\n+ Port:\n+ Command:\n+ perl\n+ -Mbignum=bpi\n+ -wle\n+ print bpi(2000)\n+ Environment: <none>\n+ Mounts: <none>\n+ Volumes: <none>\n+Events:\n+ FirstSeen LastSeen Count From SubobjectPath Type Reason Message\n+ --------- -------- ----- ---- ------------- -------- ------ -------\n+ 1m 1m 1 {job-controller } Normal SuccessfulCreate Created pod: pi-dtn4q\n+```\n+\n+Untuk melihat Pod yang sudah selesai dari sebuah Job, kamu dapat menggunakan perintah `kubectl get pods`.\n+\n+Untuk menampilkan semua Pod yang merupakan bagian dari suatu Job di mesin kamu dalam bentuk \n+yang mudah dipahami, kamu dapat menggunakan perintah berikut ini:\n+\n+```shell\n+pods=$(kubectl get pods --selector=job-name=pi --output=jsonpath='{.items[*].metadata.name}')\n+echo $pods\n+```\n+```\n+pi-aiw0a\n+```\n+\n+Disini, selektor yang ada merupakan selektor yang dama dengan yang ada pada Job. \n+Opsi `--output=jsonpath` menspesifikasikan bahka ekspresi yang hanya \n+menampilkan nama dari setiap Pod pada list yang dikembalikan.\n+\n+Untuk melihat keluaran standar dari salah satu pod:\n+\n+```shell\n+kubectl logs $pods\n+```\n+Keluaran yang dihasilkan akan sama dengan:\n+```shell\n+3.1415926535897932384626433832795028841971693993751058209749445923078164062862089986280348253421170679821480865132823066470938446095505822317253594081284811174502841027019385211055596446229489549303819644288109756659334461284756482337867831652712019091456485669234603486104543266482133936072602491412737245870066063155881748815209209628292540917153643678925903600113305305488204665213841469519415116094330572703657595919530921861173819326117931051185480744623799627495673518857527248912279381830119491298336733624406566430860213949463952247371907021798609437027705392171762931767523846748184676694051320005681271452635608277857713427577896091736371787214684409012249534301465495853710507922796892589235420199561121290219608640344181598136297747713099605187072113499999983729780499510597317328160963185950244594553469083026425223082533446850352619311881710100031378387528865875332083814206171776691473035982534904287554687311595628638823537875937519577818577805321712268066130019278766111959092164201989380952572010654858632788659361533818279682303019520353018529689957736225994138912497217752834791315155748572424541506959508295331168617278558890750983817546374649393192550604009277016711390098488240128583616035637076601047101819429555961989467678374494482553797747268471040475346462080466842590694912933136770289891521047521620569660240580381501935112533824300355876402474964732639141992726042699227967823547816360093417216412199245863150302861829745557067498385054945885869269956909272107975093029553211653449872027559602364806654991198818347977535663698074265425278625518184175746728909777727938000816470600161452491921732172147723501414419735685481613611573525521334757418494684385233239073941433345477624168625189835694855620992192221842725502542568876717904946016534668049886272327917860857843838279679766814541009538837863609506800642251252051173929848960841284886269456042419652850222106611863067442786220391949450471237137869609563643719172874677646575739624138908658326459958133904780275901\n+```\n+\n+## Menulis Spec Job\n+\n+Sama halnya dengan konfigurasi Kubernetes lainnya, sebuah Job memerlukan _field_\n+`apiVersion`, `kind`, dan `metadata`.\n+\n+Sebuah Job juga membutuhkan sebuah [bagian `.spec`](https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#spec-and-status).\n+\n+### Templat Pod\n+\n+_Field_ `.spec.template` merupakan satu-satunya _field_ wajib pada `.spec`.\n+\n+_Field_ `.spec.template` merupakan sebuah [templat pod](/docs/concepts/workloads/pods/pod-overview/#pod-templates). _Field_ ini memiliki skema yang sama dengan yang ada pada [pod](/docs/user-guide/pods), \n+kecuali _field_ ini bersifat _nested_ dan tidak memiliki _field_ `apiVersion` atau _field_ `kind`.\n+\n+Sebagai taambahan dari _field_ wajib pada sebuah Job, sebuah tempat pod pada Job \n+haruslah menspesifikasikan label yang sesuai (perhatikan [selektor pod](#pod-selektor)) \n+dan sebuah mekanisme _restart_ yang sesuai.\n+\n+Hanya sebuah [`RestartPolicy`](/docs/concepts/workloads/pods/pod-lifecycle/#restart-policy) yang sesuai dengan `Never` atau `OnFailure` yang bersifat valid.\n+\n+### Selektor Pod\n+\n+_Field_ `.spec.selector` bersifat opsional. Dan dalam sebagian besar kasus, kamu tidak perlu memberikan \n+spesifikasi untuk hal ini. Perhatikan bagian [menspesifikasikan selektor pod kamu sendiri](#menspesifikasikan-selektor-pod-kamu-sendiri).","path":"content/id/docs/concepts/workloads/controllers/jobs-run-to-completion.md","position":134,"original_position":134,"commit_id":"4db46994d466342eee7203714273064172e3bae2","original_commit_id":"4db46994d466342eee7203714273064172e3bae2","user":{"login":"girikuncoro","id":3192347,"node_id":"MDQ6VXNlcjMxOTIzNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3192347?v=4","gravatar_id":"","url":"https://api.github.com/users/girikuncoro","html_url":"https://github.com/girikuncoro","followers_url":"https://api.github.com/users/girikuncoro/followers","following_url":"https://api.github.com/users/girikuncoro/following{/other_user}","gists_url":"https://api.github.com/users/girikuncoro/gists{/gist_id}","starred_url":"https://api.github.com/users/girikuncoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girikuncoro/subscriptions","organizations_url":"https://api.github.com/users/girikuncoro/orgs","repos_url":"https://api.github.com/users/girikuncoro/repos","events_url":"https://api.github.com/users/girikuncoro/events{/privacy}","received_events_url":"https://api.github.com/users/girikuncoro/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nspesifikasi untuk hal ini. Perhatikan bagian [menspesifikasikan selektor Pod kamu sendiri](#menspesifikasikan-selektor-pod-kamu-sendiri).\r\n```","created_at":"2019-10-13T00:48:58Z","updated_at":"2019-10-13T00:56:42Z","html_url":"https://github.com/kubernetes/website/pull/16705#discussion_r334258148","pull_request_url":"https://api.github.com/repos/kubernetes/website/pulls/16705","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments/334258148"},"html":{"href":"https://github.com/kubernetes/website/pull/16705#discussion_r334258148"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16705"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/website/pulls/16705","id":324974811,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0OTc0ODEx","html_url":"https://github.com/kubernetes/website/pull/16705","diff_url":"https://github.com/kubernetes/website/pull/16705.diff","patch_url":"https://github.com/kubernetes/website/pull/16705.patch","issue_url":"https://api.github.com/repos/kubernetes/website/issues/16705","number":16705,"state":"open","locked":false,"title":"Add job running into completion in ID Localization.","user":{"login":"irvifa","id":7439590,"node_id":"MDQ6VXNlcjc0Mzk1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7439590?v=4","gravatar_id":"","url":"https://api.github.com/users/irvifa","html_url":"https://github.com/irvifa","followers_url":"https://api.github.com/users/irvifa/followers","following_url":"https://api.github.com/users/irvifa/following{/other_user}","gists_url":"https://api.github.com/users/irvifa/gists{/gist_id}","starred_url":"https://api.github.com/users/irvifa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irvifa/subscriptions","organizations_url":"https://api.github.com/users/irvifa/orgs","repos_url":"https://api.github.com/users/irvifa/repos","events_url":"https://api.github.com/users/irvifa/events{/privacy}","received_events_url":"https://api.github.com/users/irvifa/received_events","type":"User","site_admin":false},"body":"This address https://github.com/kubernetes/website/issues/15341 and https://github.com/jk8s/sig-docs-id/issues/17","created_at":"2019-10-05T20:43:34Z","updated_at":"2019-10-13T00:56:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64ffcc57443771804be8b1d7c60ce4da34f9fa78","assignee":{"login":"irvifa","id":7439590,"node_id":"MDQ6VXNlcjc0Mzk1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7439590?v=4","gravatar_id":"","url":"https://api.github.com/users/irvifa","html_url":"https://github.com/irvifa","followers_url":"https://api.github.com/users/irvifa/followers","following_url":"https://api.github.com/users/irvifa/following{/other_user}","gists_url":"https://api.github.com/users/irvifa/gists{/gist_id}","starred_url":"https://api.github.com/users/irvifa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irvifa/subscriptions","organizations_url":"https://api.github.com/users/irvifa/orgs","repos_url":"https://api.github.com/users/irvifa/repos","events_url":"https://api.github.com/users/irvifa/events{/privacy}","received_events_url":"https://api.github.com/users/irvifa/received_events","type":"User","site_admin":false},"assignees":[{"login":"girikuncoro","id":3192347,"node_id":"MDQ6VXNlcjMxOTIzNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3192347?v=4","gravatar_id":"","url":"https://api.github.com/users/girikuncoro","html_url":"https://github.com/girikuncoro","followers_url":"https://api.github.com/users/girikuncoro/followers","following_url":"https://api.github.com/users/girikuncoro/following{/other_user}","gists_url":"https://api.github.com/users/girikuncoro/gists{/gist_id}","starred_url":"https://api.github.com/users/girikuncoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girikuncoro/subscriptions","organizations_url":"https://api.github.com/users/girikuncoro/orgs","repos_url":"https://api.github.com/users/girikuncoro/repos","events_url":"https://api.github.com/users/girikuncoro/events{/privacy}","received_events_url":"https://api.github.com/users/girikuncoro/received_events","type":"User","site_admin":false},{"login":"irvifa","id":7439590,"node_id":"MDQ6VXNlcjc0Mzk1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7439590?v=4","gravatar_id":"","url":"https://api.github.com/users/irvifa","html_url":"https://github.com/irvifa","followers_url":"https://api.github.com/users/irvifa/followers","following_url":"https://api.github.com/users/irvifa/following{/other_user}","gists_url":"https://api.github.com/users/irvifa/gists{/gist_id}","starred_url":"https://api.github.com/users/irvifa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irvifa/subscriptions","organizations_url":"https://api.github.com/users/irvifa/orgs","repos_url":"https://api.github.com/users/irvifa/repos","events_url":"https://api.github.com/users/irvifa/events{/privacy}","received_events_url":"https://api.github.com/users/irvifa/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"qbl","id":304148,"node_id":"MDQ6VXNlcjMwNDE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/304148?v=4","gravatar_id":"","url":"https://api.github.com/users/qbl","html_url":"https://github.com/qbl","followers_url":"https://api.github.com/users/qbl/followers","following_url":"https://api.github.com/users/qbl/following{/other_user}","gists_url":"https://api.github.com/users/qbl/gists{/gist_id}","starred_url":"https://api.github.com/users/qbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbl/subscriptions","organizations_url":"https://api.github.com/users/qbl/orgs","repos_url":"https://api.github.com/users/qbl/repos","events_url":"https://api.github.com/users/qbl/events{/privacy}","received_events_url":"https://api.github.com/users/qbl/received_events","type":"User","site_admin":false},{"login":"phanama","id":11147376,"node_id":"MDQ6VXNlcjExMTQ3Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/11147376?v=4","gravatar_id":"","url":"https://api.github.com/users/phanama","html_url":"https://github.com/phanama","followers_url":"https://api.github.com/users/phanama/followers","following_url":"https://api.github.com/users/phanama/following{/other_user}","gists_url":"https://api.github.com/users/phanama/gists{/gist_id}","starred_url":"https://api.github.com/users/phanama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phanama/subscriptions","organizations_url":"https://api.github.com/users/phanama/orgs","repos_url":"https://api.github.com/users/phanama/repos","events_url":"https://api.github.com/users/phanama/events{/privacy}","received_events_url":"https://api.github.com/users/phanama/received_events","type":"User","site_admin":false},{"login":"danninov","id":14119706,"node_id":"MDQ6VXNlcjE0MTE5NzA2","avatar_url":"https://avatars1.githubusercontent.com/u/14119706?v=4","gravatar_id":"","url":"https://api.github.com/users/danninov","html_url":"https://github.com/danninov","followers_url":"https://api.github.com/users/danninov/followers","following_url":"https://api.github.com/users/danninov/following{/other_user}","gists_url":"https://api.github.com/users/danninov/gists{/gist_id}","starred_url":"https://api.github.com/users/danninov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danninov/subscriptions","organizations_url":"https://api.github.com/users/danninov/orgs","repos_url":"https://api.github.com/users/danninov/repos","events_url":"https://api.github.com/users/danninov/events{/privacy}","received_events_url":"https://api.github.com/users/danninov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484571291,"node_id":"MDU6TGFiZWw0ODQ1NzEyOTE=","url":"https://api.github.com/repos/kubernetes/website/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1322177855,"node_id":"MDU6TGFiZWwxMzIyMTc3ODU1","url":"https://api.github.com/repos/kubernetes/website/labels/language/id","name":"language/id","color":"e9b3f9","default":false},{"id":764235355,"node_id":"MDU6TGFiZWw3NjQyMzUzNTU=","url":"https://api.github.com/repos/kubernetes/website/labels/sig/docs","name":"sig/docs","color":"d2b48c","default":false},{"id":677767630,"node_id":"MDU6TGFiZWw2Nzc3Njc2MzA=","url":"https://api.github.com/repos/kubernetes/website/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/website/pulls/16705/commits","review_comments_url":"https://api.github.com/repos/kubernetes/website/pulls/16705/comments","review_comment_url":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/website/issues/16705/comments","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/4db46994d466342eee7203714273064172e3bae2","head":{"label":"irvifa:id/jobs-run-to-completion","ref":"id/jobs-run-to-completion","sha":"4db46994d466342eee7203714273064172e3bae2","user":{"login":"irvifa","id":7439590,"node_id":"MDQ6VXNlcjc0Mzk1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7439590?v=4","gravatar_id":"","url":"https://api.github.com/users/irvifa","html_url":"https://github.com/irvifa","followers_url":"https://api.github.com/users/irvifa/followers","following_url":"https://api.github.com/users/irvifa/following{/other_user}","gists_url":"https://api.github.com/users/irvifa/gists{/gist_id}","starred_url":"https://api.github.com/users/irvifa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irvifa/subscriptions","organizations_url":"https://api.github.com/users/irvifa/orgs","repos_url":"https://api.github.com/users/irvifa/repos","events_url":"https://api.github.com/users/irvifa/events{/privacy}","received_events_url":"https://api.github.com/users/irvifa/received_events","type":"User","site_admin":false},"repo":{"id":182526282,"node_id":"MDEwOlJlcG9zaXRvcnkxODI1MjYyODI=","name":"website","full_name":"irvifa/website","private":false,"owner":{"login":"irvifa","id":7439590,"node_id":"MDQ6VXNlcjc0Mzk1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7439590?v=4","gravatar_id":"","url":"https://api.github.com/users/irvifa","html_url":"https://github.com/irvifa","followers_url":"https://api.github.com/users/irvifa/followers","following_url":"https://api.github.com/users/irvifa/following{/other_user}","gists_url":"https://api.github.com/users/irvifa/gists{/gist_id}","starred_url":"https://api.github.com/users/irvifa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irvifa/subscriptions","organizations_url":"https://api.github.com/users/irvifa/orgs","repos_url":"https://api.github.com/users/irvifa/repos","events_url":"https://api.github.com/users/irvifa/events{/privacy}","received_events_url":"https://api.github.com/users/irvifa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/irvifa/website","description":"Kubernetes website and documentation repo: ","fork":true,"url":"https://api.github.com/repos/irvifa/website","forks_url":"https://api.github.com/repos/irvifa/website/forks","keys_url":"https://api.github.com/repos/irvifa/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irvifa/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irvifa/website/teams","hooks_url":"https://api.github.com/repos/irvifa/website/hooks","issue_events_url":"https://api.github.com/repos/irvifa/website/issues/events{/number}","events_url":"https://api.github.com/repos/irvifa/website/events","assignees_url":"https://api.github.com/repos/irvifa/website/assignees{/user}","branches_url":"https://api.github.com/repos/irvifa/website/branches{/branch}","tags_url":"https://api.github.com/repos/irvifa/website/tags","blobs_url":"https://api.github.com/repos/irvifa/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irvifa/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irvifa/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/irvifa/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irvifa/website/statuses/{sha}","languages_url":"https://api.github.com/repos/irvifa/website/languages","stargazers_url":"https://api.github.com/repos/irvifa/website/stargazers","contributors_url":"https://api.github.com/repos/irvifa/website/contributors","subscribers_url":"https://api.github.com/repos/irvifa/website/subscribers","subscription_url":"https://api.github.com/repos/irvifa/website/subscription","commits_url":"https://api.github.com/repos/irvifa/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/irvifa/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/irvifa/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/irvifa/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/irvifa/website/contents/{+path}","compare_url":"https://api.github.com/repos/irvifa/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irvifa/website/merges","archive_url":"https://api.github.com/repos/irvifa/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irvifa/website/downloads","issues_url":"https://api.github.com/repos/irvifa/website/issues{/number}","pulls_url":"https://api.github.com/repos/irvifa/website/pulls{/number}","milestones_url":"https://api.github.com/repos/irvifa/website/milestones{/number}","notifications_url":"https://api.github.com/repos/irvifa/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irvifa/website/labels{/name}","releases_url":"https://api.github.com/repos/irvifa/website/releases{/id}","deployments_url":"https://api.github.com/repos/irvifa/website/deployments","created_at":"2019-04-21T11:48:17Z","updated_at":"2019-04-21T11:48:29Z","pushed_at":"2019-10-06T09:39:45Z","git_url":"git://github.com/irvifa/website.git","ssh_url":"git@github.com:irvifa/website.git","clone_url":"https://github.com/irvifa/website.git","svn_url":"https://github.com/irvifa/website","homepage":"https://kubernetes.io","size":242173,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c51b1d65b723e62f9a2b96a9dce64ca5db88a715","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQ3ODI2Ng==","name":"website","full_name":"kubernetes/website","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/website","description":"Kubernetes website and documentation repo: ","fork":false,"url":"https://api.github.com/repos/kubernetes/website","forks_url":"https://api.github.com/repos/kubernetes/website/forks","keys_url":"https://api.github.com/repos/kubernetes/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/website/teams","hooks_url":"https://api.github.com/repos/kubernetes/website/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/website/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/website/events","assignees_url":"https://api.github.com/repos/kubernetes/website/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/website/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/website/tags","blobs_url":"https://api.github.com/repos/kubernetes/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/website/languages","stargazers_url":"https://api.github.com/repos/kubernetes/website/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/website/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/website/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/website/subscription","commits_url":"https://api.github.com/repos/kubernetes/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/website/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/website/merges","archive_url":"https://api.github.com/repos/kubernetes/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/website/downloads","issues_url":"https://api.github.com/repos/kubernetes/website/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/website/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/website/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/website/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/website/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/website/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2019-10-12T09:26:43Z","pushed_at":"2019-10-12T23:12:38Z","git_url":"git://github.com/kubernetes/website.git","ssh_url":"git@github.com:kubernetes/website.git","clone_url":"https://github.com/kubernetes/website.git","svn_url":"https://github.com/kubernetes/website","homepage":"https://kubernetes.io","size":274793,"stargazers_count":1594,"watchers_count":1594,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5637,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":627,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":5637,"open_issues":627,"watchers":1594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16705"},"html":{"href":"https://github.com/kubernetes/website/pull/16705"},"issue":{"href":"https://api.github.com/repos/kubernetes/website/issues/16705"},"comments":{"href":"https://api.github.com/repos/kubernetes/website/issues/16705/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16705/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16705/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/website/statuses/4db46994d466342eee7203714273064172e3bae2"}},"author_association":"MEMBER"}}
|
{
"id": 51478266,
"name": "kubernetes/website",
"url": "https://api.github.com/repos/kubernetes/website"
}
|
{
"id": 3192347,
"login": "girikuncoro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3192347?",
"url": "https://api.github.com/users/girikuncoro"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-10-13T00:48:58 |
10618097057
|
{"actor":{"display_login":"girikuncoro"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/268229310","pull_request_review_id":217834049,"id":268229310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODIyOTMxMA==","diff_hunk":"@@ -69,6 +69,7 @@ module.exports = {\n 'styles': [\n '../node_modules/material-design-icons/iconfont/material-icons.css',\n '../node_modules/roboto-fontface/css/roboto/roboto-fontface.css',\n+ '../node_modules/nvd3/build/nv.d3.css',","path":"aio/closure/webpack.config.js","position":4,"original_position":4,"commit_id":"72563c989a1dac8dce2387c965859a4b00705b2a","original_commit_id":"72563c989a1dac8dce2387c965859a4b00705b2a","user":{"login":"floreks","id":2285385,"node_id":"MDQ6VXNlcjIyODUzODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2285385?v=4","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false},"body":"I mean that this should only be added to the `angular.json` file. This `webpack.config.js` file is basically not used at all.","created_at":"2019-03-22T15:49:53Z","updated_at":"2019-03-22T15:49:53Z","html_url":"https://github.com/kubernetes/dashboard/pull/3667#discussion_r268229310","pull_request_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/3667","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/268229310"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/3667#discussion_r268229310"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/3667"}},"in_reply_to_id":268202727},"pull_request":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/3667","id":261841406,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxODQxNDA2","html_url":"https://github.com/kubernetes/dashboard/pull/3667","diff_url":"https://github.com/kubernetes/dashboard/pull/3667.diff","patch_url":"https://github.com/kubernetes/dashboard/pull/3667.patch","issue_url":"https://api.github.com/repos/kubernetes/dashboard/issues/3667","number":3667,"state":"open","locked":false,"title":"update WorkloadStatusComponent","user":{"login":"ajatprabha","id":11836668,"node_id":"MDQ6VXNlcjExODM2NjY4","avatar_url":"https://avatars3.githubusercontent.com/u/11836668?v=4","gravatar_id":"","url":"https://api.github.com/users/ajatprabha","html_url":"https://github.com/ajatprabha","followers_url":"https://api.github.com/users/ajatprabha/followers","following_url":"https://api.github.com/users/ajatprabha/following{/other_user}","gists_url":"https://api.github.com/users/ajatprabha/gists{/gist_id}","starred_url":"https://api.github.com/users/ajatprabha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajatprabha/subscriptions","organizations_url":"https://api.github.com/users/ajatprabha/orgs","repos_url":"https://api.github.com/users/ajatprabha/repos","events_url":"https://api.github.com/users/ajatprabha/events{/privacy}","received_events_url":"https://api.github.com/users/ajatprabha/received_events","type":"User","site_admin":false},"body":"Work towards #3440\r\n\r\nPreview:\r\n","created_at":"2019-03-17T13:09:34Z","updated_at":"2019-03-22T15:49:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79b95c36f91a4243be3fc343b593902cd0fdf1f7","assignee":{"login":"floreks","id":2285385,"node_id":"MDQ6VXNlcjIyODUzODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2285385?v=4","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false},"assignees":[{"login":"floreks","id":2285385,"node_id":"MDQ6VXNlcjIyODUzODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2285385?v=4","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"PeWu","id":6564445,"node_id":"MDQ6VXNlcjY1NjQ0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/6564445?v=4","gravatar_id":"","url":"https://api.github.com/users/PeWu","html_url":"https://github.com/PeWu","followers_url":"https://api.github.com/users/PeWu/followers","following_url":"https://api.github.com/users/PeWu/following{/other_user}","gists_url":"https://api.github.com/users/PeWu/gists{/gist_id}","starred_url":"https://api.github.com/users/PeWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeWu/subscriptions","organizations_url":"https://api.github.com/users/PeWu/orgs","repos_url":"https://api.github.com/users/PeWu/repos","events_url":"https://api.github.com/users/PeWu/events{/privacy}","received_events_url":"https://api.github.com/users/PeWu/received_events","type":"User","site_admin":false},{"login":"mhenc","id":26084858,"node_id":"MDQ6VXNlcjI2MDg0ODU4","avatar_url":"https://avatars3.githubusercontent.com/u/26084858?v=4","gravatar_id":"","url":"https://api.github.com/users/mhenc","html_url":"https://github.com/mhenc","followers_url":"https://api.github.com/users/mhenc/followers","following_url":"https://api.github.com/users/mhenc/following{/other_user}","gists_url":"https://api.github.com/users/mhenc/gists{/gist_id}","starred_url":"https://api.github.com/users/mhenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhenc/subscriptions","organizations_url":"https://api.github.com/users/mhenc/orgs","repos_url":"https://api.github.com/users/mhenc/repos","events_url":"https://api.github.com/users/mhenc/events{/privacy}","received_events_url":"https://api.github.com/users/mhenc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":485595234,"node_id":"MDU6TGFiZWw0ODU1OTUyMzQ=","url":"https://api.github.com/repos/kubernetes/dashboard/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":677086275,"node_id":"MDU6TGFiZWw2NzcwODYyNzU=","url":"https://api.github.com/repos/kubernetes/dashboard/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/3667/commits","review_comments_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/3667/comments","review_comment_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/issues/3667/comments","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/72563c989a1dac8dce2387c965859a4b00705b2a","head":{"label":"ajatprabha:workload-statuses-3440","ref":"workload-statuses-3440","sha":"72563c989a1dac8dce2387c965859a4b00705b2a","user":{"login":"ajatprabha","id":11836668,"node_id":"MDQ6VXNlcjExODM2NjY4","avatar_url":"https://avatars3.githubusercontent.com/u/11836668?v=4","gravatar_id":"","url":"https://api.github.com/users/ajatprabha","html_url":"https://github.com/ajatprabha","followers_url":"https://api.github.com/users/ajatprabha/followers","following_url":"https://api.github.com/users/ajatprabha/following{/other_user}","gists_url":"https://api.github.com/users/ajatprabha/gists{/gist_id}","starred_url":"https://api.github.com/users/ajatprabha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajatprabha/subscriptions","organizations_url":"https://api.github.com/users/ajatprabha/orgs","repos_url":"https://api.github.com/users/ajatprabha/repos","events_url":"https://api.github.com/users/ajatprabha/events{/privacy}","received_events_url":"https://api.github.com/users/ajatprabha/received_events","type":"User","site_admin":false},"repo":{"id":158959997,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg5NTk5OTc=","name":"dashboard","full_name":"ajatprabha/dashboard","private":false,"owner":{"login":"ajatprabha","id":11836668,"node_id":"MDQ6VXNlcjExODM2NjY4","avatar_url":"https://avatars3.githubusercontent.com/u/11836668?v=4","gravatar_id":"","url":"https://api.github.com/users/ajatprabha","html_url":"https://github.com/ajatprabha","followers_url":"https://api.github.com/users/ajatprabha/followers","following_url":"https://api.github.com/users/ajatprabha/following{/other_user}","gists_url":"https://api.github.com/users/ajatprabha/gists{/gist_id}","starred_url":"https://api.github.com/users/ajatprabha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajatprabha/subscriptions","organizations_url":"https://api.github.com/users/ajatprabha/orgs","repos_url":"https://api.github.com/users/ajatprabha/repos","events_url":"https://api.github.com/users/ajatprabha/events{/privacy}","received_events_url":"https://api.github.com/users/ajatprabha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ajatprabha/dashboard","description":"General-purpose web UI for Kubernetes clusters","fork":true,"url":"https://api.github.com/repos/ajatprabha/dashboard","forks_url":"https://api.github.com/repos/ajatprabha/dashboard/forks","keys_url":"https://api.github.com/repos/ajatprabha/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajatprabha/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajatprabha/dashboard/teams","hooks_url":"https://api.github.com/repos/ajatprabha/dashboard/hooks","issue_events_url":"https://api.github.com/repos/ajatprabha/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/ajatprabha/dashboard/events","assignees_url":"https://api.github.com/repos/ajatprabha/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/ajatprabha/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/ajatprabha/dashboard/tags","blobs_url":"https://api.github.com/repos/ajatprabha/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajatprabha/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajatprabha/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajatprabha/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajatprabha/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/ajatprabha/dashboard/languages","stargazers_url":"https://api.github.com/repos/ajatprabha/dashboard/stargazers","contributors_url":"https://api.github.com/repos/ajatprabha/dashboard/contributors","subscribers_url":"https://api.github.com/repos/ajatprabha/dashboard/subscribers","subscription_url":"https://api.github.com/repos/ajatprabha/dashboard/subscription","commits_url":"https://api.github.com/repos/ajatprabha/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajatprabha/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajatprabha/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajatprabha/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajatprabha/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/ajatprabha/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajatprabha/dashboard/merges","archive_url":"https://api.github.com/repos/ajatprabha/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajatprabha/dashboard/downloads","issues_url":"https://api.github.com/repos/ajatprabha/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/ajatprabha/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/ajatprabha/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/ajatprabha/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajatprabha/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/ajatprabha/dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/ajatprabha/dashboard/deployments","created_at":"2018-11-24T17:45:57Z","updated_at":"2019-03-17T23:11:57Z","pushed_at":"2019-03-22T11:30:44Z","git_url":"git://github.com/ajatprabha/dashboard.git","ssh_url":"git@github.com:ajatprabha/dashboard.git","clone_url":"https://github.com/ajatprabha/dashboard.git","svn_url":"https://github.com/ajatprabha/dashboard","homepage":"","size":122599,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6ee9f3bab1c021a9d06af2f4f5f8a22cbcc13c92","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":44350607,"node_id":"MDEwOlJlcG9zaXRvcnk0NDM1MDYwNw==","name":"dashboard","full_name":"kubernetes/dashboard","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/dashboard","description":"General-purpose web UI for Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/kubernetes/dashboard","forks_url":"https://api.github.com/repos/kubernetes/dashboard/forks","keys_url":"https://api.github.com/repos/kubernetes/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/dashboard/teams","hooks_url":"https://api.github.com/repos/kubernetes/dashboard/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/dashboard/events","assignees_url":"https://api.github.com/repos/kubernetes/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/dashboard/tags","blobs_url":"https://api.github.com/repos/kubernetes/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/dashboard/languages","stargazers_url":"https://api.github.com/repos/kubernetes/dashboard/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/dashboard/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/dashboard/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/dashboard/subscription","commits_url":"https://api.github.com/repos/kubernetes/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/dashboard/merges","archive_url":"https://api.github.com/repos/kubernetes/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/dashboard/downloads","issues_url":"https://api.github.com/repos/kubernetes/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/dashboard/deployments","created_at":"2015-10-15T23:09:14Z","updated_at":"2019-03-22T14:39:44Z","pushed_at":"2019-03-22T13:47:36Z","git_url":"git://github.com/kubernetes/dashboard.git","ssh_url":"git@github.com:kubernetes/dashboard.git","clone_url":"https://github.com/kubernetes/dashboard.git","svn_url":"https://github.com/kubernetes/dashboard","homepage":"","size":126753,"stargazers_count":4559,"watchers_count":4559,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1200,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1200,"open_issues":112,"watchers":4559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/3667"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/3667"},"issue":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/3667"},"comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/3667/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/3667/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/3667/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/dashboard/statuses/72563c989a1dac8dce2387c965859a4b00705b2a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 44350607,
"name": "kubernetes/dashboard",
"url": "https://api.github.com/repos/kubernetes/dashboard"
}
|
{
"id": 2285385,
"login": "floreks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2285385?",
"url": "https://api.github.com/users/floreks"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-03-22T15:49:53 |
9296444599
|
{"actor":{"display_login":"floreks"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/324354821","pull_request_review_id":288234381,"id":324354821,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDM1NDgyMQ==","diff_hunk":"@@ -77,13 +77,18 @@ func (fr *FirewallRules) Sync(nodeNames, additionalPorts, additionalRanges []str\n \t}\n \tsort.Strings(targetTags)\n \n+\t// De-dupe ports","path":"pkg/firewalls/firewalls.go","position":4,"original_position":4,"commit_id":"3f0914fb52d54018e69cea14137a7cdb7f2130ed","original_commit_id":"3f0914fb52d54018e69cea14137a7cdb7f2130ed","user":{"login":"bowei","id":837034,"node_id":"MDQ6VXNlcjgzNzAzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"body":"It's better to have the permanent ones first and the additional adds after. \r\n\r\n```\r\nports := sets.NewString(fr.portRanges...)\r\nports.Insert(additionalPorts...)\r\n\r\nranges := sets.NewString(fr.srcRanges...)\r\nranges.Insert(additionalRanges)\r\n```\r\n","created_at":"2019-09-13T20:23:44Z","updated_at":"2019-09-13T20:23:44Z","html_url":"https://github.com/kubernetes/ingress-gce/pull/851#discussion_r324354821","pull_request_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/851","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/324354821"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/851#discussion_r324354821"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/851"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/851","id":316666257,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2NjY2MjU3","html_url":"https://github.com/kubernetes/ingress-gce/pull/851","diff_url":"https://github.com/kubernetes/ingress-gce/pull/851.diff","patch_url":"https://github.com/kubernetes/ingress-gce/pull/851.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/851","number":851,"state":"open","locked":false,"title":"De-dupe additional source ranges for firewall","user":{"login":"spencerhance","id":9636457,"node_id":"MDQ6VXNlcjk2MzY0NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9636457?v=4","gravatar_id":"","url":"https://api.github.com/users/spencerhance","html_url":"https://github.com/spencerhance","followers_url":"https://api.github.com/users/spencerhance/followers","following_url":"https://api.github.com/users/spencerhance/following{/other_user}","gists_url":"https://api.github.com/users/spencerhance/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerhance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerhance/subscriptions","organizations_url":"https://api.github.com/users/spencerhance/orgs","repos_url":"https://api.github.com/users/spencerhance/repos","events_url":"https://api.github.com/users/spencerhance/events{/privacy}","received_events_url":"https://api.github.com/users/spencerhance/received_events","type":"User","site_admin":false},"body":"- Fixes a bug where ILB subnet range is added multiple times\r\n- Fixes a bug where empty ilb subnet is added to firewall\r\n\r\n/assign @rramkumar1 ","created_at":"2019-09-11T22:57:54Z","updated_at":"2019-09-13T20:23:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"488bf50d56fb7cbaa83013e459d49894f6a2b12d","assignee":{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"assignees":[{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":712525210,"node_id":"MDU6TGFiZWw3MTI1MjUyMTA=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1086781789,"node_id":"MDU6TGFiZWwxMDg2NzgxNzg5","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":712752183,"node_id":"MDU6TGFiZWw3MTI3NTIxODM=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/851/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/851/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/851/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/3f0914fb52d54018e69cea14137a7cdb7f2130ed","head":{"label":"spencerhance:fix-ilb-firewall","ref":"fix-ilb-firewall","sha":"3f0914fb52d54018e69cea14137a7cdb7f2130ed","user":{"login":"spencerhance","id":9636457,"node_id":"MDQ6VXNlcjk2MzY0NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9636457?v=4","gravatar_id":"","url":"https://api.github.com/users/spencerhance","html_url":"https://github.com/spencerhance","followers_url":"https://api.github.com/users/spencerhance/followers","following_url":"https://api.github.com/users/spencerhance/following{/other_user}","gists_url":"https://api.github.com/users/spencerhance/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerhance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerhance/subscriptions","organizations_url":"https://api.github.com/users/spencerhance/orgs","repos_url":"https://api.github.com/users/spencerhance/repos","events_url":"https://api.github.com/users/spencerhance/events{/privacy}","received_events_url":"https://api.github.com/users/spencerhance/received_events","type":"User","site_admin":false},"repo":{"id":173195152,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMxOTUxNTI=","name":"ingress-gce","full_name":"spencerhance/ingress-gce","private":false,"owner":{"login":"spencerhance","id":9636457,"node_id":"MDQ6VXNlcjk2MzY0NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9636457?v=4","gravatar_id":"","url":"https://api.github.com/users/spencerhance","html_url":"https://github.com/spencerhance","followers_url":"https://api.github.com/users/spencerhance/followers","following_url":"https://api.github.com/users/spencerhance/following{/other_user}","gists_url":"https://api.github.com/users/spencerhance/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerhance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerhance/subscriptions","organizations_url":"https://api.github.com/users/spencerhance/orgs","repos_url":"https://api.github.com/users/spencerhance/repos","events_url":"https://api.github.com/users/spencerhance/events{/privacy}","received_events_url":"https://api.github.com/users/spencerhance/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spencerhance/ingress-gce","description":"Ingress controller for Google Cloud","fork":true,"url":"https://api.github.com/repos/spencerhance/ingress-gce","forks_url":"https://api.github.com/repos/spencerhance/ingress-gce/forks","keys_url":"https://api.github.com/repos/spencerhance/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spencerhance/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spencerhance/ingress-gce/teams","hooks_url":"https://api.github.com/repos/spencerhance/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/spencerhance/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/spencerhance/ingress-gce/events","assignees_url":"https://api.github.com/repos/spencerhance/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/spencerhance/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/spencerhance/ingress-gce/tags","blobs_url":"https://api.github.com/repos/spencerhance/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spencerhance/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spencerhance/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/spencerhance/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spencerhance/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/spencerhance/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/spencerhance/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/spencerhance/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/spencerhance/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/spencerhance/ingress-gce/subscription","commits_url":"https://api.github.com/repos/spencerhance/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/spencerhance/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/spencerhance/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/spencerhance/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/spencerhance/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/spencerhance/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spencerhance/ingress-gce/merges","archive_url":"https://api.github.com/repos/spencerhance/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spencerhance/ingress-gce/downloads","issues_url":"https://api.github.com/repos/spencerhance/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/spencerhance/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/spencerhance/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/spencerhance/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spencerhance/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/spencerhance/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/spencerhance/ingress-gce/deployments","created_at":"2019-02-28T22:07:45Z","updated_at":"2019-09-11T22:15:57Z","pushed_at":"2019-09-13T02:30:00Z","git_url":"git://github.com/spencerhance/ingress-gce.git","ssh_url":"git@github.com:spencerhance/ingress-gce.git","clone_url":"https://github.com/spencerhance/ingress-gce.git","svn_url":"https://github.com/spencerhance/ingress-gce","homepage":"","size":44473,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"128465bf251208c994b745fe787779490613200a","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":105967469,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU5Njc0Njk=","name":"ingress-gce","full_name":"kubernetes/ingress-gce","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/ingress-gce","description":"Ingress controller for Google Cloud","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress-gce","forks_url":"https://api.github.com/repos/kubernetes/ingress-gce/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress-gce/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress-gce/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress-gce/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress-gce/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress-gce/deployments","created_at":"2017-10-06T04:32:12Z","updated_at":"2019-09-12T17:13:26Z","pushed_at":"2019-09-13T02:30:01Z","git_url":"git://github.com/kubernetes/ingress-gce.git","ssh_url":"git@github.com:kubernetes/ingress-gce.git","clone_url":"https://github.com/kubernetes/ingress-gce.git","svn_url":"https://github.com/kubernetes/ingress-gce","homepage":"","size":44230,"stargazers_count":793,"watchers_count":793,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":177,"open_issues":68,"watchers":793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/851"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/851"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/851"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/851/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/851/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/851/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/3f0914fb52d54018e69cea14137a7cdb7f2130ed"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 105967469,
"name": "kubernetes/ingress-gce",
"url": "https://api.github.com/repos/kubernetes/ingress-gce"
}
|
{
"id": 837034,
"login": "bowei",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/837034?",
"url": "https://api.github.com/users/bowei"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-09-13T20:23:44 |
10414094460
|
{"actor":{"display_login":"bowei"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments/275273517","pull_request_review_id":226536401,"id":275273517,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTI3MzUxNw==","diff_hunk":"@@ -282,3 +291,17 @@ func getLatencyThreshold(call *apiCall) time.Duration {\n \t}\n \treturn latencyThreshold\n }\n+\n+type apiResponsivenessPrometheus struct {\n+\tmetric *apiResponsiveness\n+}\n+\n+// SummaryName returns name of the summary.\n+func (*apiResponsivenessPrometheus) SummaryName() string {\n+\treturn apiResponsivenessPrometheusMeasurementName\n+}\n+","path":"clusterloader2/pkg/measurement/common/slos/api_responsiveness_prometheus.go","position":51,"original_position":51,"commit_id":"0d07406a9eebfbc2d87af2ff17bb348d662088c6","original_commit_id":"0d07406a9eebfbc2d87af2ff17bb348d662088c6","user":{"login":"wojtek-t","id":10743879,"node_id":"MDQ6VXNlcjEwNzQzODc5","avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"SummaryTime() is needed:\r\nhttps://github.com/kubernetes/perf-tests/pull/490","created_at":"2019-04-15T09:21:47Z","updated_at":"2019-04-15T09:24:03Z","html_url":"https://github.com/kubernetes/perf-tests/pull/493#discussion_r275273517","pull_request_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/493","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments/275273517"},"html":{"href":"https://github.com/kubernetes/perf-tests/pull/493#discussion_r275273517"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/493"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/493","id":269692177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5NjkyMTc3","html_url":"https://github.com/kubernetes/perf-tests/pull/493","diff_url":"https://github.com/kubernetes/perf-tests/pull/493.diff","patch_url":"https://github.com/kubernetes/perf-tests/pull/493.patch","issue_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/493","number":493,"state":"open","locked":false,"title":"ClusterLoader - Adding api reposiveness prometheus to tests","user":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"body":"- Making api responsiveness measurement non-failable.\r\n- Addinf api responsiveness measurement to density and load test.","created_at":"2019-04-11T18:22:23Z","updated_at":"2019-04-15T09:24:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09b12da991dbdb5ae07611865a7ef1c317f83624","assignee":{"login":"wojtek-t","id":10743879,"node_id":"MDQ6VXNlcjEwNzQzODc5","avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"assignees":[{"login":"wojtek-t","id":10743879,"node_id":"MDQ6VXNlcjEwNzQzODc5","avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mborsz","id":2559168,"node_id":"MDQ6VXNlcjI1NTkxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2559168?v=4","gravatar_id":"","url":"https://api.github.com/users/mborsz","html_url":"https://github.com/mborsz","followers_url":"https://api.github.com/users/mborsz/followers","following_url":"https://api.github.com/users/mborsz/following{/other_user}","gists_url":"https://api.github.com/users/mborsz/gists{/gist_id}","starred_url":"https://api.github.com/users/mborsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mborsz/subscriptions","organizations_url":"https://api.github.com/users/mborsz/orgs","repos_url":"https://api.github.com/users/mborsz/repos","events_url":"https://api.github.com/users/mborsz/events{/privacy}","received_events_url":"https://api.github.com/users/mborsz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":764013057,"node_id":"MDU6TGFiZWw3NjQwMTMwNTc=","url":"https://api.github.com/repos/kubernetes/perf-tests/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":492296491,"node_id":"MDU6TGFiZWw0OTIyOTY0OTE=","url":"https://api.github.com/repos/kubernetes/perf-tests/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":714851424,"node_id":"MDU6TGFiZWw3MTQ4NTE0MjQ=","url":"https://api.github.com/repos/kubernetes/perf-tests/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/493/commits","review_comments_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/493/comments","review_comment_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/493/comments","statuses_url":"https://api.github.com/repos/kubernetes/perf-tests/statuses/0d07406a9eebfbc2d87af2ff17bb348d662088c6","head":{"label":"krzysied:cluster_loader_api_reposiveness_prometheus_nonblocking","ref":"cluster_loader_api_reposiveness_prometheus_nonblocking","sha":"0d07406a9eebfbc2d87af2ff17bb348d662088c6","user":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"repo":{"id":128908558,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5MDg1NTg=","name":"perf-tests","full_name":"krzysied/perf-tests","private":false,"owner":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"html_url":"https://github.com/krzysied/perf-tests","description":"Performance tests and benchmarks","fork":true,"url":"https://api.github.com/repos/krzysied/perf-tests","forks_url":"https://api.github.com/repos/krzysied/perf-tests/forks","keys_url":"https://api.github.com/repos/krzysied/perf-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krzysied/perf-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krzysied/perf-tests/teams","hooks_url":"https://api.github.com/repos/krzysied/perf-tests/hooks","issue_events_url":"https://api.github.com/repos/krzysied/perf-tests/issues/events{/number}","events_url":"https://api.github.com/repos/krzysied/perf-tests/events","assignees_url":"https://api.github.com/repos/krzysied/perf-tests/assignees{/user}","branches_url":"https://api.github.com/repos/krzysied/perf-tests/branches{/branch}","tags_url":"https://api.github.com/repos/krzysied/perf-tests/tags","blobs_url":"https://api.github.com/repos/krzysied/perf-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krzysied/perf-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krzysied/perf-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/krzysied/perf-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krzysied/perf-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/krzysied/perf-tests/languages","stargazers_url":"https://api.github.com/repos/krzysied/perf-tests/stargazers","contributors_url":"https://api.github.com/repos/krzysied/perf-tests/contributors","subscribers_url":"https://api.github.com/repos/krzysied/perf-tests/subscribers","subscription_url":"https://api.github.com/repos/krzysied/perf-tests/subscription","commits_url":"https://api.github.com/repos/krzysied/perf-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/krzysied/perf-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/krzysied/perf-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/krzysied/perf-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/krzysied/perf-tests/contents/{+path}","compare_url":"https://api.github.com/repos/krzysied/perf-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krzysied/perf-tests/merges","archive_url":"https://api.github.com/repos/krzysied/perf-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krzysied/perf-tests/downloads","issues_url":"https://api.github.com/repos/krzysied/perf-tests/issues{/number}","pulls_url":"https://api.github.com/repos/krzysied/perf-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/krzysied/perf-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/krzysied/perf-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krzysied/perf-tests/labels{/name}","releases_url":"https://api.github.com/repos/krzysied/perf-tests/releases{/id}","deployments_url":"https://api.github.com/repos/krzysied/perf-tests/deployments","created_at":"2018-04-10T09:33:00Z","updated_at":"2018-04-10T09:33:03Z","pushed_at":"2019-04-15T09:19:30Z","git_url":"git://github.com/krzysied/perf-tests.git","ssh_url":"git@github.com:krzysied/perf-tests.git","clone_url":"https://github.com/krzysied/perf-tests.git","svn_url":"https://github.com/krzysied/perf-tests","homepage":null,"size":71596,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"9e184d2a2cb7c0eb9c2e0f23961342fb2df32fa4","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":68769911,"node_id":"MDEwOlJlcG9zaXRvcnk2ODc2OTkxMQ==","name":"perf-tests","full_name":"kubernetes/perf-tests","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/perf-tests","description":"Performance tests and benchmarks","fork":false,"url":"https://api.github.com/repos/kubernetes/perf-tests","forks_url":"https://api.github.com/repos/kubernetes/perf-tests/forks","keys_url":"https://api.github.com/repos/kubernetes/perf-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/perf-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/perf-tests/teams","hooks_url":"https://api.github.com/repos/kubernetes/perf-tests/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/perf-tests/events","assignees_url":"https://api.github.com/repos/kubernetes/perf-tests/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/perf-tests/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/perf-tests/tags","blobs_url":"https://api.github.com/repos/kubernetes/perf-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/perf-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/perf-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/perf-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/perf-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/perf-tests/languages","stargazers_url":"https://api.github.com/repos/kubernetes/perf-tests/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/perf-tests/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/perf-tests/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/perf-tests/subscription","commits_url":"https://api.github.com/repos/kubernetes/perf-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/perf-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/perf-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/perf-tests/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/perf-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/perf-tests/merges","archive_url":"https://api.github.com/repos/kubernetes/perf-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/perf-tests/downloads","issues_url":"https://api.github.com/repos/kubernetes/perf-tests/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/perf-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/perf-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/perf-tests/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/perf-tests/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/perf-tests/deployments","created_at":"2016-09-21T01:59:44Z","updated_at":"2019-04-14T15:54:00Z","pushed_at":"2019-04-15T09:19:32Z","git_url":"git://github.com/kubernetes/perf-tests.git","ssh_url":"git@github.com:kubernetes/perf-tests.git","clone_url":"https://github.com/kubernetes/perf-tests.git","svn_url":"https://github.com/kubernetes/perf-tests","homepage":null,"size":64315,"stargazers_count":207,"watchers_count":207,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":113,"open_issues":34,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/493"},"html":{"href":"https://github.com/kubernetes/perf-tests/pull/493"},"issue":{"href":"https://api.github.com/repos/kubernetes/perf-tests/issues/493"},"comments":{"href":"https://api.github.com/repos/kubernetes/perf-tests/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/perf-tests/statuses/0d07406a9eebfbc2d87af2ff17bb348d662088c6"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 68769911,
"name": "kubernetes/perf-tests",
"url": "https://api.github.com/repos/kubernetes/perf-tests"
}
|
{
"id": 10743879,
"login": "wojtek-t",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10743879?",
"url": "https://api.github.com/users/wojtek-t"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-04-15T09:21:47 |
9443413103
|
{"actor":{"display_login":"wojtek-t"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/305838928","pull_request_review_id":264807168,"id":305838928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTgzODkyOA==","diff_hunk":"@@ -0,0 +1,146 @@\n+/*\n+Copyright 2015 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package app\n+\n+import (\n+\t\"fmt\"\n+\t\"net/url\"\n+\n+\t\"k8s.io/component-base/cli/flag\"\n+\t\"k8s.io/klog\"\n+\t\"k8s.io/kubernetes/cmd/cri-dockerd/app/options\"\n+\t\"k8s.io/kubernetes/pkg/kubelet/dockershim\"\n+\tdockerremote \"k8s.io/kubernetes/pkg/kubelet/dockershim/remote\"\n+\t\"k8s.io/kubernetes/pkg/kubelet/server/streaming\"\n+\tutilflag \"k8s.io/kubernetes/pkg/util/flag\"\n+\t\"k8s.io/kubernetes/pkg/version/verflag\"\n+\n+\t\"github.com/spf13/cobra\"\n+\t\"github.com/spf13/pflag\"\n+)\n+\n+const (\n+\tcomponentDockerCRI = \"DockerCRI\"\n+)\n+\n+// NewDockerCRICommand creates a *cobra.Command object with default parameters\n+func NewDockerCRICommand(stopCh <-chan struct{}) *cobra.Command {\n+\tcleanFlagSet := pflag.NewFlagSet(componentDockerCRI, pflag.ContinueOnError)\n+\tcleanFlagSet.SetNormalizeFunc(flag.WordSepNormalizeFunc)\n+\tkubeletFlags := options.NewDockerCRIFlags()\n+\n+\tcmd := &cobra.Command{\n+\t\tUse: componentDockerCRI,\n+\t\tLong: `CRI that connects to Docker Daemon`,\n+\t\t// The cri-dockerd has special flag parsing requirements to enforce flag precedence rules,\n+\t\t// so we do all our parsing manually in Run, below.\n+\t\t// DisableFlagParsing=true provides the full set of flags passed to the cri-dockerd in the\n+\t\t// `args` arg to Run, without Cobra's interference.\n+\t\tDisableFlagParsing: true,","path":"cmd/cri-dockerd/app/server.go","position":53,"original_position":53,"commit_id":"51be6b8d5ae79e58074485eb7c40e9896770321e","original_commit_id":"7ce1f74c0eb13d57f36c966d2a0b20147b15d02f","user":{"login":"rosti","id":1117321,"node_id":"MDQ6VXNlcjExMTczMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1117321?v=4","gravatar_id":"","url":"https://api.github.com/users/rosti","html_url":"https://github.com/rosti","followers_url":"https://api.github.com/users/rosti/followers","following_url":"https://api.github.com/users/rosti/following{/other_user}","gists_url":"https://api.github.com/users/rosti/gists{/gist_id}","starred_url":"https://api.github.com/users/rosti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosti/subscriptions","organizations_url":"https://api.github.com/users/rosti/orgs","repos_url":"https://api.github.com/users/rosti/repos","events_url":"https://api.github.com/users/rosti/events{/privacy}","received_events_url":"https://api.github.com/users/rosti/received_events","type":"User","site_admin":false},"body":"@dims Indeed, I can see that this outside the scope of this PR, but we can still add a simplification TODO there.\r\nThe complex way of doing command line parsing in the kubelet is required, because of the ability to override config fields with command line flags. If we don't need the KubeletConfiguration in cri-dockerd, then we can greatly simplify things.\r\n\r\n@neolit123 that can be done by adding a dependency in the kubelet package to the cri-dockerd package.","created_at":"2019-07-22T13:17:02Z","updated_at":"2019-07-22T13:17:03Z","html_url":"https://github.com/kubernetes/kubernetes/pull/74051#discussion_r305838928","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74051","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/305838928"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/74051#discussion_r305838928"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74051"}},"in_reply_to_id":304332829},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74051","id":252922108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyOTIyMTA4","html_url":"https://github.com/kubernetes/kubernetes/pull/74051","diff_url":"https://github.com/kubernetes/kubernetes/pull/74051.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/74051.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74051","number":74051,"state":"open","locked":false,"title":"[WIP] Initial-cut of cri-dockerd","user":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"body":"\r\n<!-- Thanks for sending a pull request! Here are some tips for you:\r\n\r\n1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n/kind feature\r\n\r\n**What this PR does / why we need it**:\r\nWe have a long standing TODO to break up kubelet's built-in docker shim into a separate binary. This brings docker in line with all the other CRI providers and levels the playing field for all CRI(s).\r\n\r\n**Which issue(s) this PR fixes**:\r\n<!-- \r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n-->\r\nFixes #73933\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!-- \r\nIf no, just write \"NONE\" in the release-note block below.\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\ncri-dockerd is a separate binary for running the CRI for Docker that was previously built into kubelet. You can run this binary separately and then use \"--container-runtime=remote\" when you start kubelet.\r\n```\r\n","created_at":"2019-02-14T03:01:11Z","updated_at":"2019-07-22T13:17:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"155e1a013cfc7a8eb9d0b5559c708cc9b15bf410","assignee":{"login":"timothysc","id":169553,"node_id":"MDQ6VXNlcjE2OTU1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"assignees":[{"login":"timothysc","id":169553,"node_id":"MDQ6VXNlcjE2OTU1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},{"login":"Random-Liu","id":5821883,"node_id":"MDQ6VXNlcjU4MjE4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},{"login":"dchen1107","id":7740897,"node_id":"MDQ6VXNlcjc3NDA4OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7740897?v=4","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":105152717,"node_id":"MDU6TGFiZWwxMDUxNTI3MTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/test","name":"area/test","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687565804,"node_id":"MDU6TGFiZWw2ODc1NjU4MDQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74051/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74051/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74051/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/51be6b8d5ae79e58074485eb7c40e9896770321e","head":{"label":"dims:separate-binary-for-running-docker-shim","ref":"separate-binary-for-running-docker-shim","sha":"51be6b8d5ae79e58074485eb7c40e9896770321e","user":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"repo":{"id":58837596,"node_id":"MDEwOlJlcG9zaXRvcnk1ODgzNzU5Ng==","name":"kubernetes","full_name":"dims/kubernetes","private":false,"owner":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dims/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/dims/kubernetes","forks_url":"https://api.github.com/repos/dims/kubernetes/forks","keys_url":"https://api.github.com/repos/dims/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dims/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dims/kubernetes/teams","hooks_url":"https://api.github.com/repos/dims/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dims/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dims/kubernetes/events","assignees_url":"https://api.github.com/repos/dims/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dims/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dims/kubernetes/tags","blobs_url":"https://api.github.com/repos/dims/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dims/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dims/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dims/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dims/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dims/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dims/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dims/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dims/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dims/kubernetes/subscription","commits_url":"https://api.github.com/repos/dims/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dims/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dims/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dims/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dims/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dims/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dims/kubernetes/merges","archive_url":"https://api.github.com/repos/dims/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dims/kubernetes/downloads","issues_url":"https://api.github.com/repos/dims/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dims/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dims/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dims/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dims/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dims/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dims/kubernetes/deployments","created_at":"2016-05-15T01:04:18Z","updated_at":"2019-07-21T00:38:19Z","pushed_at":"2019-07-21T00:38:09Z","git_url":"git://github.com/dims/kubernetes.git","ssh_url":"git@github.com:dims/kubernetes.git","clone_url":"https://github.com/dims/kubernetes.git","svn_url":"https://github.com/dims/kubernetes","homepage":"http://kubernetes.io","size":650047,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a10eced56b9100c30489b10c7a01e685735f6f0b","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2019-07-22T11:56:01Z","pushed_at":"2019-07-22T12:56:03Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":879128,"stargazers_count":55616,"watchers_count":55616,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19324,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3236,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19324,"open_issues":3236,"watchers":55616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74051"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/74051"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/74051"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/74051/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74051/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74051/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/51be6b8d5ae79e58074485eb7c40e9896770321e"}},"author_association":"MEMBER"}}
|
{
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
}
|
{
"id": 1117321,
"login": "rosti",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1117321?",
"url": "https://api.github.com/users/rosti"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-07-22T13:17:02 |
10058121739
|
{"actor":{"display_login":"rosti"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/website/pulls/comments/337536163","pull_request_review_id":305231857,"id":337536163,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzUzNjE2Mw==","diff_hunk":"@@ -0,0 +1,253 @@\n+#!/usr/bin/env python3\n+##\n+# This script was tested with Python 3.7.4, Go 1.12, and PyYAML 5.1.2\n+# installed in a virtual environment.\n+#\n+# This script updates the generated reference documentation.\n+# See https://kubernetes.io/docs/contribute/generate-ref-docs/kubernetes-components/\n+# for further details.\n+#\n+# This script checks to make sure Go and PyYAML have been installed.\n+# The reference docs are generated by a Go command so the Go binary must be\n+# in your PATH.\n+#\n+# A temp \"work_dir\" is created and is the path where repos will be cloned.\n+# The work_dir is printed out so you can remove it\n+# when you no longer need the contents.\n+# This work_dir will temporarily become the GOPATH.\n+#\n+# To execute the script from the website/update-imported-docs directory:\n+# ./update-imported-docs.py <config_file>\n+# Config files:\n+# reference.yml use this to update the reference docs\n+# release.yml use this to auto-generate/import release notes\n+##\n+\n+import argparse\n+import glob\n+import os\n+import re\n+import shutil\n+import subprocess\n+import sys\n+import tempfile\n+\n+error_msgs = []\n+\n+reqs = subprocess.check_output([sys.executable, '-m', 'pip', 'freeze'])\n+installed_packages = [r.decode().split('==')[0] for r in reqs.split()]\n+if 'PyYAML' not in installed_packages:\n+ error_msgs.append(\n+ \"Please ensure PyYAML package is installed (https://pypi.org/project/PyYAML/). This can be done, for \"\n+ \"example, by executing the following command: pip install PyYAML \")\n+else:\n+ import yaml\n+\n+if not shutil.which('go'):\n+ error_msgs.append(\n+ \"Go must be installed. See https://golang.org/doc/install\")\n+\n+\n+def process_links(content, remote_prefix, sub_path):\n+ \"\"\"Process markdown links found in the docs.\"\"\"\n+\n+ def analyze(match_obj):\n+ ankor = match_obj.group('ankor')\n+ target = match_obj.group('target')\n+ if not (target.startswith(\"https://\") or\n+ target.startswith(\"mailto:\") or\n+ target.startswith(\"#\")):\n+ if target.startswith(\"/\"):\n+ target_list = remote_prefix, target[1:]\n+ target = \"/\".join(target_list)\n+ else:\n+ target_list = remote_prefix, sub_path, target\n+ target = \"/\".join(target_list)\n+\n+ return \"[%s](%s)\" % (ankor, target)\n+\n+ # Links are in the form '[text](url)'\n+ link_regex = re.compile(r\"\\[(?P<ankor>.*)\\]\\((?P<target>.*)\\)\")\n+ content = re.sub(link_regex, analyze, content)\n+\n+ h1_regex = re.compile(\"^(# .*)?\\n\")\n+ content = re.sub(h1_regex, \"\", content)\n+\n+ return content\n+\n+\n+def process_kubectl_links(content):\n+ \"\"\"Update markdown links found in the SeeAlso section of kubectl page.\n+ Example:[kubectl annotate](/docs/reference/generated/kubectl/kubectl-commands#annotate)\n+ \"\"\"\n+\n+ def analyze(match_obj):\n+ ankor = match_obj.group('ankor')\n+ target = match_obj.group('target')\n+ if target.endswith(\".md\") and target.startswith(\"kubectl\"):\n+ ankor_list = ankor.split(\"kubectl \")\n+ target = \"/docs/reference/generated/kubectl/kubectl-commands\" + \"#\" + \\\n+ ankor_list[1]\n+ return \"[%s](%s)\" % (ankor, target)\n+\n+ # Links are in the form '[text](url)'\n+ link_regex = re.compile(r\"\\[(?P<ankor>.*)\\]\\((?P<target>.*?)\\)\")\n+ content = re.sub(link_regex, analyze, content)\n+\n+ return content\n+\n+\n+def process_file(src, dst, repo_path, repo_dir, root_dir, gen_absolute_links):\n+ \"\"\"Process a file element.\n+\n+ :param src: A string containing the relative path of a source file. The\n+ string may contain wildcard characters such as '*' or '?'.\n+ :param dst: The path for the destination file. The string can be a\n+ directory name or a file name.\n+ :param repo_path:\n+ :param repo_dir:\n+ :param root_dir:\n+ :param gen_absolute_links:\n+ \"\"\"\n+ pattern = os.path.join(repo_dir, repo_path, src)\n+ dst_path = os.path.join(root_dir, dst)\n+\n+ for src in glob.glob(pattern):\n+ # we don't dive into subdirectories\n+ if not os.path.isfile(src):\n+ print(\"[Error] skipping non-regular path {}\".format(src))\n+ continue\n+\n+ content = \"\"\n+ try:\n+ with open(src, \"r\") as srcFile:\n+ content = srcFile.read()\n+ except Exception as ex:\n+ print(\"[Error] failed in reading source file: \".format(ex))\n+ continue\n+\n+ dst = dst_path\n+ if dst_path.endswith(\"/\"):\n+ base_name = os.path.basename(src)\n+ dst = os.path.join(dst, base_name)\n+\n+ try:\n+ print(\"Writing doc: \" + dst)\n+ with open(dst, \"w\") as dstFile:\n+ if gen_absolute_links:\n+ src_dir = os.path.dirname(src)\n+ remote_prefix = repo_path + \"/tree/master\"\n+ content = process_links(content, remote_prefix, src_dir)\n+ if dst.endswith(\"kubectl.md\"):\n+ print(\"Processing kubectl links\")\n+ content = process_kubectl_links(content)\n+ dstFile.write(content)\n+ except Exception as ex:\n+ print(\"[Error] failed in writing target file {}: {}\".format(dst, ex))\n+ continue\n+\n+\n+def parse_input_args():\n+ \"\"\"\n+ Parse command line argument\n+ There is only one argument, 'config_file, which should be one of the YAML\n+ files in this same directory\n+ :return: parsed argument\n+ \"\"\"\n+ parser = argparse.ArgumentParser()\n+ parser.add_argument('config_file', type=str,\n+ help=\"reference.yml to generate reference docs; \"\n+ \"release.yml to generate release notes\")\n+ return parser.parse_args()\n+\n+\n+def main():\n+ \"\"\"The main entry of the program.\"\"\"\n+ if len(error_msgs) > 0:\n+ for msg in error_msgs:\n+ print(msg + \"/n\")\n+ # sys.exit(-1)\n+ return -2\n+\n+ # first parse input argument\n+ in_args = parse_input_args()\n+ config_file = in_args.config_file\n+ print(\"config_file is {}\".format(config_file))\n+\n+ curr_dir = os.path.dirname(__file__)\n+ print(\"curr_dir {}\".format(curr_dir))\n+ root_dir = os.path.realpath(os.path.join(curr_dir, '..'))\n+ print(\"root_dir {}\".format(root_dir))\n+\n+ try:\n+ # yaml.load has been deprecated\n+ # https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation\n+ config_data = yaml.full_load(open(config_file, 'r'))\n+ except Exception as ex:\n+ print(\"[Error] failed in loading config file - {}\".format(str(ex)))\n+ return -2\n+\n+ os.chdir(root_dir)\n+\n+ # create the temp work_dir\n+ try:\n+ print(\"Making temp work_dir\")\n+ work_dir = tempfile.mkdtemp()\n+ except OSError as ose:\n+ print(\"[Error] Unable to create temp work_dir {}; error: {}\"\n+ .format(work_dir, ose))\n+ return -2","path":"update-imported-docs/update-imported-docs.py","position":201,"original_position":199,"commit_id":"6656021b038cdcdceca745b42936ae2b727b8a6f","original_commit_id":"e50a185d44f6b058b320791e057cb270f7d3b913","user":{"login":"kbhawkey","id":1696019,"node_id":"MDQ6VXNlcjE2OTYwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1696019?v=4","gravatar_id":"","url":"https://api.github.com/users/kbhawkey","html_url":"https://github.com/kbhawkey","followers_url":"https://api.github.com/users/kbhawkey/followers","following_url":"https://api.github.com/users/kbhawkey/following{/other_user}","gists_url":"https://api.github.com/users/kbhawkey/gists{/gist_id}","starred_url":"https://api.github.com/users/kbhawkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbhawkey/subscriptions","organizations_url":"https://api.github.com/users/kbhawkey/orgs","repos_url":"https://api.github.com/users/kbhawkey/repos","events_url":"https://api.github.com/users/kbhawkey/events{/privacy}","received_events_url":"https://api.github.com/users/kbhawkey/received_events","type":"User","site_admin":false},"body":"OK","created_at":"2019-10-22T14:03:42Z","updated_at":"2019-10-22T14:03:42Z","html_url":"https://github.com/kubernetes/website/pull/16681#discussion_r337536163","pull_request_url":"https://api.github.com/repos/kubernetes/website/pulls/16681","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments/337536163"},"html":{"href":"https://github.com/kubernetes/website/pull/16681#discussion_r337536163"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16681"}},"in_reply_to_id":334708037},"pull_request":{"url":"https://api.github.com/repos/kubernetes/website/pulls/16681","id":324335863,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0MzM1ODYz","html_url":"https://github.com/kubernetes/website/pull/16681","diff_url":"https://github.com/kubernetes/website/pull/16681.diff","patch_url":"https://github.com/kubernetes/website/pull/16681.patch","issue_url":"https://api.github.com/repos/kubernetes/website/issues/16681","number":16681,"state":"open","locked":false,"title":"Update website/update-imported-docs/update-imported-docs script for Python 3, PyYAML 5.1.2","user":{"login":"aimeeu","id":26799583,"node_id":"MDQ6VXNlcjI2Nzk5NTgz","avatar_url":"https://avatars3.githubusercontent.com/u/26799583?v=4","gravatar_id":"","url":"https://api.github.com/users/aimeeu","html_url":"https://github.com/aimeeu","followers_url":"https://api.github.com/users/aimeeu/followers","following_url":"https://api.github.com/users/aimeeu/following{/other_user}","gists_url":"https://api.github.com/users/aimeeu/gists{/gist_id}","starred_url":"https://api.github.com/users/aimeeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aimeeu/subscriptions","organizations_url":"https://api.github.com/users/aimeeu/orgs","repos_url":"https://api.github.com/users/aimeeu/repos","events_url":"https://api.github.com/users/aimeeu/events{/privacy}","received_events_url":"https://api.github.com/users/aimeeu/received_events","type":"User","site_admin":false},"body":"The current version of the script works with Python 2.7, PyYAML 3.13, Go 1.12. \r\n\r\nThis PR grew out of my attempts to run the website/update-imported-docs/update-imported-docs script using Python 3.7, **Go 1.13**, and PyYAML 5.1 -- Slack [thread](https://kubernetes.slack.com/archives/C1J0BPD2M/p1570125720198000).Using Go 1.13 caused numerous GOPATH issues.\r\n\r\nNeither the script nor [documentation](https://kubernetes.io/docs/contribute/generate-ref-docs/kubernetes-components/) specify what version of Python the script was tested with, nor the version of Golang, Git, or PyYAML; docs page says Golang v 1.9 or later… yet Kubernetes development lists specific versions of Golang for specific versions of Kubernetes (see [list](https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#go)). My issue was using Go 1.13, which Kubernetes does not support.\r\n\r\n@tengqm agreed that the script should be updated to work with Python 3. I took this opportunity to \"pythonify\" the code.\r\n\r\nUpdating to the latest version of PyYAML required an update to remove a deprecated function. Looking at the code, I decided it would be better to use the Python tempfile library to create the temp directory rather than `os` and `shutil` libraries.\r\n\r\n**This script was tested on Ubuntu 18 with Python 3.7.4, go1.12.10 linux/amd64, and PyYAML 5.1.2 installed in a virtual environment.**\r\n\r\nCurrent version in master for comparison: https://github.com/kubernetes/website/blob/master/update-imported-docs/update-imported-docs\r\n\r\n- Add .py extension to update-imported-docs file\r\n- Update shebang for Python 3\r\n- Add script comments: software versions, what the script does, and how to run it\r\n- Update to use argparse.ArgumentParser() for command line args\r\n- Change work_dir from hard-coded dir to tmp dir created using the tempfile library; remove shutil.rmtree because it was throwing permission errors and also no longer needed after switching\r\nto temp dir created with tempfile.\r\n- Enhance error handling\r\n- Add check for Go installation\r\n- Enhance check for PyYAML installation\r\n- Change deprecated PyYAML load function to full_load https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation\r\n- Modify to comply with PEP8\r\n\r\nPartial #15682 \r\n\r\n**Also updated the software version in kubernetes-components.md #before-you-begin**\r\n\r\nSigned-off-by: Aimee Ukasick <aimeeu.opensource@gmail.com>\r\n\r\n**STEPS TO TEST THE SCRIPT**\r\nScenario 1: PyYAML not installed.\r\n1. (Optional) Create a virtual environment with Python = 3.7.4\r\n2. `cd` to website/update-imported-script and execute the script `$ ./update-imported-docs.py reference.yml` - you should see a message that says `Please ensure PyYAML package is installed (https://pypi.org/project/PyYAML/). This can be done, for example, by executing the following command: pip install PyYAML`\r\n","created_at":"2019-10-03T17:55:02Z","updated_at":"2019-10-22T14:03:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86527ccc14f05817057c4934b44c14ba2d59da5b","assignee":{"login":"kbhawkey","id":1696019,"node_id":"MDQ6VXNlcjE2OTYwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1696019?v=4","gravatar_id":"","url":"https://api.github.com/users/kbhawkey","html_url":"https://github.com/kbhawkey","followers_url":"https://api.github.com/users/kbhawkey/followers","following_url":"https://api.github.com/users/kbhawkey/following{/other_user}","gists_url":"https://api.github.com/users/kbhawkey/gists{/gist_id}","starred_url":"https://api.github.com/users/kbhawkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbhawkey/subscriptions","organizations_url":"https://api.github.com/users/kbhawkey/orgs","repos_url":"https://api.github.com/users/kbhawkey/repos","events_url":"https://api.github.com/users/kbhawkey/events{/privacy}","received_events_url":"https://api.github.com/users/kbhawkey/received_events","type":"User","site_admin":false},"assignees":[{"login":"kbhawkey","id":1696019,"node_id":"MDQ6VXNlcjE2OTYwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1696019?v=4","gravatar_id":"","url":"https://api.github.com/users/kbhawkey","html_url":"https://github.com/kbhawkey","followers_url":"https://api.github.com/users/kbhawkey/followers","following_url":"https://api.github.com/users/kbhawkey/following{/other_user}","gists_url":"https://api.github.com/users/kbhawkey/gists{/gist_id}","starred_url":"https://api.github.com/users/kbhawkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbhawkey/subscriptions","organizations_url":"https://api.github.com/users/kbhawkey/orgs","repos_url":"https://api.github.com/users/kbhawkey/repos","events_url":"https://api.github.com/users/kbhawkey/events{/privacy}","received_events_url":"https://api.github.com/users/kbhawkey/received_events","type":"User","site_admin":false},{"login":"tengqm","id":5094756,"node_id":"MDQ6VXNlcjUwOTQ3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5094756?v=4","gravatar_id":"","url":"https://api.github.com/users/tengqm","html_url":"https://github.com/tengqm","followers_url":"https://api.github.com/users/tengqm/followers","following_url":"https://api.github.com/users/tengqm/following{/other_user}","gists_url":"https://api.github.com/users/tengqm/gists{/gist_id}","starred_url":"https://api.github.com/users/tengqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tengqm/subscriptions","organizations_url":"https://api.github.com/users/tengqm/orgs","repos_url":"https://api.github.com/users/tengqm/repos","events_url":"https://api.github.com/users/tengqm/events{/privacy}","received_events_url":"https://api.github.com/users/tengqm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484571291,"node_id":"MDU6TGFiZWw0ODQ1NzEyOTE=","url":"https://api.github.com/repos/kubernetes/website/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1078396901,"node_id":"MDU6TGFiZWwxMDc4Mzk2OTAx","url":"https://api.github.com/repos/kubernetes/website/labels/language/en","name":"language/en","color":"e9b3f9","default":false},{"id":764235355,"node_id":"MDU6TGFiZWw3NjQyMzUzNTU=","url":"https://api.github.com/repos/kubernetes/website/labels/sig/docs","name":"sig/docs","color":"d2b48c","default":false},{"id":679457866,"node_id":"MDU6TGFiZWw2Nzk0NTc4NjY=","url":"https://api.github.com/repos/kubernetes/website/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/website/pulls/16681/commits","review_comments_url":"https://api.github.com/repos/kubernetes/website/pulls/16681/comments","review_comment_url":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/website/issues/16681/comments","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/6656021b038cdcdceca745b42936ae2b727b8a6f","head":{"label":"aimeeu:aimeeu-refactorUpdateImportedDocsScript","ref":"aimeeu-refactorUpdateImportedDocsScript","sha":"6656021b038cdcdceca745b42936ae2b727b8a6f","user":{"login":"aimeeu","id":26799583,"node_id":"MDQ6VXNlcjI2Nzk5NTgz","avatar_url":"https://avatars3.githubusercontent.com/u/26799583?v=4","gravatar_id":"","url":"https://api.github.com/users/aimeeu","html_url":"https://github.com/aimeeu","followers_url":"https://api.github.com/users/aimeeu/followers","following_url":"https://api.github.com/users/aimeeu/following{/other_user}","gists_url":"https://api.github.com/users/aimeeu/gists{/gist_id}","starred_url":"https://api.github.com/users/aimeeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aimeeu/subscriptions","organizations_url":"https://api.github.com/users/aimeeu/orgs","repos_url":"https://api.github.com/users/aimeeu/repos","events_url":"https://api.github.com/users/aimeeu/events{/privacy}","received_events_url":"https://api.github.com/users/aimeeu/received_events","type":"User","site_admin":false},"repo":{"id":200889872,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA4ODk4NzI=","name":"website","full_name":"aimeeu/website","private":false,"owner":{"login":"aimeeu","id":26799583,"node_id":"MDQ6VXNlcjI2Nzk5NTgz","avatar_url":"https://avatars3.githubusercontent.com/u/26799583?v=4","gravatar_id":"","url":"https://api.github.com/users/aimeeu","html_url":"https://github.com/aimeeu","followers_url":"https://api.github.com/users/aimeeu/followers","following_url":"https://api.github.com/users/aimeeu/following{/other_user}","gists_url":"https://api.github.com/users/aimeeu/gists{/gist_id}","starred_url":"https://api.github.com/users/aimeeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aimeeu/subscriptions","organizations_url":"https://api.github.com/users/aimeeu/orgs","repos_url":"https://api.github.com/users/aimeeu/repos","events_url":"https://api.github.com/users/aimeeu/events{/privacy}","received_events_url":"https://api.github.com/users/aimeeu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aimeeu/website","description":"Kubernetes website and documentation repo: ","fork":true,"url":"https://api.github.com/repos/aimeeu/website","forks_url":"https://api.github.com/repos/aimeeu/website/forks","keys_url":"https://api.github.com/repos/aimeeu/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aimeeu/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aimeeu/website/teams","hooks_url":"https://api.github.com/repos/aimeeu/website/hooks","issue_events_url":"https://api.github.com/repos/aimeeu/website/issues/events{/number}","events_url":"https://api.github.com/repos/aimeeu/website/events","assignees_url":"https://api.github.com/repos/aimeeu/website/assignees{/user}","branches_url":"https://api.github.com/repos/aimeeu/website/branches{/branch}","tags_url":"https://api.github.com/repos/aimeeu/website/tags","blobs_url":"https://api.github.com/repos/aimeeu/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aimeeu/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aimeeu/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/aimeeu/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aimeeu/website/statuses/{sha}","languages_url":"https://api.github.com/repos/aimeeu/website/languages","stargazers_url":"https://api.github.com/repos/aimeeu/website/stargazers","contributors_url":"https://api.github.com/repos/aimeeu/website/contributors","subscribers_url":"https://api.github.com/repos/aimeeu/website/subscribers","subscription_url":"https://api.github.com/repos/aimeeu/website/subscription","commits_url":"https://api.github.com/repos/aimeeu/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/aimeeu/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/aimeeu/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/aimeeu/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/aimeeu/website/contents/{+path}","compare_url":"https://api.github.com/repos/aimeeu/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aimeeu/website/merges","archive_url":"https://api.github.com/repos/aimeeu/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aimeeu/website/downloads","issues_url":"https://api.github.com/repos/aimeeu/website/issues{/number}","pulls_url":"https://api.github.com/repos/aimeeu/website/pulls{/number}","milestones_url":"https://api.github.com/repos/aimeeu/website/milestones{/number}","notifications_url":"https://api.github.com/repos/aimeeu/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aimeeu/website/labels{/name}","releases_url":"https://api.github.com/repos/aimeeu/website/releases{/id}","deployments_url":"https://api.github.com/repos/aimeeu/website/deployments","created_at":"2019-08-06T16:45:11Z","updated_at":"2019-10-21T18:34:36Z","pushed_at":"2019-10-21T21:18:59Z","git_url":"git://github.com/aimeeu/website.git","ssh_url":"git@github.com:aimeeu/website.git","clone_url":"https://github.com/aimeeu/website.git","svn_url":"https://github.com/aimeeu/website","homepage":"https://kubernetes.io","size":244168,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"bc2323cece107167ae3551afc959553e6d8db405","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQ3ODI2Ng==","name":"website","full_name":"kubernetes/website","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/website","description":"Kubernetes website and documentation repo: ","fork":false,"url":"https://api.github.com/repos/kubernetes/website","forks_url":"https://api.github.com/repos/kubernetes/website/forks","keys_url":"https://api.github.com/repos/kubernetes/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/website/teams","hooks_url":"https://api.github.com/repos/kubernetes/website/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/website/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/website/events","assignees_url":"https://api.github.com/repos/kubernetes/website/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/website/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/website/tags","blobs_url":"https://api.github.com/repos/kubernetes/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/website/languages","stargazers_url":"https://api.github.com/repos/kubernetes/website/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/website/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/website/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/website/subscription","commits_url":"https://api.github.com/repos/kubernetes/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/website/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/website/merges","archive_url":"https://api.github.com/repos/kubernetes/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/website/downloads","issues_url":"https://api.github.com/repos/kubernetes/website/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/website/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/website/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/website/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/website/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/website/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2019-10-22T12:31:29Z","pushed_at":"2019-10-22T14:02:21Z","git_url":"git://github.com/kubernetes/website.git","ssh_url":"git@github.com:kubernetes/website.git","clone_url":"https://github.com/kubernetes/website.git","svn_url":"https://github.com/kubernetes/website","homepage":"https://kubernetes.io","size":275551,"stargazers_count":1604,"watchers_count":1604,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5708,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":680,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":5708,"open_issues":680,"watchers":1604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16681"},"html":{"href":"https://github.com/kubernetes/website/pull/16681"},"issue":{"href":"https://api.github.com/repos/kubernetes/website/issues/16681"},"comments":{"href":"https://api.github.com/repos/kubernetes/website/issues/16681/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16681/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16681/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/website/statuses/6656021b038cdcdceca745b42936ae2b727b8a6f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 51478266,
"name": "kubernetes/website",
"url": "https://api.github.com/repos/kubernetes/website"
}
|
{
"id": 1696019,
"login": "kbhawkey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1696019?",
"url": "https://api.github.com/users/kbhawkey"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-10-22T14:03:42 |
10686213212
|
{"actor":{"display_login":"kbhawkey"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/website/pulls/comments/317193752","pull_request_review_id":279079880,"id":317193752,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzE5Mzc1Mg==","diff_hunk":"@@ -0,0 +1,114 @@\n+---\n+reviewers:\n+- lavalamp\n+title: Kubernetesのコンポーネント\n+content_template: templates/concept\n+weight: 20\n+card: \n+ name: concepts\n+ weight: 20\n+---\n+\n+{{% capture overview %}}\n+このドキュメントでは、Kubernetesクラスターが機能するために必要となるさまざまなコンポーネントの概要を説明します。\n+{{% /capture %}}\n+\n+{{% capture body %}}\n+\n+## Masterコンポーネント\n+\n+Masterコンポーネントは、クラスターのコントロールプレーンを提供します。\n+Masterコンポーネントは、クラスターに関する(スケジューリングなどの)グローバルな決定を行います。また、クラスターイベントの検出および応答を行います(たとえば、deploymentの`replica`フィールドが満たされていない場合に、新しい {{< glossary_tooltip text=\"pod\" term_id=\"pod\">}} を起動する等)。\n+\n+Masterコンポーネントはクラスター内のどのマシンでも実行できますが、シンプルにするため、セットアップスクリプトは通常、すべてのMasterコンポーネントを同じマシンで起動し、そのマシンではユーザーコンテナを実行しません。\n+マルチMaster VMセットアップの例については、[高可用性クラスターの構築](/docs/admin/high-availability/) を参照してください。\n+\n+### kube-apiserver\n+\n+{{< glossary_definition term_id=\"kube-apiserver\" length=\"all\" >}}\n+\n+### etcd\n+\n+{{< glossary_definition term_id=\"etcd\" length=\"all\" >}}\n+\n+### kube-scheduler\n+\n+{{< glossary_definition term_id=\"kube-scheduler\" length=\"all\" >}}\n+\n+### kube-controller-manager\n+\n+{{< glossary_definition term_id=\"kube-controller-manager\" length=\"all\" >}}\n+\n+コントローラーには以下が含まれます。\n+\n+ * Nodeコントローラー：Nodeがダウンした場合の通知と対応を担当します。\n+ * Replicationコントローラー：システム内の全Replicationコントローラーオブジェクトについて、Podの数を正しく保つ役割を持ちます。\n+ * Endpointコントローラー：Endpointオブジェクトを注入します(つまり、ServiceとPodを紐付けます)。\n+ * サービスアカウントとトークンコントローラー：新規の名前空間に対して、デフォルトアカウントとAPIアクセストークンを作成します。\n+\n+### cloud-controller-manager\n+\n+[cloud-controller-manager](/docs/tasks/administer-cluster/running-cloud-controller/) は、基盤であるクラウドプロバイダーと対話するコントローラーを実行します。\n+cloud-controller-managerバイナリは、Kubernetesリリース1.6で導入された機能です。\n+\n+cloud-controller-managerは、クラウドプロバイダー固有のコントローラーループのみを実行します。これらのコントローラーループはkube-controller-managerで無効にする必要があります。 kube-controller-managerの起動時に `--cloud-provider` フラグを `external` に設定することで、コントローラーループを無効にできます。\n+\n+cloud-controller-managerを使用すると、クラウドベンダーのコードとKubernetesコードを互いに独立して進化させることができます。以前のリリースでは、コアKubernetesコードは、機能的にクラウドプロバイダー固有のコードに依存していました。将来のリリースでは、クラウドベンダーに固有のコードはクラウドベンダー自身で管理し、Kubernetesの実行中にcloud-controller-managerにリンクする必要があります。\n+\n+次のコントローラーには、クラウドプロバイダーへの依存関係があります。\n+\n+ * Nodeコントローラー：Nodeが応答を停止した後、クラウドで削除されたかどうかを判断するため、クラウドプロバイダーをチェックします。","path":"content/ja/docs/concepts/overview/components.md","position":60,"original_position":60,"commit_id":"ace68aa6bcd625f04bf7ef33523e019e6bfaf76e","original_commit_id":"ace68aa6bcd625f04bf7ef33523e019e6bfaf76e","user":{"login":"nasa9084","id":11725486,"node_id":"MDQ6VXNlcjExNzI1NDg2","avatar_url":"https://avatars2.githubusercontent.com/u/11725486?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa9084","html_url":"https://github.com/nasa9084","followers_url":"https://api.github.com/users/nasa9084/followers","following_url":"https://api.github.com/users/nasa9084/following{/other_user}","gists_url":"https://api.github.com/users/nasa9084/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa9084/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa9084/subscriptions","organizations_url":"https://api.github.com/users/nasa9084/orgs","repos_url":"https://api.github.com/users/nasa9084/repos","events_url":"https://api.github.com/users/nasa9084/events{/privacy}","received_events_url":"https://api.github.com/users/nasa9084/received_events","type":"User","site_admin":false},"body":"この場合、\r\n`Node` はk8sのリソースでしょうか・・・\r\nあるいは`Node Controller`まで一セットでリソース(というかコンポーネント)として固有名詞扱いのほうがいい可能性も","created_at":"2019-08-23T15:47:53Z","updated_at":"2019-08-23T15:59:13Z","html_url":"https://github.com/kubernetes/website/pull/16034#discussion_r317193752","pull_request_url":"https://api.github.com/repos/kubernetes/website/pulls/16034","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments/317193752"},"html":{"href":"https://github.com/kubernetes/website/pull/16034#discussion_r317193752"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16034"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/website/pulls/16034","id":310359795,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwMzU5Nzk1","html_url":"https://github.com/kubernetes/website/pull/16034","diff_url":"https://github.com/kubernetes/website/pull/16034.diff","patch_url":"https://github.com/kubernetes/website/pull/16034.patch","issue_url":"https://api.github.com/repos/kubernetes/website/issues/16034","number":16034,"state":"open","locked":false,"title":"Translate concept and related glossaries to Japanese","user":{"login":"craftone","id":3645127,"node_id":"MDQ6VXNlcjM2NDUxMjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3645127?v=4","gravatar_id":"","url":"https://api.github.com/users/craftone","html_url":"https://github.com/craftone","followers_url":"https://api.github.com/users/craftone/followers","following_url":"https://api.github.com/users/craftone/following{/other_user}","gists_url":"https://api.github.com/users/craftone/gists{/gist_id}","starred_url":"https://api.github.com/users/craftone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftone/subscriptions","organizations_url":"https://api.github.com/users/craftone/orgs","repos_url":"https://api.github.com/users/craftone/repos","events_url":"https://api.github.com/users/craftone/events{/privacy}","received_events_url":"https://api.github.com/users/craftone/received_events","type":"User","site_admin":false},"body":"concept / components と、そこからリンクされている glossaries を日本語訳しました。\r\ngloassary はディレクトリ一式追加してしまいましたが、日本語訳しているのは以下12ファイルです。\r\n* container-runtime.md\r\n* controller.md\r\n* daemonset.md\r\n* deployment.md\r\n* etcd.md\r\n* kube-apiserver.md\r\n* kube-controller-manager.md\r\n* kube-proxy.md\r\n* kube-scheduler.md\r\n* kubelet.md\r\n* pod.md\r\n* service.md\r\n\r\n","created_at":"2019-08-23T12:10:08Z","updated_at":"2019-08-23T15:59:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c66a86ac4f2bc011eec32392a37e78d13a16e79e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MasayaAoyama","id":8783194,"node_id":"MDQ6VXNlcjg3ODMxOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8783194?v=4","gravatar_id":"","url":"https://api.github.com/users/MasayaAoyama","html_url":"https://github.com/MasayaAoyama","followers_url":"https://api.github.com/users/MasayaAoyama/followers","following_url":"https://api.github.com/users/MasayaAoyama/following{/other_user}","gists_url":"https://api.github.com/users/MasayaAoyama/gists{/gist_id}","starred_url":"https://api.github.com/users/MasayaAoyama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasayaAoyama/subscriptions","organizations_url":"https://api.github.com/users/MasayaAoyama/orgs","repos_url":"https://api.github.com/users/MasayaAoyama/repos","events_url":"https://api.github.com/users/MasayaAoyama/events{/privacy}","received_events_url":"https://api.github.com/users/MasayaAoyama/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484571291,"node_id":"MDU6TGFiZWw0ODQ1NzEyOTE=","url":"https://api.github.com/repos/kubernetes/website/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1078399207,"node_id":"MDU6TGFiZWwxMDc4Mzk5MjA3","url":"https://api.github.com/repos/kubernetes/website/labels/language/ja","name":"language/ja","color":"e9b3f9","default":false},{"id":764235355,"node_id":"MDU6TGFiZWw3NjQyMzUzNTU=","url":"https://api.github.com/repos/kubernetes/website/labels/sig/docs","name":"sig/docs","color":"d2b48c","default":false},{"id":679797614,"node_id":"MDU6TGFiZWw2Nzk3OTc2MTQ=","url":"https://api.github.com/repos/kubernetes/website/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/website/pulls/16034/commits","review_comments_url":"https://api.github.com/repos/kubernetes/website/pulls/16034/comments","review_comment_url":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/website/issues/16034/comments","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/ace68aa6bcd625f04bf7ef33523e019e6bfaf76e","head":{"label":"craftone:trans_japanese_20190820","ref":"trans_japanese_20190820","sha":"ace68aa6bcd625f04bf7ef33523e019e6bfaf76e","user":{"login":"craftone","id":3645127,"node_id":"MDQ6VXNlcjM2NDUxMjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3645127?v=4","gravatar_id":"","url":"https://api.github.com/users/craftone","html_url":"https://github.com/craftone","followers_url":"https://api.github.com/users/craftone/followers","following_url":"https://api.github.com/users/craftone/following{/other_user}","gists_url":"https://api.github.com/users/craftone/gists{/gist_id}","starred_url":"https://api.github.com/users/craftone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftone/subscriptions","organizations_url":"https://api.github.com/users/craftone/orgs","repos_url":"https://api.github.com/users/craftone/repos","events_url":"https://api.github.com/users/craftone/events{/privacy}","received_events_url":"https://api.github.com/users/craftone/received_events","type":"User","site_admin":false},"repo":{"id":203098926,"node_id":"MDEwOlJlcG9zaXRvcnkyMDMwOTg5MjY=","name":"website","full_name":"craftone/website","private":false,"owner":{"login":"craftone","id":3645127,"node_id":"MDQ6VXNlcjM2NDUxMjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3645127?v=4","gravatar_id":"","url":"https://api.github.com/users/craftone","html_url":"https://github.com/craftone","followers_url":"https://api.github.com/users/craftone/followers","following_url":"https://api.github.com/users/craftone/following{/other_user}","gists_url":"https://api.github.com/users/craftone/gists{/gist_id}","starred_url":"https://api.github.com/users/craftone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftone/subscriptions","organizations_url":"https://api.github.com/users/craftone/orgs","repos_url":"https://api.github.com/users/craftone/repos","events_url":"https://api.github.com/users/craftone/events{/privacy}","received_events_url":"https://api.github.com/users/craftone/received_events","type":"User","site_admin":false},"html_url":"https://github.com/craftone/website","description":"Kubernetes website and documentation repo: ","fork":true,"url":"https://api.github.com/repos/craftone/website","forks_url":"https://api.github.com/repos/craftone/website/forks","keys_url":"https://api.github.com/repos/craftone/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craftone/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craftone/website/teams","hooks_url":"https://api.github.com/repos/craftone/website/hooks","issue_events_url":"https://api.github.com/repos/craftone/website/issues/events{/number}","events_url":"https://api.github.com/repos/craftone/website/events","assignees_url":"https://api.github.com/repos/craftone/website/assignees{/user}","branches_url":"https://api.github.com/repos/craftone/website/branches{/branch}","tags_url":"https://api.github.com/repos/craftone/website/tags","blobs_url":"https://api.github.com/repos/craftone/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craftone/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craftone/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/craftone/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craftone/website/statuses/{sha}","languages_url":"https://api.github.com/repos/craftone/website/languages","stargazers_url":"https://api.github.com/repos/craftone/website/stargazers","contributors_url":"https://api.github.com/repos/craftone/website/contributors","subscribers_url":"https://api.github.com/repos/craftone/website/subscribers","subscription_url":"https://api.github.com/repos/craftone/website/subscription","commits_url":"https://api.github.com/repos/craftone/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/craftone/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/craftone/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/craftone/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/craftone/website/contents/{+path}","compare_url":"https://api.github.com/repos/craftone/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craftone/website/merges","archive_url":"https://api.github.com/repos/craftone/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craftone/website/downloads","issues_url":"https://api.github.com/repos/craftone/website/issues{/number}","pulls_url":"https://api.github.com/repos/craftone/website/pulls{/number}","milestones_url":"https://api.github.com/repos/craftone/website/milestones{/number}","notifications_url":"https://api.github.com/repos/craftone/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craftone/website/labels{/name}","releases_url":"https://api.github.com/repos/craftone/website/releases{/id}","deployments_url":"https://api.github.com/repos/craftone/website/deployments","created_at":"2019-08-19T04:35:44Z","updated_at":"2019-08-19T04:35:47Z","pushed_at":"2019-08-23T11:57:45Z","git_url":"git://github.com/craftone/website.git","ssh_url":"git@github.com:craftone/website.git","clone_url":"https://github.com/craftone/website.git","svn_url":"https://github.com/craftone/website","homepage":"https://kubernetes.io","size":225524,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f600acf2b649596f292293b738f80988f4471b3b","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQ3ODI2Ng==","name":"website","full_name":"kubernetes/website","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/website","description":"Kubernetes website and documentation repo: ","fork":false,"url":"https://api.github.com/repos/kubernetes/website","forks_url":"https://api.github.com/repos/kubernetes/website/forks","keys_url":"https://api.github.com/repos/kubernetes/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/website/teams","hooks_url":"https://api.github.com/repos/kubernetes/website/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/website/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/website/events","assignees_url":"https://api.github.com/repos/kubernetes/website/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/website/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/website/tags","blobs_url":"https://api.github.com/repos/kubernetes/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/website/languages","stargazers_url":"https://api.github.com/repos/kubernetes/website/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/website/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/website/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/website/subscription","commits_url":"https://api.github.com/repos/kubernetes/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/website/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/website/merges","archive_url":"https://api.github.com/repos/kubernetes/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/website/downloads","issues_url":"https://api.github.com/repos/kubernetes/website/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/website/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/website/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/website/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/website/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/website/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2019-08-23T13:13:27Z","pushed_at":"2019-08-23T13:13:19Z","git_url":"git://github.com/kubernetes/website.git","ssh_url":"git@github.com:kubernetes/website.git","clone_url":"https://github.com/kubernetes/website.git","svn_url":"https://github.com/kubernetes/website","homepage":"https://kubernetes.io","size":256110,"stargazers_count":1538,"watchers_count":1538,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5341,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":636,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":5341,"open_issues":636,"watchers":1538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16034"},"html":{"href":"https://github.com/kubernetes/website/pull/16034"},"issue":{"href":"https://api.github.com/repos/kubernetes/website/issues/16034"},"comments":{"href":"https://api.github.com/repos/kubernetes/website/issues/16034/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16034/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/website/pulls/16034/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/website/statuses/ace68aa6bcd625f04bf7ef33523e019e6bfaf76e"}},"author_association":"NONE"}}
|
{
"id": 51478266,
"name": "kubernetes/website",
"url": "https://api.github.com/repos/kubernetes/website"
}
|
{
"id": 11725486,
"login": "nasa9084",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11725486?",
"url": "https://api.github.com/users/nasa9084"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-08-23T15:47:53 |
10272266814
|
{"actor":{"display_login":"nasa9084"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/364877906","pull_request_review_id":340704105,"id":364877906,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDg3NzkwNg==","diff_hunk":"@@ -327,94 +328,91 @@ var _ = SIGDescribe(\"PreemptionExecutionPath\", func() {\n \t\t\tcache.ResourceEventHandlerFuncs{\n \t\t\t\tAddFunc: func(obj interface{}) {\n \t\t\t\t\tif pod, ok := obj.(*v1.Pod); ok {\n-\t\t\t\t\t\tpodNamesSeen[pod.Name] = struct{}{}\n+\t\t\t\t\t\tpodNamesSeen <- pod.Name\n \t\t\t\t\t}\n \t\t\t\t},\n \t\t\t},\n \t\t)\n \t\tgo podController.Run(stopCh)\n \t\tdefer close(stopCh)\n \n-\t\t// prepare four ReplicaSet\n+\t\t// prepare three ReplicaSet\n \t\trsConfs := []pauseRSConfig{\n \t\t\t{\n-\t\t\t\tReplicas: int32(5),\n+\t\t\t\tReplicas: int32(1),\n \t\t\t\tPodConfig: pausePodConfig{\n \t\t\t\t\tName: \"pod1\",\n \t\t\t\t\tNamespace: ns,\n \t\t\t\t\tLabels: map[string]string{\"name\": \"pod1\"},\n \t\t\t\t\tPriorityClassName: \"p1\",\n \t\t\t\t\tNodeSelector: map[string]string{\"kubernetes.io/hostname\": nodeHostNameLabel},\n \t\t\t\t\tResources: &v1.ResourceRequirements{\n-\t\t\t\t\t\tRequests: v1.ResourceList{fakecpu: resource.MustParse(\"40\")},\n-\t\t\t\t\t\tLimits: v1.ResourceList{fakecpu: resource.MustParse(\"40\")},\n+\t\t\t\t\t\tRequests: v1.ResourceList{fakecpu: resource.MustParse(\"200\")},\n+\t\t\t\t\t\tLimits: v1.ResourceList{fakecpu: resource.MustParse(\"200\")},\n \t\t\t\t\t},\n \t\t\t\t},\n \t\t\t},\n \t\t\t{\n-\t\t\t\tReplicas: int32(4),\n+\t\t\t\tReplicas: int32(1),\n \t\t\t\tPodConfig: pausePodConfig{\n \t\t\t\t\tName: \"pod2\",\n \t\t\t\t\tNamespace: ns,\n \t\t\t\t\tLabels: map[string]string{\"name\": \"pod2\"},\n \t\t\t\t\tPriorityClassName: \"p2\",\n \t\t\t\t\tNodeSelector: map[string]string{\"kubernetes.io/hostname\": nodeHostNameLabel},\n \t\t\t\t\tResources: &v1.ResourceRequirements{\n-\t\t\t\t\t\tRequests: v1.ResourceList{fakecpu: resource.MustParse(\"50\")},\n-\t\t\t\t\t\tLimits: v1.ResourceList{fakecpu: resource.MustParse(\"50\")},\n+\t\t\t\t\t\tRequests: v1.ResourceList{fakecpu: resource.MustParse(\"300\")},\n+\t\t\t\t\t\tLimits: v1.ResourceList{fakecpu: resource.MustParse(\"300\")},\n \t\t\t\t\t},\n \t\t\t\t},\n \t\t\t},\n \t\t\t{\n-\t\t\t\tReplicas: int32(4),\n+\t\t\t\tReplicas: int32(1),\n \t\t\t\tPodConfig: pausePodConfig{\n \t\t\t\t\tName: \"pod3\",\n \t\t\t\t\tNamespace: ns,\n \t\t\t\t\tLabels: map[string]string{\"name\": \"pod3\"},\n \t\t\t\t\tPriorityClassName: \"p3\",\n \t\t\t\t\tNodeSelector: map[string]string{\"kubernetes.io/hostname\": nodeHostNameLabel},\n \t\t\t\t\tResources: &v1.ResourceRequirements{\n-\t\t\t\t\t\tRequests: v1.ResourceList{fakecpu: resource.MustParse(\"95\")},\n-\t\t\t\t\t\tLimits: v1.ResourceList{fakecpu: resource.MustParse(\"95\")},\n-\t\t\t\t\t},\n-\t\t\t\t},\n-\t\t\t},\n-\t\t\t{\n-\t\t\t\tReplicas: int32(1),\n-\t\t\t\tPodConfig: pausePodConfig{\n-\t\t\t\t\tName: \"pod4\",\n-\t\t\t\t\tNamespace: ns,\n-\t\t\t\t\tLabels: map[string]string{\"name\": \"pod4\"},\n-\t\t\t\t\tPriorityClassName: \"p4\",\n-\t\t\t\t\tNodeSelector: map[string]string{\"kubernetes.io/hostname\": nodeHostNameLabel},\n-\t\t\t\t\tResources: &v1.ResourceRequirements{\n-\t\t\t\t\t\tRequests: v1.ResourceList{fakecpu: resource.MustParse(\"400\")},\n-\t\t\t\t\t\tLimits: v1.ResourceList{fakecpu: resource.MustParse(\"400\")},\n+\t\t\t\t\t\tRequests: v1.ResourceList{fakecpu: resource.MustParse(\"450\")},\n+\t\t\t\t\t\tLimits: v1.ResourceList{fakecpu: resource.MustParse(\"450\")},\n \t\t\t\t\t},\n \t\t\t\t},\n \t\t\t},\n \t\t}\n-\t\t// create ReplicaSet{1,2,3} so as to occupy 780/800 fake resource\n-\t\trsNum := len(rsConfs)\n-\t\tfor i := 0; i < rsNum-1; i++ {\n+\t\t// create ReplicaSet{1,2,3} so as to occupy 950/1000 fake resource\n+\t\tfor i := range rsConfs {\n \t\t\trunPauseRS(f, rsConfs[i])\n \t\t}\n \n \t\tframework.Logf(\"pods created so far: %v\", podNamesSeen)\n \t\tframework.Logf(\"length of pods created so far: %v\", len(podNamesSeen))\n \n-\t\t// create ReplicaSet4\n-\t\t// if runPauseRS failed, it means ReplicaSet4 cannot be scheduled even after 1 minute\n-\t\t// which is unacceptable\n-\t\trunPauseRS(f, rsConfs[rsNum-1])\n+\t\t// create a Preemptor Pod\n+\t\tpreemptorPodConf := pausePodConfig{\n+\t\t\tName: \"pod4\",\n+\t\t\tNamespace: ns,\n+\t\t\tLabels: map[string]string{\"name\": \"pod4\"},\n+\t\t\tPriorityClassName: \"p4\",\n+\t\t\tNodeSelector: map[string]string{\"kubernetes.io/hostname\": nodeHostNameLabel},\n+\t\t\tResources: &v1.ResourceRequirements{\n+\t\t\t\tRequests: v1.ResourceList{fakecpu: resource.MustParse(\"500\")},\n+\t\t\t\tLimits: v1.ResourceList{fakecpu: resource.MustParse(\"500\")},\n+\t\t\t},\n+\t\t}\n+\t\tpreemptorPod := createPod(f, preemptorPodConf)\n+\t\twaitForPreemptingWithTimeout(f, preemptorPod, framework.PodGetTimeout)\n \n \t\tframework.Logf(\"pods created so far: %v\", podNamesSeen)\n \t\tframework.Logf(\"length of pods created so far: %v\", len(podNamesSeen))\n \n+\t\ttime.Sleep(10 * time.Second)\n+\t\tclose(podNamesSeen)","path":"test/e2e/scheduling/preemption.go","position":144,"original_position":144,"commit_id":"2e40ef366155ba77409b347fa9cf801d2d94b97a","original_commit_id":"2e40ef366155ba77409b347fa9cf801d2d94b97a","user":{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"why close this? that creates a panic in the AddFunc","created_at":"2020-01-09T17:51:16Z","updated_at":"2020-01-09T17:51:16Z","html_url":"https://github.com/kubernetes/kubernetes/pull/86400#discussion_r364877906","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/86400","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/364877906"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/86400#discussion_r364877906"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/86400"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/86400","id":354897809,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0ODk3ODA5","html_url":"https://github.com/kubernetes/kubernetes/pull/86400","diff_url":"https://github.com/kubernetes/kubernetes/pull/86400.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/86400.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/86400","number":86400,"state":"open","locked":false,"title":"Fix a flaky scheduler preemption e2e","user":{"login":"Huang-Wei","id":1425903,"node_id":"MDQ6VXNlcjE0MjU5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1425903?v=4","gravatar_id":"","url":"https://api.github.com/users/Huang-Wei","html_url":"https://github.com/Huang-Wei","followers_url":"https://api.github.com/users/Huang-Wei/followers","following_url":"https://api.github.com/users/Huang-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Huang-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Huang-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huang-Wei/subscriptions","organizations_url":"https://api.github.com/users/Huang-Wei/orgs","repos_url":"https://api.github.com/users/Huang-Wei/repos","events_url":"https://api.github.com/users/Huang-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Huang-Wei/received_events","type":"User","site_admin":false},"body":"**What type of PR is this?**\r\n\r\n/kind flake\r\n/sig scheduling\r\n/cc @ahg-g @liggitt \r\n\r\n**What this PR does / why we need it**:\r\n\r\nIn the debugging PR (#86325), it turns out in the e2e cluster, sometimes the preemptor Pod can't finish the preemption logic within 1 minute. This PR optimize the logic of checking if the preemption behavior is happening from \"check if the Pod is running\" to \"if the NominatedNodeName field has been set or the Pod is running\". Moreover, the preemptor Pod doesn't need to be a ReplicaSet instead of a plain Pod, also the number of low priority Pods has been adjusted to the least necessity manner (it's because from the log, even plain RS Pods need ~45 secs to get them running, so reducing the RS replica number can help). Moreover, increase the timeout from 1 min to 2 mins.\r\n\r\n**Which issue(s) this PR fixes**:\r\n\r\nFixes #86068.\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n\r\n```release-note\r\nNONE\r\n```","created_at":"2019-12-19T01:26:23Z","updated_at":"2020-01-09T17:51:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16b47f74548a6a502b8df0850838acaaaa1c5daa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1285569325,"node_id":"MDU6TGFiZWwxMjg1NTY5MzI1","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/e2e-test-framework","name":"area/e2e-test-framework","color":"0052cc","default":false,"description":"Issues or PRs related to refactoring the kubernetes e2e test framework"},{"id":105152717,"node_id":"MDU6TGFiZWwxMDUxNTI3MTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/test","name":"area/test","color":"0052cc","default":false,"description":null},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false,"description":"Indicates the PR's author has signed the CNCF CLA."},{"id":687565804,"node_id":"MDU6TGFiZWw2ODc1NjU4MDQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false,"description":"Indicates that a PR should not merge because someone has issued a /hold command."},{"id":264749912,"node_id":"MDU6TGFiZWwyNjQ3NDk5MTI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/flake","name":"kind/flake","color":"f7c6c7","default":false,"description":"Categorizes issue or PR as related to a flaky test."},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false,"description":"Indicates a PR lacks a `priority/foo` label and requires one."},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false,"description":"Denotes a PR that doesn't merit a release note."},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false,"description":"Categorizes an issue or PR as relevant to sig-scheduling."},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false,"description":"Categorizes an issue or PR as relevant to sig-testing."},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false,"description":"Denotes a PR that changes 100-499 lines, ignoring generated files."}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/86400/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/86400/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/86400/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/2e40ef366155ba77409b347fa9cf801d2d94b97a","head":{"label":"Huang-Wei:fix-flaky-preemption-e2e","ref":"fix-flaky-preemption-e2e","sha":"2e40ef366155ba77409b347fa9cf801d2d94b97a","user":{"login":"Huang-Wei","id":1425903,"node_id":"MDQ6VXNlcjE0MjU5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1425903?v=4","gravatar_id":"","url":"https://api.github.com/users/Huang-Wei","html_url":"https://github.com/Huang-Wei","followers_url":"https://api.github.com/users/Huang-Wei/followers","following_url":"https://api.github.com/users/Huang-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Huang-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Huang-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huang-Wei/subscriptions","organizations_url":"https://api.github.com/users/Huang-Wei/orgs","repos_url":"https://api.github.com/users/Huang-Wei/repos","events_url":"https://api.github.com/users/Huang-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Huang-Wei/received_events","type":"User","site_admin":false},"repo":{"id":140890403,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4OTA0MDM=","name":"kubernetes","full_name":"Huang-Wei/kubernetes","private":false,"owner":{"login":"Huang-Wei","id":1425903,"node_id":"MDQ6VXNlcjE0MjU5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1425903?v=4","gravatar_id":"","url":"https://api.github.com/users/Huang-Wei","html_url":"https://github.com/Huang-Wei","followers_url":"https://api.github.com/users/Huang-Wei/followers","following_url":"https://api.github.com/users/Huang-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Huang-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Huang-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huang-Wei/subscriptions","organizations_url":"https://api.github.com/users/Huang-Wei/orgs","repos_url":"https://api.github.com/users/Huang-Wei/repos","events_url":"https://api.github.com/users/Huang-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Huang-Wei/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Huang-Wei/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/Huang-Wei/kubernetes","forks_url":"https://api.github.com/repos/Huang-Wei/kubernetes/forks","keys_url":"https://api.github.com/repos/Huang-Wei/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Huang-Wei/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Huang-Wei/kubernetes/teams","hooks_url":"https://api.github.com/repos/Huang-Wei/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Huang-Wei/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Huang-Wei/kubernetes/events","assignees_url":"https://api.github.com/repos/Huang-Wei/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Huang-Wei/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Huang-Wei/kubernetes/tags","blobs_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Huang-Wei/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Huang-Wei/kubernetes/languages","stargazers_url":"https://api.github.com/repos/Huang-Wei/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Huang-Wei/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Huang-Wei/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Huang-Wei/kubernetes/subscription","commits_url":"https://api.github.com/repos/Huang-Wei/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Huang-Wei/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Huang-Wei/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Huang-Wei/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Huang-Wei/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Huang-Wei/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Huang-Wei/kubernetes/merges","archive_url":"https://api.github.com/repos/Huang-Wei/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Huang-Wei/kubernetes/downloads","issues_url":"https://api.github.com/repos/Huang-Wei/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Huang-Wei/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Huang-Wei/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Huang-Wei/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Huang-Wei/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Huang-Wei/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Huang-Wei/kubernetes/deployments","created_at":"2018-07-13T20:30:19Z","updated_at":"2020-01-09T06:10:54Z","pushed_at":"2020-01-09T17:42:07Z","git_url":"git://github.com/Huang-Wei/kubernetes.git","ssh_url":"git@github.com:Huang-Wei/kubernetes.git","clone_url":"https://github.com/Huang-Wei/kubernetes.git","svn_url":"https://github.com/Huang-Wei/kubernetes","homepage":"http://kubernetes.io","size":668384,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b9c0aa0b2aca87baaa5a8ab99578e39c162501d3","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2020-01-09T17:18:59Z","pushed_at":"2020-01-09T17:49:57Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":890332,"stargazers_count":62168,"watchers_count":62168,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21944,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3193,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21944,"open_issues":3193,"watchers":62168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/86400"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/86400"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/86400"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/86400/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/86400/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/86400/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/2e40ef366155ba77409b347fa9cf801d2d94b97a"}},"author_association":"MEMBER"}}
|
{
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
}
|
{
"id": 980082,
"login": "liggitt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/980082?",
"url": "https://api.github.com/users/liggitt"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2020-01-09T17:51:16 |
11240169703
|
{"actor":{"display_login":"liggitt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/293786895","pull_request_review_id":249874453,"id":293786895,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5Mzc4Njg5NQ==","diff_hunk":"@@ -167,38 +167,9 @@ filename | sha512 hash\n \n ### Action Required\n \n-* ACTION REQUIRED The deprecated flag --conntrack-max has been removed from kube-proxy. Users of this flag should switch to --conntrack-min and --conntrack-max-per-core instead. ([#78399](https://github.com/kubernetes/kubernetes/pull/78399), [@rikatz](https://github.com/rikatz))\n+* ACTION REQUIRED: The deprecated flag --conntrack-max has been removed from kube-proxy. Users of this flag should switch to --conntrack-min and --conntrack-max-per-core instead. ([#78399](https://github.com/kubernetes/kubernetes/pull/78399), [@rikatz](https://github.com/rikatz))\n * ACTION REQUIRED: kubeadm: the mixture of \"--config\" and \"--certificate-key\" is no longer allowed. The InitConfiguration and JoinConfiguration objects now support the \"certificateKey\" field and this field should be used instead of the command line argument in case a configuration file is already passed. ([#78542](https://github.com/kubernetes/kubernetes/pull/78542), [@neolit123](https://github.com/neolit123))\n-* Azure cloud provider could now be configured by Kubernetes secrets and a new option `cloudConfigType` is introduced, whose candicate values are `file`, `secret` and `merge` (default is `merge`). ([#78242](https://github.com/kubernetes/kubernetes/pull/78242), [@feiskyer](https://github.com/feiskyer))\n- * action required:\n- * Since Azure cloud provider would read Kubernetes secrets, the following RBAC should be configured:\n- * ---\n- * apiVersion: rbac.authorization.k8s.io/v1beta1\n- * kind: ClusterRole\n- * metadata:\n- * labels:\n- * kubernetes.io/cluster-service: \"true\"\n- * name: system:azure-cloud-provider-secret-getter\n- * rules:\n- * - apiGroups: [\"\"]\n- * resources: [\"secrets\"]\n- * verbs:\n- * - get\n- * ---\n- * apiVersion: rbac.authorization.k8s.io/v1beta1\n- * kind: ClusterRoleBinding\n- * metadata:\n- * labels:\n- * kubernetes.io/cluster-service: \"true\"\n- * name: system:azure-cloud-provider-secret-getter\n- * roleRef:\n- * apiGroup: rbac.authorization.k8s.io\n- * kind: ClusterRole\n- * name: system:azure-cloud-provider-secret-getter\n- * subjects:\n- * - kind: ServiceAccount\n- * name: azure-cloud-provider\n- * namespace: kube-system\n+* ACTION REQUIRED: Azure cloud provider could now be configured by Kubernetes secrets and a new option `cloudConfigType` is introduced, whose candicate values are `file`, `secret` and `merge` (default is `merge`). Note that the secret is a serialized version of azure.json file with key cloud-config. And the secret name is azure-cloud-provider in kube-system namespace. ([#78242](https://github.com/kubernetes/kubernetes/pull/78242), [@feiskyer](https://github.com/feiskyer))","path":"CHANGELOG-1.15.md","position":37,"original_position":37,"commit_id":"acbfe58776865c2e6a132a17eea78a66c23ce1e7","original_commit_id":"acbfe58776865c2e6a132a17eea78a66c23ce1e7","user":{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"does this need to call out that permission to read the secret must be granted to the cloud `azure-cloud-provider` service account in the `kube-system` namespace?","created_at":"2019-06-14T12:30:58Z","updated_at":"2019-06-14T12:30:58Z","html_url":"https://github.com/kubernetes/kubernetes/pull/78932#discussion_r293786895","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78932","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/293786895"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/78932#discussion_r293786895"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78932"}},"in_reply_to_id":293786583},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78932","id":287400337,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3NDAwMzM3","html_url":"https://github.com/kubernetes/kubernetes/pull/78932","diff_url":"https://github.com/kubernetes/kubernetes/pull/78932.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/78932.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/78932","number":78932,"state":"open","locked":false,"title":"Fix CHANGELOG-1.15.md bad format","user":{"login":"cwdsuzhou","id":12230714,"node_id":"MDQ6VXNlcjEyMjMwNzE0","avatar_url":"https://avatars1.githubusercontent.com/u/12230714?v=4","gravatar_id":"","url":"https://api.github.com/users/cwdsuzhou","html_url":"https://github.com/cwdsuzhou","followers_url":"https://api.github.com/users/cwdsuzhou/followers","following_url":"https://api.github.com/users/cwdsuzhou/following{/other_user}","gists_url":"https://api.github.com/users/cwdsuzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/cwdsuzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwdsuzhou/subscriptions","organizations_url":"https://api.github.com/users/cwdsuzhou/orgs","repos_url":"https://api.github.com/users/cwdsuzhou/repos","events_url":"https://api.github.com/users/cwdsuzhou/events{/privacy}","received_events_url":"https://api.github.com/users/cwdsuzhou/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for sending a pull request! Here are some tips for you:\r\n\r\n1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n\r\n/kind documentation\r\n\r\n\r\n**What this PR does / why we need it**:\r\nCHANGELOG-1.15 has bad format like this. \r\n\r\n\r\n\r\n\r\n**Which issue(s) this PR fixes**:\r\n<!--\r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n-->\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--\r\nIf no, just write \"NONE\" in the release-note block below.\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2019-06-12T08:34:07Z","updated_at":"2019-06-14T12:30:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50047867ec2a6fcee962d57a90c3318804fe5dfd","assignee":{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"assignees":[{"login":"feiskyer","id":676637,"node_id":"MDQ6VXNlcjY3NjYzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"smarterclayton","id":1163175,"node_id":"MDQ6VXNlcjExNjMxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},{"login":"brendandburns","id":5751682,"node_id":"MDQ6VXNlcjU3NTE2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":116801185,"node_id":"MDU6TGFiZWwxMTY4MDExODU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/documentation","name":"kind/documentation","color":"c7def8","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":614023989,"node_id":"MDU6TGFiZWw2MTQwMjM5ODk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/release","name":"sig/release","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78932/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78932/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/78932/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/acbfe58776865c2e6a132a17eea78a66c23ce1e7","head":{"label":"cwdsuzhou:changelog_badformat","ref":"changelog_badformat","sha":"acbfe58776865c2e6a132a17eea78a66c23ce1e7","user":{"login":"cwdsuzhou","id":12230714,"node_id":"MDQ6VXNlcjEyMjMwNzE0","avatar_url":"https://avatars1.githubusercontent.com/u/12230714?v=4","gravatar_id":"","url":"https://api.github.com/users/cwdsuzhou","html_url":"https://github.com/cwdsuzhou","followers_url":"https://api.github.com/users/cwdsuzhou/followers","following_url":"https://api.github.com/users/cwdsuzhou/following{/other_user}","gists_url":"https://api.github.com/users/cwdsuzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/cwdsuzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwdsuzhou/subscriptions","organizations_url":"https://api.github.com/users/cwdsuzhou/orgs","repos_url":"https://api.github.com/users/cwdsuzhou/repos","events_url":"https://api.github.com/users/cwdsuzhou/events{/privacy}","received_events_url":"https://api.github.com/users/cwdsuzhou/received_events","type":"User","site_admin":false},"repo":{"id":158495445,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg0OTU0NDU=","name":"kubernetes","full_name":"cwdsuzhou/kubernetes","private":false,"owner":{"login":"cwdsuzhou","id":12230714,"node_id":"MDQ6VXNlcjEyMjMwNzE0","avatar_url":"https://avatars1.githubusercontent.com/u/12230714?v=4","gravatar_id":"","url":"https://api.github.com/users/cwdsuzhou","html_url":"https://github.com/cwdsuzhou","followers_url":"https://api.github.com/users/cwdsuzhou/followers","following_url":"https://api.github.com/users/cwdsuzhou/following{/other_user}","gists_url":"https://api.github.com/users/cwdsuzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/cwdsuzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwdsuzhou/subscriptions","organizations_url":"https://api.github.com/users/cwdsuzhou/orgs","repos_url":"https://api.github.com/users/cwdsuzhou/repos","events_url":"https://api.github.com/users/cwdsuzhou/events{/privacy}","received_events_url":"https://api.github.com/users/cwdsuzhou/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cwdsuzhou/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/cwdsuzhou/kubernetes","forks_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/forks","keys_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/teams","hooks_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/events","assignees_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/tags","blobs_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/languages","stargazers_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/subscription","commits_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/merges","archive_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/downloads","issues_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/cwdsuzhou/kubernetes/deployments","created_at":"2018-11-21T05:27:17Z","updated_at":"2019-06-03T13:24:16Z","pushed_at":"2019-06-14T07:28:43Z","git_url":"git://github.com/cwdsuzhou/kubernetes.git","ssh_url":"git@github.com:cwdsuzhou/kubernetes.git","clone_url":"https://github.com/cwdsuzhou/kubernetes.git","svn_url":"https://github.com/cwdsuzhou/kubernetes","homepage":"https://kubernetes.io","size":651300,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4f29960cb2058c4f556bf1e5ba49c9a29a501e70","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2019-06-14T12:00:01Z","pushed_at":"2019-06-14T12:23:31Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":871817,"stargazers_count":53985,"watchers_count":53985,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18700,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3227,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18700,"open_issues":3227,"watchers":53985,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78932"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/78932"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/78932"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/78932/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78932/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78932/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/acbfe58776865c2e6a132a17eea78a66c23ce1e7"}},"author_association":"MEMBER"}}
|
{
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
}
|
{
"id": 980082,
"login": "liggitt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/980082?",
"url": "https://api.github.com/users/liggitt"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-06-14T12:30:58 |
9823447627
|
{"actor":{"display_login":"liggitt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/358970909","pull_request_review_id":333506471,"id":358970909,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODk3MDkwOQ==","diff_hunk":"@@ -10,6 +10,8 @@ postsubmits:\n branches:\n - ^master$\n - ^release-0.2$\n+ # this is a regex for semver, from https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string\n+ - ^v(0|[1-9]\\d*)\\.(0|[1-9]\\d*)\\.(0|[1-9]\\d*)(?:-((?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\\.(?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\\+([0-9a-zA-Z-]+(?:\\.[0-9a-zA-Z-]+)*))?$","path":"config/jobs/image-pushing/k8s-staging-cluster-api.yaml","position":5,"original_position":5,"commit_id":"59e95a0e8546c29206bc4b1d06f486d535f94e82","original_commit_id":"59e95a0e8546c29206bc4b1d06f486d535f94e82","user":{"login":"vincepri","id":3118335,"node_id":"MDQ6VXNlcjMxMTgzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3118335?v=4","gravatar_id":"","url":"https://api.github.com/users/vincepri","html_url":"https://github.com/vincepri","followers_url":"https://api.github.com/users/vincepri/followers","following_url":"https://api.github.com/users/vincepri/following{/other_user}","gists_url":"https://api.github.com/users/vincepri/gists{/gist_id}","starred_url":"https://api.github.com/users/vincepri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincepri/subscriptions","organizations_url":"https://api.github.com/users/vincepri/orgs","repos_url":"https://api.github.com/users/vincepri/repos","events_url":"https://api.github.com/users/vincepri/events{/privacy}","received_events_url":"https://api.github.com/users/vincepri/received_events","type":"User","site_admin":false},"body":"Thanks for the clarification @Katharine !","created_at":"2019-12-17T18:59:58Z","updated_at":"2019-12-17T18:59:59Z","html_url":"https://github.com/kubernetes/test-infra/pull/15624#discussion_r358970909","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/15624","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/358970909"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/15624#discussion_r358970909"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/15624"}},"in_reply_to_id":358966530},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/15624","id":354139584,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0MTM5NTg0","html_url":"https://github.com/kubernetes/test-infra/pull/15624","diff_url":"https://github.com/kubernetes/test-infra/pull/15624.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/15624.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/15624","number":15624,"state":"open","locked":false,"title":"capi/capa/cabpk/capg: build images for semver tags","user":{"login":"ncdc","id":354,"node_id":"MDQ6VXNlcjM1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"Use the regular express for semver from\r\nhttps://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string\r\nto match refs for git tags for cluster-api, cluster-api-provider-aws,\r\nand cluster-api-bootstrap-provider-kubeadm. This eliminates one of the\r\nmanual steps in the release process for these projects.\r\n\r\nIf you want me to do this for cluster-api-provider-gcp too, let me know.\r\n\r\nI also noticed that cluster-api-provider-openstack is in a different yaml file. I didn't touch that either.\r\n\r\n/cc @detiber @vincepri ","created_at":"2019-12-17T14:37:27Z","updated_at":"2019-12-17T18:59:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6126cf1882b8c241206c56bfaedd566af93312d","assignee":{"login":"Katharine","id":110792,"node_id":"MDQ6VXNlcjExMDc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/110792?v=4","gravatar_id":"","url":"https://api.github.com/users/Katharine","html_url":"https://github.com/Katharine","followers_url":"https://api.github.com/users/Katharine/followers","following_url":"https://api.github.com/users/Katharine/following{/other_user}","gists_url":"https://api.github.com/users/Katharine/gists{/gist_id}","starred_url":"https://api.github.com/users/Katharine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katharine/subscriptions","organizations_url":"https://api.github.com/users/Katharine/orgs","repos_url":"https://api.github.com/users/Katharine/repos","events_url":"https://api.github.com/users/Katharine/events{/privacy}","received_events_url":"https://api.github.com/users/Katharine/received_events","type":"User","site_admin":false},"assignees":[{"login":"Katharine","id":110792,"node_id":"MDQ6VXNlcjExMDc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/110792?v=4","gravatar_id":"","url":"https://api.github.com/users/Katharine","html_url":"https://github.com/Katharine","followers_url":"https://api.github.com/users/Katharine/followers","following_url":"https://api.github.com/users/Katharine/following{/other_user}","gists_url":"https://api.github.com/users/Katharine/gists{/gist_id}","starred_url":"https://api.github.com/users/Katharine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katharine/subscriptions","organizations_url":"https://api.github.com/users/Katharine/orgs","repos_url":"https://api.github.com/users/Katharine/repos","events_url":"https://api.github.com/users/Katharine/events{/privacy}","received_events_url":"https://api.github.com/users/Katharine/received_events","type":"User","site_admin":false},{"login":"detiber","id":915544,"node_id":"MDQ6VXNlcjkxNTU0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/915544?v=4","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},{"login":"cjwagner","id":5334145,"node_id":"MDQ6VXNlcjUzMzQxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5334145?v=4","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"detiber","id":915544,"node_id":"MDQ6VXNlcjkxNTU0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/915544?v=4","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},{"login":"vincepri","id":3118335,"node_id":"MDQ6VXNlcjMxMTgzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3118335?v=4","gravatar_id":"","url":"https://api.github.com/users/vincepri","html_url":"https://github.com/vincepri","followers_url":"https://api.github.com/users/vincepri/followers","following_url":"https://api.github.com/users/vincepri/following{/other_user}","gists_url":"https://api.github.com/users/vincepri/gists{/gist_id}","starred_url":"https://api.github.com/users/vincepri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincepri/subscriptions","organizations_url":"https://api.github.com/users/vincepri/orgs","repos_url":"https://api.github.com/users/vincepri/repos","events_url":"https://api.github.com/users/vincepri/events{/privacy}","received_events_url":"https://api.github.com/users/vincepri/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":705940018,"node_id":"MDU6TGFiZWw3MDU5NDAwMTg=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/approved","name":"approved","color":"0ffa16","default":false,"description":"Indicates a PR has been approved by an approver from all required OWNERS files."},{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false,"description":"Indicates the PR's author has signed the CNCF CLA."},{"id":682002555,"node_id":"MDU6TGFiZWw2ODIwMDI1NTU=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false,"description":"Indicates that a PR should not merge because someone has issued a /hold command."},{"id":366393439,"node_id":"MDU6TGFiZWwzNjYzOTM0Mzk=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/lgtm","name":"lgtm","color":"15dd18","default":false,"description":"Indicates that a PR is ready to be merged."},{"id":671133328,"node_id":"MDU6TGFiZWw2NzExMzMzMjg=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/XS","name":"size/XS","color":"009900","default":false,"description":"Denotes a PR that changes 0-9 lines, ignoring generated files."}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/15624/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/15624/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/15624/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/59e95a0e8546c29206bc4b1d06f486d535f94e82","head":{"label":"ncdc:capi-capa-cabpk-build-tag-images","ref":"capi-capa-cabpk-build-tag-images","sha":"59e95a0e8546c29206bc4b1d06f486d535f94e82","user":{"login":"ncdc","id":354,"node_id":"MDQ6VXNlcjM1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"repo":{"id":82085648,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA4NTY0OA==","name":"test-infra","full_name":"ncdc/test-infra","private":false,"owner":{"login":"ncdc","id":354,"node_id":"MDQ6VXNlcjM1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ncdc/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/ncdc/test-infra","forks_url":"https://api.github.com/repos/ncdc/test-infra/forks","keys_url":"https://api.github.com/repos/ncdc/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncdc/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncdc/test-infra/teams","hooks_url":"https://api.github.com/repos/ncdc/test-infra/hooks","issue_events_url":"https://api.github.com/repos/ncdc/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/ncdc/test-infra/events","assignees_url":"https://api.github.com/repos/ncdc/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/ncdc/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/ncdc/test-infra/tags","blobs_url":"https://api.github.com/repos/ncdc/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncdc/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncdc/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncdc/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncdc/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/ncdc/test-infra/languages","stargazers_url":"https://api.github.com/repos/ncdc/test-infra/stargazers","contributors_url":"https://api.github.com/repos/ncdc/test-infra/contributors","subscribers_url":"https://api.github.com/repos/ncdc/test-infra/subscribers","subscription_url":"https://api.github.com/repos/ncdc/test-infra/subscription","commits_url":"https://api.github.com/repos/ncdc/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncdc/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncdc/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncdc/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncdc/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/ncdc/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncdc/test-infra/merges","archive_url":"https://api.github.com/repos/ncdc/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncdc/test-infra/downloads","issues_url":"https://api.github.com/repos/ncdc/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/ncdc/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/ncdc/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/ncdc/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncdc/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/ncdc/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/ncdc/test-infra/deployments","created_at":"2017-02-15T17:12:15Z","updated_at":"2017-02-15T17:12:18Z","pushed_at":"2019-12-17T14:49:48Z","git_url":"git://github.com/ncdc/test-infra.git","ssh_url":"git@github.com:ncdc/test-infra.git","clone_url":"https://github.com/ncdc/test-infra.git","svn_url":"https://github.com/ncdc/test-infra","homepage":null,"size":107909,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2125a004bd89e422dcb639feb3d4d54907a6a3c4","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"node_id":"MDEwOlJlcG9zaXRvcnk1NzMzMzcwOQ==","name":"test-infra","full_name":"kubernetes/test-infra","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2019-12-17T18:34:14Z","pushed_at":"2019-12-17T18:51:25Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":108748,"stargazers_count":1767,"watchers_count":1767,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1199,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":408,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1199,"open_issues":408,"watchers":1767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/15624"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/15624"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/15624"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/15624/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/15624/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/15624/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/59e95a0e8546c29206bc4b1d06f486d535f94e82"}},"author_association":"MEMBER"}}
|
{
"id": 57333709,
"name": "kubernetes/test-infra",
"url": "https://api.github.com/repos/kubernetes/test-infra"
}
|
{
"id": 3118335,
"login": "vincepri",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3118335?",
"url": "https://api.github.com/users/vincepri"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-12-17T18:59:58 |
11110070893
|
{"actor":{"display_login":"vincepri"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/328118892","pull_request_review_id":293072083,"id":328118892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODExODg5Mg==","diff_hunk":"@@ -0,0 +1,55 @@\n+/*\n+Copyright 2019 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package waitgroup\n+\n+import (\n+\t\"sync\"\n+)\n+\n+// OptionalWaitGroup is a WaitGroup or nothing. Use it to track when\n+// goroutines start or stop or begin or end waiting if the pointer is\n+// not nil. This abstraction is intended to make it easier to write a\n+// package that can be unit tested by a function that advances a fake\n+// clock once all the available work is done. Real clients set the\n+// pointer to nil because they do not need this tracking.","path":"staging/src/k8s.io/apimachinery/pkg/util/waitgroup/optionalwaitgroup.go","position":28,"original_position":28,"commit_id":"a56e4b2ff6edab847dc363b7d94bbcf9ec759fa5","original_commit_id":"a56e4b2ff6edab847dc363b7d94bbcf9ec759fa5","user":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"> OptionalWaitGroup is not just for test. It is used in the mainline code. It's whole purpose is to streamline handling of a maybe-nil pointer to a WaitGroup.\r\n\r\nI'm still working my way down, but it's pretty unusual to only sometimes need a waitgroup. @lavalamp calling this out to see if you're comfortable with usage.","created_at":"2019-09-25T13:23:41Z","updated_at":"2019-09-25T13:23:41Z","html_url":"https://github.com/kubernetes/kubernetes/pull/81834#discussion_r328118892","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/81834","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/328118892"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/81834#discussion_r328118892"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/81834"}},"in_reply_to_id":327817444},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/81834","id":310372256,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwMzcyMjU2","html_url":"https://github.com/kubernetes/kubernetes/pull/81834","diff_url":"https://github.com/kubernetes/kubernetes/pull/81834.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/81834.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/81834","number":81834,"state":"open","locked":false,"title":"Rebase and merging feature-rate-limiting into master","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"body":"/sig api-machinery\r\n/kind feature","created_at":"2019-08-23T12:46:58Z","updated_at":"2019-09-25T13:23:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adff2da2816a1aa179252a706fc6b753d081f561","assignee":{"login":"aaron-prindle","id":1951658,"node_id":"MDQ6VXNlcjE5NTE2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1951658?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},{"login":"adohe","id":1555564,"node_id":"MDQ6VXNlcjE1NTU1NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1555564?v=4","gravatar_id":"","url":"https://api.github.com/users/adohe","html_url":"https://github.com/adohe","followers_url":"https://api.github.com/users/adohe/followers","following_url":"https://api.github.com/users/adohe/following{/other_user}","gists_url":"https://api.github.com/users/adohe/gists{/gist_id}","starred_url":"https://api.github.com/users/adohe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adohe/subscriptions","organizations_url":"https://api.github.com/users/adohe/orgs","repos_url":"https://api.github.com/users/adohe/repos","events_url":"https://api.github.com/users/adohe/events{/privacy}","received_events_url":"https://api.github.com/users/adohe/received_events","type":"User","site_admin":false},{"login":"aaron-prindle","id":1951658,"node_id":"MDQ6VXNlcjE5NTE2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1951658?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},{"login":"MikeSpreitzer","id":14296719,"node_id":"MDQ6VXNlcjE0Mjk2NzE5","avatar_url":"https://avatars2.githubusercontent.com/u/14296719?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeSpreitzer","html_url":"https://github.com/MikeSpreitzer","followers_url":"https://api.github.com/users/MikeSpreitzer/followers","following_url":"https://api.github.com/users/MikeSpreitzer/following{/other_user}","gists_url":"https://api.github.com/users/MikeSpreitzer/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeSpreitzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeSpreitzer/subscriptions","organizations_url":"https://api.github.com/users/MikeSpreitzer/orgs","repos_url":"https://api.github.com/users/MikeSpreitzer/repos","events_url":"https://api.github.com/users/MikeSpreitzer/events{/privacy}","received_events_url":"https://api.github.com/users/MikeSpreitzer/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cblecker","id":1431969,"node_id":"MDQ6VXNlcjE0MzE5Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1431969?v=4","gravatar_id":"","url":"https://api.github.com/users/cblecker","html_url":"https://github.com/cblecker","followers_url":"https://api.github.com/users/cblecker/followers","following_url":"https://api.github.com/users/cblecker/following{/other_user}","gists_url":"https://api.github.com/users/cblecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cblecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblecker/subscriptions","organizations_url":"https://api.github.com/users/cblecker/orgs","repos_url":"https://api.github.com/users/cblecker/repos","events_url":"https://api.github.com/users/cblecker/events{/privacy}","received_events_url":"https://api.github.com/users/cblecker/received_events","type":"User","site_admin":false},{"login":"CaoShuFeng","id":20855209,"node_id":"MDQ6VXNlcjIwODU1MjA5","avatar_url":"https://avatars0.githubusercontent.com/u/20855209?v=4","gravatar_id":"","url":"https://api.github.com/users/CaoShuFeng","html_url":"https://github.com/CaoShuFeng","followers_url":"https://api.github.com/users/CaoShuFeng/followers","following_url":"https://api.github.com/users/CaoShuFeng/following{/other_user}","gists_url":"https://api.github.com/users/CaoShuFeng/gists{/gist_id}","starred_url":"https://api.github.com/users/CaoShuFeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaoShuFeng/subscriptions","organizations_url":"https://api.github.com/users/CaoShuFeng/orgs","repos_url":"https://api.github.com/users/CaoShuFeng/repos","events_url":"https://api.github.com/users/CaoShuFeng/events{/privacy}","received_events_url":"https://api.github.com/users/CaoShuFeng/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":136601536,"node_id":"MDU6TGFiZWwxMzY2MDE1MzY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/apiserver","name":"area/apiserver","color":"0052cc","default":false},{"id":105152717,"node_id":"MDU6TGFiZWwxMDUxNTI3MTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/test","name":"area/test","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680152113,"node_id":"MDU6TGFiZWw2ODAxNTIxMTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":261005360,"node_id":"MDU6TGFiZWwyNjEwMDUzNjA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"e11d21","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/81834/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/81834/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/81834/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a56e4b2ff6edab847dc363b7d94bbcf9ec759fa5","head":{"label":"yue9944882:feature/rate-limiting-rebased","ref":"feature/rate-limiting-rebased","sha":"a56e4b2ff6edab847dc363b7d94bbcf9ec759fa5","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"repo":{"id":112361176,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzNjExNzY=","name":"kubernetes","full_name":"yue9944882/kubernetes","private":false,"owner":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yue9944882/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/yue9944882/kubernetes","forks_url":"https://api.github.com/repos/yue9944882/kubernetes/forks","keys_url":"https://api.github.com/repos/yue9944882/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yue9944882/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yue9944882/kubernetes/teams","hooks_url":"https://api.github.com/repos/yue9944882/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/yue9944882/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/yue9944882/kubernetes/events","assignees_url":"https://api.github.com/repos/yue9944882/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/yue9944882/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/yue9944882/kubernetes/tags","blobs_url":"https://api.github.com/repos/yue9944882/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yue9944882/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yue9944882/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/yue9944882/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yue9944882/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/yue9944882/kubernetes/languages","stargazers_url":"https://api.github.com/repos/yue9944882/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/yue9944882/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/yue9944882/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/yue9944882/kubernetes/subscription","commits_url":"https://api.github.com/repos/yue9944882/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/yue9944882/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/yue9944882/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/yue9944882/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/yue9944882/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/yue9944882/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yue9944882/kubernetes/merges","archive_url":"https://api.github.com/repos/yue9944882/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yue9944882/kubernetes/downloads","issues_url":"https://api.github.com/repos/yue9944882/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/yue9944882/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/yue9944882/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/yue9944882/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yue9944882/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/yue9944882/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/yue9944882/kubernetes/deployments","created_at":"2017-11-28T16:35:51Z","updated_at":"2019-08-30T05:33:26Z","pushed_at":"2019-09-24T08:36:52Z","git_url":"git://github.com/yue9944882/kubernetes.git","ssh_url":"git@github.com:yue9944882/kubernetes.git","clone_url":"https://github.com/yue9944882/kubernetes.git","svn_url":"https://github.com/yue9944882/kubernetes","homepage":"http://kubernetes.io","size":673608,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4e63af2324b8562ac41f46a2e82b1b8a4224c048","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2019-09-25T13:08:06Z","pushed_at":"2019-09-25T13:21:02Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":902785,"stargazers_count":58154,"watchers_count":58154,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20353,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3333,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20353,"open_issues":3333,"watchers":58154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/81834"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/81834"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/81834"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/81834/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/81834/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/81834/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a56e4b2ff6edab847dc363b7d94bbcf9ec759fa5"}},"author_association":"MEMBER"}}
|
{
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
}
|
{
"id": 8225098,
"login": "deads2k",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8225098?",
"url": "https://api.github.com/users/deads2k"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-09-25T13:23:41 |
10492493171
|
{"actor":{"display_login":"deads2k"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/325940339","pull_request_review_id":290261706,"id":325940339,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNTk0MDMzOQ==","diff_hunk":"@@ -348,6 +348,43 @@ periodics:\n cpu: \"4\"\n securityContext:\n privileged: true\n+- annotations:\n+ fork-per-release-generic-suffix: \"true\"\n+ testgrid-dashboards: google-windows, sig-release-1.16-informing, sig-windows\n+ testgrid-tab-name: gce-windows-beta\n+ description: Runs tests on a Kubernetes 1.16 cluster with Windows nodes on GCE\n+ decorate: true\n+ extra_refs:\n+ - org: yujuhong","path":"config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml","position":11,"original_position":11,"commit_id":"dcc1a5bc907498408276b1d381dbe849810f5f6d","original_commit_id":"dcc1a5bc907498408276b1d381dbe849810f5f6d","user":{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"body":"Yep. We should move it somewhere else. I think we discussed this briefly with @PatrickLang a long time ago, but it was decided that the vendor-specific configs should not be hosted in the windows-testing repo. Maybe we can re-visit that decision?","created_at":"2019-09-18T23:53:42Z","updated_at":"2019-09-18T23:53:42Z","html_url":"https://github.com/kubernetes/test-infra/pull/14329#discussion_r325940339","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/14329","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/325940339"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/14329#discussion_r325940339"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/14329"}},"in_reply_to_id":325936807},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/14329","id":317503691,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NTAzNjkx","html_url":"https://github.com/kubernetes/test-infra/pull/14329","diff_url":"https://github.com/kubernetes/test-infra/pull/14329.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/14329.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/14329","number":14329,"state":"open","locked":false,"title":"Automate windows jobs landing on SIG Release informing board","user":{"login":"YangLu1031","id":10737270,"node_id":"MDQ6VXNlcjEwNzM3Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/10737270?v=4","gravatar_id":"","url":"https://api.github.com/users/YangLu1031","html_url":"https://github.com/YangLu1031","followers_url":"https://api.github.com/users/YangLu1031/followers","following_url":"https://api.github.com/users/YangLu1031/following{/other_user}","gists_url":"https://api.github.com/users/YangLu1031/gists{/gist_id}","starred_url":"https://api.github.com/users/YangLu1031/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YangLu1031/subscriptions","organizations_url":"https://api.github.com/users/YangLu1031/orgs","repos_url":"https://api.github.com/users/YangLu1031/repos","events_url":"https://api.github.com/users/YangLu1031/events{/privacy}","received_events_url":"https://api.github.com/users/YangLu1031/received_events","type":"User","site_admin":false},"body":"1. Thanks @justaugustus, as he suggested in [comment](https://github.com/kubernetes/test-infra/pull/14278#pullrequestreview-287176185) and referred this [doc](https://github.com/kubernetes/test-infra/tree/master/experiment/config-forker) to config job forker on release\r\n2. Added OWNERS file following this [guide](https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md) ","created_at":"2019-09-13T22:38:45Z","updated_at":"2019-09-18T23:53:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4439e887f0ada934bb5369ca24e84d7f9ec7d63f","assignee":{"login":"justaugustus","id":567897,"node_id":"MDQ6VXNlcjU2Nzg5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/567897?v=4","gravatar_id":"","url":"https://api.github.com/users/justaugustus","html_url":"https://github.com/justaugustus","followers_url":"https://api.github.com/users/justaugustus/followers","following_url":"https://api.github.com/users/justaugustus/following{/other_user}","gists_url":"https://api.github.com/users/justaugustus/gists{/gist_id}","starred_url":"https://api.github.com/users/justaugustus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justaugustus/subscriptions","organizations_url":"https://api.github.com/users/justaugustus/orgs","repos_url":"https://api.github.com/users/justaugustus/repos","events_url":"https://api.github.com/users/justaugustus/events{/privacy}","received_events_url":"https://api.github.com/users/justaugustus/received_events","type":"User","site_admin":false},"assignees":[{"login":"benmoss","id":239754,"node_id":"MDQ6VXNlcjIzOTc1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/239754?v=4","gravatar_id":"","url":"https://api.github.com/users/benmoss","html_url":"https://github.com/benmoss","followers_url":"https://api.github.com/users/benmoss/followers","following_url":"https://api.github.com/users/benmoss/following{/other_user}","gists_url":"https://api.github.com/users/benmoss/gists{/gist_id}","starred_url":"https://api.github.com/users/benmoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmoss/subscriptions","organizations_url":"https://api.github.com/users/benmoss/orgs","repos_url":"https://api.github.com/users/benmoss/repos","events_url":"https://api.github.com/users/benmoss/events{/privacy}","received_events_url":"https://api.github.com/users/benmoss/received_events","type":"User","site_admin":false},{"login":"justaugustus","id":567897,"node_id":"MDQ6VXNlcjU2Nzg5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/567897?v=4","gravatar_id":"","url":"https://api.github.com/users/justaugustus","html_url":"https://github.com/justaugustus","followers_url":"https://api.github.com/users/justaugustus/followers","following_url":"https://api.github.com/users/justaugustus/following{/other_user}","gists_url":"https://api.github.com/users/justaugustus/gists{/gist_id}","starred_url":"https://api.github.com/users/justaugustus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justaugustus/subscriptions","organizations_url":"https://api.github.com/users/justaugustus/orgs","repos_url":"https://api.github.com/users/justaugustus/repos","events_url":"https://api.github.com/users/justaugustus/events{/privacy}","received_events_url":"https://api.github.com/users/justaugustus/received_events","type":"User","site_admin":false},{"login":"michmike","id":6655749,"node_id":"MDQ6VXNlcjY2NTU3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6655749?v=4","gravatar_id":"","url":"https://api.github.com/users/michmike","html_url":"https://github.com/michmike","followers_url":"https://api.github.com/users/michmike/followers","following_url":"https://api.github.com/users/michmike/following{/other_user}","gists_url":"https://api.github.com/users/michmike/gists{/gist_id}","starred_url":"https://api.github.com/users/michmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michmike/subscriptions","organizations_url":"https://api.github.com/users/michmike/orgs","repos_url":"https://api.github.com/users/michmike/repos","events_url":"https://api.github.com/users/michmike/events{/privacy}","received_events_url":"https://api.github.com/users/michmike/received_events","type":"User","site_admin":false},{"login":"PatrickLang","id":11345431,"node_id":"MDQ6VXNlcjExMzQ1NDMx","avatar_url":"https://avatars1.githubusercontent.com/u/11345431?v=4","gravatar_id":"","url":"https://api.github.com/users/PatrickLang","html_url":"https://github.com/PatrickLang","followers_url":"https://api.github.com/users/PatrickLang/followers","following_url":"https://api.github.com/users/PatrickLang/following{/other_user}","gists_url":"https://api.github.com/users/PatrickLang/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickLang/subscriptions","organizations_url":"https://api.github.com/users/PatrickLang/orgs","repos_url":"https://api.github.com/users/PatrickLang/repos","events_url":"https://api.github.com/users/PatrickLang/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickLang/received_events","type":"User","site_admin":false},{"login":"ddebroy","id":22652369,"node_id":"MDQ6VXNlcjIyNjUyMzY5","avatar_url":"https://avatars2.githubusercontent.com/u/22652369?v=4","gravatar_id":"","url":"https://api.github.com/users/ddebroy","html_url":"https://github.com/ddebroy","followers_url":"https://api.github.com/users/ddebroy/followers","following_url":"https://api.github.com/users/ddebroy/following{/other_user}","gists_url":"https://api.github.com/users/ddebroy/gists{/gist_id}","starred_url":"https://api.github.com/users/ddebroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddebroy/subscriptions","organizations_url":"https://api.github.com/users/ddebroy/orgs","repos_url":"https://api.github.com/users/ddebroy/repos","events_url":"https://api.github.com/users/ddebroy/events{/privacy}","received_events_url":"https://api.github.com/users/ddebroy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"krzyzacy","id":1108148,"node_id":"MDQ6VXNlcjExMDgxNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1108148?v=4","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false},{"login":"chases2","id":1386266,"node_id":"MDQ6VXNlcjEzODYyNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1386266?v=4","gravatar_id":"","url":"https://api.github.com/users/chases2","html_url":"https://github.com/chases2","followers_url":"https://api.github.com/users/chases2/followers","following_url":"https://api.github.com/users/chases2/following{/other_user}","gists_url":"https://api.github.com/users/chases2/gists{/gist_id}","starred_url":"https://api.github.com/users/chases2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chases2/subscriptions","organizations_url":"https://api.github.com/users/chases2/orgs","repos_url":"https://api.github.com/users/chases2/repos","events_url":"https://api.github.com/users/chases2/events{/privacy}","received_events_url":"https://api.github.com/users/chases2/received_events","type":"User","site_admin":false},{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1016669578,"node_id":"MDU6TGFiZWwxMDE2NjY5NTc4","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/config","name":"area/config","color":"0052cc","default":false},{"id":1202603318,"node_id":"MDU6TGFiZWwxMjAyNjAzMzE4","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/release-eng","name":"area/release-eng","color":"0052cc","default":false},{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":366393439,"node_id":"MDU6TGFiZWwzNjYzOTM0Mzk=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1086786497,"node_id":"MDU6TGFiZWwxMDg2Nzg2NDk3","url":"https://api.github.com/repos/kubernetes/test-infra/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":718255933,"node_id":"MDU6TGFiZWw3MTgyNTU5MzM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/sig/release","name":"sig/release","color":"d2b48c","default":false},{"id":718255721,"node_id":"MDU6TGFiZWw3MTgyNTU3MjE=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":671133125,"node_id":"MDU6TGFiZWw2NzExMzMxMjU=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/14329/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/14329/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/14329/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/dcc1a5bc907498408276b1d381dbe849810f5f6d","head":{"label":"YangLu1031:master","ref":"master","sha":"dcc1a5bc907498408276b1d381dbe849810f5f6d","user":{"login":"YangLu1031","id":10737270,"node_id":"MDQ6VXNlcjEwNzM3Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/10737270?v=4","gravatar_id":"","url":"https://api.github.com/users/YangLu1031","html_url":"https://github.com/YangLu1031","followers_url":"https://api.github.com/users/YangLu1031/followers","following_url":"https://api.github.com/users/YangLu1031/following{/other_user}","gists_url":"https://api.github.com/users/YangLu1031/gists{/gist_id}","starred_url":"https://api.github.com/users/YangLu1031/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YangLu1031/subscriptions","organizations_url":"https://api.github.com/users/YangLu1031/orgs","repos_url":"https://api.github.com/users/YangLu1031/repos","events_url":"https://api.github.com/users/YangLu1031/events{/privacy}","received_events_url":"https://api.github.com/users/YangLu1031/received_events","type":"User","site_admin":false},"repo":{"id":207679692,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc2Nzk2OTI=","name":"test-infra","full_name":"YangLu1031/test-infra","private":false,"owner":{"login":"YangLu1031","id":10737270,"node_id":"MDQ6VXNlcjEwNzM3Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/10737270?v=4","gravatar_id":"","url":"https://api.github.com/users/YangLu1031","html_url":"https://github.com/YangLu1031","followers_url":"https://api.github.com/users/YangLu1031/followers","following_url":"https://api.github.com/users/YangLu1031/following{/other_user}","gists_url":"https://api.github.com/users/YangLu1031/gists{/gist_id}","starred_url":"https://api.github.com/users/YangLu1031/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YangLu1031/subscriptions","organizations_url":"https://api.github.com/users/YangLu1031/orgs","repos_url":"https://api.github.com/users/YangLu1031/repos","events_url":"https://api.github.com/users/YangLu1031/events{/privacy}","received_events_url":"https://api.github.com/users/YangLu1031/received_events","type":"User","site_admin":false},"html_url":"https://github.com/YangLu1031/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/YangLu1031/test-infra","forks_url":"https://api.github.com/repos/YangLu1031/test-infra/forks","keys_url":"https://api.github.com/repos/YangLu1031/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YangLu1031/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YangLu1031/test-infra/teams","hooks_url":"https://api.github.com/repos/YangLu1031/test-infra/hooks","issue_events_url":"https://api.github.com/repos/YangLu1031/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/YangLu1031/test-infra/events","assignees_url":"https://api.github.com/repos/YangLu1031/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/YangLu1031/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/YangLu1031/test-infra/tags","blobs_url":"https://api.github.com/repos/YangLu1031/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YangLu1031/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YangLu1031/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/YangLu1031/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YangLu1031/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/YangLu1031/test-infra/languages","stargazers_url":"https://api.github.com/repos/YangLu1031/test-infra/stargazers","contributors_url":"https://api.github.com/repos/YangLu1031/test-infra/contributors","subscribers_url":"https://api.github.com/repos/YangLu1031/test-infra/subscribers","subscription_url":"https://api.github.com/repos/YangLu1031/test-infra/subscription","commits_url":"https://api.github.com/repos/YangLu1031/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/YangLu1031/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/YangLu1031/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/YangLu1031/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/YangLu1031/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/YangLu1031/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YangLu1031/test-infra/merges","archive_url":"https://api.github.com/repos/YangLu1031/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YangLu1031/test-infra/downloads","issues_url":"https://api.github.com/repos/YangLu1031/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/YangLu1031/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/YangLu1031/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/YangLu1031/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YangLu1031/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/YangLu1031/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/YangLu1031/test-infra/deployments","created_at":"2019-09-10T23:14:59Z","updated_at":"2019-09-18T14:52:26Z","pushed_at":"2019-09-18T14:52:23Z","git_url":"git://github.com/YangLu1031/test-infra.git","ssh_url":"git@github.com:YangLu1031/test-infra.git","clone_url":"https://github.com/YangLu1031/test-infra.git","svn_url":"https://github.com/YangLu1031/test-infra","homepage":null,"size":96231,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e0a1e8e0d0f947087e7b8295f49b21d772f7a070","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"node_id":"MDEwOlJlcG9zaXRvcnk1NzMzMzcwOQ==","name":"test-infra","full_name":"kubernetes/test-infra","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2019-09-18T23:41:04Z","pushed_at":"2019-09-18T23:41:01Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":97169,"stargazers_count":1576,"watchers_count":1576,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1044,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":402,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1044,"open_issues":402,"watchers":1576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/14329"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/14329"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/14329"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/14329/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/14329/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/14329/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/dcc1a5bc907498408276b1d381dbe849810f5f6d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 57333709,
"name": "kubernetes/test-infra",
"url": "https://api.github.com/repos/kubernetes/test-infra"
}
|
{
"id": 10524058,
"login": "yujuhong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10524058?",
"url": "https://api.github.com/users/yujuhong"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-09-18T23:53:42 |
10447122532
|
{"actor":{"display_login":"yujuhong"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/337274181","pull_request_review_id":304894632,"id":337274181,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzI3NDE4MQ==","diff_hunk":"@@ -0,0 +1,414 @@\n+/*\n+Copyright 2019 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package v1alpha1\n+\n+import (\n+\tmetav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+)\n+\n+// These are valid wildcards.\n+const (\n+\tAPIGroupAll = \"*\"\n+\tResourceAll = \"*\"\n+\tVerbAll = \"*\"\n+\tNonResourceAll = \"*\"\n+\n+\tNameAll = \"*\"\n+)\n+\n+// System preset priority level names\n+const (\n+\tPriorityLevelConfigurationNameExempt = \"exempt\"\n+)\n+\n+// Conditions\n+const (\n+\tFlowSchemaConditionDangling = \"Dangling\"\n+\n+\tPriorityLevelConfigurationConditionConcurrencyShared = \"ConcurrencyShared\"\n+)\n+\n+// +genclient\n+// +genclient:nonNamespaced\n+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n+\n+// FlowSchema defines the schema of a group of flows. Note that a flow is made up of a set of inbound API requests with\n+// similar attributes and is identified by a pair of strings: the name of the FlowSchema and a \"flow distinguisher\".\n+type FlowSchema struct {\n+\tmetav1.TypeMeta `json:\",inline\"`\n+\t// `metadata` is the standard object's metadata.\n+\t// More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata\n+\t// +optional\n+\tmetav1.ObjectMeta `json:\"metadata,omitempty\" protobuf:\"bytes,1,opt,name=metadata\"`\n+\t// `spec` is the specification of the desired behavior of a flow-schema.\n+\t// More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#spec-and-status\n+\t// +optional\n+\tSpec FlowSchemaSpec `json:\"spec,omitempty\" protobuf:\"bytes,2,opt,name=spec\"`\n+\t// `status` is the current status of a flow-schema.\n+\t// More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#spec-and-status\n+\t// +optional\n+\tStatus FlowSchemaStatus `json:\"status,omitempty\" protobuf:\"bytes,3,opt,name=status\"`\n+}\n+\n+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n+\n+// FlowSchemaList is a list of FlowSchema objects.\n+type FlowSchemaList struct {\n+\tmetav1.TypeMeta `json:\",inline\"`\n+\t// `metadata` is the standard list metadata.\n+\t// More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata\n+\t// +optional\n+\tmetav1.ListMeta `json:\"metadata,omitempty\" protobuf:\"bytes,1,opt,name=metadata\"`\n+\n+\t// `items` is a list of flow-schemas.\n+\tItems []FlowSchema `json:\"items\" protobuf:\"bytes,2,rep,name=items\"`\n+}\n+\n+// FlowSchemaSpec describes how the flow-schema's specification looks like.\n+type FlowSchemaSpec struct {\n+\t// `priorityLevelConfiguration` should reference a PriorityLevelConfiguration in the cluster. If the reference cannot\n+\t// be resolved, the flow-schema will be ignored and marked as invalid in its status.\n+\t// Required.\n+\tPriorityLevelConfiguration PriorityLevelConfigurationReference `json:\"priorityLevelConfiguration\" protobuf:\"bytes,1,opt,name=priorityLevelConfiguration\"`\n+\t// `matchingPrecedence` is used to choose among the FlowSchemas that match a given request. The chosen\n+\t// FlowSchema is among those with the numerically lowest (which we take to be logically highest)\n+\t// MatchingPrecedence. Each MatchingPrecedence value must be non-negative.\n+\t// Note that if the precedence is not specified or zero, it will be set to 1000 as default.\n+\t// +optional\n+\tMatchingPrecedence int32 `json:\"matchingPrecedence\" protobuf:\"varint,2,opt,name=matchingPrecedence\"`\n+\t// `distinguisherMethod` defines how to compute the flow distinguisher for requests that match this schema.\n+\t// `nil` specifies that the distinguisher is disabled and thus will always be the empty string.\n+\t// +optional\n+\tDistinguisherMethod *FlowDistinguisherMethod `json:\"distinguisherMethod,omitempty\" protobuf:\"bytes,3,opt,name=distinguisherMethod\"`\n+\t// `rules` describes which requests will match this flow schema. This FlowSchema matches a request if and only if\n+\t// at least one member of rules matches the request.\n+\t// +optional\n+\tRules []PolicyRulesWithSubjects `json:\"rules\" protobuf:\"bytes,4,rep,name=rules\"`\n+}\n+\n+// FlowDistinguisherMethodType is the type of flow distinguisher method\n+type FlowDistinguisherMethodType string\n+\n+// These are valid flow-distinguisher methods.\n+const (\n+\t// FlowDistinguisherMethodByUserType specifies that the flow distinguisher is the username in the request.\n+\t// This type is used to provide some insulation between users.\n+\tFlowDistinguisherMethodByUserType FlowDistinguisherMethodType = \"ByUser\"\n+\n+\t// FlowDistinguisherMethodByNamespaceType specifies that the flow distinguisher is the namespace of the\n+\t// object that the request acts upon. If the object is not namespaced, or if the request is a non-resource\n+\t// request, then the distinguisher will be the empty string. An example usage of this type is to provide\n+\t// some insulation between tenants in a situation where there are multiple tenants and each namespace\n+\t// is dedicated to a tenant.\n+\tFlowDistinguisherMethodByNamespaceType FlowDistinguisherMethodType = \"ByNamespace\"\n+)\n+\n+// FlowDistinguisherMethod specifies the method of a flow distinguisher.\n+type FlowDistinguisherMethod struct {\n+\t// `type` is the type of flow distinguisher method\n+\t// The supported types are \"ByUser\" and \"ByNamespace\".\n+\t// Required.\n+\tType FlowDistinguisherMethodType `json:\"type\" protobuf:\"bytes,1,opt,name=type\"`\n+}\n+\n+// PriorityLevelConfigurationReference contains information that points to the \"request-priority\" being used.\n+type PriorityLevelConfigurationReference struct {\n+\t// `name` is the name of resource being referenced\n+\t// Required.\n+\tName string `json:\"name\" protobuf:\"bytes,1,opt,name=name\"`\n+}\n+\n+// PolicyRulesWithSubjects prescribes a test that applies to a request to an apiserver. The test considers the subject\n+// making the request, the verb being requested, and the resource to be acted upon. This PolicyRulesWithSubjects matches\n+// a request if and only if both (a) at least one member of subjects matches the request and (b) at least one member\n+// of resourceRules or nonResourceRules matches the request.\n+type PolicyRulesWithSubjects struct {\n+\t// `subjects` is the list of normal user, serviceaccount, or group that this rule cares about.\n+\t// There must be at least one subject for this field, or it will be rejected by the api validation.\n+\t// Required.\n+\tSubjects []Subject `json:\"subjects\" protobuf:\"bytes,1,rep,name=subjects\"`\n+\t// `resourceRules` is a slice of ResourcePolicyRules that identify matching requests according to their verb and the\n+\t// resource they request to act upon.\n+\t// +optional\n+\tResourceRules []ResourcePolicyRule `json:\"resourceRules,omitempty\" protobuf:\"bytes,2,opt,name=resourceRules\"`\n+\t// `nonResourceRules` is a list of NonResourcePolicyRules that identify matching requests according to their verb\n+\t// and the non-resource URL they request to act upon.\n+\t// +optional\n+\tNonResourceRules []NonResourcePolicyRule `json:\"nonResourceRules,omitempty\" protobuf:\"bytes,3,opt,name=nonResourceRules\"`\n+}\n+\n+// Subject matches a set of users.\n+// Syntactically, Subject is a general API object reference.\n+// Authorization produces a username and a set of groups, and we imagine special kinds of non-namespaced objects,\n+// User and Group to represent such a username or group.\n+// The only kind of true object reference that currently will match any users is ServiceAccount.\n+// +union\n+type Subject struct {\n+\t// Required\n+\t// +unionDiscriminator\n+\tKind SubjectKind `json:\"kind\" protobuf:\"bytes,1,opt,name=kind\"`\n+\t// +optional\n+\tUser *UserSubject `json:\"user,omitempty\" protobuf:\"bytes,2,opt,name=user\"`\n+\t// +optional\n+\tGroup *GroupSubject `json:\"group,omitempty\" protobuf:\"bytes,3,opt,name=group\"`\n+\t// +optional\n+\tServiceAccount *ServiceAccountSubject `json:\"serviceAccount,omitempty\" protobuf:\"bytes,4,opt,name=serviceAccount\"`\n+}\n+\n+type SubjectKind string\n+\n+// Supported subject's kinds.\n+const (\n+\tSubjectKindUser SubjectKind = \"User\"\n+\tSubjectKindGroup SubjectKind = \"Group\"\n+\tSubjectKindServiceAccount SubjectKind = \"ServiceAccount\"\n+)\n+\n+// UserSubject holds detailed information for user-kind subject.\n+type UserSubject struct {\n+\t// Required\n+\tName string `json:\"name\" protobuf:\"bytes,1,opt,name=name\"`\n+}\n+\n+// GroupSubject holds detailed information for group-kind subject.\n+type GroupSubject struct {\n+\t// Required\n+\tName string `json:\"name\" protobuf:\"bytes,1,opt,name=name\"`\n+}\n+\n+// ServiceAccountSubject holds detailed information for service-account-kind subject.\n+type ServiceAccountSubject struct {\n+\t// Required\n+\tNamespace string `json:\"namespace\" protobuf:\"bytes,1,opt,name=namespace\"`\n+\t// Required\n+\tName string `json:\"name\" protobuf:\"bytes,2,opt,name=name\"`\n+}\n+\n+// ResourcePolicyRule is a predicate that matches some resource requests, testing the request's verb and the resource\n+// that the request seeks to act upon. A ResourcePolicyRule matches a request if and only if: (a) at least one member\n+// of verbs matches the request, (b) at least one member of apiGroups matches the request, and (c) at least one member\n+// of resources matches the request.\n+type ResourcePolicyRule struct {\n+\t// `verbs` is a list of matching verbs and may not be empty.\n+\t// \"*\" represents all verbs.\n+\t// Required.\n+\tVerbs []string `json:\"verbs\" protobuf:\"bytes,1,rep,name=verbs\"`\n+\t// `apiGroups` is a list of matching API groups and may not be empty.\n+\t// \"*\" represents all api-groups.\n+\t// Required.\n+\tAPIGroups []string `json:\"apiGroups\" protobuf:\"bytes,2,rep,name=apiGroups\"`\n+\t// `resources` is a list of matching resource (i.e., lowercase and plural) with, if desired, subresource. This list\n+\t// may not be empty.\n+\t// \"*\" represents all resources.\n+\t// Required.\n+\tResources []string `json:\"resources\" protobuf:\"bytes,3,rep,name=resources\"`\n+}\n+\n+// NonResourcePolicyRule is a predicate that matches non-resource requests according to their verb and the non-resource\n+// URL they request to act upon. A NonResourcePolicyRule matches a request if and only if both (a) at least one member\n+// of verbs matches the request and (b) at least one member of nonResourceURLs matches the request.\n+type NonResourcePolicyRule struct {\n+\t// `verbs` is a list of matching verbs and may not be empty.\n+\t// \"*\" represents all verbs.\n+\t// Required.\n+\tVerbs []string `json:\"verbs\" protobuf:\"bytes,1,rep,name=verbs\"`\n+\t// `nonResourceURLs` is a set of partial urls that a user should have access to.\n+\t// \"*\" represents all non-resource urls.\n+\t// Required.\n+\tNonResourceURLs []string `json:\"nonResourceURLs\" protobuf:\"bytes,6,rep,name=nonResourceURLs\"`\n+}\n+\n+// FlowSchemaStatus represents the current state of a flow-schema.\n+type FlowSchemaStatus struct {\n+\t// `conditions` is a list of current states of flow-schema.\n+\t// +optional\n+\tConditions []FlowSchemaCondition `json:\"conditions,omitempty\" protobuf:\"bytes,1,rep,name=conditions\"`\n+}\n+\n+// FlowSchemaCondition describes conditions for a flow-schema.\n+type FlowSchemaCondition struct {\n+\t// `type` is the type of the condition.\n+\t// Required.\n+\tType FlowSchemaConditionType `json:\"type,omitempty\" protobuf:\"bytes,1,opt,name=type\"`\n+\t// `status` is the status of the condition.\n+\t// Can be True, False, Unknown.\n+\t// Required.\n+\tStatus ConditionStatus `json:\"status,omitempty\" protobuf:\"bytes,2,opt,name=status\"`\n+\t// `lastTransitionTime` is the last time the condition transitioned from one status to another.\n+\tLastTransitionTime metav1.Time `json:\"lastTransitionTime,omitempty\" protobuf:\"bytes,3,opt,name=lastTransitionTime\"`\n+\t// `reason` is a unique, one-word, CamelCase reason for the condition's last transition.\n+\tReason string `json:\"reason,omitempty\" protobuf:\"bytes,4,opt,name=reason\"`\n+\t// `message` is a human-readable message indicating details about last transition.\n+\tMessage string `json:\"message,omitempty\" protobuf:\"bytes,5,opt,name=message\"`\n+}\n+\n+// FlowSchemaConditionType is a valid value for FlowSchemaStatusCondition.Type\n+type FlowSchemaConditionType string\n+\n+// +genclient\n+// +genclient:nonNamespaced\n+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n+\n+// PriorityLevelConfiguration represents the configuration of a priority level.\n+type PriorityLevelConfiguration struct {\n+\tmetav1.TypeMeta `json:\",inline\"`\n+\t// `metadata` is the standard object's metadata.\n+\t// More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata\n+\t// +optional\n+\tmetav1.ObjectMeta `json:\"metadata,omitempty\" protobuf:\"bytes,1,opt,name=metadata\"`\n+\t// `spec` is the specification of the desired behavior of a \"request-priority\".\n+\t// More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#spec-and-status\n+\t// +optional\n+\tSpec PriorityLevelConfigurationSpec `json:\"spec,omitempty\" protobuf:\"bytes,2,opt,name=spec\"`\n+\t// `status` is the current status of a \"request-priority\".\n+\t// More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#spec-and-status\n+\t// +optional\n+\tStatus PriorityLevelConfigurationStatus `json:\"status,omitempty\" protobuf:\"bytes,3,opt,name=status\"`\n+}\n+\n+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n+\n+// PriorityLevelConfigurationList is a list of PriorityLevelConfiguration objects.\n+type PriorityLevelConfigurationList struct {\n+\tmetav1.TypeMeta `json:\",inline\"`\n+\t// `metadata` is the standard object's metadata.\n+\t// More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata\n+\t// +optional\n+\tmetav1.ListMeta `json:\"metadata,omitempty\" protobuf:\"bytes,1,opt,name=metadata\"`\n+\t// `items` is a list of request-priorities.\n+\tItems []PriorityLevelConfiguration `json:\"items\" protobuf:\"bytes,2,rep,name=items\"`\n+}\n+\n+// PriorityLevelConfigurationSpec is specification of a priority level\n+// +union\n+type PriorityLevelConfigurationSpec struct {\n+\t// `queuingType` indicates whether this priority level does\n+\t// queuing or is exempt. Valid values are \"Queuing\" and \"Exempt\",\n+\t// and this field defaults to \"Queuing\". \"Exempt\" means that\n+\t// requests of this priority level are not subject to concurrency\n+\t// limits (and thus are never queued) and do not detract from the\n+\t// concurrency available for non-exempt requests.\n+\t// Required.\n+\t// +unionDiscriminator\n+\tQueuingType PriorityLevelQueueingType `json:\"queuingType\" protobuf:\"varint,1,opt,name=queuingType\"`\n+\n+\t// `queuing` holds the configuration parameters that are\n+\t// only meaningful for a priority level that does queuing (i.e.,\n+\t// is not exempt). This field must be non-empty if and only if\n+\t// `queuingType` is `\"Queuing\"`.\n+\t// +optional\n+\tQueuingConfig *QueuingConfiguration `json:\"queuing,omitempty\" protobuf:\"bytes,2,opt,name=queuing\"`\n+\n+\t// `exempt` holds the configuration parameters for exempt priority levels.\n+\t// +optional\n+\tExempt *ExemptConfiguration `json:\"exempt,omitempty\" protobuf:\"bytes,3,opt,name=exempt\"`\n+}\n+\n+// PriorityLevelQueueingType identifies the queuing nature of a priority level\n+type PriorityLevelQueueingType string\n+\n+// PriorityLevelQueuingTypeQueueing is the PriorityLevelQueueingType for priority levels that queue\n+const PriorityLevelQueuingTypeQueueing PriorityLevelQueueingType = \"Queuing\"\n+\n+// PriorityLevelQueuingTypeExempt is the PriorityLevelQueueingType for priority levels that are exempt from concurrency controls\n+const PriorityLevelQueuingTypeExempt PriorityLevelQueueingType = \"Exempt\"\n+\n+// QueuingConfiguration holds the configuration parameters that are specific to a priority level that is subject to concurrency controls\n+type QueuingConfiguration struct {\n+\t// `assuredConcurrencyShares` (ACS) must be a positive number. The\n+\t// API server's concurrency limit (SCL) is divided among the","path":"staging/src/k8s.io/api/flowcontrol/v1alpha1/types.go","position":333,"original_position":333,"commit_id":"fc3e9d6c866f9e65062d88e419a6aa4c2f98f233","original_commit_id":"fc3e9d6c866f9e65062d88e419a6aa4c2f98f233","user":{"login":"MikeSpreitzer","id":14296719,"node_id":"MDQ6VXNlcjE0Mjk2NzE5","avatar_url":"https://avatars2.githubusercontent.com/u/14296719?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeSpreitzer","html_url":"https://github.com/MikeSpreitzer","followers_url":"https://api.github.com/users/MikeSpreitzer/followers","following_url":"https://api.github.com/users/MikeSpreitzer/following{/other_user}","gists_url":"https://api.github.com/users/MikeSpreitzer/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeSpreitzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeSpreitzer/subscriptions","organizations_url":"https://api.github.com/users/MikeSpreitzer/orgs","repos_url":"https://api.github.com/users/MikeSpreitzer/repos","events_url":"https://api.github.com/users/MikeSpreitzer/events{/privacy}","received_events_url":"https://api.github.com/users/MikeSpreitzer/received_events","type":"User","site_admin":false},"body":"OK with me if others think that is clearer.","created_at":"2019-10-21T22:50:14Z","updated_at":"2019-10-21T22:50:15Z","html_url":"https://github.com/kubernetes/kubernetes/pull/83671#discussion_r337274181","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/83671","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/337274181"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/83671#discussion_r337274181"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/83671"}},"in_reply_to_id":337197958},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/83671","id":326173497,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2MTczNDk3","html_url":"https://github.com/kubernetes/kubernetes/pull/83671","diff_url":"https://github.com/kubernetes/kubernetes/pull/83671.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/83671.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/83671","number":83671,"state":"open","locked":false,"title":"Apiserver flowcontrol api models","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"body":"\r\n```release-note\r\nNONE\r\n```\r\n\r\n/sig api-machinery\r\n/kind feature","created_at":"2019-10-09T10:10:35Z","updated_at":"2019-10-21T22:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d63a2136639e94b77adfc79bec240a3b1c2531b","assignee":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"adohe","id":1555564,"node_id":"MDQ6VXNlcjE1NTU1NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1555564?v=4","gravatar_id":"","url":"https://api.github.com/users/adohe","html_url":"https://github.com/adohe","followers_url":"https://api.github.com/users/adohe/followers","following_url":"https://api.github.com/users/adohe/following{/other_user}","gists_url":"https://api.github.com/users/adohe/gists{/gist_id}","starred_url":"https://api.github.com/users/adohe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adohe/subscriptions","organizations_url":"https://api.github.com/users/adohe/orgs","repos_url":"https://api.github.com/users/adohe/repos","events_url":"https://api.github.com/users/adohe/events{/privacy}","received_events_url":"https://api.github.com/users/adohe/received_events","type":"User","site_admin":false},{"login":"aaron-prindle","id":1951658,"node_id":"MDQ6VXNlcjE5NTE2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1951658?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},{"login":"mars1024","id":15814167,"node_id":"MDQ6VXNlcjE1ODE0MTY3","avatar_url":"https://avatars1.githubusercontent.com/u/15814167?v=4","gravatar_id":"","url":"https://api.github.com/users/mars1024","html_url":"https://github.com/mars1024","followers_url":"https://api.github.com/users/mars1024/followers","following_url":"https://api.github.com/users/mars1024/following{/other_user}","gists_url":"https://api.github.com/users/mars1024/gists{/gist_id}","starred_url":"https://api.github.com/users/mars1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mars1024/subscriptions","organizations_url":"https://api.github.com/users/mars1024/orgs","repos_url":"https://api.github.com/users/mars1024/repos","events_url":"https://api.github.com/users/mars1024/events{/privacy}","received_events_url":"https://api.github.com/users/mars1024/received_events","type":"User","site_admin":false},{"login":"yliaog","id":32884155,"node_id":"MDQ6VXNlcjMyODg0MTU1","avatar_url":"https://avatars0.githubusercontent.com/u/32884155?v=4","gravatar_id":"","url":"https://api.github.com/users/yliaog","html_url":"https://github.com/yliaog","followers_url":"https://api.github.com/users/yliaog/followers","following_url":"https://api.github.com/users/yliaog/following{/other_user}","gists_url":"https://api.github.com/users/yliaog/gists{/gist_id}","starred_url":"https://api.github.com/users/yliaog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yliaog/subscriptions","organizations_url":"https://api.github.com/users/yliaog/orgs","repos_url":"https://api.github.com/users/yliaog/repos","events_url":"https://api.github.com/users/yliaog/events{/privacy}","received_events_url":"https://api.github.com/users/yliaog/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":136601536,"node_id":"MDU6TGFiZWwxMzY2MDE1MzY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/apiserver","name":"area/apiserver","color":"0052cc","default":false},{"id":732478758,"node_id":"MDU6TGFiZWw3MzI0Nzg3NTg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/code-generation","name":"area/code-generation","color":"0052cc","default":false},{"id":105152717,"node_id":"MDU6TGFiZWwxMDUxNTI3MTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/test","name":"area/test","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"node_id":"MDU6TGFiZWwyNjEwMDUzNjA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"e11d21","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/83671/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/83671/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/83671/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/fc3e9d6c866f9e65062d88e419a6aa4c2f98f233","head":{"label":"yue9944882:flow-control-api-model","ref":"flow-control-api-model","sha":"fc3e9d6c866f9e65062d88e419a6aa4c2f98f233","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"repo":{"id":112361176,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzNjExNzY=","name":"kubernetes","full_name":"yue9944882/kubernetes","private":false,"owner":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yue9944882/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/yue9944882/kubernetes","forks_url":"https://api.github.com/repos/yue9944882/kubernetes/forks","keys_url":"https://api.github.com/repos/yue9944882/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yue9944882/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yue9944882/kubernetes/teams","hooks_url":"https://api.github.com/repos/yue9944882/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/yue9944882/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/yue9944882/kubernetes/events","assignees_url":"https://api.github.com/repos/yue9944882/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/yue9944882/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/yue9944882/kubernetes/tags","blobs_url":"https://api.github.com/repos/yue9944882/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yue9944882/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yue9944882/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/yue9944882/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yue9944882/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/yue9944882/kubernetes/languages","stargazers_url":"https://api.github.com/repos/yue9944882/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/yue9944882/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/yue9944882/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/yue9944882/kubernetes/subscription","commits_url":"https://api.github.com/repos/yue9944882/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/yue9944882/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/yue9944882/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/yue9944882/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/yue9944882/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/yue9944882/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yue9944882/kubernetes/merges","archive_url":"https://api.github.com/repos/yue9944882/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yue9944882/kubernetes/downloads","issues_url":"https://api.github.com/repos/yue9944882/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/yue9944882/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/yue9944882/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/yue9944882/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yue9944882/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/yue9944882/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/yue9944882/kubernetes/deployments","created_at":"2017-11-28T16:35:51Z","updated_at":"2019-08-30T05:33:26Z","pushed_at":"2019-10-21T16:32:41Z","git_url":"git://github.com/yue9944882/kubernetes.git","ssh_url":"git@github.com:yue9944882/kubernetes.git","clone_url":"https://github.com/yue9944882/kubernetes.git","svn_url":"https://github.com/yue9944882/kubernetes","homepage":"http://kubernetes.io","size":676099,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0f834b69a1401c73225a09493c722c1d995f3d3b","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2019-10-21T21:43:59Z","pushed_at":"2019-10-21T22:31:20Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":906524,"stargazers_count":59067,"watchers_count":59067,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20714,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3277,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20714,"open_issues":3277,"watchers":59067,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/83671"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/83671"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/83671"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/83671/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/83671/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/83671/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/fc3e9d6c866f9e65062d88e419a6aa4c2f98f233"}},"author_association":"MEMBER"}}
|
{
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
}
|
{
"id": 14296719,
"login": "MikeSpreitzer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14296719?",
"url": "https://api.github.com/users/MikeSpreitzer"
}
|
{
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
}
| 2019-10-21T22:50:14 |
10680936749
|
{"actor":{"display_login":"MikeSpreitzer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/databio/logmuse/pulls/comments/290339243","pull_request_review_id":245501386,"id":290339243,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDMzOTI0Mw==","diff_hunk":"@@ -100,18 +99,7 @@ def logger_via_cli(opts, **kwargs):\n # between the CLI version and the logger setup signature).\n logs_cli_args[PARAM_BY_OPTNAME.get(optname, name)] = optval\n logs_cli_args.update(kwargs)\n- return setup_logger(**logs_cli_args)\n-\n-def setup_logger(\n- name=\"\", level=None, stream=None, logfile=None,\n- make_root=None, propagate=False, silent=False, devmode=False,\n- verbosity=None, fmt=None, datefmt=None, plain_format=False, style=None):\n- \"\"\"\n- Old alias for init_logger for backwards compatibility\n- \"\"\"\n- return init_logger(name, level, stream, logfile,\n- make_root, propagate, silent, devmode,\n- verbosity, fmt, datefmt, plain_format, style)\n+ return init_logger(**logs_cli_args)","path":"logmuse/est.py","position":46,"original_position":46,"commit_id":"95d7eee7d311ccf25b9e69517740677923a5a838","original_commit_id":"95d7eee7d311ccf25b9e69517740677923a5a838","user":{"login":"nsheff","id":5271009,"node_id":"MDQ6VXNlcjUyNzEwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5271009?v=4","gravatar_id":"","url":"https://api.github.com/users/nsheff","html_url":"https://github.com/nsheff","followers_url":"https://api.github.com/users/nsheff/followers","following_url":"https://api.github.com/users/nsheff/following{/other_user}","gists_url":"https://api.github.com/users/nsheff/gists{/gist_id}","starred_url":"https://api.github.com/users/nsheff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsheff/subscriptions","organizations_url":"https://api.github.com/users/nsheff/orgs","repos_url":"https://api.github.com/users/nsheff/repos","events_url":"https://api.github.com/users/nsheff/events{/privacy}","received_events_url":"https://api.github.com/users/nsheff/received_events","type":"User","site_admin":false},"body":"much better, thanks.","created_at":"2019-06-04T14:52:06Z","updated_at":"2019-06-04T14:52:06Z","html_url":"https://github.com/databio/logmuse/pull/9#discussion_r290339243","pull_request_url":"https://api.github.com/repos/databio/logmuse/pulls/9","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/databio/logmuse/pulls/comments/290339243"},"html":{"href":"https://github.com/databio/logmuse/pull/9#discussion_r290339243"},"pull_request":{"href":"https://api.github.com/repos/databio/logmuse/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/databio/logmuse/pulls/9","id":285005570,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1MDA1NTcw","html_url":"https://github.com/databio/logmuse/pull/9","diff_url":"https://github.com/databio/logmuse/pull/9.diff","patch_url":"https://github.com/databio/logmuse/pull/9.patch","issue_url":"https://api.github.com/repos/databio/logmuse/issues/9","number":9,"state":"open","locked":false,"title":"reduce message width","user":{"login":"nsheff","id":5271009,"node_id":"MDQ6VXNlcjUyNzEwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5271009?v=4","gravatar_id":"","url":"https://api.github.com/users/nsheff","html_url":"https://github.com/nsheff","followers_url":"https://api.github.com/users/nsheff/followers","following_url":"https://api.github.com/users/nsheff/following{/other_user}","gists_url":"https://api.github.com/users/nsheff/gists{/gist_id}","starred_url":"https://api.github.com/users/nsheff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsheff/subscriptions","organizations_url":"https://api.github.com/users/nsheff/orgs","repos_url":"https://api.github.com/users/nsheff/repos","events_url":"https://api.github.com/users/nsheff/events{/privacy}","received_events_url":"https://api.github.com/users/nsheff/received_events","type":"User","site_admin":false},"body":"It would be nice if the logmuse options were very compact so they didn't clutter the help CLI output of a tool that uses logmuse. look at this:\r\n\r\n```\r\nversion: 0.4.0-dev\r\nusage: refgenie [-h] [-V] [-c GENOME_CONFIG] [--logdev]\r\n [--verbosity VERBOSITY] [--silent]\r\n {pull,build,list,init,listr} ...\r\n\r\nrefgenie - builds and manages reference genome assemblies\r\n\r\npositional arguments:\r\n {pull,build,list,init,listr}\r\n pull Download assets.\r\n build Build genome assets\r\n list List available local genomes.\r\n init Initialize a genome configuration.\r\n listr List available genomes and assets on server.\r\n\r\noptional arguments:\r\n -h, --help show this help message and exit\r\n -V, --version show program's version number and exit\r\n -c GENOME_CONFIG, --genome-config GENOME_CONFIG\r\n --logdev Expand content of logging message format.\r\n --verbosity VERBOSITY\r\n Set logging level (integer from 0-5 or Python builtin)\r\n --silent Silence logging. Overrides --verbosity.\r\n\r\n```\r\n\r\nIn this PR I chagned the logdev and verbosity help messages to fit on one line, which is nice. However, because \"VERBOSITY\" is so long, it still takes up 2 lines regardless of size of the help message. See [this question](https://stackoverflow.com/questions/52605094/python-argparse-increase-space-between-parameter-and-description) for a complete description of what I mean.\r\n\r\nI propose: we change the `dest` for `verbosity` to be shorter... just `V` perhaps? that will solve this problem without requiring every tool that uses logmuse to have a custom help formatter.","created_at":"2019-06-04T14:38:56Z","updated_at":"2019-06-04T14:52:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5edb2cf4e5eab57c1c7327e72c885a838cf59286","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vreuter","id":12036370,"node_id":"MDQ6VXNlcjEyMDM2Mzcw","avatar_url":"https://avatars1.githubusercontent.com/u/12036370?v=4","gravatar_id":"","url":"https://api.github.com/users/vreuter","html_url":"https://github.com/vreuter","followers_url":"https://api.github.com/users/vreuter/followers","following_url":"https://api.github.com/users/vreuter/following{/other_user}","gists_url":"https://api.github.com/users/vreuter/gists{/gist_id}","starred_url":"https://api.github.com/users/vreuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vreuter/subscriptions","organizations_url":"https://api.github.com/users/vreuter/orgs","repos_url":"https://api.github.com/users/vreuter/repos","events_url":"https://api.github.com/users/vreuter/events{/privacy}","received_events_url":"https://api.github.com/users/vreuter/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/databio/logmuse/pulls/9/commits","review_comments_url":"https://api.github.com/repos/databio/logmuse/pulls/9/comments","review_comment_url":"https://api.github.com/repos/databio/logmuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/databio/logmuse/issues/9/comments","statuses_url":"https://api.github.com/repos/databio/logmuse/statuses/95d7eee7d311ccf25b9e69517740677923a5a838","head":{"label":"databio:dev","ref":"dev","sha":"95d7eee7d311ccf25b9e69517740677923a5a838","user":{"login":"databio","id":13696008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjk2MDA4","avatar_url":"https://avatars0.githubusercontent.com/u/13696008?v=4","gravatar_id":"","url":"https://api.github.com/users/databio","html_url":"https://github.com/databio","followers_url":"https://api.github.com/users/databio/followers","following_url":"https://api.github.com/users/databio/following{/other_user}","gists_url":"https://api.github.com/users/databio/gists{/gist_id}","starred_url":"https://api.github.com/users/databio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databio/subscriptions","organizations_url":"https://api.github.com/users/databio/orgs","repos_url":"https://api.github.com/users/databio/repos","events_url":"https://api.github.com/users/databio/events{/privacy}","received_events_url":"https://api.github.com/users/databio/received_events","type":"Organization","site_admin":false},"repo":{"id":179319783,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkzMTk3ODM=","name":"logmuse","full_name":"databio/logmuse","private":false,"owner":{"login":"databio","id":13696008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjk2MDA4","avatar_url":"https://avatars0.githubusercontent.com/u/13696008?v=4","gravatar_id":"","url":"https://api.github.com/users/databio","html_url":"https://github.com/databio","followers_url":"https://api.github.com/users/databio/followers","following_url":"https://api.github.com/users/databio/following{/other_user}","gists_url":"https://api.github.com/users/databio/gists{/gist_id}","starred_url":"https://api.github.com/users/databio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databio/subscriptions","organizations_url":"https://api.github.com/users/databio/orgs","repos_url":"https://api.github.com/users/databio/repos","events_url":"https://api.github.com/users/databio/events{/privacy}","received_events_url":"https://api.github.com/users/databio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/databio/logmuse","description":"Small logging setup package","fork":false,"url":"https://api.github.com/repos/databio/logmuse","forks_url":"https://api.github.com/repos/databio/logmuse/forks","keys_url":"https://api.github.com/repos/databio/logmuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/databio/logmuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/databio/logmuse/teams","hooks_url":"https://api.github.com/repos/databio/logmuse/hooks","issue_events_url":"https://api.github.com/repos/databio/logmuse/issues/events{/number}","events_url":"https://api.github.com/repos/databio/logmuse/events","assignees_url":"https://api.github.com/repos/databio/logmuse/assignees{/user}","branches_url":"https://api.github.com/repos/databio/logmuse/branches{/branch}","tags_url":"https://api.github.com/repos/databio/logmuse/tags","blobs_url":"https://api.github.com/repos/databio/logmuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/databio/logmuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/databio/logmuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/databio/logmuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/databio/logmuse/statuses/{sha}","languages_url":"https://api.github.com/repos/databio/logmuse/languages","stargazers_url":"https://api.github.com/repos/databio/logmuse/stargazers","contributors_url":"https://api.github.com/repos/databio/logmuse/contributors","subscribers_url":"https://api.github.com/repos/databio/logmuse/subscribers","subscription_url":"https://api.github.com/repos/databio/logmuse/subscription","commits_url":"https://api.github.com/repos/databio/logmuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/databio/logmuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/databio/logmuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/databio/logmuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/databio/logmuse/contents/{+path}","compare_url":"https://api.github.com/repos/databio/logmuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/databio/logmuse/merges","archive_url":"https://api.github.com/repos/databio/logmuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/databio/logmuse/downloads","issues_url":"https://api.github.com/repos/databio/logmuse/issues{/number}","pulls_url":"https://api.github.com/repos/databio/logmuse/pulls{/number}","milestones_url":"https://api.github.com/repos/databio/logmuse/milestones{/number}","notifications_url":"https://api.github.com/repos/databio/logmuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/databio/logmuse/labels{/name}","releases_url":"https://api.github.com/repos/databio/logmuse/releases{/id}","deployments_url":"https://api.github.com/repos/databio/logmuse/deployments","created_at":"2019-04-03T15:35:54Z","updated_at":"2019-05-13T21:30:29Z","pushed_at":"2019-06-04T14:47:49Z","git_url":"git://github.com/databio/logmuse.git","ssh_url":"git@github.com:databio/logmuse.git","clone_url":"https://github.com/databio/logmuse.git","svn_url":"https://github.com/databio/logmuse","homepage":"http://logmuse.databio.org","size":36,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"databio:master","ref":"master","sha":"a7d11aad6f2cec61f94b900c6abfeab049dc1cfc","user":{"login":"databio","id":13696008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjk2MDA4","avatar_url":"https://avatars0.githubusercontent.com/u/13696008?v=4","gravatar_id":"","url":"https://api.github.com/users/databio","html_url":"https://github.com/databio","followers_url":"https://api.github.com/users/databio/followers","following_url":"https://api.github.com/users/databio/following{/other_user}","gists_url":"https://api.github.com/users/databio/gists{/gist_id}","starred_url":"https://api.github.com/users/databio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databio/subscriptions","organizations_url":"https://api.github.com/users/databio/orgs","repos_url":"https://api.github.com/users/databio/repos","events_url":"https://api.github.com/users/databio/events{/privacy}","received_events_url":"https://api.github.com/users/databio/received_events","type":"Organization","site_admin":false},"repo":{"id":179319783,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkzMTk3ODM=","name":"logmuse","full_name":"databio/logmuse","private":false,"owner":{"login":"databio","id":13696008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjk2MDA4","avatar_url":"https://avatars0.githubusercontent.com/u/13696008?v=4","gravatar_id":"","url":"https://api.github.com/users/databio","html_url":"https://github.com/databio","followers_url":"https://api.github.com/users/databio/followers","following_url":"https://api.github.com/users/databio/following{/other_user}","gists_url":"https://api.github.com/users/databio/gists{/gist_id}","starred_url":"https://api.github.com/users/databio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databio/subscriptions","organizations_url":"https://api.github.com/users/databio/orgs","repos_url":"https://api.github.com/users/databio/repos","events_url":"https://api.github.com/users/databio/events{/privacy}","received_events_url":"https://api.github.com/users/databio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/databio/logmuse","description":"Small logging setup package","fork":false,"url":"https://api.github.com/repos/databio/logmuse","forks_url":"https://api.github.com/repos/databio/logmuse/forks","keys_url":"https://api.github.com/repos/databio/logmuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/databio/logmuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/databio/logmuse/teams","hooks_url":"https://api.github.com/repos/databio/logmuse/hooks","issue_events_url":"https://api.github.com/repos/databio/logmuse/issues/events{/number}","events_url":"https://api.github.com/repos/databio/logmuse/events","assignees_url":"https://api.github.com/repos/databio/logmuse/assignees{/user}","branches_url":"https://api.github.com/repos/databio/logmuse/branches{/branch}","tags_url":"https://api.github.com/repos/databio/logmuse/tags","blobs_url":"https://api.github.com/repos/databio/logmuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/databio/logmuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/databio/logmuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/databio/logmuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/databio/logmuse/statuses/{sha}","languages_url":"https://api.github.com/repos/databio/logmuse/languages","stargazers_url":"https://api.github.com/repos/databio/logmuse/stargazers","contributors_url":"https://api.github.com/repos/databio/logmuse/contributors","subscribers_url":"https://api.github.com/repos/databio/logmuse/subscribers","subscription_url":"https://api.github.com/repos/databio/logmuse/subscription","commits_url":"https://api.github.com/repos/databio/logmuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/databio/logmuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/databio/logmuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/databio/logmuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/databio/logmuse/contents/{+path}","compare_url":"https://api.github.com/repos/databio/logmuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/databio/logmuse/merges","archive_url":"https://api.github.com/repos/databio/logmuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/databio/logmuse/downloads","issues_url":"https://api.github.com/repos/databio/logmuse/issues{/number}","pulls_url":"https://api.github.com/repos/databio/logmuse/pulls{/number}","milestones_url":"https://api.github.com/repos/databio/logmuse/milestones{/number}","notifications_url":"https://api.github.com/repos/databio/logmuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/databio/logmuse/labels{/name}","releases_url":"https://api.github.com/repos/databio/logmuse/releases{/id}","deployments_url":"https://api.github.com/repos/databio/logmuse/deployments","created_at":"2019-04-03T15:35:54Z","updated_at":"2019-05-13T21:30:29Z","pushed_at":"2019-06-04T14:47:49Z","git_url":"git://github.com/databio/logmuse.git","ssh_url":"git@github.com:databio/logmuse.git","clone_url":"https://github.com/databio/logmuse.git","svn_url":"https://github.com/databio/logmuse","homepage":"http://logmuse.databio.org","size":36,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/databio/logmuse/pulls/9"},"html":{"href":"https://github.com/databio/logmuse/pull/9"},"issue":{"href":"https://api.github.com/repos/databio/logmuse/issues/9"},"comments":{"href":"https://api.github.com/repos/databio/logmuse/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/databio/logmuse/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/databio/logmuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/databio/logmuse/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/databio/logmuse/statuses/95d7eee7d311ccf25b9e69517740677923a5a838"}},"author_association":"MEMBER"}}
|
{
"id": 179319783,
"name": "databio/logmuse",
"url": "https://api.github.com/repos/databio/logmuse"
}
|
{
"id": 5271009,
"login": "nsheff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5271009?",
"url": "https://api.github.com/users/nsheff"
}
|
{
"id": 13696008,
"login": "databio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13696008?",
"url": "https://api.github.com/orgs/databio"
}
| 2019-06-04T14:52:06 |
9755953473
|
{"actor":{"display_login":"nsheff"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/JMRI/JMRI/pulls/comments/277181660","pull_request_review_id":228926723,"id":277181660,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzE4MTY2MA==","diff_hunk":"@@ -485,11 +487,41 @@ public void startThreads() {\n Thread rcvThread;\n Thread xmtThread;\n \n- \n /**\n- * Flag that threads should terminate as soon as they can.\n+ * Testing Only - request the rec & xmit threads to be terminated\n+ * if set before start, one loop only is performed.\n+ */\n+ protected void setthreadStopRequestOn() {\n+ threadStopRequest = true;\n+ }\n+\n+ /**\n+ * Testing Only - Spins its wheels for 100ms or threads terminated\n+ * @return true threads were terminated\n+ */\n+ protected boolean waitForThreadsToStop() {\n+ for (int i = 1; i < 10; i++) {","path":"java/src/jmri/jmrix/loconet/LnPacketizer.java","position":102,"original_position":57,"commit_id":"95467bff848342183e704b95b7de5909d03bafa6","original_commit_id":"3d0ce8446c7b7225cfdc68b1570b5f5c1c4355e3","user":{"login":"pabender","id":14183416,"node_id":"MDQ6VXNlcjE0MTgzNDE2","avatar_url":"https://avatars2.githubusercontent.com/u/14183416?v=4","gravatar_id":"","url":"https://api.github.com/users/pabender","html_url":"https://github.com/pabender","followers_url":"https://api.github.com/users/pabender/followers","following_url":"https://api.github.com/users/pabender/following{/other_user}","gists_url":"https://api.github.com/users/pabender/gists{/gist_id}","starred_url":"https://api.github.com/users/pabender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabender/subscriptions","organizations_url":"https://api.github.com/users/pabender/orgs","repos_url":"https://api.github.com/users/pabender/repos","events_url":"https://api.github.com/users/pabender/events{/privacy}","received_events_url":"https://api.github.com/users/pabender/received_events","type":"User","site_admin":false},"body":"Shouldn’t this method be calling join on the two threads involved instead of waiting for these flags to be set?\r\n\r\nNot joining the thread leaves open the possibility that the threads will still be running after this loop completes.\r\n\r\nCalling join makes the flags irrelevant.","created_at":"2019-04-21T21:01:26Z","updated_at":"2019-04-21T21:01:27Z","html_url":"https://github.com/JMRI/JMRI/pull/6707#discussion_r277181660","pull_request_url":"https://api.github.com/repos/JMRI/JMRI/pulls/6707","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/comments/277181660"},"html":{"href":"https://github.com/JMRI/JMRI/pull/6707#discussion_r277181660"},"pull_request":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/6707"}}},"pull_request":{"url":"https://api.github.com/repos/JMRI/JMRI/pulls/6707","id":262343875,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyMzQzODc1","html_url":"https://github.com/JMRI/JMRI/pull/6707","diff_url":"https://github.com/JMRI/JMRI/pull/6707.diff","patch_url":"https://github.com/JMRI/JMRI/pull/6707.patch","issue_url":"https://api.github.com/repos/JMRI/JMRI/issues/6707","number":6707,"state":"open","locked":false,"title":"WIP: stop xmt and rec threads with boolean","user":{"login":"Pugwash1","id":18124026,"node_id":"MDQ6VXNlcjE4MTI0MDI2","avatar_url":"https://avatars3.githubusercontent.com/u/18124026?v=4","gravatar_id":"","url":"https://api.github.com/users/Pugwash1","html_url":"https://github.com/Pugwash1","followers_url":"https://api.github.com/users/Pugwash1/followers","following_url":"https://api.github.com/users/Pugwash1/following{/other_user}","gists_url":"https://api.github.com/users/Pugwash1/gists{/gist_id}","starred_url":"https://api.github.com/users/Pugwash1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pugwash1/subscriptions","organizations_url":"https://api.github.com/users/Pugwash1/orgs","repos_url":"https://api.github.com/users/Pugwash1/repos","events_url":"https://api.github.com/users/Pugwash1/events{/privacy}","received_events_url":"https://api.github.com/users/Pugwash1/received_events","type":"User","site_admin":false},"body":"Replaces #6701. \r\nProvide clean exits from threads","created_at":"2019-03-19T07:49:01Z","updated_at":"2019-04-21T21:01:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26a933bcd4900a57d3854c0bb298eeb092fa3c8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JMRI/JMRI/pulls/6707/commits","review_comments_url":"https://api.github.com/repos/JMRI/JMRI/pulls/6707/comments","review_comment_url":"https://api.github.com/repos/JMRI/JMRI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JMRI/JMRI/issues/6707/comments","statuses_url":"https://api.github.com/repos/JMRI/JMRI/statuses/95467bff848342183e704b95b7de5909d03bafa6","head":{"label":"Pugwash1:LnPacketizerThreading","ref":"LnPacketizerThreading","sha":"95467bff848342183e704b95b7de5909d03bafa6","user":{"login":"Pugwash1","id":18124026,"node_id":"MDQ6VXNlcjE4MTI0MDI2","avatar_url":"https://avatars3.githubusercontent.com/u/18124026?v=4","gravatar_id":"","url":"https://api.github.com/users/Pugwash1","html_url":"https://github.com/Pugwash1","followers_url":"https://api.github.com/users/Pugwash1/followers","following_url":"https://api.github.com/users/Pugwash1/following{/other_user}","gists_url":"https://api.github.com/users/Pugwash1/gists{/gist_id}","starred_url":"https://api.github.com/users/Pugwash1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pugwash1/subscriptions","organizations_url":"https://api.github.com/users/Pugwash1/orgs","repos_url":"https://api.github.com/users/Pugwash1/repos","events_url":"https://api.github.com/users/Pugwash1/events{/privacy}","received_events_url":"https://api.github.com/users/Pugwash1/received_events","type":"User","site_admin":false},"repo":{"id":77562431,"node_id":"MDEwOlJlcG9zaXRvcnk3NzU2MjQzMQ==","name":"JMRI","full_name":"Pugwash1/JMRI","private":false,"owner":{"login":"Pugwash1","id":18124026,"node_id":"MDQ6VXNlcjE4MTI0MDI2","avatar_url":"https://avatars3.githubusercontent.com/u/18124026?v=4","gravatar_id":"","url":"https://api.github.com/users/Pugwash1","html_url":"https://github.com/Pugwash1","followers_url":"https://api.github.com/users/Pugwash1/followers","following_url":"https://api.github.com/users/Pugwash1/following{/other_user}","gists_url":"https://api.github.com/users/Pugwash1/gists{/gist_id}","starred_url":"https://api.github.com/users/Pugwash1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pugwash1/subscriptions","organizations_url":"https://api.github.com/users/Pugwash1/orgs","repos_url":"https://api.github.com/users/Pugwash1/repos","events_url":"https://api.github.com/users/Pugwash1/events{/privacy}","received_events_url":"https://api.github.com/users/Pugwash1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Pugwash1/JMRI","description":"JMRI model railroad digital command & control software","fork":true,"url":"https://api.github.com/repos/Pugwash1/JMRI","forks_url":"https://api.github.com/repos/Pugwash1/JMRI/forks","keys_url":"https://api.github.com/repos/Pugwash1/JMRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pugwash1/JMRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pugwash1/JMRI/teams","hooks_url":"https://api.github.com/repos/Pugwash1/JMRI/hooks","issue_events_url":"https://api.github.com/repos/Pugwash1/JMRI/issues/events{/number}","events_url":"https://api.github.com/repos/Pugwash1/JMRI/events","assignees_url":"https://api.github.com/repos/Pugwash1/JMRI/assignees{/user}","branches_url":"https://api.github.com/repos/Pugwash1/JMRI/branches{/branch}","tags_url":"https://api.github.com/repos/Pugwash1/JMRI/tags","blobs_url":"https://api.github.com/repos/Pugwash1/JMRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pugwash1/JMRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pugwash1/JMRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pugwash1/JMRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pugwash1/JMRI/statuses/{sha}","languages_url":"https://api.github.com/repos/Pugwash1/JMRI/languages","stargazers_url":"https://api.github.com/repos/Pugwash1/JMRI/stargazers","contributors_url":"https://api.github.com/repos/Pugwash1/JMRI/contributors","subscribers_url":"https://api.github.com/repos/Pugwash1/JMRI/subscribers","subscription_url":"https://api.github.com/repos/Pugwash1/JMRI/subscription","commits_url":"https://api.github.com/repos/Pugwash1/JMRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pugwash1/JMRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pugwash1/JMRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pugwash1/JMRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pugwash1/JMRI/contents/{+path}","compare_url":"https://api.github.com/repos/Pugwash1/JMRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pugwash1/JMRI/merges","archive_url":"https://api.github.com/repos/Pugwash1/JMRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pugwash1/JMRI/downloads","issues_url":"https://api.github.com/repos/Pugwash1/JMRI/issues{/number}","pulls_url":"https://api.github.com/repos/Pugwash1/JMRI/pulls{/number}","milestones_url":"https://api.github.com/repos/Pugwash1/JMRI/milestones{/number}","notifications_url":"https://api.github.com/repos/Pugwash1/JMRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pugwash1/JMRI/labels{/name}","releases_url":"https://api.github.com/repos/Pugwash1/JMRI/releases{/id}","deployments_url":"https://api.github.com/repos/Pugwash1/JMRI/deployments","created_at":"2016-12-28T21:28:26Z","updated_at":"2019-04-12T12:29:46Z","pushed_at":"2019-04-21T20:52:57Z","git_url":"git://github.com/Pugwash1/JMRI.git","ssh_url":"git@github.com:Pugwash1/JMRI.git","clone_url":"https://github.com/Pugwash1/JMRI.git","svn_url":"https://github.com/Pugwash1/JMRI","homepage":"http://jmri.org","size":1835952,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JMRI:master","ref":"master","sha":"a41c1a58c89c6d8aa95a311263ecc18f439c9de1","user":{"login":"JMRI","id":13712710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzEyNzEw","avatar_url":"https://avatars2.githubusercontent.com/u/13712710?v=4","gravatar_id":"","url":"https://api.github.com/users/JMRI","html_url":"https://github.com/JMRI","followers_url":"https://api.github.com/users/JMRI/followers","following_url":"https://api.github.com/users/JMRI/following{/other_user}","gists_url":"https://api.github.com/users/JMRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JMRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMRI/subscriptions","organizations_url":"https://api.github.com/users/JMRI/orgs","repos_url":"https://api.github.com/users/JMRI/repos","events_url":"https://api.github.com/users/JMRI/events{/privacy}","received_events_url":"https://api.github.com/users/JMRI/received_events","type":"Organization","site_admin":false},"repo":{"id":42789514,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc4OTUxNA==","name":"JMRI","full_name":"JMRI/JMRI","private":false,"owner":{"login":"JMRI","id":13712710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzEyNzEw","avatar_url":"https://avatars2.githubusercontent.com/u/13712710?v=4","gravatar_id":"","url":"https://api.github.com/users/JMRI","html_url":"https://github.com/JMRI","followers_url":"https://api.github.com/users/JMRI/followers","following_url":"https://api.github.com/users/JMRI/following{/other_user}","gists_url":"https://api.github.com/users/JMRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JMRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMRI/subscriptions","organizations_url":"https://api.github.com/users/JMRI/orgs","repos_url":"https://api.github.com/users/JMRI/repos","events_url":"https://api.github.com/users/JMRI/events{/privacy}","received_events_url":"https://api.github.com/users/JMRI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JMRI/JMRI","description":"JMRI model railroad digital command & control software","fork":false,"url":"https://api.github.com/repos/JMRI/JMRI","forks_url":"https://api.github.com/repos/JMRI/JMRI/forks","keys_url":"https://api.github.com/repos/JMRI/JMRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JMRI/JMRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JMRI/JMRI/teams","hooks_url":"https://api.github.com/repos/JMRI/JMRI/hooks","issue_events_url":"https://api.github.com/repos/JMRI/JMRI/issues/events{/number}","events_url":"https://api.github.com/repos/JMRI/JMRI/events","assignees_url":"https://api.github.com/repos/JMRI/JMRI/assignees{/user}","branches_url":"https://api.github.com/repos/JMRI/JMRI/branches{/branch}","tags_url":"https://api.github.com/repos/JMRI/JMRI/tags","blobs_url":"https://api.github.com/repos/JMRI/JMRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JMRI/JMRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JMRI/JMRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/JMRI/JMRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JMRI/JMRI/statuses/{sha}","languages_url":"https://api.github.com/repos/JMRI/JMRI/languages","stargazers_url":"https://api.github.com/repos/JMRI/JMRI/stargazers","contributors_url":"https://api.github.com/repos/JMRI/JMRI/contributors","subscribers_url":"https://api.github.com/repos/JMRI/JMRI/subscribers","subscription_url":"https://api.github.com/repos/JMRI/JMRI/subscription","commits_url":"https://api.github.com/repos/JMRI/JMRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/JMRI/JMRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/JMRI/JMRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/JMRI/JMRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/JMRI/JMRI/contents/{+path}","compare_url":"https://api.github.com/repos/JMRI/JMRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JMRI/JMRI/merges","archive_url":"https://api.github.com/repos/JMRI/JMRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JMRI/JMRI/downloads","issues_url":"https://api.github.com/repos/JMRI/JMRI/issues{/number}","pulls_url":"https://api.github.com/repos/JMRI/JMRI/pulls{/number}","milestones_url":"https://api.github.com/repos/JMRI/JMRI/milestones{/number}","notifications_url":"https://api.github.com/repos/JMRI/JMRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JMRI/JMRI/labels{/name}","releases_url":"https://api.github.com/repos/JMRI/JMRI/releases{/id}","deployments_url":"https://api.github.com/repos/JMRI/JMRI/deployments","created_at":"2015-09-19T21:01:07Z","updated_at":"2019-04-21T16:37:16Z","pushed_at":"2019-04-21T20:52:59Z","git_url":"git://github.com/JMRI/JMRI.git","ssh_url":"git@github.com:JMRI/JMRI.git","clone_url":"https://github.com/JMRI/JMRI.git","svn_url":"https://github.com/JMRI/JMRI","homepage":"http://jmri.org","size":1739396,"stargazers_count":93,"watchers_count":93,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":385,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":188,"open_issues":385,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/6707"},"html":{"href":"https://github.com/JMRI/JMRI/pull/6707"},"issue":{"href":"https://api.github.com/repos/JMRI/JMRI/issues/6707"},"comments":{"href":"https://api.github.com/repos/JMRI/JMRI/issues/6707/comments"},"review_comments":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/6707/comments"},"review_comment":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/6707/commits"},"statuses":{"href":"https://api.github.com/repos/JMRI/JMRI/statuses/95467bff848342183e704b95b7de5909d03bafa6"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 42789514,
"name": "JMRI/JMRI",
"url": "https://api.github.com/repos/JMRI/JMRI"
}
|
{
"id": 14183416,
"login": "pabender",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14183416?",
"url": "https://api.github.com/users/pabender"
}
|
{
"id": 13712710,
"login": "JMRI",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13712710?",
"url": "https://api.github.com/orgs/JMRI"
}
| 2019-04-21T21:01:26 |
9483126821
|
{"actor":{"display_login":"pabender"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hibobio/bob-style/pulls/comments/346194074","pull_request_review_id":316799645,"id":346194074,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NjE5NDA3NA==","diff_hunk":"@@ -1,7 +1,12 @@\n <div class=\"side-menu-container\">","path":"projects/ui-framework/src/lib/navigation/side-menu/side-menu.component.html","position":1,"original_position":1,"commit_id":"61f3ec175d348eaa9dc61485cbb5e53f0725da67","original_commit_id":"61f3ec175d348eaa9dc61485cbb5e53f0725da67","user":{"login":"rinat-shemer","id":20039363,"node_id":"MDQ6VXNlcjIwMDM5MzYz","avatar_url":"https://avatars1.githubusercontent.com/u/20039363?v=4","gravatar_id":"","url":"https://api.github.com/users/rinat-shemer","html_url":"https://github.com/rinat-shemer","followers_url":"https://api.github.com/users/rinat-shemer/followers","following_url":"https://api.github.com/users/rinat-shemer/following{/other_user}","gists_url":"https://api.github.com/users/rinat-shemer/gists{/gist_id}","starred_url":"https://api.github.com/users/rinat-shemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinat-shemer/subscriptions","organizations_url":"https://api.github.com/users/rinat-shemer/orgs","repos_url":"https://api.github.com/users/rinat-shemer/repos","events_url":"https://api.github.com/users/rinat-shemer/events{/privacy}","received_events_url":"https://api.github.com/users/rinat-shemer/received_events","type":"User","site_admin":false},"body":"it has `box-sizing: border-box;` without it the header lose it's width","created_at":"2019-11-14T09:06:47Z","updated_at":"2019-11-14T09:06:47Z","html_url":"https://github.com/hibobio/bob-style/pull/1100#discussion_r346194074","pull_request_url":"https://api.github.com/repos/hibobio/bob-style/pulls/1100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hibobio/bob-style/pulls/comments/346194074"},"html":{"href":"https://github.com/hibobio/bob-style/pull/1100#discussion_r346194074"},"pull_request":{"href":"https://api.github.com/repos/hibobio/bob-style/pulls/1100"}},"in_reply_to_id":345770311},"pull_request":{"url":"https://api.github.com/repos/hibobio/bob-style/pulls/1100","id":340463439,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQwNDYzNDM5","html_url":"https://github.com/hibobio/bob-style/pull/1100","diff_url":"https://github.com/hibobio/bob-style/pull/1100.diff","patch_url":"https://github.com/hibobio/bob-style/pull/1100.patch","issue_url":"https://api.github.com/repos/hibobio/bob-style/issues/1100","number":1100,"state":"open","locked":false,"title":"Side menu changes","user":{"login":"rinat-shemer","id":20039363,"node_id":"MDQ6VXNlcjIwMDM5MzYz","avatar_url":"https://avatars1.githubusercontent.com/u/20039363?v=4","gravatar_id":"","url":"https://api.github.com/users/rinat-shemer","html_url":"https://github.com/rinat-shemer","followers_url":"https://api.github.com/users/rinat-shemer/followers","following_url":"https://api.github.com/users/rinat-shemer/following{/other_user}","gists_url":"https://api.github.com/users/rinat-shemer/gists{/gist_id}","starred_url":"https://api.github.com/users/rinat-shemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinat-shemer/subscriptions","organizations_url":"https://api.github.com/users/rinat-shemer/orgs","repos_url":"https://api.github.com/users/rinat-shemer/repos","events_url":"https://api.github.com/users/rinat-shemer/events{/privacy}","received_events_url":"https://api.github.com/users/rinat-shemer/received_events","type":"User","site_admin":false},"body":"- add header with label and container for actions\r\n- change the prefix to icon, use normal color as default\r\n- change icon color on select\r\n\r\n* Need to make changes in Bob where using this component (docs)","created_at":"2019-11-13T13:30:01Z","updated_at":"2019-11-14T09:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6008f0f9924349728ab2798328a069a3c496f8f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibobio/bob-style/pulls/1100/commits","review_comments_url":"https://api.github.com/repos/hibobio/bob-style/pulls/1100/comments","review_comment_url":"https://api.github.com/repos/hibobio/bob-style/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibobio/bob-style/issues/1100/comments","statuses_url":"https://api.github.com/repos/hibobio/bob-style/statuses/61f3ec175d348eaa9dc61485cbb5e53f0725da67","head":{"label":"hibobio:rinat/change-side-menu","ref":"rinat/change-side-menu","sha":"61f3ec175d348eaa9dc61485cbb5e53f0725da67","user":{"login":"hibobio","id":13721048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzIxMDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/13721048?v=4","gravatar_id":"","url":"https://api.github.com/users/hibobio","html_url":"https://github.com/hibobio","followers_url":"https://api.github.com/users/hibobio/followers","following_url":"https://api.github.com/users/hibobio/following{/other_user}","gists_url":"https://api.github.com/users/hibobio/gists{/gist_id}","starred_url":"https://api.github.com/users/hibobio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibobio/subscriptions","organizations_url":"https://api.github.com/users/hibobio/orgs","repos_url":"https://api.github.com/users/hibobio/repos","events_url":"https://api.github.com/users/hibobio/events{/privacy}","received_events_url":"https://api.github.com/users/hibobio/received_events","type":"Organization","site_admin":false},"repo":{"id":151245228,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyNDUyMjg=","name":"bob-style","full_name":"hibobio/bob-style","private":false,"owner":{"login":"hibobio","id":13721048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzIxMDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/13721048?v=4","gravatar_id":"","url":"https://api.github.com/users/hibobio","html_url":"https://github.com/hibobio","followers_url":"https://api.github.com/users/hibobio/followers","following_url":"https://api.github.com/users/hibobio/following{/other_user}","gists_url":"https://api.github.com/users/hibobio/gists{/gist_id}","starred_url":"https://api.github.com/users/hibobio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibobio/subscriptions","organizations_url":"https://api.github.com/users/hibobio/orgs","repos_url":"https://api.github.com/users/hibobio/repos","events_url":"https://api.github.com/users/hibobio/events{/privacy}","received_events_url":"https://api.github.com/users/hibobio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hibobio/bob-style","description":"hibob storybook ","fork":false,"url":"https://api.github.com/repos/hibobio/bob-style","forks_url":"https://api.github.com/repos/hibobio/bob-style/forks","keys_url":"https://api.github.com/repos/hibobio/bob-style/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibobio/bob-style/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibobio/bob-style/teams","hooks_url":"https://api.github.com/repos/hibobio/bob-style/hooks","issue_events_url":"https://api.github.com/repos/hibobio/bob-style/issues/events{/number}","events_url":"https://api.github.com/repos/hibobio/bob-style/events","assignees_url":"https://api.github.com/repos/hibobio/bob-style/assignees{/user}","branches_url":"https://api.github.com/repos/hibobio/bob-style/branches{/branch}","tags_url":"https://api.github.com/repos/hibobio/bob-style/tags","blobs_url":"https://api.github.com/repos/hibobio/bob-style/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibobio/bob-style/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibobio/bob-style/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibobio/bob-style/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibobio/bob-style/statuses/{sha}","languages_url":"https://api.github.com/repos/hibobio/bob-style/languages","stargazers_url":"https://api.github.com/repos/hibobio/bob-style/stargazers","contributors_url":"https://api.github.com/repos/hibobio/bob-style/contributors","subscribers_url":"https://api.github.com/repos/hibobio/bob-style/subscribers","subscription_url":"https://api.github.com/repos/hibobio/bob-style/subscription","commits_url":"https://api.github.com/repos/hibobio/bob-style/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibobio/bob-style/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibobio/bob-style/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibobio/bob-style/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibobio/bob-style/contents/{+path}","compare_url":"https://api.github.com/repos/hibobio/bob-style/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibobio/bob-style/merges","archive_url":"https://api.github.com/repos/hibobio/bob-style/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibobio/bob-style/downloads","issues_url":"https://api.github.com/repos/hibobio/bob-style/issues{/number}","pulls_url":"https://api.github.com/repos/hibobio/bob-style/pulls{/number}","milestones_url":"https://api.github.com/repos/hibobio/bob-style/milestones{/number}","notifications_url":"https://api.github.com/repos/hibobio/bob-style/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibobio/bob-style/labels{/name}","releases_url":"https://api.github.com/repos/hibobio/bob-style/releases{/id}","deployments_url":"https://api.github.com/repos/hibobio/bob-style/deployments","created_at":"2018-10-02T11:43:16Z","updated_at":"2019-11-13T16:49:55Z","pushed_at":"2019-11-13T17:56:45Z","git_url":"git://github.com/hibobio/bob-style.git","ssh_url":"git@github.com:hibobio/bob-style.git","clone_url":"https://github.com/hibobio/bob-style.git","svn_url":"https://github.com/hibobio/bob-style","homepage":"https://hibobio.github.io/bob-style/","size":12723,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":null,"forks":0,"open_issues":20,"watchers":3,"default_branch":"master"}},"base":{"label":"hibobio:master","ref":"master","sha":"290a78dd09b82bdd7fd4b183fe36335cc728bd38","user":{"login":"hibobio","id":13721048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzIxMDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/13721048?v=4","gravatar_id":"","url":"https://api.github.com/users/hibobio","html_url":"https://github.com/hibobio","followers_url":"https://api.github.com/users/hibobio/followers","following_url":"https://api.github.com/users/hibobio/following{/other_user}","gists_url":"https://api.github.com/users/hibobio/gists{/gist_id}","starred_url":"https://api.github.com/users/hibobio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibobio/subscriptions","organizations_url":"https://api.github.com/users/hibobio/orgs","repos_url":"https://api.github.com/users/hibobio/repos","events_url":"https://api.github.com/users/hibobio/events{/privacy}","received_events_url":"https://api.github.com/users/hibobio/received_events","type":"Organization","site_admin":false},"repo":{"id":151245228,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyNDUyMjg=","name":"bob-style","full_name":"hibobio/bob-style","private":false,"owner":{"login":"hibobio","id":13721048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzIxMDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/13721048?v=4","gravatar_id":"","url":"https://api.github.com/users/hibobio","html_url":"https://github.com/hibobio","followers_url":"https://api.github.com/users/hibobio/followers","following_url":"https://api.github.com/users/hibobio/following{/other_user}","gists_url":"https://api.github.com/users/hibobio/gists{/gist_id}","starred_url":"https://api.github.com/users/hibobio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibobio/subscriptions","organizations_url":"https://api.github.com/users/hibobio/orgs","repos_url":"https://api.github.com/users/hibobio/repos","events_url":"https://api.github.com/users/hibobio/events{/privacy}","received_events_url":"https://api.github.com/users/hibobio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hibobio/bob-style","description":"hibob storybook ","fork":false,"url":"https://api.github.com/repos/hibobio/bob-style","forks_url":"https://api.github.com/repos/hibobio/bob-style/forks","keys_url":"https://api.github.com/repos/hibobio/bob-style/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibobio/bob-style/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibobio/bob-style/teams","hooks_url":"https://api.github.com/repos/hibobio/bob-style/hooks","issue_events_url":"https://api.github.com/repos/hibobio/bob-style/issues/events{/number}","events_url":"https://api.github.com/repos/hibobio/bob-style/events","assignees_url":"https://api.github.com/repos/hibobio/bob-style/assignees{/user}","branches_url":"https://api.github.com/repos/hibobio/bob-style/branches{/branch}","tags_url":"https://api.github.com/repos/hibobio/bob-style/tags","blobs_url":"https://api.github.com/repos/hibobio/bob-style/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibobio/bob-style/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibobio/bob-style/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibobio/bob-style/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibobio/bob-style/statuses/{sha}","languages_url":"https://api.github.com/repos/hibobio/bob-style/languages","stargazers_url":"https://api.github.com/repos/hibobio/bob-style/stargazers","contributors_url":"https://api.github.com/repos/hibobio/bob-style/contributors","subscribers_url":"https://api.github.com/repos/hibobio/bob-style/subscribers","subscription_url":"https://api.github.com/repos/hibobio/bob-style/subscription","commits_url":"https://api.github.com/repos/hibobio/bob-style/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibobio/bob-style/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibobio/bob-style/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibobio/bob-style/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibobio/bob-style/contents/{+path}","compare_url":"https://api.github.com/repos/hibobio/bob-style/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibobio/bob-style/merges","archive_url":"https://api.github.com/repos/hibobio/bob-style/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibobio/bob-style/downloads","issues_url":"https://api.github.com/repos/hibobio/bob-style/issues{/number}","pulls_url":"https://api.github.com/repos/hibobio/bob-style/pulls{/number}","milestones_url":"https://api.github.com/repos/hibobio/bob-style/milestones{/number}","notifications_url":"https://api.github.com/repos/hibobio/bob-style/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibobio/bob-style/labels{/name}","releases_url":"https://api.github.com/repos/hibobio/bob-style/releases{/id}","deployments_url":"https://api.github.com/repos/hibobio/bob-style/deployments","created_at":"2018-10-02T11:43:16Z","updated_at":"2019-11-13T16:49:55Z","pushed_at":"2019-11-13T17:56:45Z","git_url":"git://github.com/hibobio/bob-style.git","ssh_url":"git@github.com:hibobio/bob-style.git","clone_url":"https://github.com/hibobio/bob-style.git","svn_url":"https://github.com/hibobio/bob-style","homepage":"https://hibobio.github.io/bob-style/","size":12723,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":null,"forks":0,"open_issues":20,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibobio/bob-style/pulls/1100"},"html":{"href":"https://github.com/hibobio/bob-style/pull/1100"},"issue":{"href":"https://api.github.com/repos/hibobio/bob-style/issues/1100"},"comments":{"href":"https://api.github.com/repos/hibobio/bob-style/issues/1100/comments"},"review_comments":{"href":"https://api.github.com/repos/hibobio/bob-style/pulls/1100/comments"},"review_comment":{"href":"https://api.github.com/repos/hibobio/bob-style/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibobio/bob-style/pulls/1100/commits"},"statuses":{"href":"https://api.github.com/repos/hibobio/bob-style/statuses/61f3ec175d348eaa9dc61485cbb5e53f0725da67"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 151245228,
"name": "hibobio/bob-style",
"url": "https://api.github.com/repos/hibobio/bob-style"
}
|
{
"id": 20039363,
"login": "rinat-shemer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20039363?",
"url": "https://api.github.com/users/rinat-shemer"
}
|
{
"id": 13721048,
"login": "hibobio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13721048?",
"url": "https://api.github.com/orgs/hibobio"
}
| 2019-11-14T09:06:47 |
10860456630
|
{"actor":{"display_login":"rinat-shemer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/comments/292020678","pull_request_review_id":247627143,"id":292020678,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MjAyMDY3OA==","diff_hunk":"@@ -61,3 +82,85 @@ void * find_crypto_symbol(void *handle, const char *symname) {\n return symptr;\n }\n \n+/*\n+ * Find path to JRE based on .exe's location\n+ */\n+jboolean\n+GetJREPath(char *path, jint pathsize)","path":"closed/adds/jdk/src/windows/native/jdk/crypto/jniprovider/NativeCrypto_md.c","position":92,"original_position":62,"commit_id":"ac537b50ab4591cc4801c9cf0323a6e4a98d45bf","original_commit_id":"332f59c5002750446dc9155cefbbc2b3dbc20b33","user":{"login":"keithc-ca","id":17774687,"node_id":"MDQ6VXNlcjE3Nzc0Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/17774687?v=4","gravatar_id":"","url":"https://api.github.com/users/keithc-ca","html_url":"https://github.com/keithc-ca","followers_url":"https://api.github.com/users/keithc-ca/followers","following_url":"https://api.github.com/users/keithc-ca/following{/other_user}","gists_url":"https://api.github.com/users/keithc-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/keithc-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithc-ca/subscriptions","organizations_url":"https://api.github.com/users/keithc-ca/orgs","repos_url":"https://api.github.com/users/keithc-ca/repos","events_url":"https://api.github.com/users/keithc-ca/events{/privacy}","received_events_url":"https://api.github.com/users/keithc-ca/received_events","type":"User","site_admin":false},"body":"The top of the file is 'prior' to the Oracle code that was added. I won't push it, but it would eliminate the copyright checker issue.","created_at":"2019-06-10T13:55:06Z","updated_at":"2019-06-10T13:55:06Z","html_url":"https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/312#discussion_r292020678","pull_request_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/312","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/comments/292020678"},"html":{"href":"https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/312#discussion_r292020678"},"pull_request":{"href":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/312"}},"in_reply_to_id":291265828},"pull_request":{"url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/312","id":285806431,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1ODA2NDMx","html_url":"https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/312","diff_url":"https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/312.diff","patch_url":"https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/312.patch","issue_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/issues/312","number":312,"state":"open","locked":false,"title":"WIP: Detect openssl library in jre path","user":{"login":"groeges","id":23166924,"node_id":"MDQ6VXNlcjIzMTY2OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/23166924?v=4","gravatar_id":"","url":"https://api.github.com/users/groeges","html_url":"https://github.com/groeges","followers_url":"https://api.github.com/users/groeges/followers","following_url":"https://api.github.com/users/groeges/following{/other_user}","gists_url":"https://api.github.com/users/groeges/gists{/gist_id}","starred_url":"https://api.github.com/users/groeges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groeges/subscriptions","organizations_url":"https://api.github.com/users/groeges/orgs","repos_url":"https://api.github.com/users/groeges/repos","events_url":"https://api.github.com/users/groeges/events{/privacy}","received_events_url":"https://api.github.com/users/groeges/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Steve Groeger <GROEGES@uk.ibm.com>\r\n\r\nThis issue explains the reason for the modification: https://github.com/eclipse/openj9/issues/5931","created_at":"2019-06-06T13:35:43Z","updated_at":"2019-06-10T13:55:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d77a293398190f9390a11c8bffb32392bd85d1f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/312/commits","review_comments_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/312/comments","review_comment_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/issues/312/comments","statuses_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/statuses/ac537b50ab4591cc4801c9cf0323a6e4a98d45bf","head":{"label":"groeges:openj9-openssl","ref":"openj9-openssl","sha":"ac537b50ab4591cc4801c9cf0323a6e4a98d45bf","user":{"login":"groeges","id":23166924,"node_id":"MDQ6VXNlcjIzMTY2OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/23166924?v=4","gravatar_id":"","url":"https://api.github.com/users/groeges","html_url":"https://github.com/groeges","followers_url":"https://api.github.com/users/groeges/followers","following_url":"https://api.github.com/users/groeges/following{/other_user}","gists_url":"https://api.github.com/users/groeges/gists{/gist_id}","starred_url":"https://api.github.com/users/groeges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groeges/subscriptions","organizations_url":"https://api.github.com/users/groeges/orgs","repos_url":"https://api.github.com/users/groeges/repos","events_url":"https://api.github.com/users/groeges/events{/privacy}","received_events_url":"https://api.github.com/users/groeges/received_events","type":"User","site_admin":false},"repo":{"id":112332141,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzMzIxNDE=","name":"openj9-openjdk-jdk8","full_name":"groeges/openj9-openjdk-jdk8","private":false,"owner":{"login":"groeges","id":23166924,"node_id":"MDQ6VXNlcjIzMTY2OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/23166924?v=4","gravatar_id":"","url":"https://api.github.com/users/groeges","html_url":"https://github.com/groeges","followers_url":"https://api.github.com/users/groeges/followers","following_url":"https://api.github.com/users/groeges/following{/other_user}","gists_url":"https://api.github.com/users/groeges/gists{/gist_id}","starred_url":"https://api.github.com/users/groeges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groeges/subscriptions","organizations_url":"https://api.github.com/users/groeges/orgs","repos_url":"https://api.github.com/users/groeges/repos","events_url":"https://api.github.com/users/groeges/events{/privacy}","received_events_url":"https://api.github.com/users/groeges/received_events","type":"User","site_admin":false},"html_url":"https://github.com/groeges/openj9-openjdk-jdk8","description":"Extensions for OpenJDK8 for Eclipse OpenJ9 ","fork":true,"url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8","forks_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/forks","keys_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/teams","hooks_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/hooks","issue_events_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/issues/events{/number}","events_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/events","assignees_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/assignees{/user}","branches_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/branches{/branch}","tags_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/tags","blobs_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/git/refs{/sha}","trees_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/statuses/{sha}","languages_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/languages","stargazers_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/stargazers","contributors_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/contributors","subscribers_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/subscribers","subscription_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/subscription","commits_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/commits{/sha}","git_commits_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/git/commits{/sha}","comments_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/comments{/number}","issue_comment_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/issues/comments{/number}","contents_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/contents/{+path}","compare_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/merges","archive_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/downloads","issues_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/issues{/number}","pulls_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/pulls{/number}","milestones_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/milestones{/number}","notifications_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/labels{/name}","releases_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/releases{/id}","deployments_url":"https://api.github.com/repos/groeges/openj9-openjdk-jdk8/deployments","created_at":"2017-11-28T12:25:05Z","updated_at":"2019-05-31T12:56:13Z","pushed_at":"2019-06-10T12:42:52Z","git_url":"git://github.com/groeges/openj9-openjdk-jdk8.git","ssh_url":"git@github.com:groeges/openj9-openjdk-jdk8.git","clone_url":"https://github.com/groeges/openj9-openjdk-jdk8.git","svn_url":"https://github.com/groeges/openj9-openjdk-jdk8","homepage":null,"size":568249,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"openj9"}},"base":{"label":"ibmruntimes:openj9","ref":"openj9","sha":"54d17fa253ca62b7a2ee0107f1c2a2c18a3cbae3","user":{"login":"ibmruntimes","id":13797644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzk3NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/13797644?v=4","gravatar_id":"","url":"https://api.github.com/users/ibmruntimes","html_url":"https://github.com/ibmruntimes","followers_url":"https://api.github.com/users/ibmruntimes/followers","following_url":"https://api.github.com/users/ibmruntimes/following{/other_user}","gists_url":"https://api.github.com/users/ibmruntimes/gists{/gist_id}","starred_url":"https://api.github.com/users/ibmruntimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibmruntimes/subscriptions","organizations_url":"https://api.github.com/users/ibmruntimes/orgs","repos_url":"https://api.github.com/users/ibmruntimes/repos","events_url":"https://api.github.com/users/ibmruntimes/events{/privacy}","received_events_url":"https://api.github.com/users/ibmruntimes/received_events","type":"Organization","site_admin":false},"repo":{"id":111414625,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0MTQ2MjU=","name":"openj9-openjdk-jdk8","full_name":"ibmruntimes/openj9-openjdk-jdk8","private":false,"owner":{"login":"ibmruntimes","id":13797644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzk3NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/13797644?v=4","gravatar_id":"","url":"https://api.github.com/users/ibmruntimes","html_url":"https://github.com/ibmruntimes","followers_url":"https://api.github.com/users/ibmruntimes/followers","following_url":"https://api.github.com/users/ibmruntimes/following{/other_user}","gists_url":"https://api.github.com/users/ibmruntimes/gists{/gist_id}","starred_url":"https://api.github.com/users/ibmruntimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibmruntimes/subscriptions","organizations_url":"https://api.github.com/users/ibmruntimes/orgs","repos_url":"https://api.github.com/users/ibmruntimes/repos","events_url":"https://api.github.com/users/ibmruntimes/events{/privacy}","received_events_url":"https://api.github.com/users/ibmruntimes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ibmruntimes/openj9-openjdk-jdk8","description":"Extensions for OpenJDK8 for Eclipse OpenJ9 ","fork":false,"url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8","forks_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/forks","keys_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/teams","hooks_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/hooks","issue_events_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/issues/events{/number}","events_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/events","assignees_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/assignees{/user}","branches_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/branches{/branch}","tags_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/tags","blobs_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/statuses/{sha}","languages_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/languages","stargazers_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/stargazers","contributors_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/contributors","subscribers_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/subscribers","subscription_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/subscription","commits_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/contents/{+path}","compare_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/merges","archive_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/downloads","issues_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/issues{/number}","pulls_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls{/number}","milestones_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/milestones{/number}","notifications_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/labels{/name}","releases_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/releases{/id}","deployments_url":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/deployments","created_at":"2017-11-20T13:34:53Z","updated_at":"2019-06-07T10:03:31Z","pushed_at":"2019-06-10T12:42:53Z","git_url":"git://github.com/ibmruntimes/openj9-openjdk-jdk8.git","ssh_url":"git@github.com:ibmruntimes/openj9-openjdk-jdk8.git","clone_url":"https://github.com/ibmruntimes/openj9-openjdk-jdk8.git","svn_url":"https://github.com/ibmruntimes/openj9-openjdk-jdk8","homepage":null,"size":568937,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":60,"open_issues":19,"watchers":25,"default_branch":"openj9"}},"_links":{"self":{"href":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/312"},"html":{"href":"https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/312"},"issue":{"href":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/issues/312"},"comments":{"href":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/issues/312/comments"},"review_comments":{"href":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/312/comments"},"review_comment":{"href":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/pulls/312/commits"},"statuses":{"href":"https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8/statuses/ac537b50ab4591cc4801c9cf0323a6e4a98d45bf"}},"author_association":"MEMBER"}}
|
{
"id": 111414625,
"name": "ibmruntimes/openj9-openjdk-jdk8",
"url": "https://api.github.com/repos/ibmruntimes/openj9-openjdk-jdk8"
}
|
{
"id": 17774687,
"login": "keithc-ca",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17774687?",
"url": "https://api.github.com/users/keithc-ca"
}
|
{
"id": 13797644,
"login": "ibmruntimes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13797644?",
"url": "https://api.github.com/orgs/ibmruntimes"
}
| 2019-06-10T13:55:06 |
9790914928
|
{"actor":{"display_login":"keithc-ca"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/comments/284046345","pull_request_review_id":237553559,"id":284046345,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDA0NjM0NQ==","diff_hunk":"@@ -120,20 +121,22 @@ func (p *proposals) Done(key string, err error) {\n \tpd.Ch <- err\n }\n \n-func (w *RaftServer) GetNode() *Node {\n+func (w *RaftServer) getNode() *Node {\n \tw.nodeLock.RLock()\n \tdefer w.nodeLock.RUnlock()\n \treturn w.Node\n }\n \n+// RaftServer stores a RAFT node along with a lock.\n type RaftServer struct {\n \tnodeLock sync.RWMutex // protects Node.","path":"conn/raft_server.go","position":21,"original_position":21,"commit_id":"68edf32029d6b13c989b175abbd84b6fe98b1596","original_commit_id":"68edf32029d6b13c989b175abbd84b6fe98b1596","user":{"login":"campoy","id":2237452,"node_id":"MDQ6VXNlcjIyMzc0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2237452?v=4","gravatar_id":"","url":"https://api.github.com/users/campoy","html_url":"https://github.com/campoy","followers_url":"https://api.github.com/users/campoy/followers","following_url":"https://api.github.com/users/campoy/following{/other_user}","gists_url":"https://api.github.com/users/campoy/gists{/gist_id}","starred_url":"https://api.github.com/users/campoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campoy/subscriptions","organizations_url":"https://api.github.com/users/campoy/orgs","repos_url":"https://api.github.com/users/campoy/repos","events_url":"https://api.github.com/users/campoy/events{/privacy}","received_events_url":"https://api.github.com/users/campoy/received_events","type":"User","site_admin":false},"body":"rename `nodeLock` to `lock` or simply `m`","created_at":"2019-05-15T00:09:10Z","updated_at":"2019-05-15T00:13:27Z","html_url":"https://github.com/dgraph-io/dgraph/pull/3413#discussion_r284046345","pull_request_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/3413","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/comments/284046345"},"html":{"href":"https://github.com/dgraph-io/dgraph/pull/3413#discussion_r284046345"},"pull_request":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/3413"}}},"pull_request":{"url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/3413","id":278817480,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4ODE3NDgw","html_url":"https://github.com/dgraph-io/dgraph/pull/3413","diff_url":"https://github.com/dgraph-io/dgraph/pull/3413.diff","patch_url":"https://github.com/dgraph-io/dgraph/pull/3413.patch","issue_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/3413","number":3413,"state":"open","locked":false,"title":"Fix golint warnings in package conn.","user":{"login":"martinmr","id":419668,"node_id":"MDQ6VXNlcjQxOTY2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/419668?v=4","gravatar_id":"","url":"https://api.github.com/users/martinmr","html_url":"https://github.com/martinmr","followers_url":"https://api.github.com/users/martinmr/followers","following_url":"https://api.github.com/users/martinmr/following{/other_user}","gists_url":"https://api.github.com/users/martinmr/gists{/gist_id}","starred_url":"https://api.github.com/users/martinmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinmr/subscriptions","organizations_url":"https://api.github.com/users/martinmr/orgs","repos_url":"https://api.github.com/users/martinmr/repos","events_url":"https://api.github.com/users/martinmr/events{/privacy}","received_events_url":"https://api.github.com/users/martinmr/received_events","type":"User","site_admin":false},"body":"- Unexport some variables and types that were not needed outside the\r\npackage.\r\n- Add doc comments to exported types and vars.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dgraph-io/dgraph/3413)\n<!-- Reviewable:end -->\n","created_at":"2019-05-14T19:21:30Z","updated_at":"2019-05-15T00:13:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03847d4523d10d48e88afbd63c7e14a42a8f3435","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielmai","id":2251820,"node_id":"MDQ6VXNlcjIyNTE4MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2251820?v=4","gravatar_id":"","url":"https://api.github.com/users/danielmai","html_url":"https://github.com/danielmai","followers_url":"https://api.github.com/users/danielmai/followers","following_url":"https://api.github.com/users/danielmai/following{/other_user}","gists_url":"https://api.github.com/users/danielmai/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmai/subscriptions","organizations_url":"https://api.github.com/users/danielmai/orgs","repos_url":"https://api.github.com/users/danielmai/repos","events_url":"https://api.github.com/users/danielmai/events{/privacy}","received_events_url":"https://api.github.com/users/danielmai/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/3413/commits","review_comments_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/3413/comments","review_comment_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/3413/comments","statuses_url":"https://api.github.com/repos/dgraph-io/dgraph/statuses/68edf32029d6b13c989b175abbd84b6fe98b1596","head":{"label":"dgraph-io:martinmr/golint-conn","ref":"martinmr/golint-conn","sha":"68edf32029d6b13c989b175abbd84b6fe98b1596","user":{"login":"dgraph-io","id":13958706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTU4NzA2","avatar_url":"https://avatars0.githubusercontent.com/u/13958706?v=4","gravatar_id":"","url":"https://api.github.com/users/dgraph-io","html_url":"https://github.com/dgraph-io","followers_url":"https://api.github.com/users/dgraph-io/followers","following_url":"https://api.github.com/users/dgraph-io/following{/other_user}","gists_url":"https://api.github.com/users/dgraph-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dgraph-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgraph-io/subscriptions","organizations_url":"https://api.github.com/users/dgraph-io/orgs","repos_url":"https://api.github.com/users/dgraph-io/repos","events_url":"https://api.github.com/users/dgraph-io/events{/privacy}","received_events_url":"https://api.github.com/users/dgraph-io/received_events","type":"Organization","site_admin":false},"repo":{"id":41349039,"node_id":"MDEwOlJlcG9zaXRvcnk0MTM0OTAzOQ==","name":"dgraph","full_name":"dgraph-io/dgraph","private":false,"owner":{"login":"dgraph-io","id":13958706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTU4NzA2","avatar_url":"https://avatars0.githubusercontent.com/u/13958706?v=4","gravatar_id":"","url":"https://api.github.com/users/dgraph-io","html_url":"https://github.com/dgraph-io","followers_url":"https://api.github.com/users/dgraph-io/followers","following_url":"https://api.github.com/users/dgraph-io/following{/other_user}","gists_url":"https://api.github.com/users/dgraph-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dgraph-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgraph-io/subscriptions","organizations_url":"https://api.github.com/users/dgraph-io/orgs","repos_url":"https://api.github.com/users/dgraph-io/repos","events_url":"https://api.github.com/users/dgraph-io/events{/privacy}","received_events_url":"https://api.github.com/users/dgraph-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dgraph-io/dgraph","description":"Fast, Distributed Graph DB","fork":false,"url":"https://api.github.com/repos/dgraph-io/dgraph","forks_url":"https://api.github.com/repos/dgraph-io/dgraph/forks","keys_url":"https://api.github.com/repos/dgraph-io/dgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgraph-io/dgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgraph-io/dgraph/teams","hooks_url":"https://api.github.com/repos/dgraph-io/dgraph/hooks","issue_events_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/events{/number}","events_url":"https://api.github.com/repos/dgraph-io/dgraph/events","assignees_url":"https://api.github.com/repos/dgraph-io/dgraph/assignees{/user}","branches_url":"https://api.github.com/repos/dgraph-io/dgraph/branches{/branch}","tags_url":"https://api.github.com/repos/dgraph-io/dgraph/tags","blobs_url":"https://api.github.com/repos/dgraph-io/dgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgraph-io/dgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgraph-io/dgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgraph-io/dgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgraph-io/dgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/dgraph-io/dgraph/languages","stargazers_url":"https://api.github.com/repos/dgraph-io/dgraph/stargazers","contributors_url":"https://api.github.com/repos/dgraph-io/dgraph/contributors","subscribers_url":"https://api.github.com/repos/dgraph-io/dgraph/subscribers","subscription_url":"https://api.github.com/repos/dgraph-io/dgraph/subscription","commits_url":"https://api.github.com/repos/dgraph-io/dgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgraph-io/dgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgraph-io/dgraph/contents/{+path}","compare_url":"https://api.github.com/repos/dgraph-io/dgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgraph-io/dgraph/merges","archive_url":"https://api.github.com/repos/dgraph-io/dgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgraph-io/dgraph/downloads","issues_url":"https://api.github.com/repos/dgraph-io/dgraph/issues{/number}","pulls_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/dgraph-io/dgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/dgraph-io/dgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgraph-io/dgraph/labels{/name}","releases_url":"https://api.github.com/repos/dgraph-io/dgraph/releases{/id}","deployments_url":"https://api.github.com/repos/dgraph-io/dgraph/deployments","created_at":"2015-08-25T07:15:56Z","updated_at":"2019-05-14T23:17:29Z","pushed_at":"2019-05-14T23:52:23Z","git_url":"git://github.com/dgraph-io/dgraph.git","ssh_url":"git@github.com:dgraph-io/dgraph.git","clone_url":"https://github.com/dgraph-io/dgraph.git","svn_url":"https://github.com/dgraph-io/dgraph","homepage":"https://dgraph.io","size":245117,"stargazers_count":9538,"watchers_count":9538,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":655,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":141,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":655,"open_issues":141,"watchers":9538,"default_branch":"master"}},"base":{"label":"dgraph-io:master","ref":"master","sha":"b36f402ad1986016c9eff8fdb41ea82f37737b47","user":{"login":"dgraph-io","id":13958706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTU4NzA2","avatar_url":"https://avatars0.githubusercontent.com/u/13958706?v=4","gravatar_id":"","url":"https://api.github.com/users/dgraph-io","html_url":"https://github.com/dgraph-io","followers_url":"https://api.github.com/users/dgraph-io/followers","following_url":"https://api.github.com/users/dgraph-io/following{/other_user}","gists_url":"https://api.github.com/users/dgraph-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dgraph-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgraph-io/subscriptions","organizations_url":"https://api.github.com/users/dgraph-io/orgs","repos_url":"https://api.github.com/users/dgraph-io/repos","events_url":"https://api.github.com/users/dgraph-io/events{/privacy}","received_events_url":"https://api.github.com/users/dgraph-io/received_events","type":"Organization","site_admin":false},"repo":{"id":41349039,"node_id":"MDEwOlJlcG9zaXRvcnk0MTM0OTAzOQ==","name":"dgraph","full_name":"dgraph-io/dgraph","private":false,"owner":{"login":"dgraph-io","id":13958706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTU4NzA2","avatar_url":"https://avatars0.githubusercontent.com/u/13958706?v=4","gravatar_id":"","url":"https://api.github.com/users/dgraph-io","html_url":"https://github.com/dgraph-io","followers_url":"https://api.github.com/users/dgraph-io/followers","following_url":"https://api.github.com/users/dgraph-io/following{/other_user}","gists_url":"https://api.github.com/users/dgraph-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dgraph-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgraph-io/subscriptions","organizations_url":"https://api.github.com/users/dgraph-io/orgs","repos_url":"https://api.github.com/users/dgraph-io/repos","events_url":"https://api.github.com/users/dgraph-io/events{/privacy}","received_events_url":"https://api.github.com/users/dgraph-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dgraph-io/dgraph","description":"Fast, Distributed Graph DB","fork":false,"url":"https://api.github.com/repos/dgraph-io/dgraph","forks_url":"https://api.github.com/repos/dgraph-io/dgraph/forks","keys_url":"https://api.github.com/repos/dgraph-io/dgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgraph-io/dgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgraph-io/dgraph/teams","hooks_url":"https://api.github.com/repos/dgraph-io/dgraph/hooks","issue_events_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/events{/number}","events_url":"https://api.github.com/repos/dgraph-io/dgraph/events","assignees_url":"https://api.github.com/repos/dgraph-io/dgraph/assignees{/user}","branches_url":"https://api.github.com/repos/dgraph-io/dgraph/branches{/branch}","tags_url":"https://api.github.com/repos/dgraph-io/dgraph/tags","blobs_url":"https://api.github.com/repos/dgraph-io/dgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgraph-io/dgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgraph-io/dgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgraph-io/dgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgraph-io/dgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/dgraph-io/dgraph/languages","stargazers_url":"https://api.github.com/repos/dgraph-io/dgraph/stargazers","contributors_url":"https://api.github.com/repos/dgraph-io/dgraph/contributors","subscribers_url":"https://api.github.com/repos/dgraph-io/dgraph/subscribers","subscription_url":"https://api.github.com/repos/dgraph-io/dgraph/subscription","commits_url":"https://api.github.com/repos/dgraph-io/dgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgraph-io/dgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgraph-io/dgraph/contents/{+path}","compare_url":"https://api.github.com/repos/dgraph-io/dgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgraph-io/dgraph/merges","archive_url":"https://api.github.com/repos/dgraph-io/dgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgraph-io/dgraph/downloads","issues_url":"https://api.github.com/repos/dgraph-io/dgraph/issues{/number}","pulls_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/dgraph-io/dgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/dgraph-io/dgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgraph-io/dgraph/labels{/name}","releases_url":"https://api.github.com/repos/dgraph-io/dgraph/releases{/id}","deployments_url":"https://api.github.com/repos/dgraph-io/dgraph/deployments","created_at":"2015-08-25T07:15:56Z","updated_at":"2019-05-14T23:17:29Z","pushed_at":"2019-05-14T23:52:23Z","git_url":"git://github.com/dgraph-io/dgraph.git","ssh_url":"git@github.com:dgraph-io/dgraph.git","clone_url":"https://github.com/dgraph-io/dgraph.git","svn_url":"https://github.com/dgraph-io/dgraph","homepage":"https://dgraph.io","size":245117,"stargazers_count":9538,"watchers_count":9538,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":655,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":141,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":655,"open_issues":141,"watchers":9538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/3413"},"html":{"href":"https://github.com/dgraph-io/dgraph/pull/3413"},"issue":{"href":"https://api.github.com/repos/dgraph-io/dgraph/issues/3413"},"comments":{"href":"https://api.github.com/repos/dgraph-io/dgraph/issues/3413/comments"},"review_comments":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/3413/comments"},"review_comment":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/3413/commits"},"statuses":{"href":"https://api.github.com/repos/dgraph-io/dgraph/statuses/68edf32029d6b13c989b175abbd84b6fe98b1596"}},"author_association":"MEMBER"}}
|
{
"id": 41349039,
"name": "dgraph-io/dgraph",
"url": "https://api.github.com/repos/dgraph-io/dgraph"
}
|
{
"id": 2237452,
"login": "campoy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2237452?",
"url": "https://api.github.com/users/campoy"
}
|
{
"id": 13958706,
"login": "dgraph-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13958706?",
"url": "https://api.github.com/orgs/dgraph-io"
}
| 2019-05-15T00:09:10 |
9626878987
|
{"actor":{"display_login":"campoy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/comments/293762331","pull_request_review_id":249841604,"id":293762331,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5Mzc2MjMzMQ==","diff_hunk":"@@ -576,14 +577,51 @@ def test_directory_origin_configuration_max_object_length_in_chars(sdc_builder,\n \n \n @pytest.mark.parametrize('data_format', ['DELIMITED'])\n-@pytest.mark.skip('Not yet implemented')\n-def test_directory_origin_configuration_max_record_length_in_chars(sdc_builder, sdc_executor, data_format):\n- pass\n+@pytest.mark.parametrize('max_record_length_in_chars', [20, 23, 30])\n+def test_directory_origin_configuration_max_record_length_in_chars_delimited(sdc_builder, sdc_executor, data_format,\n+ max_record_length_in_chars, file_writer, shell_executor):\n+\n+ \"\"\"\n+ Case 1: Record length > max_record_length | Expected outcome --> Record to error\n+ Case 2: Record length = max_record_length | Expected outcome --> Record processed\n+ Case 3: Record length < max_record_length | Expected outcome --> Record processed\n+ \"\"\"\n+ files_directory = os.path.join('/tmp', get_random_string())\n+ file_name = f'{get_random_string()}.txt'\n+ file_path = os.path.join(files_directory, file_name)\n+ file_contents = 'Field11,Field12,Field13'\n+ try:\n+ shell_executor(f'mkdir {files_directory}')\n+ file_writer(file_path, file_contents)\n+\n+ pipeline_builder = sdc_builder.get_pipeline_builder()\n+ directory = pipeline_builder.add_stage('Directory')\n+ directory.set_attributes(max_record_length_in_chars=max_record_length_in_chars,\n+ data_format=data_format,\n+ files_directory=files_directory,\n+ file_name_pattern=file_name)\n+ trash = pipeline_builder.add_stage('Trash')\n+ directory >> trash\n+ pipeline = pipeline_builder.build()\n+\n+ sdc_executor.add_pipeline(pipeline)\n+ snapshot = sdc_executor.capture_snapshot(pipeline, start_pipeline=True).snapshot\n+ output_records = snapshot[directory.instance_name].output\n+\n+ if max_record_length_in_chars == 20:\n+ assert not snapshot[directory].output\n+ else:\n+ assert output_records[0].get_field_data('/0') == 'Field11'","path":"stage/configuration/test_directory_origin.py","position":49,"original_position":49,"commit_id":"2f830160a56568ab05199ef08836c894dbac92e7","original_commit_id":"2f830160a56568ab05199ef08836c894dbac92e7","user":{"login":"shravantal","id":49744401,"node_id":"MDQ6VXNlcjQ5NzQ0NDAx","avatar_url":"https://avatars2.githubusercontent.com/u/49744401?v=4","gravatar_id":"","url":"https://api.github.com/users/shravantal","html_url":"https://github.com/shravantal","followers_url":"https://api.github.com/users/shravantal/followers","following_url":"https://api.github.com/users/shravantal/following{/other_user}","gists_url":"https://api.github.com/users/shravantal/gists{/gist_id}","starred_url":"https://api.github.com/users/shravantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shravantal/subscriptions","organizations_url":"https://api.github.com/users/shravantal/orgs","repos_url":"https://api.github.com/users/shravantal/repos","events_url":"https://api.github.com/users/shravantal/events{/privacy}","received_events_url":"https://api.github.com/users/shravantal/received_events","type":"User","site_admin":false},"body":"done","created_at":"2019-06-14T11:06:08Z","updated_at":"2019-06-14T11:06:08Z","html_url":"https://github.com/streamsets/datacollector-tests/pull/21#discussion_r293762331","pull_request_url":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/21","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/comments/293762331"},"html":{"href":"https://github.com/streamsets/datacollector-tests/pull/21#discussion_r293762331"},"pull_request":{"href":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/21"}},"in_reply_to_id":293633650},"pull_request":{"url":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/21","id":279405553,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5NDA1NTUz","html_url":"https://github.com/streamsets/datacollector-tests/pull/21","diff_url":"https://github.com/streamsets/datacollector-tests/pull/21.diff","patch_url":"https://github.com/streamsets/datacollector-tests/pull/21.patch","issue_url":"https://api.github.com/repos/streamsets/datacollector-tests/issues/21","number":21,"state":"open","locked":false,"title":"Sdc 11540","user":{"login":"shravantal","id":49744401,"node_id":"MDQ6VXNlcjQ5NzQ0NDAx","avatar_url":"https://avatars2.githubusercontent.com/u/49744401?v=4","gravatar_id":"","url":"https://api.github.com/users/shravantal","html_url":"https://github.com/shravantal","followers_url":"https://api.github.com/users/shravantal/followers","following_url":"https://api.github.com/users/shravantal/following{/other_user}","gists_url":"https://api.github.com/users/shravantal/gists{/gist_id}","starred_url":"https://api.github.com/users/shravantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shravantal/subscriptions","organizations_url":"https://api.github.com/users/shravantal/orgs","repos_url":"https://api.github.com/users/shravantal/repos","events_url":"https://api.github.com/users/shravantal/events{/privacy}","received_events_url":"https://api.github.com/users/shravantal/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-16T08:48:04Z","updated_at":"2019-06-14T11:06:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/21/commits","review_comments_url":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/21/comments","review_comment_url":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/streamsets/datacollector-tests/issues/21/comments","statuses_url":"https://api.github.com/repos/streamsets/datacollector-tests/statuses/2f830160a56568ab05199ef08836c894dbac92e7","head":{"label":"anubandhan:SDC-11540","ref":"SDC-11540","sha":"2f830160a56568ab05199ef08836c894dbac92e7","user":{"login":"anubandhan","id":12196743,"node_id":"MDQ6VXNlcjEyMTk2NzQz","avatar_url":"https://avatars0.githubusercontent.com/u/12196743?v=4","gravatar_id":"","url":"https://api.github.com/users/anubandhan","html_url":"https://github.com/anubandhan","followers_url":"https://api.github.com/users/anubandhan/followers","following_url":"https://api.github.com/users/anubandhan/following{/other_user}","gists_url":"https://api.github.com/users/anubandhan/gists{/gist_id}","starred_url":"https://api.github.com/users/anubandhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anubandhan/subscriptions","organizations_url":"https://api.github.com/users/anubandhan/orgs","repos_url":"https://api.github.com/users/anubandhan/repos","events_url":"https://api.github.com/users/anubandhan/events{/privacy}","received_events_url":"https://api.github.com/users/anubandhan/received_events","type":"User","site_admin":false},"repo":{"id":182205236,"node_id":"MDEwOlJlcG9zaXRvcnkxODIyMDUyMzY=","name":"datacollector-tests","full_name":"anubandhan/datacollector-tests","private":false,"owner":{"login":"anubandhan","id":12196743,"node_id":"MDQ6VXNlcjEyMTk2NzQz","avatar_url":"https://avatars0.githubusercontent.com/u/12196743?v=4","gravatar_id":"","url":"https://api.github.com/users/anubandhan","html_url":"https://github.com/anubandhan","followers_url":"https://api.github.com/users/anubandhan/followers","following_url":"https://api.github.com/users/anubandhan/following{/other_user}","gists_url":"https://api.github.com/users/anubandhan/gists{/gist_id}","starred_url":"https://api.github.com/users/anubandhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anubandhan/subscriptions","organizations_url":"https://api.github.com/users/anubandhan/orgs","repos_url":"https://api.github.com/users/anubandhan/repos","events_url":"https://api.github.com/users/anubandhan/events{/privacy}","received_events_url":"https://api.github.com/users/anubandhan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anubandhan/datacollector-tests","description":"StreamSets Test Framework-based tests for StreamSets Data Collector","fork":true,"url":"https://api.github.com/repos/anubandhan/datacollector-tests","forks_url":"https://api.github.com/repos/anubandhan/datacollector-tests/forks","keys_url":"https://api.github.com/repos/anubandhan/datacollector-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anubandhan/datacollector-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anubandhan/datacollector-tests/teams","hooks_url":"https://api.github.com/repos/anubandhan/datacollector-tests/hooks","issue_events_url":"https://api.github.com/repos/anubandhan/datacollector-tests/issues/events{/number}","events_url":"https://api.github.com/repos/anubandhan/datacollector-tests/events","assignees_url":"https://api.github.com/repos/anubandhan/datacollector-tests/assignees{/user}","branches_url":"https://api.github.com/repos/anubandhan/datacollector-tests/branches{/branch}","tags_url":"https://api.github.com/repos/anubandhan/datacollector-tests/tags","blobs_url":"https://api.github.com/repos/anubandhan/datacollector-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anubandhan/datacollector-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anubandhan/datacollector-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/anubandhan/datacollector-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anubandhan/datacollector-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/anubandhan/datacollector-tests/languages","stargazers_url":"https://api.github.com/repos/anubandhan/datacollector-tests/stargazers","contributors_url":"https://api.github.com/repos/anubandhan/datacollector-tests/contributors","subscribers_url":"https://api.github.com/repos/anubandhan/datacollector-tests/subscribers","subscription_url":"https://api.github.com/repos/anubandhan/datacollector-tests/subscription","commits_url":"https://api.github.com/repos/anubandhan/datacollector-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/anubandhan/datacollector-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/anubandhan/datacollector-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/anubandhan/datacollector-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/anubandhan/datacollector-tests/contents/{+path}","compare_url":"https://api.github.com/repos/anubandhan/datacollector-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anubandhan/datacollector-tests/merges","archive_url":"https://api.github.com/repos/anubandhan/datacollector-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anubandhan/datacollector-tests/downloads","issues_url":"https://api.github.com/repos/anubandhan/datacollector-tests/issues{/number}","pulls_url":"https://api.github.com/repos/anubandhan/datacollector-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/anubandhan/datacollector-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/anubandhan/datacollector-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anubandhan/datacollector-tests/labels{/name}","releases_url":"https://api.github.com/repos/anubandhan/datacollector-tests/releases{/id}","deployments_url":"https://api.github.com/repos/anubandhan/datacollector-tests/deployments","created_at":"2019-04-19T05:10:22Z","updated_at":"2019-06-13T06:37:18Z","pushed_at":"2019-06-14T10:21:47Z","git_url":"git://github.com/anubandhan/datacollector-tests.git","ssh_url":"git@github.com:anubandhan/datacollector-tests.git","clone_url":"https://github.com/anubandhan/datacollector-tests.git","svn_url":"https://github.com/anubandhan/datacollector-tests","homepage":"","size":1855,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"streamsets:master","ref":"master","sha":"08458ba94c265e27c9d322db19ff8f6c12d1ddd9","user":{"login":"streamsets","id":14020362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIwMzYy","avatar_url":"https://avatars3.githubusercontent.com/u/14020362?v=4","gravatar_id":"","url":"https://api.github.com/users/streamsets","html_url":"https://github.com/streamsets","followers_url":"https://api.github.com/users/streamsets/followers","following_url":"https://api.github.com/users/streamsets/following{/other_user}","gists_url":"https://api.github.com/users/streamsets/gists{/gist_id}","starred_url":"https://api.github.com/users/streamsets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamsets/subscriptions","organizations_url":"https://api.github.com/users/streamsets/orgs","repos_url":"https://api.github.com/users/streamsets/repos","events_url":"https://api.github.com/users/streamsets/events{/privacy}","received_events_url":"https://api.github.com/users/streamsets/received_events","type":"Organization","site_admin":false},"repo":{"id":75122350,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEyMjM1MA==","name":"datacollector-tests","full_name":"streamsets/datacollector-tests","private":false,"owner":{"login":"streamsets","id":14020362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIwMzYy","avatar_url":"https://avatars3.githubusercontent.com/u/14020362?v=4","gravatar_id":"","url":"https://api.github.com/users/streamsets","html_url":"https://github.com/streamsets","followers_url":"https://api.github.com/users/streamsets/followers","following_url":"https://api.github.com/users/streamsets/following{/other_user}","gists_url":"https://api.github.com/users/streamsets/gists{/gist_id}","starred_url":"https://api.github.com/users/streamsets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamsets/subscriptions","organizations_url":"https://api.github.com/users/streamsets/orgs","repos_url":"https://api.github.com/users/streamsets/repos","events_url":"https://api.github.com/users/streamsets/events{/privacy}","received_events_url":"https://api.github.com/users/streamsets/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/streamsets/datacollector-tests","description":"StreamSets Test Framework-based tests for StreamSets Data Collector","fork":false,"url":"https://api.github.com/repos/streamsets/datacollector-tests","forks_url":"https://api.github.com/repos/streamsets/datacollector-tests/forks","keys_url":"https://api.github.com/repos/streamsets/datacollector-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/streamsets/datacollector-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/streamsets/datacollector-tests/teams","hooks_url":"https://api.github.com/repos/streamsets/datacollector-tests/hooks","issue_events_url":"https://api.github.com/repos/streamsets/datacollector-tests/issues/events{/number}","events_url":"https://api.github.com/repos/streamsets/datacollector-tests/events","assignees_url":"https://api.github.com/repos/streamsets/datacollector-tests/assignees{/user}","branches_url":"https://api.github.com/repos/streamsets/datacollector-tests/branches{/branch}","tags_url":"https://api.github.com/repos/streamsets/datacollector-tests/tags","blobs_url":"https://api.github.com/repos/streamsets/datacollector-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/streamsets/datacollector-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/streamsets/datacollector-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/streamsets/datacollector-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/streamsets/datacollector-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/streamsets/datacollector-tests/languages","stargazers_url":"https://api.github.com/repos/streamsets/datacollector-tests/stargazers","contributors_url":"https://api.github.com/repos/streamsets/datacollector-tests/contributors","subscribers_url":"https://api.github.com/repos/streamsets/datacollector-tests/subscribers","subscription_url":"https://api.github.com/repos/streamsets/datacollector-tests/subscription","commits_url":"https://api.github.com/repos/streamsets/datacollector-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/streamsets/datacollector-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/streamsets/datacollector-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/streamsets/datacollector-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/streamsets/datacollector-tests/contents/{+path}","compare_url":"https://api.github.com/repos/streamsets/datacollector-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/streamsets/datacollector-tests/merges","archive_url":"https://api.github.com/repos/streamsets/datacollector-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/streamsets/datacollector-tests/downloads","issues_url":"https://api.github.com/repos/streamsets/datacollector-tests/issues{/number}","pulls_url":"https://api.github.com/repos/streamsets/datacollector-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/streamsets/datacollector-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/streamsets/datacollector-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/streamsets/datacollector-tests/labels{/name}","releases_url":"https://api.github.com/repos/streamsets/datacollector-tests/releases{/id}","deployments_url":"https://api.github.com/repos/streamsets/datacollector-tests/deployments","created_at":"2016-11-29T21:10:17Z","updated_at":"2019-06-13T21:33:03Z","pushed_at":"2019-06-14T10:20:26Z","git_url":"git://github.com/streamsets/datacollector-tests.git","ssh_url":"git@github.com:streamsets/datacollector-tests.git","clone_url":"https://github.com/streamsets/datacollector-tests.git","svn_url":"https://github.com/streamsets/datacollector-tests","homepage":"","size":1667,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":26,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/21"},"html":{"href":"https://github.com/streamsets/datacollector-tests/pull/21"},"issue":{"href":"https://api.github.com/repos/streamsets/datacollector-tests/issues/21"},"comments":{"href":"https://api.github.com/repos/streamsets/datacollector-tests/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/streamsets/datacollector-tests/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/streamsets/datacollector-tests/statuses/2f830160a56568ab05199ef08836c894dbac92e7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 75122350,
"name": "streamsets/datacollector-tests",
"url": "https://api.github.com/repos/streamsets/datacollector-tests"
}
|
{
"id": 49744401,
"login": "shravantal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49744401?",
"url": "https://api.github.com/users/shravantal"
}
|
{
"id": 14020362,
"login": "streamsets",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14020362?",
"url": "https://api.github.com/orgs/streamsets"
}
| 2019-06-14T11:06:08 |
9822949456
|
{"actor":{"display_login":"shravantal"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/xgcm/xgcm/pulls/comments/333717867","pull_request_review_id":300328744,"id":333717867,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMzcxNzg2Nw==","diff_hunk":"@@ -1162,29 +1183,49 @@ def integrate(self, da, axis, **kwargs):\n da_i : xarray.DataArray\n The integrated data\n \"\"\"\n- check_axes = [ax for ax in axis if ax not in self.axes]\n- check_axes_str = \",\".join(check_axes)\n- if any(check_axes):\n- raise ValueError(\"Axis %s not found in grid object\" % check_axes_str)\n-\n- dim = []\n- for ax in axis:\n- all_dim = self.axes[ax].coords.values()\n- matching_dim = [di for di in all_dim if di in da.dims]\n- if len(matching_dim) == 1:\n- dim.append(matching_dim[0])\n- else:\n- raise ValueError(\n- \"Did not find single matching dimension corresponding to axis %s. Got (%s)\"\n- % (ax, matching_dim)\n- )\n+ # check if axis input is compatible\n+ self._check_axes(axis)\n \n+ # get dimension(s) corresponding\n+ # to `da` and `axis` input\n+ dim = self._get_dims_from_axis(da, axis)\n+ print(dim)\n weight = self.get_metric(da, axis)\n weighted = da * weight\n # TODO: We should integrate xarray.weighted once available.\n \n return weighted.sum(dim)\n \n+ @docstrings.dedent\n+ def average(self, da, axis, **kwargs):\n+ \"\"\"\n+ Perform weighted average along specified axis or axes,\n+ accounting for grid metrics. (e.g. cell length, area, volume)\n+\n+ Parameters\n+ ----------\n+ axis : str, list of str\n+ Name of the axis on which to act\n+ %(neighbor_binary_func.parameters.no_f)s\n+\n+ Returns\n+ -------\n+ da_i : xarray.DataArray\n+ The averaged data\n+ \"\"\"\n+ # check if axis input is compatible\n+ self._check_axes(axis)","path":"xgcm/grid.py","position":79,"original_position":79,"commit_id":"ec39876863d50f4317963b25095eee7b1b24bcb8","original_commit_id":"ec39876863d50f4317963b25095eee7b1b24bcb8","user":{"login":"jbusecke","id":14314623,"node_id":"MDQ6VXNlcjE0MzE0NjIz","avatar_url":"https://avatars2.githubusercontent.com/u/14314623?v=4","gravatar_id":"","url":"https://api.github.com/users/jbusecke","html_url":"https://github.com/jbusecke","followers_url":"https://api.github.com/users/jbusecke/followers","following_url":"https://api.github.com/users/jbusecke/following{/other_user}","gists_url":"https://api.github.com/users/jbusecke/gists{/gist_id}","starred_url":"https://api.github.com/users/jbusecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbusecke/subscriptions","organizations_url":"https://api.github.com/users/jbusecke/orgs","repos_url":"https://api.github.com/users/jbusecke/repos","events_url":"https://api.github.com/users/jbusecke/events{/privacy}","received_events_url":"https://api.github.com/users/jbusecke/received_events","type":"User","site_admin":false},"body":"Oh you might be right. Ill investigate","created_at":"2019-10-10T20:22:41Z","updated_at":"2019-10-10T20:22:41Z","html_url":"https://github.com/xgcm/xgcm/pull/162#discussion_r333717867","pull_request_url":"https://api.github.com/repos/xgcm/xgcm/pulls/162","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/xgcm/xgcm/pulls/comments/333717867"},"html":{"href":"https://github.com/xgcm/xgcm/pull/162#discussion_r333717867"},"pull_request":{"href":"https://api.github.com/repos/xgcm/xgcm/pulls/162"}},"in_reply_to_id":333714938},"pull_request":{"url":"https://api.github.com/repos/xgcm/xgcm/pulls/162","id":326863011,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2ODYzMDEx","html_url":"https://github.com/xgcm/xgcm/pull/162","diff_url":"https://github.com/xgcm/xgcm/pull/162.diff","patch_url":"https://github.com/xgcm/xgcm/pull/162.patch","issue_url":"https://api.github.com/repos/xgcm/xgcm/issues/162","number":162,"state":"open","locked":false,"title":"WIP: Adding weighted average and cumsum","user":{"login":"jbusecke","id":14314623,"node_id":"MDQ6VXNlcjE0MzE0NjIz","avatar_url":"https://avatars2.githubusercontent.com/u/14314623?v=4","gravatar_id":"","url":"https://api.github.com/users/jbusecke","html_url":"https://github.com/jbusecke","followers_url":"https://api.github.com/users/jbusecke/followers","following_url":"https://api.github.com/users/jbusecke/following{/other_user}","gists_url":"https://api.github.com/users/jbusecke/gists{/gist_id}","starred_url":"https://api.github.com/users/jbusecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbusecke/subscriptions","organizations_url":"https://api.github.com/users/jbusecke/orgs","repos_url":"https://api.github.com/users/jbusecke/repos","events_url":"https://api.github.com/users/jbusecke/events{/privacy}","received_events_url":"https://api.github.com/users/jbusecke/received_events","type":"User","site_admin":false},"body":"Added average, generalized tests for integrate/average","created_at":"2019-10-10T18:07:15Z","updated_at":"2019-10-10T20:22:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b827a2f34e1f1c72b4cbe6b0fbab85c18760d44d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":253990788,"node_id":"MDU6TGFiZWwyNTM5OTA3ODg=","url":"https://api.github.com/repos/xgcm/xgcm/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/xgcm/xgcm/pulls/162/commits","review_comments_url":"https://api.github.com/repos/xgcm/xgcm/pulls/162/comments","review_comment_url":"https://api.github.com/repos/xgcm/xgcm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xgcm/xgcm/issues/162/comments","statuses_url":"https://api.github.com/repos/xgcm/xgcm/statuses/ec39876863d50f4317963b25095eee7b1b24bcb8","head":{"label":"jbusecke:jbusecke_weighted_average_and_cumsum","ref":"jbusecke_weighted_average_and_cumsum","sha":"ec39876863d50f4317963b25095eee7b1b24bcb8","user":{"login":"jbusecke","id":14314623,"node_id":"MDQ6VXNlcjE0MzE0NjIz","avatar_url":"https://avatars2.githubusercontent.com/u/14314623?v=4","gravatar_id":"","url":"https://api.github.com/users/jbusecke","html_url":"https://github.com/jbusecke","followers_url":"https://api.github.com/users/jbusecke/followers","following_url":"https://api.github.com/users/jbusecke/following{/other_user}","gists_url":"https://api.github.com/users/jbusecke/gists{/gist_id}","starred_url":"https://api.github.com/users/jbusecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbusecke/subscriptions","organizations_url":"https://api.github.com/users/jbusecke/orgs","repos_url":"https://api.github.com/users/jbusecke/repos","events_url":"https://api.github.com/users/jbusecke/events{/privacy}","received_events_url":"https://api.github.com/users/jbusecke/received_events","type":"User","site_admin":false},"repo":{"id":110038277,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMzgyNzc=","name":"xgcm","full_name":"jbusecke/xgcm","private":false,"owner":{"login":"jbusecke","id":14314623,"node_id":"MDQ6VXNlcjE0MzE0NjIz","avatar_url":"https://avatars2.githubusercontent.com/u/14314623?v=4","gravatar_id":"","url":"https://api.github.com/users/jbusecke","html_url":"https://github.com/jbusecke","followers_url":"https://api.github.com/users/jbusecke/followers","following_url":"https://api.github.com/users/jbusecke/following{/other_user}","gists_url":"https://api.github.com/users/jbusecke/gists{/gist_id}","starred_url":"https://api.github.com/users/jbusecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbusecke/subscriptions","organizations_url":"https://api.github.com/users/jbusecke/orgs","repos_url":"https://api.github.com/users/jbusecke/repos","events_url":"https://api.github.com/users/jbusecke/events{/privacy}","received_events_url":"https://api.github.com/users/jbusecke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbusecke/xgcm","description":"python package for analyzing general circulation model output data","fork":true,"url":"https://api.github.com/repos/jbusecke/xgcm","forks_url":"https://api.github.com/repos/jbusecke/xgcm/forks","keys_url":"https://api.github.com/repos/jbusecke/xgcm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbusecke/xgcm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbusecke/xgcm/teams","hooks_url":"https://api.github.com/repos/jbusecke/xgcm/hooks","issue_events_url":"https://api.github.com/repos/jbusecke/xgcm/issues/events{/number}","events_url":"https://api.github.com/repos/jbusecke/xgcm/events","assignees_url":"https://api.github.com/repos/jbusecke/xgcm/assignees{/user}","branches_url":"https://api.github.com/repos/jbusecke/xgcm/branches{/branch}","tags_url":"https://api.github.com/repos/jbusecke/xgcm/tags","blobs_url":"https://api.github.com/repos/jbusecke/xgcm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbusecke/xgcm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbusecke/xgcm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbusecke/xgcm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbusecke/xgcm/statuses/{sha}","languages_url":"https://api.github.com/repos/jbusecke/xgcm/languages","stargazers_url":"https://api.github.com/repos/jbusecke/xgcm/stargazers","contributors_url":"https://api.github.com/repos/jbusecke/xgcm/contributors","subscribers_url":"https://api.github.com/repos/jbusecke/xgcm/subscribers","subscription_url":"https://api.github.com/repos/jbusecke/xgcm/subscription","commits_url":"https://api.github.com/repos/jbusecke/xgcm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbusecke/xgcm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbusecke/xgcm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbusecke/xgcm/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbusecke/xgcm/contents/{+path}","compare_url":"https://api.github.com/repos/jbusecke/xgcm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbusecke/xgcm/merges","archive_url":"https://api.github.com/repos/jbusecke/xgcm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbusecke/xgcm/downloads","issues_url":"https://api.github.com/repos/jbusecke/xgcm/issues{/number}","pulls_url":"https://api.github.com/repos/jbusecke/xgcm/pulls{/number}","milestones_url":"https://api.github.com/repos/jbusecke/xgcm/milestones{/number}","notifications_url":"https://api.github.com/repos/jbusecke/xgcm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbusecke/xgcm/labels{/name}","releases_url":"https://api.github.com/repos/jbusecke/xgcm/releases{/id}","deployments_url":"https://api.github.com/repos/jbusecke/xgcm/deployments","created_at":"2017-11-08T22:34:56Z","updated_at":"2018-06-29T15:30:49Z","pushed_at":"2019-10-10T18:06:39Z","git_url":"git://github.com/jbusecke/xgcm.git","ssh_url":"git@github.com:jbusecke/xgcm.git","clone_url":"https://github.com/jbusecke/xgcm.git","svn_url":"https://github.com/jbusecke/xgcm","homepage":"http://xgcm.readthedocs.org","size":35565,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xgcm:master","ref":"master","sha":"331649ed8438d735754c37a09acc4eb115da0955","user":{"login":"xgcm","id":14025832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI1ODMy","avatar_url":"https://avatars2.githubusercontent.com/u/14025832?v=4","gravatar_id":"","url":"https://api.github.com/users/xgcm","html_url":"https://github.com/xgcm","followers_url":"https://api.github.com/users/xgcm/followers","following_url":"https://api.github.com/users/xgcm/following{/other_user}","gists_url":"https://api.github.com/users/xgcm/gists{/gist_id}","starred_url":"https://api.github.com/users/xgcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xgcm/subscriptions","organizations_url":"https://api.github.com/users/xgcm/orgs","repos_url":"https://api.github.com/users/xgcm/repos","events_url":"https://api.github.com/users/xgcm/events{/privacy}","received_events_url":"https://api.github.com/users/xgcm/received_events","type":"Organization","site_admin":false},"repo":{"id":41581350,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU4MTM1MA==","name":"xgcm","full_name":"xgcm/xgcm","private":false,"owner":{"login":"xgcm","id":14025832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI1ODMy","avatar_url":"https://avatars2.githubusercontent.com/u/14025832?v=4","gravatar_id":"","url":"https://api.github.com/users/xgcm","html_url":"https://github.com/xgcm","followers_url":"https://api.github.com/users/xgcm/followers","following_url":"https://api.github.com/users/xgcm/following{/other_user}","gists_url":"https://api.github.com/users/xgcm/gists{/gist_id}","starred_url":"https://api.github.com/users/xgcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xgcm/subscriptions","organizations_url":"https://api.github.com/users/xgcm/orgs","repos_url":"https://api.github.com/users/xgcm/repos","events_url":"https://api.github.com/users/xgcm/events{/privacy}","received_events_url":"https://api.github.com/users/xgcm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xgcm/xgcm","description":"python package for analyzing general circulation model output data","fork":false,"url":"https://api.github.com/repos/xgcm/xgcm","forks_url":"https://api.github.com/repos/xgcm/xgcm/forks","keys_url":"https://api.github.com/repos/xgcm/xgcm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xgcm/xgcm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xgcm/xgcm/teams","hooks_url":"https://api.github.com/repos/xgcm/xgcm/hooks","issue_events_url":"https://api.github.com/repos/xgcm/xgcm/issues/events{/number}","events_url":"https://api.github.com/repos/xgcm/xgcm/events","assignees_url":"https://api.github.com/repos/xgcm/xgcm/assignees{/user}","branches_url":"https://api.github.com/repos/xgcm/xgcm/branches{/branch}","tags_url":"https://api.github.com/repos/xgcm/xgcm/tags","blobs_url":"https://api.github.com/repos/xgcm/xgcm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xgcm/xgcm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xgcm/xgcm/git/refs{/sha}","trees_url":"https://api.github.com/repos/xgcm/xgcm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xgcm/xgcm/statuses/{sha}","languages_url":"https://api.github.com/repos/xgcm/xgcm/languages","stargazers_url":"https://api.github.com/repos/xgcm/xgcm/stargazers","contributors_url":"https://api.github.com/repos/xgcm/xgcm/contributors","subscribers_url":"https://api.github.com/repos/xgcm/xgcm/subscribers","subscription_url":"https://api.github.com/repos/xgcm/xgcm/subscription","commits_url":"https://api.github.com/repos/xgcm/xgcm/commits{/sha}","git_commits_url":"https://api.github.com/repos/xgcm/xgcm/git/commits{/sha}","comments_url":"https://api.github.com/repos/xgcm/xgcm/comments{/number}","issue_comment_url":"https://api.github.com/repos/xgcm/xgcm/issues/comments{/number}","contents_url":"https://api.github.com/repos/xgcm/xgcm/contents/{+path}","compare_url":"https://api.github.com/repos/xgcm/xgcm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xgcm/xgcm/merges","archive_url":"https://api.github.com/repos/xgcm/xgcm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xgcm/xgcm/downloads","issues_url":"https://api.github.com/repos/xgcm/xgcm/issues{/number}","pulls_url":"https://api.github.com/repos/xgcm/xgcm/pulls{/number}","milestones_url":"https://api.github.com/repos/xgcm/xgcm/milestones{/number}","notifications_url":"https://api.github.com/repos/xgcm/xgcm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xgcm/xgcm/labels{/name}","releases_url":"https://api.github.com/repos/xgcm/xgcm/releases{/id}","deployments_url":"https://api.github.com/repos/xgcm/xgcm/deployments","created_at":"2015-08-29T04:57:31Z","updated_at":"2019-10-10T16:23:31Z","pushed_at":"2019-10-10T18:07:16Z","git_url":"git://github.com/xgcm/xgcm.git","ssh_url":"git@github.com:xgcm/xgcm.git","clone_url":"https://github.com/xgcm/xgcm.git","svn_url":"https://github.com/xgcm/xgcm","homepage":"http://xgcm.readthedocs.org","size":35187,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":32,"open_issues":32,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xgcm/xgcm/pulls/162"},"html":{"href":"https://github.com/xgcm/xgcm/pull/162"},"issue":{"href":"https://api.github.com/repos/xgcm/xgcm/issues/162"},"comments":{"href":"https://api.github.com/repos/xgcm/xgcm/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/xgcm/xgcm/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/xgcm/xgcm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xgcm/xgcm/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/xgcm/xgcm/statuses/ec39876863d50f4317963b25095eee7b1b24bcb8"}},"author_association":"COLLABORATOR"}}
|
{
"id": 41581350,
"name": "xgcm/xgcm",
"url": "https://api.github.com/repos/xgcm/xgcm"
}
|
{
"id": 14314623,
"login": "jbusecke",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14314623?",
"url": "https://api.github.com/users/jbusecke"
}
|
{
"id": 14025832,
"login": "xgcm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14025832?",
"url": "https://api.github.com/orgs/xgcm"
}
| 2019-10-10T20:22:41 |
10605396703
|
{"actor":{"display_login":"jbusecke"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/devtools/pulls/comments/334186045","pull_request_review_id":300943329,"id":334186045,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDE4NjA0NQ==","diff_hunk":"@@ -104,25 +104,20 @@ class _ConnectScreenBodyState extends State<ConnectScreenBody> {\n }\n \n Future<void> _connect([_]) async {\n- var connected = false;\n- try {\n- connected = await FrameworkCore.initVmService(\n- '',\n- explicitUri: Uri.parse(controller.text),\n- );\n- } catch (_) {}\n+ var uri = Uri.parse(controller.text);\n+ final bool connected = await FrameworkCore.initVmService(","path":"packages/devtools_app/lib/src/flutter/connect_screen.dart","position":12,"original_position":12,"commit_id":"0095b83a8a5682f8dc0e7d3c9323e2a59f275852","original_commit_id":"0095b83a8a5682f8dc0e7d3c9323e2a59f275852","user":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"body":"this error reporting behavior is consistent with the dart:html app.","created_at":"2019-10-11T21:51:02Z","updated_at":"2019-10-11T21:51:02Z","html_url":"https://github.com/flutter/devtools/pull/1169#discussion_r334186045","pull_request_url":"https://api.github.com/repos/flutter/devtools/pulls/1169","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/devtools/pulls/comments/334186045"},"html":{"href":"https://github.com/flutter/devtools/pull/1169#discussion_r334186045"},"pull_request":{"href":"https://api.github.com/repos/flutter/devtools/pulls/1169"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/devtools/pulls/1169","id":327379113,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3Mzc5MTEz","html_url":"https://github.com/flutter/devtools/pull/1169","diff_url":"https://github.com/flutter/devtools/pull/1169.diff","patch_url":"https://github.com/flutter/devtools/pull/1169.patch","issue_url":"https://api.github.com/repos/flutter/devtools/issues/1169","number":1169,"state":"open","locked":false,"title":"Use a version of WebSocket compatible with the VM and the Web for Flutter Desktop compatibility.","user":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"body":"Thanks @natebosch for reviewing the change to web_socket_channel required to make this work.","created_at":"2019-10-11T21:50:09Z","updated_at":"2019-10-11T21:51:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9baaa3277a22dacd11013587d60425ea58f58180","assignee":null,"assignees":[],"requested_reviewers":[{"login":"grouma","id":1840773,"node_id":"MDQ6VXNlcjE4NDA3NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1840773?v=4","gravatar_id":"","url":"https://api.github.com/users/grouma","html_url":"https://github.com/grouma","followers_url":"https://api.github.com/users/grouma/followers","following_url":"https://api.github.com/users/grouma/following{/other_user}","gists_url":"https://api.github.com/users/grouma/gists{/gist_id}","starred_url":"https://api.github.com/users/grouma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grouma/subscriptions","organizations_url":"https://api.github.com/users/grouma/orgs","repos_url":"https://api.github.com/users/grouma/repos","events_url":"https://api.github.com/users/grouma/events{/privacy}","received_events_url":"https://api.github.com/users/grouma/received_events","type":"User","site_admin":false},{"login":"natebosch","id":7528195,"node_id":"MDQ6VXNlcjc1MjgxOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7528195?v=4","gravatar_id":"","url":"https://api.github.com/users/natebosch","html_url":"https://github.com/natebosch","followers_url":"https://api.github.com/users/natebosch/followers","following_url":"https://api.github.com/users/natebosch/following{/other_user}","gists_url":"https://api.github.com/users/natebosch/gists{/gist_id}","starred_url":"https://api.github.com/users/natebosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natebosch/subscriptions","organizations_url":"https://api.github.com/users/natebosch/orgs","repos_url":"https://api.github.com/users/natebosch/repos","events_url":"https://api.github.com/users/natebosch/events{/privacy}","received_events_url":"https://api.github.com/users/natebosch/received_events","type":"User","site_admin":false},{"login":"DaveShuckerow","id":14947366,"node_id":"MDQ6VXNlcjE0OTQ3MzY2","avatar_url":"https://avatars2.githubusercontent.com/u/14947366?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveShuckerow","html_url":"https://github.com/DaveShuckerow","followers_url":"https://api.github.com/users/DaveShuckerow/followers","following_url":"https://api.github.com/users/DaveShuckerow/following{/other_user}","gists_url":"https://api.github.com/users/DaveShuckerow/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveShuckerow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveShuckerow/subscriptions","organizations_url":"https://api.github.com/users/DaveShuckerow/orgs","repos_url":"https://api.github.com/users/DaveShuckerow/repos","events_url":"https://api.github.com/users/DaveShuckerow/events{/privacy}","received_events_url":"https://api.github.com/users/DaveShuckerow/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/devtools/pulls/1169/commits","review_comments_url":"https://api.github.com/repos/flutter/devtools/pulls/1169/comments","review_comment_url":"https://api.github.com/repos/flutter/devtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/devtools/issues/1169/comments","statuses_url":"https://api.github.com/repos/flutter/devtools/statuses/0095b83a8a5682f8dc0e7d3c9323e2a59f275852","head":{"label":"jacob314:desktop_websocket","ref":"desktop_websocket","sha":"0095b83a8a5682f8dc0e7d3c9323e2a59f275852","user":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"repo":{"id":159366042,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzNjYwNDI=","name":"devtools","full_name":"jacob314/devtools","private":false,"owner":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jacob314/devtools","description":"Performance tools for Flutter.","fork":true,"url":"https://api.github.com/repos/jacob314/devtools","forks_url":"https://api.github.com/repos/jacob314/devtools/forks","keys_url":"https://api.github.com/repos/jacob314/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacob314/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacob314/devtools/teams","hooks_url":"https://api.github.com/repos/jacob314/devtools/hooks","issue_events_url":"https://api.github.com/repos/jacob314/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/jacob314/devtools/events","assignees_url":"https://api.github.com/repos/jacob314/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/jacob314/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/jacob314/devtools/tags","blobs_url":"https://api.github.com/repos/jacob314/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacob314/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacob314/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacob314/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacob314/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/jacob314/devtools/languages","stargazers_url":"https://api.github.com/repos/jacob314/devtools/stargazers","contributors_url":"https://api.github.com/repos/jacob314/devtools/contributors","subscribers_url":"https://api.github.com/repos/jacob314/devtools/subscribers","subscription_url":"https://api.github.com/repos/jacob314/devtools/subscription","commits_url":"https://api.github.com/repos/jacob314/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacob314/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacob314/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacob314/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacob314/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/jacob314/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacob314/devtools/merges","archive_url":"https://api.github.com/repos/jacob314/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacob314/devtools/downloads","issues_url":"https://api.github.com/repos/jacob314/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/jacob314/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/jacob314/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/jacob314/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacob314/devtools/labels{/name}","releases_url":"https://api.github.com/repos/jacob314/devtools/releases{/id}","deployments_url":"https://api.github.com/repos/jacob314/devtools/deployments","created_at":"2018-11-27T16:30:04Z","updated_at":"2018-11-27T16:30:07Z","pushed_at":"2019-10-11T21:47:37Z","git_url":"git://github.com/jacob314/devtools.git","ssh_url":"git@github.com:jacob314/devtools.git","clone_url":"https://github.com/jacob314/devtools.git","svn_url":"https://github.com/jacob314/devtools","homepage":null,"size":50812,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"08a27d86a2ccbd57ca3362d8fe03208d77345d44","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":143762238,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NjIyMzg=","name":"devtools","full_name":"flutter/devtools","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/devtools","description":"Performance tools for Flutter.","fork":false,"url":"https://api.github.com/repos/flutter/devtools","forks_url":"https://api.github.com/repos/flutter/devtools/forks","keys_url":"https://api.github.com/repos/flutter/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/devtools/teams","hooks_url":"https://api.github.com/repos/flutter/devtools/hooks","issue_events_url":"https://api.github.com/repos/flutter/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/devtools/events","assignees_url":"https://api.github.com/repos/flutter/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/devtools/tags","blobs_url":"https://api.github.com/repos/flutter/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/devtools/languages","stargazers_url":"https://api.github.com/repos/flutter/devtools/stargazers","contributors_url":"https://api.github.com/repos/flutter/devtools/contributors","subscribers_url":"https://api.github.com/repos/flutter/devtools/subscribers","subscription_url":"https://api.github.com/repos/flutter/devtools/subscription","commits_url":"https://api.github.com/repos/flutter/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/devtools/merges","archive_url":"https://api.github.com/repos/flutter/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/devtools/downloads","issues_url":"https://api.github.com/repos/flutter/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/devtools/labels{/name}","releases_url":"https://api.github.com/repos/flutter/devtools/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/devtools/deployments","created_at":"2018-08-06T17:39:43Z","updated_at":"2019-10-11T21:04:39Z","pushed_at":"2019-10-11T21:50:09Z","git_url":"git://github.com/flutter/devtools.git","ssh_url":"git@github.com:flutter/devtools.git","clone_url":"https://github.com/flutter/devtools.git","svn_url":"https://github.com/flutter/devtools","homepage":"https://flutter.dev/docs/development/tools/devtools/","size":44182,"stargazers_count":389,"watchers_count":389,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":194,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":43,"open_issues":194,"watchers":389,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/devtools/pulls/1169"},"html":{"href":"https://github.com/flutter/devtools/pull/1169"},"issue":{"href":"https://api.github.com/repos/flutter/devtools/issues/1169"},"comments":{"href":"https://api.github.com/repos/flutter/devtools/issues/1169/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/devtools/pulls/1169/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/devtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/devtools/pulls/1169/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/devtools/statuses/0095b83a8a5682f8dc0e7d3c9323e2a59f275852"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 143762238,
"name": "flutter/devtools",
"url": "https://api.github.com/repos/flutter/devtools"
}
|
{
"id": 1226812,
"login": "jacob314",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1226812?",
"url": "https://api.github.com/users/jacob314"
}
|
{
"id": 14101776,
"login": "flutter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14101776?",
"url": "https://api.github.com/orgs/flutter"
}
| 2019-10-11T21:51:02 |
10614434664
|
{"actor":{"display_login":"jacob314"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/312667037","pull_request_review_id":273384589,"id":312667037,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjY2NzAzNw==","diff_hunk":"@@ -0,0 +1,116 @@\n+// Copyright 2019 The Chromium Authors. All rights reserved.\n+// Use of this source code is governed by a BSD-style license that can be\n+// found in the LICENSE file.\n+\n+import 'package:flutter_driver/src/common/wait.dart';\n+\n+import '../common.dart';","path":"packages/flutter_driver/test/src/wait_test.dart","position":7,"original_position":7,"commit_id":"16044e90560f8cb09b9f3c1a4e40a79b44da3401","original_commit_id":"16044e90560f8cb09b9f3c1a4e40a79b44da3401","user":{"login":"adazh","id":46544665,"node_id":"MDQ6VXNlcjQ2NTQ0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/46544665?v=4","gravatar_id":"","url":"https://api.github.com/users/adazh","html_url":"https://github.com/adazh","followers_url":"https://api.github.com/users/adazh/followers","following_url":"https://api.github.com/users/adazh/following{/other_user}","gists_url":"https://api.github.com/users/adazh/gists{/gist_id}","starred_url":"https://api.github.com/users/adazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adazh/subscriptions","organizations_url":"https://api.github.com/users/adazh/orgs","repos_url":"https://api.github.com/users/adazh/repos","events_url":"https://api.github.com/users/adazh/events{/privacy}","received_events_url":"https://api.github.com/users/adazh/received_events","type":"User","site_admin":false},"body":"Note this is a test file, and using `import '../../lib/src/common/wait.dart';` makes the analyzer complain \"Avoid relative imports for files under lib/\".","created_at":"2019-08-09T22:32:30Z","updated_at":"2019-08-09T22:32:30Z","html_url":"https://github.com/flutter/flutter/pull/37736#discussion_r312667037","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/37736","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/312667037"},"html":{"href":"https://github.com/flutter/flutter/pull/37736#discussion_r312667037"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/37736"}},"in_reply_to_id":312568334},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/37736","id":304929121,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0OTI5MTIx","html_url":"https://github.com/flutter/flutter/pull/37736","diff_url":"https://github.com/flutter/flutter/pull/37736.diff","patch_url":"https://github.com/flutter/flutter/pull/37736.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/37736","number":37736,"state":"open","locked":false,"title":"Added a composable waitForCondition Driver/extension API","user":{"login":"adazh","id":46544665,"node_id":"MDQ6VXNlcjQ2NTQ0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/46544665?v=4","gravatar_id":"","url":"https://api.github.com/users/adazh","html_url":"https://github.com/adazh","followers_url":"https://api.github.com/users/adazh/followers","following_url":"https://api.github.com/users/adazh/following{/other_user}","gists_url":"https://api.github.com/users/adazh/gists{/gist_id}","starred_url":"https://api.github.com/users/adazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adazh/subscriptions","organizations_url":"https://api.github.com/users/adazh/orgs","repos_url":"https://api.github.com/users/adazh/repos","events_url":"https://api.github.com/users/adazh/events{/privacy}","received_events_url":"https://api.github.com/users/adazh/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR added a waitForCondition API that can be used to compose conditions that the client would like to wait for. Currently supported conditions are:\r\n\r\n- NoTransientCallbacksCondition;\r\n- NoPendingFrameCondition;\r\n- Or a combined condition of the above two.\r\n\r\nIn favor of this change, we can deprecate the waitUntilNoTransientCallbacks extension API.\r\n\r\n## Related Issues\r\n\r\nhttps://github.com/flutter/flutter/issues/37409\r\n\r\n## Tests\r\n\r\nI added the following tests:\r\n\r\n- flutter_driver_test.dart\r\n\r\n- extension_test.dart\r\n\r\n- wait_test.dart\r\n\r\n## Checklist\r\n\r\nBefore you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.\r\n\r\n- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.\r\n- [x] I signed the [CLA].\r\n- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].\r\n- [x] I updated/added relevant documentation (doc comments with `///`).\r\n- [x] All existing and new tests are passing.\r\n- [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.\r\n- [x] I am willing to follow-up on review comments in a timely manner.\r\n\r\n## Breaking Change\r\n\r\nDoes your PR require Flutter developers to manually update their apps to accommodate your change?\r\n\r\n- [] Yes, this is a breaking change (Please read [Handling breaking changes]). *Replace this with a link to the e-mail where you asked for input on this proposed change.*\r\n- [X] No, this is *not* a breaking change.\r\n\r\n<!-- Links -->\r\n[issue database]: https://github.com/flutter/flutter/issues\r\n[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview\r\n[Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter\r\n[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo\r\n[Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement\r\n[CLA]: https://cla.developers.google.com/\r\n[Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes\r\n","created_at":"2019-08-06T23:50:44Z","updated_at":"2019-08-09T22:32:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d4d0aa6de4bf8412261d450392392c6cd9d25a0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},{"login":"tvolkert","id":15253456,"node_id":"MDQ6VXNlcjE1MjUzNDU2","avatar_url":"https://avatars0.githubusercontent.com/u/15253456?v=4","gravatar_id":"","url":"https://api.github.com/users/tvolkert","html_url":"https://github.com/tvolkert","followers_url":"https://api.github.com/users/tvolkert/followers","following_url":"https://api.github.com/users/tvolkert/following{/other_user}","gists_url":"https://api.github.com/users/tvolkert/gists{/gist_id}","starred_url":"https://api.github.com/users/tvolkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvolkert/subscriptions","organizations_url":"https://api.github.com/users/tvolkert/orgs","repos_url":"https://api.github.com/users/tvolkert/repos","events_url":"https://api.github.com/users/tvolkert/events{/privacy}","received_events_url":"https://api.github.com/users/tvolkert/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":283479128,"node_id":"MDU6TGFiZWwyODM0NzkxMjg=","url":"https://api.github.com/repos/flutter/flutter/labels/a:%20tests","name":"a: tests","color":"38d8c8","default":false},{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false},{"id":284437560,"node_id":"MDU6TGFiZWwyODQ0Mzc1NjA=","url":"https://api.github.com/repos/flutter/flutter/labels/framework","name":"framework","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/37736/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/37736/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/37736/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/16044e90560f8cb09b9f3c1a4e40a79b44da3401","head":{"label":"adazh:wait_conditions","ref":"wait_conditions","sha":"16044e90560f8cb09b9f3c1a4e40a79b44da3401","user":{"login":"adazh","id":46544665,"node_id":"MDQ6VXNlcjQ2NTQ0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/46544665?v=4","gravatar_id":"","url":"https://api.github.com/users/adazh","html_url":"https://github.com/adazh","followers_url":"https://api.github.com/users/adazh/followers","following_url":"https://api.github.com/users/adazh/following{/other_user}","gists_url":"https://api.github.com/users/adazh/gists{/gist_id}","starred_url":"https://api.github.com/users/adazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adazh/subscriptions","organizations_url":"https://api.github.com/users/adazh/orgs","repos_url":"https://api.github.com/users/adazh/repos","events_url":"https://api.github.com/users/adazh/events{/privacy}","received_events_url":"https://api.github.com/users/adazh/received_events","type":"User","site_admin":false},"repo":{"id":165752854,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU3NTI4NTQ=","name":"flutter","full_name":"adazh/flutter","private":false,"owner":{"login":"adazh","id":46544665,"node_id":"MDQ6VXNlcjQ2NTQ0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/46544665?v=4","gravatar_id":"","url":"https://api.github.com/users/adazh","html_url":"https://github.com/adazh","followers_url":"https://api.github.com/users/adazh/followers","following_url":"https://api.github.com/users/adazh/following{/other_user}","gists_url":"https://api.github.com/users/adazh/gists{/gist_id}","starred_url":"https://api.github.com/users/adazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adazh/subscriptions","organizations_url":"https://api.github.com/users/adazh/orgs","repos_url":"https://api.github.com/users/adazh/repos","events_url":"https://api.github.com/users/adazh/events{/privacy}","received_events_url":"https://api.github.com/users/adazh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adazh/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/adazh/flutter","forks_url":"https://api.github.com/repos/adazh/flutter/forks","keys_url":"https://api.github.com/repos/adazh/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adazh/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adazh/flutter/teams","hooks_url":"https://api.github.com/repos/adazh/flutter/hooks","issue_events_url":"https://api.github.com/repos/adazh/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/adazh/flutter/events","assignees_url":"https://api.github.com/repos/adazh/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/adazh/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/adazh/flutter/tags","blobs_url":"https://api.github.com/repos/adazh/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adazh/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adazh/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/adazh/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adazh/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/adazh/flutter/languages","stargazers_url":"https://api.github.com/repos/adazh/flutter/stargazers","contributors_url":"https://api.github.com/repos/adazh/flutter/contributors","subscribers_url":"https://api.github.com/repos/adazh/flutter/subscribers","subscription_url":"https://api.github.com/repos/adazh/flutter/subscription","commits_url":"https://api.github.com/repos/adazh/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/adazh/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/adazh/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/adazh/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/adazh/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/adazh/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adazh/flutter/merges","archive_url":"https://api.github.com/repos/adazh/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adazh/flutter/downloads","issues_url":"https://api.github.com/repos/adazh/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/adazh/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/adazh/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/adazh/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adazh/flutter/labels{/name}","releases_url":"https://api.github.com/repos/adazh/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/adazh/flutter/deployments","created_at":"2019-01-14T23:43:30Z","updated_at":"2019-08-01T18:24:17Z","pushed_at":"2019-08-09T17:14:28Z","git_url":"git://github.com/adazh/flutter.git","ssh_url":"git@github.com:adazh/flutter.git","clone_url":"https://github.com/adazh/flutter.git","svn_url":"https://github.com/adazh/flutter","homepage":"https://flutter.io","size":68742,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"aeccd206975be4fcacd0a7a409e6d8b17ce5792f","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2019-08-09T22:28:04Z","pushed_at":"2019-08-09T22:30:23Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.dev","size":69342,"stargazers_count":72332,"watchers_count":72332,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8651,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7306,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8651,"open_issues":7306,"watchers":72332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/37736"},"html":{"href":"https://github.com/flutter/flutter/pull/37736"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/37736"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/37736/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/37736/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/37736/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/16044e90560f8cb09b9f3c1a4e40a79b44da3401"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 31792824,
"name": "flutter/flutter",
"url": "https://api.github.com/repos/flutter/flutter"
}
|
{
"id": 46544665,
"login": "adazh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46544665?",
"url": "https://api.github.com/users/adazh"
}
|
{
"id": 14101776,
"login": "flutter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14101776?",
"url": "https://api.github.com/orgs/flutter"
}
| 2019-08-09T22:32:30 |
10184834967
|
{"actor":{"display_login":"adazh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/288804267","pull_request_review_id":243561161,"id":288804267,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODgwNDI2Nw==","diff_hunk":"@@ -73,3 +74,21 @@ Future<T> debugInstrumentAction<T>(String description, Future<T> action()) {\n const Map<String, String> timelineWhitelistArguments = <String, String>{\n 'mode': 'basic',\n };\n+\n+/// Configure `debugFormatDouble` using [num.toStringAsPrecision].\n+///\n+/// Defaults to `null`, which uses the default logic of `debugFormatDouble`.","path":"packages/flutter/lib/src/foundation/debug.dart","position":17,"original_position":17,"commit_id":"1db1738a7e8e86b88c44c1a8158f8be1235ccd7c","original_commit_id":"1db1738a7e8e86b88c44c1a8158f8be1235ccd7c","user":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"body":"I believe our style is to not enclose null in `","created_at":"2019-05-29T23:16:17Z","updated_at":"2019-05-29T23:27:44Z","html_url":"https://github.com/flutter/flutter/pull/33488#discussion_r288804267","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/33488","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/288804267"},"html":{"href":"https://github.com/flutter/flutter/pull/33488#discussion_r288804267"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/33488"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/33488","id":283078887,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzMDc4ODg3","html_url":"https://github.com/flutter/flutter/pull/33488","diff_url":"https://github.com/flutter/flutter/pull/33488.diff","patch_url":"https://github.com/flutter/flutter/pull/33488.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/33488","number":33488,"state":"open","locked":false,"title":"use toFixedAsString and DoubleProperty in diagnosticProperties","user":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nuse `DoubleProperty` instead of `DiagnosticProperty<double>` and use toFixedAsString(1) in place of String interpolation in several cases that were flagged during rolling flutter web.\r\n\r\n## Related Issues\r\n\r\nhttps://github.com/flutter/flutter/pull/33349","created_at":"2019-05-29T03:23:10Z","updated_at":"2019-05-29T23:27:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cdf64dbc60ab9dafed43de52094df5bf4e55c78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false},{"id":284437560,"node_id":"MDU6TGFiZWwyODQ0Mzc1NjA=","url":"https://api.github.com/repos/flutter/flutter/labels/framework","name":"framework","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/33488/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/33488/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/33488/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/1db1738a7e8e86b88c44c1a8158f8be1235ccd7c","head":{"label":"jonahwilliams:fix_some_diagnostics","ref":"fix_some_diagnostics","sha":"1db1738a7e8e86b88c44c1a8158f8be1235ccd7c","user":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"repo":{"id":123957473,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5NTc0NzM=","name":"flutter","full_name":"jonahwilliams/flutter","private":false,"owner":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jonahwilliams/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/jonahwilliams/flutter","forks_url":"https://api.github.com/repos/jonahwilliams/flutter/forks","keys_url":"https://api.github.com/repos/jonahwilliams/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonahwilliams/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonahwilliams/flutter/teams","hooks_url":"https://api.github.com/repos/jonahwilliams/flutter/hooks","issue_events_url":"https://api.github.com/repos/jonahwilliams/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/jonahwilliams/flutter/events","assignees_url":"https://api.github.com/repos/jonahwilliams/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/jonahwilliams/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/jonahwilliams/flutter/tags","blobs_url":"https://api.github.com/repos/jonahwilliams/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonahwilliams/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonahwilliams/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonahwilliams/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonahwilliams/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/jonahwilliams/flutter/languages","stargazers_url":"https://api.github.com/repos/jonahwilliams/flutter/stargazers","contributors_url":"https://api.github.com/repos/jonahwilliams/flutter/contributors","subscribers_url":"https://api.github.com/repos/jonahwilliams/flutter/subscribers","subscription_url":"https://api.github.com/repos/jonahwilliams/flutter/subscription","commits_url":"https://api.github.com/repos/jonahwilliams/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonahwilliams/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonahwilliams/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonahwilliams/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonahwilliams/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/jonahwilliams/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonahwilliams/flutter/merges","archive_url":"https://api.github.com/repos/jonahwilliams/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonahwilliams/flutter/downloads","issues_url":"https://api.github.com/repos/jonahwilliams/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/jonahwilliams/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/jonahwilliams/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/jonahwilliams/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonahwilliams/flutter/labels{/name}","releases_url":"https://api.github.com/repos/jonahwilliams/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/jonahwilliams/flutter/deployments","created_at":"2018-03-05T17:57:36Z","updated_at":"2019-04-20T04:47:59Z","pushed_at":"2019-05-29T23:16:10Z","git_url":"git://github.com/jonahwilliams/flutter.git","ssh_url":"git@github.com:jonahwilliams/flutter.git","clone_url":"https://github.com/jonahwilliams/flutter.git","svn_url":"https://github.com/jonahwilliams/flutter","homepage":"https://flutter.io","size":69573,"stargazers_count":2,"watchers_count":2,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"c56b4551808477ff0526522c9cd3dc16b081f6e8","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2019-05-29T23:26:29Z","pushed_at":"2019-05-29T23:19:02Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.dev","size":63130,"stargazers_count":65489,"watchers_count":65489,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7362,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5901,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7362,"open_issues":5901,"watchers":65489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/33488"},"html":{"href":"https://github.com/flutter/flutter/pull/33488"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/33488"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/33488/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/33488/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/33488/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/1db1738a7e8e86b88c44c1a8158f8be1235ccd7c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 31792824,
"name": "flutter/flutter",
"url": "https://api.github.com/repos/flutter/flutter"
}
|
{
"id": 1227763,
"login": "goderbauer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1227763?",
"url": "https://api.github.com/users/goderbauer"
}
|
{
"id": 14101776,
"login": "flutter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14101776?",
"url": "https://api.github.com/orgs/flutter"
}
| 2019-05-29T23:16:17 |
9723268561
|
{"actor":{"display_login":"goderbauer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/271402993","pull_request_review_id":221783300,"id":271402993,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTQwMjk5Mw==","diff_hunk":"@@ -196,9 +196,7 @@ class CardItem extends StatelessWidget {\n }\n }\n \n-void main() {\n- runApp(AnimatedListSample());\n-}\n+void main() { runApp(AnimatedListSample()); }","path":"examples/catalog/lib/animated_list.dart","position":35,"original_position":35,"commit_id":"8da5dfca8e1b3a90dce8a057105f4d8b052c8f8c","original_commit_id":"8da5dfca8e1b3a90dce8a057105f4d8b052c8f8c","user":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"this is a surprising change","created_at":"2019-04-02T16:56:08Z","updated_at":"2019-04-02T16:56:08Z","html_url":"https://github.com/flutter/flutter/pull/30138#discussion_r271402993","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/30138","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/271402993"},"html":{"href":"https://github.com/flutter/flutter/pull/30138#discussion_r271402993"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/30138"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/30138","id":265519541,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1NTE5NTQx","html_url":"https://github.com/flutter/flutter/pull/30138","diff_url":"https://github.com/flutter/flutter/pull/30138.diff","patch_url":"https://github.com/flutter/flutter/pull/30138.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/30138","number":30138,"state":"open","locked":false,"title":"[NOT FOR REVIEW] Format examples","user":{"login":"a14n","id":1206632,"node_id":"MDQ6VXNlcjEyMDY2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1206632?v=4","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-28T22:03:37Z","updated_at":"2019-04-02T16:56:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"741475bdc9b9db1d7b736afb0e8e1e3d8d023f5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false},{"id":283479307,"node_id":"MDU6TGFiZWwyODM0NzkzMDc=","url":"https://api.github.com/repos/flutter/flutter/labels/team","name":"team","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/30138/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/30138/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/30138/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/8da5dfca8e1b3a90dce8a057105f4d8b052c8f8c","head":{"label":"a14n:format-examples","ref":"format-examples","sha":"8da5dfca8e1b3a90dce8a057105f4d8b052c8f8c","user":{"login":"a14n","id":1206632,"node_id":"MDQ6VXNlcjEyMDY2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1206632?v=4","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"repo":{"id":50984105,"node_id":"MDEwOlJlcG9zaXRvcnk1MDk4NDEwNQ==","name":"flutter","full_name":"a14n/flutter","private":false,"owner":{"login":"a14n","id":1206632,"node_id":"MDQ6VXNlcjEyMDY2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1206632?v=4","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"html_url":"https://github.com/a14n/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":true,"url":"https://api.github.com/repos/a14n/flutter","forks_url":"https://api.github.com/repos/a14n/flutter/forks","keys_url":"https://api.github.com/repos/a14n/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a14n/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a14n/flutter/teams","hooks_url":"https://api.github.com/repos/a14n/flutter/hooks","issue_events_url":"https://api.github.com/repos/a14n/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/a14n/flutter/events","assignees_url":"https://api.github.com/repos/a14n/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/a14n/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/a14n/flutter/tags","blobs_url":"https://api.github.com/repos/a14n/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a14n/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a14n/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/a14n/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a14n/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/a14n/flutter/languages","stargazers_url":"https://api.github.com/repos/a14n/flutter/stargazers","contributors_url":"https://api.github.com/repos/a14n/flutter/contributors","subscribers_url":"https://api.github.com/repos/a14n/flutter/subscribers","subscription_url":"https://api.github.com/repos/a14n/flutter/subscription","commits_url":"https://api.github.com/repos/a14n/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/a14n/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/a14n/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/a14n/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/a14n/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/a14n/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a14n/flutter/merges","archive_url":"https://api.github.com/repos/a14n/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a14n/flutter/downloads","issues_url":"https://api.github.com/repos/a14n/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/a14n/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/a14n/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/a14n/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a14n/flutter/labels{/name}","releases_url":"https://api.github.com/repos/a14n/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/a14n/flutter/deployments","created_at":"2016-02-03T08:04:00Z","updated_at":"2018-12-27T20:23:04Z","pushed_at":"2019-04-02T09:09:32Z","git_url":"git://github.com/a14n/flutter.git","ssh_url":"git@github.com:a14n/flutter.git","clone_url":"https://github.com/a14n/flutter.git","svn_url":"https://github.com/a14n/flutter","homepage":"http://flutter.io","size":59986,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"159c493803154aee5aaa3a3e3a6e26b4ff010a97","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2019-04-02T16:52:04Z","pushed_at":"2019-04-02T16:45:06Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.dev","size":59624,"stargazers_count":58867,"watchers_count":58867,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6422,"mirror_url":null,"archived":false,"open_issues_count":4941,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6422,"open_issues":4941,"watchers":58867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/30138"},"html":{"href":"https://github.com/flutter/flutter/pull/30138"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/30138"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/30138/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/30138/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/30138/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/8da5dfca8e1b3a90dce8a057105f4d8b052c8f8c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 31792824,
"name": "flutter/flutter",
"url": "https://api.github.com/repos/flutter/flutter"
}
|
{
"id": 551196,
"login": "Hixie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/551196?",
"url": "https://api.github.com/users/Hixie"
}
|
{
"id": 14101776,
"login": "flutter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14101776?",
"url": "https://api.github.com/orgs/flutter"
}
| 2019-04-02T16:56:08 |
9363843554
|
{"actor":{"display_login":"Hixie"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/devtools/pulls/comments/259097020","pull_request_review_id":206517896,"id":259097020,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTA5NzAyMA==","diff_hunk":"@@ -54,10 +55,10 @@ class FramesBarPlotly {\n \n static List<Data> createFPSTraces() {\n final Data traceCpuGood = Data(\n- y: [],\n- x: [],\n+ y: [0],\n+ x: [-1],","path":"packages/devtools/lib/src/timeline/frames_bar_plotly.dart","position":44,"original_position":44,"commit_id":"ce61216dbe01a7e07a4825f74d264576cce03ba0","original_commit_id":"ce61216dbe01a7e07a4825f74d264576cce03ba0","user":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"body":"nit: comment why these default values are needed to work around strange plotly behavior.","created_at":"2019-02-21T20:12:55Z","updated_at":"2019-02-21T20:12:55Z","html_url":"https://github.com/flutter/devtools/pull/326#discussion_r259097020","pull_request_url":"https://api.github.com/repos/flutter/devtools/pulls/326","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/devtools/pulls/comments/259097020"},"html":{"href":"https://github.com/flutter/devtools/pull/326#discussion_r259097020"},"pull_request":{"href":"https://api.github.com/repos/flutter/devtools/pulls/326"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/devtools/pulls/326","id":255151217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1MTUxMjE3","html_url":"https://github.com/flutter/devtools/pull/326","diff_url":"https://github.com/flutter/devtools/pull/326.diff","patch_url":"https://github.com/flutter/devtools/pull/326.patch","issue_url":"https://api.github.com/repos/flutter/devtools/issues/326","number":326,"state":"open","locked":false,"title":"Fixed first bars of trace missing color and grouping legend.","user":{"login":"terrylucas","id":2055873,"node_id":"MDQ6VXNlcjIwNTU4NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/2055873?v=4","gravatar_id":"","url":"https://api.github.com/users/terrylucas","html_url":"https://github.com/terrylucas","followers_url":"https://api.github.com/users/terrylucas/followers","following_url":"https://api.github.com/users/terrylucas/following{/other_user}","gists_url":"https://api.github.com/users/terrylucas/gists{/gist_id}","starred_url":"https://api.github.com/users/terrylucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrylucas/subscriptions","organizations_url":"https://api.github.com/users/terrylucas/orgs","repos_url":"https://api.github.com/users/terrylucas/repos","events_url":"https://api.github.com/users/terrylucas/events{/privacy}","received_events_url":"https://api.github.com/users/terrylucas/received_events","type":"User","site_admin":false},"body":"Fixed the first datum of a trace may not display it colored bar. \r\nFixed legend so good cpu/gpu and jank cpu/jank gpu are grouped together.","created_at":"2019-02-21T19:24:00Z","updated_at":"2019-02-21T20:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e2ec6feaeb645d2c42a5764ba0ddb586cdbbf89","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kenzieschmoll","id":43759233,"node_id":"MDQ6VXNlcjQzNzU5MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/43759233?v=4","gravatar_id":"","url":"https://api.github.com/users/kenzieschmoll","html_url":"https://github.com/kenzieschmoll","followers_url":"https://api.github.com/users/kenzieschmoll/followers","following_url":"https://api.github.com/users/kenzieschmoll/following{/other_user}","gists_url":"https://api.github.com/users/kenzieschmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/kenzieschmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenzieschmoll/subscriptions","organizations_url":"https://api.github.com/users/kenzieschmoll/orgs","repos_url":"https://api.github.com/users/kenzieschmoll/repos","events_url":"https://api.github.com/users/kenzieschmoll/events{/privacy}","received_events_url":"https://api.github.com/users/kenzieschmoll/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/devtools/pulls/326/commits","review_comments_url":"https://api.github.com/repos/flutter/devtools/pulls/326/comments","review_comment_url":"https://api.github.com/repos/flutter/devtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/devtools/issues/326/comments","statuses_url":"https://api.github.com/repos/flutter/devtools/statuses/ce61216dbe01a7e07a4825f74d264576cce03ba0","head":{"label":"terrylucas:fix_bars_missing_color","ref":"fix_bars_missing_color","sha":"ce61216dbe01a7e07a4825f74d264576cce03ba0","user":{"login":"terrylucas","id":2055873,"node_id":"MDQ6VXNlcjIwNTU4NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/2055873?v=4","gravatar_id":"","url":"https://api.github.com/users/terrylucas","html_url":"https://github.com/terrylucas","followers_url":"https://api.github.com/users/terrylucas/followers","following_url":"https://api.github.com/users/terrylucas/following{/other_user}","gists_url":"https://api.github.com/users/terrylucas/gists{/gist_id}","starred_url":"https://api.github.com/users/terrylucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrylucas/subscriptions","organizations_url":"https://api.github.com/users/terrylucas/orgs","repos_url":"https://api.github.com/users/terrylucas/repos","events_url":"https://api.github.com/users/terrylucas/events{/privacy}","received_events_url":"https://api.github.com/users/terrylucas/received_events","type":"User","site_admin":false},"repo":{"id":171373068,"node_id":"MDEwOlJlcG9zaXRvcnkxNzEzNzMwNjg=","name":"devtools","full_name":"terrylucas/devtools","private":false,"owner":{"login":"terrylucas","id":2055873,"node_id":"MDQ6VXNlcjIwNTU4NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/2055873?v=4","gravatar_id":"","url":"https://api.github.com/users/terrylucas","html_url":"https://github.com/terrylucas","followers_url":"https://api.github.com/users/terrylucas/followers","following_url":"https://api.github.com/users/terrylucas/following{/other_user}","gists_url":"https://api.github.com/users/terrylucas/gists{/gist_id}","starred_url":"https://api.github.com/users/terrylucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrylucas/subscriptions","organizations_url":"https://api.github.com/users/terrylucas/orgs","repos_url":"https://api.github.com/users/terrylucas/repos","events_url":"https://api.github.com/users/terrylucas/events{/privacy}","received_events_url":"https://api.github.com/users/terrylucas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/terrylucas/devtools","description":"Performance tools for Flutter.","fork":true,"url":"https://api.github.com/repos/terrylucas/devtools","forks_url":"https://api.github.com/repos/terrylucas/devtools/forks","keys_url":"https://api.github.com/repos/terrylucas/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terrylucas/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terrylucas/devtools/teams","hooks_url":"https://api.github.com/repos/terrylucas/devtools/hooks","issue_events_url":"https://api.github.com/repos/terrylucas/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/terrylucas/devtools/events","assignees_url":"https://api.github.com/repos/terrylucas/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/terrylucas/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/terrylucas/devtools/tags","blobs_url":"https://api.github.com/repos/terrylucas/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terrylucas/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terrylucas/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/terrylucas/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terrylucas/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/terrylucas/devtools/languages","stargazers_url":"https://api.github.com/repos/terrylucas/devtools/stargazers","contributors_url":"https://api.github.com/repos/terrylucas/devtools/contributors","subscribers_url":"https://api.github.com/repos/terrylucas/devtools/subscribers","subscription_url":"https://api.github.com/repos/terrylucas/devtools/subscription","commits_url":"https://api.github.com/repos/terrylucas/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/terrylucas/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/terrylucas/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/terrylucas/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/terrylucas/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/terrylucas/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terrylucas/devtools/merges","archive_url":"https://api.github.com/repos/terrylucas/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terrylucas/devtools/downloads","issues_url":"https://api.github.com/repos/terrylucas/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/terrylucas/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/terrylucas/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/terrylucas/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terrylucas/devtools/labels{/name}","releases_url":"https://api.github.com/repos/terrylucas/devtools/releases{/id}","deployments_url":"https://api.github.com/repos/terrylucas/devtools/deployments","created_at":"2019-02-18T23:45:39Z","updated_at":"2019-02-20T00:05:38Z","pushed_at":"2019-02-21T19:22:10Z","git_url":"git://github.com/terrylucas/devtools.git","ssh_url":"git@github.com:terrylucas/devtools.git","clone_url":"https://github.com/terrylucas/devtools.git","svn_url":"https://github.com/terrylucas/devtools","homepage":null,"size":36946,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"69d35ae23f061aded0485021b47ef4e146ddc96f","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":143762238,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NjIyMzg=","name":"devtools","full_name":"flutter/devtools","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/devtools","description":"Performance tools for Flutter.","fork":false,"url":"https://api.github.com/repos/flutter/devtools","forks_url":"https://api.github.com/repos/flutter/devtools/forks","keys_url":"https://api.github.com/repos/flutter/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/devtools/teams","hooks_url":"https://api.github.com/repos/flutter/devtools/hooks","issue_events_url":"https://api.github.com/repos/flutter/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/devtools/events","assignees_url":"https://api.github.com/repos/flutter/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/devtools/tags","blobs_url":"https://api.github.com/repos/flutter/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/devtools/languages","stargazers_url":"https://api.github.com/repos/flutter/devtools/stargazers","contributors_url":"https://api.github.com/repos/flutter/devtools/contributors","subscribers_url":"https://api.github.com/repos/flutter/devtools/subscribers","subscription_url":"https://api.github.com/repos/flutter/devtools/subscription","commits_url":"https://api.github.com/repos/flutter/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/devtools/merges","archive_url":"https://api.github.com/repos/flutter/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/devtools/downloads","issues_url":"https://api.github.com/repos/flutter/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/devtools/labels{/name}","releases_url":"https://api.github.com/repos/flutter/devtools/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/devtools/deployments","created_at":"2018-08-06T17:39:43Z","updated_at":"2019-02-21T18:46:23Z","pushed_at":"2019-02-21T20:10:52Z","git_url":"git://github.com/flutter/devtools.git","ssh_url":"git@github.com:flutter/devtools.git","clone_url":"https://github.com/flutter/devtools.git","svn_url":"https://github.com/flutter/devtools","homepage":null,"size":37106,"stargazers_count":95,"watchers_count":95,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":15,"open_issues":50,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/devtools/pulls/326"},"html":{"href":"https://github.com/flutter/devtools/pull/326"},"issue":{"href":"https://api.github.com/repos/flutter/devtools/issues/326"},"comments":{"href":"https://api.github.com/repos/flutter/devtools/issues/326/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/devtools/pulls/326/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/devtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/devtools/pulls/326/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/devtools/statuses/ce61216dbe01a7e07a4825f74d264576cce03ba0"}},"author_association":"COLLABORATOR"}}
|
{
"id": 143762238,
"name": "flutter/devtools",
"url": "https://api.github.com/repos/flutter/devtools"
}
|
{
"id": 1226812,
"login": "jacob314",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1226812?",
"url": "https://api.github.com/users/jacob314"
}
|
{
"id": 14101776,
"login": "flutter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14101776?",
"url": "https://api.github.com/orgs/flutter"
}
| 2019-02-21T20:12:55 |
9113146151
|
{"actor":{"display_login":"jacob314"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/comments/284480101","pull_request_review_id":238106821,"id":284480101,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDQ4MDEwMQ==","diff_hunk":"@@ -0,0 +1,10 @@\n+module Concerns\n+ module SearchFilters\n+ extend ActiveSupport::Concern\n+\n+ included do\n+ scope :of_date, ->(date) { where('start_date_rent <= ? AND end_date_rent >= ?', date, date) }\n+ scope :current, -> { of_date(Time.zone.today.strftime('%Y-%m-%d')) }","path":"app/models/concerns/search_filters.rb","position":7,"original_position":7,"commit_id":"1a8190d2eab5b7f94fe3105fded22531779824bf","original_commit_id":"1a8190d2eab5b7f94fe3105fded22531779824bf","user":{"login":"blacksam07","id":50454914,"node_id":"MDQ6VXNlcjUwNDU0OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/50454914?v=4","gravatar_id":"","url":"https://api.github.com/users/blacksam07","html_url":"https://github.com/blacksam07","followers_url":"https://api.github.com/users/blacksam07/followers","following_url":"https://api.github.com/users/blacksam07/following{/other_user}","gists_url":"https://api.github.com/users/blacksam07/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksam07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksam07/subscriptions","organizations_url":"https://api.github.com/users/blacksam07/orgs","repos_url":"https://api.github.com/users/blacksam07/repos","events_url":"https://api.github.com/users/blacksam07/events{/privacy}","received_events_url":"https://api.github.com/users/blacksam07/received_events","type":"User","site_admin":false},"body":"Bueno al momento de ver el Date.current me arrojaba lo visualizado en la imagen, obvie que podría funcionar \r\n\r\n\r\n","created_at":"2019-05-15T22:43:26Z","updated_at":"2019-05-15T22:43:26Z","html_url":"https://github.com/wolox-training/shtt-rails/pull/9#discussion_r284480101","pull_request_url":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/9","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/comments/284480101"},"html":{"href":"https://github.com/wolox-training/shtt-rails/pull/9#discussion_r284480101"},"pull_request":{"href":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/9"}},"in_reply_to_id":284473849},"pull_request":{"url":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/9","id":278829479,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4ODI5NDc5","html_url":"https://github.com/wolox-training/shtt-rails/pull/9","diff_url":"https://github.com/wolox-training/shtt-rails/pull/9.diff","patch_url":"https://github.com/wolox-training/shtt-rails/pull/9.patch","issue_url":"https://api.github.com/repos/wolox-training/shtt-rails/issues/9","number":9,"state":"open","locked":false,"title":"Added index and show endpoint to book controller","user":{"login":"blacksam07","id":50454914,"node_id":"MDQ6VXNlcjUwNDU0OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/50454914?v=4","gravatar_id":"","url":"https://api.github.com/users/blacksam07","html_url":"https://github.com/blacksam07","followers_url":"https://api.github.com/users/blacksam07/followers","following_url":"https://api.github.com/users/blacksam07/following{/other_user}","gists_url":"https://api.github.com/users/blacksam07/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksam07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksam07/subscriptions","organizations_url":"https://api.github.com/users/blacksam07/orgs","repos_url":"https://api.github.com/users/blacksam07/repos","events_url":"https://api.github.com/users/blacksam07/events{/privacy}","received_events_url":"https://api.github.com/users/blacksam07/received_events","type":"User","site_admin":false},"body":"# Summary\r\n- Added index and show endpoints to book controller\r\n- Added [wor-paginate](https://github.com/Wolox/wor-paginate) gem\r\n- Added [Active Model Serializers](https://github.com/rails-api/active_model_serializers) gem\r\n- Change expiry time of token\r\n- Rename column Gender to Genre in Book model\r\n\r\n# Trello Cards\r\n- [Crear rutas index y show para book](https://trello.com/c/Gx66F6HL/21-2-crear-rutas-index-y-show-para-book)\r\n\r\n# Screenshots\r\n ## Index\r\n<img width=\"1362\" alt=\"Screen Shot 2019-05-14 at 13 51 35\" src=\"https://user-images.githubusercontent.com/50454914/57727967-5cf0df00-7658-11e9-9bc4-92b89b3b316a.png\">\r\n\r\n<img width=\"1362\" alt=\"Screen Shot 2019-05-14 at 14 33 04\" src=\"https://user-images.githubusercontent.com/50454914/57728017-7560f980-7658-11e9-9da3-a28ba838445d.png\">\r\n\r\n## Show\r\n<img width=\"1362\" alt=\"Screen Shot 2019-05-14 at 13 51 45\" src=\"https://user-images.githubusercontent.com/50454914/57728059-96294f00-7658-11e9-8738-11d589e99234.png\">\r\n\r\n","created_at":"2019-05-14T19:58:54Z","updated_at":"2019-05-15T22:43:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d41bccfad18eb05da54d9c5ce3cd15a6cadc96b9","assignee":{"login":"blacksam07","id":50454914,"node_id":"MDQ6VXNlcjUwNDU0OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/50454914?v=4","gravatar_id":"","url":"https://api.github.com/users/blacksam07","html_url":"https://github.com/blacksam07","followers_url":"https://api.github.com/users/blacksam07/followers","following_url":"https://api.github.com/users/blacksam07/following{/other_user}","gists_url":"https://api.github.com/users/blacksam07/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksam07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksam07/subscriptions","organizations_url":"https://api.github.com/users/blacksam07/orgs","repos_url":"https://api.github.com/users/blacksam07/repos","events_url":"https://api.github.com/users/blacksam07/events{/privacy}","received_events_url":"https://api.github.com/users/blacksam07/received_events","type":"User","site_admin":false},"assignees":[{"login":"blacksam07","id":50454914,"node_id":"MDQ6VXNlcjUwNDU0OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/50454914?v=4","gravatar_id":"","url":"https://api.github.com/users/blacksam07","html_url":"https://github.com/blacksam07","followers_url":"https://api.github.com/users/blacksam07/followers","following_url":"https://api.github.com/users/blacksam07/following{/other_user}","gists_url":"https://api.github.com/users/blacksam07/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksam07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksam07/subscriptions","organizations_url":"https://api.github.com/users/blacksam07/orgs","repos_url":"https://api.github.com/users/blacksam07/repos","events_url":"https://api.github.com/users/blacksam07/events{/privacy}","received_events_url":"https://api.github.com/users/blacksam07/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mcolombo87","id":8608635,"node_id":"MDQ6VXNlcjg2MDg2MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/8608635?v=4","gravatar_id":"","url":"https://api.github.com/users/mcolombo87","html_url":"https://github.com/mcolombo87","followers_url":"https://api.github.com/users/mcolombo87/followers","following_url":"https://api.github.com/users/mcolombo87/following{/other_user}","gists_url":"https://api.github.com/users/mcolombo87/gists{/gist_id}","starred_url":"https://api.github.com/users/mcolombo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcolombo87/subscriptions","organizations_url":"https://api.github.com/users/mcolombo87/orgs","repos_url":"https://api.github.com/users/mcolombo87/repos","events_url":"https://api.github.com/users/mcolombo87/events{/privacy}","received_events_url":"https://api.github.com/users/mcolombo87/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/9/commits","review_comments_url":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/9/comments","review_comment_url":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wolox-training/shtt-rails/issues/9/comments","statuses_url":"https://api.github.com/repos/wolox-training/shtt-rails/statuses/1a8190d2eab5b7f94fe3105fded22531779824bf","head":{"label":"wolox-training:wbooks/book-controller","ref":"wbooks/book-controller","sha":"1a8190d2eab5b7f94fe3105fded22531779824bf","user":{"login":"wolox-training","id":14113351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTEzMzUx","avatar_url":"https://avatars1.githubusercontent.com/u/14113351?v=4","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"repo":{"id":185816294,"node_id":"MDEwOlJlcG9zaXRvcnkxODU4MTYyOTQ=","name":"shtt-rails","full_name":"wolox-training/shtt-rails","private":false,"owner":{"login":"wolox-training","id":14113351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTEzMzUx","avatar_url":"https://avatars1.githubusercontent.com/u/14113351?v=4","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wolox-training/shtt-rails","description":null,"fork":false,"url":"https://api.github.com/repos/wolox-training/shtt-rails","forks_url":"https://api.github.com/repos/wolox-training/shtt-rails/forks","keys_url":"https://api.github.com/repos/wolox-training/shtt-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolox-training/shtt-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolox-training/shtt-rails/teams","hooks_url":"https://api.github.com/repos/wolox-training/shtt-rails/hooks","issue_events_url":"https://api.github.com/repos/wolox-training/shtt-rails/issues/events{/number}","events_url":"https://api.github.com/repos/wolox-training/shtt-rails/events","assignees_url":"https://api.github.com/repos/wolox-training/shtt-rails/assignees{/user}","branches_url":"https://api.github.com/repos/wolox-training/shtt-rails/branches{/branch}","tags_url":"https://api.github.com/repos/wolox-training/shtt-rails/tags","blobs_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolox-training/shtt-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/wolox-training/shtt-rails/languages","stargazers_url":"https://api.github.com/repos/wolox-training/shtt-rails/stargazers","contributors_url":"https://api.github.com/repos/wolox-training/shtt-rails/contributors","subscribers_url":"https://api.github.com/repos/wolox-training/shtt-rails/subscribers","subscription_url":"https://api.github.com/repos/wolox-training/shtt-rails/subscription","commits_url":"https://api.github.com/repos/wolox-training/shtt-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolox-training/shtt-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolox-training/shtt-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolox-training/shtt-rails/contents/{+path}","compare_url":"https://api.github.com/repos/wolox-training/shtt-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolox-training/shtt-rails/merges","archive_url":"https://api.github.com/repos/wolox-training/shtt-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolox-training/shtt-rails/downloads","issues_url":"https://api.github.com/repos/wolox-training/shtt-rails/issues{/number}","pulls_url":"https://api.github.com/repos/wolox-training/shtt-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/wolox-training/shtt-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/wolox-training/shtt-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolox-training/shtt-rails/labels{/name}","releases_url":"https://api.github.com/repos/wolox-training/shtt-rails/releases{/id}","deployments_url":"https://api.github.com/repos/wolox-training/shtt-rails/deployments","created_at":"2019-05-09T14:33:09Z","updated_at":"2019-05-15T16:54:56Z","pushed_at":"2019-05-15T21:42:40Z","git_url":"git://github.com/wolox-training/shtt-rails.git","ssh_url":"git@github.com:wolox-training/shtt-rails.git","clone_url":"https://github.com/wolox-training/shtt-rails.git","svn_url":"https://github.com/wolox-training/shtt-rails","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"wolox-training:master","ref":"master","sha":"08df24fb2f3e538d2ec06017e2f7eea26c57f606","user":{"login":"wolox-training","id":14113351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTEzMzUx","avatar_url":"https://avatars1.githubusercontent.com/u/14113351?v=4","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"repo":{"id":185816294,"node_id":"MDEwOlJlcG9zaXRvcnkxODU4MTYyOTQ=","name":"shtt-rails","full_name":"wolox-training/shtt-rails","private":false,"owner":{"login":"wolox-training","id":14113351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTEzMzUx","avatar_url":"https://avatars1.githubusercontent.com/u/14113351?v=4","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wolox-training/shtt-rails","description":null,"fork":false,"url":"https://api.github.com/repos/wolox-training/shtt-rails","forks_url":"https://api.github.com/repos/wolox-training/shtt-rails/forks","keys_url":"https://api.github.com/repos/wolox-training/shtt-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolox-training/shtt-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolox-training/shtt-rails/teams","hooks_url":"https://api.github.com/repos/wolox-training/shtt-rails/hooks","issue_events_url":"https://api.github.com/repos/wolox-training/shtt-rails/issues/events{/number}","events_url":"https://api.github.com/repos/wolox-training/shtt-rails/events","assignees_url":"https://api.github.com/repos/wolox-training/shtt-rails/assignees{/user}","branches_url":"https://api.github.com/repos/wolox-training/shtt-rails/branches{/branch}","tags_url":"https://api.github.com/repos/wolox-training/shtt-rails/tags","blobs_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolox-training/shtt-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/wolox-training/shtt-rails/languages","stargazers_url":"https://api.github.com/repos/wolox-training/shtt-rails/stargazers","contributors_url":"https://api.github.com/repos/wolox-training/shtt-rails/contributors","subscribers_url":"https://api.github.com/repos/wolox-training/shtt-rails/subscribers","subscription_url":"https://api.github.com/repos/wolox-training/shtt-rails/subscription","commits_url":"https://api.github.com/repos/wolox-training/shtt-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolox-training/shtt-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolox-training/shtt-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolox-training/shtt-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolox-training/shtt-rails/contents/{+path}","compare_url":"https://api.github.com/repos/wolox-training/shtt-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolox-training/shtt-rails/merges","archive_url":"https://api.github.com/repos/wolox-training/shtt-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolox-training/shtt-rails/downloads","issues_url":"https://api.github.com/repos/wolox-training/shtt-rails/issues{/number}","pulls_url":"https://api.github.com/repos/wolox-training/shtt-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/wolox-training/shtt-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/wolox-training/shtt-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolox-training/shtt-rails/labels{/name}","releases_url":"https://api.github.com/repos/wolox-training/shtt-rails/releases{/id}","deployments_url":"https://api.github.com/repos/wolox-training/shtt-rails/deployments","created_at":"2019-05-09T14:33:09Z","updated_at":"2019-05-15T16:54:56Z","pushed_at":"2019-05-15T21:42:40Z","git_url":"git://github.com/wolox-training/shtt-rails.git","ssh_url":"git@github.com:wolox-training/shtt-rails.git","clone_url":"https://github.com/wolox-training/shtt-rails.git","svn_url":"https://github.com/wolox-training/shtt-rails","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/9"},"html":{"href":"https://github.com/wolox-training/shtt-rails/pull/9"},"issue":{"href":"https://api.github.com/repos/wolox-training/shtt-rails/issues/9"},"comments":{"href":"https://api.github.com/repos/wolox-training/shtt-rails/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wolox-training/shtt-rails/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/wolox-training/shtt-rails/statuses/1a8190d2eab5b7f94fe3105fded22531779824bf"}},"author_association":"COLLABORATOR"}}
|
{
"id": 185816294,
"name": "wolox-training/shtt-rails",
"url": "https://api.github.com/repos/wolox-training/shtt-rails"
}
|
{
"id": 50454914,
"login": "blacksam07",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50454914?",
"url": "https://api.github.com/users/blacksam07"
}
|
{
"id": 14113351,
"login": "wolox-training",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14113351?",
"url": "https://api.github.com/orgs/wolox-training"
}
| 2019-05-15T22:43:26 |
9634902035
|
{"actor":{"display_login":"blacksam07"}}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.