type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
428k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
11
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/comments/271432467","pull_request_review_id":221820351,"id":271432467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTQzMjQ2Nw==","diff_hunk":"@@ -0,0 +1,16 @@\n+/*\n+rule = v1\n+*/\n+package fix\n+\n+import fs2._\n+import fs2.{Pipe, Sink, Stream}\n+import fs2.{Sink => X, Stream}\n+\n+object Fs2sinkremoval {\n+\n+ private def foo[F[_], A](s: Stream[F, A], sink: Sink[F, A]): Stream[F, Unit] =\n+ s.to(sink)\n+\n+ def bar[F[_], A, B](): Pipe[F, A, B] = ???","path":"scalafix/input/src/main/scala/fix/Fs2sinkremoval.scala","position":15,"original_position":15,"commit_id":"b6f6c61c38a992217bb577b8014c13ebcb628c43","original_commit_id":"b6f6c61c38a992217bb577b8014c13ebcb628c43","user":{"login":"mpilquist","id":118078,"node_id":"MDQ6VXNlcjExODA3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/118078?v=4","gravatar_id":"","url":"https://api.github.com/users/mpilquist","html_url":"https://github.com/mpilquist","followers_url":"https://api.github.com/users/mpilquist/followers","following_url":"https://api.github.com/users/mpilquist/following{/other_user}","gists_url":"https://api.github.com/users/mpilquist/gists{/gist_id}","starred_url":"https://api.github.com/users/mpilquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpilquist/subscriptions","organizations_url":"https://api.github.com/users/mpilquist/orgs","repos_url":"https://api.github.com/users/mpilquist/repos","events_url":"https://api.github.com/users/mpilquist/events{/privacy}","received_events_url":"https://api.github.com/users/mpilquist/received_events","type":"User","site_admin":false},"body":"Should this return `Sink[F, A]`?","created_at":"2019-04-02T18:10:13Z","updated_at":"2019-04-02T18:10:14Z","html_url":"https://github.com/functional-streams-for-scala/fs2/pull/1432#discussion_r271432467","pull_request_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/1432","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/comments/271432467"},"html":{"href":"https://github.com/functional-streams-for-scala/fs2/pull/1432#discussion_r271432467"},"pull_request":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/1432"}}},"pull_request":{"url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/1432","id":263410040,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzNDEwMDQw","html_url":"https://github.com/functional-streams-for-scala/fs2/pull/1432","diff_url":"https://github.com/functional-streams-for-scala/fs2/pull/1432.diff","patch_url":"https://github.com/functional-streams-for-scala/fs2/pull/1432.patch","issue_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/1432","number":1432,"state":"open","locked":false,"title":"Scalafix for replacing Sink with Pipe","user":{"login":"tmciver","id":742887,"node_id":"MDQ6VXNlcjc0Mjg4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/742887?v=4","gravatar_id":"","url":"https://api.github.com/users/tmciver","html_url":"https://github.com/tmciver","followers_url":"https://api.github.com/users/tmciver/followers","following_url":"https://api.github.com/users/tmciver/following{/other_user}","gists_url":"https://api.github.com/users/tmciver/gists{/gist_id}","starred_url":"https://api.github.com/users/tmciver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmciver/subscriptions","organizations_url":"https://api.github.com/users/tmciver/orgs","repos_url":"https://api.github.com/users/tmciver/repos","events_url":"https://api.github.com/users/tmciver/events{/privacy}","received_events_url":"https://api.github.com/users/tmciver/received_events","type":"User","site_admin":false},"body":"One possible issue with this PR is that there are 2 input and output files associated with this scalafix rule. Would it be preferred that they be combined into one?","created_at":"2019-03-21T21:25:20Z","updated_at":"2019-04-02T18:10:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e8f3740868f441f9b712ddbb6db3aeaf061f3f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/1432/commits","review_comments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/1432/comments","review_comment_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/1432/comments","statuses_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/statuses/b6f6c61c38a992217bb577b8014c13ebcb628c43","head":{"label":"tmciver:sink-to-pipe-scalafix","ref":"sink-to-pipe-scalafix","sha":"b6f6c61c38a992217bb577b8014c13ebcb628c43","user":{"login":"tmciver","id":742887,"node_id":"MDQ6VXNlcjc0Mjg4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/742887?v=4","gravatar_id":"","url":"https://api.github.com/users/tmciver","html_url":"https://github.com/tmciver","followers_url":"https://api.github.com/users/tmciver/followers","following_url":"https://api.github.com/users/tmciver/following{/other_user}","gists_url":"https://api.github.com/users/tmciver/gists{/gist_id}","starred_url":"https://api.github.com/users/tmciver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmciver/subscriptions","organizations_url":"https://api.github.com/users/tmciver/orgs","repos_url":"https://api.github.com/users/tmciver/repos","events_url":"https://api.github.com/users/tmciver/events{/privacy}","received_events_url":"https://api.github.com/users/tmciver/received_events","type":"User","site_admin":false},"repo":{"id":165298634,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUyOTg2MzQ=","name":"fs2","full_name":"tmciver/fs2","private":false,"owner":{"login":"tmciver","id":742887,"node_id":"MDQ6VXNlcjc0Mjg4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/742887?v=4","gravatar_id":"","url":"https://api.github.com/users/tmciver","html_url":"https://github.com/tmciver","followers_url":"https://api.github.com/users/tmciver/followers","following_url":"https://api.github.com/users/tmciver/following{/other_user}","gists_url":"https://api.github.com/users/tmciver/gists{/gist_id}","starred_url":"https://api.github.com/users/tmciver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmciver/subscriptions","organizations_url":"https://api.github.com/users/tmciver/orgs","repos_url":"https://api.github.com/users/tmciver/repos","events_url":"https://api.github.com/users/tmciver/events{/privacy}","received_events_url":"https://api.github.com/users/tmciver/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tmciver/fs2","description":"Compositional, streaming I/O library for Scala","fork":true,"url":"https://api.github.com/repos/tmciver/fs2","forks_url":"https://api.github.com/repos/tmciver/fs2/forks","keys_url":"https://api.github.com/repos/tmciver/fs2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmciver/fs2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmciver/fs2/teams","hooks_url":"https://api.github.com/repos/tmciver/fs2/hooks","issue_events_url":"https://api.github.com/repos/tmciver/fs2/issues/events{/number}","events_url":"https://api.github.com/repos/tmciver/fs2/events","assignees_url":"https://api.github.com/repos/tmciver/fs2/assignees{/user}","branches_url":"https://api.github.com/repos/tmciver/fs2/branches{/branch}","tags_url":"https://api.github.com/repos/tmciver/fs2/tags","blobs_url":"https://api.github.com/repos/tmciver/fs2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmciver/fs2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmciver/fs2/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmciver/fs2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmciver/fs2/statuses/{sha}","languages_url":"https://api.github.com/repos/tmciver/fs2/languages","stargazers_url":"https://api.github.com/repos/tmciver/fs2/stargazers","contributors_url":"https://api.github.com/repos/tmciver/fs2/contributors","subscribers_url":"https://api.github.com/repos/tmciver/fs2/subscribers","subscription_url":"https://api.github.com/repos/tmciver/fs2/subscription","commits_url":"https://api.github.com/repos/tmciver/fs2/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmciver/fs2/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmciver/fs2/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmciver/fs2/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmciver/fs2/contents/{+path}","compare_url":"https://api.github.com/repos/tmciver/fs2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmciver/fs2/merges","archive_url":"https://api.github.com/repos/tmciver/fs2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmciver/fs2/downloads","issues_url":"https://api.github.com/repos/tmciver/fs2/issues{/number}","pulls_url":"https://api.github.com/repos/tmciver/fs2/pulls{/number}","milestones_url":"https://api.github.com/repos/tmciver/fs2/milestones{/number}","notifications_url":"https://api.github.com/repos/tmciver/fs2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmciver/fs2/labels{/name}","releases_url":"https://api.github.com/repos/tmciver/fs2/releases{/id}","deployments_url":"https://api.github.com/repos/tmciver/fs2/deployments","created_at":"2019-01-11T19:33:05Z","updated_at":"2019-01-11T21:08:12Z","pushed_at":"2019-03-22T13:52:14Z","git_url":"git://github.com/tmciver/fs2.git","ssh_url":"git@github.com:tmciver/fs2.git","clone_url":"https://github.com/tmciver/fs2.git","svn_url":"https://github.com/tmciver/fs2","homepage":"https://fs2.io","size":9398,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"series/1.0"}},"base":{"label":"functional-streams-for-scala:series/1.0","ref":"series/1.0","sha":"a34ed54d3b9c07b98e704862cd6d081edbcdbdca","user":{"login":"functional-streams-for-scala","id":14128107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTI4MTA3","avatar_url":"https://avatars0.githubusercontent.com/u/14128107?v=4","gravatar_id":"","url":"https://api.github.com/users/functional-streams-for-scala","html_url":"https://github.com/functional-streams-for-scala","followers_url":"https://api.github.com/users/functional-streams-for-scala/followers","following_url":"https://api.github.com/users/functional-streams-for-scala/following{/other_user}","gists_url":"https://api.github.com/users/functional-streams-for-scala/gists{/gist_id}","starred_url":"https://api.github.com/users/functional-streams-for-scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/functional-streams-for-scala/subscriptions","organizations_url":"https://api.github.com/users/functional-streams-for-scala/orgs","repos_url":"https://api.github.com/users/functional-streams-for-scala/repos","events_url":"https://api.github.com/users/functional-streams-for-scala/events{/privacy}","received_events_url":"https://api.github.com/users/functional-streams-for-scala/received_events","type":"Organization","site_admin":false},"repo":{"id":8609125,"node_id":"MDEwOlJlcG9zaXRvcnk4NjA5MTI1","name":"fs2","full_name":"functional-streams-for-scala/fs2","private":false,"owner":{"login":"functional-streams-for-scala","id":14128107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTI4MTA3","avatar_url":"https://avatars0.githubusercontent.com/u/14128107?v=4","gravatar_id":"","url":"https://api.github.com/users/functional-streams-for-scala","html_url":"https://github.com/functional-streams-for-scala","followers_url":"https://api.github.com/users/functional-streams-for-scala/followers","following_url":"https://api.github.com/users/functional-streams-for-scala/following{/other_user}","gists_url":"https://api.github.com/users/functional-streams-for-scala/gists{/gist_id}","starred_url":"https://api.github.com/users/functional-streams-for-scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/functional-streams-for-scala/subscriptions","organizations_url":"https://api.github.com/users/functional-streams-for-scala/orgs","repos_url":"https://api.github.com/users/functional-streams-for-scala/repos","events_url":"https://api.github.com/users/functional-streams-for-scala/events{/privacy}","received_events_url":"https://api.github.com/users/functional-streams-for-scala/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/functional-streams-for-scala/fs2","description":"Compositional, streaming I/O library for Scala","fork":false,"url":"https://api.github.com/repos/functional-streams-for-scala/fs2","forks_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/forks","keys_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/teams","hooks_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/hooks","issue_events_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/events{/number}","events_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/events","assignees_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/assignees{/user}","branches_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/branches{/branch}","tags_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/tags","blobs_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/refs{/sha}","trees_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/statuses/{sha}","languages_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/languages","stargazers_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/stargazers","contributors_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/contributors","subscribers_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/subscribers","subscription_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/subscription","commits_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/commits{/sha}","git_commits_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/commits{/sha}","comments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/comments{/number}","issue_comment_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/comments{/number}","contents_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/contents/{+path}","compare_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/merges","archive_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/downloads","issues_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues{/number}","pulls_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls{/number}","milestones_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/milestones{/number}","notifications_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/labels{/name}","releases_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/releases{/id}","deployments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/deployments","created_at":"2013-03-06T17:34:15Z","updated_at":"2019-04-02T18:08:20Z","pushed_at":"2019-04-02T18:08:16Z","git_url":"git://github.com/functional-streams-for-scala/fs2.git","ssh_url":"git@github.com:functional-streams-for-scala/fs2.git","clone_url":"https://github.com/functional-streams-for-scala/fs2.git","svn_url":"https://github.com/functional-streams-for-scala/fs2","homepage":"https://fs2.io","size":9638,"stargazers_count":1362,"watchers_count":1362,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":348,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":348,"open_issues":34,"watchers":1362,"default_branch":"series/1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/1432"},"html":{"href":"https://github.com/functional-streams-for-scala/fs2/pull/1432"},"issue":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/1432"},"comments":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/1432/comments"},"review_comments":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/1432/comments"},"review_comment":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/1432/commits"},"statuses":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/statuses/b6f6c61c38a992217bb577b8014c13ebcb628c43"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 8609125,
"name": "functional-streams-for-scala/fs2",
"url": "https://api.github.com/repos/functional-streams-for-scala/fs2"
}
|
{
"id": 118078,
"login": "mpilquist",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/118078?",
"url": "https://api.github.com/users/mpilquist"
}
|
{
"id": 14128107,
"login": "functional-streams-for-scala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14128107?",
"url": "https://api.github.com/orgs/functional-streams-for-scala"
}
| 2019-04-02T18:10:13 |
9364334632
|
{"actor":{"display_login":"mpilquist"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/comments/340233829","pull_request_review_id":308716214,"id":340233829,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDIzMzgyOQ==","diff_hunk":"@@ -25,18 +24,15 @@\n return fragment;\n };\n \n- var dataSuccessHandler = function (photoData) {\n- window.data.photosData = photoData;\n- var picturesNode = accumulateNode(photoData, AMOUNT_DESCRIPTIONS);\n+ var renderGallery = function (data) {\n+ var picturesNode = accumulateNode(data, AMOUNT_DESCRIPTIONS);\n picturesList.appendChild(picturesNode);\n };\n \n- var renderPictureList = function () {\n- window.backend.initRequestDownload(dataSuccessHandler);\n- };\n-\n- renderPictureList();\n-\n document.querySelector('.social__comment-count').classList.add('visually-hidden');\n document.querySelector('.comments-loader').classList.add('visually-hidden');\n+\n+ window.gallery = {\n+ renderGallery: renderGallery","path":"js/gallery.js","position":30,"original_position":30,"commit_id":"286cbc7ad8fb030761fefeb51cba9059d4ff4d76","original_commit_id":"286cbc7ad8fb030761fefeb51cba9059d4ff4d76","user":{"login":"balesniy","id":16609542,"node_id":"MDQ6VXNlcjE2NjA5NTQy","avatar_url":"https://avatars1.githubusercontent.com/u/16609542?v=4","gravatar_id":"","url":"https://api.github.com/users/balesniy","html_url":"https://github.com/balesniy","followers_url":"https://api.github.com/users/balesniy/followers","following_url":"https://api.github.com/users/balesniy/following{/other_user}","gists_url":"https://api.github.com/users/balesniy/gists{/gist_id}","starred_url":"https://api.github.com/users/balesniy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balesniy/subscriptions","organizations_url":"https://api.github.com/users/balesniy/orgs","repos_url":"https://api.github.com/users/balesniy/repos","events_url":"https://api.github.com/users/balesniy/events{/privacy}","received_events_url":"https://api.github.com/users/balesniy/received_events","type":"User","site_admin":false},"body":"https://up.htmlacademy.ru/javascript/18/criteries#d3","created_at":"2019-10-29T17:51:06Z","updated_at":"2019-10-29T17:51:07Z","html_url":"https://github.com/htmlacademy-javascript/164805-kekstagram-18/pull/9#discussion_r340233829","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/9","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/comments/340233829"},"html":{"href":"https://github.com/htmlacademy-javascript/164805-kekstagram-18/pull/9#discussion_r340233829"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/9","id":333512097,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzNTEyMDk3","html_url":"https://github.com/htmlacademy-javascript/164805-kekstagram-18/pull/9","diff_url":"https://github.com/htmlacademy-javascript/164805-kekstagram-18/pull/9.diff","patch_url":"https://github.com/htmlacademy-javascript/164805-kekstagram-18/pull/9.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/issues/9","number":9,"state":"open","locked":false,"title":"Личный проект: воздушные формы","user":{"login":"pipols","id":19201745,"node_id":"MDQ6VXNlcjE5MjAxNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/19201745?v=4","gravatar_id":"","url":"https://api.github.com/users/pipols","html_url":"https://github.com/pipols","followers_url":"https://api.github.com/users/pipols/followers","following_url":"https://api.github.com/users/pipols/following{/other_user}","gists_url":"https://api.github.com/users/pipols/gists{/gist_id}","starred_url":"https://api.github.com/users/pipols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipols/subscriptions","organizations_url":"https://api.github.com/users/pipols/orgs","repos_url":"https://api.github.com/users/pipols/repos","events_url":"https://api.github.com/users/pipols/events{/privacy}","received_events_url":"https://api.github.com/users/pipols/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Личный проект: воздушные формы](https://up.htmlacademy.ru/javascript/18/user/164805/tasks/15)","created_at":"2019-10-29T09:27:26Z","updated_at":"2019-10-29T17:51:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"febe82e3dd8d345ebed4766f69751f47e12e72de","assignee":{"login":"balesniy","id":16609542,"node_id":"MDQ6VXNlcjE2NjA5NTQy","avatar_url":"https://avatars1.githubusercontent.com/u/16609542?v=4","gravatar_id":"","url":"https://api.github.com/users/balesniy","html_url":"https://github.com/balesniy","followers_url":"https://api.github.com/users/balesniy/followers","following_url":"https://api.github.com/users/balesniy/following{/other_user}","gists_url":"https://api.github.com/users/balesniy/gists{/gist_id}","starred_url":"https://api.github.com/users/balesniy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balesniy/subscriptions","organizations_url":"https://api.github.com/users/balesniy/orgs","repos_url":"https://api.github.com/users/balesniy/repos","events_url":"https://api.github.com/users/balesniy/events{/privacy}","received_events_url":"https://api.github.com/users/balesniy/received_events","type":"User","site_admin":false},"assignees":[{"login":"balesniy","id":16609542,"node_id":"MDQ6VXNlcjE2NjA5NTQy","avatar_url":"https://avatars1.githubusercontent.com/u/16609542?v=4","gravatar_id":"","url":"https://api.github.com/users/balesniy","html_url":"https://github.com/balesniy","followers_url":"https://api.github.com/users/balesniy/followers","following_url":"https://api.github.com/users/balesniy/following{/other_user}","gists_url":"https://api.github.com/users/balesniy/gists{/gist_id}","starred_url":"https://api.github.com/users/balesniy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balesniy/subscriptions","organizations_url":"https://api.github.com/users/balesniy/orgs","repos_url":"https://api.github.com/users/balesniy/repos","events_url":"https://api.github.com/users/balesniy/events{/privacy}","received_events_url":"https://api.github.com/users/balesniy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/9/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/9/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/issues/9/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/statuses/286cbc7ad8fb030761fefeb51cba9059d4ff4d76","head":{"label":"pipols:module6-task3","ref":"module6-task3","sha":"286cbc7ad8fb030761fefeb51cba9059d4ff4d76","user":{"login":"pipols","id":19201745,"node_id":"MDQ6VXNlcjE5MjAxNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/19201745?v=4","gravatar_id":"","url":"https://api.github.com/users/pipols","html_url":"https://github.com/pipols","followers_url":"https://api.github.com/users/pipols/followers","following_url":"https://api.github.com/users/pipols/following{/other_user}","gists_url":"https://api.github.com/users/pipols/gists{/gist_id}","starred_url":"https://api.github.com/users/pipols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipols/subscriptions","organizations_url":"https://api.github.com/users/pipols/orgs","repos_url":"https://api.github.com/users/pipols/repos","events_url":"https://api.github.com/users/pipols/events{/privacy}","received_events_url":"https://api.github.com/users/pipols/received_events","type":"User","site_admin":false},"repo":{"id":207838988,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc4Mzg5ODg=","name":"164805-kekstagram-18","full_name":"pipols/164805-kekstagram-18","private":false,"owner":{"login":"pipols","id":19201745,"node_id":"MDQ6VXNlcjE5MjAxNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/19201745?v=4","gravatar_id":"","url":"https://api.github.com/users/pipols","html_url":"https://github.com/pipols","followers_url":"https://api.github.com/users/pipols/followers","following_url":"https://api.github.com/users/pipols/following{/other_user}","gists_url":"https://api.github.com/users/pipols/gists{/gist_id}","starred_url":"https://api.github.com/users/pipols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipols/subscriptions","organizations_url":"https://api.github.com/users/pipols/orgs","repos_url":"https://api.github.com/users/pipols/repos","events_url":"https://api.github.com/users/pipols/events{/privacy}","received_events_url":"https://api.github.com/users/pipols/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pipols/164805-kekstagram-18","description":"Максим Дурандин","fork":true,"url":"https://api.github.com/repos/pipols/164805-kekstagram-18","forks_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/forks","keys_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/teams","hooks_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/hooks","issue_events_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/issues/events{/number}","events_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/events","assignees_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/assignees{/user}","branches_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/branches{/branch}","tags_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/tags","blobs_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/git/refs{/sha}","trees_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/statuses/{sha}","languages_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/languages","stargazers_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/stargazers","contributors_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/contributors","subscribers_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/subscribers","subscription_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/subscription","commits_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/commits{/sha}","git_commits_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/git/commits{/sha}","comments_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/comments{/number}","issue_comment_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/issues/comments{/number}","contents_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/contents/{+path}","compare_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/merges","archive_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/downloads","issues_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/issues{/number}","pulls_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/pulls{/number}","milestones_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/milestones{/number}","notifications_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/labels{/name}","releases_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/releases{/id}","deployments_url":"https://api.github.com/repos/pipols/164805-kekstagram-18/deployments","created_at":"2019-09-11T14:57:41Z","updated_at":"2019-10-27T18:36:10Z","pushed_at":"2019-10-29T08:52:39Z","git_url":"git://github.com/pipols/164805-kekstagram-18.git","ssh_url":"git@github.com:pipols/164805-kekstagram-18.git","clone_url":"https://github.com/pipols/164805-kekstagram-18.git","svn_url":"https://github.com/pipols/164805-kekstagram-18","homepage":null,"size":2255,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"1ca32eaad1709cb3e09f1c36de1c6cf1ac072aab","user":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":207718347,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc3MTgzNDc=","name":"164805-kekstagram-18","full_name":"htmlacademy-javascript/164805-kekstagram-18","private":false,"owner":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-javascript/164805-kekstagram-18","description":"Максим Дурандин","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18","forks_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/deployments","created_at":"2019-09-11T03:50:54Z","updated_at":"2019-10-27T16:15:32Z","pushed_at":"2019-10-29T09:27:27Z","git_url":"git://github.com/htmlacademy-javascript/164805-kekstagram-18.git","ssh_url":"git@github.com:htmlacademy-javascript/164805-kekstagram-18.git","clone_url":"https://github.com/htmlacademy-javascript/164805-kekstagram-18.git","svn_url":"https://github.com/htmlacademy-javascript/164805-kekstagram-18","homepage":"https://github.com/pipols/164805-kekstagram-18","size":2264,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/9"},"html":{"href":"https://github.com/htmlacademy-javascript/164805-kekstagram-18/pull/9"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/issues/9"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18/statuses/286cbc7ad8fb030761fefeb51cba9059d4ff4d76"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 207718347,
"name": "htmlacademy-javascript/164805-kekstagram-18",
"url": "https://api.github.com/repos/htmlacademy-javascript/164805-kekstagram-18"
}
|
{
"id": 16609542,
"login": "balesniy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16609542?",
"url": "https://api.github.com/users/balesniy"
}
|
{
"id": 14179712,
"login": "htmlacademy-javascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14179712?",
"url": "https://api.github.com/orgs/htmlacademy-javascript"
}
| 2019-10-29T17:51:06 |
10740262941
|
{"actor":{"display_login":"balesniy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/comments/294092760","pull_request_review_id":250239514,"id":294092760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDA5Mjc2MA==","diff_hunk":"@@ -18,7 +24,56 @@ var offersTypes = ['palace', 'flat', 'house', 'bungalo'];\n * Задает предварительные настройки\n */\n var setup = function () {\n- map[0].classList.remove('map--faded');\n+ activateFields(adFormInputs, 'deactivate');\n+ activateFields(adFormSelects, 'deactivate');\n+ findPinCoordinates('circle');\n+};\n+\n+/**\n+ * Переводит поля формы в указанное состояние (активное или неактивное)\n+ * @param {node[]} arr Массив, содержащий поля формы\n+ * @param {string} mode Указывает на текущий режим страницы, значение activate соответствует активному состоянию\n+ */\n+var activateFields = function (arr, mode) {\n+ for (var i = 0; i < arr.length; i++) {\n+ if (mode === 'activate') {\n+ arr[i].disabled = false; // Тут подчеркивате disabled серым цветом и пишет, что данное свойство не подходит для типа node.\n+ } else {\n+ arr[i].disabled = true; // Как быть? Ведь у меня тут могут быть и HTMLInputElement, и HTMLSelectElement, в JSDoc как-то можно указать несколько типов для параметра?\n+ }\n+ }\n+};\n+\n+/**\n+ * Находит текущие координаты метки и заполняет их значениями поле адреса\n+ * @param {string} mode Указывает на форму метки. Метка может быть круглой (в самом начале) или с острым концом снизу (shapeless)\n+ */\n+var findPinCoordinates = function (mode) {\n+ var mainPinX = mainPin.style.left;\n+ var mainPinY = mainPin.style.top;\n+ mainPinX = Number(mainPinX.substr(0, mainPinX.length - 2));\n+ mainPinY = Number(mainPinY.substr(0, mainPinY.length - 2));\n+ if (mode === 'shapeless') {\n+ mainPinX = mainPinX - PIN_WIDTH / 2;\n+ mainPinY = mainPinY - PIN_HEIGHT;\n+ }\n+ addressInput.value = mainPinX + ',' + mainPinY;\n+};\n+\n+/**\n+ * Переводит страницу в активное состояние после первого щелчка на метку\n+ */\n+var onMainPinMouseUp = function () {\n+ if (map[0].classList.contains('map--faded')) {\n+ map[0].classList.remove('map--faded');\n+ adForm.classList.remove('ad-form--disabled');\n+ mapFilter.classList.remove('map__filters--disabled');\n+ activateFields(adFormInputs, 'activate');\n+ activateFields(adFormSelects, 'activate');","path":"js/main.js","position":63,"original_position":63,"commit_id":"a746d6fa49df42615c991bc236757320b0738c50","original_commit_id":"a746d6fa49df42615c991bc236757320b0738c50","user":{"login":"catcococo","id":51405282,"node_id":"MDQ6VXNlcjUxNDA1Mjgy","avatar_url":"https://avatars2.githubusercontent.com/u/51405282?v=4","gravatar_id":"","url":"https://api.github.com/users/catcococo","html_url":"https://github.com/catcococo","followers_url":"https://api.github.com/users/catcococo/followers","following_url":"https://api.github.com/users/catcococo/following{/other_user}","gists_url":"https://api.github.com/users/catcococo/gists{/gist_id}","starred_url":"https://api.github.com/users/catcococo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catcococo/subscriptions","organizations_url":"https://api.github.com/users/catcococo/orgs","repos_url":"https://api.github.com/users/catcococo/repos","events_url":"https://api.github.com/users/catcococo/events{/privacy}","received_events_url":"https://api.github.com/users/catcococo/received_events","type":"User","site_admin":false},"body":"чтобы не вызывать функцию 4 раза подряд (а у тебя будет 4, когда добавишь textarea и button, собери все элементы формы в один массив","created_at":"2019-06-16T17:08:09Z","updated_at":"2019-06-16T17:08:23Z","html_url":"https://github.com/htmlacademy-javascript/928569-keksobooking-17/pull/3#discussion_r294092760","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/comments/294092760"},"html":{"href":"https://github.com/htmlacademy-javascript/928569-keksobooking-17/pull/3#discussion_r294092760"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/3","id":288589251,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NTg5MjUx","html_url":"https://github.com/htmlacademy-javascript/928569-keksobooking-17/pull/3","diff_url":"https://github.com/htmlacademy-javascript/928569-keksobooking-17/pull/3.diff","patch_url":"https://github.com/htmlacademy-javascript/928569-keksobooking-17/pull/3.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/issues/3","number":3,"state":"open","locked":false,"title":"Личный проект: подробности","user":{"login":"slegka0","id":44324112,"node_id":"MDQ6VXNlcjQ0MzI0MTEy","avatar_url":"https://avatars3.githubusercontent.com/u/44324112?v=4","gravatar_id":"","url":"https://api.github.com/users/slegka0","html_url":"https://github.com/slegka0","followers_url":"https://api.github.com/users/slegka0/followers","following_url":"https://api.github.com/users/slegka0/following{/other_user}","gists_url":"https://api.github.com/users/slegka0/gists{/gist_id}","starred_url":"https://api.github.com/users/slegka0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slegka0/subscriptions","organizations_url":"https://api.github.com/users/slegka0/orgs","repos_url":"https://api.github.com/users/slegka0/repos","events_url":"https://api.github.com/users/slegka0/events{/privacy}","received_events_url":"https://api.github.com/users/slegka0/received_events","type":"User","site_admin":false},"body":"+ нахождение координат метки\n\n---\n:mortar_board: [Личный проект: подробности](https://up.htmlacademy.ru/javascript/17/user/928569/tasks/7)\n\n:boom: https://htmlacademy-javascript.github.io/928569-keksobooking-17/3/","created_at":"2019-06-16T00:04:44Z","updated_at":"2019-06-16T17:08:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67c9f42e51a2b28e8f32d1a3a1feac84ef3b0bf6","assignee":{"login":"catcococo","id":51405282,"node_id":"MDQ6VXNlcjUxNDA1Mjgy","avatar_url":"https://avatars2.githubusercontent.com/u/51405282?v=4","gravatar_id":"","url":"https://api.github.com/users/catcococo","html_url":"https://github.com/catcococo","followers_url":"https://api.github.com/users/catcococo/followers","following_url":"https://api.github.com/users/catcococo/following{/other_user}","gists_url":"https://api.github.com/users/catcococo/gists{/gist_id}","starred_url":"https://api.github.com/users/catcococo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catcococo/subscriptions","organizations_url":"https://api.github.com/users/catcococo/orgs","repos_url":"https://api.github.com/users/catcococo/repos","events_url":"https://api.github.com/users/catcococo/events{/privacy}","received_events_url":"https://api.github.com/users/catcococo/received_events","type":"User","site_admin":false},"assignees":[{"login":"catcococo","id":51405282,"node_id":"MDQ6VXNlcjUxNDA1Mjgy","avatar_url":"https://avatars2.githubusercontent.com/u/51405282?v=4","gravatar_id":"","url":"https://api.github.com/users/catcococo","html_url":"https://github.com/catcococo","followers_url":"https://api.github.com/users/catcococo/followers","following_url":"https://api.github.com/users/catcococo/following{/other_user}","gists_url":"https://api.github.com/users/catcococo/gists{/gist_id}","starred_url":"https://api.github.com/users/catcococo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catcococo/subscriptions","organizations_url":"https://api.github.com/users/catcococo/orgs","repos_url":"https://api.github.com/users/catcococo/repos","events_url":"https://api.github.com/users/catcococo/events{/privacy}","received_events_url":"https://api.github.com/users/catcococo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/3/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/3/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/issues/3/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/statuses/a746d6fa49df42615c991bc236757320b0738c50","head":{"label":"slegka0:module4-task1","ref":"module4-task1","sha":"a746d6fa49df42615c991bc236757320b0738c50","user":{"login":"slegka0","id":44324112,"node_id":"MDQ6VXNlcjQ0MzI0MTEy","avatar_url":"https://avatars3.githubusercontent.com/u/44324112?v=4","gravatar_id":"","url":"https://api.github.com/users/slegka0","html_url":"https://github.com/slegka0","followers_url":"https://api.github.com/users/slegka0/followers","following_url":"https://api.github.com/users/slegka0/following{/other_user}","gists_url":"https://api.github.com/users/slegka0/gists{/gist_id}","starred_url":"https://api.github.com/users/slegka0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slegka0/subscriptions","organizations_url":"https://api.github.com/users/slegka0/orgs","repos_url":"https://api.github.com/users/slegka0/repos","events_url":"https://api.github.com/users/slegka0/events{/privacy}","received_events_url":"https://api.github.com/users/slegka0/received_events","type":"User","site_admin":false},"repo":{"id":189657748,"node_id":"MDEwOlJlcG9zaXRvcnkxODk2NTc3NDg=","name":"928569-keksobooking-17","full_name":"slegka0/928569-keksobooking-17","private":false,"owner":{"login":"slegka0","id":44324112,"node_id":"MDQ6VXNlcjQ0MzI0MTEy","avatar_url":"https://avatars3.githubusercontent.com/u/44324112?v=4","gravatar_id":"","url":"https://api.github.com/users/slegka0","html_url":"https://github.com/slegka0","followers_url":"https://api.github.com/users/slegka0/followers","following_url":"https://api.github.com/users/slegka0/following{/other_user}","gists_url":"https://api.github.com/users/slegka0/gists{/gist_id}","starred_url":"https://api.github.com/users/slegka0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slegka0/subscriptions","organizations_url":"https://api.github.com/users/slegka0/orgs","repos_url":"https://api.github.com/users/slegka0/repos","events_url":"https://api.github.com/users/slegka0/events{/privacy}","received_events_url":"https://api.github.com/users/slegka0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/slegka0/928569-keksobooking-17","description":"Дмитрий Беляев","fork":true,"url":"https://api.github.com/repos/slegka0/928569-keksobooking-17","forks_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/forks","keys_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/teams","hooks_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/hooks","issue_events_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/issues/events{/number}","events_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/events","assignees_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/assignees{/user}","branches_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/branches{/branch}","tags_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/tags","blobs_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/git/refs{/sha}","trees_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/statuses/{sha}","languages_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/languages","stargazers_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/stargazers","contributors_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/contributors","subscribers_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/subscribers","subscription_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/subscription","commits_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/commits{/sha}","git_commits_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/git/commits{/sha}","comments_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/comments{/number}","issue_comment_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/issues/comments{/number}","contents_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/contents/{+path}","compare_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/merges","archive_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/downloads","issues_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/issues{/number}","pulls_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/pulls{/number}","milestones_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/milestones{/number}","notifications_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/labels{/name}","releases_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/releases{/id}","deployments_url":"https://api.github.com/repos/slegka0/928569-keksobooking-17/deployments","created_at":"2019-05-31T20:59:15Z","updated_at":"2019-06-15T21:38:12Z","pushed_at":"2019-06-16T00:06:57Z","git_url":"git://github.com/slegka0/928569-keksobooking-17.git","ssh_url":"git@github.com:slegka0/928569-keksobooking-17.git","clone_url":"https://github.com/slegka0/928569-keksobooking-17.git","svn_url":"https://github.com/slegka0/928569-keksobooking-17","homepage":null,"size":888,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"bd530ff633725b5809f16e3cd7c9358d40663f2f","user":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":189651914,"node_id":"MDEwOlJlcG9zaXRvcnkxODk2NTE5MTQ=","name":"928569-keksobooking-17","full_name":"htmlacademy-javascript/928569-keksobooking-17","private":false,"owner":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-javascript/928569-keksobooking-17","description":"Дмитрий Беляев","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17","forks_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/deployments","created_at":"2019-05-31T20:03:46Z","updated_at":"2019-06-13T09:08:10Z","pushed_at":"2019-06-16T16:12:00Z","git_url":"git://github.com/htmlacademy-javascript/928569-keksobooking-17.git","ssh_url":"git@github.com:htmlacademy-javascript/928569-keksobooking-17.git","clone_url":"https://github.com/htmlacademy-javascript/928569-keksobooking-17.git","svn_url":"https://github.com/htmlacademy-javascript/928569-keksobooking-17","homepage":"https://github.com/slegka0/928569-keksobooking-17","size":890,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/3"},"html":{"href":"https://github.com/htmlacademy-javascript/928569-keksobooking-17/pull/3"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/issues/3"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17/statuses/a746d6fa49df42615c991bc236757320b0738c50"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 189651914,
"name": "htmlacademy-javascript/928569-keksobooking-17",
"url": "https://api.github.com/repos/htmlacademy-javascript/928569-keksobooking-17"
}
|
{
"id": 51405282,
"login": "catcococo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51405282?",
"url": "https://api.github.com/users/catcococo"
}
|
{
"id": 14179712,
"login": "htmlacademy-javascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14179712?",
"url": "https://api.github.com/orgs/htmlacademy-javascript"
}
| 2019-06-16T17:08:09 |
9831385267
|
{"actor":{"display_login":"catcococo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/comments/299631387","pull_request_review_id":257080454,"id":299631387,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTYzMTM4Nw==","diff_hunk":"@@ -1,107 +1,56 @@\n 'use strict';\n \n (function () {\n- var OFFERS_COUNT = 8;\n- var HOUSING_TYPES = ['palace', 'flat', 'house', 'bungalo'];\n- var HOUSING_TITLES = [\n- 'Большая уютная квартира',\n- 'Маленькая неуютная квартира',\n- 'Огромный прекрасный дворец',\n- 'Маленький ужасный дворец',\n- 'Красивый гостевой домик',\n- 'Некрасивый негостеприимный домик',\n- 'Уютное бунгало далеко от моря',\n- 'Неуютное бунгало по колено в воде'\n- ];\n- var PIN_WIDTH = 50;\n- var PIN_Y_MIN = 130;\n- var PIN_Y_MAX = 630;\n- var CONTAINER_SELECTOR = '.map';\n- var OFFERS_WRAPPER_SELECTOR = '.map__pins';\n- var MAIN_PIN_SELECTOR = '.map__pin--main';\n- var OFFER_TEMPLATE_SELECTOR = '#pin';\n- var OFFER_TEMPLATE_CONTENT_SELECTOR = '.map__pin';\n+ var filterForm = document.querySelector('.map__filters');\n \n- var map = document.querySelector(CONTAINER_SELECTOR);\n- var mapPinsArea = map.querySelector(OFFERS_WRAPPER_SELECTOR);\n+ var filter = {","path":"js/offers.js","position":28,"original_position":28,"commit_id":"9c0f06e3981560d17f35225f2bb0202cb2f0f675","original_commit_id":"9c0f06e3981560d17f35225f2bb0202cb2f0f675","user":{"login":"BykovDenis","id":6918640,"node_id":"MDQ6VXNlcjY5MTg2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6918640?v=4","gravatar_id":"","url":"https://api.github.com/users/BykovDenis","html_url":"https://github.com/BykovDenis","followers_url":"https://api.github.com/users/BykovDenis/followers","following_url":"https://api.github.com/users/BykovDenis/following{/other_user}","gists_url":"https://api.github.com/users/BykovDenis/gists{/gist_id}","starred_url":"https://api.github.com/users/BykovDenis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BykovDenis/subscriptions","organizations_url":"https://api.github.com/users/BykovDenis/orgs","repos_url":"https://api.github.com/users/BykovDenis/repos","events_url":"https://api.github.com/users/BykovDenis/events{/privacy}","received_events_url":"https://api.github.com/users/BykovDenis/received_events","type":"User","site_admin":false},"body":"Это перечисление Filter","created_at":"2019-07-02T18:46:03Z","updated_at":"2019-07-02T18:55:10Z","html_url":"https://github.com/htmlacademy-javascript/368057-keksobooking-17/pull/8#discussion_r299631387","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/comments/299631387"},"html":{"href":"https://github.com/htmlacademy-javascript/368057-keksobooking-17/pull/8#discussion_r299631387"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/8","id":293461568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzNDYxNTY4","html_url":"https://github.com/htmlacademy-javascript/368057-keksobooking-17/pull/8","diff_url":"https://github.com/htmlacademy-javascript/368057-keksobooking-17/pull/8.diff","patch_url":"https://github.com/htmlacademy-javascript/368057-keksobooking-17/pull/8.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/issues/8","number":8,"state":"open","locked":false,"title":"Личный проект: перламутровые пуговицы","user":{"login":"dmekhov","id":15914658,"node_id":"MDQ6VXNlcjE1OTE0NjU4","avatar_url":"https://avatars2.githubusercontent.com/u/15914658?v=4","gravatar_id":"","url":"https://api.github.com/users/dmekhov","html_url":"https://github.com/dmekhov","followers_url":"https://api.github.com/users/dmekhov/followers","following_url":"https://api.github.com/users/dmekhov/following{/other_user}","gists_url":"https://api.github.com/users/dmekhov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmekhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmekhov/subscriptions","organizations_url":"https://api.github.com/users/dmekhov/orgs","repos_url":"https://api.github.com/users/dmekhov/repos","events_url":"https://api.github.com/users/dmekhov/events{/privacy}","received_events_url":"https://api.github.com/users/dmekhov/received_events","type":"User","site_admin":false},"body":"Зависит от https://github.com/htmlacademy-javascript/368057-keksobooking-17/pull/7\n\n---\n:mortar_board: [Личный проект: перламутровые пуговицы](https://up.htmlacademy.ru/javascript/17/user/368057/tasks/16)\n\n:boom: https://htmlacademy-javascript.github.io/368057-keksobooking-17/8/","created_at":"2019-07-01T19:06:31Z","updated_at":"2019-07-02T18:55:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b25a911fa1471a6c757f840952a278ab1a072a3","assignee":{"login":"BykovDenis","id":6918640,"node_id":"MDQ6VXNlcjY5MTg2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6918640?v=4","gravatar_id":"","url":"https://api.github.com/users/BykovDenis","html_url":"https://github.com/BykovDenis","followers_url":"https://api.github.com/users/BykovDenis/followers","following_url":"https://api.github.com/users/BykovDenis/following{/other_user}","gists_url":"https://api.github.com/users/BykovDenis/gists{/gist_id}","starred_url":"https://api.github.com/users/BykovDenis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BykovDenis/subscriptions","organizations_url":"https://api.github.com/users/BykovDenis/orgs","repos_url":"https://api.github.com/users/BykovDenis/repos","events_url":"https://api.github.com/users/BykovDenis/events{/privacy}","received_events_url":"https://api.github.com/users/BykovDenis/received_events","type":"User","site_admin":false},"assignees":[{"login":"BykovDenis","id":6918640,"node_id":"MDQ6VXNlcjY5MTg2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6918640?v=4","gravatar_id":"","url":"https://api.github.com/users/BykovDenis","html_url":"https://github.com/BykovDenis","followers_url":"https://api.github.com/users/BykovDenis/followers","following_url":"https://api.github.com/users/BykovDenis/following{/other_user}","gists_url":"https://api.github.com/users/BykovDenis/gists{/gist_id}","starred_url":"https://api.github.com/users/BykovDenis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BykovDenis/subscriptions","organizations_url":"https://api.github.com/users/BykovDenis/orgs","repos_url":"https://api.github.com/users/BykovDenis/repos","events_url":"https://api.github.com/users/BykovDenis/events{/privacy}","received_events_url":"https://api.github.com/users/BykovDenis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/8/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/8/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/issues/8/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/statuses/9c0f06e3981560d17f35225f2bb0202cb2f0f675","head":{"label":"dmekhov:module7-task1","ref":"module7-task1","sha":"9c0f06e3981560d17f35225f2bb0202cb2f0f675","user":{"login":"dmekhov","id":15914658,"node_id":"MDQ6VXNlcjE1OTE0NjU4","avatar_url":"https://avatars2.githubusercontent.com/u/15914658?v=4","gravatar_id":"","url":"https://api.github.com/users/dmekhov","html_url":"https://github.com/dmekhov","followers_url":"https://api.github.com/users/dmekhov/followers","following_url":"https://api.github.com/users/dmekhov/following{/other_user}","gists_url":"https://api.github.com/users/dmekhov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmekhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmekhov/subscriptions","organizations_url":"https://api.github.com/users/dmekhov/orgs","repos_url":"https://api.github.com/users/dmekhov/repos","events_url":"https://api.github.com/users/dmekhov/events{/privacy}","received_events_url":"https://api.github.com/users/dmekhov/received_events","type":"User","site_admin":false},"repo":{"id":189864202,"node_id":"MDEwOlJlcG9zaXRvcnkxODk4NjQyMDI=","name":"368057-keksobooking-17","full_name":"dmekhov/368057-keksobooking-17","private":false,"owner":{"login":"dmekhov","id":15914658,"node_id":"MDQ6VXNlcjE1OTE0NjU4","avatar_url":"https://avatars2.githubusercontent.com/u/15914658?v=4","gravatar_id":"","url":"https://api.github.com/users/dmekhov","html_url":"https://github.com/dmekhov","followers_url":"https://api.github.com/users/dmekhov/followers","following_url":"https://api.github.com/users/dmekhov/following{/other_user}","gists_url":"https://api.github.com/users/dmekhov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmekhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmekhov/subscriptions","organizations_url":"https://api.github.com/users/dmekhov/orgs","repos_url":"https://api.github.com/users/dmekhov/repos","events_url":"https://api.github.com/users/dmekhov/events{/privacy}","received_events_url":"https://api.github.com/users/dmekhov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmekhov/368057-keksobooking-17","description":"Dmitriy Mekhov","fork":true,"url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17","forks_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/forks","keys_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/teams","hooks_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/hooks","issue_events_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/issues/events{/number}","events_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/events","assignees_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/assignees{/user}","branches_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/branches{/branch}","tags_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/tags","blobs_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/statuses/{sha}","languages_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/languages","stargazers_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/stargazers","contributors_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/contributors","subscribers_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/subscribers","subscription_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/subscription","commits_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/contents/{+path}","compare_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/merges","archive_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/downloads","issues_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/issues{/number}","pulls_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/pulls{/number}","milestones_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/milestones{/number}","notifications_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/labels{/name}","releases_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/releases{/id}","deployments_url":"https://api.github.com/repos/dmekhov/368057-keksobooking-17/deployments","created_at":"2019-06-02T15:36:37Z","updated_at":"2019-06-02T15:36:39Z","pushed_at":"2019-07-02T18:55:06Z","git_url":"git://github.com/dmekhov/368057-keksobooking-17.git","ssh_url":"git@github.com:dmekhov/368057-keksobooking-17.git","clone_url":"https://github.com/dmekhov/368057-keksobooking-17.git","svn_url":"https://github.com/dmekhov/368057-keksobooking-17","homepage":null,"size":901,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"5f11fc9406223566366e2129ebcff56d90dcb4fb","user":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":189863625,"node_id":"MDEwOlJlcG9zaXRvcnkxODk4NjM2MjU=","name":"368057-keksobooking-17","full_name":"htmlacademy-javascript/368057-keksobooking-17","private":false,"owner":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-javascript/368057-keksobooking-17","description":"Dmitriy Mekhov","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17","forks_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/deployments","created_at":"2019-06-02T15:31:12Z","updated_at":"2019-07-02T18:40:20Z","pushed_at":"2019-07-02T18:40:18Z","git_url":"git://github.com/htmlacademy-javascript/368057-keksobooking-17.git","ssh_url":"git@github.com:htmlacademy-javascript/368057-keksobooking-17.git","clone_url":"https://github.com/htmlacademy-javascript/368057-keksobooking-17.git","svn_url":"https://github.com/htmlacademy-javascript/368057-keksobooking-17","homepage":"https://github.com/dmekhov/368057-keksobooking-17","size":938,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/8"},"html":{"href":"https://github.com/htmlacademy-javascript/368057-keksobooking-17/pull/8"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/issues/8"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17/statuses/9c0f06e3981560d17f35225f2bb0202cb2f0f675"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 189863625,
"name": "htmlacademy-javascript/368057-keksobooking-17",
"url": "https://api.github.com/repos/htmlacademy-javascript/368057-keksobooking-17"
}
|
{
"id": 6918640,
"login": "BykovDenis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6918640?",
"url": "https://api.github.com/users/BykovDenis"
}
|
{
"id": 14179712,
"login": "htmlacademy-javascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14179712?",
"url": "https://api.github.com/orgs/htmlacademy-javascript"
}
| 2019-07-02T18:46:03 |
9936359366
|
{"actor":{"display_login":"BykovDenis"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/comments/290474684","pull_request_review_id":245674117,"id":290474684,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDQ3NDY4NA==","diff_hunk":"@@ -181,6 +181,28 @@ <h4 class=\"setup-similar-title\">Похожие персонажи</h4>\n </div>\n </template>\n \n+<script>\n+ var fireballSize = 22;\n+ var wizardSpeed = 3;\n+ var wizardWidth = 70;\n+\n+ var getFireballSize = function (left) {\n+ return left ? 5 : -2;","path":"index.html","position":10,"original_position":10,"commit_id":"f65d23baacfd68eee790b19867e3e819c8bba3e7","original_commit_id":"f65d23baacfd68eee790b19867e3e819c8bba3e7","user":{"login":"Shv-sergey70","id":35741647,"node_id":"MDQ6VXNlcjM1NzQxNjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/35741647?v=4","gravatar_id":"","url":"https://api.github.com/users/Shv-sergey70","html_url":"https://github.com/Shv-sergey70","followers_url":"https://api.github.com/users/Shv-sergey70/followers","following_url":"https://api.github.com/users/Shv-sergey70/following{/other_user}","gists_url":"https://api.github.com/users/Shv-sergey70/gists{/gist_id}","starred_url":"https://api.github.com/users/Shv-sergey70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shv-sergey70/subscriptions","organizations_url":"https://api.github.com/users/Shv-sergey70/orgs","repos_url":"https://api.github.com/users/Shv-sergey70/repos","events_url":"https://api.github.com/users/Shv-sergey70/events{/privacy}","received_events_url":"https://api.github.com/users/Shv-sergey70/received_events","type":"User","site_admin":false},"body":"> иначе он летит против ветра со скоростью 2\r\n\r\nПросто 2","created_at":"2019-06-04T20:07:21Z","updated_at":"2019-06-04T20:07:21Z","html_url":"https://github.com/htmlacademy-javascript/146834-code-and-magick-17/pull/1#discussion_r290474684","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/comments/290474684"},"html":{"href":"https://github.com/htmlacademy-javascript/146834-code-and-magick-17/pull/1#discussion_r290474684"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/1","id":285056351,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1MDU2MzUx","html_url":"https://github.com/htmlacademy-javascript/146834-code-and-magick-17/pull/1","diff_url":"https://github.com/htmlacademy-javascript/146834-code-and-magick-17/pull/1.diff","patch_url":"https://github.com/htmlacademy-javascript/146834-code-and-magick-17/pull/1.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/issues/1","number":1,"state":"open","locked":false,"title":"Учебный проект: начинаем программировать","user":{"login":"4ubaka447","id":32044738,"node_id":"MDQ6VXNlcjMyMDQ0NzM4","avatar_url":"https://avatars2.githubusercontent.com/u/32044738?v=4","gravatar_id":"","url":"https://api.github.com/users/4ubaka447","html_url":"https://github.com/4ubaka447","followers_url":"https://api.github.com/users/4ubaka447/followers","following_url":"https://api.github.com/users/4ubaka447/following{/other_user}","gists_url":"https://api.github.com/users/4ubaka447/gists{/gist_id}","starred_url":"https://api.github.com/users/4ubaka447/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4ubaka447/subscriptions","organizations_url":"https://api.github.com/users/4ubaka447/orgs","repos_url":"https://api.github.com/users/4ubaka447/repos","events_url":"https://api.github.com/users/4ubaka447/events{/privacy}","received_events_url":"https://api.github.com/users/4ubaka447/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Учебный проект: начинаем программировать](https://up.htmlacademy.ru/javascript/17/user/146834/tasks/2)","created_at":"2019-06-04T16:41:43Z","updated_at":"2019-06-04T20:07:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b052ba6c9b8e6b90cd5530e20522e191ca9fba67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/1/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/1/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/issues/1/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/statuses/f65d23baacfd68eee790b19867e3e819c8bba3e7","head":{"label":"4ubaka447:module1-task1","ref":"module1-task1","sha":"f65d23baacfd68eee790b19867e3e819c8bba3e7","user":{"login":"4ubaka447","id":32044738,"node_id":"MDQ6VXNlcjMyMDQ0NzM4","avatar_url":"https://avatars2.githubusercontent.com/u/32044738?v=4","gravatar_id":"","url":"https://api.github.com/users/4ubaka447","html_url":"https://github.com/4ubaka447","followers_url":"https://api.github.com/users/4ubaka447/followers","following_url":"https://api.github.com/users/4ubaka447/following{/other_user}","gists_url":"https://api.github.com/users/4ubaka447/gists{/gist_id}","starred_url":"https://api.github.com/users/4ubaka447/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4ubaka447/subscriptions","organizations_url":"https://api.github.com/users/4ubaka447/orgs","repos_url":"https://api.github.com/users/4ubaka447/repos","events_url":"https://api.github.com/users/4ubaka447/events{/privacy}","received_events_url":"https://api.github.com/users/4ubaka447/received_events","type":"User","site_admin":false},"repo":{"id":189821997,"node_id":"MDEwOlJlcG9zaXRvcnkxODk4MjE5OTc=","name":"146834-code-and-magick-17","full_name":"4ubaka447/146834-code-and-magick-17","private":false,"owner":{"login":"4ubaka447","id":32044738,"node_id":"MDQ6VXNlcjMyMDQ0NzM4","avatar_url":"https://avatars2.githubusercontent.com/u/32044738?v=4","gravatar_id":"","url":"https://api.github.com/users/4ubaka447","html_url":"https://github.com/4ubaka447","followers_url":"https://api.github.com/users/4ubaka447/followers","following_url":"https://api.github.com/users/4ubaka447/following{/other_user}","gists_url":"https://api.github.com/users/4ubaka447/gists{/gist_id}","starred_url":"https://api.github.com/users/4ubaka447/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4ubaka447/subscriptions","organizations_url":"https://api.github.com/users/4ubaka447/orgs","repos_url":"https://api.github.com/users/4ubaka447/repos","events_url":"https://api.github.com/users/4ubaka447/events{/privacy}","received_events_url":"https://api.github.com/users/4ubaka447/received_events","type":"User","site_admin":false},"html_url":"https://github.com/4ubaka447/146834-code-and-magick-17","description":"Ярослав Семенченко","fork":true,"url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17","forks_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/forks","keys_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/teams","hooks_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/hooks","issue_events_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/issues/events{/number}","events_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/events","assignees_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/assignees{/user}","branches_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/branches{/branch}","tags_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/tags","blobs_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/git/refs{/sha}","trees_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/statuses/{sha}","languages_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/languages","stargazers_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/stargazers","contributors_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/contributors","subscribers_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/subscribers","subscription_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/subscription","commits_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/commits{/sha}","git_commits_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/git/commits{/sha}","comments_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/comments{/number}","issue_comment_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/issues/comments{/number}","contents_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/contents/{+path}","compare_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/merges","archive_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/downloads","issues_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/issues{/number}","pulls_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/pulls{/number}","milestones_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/milestones{/number}","notifications_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/labels{/name}","releases_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/releases{/id}","deployments_url":"https://api.github.com/repos/4ubaka447/146834-code-and-magick-17/deployments","created_at":"2019-06-02T08:23:39Z","updated_at":"2019-06-02T08:23:42Z","pushed_at":"2019-06-04T16:39:42Z","git_url":"git://github.com/4ubaka447/146834-code-and-magick-17.git","ssh_url":"git@github.com:4ubaka447/146834-code-and-magick-17.git","clone_url":"https://github.com/4ubaka447/146834-code-and-magick-17.git","svn_url":"https://github.com/4ubaka447/146834-code-and-magick-17","homepage":null,"size":1070,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"f5a5c31663915adb9e5f4617aed4a649a03222fc","user":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":189642306,"node_id":"MDEwOlJlcG9zaXRvcnkxODk2NDIzMDY=","name":"146834-code-and-magick-17","full_name":"htmlacademy-javascript/146834-code-and-magick-17","private":false,"owner":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-javascript/146834-code-and-magick-17","description":"Ярослав Семенченко","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17","forks_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/deployments","created_at":"2019-05-31T18:44:08Z","updated_at":"2019-06-04T16:47:34Z","pushed_at":"2019-06-04T16:41:44Z","git_url":"git://github.com/htmlacademy-javascript/146834-code-and-magick-17.git","ssh_url":"git@github.com:htmlacademy-javascript/146834-code-and-magick-17.git","clone_url":"https://github.com/htmlacademy-javascript/146834-code-and-magick-17.git","svn_url":"https://github.com/htmlacademy-javascript/146834-code-and-magick-17","homepage":"https://github.com/4ubaka447/146834-code-and-magick-17","size":1070,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/1"},"html":{"href":"https://github.com/htmlacademy-javascript/146834-code-and-magick-17/pull/1"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/issues/1"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17/statuses/f65d23baacfd68eee790b19867e3e819c8bba3e7"}},"author_association":"NONE"}}
|
{
"id": 189642306,
"name": "htmlacademy-javascript/146834-code-and-magick-17",
"url": "https://api.github.com/repos/htmlacademy-javascript/146834-code-and-magick-17"
}
|
{
"id": 35741647,
"login": "Shv-sergey70",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35741647?",
"url": "https://api.github.com/users/Shv-sergey70"
}
|
{
"id": 14179712,
"login": "htmlacademy-javascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14179712?",
"url": "https://api.github.com/orgs/htmlacademy-javascript"
}
| 2019-06-04T20:07:21 |
9758189651
|
{"actor":{"display_login":"Shv-sergey70"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/352556628","pull_request_review_id":325188088,"id":352556628,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjU1NjYyOA==","diff_hunk":"@@ -0,0 +1,54 @@\n+#include \"testing/testing.hpp\"\n+\n+#include \"geometry/point2d.hpp\"\n+#include \"geometry/polyline2d.hpp\"\n+#include \"geometry/rect2d.hpp\"\n+\n+#include \"base/math.hpp\"\n+\n+namespace\n+{\n+double constexpr kEps = 1e-5;\n+\n+void TestClosest(m2::PolylineD const & poly, m2::PointD const & point, double expectedSquaredDist,\n+ uint32_t expectedIndex)\n+{\n+ auto const closest = poly.CalcMinSquaredDistance(m2::PointD(point));\n+ TEST(base::AlmostEqualAbs(closest.first, expectedSquaredDist, kEps),\n+ (closest.first, expectedSquaredDist));\n+ TEST_EQUAL(closest.second, expectedIndex, (closest.second, expectedIndex));\n+}\n+\n+UNIT_TEST(Rect_PolylineSmokeTest)\n+{\n+ m2::PolylineD poly = {{0.0, 0.0}, {1.0, 0.0}, {1.0, 1.0}};\n+ TEST_EQUAL(poly.GetSize(), 3, ());\n+ TEST(base::AlmostEqualAbs(poly.GetLength(), 2.0, kEps), ());","path":"geometry/geometry_tests/polyline_tests.cpp","position":26,"original_position":26,"commit_id":"5fea5d7c4918b718a74378477bb5d2a92e64734e","original_commit_id":"5fea5d7c4918b718a74378477bb5d2a92e64734e","user":{"login":"gmoryes","id":17534533,"node_id":"MDQ6VXNlcjE3NTM0NTMz","avatar_url":"https://avatars2.githubusercontent.com/u/17534533?v=4","gravatar_id":"","url":"https://api.github.com/users/gmoryes","html_url":"https://github.com/gmoryes","followers_url":"https://api.github.com/users/gmoryes/followers","following_url":"https://api.github.com/users/gmoryes/following{/other_user}","gists_url":"https://api.github.com/users/gmoryes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoryes/subscriptions","organizations_url":"https://api.github.com/users/gmoryes/orgs","repos_url":"https://api.github.com/users/gmoryes/repos","events_url":"https://api.github.com/users/gmoryes/events{/privacy}","received_events_url":"https://api.github.com/users/gmoryes/received_events","type":"User","site_admin":false},"body":"TEST_ALMOST_EQUAL_ABS","created_at":"2019-12-02T11:55:55Z","updated_at":"2019-12-02T11:55:56Z","html_url":"https://github.com/mapsme/omim/pull/12191#discussion_r352556628","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/12191","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/352556628"},"html":{"href":"https://github.com/mapsme/omim/pull/12191#discussion_r352556628"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/12191"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/12191","id":347582139,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3NTgyMTM5","html_url":"https://github.com/mapsme/omim/pull/12191","diff_url":"https://github.com/mapsme/omim/pull/12191.diff","patch_url":"https://github.com/mapsme/omim/pull/12191.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/12191","number":12191,"state":"open","locked":false,"title":"[geometry] polyline refactoring and tests.","user":{"login":"bykoianko","id":1768114,"node_id":"MDQ6VXNlcjE3NjgxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"body":"Рефакторинг. Добавил функциональности в ранее не используемый метод: Polyline ::CalcMinSquaredDistance()\r\nДобавил тесты на Polyline в целом и особенно на метод: olyline ::CalcMinSquaredDistance()\r\n\r\n@mesozoic-drones @gmoryes PTAL\r\n\r\nP.S. В xcode не добавил специально. Сейчас тесты в xcode вообще не работают. Договорился с @beloal о варианте починки. Сделаю отдельным PR-ом, тогда и добавлю.","created_at":"2019-12-02T11:44:04Z","updated_at":"2019-12-02T11:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b523474b7ea1633120723773ceb82259e41727d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/12191/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/12191/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/12191/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/5fea5d7c4918b718a74378477bb5d2a92e64734e","head":{"label":"bykoianko:master-Polyline-refactoring-and-tests","ref":"master-Polyline-refactoring-and-tests","sha":"5fea5d7c4918b718a74378477bb5d2a92e64734e","user":{"login":"bykoianko","id":1768114,"node_id":"MDQ6VXNlcjE3NjgxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"repo":{"id":43428862,"node_id":"MDEwOlJlcG9zaXRvcnk0MzQyODg2Mg==","name":"omim","full_name":"bykoianko/omim","private":false,"owner":{"login":"bykoianko","id":1768114,"node_id":"MDQ6VXNlcjE3NjgxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bykoianko/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/bykoianko/omim","forks_url":"https://api.github.com/repos/bykoianko/omim/forks","keys_url":"https://api.github.com/repos/bykoianko/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bykoianko/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bykoianko/omim/teams","hooks_url":"https://api.github.com/repos/bykoianko/omim/hooks","issue_events_url":"https://api.github.com/repos/bykoianko/omim/issues/events{/number}","events_url":"https://api.github.com/repos/bykoianko/omim/events","assignees_url":"https://api.github.com/repos/bykoianko/omim/assignees{/user}","branches_url":"https://api.github.com/repos/bykoianko/omim/branches{/branch}","tags_url":"https://api.github.com/repos/bykoianko/omim/tags","blobs_url":"https://api.github.com/repos/bykoianko/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bykoianko/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bykoianko/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/bykoianko/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bykoianko/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/bykoianko/omim/languages","stargazers_url":"https://api.github.com/repos/bykoianko/omim/stargazers","contributors_url":"https://api.github.com/repos/bykoianko/omim/contributors","subscribers_url":"https://api.github.com/repos/bykoianko/omim/subscribers","subscription_url":"https://api.github.com/repos/bykoianko/omim/subscription","commits_url":"https://api.github.com/repos/bykoianko/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/bykoianko/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/bykoianko/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/bykoianko/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/bykoianko/omim/contents/{+path}","compare_url":"https://api.github.com/repos/bykoianko/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bykoianko/omim/merges","archive_url":"https://api.github.com/repos/bykoianko/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bykoianko/omim/downloads","issues_url":"https://api.github.com/repos/bykoianko/omim/issues{/number}","pulls_url":"https://api.github.com/repos/bykoianko/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/bykoianko/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/bykoianko/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bykoianko/omim/labels{/name}","releases_url":"https://api.github.com/repos/bykoianko/omim/releases{/id}","deployments_url":"https://api.github.com/repos/bykoianko/omim/deployments","created_at":"2015-09-30T11:21:20Z","updated_at":"2018-12-25T06:33:03Z","pushed_at":"2019-12-02T11:41:07Z","git_url":"git://github.com/bykoianko/omim.git","ssh_url":"git@github.com:bykoianko/omim.git","clone_url":"https://github.com/bykoianko/omim.git","svn_url":"https://github.com/bykoianko/omim","homepage":null,"size":4378859,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"74f1d5b41f5395346a51072f300f45ae9bc49703","user":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc5ODAzMw==","name":"omim","full_name":"mapsme/omim","private":false,"owner":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2019-12-02T11:33:31Z","pushed_at":"2019-12-02T11:44:05Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":4560515,"stargazers_count":3164,"watchers_count":3164,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":676,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":890,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":676,"open_issues":890,"watchers":3164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/12191"},"html":{"href":"https://github.com/mapsme/omim/pull/12191"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/12191"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/12191/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/12191/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/12191/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/5fea5d7c4918b718a74378477bb5d2a92e64734e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 42798033,
"name": "mapsme/omim",
"url": "https://api.github.com/repos/mapsme/omim"
}
|
{
"id": 17534533,
"login": "gmoryes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17534533?",
"url": "https://api.github.com/users/gmoryes"
}
|
{
"id": 14185141,
"login": "mapsme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14185141?",
"url": "https://api.github.com/orgs/mapsme"
}
| 2019-12-02T11:55:55 |
10988751411
|
{"actor":{"display_login":"gmoryes"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/comments/297295299","pull_request_review_id":254133601,"id":297295299,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzI5NTI5OQ==","diff_hunk":"@@ -0,0 +1,223 @@\n+#!/usr/bin/env python\n+\n+# This program is free software; you can redistribute it and/or modify\n+# it under the terms of the GNU Affero General Public License as published by\n+# the Free Software Foundation; either version 3 of the License, or\n+# (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n+#\n+# See LICENSE for more details.\n+#\n+# Copyright (c) 2016 ScyllaDB\n+\n+import random\n+import string\n+import time\n+\n+from avocado import main","path":"performance_regression_row_level_repair_test.py","position":20,"original_position":20,"commit_id":"87fa02e29524847292c3ba8735575a5ed5a04208","original_commit_id":"87fa02e29524847292c3ba8735575a5ed5a04208","user":{"login":"bentsi","id":5269241,"node_id":"MDQ6VXNlcjUyNjkyNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5269241?v=4","gravatar_id":"","url":"https://api.github.com/users/bentsi","html_url":"https://github.com/bentsi","followers_url":"https://api.github.com/users/bentsi/followers","following_url":"https://api.github.com/users/bentsi/following{/other_user}","gists_url":"https://api.github.com/users/bentsi/gists{/gist_id}","starred_url":"https://api.github.com/users/bentsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bentsi/subscriptions","organizations_url":"https://api.github.com/users/bentsi/orgs","repos_url":"https://api.github.com/users/bentsi/repos","events_url":"https://api.github.com/users/bentsi/events{/privacy}","received_events_url":"https://api.github.com/users/bentsi/received_events","type":"User","site_admin":false},"body":"avocado was evicted :) Remove the imports","created_at":"2019-06-25T17:03:29Z","updated_at":"2019-06-25T17:07:20Z","html_url":"https://github.com/scylladb/scylla-cluster-tests/pull/823#discussion_r297295299","pull_request_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/823","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/comments/297295299"},"html":{"href":"https://github.com/scylladb/scylla-cluster-tests/pull/823#discussion_r297295299"},"pull_request":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/823"}}},"pull_request":{"url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/823","id":258713183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4NzEzMTgz","html_url":"https://github.com/scylladb/scylla-cluster-tests/pull/823","diff_url":"https://github.com/scylladb/scylla-cluster-tests/pull/823.diff","patch_url":"https://github.com/scylladb/scylla-cluster-tests/pull/823.patch","issue_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/823","number":823,"state":"open","locked":false,"title":"Row level repair","user":{"login":"yarongilor","id":9427929,"node_id":"MDQ6VXNlcjk0Mjc5Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/9427929?v=4","gravatar_id":"","url":"https://api.github.com/users/yarongilor","html_url":"https://github.com/yarongilor","followers_url":"https://api.github.com/users/yarongilor/followers","following_url":"https://api.github.com/users/yarongilor/following{/other_user}","gists_url":"https://api.github.com/users/yarongilor/gists{/gist_id}","starred_url":"https://api.github.com/users/yarongilor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarongilor/subscriptions","organizations_url":"https://api.github.com/users/yarongilor/orgs","repos_url":"https://api.github.com/users/yarongilor/repos","events_url":"https://api.github.com/users/yarongilor/events{/privacy}","received_events_url":"https://api.github.com/users/yarongilor/received_events","type":"User","site_admin":false},"body":"(1) Added row-level-repair performance test. \r\n(2) Support a specific given stats-param query on Elastic-Search.\r\n\r\nexample performance test output:\r\n```\r\n2019-03-06 11:21:33,231 results_analyze L0297 INFO | Performance result for: repair_runtime is: 60.0547149181. (average statistics deviation limit is: 23.2956554174\r\n2019-03-06 11:21:33,232 results_analyze L0302 INFO | Performance average of 8 results for: repair_runtime on version: 2.3.0 is: 13.7077978551\r\n2019-03-06 11:21:33,232 results_analyze L0302 INFO | Performance average of 4 results for: repair_runtime on version: 3.0.4 is: 19.4130461812\r\n2019-03-06 11:21:33,232 tester L1285 ERROR| Failed to check regression: Current test performance for: repair_runtime exceeds allowed deviation (23.2956554174)\r\n```","created_at":"2019-03-06T13:11:42Z","updated_at":"2019-06-25T17:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09b9a124ef4ba275147afb3e534b9e9abce00b7b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"roydahan","id":20959584,"node_id":"MDQ6VXNlcjIwOTU5NTg0","avatar_url":"https://avatars3.githubusercontent.com/u/20959584?v=4","gravatar_id":"","url":"https://api.github.com/users/roydahan","html_url":"https://github.com/roydahan","followers_url":"https://api.github.com/users/roydahan/followers","following_url":"https://api.github.com/users/roydahan/following{/other_user}","gists_url":"https://api.github.com/users/roydahan/gists{/gist_id}","starred_url":"https://api.github.com/users/roydahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roydahan/subscriptions","organizations_url":"https://api.github.com/users/roydahan/orgs","repos_url":"https://api.github.com/users/roydahan/repos","events_url":"https://api.github.com/users/roydahan/events{/privacy}","received_events_url":"https://api.github.com/users/roydahan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1276942490,"node_id":"MDU6TGFiZWwxMjc2OTQyNDkw","url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/labels/Backport-2019.1","name":"Backport-2019.1","color":"163c9e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/823/commits","review_comments_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/823/comments","review_comment_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/823/comments","statuses_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/statuses/87fa02e29524847292c3ba8735575a5ed5a04208","head":{"label":"yarongilor:row_level_repair","ref":"row_level_repair","sha":"87fa02e29524847292c3ba8735575a5ed5a04208","user":{"login":"yarongilor","id":9427929,"node_id":"MDQ6VXNlcjk0Mjc5Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/9427929?v=4","gravatar_id":"","url":"https://api.github.com/users/yarongilor","html_url":"https://github.com/yarongilor","followers_url":"https://api.github.com/users/yarongilor/followers","following_url":"https://api.github.com/users/yarongilor/following{/other_user}","gists_url":"https://api.github.com/users/yarongilor/gists{/gist_id}","starred_url":"https://api.github.com/users/yarongilor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarongilor/subscriptions","organizations_url":"https://api.github.com/users/yarongilor/orgs","repos_url":"https://api.github.com/users/yarongilor/repos","events_url":"https://api.github.com/users/yarongilor/events{/privacy}","received_events_url":"https://api.github.com/users/yarongilor/received_events","type":"User","site_admin":false},"repo":{"id":147674353,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc2NzQzNTM=","name":"scylla-cluster-tests","full_name":"yarongilor/scylla-cluster-tests","private":false,"owner":{"login":"yarongilor","id":9427929,"node_id":"MDQ6VXNlcjk0Mjc5Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/9427929?v=4","gravatar_id":"","url":"https://api.github.com/users/yarongilor","html_url":"https://github.com/yarongilor","followers_url":"https://api.github.com/users/yarongilor/followers","following_url":"https://api.github.com/users/yarongilor/following{/other_user}","gists_url":"https://api.github.com/users/yarongilor/gists{/gist_id}","starred_url":"https://api.github.com/users/yarongilor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarongilor/subscriptions","organizations_url":"https://api.github.com/users/yarongilor/orgs","repos_url":"https://api.github.com/users/yarongilor/repos","events_url":"https://api.github.com/users/yarongilor/events{/privacy}","received_events_url":"https://api.github.com/users/yarongilor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yarongilor/scylla-cluster-tests","description":"Tests for Scylla Clusters","fork":true,"url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests","forks_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/forks","keys_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/teams","hooks_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/hooks","issue_events_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/issues/events{/number}","events_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/events","assignees_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/assignees{/user}","branches_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/branches{/branch}","tags_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/tags","blobs_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/languages","stargazers_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/stargazers","contributors_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/contributors","subscribers_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/subscribers","subscription_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/subscription","commits_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/contents/{+path}","compare_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/merges","archive_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/downloads","issues_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/issues{/number}","pulls_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/labels{/name}","releases_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/releases{/id}","deployments_url":"https://api.github.com/repos/yarongilor/scylla-cluster-tests/deployments","created_at":"2018-09-06T13:01:24Z","updated_at":"2018-09-06T13:01:27Z","pushed_at":"2019-06-20T15:37:01Z","git_url":"git://github.com/yarongilor/scylla-cluster-tests.git","ssh_url":"git@github.com:yarongilor/scylla-cluster-tests.git","clone_url":"https://github.com/yarongilor/scylla-cluster-tests.git","svn_url":"https://github.com/yarongilor/scylla-cluster-tests","homepage":"","size":6144,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scylladb:master","ref":"master","sha":"71424e7a96616f5c6ea67c3afa66c80dd8f8e5d0","user":{"login":"scylladb","id":14364730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzY0NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/14364730?v=4","gravatar_id":"","url":"https://api.github.com/users/scylladb","html_url":"https://github.com/scylladb","followers_url":"https://api.github.com/users/scylladb/followers","following_url":"https://api.github.com/users/scylladb/following{/other_user}","gists_url":"https://api.github.com/users/scylladb/gists{/gist_id}","starred_url":"https://api.github.com/users/scylladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scylladb/subscriptions","organizations_url":"https://api.github.com/users/scylladb/orgs","repos_url":"https://api.github.com/users/scylladb/repos","events_url":"https://api.github.com/users/scylladb/events{/privacy}","received_events_url":"https://api.github.com/users/scylladb/received_events","type":"Organization","site_admin":false},"repo":{"id":48770856,"node_id":"MDEwOlJlcG9zaXRvcnk0ODc3MDg1Ng==","name":"scylla-cluster-tests","full_name":"scylladb/scylla-cluster-tests","private":false,"owner":{"login":"scylladb","id":14364730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzY0NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/14364730?v=4","gravatar_id":"","url":"https://api.github.com/users/scylladb","html_url":"https://github.com/scylladb","followers_url":"https://api.github.com/users/scylladb/followers","following_url":"https://api.github.com/users/scylladb/following{/other_user}","gists_url":"https://api.github.com/users/scylladb/gists{/gist_id}","starred_url":"https://api.github.com/users/scylladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scylladb/subscriptions","organizations_url":"https://api.github.com/users/scylladb/orgs","repos_url":"https://api.github.com/users/scylladb/repos","events_url":"https://api.github.com/users/scylladb/events{/privacy}","received_events_url":"https://api.github.com/users/scylladb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scylladb/scylla-cluster-tests","description":"Tests for Scylla Clusters","fork":false,"url":"https://api.github.com/repos/scylladb/scylla-cluster-tests","forks_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/forks","keys_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/teams","hooks_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/hooks","issue_events_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/events{/number}","events_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/events","assignees_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/assignees{/user}","branches_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/branches{/branch}","tags_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/tags","blobs_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/languages","stargazers_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/stargazers","contributors_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/contributors","subscribers_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/subscribers","subscription_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/subscription","commits_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/contents/{+path}","compare_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/merges","archive_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/downloads","issues_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues{/number}","pulls_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/labels{/name}","releases_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/releases{/id}","deployments_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/deployments","created_at":"2015-12-29T23:03:42Z","updated_at":"2019-06-25T07:35:22Z","pushed_at":"2019-06-25T16:28:12Z","git_url":"git://github.com/scylladb/scylla-cluster-tests.git","ssh_url":"git@github.com:scylladb/scylla-cluster-tests.git","clone_url":"https://github.com/scylladb/scylla-cluster-tests.git","svn_url":"https://github.com/scylladb/scylla-cluster-tests","homepage":"","size":6462,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":55,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":24,"open_issues":55,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/823"},"html":{"href":"https://github.com/scylladb/scylla-cluster-tests/pull/823"},"issue":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/823"},"comments":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/823/comments"},"review_comments":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/823/comments"},"review_comment":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/823/commits"},"statuses":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/statuses/87fa02e29524847292c3ba8735575a5ed5a04208"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 48770856,
"name": "scylladb/scylla-cluster-tests",
"url": "https://api.github.com/repos/scylladb/scylla-cluster-tests"
}
|
{
"id": 5269241,
"login": "bentsi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5269241?",
"url": "https://api.github.com/users/bentsi"
}
|
{
"id": 14364730,
"login": "scylladb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14364730?",
"url": "https://api.github.com/orgs/scylladb"
}
| 2019-06-25T17:03:29 |
9891109076
|
{"actor":{"display_login":"bentsi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/comments/272837413","pull_request_review_id":223583884,"id":272837413,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MjgzNzQxMw==","diff_hunk":"@@ -431,29 +437,35 @@ def approach_enospc():\n self.log.error(str(details))\n return search_database_enospc(node) > orig_errors\n \n- for node in nodes:\n- result = node.remoter.run('cat /proc/mounts')\n- if '/var/lib/scylla' not in result.stdout:\n- self.log.error(\"Scylla doesn't use an individual storage, skip enospc test\")\n- continue\n-\n- # check original ENOSPC error\n- orig_errors = search_database_enospc(node)\n- wait.wait_for(func=approach_enospc,\n- timeout=300,\n- step=5,\n- text='Wait for new ENOSPC error occurs in database')\n-\n- self.log.debug('Sleep {} seconds before releasing space to scylla'.format(sleep_time))\n- time.sleep(sleep_time)\n-\n- self.log.debug('Delete occupy_90percent file to release space to scylla-server')\n- node.remoter.run('sudo rm -rf /var/lib/scylla/occupy_90percent.*')\n-\n- self.log.debug('Sleep a while before restart scylla-server')\n- time.sleep(sleep_time / 2)\n- node.remoter.run('sudo systemctl restart scylla-server.service')\n- node.wait_db_up()\n+ enospc_log_filter = EventsFilter(name='filter_enospc', filter_name='NO_SPACE_ERROR')\n+ enospc_backtrace_filter = EventsFilter(name='filter_enospc_backtrace', filter_name='BACKTRACE', filter_string='No space left on device')","path":"sdcm/nemesis.py","position":55,"original_position":55,"commit_id":"1e41b2e0694476be74ded8a32708b650fb01f867","original_commit_id":"1e41b2e0694476be74ded8a32708b650fb01f867","user":{"login":"bentsi","id":5269241,"node_id":"MDQ6VXNlcjUyNjkyNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5269241?v=4","gravatar_id":"","url":"https://api.github.com/users/bentsi","html_url":"https://github.com/bentsi","followers_url":"https://api.github.com/users/bentsi/followers","following_url":"https://api.github.com/users/bentsi/following{/other_user}","gists_url":"https://api.github.com/users/bentsi/gists{/gist_id}","starred_url":"https://api.github.com/users/bentsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bentsi/subscriptions","organizations_url":"https://api.github.com/users/bentsi/orgs","repos_url":"https://api.github.com/users/bentsi/repos","events_url":"https://api.github.com/users/bentsi/events{/privacy}","received_events_url":"https://api.github.com/users/bentsi/received_events","type":"User","site_admin":false},"body":"API: EventsFilter(type=..., string=)\r\nremove `name` argument and use `id` of the object to identify in list of events","created_at":"2019-04-07T14:34:06Z","updated_at":"2019-04-07T14:48:38Z","html_url":"https://github.com/scylladb/scylla-cluster-tests/pull/861#discussion_r272837413","pull_request_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/861","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/comments/272837413"},"html":{"href":"https://github.com/scylladb/scylla-cluster-tests/pull/861#discussion_r272837413"},"pull_request":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/861"}}},"pull_request":{"url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/861","id":264566718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0NTY2NzE4","html_url":"https://github.com/scylladb/scylla-cluster-tests/pull/861","diff_url":"https://github.com/scylladb/scylla-cluster-tests/pull/861.diff","patch_url":"https://github.com/scylladb/scylla-cluster-tests/pull/861.patch","issue_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/861","number":861,"state":"open","locked":false,"title":"Adding sct_events basic","user":{"login":"fruch","id":340979,"node_id":"MDQ6VXNlcjM0MDk3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/340979?v=4","gravatar_id":"","url":"https://api.github.com/users/fruch","html_url":"https://github.com/fruch","followers_url":"https://api.github.com/users/fruch/followers","following_url":"https://api.github.com/users/fruch/following{/other_user}","gists_url":"https://api.github.com/users/fruch/gists{/gist_id}","starred_url":"https://api.github.com/users/fruch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fruch/subscriptions","organizations_url":"https://api.github.com/users/fruch/orgs","repos_url":"https://api.github.com/users/fruch/repos","events_url":"https://api.github.com/users/fruch/events{/privacy}","received_events_url":"https://api.github.com/users/fruch/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-26T15:17:17Z","updated_at":"2019-04-07T14:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f3146242de374746755715e7511bf2c1282d697","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1278182254,"node_id":"MDU6TGFiZWwxMjc4MTgyMjU0","url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/labels/No%20Backport%20Needed","name":"No Backport Needed","color":"d2f9a7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/861/commits","review_comments_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/861/comments","review_comment_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/861/comments","statuses_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/statuses/1e41b2e0694476be74ded8a32708b650fb01f867","head":{"label":"fruch:sct_events","ref":"sct_events","sha":"1e41b2e0694476be74ded8a32708b650fb01f867","user":{"login":"fruch","id":340979,"node_id":"MDQ6VXNlcjM0MDk3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/340979?v=4","gravatar_id":"","url":"https://api.github.com/users/fruch","html_url":"https://github.com/fruch","followers_url":"https://api.github.com/users/fruch/followers","following_url":"https://api.github.com/users/fruch/following{/other_user}","gists_url":"https://api.github.com/users/fruch/gists{/gist_id}","starred_url":"https://api.github.com/users/fruch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fruch/subscriptions","organizations_url":"https://api.github.com/users/fruch/orgs","repos_url":"https://api.github.com/users/fruch/repos","events_url":"https://api.github.com/users/fruch/events{/privacy}","received_events_url":"https://api.github.com/users/fruch/received_events","type":"User","site_admin":false},"repo":{"id":169052202,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNTIyMDI=","name":"scylla-cluster-tests","full_name":"fruch/scylla-cluster-tests","private":false,"owner":{"login":"fruch","id":340979,"node_id":"MDQ6VXNlcjM0MDk3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/340979?v=4","gravatar_id":"","url":"https://api.github.com/users/fruch","html_url":"https://github.com/fruch","followers_url":"https://api.github.com/users/fruch/followers","following_url":"https://api.github.com/users/fruch/following{/other_user}","gists_url":"https://api.github.com/users/fruch/gists{/gist_id}","starred_url":"https://api.github.com/users/fruch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fruch/subscriptions","organizations_url":"https://api.github.com/users/fruch/orgs","repos_url":"https://api.github.com/users/fruch/repos","events_url":"https://api.github.com/users/fruch/events{/privacy}","received_events_url":"https://api.github.com/users/fruch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fruch/scylla-cluster-tests","description":"Tests for Scylla Clusters","fork":true,"url":"https://api.github.com/repos/fruch/scylla-cluster-tests","forks_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/forks","keys_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/teams","hooks_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/hooks","issue_events_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/issues/events{/number}","events_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/events","assignees_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/assignees{/user}","branches_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/branches{/branch}","tags_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/tags","blobs_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/languages","stargazers_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/stargazers","contributors_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/contributors","subscribers_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/subscribers","subscription_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/subscription","commits_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/contents/{+path}","compare_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/merges","archive_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/downloads","issues_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/issues{/number}","pulls_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/labels{/name}","releases_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/releases{/id}","deployments_url":"https://api.github.com/repos/fruch/scylla-cluster-tests/deployments","created_at":"2019-02-04T09:06:11Z","updated_at":"2019-03-31T20:23:18Z","pushed_at":"2019-04-07T13:28:03Z","git_url":"git://github.com/fruch/scylla-cluster-tests.git","ssh_url":"git@github.com:fruch/scylla-cluster-tests.git","clone_url":"https://github.com/fruch/scylla-cluster-tests.git","svn_url":"https://github.com/fruch/scylla-cluster-tests","homepage":"","size":5460,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"scylladb:master","ref":"master","sha":"04b8f0e5cd73c4aa3f0f3a3544322855a3d4bd17","user":{"login":"scylladb","id":14364730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzY0NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/14364730?v=4","gravatar_id":"","url":"https://api.github.com/users/scylladb","html_url":"https://github.com/scylladb","followers_url":"https://api.github.com/users/scylladb/followers","following_url":"https://api.github.com/users/scylladb/following{/other_user}","gists_url":"https://api.github.com/users/scylladb/gists{/gist_id}","starred_url":"https://api.github.com/users/scylladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scylladb/subscriptions","organizations_url":"https://api.github.com/users/scylladb/orgs","repos_url":"https://api.github.com/users/scylladb/repos","events_url":"https://api.github.com/users/scylladb/events{/privacy}","received_events_url":"https://api.github.com/users/scylladb/received_events","type":"Organization","site_admin":false},"repo":{"id":48770856,"node_id":"MDEwOlJlcG9zaXRvcnk0ODc3MDg1Ng==","name":"scylla-cluster-tests","full_name":"scylladb/scylla-cluster-tests","private":false,"owner":{"login":"scylladb","id":14364730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzY0NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/14364730?v=4","gravatar_id":"","url":"https://api.github.com/users/scylladb","html_url":"https://github.com/scylladb","followers_url":"https://api.github.com/users/scylladb/followers","following_url":"https://api.github.com/users/scylladb/following{/other_user}","gists_url":"https://api.github.com/users/scylladb/gists{/gist_id}","starred_url":"https://api.github.com/users/scylladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scylladb/subscriptions","organizations_url":"https://api.github.com/users/scylladb/orgs","repos_url":"https://api.github.com/users/scylladb/repos","events_url":"https://api.github.com/users/scylladb/events{/privacy}","received_events_url":"https://api.github.com/users/scylladb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scylladb/scylla-cluster-tests","description":"Tests for Scylla Clusters","fork":false,"url":"https://api.github.com/repos/scylladb/scylla-cluster-tests","forks_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/forks","keys_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/teams","hooks_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/hooks","issue_events_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/events{/number}","events_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/events","assignees_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/assignees{/user}","branches_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/branches{/branch}","tags_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/tags","blobs_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/languages","stargazers_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/stargazers","contributors_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/contributors","subscribers_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/subscribers","subscription_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/subscription","commits_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/contents/{+path}","compare_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/merges","archive_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/downloads","issues_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues{/number}","pulls_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/labels{/name}","releases_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/releases{/id}","deployments_url":"https://api.github.com/repos/scylladb/scylla-cluster-tests/deployments","created_at":"2015-12-29T23:03:42Z","updated_at":"2019-04-07T13:58:37Z","pushed_at":"2019-04-07T13:58:34Z","git_url":"git://github.com/scylladb/scylla-cluster-tests.git","ssh_url":"git@github.com:scylladb/scylla-cluster-tests.git","clone_url":"https://github.com/scylladb/scylla-cluster-tests.git","svn_url":"https://github.com/scylladb/scylla-cluster-tests","homepage":"","size":5534,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":44,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":22,"open_issues":44,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/861"},"html":{"href":"https://github.com/scylladb/scylla-cluster-tests/pull/861"},"issue":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/861"},"comments":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/scylladb/scylla-cluster-tests/statuses/1e41b2e0694476be74ded8a32708b650fb01f867"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 48770856,
"name": "scylladb/scylla-cluster-tests",
"url": "https://api.github.com/repos/scylladb/scylla-cluster-tests"
}
|
{
"id": 5269241,
"login": "bentsi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5269241?",
"url": "https://api.github.com/users/bentsi"
}
|
{
"id": 14364730,
"login": "scylladb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14364730?",
"url": "https://api.github.com/orgs/scylladb"
}
| 2019-04-07T14:34:06 |
9393845062
|
{"actor":{"display_login":"bentsi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/comments/277218164","pull_request_review_id":228971659,"id":277218164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzIxODE2NA==","diff_hunk":"@@ -26,3 +26,4 @@ members = [\n \n [dev-dependencies]\n shared = { path = \"shared\" }\n+libc = { version = \"0.2.14\", default-features = false }","path":"Cargo.toml","position":4,"original_position":4,"commit_id":"1638996c666c6532c53ec298cab4f4a91b1e4a2d","original_commit_id":"1638996c666c6532c53ec298cab4f4a91b1e4a2d","user":{"login":"gnzlbg","id":904614,"node_id":"MDQ6VXNlcjkwNDYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/904614?v=4","gravatar_id":"","url":"https://api.github.com/users/gnzlbg","html_url":"https://github.com/gnzlbg","followers_url":"https://api.github.com/users/gnzlbg/followers","following_url":"https://api.github.com/users/gnzlbg/following{/other_user}","gists_url":"https://api.github.com/users/gnzlbg/gists{/gist_id}","starred_url":"https://api.github.com/users/gnzlbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnzlbg/subscriptions","organizations_url":"https://api.github.com/users/gnzlbg/orgs","repos_url":"https://api.github.com/users/gnzlbg/repos","events_url":"https://api.github.com/users/gnzlbg/events{/privacy}","received_events_url":"https://api.github.com/users/gnzlbg/received_events","type":"User","site_admin":false},"body":"This libc version is really old. Why isn't this just `0.2` ?","created_at":"2019-04-22T06:40:18Z","updated_at":"2019-04-22T06:41:51Z","html_url":"https://github.com/rust-lang-nursery/libm/pull/159#discussion_r277218164","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/159","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/comments/277218164"},"html":{"href":"https://github.com/rust-lang-nursery/libm/pull/159#discussion_r277218164"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/159","id":270313046,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMzEzMDQ2","html_url":"https://github.com/rust-lang-nursery/libm/pull/159","diff_url":"https://github.com/rust-lang-nursery/libm/pull/159.diff","patch_url":"https://github.com/rust-lang-nursery/libm/pull/159.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/libm/issues/159","number":159,"state":"open","locked":false,"title":"fix build and test","user":{"login":"Yoopo","id":1165445,"node_id":"MDQ6VXNlcjExNjU0NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1165445?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoopo","html_url":"https://github.com/Yoopo","followers_url":"https://api.github.com/users/Yoopo/followers","following_url":"https://api.github.com/users/Yoopo/following{/other_user}","gists_url":"https://api.github.com/users/Yoopo/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoopo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoopo/subscriptions","organizations_url":"https://api.github.com/users/Yoopo/orgs","repos_url":"https://api.github.com/users/Yoopo/repos","events_url":"https://api.github.com/users/Yoopo/events{/privacy}","received_events_url":"https://api.github.com/users/Yoopo/received_events","type":"User","site_admin":false},"body":"- refactor exact_chunks to chunks_exact\r\n- refactor to_bytes which as been deprecated\r\n- remove qemu-arm-rt dependence which as been deprecated and does not compile\r\n- refactor newlib test generation code\r\n- extract common code in a template folder","created_at":"2019-04-14T17:29:19Z","updated_at":"2019-04-22T06:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cd660a00e3689e8f98700b53636d199f0798281","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/159/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/159/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/libm/issues/159/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/libm/statuses/1638996c666c6532c53ec298cab4f4a91b1e4a2d","head":{"label":"Yoopo:fix-test-suite","ref":"fix-test-suite","sha":"1638996c666c6532c53ec298cab4f4a91b1e4a2d","user":{"login":"Yoopo","id":1165445,"node_id":"MDQ6VXNlcjExNjU0NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1165445?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoopo","html_url":"https://github.com/Yoopo","followers_url":"https://api.github.com/users/Yoopo/followers","following_url":"https://api.github.com/users/Yoopo/following{/other_user}","gists_url":"https://api.github.com/users/Yoopo/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoopo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoopo/subscriptions","organizations_url":"https://api.github.com/users/Yoopo/orgs","repos_url":"https://api.github.com/users/Yoopo/repos","events_url":"https://api.github.com/users/Yoopo/events{/privacy}","received_events_url":"https://api.github.com/users/Yoopo/received_events","type":"User","site_admin":false},"repo":{"id":141455506,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0NTU1MDY=","name":"libm","full_name":"Yoopo/libm","private":false,"owner":{"login":"Yoopo","id":1165445,"node_id":"MDQ6VXNlcjExNjU0NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1165445?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoopo","html_url":"https://github.com/Yoopo","followers_url":"https://api.github.com/users/Yoopo/followers","following_url":"https://api.github.com/users/Yoopo/following{/other_user}","gists_url":"https://api.github.com/users/Yoopo/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoopo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoopo/subscriptions","organizations_url":"https://api.github.com/users/Yoopo/orgs","repos_url":"https://api.github.com/users/Yoopo/repos","events_url":"https://api.github.com/users/Yoopo/events{/privacy}","received_events_url":"https://api.github.com/users/Yoopo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Yoopo/libm","description":"A port of MUSL's libm to Rust.","fork":true,"url":"https://api.github.com/repos/Yoopo/libm","forks_url":"https://api.github.com/repos/Yoopo/libm/forks","keys_url":"https://api.github.com/repos/Yoopo/libm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoopo/libm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoopo/libm/teams","hooks_url":"https://api.github.com/repos/Yoopo/libm/hooks","issue_events_url":"https://api.github.com/repos/Yoopo/libm/issues/events{/number}","events_url":"https://api.github.com/repos/Yoopo/libm/events","assignees_url":"https://api.github.com/repos/Yoopo/libm/assignees{/user}","branches_url":"https://api.github.com/repos/Yoopo/libm/branches{/branch}","tags_url":"https://api.github.com/repos/Yoopo/libm/tags","blobs_url":"https://api.github.com/repos/Yoopo/libm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoopo/libm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoopo/libm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoopo/libm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoopo/libm/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoopo/libm/languages","stargazers_url":"https://api.github.com/repos/Yoopo/libm/stargazers","contributors_url":"https://api.github.com/repos/Yoopo/libm/contributors","subscribers_url":"https://api.github.com/repos/Yoopo/libm/subscribers","subscription_url":"https://api.github.com/repos/Yoopo/libm/subscription","commits_url":"https://api.github.com/repos/Yoopo/libm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoopo/libm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoopo/libm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoopo/libm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoopo/libm/contents/{+path}","compare_url":"https://api.github.com/repos/Yoopo/libm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoopo/libm/merges","archive_url":"https://api.github.com/repos/Yoopo/libm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoopo/libm/downloads","issues_url":"https://api.github.com/repos/Yoopo/libm/issues{/number}","pulls_url":"https://api.github.com/repos/Yoopo/libm/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoopo/libm/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoopo/libm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoopo/libm/labels{/name}","releases_url":"https://api.github.com/repos/Yoopo/libm/releases{/id}","deployments_url":"https://api.github.com/repos/Yoopo/libm/deployments","created_at":"2018-07-18T15:39:24Z","updated_at":"2019-04-06T16:33:04Z","pushed_at":"2019-04-14T17:26:01Z","git_url":"git://github.com/Yoopo/libm.git","ssh_url":"git@github.com:Yoopo/libm.git","clone_url":"https://github.com/Yoopo/libm.git","svn_url":"https://github.com/Yoopo/libm","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"3559e703795d33e84a91da2a35f2f3baac47e872","user":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":140666750,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2NjY3NTA=","name":"libm","full_name":"rust-lang-nursery/libm","private":false,"owner":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang-nursery/libm","description":"A port of MUSL's libm to Rust.","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/libm","forks_url":"https://api.github.com/repos/rust-lang-nursery/libm/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/libm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/libm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/libm/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/libm/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/libm/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/libm/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/libm/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/libm/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/libm/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/libm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/libm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/libm/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/libm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/libm/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/libm/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/libm/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/libm/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/libm/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/libm/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/libm/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/libm/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/libm/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/libm/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/libm/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/libm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/libm/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/libm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/libm/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/libm/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/libm/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/libm/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/libm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/libm/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/libm/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/libm/deployments","created_at":"2018-07-12T05:47:15Z","updated_at":"2019-04-16T19:55:36Z","pushed_at":"2019-04-14T17:29:19Z","git_url":"git://github.com/rust-lang-nursery/libm.git","ssh_url":"git@github.com:rust-lang-nursery/libm.git","clone_url":"https://github.com/rust-lang-nursery/libm.git","svn_url":"https://github.com/rust-lang-nursery/libm","homepage":null,"size":299,"stargazers_count":163,"watchers_count":163,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":29,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/159"},"html":{"href":"https://github.com/rust-lang-nursery/libm/pull/159"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/libm/issues/159"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/libm/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/libm/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/libm/statuses/1638996c666c6532c53ec298cab4f4a91b1e4a2d"}},"author_association":"NONE"}}
|
{
"id": 140666750,
"name": "rust-lang-nursery/libm",
"url": "https://api.github.com/repos/rust-lang-nursery/libm"
}
|
{
"id": 904614,
"login": "gnzlbg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/904614?",
"url": "https://api.github.com/users/gnzlbg"
}
|
{
"id": 14631425,
"login": "rust-lang-nursery",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14631425?",
"url": "https://api.github.com/orgs/rust-lang-nursery"
}
| 2019-04-22T06:40:18 |
9484471227
|
{"actor":{"display_login":"gnzlbg"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pedaling/class101-ui/pulls/comments/316563137","pull_request_review_id":278275143,"id":316563137,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjU2MzEzNw==","diff_hunk":"@@ -0,0 +1,171 @@\n+import React, { PureComponent, ChangeEvent, ChangeEventHandler } from 'react';\n+import styled, { css } from 'styled-components';\n+import Theme, { ThemeConfig } from '../../Theme';\n+import { gray100, orange500, gray300, gray500, orange700, gray800 } from '../../Colors';\n+import { elevation1 } from '../../ElevationStyles';\n+import { body2 } from '../../TextStyles';\n+\n+export interface SwitchProps {\n+ style?: React.CSSProperties;\n+ theme: ThemeConfig;\n+ disabled: boolean;\n+ checked: boolean;\n+ color: string;\n+ hoverColor: string;\n+ onChange?: (e: ChangeEvent<HTMLInputElement>) => boolean | void;\n+ inline?: boolean;\n+ onText?: React.ReactNode;\n+ offText?: React.ReactNode;\n+ children?: React.ReactNode;\n+}\n+\n+export interface SwitchState {\n+ checked: boolean;\n+}\n+\n+export default class Switch extends PureComponent<SwitchProps, SwitchState> {\n+ public static defaultProps: Partial<SwitchProps> = {\n+ theme: Theme.light,\n+ disabled: false,\n+ checked: false,\n+ color: orange500,\n+ hoverColor: orange700,\n+ };\n+\n+ private changeChecked: ChangeEventHandler<HTMLInputElement> = e => {\n+ const { onChange } = this.props;\n+ if (!onChange || onChange(e) !== false)\n+ this.setState({\n+ checked: e.target.checked,\n+ });\n+ };\n+\n+ public state: SwitchState = {\n+ checked: this.props.checked,\n+ };\n+\n+ public render() {\n+ const { inline, onText, offText, children, style, disabled, color, hoverColor } = this.props;\n+ const { checked } = this.state;\n+ const textExists = children || onText || offText;\n+ return (\n+ <StyledSwitchContainer inline={inline} disabled={disabled} style={style}>\n+ {textExists && (\n+ <StyledSwitchText inline={inline} disabled={disabled}>\n+ {children || (checked ? onText : offText)}","path":"src/FormInput/Switch/index.tsx","position":55,"original_position":55,"commit_id":"4fa7deeda9c5c7ba431e5a5fae999576b2ccd1bb","original_commit_id":"4fa7deeda9c5c7ba431e5a5fae999576b2ccd1bb","user":{"login":"tbvjaos510","id":32216112,"node_id":"MDQ6VXNlcjMyMjE2MTEy","avatar_url":"https://avatars1.githubusercontent.com/u/32216112?v=4","gravatar_id":"","url":"https://api.github.com/users/tbvjaos510","html_url":"https://github.com/tbvjaos510","followers_url":"https://api.github.com/users/tbvjaos510/followers","following_url":"https://api.github.com/users/tbvjaos510/following{/other_user}","gists_url":"https://api.github.com/users/tbvjaos510/gists{/gist_id}","starred_url":"https://api.github.com/users/tbvjaos510/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbvjaos510/subscriptions","organizations_url":"https://api.github.com/users/tbvjaos510/orgs","repos_url":"https://api.github.com/users/tbvjaos510/repos","events_url":"https://api.github.com/users/tbvjaos510/events{/privacy}","received_events_url":"https://api.github.com/users/tbvjaos510/received_events","type":"User","site_admin":false},"body":"체크가 됐을때만 나타나는 텍스트나 컴포넌트도 있지 않을까? 너무 어렵게 생각했나..","created_at":"2019-08-22T08:48:31Z","updated_at":"2019-08-22T08:48:31Z","html_url":"https://github.com/pedaling/class101-ui/pull/91#discussion_r316563137","pull_request_url":"https://api.github.com/repos/pedaling/class101-ui/pulls/91","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pedaling/class101-ui/pulls/comments/316563137"},"html":{"href":"https://github.com/pedaling/class101-ui/pull/91#discussion_r316563137"},"pull_request":{"href":"https://api.github.com/repos/pedaling/class101-ui/pulls/91"}},"in_reply_to_id":316548887},"pull_request":{"url":"https://api.github.com/repos/pedaling/class101-ui/pulls/91","id":309347005,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5MzQ3MDA1","html_url":"https://github.com/pedaling/class101-ui/pull/91","diff_url":"https://github.com/pedaling/class101-ui/pull/91.diff","patch_url":"https://github.com/pedaling/class101-ui/pull/91.patch","issue_url":"https://api.github.com/repos/pedaling/class101-ui/issues/91","number":91,"state":"open","locked":false,"title":"feat: SwitchButton 추가","user":{"login":"tbvjaos510","id":32216112,"node_id":"MDQ6VXNlcjMyMjE2MTEy","avatar_url":"https://avatars1.githubusercontent.com/u/32216112?v=4","gravatar_id":"","url":"https://api.github.com/users/tbvjaos510","html_url":"https://github.com/tbvjaos510","followers_url":"https://api.github.com/users/tbvjaos510/followers","following_url":"https://api.github.com/users/tbvjaos510/following{/other_user}","gists_url":"https://api.github.com/users/tbvjaos510/gists{/gist_id}","starred_url":"https://api.github.com/users/tbvjaos510/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbvjaos510/subscriptions","organizations_url":"https://api.github.com/users/tbvjaos510/orgs","repos_url":"https://api.github.com/users/tbvjaos510/repos","events_url":"https://api.github.com/users/tbvjaos510/events{/privacy}","received_events_url":"https://api.github.com/users/tbvjaos510/received_events","type":"User","site_admin":false},"body":"SwitchButton을 FormInput 하위 디렉토리에 추가.\r\n\r\n## Image\r\n\r\n","created_at":"2019-08-21T06:44:26Z","updated_at":"2019-08-22T08:48:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ed497593d8dbf5064f61aad13a414b8cdab5df4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ddalpange","id":20659160,"node_id":"MDQ6VXNlcjIwNjU5MTYw","avatar_url":"https://avatars1.githubusercontent.com/u/20659160?v=4","gravatar_id":"","url":"https://api.github.com/users/ddalpange","html_url":"https://github.com/ddalpange","followers_url":"https://api.github.com/users/ddalpange/followers","following_url":"https://api.github.com/users/ddalpange/following{/other_user}","gists_url":"https://api.github.com/users/ddalpange/gists{/gist_id}","starred_url":"https://api.github.com/users/ddalpange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddalpange/subscriptions","organizations_url":"https://api.github.com/users/ddalpange/orgs","repos_url":"https://api.github.com/users/ddalpange/repos","events_url":"https://api.github.com/users/ddalpange/events{/privacy}","received_events_url":"https://api.github.com/users/ddalpange/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1416200067,"node_id":"MDU6TGFiZWwxNDE2MjAwMDY3","url":"https://api.github.com/repos/pedaling/class101-ui/labels/size/L","name":"size/L","color":"A14C05","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pedaling/class101-ui/pulls/91/commits","review_comments_url":"https://api.github.com/repos/pedaling/class101-ui/pulls/91/comments","review_comment_url":"https://api.github.com/repos/pedaling/class101-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pedaling/class101-ui/issues/91/comments","statuses_url":"https://api.github.com/repos/pedaling/class101-ui/statuses/4fa7deeda9c5c7ba431e5a5fae999576b2ccd1bb","head":{"label":"pedaling:feat/create-switch-button","ref":"feat/create-switch-button","sha":"4fa7deeda9c5c7ba431e5a5fae999576b2ccd1bb","user":{"login":"pedaling","id":14806827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODA2ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/14806827?v=4","gravatar_id":"","url":"https://api.github.com/users/pedaling","html_url":"https://github.com/pedaling","followers_url":"https://api.github.com/users/pedaling/followers","following_url":"https://api.github.com/users/pedaling/following{/other_user}","gists_url":"https://api.github.com/users/pedaling/gists{/gist_id}","starred_url":"https://api.github.com/users/pedaling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedaling/subscriptions","organizations_url":"https://api.github.com/users/pedaling/orgs","repos_url":"https://api.github.com/users/pedaling/repos","events_url":"https://api.github.com/users/pedaling/events{/privacy}","received_events_url":"https://api.github.com/users/pedaling/received_events","type":"Organization","site_admin":false},"repo":{"id":147155325,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxNTUzMjU=","name":"class101-ui","full_name":"pedaling/class101-ui","private":false,"owner":{"login":"pedaling","id":14806827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODA2ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/14806827?v=4","gravatar_id":"","url":"https://api.github.com/users/pedaling","html_url":"https://github.com/pedaling","followers_url":"https://api.github.com/users/pedaling/followers","following_url":"https://api.github.com/users/pedaling/following{/other_user}","gists_url":"https://api.github.com/users/pedaling/gists{/gist_id}","starred_url":"https://api.github.com/users/pedaling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedaling/subscriptions","organizations_url":"https://api.github.com/users/pedaling/orgs","repos_url":"https://api.github.com/users/pedaling/repos","events_url":"https://api.github.com/users/pedaling/events{/privacy}","received_events_url":"https://api.github.com/users/pedaling/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pedaling/class101-ui","description":"💅A React-based UI Component Library, powered by Class101.","fork":false,"url":"https://api.github.com/repos/pedaling/class101-ui","forks_url":"https://api.github.com/repos/pedaling/class101-ui/forks","keys_url":"https://api.github.com/repos/pedaling/class101-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedaling/class101-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedaling/class101-ui/teams","hooks_url":"https://api.github.com/repos/pedaling/class101-ui/hooks","issue_events_url":"https://api.github.com/repos/pedaling/class101-ui/issues/events{/number}","events_url":"https://api.github.com/repos/pedaling/class101-ui/events","assignees_url":"https://api.github.com/repos/pedaling/class101-ui/assignees{/user}","branches_url":"https://api.github.com/repos/pedaling/class101-ui/branches{/branch}","tags_url":"https://api.github.com/repos/pedaling/class101-ui/tags","blobs_url":"https://api.github.com/repos/pedaling/class101-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedaling/class101-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedaling/class101-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedaling/class101-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedaling/class101-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/pedaling/class101-ui/languages","stargazers_url":"https://api.github.com/repos/pedaling/class101-ui/stargazers","contributors_url":"https://api.github.com/repos/pedaling/class101-ui/contributors","subscribers_url":"https://api.github.com/repos/pedaling/class101-ui/subscribers","subscription_url":"https://api.github.com/repos/pedaling/class101-ui/subscription","commits_url":"https://api.github.com/repos/pedaling/class101-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedaling/class101-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedaling/class101-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedaling/class101-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedaling/class101-ui/contents/{+path}","compare_url":"https://api.github.com/repos/pedaling/class101-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedaling/class101-ui/merges","archive_url":"https://api.github.com/repos/pedaling/class101-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedaling/class101-ui/downloads","issues_url":"https://api.github.com/repos/pedaling/class101-ui/issues{/number}","pulls_url":"https://api.github.com/repos/pedaling/class101-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/pedaling/class101-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/pedaling/class101-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedaling/class101-ui/labels{/name}","releases_url":"https://api.github.com/repos/pedaling/class101-ui/releases{/id}","deployments_url":"https://api.github.com/repos/pedaling/class101-ui/deployments","created_at":"2018-09-03T05:23:42Z","updated_at":"2019-08-21T08:01:00Z","pushed_at":"2019-08-22T06:41:25Z","git_url":"git://github.com/pedaling/class101-ui.git","ssh_url":"git@github.com:pedaling/class101-ui.git","clone_url":"https://github.com/pedaling/class101-ui.git","svn_url":"https://github.com/pedaling/class101-ui","homepage":"https://class101.net","size":2554,"stargazers_count":19,"watchers_count":19,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":19,"default_branch":"master"}},"base":{"label":"pedaling:master","ref":"master","sha":"5b9482a93d53b4e8516031465414d39c37b9f694","user":{"login":"pedaling","id":14806827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODA2ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/14806827?v=4","gravatar_id":"","url":"https://api.github.com/users/pedaling","html_url":"https://github.com/pedaling","followers_url":"https://api.github.com/users/pedaling/followers","following_url":"https://api.github.com/users/pedaling/following{/other_user}","gists_url":"https://api.github.com/users/pedaling/gists{/gist_id}","starred_url":"https://api.github.com/users/pedaling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedaling/subscriptions","organizations_url":"https://api.github.com/users/pedaling/orgs","repos_url":"https://api.github.com/users/pedaling/repos","events_url":"https://api.github.com/users/pedaling/events{/privacy}","received_events_url":"https://api.github.com/users/pedaling/received_events","type":"Organization","site_admin":false},"repo":{"id":147155325,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxNTUzMjU=","name":"class101-ui","full_name":"pedaling/class101-ui","private":false,"owner":{"login":"pedaling","id":14806827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODA2ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/14806827?v=4","gravatar_id":"","url":"https://api.github.com/users/pedaling","html_url":"https://github.com/pedaling","followers_url":"https://api.github.com/users/pedaling/followers","following_url":"https://api.github.com/users/pedaling/following{/other_user}","gists_url":"https://api.github.com/users/pedaling/gists{/gist_id}","starred_url":"https://api.github.com/users/pedaling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedaling/subscriptions","organizations_url":"https://api.github.com/users/pedaling/orgs","repos_url":"https://api.github.com/users/pedaling/repos","events_url":"https://api.github.com/users/pedaling/events{/privacy}","received_events_url":"https://api.github.com/users/pedaling/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pedaling/class101-ui","description":"💅A React-based UI Component Library, powered by Class101.","fork":false,"url":"https://api.github.com/repos/pedaling/class101-ui","forks_url":"https://api.github.com/repos/pedaling/class101-ui/forks","keys_url":"https://api.github.com/repos/pedaling/class101-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedaling/class101-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedaling/class101-ui/teams","hooks_url":"https://api.github.com/repos/pedaling/class101-ui/hooks","issue_events_url":"https://api.github.com/repos/pedaling/class101-ui/issues/events{/number}","events_url":"https://api.github.com/repos/pedaling/class101-ui/events","assignees_url":"https://api.github.com/repos/pedaling/class101-ui/assignees{/user}","branches_url":"https://api.github.com/repos/pedaling/class101-ui/branches{/branch}","tags_url":"https://api.github.com/repos/pedaling/class101-ui/tags","blobs_url":"https://api.github.com/repos/pedaling/class101-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedaling/class101-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedaling/class101-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedaling/class101-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedaling/class101-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/pedaling/class101-ui/languages","stargazers_url":"https://api.github.com/repos/pedaling/class101-ui/stargazers","contributors_url":"https://api.github.com/repos/pedaling/class101-ui/contributors","subscribers_url":"https://api.github.com/repos/pedaling/class101-ui/subscribers","subscription_url":"https://api.github.com/repos/pedaling/class101-ui/subscription","commits_url":"https://api.github.com/repos/pedaling/class101-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedaling/class101-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedaling/class101-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedaling/class101-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedaling/class101-ui/contents/{+path}","compare_url":"https://api.github.com/repos/pedaling/class101-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedaling/class101-ui/merges","archive_url":"https://api.github.com/repos/pedaling/class101-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedaling/class101-ui/downloads","issues_url":"https://api.github.com/repos/pedaling/class101-ui/issues{/number}","pulls_url":"https://api.github.com/repos/pedaling/class101-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/pedaling/class101-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/pedaling/class101-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedaling/class101-ui/labels{/name}","releases_url":"https://api.github.com/repos/pedaling/class101-ui/releases{/id}","deployments_url":"https://api.github.com/repos/pedaling/class101-ui/deployments","created_at":"2018-09-03T05:23:42Z","updated_at":"2019-08-21T08:01:00Z","pushed_at":"2019-08-22T06:41:25Z","git_url":"git://github.com/pedaling/class101-ui.git","ssh_url":"git@github.com:pedaling/class101-ui.git","clone_url":"https://github.com/pedaling/class101-ui.git","svn_url":"https://github.com/pedaling/class101-ui","homepage":"https://class101.net","size":2554,"stargazers_count":19,"watchers_count":19,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pedaling/class101-ui/pulls/91"},"html":{"href":"https://github.com/pedaling/class101-ui/pull/91"},"issue":{"href":"https://api.github.com/repos/pedaling/class101-ui/issues/91"},"comments":{"href":"https://api.github.com/repos/pedaling/class101-ui/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/pedaling/class101-ui/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/pedaling/class101-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pedaling/class101-ui/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/pedaling/class101-ui/statuses/4fa7deeda9c5c7ba431e5a5fae999576b2ccd1bb"}},"author_association":"NONE"}}
|
{
"id": 147155325,
"name": "pedaling/class101-ui",
"url": "https://api.github.com/repos/pedaling/class101-ui"
}
|
{
"id": 32216112,
"login": "tbvjaos510",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32216112?",
"url": "https://api.github.com/users/tbvjaos510"
}
|
{
"id": 14806827,
"login": "pedaling",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14806827?",
"url": "https://api.github.com/orgs/pedaling"
}
| 2019-08-22T08:48:31 |
10261002237
|
{"actor":{"display_login":"tbvjaos510"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/comments/270067824","pull_request_review_id":220094407,"id":270067824,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MDA2NzgyNA==","diff_hunk":"@@ -41,20 +41,27 @@ class LimitDialer {\n callback = once(callback) // only call callback once\n \n let errors = []\n+ let successfulDial = null\n const tasks = addrs.map((m) => {\n- return (cb) => this.dialSingle(peer, transport, m, token, (err, result) => {\n+ return (cb) => this.dialSingle(peer, transport, m, token, (err, res) => {\n if (err) {\n errors.push(err)\n- return cb(err)\n+ return cb()\n }\n- return cb(null, result)\n+\n+ // There should only ever be 1 result\n+ if (res && !successfulDial) {\n+ successfulDial = res\n+ }\n+\n+ cb()\n })\n })\n \n- tryEach(tasks, (_, result) => {\n- if (result && result.conn) {\n+ parallel(tasks, (_) => {","path":"src/limit-dialer/index.js","position":34,"original_position":34,"commit_id":"0bda496ae6c744ace1ab1ba26dd873e3d4cb5e1b","original_commit_id":"0bda496ae6c744ace1ab1ba26dd873e3d4cb5e1b","user":{"login":"alanshaw","id":152863,"node_id":"MDQ6VXNlcjE1Mjg2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/152863?v=4","gravatar_id":"","url":"https://api.github.com/users/alanshaw","html_url":"https://github.com/alanshaw","followers_url":"https://api.github.com/users/alanshaw/followers","following_url":"https://api.github.com/users/alanshaw/following{/other_user}","gists_url":"https://api.github.com/users/alanshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/alanshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanshaw/subscriptions","organizations_url":"https://api.github.com/users/alanshaw/orgs","repos_url":"https://api.github.com/users/alanshaw/repos","events_url":"https://api.github.com/users/alanshaw/events{/privacy}","received_events_url":"https://api.github.com/users/alanshaw/received_events","type":"User","site_admin":false},"body":"Actually, do you want to use `async/race` for this instead so you don't have to wait for all the dials to finish before calling back?","created_at":"2019-03-28T15:40:04Z","updated_at":"2019-03-28T15:44:22Z","html_url":"https://github.com/libp2p/js-libp2p-switch/pull/315#discussion_r270067824","pull_request_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/315","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/comments/270067824"},"html":{"href":"https://github.com/libp2p/js-libp2p-switch/pull/315#discussion_r270067824"},"pull_request":{"href":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/315"}}},"pull_request":{"url":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/315","id":265296417,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1Mjk2NDE3","html_url":"https://github.com/libp2p/js-libp2p-switch/pull/315","diff_url":"https://github.com/libp2p/js-libp2p-switch/pull/315.diff","patch_url":"https://github.com/libp2p/js-libp2p-switch/pull/315.patch","issue_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues/315","number":315,"state":"open","locked":false,"title":"[WIP] fix: improve dial queue and parallel dials","user":{"login":"jacobheun","id":639834,"node_id":"MDQ6VXNlcjYzOTgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/639834?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobheun","html_url":"https://github.com/jacobheun","followers_url":"https://api.github.com/users/jacobheun/followers","following_url":"https://api.github.com/users/jacobheun/following{/other_user}","gists_url":"https://api.github.com/users/jacobheun/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobheun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobheun/subscriptions","organizations_url":"https://api.github.com/users/jacobheun/orgs","repos_url":"https://api.github.com/users/jacobheun/repos","events_url":"https://api.github.com/users/jacobheun/events{/privacy}","received_events_url":"https://api.github.com/users/jacobheun/received_events","type":"User","site_admin":false},"body":"## Improved Dialer\r\nThis improves the dialer queue a bit by doing a few things:\r\n\r\n**Multidimensional queues**\r\nAs dial requests are made they no longer go into a single, global queue, they are immediately added to the dial queue for that specific peer. This allows a successful queue, or one that errors, to immediately resolve the remaining dialing requests. Previously, a subsequent request would need to wait until its turn globally, which is slow, especially if it just needs to be aborted or a new stream needs to be created for a protocol.\r\n\r\n**Immediate dials for connected peers**\r\nIf a peer is already connected, we immediately start its queue if it's not already running. The max parallel queues aren't affected by this. This ensures that we have a steady stream of communication with our connected peers, which is critical to maintaining a healthy network.\r\n\r\n\r\n## Configurable dial timeout\r\nThe dial timeout was also not configurable. This has been corrected and added to the readme.","created_at":"2019-03-28T11:44:21Z","updated_at":"2019-03-28T15:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b28aa218aed58cf7cbd0e4e5e57e68c05d7667a2","assignee":{"login":"jacobheun","id":639834,"node_id":"MDQ6VXNlcjYzOTgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/639834?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobheun","html_url":"https://github.com/jacobheun","followers_url":"https://api.github.com/users/jacobheun/followers","following_url":"https://api.github.com/users/jacobheun/following{/other_user}","gists_url":"https://api.github.com/users/jacobheun/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobheun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobheun/subscriptions","organizations_url":"https://api.github.com/users/jacobheun/orgs","repos_url":"https://api.github.com/users/jacobheun/repos","events_url":"https://api.github.com/users/jacobheun/events{/privacy}","received_events_url":"https://api.github.com/users/jacobheun/received_events","type":"User","site_admin":false},"assignees":[{"login":"jacobheun","id":639834,"node_id":"MDQ6VXNlcjYzOTgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/639834?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobheun","html_url":"https://github.com/jacobheun","followers_url":"https://api.github.com/users/jacobheun/followers","following_url":"https://api.github.com/users/jacobheun/following{/other_user}","gists_url":"https://api.github.com/users/jacobheun/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobheun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobheun/subscriptions","organizations_url":"https://api.github.com/users/jacobheun/orgs","repos_url":"https://api.github.com/users/jacobheun/repos","events_url":"https://api.github.com/users/jacobheun/events{/privacy}","received_events_url":"https://api.github.com/users/jacobheun/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":418856654,"node_id":"MDU6TGFiZWw0MTg4NTY2NTQ=","url":"https://api.github.com/repos/libp2p/js-libp2p-switch/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/315/commits","review_comments_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/315/comments","review_comment_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues/315/comments","statuses_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/statuses/0bda496ae6c744ace1ab1ba26dd873e3d4cb5e1b","head":{"label":"libp2p:fix/dial-queue","ref":"fix/dial-queue","sha":"0bda496ae6c744ace1ab1ba26dd873e3d4cb5e1b","user":{"login":"libp2p","id":14838238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM4MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":38784511,"node_id":"MDEwOlJlcG9zaXRvcnkzODc4NDUxMQ==","name":"js-libp2p-switch","full_name":"libp2p/js-libp2p-switch","private":false,"owner":{"login":"libp2p","id":14838238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM4MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libp2p/js-libp2p-switch","description":"libp2p dialer machine implementation in JavaScript.","fork":false,"url":"https://api.github.com/repos/libp2p/js-libp2p-switch","forks_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/forks","keys_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/teams","hooks_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/hooks","issue_events_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/events","assignees_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/tags","blobs_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/languages","stargazers_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/stargazers","contributors_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/contributors","subscribers_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/subscribers","subscription_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/subscription","commits_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/merges","archive_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/downloads","issues_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/deployments","created_at":"2015-07-08T22:59:25Z","updated_at":"2019-03-28T08:28:06Z","pushed_at":"2019-03-28T14:43:59Z","git_url":"git://github.com/libp2p/js-libp2p-switch.git","ssh_url":"git@github.com:libp2p/js-libp2p-switch.git","clone_url":"https://github.com/libp2p/js-libp2p-switch.git","svn_url":"https://github.com/libp2p/js-libp2p-switch","homepage":"https://libp2p.io","size":1021,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":29,"open_issues":24,"watchers":44,"default_branch":"master"}},"base":{"label":"libp2p:master","ref":"master","sha":"57146a0ee351801c007e36696463c1afe991b983","user":{"login":"libp2p","id":14838238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM4MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":38784511,"node_id":"MDEwOlJlcG9zaXRvcnkzODc4NDUxMQ==","name":"js-libp2p-switch","full_name":"libp2p/js-libp2p-switch","private":false,"owner":{"login":"libp2p","id":14838238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM4MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libp2p/js-libp2p-switch","description":"libp2p dialer machine implementation in JavaScript.","fork":false,"url":"https://api.github.com/repos/libp2p/js-libp2p-switch","forks_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/forks","keys_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/teams","hooks_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/hooks","issue_events_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/events","assignees_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/tags","blobs_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/languages","stargazers_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/stargazers","contributors_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/contributors","subscribers_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/subscribers","subscription_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/subscription","commits_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/merges","archive_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/downloads","issues_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/js-libp2p-switch/deployments","created_at":"2015-07-08T22:59:25Z","updated_at":"2019-03-28T08:28:06Z","pushed_at":"2019-03-28T14:43:59Z","git_url":"git://github.com/libp2p/js-libp2p-switch.git","ssh_url":"git@github.com:libp2p/js-libp2p-switch.git","clone_url":"https://github.com/libp2p/js-libp2p-switch.git","svn_url":"https://github.com/libp2p/js-libp2p-switch","homepage":"https://libp2p.io","size":1021,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":29,"open_issues":24,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/315"},"html":{"href":"https://github.com/libp2p/js-libp2p-switch/pull/315"},"issue":{"href":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues/315"},"comments":{"href":"https://api.github.com/repos/libp2p/js-libp2p-switch/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libp2p/js-libp2p-switch/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/libp2p/js-libp2p-switch/statuses/0bda496ae6c744ace1ab1ba26dd873e3d4cb5e1b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 38784511,
"name": "libp2p/js-libp2p-switch",
"url": "https://api.github.com/repos/libp2p/js-libp2p-switch"
}
|
{
"id": 152863,
"login": "alanshaw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/152863?",
"url": "https://api.github.com/users/alanshaw"
}
|
{
"id": 14838238,
"login": "libp2p",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14838238?",
"url": "https://api.github.com/orgs/libp2p"
}
| 2019-03-28T15:40:04 |
9334142211
|
{"actor":{"display_login":"alanshaw"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/zeit/next.js/pulls/comments/275785746","pull_request_review_id":227179871,"id":275785746,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTc4NTc0Ng==","diff_hunk":"@@ -261,6 +263,21 @@ export default function onDemandEntryHandler (devMiddleware, multiCompiler, {\n \n function handleCallback (err) {\n if (err) return reject(err)\n+ const { name } = entries[normalizedPage]\n+ let serverPage = join(dir, distDir, 'server', name)\n+ const clientPage = join(dir, distDir, name)\n+ try {\n+ require('next/config').setConfig({})\n+ let mod = require(serverPage)\n+ mod = mod.default || mod\n+ if (mod && mod.__nextAmpOnly) {\n+ fs.unlinkSync(clientPage)\n+ }\n+ } catch (err) {\n+ if (err.code !== 'ENOENT' && (err.message && !err.message.includes('Cannot find module'))) {\n+ reject(err)","path":"packages/next/server/on-demand-entry-handler.js","position":32,"original_position":32,"commit_id":"889eb036edfc1792f9bdd74b48755d88fe3fce4d","original_commit_id":"889eb036edfc1792f9bdd74b48755d88fe3fce4d","user":{"login":"timneutkens","id":6324199,"node_id":"MDQ6VXNlcjYzMjQxOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6324199?v=4","gravatar_id":"","url":"https://api.github.com/users/timneutkens","html_url":"https://github.com/timneutkens","followers_url":"https://api.github.com/users/timneutkens/followers","following_url":"https://api.github.com/users/timneutkens/following{/other_user}","gists_url":"https://api.github.com/users/timneutkens/gists{/gist_id}","starred_url":"https://api.github.com/users/timneutkens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timneutkens/subscriptions","organizations_url":"https://api.github.com/users/timneutkens/orgs","repos_url":"https://api.github.com/users/timneutkens/repos","events_url":"https://api.github.com/users/timneutkens/events{/privacy}","received_events_url":"https://api.github.com/users/timneutkens/received_events","type":"User","site_admin":false},"body":"`return reject(err)`?","created_at":"2019-04-16T13:06:35Z","updated_at":"2019-04-16T13:06:36Z","html_url":"https://github.com/zeit/next.js/pull/7034#discussion_r275785746","pull_request_url":"https://api.github.com/repos/zeit/next.js/pulls/7034","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zeit/next.js/pulls/comments/275785746"},"html":{"href":"https://github.com/zeit/next.js/pull/7034#discussion_r275785746"},"pull_request":{"href":"https://api.github.com/repos/zeit/next.js/pulls/7034"}}},"pull_request":{"url":"https://api.github.com/repos/zeit/next.js/pulls/7034","id":270469126,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNDY5MTI2","html_url":"https://github.com/zeit/next.js/pull/7034","diff_url":"https://github.com/zeit/next.js/pull/7034.diff","patch_url":"https://github.com/zeit/next.js/pull/7034.patch","issue_url":"https://api.github.com/repos/zeit/next.js/issues/7034","number":7034,"state":"open","locked":false,"title":"Remove client bundles for AMP only pages","user":{"login":"ijjk","id":22380829,"node_id":"MDQ6VXNlcjIyMzgwODI5","avatar_url":"https://avatars0.githubusercontent.com/u/22380829?v=4","gravatar_id":"","url":"https://api.github.com/users/ijjk","html_url":"https://github.com/ijjk","followers_url":"https://api.github.com/users/ijjk/followers","following_url":"https://api.github.com/users/ijjk/following{/other_user}","gists_url":"https://api.github.com/users/ijjk/gists{/gist_id}","starred_url":"https://api.github.com/users/ijjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijjk/subscriptions","organizations_url":"https://api.github.com/users/ijjk/orgs","repos_url":"https://api.github.com/users/ijjk/repos","events_url":"https://api.github.com/users/ijjk/events{/privacy}","received_events_url":"https://api.github.com/users/ijjk/received_events","type":"User","site_admin":false},"body":"Since we don't use the client bundles for AMP only pages we remove them. ","created_at":"2019-04-15T11:04:58Z","updated_at":"2019-04-16T13:06:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5648134ebcdf540e4473a7335ad3ee297b31efd1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Timer","id":616428,"node_id":"MDQ6VXNlcjYxNjQyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/616428?v=4","gravatar_id":"","url":"https://api.github.com/users/Timer","html_url":"https://github.com/Timer","followers_url":"https://api.github.com/users/Timer/followers","following_url":"https://api.github.com/users/Timer/following{/other_user}","gists_url":"https://api.github.com/users/Timer/gists{/gist_id}","starred_url":"https://api.github.com/users/Timer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Timer/subscriptions","organizations_url":"https://api.github.com/users/Timer/orgs","repos_url":"https://api.github.com/users/Timer/repos","events_url":"https://api.github.com/users/Timer/events{/privacy}","received_events_url":"https://api.github.com/users/Timer/received_events","type":"User","site_admin":false},{"login":"lfades","id":4278345,"node_id":"MDQ6VXNlcjQyNzgzNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4278345?v=4","gravatar_id":"","url":"https://api.github.com/users/lfades","html_url":"https://github.com/lfades","followers_url":"https://api.github.com/users/lfades/followers","following_url":"https://api.github.com/users/lfades/following{/other_user}","gists_url":"https://api.github.com/users/lfades/gists{/gist_id}","starred_url":"https://api.github.com/users/lfades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfades/subscriptions","organizations_url":"https://api.github.com/users/lfades/orgs","repos_url":"https://api.github.com/users/lfades/repos","events_url":"https://api.github.com/users/lfades/events{/privacy}","received_events_url":"https://api.github.com/users/lfades/received_events","type":"User","site_admin":false},{"login":"dav-is","id":11590024,"node_id":"MDQ6VXNlcjExNTkwMDI0","avatar_url":"https://avatars3.githubusercontent.com/u/11590024?v=4","gravatar_id":"","url":"https://api.github.com/users/dav-is","html_url":"https://github.com/dav-is","followers_url":"https://api.github.com/users/dav-is/followers","following_url":"https://api.github.com/users/dav-is/following{/other_user}","gists_url":"https://api.github.com/users/dav-is/gists{/gist_id}","starred_url":"https://api.github.com/users/dav-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dav-is/subscriptions","organizations_url":"https://api.github.com/users/dav-is/orgs","repos_url":"https://api.github.com/users/dav-is/repos","events_url":"https://api.github.com/users/dav-is/events{/privacy}","received_events_url":"https://api.github.com/users/dav-is/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeit/next.js/pulls/7034/commits","review_comments_url":"https://api.github.com/repos/zeit/next.js/pulls/7034/comments","review_comment_url":"https://api.github.com/repos/zeit/next.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeit/next.js/issues/7034/comments","statuses_url":"https://api.github.com/repos/zeit/next.js/statuses/889eb036edfc1792f9bdd74b48755d88fe3fce4d","head":{"label":"ijjk:amp/remove-clients","ref":"amp/remove-clients","sha":"889eb036edfc1792f9bdd74b48755d88fe3fce4d","user":{"login":"ijjk","id":22380829,"node_id":"MDQ6VXNlcjIyMzgwODI5","avatar_url":"https://avatars0.githubusercontent.com/u/22380829?v=4","gravatar_id":"","url":"https://api.github.com/users/ijjk","html_url":"https://github.com/ijjk","followers_url":"https://api.github.com/users/ijjk/followers","following_url":"https://api.github.com/users/ijjk/following{/other_user}","gists_url":"https://api.github.com/users/ijjk/gists{/gist_id}","starred_url":"https://api.github.com/users/ijjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijjk/subscriptions","organizations_url":"https://api.github.com/users/ijjk/orgs","repos_url":"https://api.github.com/users/ijjk/repos","events_url":"https://api.github.com/users/ijjk/events{/privacy}","received_events_url":"https://api.github.com/users/ijjk/received_events","type":"User","site_admin":false},"repo":{"id":135074940,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwNzQ5NDA=","name":"next.js","full_name":"ijjk/next.js","private":false,"owner":{"login":"ijjk","id":22380829,"node_id":"MDQ6VXNlcjIyMzgwODI5","avatar_url":"https://avatars0.githubusercontent.com/u/22380829?v=4","gravatar_id":"","url":"https://api.github.com/users/ijjk","html_url":"https://github.com/ijjk","followers_url":"https://api.github.com/users/ijjk/followers","following_url":"https://api.github.com/users/ijjk/following{/other_user}","gists_url":"https://api.github.com/users/ijjk/gists{/gist_id}","starred_url":"https://api.github.com/users/ijjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijjk/subscriptions","organizations_url":"https://api.github.com/users/ijjk/orgs","repos_url":"https://api.github.com/users/ijjk/repos","events_url":"https://api.github.com/users/ijjk/events{/privacy}","received_events_url":"https://api.github.com/users/ijjk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ijjk/next.js","description":"Next.js is a lightweight framework for static and server‑rendered applications.","fork":true,"url":"https://api.github.com/repos/ijjk/next.js","forks_url":"https://api.github.com/repos/ijjk/next.js/forks","keys_url":"https://api.github.com/repos/ijjk/next.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijjk/next.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijjk/next.js/teams","hooks_url":"https://api.github.com/repos/ijjk/next.js/hooks","issue_events_url":"https://api.github.com/repos/ijjk/next.js/issues/events{/number}","events_url":"https://api.github.com/repos/ijjk/next.js/events","assignees_url":"https://api.github.com/repos/ijjk/next.js/assignees{/user}","branches_url":"https://api.github.com/repos/ijjk/next.js/branches{/branch}","tags_url":"https://api.github.com/repos/ijjk/next.js/tags","blobs_url":"https://api.github.com/repos/ijjk/next.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijjk/next.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijjk/next.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijjk/next.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijjk/next.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ijjk/next.js/languages","stargazers_url":"https://api.github.com/repos/ijjk/next.js/stargazers","contributors_url":"https://api.github.com/repos/ijjk/next.js/contributors","subscribers_url":"https://api.github.com/repos/ijjk/next.js/subscribers","subscription_url":"https://api.github.com/repos/ijjk/next.js/subscription","commits_url":"https://api.github.com/repos/ijjk/next.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijjk/next.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijjk/next.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijjk/next.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijjk/next.js/contents/{+path}","compare_url":"https://api.github.com/repos/ijjk/next.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijjk/next.js/merges","archive_url":"https://api.github.com/repos/ijjk/next.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijjk/next.js/downloads","issues_url":"https://api.github.com/repos/ijjk/next.js/issues{/number}","pulls_url":"https://api.github.com/repos/ijjk/next.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ijjk/next.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ijjk/next.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijjk/next.js/labels{/name}","releases_url":"https://api.github.com/repos/ijjk/next.js/releases{/id}","deployments_url":"https://api.github.com/repos/ijjk/next.js/deployments","created_at":"2018-05-27T19:20:30Z","updated_at":"2019-04-12T23:32:16Z","pushed_at":"2019-04-16T12:58:45Z","git_url":"git://github.com/ijjk/next.js.git","ssh_url":"git@github.com:ijjk/next.js.git","clone_url":"https://github.com/ijjk/next.js.git","svn_url":"https://github.com/ijjk/next.js","homepage":"https://nextjs.org","size":11147,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"canary"}},"base":{"label":"zeit:canary","ref":"canary","sha":"c48340cd8cd45c05edaf2e21c5949099251892d2","user":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":70107786,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEwNzc4Ng==","name":"next.js","full_name":"zeit/next.js","private":false,"owner":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zeit/next.js","description":"The React Framework","fork":false,"url":"https://api.github.com/repos/zeit/next.js","forks_url":"https://api.github.com/repos/zeit/next.js/forks","keys_url":"https://api.github.com/repos/zeit/next.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/next.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/next.js/teams","hooks_url":"https://api.github.com/repos/zeit/next.js/hooks","issue_events_url":"https://api.github.com/repos/zeit/next.js/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/next.js/events","assignees_url":"https://api.github.com/repos/zeit/next.js/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/next.js/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/next.js/tags","blobs_url":"https://api.github.com/repos/zeit/next.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/next.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/next.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/next.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/next.js/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/next.js/languages","stargazers_url":"https://api.github.com/repos/zeit/next.js/stargazers","contributors_url":"https://api.github.com/repos/zeit/next.js/contributors","subscribers_url":"https://api.github.com/repos/zeit/next.js/subscribers","subscription_url":"https://api.github.com/repos/zeit/next.js/subscription","commits_url":"https://api.github.com/repos/zeit/next.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/next.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/next.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/next.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/next.js/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/next.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/next.js/merges","archive_url":"https://api.github.com/repos/zeit/next.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/next.js/downloads","issues_url":"https://api.github.com/repos/zeit/next.js/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/next.js/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/next.js/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/next.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/next.js/labels{/name}","releases_url":"https://api.github.com/repos/zeit/next.js/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/next.js/deployments","created_at":"2016-10-05T23:32:51Z","updated_at":"2019-04-16T12:03:38Z","pushed_at":"2019-04-16T12:58:47Z","git_url":"git://github.com/zeit/next.js.git","ssh_url":"git@github.com:zeit/next.js.git","clone_url":"https://github.com/zeit/next.js.git","svn_url":"https://github.com/zeit/next.js","homepage":"https://nextjs.org","size":11352,"stargazers_count":36576,"watchers_count":36576,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4232,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":205,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4232,"open_issues":205,"watchers":36576,"default_branch":"canary"}},"_links":{"self":{"href":"https://api.github.com/repos/zeit/next.js/pulls/7034"},"html":{"href":"https://github.com/zeit/next.js/pull/7034"},"issue":{"href":"https://api.github.com/repos/zeit/next.js/issues/7034"},"comments":{"href":"https://api.github.com/repos/zeit/next.js/issues/7034/comments"},"review_comments":{"href":"https://api.github.com/repos/zeit/next.js/pulls/7034/comments"},"review_comment":{"href":"https://api.github.com/repos/zeit/next.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeit/next.js/pulls/7034/commits"},"statuses":{"href":"https://api.github.com/repos/zeit/next.js/statuses/889eb036edfc1792f9bdd74b48755d88fe3fce4d"}},"author_association":"MEMBER"}}
|
{
"id": 70107786,
"name": "zeit/next.js",
"url": "https://api.github.com/repos/zeit/next.js"
}
|
{
"id": 6324199,
"login": "timneutkens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6324199?",
"url": "https://api.github.com/users/timneutkens"
}
|
{
"id": 14985020,
"login": "zeit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14985020?",
"url": "https://api.github.com/orgs/zeit"
}
| 2019-04-16T13:06:35 |
9453058322
|
{"actor":{"display_login":"timneutkens"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/zeit/now/pulls/comments/363390504","pull_request_review_id":338772768,"id":363390504,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzM5MDUwNA==","diff_hunk":"@@ -13,4 +13,10 @@ export interface Framework {\n every?: FrameworkDetectionItem[];\n some?: FrameworkDetectionItem[];\n };\n+ settings?: {\n+ [key: string]: {\n+ value?: string;\n+ placeholder?: string;","path":"packages/frameworks/index.d.ts","position":7,"original_position":7,"commit_id":"b30ba3cf80f391f1bdd7dc0c8353df6f75b0af47","original_commit_id":"b30ba3cf80f391f1bdd7dc0c8353df6f75b0af47","user":{"login":"lucleray","id":6616955,"node_id":"MDQ6VXNlcjY2MTY5NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6616955?v=4","gravatar_id":"","url":"https://api.github.com/users/lucleray","html_url":"https://github.com/lucleray","followers_url":"https://api.github.com/users/lucleray/followers","following_url":"https://api.github.com/users/lucleray/following{/other_user}","gists_url":"https://api.github.com/users/lucleray/gists{/gist_id}","starred_url":"https://api.github.com/users/lucleray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucleray/subscriptions","organizations_url":"https://api.github.com/users/lucleray/orgs","repos_url":"https://api.github.com/users/lucleray/repos","events_url":"https://api.github.com/users/lucleray/events{/privacy}","received_events_url":"https://api.github.com/users/lucleray/received_events","type":"User","site_admin":false},"body":"Why not explicitly type `buildCommand`, `devCommand` and `outputDirectory`?","created_at":"2020-01-06T17:13:00Z","updated_at":"2020-01-06T17:13:00Z","html_url":"https://github.com/zeit/now/pull/3506#discussion_r363390504","pull_request_url":"https://api.github.com/repos/zeit/now/pulls/3506","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zeit/now/pulls/comments/363390504"},"html":{"href":"https://github.com/zeit/now/pull/3506#discussion_r363390504"},"pull_request":{"href":"https://api.github.com/repos/zeit/now/pulls/3506"}}},"pull_request":{"url":"https://api.github.com/repos/zeit/now/pulls/3506","id":359571014,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5NTcxMDE0","html_url":"https://github.com/zeit/now/pull/3506","diff_url":"https://github.com/zeit/now/pull/3506.diff","patch_url":"https://github.com/zeit/now/pull/3506.patch","issue_url":"https://api.github.com/repos/zeit/now/issues/3506","number":3506,"state":"open","locked":false,"title":"[frameworks] Add `settings` to frameworks","user":{"login":"AndyBitz","id":16088670,"node_id":"MDQ6VXNlcjE2MDg4Njcw","avatar_url":"https://avatars3.githubusercontent.com/u/16088670?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyBitz","html_url":"https://github.com/AndyBitz","followers_url":"https://api.github.com/users/AndyBitz/followers","following_url":"https://api.github.com/users/AndyBitz/following{/other_user}","gists_url":"https://api.github.com/users/AndyBitz/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyBitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyBitz/subscriptions","organizations_url":"https://api.github.com/users/AndyBitz/orgs","repos_url":"https://api.github.com/users/AndyBitz/repos","events_url":"https://api.github.com/users/AndyBitz/events{/privacy}","received_events_url":"https://api.github.com/users/AndyBitz/received_events","type":"User","site_admin":false},"body":"Adds a new `settings` property that can be used to retrieve defaults for the framework.\r\n\r\n[PRODUCT-944]\r\n\r\n[PRODUCT-944]: https://zeit.atlassian.net/browse/PRODUCT-944","created_at":"2020-01-06T14:41:12Z","updated_at":"2020-01-06T17:13:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28d5d5bcf17b5f487cc252a07ad29c6d60963f6b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TooTallNate","id":71256,"node_id":"MDQ6VXNlcjcxMjU2","avatar_url":"https://avatars3.githubusercontent.com/u/71256?v=4","gravatar_id":"","url":"https://api.github.com/users/TooTallNate","html_url":"https://github.com/TooTallNate","followers_url":"https://api.github.com/users/TooTallNate/followers","following_url":"https://api.github.com/users/TooTallNate/following{/other_user}","gists_url":"https://api.github.com/users/TooTallNate/gists{/gist_id}","starred_url":"https://api.github.com/users/TooTallNate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TooTallNate/subscriptions","organizations_url":"https://api.github.com/users/TooTallNate/orgs","repos_url":"https://api.github.com/users/TooTallNate/repos","events_url":"https://api.github.com/users/TooTallNate/events{/privacy}","received_events_url":"https://api.github.com/users/TooTallNate/received_events","type":"User","site_admin":false},{"login":"quietshu","id":3676859,"node_id":"MDQ6VXNlcjM2NzY4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/3676859?v=4","gravatar_id":"","url":"https://api.github.com/users/quietshu","html_url":"https://github.com/quietshu","followers_url":"https://api.github.com/users/quietshu/followers","following_url":"https://api.github.com/users/quietshu/following{/other_user}","gists_url":"https://api.github.com/users/quietshu/gists{/gist_id}","starred_url":"https://api.github.com/users/quietshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quietshu/subscriptions","organizations_url":"https://api.github.com/users/quietshu/orgs","repos_url":"https://api.github.com/users/quietshu/repos","events_url":"https://api.github.com/users/quietshu/events{/privacy}","received_events_url":"https://api.github.com/users/quietshu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeit/now/pulls/3506/commits","review_comments_url":"https://api.github.com/repos/zeit/now/pulls/3506/comments","review_comment_url":"https://api.github.com/repos/zeit/now/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeit/now/issues/3506/comments","statuses_url":"https://api.github.com/repos/zeit/now/statuses/b30ba3cf80f391f1bdd7dc0c8353df6f75b0af47","head":{"label":"zeit:now-frameworks/add-settings","ref":"now-frameworks/add-settings","sha":"b30ba3cf80f391f1bdd7dc0c8353df6f75b0af47","user":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":67753070,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzc1MzA3MA==","name":"now","full_name":"zeit/now","private":false,"owner":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zeit/now","description":"The easiest way to deploy websites","fork":false,"url":"https://api.github.com/repos/zeit/now","forks_url":"https://api.github.com/repos/zeit/now/forks","keys_url":"https://api.github.com/repos/zeit/now/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/now/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/now/teams","hooks_url":"https://api.github.com/repos/zeit/now/hooks","issue_events_url":"https://api.github.com/repos/zeit/now/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/now/events","assignees_url":"https://api.github.com/repos/zeit/now/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/now/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/now/tags","blobs_url":"https://api.github.com/repos/zeit/now/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/now/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/now/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/now/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/now/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/now/languages","stargazers_url":"https://api.github.com/repos/zeit/now/stargazers","contributors_url":"https://api.github.com/repos/zeit/now/contributors","subscribers_url":"https://api.github.com/repos/zeit/now/subscribers","subscription_url":"https://api.github.com/repos/zeit/now/subscription","commits_url":"https://api.github.com/repos/zeit/now/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/now/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/now/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/now/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/now/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/now/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/now/merges","archive_url":"https://api.github.com/repos/zeit/now/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/now/downloads","issues_url":"https://api.github.com/repos/zeit/now/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/now/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/now/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/now/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/now/labels{/name}","releases_url":"https://api.github.com/repos/zeit/now/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/now/deployments","created_at":"2016-09-09T01:12:08Z","updated_at":"2020-01-06T16:07:52Z","pushed_at":"2020-01-06T16:49:26Z","git_url":"git://github.com/zeit/now.git","ssh_url":"git@github.com:zeit/now.git","clone_url":"https://github.com/zeit/now.git","svn_url":"https://github.com/zeit/now","homepage":"https://zeit.co","size":50219,"stargazers_count":4199,"watchers_count":4199,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":495,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":170,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":495,"open_issues":170,"watchers":4199,"default_branch":"master"}},"base":{"label":"zeit:master","ref":"master","sha":"9d95b99b72bb407a2ce3927066e56fb1ed07b695","user":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":67753070,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzc1MzA3MA==","name":"now","full_name":"zeit/now","private":false,"owner":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zeit/now","description":"The easiest way to deploy websites","fork":false,"url":"https://api.github.com/repos/zeit/now","forks_url":"https://api.github.com/repos/zeit/now/forks","keys_url":"https://api.github.com/repos/zeit/now/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/now/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/now/teams","hooks_url":"https://api.github.com/repos/zeit/now/hooks","issue_events_url":"https://api.github.com/repos/zeit/now/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/now/events","assignees_url":"https://api.github.com/repos/zeit/now/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/now/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/now/tags","blobs_url":"https://api.github.com/repos/zeit/now/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/now/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/now/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/now/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/now/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/now/languages","stargazers_url":"https://api.github.com/repos/zeit/now/stargazers","contributors_url":"https://api.github.com/repos/zeit/now/contributors","subscribers_url":"https://api.github.com/repos/zeit/now/subscribers","subscription_url":"https://api.github.com/repos/zeit/now/subscription","commits_url":"https://api.github.com/repos/zeit/now/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/now/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/now/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/now/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/now/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/now/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/now/merges","archive_url":"https://api.github.com/repos/zeit/now/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/now/downloads","issues_url":"https://api.github.com/repos/zeit/now/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/now/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/now/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/now/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/now/labels{/name}","releases_url":"https://api.github.com/repos/zeit/now/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/now/deployments","created_at":"2016-09-09T01:12:08Z","updated_at":"2020-01-06T16:07:52Z","pushed_at":"2020-01-06T16:49:26Z","git_url":"git://github.com/zeit/now.git","ssh_url":"git@github.com:zeit/now.git","clone_url":"https://github.com/zeit/now.git","svn_url":"https://github.com/zeit/now","homepage":"https://zeit.co","size":50219,"stargazers_count":4199,"watchers_count":4199,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":495,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":170,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":495,"open_issues":170,"watchers":4199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeit/now/pulls/3506"},"html":{"href":"https://github.com/zeit/now/pull/3506"},"issue":{"href":"https://api.github.com/repos/zeit/now/issues/3506"},"comments":{"href":"https://api.github.com/repos/zeit/now/issues/3506/comments"},"review_comments":{"href":"https://api.github.com/repos/zeit/now/pulls/3506/comments"},"review_comment":{"href":"https://api.github.com/repos/zeit/now/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeit/now/pulls/3506/commits"},"statuses":{"href":"https://api.github.com/repos/zeit/now/statuses/b30ba3cf80f391f1bdd7dc0c8353df6f75b0af47"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 67753070,
"name": "zeit/now",
"url": "https://api.github.com/repos/zeit/now"
}
|
{
"id": 6616955,
"login": "lucleray",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6616955?",
"url": "https://api.github.com/users/lucleray"
}
|
{
"id": 14985020,
"login": "zeit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14985020?",
"url": "https://api.github.com/orgs/zeit"
}
| 2020-01-06T17:13:00 |
11212281829
|
{"actor":{"display_login":"lucleray"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments/280846323","pull_request_review_id":233564585,"id":280846323,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDg0NjMyMw==","diff_hunk":"@@ -77,10 +77,12 @@ We support and actively test against certain third-party clients to ensure compa\n |`DAYOFYEAR(date)`|Returns the day of the year of the given date.|\n |`FLOOR(number)`|Return the largest integer value that is less than or equal to `number`.|\n |`FROM_BASE64(str)`|Decodes the base64-encoded string str.|\n+|`GREATEST(...)`|Return the greatest numeric or string value.|\n |`HOUR(date)`|Returns the hours of the given date.|","path":"README.md","position":5,"original_position":5,"commit_id":"a1e08793d7ae2e70ea358ef835e4b0a61be43731","original_commit_id":"d75921ec9884384f067fd2b9ec4580630d60b1e7","user":{"login":"juanjux","id":277378,"node_id":"MDQ6VXNlcjI3NzM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/277378?v=4","gravatar_id":"","url":"https://api.github.com/users/juanjux","html_url":"https://github.com/juanjux","followers_url":"https://api.github.com/users/juanjux/followers","following_url":"https://api.github.com/users/juanjux/following{/other_user}","gists_url":"https://api.github.com/users/juanjux/gists{/gist_id}","starred_url":"https://api.github.com/users/juanjux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanjux/subscriptions","organizations_url":"https://api.github.com/users/juanjux/orgs","repos_url":"https://api.github.com/users/juanjux/repos","events_url":"https://api.github.com/users/juanjux/events{/privacy}","received_events_url":"https://api.github.com/users/juanjux/received_events","type":"User","site_admin":false},"body":"Fixed, thanks.","created_at":"2019-05-03T16:40:28Z","updated_at":"2019-05-03T16:40:29Z","html_url":"https://github.com/src-d/go-mysql-server/pull/700#discussion_r280846323","pull_request_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/700","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments/280846323"},"html":{"href":"https://github.com/src-d/go-mysql-server/pull/700#discussion_r280846323"},"pull_request":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/700"}},"in_reply_to_id":280841261},"pull_request":{"url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/700","id":275770607,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1NzcwNjA3","html_url":"https://github.com/src-d/go-mysql-server/pull/700","diff_url":"https://github.com/src-d/go-mysql-server/pull/700.diff","patch_url":"https://github.com/src-d/go-mysql-server/pull/700.patch","issue_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/700","number":700,"state":"open","locked":false,"title":"add greatest and least","user":{"login":"juanjux","id":277378,"node_id":"MDQ6VXNlcjI3NzM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/277378?v=4","gravatar_id":"","url":"https://api.github.com/users/juanjux","html_url":"https://github.com/juanjux","followers_url":"https://api.github.com/users/juanjux/followers","following_url":"https://api.github.com/users/juanjux/following{/other_user}","gists_url":"https://api.github.com/users/juanjux/gists{/gist_id}","starred_url":"https://api.github.com/users/juanjux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanjux/subscriptions","organizations_url":"https://api.github.com/users/juanjux/orgs","repos_url":"https://api.github.com/users/juanjux/repos","events_url":"https://api.github.com/users/juanjux/events{/privacy}","received_events_url":"https://api.github.com/users/juanjux/received_events","type":"User","site_admin":false},"body":"- Adds MySQL `GREATEST` and `LEAST` functions.\r\n- Sort function names in `SUPPORTED.md`.\r\n\r\nSigned-off-by: Juanjo Alvarez <juanjo@sourced.tech>","created_at":"2019-05-03T16:14:56Z","updated_at":"2019-05-03T16:40:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b5090394cd2ed21629e6a71a20cc0ec5cbada08","assignee":{"login":"juanjux","id":277378,"node_id":"MDQ6VXNlcjI3NzM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/277378?v=4","gravatar_id":"","url":"https://api.github.com/users/juanjux","html_url":"https://github.com/juanjux","followers_url":"https://api.github.com/users/juanjux/followers","following_url":"https://api.github.com/users/juanjux/following{/other_user}","gists_url":"https://api.github.com/users/juanjux/gists{/gist_id}","starred_url":"https://api.github.com/users/juanjux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanjux/subscriptions","organizations_url":"https://api.github.com/users/juanjux/orgs","repos_url":"https://api.github.com/users/juanjux/repos","events_url":"https://api.github.com/users/juanjux/events{/privacy}","received_events_url":"https://api.github.com/users/juanjux/received_events","type":"User","site_admin":false},"assignees":[{"login":"juanjux","id":277378,"node_id":"MDQ6VXNlcjI3NzM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/277378?v=4","gravatar_id":"","url":"https://api.github.com/users/juanjux","html_url":"https://github.com/juanjux","followers_url":"https://api.github.com/users/juanjux/followers","following_url":"https://api.github.com/users/juanjux/following{/other_user}","gists_url":"https://api.github.com/users/juanjux/gists{/gist_id}","starred_url":"https://api.github.com/users/juanjux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanjux/subscriptions","organizations_url":"https://api.github.com/users/juanjux/orgs","repos_url":"https://api.github.com/users/juanjux/repos","events_url":"https://api.github.com/users/juanjux/events{/privacy}","received_events_url":"https://api.github.com/users/juanjux/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ajnavarro","id":1196465,"node_id":"MDQ6VXNlcjExOTY0NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1196465?v=4","gravatar_id":"","url":"https://api.github.com/users/ajnavarro","html_url":"https://github.com/ajnavarro","followers_url":"https://api.github.com/users/ajnavarro/followers","following_url":"https://api.github.com/users/ajnavarro/following{/other_user}","gists_url":"https://api.github.com/users/ajnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/ajnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajnavarro/subscriptions","organizations_url":"https://api.github.com/users/ajnavarro/orgs","repos_url":"https://api.github.com/users/ajnavarro/repos","events_url":"https://api.github.com/users/ajnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/ajnavarro/received_events","type":"User","site_admin":false},{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/700/commits","review_comments_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/700/comments","review_comment_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/700/comments","statuses_url":"https://api.github.com/repos/src-d/go-mysql-server/statuses/a1e08793d7ae2e70ea358ef835e4b0a61be43731","head":{"label":"juanjux:greatest_least","ref":"greatest_least","sha":"a1e08793d7ae2e70ea358ef835e4b0a61be43731","user":{"login":"juanjux","id":277378,"node_id":"MDQ6VXNlcjI3NzM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/277378?v=4","gravatar_id":"","url":"https://api.github.com/users/juanjux","html_url":"https://github.com/juanjux","followers_url":"https://api.github.com/users/juanjux/followers","following_url":"https://api.github.com/users/juanjux/following{/other_user}","gists_url":"https://api.github.com/users/juanjux/gists{/gist_id}","starred_url":"https://api.github.com/users/juanjux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanjux/subscriptions","organizations_url":"https://api.github.com/users/juanjux/orgs","repos_url":"https://api.github.com/users/juanjux/repos","events_url":"https://api.github.com/users/juanjux/events{/privacy}","received_events_url":"https://api.github.com/users/juanjux/received_events","type":"User","site_admin":false},"repo":{"id":177552258,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc1NTIyNTg=","name":"go-mysql-server","full_name":"juanjux/go-mysql-server","private":false,"owner":{"login":"juanjux","id":277378,"node_id":"MDQ6VXNlcjI3NzM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/277378?v=4","gravatar_id":"","url":"https://api.github.com/users/juanjux","html_url":"https://github.com/juanjux","followers_url":"https://api.github.com/users/juanjux/followers","following_url":"https://api.github.com/users/juanjux/following{/other_user}","gists_url":"https://api.github.com/users/juanjux/gists{/gist_id}","starred_url":"https://api.github.com/users/juanjux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanjux/subscriptions","organizations_url":"https://api.github.com/users/juanjux/orgs","repos_url":"https://api.github.com/users/juanjux/repos","events_url":"https://api.github.com/users/juanjux/events{/privacy}","received_events_url":"https://api.github.com/users/juanjux/received_events","type":"User","site_admin":false},"html_url":"https://github.com/juanjux/go-mysql-server","description":"An extensible MySQL server implementation in Go.","fork":true,"url":"https://api.github.com/repos/juanjux/go-mysql-server","forks_url":"https://api.github.com/repos/juanjux/go-mysql-server/forks","keys_url":"https://api.github.com/repos/juanjux/go-mysql-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanjux/go-mysql-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanjux/go-mysql-server/teams","hooks_url":"https://api.github.com/repos/juanjux/go-mysql-server/hooks","issue_events_url":"https://api.github.com/repos/juanjux/go-mysql-server/issues/events{/number}","events_url":"https://api.github.com/repos/juanjux/go-mysql-server/events","assignees_url":"https://api.github.com/repos/juanjux/go-mysql-server/assignees{/user}","branches_url":"https://api.github.com/repos/juanjux/go-mysql-server/branches{/branch}","tags_url":"https://api.github.com/repos/juanjux/go-mysql-server/tags","blobs_url":"https://api.github.com/repos/juanjux/go-mysql-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanjux/go-mysql-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanjux/go-mysql-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanjux/go-mysql-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanjux/go-mysql-server/statuses/{sha}","languages_url":"https://api.github.com/repos/juanjux/go-mysql-server/languages","stargazers_url":"https://api.github.com/repos/juanjux/go-mysql-server/stargazers","contributors_url":"https://api.github.com/repos/juanjux/go-mysql-server/contributors","subscribers_url":"https://api.github.com/repos/juanjux/go-mysql-server/subscribers","subscription_url":"https://api.github.com/repos/juanjux/go-mysql-server/subscription","commits_url":"https://api.github.com/repos/juanjux/go-mysql-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanjux/go-mysql-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanjux/go-mysql-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanjux/go-mysql-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanjux/go-mysql-server/contents/{+path}","compare_url":"https://api.github.com/repos/juanjux/go-mysql-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanjux/go-mysql-server/merges","archive_url":"https://api.github.com/repos/juanjux/go-mysql-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanjux/go-mysql-server/downloads","issues_url":"https://api.github.com/repos/juanjux/go-mysql-server/issues{/number}","pulls_url":"https://api.github.com/repos/juanjux/go-mysql-server/pulls{/number}","milestones_url":"https://api.github.com/repos/juanjux/go-mysql-server/milestones{/number}","notifications_url":"https://api.github.com/repos/juanjux/go-mysql-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanjux/go-mysql-server/labels{/name}","releases_url":"https://api.github.com/repos/juanjux/go-mysql-server/releases{/id}","deployments_url":"https://api.github.com/repos/juanjux/go-mysql-server/deployments","created_at":"2019-03-25T09:12:32Z","updated_at":"2019-03-25T09:12:35Z","pushed_at":"2019-05-03T16:40:24Z","git_url":"git://github.com/juanjux/go-mysql-server.git","ssh_url":"git@github.com:juanjux/go-mysql-server.git","clone_url":"https://github.com/juanjux/go-mysql-server.git","svn_url":"https://github.com/juanjux/go-mysql-server","homepage":"","size":9528,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"c660bf17ea8fd574b29b8c4fc18e75c060046e26","user":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":121319560,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEzMTk1NjA=","name":"go-mysql-server","full_name":"src-d/go-mysql-server","private":false,"owner":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/src-d/go-mysql-server","description":"An extensible MySQL server implementation in Go.","fork":false,"url":"https://api.github.com/repos/src-d/go-mysql-server","forks_url":"https://api.github.com/repos/src-d/go-mysql-server/forks","keys_url":"https://api.github.com/repos/src-d/go-mysql-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/go-mysql-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/go-mysql-server/teams","hooks_url":"https://api.github.com/repos/src-d/go-mysql-server/hooks","issue_events_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/go-mysql-server/events","assignees_url":"https://api.github.com/repos/src-d/go-mysql-server/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/go-mysql-server/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/go-mysql-server/tags","blobs_url":"https://api.github.com/repos/src-d/go-mysql-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/go-mysql-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/go-mysql-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/go-mysql-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/go-mysql-server/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/go-mysql-server/languages","stargazers_url":"https://api.github.com/repos/src-d/go-mysql-server/stargazers","contributors_url":"https://api.github.com/repos/src-d/go-mysql-server/contributors","subscribers_url":"https://api.github.com/repos/src-d/go-mysql-server/subscribers","subscription_url":"https://api.github.com/repos/src-d/go-mysql-server/subscription","commits_url":"https://api.github.com/repos/src-d/go-mysql-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/go-mysql-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/go-mysql-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/go-mysql-server/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/go-mysql-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/go-mysql-server/merges","archive_url":"https://api.github.com/repos/src-d/go-mysql-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/go-mysql-server/downloads","issues_url":"https://api.github.com/repos/src-d/go-mysql-server/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/go-mysql-server/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/go-mysql-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/go-mysql-server/labels{/name}","releases_url":"https://api.github.com/repos/src-d/go-mysql-server/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/go-mysql-server/deployments","created_at":"2018-02-13T00:24:19Z","updated_at":"2019-05-03T08:41:10Z","pushed_at":"2019-05-03T16:40:25Z","git_url":"git://github.com/src-d/go-mysql-server.git","ssh_url":"git@github.com:src-d/go-mysql-server.git","clone_url":"https://github.com/src-d/go-mysql-server.git","svn_url":"https://github.com/src-d/go-mysql-server","homepage":"","size":9568,"stargazers_count":758,"watchers_count":758,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":76,"open_issues":20,"watchers":758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/700"},"html":{"href":"https://github.com/src-d/go-mysql-server/pull/700"},"issue":{"href":"https://api.github.com/repos/src-d/go-mysql-server/issues/700"},"comments":{"href":"https://api.github.com/repos/src-d/go-mysql-server/issues/700/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/700/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/700/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/go-mysql-server/statuses/a1e08793d7ae2e70ea358ef835e4b0a61be43731"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 121319560,
"name": "src-d/go-mysql-server",
"url": "https://api.github.com/repos/src-d/go-mysql-server"
}
|
{
"id": 277378,
"login": "juanjux",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/277378?",
"url": "https://api.github.com/users/juanjux"
}
|
{
"id": 15128793,
"login": "src-d",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15128793?",
"url": "https://api.github.com/orgs/src-d"
}
| 2019-05-03T16:40:28 |
9559428973
|
{"actor":{"display_login":"juanjux"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gro-intelligence/api-client/pulls/comments/320421562","pull_request_review_id":283188604,"id":320421562,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDQyMTU2Mg==","diff_hunk":"@@ -0,0 +1,693 @@\n+{","path":"api/client/samples/analysis_kits/stocks_to_use_price_model.ipynb","position":1,"original_position":1,"commit_id":"eee350bc0a8da5e467ea79b9604bccd13baf7a62","original_commit_id":"71a528574ebc58dfc13720481c2b8ba592362e05","user":{"login":"stephenbernardi","id":38086048,"node_id":"MDQ6VXNlcjM4MDg2MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/38086048?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenbernardi","html_url":"https://github.com/stephenbernardi","followers_url":"https://api.github.com/users/stephenbernardi/followers","following_url":"https://api.github.com/users/stephenbernardi/following{/other_user}","gists_url":"https://api.github.com/users/stephenbernardi/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenbernardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenbernardi/subscriptions","organizations_url":"https://api.github.com/users/stephenbernardi/orgs","repos_url":"https://api.github.com/users/stephenbernardi/repos","events_url":"https://api.github.com/users/stephenbernardi/events{/privacy}","received_events_url":"https://api.github.com/users/stephenbernardi/received_events","type":"User","site_admin":false},"body":"<p>completely removed the use of the term \"new crop\" to avoid confusion</p>","created_at":"2019-09-03T18:42:28Z","updated_at":"2019-09-03T18:42:28Z","html_url":"https://github.com/gro-intelligence/api-client/pull/102#discussion_r320421562","pull_request_url":"https://api.github.com/repos/gro-intelligence/api-client/pulls/102","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gro-intelligence/api-client/pulls/comments/320421562"},"html":{"href":"https://github.com/gro-intelligence/api-client/pull/102#discussion_r320421562"},"pull_request":{"href":"https://api.github.com/repos/gro-intelligence/api-client/pulls/102"}},"in_reply_to_id":318640971},"pull_request":{"url":"https://api.github.com/repos/gro-intelligence/api-client/pulls/102","id":310503482,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwNTAzNDgy","html_url":"https://github.com/gro-intelligence/api-client/pull/102","diff_url":"https://github.com/gro-intelligence/api-client/pull/102.diff","patch_url":"https://github.com/gro-intelligence/api-client/pull/102.patch","issue_url":"https://api.github.com/repos/gro-intelligence/api-client/issues/102","number":102,"state":"open","locked":false,"title":"Convert the Stocks to Use Price Model Into A Notebook","user":{"login":"stephenbernardi","id":38086048,"node_id":"MDQ6VXNlcjM4MDg2MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/38086048?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenbernardi","html_url":"https://github.com/stephenbernardi","followers_url":"https://api.github.com/users/stephenbernardi/followers","following_url":"https://api.github.com/users/stephenbernardi/following{/other_user}","gists_url":"https://api.github.com/users/stephenbernardi/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenbernardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenbernardi/subscriptions","organizations_url":"https://api.github.com/users/stephenbernardi/orgs","repos_url":"https://api.github.com/users/stephenbernardi/repos","events_url":"https://api.github.com/users/stephenbernardi/events{/privacy}","received_events_url":"https://api.github.com/users/stephenbernardi/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-23T19:14:32Z","updated_at":"2019-09-03T18:42:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae14d5d82b860ae833a9349a3b292fd70e6aca7c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"itsjohnward","id":3478393,"node_id":"MDQ6VXNlcjM0NzgzOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3478393?v=4","gravatar_id":"","url":"https://api.github.com/users/itsjohnward","html_url":"https://github.com/itsjohnward","followers_url":"https://api.github.com/users/itsjohnward/followers","following_url":"https://api.github.com/users/itsjohnward/following{/other_user}","gists_url":"https://api.github.com/users/itsjohnward/gists{/gist_id}","starred_url":"https://api.github.com/users/itsjohnward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsjohnward/subscriptions","organizations_url":"https://api.github.com/users/itsjohnward/orgs","repos_url":"https://api.github.com/users/itsjohnward/repos","events_url":"https://api.github.com/users/itsjohnward/events{/privacy}","received_events_url":"https://api.github.com/users/itsjohnward/received_events","type":"User","site_admin":false},{"login":"nemozen","id":15130196,"node_id":"MDQ6VXNlcjE1MTMwMTk2","avatar_url":"https://avatars2.githubusercontent.com/u/15130196?v=4","gravatar_id":"","url":"https://api.github.com/users/nemozen","html_url":"https://github.com/nemozen","followers_url":"https://api.github.com/users/nemozen/followers","following_url":"https://api.github.com/users/nemozen/following{/other_user}","gists_url":"https://api.github.com/users/nemozen/gists{/gist_id}","starred_url":"https://api.github.com/users/nemozen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemozen/subscriptions","organizations_url":"https://api.github.com/users/nemozen/orgs","repos_url":"https://api.github.com/users/nemozen/repos","events_url":"https://api.github.com/users/nemozen/events{/privacy}","received_events_url":"https://api.github.com/users/nemozen/received_events","type":"User","site_admin":false},{"login":"JGrinst","id":45766323,"node_id":"MDQ6VXNlcjQ1NzY2MzIz","avatar_url":"https://avatars3.githubusercontent.com/u/45766323?v=4","gravatar_id":"","url":"https://api.github.com/users/JGrinst","html_url":"https://github.com/JGrinst","followers_url":"https://api.github.com/users/JGrinst/followers","following_url":"https://api.github.com/users/JGrinst/following{/other_user}","gists_url":"https://api.github.com/users/JGrinst/gists{/gist_id}","starred_url":"https://api.github.com/users/JGrinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGrinst/subscriptions","organizations_url":"https://api.github.com/users/JGrinst/orgs","repos_url":"https://api.github.com/users/JGrinst/repos","events_url":"https://api.github.com/users/JGrinst/events{/privacy}","received_events_url":"https://api.github.com/users/JGrinst/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gro-intelligence/api-client/pulls/102/commits","review_comments_url":"https://api.github.com/repos/gro-intelligence/api-client/pulls/102/comments","review_comment_url":"https://api.github.com/repos/gro-intelligence/api-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gro-intelligence/api-client/issues/102/comments","statuses_url":"https://api.github.com/repos/gro-intelligence/api-client/statuses/eee350bc0a8da5e467ea79b9604bccd13baf7a62","head":{"label":"gro-intelligence:stocks-to-use-notebook","ref":"stocks-to-use-notebook","sha":"eee350bc0a8da5e467ea79b9604bccd13baf7a62","user":{"login":"gro-intelligence","id":15130228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTMwMjI4","avatar_url":"https://avatars1.githubusercontent.com/u/15130228?v=4","gravatar_id":"","url":"https://api.github.com/users/gro-intelligence","html_url":"https://github.com/gro-intelligence","followers_url":"https://api.github.com/users/gro-intelligence/followers","following_url":"https://api.github.com/users/gro-intelligence/following{/other_user}","gists_url":"https://api.github.com/users/gro-intelligence/gists{/gist_id}","starred_url":"https://api.github.com/users/gro-intelligence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gro-intelligence/subscriptions","organizations_url":"https://api.github.com/users/gro-intelligence/orgs","repos_url":"https://api.github.com/users/gro-intelligence/repos","events_url":"https://api.github.com/users/gro-intelligence/events{/privacy}","received_events_url":"https://api.github.com/users/gro-intelligence/received_events","type":"Organization","site_admin":false},"repo":{"id":119446076,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0NDYwNzY=","name":"api-client","full_name":"gro-intelligence/api-client","private":false,"owner":{"login":"gro-intelligence","id":15130228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTMwMjI4","avatar_url":"https://avatars1.githubusercontent.com/u/15130228?v=4","gravatar_id":"","url":"https://api.github.com/users/gro-intelligence","html_url":"https://github.com/gro-intelligence","followers_url":"https://api.github.com/users/gro-intelligence/followers","following_url":"https://api.github.com/users/gro-intelligence/following{/other_user}","gists_url":"https://api.github.com/users/gro-intelligence/gists{/gist_id}","starred_url":"https://api.github.com/users/gro-intelligence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gro-intelligence/subscriptions","organizations_url":"https://api.github.com/users/gro-intelligence/orgs","repos_url":"https://api.github.com/users/gro-intelligence/repos","events_url":"https://api.github.com/users/gro-intelligence/events{/privacy}","received_events_url":"https://api.github.com/users/gro-intelligence/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gro-intelligence/api-client","description":"Gro Intelligence API Client","fork":false,"url":"https://api.github.com/repos/gro-intelligence/api-client","forks_url":"https://api.github.com/repos/gro-intelligence/api-client/forks","keys_url":"https://api.github.com/repos/gro-intelligence/api-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gro-intelligence/api-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gro-intelligence/api-client/teams","hooks_url":"https://api.github.com/repos/gro-intelligence/api-client/hooks","issue_events_url":"https://api.github.com/repos/gro-intelligence/api-client/issues/events{/number}","events_url":"https://api.github.com/repos/gro-intelligence/api-client/events","assignees_url":"https://api.github.com/repos/gro-intelligence/api-client/assignees{/user}","branches_url":"https://api.github.com/repos/gro-intelligence/api-client/branches{/branch}","tags_url":"https://api.github.com/repos/gro-intelligence/api-client/tags","blobs_url":"https://api.github.com/repos/gro-intelligence/api-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gro-intelligence/api-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gro-intelligence/api-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/gro-intelligence/api-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gro-intelligence/api-client/statuses/{sha}","languages_url":"https://api.github.com/repos/gro-intelligence/api-client/languages","stargazers_url":"https://api.github.com/repos/gro-intelligence/api-client/stargazers","contributors_url":"https://api.github.com/repos/gro-intelligence/api-client/contributors","subscribers_url":"https://api.github.com/repos/gro-intelligence/api-client/subscribers","subscription_url":"https://api.github.com/repos/gro-intelligence/api-client/subscription","commits_url":"https://api.github.com/repos/gro-intelligence/api-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/gro-intelligence/api-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/gro-intelligence/api-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/gro-intelligence/api-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/gro-intelligence/api-client/contents/{+path}","compare_url":"https://api.github.com/repos/gro-intelligence/api-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gro-intelligence/api-client/merges","archive_url":"https://api.github.com/repos/gro-intelligence/api-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gro-intelligence/api-client/downloads","issues_url":"https://api.github.com/repos/gro-intelligence/api-client/issues{/number}","pulls_url":"https://api.github.com/repos/gro-intelligence/api-client/pulls{/number}","milestones_url":"https://api.github.com/repos/gro-intelligence/api-client/milestones{/number}","notifications_url":"https://api.github.com/repos/gro-intelligence/api-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gro-intelligence/api-client/labels{/name}","releases_url":"https://api.github.com/repos/gro-intelligence/api-client/releases{/id}","deployments_url":"https://api.github.com/repos/gro-intelligence/api-client/deployments","created_at":"2018-01-29T21:46:28Z","updated_at":"2019-08-28T14:54:07Z","pushed_at":"2019-09-03T18:38:00Z","git_url":"git://github.com/gro-intelligence/api-client.git","ssh_url":"git@github.com:gro-intelligence/api-client.git","clone_url":"https://github.com/gro-intelligence/api-client.git","svn_url":"https://github.com/gro-intelligence/api-client","homepage":"https://www.gro-intelligence.com/products/gro-api","size":33057,"stargazers_count":6,"watchers_count":6,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":null,"forks":5,"open_issues":11,"watchers":6,"default_branch":"development"}},"base":{"label":"gro-intelligence:development","ref":"development","sha":"0886154b0a68f89f033f32955a8a1195cff63807","user":{"login":"gro-intelligence","id":15130228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTMwMjI4","avatar_url":"https://avatars1.githubusercontent.com/u/15130228?v=4","gravatar_id":"","url":"https://api.github.com/users/gro-intelligence","html_url":"https://github.com/gro-intelligence","followers_url":"https://api.github.com/users/gro-intelligence/followers","following_url":"https://api.github.com/users/gro-intelligence/following{/other_user}","gists_url":"https://api.github.com/users/gro-intelligence/gists{/gist_id}","starred_url":"https://api.github.com/users/gro-intelligence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gro-intelligence/subscriptions","organizations_url":"https://api.github.com/users/gro-intelligence/orgs","repos_url":"https://api.github.com/users/gro-intelligence/repos","events_url":"https://api.github.com/users/gro-intelligence/events{/privacy}","received_events_url":"https://api.github.com/users/gro-intelligence/received_events","type":"Organization","site_admin":false},"repo":{"id":119446076,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0NDYwNzY=","name":"api-client","full_name":"gro-intelligence/api-client","private":false,"owner":{"login":"gro-intelligence","id":15130228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTMwMjI4","avatar_url":"https://avatars1.githubusercontent.com/u/15130228?v=4","gravatar_id":"","url":"https://api.github.com/users/gro-intelligence","html_url":"https://github.com/gro-intelligence","followers_url":"https://api.github.com/users/gro-intelligence/followers","following_url":"https://api.github.com/users/gro-intelligence/following{/other_user}","gists_url":"https://api.github.com/users/gro-intelligence/gists{/gist_id}","starred_url":"https://api.github.com/users/gro-intelligence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gro-intelligence/subscriptions","organizations_url":"https://api.github.com/users/gro-intelligence/orgs","repos_url":"https://api.github.com/users/gro-intelligence/repos","events_url":"https://api.github.com/users/gro-intelligence/events{/privacy}","received_events_url":"https://api.github.com/users/gro-intelligence/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gro-intelligence/api-client","description":"Gro Intelligence API Client","fork":false,"url":"https://api.github.com/repos/gro-intelligence/api-client","forks_url":"https://api.github.com/repos/gro-intelligence/api-client/forks","keys_url":"https://api.github.com/repos/gro-intelligence/api-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gro-intelligence/api-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gro-intelligence/api-client/teams","hooks_url":"https://api.github.com/repos/gro-intelligence/api-client/hooks","issue_events_url":"https://api.github.com/repos/gro-intelligence/api-client/issues/events{/number}","events_url":"https://api.github.com/repos/gro-intelligence/api-client/events","assignees_url":"https://api.github.com/repos/gro-intelligence/api-client/assignees{/user}","branches_url":"https://api.github.com/repos/gro-intelligence/api-client/branches{/branch}","tags_url":"https://api.github.com/repos/gro-intelligence/api-client/tags","blobs_url":"https://api.github.com/repos/gro-intelligence/api-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gro-intelligence/api-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gro-intelligence/api-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/gro-intelligence/api-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gro-intelligence/api-client/statuses/{sha}","languages_url":"https://api.github.com/repos/gro-intelligence/api-client/languages","stargazers_url":"https://api.github.com/repos/gro-intelligence/api-client/stargazers","contributors_url":"https://api.github.com/repos/gro-intelligence/api-client/contributors","subscribers_url":"https://api.github.com/repos/gro-intelligence/api-client/subscribers","subscription_url":"https://api.github.com/repos/gro-intelligence/api-client/subscription","commits_url":"https://api.github.com/repos/gro-intelligence/api-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/gro-intelligence/api-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/gro-intelligence/api-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/gro-intelligence/api-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/gro-intelligence/api-client/contents/{+path}","compare_url":"https://api.github.com/repos/gro-intelligence/api-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gro-intelligence/api-client/merges","archive_url":"https://api.github.com/repos/gro-intelligence/api-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gro-intelligence/api-client/downloads","issues_url":"https://api.github.com/repos/gro-intelligence/api-client/issues{/number}","pulls_url":"https://api.github.com/repos/gro-intelligence/api-client/pulls{/number}","milestones_url":"https://api.github.com/repos/gro-intelligence/api-client/milestones{/number}","notifications_url":"https://api.github.com/repos/gro-intelligence/api-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gro-intelligence/api-client/labels{/name}","releases_url":"https://api.github.com/repos/gro-intelligence/api-client/releases{/id}","deployments_url":"https://api.github.com/repos/gro-intelligence/api-client/deployments","created_at":"2018-01-29T21:46:28Z","updated_at":"2019-08-28T14:54:07Z","pushed_at":"2019-09-03T18:38:00Z","git_url":"git://github.com/gro-intelligence/api-client.git","ssh_url":"git@github.com:gro-intelligence/api-client.git","clone_url":"https://github.com/gro-intelligence/api-client.git","svn_url":"https://github.com/gro-intelligence/api-client","homepage":"https://www.gro-intelligence.com/products/gro-api","size":33057,"stargazers_count":6,"watchers_count":6,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":null,"forks":5,"open_issues":11,"watchers":6,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/gro-intelligence/api-client/pulls/102"},"html":{"href":"https://github.com/gro-intelligence/api-client/pull/102"},"issue":{"href":"https://api.github.com/repos/gro-intelligence/api-client/issues/102"},"comments":{"href":"https://api.github.com/repos/gro-intelligence/api-client/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/gro-intelligence/api-client/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/gro-intelligence/api-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gro-intelligence/api-client/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/gro-intelligence/api-client/statuses/eee350bc0a8da5e467ea79b9604bccd13baf7a62"}},"author_association":"COLLABORATOR"}}
|
{
"id": 119446076,
"name": "gro-intelligence/api-client",
"url": "https://api.github.com/repos/gro-intelligence/api-client"
}
|
{
"id": 38086048,
"login": "stephenbernardi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38086048?",
"url": "https://api.github.com/users/stephenbernardi"
}
|
{
"id": 15130228,
"login": "gro-intelligence",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15130228?",
"url": "https://api.github.com/orgs/gro-intelligence"
}
| 2019-09-03T18:42:28 |
10339180379
|
{"actor":{"display_login":"stephenbernardi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/357090772","pull_request_review_id":331159377,"id":357090772,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzA5MDc3Mg==","diff_hunk":"@@ -0,0 +1,100 @@\n+import os\n+from conans import ConanFile, tools, AutoToolsBuildEnvironment\n+from conans.errors import ConanInvalidConfiguration\n+\n+\n+class DarknetConan(ConanFile):\n+ name = \"darknet\"\n+ license = \"YOLO\"\n+ url = \"https://github.com/conan-io/conan-center-index\"\n+ homepage = \"http://pjreddie.com/darknet/\"\n+ description = \"Darknet is a neural network frameworks written in C\"\n+ topics = (\"darknet\", \"neural network\", \"deep learning\")\n+ settings = \"os\", \"compiler\", \"build_type\", \"arch\", \"arch_build\"\n+ options = {\n+ \"shared\": [True, False],\n+ \"fPIC\": [True, False],\n+ \"OpenCV\": [True, False]\n+ }\n+ default_options = {\n+ \"shared\": False,\n+ \"fPIC\": True,\n+ \"OpenCV\": False,\n+ }\n+\n+ @property\n+ def _source_subfolder(self):\n+ return \"source_subfolder\"\n+\n+ @property\n+ def _commit(self):\n+ url = self.conan_data[\"sources\"][self.version][\"url\"]\n+ return url[url.rfind(\"/\")+1:url.rfind(\".\")]\n+\n+ @property\n+ def _lib_to_compile(self):\n+ if not self.options.shared:\n+ return \"$(ALIB)\"\n+ else:\n+ return \"$(SLIB)\"\n+\n+ @property\n+ def _shared_lib_extension(self):\n+ if self.settings.os == \"Macos\":\n+ return \".dylib\"\n+ else:\n+ return \".so\"\n+\n+ def _activate_makefile(self, option):\n+ makefileName = option.upper()\n+ with tools.chdir(self._source_subfolder):\n+ if getattr(self.options, option) == True:\n+ tools.replace_in_file('Makefile', makefileName + '=0', makefileName + '=1')\n+\n+ def configure(self):\n+ if self.settings.os == \"Windows\":\n+ raise ConanInvalidConfiguration(\"This library is not compatible with Windows\")\n+ del self.settings.compiler.libcxx\n+ del self.settings.compiler.cppstd\n+\n+ def requirements(self):\n+ if self.options.OpenCV:\n+ self.requires(\"opencv/3.4.3\")\n+\n+ def source(self):\n+ tools.get(**self.conan_data[\"sources\"][self.version])\n+ extracted_folder = self.name + \"-\" + self._commit\n+ os.rename(extracted_folder, self._source_subfolder)\n+\n+ def build(self):\n+ self._activate_makefile(\"OpenCV\")\n+ with tools.chdir(self._source_subfolder):\n+ tools.replace_in_file('Makefile', \"-fPIC\", \"\")","path":"recipes/darknet/all/conanfile.py","position":72,"original_position":72,"commit_id":"b1b07ee681ec353cdb88afe2ded5d6fc82b06e1e","original_commit_id":"b1b07ee681ec353cdb88afe2ded5d6fc82b06e1e","user":{"login":"danimtb","id":10808592,"node_id":"MDQ6VXNlcjEwODA4NTky","avatar_url":"https://avatars1.githubusercontent.com/u/10808592?v=4","gravatar_id":"","url":"https://api.github.com/users/danimtb","html_url":"https://github.com/danimtb","followers_url":"https://api.github.com/users/danimtb/followers","following_url":"https://api.github.com/users/danimtb/following{/other_user}","gists_url":"https://api.github.com/users/danimtb/gists{/gist_id}","starred_url":"https://api.github.com/users/danimtb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danimtb/subscriptions","organizations_url":"https://api.github.com/users/danimtb/orgs","repos_url":"https://api.github.com/users/danimtb/repos","events_url":"https://api.github.com/users/danimtb/events{/privacy}","received_events_url":"https://api.github.com/users/danimtb/received_events","type":"User","site_admin":false},"body":"please @PierreRamoin address the changes requested\r\n","created_at":"2019-12-12T11:18:54Z","updated_at":"2019-12-12T11:18:54Z","html_url":"https://github.com/conan-io/conan-center-index/pull/356#discussion_r357090772","pull_request_url":"https://api.github.com/repos/conan-io/conan-center-index/pulls/356","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan-center-index/pulls/comments/357090772"},"html":{"href":"https://github.com/conan-io/conan-center-index/pull/356#discussion_r357090772"},"pull_request":{"href":"https://api.github.com/repos/conan-io/conan-center-index/pulls/356"}},"in_reply_to_id":348315120},"pull_request":{"url":"https://api.github.com/repos/conan-io/conan-center-index/pulls/356","id":342420985,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyNDIwOTg1","html_url":"https://github.com/conan-io/conan-center-index/pull/356","diff_url":"https://github.com/conan-io/conan-center-index/pull/356.diff","patch_url":"https://github.com/conan-io/conan-center-index/pull/356.patch","issue_url":"https://api.github.com/repos/conan-io/conan-center-index/issues/356","number":356,"state":"open","locked":false,"title":"add darknet recipe","user":{"login":"PierreRamoin","id":48487420,"node_id":"MDQ6VXNlcjQ4NDg3NDIw","avatar_url":"https://avatars1.githubusercontent.com/u/48487420?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreRamoin","html_url":"https://github.com/PierreRamoin","followers_url":"https://api.github.com/users/PierreRamoin/followers","following_url":"https://api.github.com/users/PierreRamoin/following{/other_user}","gists_url":"https://api.github.com/users/PierreRamoin/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreRamoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreRamoin/subscriptions","organizations_url":"https://api.github.com/users/PierreRamoin/orgs","repos_url":"https://api.github.com/users/PierreRamoin/repos","events_url":"https://api.github.com/users/PierreRamoin/events{/privacy}","received_events_url":"https://api.github.com/users/PierreRamoin/received_events","type":"User","site_admin":false},"body":"Specify library name and version: **darknet/0.1**\r\n\r\n- [ x ] I've read the [guidelines](https://github.com/conan-io/conan-center-index/wiki#how-to-submit-a-pull-request) for contributing.\r\n- [ x ] I've followed the [PEP8](https://www.python.org/dev/peps/pep-0008/) style guides for Python code in the recipes.\r\n- [ x ] I've used the [latest](https://github.com/conan-io/conan/releases/latest) Conan client version.\r\n- [ x ] I've tried at least one configuration locally with the\r\n [conan-center hook](https://github.com/conan-io/hooks.git) activated.\r\n\r\n","created_at":"2019-11-19T00:01:00Z","updated_at":"2019-12-12T11:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82c33fe85e29811c6c905e2cfc5c65b1ef26c13c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/conan-io/conan-center-index/pulls/356/commits","review_comments_url":"https://api.github.com/repos/conan-io/conan-center-index/pulls/356/comments","review_comment_url":"https://api.github.com/repos/conan-io/conan-center-index/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conan-io/conan-center-index/issues/356/comments","statuses_url":"https://api.github.com/repos/conan-io/conan-center-index/statuses/b1b07ee681ec353cdb88afe2ded5d6fc82b06e1e","head":{"label":"snowconnect:darknet","ref":"darknet","sha":"b1b07ee681ec353cdb88afe2ded5d6fc82b06e1e","user":{"login":"snowconnect","id":53355423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzU1NDIz","avatar_url":"https://avatars1.githubusercontent.com/u/53355423?v=4","gravatar_id":"","url":"https://api.github.com/users/snowconnect","html_url":"https://github.com/snowconnect","followers_url":"https://api.github.com/users/snowconnect/followers","following_url":"https://api.github.com/users/snowconnect/following{/other_user}","gists_url":"https://api.github.com/users/snowconnect/gists{/gist_id}","starred_url":"https://api.github.com/users/snowconnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowconnect/subscriptions","organizations_url":"https://api.github.com/users/snowconnect/orgs","repos_url":"https://api.github.com/users/snowconnect/repos","events_url":"https://api.github.com/users/snowconnect/events{/privacy}","received_events_url":"https://api.github.com/users/snowconnect/received_events","type":"Organization","site_admin":false},"repo":{"id":222565981,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI1NjU5ODE=","name":"conan-center-index","full_name":"snowconnect/conan-center-index","private":false,"owner":{"login":"snowconnect","id":53355423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzU1NDIz","avatar_url":"https://avatars1.githubusercontent.com/u/53355423?v=4","gravatar_id":"","url":"https://api.github.com/users/snowconnect","html_url":"https://github.com/snowconnect","followers_url":"https://api.github.com/users/snowconnect/followers","following_url":"https://api.github.com/users/snowconnect/following{/other_user}","gists_url":"https://api.github.com/users/snowconnect/gists{/gist_id}","starred_url":"https://api.github.com/users/snowconnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowconnect/subscriptions","organizations_url":"https://api.github.com/users/snowconnect/orgs","repos_url":"https://api.github.com/users/snowconnect/repos","events_url":"https://api.github.com/users/snowconnect/events{/privacy}","received_events_url":"https://api.github.com/users/snowconnect/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snowconnect/conan-center-index","description":"Recipes for the conan-center repository","fork":true,"url":"https://api.github.com/repos/snowconnect/conan-center-index","forks_url":"https://api.github.com/repos/snowconnect/conan-center-index/forks","keys_url":"https://api.github.com/repos/snowconnect/conan-center-index/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snowconnect/conan-center-index/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snowconnect/conan-center-index/teams","hooks_url":"https://api.github.com/repos/snowconnect/conan-center-index/hooks","issue_events_url":"https://api.github.com/repos/snowconnect/conan-center-index/issues/events{/number}","events_url":"https://api.github.com/repos/snowconnect/conan-center-index/events","assignees_url":"https://api.github.com/repos/snowconnect/conan-center-index/assignees{/user}","branches_url":"https://api.github.com/repos/snowconnect/conan-center-index/branches{/branch}","tags_url":"https://api.github.com/repos/snowconnect/conan-center-index/tags","blobs_url":"https://api.github.com/repos/snowconnect/conan-center-index/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snowconnect/conan-center-index/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snowconnect/conan-center-index/git/refs{/sha}","trees_url":"https://api.github.com/repos/snowconnect/conan-center-index/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snowconnect/conan-center-index/statuses/{sha}","languages_url":"https://api.github.com/repos/snowconnect/conan-center-index/languages","stargazers_url":"https://api.github.com/repos/snowconnect/conan-center-index/stargazers","contributors_url":"https://api.github.com/repos/snowconnect/conan-center-index/contributors","subscribers_url":"https://api.github.com/repos/snowconnect/conan-center-index/subscribers","subscription_url":"https://api.github.com/repos/snowconnect/conan-center-index/subscription","commits_url":"https://api.github.com/repos/snowconnect/conan-center-index/commits{/sha}","git_commits_url":"https://api.github.com/repos/snowconnect/conan-center-index/git/commits{/sha}","comments_url":"https://api.github.com/repos/snowconnect/conan-center-index/comments{/number}","issue_comment_url":"https://api.github.com/repos/snowconnect/conan-center-index/issues/comments{/number}","contents_url":"https://api.github.com/repos/snowconnect/conan-center-index/contents/{+path}","compare_url":"https://api.github.com/repos/snowconnect/conan-center-index/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snowconnect/conan-center-index/merges","archive_url":"https://api.github.com/repos/snowconnect/conan-center-index/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snowconnect/conan-center-index/downloads","issues_url":"https://api.github.com/repos/snowconnect/conan-center-index/issues{/number}","pulls_url":"https://api.github.com/repos/snowconnect/conan-center-index/pulls{/number}","milestones_url":"https://api.github.com/repos/snowconnect/conan-center-index/milestones{/number}","notifications_url":"https://api.github.com/repos/snowconnect/conan-center-index/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snowconnect/conan-center-index/labels{/name}","releases_url":"https://api.github.com/repos/snowconnect/conan-center-index/releases{/id}","deployments_url":"https://api.github.com/repos/snowconnect/conan-center-index/deployments","created_at":"2019-11-18T23:36:57Z","updated_at":"2019-11-18T23:36:59Z","pushed_at":"2019-11-19T16:51:46Z","git_url":"git://github.com/snowconnect/conan-center-index.git","ssh_url":"git@github.com:snowconnect/conan-center-index.git","clone_url":"https://github.com/snowconnect/conan-center-index.git","svn_url":"https://github.com/snowconnect/conan-center-index","homepage":"https://bintray.com/conan/conan-center","size":7619,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"conan-io:master","ref":"master","sha":"ed521baa4c008c0446934d90bf4c071034a94207","user":{"login":"conan-io","id":15212165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"repo":{"id":204671232,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ2NzEyMzI=","name":"conan-center-index","full_name":"conan-io/conan-center-index","private":false,"owner":{"login":"conan-io","id":15212165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/conan-io/conan-center-index","description":"Recipes for the conan-center repository","fork":false,"url":"https://api.github.com/repos/conan-io/conan-center-index","forks_url":"https://api.github.com/repos/conan-io/conan-center-index/forks","keys_url":"https://api.github.com/repos/conan-io/conan-center-index/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-io/conan-center-index/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-io/conan-center-index/teams","hooks_url":"https://api.github.com/repos/conan-io/conan-center-index/hooks","issue_events_url":"https://api.github.com/repos/conan-io/conan-center-index/issues/events{/number}","events_url":"https://api.github.com/repos/conan-io/conan-center-index/events","assignees_url":"https://api.github.com/repos/conan-io/conan-center-index/assignees{/user}","branches_url":"https://api.github.com/repos/conan-io/conan-center-index/branches{/branch}","tags_url":"https://api.github.com/repos/conan-io/conan-center-index/tags","blobs_url":"https://api.github.com/repos/conan-io/conan-center-index/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-io/conan-center-index/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-io/conan-center-index/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-io/conan-center-index/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-io/conan-center-index/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-io/conan-center-index/languages","stargazers_url":"https://api.github.com/repos/conan-io/conan-center-index/stargazers","contributors_url":"https://api.github.com/repos/conan-io/conan-center-index/contributors","subscribers_url":"https://api.github.com/repos/conan-io/conan-center-index/subscribers","subscription_url":"https://api.github.com/repos/conan-io/conan-center-index/subscription","commits_url":"https://api.github.com/repos/conan-io/conan-center-index/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-io/conan-center-index/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-io/conan-center-index/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-io/conan-center-index/issues/comments{/number}","contents_url":"https://api.github.com/repos/conan-io/conan-center-index/contents/{+path}","compare_url":"https://api.github.com/repos/conan-io/conan-center-index/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-io/conan-center-index/merges","archive_url":"https://api.github.com/repos/conan-io/conan-center-index/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-io/conan-center-index/downloads","issues_url":"https://api.github.com/repos/conan-io/conan-center-index/issues{/number}","pulls_url":"https://api.github.com/repos/conan-io/conan-center-index/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-io/conan-center-index/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-io/conan-center-index/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-io/conan-center-index/labels{/name}","releases_url":"https://api.github.com/repos/conan-io/conan-center-index/releases{/id}","deployments_url":"https://api.github.com/repos/conan-io/conan-center-index/deployments","created_at":"2019-08-27T09:43:58Z","updated_at":"2019-12-12T10:32:31Z","pushed_at":"2019-12-12T10:32:13Z","git_url":"git://github.com/conan-io/conan-center-index.git","ssh_url":"git@github.com:conan-io/conan-center-index.git","clone_url":"https://github.com/conan-io/conan-center-index.git","svn_url":"https://github.com/conan-io/conan-center-index","homepage":"https://bintray.com/conan/conan-center","size":7888,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":141,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":78,"open_issues":141,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan-center-index/pulls/356"},"html":{"href":"https://github.com/conan-io/conan-center-index/pull/356"},"issue":{"href":"https://api.github.com/repos/conan-io/conan-center-index/issues/356"},"comments":{"href":"https://api.github.com/repos/conan-io/conan-center-index/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/conan-io/conan-center-index/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/conan-io/conan-center-index/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conan-io/conan-center-index/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/conan-io/conan-center-index/statuses/b1b07ee681ec353cdb88afe2ded5d6fc82b06e1e"}},"author_association":"NONE"}}
|
{
"id": 204671232,
"name": "conan-io/conan-center-index",
"url": "https://api.github.com/repos/conan-io/conan-center-index"
}
|
{
"id": 10808592,
"login": "danimtb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10808592?",
"url": "https://api.github.com/users/danimtb"
}
|
{
"id": 15212165,
"login": "conan-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15212165?",
"url": "https://api.github.com/orgs/conan-io"
}
| 2019-12-12T11:18:54 |
11072933154
|
{"actor":{"display_login":"danimtb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/iiasa/message_ix/pulls/comments/307721587","pull_request_review_id":267159746,"id":307721587,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzcyMTU4Nw==","diff_hunk":"@@ -1,61 +1,461 @@\n+import collections\n+import os\n+import warnings\n+\n+import pandas as pd\n+\n+from functools import lru_cache\n+\n+from ixmp.utils import logger\n+\n+#\n+# TODOS:\n+#\n+# 1) all demands/prices assumed to be on USEFUL level, need to extend this\n+# to support others\n+#\n \n MACRO_INIT = {\n- 'sets': [\n- ['sector', ],\n- ['mapping_macro_sector', ['sector', 'commodity', 'level', ], ],\n- ],\n- 'pars': [\n- ['demand_MESSAGE', ['node', 'sector', 'year', ], ],\n- ['price_MESSAGE', ['node', 'sector', 'year', ], ],\n- ['cost_MESSAGE', ['node', 'year', ], ],\n- ['gdp_calibrate', ['node', 'year', ], ],\n- ['MERtoPPP', ['node', 'year', ], ],\n- ['kgdp', ['node', ], ],\n- ['kpvs', ['node', ], ],\n- ['depr', ['node', ], ],\n- ['drate', ['node', ], ],\n- ['esub', ['node', ], ],\n- ['lotol', ['node', ], ],\n- ['p_ref', ['node', 'sector', ], ],\n- ['lakl', ['node', ], ],\n- ['prfconst', ['node', 'sector', ], ],\n- ['grow', ['node', 'year', ], ],\n- ['aeei', ['node', 'sector', 'year', ], ],\n- ],\n- 'vars': [\n- ['DEMAND', ['node', 'commodity', 'level', 'year', 'time', ], ],\n- ['PRICE', ['node', 'commodity', 'level', 'year', 'time', ], ],\n- ['COST_NODAL', ['node', 'year', ], ],\n- ['COST_NODAL_NET', ['node', 'year', ], ],\n- ['GDP', ['node', 'year', ], ],\n- ['I', ['node', 'year', ], ],\n- ['C', ['node', 'year', ], ],\n- ['K', ['node', 'year', ], ],\n- ['KN', ['node', 'year', ], ],\n- ['Y', ['node', 'year', ], ],\n- ['YN', ['node', 'year', ], ],\n- ['EC', ['node', 'year', ], ],\n- ['UTILITY', ],\n- ['PHYSENE', ['node', 'sector', 'year', ], ],\n- ['PRODENE', ['node', 'sector', 'year', ], ],\n- ['NEWENE', ['node', 'sector', 'year', ], ],\n- ['EC', ['node', 'year', ], ],\n- ['grow_calibrate', ['node', 'year', ], ],\n- ['aeei_calibrate', ['node', 'sector', 'year', ], ],\n- ],\n- 'equs': [\n- ['COST_ACCOUNTING_NODAL', ['node', 'year', ], ]\n- ],\n+ 'sets': {\n+ 'sector': None,\n+ 'mapping_macro_sector': ['sector', 'commodity', 'level', ],\n+ },\n+ 'pars': {\n+ 'demand_MESSAGE': {\n+ 'idx': ['node', 'sector', 'year', ],\n+ 'unit': 'GWa',\n+ 'data_key': 'demand',\n+ },\n+ 'price_MESSAGE': {\n+ 'idx': ['node', 'sector', 'year', ],\n+ 'unit': 'USD/kWa',\n+ 'data_key': 'price',\n+ },\n+ 'cost_MESSAGE': {\n+ 'idx': ['node', 'year', ],\n+ 'unit': 'G$',\n+ 'data_key': 'total_cost',\n+ },\n+ 'gdp_calibrate': {\n+ 'idx': ['node', 'year', ],\n+ 'unit': 'T$',\n+ },\n+ 'historical_gdp': {\n+ 'idx': ['node', 'year', ],\n+ 'unit': 'T$',\n+ 'data_key': 'gdp0',\n+ },\n+ 'MERtoPPP': {\n+ 'idx': ['node', 'year', ],\n+ 'unit': '-',\n+ },\n+ 'kgdp': {\n+ 'idx': ['node', ],\n+ 'unit': '-',\n+ },\n+ 'kpvs': {\n+ 'idx': ['node', ],\n+ 'unit': '-',\n+ },\n+ 'depr': {\n+ 'idx': ['node', ],\n+ 'unit': '-',\n+ },\n+ 'drate': {\n+ 'idx': ['node', ],\n+ 'unit': '-',\n+ },\n+ 'esub': {\n+ 'idx': ['node', ],\n+ 'unit': '-',\n+ },\n+ 'lotol': {\n+ 'idx': ['node', ],\n+ 'unit': '-',\n+ },\n+ 'price_ref': {\n+ 'idx': ['node', 'sector', ],\n+ 'unit': 'USD/kWa',\n+ },\n+ 'lakl': {\n+ 'idx': ['node', ],\n+ 'unit': '-',\n+ 'data_key': 'aconst',\n+ },\n+ 'prfconst': {\n+ 'idx': ['node', 'sector', ],\n+ 'unit': '-',\n+ 'data_key': 'bconst',\n+ },\n+ 'grow': {\n+ 'idx': ['node', 'year', ],\n+ 'unit': '-',\n+ 'data_key': 'growth',\n+ },\n+ 'aeei': {\n+ 'idx': ['node', 'sector', 'year', ],\n+ 'unit': '-',\n+ },\n+ },\n+ 'vars': {\n+ 'DEMAND': ['node', 'commodity', 'level', 'year', 'time', ],\n+ 'PRICE': ['node', 'commodity', 'level', 'year', 'time', ],\n+ 'COST_NODAL': ['node', 'year', ],\n+ 'COST_NODAL_NET': ['node', 'year', ],\n+ 'GDP': ['node', 'year', ],\n+ 'I': ['node', 'year', ],\n+ 'C': ['node', 'year', ],\n+ 'K': ['node', 'year', ],\n+ 'KN': ['node', 'year', ],\n+ 'Y': ['node', 'year', ],\n+ 'YN': ['node', 'year', ],\n+ 'EC': ['node', 'year', ],","path":"message_ix/macro.py","position":158,"original_position":158,"commit_id":"8ae03056faf8c2fd7a6c8e42f7a7803e5f59d961","original_commit_id":"8ae03056faf8c2fd7a6c8e42f7a7803e5f59d961","user":{"login":"stickler-ci","id":16011037,"node_id":"MDQ6VXNlcjE2MDExMDM3","avatar_url":"https://avatars3.githubusercontent.com/u/16011037?v=4","gravatar_id":"","url":"https://api.github.com/users/stickler-ci","html_url":"https://github.com/stickler-ci","followers_url":"https://api.github.com/users/stickler-ci/followers","following_url":"https://api.github.com/users/stickler-ci/following{/other_user}","gists_url":"https://api.github.com/users/stickler-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/stickler-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickler-ci/subscriptions","organizations_url":"https://api.github.com/users/stickler-ci/orgs","repos_url":"https://api.github.com/users/stickler-ci/repos","events_url":"https://api.github.com/users/stickler-ci/events{/privacy}","received_events_url":"https://api.github.com/users/stickler-ci/received_events","type":"User","site_admin":false},"body":"F601 dictionary key 'EC' repeated with different values","created_at":"2019-07-26T12:33:32Z","updated_at":"2019-07-26T12:33:34Z","html_url":"https://github.com/iiasa/message_ix/pull/223#discussion_r307721587","pull_request_url":"https://api.github.com/repos/iiasa/message_ix/pulls/223","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/iiasa/message_ix/pulls/comments/307721587"},"html":{"href":"https://github.com/iiasa/message_ix/pull/223#discussion_r307721587"},"pull_request":{"href":"https://api.github.com/repos/iiasa/message_ix/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/iiasa/message_ix/pulls/223","id":301522556,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNTIyNTU2","html_url":"https://github.com/iiasa/message_ix/pull/223","diff_url":"https://github.com/iiasa/message_ix/pull/223.diff","patch_url":"https://github.com/iiasa/message_ix/pull/223.patch","issue_url":"https://api.github.com/repos/iiasa/message_ix/issues/223","number":223,"state":"open","locked":false,"title":"Connect MACRO expilcitly to MESSAGEix Scenarios","user":{"login":"gidden","id":1392657,"node_id":"MDQ6VXNlcjEzOTI2NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1392657?v=4","gravatar_id":"","url":"https://api.github.com/users/gidden","html_url":"https://github.com/gidden","followers_url":"https://api.github.com/users/gidden/followers","following_url":"https://api.github.com/users/gidden/following{/other_user}","gists_url":"https://api.github.com/users/gidden/gists{/gist_id}","starred_url":"https://api.github.com/users/gidden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gidden/subscriptions","organizations_url":"https://api.github.com/users/gidden/orgs","repos_url":"https://api.github.com/users/gidden/repos","events_url":"https://api.github.com/users/gidden/events{/privacy}","received_events_url":"https://api.github.com/users/gidden/received_events","type":"User","site_admin":false},"body":"**Required:** write a single sentence here describing the changes made by this PR.\r\n\r\nThis PR brings explicit `MACRO` support into the `message_ix` library. Given a solved `MESSAGE`-stand alone scenario and additional input data (example attached), `MACRO` is parameterized and calibrated. There is an additional option to check that calibration against the number of iterations of a `MESSAGE-MACRO` scenario, checking that `n_iter == `.\r\n\r\n**PR checklist:**\r\n\r\n- [ ] Tests added.\r\n- [ ] Documentation added.\r\n- [ ] Release notes updated. Add a single line at the top of `RELEASE_NOTES.md` similar to…\r\n ```\r\n - [#999](https://github.com/iiasa/message_ix/pull/999) Description from above.\r\n ```\r\n …then, delete this sentence to confirm you've understood the instructions.\r\n","created_at":"2019-07-26T12:33:23Z","updated_at":"2019-07-26T12:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c11e5f55aa7619e9e61efd51f04f60c8321b575","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iiasa/message_ix/pulls/223/commits","review_comments_url":"https://api.github.com/repos/iiasa/message_ix/pulls/223/comments","review_comment_url":"https://api.github.com/repos/iiasa/message_ix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iiasa/message_ix/issues/223/comments","statuses_url":"https://api.github.com/repos/iiasa/message_ix/statuses/8ae03056faf8c2fd7a6c8e42f7a7803e5f59d961","head":{"label":"gidden:explore-macro","ref":"explore-macro","sha":"8ae03056faf8c2fd7a6c8e42f7a7803e5f59d961","user":{"login":"gidden","id":1392657,"node_id":"MDQ6VXNlcjEzOTI2NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1392657?v=4","gravatar_id":"","url":"https://api.github.com/users/gidden","html_url":"https://github.com/gidden","followers_url":"https://api.github.com/users/gidden/followers","following_url":"https://api.github.com/users/gidden/following{/other_user}","gists_url":"https://api.github.com/users/gidden/gists{/gist_id}","starred_url":"https://api.github.com/users/gidden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gidden/subscriptions","organizations_url":"https://api.github.com/users/gidden/orgs","repos_url":"https://api.github.com/users/gidden/repos","events_url":"https://api.github.com/users/gidden/events{/privacy}","received_events_url":"https://api.github.com/users/gidden/received_events","type":"User","site_admin":false},"repo":{"id":124897429,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4OTc0Mjk=","name":"message_ix","full_name":"gidden/message_ix","private":false,"owner":{"login":"gidden","id":1392657,"node_id":"MDQ6VXNlcjEzOTI2NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1392657?v=4","gravatar_id":"","url":"https://api.github.com/users/gidden","html_url":"https://github.com/gidden","followers_url":"https://api.github.com/users/gidden/followers","following_url":"https://api.github.com/users/gidden/following{/other_user}","gists_url":"https://api.github.com/users/gidden/gists{/gist_id}","starred_url":"https://api.github.com/users/gidden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gidden/subscriptions","organizations_url":"https://api.github.com/users/gidden/orgs","repos_url":"https://api.github.com/users/gidden/repos","events_url":"https://api.github.com/users/gidden/events{/privacy}","received_events_url":"https://api.github.com/users/gidden/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gidden/message_ix","description":"The integrated assessment and energy systems model MESSAGEix","fork":true,"url":"https://api.github.com/repos/gidden/message_ix","forks_url":"https://api.github.com/repos/gidden/message_ix/forks","keys_url":"https://api.github.com/repos/gidden/message_ix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gidden/message_ix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gidden/message_ix/teams","hooks_url":"https://api.github.com/repos/gidden/message_ix/hooks","issue_events_url":"https://api.github.com/repos/gidden/message_ix/issues/events{/number}","events_url":"https://api.github.com/repos/gidden/message_ix/events","assignees_url":"https://api.github.com/repos/gidden/message_ix/assignees{/user}","branches_url":"https://api.github.com/repos/gidden/message_ix/branches{/branch}","tags_url":"https://api.github.com/repos/gidden/message_ix/tags","blobs_url":"https://api.github.com/repos/gidden/message_ix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gidden/message_ix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gidden/message_ix/git/refs{/sha}","trees_url":"https://api.github.com/repos/gidden/message_ix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gidden/message_ix/statuses/{sha}","languages_url":"https://api.github.com/repos/gidden/message_ix/languages","stargazers_url":"https://api.github.com/repos/gidden/message_ix/stargazers","contributors_url":"https://api.github.com/repos/gidden/message_ix/contributors","subscribers_url":"https://api.github.com/repos/gidden/message_ix/subscribers","subscription_url":"https://api.github.com/repos/gidden/message_ix/subscription","commits_url":"https://api.github.com/repos/gidden/message_ix/commits{/sha}","git_commits_url":"https://api.github.com/repos/gidden/message_ix/git/commits{/sha}","comments_url":"https://api.github.com/repos/gidden/message_ix/comments{/number}","issue_comment_url":"https://api.github.com/repos/gidden/message_ix/issues/comments{/number}","contents_url":"https://api.github.com/repos/gidden/message_ix/contents/{+path}","compare_url":"https://api.github.com/repos/gidden/message_ix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gidden/message_ix/merges","archive_url":"https://api.github.com/repos/gidden/message_ix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gidden/message_ix/downloads","issues_url":"https://api.github.com/repos/gidden/message_ix/issues{/number}","pulls_url":"https://api.github.com/repos/gidden/message_ix/pulls{/number}","milestones_url":"https://api.github.com/repos/gidden/message_ix/milestones{/number}","notifications_url":"https://api.github.com/repos/gidden/message_ix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gidden/message_ix/labels{/name}","releases_url":"https://api.github.com/repos/gidden/message_ix/releases{/id}","deployments_url":"https://api.github.com/repos/gidden/message_ix/deployments","created_at":"2018-03-12T13:58:07Z","updated_at":"2019-06-26T03:27:25Z","pushed_at":"2019-07-26T11:37:00Z","git_url":"git://github.com/gidden/message_ix.git","ssh_url":"git@github.com:gidden/message_ix.git","clone_url":"https://github.com/gidden/message_ix.git","svn_url":"https://github.com/gidden/message_ix","homepage":"https://MESSAGEix.iiasa.ac.at/","size":4101,"stargazers_count":1,"watchers_count":1,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"iiasa:master","ref":"master","sha":"8a4587544b242744da21439af9e61bf986d6733e","user":{"login":"iiasa","id":15230149,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjMwMTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/15230149?v=4","gravatar_id":"","url":"https://api.github.com/users/iiasa","html_url":"https://github.com/iiasa","followers_url":"https://api.github.com/users/iiasa/followers","following_url":"https://api.github.com/users/iiasa/following{/other_user}","gists_url":"https://api.github.com/users/iiasa/gists{/gist_id}","starred_url":"https://api.github.com/users/iiasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iiasa/subscriptions","organizations_url":"https://api.github.com/users/iiasa/orgs","repos_url":"https://api.github.com/users/iiasa/repos","events_url":"https://api.github.com/users/iiasa/events{/privacy}","received_events_url":"https://api.github.com/users/iiasa/received_events","type":"Organization","site_admin":false},"repo":{"id":113015968,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMwMTU5Njg=","name":"message_ix","full_name":"iiasa/message_ix","private":false,"owner":{"login":"iiasa","id":15230149,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjMwMTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/15230149?v=4","gravatar_id":"","url":"https://api.github.com/users/iiasa","html_url":"https://github.com/iiasa","followers_url":"https://api.github.com/users/iiasa/followers","following_url":"https://api.github.com/users/iiasa/following{/other_user}","gists_url":"https://api.github.com/users/iiasa/gists{/gist_id}","starred_url":"https://api.github.com/users/iiasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iiasa/subscriptions","organizations_url":"https://api.github.com/users/iiasa/orgs","repos_url":"https://api.github.com/users/iiasa/repos","events_url":"https://api.github.com/users/iiasa/events{/privacy}","received_events_url":"https://api.github.com/users/iiasa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iiasa/message_ix","description":"The integrated assessment and energy systems model MESSAGEix","fork":false,"url":"https://api.github.com/repos/iiasa/message_ix","forks_url":"https://api.github.com/repos/iiasa/message_ix/forks","keys_url":"https://api.github.com/repos/iiasa/message_ix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iiasa/message_ix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iiasa/message_ix/teams","hooks_url":"https://api.github.com/repos/iiasa/message_ix/hooks","issue_events_url":"https://api.github.com/repos/iiasa/message_ix/issues/events{/number}","events_url":"https://api.github.com/repos/iiasa/message_ix/events","assignees_url":"https://api.github.com/repos/iiasa/message_ix/assignees{/user}","branches_url":"https://api.github.com/repos/iiasa/message_ix/branches{/branch}","tags_url":"https://api.github.com/repos/iiasa/message_ix/tags","blobs_url":"https://api.github.com/repos/iiasa/message_ix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iiasa/message_ix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iiasa/message_ix/git/refs{/sha}","trees_url":"https://api.github.com/repos/iiasa/message_ix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iiasa/message_ix/statuses/{sha}","languages_url":"https://api.github.com/repos/iiasa/message_ix/languages","stargazers_url":"https://api.github.com/repos/iiasa/message_ix/stargazers","contributors_url":"https://api.github.com/repos/iiasa/message_ix/contributors","subscribers_url":"https://api.github.com/repos/iiasa/message_ix/subscribers","subscription_url":"https://api.github.com/repos/iiasa/message_ix/subscription","commits_url":"https://api.github.com/repos/iiasa/message_ix/commits{/sha}","git_commits_url":"https://api.github.com/repos/iiasa/message_ix/git/commits{/sha}","comments_url":"https://api.github.com/repos/iiasa/message_ix/comments{/number}","issue_comment_url":"https://api.github.com/repos/iiasa/message_ix/issues/comments{/number}","contents_url":"https://api.github.com/repos/iiasa/message_ix/contents/{+path}","compare_url":"https://api.github.com/repos/iiasa/message_ix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iiasa/message_ix/merges","archive_url":"https://api.github.com/repos/iiasa/message_ix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iiasa/message_ix/downloads","issues_url":"https://api.github.com/repos/iiasa/message_ix/issues{/number}","pulls_url":"https://api.github.com/repos/iiasa/message_ix/pulls{/number}","milestones_url":"https://api.github.com/repos/iiasa/message_ix/milestones{/number}","notifications_url":"https://api.github.com/repos/iiasa/message_ix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iiasa/message_ix/labels{/name}","releases_url":"https://api.github.com/repos/iiasa/message_ix/releases{/id}","deployments_url":"https://api.github.com/repos/iiasa/message_ix/deployments","created_at":"2017-12-04T08:29:06Z","updated_at":"2019-06-27T16:20:22Z","pushed_at":"2019-07-26T12:33:24Z","git_url":"git://github.com/iiasa/message_ix.git","ssh_url":"git@github.com:iiasa/message_ix.git","clone_url":"https://github.com/iiasa/message_ix.git","svn_url":"https://github.com/iiasa/message_ix","homepage":"https://message.iiasa.ac.at/","size":3922,"stargazers_count":25,"watchers_count":25,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":47,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":63,"open_issues":47,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iiasa/message_ix/pulls/223"},"html":{"href":"https://github.com/iiasa/message_ix/pull/223"},"issue":{"href":"https://api.github.com/repos/iiasa/message_ix/issues/223"},"comments":{"href":"https://api.github.com/repos/iiasa/message_ix/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/iiasa/message_ix/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/iiasa/message_ix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iiasa/message_ix/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/iiasa/message_ix/statuses/8ae03056faf8c2fd7a6c8e42f7a7803e5f59d961"}},"author_association":"MEMBER"}}
|
{
"id": 113015968,
"name": "iiasa/message_ix",
"url": "https://api.github.com/repos/iiasa/message_ix"
}
|
{
"id": 16011037,
"login": "stickler-ci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16011037?",
"url": "https://api.github.com/users/stickler-ci"
}
|
{
"id": 15230149,
"login": "iiasa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15230149?",
"url": "https://api.github.com/orgs/iiasa"
}
| 2019-07-26T12:33:32 |
10090743560
|
{"actor":{"display_login":"stickler-ci"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/273918967","pull_request_review_id":224920115,"id":273918967,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzkxODk2Nw==","diff_hunk":"@@ -0,0 +1,38 @@\n+\n+#include <pthread.h>","path":"tensorflow/contrib/seastar/seastar_tensor_coding.cc","position":1,"original_position":2,"commit_id":"04bffbed05abacc12cc9c017a456afbfb447d3fb","original_commit_id":"ee72a4bb8dd490957708dd2e8416f40cab02e21a","user":{"login":"liutongxuan","id":2573025,"node_id":"MDQ6VXNlcjI1NzMwMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2573025?v=4","gravatar_id":"","url":"https://api.github.com/users/liutongxuan","html_url":"https://github.com/liutongxuan","followers_url":"https://api.github.com/users/liutongxuan/followers","following_url":"https://api.github.com/users/liutongxuan/following{/other_user}","gists_url":"https://api.github.com/users/liutongxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/liutongxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liutongxuan/subscriptions","organizations_url":"https://api.github.com/users/liutongxuan/orgs","repos_url":"https://api.github.com/users/liutongxuan/repos","events_url":"https://api.github.com/users/liutongxuan/events{/privacy}","received_events_url":"https://api.github.com/users/liutongxuan/received_events","type":"User","site_admin":false},"body":"i suppose, these code is useless.","created_at":"2019-04-10T11:52:35Z","updated_at":"2019-04-10T11:52:36Z","html_url":"https://github.com/tensorflow/tensorflow/pull/27454#discussion_r273918967","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27454","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/273918967"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/27454#discussion_r273918967"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27454"}},"in_reply_to_id":272061828},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27454","id":266950427,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2OTUwNDI3","html_url":"https://github.com/tensorflow/tensorflow/pull/27454","diff_url":"https://github.com/tensorflow/tensorflow/pull/27454.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/27454.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/27454","number":27454,"state":"open","locked":false,"title":"[WIP] grpc+seastar: add grpc+seastar protocol which uses Seastar as RPC for WorkerService","user":{"login":"byronyi","id":2613663,"node_id":"MDQ6VXNlcjI2MTM2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2613663?v=4","gravatar_id":"","url":"https://api.github.com/users/byronyi","html_url":"https://github.com/byronyi","followers_url":"https://api.github.com/users/byronyi/followers","following_url":"https://api.github.com/users/byronyi/following{/other_user}","gists_url":"https://api.github.com/users/byronyi/gists{/gist_id}","starred_url":"https://api.github.com/users/byronyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byronyi/subscriptions","organizations_url":"https://api.github.com/users/byronyi/orgs","repos_url":"https://api.github.com/users/byronyi/repos","events_url":"https://api.github.com/users/byronyi/events{/privacy}","received_events_url":"https://api.github.com/users/byronyi/received_events","type":"User","site_admin":false},"body":"This PR serves as a placeholder for contribution from @liutongxuan and his colleagues in Alibaba. \r\n\r\nSince TF is going to have yet another (hopefully last) release before 2.0 (r1.14 to be cut on April 15), I am not sure if we have enough time (or incentive) to push this feature into the main repo. \r\n\r\n[tensorflow/networking](https://github.com/tensorflow/networking) should serve as its final target after 2.0. As we are still transitioning and @annarev is working on the networking C API, I would still like to submit this PR against the main repo, mainly for the convenience of reviewing. When we feel like ready, we shall have another PR in https://github.com/tensorflow/networking for refactoring it as a standalone plugin.\r\n\r\nPing @jbedorf @poxvoculi; if you have time feel free to join the reviewing process.","created_at":"2019-04-03T08:54:59Z","updated_at":"2019-04-10T11:52:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4433071a06e639f18591ac8fff7e1bab1ddd835","assignee":{"login":"rthadur","id":43972606,"node_id":"MDQ6VXNlcjQzOTcyNjA2","avatar_url":"https://avatars2.githubusercontent.com/u/43972606?v=4","gravatar_id":"","url":"https://api.github.com/users/rthadur","html_url":"https://github.com/rthadur","followers_url":"https://api.github.com/users/rthadur/followers","following_url":"https://api.github.com/users/rthadur/following{/other_user}","gists_url":"https://api.github.com/users/rthadur/gists{/gist_id}","starred_url":"https://api.github.com/users/rthadur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rthadur/subscriptions","organizations_url":"https://api.github.com/users/rthadur/orgs","repos_url":"https://api.github.com/users/rthadur/repos","events_url":"https://api.github.com/users/rthadur/events{/privacy}","received_events_url":"https://api.github.com/users/rthadur/received_events","type":"User","site_admin":false},"assignees":[{"login":"rthadur","id":43972606,"node_id":"MDQ6VXNlcjQzOTcyNjA2","avatar_url":"https://avatars2.githubusercontent.com/u/43972606?v=4","gravatar_id":"","url":"https://api.github.com/users/rthadur","html_url":"https://github.com/rthadur","followers_url":"https://api.github.com/users/rthadur/followers","following_url":"https://api.github.com/users/rthadur/following{/other_user}","gists_url":"https://api.github.com/users/rthadur/gists{/gist_id}","starred_url":"https://api.github.com/users/rthadur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rthadur/subscriptions","organizations_url":"https://api.github.com/users/rthadur/orgs","repos_url":"https://api.github.com/users/rthadur/repos","events_url":"https://api.github.com/users/rthadur/events{/privacy}","received_events_url":"https://api.github.com/users/rthadur/received_events","type":"User","site_admin":false},{"login":"gbaned","id":48215717,"node_id":"MDQ6VXNlcjQ4MjE1NzE3","avatar_url":"https://avatars3.githubusercontent.com/u/48215717?v=4","gravatar_id":"","url":"https://api.github.com/users/gbaned","html_url":"https://github.com/gbaned","followers_url":"https://api.github.com/users/gbaned/followers","following_url":"https://api.github.com/users/gbaned/following{/other_user}","gists_url":"https://api.github.com/users/gbaned/gists{/gist_id}","starred_url":"https://api.github.com/users/gbaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbaned/subscriptions","organizations_url":"https://api.github.com/users/gbaned/orgs","repos_url":"https://api.github.com/users/gbaned/repos","events_url":"https://api.github.com/users/gbaned/events{/privacy}","received_events_url":"https://api.github.com/users/gbaned/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"poxvoculi","id":15676913,"node_id":"MDQ6VXNlcjE1Njc2OTEz","avatar_url":"https://avatars2.githubusercontent.com/u/15676913?v=4","gravatar_id":"","url":"https://api.github.com/users/poxvoculi","html_url":"https://github.com/poxvoculi","followers_url":"https://api.github.com/users/poxvoculi/followers","following_url":"https://api.github.com/users/poxvoculi/following{/other_user}","gists_url":"https://api.github.com/users/poxvoculi/gists{/gist_id}","starred_url":"https://api.github.com/users/poxvoculi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poxvoculi/subscriptions","organizations_url":"https://api.github.com/users/poxvoculi/orgs","repos_url":"https://api.github.com/users/poxvoculi/repos","events_url":"https://api.github.com/users/poxvoculi/events{/privacy}","received_events_url":"https://api.github.com/users/poxvoculi/received_events","type":"User","site_admin":false},{"login":"annarev","id":22060313,"node_id":"MDQ6VXNlcjIyMDYwMzEz","avatar_url":"https://avatars0.githubusercontent.com/u/22060313?v=4","gravatar_id":"","url":"https://api.github.com/users/annarev","html_url":"https://github.com/annarev","followers_url":"https://api.github.com/users/annarev/followers","following_url":"https://api.github.com/users/annarev/following{/other_user}","gists_url":"https://api.github.com/users/annarev/gists{/gist_id}","starred_url":"https://api.github.com/users/annarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annarev/subscriptions","organizations_url":"https://api.github.com/users/annarev/orgs","repos_url":"https://api.github.com/users/annarev/repos","events_url":"https://api.github.com/users/annarev/events{/privacy}","received_events_url":"https://api.github.com/users/annarev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":1173072136,"node_id":"MDU6TGFiZWwxMTczMDcyMTM2","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/size:XL","name":"size:XL","color":"adafea","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27454/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27454/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/27454/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/04bffbed05abacc12cc9c017a456afbfb447d3fb","head":{"label":"liutongxuan:features/grpc+seastar","ref":"features/grpc+seastar","sha":"04bffbed05abacc12cc9c017a456afbfb447d3fb","user":{"login":"liutongxuan","id":2573025,"node_id":"MDQ6VXNlcjI1NzMwMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2573025?v=4","gravatar_id":"","url":"https://api.github.com/users/liutongxuan","html_url":"https://github.com/liutongxuan","followers_url":"https://api.github.com/users/liutongxuan/followers","following_url":"https://api.github.com/users/liutongxuan/following{/other_user}","gists_url":"https://api.github.com/users/liutongxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/liutongxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liutongxuan/subscriptions","organizations_url":"https://api.github.com/users/liutongxuan/orgs","repos_url":"https://api.github.com/users/liutongxuan/repos","events_url":"https://api.github.com/users/liutongxuan/events{/privacy}","received_events_url":"https://api.github.com/users/liutongxuan/received_events","type":"User","site_admin":false},"repo":{"id":47862268,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzg2MjI2OA==","name":"tensorflow","full_name":"liutongxuan/tensorflow","private":false,"owner":{"login":"liutongxuan","id":2573025,"node_id":"MDQ6VXNlcjI1NzMwMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2573025?v=4","gravatar_id":"","url":"https://api.github.com/users/liutongxuan","html_url":"https://github.com/liutongxuan","followers_url":"https://api.github.com/users/liutongxuan/followers","following_url":"https://api.github.com/users/liutongxuan/following{/other_user}","gists_url":"https://api.github.com/users/liutongxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/liutongxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liutongxuan/subscriptions","organizations_url":"https://api.github.com/users/liutongxuan/orgs","repos_url":"https://api.github.com/users/liutongxuan/repos","events_url":"https://api.github.com/users/liutongxuan/events{/privacy}","received_events_url":"https://api.github.com/users/liutongxuan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/liutongxuan/tensorflow","description":" Open source software library for numerical computation using data flow graphs.","fork":true,"url":"https://api.github.com/repos/liutongxuan/tensorflow","forks_url":"https://api.github.com/repos/liutongxuan/tensorflow/forks","keys_url":"https://api.github.com/repos/liutongxuan/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liutongxuan/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liutongxuan/tensorflow/teams","hooks_url":"https://api.github.com/repos/liutongxuan/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/liutongxuan/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/liutongxuan/tensorflow/events","assignees_url":"https://api.github.com/repos/liutongxuan/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/liutongxuan/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/liutongxuan/tensorflow/tags","blobs_url":"https://api.github.com/repos/liutongxuan/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liutongxuan/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liutongxuan/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/liutongxuan/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liutongxuan/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/liutongxuan/tensorflow/languages","stargazers_url":"https://api.github.com/repos/liutongxuan/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/liutongxuan/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/liutongxuan/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/liutongxuan/tensorflow/subscription","commits_url":"https://api.github.com/repos/liutongxuan/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/liutongxuan/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/liutongxuan/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/liutongxuan/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/liutongxuan/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/liutongxuan/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liutongxuan/tensorflow/merges","archive_url":"https://api.github.com/repos/liutongxuan/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liutongxuan/tensorflow/downloads","issues_url":"https://api.github.com/repos/liutongxuan/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/liutongxuan/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/liutongxuan/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/liutongxuan/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liutongxuan/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/liutongxuan/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/liutongxuan/tensorflow/deployments","created_at":"2015-12-12T03:17:53Z","updated_at":"2019-03-12T02:32:50Z","pushed_at":"2019-04-09T12:03:30Z","git_url":"git://github.com/liutongxuan/tensorflow.git","ssh_url":"git@github.com:liutongxuan/tensorflow.git","clone_url":"https://github.com/liutongxuan/tensorflow.git","svn_url":"https://github.com/liutongxuan/tensorflow","homepage":"http://tensorflow.org","size":334336,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"d38aee5165fc4033612e270e1ee222aeb9f60860","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcxNzI1MA==","name":"tensorflow","full_name":"tensorflow/tensorflow","private":false,"owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tensorflow/tensorflow","description":"An Open Source Machine Learning Framework for Everyone","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2019-04-10T11:49:24Z","pushed_at":"2019-04-10T10:17:13Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"https://tensorflow.org","size":335402,"stargazers_count":125156,"watchers_count":125156,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73640,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2445,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73640,"open_issues":2445,"watchers":125156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27454"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/27454"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/27454"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/27454/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27454/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27454/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/04bffbed05abacc12cc9c017a456afbfb447d3fb"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 45717250,
"name": "tensorflow/tensorflow",
"url": "https://api.github.com/repos/tensorflow/tensorflow"
}
|
{
"id": 2573025,
"login": "liutongxuan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2573025?",
"url": "https://api.github.com/users/liutongxuan"
}
|
{
"id": 15658638,
"login": "tensorflow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15658638?",
"url": "https://api.github.com/orgs/tensorflow"
}
| 2019-04-10T11:52:35 |
9415114616
|
{"actor":{"display_login":"liutongxuan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/273561304","pull_request_review_id":224495046,"id":273561304,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzU2MTMwNA==","diff_hunk":"@@ -1999,7 +1999,7 @@ REGISTER_OP(\"_MklLeakyRelu\")\n .Input(\"mkl_features: uint8\")\n .Output(\"activations: T\")\n .Output(\"mkl_activations: uint8\")\n- .Attr(\"T: {half, float, double} = DT_FLOAT\")\n+ .Attr(\"T: realnumbertype = DT_FLOAT\")","path":"tensorflow/core/ops/nn_ops.cc","position":5,"original_position":5,"commit_id":"d495b8dfe96de1d0c8d41fb93d0c4016c683cb5c","original_commit_id":"d495b8dfe96de1d0c8d41fb93d0c4016c683cb5c","user":{"login":"penpornk","id":38085909,"node_id":"MDQ6VXNlcjM4MDg1OTA5","avatar_url":"https://avatars3.githubusercontent.com/u/38085909?v=4","gravatar_id":"","url":"https://api.github.com/users/penpornk","html_url":"https://github.com/penpornk","followers_url":"https://api.github.com/users/penpornk/followers","following_url":"https://api.github.com/users/penpornk/following{/other_user}","gists_url":"https://api.github.com/users/penpornk/gists{/gist_id}","starred_url":"https://api.github.com/users/penpornk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penpornk/subscriptions","organizations_url":"https://api.github.com/users/penpornk/orgs","repos_url":"https://api.github.com/users/penpornk/repos","events_url":"https://api.github.com/users/penpornk/events{/privacy}","received_events_url":"https://api.github.com/users/penpornk/received_events","type":"User","site_admin":false},"body":"`realnumbertype` supports integrals. Do you want to allow int as well?\r\nhttps://github.com/tensorflow/tensorflow/blob/526f6337bbbaee4492156d358b9d5e90d1c87382/tensorflow/core/framework/op_def_builder.cc#L135-L140\r\nhttps://github.com/tensorflow/tensorflow/blob/526f6337bbbaee4492156d358b9d5e90d1c87382/tensorflow/core/framework/types.h#L274-L279","created_at":"2019-04-09T15:49:54Z","updated_at":"2019-04-09T15:52:04Z","html_url":"https://github.com/tensorflow/tensorflow/pull/27436#discussion_r273561304","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27436","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/273561304"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/27436#discussion_r273561304"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27436"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27436","id":266832497,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2ODMyNDk3","html_url":"https://github.com/tensorflow/tensorflow/pull/27436","diff_url":"https://github.com/tensorflow/tensorflow/pull/27436.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/27436.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/27436","number":27436,"state":"open","locked":false,"title":"[Intel MKL] Enabling BFloat16 element-wise ops using MKLDNN API - Rou…","user":{"login":"nhasabni","id":22304502,"node_id":"MDQ6VXNlcjIyMzA0NTAy","avatar_url":"https://avatars0.githubusercontent.com/u/22304502?v=4","gravatar_id":"","url":"https://api.github.com/users/nhasabni","html_url":"https://github.com/nhasabni","followers_url":"https://api.github.com/users/nhasabni/followers","following_url":"https://api.github.com/users/nhasabni/following{/other_user}","gists_url":"https://api.github.com/users/nhasabni/gists{/gist_id}","starred_url":"https://api.github.com/users/nhasabni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhasabni/subscriptions","organizations_url":"https://api.github.com/users/nhasabni/orgs","repos_url":"https://api.github.com/users/nhasabni/repos","events_url":"https://api.github.com/users/nhasabni/events{/privacy}","received_events_url":"https://api.github.com/users/nhasabni/received_events","type":"User","site_admin":false},"body":"…nd 2\r\n\r\nThis PR enables support for BFloat16 versions of element-wise arithmetic ops\r\nand activation functions using MKL-DNN API.","created_at":"2019-04-02T22:33:25Z","updated_at":"2019-04-09T15:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4048890c20962eb7e4a11b570e07eeb79046cf45","assignee":{"login":"rthadur","id":43972606,"node_id":"MDQ6VXNlcjQzOTcyNjA2","avatar_url":"https://avatars2.githubusercontent.com/u/43972606?v=4","gravatar_id":"","url":"https://api.github.com/users/rthadur","html_url":"https://github.com/rthadur","followers_url":"https://api.github.com/users/rthadur/followers","following_url":"https://api.github.com/users/rthadur/following{/other_user}","gists_url":"https://api.github.com/users/rthadur/gists{/gist_id}","starred_url":"https://api.github.com/users/rthadur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rthadur/subscriptions","organizations_url":"https://api.github.com/users/rthadur/orgs","repos_url":"https://api.github.com/users/rthadur/repos","events_url":"https://api.github.com/users/rthadur/events{/privacy}","received_events_url":"https://api.github.com/users/rthadur/received_events","type":"User","site_admin":false},"assignees":[{"login":"rthadur","id":43972606,"node_id":"MDQ6VXNlcjQzOTcyNjA2","avatar_url":"https://avatars2.githubusercontent.com/u/43972606?v=4","gravatar_id":"","url":"https://api.github.com/users/rthadur","html_url":"https://github.com/rthadur","followers_url":"https://api.github.com/users/rthadur/followers","following_url":"https://api.github.com/users/rthadur/following{/other_user}","gists_url":"https://api.github.com/users/rthadur/gists{/gist_id}","starred_url":"https://api.github.com/users/rthadur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rthadur/subscriptions","organizations_url":"https://api.github.com/users/rthadur/orgs","repos_url":"https://api.github.com/users/rthadur/repos","events_url":"https://api.github.com/users/rthadur/events{/privacy}","received_events_url":"https://api.github.com/users/rthadur/received_events","type":"User","site_admin":false},{"login":"gbaned","id":48215717,"node_id":"MDQ6VXNlcjQ4MjE1NzE3","avatar_url":"https://avatars3.githubusercontent.com/u/48215717?v=4","gravatar_id":"","url":"https://api.github.com/users/gbaned","html_url":"https://github.com/gbaned","followers_url":"https://api.github.com/users/gbaned/followers","following_url":"https://api.github.com/users/gbaned/following{/other_user}","gists_url":"https://api.github.com/users/gbaned/gists{/gist_id}","starred_url":"https://api.github.com/users/gbaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbaned/subscriptions","organizations_url":"https://api.github.com/users/gbaned/orgs","repos_url":"https://api.github.com/users/gbaned/repos","events_url":"https://api.github.com/users/gbaned/events{/privacy}","received_events_url":"https://api.github.com/users/gbaned/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":1104829434,"node_id":"MDU6TGFiZWwxMTA0ODI5NDM0","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/comp:mkl","name":"comp:mkl","color":"0052cc","default":false},{"id":1169365494,"node_id":"MDU6TGFiZWwxMTY5MzY1NDk0","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/size:M","name":"size:M","color":"adafea","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27436/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27436/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/27436/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/d495b8dfe96de1d0c8d41fb93d0c4016c683cb5c","head":{"label":"Intel-tensorflow:nhasabni/bf16v2","ref":"nhasabni/bf16v2","sha":"d495b8dfe96de1d0c8d41fb93d0c4016c683cb5c","user":{"login":"Intel-tensorflow","id":24963131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTYzMTMx","avatar_url":"https://avatars0.githubusercontent.com/u/24963131?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-tensorflow","html_url":"https://github.com/Intel-tensorflow","followers_url":"https://api.github.com/users/Intel-tensorflow/followers","following_url":"https://api.github.com/users/Intel-tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/Intel-tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-tensorflow/subscriptions","organizations_url":"https://api.github.com/users/Intel-tensorflow/orgs","repos_url":"https://api.github.com/users/Intel-tensorflow/repos","events_url":"https://api.github.com/users/Intel-tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":78224733,"node_id":"MDEwOlJlcG9zaXRvcnk3ODIyNDczMw==","name":"tensorflow","full_name":"Intel-tensorflow/tensorflow","private":false,"owner":{"login":"Intel-tensorflow","id":24963131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTYzMTMx","avatar_url":"https://avatars0.githubusercontent.com/u/24963131?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-tensorflow","html_url":"https://github.com/Intel-tensorflow","followers_url":"https://api.github.com/users/Intel-tensorflow/followers","following_url":"https://api.github.com/users/Intel-tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/Intel-tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-tensorflow/subscriptions","organizations_url":"https://api.github.com/users/Intel-tensorflow/orgs","repos_url":"https://api.github.com/users/Intel-tensorflow/repos","events_url":"https://api.github.com/users/Intel-tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-tensorflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Intel-tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/Intel-tensorflow/tensorflow","forks_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/Intel-tensorflow/tensorflow/deployments","created_at":"2017-01-06T17:23:49Z","updated_at":"2019-04-09T04:34:39Z","pushed_at":"2019-04-09T04:36:48Z","git_url":"git://github.com/Intel-tensorflow/tensorflow.git","ssh_url":"git@github.com:Intel-tensorflow/tensorflow.git","clone_url":"https://github.com/Intel-tensorflow/tensorflow.git","svn_url":"https://github.com/Intel-tensorflow/tensorflow","homepage":"http://tensorflow.org","size":334122,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":1,"watchers":12,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"a6a0611a6320e915f8ec99fefa4fb27153080499","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcxNzI1MA==","name":"tensorflow","full_name":"tensorflow/tensorflow","private":false,"owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tensorflow/tensorflow","description":"An Open Source Machine Learning Framework for Everyone","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2019-04-09T15:40:58Z","pushed_at":"2019-04-09T15:31:28Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"https://tensorflow.org","size":337889,"stargazers_count":125071,"watchers_count":125071,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73617,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2437,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73617,"open_issues":2437,"watchers":125071,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27436"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/27436"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/27436"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/27436/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27436/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/27436/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/d495b8dfe96de1d0c8d41fb93d0c4016c683cb5c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 45717250,
"name": "tensorflow/tensorflow",
"url": "https://api.github.com/repos/tensorflow/tensorflow"
}
|
{
"id": 38085909,
"login": "penpornk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38085909?",
"url": "https://api.github.com/users/penpornk"
}
|
{
"id": 15658638,
"login": "tensorflow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15658638?",
"url": "https://api.github.com/orgs/tensorflow"
}
| 2019-04-09T15:49:54 |
9408644601
|
{"actor":{"display_login":"penpornk"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/addons/pulls/comments/260549257","pull_request_review_id":208282458,"id":260549257,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDU0OTI1Nw==","diff_hunk":"@@ -19,27 +19,27 @@\n from __future__ import print_function\n \n import numpy as np\n+import tensorflow as tf\n \n-from tensorflow.python.keras import testing_utils\n-from tensorflow.python.platform import test\n+from tensorflow.python.keras import testing_utils as keras_test_util","path":"tensorflow_addons/layers/python/maxout_test.py","position":8,"original_position":8,"commit_id":"e1cb2780812b3b1e70b17914ba070da583ab14c5","original_commit_id":"99d8575c337f5b825ed2b2841222247a1a39ecb9","user":{"login":"seanpmorgan","id":18154355,"node_id":"MDQ6VXNlcjE4MTU0MzU1","avatar_url":"https://avatars3.githubusercontent.com/u/18154355?v=4","gravatar_id":"","url":"https://api.github.com/users/seanpmorgan","html_url":"https://github.com/seanpmorgan","followers_url":"https://api.github.com/users/seanpmorgan/followers","following_url":"https://api.github.com/users/seanpmorgan/following{/other_user}","gists_url":"https://api.github.com/users/seanpmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpmorgan/subscriptions","organizations_url":"https://api.github.com/users/seanpmorgan/orgs","repos_url":"https://api.github.com/users/seanpmorgan/repos","events_url":"https://api.github.com/users/seanpmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/seanpmorgan/received_events","type":"User","site_admin":false},"body":"I don't believe they are. I can add this to the list of APIs that we find we need.","created_at":"2019-02-27T00:30:30Z","updated_at":"2019-02-27T00:30:30Z","html_url":"https://github.com/tensorflow/addons/pull/55#discussion_r260549257","pull_request_url":"https://api.github.com/repos/tensorflow/addons/pulls/55","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/addons/pulls/comments/260549257"},"html":{"href":"https://github.com/tensorflow/addons/pull/55#discussion_r260549257"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/addons/pulls/55"}},"in_reply_to_id":260415175},"pull_request":{"url":"https://api.github.com/repos/tensorflow/addons/pulls/55","id":256089984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2MDg5OTg0","html_url":"https://github.com/tensorflow/addons/pull/55","diff_url":"https://github.com/tensorflow/addons/pull/55.diff","patch_url":"https://github.com/tensorflow/addons/pull/55.patch","issue_url":"https://api.github.com/repos/tensorflow/addons/issues/55","number":55,"state":"open","locked":false,"title":"FIX: Use correct TF imports","user":{"login":"seanpmorgan","id":18154355,"node_id":"MDQ6VXNlcjE4MTU0MzU1","avatar_url":"https://avatars3.githubusercontent.com/u/18154355?v=4","gravatar_id":"","url":"https://api.github.com/users/seanpmorgan","html_url":"https://github.com/seanpmorgan","followers_url":"https://api.github.com/users/seanpmorgan/followers","following_url":"https://api.github.com/users/seanpmorgan/following{/other_user}","gists_url":"https://api.github.com/users/seanpmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpmorgan/subscriptions","organizations_url":"https://api.github.com/users/seanpmorgan/orgs","repos_url":"https://api.github.com/users/seanpmorgan/repos","events_url":"https://api.github.com/users/seanpmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/seanpmorgan/received_events","type":"User","site_admin":false},"body":"Couple of different ways this could be done so wanted to submit the PR and discuss. When we merge this we should probably start a STYLE doc and add this.\r\n\r\nCloses #50 ","created_at":"2019-02-25T23:47:37Z","updated_at":"2019-02-27T00:30:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"613e1dbfa8fea87e9d9e0f37a82174d27909c6ce","assignee":null,"assignees":[],"requested_reviewers":[{"login":"facaiy","id":1112263,"node_id":"MDQ6VXNlcjExMTIyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1112263?v=4","gravatar_id":"","url":"https://api.github.com/users/facaiy","html_url":"https://github.com/facaiy","followers_url":"https://api.github.com/users/facaiy/followers","following_url":"https://api.github.com/users/facaiy/following{/other_user}","gists_url":"https://api.github.com/users/facaiy/gists{/gist_id}","starred_url":"https://api.github.com/users/facaiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facaiy/subscriptions","organizations_url":"https://api.github.com/users/facaiy/orgs","repos_url":"https://api.github.com/users/facaiy/repos","events_url":"https://api.github.com/users/facaiy/events{/privacy}","received_events_url":"https://api.github.com/users/facaiy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1245934882,"node_id":"MDU6TGFiZWwxMjQ1OTM0ODgy","url":"https://api.github.com/repos/tensorflow/addons/labels/cla:%20yes","name":"cla: yes","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/addons/pulls/55/commits","review_comments_url":"https://api.github.com/repos/tensorflow/addons/pulls/55/comments","review_comment_url":"https://api.github.com/repos/tensorflow/addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/addons/issues/55/comments","statuses_url":"https://api.github.com/repos/tensorflow/addons/statuses/e1cb2780812b3b1e70b17914ba070da583ab14c5","head":{"label":"seanpmorgan:fix-tf-api","ref":"fix-tf-api","sha":"e1cb2780812b3b1e70b17914ba070da583ab14c5","user":{"login":"seanpmorgan","id":18154355,"node_id":"MDQ6VXNlcjE4MTU0MzU1","avatar_url":"https://avatars3.githubusercontent.com/u/18154355?v=4","gravatar_id":"","url":"https://api.github.com/users/seanpmorgan","html_url":"https://github.com/seanpmorgan","followers_url":"https://api.github.com/users/seanpmorgan/followers","following_url":"https://api.github.com/users/seanpmorgan/following{/other_user}","gists_url":"https://api.github.com/users/seanpmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpmorgan/subscriptions","organizations_url":"https://api.github.com/users/seanpmorgan/orgs","repos_url":"https://api.github.com/users/seanpmorgan/repos","events_url":"https://api.github.com/users/seanpmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/seanpmorgan/received_events","type":"User","site_admin":false},"repo":{"id":159349774,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzNDk3NzQ=","name":"addons","full_name":"seanpmorgan/addons","private":false,"owner":{"login":"seanpmorgan","id":18154355,"node_id":"MDQ6VXNlcjE4MTU0MzU1","avatar_url":"https://avatars3.githubusercontent.com/u/18154355?v=4","gravatar_id":"","url":"https://api.github.com/users/seanpmorgan","html_url":"https://github.com/seanpmorgan","followers_url":"https://api.github.com/users/seanpmorgan/followers","following_url":"https://api.github.com/users/seanpmorgan/following{/other_user}","gists_url":"https://api.github.com/users/seanpmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpmorgan/subscriptions","organizations_url":"https://api.github.com/users/seanpmorgan/orgs","repos_url":"https://api.github.com/users/seanpmorgan/repos","events_url":"https://api.github.com/users/seanpmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/seanpmorgan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/seanpmorgan/addons","description":"Useful extra functionality for TensorFlow maintained by SIG-addons","fork":true,"url":"https://api.github.com/repos/seanpmorgan/addons","forks_url":"https://api.github.com/repos/seanpmorgan/addons/forks","keys_url":"https://api.github.com/repos/seanpmorgan/addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seanpmorgan/addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seanpmorgan/addons/teams","hooks_url":"https://api.github.com/repos/seanpmorgan/addons/hooks","issue_events_url":"https://api.github.com/repos/seanpmorgan/addons/issues/events{/number}","events_url":"https://api.github.com/repos/seanpmorgan/addons/events","assignees_url":"https://api.github.com/repos/seanpmorgan/addons/assignees{/user}","branches_url":"https://api.github.com/repos/seanpmorgan/addons/branches{/branch}","tags_url":"https://api.github.com/repos/seanpmorgan/addons/tags","blobs_url":"https://api.github.com/repos/seanpmorgan/addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seanpmorgan/addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seanpmorgan/addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/seanpmorgan/addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seanpmorgan/addons/statuses/{sha}","languages_url":"https://api.github.com/repos/seanpmorgan/addons/languages","stargazers_url":"https://api.github.com/repos/seanpmorgan/addons/stargazers","contributors_url":"https://api.github.com/repos/seanpmorgan/addons/contributors","subscribers_url":"https://api.github.com/repos/seanpmorgan/addons/subscribers","subscription_url":"https://api.github.com/repos/seanpmorgan/addons/subscription","commits_url":"https://api.github.com/repos/seanpmorgan/addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/seanpmorgan/addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/seanpmorgan/addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/seanpmorgan/addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/seanpmorgan/addons/contents/{+path}","compare_url":"https://api.github.com/repos/seanpmorgan/addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seanpmorgan/addons/merges","archive_url":"https://api.github.com/repos/seanpmorgan/addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seanpmorgan/addons/downloads","issues_url":"https://api.github.com/repos/seanpmorgan/addons/issues{/number}","pulls_url":"https://api.github.com/repos/seanpmorgan/addons/pulls{/number}","milestones_url":"https://api.github.com/repos/seanpmorgan/addons/milestones{/number}","notifications_url":"https://api.github.com/repos/seanpmorgan/addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seanpmorgan/addons/labels{/name}","releases_url":"https://api.github.com/repos/seanpmorgan/addons/releases{/id}","deployments_url":"https://api.github.com/repos/seanpmorgan/addons/deployments","created_at":"2018-11-27T14:39:25Z","updated_at":"2019-02-16T23:10:13Z","pushed_at":"2019-02-27T00:23:05Z","git_url":"git://github.com/seanpmorgan/addons.git","ssh_url":"git@github.com:seanpmorgan/addons.git","clone_url":"https://github.com/seanpmorgan/addons.git","svn_url":"https://github.com/seanpmorgan/addons","homepage":null,"size":146,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"4bf9c3d1d9ea7415ace9a181243f25977fc68f89","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":159249114,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkyNDkxMTQ=","name":"addons","full_name":"tensorflow/addons","private":false,"owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tensorflow/addons","description":"Useful extra functionality for TensorFlow maintained by SIG-addons","fork":false,"url":"https://api.github.com/repos/tensorflow/addons","forks_url":"https://api.github.com/repos/tensorflow/addons/forks","keys_url":"https://api.github.com/repos/tensorflow/addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/addons/teams","hooks_url":"https://api.github.com/repos/tensorflow/addons/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/addons/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/addons/events","assignees_url":"https://api.github.com/repos/tensorflow/addons/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/addons/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/addons/tags","blobs_url":"https://api.github.com/repos/tensorflow/addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/addons/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/addons/languages","stargazers_url":"https://api.github.com/repos/tensorflow/addons/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/addons/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/addons/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/addons/subscription","commits_url":"https://api.github.com/repos/tensorflow/addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/addons/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/addons/merges","archive_url":"https://api.github.com/repos/tensorflow/addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/addons/downloads","issues_url":"https://api.github.com/repos/tensorflow/addons/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/addons/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/addons/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/addons/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/addons/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/addons/deployments","created_at":"2018-11-26T23:57:17Z","updated_at":"2019-02-26T14:33:38Z","pushed_at":"2019-02-27T00:23:06Z","git_url":"git://github.com/tensorflow/addons.git","ssh_url":"git@github.com:tensorflow/addons.git","clone_url":"https://github.com/tensorflow/addons.git","svn_url":"https://github.com/tensorflow/addons","homepage":null,"size":138,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":25,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/addons/pulls/55"},"html":{"href":"https://github.com/tensorflow/addons/pull/55"},"issue":{"href":"https://api.github.com/repos/tensorflow/addons/issues/55"},"comments":{"href":"https://api.github.com/repos/tensorflow/addons/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/addons/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/addons/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/addons/statuses/e1cb2780812b3b1e70b17914ba070da583ab14c5"}},"author_association":"MEMBER"}}
|
{
"id": 159249114,
"name": "tensorflow/addons",
"url": "https://api.github.com/repos/tensorflow/addons"
}
|
{
"id": 18154355,
"login": "seanpmorgan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18154355?",
"url": "https://api.github.com/users/seanpmorgan"
}
|
{
"id": 15658638,
"login": "tensorflow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15658638?",
"url": "https://api.github.com/orgs/tensorflow"
}
| 2019-02-27T00:30:30 |
9142882104
|
{"actor":{"display_login":"seanpmorgan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/comments/342453134","pull_request_review_id":311580484,"id":342453134,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MjQ1MzEzNA==","diff_hunk":"@@ -387,6 +394,161 @@ def test_postbirth_other_passport_origin(self):\n self.assertEqual(registration.passport_country, \"other\")\n \n \n+class MessagesViewSetTests(APITestCase):\n+ url = reverse(\"messages-list\")\n+\n+ def generate_hmac_signature(self, data, key):\n+ data = JSONRenderer().render(data)\n+ h = hmac.new(key.encode(), data, sha256)\n+ return base64.b64encode(h.digest()).decode()\n+\n+ def test_successful_messages_request(self):\n+ \"\"\"\n+ Should create a new Messages object in the database\n+ \"\"\"\n+ user = get_user_model().objects.create_user(\"test\")\n+ user.user_permissions.add(Permission.objects.get(codename=\"add_messages\"))\n+ self.client.force_authenticate(user)\n+ data = {\n+ \"messages\": [\n+ {\n+ \"id\": \"9e12d04c-af25-40b6-aa4f-57c72e8e3f91\",\n+ \"from\": \"sender-wa-id\",\n+ \"timestamp\": \"1518694700\",\n+ \"type\": \"image\",\n+ \"message_direction\": \"I\",\n+ \"recipient_type\": \"type\",\n+ \"context\": {\n+ \"from\": \"sender-wa-id-of-context-message\",\n+ \"group_id\": \"group-id-of-context-message\",\n+ \"id\": \"message-id-of-context-message\",\n+ \"mentions\": [\"wa-id1\", \"wa-id2\"],\n+ },\n+ \"image\": {\n+ \"file\": \"absolute-filepath-on-coreapp\",\n+ \"id\": \"media-id\",\n+ \"link\": \"link-to-image-file\",\n+ \"mime_type\": \"media-mime-type\",\n+ \"sha256\": \"checksum\",\n+ \"caption\": \"image-caption\",\n+ },\n+ \"location\": {\n+ \"address\": \"1 Hacker Way, Menlo Park, CA, 94025\",\n+ \"name\": \"location-name\",\n+ },\n+ \"system\": {\"body\": \"system-message-content\"},\n+ \"text\": {\"body\": \"text-message-content\"},\n+ }\n+ ]\n+ }\n+ response = self.client.post(\n+ self.url,\n+ data,\n+ format=\"json\",\n+ HTTP_X_TURN_HOOK_SIGNATURE=self.generate_hmac_signature(data, \"REPLACEME\"),\n+ )\n+\n+ self.assertEqual(response.status_code, status.HTTP_202_ACCEPTED)\n+ [messages] = Messages.objects.all()\n+ self.assertEqual(str(messages.contact_id), \"sender-wa-id\")\n+ self.assertEqual(\n+ messages.timestamp, datetime.datetime(2018, 2, 15, 11, 38, 20, tzinfo=UTC)\n+ ),\n+ self.assertEqual(messages.id, \"9e12d04c-af25-40b6-aa4f-57c72e8e3f91\"),\n+ self.assertEqual(messages.type, \"image\"),\n+ self.assertEqual(messages.message_direction, \"I\"),\n+ self.assertEqual(\n+ messages.data,\n+ {\n+ \"context\": {\n+ \"from\": \"sender-wa-id-of-context-message\",\n+ \"group_id\": \"group-id-of-context-message\",\n+ \"id\": \"message-id-of-context-message\",\n+ \"mentions\": [\"wa-id1\", \"wa-id2\"],\n+ },\n+ \"audio\": None,\n+ \"document\": None,\n+ \"errors\": None,\n+ \"video\": None,\n+ \"voice\": None,\n+ \"image\": {\n+ \"file\": \"absolute-filepath-on-coreapp\",\n+ \"id\": \"media-id\",\n+ \"link\": \"link-to-image-file\",\n+ \"mime_type\": \"media-mime-type\",\n+ \"sha256\": \"checksum\",\n+ \"caption\": \"image-caption\",\n+ },\n+ \"location\": {\n+ \"address\": \"1 Hacker Way, Menlo Park, CA, 94025\",\n+ \"name\": \"location-name\",\n+ },\n+ \"system\": {\"body\": \"system-message-content\"},\n+ \"text\": {\"body\": \"text-message-content\"},\n+ },\n+ ),\n+ self.assertEqual(messages.created_by, user.username)\n+ self.assertEqual(messages.recipient_type, \"type\")\n+\n+ def test_successful_events_request(self):\n+ \"\"\"\n+ Should create a new Events object in the database\n+ \"\"\"\n+ user = get_user_model().objects.create_user(\"test\")\n+ user.user_permissions.add(Permission.objects.get(codename=\"add_messages\"))\n+ self.client.force_authenticate(user)\n+ data = {\n+ \"statuses\": [\n+ {\n+ \"id\": \"ABGGFlA5FpafAgo6tHcNmNjXmuSf\",\n+ \"recipient_id\": \"16315555555\",\n+ \"status\": \"read\",\n+ \"timestamp\": \"1518694700\",\n+ }\n+ ]\n+ }\n+ response = self.client.post(\n+ self.url,\n+ data,\n+ format=\"json\",\n+ HTTP_X_TURN_HOOK_SIGNATURE=self.generate_hmac_signature(data, \"REPLACEME\"),\n+ )\n+\n+ self.assertEqual(response.status_code, status.HTTP_202_ACCEPTED)\n+ [events] = Events.objects.all()\n+ self.assertEqual(str(events.message_id), \"ABGGFlA5FpafAgo6tHcNmNjXmuSf\")\n+ self.assertEqual(str(events.recipient_id), \"16315555555\")\n+ self.assertEqual(events.status, \"read\")\n+ self.assertEqual(\n+ events.timestamp, datetime.datetime(2018, 2, 15, 11, 38, 20, tzinfo=UTC)\n+ )\n+ self.assertEqual(events.created_by, user.username)\n+\n+ def test_signature_required(self):\n+ \"\"\"\n+ Should see if the signature hook is given,\n+ otherwise, return a 401\n+ \"\"\"\n+ user = get_user_model().objects.create_user(\"test\")\n+ user.user_permissions.add(Permission.objects.get(codename=\"add_messages\"))\n+ self.client.force_authenticate(user)\n+ data = {\n+ \"messages\": [\n+ {\n+ \"id\": \"9e12d04c-af25-40b6-aa4f-57c72e8e3f91\",\n+ \"from\": \"sender-wa-id\",\n+ \"timestamp\": \"1518694700\",\n+ \"type\": \"image\",\n+ \"message_direction\": \"I\",\n+ \"recipient_type\": \"type\",\n+ }\n+ ]\n+ }\n+ response = self.client.post(self.url, data, format=\"json\")\n+\n+ self.assertEqual(response.status_code, status.HTTP_401_UNAUTHORIZED)\n+\n+","path":"eventstore/test_views.py","position":182,"original_position":182,"commit_id":"89bb950ff64d5f289121aba6580f4188b426cf85","original_commit_id":"89bb950ff64d5f289121aba6580f4188b426cf85","user":{"login":"rudigiesler","id":8234653,"node_id":"MDQ6VXNlcjgyMzQ2NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8234653?v=4","gravatar_id":"","url":"https://api.github.com/users/rudigiesler","html_url":"https://github.com/rudigiesler","followers_url":"https://api.github.com/users/rudigiesler/followers","following_url":"https://api.github.com/users/rudigiesler/following{/other_user}","gists_url":"https://api.github.com/users/rudigiesler/gists{/gist_id}","starred_url":"https://api.github.com/users/rudigiesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudigiesler/subscriptions","organizations_url":"https://api.github.com/users/rudigiesler/orgs","repos_url":"https://api.github.com/users/rudigiesler/repos","events_url":"https://api.github.com/users/rudigiesler/events{/privacy}","received_events_url":"https://api.github.com/users/rudigiesler/received_events","type":"User","site_admin":false},"body":"It seems like we're missing a test for outbound messages","created_at":"2019-11-05T09:21:05Z","updated_at":"2019-11-05T09:46:43Z","html_url":"https://github.com/praekeltfoundation/ndoh-hub/pull/265#discussion_r342453134","pull_request_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/265","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/comments/342453134"},"html":{"href":"https://github.com/praekeltfoundation/ndoh-hub/pull/265#discussion_r342453134"},"pull_request":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/265","id":336200406,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2MjAwNDA2","html_url":"https://github.com/praekeltfoundation/ndoh-hub/pull/265","diff_url":"https://github.com/praekeltfoundation/ndoh-hub/pull/265.diff","patch_url":"https://github.com/praekeltfoundation/ndoh-hub/pull/265.patch","issue_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues/265","number":265,"state":"open","locked":false,"title":"Feature/mcmr 80 store messages and events in event store","user":{"login":"OMosimege","id":28597626,"node_id":"MDQ6VXNlcjI4NTk3NjI2","avatar_url":"https://avatars1.githubusercontent.com/u/28597626?v=4","gravatar_id":"","url":"https://api.github.com/users/OMosimege","html_url":"https://github.com/OMosimege","followers_url":"https://api.github.com/users/OMosimege/followers","following_url":"https://api.github.com/users/OMosimege/following{/other_user}","gists_url":"https://api.github.com/users/OMosimege/gists{/gist_id}","starred_url":"https://api.github.com/users/OMosimege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OMosimege/subscriptions","organizations_url":"https://api.github.com/users/OMosimege/orgs","repos_url":"https://api.github.com/users/OMosimege/repos","events_url":"https://api.github.com/users/OMosimege/events{/privacy}","received_events_url":"https://api.github.com/users/OMosimege/received_events","type":"User","site_admin":false},"body":"This PR creates a model for Events and Messages, and creates a view to handle them","created_at":"2019-11-04T10:19:04Z","updated_at":"2019-11-05T09:46:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98844faf47e4c53af72ddaeee8adec37b005cb94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/265/commits","review_comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/265/comments","review_comment_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues/265/comments","statuses_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/statuses/89bb950ff64d5f289121aba6580f4188b426cf85","head":{"label":"praekeltfoundation:feature/MCMR-80-Store-messages-and-events-in-event-store","ref":"feature/MCMR-80-Store-messages-and-events-in-event-store","sha":"89bb950ff64d5f289121aba6580f4188b426cf85","user":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":61732760,"node_id":"MDEwOlJlcG9zaXRvcnk2MTczMjc2MA==","name":"ndoh-hub","full_name":"praekeltfoundation/ndoh-hub","private":false,"owner":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/praekeltfoundation/ndoh-hub","description":null,"fork":false,"url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub","forks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/forks","keys_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/teams","hooks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/hooks","issue_events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues/events{/number}","events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/events","assignees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/assignees{/user}","branches_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/branches{/branch}","tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/tags","blobs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/statuses/{sha}","languages_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/languages","stargazers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/stargazers","contributors_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/contributors","subscribers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/subscribers","subscription_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/subscription","commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/contents/{+path}","compare_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/merges","archive_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/downloads","issues_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues{/number}","pulls_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls{/number}","milestones_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/milestones{/number}","notifications_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/labels{/name}","releases_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/releases{/id}","deployments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/deployments","created_at":"2016-06-22T16:04:09Z","updated_at":"2019-11-04T06:52:10Z","pushed_at":"2019-11-05T08:29:53Z","git_url":"git://github.com/praekeltfoundation/ndoh-hub.git","ssh_url":"git@github.com:praekeltfoundation/ndoh-hub.git","clone_url":"https://github.com/praekeltfoundation/ndoh-hub.git","svn_url":"https://github.com/praekeltfoundation/ndoh-hub","homepage":null,"size":1545,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":16,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":16,"watchers":0,"default_branch":"develop"}},"base":{"label":"praekeltfoundation:develop","ref":"develop","sha":"94a96d1f62c17e7cbc32a739210e414700ac0691","user":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":61732760,"node_id":"MDEwOlJlcG9zaXRvcnk2MTczMjc2MA==","name":"ndoh-hub","full_name":"praekeltfoundation/ndoh-hub","private":false,"owner":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/praekeltfoundation/ndoh-hub","description":null,"fork":false,"url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub","forks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/forks","keys_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/teams","hooks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/hooks","issue_events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues/events{/number}","events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/events","assignees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/assignees{/user}","branches_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/branches{/branch}","tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/tags","blobs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/statuses/{sha}","languages_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/languages","stargazers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/stargazers","contributors_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/contributors","subscribers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/subscribers","subscription_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/subscription","commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/contents/{+path}","compare_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/merges","archive_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/downloads","issues_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues{/number}","pulls_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls{/number}","milestones_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/milestones{/number}","notifications_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/labels{/name}","releases_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/releases{/id}","deployments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/deployments","created_at":"2016-06-22T16:04:09Z","updated_at":"2019-11-04T06:52:10Z","pushed_at":"2019-11-05T08:29:53Z","git_url":"git://github.com/praekeltfoundation/ndoh-hub.git","ssh_url":"git@github.com:praekeltfoundation/ndoh-hub.git","clone_url":"https://github.com/praekeltfoundation/ndoh-hub.git","svn_url":"https://github.com/praekeltfoundation/ndoh-hub","homepage":null,"size":1545,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":16,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":16,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/265"},"html":{"href":"https://github.com/praekeltfoundation/ndoh-hub/pull/265"},"issue":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues/265"},"comments":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-hub/statuses/89bb950ff64d5f289121aba6580f4188b426cf85"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 61732760,
"name": "praekeltfoundation/ndoh-hub",
"url": "https://api.github.com/repos/praekeltfoundation/ndoh-hub"
}
|
{
"id": 8234653,
"login": "rudigiesler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8234653?",
"url": "https://api.github.com/users/rudigiesler"
}
|
{
"id": 15786759,
"login": "praekeltfoundation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15786759?",
"url": "https://api.github.com/orgs/praekeltfoundation"
}
| 2019-11-05T09:21:05 |
10788431958
|
{"actor":{"display_login":"rudigiesler"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tango-controls/pytango/pulls/comments/283765376","pull_request_review_id":237201655,"id":283765376,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4Mzc2NTM3Ng==","diff_hunk":"@@ -0,0 +1,324 @@\n+version: 1.0.{build}\n+branches:\n+ only:\n+ - NexeyaSGara-windows-ci","path":"appveyor.yml","position":null,"original_position":4,"commit_id":"172413c53cb2dc26dc4009e6c15b69019b5999fd","original_commit_id":"28c7efc0b612f44b2e7a073c9daa2e792bb6ec2b","user":{"login":"tiagocoutinho","id":2684070,"node_id":"MDQ6VXNlcjI2ODQwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2684070?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagocoutinho","html_url":"https://github.com/tiagocoutinho","followers_url":"https://api.github.com/users/tiagocoutinho/followers","following_url":"https://api.github.com/users/tiagocoutinho/following{/other_user}","gists_url":"https://api.github.com/users/tiagocoutinho/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagocoutinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagocoutinho/subscriptions","organizations_url":"https://api.github.com/users/tiagocoutinho/orgs","repos_url":"https://api.github.com/users/tiagocoutinho/repos","events_url":"https://api.github.com/users/tiagocoutinho/events{/privacy}","received_events_url":"https://api.github.com/users/tiagocoutinho/received_events","type":"User","site_admin":false},"body":"Uau! didn't know this existed.\r\n\r\nThanks for unblocking this @bourtemb. That is the kind of push I needed","created_at":"2019-05-14T12:13:19Z","updated_at":"2019-05-14T12:13:19Z","html_url":"https://github.com/tango-controls/pytango/pull/277#discussion_r283765376","pull_request_url":"https://api.github.com/repos/tango-controls/pytango/pulls/277","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/comments/283765376"},"html":{"href":"https://github.com/tango-controls/pytango/pull/277#discussion_r283765376"},"pull_request":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/277"}},"in_reply_to_id":280989837},"pull_request":{"url":"https://api.github.com/repos/tango-controls/pytango/pulls/277","id":275936339,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1OTM2MzM5","html_url":"https://github.com/tango-controls/pytango/pull/277","diff_url":"https://github.com/tango-controls/pytango/pull/277.diff","patch_url":"https://github.com/tango-controls/pytango/pull/277.patch","issue_url":"https://api.github.com/repos/tango-controls/pytango/issues/277","number":277,"state":"open","locked":false,"title":"Windows builds update to 9.3.1","user":{"login":"tiagocoutinho","id":2684070,"node_id":"MDQ6VXNlcjI2ODQwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2684070?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagocoutinho","html_url":"https://github.com/tiagocoutinho","followers_url":"https://api.github.com/users/tiagocoutinho/followers","following_url":"https://api.github.com/users/tiagocoutinho/following{/other_user}","gists_url":"https://api.github.com/users/tiagocoutinho/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagocoutinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagocoutinho/subscriptions","organizations_url":"https://api.github.com/users/tiagocoutinho/orgs","repos_url":"https://api.github.com/users/tiagocoutinho/repos","events_url":"https://api.github.com/users/tiagocoutinho/events{/privacy}","received_events_url":"https://api.github.com/users/tiagocoutinho/received_events","type":"User","site_admin":false},"body":"* based on NexeyaSGara work\r\n* updates to tango 9.3\r\n* add python 3.7, drop 3.4 and 3.5\r\n* fix build on VC9 64bits\r\n* add support for wheel\r\n","created_at":"2019-05-04T17:29:42Z","updated_at":"2019-05-14T12:13:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72fb3ab0fd545cd96ba5f0c8d195498a2362b32b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jairomoldes","id":11044004,"node_id":"MDQ6VXNlcjExMDQ0MDA0","avatar_url":"https://avatars1.githubusercontent.com/u/11044004?v=4","gravatar_id":"","url":"https://api.github.com/users/jairomoldes","html_url":"https://github.com/jairomoldes","followers_url":"https://api.github.com/users/jairomoldes/followers","following_url":"https://api.github.com/users/jairomoldes/following{/other_user}","gists_url":"https://api.github.com/users/jairomoldes/gists{/gist_id}","starred_url":"https://api.github.com/users/jairomoldes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jairomoldes/subscriptions","organizations_url":"https://api.github.com/users/jairomoldes/orgs","repos_url":"https://api.github.com/users/jairomoldes/repos","events_url":"https://api.github.com/users/jairomoldes/events{/privacy}","received_events_url":"https://api.github.com/users/jairomoldes/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tango-controls/pytango/pulls/277/commits","review_comments_url":"https://api.github.com/repos/tango-controls/pytango/pulls/277/comments","review_comment_url":"https://api.github.com/repos/tango-controls/pytango/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tango-controls/pytango/issues/277/comments","statuses_url":"https://api.github.com/repos/tango-controls/pytango/statuses/172413c53cb2dc26dc4009e6c15b69019b5999fd","head":{"label":"tiagocoutinho:windows","ref":"windows","sha":"172413c53cb2dc26dc4009e6c15b69019b5999fd","user":{"login":"tiagocoutinho","id":2684070,"node_id":"MDQ6VXNlcjI2ODQwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2684070?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagocoutinho","html_url":"https://github.com/tiagocoutinho","followers_url":"https://api.github.com/users/tiagocoutinho/followers","following_url":"https://api.github.com/users/tiagocoutinho/following{/other_user}","gists_url":"https://api.github.com/users/tiagocoutinho/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagocoutinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagocoutinho/subscriptions","organizations_url":"https://api.github.com/users/tiagocoutinho/orgs","repos_url":"https://api.github.com/users/tiagocoutinho/repos","events_url":"https://api.github.com/users/tiagocoutinho/events{/privacy}","received_events_url":"https://api.github.com/users/tiagocoutinho/received_events","type":"User","site_admin":false},"repo":{"id":182566184,"node_id":"MDEwOlJlcG9zaXRvcnkxODI1NjYxODQ=","name":"pytango","full_name":"tiagocoutinho/pytango","private":false,"owner":{"login":"tiagocoutinho","id":2684070,"node_id":"MDQ6VXNlcjI2ODQwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2684070?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagocoutinho","html_url":"https://github.com/tiagocoutinho","followers_url":"https://api.github.com/users/tiagocoutinho/followers","following_url":"https://api.github.com/users/tiagocoutinho/following{/other_user}","gists_url":"https://api.github.com/users/tiagocoutinho/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagocoutinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagocoutinho/subscriptions","organizations_url":"https://api.github.com/users/tiagocoutinho/orgs","repos_url":"https://api.github.com/users/tiagocoutinho/repos","events_url":"https://api.github.com/users/tiagocoutinho/events{/privacy}","received_events_url":"https://api.github.com/users/tiagocoutinho/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tiagocoutinho/pytango","description":"Python binding to Tango C++","fork":true,"url":"https://api.github.com/repos/tiagocoutinho/pytango","forks_url":"https://api.github.com/repos/tiagocoutinho/pytango/forks","keys_url":"https://api.github.com/repos/tiagocoutinho/pytango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiagocoutinho/pytango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiagocoutinho/pytango/teams","hooks_url":"https://api.github.com/repos/tiagocoutinho/pytango/hooks","issue_events_url":"https://api.github.com/repos/tiagocoutinho/pytango/issues/events{/number}","events_url":"https://api.github.com/repos/tiagocoutinho/pytango/events","assignees_url":"https://api.github.com/repos/tiagocoutinho/pytango/assignees{/user}","branches_url":"https://api.github.com/repos/tiagocoutinho/pytango/branches{/branch}","tags_url":"https://api.github.com/repos/tiagocoutinho/pytango/tags","blobs_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiagocoutinho/pytango/statuses/{sha}","languages_url":"https://api.github.com/repos/tiagocoutinho/pytango/languages","stargazers_url":"https://api.github.com/repos/tiagocoutinho/pytango/stargazers","contributors_url":"https://api.github.com/repos/tiagocoutinho/pytango/contributors","subscribers_url":"https://api.github.com/repos/tiagocoutinho/pytango/subscribers","subscription_url":"https://api.github.com/repos/tiagocoutinho/pytango/subscription","commits_url":"https://api.github.com/repos/tiagocoutinho/pytango/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiagocoutinho/pytango/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiagocoutinho/pytango/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiagocoutinho/pytango/contents/{+path}","compare_url":"https://api.github.com/repos/tiagocoutinho/pytango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiagocoutinho/pytango/merges","archive_url":"https://api.github.com/repos/tiagocoutinho/pytango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiagocoutinho/pytango/downloads","issues_url":"https://api.github.com/repos/tiagocoutinho/pytango/issues{/number}","pulls_url":"https://api.github.com/repos/tiagocoutinho/pytango/pulls{/number}","milestones_url":"https://api.github.com/repos/tiagocoutinho/pytango/milestones{/number}","notifications_url":"https://api.github.com/repos/tiagocoutinho/pytango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiagocoutinho/pytango/labels{/name}","releases_url":"https://api.github.com/repos/tiagocoutinho/pytango/releases{/id}","deployments_url":"https://api.github.com/repos/tiagocoutinho/pytango/deployments","created_at":"2019-04-21T18:03:50Z","updated_at":"2019-04-21T18:03:52Z","pushed_at":"2019-05-11T15:39:10Z","git_url":"git://github.com/tiagocoutinho/pytango.git","ssh_url":"git@github.com:tiagocoutinho/pytango.git","clone_url":"https://github.com/tiagocoutinho/pytango.git","svn_url":"https://github.com/tiagocoutinho/pytango","homepage":"http://pytango.rtfd.io","size":17128,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"tango-controls:develop","ref":"develop","sha":"9cf78c517c9cdc1081ff6d080a9646a740cc1d36","user":{"login":"tango-controls","id":15830606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODMwNjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":27967182,"node_id":"MDEwOlJlcG9zaXRvcnkyNzk2NzE4Mg==","name":"pytango","full_name":"tango-controls/pytango","private":false,"owner":{"login":"tango-controls","id":15830606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODMwNjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tango-controls/pytango","description":"Python binding to Tango C++","fork":false,"url":"https://api.github.com/repos/tango-controls/pytango","forks_url":"https://api.github.com/repos/tango-controls/pytango/forks","keys_url":"https://api.github.com/repos/tango-controls/pytango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tango-controls/pytango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tango-controls/pytango/teams","hooks_url":"https://api.github.com/repos/tango-controls/pytango/hooks","issue_events_url":"https://api.github.com/repos/tango-controls/pytango/issues/events{/number}","events_url":"https://api.github.com/repos/tango-controls/pytango/events","assignees_url":"https://api.github.com/repos/tango-controls/pytango/assignees{/user}","branches_url":"https://api.github.com/repos/tango-controls/pytango/branches{/branch}","tags_url":"https://api.github.com/repos/tango-controls/pytango/tags","blobs_url":"https://api.github.com/repos/tango-controls/pytango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tango-controls/pytango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tango-controls/pytango/git/refs{/sha}","trees_url":"https://api.github.com/repos/tango-controls/pytango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tango-controls/pytango/statuses/{sha}","languages_url":"https://api.github.com/repos/tango-controls/pytango/languages","stargazers_url":"https://api.github.com/repos/tango-controls/pytango/stargazers","contributors_url":"https://api.github.com/repos/tango-controls/pytango/contributors","subscribers_url":"https://api.github.com/repos/tango-controls/pytango/subscribers","subscription_url":"https://api.github.com/repos/tango-controls/pytango/subscription","commits_url":"https://api.github.com/repos/tango-controls/pytango/commits{/sha}","git_commits_url":"https://api.github.com/repos/tango-controls/pytango/git/commits{/sha}","comments_url":"https://api.github.com/repos/tango-controls/pytango/comments{/number}","issue_comment_url":"https://api.github.com/repos/tango-controls/pytango/issues/comments{/number}","contents_url":"https://api.github.com/repos/tango-controls/pytango/contents/{+path}","compare_url":"https://api.github.com/repos/tango-controls/pytango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tango-controls/pytango/merges","archive_url":"https://api.github.com/repos/tango-controls/pytango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tango-controls/pytango/downloads","issues_url":"https://api.github.com/repos/tango-controls/pytango/issues{/number}","pulls_url":"https://api.github.com/repos/tango-controls/pytango/pulls{/number}","milestones_url":"https://api.github.com/repos/tango-controls/pytango/milestones{/number}","notifications_url":"https://api.github.com/repos/tango-controls/pytango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tango-controls/pytango/labels{/name}","releases_url":"https://api.github.com/repos/tango-controls/pytango/releases{/id}","deployments_url":"https://api.github.com/repos/tango-controls/pytango/deployments","created_at":"2014-12-13T16:58:57Z","updated_at":"2019-04-26T12:16:57Z","pushed_at":"2019-05-11T15:39:12Z","git_url":"git://github.com/tango-controls/pytango.git","ssh_url":"git@github.com:tango-controls/pytango.git","clone_url":"https://github.com/tango-controls/pytango.git","svn_url":"https://github.com/tango-controls/pytango","homepage":"http://pytango.rtfd.io","size":16998,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":34,"open_issues":39,"watchers":33,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/277"},"html":{"href":"https://github.com/tango-controls/pytango/pull/277"},"issue":{"href":"https://api.github.com/repos/tango-controls/pytango/issues/277"},"comments":{"href":"https://api.github.com/repos/tango-controls/pytango/issues/277/comments"},"review_comments":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/277/comments"},"review_comment":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/277/commits"},"statuses":{"href":"https://api.github.com/repos/tango-controls/pytango/statuses/172413c53cb2dc26dc4009e6c15b69019b5999fd"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27967182,
"name": "tango-controls/pytango",
"url": "https://api.github.com/repos/tango-controls/pytango"
}
|
{
"id": 2684070,
"login": "tiagocoutinho",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2684070?",
"url": "https://api.github.com/users/tiagocoutinho"
}
|
{
"id": 15830606,
"login": "tango-controls",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15830606?",
"url": "https://api.github.com/orgs/tango-controls"
}
| 2019-05-14T12:13:19 |
9622064295
|
{"actor":{"display_login":"tiagocoutinho"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tango-controls/pytango/pulls/comments/283404674","pull_request_review_id":236752301,"id":283404674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzQwNDY3NA==","diff_hunk":"@@ -0,0 +1,324 @@\n+version: 1.0.{build}\n+branches:\n+ only:\n+ - NexeyaSGara-windows-ci","path":"appveyor.yml","position":null,"original_position":4,"commit_id":"172413c53cb2dc26dc4009e6c15b69019b5999fd","original_commit_id":"28c7efc0b612f44b2e7a073c9daa2e792bb6ec2b","user":{"login":"tiagocoutinho","id":2684070,"node_id":"MDQ6VXNlcjI2ODQwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2684070?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagocoutinho","html_url":"https://github.com/tiagocoutinho","followers_url":"https://api.github.com/users/tiagocoutinho/followers","following_url":"https://api.github.com/users/tiagocoutinho/following{/other_user}","gists_url":"https://api.github.com/users/tiagocoutinho/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagocoutinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagocoutinho/subscriptions","organizations_url":"https://api.github.com/users/tiagocoutinho/orgs","repos_url":"https://api.github.com/users/tiagocoutinho/repos","events_url":"https://api.github.com/users/tiagocoutinho/events{/privacy}","received_events_url":"https://api.github.com/users/tiagocoutinho/received_events","type":"User","site_admin":false},"body":"I propse to focus just on windows build on this PR.\r\n\r\nAppveyor / Azure devops can come in a future PR.","created_at":"2019-05-13T15:29:22Z","updated_at":"2019-05-13T15:29:23Z","html_url":"https://github.com/tango-controls/pytango/pull/277#discussion_r283404674","pull_request_url":"https://api.github.com/repos/tango-controls/pytango/pulls/277","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/comments/283404674"},"html":{"href":"https://github.com/tango-controls/pytango/pull/277#discussion_r283404674"},"pull_request":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/277"}},"in_reply_to_id":280989837},"pull_request":{"url":"https://api.github.com/repos/tango-controls/pytango/pulls/277","id":275936339,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1OTM2MzM5","html_url":"https://github.com/tango-controls/pytango/pull/277","diff_url":"https://github.com/tango-controls/pytango/pull/277.diff","patch_url":"https://github.com/tango-controls/pytango/pull/277.patch","issue_url":"https://api.github.com/repos/tango-controls/pytango/issues/277","number":277,"state":"open","locked":false,"title":"Windows builds update to 9.3.1","user":{"login":"tiagocoutinho","id":2684070,"node_id":"MDQ6VXNlcjI2ODQwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2684070?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagocoutinho","html_url":"https://github.com/tiagocoutinho","followers_url":"https://api.github.com/users/tiagocoutinho/followers","following_url":"https://api.github.com/users/tiagocoutinho/following{/other_user}","gists_url":"https://api.github.com/users/tiagocoutinho/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagocoutinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagocoutinho/subscriptions","organizations_url":"https://api.github.com/users/tiagocoutinho/orgs","repos_url":"https://api.github.com/users/tiagocoutinho/repos","events_url":"https://api.github.com/users/tiagocoutinho/events{/privacy}","received_events_url":"https://api.github.com/users/tiagocoutinho/received_events","type":"User","site_admin":false},"body":"* based on NexeyaSGara work\r\n* updates to tango 9.3\r\n* add python 3.7, drop 3.4 and 3.5\r\n* fix build on VC9 64bits\r\n* add support for wheel\r\n","created_at":"2019-05-04T17:29:42Z","updated_at":"2019-05-13T15:29:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72fb3ab0fd545cd96ba5f0c8d195498a2362b32b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jairomoldes","id":11044004,"node_id":"MDQ6VXNlcjExMDQ0MDA0","avatar_url":"https://avatars1.githubusercontent.com/u/11044004?v=4","gravatar_id":"","url":"https://api.github.com/users/jairomoldes","html_url":"https://github.com/jairomoldes","followers_url":"https://api.github.com/users/jairomoldes/followers","following_url":"https://api.github.com/users/jairomoldes/following{/other_user}","gists_url":"https://api.github.com/users/jairomoldes/gists{/gist_id}","starred_url":"https://api.github.com/users/jairomoldes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jairomoldes/subscriptions","organizations_url":"https://api.github.com/users/jairomoldes/orgs","repos_url":"https://api.github.com/users/jairomoldes/repos","events_url":"https://api.github.com/users/jairomoldes/events{/privacy}","received_events_url":"https://api.github.com/users/jairomoldes/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tango-controls/pytango/pulls/277/commits","review_comments_url":"https://api.github.com/repos/tango-controls/pytango/pulls/277/comments","review_comment_url":"https://api.github.com/repos/tango-controls/pytango/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tango-controls/pytango/issues/277/comments","statuses_url":"https://api.github.com/repos/tango-controls/pytango/statuses/172413c53cb2dc26dc4009e6c15b69019b5999fd","head":{"label":"tiagocoutinho:windows","ref":"windows","sha":"172413c53cb2dc26dc4009e6c15b69019b5999fd","user":{"login":"tiagocoutinho","id":2684070,"node_id":"MDQ6VXNlcjI2ODQwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2684070?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagocoutinho","html_url":"https://github.com/tiagocoutinho","followers_url":"https://api.github.com/users/tiagocoutinho/followers","following_url":"https://api.github.com/users/tiagocoutinho/following{/other_user}","gists_url":"https://api.github.com/users/tiagocoutinho/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagocoutinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagocoutinho/subscriptions","organizations_url":"https://api.github.com/users/tiagocoutinho/orgs","repos_url":"https://api.github.com/users/tiagocoutinho/repos","events_url":"https://api.github.com/users/tiagocoutinho/events{/privacy}","received_events_url":"https://api.github.com/users/tiagocoutinho/received_events","type":"User","site_admin":false},"repo":{"id":182566184,"node_id":"MDEwOlJlcG9zaXRvcnkxODI1NjYxODQ=","name":"pytango","full_name":"tiagocoutinho/pytango","private":false,"owner":{"login":"tiagocoutinho","id":2684070,"node_id":"MDQ6VXNlcjI2ODQwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2684070?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagocoutinho","html_url":"https://github.com/tiagocoutinho","followers_url":"https://api.github.com/users/tiagocoutinho/followers","following_url":"https://api.github.com/users/tiagocoutinho/following{/other_user}","gists_url":"https://api.github.com/users/tiagocoutinho/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagocoutinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagocoutinho/subscriptions","organizations_url":"https://api.github.com/users/tiagocoutinho/orgs","repos_url":"https://api.github.com/users/tiagocoutinho/repos","events_url":"https://api.github.com/users/tiagocoutinho/events{/privacy}","received_events_url":"https://api.github.com/users/tiagocoutinho/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tiagocoutinho/pytango","description":"Python binding to Tango C++","fork":true,"url":"https://api.github.com/repos/tiagocoutinho/pytango","forks_url":"https://api.github.com/repos/tiagocoutinho/pytango/forks","keys_url":"https://api.github.com/repos/tiagocoutinho/pytango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiagocoutinho/pytango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiagocoutinho/pytango/teams","hooks_url":"https://api.github.com/repos/tiagocoutinho/pytango/hooks","issue_events_url":"https://api.github.com/repos/tiagocoutinho/pytango/issues/events{/number}","events_url":"https://api.github.com/repos/tiagocoutinho/pytango/events","assignees_url":"https://api.github.com/repos/tiagocoutinho/pytango/assignees{/user}","branches_url":"https://api.github.com/repos/tiagocoutinho/pytango/branches{/branch}","tags_url":"https://api.github.com/repos/tiagocoutinho/pytango/tags","blobs_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiagocoutinho/pytango/statuses/{sha}","languages_url":"https://api.github.com/repos/tiagocoutinho/pytango/languages","stargazers_url":"https://api.github.com/repos/tiagocoutinho/pytango/stargazers","contributors_url":"https://api.github.com/repos/tiagocoutinho/pytango/contributors","subscribers_url":"https://api.github.com/repos/tiagocoutinho/pytango/subscribers","subscription_url":"https://api.github.com/repos/tiagocoutinho/pytango/subscription","commits_url":"https://api.github.com/repos/tiagocoutinho/pytango/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiagocoutinho/pytango/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiagocoutinho/pytango/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiagocoutinho/pytango/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiagocoutinho/pytango/contents/{+path}","compare_url":"https://api.github.com/repos/tiagocoutinho/pytango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiagocoutinho/pytango/merges","archive_url":"https://api.github.com/repos/tiagocoutinho/pytango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiagocoutinho/pytango/downloads","issues_url":"https://api.github.com/repos/tiagocoutinho/pytango/issues{/number}","pulls_url":"https://api.github.com/repos/tiagocoutinho/pytango/pulls{/number}","milestones_url":"https://api.github.com/repos/tiagocoutinho/pytango/milestones{/number}","notifications_url":"https://api.github.com/repos/tiagocoutinho/pytango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiagocoutinho/pytango/labels{/name}","releases_url":"https://api.github.com/repos/tiagocoutinho/pytango/releases{/id}","deployments_url":"https://api.github.com/repos/tiagocoutinho/pytango/deployments","created_at":"2019-04-21T18:03:50Z","updated_at":"2019-04-21T18:03:52Z","pushed_at":"2019-05-11T15:39:10Z","git_url":"git://github.com/tiagocoutinho/pytango.git","ssh_url":"git@github.com:tiagocoutinho/pytango.git","clone_url":"https://github.com/tiagocoutinho/pytango.git","svn_url":"https://github.com/tiagocoutinho/pytango","homepage":"http://pytango.rtfd.io","size":17128,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"tango-controls:develop","ref":"develop","sha":"9cf78c517c9cdc1081ff6d080a9646a740cc1d36","user":{"login":"tango-controls","id":15830606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODMwNjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":27967182,"node_id":"MDEwOlJlcG9zaXRvcnkyNzk2NzE4Mg==","name":"pytango","full_name":"tango-controls/pytango","private":false,"owner":{"login":"tango-controls","id":15830606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODMwNjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tango-controls/pytango","description":"Python binding to Tango C++","fork":false,"url":"https://api.github.com/repos/tango-controls/pytango","forks_url":"https://api.github.com/repos/tango-controls/pytango/forks","keys_url":"https://api.github.com/repos/tango-controls/pytango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tango-controls/pytango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tango-controls/pytango/teams","hooks_url":"https://api.github.com/repos/tango-controls/pytango/hooks","issue_events_url":"https://api.github.com/repos/tango-controls/pytango/issues/events{/number}","events_url":"https://api.github.com/repos/tango-controls/pytango/events","assignees_url":"https://api.github.com/repos/tango-controls/pytango/assignees{/user}","branches_url":"https://api.github.com/repos/tango-controls/pytango/branches{/branch}","tags_url":"https://api.github.com/repos/tango-controls/pytango/tags","blobs_url":"https://api.github.com/repos/tango-controls/pytango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tango-controls/pytango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tango-controls/pytango/git/refs{/sha}","trees_url":"https://api.github.com/repos/tango-controls/pytango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tango-controls/pytango/statuses/{sha}","languages_url":"https://api.github.com/repos/tango-controls/pytango/languages","stargazers_url":"https://api.github.com/repos/tango-controls/pytango/stargazers","contributors_url":"https://api.github.com/repos/tango-controls/pytango/contributors","subscribers_url":"https://api.github.com/repos/tango-controls/pytango/subscribers","subscription_url":"https://api.github.com/repos/tango-controls/pytango/subscription","commits_url":"https://api.github.com/repos/tango-controls/pytango/commits{/sha}","git_commits_url":"https://api.github.com/repos/tango-controls/pytango/git/commits{/sha}","comments_url":"https://api.github.com/repos/tango-controls/pytango/comments{/number}","issue_comment_url":"https://api.github.com/repos/tango-controls/pytango/issues/comments{/number}","contents_url":"https://api.github.com/repos/tango-controls/pytango/contents/{+path}","compare_url":"https://api.github.com/repos/tango-controls/pytango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tango-controls/pytango/merges","archive_url":"https://api.github.com/repos/tango-controls/pytango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tango-controls/pytango/downloads","issues_url":"https://api.github.com/repos/tango-controls/pytango/issues{/number}","pulls_url":"https://api.github.com/repos/tango-controls/pytango/pulls{/number}","milestones_url":"https://api.github.com/repos/tango-controls/pytango/milestones{/number}","notifications_url":"https://api.github.com/repos/tango-controls/pytango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tango-controls/pytango/labels{/name}","releases_url":"https://api.github.com/repos/tango-controls/pytango/releases{/id}","deployments_url":"https://api.github.com/repos/tango-controls/pytango/deployments","created_at":"2014-12-13T16:58:57Z","updated_at":"2019-04-26T12:16:57Z","pushed_at":"2019-05-11T15:39:12Z","git_url":"git://github.com/tango-controls/pytango.git","ssh_url":"git@github.com:tango-controls/pytango.git","clone_url":"https://github.com/tango-controls/pytango.git","svn_url":"https://github.com/tango-controls/pytango","homepage":"http://pytango.rtfd.io","size":16998,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":34,"open_issues":39,"watchers":33,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/277"},"html":{"href":"https://github.com/tango-controls/pytango/pull/277"},"issue":{"href":"https://api.github.com/repos/tango-controls/pytango/issues/277"},"comments":{"href":"https://api.github.com/repos/tango-controls/pytango/issues/277/comments"},"review_comments":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/277/comments"},"review_comment":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tango-controls/pytango/pulls/277/commits"},"statuses":{"href":"https://api.github.com/repos/tango-controls/pytango/statuses/172413c53cb2dc26dc4009e6c15b69019b5999fd"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27967182,
"name": "tango-controls/pytango",
"url": "https://api.github.com/repos/tango-controls/pytango"
}
|
{
"id": 2684070,
"login": "tiagocoutinho",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2684070?",
"url": "https://api.github.com/users/tiagocoutinho"
}
|
{
"id": 15830606,
"login": "tango-controls",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15830606?",
"url": "https://api.github.com/orgs/tango-controls"
}
| 2019-05-13T15:29:22 |
9615322610
|
{"actor":{"display_login":"tiagocoutinho"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gridsingularity/d3a/pulls/comments/281111197","pull_request_review_id":233887365,"id":281111197,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTExMTE5Nw==","diff_hunk":"@@ -119,13 +119,13 @@ def accept_offer(self, offer_or_id: Union[str, Offer], buyer: str, *, energy: in\n if trade_rate is None:\n trade_rate = offer.price / offer.energy\n \n- energy_portion = energy / offer.energy\n self._sorted_offers = sorted(self.offers.values(),\n key=lambda o: o.price / o.energy)\n try:\n if time is None:\n time = self._now\n if energy is not None:\n+ energy_portion = energy / offer.energy","path":"src/d3a/models/market/one_sided.py","position":83,"original_position":11,"commit_id":"18b37cdea0f3813a6143c49541177b8897bb87af","original_commit_id":"18b37cdea0f3813a6143c49541177b8897bb87af","user":{"login":"hannesdiedrich","id":19326608,"node_id":"MDQ6VXNlcjE5MzI2NjA4","avatar_url":"https://avatars3.githubusercontent.com/u/19326608?v=4","gravatar_id":"","url":"https://api.github.com/users/hannesdiedrich","html_url":"https://github.com/hannesdiedrich","followers_url":"https://api.github.com/users/hannesdiedrich/followers","following_url":"https://api.github.com/users/hannesdiedrich/following{/other_user}","gists_url":"https://api.github.com/users/hannesdiedrich/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesdiedrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesdiedrich/subscriptions","organizations_url":"https://api.github.com/users/hannesdiedrich/orgs","repos_url":"https://api.github.com/users/hannesdiedrich/repos","events_url":"https://api.github.com/users/hannesdiedrich/events{/privacy}","received_events_url":"https://api.github.com/users/hannesdiedrich/received_events","type":"User","site_admin":false},"body":"Ah, ok! Thanks!","created_at":"2019-05-06T09:10:56Z","updated_at":"2019-05-06T09:10:56Z","html_url":"https://github.com/gridsingularity/d3a/pull/438#discussion_r281111197","pull_request_url":"https://api.github.com/repos/gridsingularity/d3a/pulls/438","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gridsingularity/d3a/pulls/comments/281111197"},"html":{"href":"https://github.com/gridsingularity/d3a/pull/438#discussion_r281111197"},"pull_request":{"href":"https://api.github.com/repos/gridsingularity/d3a/pulls/438"}},"in_reply_to_id":281109737},"pull_request":{"url":"https://api.github.com/repos/gridsingularity/d3a/pulls/438","id":275744321,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1NzQ0MzIx","html_url":"https://github.com/gridsingularity/d3a/pull/438","diff_url":"https://github.com/gridsingularity/d3a/pull/438.diff","patch_url":"https://github.com/gridsingularity/d3a/pull/438.patch","issue_url":"https://api.github.com/repos/gridsingularity/d3a/issues/438","number":438,"state":"open","locked":false,"title":"D3ASIM-1110: Replaced grid fee calculation to take into account initi…","user":{"login":"spyrostz","id":37290802,"node_id":"MDQ6VXNlcjM3MjkwODAy","avatar_url":"https://avatars2.githubusercontent.com/u/37290802?v=4","gravatar_id":"","url":"https://api.github.com/users/spyrostz","html_url":"https://github.com/spyrostz","followers_url":"https://api.github.com/users/spyrostz/followers","following_url":"https://api.github.com/users/spyrostz/following{/other_user}","gists_url":"https://api.github.com/users/spyrostz/gists{/gist_id}","starred_url":"https://api.github.com/users/spyrostz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spyrostz/subscriptions","organizations_url":"https://api.github.com/users/spyrostz/orgs","repos_url":"https://api.github.com/users/spyrostz/repos","events_url":"https://api.github.com/users/spyrostz/events{/privacy}","received_events_url":"https://api.github.com/users/spyrostz/received_events","type":"User","site_admin":false},"body":"…al offer/bid/trade price.","created_at":"2019-05-03T14:59:24Z","updated_at":"2019-05-06T09:10:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d24944101124038c201061a8778fd8d7a63a1e3e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"faizan2590","id":33482427,"node_id":"MDQ6VXNlcjMzNDgyNDI3","avatar_url":"https://avatars2.githubusercontent.com/u/33482427?v=4","gravatar_id":"","url":"https://api.github.com/users/faizan2590","html_url":"https://github.com/faizan2590","followers_url":"https://api.github.com/users/faizan2590/followers","following_url":"https://api.github.com/users/faizan2590/following{/other_user}","gists_url":"https://api.github.com/users/faizan2590/gists{/gist_id}","starred_url":"https://api.github.com/users/faizan2590/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faizan2590/subscriptions","organizations_url":"https://api.github.com/users/faizan2590/orgs","repos_url":"https://api.github.com/users/faizan2590/repos","events_url":"https://api.github.com/users/faizan2590/events{/privacy}","received_events_url":"https://api.github.com/users/faizan2590/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gridsingularity/d3a/pulls/438/commits","review_comments_url":"https://api.github.com/repos/gridsingularity/d3a/pulls/438/comments","review_comment_url":"https://api.github.com/repos/gridsingularity/d3a/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gridsingularity/d3a/issues/438/comments","statuses_url":"https://api.github.com/repos/gridsingularity/d3a/statuses/18b37cdea0f3813a6143c49541177b8897bb87af","head":{"label":"gridsingularity:feature/D3ASIM-1110","ref":"feature/D3ASIM-1110","sha":"18b37cdea0f3813a6143c49541177b8897bb87af","user":{"login":"gridsingularity","id":15871858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxODU4","avatar_url":"https://avatars3.githubusercontent.com/u/15871858?v=4","gravatar_id":"","url":"https://api.github.com/users/gridsingularity","html_url":"https://github.com/gridsingularity","followers_url":"https://api.github.com/users/gridsingularity/followers","following_url":"https://api.github.com/users/gridsingularity/following{/other_user}","gists_url":"https://api.github.com/users/gridsingularity/gists{/gist_id}","starred_url":"https://api.github.com/users/gridsingularity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridsingularity/subscriptions","organizations_url":"https://api.github.com/users/gridsingularity/orgs","repos_url":"https://api.github.com/users/gridsingularity/repos","events_url":"https://api.github.com/users/gridsingularity/events{/privacy}","received_events_url":"https://api.github.com/users/gridsingularity/received_events","type":"Organization","site_admin":false},"repo":{"id":73289025,"node_id":"MDEwOlJlcG9zaXRvcnk3MzI4OTAyNQ==","name":"d3a","full_name":"gridsingularity/d3a","private":false,"owner":{"login":"gridsingularity","id":15871858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxODU4","avatar_url":"https://avatars3.githubusercontent.com/u/15871858?v=4","gravatar_id":"","url":"https://api.github.com/users/gridsingularity","html_url":"https://github.com/gridsingularity","followers_url":"https://api.github.com/users/gridsingularity/followers","following_url":"https://api.github.com/users/gridsingularity/following{/other_user}","gists_url":"https://api.github.com/users/gridsingularity/gists{/gist_id}","starred_url":"https://api.github.com/users/gridsingularity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridsingularity/subscriptions","organizations_url":"https://api.github.com/users/gridsingularity/orgs","repos_url":"https://api.github.com/users/gridsingularity/repos","events_url":"https://api.github.com/users/gridsingularity/events{/privacy}","received_events_url":"https://api.github.com/users/gridsingularity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gridsingularity/d3a","description":"decentralised autonomous area agent","fork":false,"url":"https://api.github.com/repos/gridsingularity/d3a","forks_url":"https://api.github.com/repos/gridsingularity/d3a/forks","keys_url":"https://api.github.com/repos/gridsingularity/d3a/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gridsingularity/d3a/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gridsingularity/d3a/teams","hooks_url":"https://api.github.com/repos/gridsingularity/d3a/hooks","issue_events_url":"https://api.github.com/repos/gridsingularity/d3a/issues/events{/number}","events_url":"https://api.github.com/repos/gridsingularity/d3a/events","assignees_url":"https://api.github.com/repos/gridsingularity/d3a/assignees{/user}","branches_url":"https://api.github.com/repos/gridsingularity/d3a/branches{/branch}","tags_url":"https://api.github.com/repos/gridsingularity/d3a/tags","blobs_url":"https://api.github.com/repos/gridsingularity/d3a/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gridsingularity/d3a/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gridsingularity/d3a/git/refs{/sha}","trees_url":"https://api.github.com/repos/gridsingularity/d3a/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gridsingularity/d3a/statuses/{sha}","languages_url":"https://api.github.com/repos/gridsingularity/d3a/languages","stargazers_url":"https://api.github.com/repos/gridsingularity/d3a/stargazers","contributors_url":"https://api.github.com/repos/gridsingularity/d3a/contributors","subscribers_url":"https://api.github.com/repos/gridsingularity/d3a/subscribers","subscription_url":"https://api.github.com/repos/gridsingularity/d3a/subscription","commits_url":"https://api.github.com/repos/gridsingularity/d3a/commits{/sha}","git_commits_url":"https://api.github.com/repos/gridsingularity/d3a/git/commits{/sha}","comments_url":"https://api.github.com/repos/gridsingularity/d3a/comments{/number}","issue_comment_url":"https://api.github.com/repos/gridsingularity/d3a/issues/comments{/number}","contents_url":"https://api.github.com/repos/gridsingularity/d3a/contents/{+path}","compare_url":"https://api.github.com/repos/gridsingularity/d3a/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gridsingularity/d3a/merges","archive_url":"https://api.github.com/repos/gridsingularity/d3a/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gridsingularity/d3a/downloads","issues_url":"https://api.github.com/repos/gridsingularity/d3a/issues{/number}","pulls_url":"https://api.github.com/repos/gridsingularity/d3a/pulls{/number}","milestones_url":"https://api.github.com/repos/gridsingularity/d3a/milestones{/number}","notifications_url":"https://api.github.com/repos/gridsingularity/d3a/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gridsingularity/d3a/labels{/name}","releases_url":"https://api.github.com/repos/gridsingularity/d3a/releases{/id}","deployments_url":"https://api.github.com/repos/gridsingularity/d3a/deployments","created_at":"2016-11-09T14:01:56Z","updated_at":"2019-05-02T13:21:54Z","pushed_at":"2019-05-06T09:07:10Z","git_url":"git://github.com/gridsingularity/d3a.git","ssh_url":"git@github.com:gridsingularity/d3a.git","clone_url":"https://github.com/gridsingularity/d3a.git","svn_url":"https://github.com/gridsingularity/d3a","homepage":null,"size":3438,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"gridsingularity:master","ref":"master","sha":"35e74789dfbcb05a4b2b7b584b470fd49190b50c","user":{"login":"gridsingularity","id":15871858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxODU4","avatar_url":"https://avatars3.githubusercontent.com/u/15871858?v=4","gravatar_id":"","url":"https://api.github.com/users/gridsingularity","html_url":"https://github.com/gridsingularity","followers_url":"https://api.github.com/users/gridsingularity/followers","following_url":"https://api.github.com/users/gridsingularity/following{/other_user}","gists_url":"https://api.github.com/users/gridsingularity/gists{/gist_id}","starred_url":"https://api.github.com/users/gridsingularity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridsingularity/subscriptions","organizations_url":"https://api.github.com/users/gridsingularity/orgs","repos_url":"https://api.github.com/users/gridsingularity/repos","events_url":"https://api.github.com/users/gridsingularity/events{/privacy}","received_events_url":"https://api.github.com/users/gridsingularity/received_events","type":"Organization","site_admin":false},"repo":{"id":73289025,"node_id":"MDEwOlJlcG9zaXRvcnk3MzI4OTAyNQ==","name":"d3a","full_name":"gridsingularity/d3a","private":false,"owner":{"login":"gridsingularity","id":15871858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxODU4","avatar_url":"https://avatars3.githubusercontent.com/u/15871858?v=4","gravatar_id":"","url":"https://api.github.com/users/gridsingularity","html_url":"https://github.com/gridsingularity","followers_url":"https://api.github.com/users/gridsingularity/followers","following_url":"https://api.github.com/users/gridsingularity/following{/other_user}","gists_url":"https://api.github.com/users/gridsingularity/gists{/gist_id}","starred_url":"https://api.github.com/users/gridsingularity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridsingularity/subscriptions","organizations_url":"https://api.github.com/users/gridsingularity/orgs","repos_url":"https://api.github.com/users/gridsingularity/repos","events_url":"https://api.github.com/users/gridsingularity/events{/privacy}","received_events_url":"https://api.github.com/users/gridsingularity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gridsingularity/d3a","description":"decentralised autonomous area agent","fork":false,"url":"https://api.github.com/repos/gridsingularity/d3a","forks_url":"https://api.github.com/repos/gridsingularity/d3a/forks","keys_url":"https://api.github.com/repos/gridsingularity/d3a/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gridsingularity/d3a/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gridsingularity/d3a/teams","hooks_url":"https://api.github.com/repos/gridsingularity/d3a/hooks","issue_events_url":"https://api.github.com/repos/gridsingularity/d3a/issues/events{/number}","events_url":"https://api.github.com/repos/gridsingularity/d3a/events","assignees_url":"https://api.github.com/repos/gridsingularity/d3a/assignees{/user}","branches_url":"https://api.github.com/repos/gridsingularity/d3a/branches{/branch}","tags_url":"https://api.github.com/repos/gridsingularity/d3a/tags","blobs_url":"https://api.github.com/repos/gridsingularity/d3a/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gridsingularity/d3a/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gridsingularity/d3a/git/refs{/sha}","trees_url":"https://api.github.com/repos/gridsingularity/d3a/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gridsingularity/d3a/statuses/{sha}","languages_url":"https://api.github.com/repos/gridsingularity/d3a/languages","stargazers_url":"https://api.github.com/repos/gridsingularity/d3a/stargazers","contributors_url":"https://api.github.com/repos/gridsingularity/d3a/contributors","subscribers_url":"https://api.github.com/repos/gridsingularity/d3a/subscribers","subscription_url":"https://api.github.com/repos/gridsingularity/d3a/subscription","commits_url":"https://api.github.com/repos/gridsingularity/d3a/commits{/sha}","git_commits_url":"https://api.github.com/repos/gridsingularity/d3a/git/commits{/sha}","comments_url":"https://api.github.com/repos/gridsingularity/d3a/comments{/number}","issue_comment_url":"https://api.github.com/repos/gridsingularity/d3a/issues/comments{/number}","contents_url":"https://api.github.com/repos/gridsingularity/d3a/contents/{+path}","compare_url":"https://api.github.com/repos/gridsingularity/d3a/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gridsingularity/d3a/merges","archive_url":"https://api.github.com/repos/gridsingularity/d3a/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gridsingularity/d3a/downloads","issues_url":"https://api.github.com/repos/gridsingularity/d3a/issues{/number}","pulls_url":"https://api.github.com/repos/gridsingularity/d3a/pulls{/number}","milestones_url":"https://api.github.com/repos/gridsingularity/d3a/milestones{/number}","notifications_url":"https://api.github.com/repos/gridsingularity/d3a/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gridsingularity/d3a/labels{/name}","releases_url":"https://api.github.com/repos/gridsingularity/d3a/releases{/id}","deployments_url":"https://api.github.com/repos/gridsingularity/d3a/deployments","created_at":"2016-11-09T14:01:56Z","updated_at":"2019-05-02T13:21:54Z","pushed_at":"2019-05-06T09:07:10Z","git_url":"git://github.com/gridsingularity/d3a.git","ssh_url":"git@github.com:gridsingularity/d3a.git","clone_url":"https://github.com/gridsingularity/d3a.git","svn_url":"https://github.com/gridsingularity/d3a","homepage":null,"size":3438,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gridsingularity/d3a/pulls/438"},"html":{"href":"https://github.com/gridsingularity/d3a/pull/438"},"issue":{"href":"https://api.github.com/repos/gridsingularity/d3a/issues/438"},"comments":{"href":"https://api.github.com/repos/gridsingularity/d3a/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/gridsingularity/d3a/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/gridsingularity/d3a/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gridsingularity/d3a/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/gridsingularity/d3a/statuses/18b37cdea0f3813a6143c49541177b8897bb87af"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 73289025,
"name": "gridsingularity/d3a",
"url": "https://api.github.com/repos/gridsingularity/d3a"
}
|
{
"id": 19326608,
"login": "hannesdiedrich",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19326608?",
"url": "https://api.github.com/users/hannesdiedrich"
}
|
{
"id": 15871858,
"login": "gridsingularity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15871858?",
"url": "https://api.github.com/orgs/gridsingularity"
}
| 2019-05-06T09:10:56 |
9568690972
|
{"actor":{"display_login":"hannesdiedrich"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/moira-alert/moira/pulls/comments/351925744","pull_request_review_id":324455922,"id":351925744,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTkyNTc0NA==","diff_hunk":"@@ -49,10 +59,81 @@ func deleteUser(database moira.Database, user string) error {\n \tif err != nil {\n \t\treturn err\n \t}\n+\n \tfor _, contactID := range contactIDs {\n \t\tif err := database.RemoveContact(contactID); err != nil {\n \t\t\treturn err\n \t\t}\n \t}\n+\n \treturn nil\n }\n+\n+func handleCleanup(logger moira.Logger, database moira.Database, config cleanupConfig) error {\n+\tvar users []string\n+\n+\treader := json.NewDecoder(bufio.NewReader(os.Stdin))\n+\n+\tif err := reader.Decode(&users); err != nil {\n+\t\treturn err\n+\t}\n+\n+\treturn usersCleanup(logger, database, users, config)\n+}\n+\n+func usersCleanup(logger moira.Logger, database moira.Database, users []string, config cleanupConfig) error {\n+\tusersMap := make(map[string]bool, len(users)+len(config.Whitelist))\n+\n+\tif config.HandlingAnonymous {\n+\t\tconfig.Whitelist = append(config.Whitelist, \"\")\n+\t}\n+\n+\tfor _, user := range append(users, config.Whitelist...) {\n+\t\tusersMap[user] = true\n+\t}\n+\n+\tcontacts, err := database.GetAllContacts()\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\tvar usersNotFound []string\n+\n+\tfor _, contact := range contacts {\n+\t\tif !usersMap[contact.User] {\n+\t\t\tusersNotFound = append(usersNotFound, contact.User)\n+\t\t}\n+\t}\n+\n+\tfor _, user := range usersNotFound {\n+\t\tif config.Delete {\n+\t\t\tif err = deleteUser(database, user); err != nil {\n+\t\t\t\tbreak\n+\t\t\t}\n+\t\t} else if err = offNotification(database, user); err != nil {\n+\t\t\tbreak\n+\t\t}\n+\n+\t\tlogger.Info(\"User cleaned:\", user)\n+\t}\n+\n+\treturn err\n+}\n+\n+func offNotification(database moira.Database, user string) error {\n+\tsubscriptionIDs, err := database.GetUserSubscriptionIDs(user)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\tsubscriptions, err := database.GetSubscriptions(subscriptionIDs)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\tfor _, subscription := range subscriptions {\n+\t\tsubscription.Enabled = false","path":"cmd/cli/user.go","position":126,"original_position":126,"commit_id":"9db3b9f92f4b5834c80b66653521497846122dac","original_commit_id":"9db3b9f92f4b5834c80b66653521497846122dac","user":{"login":"kamaev","id":5269320,"node_id":"MDQ6VXNlcjUyNjkzMjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5269320?v=4","gravatar_id":"","url":"https://api.github.com/users/kamaev","html_url":"https://github.com/kamaev","followers_url":"https://api.github.com/users/kamaev/followers","following_url":"https://api.github.com/users/kamaev/following{/other_user}","gists_url":"https://api.github.com/users/kamaev/gists{/gist_id}","starred_url":"https://api.github.com/users/kamaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamaev/subscriptions","organizations_url":"https://api.github.com/users/kamaev/orgs","repos_url":"https://api.github.com/users/kamaev/repos","events_url":"https://api.github.com/users/kamaev/events{/privacy}","received_events_url":"https://api.github.com/users/kamaev/received_events","type":"User","site_admin":false},"body":"BTW: i think we can also flush already scheduled notifications here (https://github.com/moira-alert/moira/blob/3fa28a373f082c49a0c1dc6b6d512470d35bb496/database/redis/notification.go#L54)","created_at":"2019-11-28T21:01:53Z","updated_at":"2019-11-28T21:01:53Z","html_url":"https://github.com/moira-alert/moira/pull/451#discussion_r351925744","pull_request_url":"https://api.github.com/repos/moira-alert/moira/pulls/451","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moira-alert/moira/pulls/comments/351925744"},"html":{"href":"https://github.com/moira-alert/moira/pull/451#discussion_r351925744"},"pull_request":{"href":"https://api.github.com/repos/moira-alert/moira/pulls/451"}},"in_reply_to_id":351920009},"pull_request":{"url":"https://api.github.com/repos/moira-alert/moira/pulls/451","id":336619742,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2NjE5NzQy","html_url":"https://github.com/moira-alert/moira/pull/451","diff_url":"https://github.com/moira-alert/moira/pull/451.diff","patch_url":"https://github.com/moira-alert/moira/pull/451.patch","issue_url":"https://api.github.com/repos/moira-alert/moira/issues/451","number":451,"state":"open","locked":false,"title":"Disabling and deleting notifications and contacts for fired users","user":{"login":"Nixolay","id":29486434,"node_id":"MDQ6VXNlcjI5NDg2NDM0","avatar_url":"https://avatars2.githubusercontent.com/u/29486434?v=4","gravatar_id":"","url":"https://api.github.com/users/Nixolay","html_url":"https://github.com/Nixolay","followers_url":"https://api.github.com/users/Nixolay/followers","following_url":"https://api.github.com/users/Nixolay/following{/other_user}","gists_url":"https://api.github.com/users/Nixolay/gists{/gist_id}","starred_url":"https://api.github.com/users/Nixolay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nixolay/subscriptions","organizations_url":"https://api.github.com/users/Nixolay/orgs","repos_url":"https://api.github.com/users/Nixolay/repos","events_url":"https://api.github.com/users/Nixolay/events{/privacy}","received_events_url":"https://api.github.com/users/Nixolay/received_events","type":"User","site_admin":false},"body":"\r\n* Getting a list of users through stdin\r\n* Add a whitelist of users and the delete flag (notifications and contacts for the user)","created_at":"2019-11-05T06:46:06Z","updated_at":"2019-11-28T21:01:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"220b945025a79b9847d07077efe30a201f02c21d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1174803457,"node_id":"MDU6TGFiZWwxMTc0ODAzNDU3","url":"https://api.github.com/repos/moira-alert/moira/labels/backend","name":"backend","color":"3e77e0","default":false,"description":""},{"id":1125919478,"node_id":"MDU6TGFiZWwxMTI1OTE5NDc4","url":"https://api.github.com/repos/moira-alert/moira/labels/feature","name":"feature","color":"e2ca88","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/moira-alert/moira/pulls/451/commits","review_comments_url":"https://api.github.com/repos/moira-alert/moira/pulls/451/comments","review_comment_url":"https://api.github.com/repos/moira-alert/moira/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moira-alert/moira/issues/451/comments","statuses_url":"https://api.github.com/repos/moira-alert/moira/statuses/9db3b9f92f4b5834c80b66653521497846122dac","head":{"label":"moira-alert:feature/424-off-notifications-by-list-staff","ref":"feature/424-off-notifications-by-list-staff","sha":"9db3b9f92f4b5834c80b66653521497846122dac","user":{"login":"moira-alert","id":15890491,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODkwNDkx","avatar_url":"https://avatars1.githubusercontent.com/u/15890491?v=4","gravatar_id":"","url":"https://api.github.com/users/moira-alert","html_url":"https://github.com/moira-alert","followers_url":"https://api.github.com/users/moira-alert/followers","following_url":"https://api.github.com/users/moira-alert/following{/other_user}","gists_url":"https://api.github.com/users/moira-alert/gists{/gist_id}","starred_url":"https://api.github.com/users/moira-alert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moira-alert/subscriptions","organizations_url":"https://api.github.com/users/moira-alert/orgs","repos_url":"https://api.github.com/users/moira-alert/repos","events_url":"https://api.github.com/users/moira-alert/events{/privacy}","received_events_url":"https://api.github.com/users/moira-alert/received_events","type":"Organization","site_admin":false},"repo":{"id":96085061,"node_id":"MDEwOlJlcG9zaXRvcnk5NjA4NTA2MQ==","name":"moira","full_name":"moira-alert/moira","private":false,"owner":{"login":"moira-alert","id":15890491,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODkwNDkx","avatar_url":"https://avatars1.githubusercontent.com/u/15890491?v=4","gravatar_id":"","url":"https://api.github.com/users/moira-alert","html_url":"https://github.com/moira-alert","followers_url":"https://api.github.com/users/moira-alert/followers","following_url":"https://api.github.com/users/moira-alert/following{/other_user}","gists_url":"https://api.github.com/users/moira-alert/gists{/gist_id}","starred_url":"https://api.github.com/users/moira-alert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moira-alert/subscriptions","organizations_url":"https://api.github.com/users/moira-alert/orgs","repos_url":"https://api.github.com/users/moira-alert/repos","events_url":"https://api.github.com/users/moira-alert/events{/privacy}","received_events_url":"https://api.github.com/users/moira-alert/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moira-alert/moira","description":"Realtime Alerting for Graphite","fork":false,"url":"https://api.github.com/repos/moira-alert/moira","forks_url":"https://api.github.com/repos/moira-alert/moira/forks","keys_url":"https://api.github.com/repos/moira-alert/moira/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moira-alert/moira/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moira-alert/moira/teams","hooks_url":"https://api.github.com/repos/moira-alert/moira/hooks","issue_events_url":"https://api.github.com/repos/moira-alert/moira/issues/events{/number}","events_url":"https://api.github.com/repos/moira-alert/moira/events","assignees_url":"https://api.github.com/repos/moira-alert/moira/assignees{/user}","branches_url":"https://api.github.com/repos/moira-alert/moira/branches{/branch}","tags_url":"https://api.github.com/repos/moira-alert/moira/tags","blobs_url":"https://api.github.com/repos/moira-alert/moira/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moira-alert/moira/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moira-alert/moira/git/refs{/sha}","trees_url":"https://api.github.com/repos/moira-alert/moira/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moira-alert/moira/statuses/{sha}","languages_url":"https://api.github.com/repos/moira-alert/moira/languages","stargazers_url":"https://api.github.com/repos/moira-alert/moira/stargazers","contributors_url":"https://api.github.com/repos/moira-alert/moira/contributors","subscribers_url":"https://api.github.com/repos/moira-alert/moira/subscribers","subscription_url":"https://api.github.com/repos/moira-alert/moira/subscription","commits_url":"https://api.github.com/repos/moira-alert/moira/commits{/sha}","git_commits_url":"https://api.github.com/repos/moira-alert/moira/git/commits{/sha}","comments_url":"https://api.github.com/repos/moira-alert/moira/comments{/number}","issue_comment_url":"https://api.github.com/repos/moira-alert/moira/issues/comments{/number}","contents_url":"https://api.github.com/repos/moira-alert/moira/contents/{+path}","compare_url":"https://api.github.com/repos/moira-alert/moira/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moira-alert/moira/merges","archive_url":"https://api.github.com/repos/moira-alert/moira/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moira-alert/moira/downloads","issues_url":"https://api.github.com/repos/moira-alert/moira/issues{/number}","pulls_url":"https://api.github.com/repos/moira-alert/moira/pulls{/number}","milestones_url":"https://api.github.com/repos/moira-alert/moira/milestones{/number}","notifications_url":"https://api.github.com/repos/moira-alert/moira/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moira-alert/moira/labels{/name}","releases_url":"https://api.github.com/repos/moira-alert/moira/releases{/id}","deployments_url":"https://api.github.com/repos/moira-alert/moira/deployments","created_at":"2017-07-03T07:54:55Z","updated_at":"2019-11-28T17:23:46Z","pushed_at":"2019-11-28T14:40:20Z","git_url":"git://github.com/moira-alert/moira.git","ssh_url":"git@github.com:moira-alert/moira.git","clone_url":"https://github.com/moira-alert/moira.git","svn_url":"https://github.com/moira-alert/moira","homepage":"","size":10843,"stargazers_count":182,"watchers_count":182,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":82,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":82,"watchers":182,"default_branch":"master"}},"base":{"label":"moira-alert:master","ref":"master","sha":"3fa28a373f082c49a0c1dc6b6d512470d35bb496","user":{"login":"moira-alert","id":15890491,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODkwNDkx","avatar_url":"https://avatars1.githubusercontent.com/u/15890491?v=4","gravatar_id":"","url":"https://api.github.com/users/moira-alert","html_url":"https://github.com/moira-alert","followers_url":"https://api.github.com/users/moira-alert/followers","following_url":"https://api.github.com/users/moira-alert/following{/other_user}","gists_url":"https://api.github.com/users/moira-alert/gists{/gist_id}","starred_url":"https://api.github.com/users/moira-alert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moira-alert/subscriptions","organizations_url":"https://api.github.com/users/moira-alert/orgs","repos_url":"https://api.github.com/users/moira-alert/repos","events_url":"https://api.github.com/users/moira-alert/events{/privacy}","received_events_url":"https://api.github.com/users/moira-alert/received_events","type":"Organization","site_admin":false},"repo":{"id":96085061,"node_id":"MDEwOlJlcG9zaXRvcnk5NjA4NTA2MQ==","name":"moira","full_name":"moira-alert/moira","private":false,"owner":{"login":"moira-alert","id":15890491,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODkwNDkx","avatar_url":"https://avatars1.githubusercontent.com/u/15890491?v=4","gravatar_id":"","url":"https://api.github.com/users/moira-alert","html_url":"https://github.com/moira-alert","followers_url":"https://api.github.com/users/moira-alert/followers","following_url":"https://api.github.com/users/moira-alert/following{/other_user}","gists_url":"https://api.github.com/users/moira-alert/gists{/gist_id}","starred_url":"https://api.github.com/users/moira-alert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moira-alert/subscriptions","organizations_url":"https://api.github.com/users/moira-alert/orgs","repos_url":"https://api.github.com/users/moira-alert/repos","events_url":"https://api.github.com/users/moira-alert/events{/privacy}","received_events_url":"https://api.github.com/users/moira-alert/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moira-alert/moira","description":"Realtime Alerting for Graphite","fork":false,"url":"https://api.github.com/repos/moira-alert/moira","forks_url":"https://api.github.com/repos/moira-alert/moira/forks","keys_url":"https://api.github.com/repos/moira-alert/moira/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moira-alert/moira/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moira-alert/moira/teams","hooks_url":"https://api.github.com/repos/moira-alert/moira/hooks","issue_events_url":"https://api.github.com/repos/moira-alert/moira/issues/events{/number}","events_url":"https://api.github.com/repos/moira-alert/moira/events","assignees_url":"https://api.github.com/repos/moira-alert/moira/assignees{/user}","branches_url":"https://api.github.com/repos/moira-alert/moira/branches{/branch}","tags_url":"https://api.github.com/repos/moira-alert/moira/tags","blobs_url":"https://api.github.com/repos/moira-alert/moira/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moira-alert/moira/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moira-alert/moira/git/refs{/sha}","trees_url":"https://api.github.com/repos/moira-alert/moira/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moira-alert/moira/statuses/{sha}","languages_url":"https://api.github.com/repos/moira-alert/moira/languages","stargazers_url":"https://api.github.com/repos/moira-alert/moira/stargazers","contributors_url":"https://api.github.com/repos/moira-alert/moira/contributors","subscribers_url":"https://api.github.com/repos/moira-alert/moira/subscribers","subscription_url":"https://api.github.com/repos/moira-alert/moira/subscription","commits_url":"https://api.github.com/repos/moira-alert/moira/commits{/sha}","git_commits_url":"https://api.github.com/repos/moira-alert/moira/git/commits{/sha}","comments_url":"https://api.github.com/repos/moira-alert/moira/comments{/number}","issue_comment_url":"https://api.github.com/repos/moira-alert/moira/issues/comments{/number}","contents_url":"https://api.github.com/repos/moira-alert/moira/contents/{+path}","compare_url":"https://api.github.com/repos/moira-alert/moira/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moira-alert/moira/merges","archive_url":"https://api.github.com/repos/moira-alert/moira/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moira-alert/moira/downloads","issues_url":"https://api.github.com/repos/moira-alert/moira/issues{/number}","pulls_url":"https://api.github.com/repos/moira-alert/moira/pulls{/number}","milestones_url":"https://api.github.com/repos/moira-alert/moira/milestones{/number}","notifications_url":"https://api.github.com/repos/moira-alert/moira/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moira-alert/moira/labels{/name}","releases_url":"https://api.github.com/repos/moira-alert/moira/releases{/id}","deployments_url":"https://api.github.com/repos/moira-alert/moira/deployments","created_at":"2017-07-03T07:54:55Z","updated_at":"2019-11-28T17:23:46Z","pushed_at":"2019-11-28T14:40:20Z","git_url":"git://github.com/moira-alert/moira.git","ssh_url":"git@github.com:moira-alert/moira.git","clone_url":"https://github.com/moira-alert/moira.git","svn_url":"https://github.com/moira-alert/moira","homepage":"","size":10843,"stargazers_count":182,"watchers_count":182,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":82,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":82,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moira-alert/moira/pulls/451"},"html":{"href":"https://github.com/moira-alert/moira/pull/451"},"issue":{"href":"https://api.github.com/repos/moira-alert/moira/issues/451"},"comments":{"href":"https://api.github.com/repos/moira-alert/moira/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/moira-alert/moira/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/moira-alert/moira/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moira-alert/moira/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/moira-alert/moira/statuses/9db3b9f92f4b5834c80b66653521497846122dac"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 96085061,
"name": "moira-alert/moira",
"url": "https://api.github.com/repos/moira-alert/moira"
}
|
{
"id": 5269320,
"login": "kamaev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5269320?",
"url": "https://api.github.com/users/kamaev"
}
|
{
"id": 15890491,
"login": "moira-alert",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15890491?",
"url": "https://api.github.com/orgs/moira-alert"
}
| 2019-11-28T21:01:53 |
10971869239
|
{"actor":{"display_login":"kamaev"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-server/pulls/comments/256364460","pull_request_review_id":203170928,"id":256364460,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjM2NDQ2MA==","diff_hunk":"@@ -0,0 +1,42 @@\n+# Style\n+\n+## Default Extensions\n+\n+- AllowAmbiguousTypes\n+- BangPatterns\n+- ConstraintKinds\n+- DataKinds\n+- DefaultSignatures\n+- DeriveFunctor\n+- DeriveGeneric\n+- DeriveLift\n+- DeriveTraversable\n+- EmptyCase\n+- FlexibleContexts\n+- FlexibleInstances\n+- FunctionalDependencies\n+- GADTs\n+- InstanceSigs\n+- KindSignatures\n+- LambdaCase\n+- MultiParamTypeClasses\n+- MultiWayIf\n+- NamedFieldPuns\n+- NoMonomorphismRestriction\n+- OverloadedStrings\n+- PackageImports\n+- PatternSynonyms\n+- PolyKinds\n+- QuasiQuotes\n+- RankNTypes\n+- ScopedTypeVariables\n+- StandaloneDeriving\n+- StandaloneDeriving","path":"doc/Style.md","position":34,"original_position":34,"commit_id":"f450f107e9c71300eee62c49932b9a48d69c7a7d","original_commit_id":"ad1b9e10c6bfd7d41bff41b10bc7c36b595428ec","user":{"login":"neongreen","id":1523306,"node_id":"MDQ6VXNlcjE1MjMzMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1523306?v=4","gravatar_id":"","url":"https://api.github.com/users/neongreen","html_url":"https://github.com/neongreen","followers_url":"https://api.github.com/users/neongreen/followers","following_url":"https://api.github.com/users/neongreen/following{/other_user}","gists_url":"https://api.github.com/users/neongreen/gists{/gist_id}","starred_url":"https://api.github.com/users/neongreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neongreen/subscriptions","organizations_url":"https://api.github.com/users/neongreen/orgs","repos_url":"https://api.github.com/users/neongreen/repos","events_url":"https://api.github.com/users/neongreen/events{/privacy}","received_events_url":"https://api.github.com/users/neongreen/received_events","type":"User","site_admin":false},"body":"Duplicate.","created_at":"2019-02-13T12:00:33Z","updated_at":"2019-02-13T12:06:30Z","html_url":"https://github.com/wireapp/wire-server/pull/619#discussion_r256364460","pull_request_url":"https://api.github.com/repos/wireapp/wire-server/pulls/619","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/comments/256364460"},"html":{"href":"https://github.com/wireapp/wire-server/pull/619#discussion_r256364460"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/619"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-server/pulls/619","id":252650418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyNjUwNDE4","html_url":"https://github.com/wireapp/wire-server/pull/619","diff_url":"https://github.com/wireapp/wire-server/pull/619.diff","patch_url":"https://github.com/wireapp/wire-server/pull/619.patch","issue_url":"https://api.github.com/repos/wireapp/wire-server/issues/619","number":619,"state":"open","locked":false,"title":"Extend the list of default language extensions","user":{"login":"ChrisPenner","id":6439644,"node_id":"MDQ6VXNlcjY0Mzk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6439644?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisPenner","html_url":"https://github.com/ChrisPenner","followers_url":"https://api.github.com/users/ChrisPenner/followers","following_url":"https://api.github.com/users/ChrisPenner/following{/other_user}","gists_url":"https://api.github.com/users/ChrisPenner/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisPenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisPenner/subscriptions","organizations_url":"https://api.github.com/users/ChrisPenner/orgs","repos_url":"https://api.github.com/users/ChrisPenner/repos","events_url":"https://api.github.com/users/ChrisPenner/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisPenner/received_events","type":"User","site_admin":false},"body":"Chatted with @fisx this morning and came up with the following list of default extensions; feel free to chime in if there's anything you'd like to be added/removed, or just have thoughts about it 😄\r\n\r\nNote that I'm leaving off `StrictData` for now since that may have unintended effects; we can look at that one separately. \r\n\r\n- AllowAmbiguousTypes \r\n- BangPatterns \r\n- ConstraintKinds \r\n- DataKinds \r\n- DefaultSignatures \r\n- DeriveFunctor \r\n- DeriveGeneric \r\n- DeriveLift \r\n- DeriveTraversable \r\n- EmptyCase \r\n- FlexibleContexts \r\n- FlexibleInstances \r\n- FunctionalDependencies \r\n- GADTs \r\n- InstanceSigs \r\n- KindSignatures \r\n- LambdaCase \r\n- MultiParamTypeClasses \r\n- MultiWayIf \r\n- NamedFieldPuns \r\n- NoImplicitPrelude \r\n- NoMonomorphismRestriction \r\n- OverloadedStrings \r\n- PackageImports \r\n- PatternSynonyms \r\n- PolyKinds \r\n- QuasiQuotes \r\n- RankNTypes \r\n- ScopedTypeVariables \r\n- StandaloneDeriving \r\n- StandaloneDeriving \r\n- TemplateHaskell \r\n- TupleSections \r\n- TypeApplications \r\n- TypeFamilies \r\n- TypeFamilyDependencies \r\n- TypeOperators \r\n- UndecidableInstances \r\n- ViewPatterns \r\n\r\nNotably missing from the list are:\r\n- GeneralizedNewtypeDeriving\r\n - @fisx suggested this not be globally enabled; presumably due to the following:\r\n - > GeneralizedNewtypeDeriving — It can be used to violate constructor access control, by allowing untrusted code to manipulate protected data types in ways the data type author did not intend. For example can be used to break invariants of data structures.\r\n - https://downloads.haskell.org/~ghc/7.2.1/docs/html/users_guide/safe-haskell.html\r\n- RecordWildCards\r\n - I'm personally not a big fan of using RWC; at least not in a pattern-matching position as it brings into scope many names without any way to tell WHAT was brought into scope; this makes it tough to read, and also means that adding new record fields can cause some weird name shadowing problems in distant code blocks.\r\n\r\nOnes which I've added but may be worth discussing:\r\n- AllowAmbiguousTypes\r\n - Are there any cases where one could accidentally introduce an ambiguous type without noticing? I don't believe so, but correct me if I'm wrong.\r\n- UndecidableInstances\r\n - Sometimes it's nice to know when you've written an instance which is undecidable (via getting a compiler warning), but in general I don't really care 🤷♂️ \r\n\r\nChanges in this PR other than enabling the modules are related to fixing issues caused by non-generalized let bindings due to `GADTs` enabling `MonoLocalBinds`. It's strange that this causes several problems for us, but in general I think it just requires that we be more explicit, which is a good thing. Since we do need GADTs in SOME parts of our code, I'm in favour of enabling it everywhere for consistency of the language; as expressed better by Alexis King here:\r\n\r\nhttps://lexi-lambda.github.io/blog/2018/02/10/an-opinionated-guide-to-haskell-in-2018/\r\n\r\n> All of these extensions involve a tradeoff. Enabling GADTs also implies MonoLocalBinds, which disables let generalization, one of the most likely ways a program that used to typecheck might subsequently fail to do so. Some might argue that this is a good reason to turn GADTs on in a per-module basis, but I disagree: I actually want my language to be fairly consistent, and given that I know I am likely going to want to use GADTs somewhere, I want MonoLocalBinds enabled everywhere, not inconsistently and sporadically.","created_at":"2019-02-13T11:04:54Z","updated_at":"2019-02-13T12:06:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21d80a073e93e75d887e70a3d8e7e9be7dbf5fb1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-server/pulls/619/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-server/pulls/619/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-server/issues/619/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/f450f107e9c71300eee62c49932b9a48d69c7a7d","head":{"label":"wireapp:extra-default-extensions","ref":"extra-default-extensions","sha":"f450f107e9c71300eee62c49932b9a48d69c7a7d","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":81935044,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNTA0NA==","name":"wire-server","full_name":"wireapp/wire-server","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-server","description":"🇪🇺 Wire back-end services","fork":false,"url":"https://api.github.com/repos/wireapp/wire-server","forks_url":"https://api.github.com/repos/wireapp/wire-server/forks","keys_url":"https://api.github.com/repos/wireapp/wire-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-server/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-server/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-server/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-server/events","assignees_url":"https://api.github.com/repos/wireapp/wire-server/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-server/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-server/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-server/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-server/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-server/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-server/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-server/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-server/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-server/merges","archive_url":"https://api.github.com/repos/wireapp/wire-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-server/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-server/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-server/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-server/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-server/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-server/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-server/deployments","created_at":"2017-02-14T10:42:59Z","updated_at":"2019-02-13T12:05:08Z","pushed_at":"2019-02-13T12:05:08Z","git_url":"git://github.com/wireapp/wire-server.git","ssh_url":"git@github.com:wireapp/wire-server.git","clone_url":"https://github.com/wireapp/wire-server.git","svn_url":"https://github.com/wireapp/wire-server","homepage":"https://wire.com","size":4621,"stargazers_count":1843,"watchers_count":1843,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":225,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":225,"open_issues":20,"watchers":1843,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"ee5294b5252aec968409a8663a20403ec28e1b0c","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":81935044,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNTA0NA==","name":"wire-server","full_name":"wireapp/wire-server","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-server","description":"🇪🇺 Wire back-end services","fork":false,"url":"https://api.github.com/repos/wireapp/wire-server","forks_url":"https://api.github.com/repos/wireapp/wire-server/forks","keys_url":"https://api.github.com/repos/wireapp/wire-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-server/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-server/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-server/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-server/events","assignees_url":"https://api.github.com/repos/wireapp/wire-server/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-server/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-server/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-server/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-server/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-server/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-server/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-server/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-server/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-server/merges","archive_url":"https://api.github.com/repos/wireapp/wire-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-server/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-server/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-server/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-server/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-server/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-server/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-server/deployments","created_at":"2017-02-14T10:42:59Z","updated_at":"2019-02-13T12:05:08Z","pushed_at":"2019-02-13T12:05:08Z","git_url":"git://github.com/wireapp/wire-server.git","ssh_url":"git@github.com:wireapp/wire-server.git","clone_url":"https://github.com/wireapp/wire-server.git","svn_url":"https://github.com/wireapp/wire-server","homepage":"https://wire.com","size":4621,"stargazers_count":1843,"watchers_count":1843,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":225,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":225,"open_issues":20,"watchers":1843,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/619"},"html":{"href":"https://github.com/wireapp/wire-server/pull/619"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-server/issues/619"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-server/issues/619/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/619/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/619/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-server/statuses/f450f107e9c71300eee62c49932b9a48d69c7a7d"}},"author_association":"NONE"}}
|
{
"id": 81935044,
"name": "wireapp/wire-server",
"url": "https://api.github.com/repos/wireapp/wire-server"
}
|
{
"id": 1523306,
"login": "neongreen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1523306?",
"url": "https://api.github.com/users/neongreen"
}
|
{
"id": 16047324,
"login": "wireapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16047324?",
"url": "https://api.github.com/orgs/wireapp"
}
| 2019-02-13T12:00:33 |
9059643759
|
{"actor":{"display_login":"neongreen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments/269023002","pull_request_review_id":218791634,"id":269023002,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTAyMzAwMg==","diff_hunk":"@@ -23,7 +23,7 @@ github \"wireapp/wire-ios-link-preview\" \"17.0.0\"\n github \"wireapp/wire-ios-protos\" \"19.0.0\"\n github \"wireapp/wire-ios-request-strategy\" \"140.0.1\"\n github \"wireapp/wire-ios-share-engine\" \"129.0.0\"\n-github \"wireapp/wire-ios-sync-engine\" \"241.0.1\"\n+github \"wireapp/wire-ios-sync-engine\" \"243.0.1\"","path":"Cartfile.resolved","position":5,"original_position":5,"commit_id":"766004d9546760b9034fc86b991129f0ac7700fa","original_commit_id":"766004d9546760b9034fc86b991129f0ac7700fa","user":{"login":"typfel","id":7156,"node_id":"MDQ6VXNlcjcxNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7156?v=4","gravatar_id":"","url":"https://api.github.com/users/typfel","html_url":"https://github.com/typfel","followers_url":"https://api.github.com/users/typfel/followers","following_url":"https://api.github.com/users/typfel/following{/other_user}","gists_url":"https://api.github.com/users/typfel/gists{/gist_id}","starred_url":"https://api.github.com/users/typfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typfel/subscriptions","organizations_url":"https://api.github.com/users/typfel/orgs","repos_url":"https://api.github.com/users/typfel/repos","events_url":"https://api.github.com/users/typfel/events{/privacy}","received_events_url":"https://api.github.com/users/typfel/received_events","type":"User","site_admin":false},"body":"This doesn't match the `Cartfile`, when bumping a major version you need to update major version in the `Cartfile` and run `carthage update`","created_at":"2019-03-26T10:04:22Z","updated_at":"2019-03-26T10:04:22Z","html_url":"https://github.com/wireapp/wire-ios/pull/3287#discussion_r269023002","pull_request_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/3287","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments/269023002"},"html":{"href":"https://github.com/wireapp/wire-ios/pull/3287#discussion_r269023002"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/3287"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/3287","id":264121311,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0MTIxMzEx","html_url":"https://github.com/wireapp/wire-ios/pull/3287","diff_url":"https://github.com/wireapp/wire-ios/pull/3287.diff","patch_url":"https://github.com/wireapp/wire-ios/pull/3287.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios/issues/3287","number":3287,"state":"open","locked":false,"title":"Fix: Showing a dialog when opens a deep link with no logged in account.","user":{"login":"billypchan","id":11852044,"node_id":"MDQ6VXNlcjExODUyMDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/11852044?v=4","gravatar_id":"","url":"https://api.github.com/users/billypchan","html_url":"https://github.com/billypchan","followers_url":"https://api.github.com/users/billypchan/followers","following_url":"https://api.github.com/users/billypchan/following{/other_user}","gists_url":"https://api.github.com/users/billypchan/gists{/gist_id}","starred_url":"https://api.github.com/users/billypchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billypchan/subscriptions","organizations_url":"https://api.github.com/users/billypchan/orgs","repos_url":"https://api.github.com/users/billypchan/repos","events_url":"https://api.github.com/users/billypchan/events{/privacy}","received_events_url":"https://api.github.com/users/billypchan/received_events","type":"User","site_admin":false},"body":"## What's new in this PR?\r\n\r\n### Issues\r\n\r\nIf a user opens a deep link with no logged in account, no info dialog is shown.\r\n\r\n### Causes\r\n\r\nThe pending `URLAction` would not be executed in this case since there is no active user session.\r\n\r\n### Solutions\r\n\r\nWhen the app becomes active, AppRootViewController checks if the `authenticationState` is not `loggedIn` and having unhandled deep link stored, show a warning dialog.\r\n\r\n### Dependencies\r\n- [x] https://github.com/wireapp/wire-ios-sync-engine/pull/992\r\n- [x] Wait for the text copy of the dialog.\r\n\r\n","created_at":"2019-03-25T13:32:06Z","updated_at":"2019-03-26T10:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c3b7876be571cb23295dd1e952d9987b495e39a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/3287/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/3287/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/issues/3287/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/766004d9546760b9034fc86b991129f0ac7700fa","head":{"label":"wireapp:fix/deeplink-not-logged-in","ref":"fix/deeplink-not-logged-in","sha":"766004d9546760b9034fc86b991129f0ac7700fa","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63855049,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg1NTA0OQ==","name":"wire-ios","full_name":"wireapp/wire-ios","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-ios","description":"📱 Wire for iOS (iPhone and iPad)","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios","forks_url":"https://api.github.com/repos/wireapp/wire-ios/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios/deployments","created_at":"2016-07-21T09:16:34Z","updated_at":"2019-03-26T10:02:02Z","pushed_at":"2019-03-26T10:02:00Z","git_url":"git://github.com/wireapp/wire-ios.git","ssh_url":"git@github.com:wireapp/wire-ios.git","clone_url":"https://github.com/wireapp/wire-ios.git","svn_url":"https://github.com/wireapp/wire-ios","homepage":"https://wire.com/download/","size":468716,"stargazers_count":2622,"watchers_count":2622,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":445,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":445,"open_issues":135,"watchers":2622,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"f7d6604298f87b02f3986e45160225cb263ef572","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63855049,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg1NTA0OQ==","name":"wire-ios","full_name":"wireapp/wire-ios","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-ios","description":"📱 Wire for iOS (iPhone and iPad)","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios","forks_url":"https://api.github.com/repos/wireapp/wire-ios/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios/deployments","created_at":"2016-07-21T09:16:34Z","updated_at":"2019-03-26T10:02:02Z","pushed_at":"2019-03-26T10:02:00Z","git_url":"git://github.com/wireapp/wire-ios.git","ssh_url":"git@github.com:wireapp/wire-ios.git","clone_url":"https://github.com/wireapp/wire-ios.git","svn_url":"https://github.com/wireapp/wire-ios","homepage":"https://wire.com/download/","size":468716,"stargazers_count":2622,"watchers_count":2622,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":445,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":445,"open_issues":135,"watchers":2622,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/3287"},"html":{"href":"https://github.com/wireapp/wire-ios/pull/3287"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios/issues/3287"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios/issues/3287/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/3287/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios/pulls/3287/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios/statuses/766004d9546760b9034fc86b991129f0ac7700fa"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 63855049,
"name": "wireapp/wire-ios",
"url": "https://api.github.com/repos/wireapp/wire-ios"
}
|
{
"id": 7156,
"login": "typfel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7156?",
"url": "https://api.github.com/users/typfel"
}
|
{
"id": 16047324,
"login": "wireapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16047324?",
"url": "https://api.github.com/orgs/wireapp"
}
| 2019-03-26T10:04:22 |
9314773077
|
{"actor":{"display_login":"typfel"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments/349022279","pull_request_review_id":320800611,"id":349022279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0OTAyMjI3OQ==","diff_hunk":"@@ -399,7 +409,7 @@ export class UserRepository {\n this.logger.log(`Availability was again set to '${newAvailabilityValue}'`);\n }\n \n- if (teamUsers.length > UserRepository.CONFIG.MAXIMUM_TEAM_SIZE_BROADCAST) {\n+ if (teamUsers.length >= UserRepository.CONFIG.MAXIMUM_TEAM_SIZE_BROADCAST) {","path":"src/script/user/UserRepository.ts","position":59,"original_position":59,"commit_id":"0c3361c92eefa1c2ce9e6e42b8cde73858530a58","original_commit_id":"0c3361c92eefa1c2ce9e6e42b8cde73858530a58","user":{"login":"AndyLnd","id":1122618,"node_id":"MDQ6VXNlcjExMjI2MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1122618?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyLnd","html_url":"https://github.com/AndyLnd","followers_url":"https://api.github.com/users/AndyLnd/followers","following_url":"https://api.github.com/users/AndyLnd/following{/other_user}","gists_url":"https://api.github.com/users/AndyLnd/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyLnd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyLnd/subscriptions","organizations_url":"https://api.github.com/users/AndyLnd/orgs","repos_url":"https://api.github.com/users/AndyLnd/repos","events_url":"https://api.github.com/users/AndyLnd/events{/privacy}","received_events_url":"https://api.github.com/users/AndyLnd/received_events","type":"User","site_admin":false},"body":"🕵🏻♂️","created_at":"2019-11-21T11:02:15Z","updated_at":"2019-11-21T11:02:20Z","html_url":"https://github.com/wireapp/wire-webapp/pull/7758#discussion_r349022279","pull_request_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/7758","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments/349022279"},"html":{"href":"https://github.com/wireapp/wire-webapp/pull/7758#discussion_r349022279"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/7758"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/7758","id":343966825,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzOTY2ODI1","html_url":"https://github.com/wireapp/wire-webapp/pull/7758","diff_url":"https://github.com/wireapp/wire-webapp/pull/7758.diff","patch_url":"https://github.com/wireapp/wire-webapp/pull/7758.patch","issue_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/7758","number":7758,"state":"open","locked":false,"title":"runfix: Adjust maximum team size for broadcasting (WEBAPP-6544)","user":{"login":"ffflorian","id":5497598,"node_id":"MDQ6VXNlcjU0OTc1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5497598?v=4","gravatar_id":"","url":"https://api.github.com/users/ffflorian","html_url":"https://github.com/ffflorian","followers_url":"https://api.github.com/users/ffflorian/followers","following_url":"https://api.github.com/users/ffflorian/following{/other_user}","gists_url":"https://api.github.com/users/ffflorian/gists{/gist_id}","starred_url":"https://api.github.com/users/ffflorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffflorian/subscriptions","organizations_url":"https://api.github.com/users/ffflorian/orgs","repos_url":"https://api.github.com/users/ffflorian/repos","events_url":"https://api.github.com/users/ffflorian/events{/privacy}","received_events_url":"https://api.github.com/users/ffflorian/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-21T10:54:54Z","updated_at":"2019-11-21T11:02:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"930f8437813244d54b818312e1e60301c3a6d64b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/7758/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/7758/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/7758/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/0c3361c92eefa1c2ce9e6e42b8cde73858530a58","head":{"label":"wireapp:runfix/maximum-team-size-adjust","ref":"runfix/maximum-team-size-adjust","sha":"0c3361c92eefa1c2ce9e6e42b8cde73858530a58","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63881328,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg4MTMyOA==","name":"wire-webapp","full_name":"wireapp/wire-webapp","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-webapp","description":"👽 Wire for web","fork":false,"url":"https://api.github.com/repos/wireapp/wire-webapp","forks_url":"https://api.github.com/repos/wireapp/wire-webapp/forks","keys_url":"https://api.github.com/repos/wireapp/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-webapp/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-webapp/events","assignees_url":"https://api.github.com/repos/wireapp/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-webapp/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-webapp/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-webapp/merges","archive_url":"https://api.github.com/repos/wireapp/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-webapp/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-webapp/deployments","created_at":"2016-07-21T15:34:05Z","updated_at":"2019-11-20T16:46:02Z","pushed_at":"2019-11-21T10:57:28Z","git_url":"git://github.com/wireapp/wire-webapp.git","ssh_url":"git@github.com:wireapp/wire-webapp.git","clone_url":"https://github.com/wireapp/wire-webapp.git","svn_url":"https://github.com/wireapp/wire-webapp","homepage":"https://app.wire.com","size":47930,"stargazers_count":896,"watchers_count":896,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":112,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":215,"open_issues":112,"watchers":896,"default_branch":"dev"}},"base":{"label":"wireapp:dev","ref":"dev","sha":"ccb12c8ccf3ee19d08bb8de79e4d5e31c00eaf4a","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63881328,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg4MTMyOA==","name":"wire-webapp","full_name":"wireapp/wire-webapp","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-webapp","description":"👽 Wire for web","fork":false,"url":"https://api.github.com/repos/wireapp/wire-webapp","forks_url":"https://api.github.com/repos/wireapp/wire-webapp/forks","keys_url":"https://api.github.com/repos/wireapp/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-webapp/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-webapp/events","assignees_url":"https://api.github.com/repos/wireapp/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-webapp/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-webapp/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-webapp/merges","archive_url":"https://api.github.com/repos/wireapp/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-webapp/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-webapp/deployments","created_at":"2016-07-21T15:34:05Z","updated_at":"2019-11-20T16:46:02Z","pushed_at":"2019-11-21T10:57:28Z","git_url":"git://github.com/wireapp/wire-webapp.git","ssh_url":"git@github.com:wireapp/wire-webapp.git","clone_url":"https://github.com/wireapp/wire-webapp.git","svn_url":"https://github.com/wireapp/wire-webapp","homepage":"https://app.wire.com","size":47930,"stargazers_count":896,"watchers_count":896,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":112,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":215,"open_issues":112,"watchers":896,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/7758"},"html":{"href":"https://github.com/wireapp/wire-webapp/pull/7758"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/7758"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/7758/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/7758/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/7758/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-webapp/statuses/0c3361c92eefa1c2ce9e6e42b8cde73858530a58"}},"author_association":"MEMBER"}}
|
{
"id": 63881328,
"name": "wireapp/wire-webapp",
"url": "https://api.github.com/repos/wireapp/wire-webapp"
}
|
{
"id": 1122618,
"login": "AndyLnd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1122618?",
"url": "https://api.github.com/users/AndyLnd"
}
|
{
"id": 16047324,
"login": "wireapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16047324?",
"url": "https://api.github.com/orgs/wireapp"
}
| 2019-11-21T11:02:15 |
10915377682
|
{"actor":{"display_login":"AndyLnd"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/comments/344303708","pull_request_review_id":314375069,"id":344303708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDMwMzcwOA==","diff_hunk":"@@ -87,7 +87,7 @@ void PrintHelp(msdk_char *strAppName, const msdk_char *strErrorMessage, ...)\n msdk_printf(MSDK_STRING(\" [-la] - use the look ahead bitrate control algorithm (LA BRC) (by default constant bitrate control method is used)\\n\"));\n msdk_printf(MSDK_STRING(\" for H.264, H.265 encoder. Supported only with -hw option on 4th Generation Intel Core processors. \\n\"));\n msdk_printf(MSDK_STRING(\" if [-icq] option is also enabled simultaneously, then LA_ICQ bitrate control algotithm will be used. \\n\"));\n- msdk_printf(MSDK_STRING(\" [-lad depth] - depth parameter for the LA BRC, the number of frames to be analyzed before encoding. In range [1,100].\\n\"));\n+ msdk_printf(MSDK_STRING(\" [-lad depth] - depth parameter for the LA BRC, the number of frames to be analyzed before encoding. In range [1,100] (0 used for automatic selection).\\n\"));","path":"samples/sample_encode/src/sample_encode.cpp","position":5,"original_position":5,"commit_id":"2bbae8e359805e689b2d6e21bc3ba7977d0f9715","original_commit_id":"2bbae8e359805e689b2d6e21bc3ba7977d0f9715","user":{"login":"dvrogozh","id":7403219,"node_id":"MDQ6VXNlcjc0MDMyMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7403219?v=4","gravatar_id":"","url":"https://api.github.com/users/dvrogozh","html_url":"https://github.com/dvrogozh","followers_url":"https://api.github.com/users/dvrogozh/followers","following_url":"https://api.github.com/users/dvrogozh/following{/other_user}","gists_url":"https://api.github.com/users/dvrogozh/gists{/gist_id}","starred_url":"https://api.github.com/users/dvrogozh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvrogozh/subscriptions","organizations_url":"https://api.github.com/users/dvrogozh/orgs","repos_url":"https://api.github.com/users/dvrogozh/repos","events_url":"https://api.github.com/users/dvrogozh/events{/privacy}","received_events_url":"https://api.github.com/users/dvrogozh/received_events","type":"User","site_admin":false},"body":"`[-lad depth] - depth parameter for the LA BRC, the number of frames to be analyzed before encoding. In range [0,100] (0 - default: auto-select by mediasdk library)`\r\n\r\nValid range is [0,100], 0 just has specific meaning. So, write exactly that. Is 0 default?","created_at":"2019-11-08T18:18:27Z","updated_at":"2019-11-08T18:18:55Z","html_url":"https://github.com/Intel-Media-SDK/MediaSDK/pull/1753#discussion_r344303708","pull_request_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/1753","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/comments/344303708"},"html":{"href":"https://github.com/Intel-Media-SDK/MediaSDK/pull/1753#discussion_r344303708"},"pull_request":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/1753"}}},"pull_request":{"url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/1753","id":336733227,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2NzMzMjI3","html_url":"https://github.com/Intel-Media-SDK/MediaSDK/pull/1753","diff_url":"https://github.com/Intel-Media-SDK/MediaSDK/pull/1753.diff","patch_url":"https://github.com/Intel-Media-SDK/MediaSDK/pull/1753.patch","issue_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/1753","number":1753,"state":"open","locked":false,"title":"samples: Change LADepth checking condition","user":{"login":"pgribov","id":50143375,"node_id":"MDQ6VXNlcjUwMTQzMzc1","avatar_url":"https://avatars0.githubusercontent.com/u/50143375?v=4","gravatar_id":"","url":"https://api.github.com/users/pgribov","html_url":"https://github.com/pgribov","followers_url":"https://api.github.com/users/pgribov/followers","following_url":"https://api.github.com/users/pgribov/following{/other_user}","gists_url":"https://api.github.com/users/pgribov/gists{/gist_id}","starred_url":"https://api.github.com/users/pgribov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgribov/subscriptions","organizations_url":"https://api.github.com/users/pgribov/orgs","repos_url":"https://api.github.com/users/pgribov/repos","events_url":"https://api.github.com/users/pgribov/events{/privacy}","received_events_url":"https://api.github.com/users/pgribov/received_events","type":"User","site_admin":false},"body":"After this PR: https://github.com/Intel-Media-SDK/MediaSDK/pull/1668\r\nsample_encode and sample_multi_transcode check -LADepth 0 and report error.\r\nThere is no need to check 0, it is default value,\r\nin this case encoder will choose the value on his own.","created_at":"2019-11-05T11:34:00Z","updated_at":"2019-11-08T18:18:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f349bf5d26a360aeaf248a4998170fcea4dc4ed","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dmitryermilov","id":19732160,"node_id":"MDQ6VXNlcjE5NzMyMTYw","avatar_url":"https://avatars2.githubusercontent.com/u/19732160?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitryermilov","html_url":"https://github.com/dmitryermilov","followers_url":"https://api.github.com/users/dmitryermilov/followers","following_url":"https://api.github.com/users/dmitryermilov/following{/other_user}","gists_url":"https://api.github.com/users/dmitryermilov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitryermilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitryermilov/subscriptions","organizations_url":"https://api.github.com/users/dmitryermilov/orgs","repos_url":"https://api.github.com/users/dmitryermilov/repos","events_url":"https://api.github.com/users/dmitryermilov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitryermilov/received_events","type":"User","site_admin":false},{"login":"onabiull","id":28653530,"node_id":"MDQ6VXNlcjI4NjUzNTMw","avatar_url":"https://avatars0.githubusercontent.com/u/28653530?v=4","gravatar_id":"","url":"https://api.github.com/users/onabiull","html_url":"https://github.com/onabiull","followers_url":"https://api.github.com/users/onabiull/followers","following_url":"https://api.github.com/users/onabiull/following{/other_user}","gists_url":"https://api.github.com/users/onabiull/gists{/gist_id}","starred_url":"https://api.github.com/users/onabiull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onabiull/subscriptions","organizations_url":"https://api.github.com/users/onabiull/orgs","repos_url":"https://api.github.com/users/onabiull/repos","events_url":"https://api.github.com/users/onabiull/events{/privacy}","received_events_url":"https://api.github.com/users/onabiull/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"MediaSDK-Admin","id":2634406,"node_id":"MDQ6VGVhbTI2MzQ0MDY=","slug":"mediasdk-admin","description":"","privacy":"closed","url":"https://api.github.com/teams/2634406","html_url":"https://github.com/orgs/Intel-Media-SDK/teams/mediasdk-admin","members_url":"https://api.github.com/teams/2634406/members{/member}","repositories_url":"https://api.github.com/teams/2634406/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/1753/commits","review_comments_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/1753/comments","review_comment_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/1753/comments","statuses_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/statuses/2bbae8e359805e689b2d6e21bc3ba7977d0f9715","head":{"label":"pgribov:short_la_la_depth_fix","ref":"short_la_la_depth_fix","sha":"2bbae8e359805e689b2d6e21bc3ba7977d0f9715","user":{"login":"pgribov","id":50143375,"node_id":"MDQ6VXNlcjUwMTQzMzc1","avatar_url":"https://avatars0.githubusercontent.com/u/50143375?v=4","gravatar_id":"","url":"https://api.github.com/users/pgribov","html_url":"https://github.com/pgribov","followers_url":"https://api.github.com/users/pgribov/followers","following_url":"https://api.github.com/users/pgribov/following{/other_user}","gists_url":"https://api.github.com/users/pgribov/gists{/gist_id}","starred_url":"https://api.github.com/users/pgribov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgribov/subscriptions","organizations_url":"https://api.github.com/users/pgribov/orgs","repos_url":"https://api.github.com/users/pgribov/repos","events_url":"https://api.github.com/users/pgribov/events{/privacy}","received_events_url":"https://api.github.com/users/pgribov/received_events","type":"User","site_admin":false},"repo":{"id":185139642,"node_id":"MDEwOlJlcG9zaXRvcnkxODUxMzk2NDI=","name":"MediaSDK","full_name":"pgribov/MediaSDK","private":false,"owner":{"login":"pgribov","id":50143375,"node_id":"MDQ6VXNlcjUwMTQzMzc1","avatar_url":"https://avatars0.githubusercontent.com/u/50143375?v=4","gravatar_id":"","url":"https://api.github.com/users/pgribov","html_url":"https://github.com/pgribov","followers_url":"https://api.github.com/users/pgribov/followers","following_url":"https://api.github.com/users/pgribov/following{/other_user}","gists_url":"https://api.github.com/users/pgribov/gists{/gist_id}","starred_url":"https://api.github.com/users/pgribov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgribov/subscriptions","organizations_url":"https://api.github.com/users/pgribov/orgs","repos_url":"https://api.github.com/users/pgribov/repos","events_url":"https://api.github.com/users/pgribov/events{/privacy}","received_events_url":"https://api.github.com/users/pgribov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pgribov/MediaSDK","description":"The Intel® Media SDK","fork":true,"url":"https://api.github.com/repos/pgribov/MediaSDK","forks_url":"https://api.github.com/repos/pgribov/MediaSDK/forks","keys_url":"https://api.github.com/repos/pgribov/MediaSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgribov/MediaSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgribov/MediaSDK/teams","hooks_url":"https://api.github.com/repos/pgribov/MediaSDK/hooks","issue_events_url":"https://api.github.com/repos/pgribov/MediaSDK/issues/events{/number}","events_url":"https://api.github.com/repos/pgribov/MediaSDK/events","assignees_url":"https://api.github.com/repos/pgribov/MediaSDK/assignees{/user}","branches_url":"https://api.github.com/repos/pgribov/MediaSDK/branches{/branch}","tags_url":"https://api.github.com/repos/pgribov/MediaSDK/tags","blobs_url":"https://api.github.com/repos/pgribov/MediaSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgribov/MediaSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgribov/MediaSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgribov/MediaSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgribov/MediaSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/pgribov/MediaSDK/languages","stargazers_url":"https://api.github.com/repos/pgribov/MediaSDK/stargazers","contributors_url":"https://api.github.com/repos/pgribov/MediaSDK/contributors","subscribers_url":"https://api.github.com/repos/pgribov/MediaSDK/subscribers","subscription_url":"https://api.github.com/repos/pgribov/MediaSDK/subscription","commits_url":"https://api.github.com/repos/pgribov/MediaSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgribov/MediaSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgribov/MediaSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgribov/MediaSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgribov/MediaSDK/contents/{+path}","compare_url":"https://api.github.com/repos/pgribov/MediaSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgribov/MediaSDK/merges","archive_url":"https://api.github.com/repos/pgribov/MediaSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgribov/MediaSDK/downloads","issues_url":"https://api.github.com/repos/pgribov/MediaSDK/issues{/number}","pulls_url":"https://api.github.com/repos/pgribov/MediaSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/pgribov/MediaSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/pgribov/MediaSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgribov/MediaSDK/labels{/name}","releases_url":"https://api.github.com/repos/pgribov/MediaSDK/releases{/id}","deployments_url":"https://api.github.com/repos/pgribov/MediaSDK/deployments","created_at":"2019-05-06T06:50:00Z","updated_at":"2019-07-02T08:59:09Z","pushed_at":"2019-11-08T13:03:37Z","git_url":"git://github.com/pgribov/MediaSDK.git","ssh_url":"git@github.com:pgribov/MediaSDK.git","clone_url":"https://github.com/pgribov/MediaSDK.git","svn_url":"https://github.com/pgribov/MediaSDK","homepage":"http://mediasdk.intel.com","size":34440,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Intel-Media-SDK:master","ref":"master","sha":"631280edcdb1d1ffc3ff84107541f16f36af59e2","user":{"login":"Intel-Media-SDK","id":16081150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDgxMTUw","avatar_url":"https://avatars1.githubusercontent.com/u/16081150?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-Media-SDK","html_url":"https://github.com/Intel-Media-SDK","followers_url":"https://api.github.com/users/Intel-Media-SDK/followers","following_url":"https://api.github.com/users/Intel-Media-SDK/following{/other_user}","gists_url":"https://api.github.com/users/Intel-Media-SDK/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-Media-SDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-Media-SDK/subscriptions","organizations_url":"https://api.github.com/users/Intel-Media-SDK/orgs","repos_url":"https://api.github.com/users/Intel-Media-SDK/repos","events_url":"https://api.github.com/users/Intel-Media-SDK/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-Media-SDK/received_events","type":"Organization","site_admin":false},"repo":{"id":87199173,"node_id":"MDEwOlJlcG9zaXRvcnk4NzE5OTE3Mw==","name":"MediaSDK","full_name":"Intel-Media-SDK/MediaSDK","private":false,"owner":{"login":"Intel-Media-SDK","id":16081150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDgxMTUw","avatar_url":"https://avatars1.githubusercontent.com/u/16081150?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-Media-SDK","html_url":"https://github.com/Intel-Media-SDK","followers_url":"https://api.github.com/users/Intel-Media-SDK/followers","following_url":"https://api.github.com/users/Intel-Media-SDK/following{/other_user}","gists_url":"https://api.github.com/users/Intel-Media-SDK/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-Media-SDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-Media-SDK/subscriptions","organizations_url":"https://api.github.com/users/Intel-Media-SDK/orgs","repos_url":"https://api.github.com/users/Intel-Media-SDK/repos","events_url":"https://api.github.com/users/Intel-Media-SDK/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-Media-SDK/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Intel-Media-SDK/MediaSDK","description":"The Intel® Media SDK","fork":false,"url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK","forks_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/forks","keys_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/teams","hooks_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/hooks","issue_events_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/events{/number}","events_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/events","assignees_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/assignees{/user}","branches_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/branches{/branch}","tags_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/tags","blobs_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/languages","stargazers_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/stargazers","contributors_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/contributors","subscribers_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/subscribers","subscription_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/subscription","commits_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/contents/{+path}","compare_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/merges","archive_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/downloads","issues_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues{/number}","pulls_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/labels{/name}","releases_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/releases{/id}","deployments_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/deployments","created_at":"2017-04-04T14:52:06Z","updated_at":"2019-11-08T09:07:43Z","pushed_at":"2019-11-08T13:14:29Z","git_url":"git://github.com/Intel-Media-SDK/MediaSDK.git","ssh_url":"git@github.com:Intel-Media-SDK/MediaSDK.git","clone_url":"https://github.com/Intel-Media-SDK/MediaSDK.git","svn_url":"https://github.com/Intel-Media-SDK/MediaSDK","homepage":"http://mediasdk.intel.com","size":34491,"stargazers_count":365,"watchers_count":365,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":237,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":115,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":237,"open_issues":115,"watchers":365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/1753"},"html":{"href":"https://github.com/Intel-Media-SDK/MediaSDK/pull/1753"},"issue":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/1753"},"comments":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/1753/comments"},"review_comments":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/1753/comments"},"review_comment":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/1753/commits"},"statuses":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/statuses/2bbae8e359805e689b2d6e21bc3ba7977d0f9715"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 87199173,
"name": "Intel-Media-SDK/MediaSDK",
"url": "https://api.github.com/repos/Intel-Media-SDK/MediaSDK"
}
|
{
"id": 7403219,
"login": "dvrogozh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7403219?",
"url": "https://api.github.com/users/dvrogozh"
}
|
{
"id": 16081150,
"login": "Intel-Media-SDK",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16081150?",
"url": "https://api.github.com/orgs/Intel-Media-SDK"
}
| 2019-11-08T18:18:27 |
10821288848
|
{"actor":{"display_login":"dvrogozh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/zcash/zcash/pulls/comments/263091803","pull_request_review_id":211377353,"id":263091803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzA5MTgwMw==","diff_hunk":"@@ -1444,8 +1445,18 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)\n nTotalCache = std::max(nTotalCache, nMinDbCache << 20); // total cache cannot be less than nMinDbCache\n nTotalCache = std::min(nTotalCache, nMaxDbCache << 20); // total cache cannot be greated than nMaxDbcache\n int64_t nBlockTreeDBCache = nTotalCache / 8;\n- if (nBlockTreeDBCache > (1 << 21) && !GetBoolArg(\"-txindex\", false))\n- nBlockTreeDBCache = (1 << 21); // block tree db cache shouldn't be larger than 2 MiB\n+ if (GetBoolArg(\"-addressindex\", false)) {\n+ if (!GetBoolArg(\"-txindex\", false)) {\n+ return InitError(_(\"-addressindex requires -txindex.\"));\n+ }\n+ // enable 3/4 of the cache if addressindex is enabled\n+ nBlockTreeDBCache = nTotalCache * 3 / 4;\n+\n+ } else {","path":"src/init.cpp","position":21,"original_position":21,"commit_id":"cdd825f3f3f7817188c42e7d59c6614110172472","original_commit_id":"523ac9f4fb6b705d1669a3300446e4787f167c31","user":{"login":"LarryRuane","id":8321330,"node_id":"MDQ6VXNlcjgzMjEzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8321330?v=4","gravatar_id":"","url":"https://api.github.com/users/LarryRuane","html_url":"https://github.com/LarryRuane","followers_url":"https://api.github.com/users/LarryRuane/followers","following_url":"https://api.github.com/users/LarryRuane/following{/other_user}","gists_url":"https://api.github.com/users/LarryRuane/gists{/gist_id}","starred_url":"https://api.github.com/users/LarryRuane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarryRuane/subscriptions","organizations_url":"https://api.github.com/users/LarryRuane/orgs","repos_url":"https://api.github.com/users/LarryRuane/repos","events_url":"https://api.github.com/users/LarryRuane/events{/privacy}","received_events_url":"https://api.github.com/users/LarryRuane/received_events","type":"User","site_admin":false},"body":"Just for future reference, nothing is too much of a nit for me; please always provide them. I love these kinds of improvements.","created_at":"2019-03-06T19:12:24Z","updated_at":"2019-03-06T19:18:22Z","html_url":"https://github.com/zcash/zcash/pull/3837#discussion_r263091803","pull_request_url":"https://api.github.com/repos/zcash/zcash/pulls/3837","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments/263091803"},"html":{"href":"https://github.com/zcash/zcash/pull/3837#discussion_r263091803"},"pull_request":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3837"}},"in_reply_to_id":260451891},"pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/3837","id":252791987,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyNzkxOTg3","html_url":"https://github.com/zcash/zcash/pull/3837","diff_url":"https://github.com/zcash/zcash/pull/3837.diff","patch_url":"https://github.com/zcash/zcash/pull/3837.patch","issue_url":"https://api.github.com/repos/zcash/zcash/issues/3837","number":3837,"state":"open","locked":false,"title":"add AddressIndex changes needed for bitcore block explorer","user":{"login":"LarryRuane","id":8321330,"node_id":"MDQ6VXNlcjgzMjEzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8321330?v=4","gravatar_id":"","url":"https://api.github.com/users/LarryRuane","html_url":"https://github.com/LarryRuane","followers_url":"https://api.github.com/users/LarryRuane/followers","following_url":"https://api.github.com/users/LarryRuane/following{/other_user}","gists_url":"https://api.github.com/users/LarryRuane/gists{/gist_id}","starred_url":"https://api.github.com/users/LarryRuane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarryRuane/subscriptions","organizations_url":"https://api.github.com/users/LarryRuane/orgs","repos_url":"https://api.github.com/users/LarryRuane/repos","events_url":"https://api.github.com/users/LarryRuane/events{/privacy}","received_events_url":"https://api.github.com/users/LarryRuane/received_events","type":"User","site_admin":false},"body":"Addresses #3708, note there are no tests yet (will come later with RPC interfaces).","created_at":"2019-02-13T17:59:10Z","updated_at":"2019-03-06T19:18:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca290cf2ddf64c80105d3ca69d16f5a9a2981432","assignee":{"login":"LarryRuane","id":8321330,"node_id":"MDQ6VXNlcjgzMjEzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8321330?v=4","gravatar_id":"","url":"https://api.github.com/users/LarryRuane","html_url":"https://github.com/LarryRuane","followers_url":"https://api.github.com/users/LarryRuane/followers","following_url":"https://api.github.com/users/LarryRuane/following{/other_user}","gists_url":"https://api.github.com/users/LarryRuane/gists{/gist_id}","starred_url":"https://api.github.com/users/LarryRuane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarryRuane/subscriptions","organizations_url":"https://api.github.com/users/LarryRuane/orgs","repos_url":"https://api.github.com/users/LarryRuane/repos","events_url":"https://api.github.com/users/LarryRuane/events{/privacy}","received_events_url":"https://api.github.com/users/LarryRuane/received_events","type":"User","site_admin":false},"assignees":[{"login":"LarryRuane","id":8321330,"node_id":"MDQ6VXNlcjgzMjEzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8321330?v=4","gravatar_id":"","url":"https://api.github.com/users/LarryRuane","html_url":"https://github.com/LarryRuane","followers_url":"https://api.github.com/users/LarryRuane/followers","following_url":"https://api.github.com/users/LarryRuane/following{/other_user}","gists_url":"https://api.github.com/users/LarryRuane/gists{/gist_id}","starred_url":"https://api.github.com/users/LarryRuane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarryRuane/subscriptions","organizations_url":"https://api.github.com/users/LarryRuane/orgs","repos_url":"https://api.github.com/users/LarryRuane/repos","events_url":"https://api.github.com/users/LarryRuane/events{/privacy}","received_events_url":"https://api.github.com/users/LarryRuane/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"daira","id":643204,"node_id":"MDQ6VXNlcjY0MzIwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/643204?v=4","gravatar_id":"","url":"https://api.github.com/users/daira","html_url":"https://github.com/daira","followers_url":"https://api.github.com/users/daira/followers","following_url":"https://api.github.com/users/daira/following{/other_user}","gists_url":"https://api.github.com/users/daira/gists{/gist_id}","starred_url":"https://api.github.com/users/daira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daira/subscriptions","organizations_url":"https://api.github.com/users/daira/orgs","repos_url":"https://api.github.com/users/daira/repos","events_url":"https://api.github.com/users/daira/events{/privacy}","received_events_url":"https://api.github.com/users/daira/received_events","type":"User","site_admin":false},{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},{"login":"Eirik0","id":6133620,"node_id":"MDQ6VXNlcjYxMzM2MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/6133620?v=4","gravatar_id":"","url":"https://api.github.com/users/Eirik0","html_url":"https://github.com/Eirik0","followers_url":"https://api.github.com/users/Eirik0/followers","following_url":"https://api.github.com/users/Eirik0/following{/other_user}","gists_url":"https://api.github.com/users/Eirik0/gists{/gist_id}","starred_url":"https://api.github.com/users/Eirik0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eirik0/subscriptions","organizations_url":"https://api.github.com/users/Eirik0/orgs","repos_url":"https://api.github.com/users/Eirik0/repos","events_url":"https://api.github.com/users/Eirik0/events{/privacy}","received_events_url":"https://api.github.com/users/Eirik0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1260147401,"node_id":"MDU6TGFiZWwxMjYwMTQ3NDAx","url":"https://api.github.com/repos/zcash/zcash/labels/explorer","name":"explorer","color":"f95939","default":false},{"id":266407753,"node_id":"MDU6TGFiZWwyNjY0MDc3NTM=","url":"https://api.github.com/repos/zcash/zcash/labels/operations","name":"operations","color":"5319e7","default":false},{"id":163608996,"node_id":"MDU6TGFiZWwxNjM2MDg5OTY=","url":"https://api.github.com/repos/zcash/zcash/labels/packaging","name":"packaging","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zcash/zcash/pulls/3837/commits","review_comments_url":"https://api.github.com/repos/zcash/zcash/pulls/3837/comments","review_comment_url":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/3837/comments","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/cdd825f3f3f7817188c42e7d59c6614110172472","head":{"label":"LarryRuane:3708-addressindex","ref":"3708-addressindex","sha":"cdd825f3f3f7817188c42e7d59c6614110172472","user":{"login":"LarryRuane","id":8321330,"node_id":"MDQ6VXNlcjgzMjEzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8321330?v=4","gravatar_id":"","url":"https://api.github.com/users/LarryRuane","html_url":"https://github.com/LarryRuane","followers_url":"https://api.github.com/users/LarryRuane/followers","following_url":"https://api.github.com/users/LarryRuane/following{/other_user}","gists_url":"https://api.github.com/users/LarryRuane/gists{/gist_id}","starred_url":"https://api.github.com/users/LarryRuane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarryRuane/subscriptions","organizations_url":"https://api.github.com/users/LarryRuane/orgs","repos_url":"https://api.github.com/users/LarryRuane/repos","events_url":"https://api.github.com/users/LarryRuane/events{/privacy}","received_events_url":"https://api.github.com/users/LarryRuane/received_events","type":"User","site_admin":false},"repo":{"id":134631446,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2MzE0NDY=","name":"zcash","full_name":"LarryRuane/zcash","private":false,"owner":{"login":"LarryRuane","id":8321330,"node_id":"MDQ6VXNlcjgzMjEzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8321330?v=4","gravatar_id":"","url":"https://api.github.com/users/LarryRuane","html_url":"https://github.com/LarryRuane","followers_url":"https://api.github.com/users/LarryRuane/followers","following_url":"https://api.github.com/users/LarryRuane/following{/other_user}","gists_url":"https://api.github.com/users/LarryRuane/gists{/gist_id}","starred_url":"https://api.github.com/users/LarryRuane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarryRuane/subscriptions","organizations_url":"https://api.github.com/users/LarryRuane/orgs","repos_url":"https://api.github.com/users/LarryRuane/repos","events_url":"https://api.github.com/users/LarryRuane/events{/privacy}","received_events_url":"https://api.github.com/users/LarryRuane/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LarryRuane/zcash","description":"Zcash - Internet Money","fork":true,"url":"https://api.github.com/repos/LarryRuane/zcash","forks_url":"https://api.github.com/repos/LarryRuane/zcash/forks","keys_url":"https://api.github.com/repos/LarryRuane/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LarryRuane/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LarryRuane/zcash/teams","hooks_url":"https://api.github.com/repos/LarryRuane/zcash/hooks","issue_events_url":"https://api.github.com/repos/LarryRuane/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/LarryRuane/zcash/events","assignees_url":"https://api.github.com/repos/LarryRuane/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/LarryRuane/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/LarryRuane/zcash/tags","blobs_url":"https://api.github.com/repos/LarryRuane/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LarryRuane/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LarryRuane/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/LarryRuane/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LarryRuane/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/LarryRuane/zcash/languages","stargazers_url":"https://api.github.com/repos/LarryRuane/zcash/stargazers","contributors_url":"https://api.github.com/repos/LarryRuane/zcash/contributors","subscribers_url":"https://api.github.com/repos/LarryRuane/zcash/subscribers","subscription_url":"https://api.github.com/repos/LarryRuane/zcash/subscription","commits_url":"https://api.github.com/repos/LarryRuane/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/LarryRuane/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/LarryRuane/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/LarryRuane/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/LarryRuane/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/LarryRuane/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LarryRuane/zcash/merges","archive_url":"https://api.github.com/repos/LarryRuane/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LarryRuane/zcash/downloads","issues_url":"https://api.github.com/repos/LarryRuane/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/LarryRuane/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/LarryRuane/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/LarryRuane/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LarryRuane/zcash/labels{/name}","releases_url":"https://api.github.com/repos/LarryRuane/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/LarryRuane/zcash/deployments","created_at":"2018-05-23T22:21:05Z","updated_at":"2019-01-07T16:20:54Z","pushed_at":"2019-03-05T16:33:55Z","git_url":"git://github.com/LarryRuane/zcash.git","ssh_url":"git@github.com:LarryRuane/zcash.git","clone_url":"https://github.com/LarryRuane/zcash.git","svn_url":"https://github.com/LarryRuane/zcash","homepage":"https://z.cash/","size":59773,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zcash:master","ref":"master","sha":"92cd76fcba8f284694f213547293a1cfc2c0369d","user":{"login":"zcash","id":16122764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTIyNzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"repo":{"id":26987049,"node_id":"MDEwOlJlcG9zaXRvcnkyNjk4NzA0OQ==","name":"zcash","full_name":"zcash/zcash","private":false,"owner":{"login":"zcash","id":16122764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTIyNzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zcash/zcash","description":"Zcash - Internet Money","fork":false,"url":"https://api.github.com/repos/zcash/zcash","forks_url":"https://api.github.com/repos/zcash/zcash/forks","keys_url":"https://api.github.com/repos/zcash/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcash/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcash/zcash/teams","hooks_url":"https://api.github.com/repos/zcash/zcash/hooks","issue_events_url":"https://api.github.com/repos/zcash/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/zcash/zcash/events","assignees_url":"https://api.github.com/repos/zcash/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/zcash/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/zcash/zcash/tags","blobs_url":"https://api.github.com/repos/zcash/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcash/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcash/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcash/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/zcash/zcash/languages","stargazers_url":"https://api.github.com/repos/zcash/zcash/stargazers","contributors_url":"https://api.github.com/repos/zcash/zcash/contributors","subscribers_url":"https://api.github.com/repos/zcash/zcash/subscribers","subscription_url":"https://api.github.com/repos/zcash/zcash/subscription","commits_url":"https://api.github.com/repos/zcash/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcash/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcash/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcash/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcash/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/zcash/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcash/zcash/merges","archive_url":"https://api.github.com/repos/zcash/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcash/zcash/downloads","issues_url":"https://api.github.com/repos/zcash/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/zcash/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/zcash/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/zcash/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcash/zcash/labels{/name}","releases_url":"https://api.github.com/repos/zcash/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/zcash/zcash/deployments","created_at":"2014-11-22T03:13:10Z","updated_at":"2019-03-06T15:28:33Z","pushed_at":"2019-03-05T21:04:44Z","git_url":"git://github.com/zcash/zcash.git","ssh_url":"git@github.com:zcash/zcash.git","clone_url":"https://github.com/zcash/zcash.git","svn_url":"https://github.com/zcash/zcash","homepage":"https://z.cash/","size":66369,"stargazers_count":3981,"watchers_count":3981,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1446,"mirror_url":null,"archived":false,"open_issues_count":901,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1446,"open_issues":901,"watchers":3981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3837"},"html":{"href":"https://github.com/zcash/zcash/pull/3837"},"issue":{"href":"https://api.github.com/repos/zcash/zcash/issues/3837"},"comments":{"href":"https://api.github.com/repos/zcash/zcash/issues/3837/comments"},"review_comments":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3837/comments"},"review_comment":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3837/commits"},"statuses":{"href":"https://api.github.com/repos/zcash/zcash/statuses/cdd825f3f3f7817188c42e7d59c6614110172472"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 26987049,
"name": "zcash/zcash",
"url": "https://api.github.com/repos/zcash/zcash"
}
|
{
"id": 8321330,
"login": "LarryRuane",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8321330?",
"url": "https://api.github.com/users/LarryRuane"
}
|
{
"id": 16122764,
"login": "zcash",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16122764?",
"url": "https://api.github.com/orgs/zcash"
}
| 2019-03-06T19:12:24 |
9193270609
|
{"actor":{"display_login":"LarryRuane"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/comments/336784648","pull_request_review_id":304265191,"id":336784648,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjc4NDY0OA==","diff_hunk":"@@ -0,0 +1,47 @@\n+/*\n+ * Benchmarks contributed by Divyesh Unadkat[1,2], Supratik Chakraborty[1], Ashutosh Gupta[1]\n+ * [1] Indian Institute of Technology Bombay, Mumbai\n+ * [2] TCS Innovation labs, Pune\n+ *\n+ */\n+\n+extern void __VERIFIER_error() __attribute__ ((__noreturn__));\n+extern void __VERIFIER_assume(int);\n+void __VERIFIER_assert(int cond) { if(!(cond)) { ERROR: __VERIFIER_error(); } }\n+extern int __VERIFIER_nondet_int(void);\n+\n+int N;\n+\n+int main()\n+{\n+\tN = __VERIFIER_nondet_int();\n+\tint i;\n+\tint sum[1];\n+\tint a[N];","path":"c/array-fpi/brs1.c","position":22,"original_position":20,"commit_id":"bfcbff74be8c8b2af122a4154b0716591a03f987","original_commit_id":"af599bf73ea1942dd791e44b96cc1ee76d3d4793","user":{"login":"PhilippWendler","id":2545335,"node_id":"MDQ6VXNlcjI1NDUzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2545335?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilippWendler","html_url":"https://github.com/PhilippWendler","followers_url":"https://api.github.com/users/PhilippWendler/followers","following_url":"https://api.github.com/users/PhilippWendler/following{/other_user}","gists_url":"https://api.github.com/users/PhilippWendler/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilippWendler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilippWendler/subscriptions","organizations_url":"https://api.github.com/users/PhilippWendler/orgs","repos_url":"https://api.github.com/users/PhilippWendler/repos","events_url":"https://api.github.com/users/PhilippWendler/events{/privacy}","received_events_url":"https://api.github.com/users/PhilippWendler/received_events","type":"User","site_admin":false},"body":"> @PhilippWendler I have modified the programs such that they won't create arrays of negative or zero size. This should help the tools that try to execute the programs for testing and verification. For the second point, the sizes are parametric and hence not necessarily large.\r\n\r\nBut they can be large and a verifier needs to handle that.\r\n\r\n> Arrays with fixed size would defeat the purpose here as the tools must be able to verify the program irrespective of its size.\r\n\r\nThe array size could be bounded but still nondeterministic.\r\n\r\n> I would like to keep them array manipulating rather than heap manipulating.\r\n\r\nThen this needs to be discussed with those people who argued in favor of forbidding such programs in the previous years (cf. the issues I linked). For me both is fine.","created_at":"2019-10-20T15:56:07Z","updated_at":"2019-10-20T15:56:07Z","html_url":"https://github.com/sosy-lab/sv-benchmarks/pull/824#discussion_r336784648","pull_request_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/824","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/comments/336784648"},"html":{"href":"https://github.com/sosy-lab/sv-benchmarks/pull/824#discussion_r336784648"},"pull_request":{"href":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/824"}},"in_reply_to_id":336384161},"pull_request":{"url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/824","id":326759676,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2NzU5Njc2","html_url":"https://github.com/sosy-lab/sv-benchmarks/pull/824","diff_url":"https://github.com/sosy-lab/sv-benchmarks/pull/824.diff","patch_url":"https://github.com/sosy-lab/sv-benchmarks/pull/824.patch","issue_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/824","number":824,"state":"open","locked":false,"title":"Added new array reach-safety benchmarks","user":{"login":"divyeshunadkat","id":16955764,"node_id":"MDQ6VXNlcjE2OTU1NzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16955764?v=4","gravatar_id":"","url":"https://api.github.com/users/divyeshunadkat","html_url":"https://github.com/divyeshunadkat","followers_url":"https://api.github.com/users/divyeshunadkat/followers","following_url":"https://api.github.com/users/divyeshunadkat/following{/other_user}","gists_url":"https://api.github.com/users/divyeshunadkat/gists{/gist_id}","starred_url":"https://api.github.com/users/divyeshunadkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divyeshunadkat/subscriptions","organizations_url":"https://api.github.com/users/divyeshunadkat/orgs","repos_url":"https://api.github.com/users/divyeshunadkat/repos","events_url":"https://api.github.com/users/divyeshunadkat/events{/privacy}","received_events_url":"https://api.github.com/users/divyeshunadkat/received_events","type":"User","site_admin":false},"body":"Adding new array reach-safety benchmarks\r\n\r\nBenchmarks contributed by Divyesh Unadkat[1,2], Supratik Chakraborty[1], Ashutosh Gupta[1]\r\n[1] Indian Institute of Technology Bombay, Mumbai\r\n[2] TCS Innovation labs, Pune\r\n\r\n<!--\r\n Please describe your PR as usual.\r\n\r\n For submission of new verification tasks,\r\n keep the following checklist and make sure that all items are fullfilled.\r\n For other PRs, just remove it.\r\n-->\r\n\r\n- [x] programs added to new and [appropriately named](https://github.com/sosy-lab/sv-benchmarks/blob/master/CONTRIBUTING.md#directory-structure-and-names) directory\r\n- [x] license present and [acceptable](https://github.com/sosy-lab/sv-benchmarks/blob/master/CONTRIBUTING.md#license) (either in separate file or as comment at beginning of program)\r\n- [x] [contributed-by](https://github.com/sosy-lab/sv-benchmarks/blob/master/CONTRIBUTING.md#origin-description-and-attribution) present (either in README file or as comment at beginning of program)\r\n\r\n- [x] programs added to a `.set` file of an existing category, or new sub-category established (if justified)\r\n- [x] intended property matches the corresponding `.prp` file\r\n- [x] programs and expected answer added to a `.yml` file according to [task definitions](https://github.com/sosy-lab/sv-benchmarks#task-definitions)\r\n\r\n<!-- For C programs: -->\r\n- [x] [architecture](https://github.com/sosy-lab/sv-benchmarks/blob/master/CONTRIBUTING.md#architecture) (32 bit vs. 64 bit) matches the corresponding `.cfg` file\r\n- [x] original sources present\r\n- [ ] [preprocessed](https://github.com/sosy-lab/sv-benchmarks/blob/master/CONTRIBUTING.md#preprocessing) files present\r\n- [ ] preprocessed files generated with correct architecture\r\n- [x] [Makefile](https://github.com/sosy-lab/sv-benchmarks/blob/master/CONTRIBUTING.md#compile-checks) added with correct content and without overly broad suppression of warnings\r\n","created_at":"2019-10-10T14:13:41Z","updated_at":"2019-10-20T15:56:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cf1e2659ec0323a7d27ce6dbe8df68c7c4ac75e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"PhilippWendler","id":2545335,"node_id":"MDQ6VXNlcjI1NDUzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2545335?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilippWendler","html_url":"https://github.com/PhilippWendler","followers_url":"https://api.github.com/users/PhilippWendler/followers","following_url":"https://api.github.com/users/PhilippWendler/following{/other_user}","gists_url":"https://api.github.com/users/PhilippWendler/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilippWendler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilippWendler/subscriptions","organizations_url":"https://api.github.com/users/PhilippWendler/orgs","repos_url":"https://api.github.com/users/PhilippWendler/repos","events_url":"https://api.github.com/users/PhilippWendler/events{/privacy}","received_events_url":"https://api.github.com/users/PhilippWendler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1618590365,"node_id":"MDU6TGFiZWwxNjE4NTkwMzY1","url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/labels/C","name":"C","color":"b790ed","default":false},{"id":1618592221,"node_id":"MDU6TGFiZWwxNjE4NTkyMjIx","url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/labels/for%20verification","name":"for verification","color":"5319e7","default":false},{"id":472360169,"node_id":"MDU6TGFiZWw0NzIzNjAxNjk=","url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/labels/new%20benchmarks","name":"new benchmarks","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/824/commits","review_comments_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/824/comments","review_comment_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/824/comments","statuses_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/statuses/bfcbff74be8c8b2af122a4154b0716591a03f987","head":{"label":"divyeshunadkat:master","ref":"master","sha":"bfcbff74be8c8b2af122a4154b0716591a03f987","user":{"login":"divyeshunadkat","id":16955764,"node_id":"MDQ6VXNlcjE2OTU1NzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16955764?v=4","gravatar_id":"","url":"https://api.github.com/users/divyeshunadkat","html_url":"https://github.com/divyeshunadkat","followers_url":"https://api.github.com/users/divyeshunadkat/followers","following_url":"https://api.github.com/users/divyeshunadkat/following{/other_user}","gists_url":"https://api.github.com/users/divyeshunadkat/gists{/gist_id}","starred_url":"https://api.github.com/users/divyeshunadkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divyeshunadkat/subscriptions","organizations_url":"https://api.github.com/users/divyeshunadkat/orgs","repos_url":"https://api.github.com/users/divyeshunadkat/repos","events_url":"https://api.github.com/users/divyeshunadkat/events{/privacy}","received_events_url":"https://api.github.com/users/divyeshunadkat/received_events","type":"User","site_admin":false},"repo":{"id":214123257,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQxMjMyNTc=","name":"sv-benchmarks","full_name":"divyeshunadkat/sv-benchmarks","private":false,"owner":{"login":"divyeshunadkat","id":16955764,"node_id":"MDQ6VXNlcjE2OTU1NzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16955764?v=4","gravatar_id":"","url":"https://api.github.com/users/divyeshunadkat","html_url":"https://github.com/divyeshunadkat","followers_url":"https://api.github.com/users/divyeshunadkat/followers","following_url":"https://api.github.com/users/divyeshunadkat/following{/other_user}","gists_url":"https://api.github.com/users/divyeshunadkat/gists{/gist_id}","starred_url":"https://api.github.com/users/divyeshunadkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divyeshunadkat/subscriptions","organizations_url":"https://api.github.com/users/divyeshunadkat/orgs","repos_url":"https://api.github.com/users/divyeshunadkat/repos","events_url":"https://api.github.com/users/divyeshunadkat/events{/privacy}","received_events_url":"https://api.github.com/users/divyeshunadkat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/divyeshunadkat/sv-benchmarks","description":"Collection of Verification Tasks","fork":true,"url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks","forks_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/forks","keys_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/teams","hooks_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/hooks","issue_events_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/events","assignees_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/tags","blobs_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/languages","stargazers_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/stargazers","contributors_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/contributors","subscribers_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/subscribers","subscription_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/subscription","commits_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/merges","archive_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/downloads","issues_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/labels{/name}","releases_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/divyeshunadkat/sv-benchmarks/deployments","created_at":"2019-10-10T08:04:19Z","updated_at":"2019-10-20T08:40:03Z","pushed_at":"2019-10-20T08:40:01Z","git_url":"git://github.com/divyeshunadkat/sv-benchmarks.git","ssh_url":"git@github.com:divyeshunadkat/sv-benchmarks.git","clone_url":"https://github.com/divyeshunadkat/sv-benchmarks.git","svn_url":"https://github.com/divyeshunadkat/sv-benchmarks","homepage":"","size":1342306,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sosy-lab:master","ref":"master","sha":"65609f28c95ecafc3c9dcec644ffb5d2607b3831","user":{"login":"sosy-lab","id":16129993,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTI5OTkz","avatar_url":"https://avatars0.githubusercontent.com/u/16129993?v=4","gravatar_id":"","url":"https://api.github.com/users/sosy-lab","html_url":"https://github.com/sosy-lab","followers_url":"https://api.github.com/users/sosy-lab/followers","following_url":"https://api.github.com/users/sosy-lab/following{/other_user}","gists_url":"https://api.github.com/users/sosy-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/sosy-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosy-lab/subscriptions","organizations_url":"https://api.github.com/users/sosy-lab/orgs","repos_url":"https://api.github.com/users/sosy-lab/repos","events_url":"https://api.github.com/users/sosy-lab/events{/privacy}","received_events_url":"https://api.github.com/users/sosy-lab/received_events","type":"Organization","site_admin":false},"repo":{"id":36810422,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgxMDQyMg==","name":"sv-benchmarks","full_name":"sosy-lab/sv-benchmarks","private":false,"owner":{"login":"sosy-lab","id":16129993,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTI5OTkz","avatar_url":"https://avatars0.githubusercontent.com/u/16129993?v=4","gravatar_id":"","url":"https://api.github.com/users/sosy-lab","html_url":"https://github.com/sosy-lab","followers_url":"https://api.github.com/users/sosy-lab/followers","following_url":"https://api.github.com/users/sosy-lab/following{/other_user}","gists_url":"https://api.github.com/users/sosy-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/sosy-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosy-lab/subscriptions","organizations_url":"https://api.github.com/users/sosy-lab/orgs","repos_url":"https://api.github.com/users/sosy-lab/repos","events_url":"https://api.github.com/users/sosy-lab/events{/privacy}","received_events_url":"https://api.github.com/users/sosy-lab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sosy-lab/sv-benchmarks","description":"Collection of Verification Tasks","fork":false,"url":"https://api.github.com/repos/sosy-lab/sv-benchmarks","forks_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/forks","keys_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/teams","hooks_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/hooks","issue_events_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/events","assignees_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/tags","blobs_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/languages","stargazers_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/stargazers","contributors_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/contributors","subscribers_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/subscribers","subscription_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/subscription","commits_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/merges","archive_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/downloads","issues_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/labels{/name}","releases_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/sosy-lab/sv-benchmarks/deployments","created_at":"2015-06-03T14:51:22Z","updated_at":"2019-10-19T18:13:08Z","pushed_at":"2019-10-20T14:44:14Z","git_url":"git://github.com/sosy-lab/sv-benchmarks.git","ssh_url":"git@github.com:sosy-lab/sv-benchmarks.git","clone_url":"https://github.com/sosy-lab/sv-benchmarks.git","svn_url":"https://github.com/sosy-lab/sv-benchmarks","homepage":"","size":1342184,"stargazers_count":109,"watchers_count":109,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":64,"license":null,"forks":124,"open_issues":64,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/824"},"html":{"href":"https://github.com/sosy-lab/sv-benchmarks/pull/824"},"issue":{"href":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/824"},"comments":{"href":"https://api.github.com/repos/sosy-lab/sv-benchmarks/issues/824/comments"},"review_comments":{"href":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/824/comments"},"review_comment":{"href":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sosy-lab/sv-benchmarks/pulls/824/commits"},"statuses":{"href":"https://api.github.com/repos/sosy-lab/sv-benchmarks/statuses/bfcbff74be8c8b2af122a4154b0716591a03f987"}},"author_association":"NONE"}}
|
{
"id": 36810422,
"name": "sosy-lab/sv-benchmarks",
"url": "https://api.github.com/repos/sosy-lab/sv-benchmarks"
}
|
{
"id": 2545335,
"login": "PhilippWendler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2545335?",
"url": "https://api.github.com/users/PhilippWendler"
}
|
{
"id": 16129993,
"login": "sosy-lab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16129993?",
"url": "https://api.github.com/orgs/sosy-lab"
}
| 2019-10-20T15:56:07 |
10670731882
|
{"actor":{"display_login":"PhilippWendler"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/285755997","pull_request_review_id":239676797,"id":285755997,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTc1NTk5Nw==","diff_hunk":"@@ -92,8 +92,9 @@ public synchronized void heartbeat() throws InterruptedException {\n mContext.getClientContext().getPathConfHash());\n if (isClusterConfUpdated || isPathConfUpdated) {\n try {\n- mContext.reinit(isClusterConfUpdated, isPathConfUpdated);\n- mException = null;\n+ if (mContext.reinit(isClusterConfUpdated, isPathConfUpdated)) {\n+ mException = null;\n+ }","path":"core/client/fs/src/main/java/alluxio/client/file/ConfigHashSync.java","position":33,"original_position":33,"commit_id":"55c3c533211df96189363f69b7d5b0c9966d44f4","original_commit_id":"55c3c533211df96189363f69b7d5b0c9966d44f4","user":{"login":"ggezer","id":4190144,"node_id":"MDQ6VXNlcjQxOTAxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4190144?v=4","gravatar_id":"","url":"https://api.github.com/users/ggezer","html_url":"https://github.com/ggezer","followers_url":"https://api.github.com/users/ggezer/followers","following_url":"https://api.github.com/users/ggezer/following{/other_user}","gists_url":"https://api.github.com/users/ggezer/gists{/gist_id}","starred_url":"https://api.github.com/users/ggezer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggezer/subscriptions","organizations_url":"https://api.github.com/users/ggezer/orgs","repos_url":"https://api.github.com/users/ggezer/repos","events_url":"https://api.github.com/users/ggezer/events{/privacy}","received_events_url":"https://api.github.com/users/ggezer/received_events","type":"User","site_admin":false},"body":"Some warning would be useful if not synced. Basically the same message as in the deleted TimeoutException section.","created_at":"2019-05-20T20:29:17Z","updated_at":"2019-05-20T20:42:40Z","html_url":"https://github.com/Alluxio/alluxio/pull/9106#discussion_r285755997","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/9106","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/285755997"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/9106#discussion_r285755997"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/9106"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/9106","id":280034175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwMDM0MTc1","html_url":"https://github.com/Alluxio/alluxio/pull/9106","diff_url":"https://github.com/Alluxio/alluxio/pull/9106.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/9106.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/9106","number":9106,"state":"open","locked":false,"title":"Replace lock with atomic counter in FileSystemContextReinitializer","user":{"login":"cheng-chang","id":3663941,"node_id":"MDQ6VXNlcjM2NjM5NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/3663941?v=4","gravatar_id":"","url":"https://api.github.com/users/cheng-chang","html_url":"https://github.com/cheng-chang","followers_url":"https://api.github.com/users/cheng-chang/followers","following_url":"https://api.github.com/users/cheng-chang/following{/other_user}","gists_url":"https://api.github.com/users/cheng-chang/gists{/gist_id}","starred_url":"https://api.github.com/users/cheng-chang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheng-chang/subscriptions","organizations_url":"https://api.github.com/users/cheng-chang/orgs","repos_url":"https://api.github.com/users/cheng-chang/repos","events_url":"https://api.github.com/users/cheng-chang/events{/privacy}","received_events_url":"https://api.github.com/users/cheng-chang/received_events","type":"User","site_admin":false},"body":"Previously, lock is used. But in FileInStream and FileOutStream, the lock may be held in one thread during construction and unlocked in another thread during close(), this will cause IllegalMonitorStateException.\r\n\r\nThis is observed when testing Alluxio with Presto.","created_at":"2019-05-17T21:12:27Z","updated_at":"2019-05-20T20:42:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8da72fbf34d6e00fdb3c68a8810b5116065f3141","assignee":{"login":"calvinjia","id":2223813,"node_id":"MDQ6VXNlcjIyMjM4MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2223813?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"assignees":[{"login":"calvinjia","id":2223813,"node_id":"MDQ6VXNlcjIyMjM4MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2223813?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/9106/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/9106/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/9106/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/55c3c533211df96189363f69b7d5b0c9966d44f4","head":{"label":"cheng-chang:conf-prop-fix","ref":"conf-prop-fix","sha":"55c3c533211df96189363f69b7d5b0c9966d44f4","user":{"login":"cheng-chang","id":3663941,"node_id":"MDQ6VXNlcjM2NjM5NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/3663941?v=4","gravatar_id":"","url":"https://api.github.com/users/cheng-chang","html_url":"https://github.com/cheng-chang","followers_url":"https://api.github.com/users/cheng-chang/followers","following_url":"https://api.github.com/users/cheng-chang/following{/other_user}","gists_url":"https://api.github.com/users/cheng-chang/gists{/gist_id}","starred_url":"https://api.github.com/users/cheng-chang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheng-chang/subscriptions","organizations_url":"https://api.github.com/users/cheng-chang/orgs","repos_url":"https://api.github.com/users/cheng-chang/repos","events_url":"https://api.github.com/users/cheng-chang/events{/privacy}","received_events_url":"https://api.github.com/users/cheng-chang/received_events","type":"User","site_admin":false},"repo":{"id":173817988,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM4MTc5ODg=","name":"alluxio","full_name":"cheng-chang/alluxio","private":false,"owner":{"login":"cheng-chang","id":3663941,"node_id":"MDQ6VXNlcjM2NjM5NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/3663941?v=4","gravatar_id":"","url":"https://api.github.com/users/cheng-chang","html_url":"https://github.com/cheng-chang","followers_url":"https://api.github.com/users/cheng-chang/followers","following_url":"https://api.github.com/users/cheng-chang/following{/other_user}","gists_url":"https://api.github.com/users/cheng-chang/gists{/gist_id}","starred_url":"https://api.github.com/users/cheng-chang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheng-chang/subscriptions","organizations_url":"https://api.github.com/users/cheng-chang/orgs","repos_url":"https://api.github.com/users/cheng-chang/repos","events_url":"https://api.github.com/users/cheng-chang/events{/privacy}","received_events_url":"https://api.github.com/users/cheng-chang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cheng-chang/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":true,"url":"https://api.github.com/repos/cheng-chang/alluxio","forks_url":"https://api.github.com/repos/cheng-chang/alluxio/forks","keys_url":"https://api.github.com/repos/cheng-chang/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cheng-chang/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cheng-chang/alluxio/teams","hooks_url":"https://api.github.com/repos/cheng-chang/alluxio/hooks","issue_events_url":"https://api.github.com/repos/cheng-chang/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/cheng-chang/alluxio/events","assignees_url":"https://api.github.com/repos/cheng-chang/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/cheng-chang/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/cheng-chang/alluxio/tags","blobs_url":"https://api.github.com/repos/cheng-chang/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cheng-chang/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cheng-chang/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/cheng-chang/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cheng-chang/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/cheng-chang/alluxio/languages","stargazers_url":"https://api.github.com/repos/cheng-chang/alluxio/stargazers","contributors_url":"https://api.github.com/repos/cheng-chang/alluxio/contributors","subscribers_url":"https://api.github.com/repos/cheng-chang/alluxio/subscribers","subscription_url":"https://api.github.com/repos/cheng-chang/alluxio/subscription","commits_url":"https://api.github.com/repos/cheng-chang/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/cheng-chang/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/cheng-chang/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/cheng-chang/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/cheng-chang/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/cheng-chang/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cheng-chang/alluxio/merges","archive_url":"https://api.github.com/repos/cheng-chang/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cheng-chang/alluxio/downloads","issues_url":"https://api.github.com/repos/cheng-chang/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/cheng-chang/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/cheng-chang/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/cheng-chang/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cheng-chang/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/cheng-chang/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/cheng-chang/alluxio/deployments","created_at":"2019-03-04T20:41:07Z","updated_at":"2019-03-04T20:41:18Z","pushed_at":"2019-05-20T20:34:54Z","git_url":"git://github.com/cheng-chang/alluxio.git","ssh_url":"git@github.com:cheng-chang/alluxio.git","clone_url":"https://github.com/cheng-chang/alluxio.git","svn_url":"https://github.com/cheng-chang/alluxio","homepage":"http://www.alluxio.org/","size":112305,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"43012313e377b2c24b47e8a3019a6dbd108991a6","user":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc2OTU0","name":"alluxio","full_name":"Alluxio/alluxio","private":false,"owner":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, data orchestration for analytics and machine learning in the cloud","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2019-05-20T19:59:48Z","pushed_at":"2019-05-20T20:35:01Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"https://www.alluxio.io","size":112238,"stargazers_count":4131,"watchers_count":4131,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2207,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":108,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2207,"open_issues":108,"watchers":4131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/9106"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/9106"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/9106"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/9106/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/9106/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/9106/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/55c3c533211df96189363f69b7d5b0c9966d44f4"}},"author_association":"COLLABORATOR"}}
|
{
"id": 7276954,
"name": "Alluxio/alluxio",
"url": "https://api.github.com/repos/Alluxio/alluxio"
}
|
{
"id": 4190144,
"login": "ggezer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4190144?",
"url": "https://api.github.com/users/ggezer"
}
|
{
"id": 16203694,
"login": "Alluxio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16203694?",
"url": "https://api.github.com/orgs/Alluxio"
}
| 2019-05-20T20:29:17 |
9662394635
|
{"actor":{"display_login":"ggezer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/comments/285462765","pull_request_review_id":239337685,"id":285462765,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTQ2Mjc2NQ==","diff_hunk":"@@ -0,0 +1,17 @@\n+# Course tools Quickstart","path":"course-tools-quickstart.md","position":1,"original_position":1,"commit_id":"519287a5a564355305c03f7c0574cd24b74cc387","original_commit_id":"519287a5a564355305c03f7c0574cd24b74cc387","user":{"login":"eloots","id":2806012,"node_id":"MDQ6VXNlcjI4MDYwMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2806012?v=4","gravatar_id":"","url":"https://api.github.com/users/eloots","html_url":"https://github.com/eloots","followers_url":"https://api.github.com/users/eloots/followers","following_url":"https://api.github.com/users/eloots/following{/other_user}","gists_url":"https://api.github.com/users/eloots/gists{/gist_id}","starred_url":"https://api.github.com/users/eloots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloots/subscriptions","organizations_url":"https://api.github.com/users/eloots/orgs","repos_url":"https://api.github.com/users/eloots/repos","events_url":"https://api.github.com/users/eloots/events{/privacy}","received_events_url":"https://api.github.com/users/eloots/received_events","type":"User","site_admin":false},"body":"@kikiya Been reflecting on working with a studentified a bit more. I think we should go for it. As said, it impact `run` and `copy`. It should be possible to have one version of each command that covers both cases (working with a master repo or the studentified repo). We may have to add a command option to cover handing the second (optional) argument to the `copy` command which specifies that the artefact should be copied to one node only (with node number equal to the number passed as second argument). \r\nCopy syntax on master would then be:\r\n\r\n`./copy [-node=ddd] ex_nr`\r\n\r\nwhereas on a studentified repo it would be:\r\n\r\n`./copy [-node=ddd]`","created_at":"2019-05-20T07:49:52Z","updated_at":"2019-05-20T07:49:52Z","html_url":"https://github.com/lightbend/Pi-Akka-Cluster/pull/93#discussion_r285462765","pull_request_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/93","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/comments/285462765"},"html":{"href":"https://github.com/lightbend/Pi-Akka-Cluster/pull/93#discussion_r285462765"},"pull_request":{"href":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/93"}},"in_reply_to_id":283878229},"pull_request":{"url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/93","id":278729016,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4NzI5MDE2","html_url":"https://github.com/lightbend/Pi-Akka-Cluster/pull/93","diff_url":"https://github.com/lightbend/Pi-Akka-Cluster/pull/93.diff","patch_url":"https://github.com/lightbend/Pi-Akka-Cluster/pull/93.patch","issue_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues/93","number":93,"state":"open","locked":false,"title":"clean docs, focus on course, clarify build","user":{"login":"kikiya","id":4748696,"node_id":"MDQ6VXNlcjQ3NDg2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4748696?v=4","gravatar_id":"","url":"https://api.github.com/users/kikiya","html_url":"https://github.com/kikiya","followers_url":"https://api.github.com/users/kikiya/followers","following_url":"https://api.github.com/users/kikiya/following{/other_user}","gists_url":"https://api.github.com/users/kikiya/gists{/gist_id}","starred_url":"https://api.github.com/users/kikiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikiya/subscriptions","organizations_url":"https://api.github.com/users/kikiya/orgs","repos_url":"https://api.github.com/users/kikiya/repos","events_url":"https://api.github.com/users/kikiya/events{/privacy}","received_events_url":"https://api.github.com/users/kikiya/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-14T15:10:54Z","updated_at":"2019-05-20T07:49:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"543a4cf25f7947f44934a668b0f37bc4eccbbb61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/93/commits","review_comments_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/93/comments","review_comment_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues/93/comments","statuses_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/statuses/519287a5a564355305c03f7c0574cd24b74cc387","head":{"label":"lightbend:update-readme-k","ref":"update-readme-k","sha":"519287a5a564355305c03f7c0574cd24b74cc387","user":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"repo":{"id":115749730,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3NDk3MzA=","name":"Pi-Akka-Cluster","full_name":"lightbend/Pi-Akka-Cluster","private":false,"owner":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightbend/Pi-Akka-Cluster","description":null,"fork":false,"url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster","forks_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/forks","keys_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/teams","hooks_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/hooks","issue_events_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues/events{/number}","events_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/events","assignees_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/assignees{/user}","branches_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/branches{/branch}","tags_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/tags","blobs_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/languages","stargazers_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/stargazers","contributors_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/contributors","subscribers_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/subscribers","subscription_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/subscription","commits_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/contents/{+path}","compare_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/merges","archive_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/downloads","issues_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues{/number}","pulls_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/labels{/name}","releases_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/releases{/id}","deployments_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/deployments","created_at":"2017-12-29T19:46:31Z","updated_at":"2019-05-19T06:45:51Z","pushed_at":"2019-05-19T06:45:49Z","git_url":"git://github.com/lightbend/Pi-Akka-Cluster.git","ssh_url":"git@github.com:lightbend/Pi-Akka-Cluster.git","clone_url":"https://github.com/lightbend/Pi-Akka-Cluster.git","svn_url":"https://github.com/lightbend/Pi-Akka-Cluster","homepage":null,"size":38837,"stargazers_count":84,"watchers_count":84,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":8,"watchers":84,"default_branch":"master"}},"base":{"label":"lightbend:master","ref":"master","sha":"b427f1df5e7a72a285d6e956a4f69c63fc6bea2a","user":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"repo":{"id":115749730,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3NDk3MzA=","name":"Pi-Akka-Cluster","full_name":"lightbend/Pi-Akka-Cluster","private":false,"owner":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightbend/Pi-Akka-Cluster","description":null,"fork":false,"url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster","forks_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/forks","keys_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/teams","hooks_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/hooks","issue_events_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues/events{/number}","events_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/events","assignees_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/assignees{/user}","branches_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/branches{/branch}","tags_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/tags","blobs_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/languages","stargazers_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/stargazers","contributors_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/contributors","subscribers_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/subscribers","subscription_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/subscription","commits_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/contents/{+path}","compare_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/merges","archive_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/downloads","issues_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues{/number}","pulls_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/labels{/name}","releases_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/releases{/id}","deployments_url":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/deployments","created_at":"2017-12-29T19:46:31Z","updated_at":"2019-05-19T06:45:51Z","pushed_at":"2019-05-19T06:45:49Z","git_url":"git://github.com/lightbend/Pi-Akka-Cluster.git","ssh_url":"git@github.com:lightbend/Pi-Akka-Cluster.git","clone_url":"https://github.com/lightbend/Pi-Akka-Cluster.git","svn_url":"https://github.com/lightbend/Pi-Akka-Cluster","homepage":null,"size":38837,"stargazers_count":84,"watchers_count":84,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":8,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/93"},"html":{"href":"https://github.com/lightbend/Pi-Akka-Cluster/pull/93"},"issue":{"href":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues/93"},"comments":{"href":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/lightbend/Pi-Akka-Cluster/statuses/519287a5a564355305c03f7c0574cd24b74cc387"}},"author_association":"COLLABORATOR"}}
|
{
"id": 115749730,
"name": "lightbend/Pi-Akka-Cluster",
"url": "https://api.github.com/repos/lightbend/Pi-Akka-Cluster"
}
|
{
"id": 2806012,
"login": "eloots",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2806012?",
"url": "https://api.github.com/users/eloots"
}
|
{
"id": 16247783,
"login": "lightbend",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16247783?",
"url": "https://api.github.com/orgs/lightbend"
}
| 2019-05-20T07:49:52 |
9657148265
|
{"actor":{"display_login":"eloots"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/comments/311639909","pull_request_review_id":272073953,"id":311639909,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTYzOTkwOQ==","diff_hunk":"@@ -91,16 +91,16 @@ def build_from_line_items(account = nil)\n # end\n # end\n else\n- unless line_item[\"price\"] && line_item[\"quantity\"]\n+ unless line_item[\"line_item_price\"] && line_item[\"quantity\"]\n raise UnsupportedException.new \"Line Items must have a valid price and quantity\"\n end\n- line.amount = (line_item[\"quantity\"].to_i * line_item[\"price\"].to_f)\n+ line.amount = (line_item[\"quantity\"].to_i * line_item[\"line_item_price\"].to_f)\n line.description = line_item[\"name\"]\n \n line.sales_item! do |sales_item|\n sales_item.item_id = item_found.id\n sales_item.quantity = line_item[\"quantity\"].to_i\n- sales_item.unit_price = line_item[\"price\"].to_f\n+ sales_item.unit_price = line_item[\"line_item_price\"].to_f","path":"lib/qb_integration/services/line.rb","position":16,"original_position":16,"commit_id":"050844b8b5223a7911614cb797fcea8d98a0b7f0","original_commit_id":"050844b8b5223a7911614cb797fcea8d98a0b7f0","user":{"login":"msalo3","id":18582423,"node_id":"MDQ6VXNlcjE4NTgyNDIz","avatar_url":"https://avatars3.githubusercontent.com/u/18582423?v=4","gravatar_id":"","url":"https://api.github.com/users/msalo3","html_url":"https://github.com/msalo3","followers_url":"https://api.github.com/users/msalo3/followers","following_url":"https://api.github.com/users/msalo3/following{/other_user}","gists_url":"https://api.github.com/users/msalo3/gists{/gist_id}","starred_url":"https://api.github.com/users/msalo3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msalo3/subscriptions","organizations_url":"https://api.github.com/users/msalo3/orgs","repos_url":"https://api.github.com/users/msalo3/repos","events_url":"https://api.github.com/users/msalo3/events{/privacy}","received_events_url":"https://api.github.com/users/msalo3/received_events","type":"User","site_admin":false},"body":"wdyt?","created_at":"2019-08-07T16:10:37Z","updated_at":"2019-08-07T16:10:37Z","html_url":"https://github.com/flowlink/quickbooks_integration/pull/63#discussion_r311639909","pull_request_url":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/63","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/comments/311639909"},"html":{"href":"https://github.com/flowlink/quickbooks_integration/pull/63#discussion_r311639909"},"pull_request":{"href":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/63"}},"in_reply_to_id":311639771},"pull_request":{"url":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/63","id":304802633,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0ODAyNjMz","html_url":"https://github.com/flowlink/quickbooks_integration/pull/63","diff_url":"https://github.com/flowlink/quickbooks_integration/pull/63.diff","patch_url":"https://github.com/flowlink/quickbooks_integration/pull/63.patch","issue_url":"https://api.github.com/repos/flowlink/quickbooks_integration/issues/63","number":63,"state":"open","locked":false,"title":"Feature/line item updates","user":{"login":"raysapida","id":8047928,"node_id":"MDQ6VXNlcjgwNDc5Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8047928?v=4","gravatar_id":"","url":"https://api.github.com/users/raysapida","html_url":"https://github.com/raysapida","followers_url":"https://api.github.com/users/raysapida/followers","following_url":"https://api.github.com/users/raysapida/following{/other_user}","gists_url":"https://api.github.com/users/raysapida/gists{/gist_id}","starred_url":"https://api.github.com/users/raysapida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raysapida/subscriptions","organizations_url":"https://api.github.com/users/raysapida/orgs","repos_url":"https://api.github.com/users/raysapida/repos","events_url":"https://api.github.com/users/raysapida/events{/privacy}","received_events_url":"https://api.github.com/users/raysapida/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-06T16:46:13Z","updated_at":"2019-08-07T16:10:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b6086839a22e08d6692d2e1114bc49b5e649ded","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gorandev","id":662596,"node_id":"MDQ6VXNlcjY2MjU5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/662596?v=4","gravatar_id":"","url":"https://api.github.com/users/gorandev","html_url":"https://github.com/gorandev","followers_url":"https://api.github.com/users/gorandev/followers","following_url":"https://api.github.com/users/gorandev/following{/other_user}","gists_url":"https://api.github.com/users/gorandev/gists{/gist_id}","starred_url":"https://api.github.com/users/gorandev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorandev/subscriptions","organizations_url":"https://api.github.com/users/gorandev/orgs","repos_url":"https://api.github.com/users/gorandev/repos","events_url":"https://api.github.com/users/gorandev/events{/privacy}","received_events_url":"https://api.github.com/users/gorandev/received_events","type":"User","site_admin":false},{"login":"bcgianni","id":12086336,"node_id":"MDQ6VXNlcjEyMDg2MzM2","avatar_url":"https://avatars2.githubusercontent.com/u/12086336?v=4","gravatar_id":"","url":"https://api.github.com/users/bcgianni","html_url":"https://github.com/bcgianni","followers_url":"https://api.github.com/users/bcgianni/followers","following_url":"https://api.github.com/users/bcgianni/following{/other_user}","gists_url":"https://api.github.com/users/bcgianni/gists{/gist_id}","starred_url":"https://api.github.com/users/bcgianni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcgianni/subscriptions","organizations_url":"https://api.github.com/users/bcgianni/orgs","repos_url":"https://api.github.com/users/bcgianni/repos","events_url":"https://api.github.com/users/bcgianni/events{/privacy}","received_events_url":"https://api.github.com/users/bcgianni/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/63/commits","review_comments_url":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/63/comments","review_comment_url":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flowlink/quickbooks_integration/issues/63/comments","statuses_url":"https://api.github.com/repos/flowlink/quickbooks_integration/statuses/050844b8b5223a7911614cb797fcea8d98a0b7f0","head":{"label":"flowlink:feature/line-item-updates","ref":"feature/line-item-updates","sha":"050844b8b5223a7911614cb797fcea8d98a0b7f0","user":{"login":"flowlink","id":16366543,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzY2NTQz","avatar_url":"https://avatars3.githubusercontent.com/u/16366543?v=4","gravatar_id":"","url":"https://api.github.com/users/flowlink","html_url":"https://github.com/flowlink","followers_url":"https://api.github.com/users/flowlink/followers","following_url":"https://api.github.com/users/flowlink/following{/other_user}","gists_url":"https://api.github.com/users/flowlink/gists{/gist_id}","starred_url":"https://api.github.com/users/flowlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowlink/subscriptions","organizations_url":"https://api.github.com/users/flowlink/orgs","repos_url":"https://api.github.com/users/flowlink/repos","events_url":"https://api.github.com/users/flowlink/events{/privacy}","received_events_url":"https://api.github.com/users/flowlink/received_events","type":"Organization","site_admin":false},"repo":{"id":48302429,"node_id":"MDEwOlJlcG9zaXRvcnk0ODMwMjQyOQ==","name":"quickbooks_integration","full_name":"flowlink/quickbooks_integration","private":false,"owner":{"login":"flowlink","id":16366543,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzY2NTQz","avatar_url":"https://avatars3.githubusercontent.com/u/16366543?v=4","gravatar_id":"","url":"https://api.github.com/users/flowlink","html_url":"https://github.com/flowlink","followers_url":"https://api.github.com/users/flowlink/followers","following_url":"https://api.github.com/users/flowlink/following{/other_user}","gists_url":"https://api.github.com/users/flowlink/gists{/gist_id}","starred_url":"https://api.github.com/users/flowlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowlink/subscriptions","organizations_url":"https://api.github.com/users/flowlink/orgs","repos_url":"https://api.github.com/users/flowlink/repos","events_url":"https://api.github.com/users/flowlink/events{/privacy}","received_events_url":"https://api.github.com/users/flowlink/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flowlink/quickbooks_integration","description":"Quickbooks Integration for FlowLink","fork":false,"url":"https://api.github.com/repos/flowlink/quickbooks_integration","forks_url":"https://api.github.com/repos/flowlink/quickbooks_integration/forks","keys_url":"https://api.github.com/repos/flowlink/quickbooks_integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flowlink/quickbooks_integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flowlink/quickbooks_integration/teams","hooks_url":"https://api.github.com/repos/flowlink/quickbooks_integration/hooks","issue_events_url":"https://api.github.com/repos/flowlink/quickbooks_integration/issues/events{/number}","events_url":"https://api.github.com/repos/flowlink/quickbooks_integration/events","assignees_url":"https://api.github.com/repos/flowlink/quickbooks_integration/assignees{/user}","branches_url":"https://api.github.com/repos/flowlink/quickbooks_integration/branches{/branch}","tags_url":"https://api.github.com/repos/flowlink/quickbooks_integration/tags","blobs_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flowlink/quickbooks_integration/statuses/{sha}","languages_url":"https://api.github.com/repos/flowlink/quickbooks_integration/languages","stargazers_url":"https://api.github.com/repos/flowlink/quickbooks_integration/stargazers","contributors_url":"https://api.github.com/repos/flowlink/quickbooks_integration/contributors","subscribers_url":"https://api.github.com/repos/flowlink/quickbooks_integration/subscribers","subscription_url":"https://api.github.com/repos/flowlink/quickbooks_integration/subscription","commits_url":"https://api.github.com/repos/flowlink/quickbooks_integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/flowlink/quickbooks_integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/flowlink/quickbooks_integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/flowlink/quickbooks_integration/contents/{+path}","compare_url":"https://api.github.com/repos/flowlink/quickbooks_integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flowlink/quickbooks_integration/merges","archive_url":"https://api.github.com/repos/flowlink/quickbooks_integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flowlink/quickbooks_integration/downloads","issues_url":"https://api.github.com/repos/flowlink/quickbooks_integration/issues{/number}","pulls_url":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls{/number}","milestones_url":"https://api.github.com/repos/flowlink/quickbooks_integration/milestones{/number}","notifications_url":"https://api.github.com/repos/flowlink/quickbooks_integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flowlink/quickbooks_integration/labels{/name}","releases_url":"https://api.github.com/repos/flowlink/quickbooks_integration/releases{/id}","deployments_url":"https://api.github.com/repos/flowlink/quickbooks_integration/deployments","created_at":"2015-12-20T00:43:56Z","updated_at":"2019-07-30T14:54:56Z","pushed_at":"2019-08-06T21:19:34Z","git_url":"git://github.com/flowlink/quickbooks_integration.git","ssh_url":"git@github.com:flowlink/quickbooks_integration.git","clone_url":"https://github.com/flowlink/quickbooks_integration.git","svn_url":"https://github.com/flowlink/quickbooks_integration","homepage":"https://flowlink.io/","size":1736,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"flowlink:develop","ref":"develop","sha":"9710a0890465dc94d7a77360c94ebdec34a2b8cb","user":{"login":"flowlink","id":16366543,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzY2NTQz","avatar_url":"https://avatars3.githubusercontent.com/u/16366543?v=4","gravatar_id":"","url":"https://api.github.com/users/flowlink","html_url":"https://github.com/flowlink","followers_url":"https://api.github.com/users/flowlink/followers","following_url":"https://api.github.com/users/flowlink/following{/other_user}","gists_url":"https://api.github.com/users/flowlink/gists{/gist_id}","starred_url":"https://api.github.com/users/flowlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowlink/subscriptions","organizations_url":"https://api.github.com/users/flowlink/orgs","repos_url":"https://api.github.com/users/flowlink/repos","events_url":"https://api.github.com/users/flowlink/events{/privacy}","received_events_url":"https://api.github.com/users/flowlink/received_events","type":"Organization","site_admin":false},"repo":{"id":48302429,"node_id":"MDEwOlJlcG9zaXRvcnk0ODMwMjQyOQ==","name":"quickbooks_integration","full_name":"flowlink/quickbooks_integration","private":false,"owner":{"login":"flowlink","id":16366543,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzY2NTQz","avatar_url":"https://avatars3.githubusercontent.com/u/16366543?v=4","gravatar_id":"","url":"https://api.github.com/users/flowlink","html_url":"https://github.com/flowlink","followers_url":"https://api.github.com/users/flowlink/followers","following_url":"https://api.github.com/users/flowlink/following{/other_user}","gists_url":"https://api.github.com/users/flowlink/gists{/gist_id}","starred_url":"https://api.github.com/users/flowlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowlink/subscriptions","organizations_url":"https://api.github.com/users/flowlink/orgs","repos_url":"https://api.github.com/users/flowlink/repos","events_url":"https://api.github.com/users/flowlink/events{/privacy}","received_events_url":"https://api.github.com/users/flowlink/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flowlink/quickbooks_integration","description":"Quickbooks Integration for FlowLink","fork":false,"url":"https://api.github.com/repos/flowlink/quickbooks_integration","forks_url":"https://api.github.com/repos/flowlink/quickbooks_integration/forks","keys_url":"https://api.github.com/repos/flowlink/quickbooks_integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flowlink/quickbooks_integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flowlink/quickbooks_integration/teams","hooks_url":"https://api.github.com/repos/flowlink/quickbooks_integration/hooks","issue_events_url":"https://api.github.com/repos/flowlink/quickbooks_integration/issues/events{/number}","events_url":"https://api.github.com/repos/flowlink/quickbooks_integration/events","assignees_url":"https://api.github.com/repos/flowlink/quickbooks_integration/assignees{/user}","branches_url":"https://api.github.com/repos/flowlink/quickbooks_integration/branches{/branch}","tags_url":"https://api.github.com/repos/flowlink/quickbooks_integration/tags","blobs_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flowlink/quickbooks_integration/statuses/{sha}","languages_url":"https://api.github.com/repos/flowlink/quickbooks_integration/languages","stargazers_url":"https://api.github.com/repos/flowlink/quickbooks_integration/stargazers","contributors_url":"https://api.github.com/repos/flowlink/quickbooks_integration/contributors","subscribers_url":"https://api.github.com/repos/flowlink/quickbooks_integration/subscribers","subscription_url":"https://api.github.com/repos/flowlink/quickbooks_integration/subscription","commits_url":"https://api.github.com/repos/flowlink/quickbooks_integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/flowlink/quickbooks_integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/flowlink/quickbooks_integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/flowlink/quickbooks_integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/flowlink/quickbooks_integration/contents/{+path}","compare_url":"https://api.github.com/repos/flowlink/quickbooks_integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flowlink/quickbooks_integration/merges","archive_url":"https://api.github.com/repos/flowlink/quickbooks_integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flowlink/quickbooks_integration/downloads","issues_url":"https://api.github.com/repos/flowlink/quickbooks_integration/issues{/number}","pulls_url":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls{/number}","milestones_url":"https://api.github.com/repos/flowlink/quickbooks_integration/milestones{/number}","notifications_url":"https://api.github.com/repos/flowlink/quickbooks_integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flowlink/quickbooks_integration/labels{/name}","releases_url":"https://api.github.com/repos/flowlink/quickbooks_integration/releases{/id}","deployments_url":"https://api.github.com/repos/flowlink/quickbooks_integration/deployments","created_at":"2015-12-20T00:43:56Z","updated_at":"2019-07-30T14:54:56Z","pushed_at":"2019-08-06T21:19:34Z","git_url":"git://github.com/flowlink/quickbooks_integration.git","ssh_url":"git@github.com:flowlink/quickbooks_integration.git","clone_url":"https://github.com/flowlink/quickbooks_integration.git","svn_url":"https://github.com/flowlink/quickbooks_integration","homepage":"https://flowlink.io/","size":1736,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/63"},"html":{"href":"https://github.com/flowlink/quickbooks_integration/pull/63"},"issue":{"href":"https://api.github.com/repos/flowlink/quickbooks_integration/issues/63"},"comments":{"href":"https://api.github.com/repos/flowlink/quickbooks_integration/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flowlink/quickbooks_integration/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/flowlink/quickbooks_integration/statuses/050844b8b5223a7911614cb797fcea8d98a0b7f0"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 48302429,
"name": "flowlink/quickbooks_integration",
"url": "https://api.github.com/repos/flowlink/quickbooks_integration"
}
|
{
"id": 18582423,
"login": "msalo3",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18582423?",
"url": "https://api.github.com/users/msalo3"
}
|
{
"id": 16366543,
"login": "flowlink",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16366543?",
"url": "https://api.github.com/orgs/flowlink"
}
| 2019-08-07T16:10:37 |
10166606879
|
{"actor":{"display_login":"msalo3"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/manifoldco/ui/pulls/comments/346887878","pull_request_review_id":317705108,"id":346887878,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0Njg4Nzg3OA==","diff_hunk":"@@ -0,0 +1,116 @@\n+query getResource($resourceLabel: String!) {\n+ resource(label: $resourceLabel) {\n+ id\n+ label\n+ region {\n+ id\n+ displayName\n+ }\n+ status {\n+ label\n+ message\n+ }\n+ plan {\n+ id\n+ label\n+ displayName\n+ state\n+ cost\n+ free\n+ regions(first: 20) {\n+ pageInfo {\n+ startCursor\n+ endCursor\n+ hasNextPage\n+ hasPreviousPage\n+ }\n+ edges {\n+ node {\n+ id\n+ displayName\n+ platform\n+ dataCenter\n+ }\n+ cursor\n+ }\n+ }\n+ product {\n+ id\n+ displayName\n+ tagline\n+ label\n+ logoUrl\n+ }\n+ fixedFeatures(first: 20) {\n+ pageInfo {\n+ startCursor\n+ endCursor\n+ hasNextPage\n+ hasPreviousPage\n+ }\n+ edges {\n+ cursor\n+ node {\n+ id\n+ label\n+ displayName\n+ displayValue\n+ }\n+ }\n+ }\n+ meteredFeatures(first: 20) {\n+ pageInfo {\n+ startCursor\n+ endCursor\n+ hasNextPage\n+ hasPreviousPage\n+ }\n+ edges {\n+ cursor\n+ node {\n+ id\n+ label\n+ displayName\n+ numericDetails {\n+ unit\n+ costTiers {\n+ limit\n+ cost\n+ }\n+ }\n+ }\n+ }\n+ }\n+ configurableFeatures(first: 20) {","path":"src/components/manifold-resource-container/resource.graphql","position":84,"original_position":84,"commit_id":"1a6fafc557ba86336caacbbd90f2774d80e92fd8","original_commit_id":"1a6fafc557ba86336caacbbd90f2774d80e92fd8","user":{"login":"dangodev","id":1369770,"node_id":"MDQ6VXNlcjEzNjk3NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1369770?v=4","gravatar_id":"","url":"https://api.github.com/users/dangodev","html_url":"https://github.com/dangodev","followers_url":"https://api.github.com/users/dangodev/followers","following_url":"https://api.github.com/users/dangodev/following{/other_user}","gists_url":"https://api.github.com/users/dangodev/gists{/gist_id}","starred_url":"https://api.github.com/users/dangodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangodev/subscriptions","organizations_url":"https://api.github.com/users/dangodev/orgs","repos_url":"https://api.github.com/users/dangodev/repos","events_url":"https://api.github.com/users/dangodev/events{/privacy}","received_events_url":"https://api.github.com/users/dangodev/received_events","type":"User","site_admin":false},"body":"We don’t load the plan selector through this; we load `<manifold-plan-details>`. It’s just that `<manifold-plan-details>` needs the exact same type shape, which includes all regions (right now we’re cheating, and using `Plan`, but when we type queries, the types will need to match)","created_at":"2019-11-15T15:50:36Z","updated_at":"2019-11-15T15:50:36Z","html_url":"https://github.com/manifoldco/ui/pull/733#discussion_r346887878","pull_request_url":"https://api.github.com/repos/manifoldco/ui/pulls/733","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/comments/346887878"},"html":{"href":"https://github.com/manifoldco/ui/pull/733#discussion_r346887878"},"pull_request":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/733"}},"in_reply_to_id":346839287},"pull_request":{"url":"https://api.github.com/repos/manifoldco/ui/pulls/733","id":341197817,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxMTk3ODE3","html_url":"https://github.com/manifoldco/ui/pull/733","diff_url":"https://github.com/manifoldco/ui/pull/733.diff","patch_url":"https://github.com/manifoldco/ui/pull/733.patch","issue_url":"https://api.github.com/repos/manifoldco/ui/issues/733","number":733,"state":"open","locked":false,"title":"Use typed query for manifold-resource-container","user":{"login":"dangodev","id":1369770,"node_id":"MDQ6VXNlcjEzNjk3NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1369770?v=4","gravatar_id":"","url":"https://api.github.com/users/dangodev","html_url":"https://github.com/dangodev","followers_url":"https://api.github.com/users/dangodev/followers","following_url":"https://api.github.com/users/dangodev/following{/other_user}","gists_url":"https://api.github.com/users/dangodev/gists{/gist_id}","starred_url":"https://api.github.com/users/dangodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangodev/subscriptions","organizations_url":"https://api.github.com/users/dangodev/orgs","repos_url":"https://api.github.com/users/dangodev/repos","events_url":"https://api.github.com/users/dangodev/events{/privacy}","received_events_url":"https://api.github.com/users/dangodev/received_events","type":"User","site_admin":false},"body":"## Reason for change\r\n\r\nConverts `<manifold-resource-container>` to use a typed GraphQL query.\r\n\r\nThis is cleanup work that will make the upcoming ticket https://github.com/manifoldco/engineering/issues/9877 easier.\r\n\r\n## Testing\r\n\r\nAll tests should pass. This doesn’t change any production code; it just makes the types more resilient.\r\n<!-- For someone unfamiliar with the issue, how should this be tested? -->\r\n\r\n## Checklist\r\n\r\n<!-- are all the steps completed? -->\r\n\r\n- [ ] **CHANGELOG**: The **Unreleased** section of CHANGELOG was updated\r\n- [ ] **Prop changes**: [docs][docs] were updated\r\n- [ ] **Prop changes**: E2E tests were updated, testing from the highest level possible\r\n- [ ] **Platform testing**: If this change should be [tested against a platform][platform-testing], has it been?\r\n\r\n[docs]: https://ui.sandbox.manifold.co\r\n[platform-testing]: https://app.gitbook.com/@manifold/s/engineering/playbooks/testing-your-code-against-a-platform\r\n","created_at":"2019-11-14T22:05:20Z","updated_at":"2019-11-15T15:50:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f42e64164e3002b15c1619a2113a89cfd55c54b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Minivera","id":20424444,"node_id":"MDQ6VXNlcjIwNDI0NDQ0","avatar_url":"https://avatars0.githubusercontent.com/u/20424444?v=4","gravatar_id":"","url":"https://api.github.com/users/Minivera","html_url":"https://github.com/Minivera","followers_url":"https://api.github.com/users/Minivera/followers","following_url":"https://api.github.com/users/Minivera/following{/other_user}","gists_url":"https://api.github.com/users/Minivera/gists{/gist_id}","starred_url":"https://api.github.com/users/Minivera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minivera/subscriptions","organizations_url":"https://api.github.com/users/Minivera/orgs","repos_url":"https://api.github.com/users/Minivera/repos","events_url":"https://api.github.com/users/Minivera/events{/privacy}","received_events_url":"https://api.github.com/users/Minivera/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/manifoldco/ui/pulls/733/commits","review_comments_url":"https://api.github.com/repos/manifoldco/ui/pulls/733/comments","review_comment_url":"https://api.github.com/repos/manifoldco/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/manifoldco/ui/issues/733/comments","statuses_url":"https://api.github.com/repos/manifoldco/ui/statuses/1a6fafc557ba86336caacbbd90f2774d80e92fd8","head":{"label":"manifoldco:dangodev/gql-resource-container","ref":"dangodev/gql-resource-container","sha":"1a6fafc557ba86336caacbbd90f2774d80e92fd8","user":{"login":"manifoldco","id":16501525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTAxNTI1","avatar_url":"https://avatars2.githubusercontent.com/u/16501525?v=4","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"repo":{"id":168354990,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgzNTQ5OTA=","name":"ui","full_name":"manifoldco/ui","private":false,"owner":{"login":"manifoldco","id":16501525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTAxNTI1","avatar_url":"https://avatars2.githubusercontent.com/u/16501525?v=4","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/manifoldco/ui","description":"Manifold’s web component UI library","fork":false,"url":"https://api.github.com/repos/manifoldco/ui","forks_url":"https://api.github.com/repos/manifoldco/ui/forks","keys_url":"https://api.github.com/repos/manifoldco/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manifoldco/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manifoldco/ui/teams","hooks_url":"https://api.github.com/repos/manifoldco/ui/hooks","issue_events_url":"https://api.github.com/repos/manifoldco/ui/issues/events{/number}","events_url":"https://api.github.com/repos/manifoldco/ui/events","assignees_url":"https://api.github.com/repos/manifoldco/ui/assignees{/user}","branches_url":"https://api.github.com/repos/manifoldco/ui/branches{/branch}","tags_url":"https://api.github.com/repos/manifoldco/ui/tags","blobs_url":"https://api.github.com/repos/manifoldco/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manifoldco/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manifoldco/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/manifoldco/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manifoldco/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/manifoldco/ui/languages","stargazers_url":"https://api.github.com/repos/manifoldco/ui/stargazers","contributors_url":"https://api.github.com/repos/manifoldco/ui/contributors","subscribers_url":"https://api.github.com/repos/manifoldco/ui/subscribers","subscription_url":"https://api.github.com/repos/manifoldco/ui/subscription","commits_url":"https://api.github.com/repos/manifoldco/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/manifoldco/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/manifoldco/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/manifoldco/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/manifoldco/ui/contents/{+path}","compare_url":"https://api.github.com/repos/manifoldco/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manifoldco/ui/merges","archive_url":"https://api.github.com/repos/manifoldco/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manifoldco/ui/downloads","issues_url":"https://api.github.com/repos/manifoldco/ui/issues{/number}","pulls_url":"https://api.github.com/repos/manifoldco/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/manifoldco/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/manifoldco/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manifoldco/ui/labels{/name}","releases_url":"https://api.github.com/repos/manifoldco/ui/releases{/id}","deployments_url":"https://api.github.com/repos/manifoldco/ui/deployments","created_at":"2019-01-30T14:19:58Z","updated_at":"2019-11-15T05:12:13Z","pushed_at":"2019-11-15T13:47:38Z","git_url":"git://github.com/manifoldco/ui.git","ssh_url":"git@github.com:manifoldco/ui.git","clone_url":"https://github.com/manifoldco/ui.git","svn_url":"https://github.com/manifoldco/ui","homepage":"https://ui.sandbox.manifold.co","size":8616,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"manifoldco:master","ref":"master","sha":"403fa5bae17d30c7ff54fcf1afa233cd3c27352d","user":{"login":"manifoldco","id":16501525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTAxNTI1","avatar_url":"https://avatars2.githubusercontent.com/u/16501525?v=4","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"repo":{"id":168354990,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgzNTQ5OTA=","name":"ui","full_name":"manifoldco/ui","private":false,"owner":{"login":"manifoldco","id":16501525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTAxNTI1","avatar_url":"https://avatars2.githubusercontent.com/u/16501525?v=4","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/manifoldco/ui","description":"Manifold’s web component UI library","fork":false,"url":"https://api.github.com/repos/manifoldco/ui","forks_url":"https://api.github.com/repos/manifoldco/ui/forks","keys_url":"https://api.github.com/repos/manifoldco/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manifoldco/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manifoldco/ui/teams","hooks_url":"https://api.github.com/repos/manifoldco/ui/hooks","issue_events_url":"https://api.github.com/repos/manifoldco/ui/issues/events{/number}","events_url":"https://api.github.com/repos/manifoldco/ui/events","assignees_url":"https://api.github.com/repos/manifoldco/ui/assignees{/user}","branches_url":"https://api.github.com/repos/manifoldco/ui/branches{/branch}","tags_url":"https://api.github.com/repos/manifoldco/ui/tags","blobs_url":"https://api.github.com/repos/manifoldco/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manifoldco/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manifoldco/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/manifoldco/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manifoldco/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/manifoldco/ui/languages","stargazers_url":"https://api.github.com/repos/manifoldco/ui/stargazers","contributors_url":"https://api.github.com/repos/manifoldco/ui/contributors","subscribers_url":"https://api.github.com/repos/manifoldco/ui/subscribers","subscription_url":"https://api.github.com/repos/manifoldco/ui/subscription","commits_url":"https://api.github.com/repos/manifoldco/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/manifoldco/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/manifoldco/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/manifoldco/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/manifoldco/ui/contents/{+path}","compare_url":"https://api.github.com/repos/manifoldco/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manifoldco/ui/merges","archive_url":"https://api.github.com/repos/manifoldco/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manifoldco/ui/downloads","issues_url":"https://api.github.com/repos/manifoldco/ui/issues{/number}","pulls_url":"https://api.github.com/repos/manifoldco/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/manifoldco/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/manifoldco/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manifoldco/ui/labels{/name}","releases_url":"https://api.github.com/repos/manifoldco/ui/releases{/id}","deployments_url":"https://api.github.com/repos/manifoldco/ui/deployments","created_at":"2019-01-30T14:19:58Z","updated_at":"2019-11-15T05:12:13Z","pushed_at":"2019-11-15T13:47:38Z","git_url":"git://github.com/manifoldco/ui.git","ssh_url":"git@github.com:manifoldco/ui.git","clone_url":"https://github.com/manifoldco/ui.git","svn_url":"https://github.com/manifoldco/ui","homepage":"https://ui.sandbox.manifold.co","size":8616,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/733"},"html":{"href":"https://github.com/manifoldco/ui/pull/733"},"issue":{"href":"https://api.github.com/repos/manifoldco/ui/issues/733"},"comments":{"href":"https://api.github.com/repos/manifoldco/ui/issues/733/comments"},"review_comments":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/733/comments"},"review_comment":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/733/commits"},"statuses":{"href":"https://api.github.com/repos/manifoldco/ui/statuses/1a6fafc557ba86336caacbbd90f2774d80e92fd8"}},"author_association":"MEMBER"}}
|
{
"id": 168354990,
"name": "manifoldco/ui",
"url": "https://api.github.com/repos/manifoldco/ui"
}
|
{
"id": 1369770,
"login": "dangodev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1369770?",
"url": "https://api.github.com/users/dangodev"
}
|
{
"id": 16501525,
"login": "manifoldco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16501525?",
"url": "https://api.github.com/orgs/manifoldco"
}
| 2019-11-15T15:50:36 |
10873065948
|
{"actor":{"display_login":"dangodev"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/comments/329454725","pull_request_review_id":294808739,"id":329454725,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTQ1NDcyNQ==","diff_hunk":"@@ -11,60 +12,70 @@\n <ul>\n <li><a href=\"\">студия</a></li>\n <li><a href=\"\">клиенты</a></li>\n- <li><a href=\"catalog.html\">магазин</a></li>\n+ <li><a>магазин</a></li>\n <li><a href=\"\">контакты</a></li>\n </ul>\n <ul>\n- <li><a href=\"\"><img src=\"img/cart-icon.svg\">корзина</a></li>\n+ <li><a href=\"\">корзина</a></li>\n </ul>\n </nav>\n- <h1>магазин готовых шаблонов</h1>\n+ \n </header>\n <main>\n- <p>Сетка:</p>\n- <label>\n- <input type=\"radio\" name=\"Сетка\" value=\"Адаптивная\">Адаптивная\n- </label>\n- <br>\n- <label>\n- <input type=\"radio\" name=\"Сетка\" value=\"Фиксированная\">Фиксированная\n- </label>\n- <br>\n- <label>\n- <input type=\"radio\" name=\"Сетка\" value=\"Резиновая\">Резиновая\n- </label>\n- <p>Особенности:</p>\n- <label>\n- <input type=\"checkbox\" name=\"Слайдер\">Слайдер\n- </label>\n- <br>\n- <label>\n- <input type=\"checkbox\" name=\"Блок преимуществ\">Блок преимуществ\n- </label>\n- <br>\n- <label>\n- <input type=\"checkbox\" name=\"Новости\">Новости\n- </label>\n- <br>\n- <label>\n- <input type=\"checkbox\" name=\"Галерея\">Галерея\n- </label>\n- <br>\n- <label>\n- <input type=\"checkbox\" name=\"Корзина\">Корзина\n- </label>\n- <br>\n <form>\n+ <p>Сетка:</p>\n+ <label>\n+ <input type=\"radio\" name=\"Сетка\" value=\"Адаптивная\">Адаптивная\n+ </label>\n+ <br>\n+ <label>\n+ <input type=\"radio\" name=\"Сетка\" value=\"Фиксированная\">Фиксированная\n+ </label>\n+ <br>\n+ <label>\n+ <input type=\"radio\" name=\"Сетка\" value=\"Резиновая\">Резиновая\n+ </label>\n+ <p>Особенности:</p>\n+ <label>\n+ <input type=\"checkbox\" name=\"Слайдер\">Слайдер\n+ </label>\n+ <br>\n+ <label>\n+ <input type=\"checkbox\" name=\"Блок преимуществ\">Блок преимуществ\n+ </label>\n+ <br>\n+ <label>\n+ <input type=\"checkbox\" name=\"Новости\">Новости\n+ </label>\n+ <br>\n+ <label>\n+ <input type=\"checkbox\" name=\"Галерея\">Галерея\n+ </label>\n+ <br>\n+ <label>\n+ <input type=\"checkbox\" name=\"Корзина\">Корзина\n+ </label>\n+ <br>\n <button>Показать</button>\n </form>\n- <img src=\"img/img-sedona.jpg\" alt=\"\">\n- <img src=\"img/img-pink.jpg\" alt=\"\">\n- <img src=\"img/img-barbershop.jpg\" alt=\"\">\n- <img src=\"img/img-mishka.jpg\" alt=\"\">\n- <img src=\"img/img-aplus.jpg\" alt=\"\">\n- <img src=\"img/img-kvast.jpg\" alt=\"\">\n+ <h1 class=\"visually-hidden\">магазин готовых шаблонов</h1>\n+ <img src=\"img/img-sedona.jpg\" alt=\"\">\n+ <img src=\"img/img-pink.jpg\" alt=\"\">\n+ <img src=\"img/img-barbershop.jpg\" alt=\"\">\n+ <img src=\"img/img-mishka.jpg\" alt=\"\">\n+ <img src=\"img/img-aplus.jpg\" alt=\"\">\n+ <img src=\"img/img-kvast.jpg\" alt=\"\">\n </main>\n <footer>\n+ <div>\n+ <h2>NЁRDS DESIGN STUDIO</h2>\n+ <p>191186, Санкт-Петербург,</p> \n+ <p>ул. Б. Конюшенная, д. 19/8</p>\n+ <p>тел. +7 (812) 275-75-75</p> \n+ <form>\n+ <button>напишите нам</button>\n+ </form>","path":"catalog.html","position":116,"original_position":116,"commit_id":"cd209d5db40ecf58f2dd49b47c1c5bcfa5f9038f","original_commit_id":"cd209d5db40ecf58f2dd49b47c1c5bcfa5f9038f","user":{"login":"raccoonroman","id":34542700,"node_id":"MDQ6VXNlcjM0NTQyNzAw","avatar_url":"https://avatars1.githubusercontent.com/u/34542700?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoonroman","html_url":"https://github.com/raccoonroman","followers_url":"https://api.github.com/users/raccoonroman/followers","following_url":"https://api.github.com/users/raccoonroman/following{/other_user}","gists_url":"https://api.github.com/users/raccoonroman/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoonroman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoonroman/subscriptions","organizations_url":"https://api.github.com/users/raccoonroman/orgs","repos_url":"https://api.github.com/users/raccoonroman/repos","events_url":"https://api.github.com/users/raccoonroman/events{/privacy}","received_events_url":"https://api.github.com/users/raccoonroman/received_events","type":"User","site_admin":false},"body":"Это не форма, а обычная ссылка в виде кнопки","created_at":"2019-09-30T08:14:07Z","updated_at":"2019-09-30T08:22:33Z","html_url":"https://github.com/htmlacademy-htmlcss/1124569-nerds-26/pull/4#discussion_r329454725","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/comments/329454725"},"html":{"href":"https://github.com/htmlacademy-htmlcss/1124569-nerds-26/pull/4#discussion_r329454725"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/4","id":322538122,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyNTM4MTIy","html_url":"https://github.com/htmlacademy-htmlcss/1124569-nerds-26/pull/4","diff_url":"https://github.com/htmlacademy-htmlcss/1124569-nerds-26/pull/4.diff","patch_url":"https://github.com/htmlacademy-htmlcss/1124569-nerds-26/pull/4.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/issues/4","number":4,"state":"open","locked":false,"title":"Личный проект: продолжаем разметку ","user":{"login":"Rudolf31","id":55095427,"node_id":"MDQ6VXNlcjU1MDk1NDI3","avatar_url":"https://avatars1.githubusercontent.com/u/55095427?v=4","gravatar_id":"","url":"https://api.github.com/users/Rudolf31","html_url":"https://github.com/Rudolf31","followers_url":"https://api.github.com/users/Rudolf31/followers","following_url":"https://api.github.com/users/Rudolf31/following{/other_user}","gists_url":"https://api.github.com/users/Rudolf31/gists{/gist_id}","starred_url":"https://api.github.com/users/Rudolf31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rudolf31/subscriptions","organizations_url":"https://api.github.com/users/Rudolf31/orgs","repos_url":"https://api.github.com/users/Rudolf31/repos","events_url":"https://api.github.com/users/Rudolf31/events{/privacy}","received_events_url":"https://api.github.com/users/Rudolf31/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Личный проект: продолжаем разметку ](https://up.htmlacademy.ru/htmlcss/26/user/1124569/tasks/9)\n\n:boom: https://htmlacademy-htmlcss.github.io/1124569-nerds-26/4/","created_at":"2019-09-29T20:31:49Z","updated_at":"2019-09-30T08:22:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"369a29a74253f7f1e533049e8d48d4de9a8167c2","assignee":{"login":"raccoonroman","id":34542700,"node_id":"MDQ6VXNlcjM0NTQyNzAw","avatar_url":"https://avatars1.githubusercontent.com/u/34542700?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoonroman","html_url":"https://github.com/raccoonroman","followers_url":"https://api.github.com/users/raccoonroman/followers","following_url":"https://api.github.com/users/raccoonroman/following{/other_user}","gists_url":"https://api.github.com/users/raccoonroman/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoonroman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoonroman/subscriptions","organizations_url":"https://api.github.com/users/raccoonroman/orgs","repos_url":"https://api.github.com/users/raccoonroman/repos","events_url":"https://api.github.com/users/raccoonroman/events{/privacy}","received_events_url":"https://api.github.com/users/raccoonroman/received_events","type":"User","site_admin":false},"assignees":[{"login":"raccoonroman","id":34542700,"node_id":"MDQ6VXNlcjM0NTQyNzAw","avatar_url":"https://avatars1.githubusercontent.com/u/34542700?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoonroman","html_url":"https://github.com/raccoonroman","followers_url":"https://api.github.com/users/raccoonroman/followers","following_url":"https://api.github.com/users/raccoonroman/following{/other_user}","gists_url":"https://api.github.com/users/raccoonroman/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoonroman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoonroman/subscriptions","organizations_url":"https://api.github.com/users/raccoonroman/orgs","repos_url":"https://api.github.com/users/raccoonroman/repos","events_url":"https://api.github.com/users/raccoonroman/events{/privacy}","received_events_url":"https://api.github.com/users/raccoonroman/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/4/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/4/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/issues/4/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/statuses/cd209d5db40ecf58f2dd49b47c1c5bcfa5f9038f","head":{"label":"Rudolf31:master","ref":"master","sha":"cd209d5db40ecf58f2dd49b47c1c5bcfa5f9038f","user":{"login":"Rudolf31","id":55095427,"node_id":"MDQ6VXNlcjU1MDk1NDI3","avatar_url":"https://avatars1.githubusercontent.com/u/55095427?v=4","gravatar_id":"","url":"https://api.github.com/users/Rudolf31","html_url":"https://github.com/Rudolf31","followers_url":"https://api.github.com/users/Rudolf31/followers","following_url":"https://api.github.com/users/Rudolf31/following{/other_user}","gists_url":"https://api.github.com/users/Rudolf31/gists{/gist_id}","starred_url":"https://api.github.com/users/Rudolf31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rudolf31/subscriptions","organizations_url":"https://api.github.com/users/Rudolf31/orgs","repos_url":"https://api.github.com/users/Rudolf31/repos","events_url":"https://api.github.com/users/Rudolf31/events{/privacy}","received_events_url":"https://api.github.com/users/Rudolf31/received_events","type":"User","site_admin":false},"repo":{"id":207847901,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc4NDc5MDE=","name":"1124569-nerds-26","full_name":"Rudolf31/1124569-nerds-26","private":false,"owner":{"login":"Rudolf31","id":55095427,"node_id":"MDQ6VXNlcjU1MDk1NDI3","avatar_url":"https://avatars1.githubusercontent.com/u/55095427?v=4","gravatar_id":"","url":"https://api.github.com/users/Rudolf31","html_url":"https://github.com/Rudolf31","followers_url":"https://api.github.com/users/Rudolf31/followers","following_url":"https://api.github.com/users/Rudolf31/following{/other_user}","gists_url":"https://api.github.com/users/Rudolf31/gists{/gist_id}","starred_url":"https://api.github.com/users/Rudolf31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rudolf31/subscriptions","organizations_url":"https://api.github.com/users/Rudolf31/orgs","repos_url":"https://api.github.com/users/Rudolf31/repos","events_url":"https://api.github.com/users/Rudolf31/events{/privacy}","received_events_url":"https://api.github.com/users/Rudolf31/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Rudolf31/1124569-nerds-26","description":"Рудольф Шевченко","fork":true,"url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26","forks_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/forks","keys_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/teams","hooks_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/hooks","issue_events_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/issues/events{/number}","events_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/events","assignees_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/assignees{/user}","branches_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/branches{/branch}","tags_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/tags","blobs_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/statuses/{sha}","languages_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/languages","stargazers_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/stargazers","contributors_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/contributors","subscribers_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/subscribers","subscription_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/subscription","commits_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/contents/{+path}","compare_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/merges","archive_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/downloads","issues_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/issues{/number}","pulls_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/pulls{/number}","milestones_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/milestones{/number}","notifications_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/labels{/name}","releases_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/releases{/id}","deployments_url":"https://api.github.com/repos/Rudolf31/1124569-nerds-26/deployments","created_at":"2019-09-11T15:38:55Z","updated_at":"2019-09-29T20:31:18Z","pushed_at":"2019-09-29T20:31:16Z","git_url":"git://github.com/Rudolf31/1124569-nerds-26.git","ssh_url":"git@github.com:Rudolf31/1124569-nerds-26.git","clone_url":"https://github.com/Rudolf31/1124569-nerds-26.git","svn_url":"https://github.com/Rudolf31/1124569-nerds-26","homepage":null,"size":1421,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"fd6eb443595b3b3a205b8cd6f01c0511bd5f9960","user":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":207331990,"node_id":"MDEwOlJlcG9zaXRvcnkyMDczMzE5OTA=","name":"1124569-nerds-26","full_name":"htmlacademy-htmlcss/1124569-nerds-26","private":false,"owner":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-htmlcss/1124569-nerds-26","description":"Рудольф Шевченко","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/deployments","created_at":"2019-09-09T14:42:32Z","updated_at":"2019-09-26T10:18:53Z","pushed_at":"2019-09-29T20:32:24Z","git_url":"git://github.com/htmlacademy-htmlcss/1124569-nerds-26.git","ssh_url":"git@github.com:htmlacademy-htmlcss/1124569-nerds-26.git","clone_url":"https://github.com/htmlacademy-htmlcss/1124569-nerds-26.git","svn_url":"https://github.com/htmlacademy-htmlcss/1124569-nerds-26","homepage":"https://github.com/Rudolf31/1124569-nerds-26","size":1429,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/4"},"html":{"href":"https://github.com/htmlacademy-htmlcss/1124569-nerds-26/pull/4"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/issues/4"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26/statuses/cd209d5db40ecf58f2dd49b47c1c5bcfa5f9038f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 207331990,
"name": "htmlacademy-htmlcss/1124569-nerds-26",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/1124569-nerds-26"
}
|
{
"id": 34542700,
"login": "raccoonroman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34542700?",
"url": "https://api.github.com/users/raccoonroman"
}
|
{
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
}
| 2019-09-30T08:14:07 |
10522276419
|
{"actor":{"display_login":"raccoonroman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/comments/290443826","pull_request_review_id":245635206,"id":290443826,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDQ0MzgyNg==","diff_hunk":"@@ -5,50 +5,55 @@\n <meta charset=\"UTF-8\">\n <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\">\n <meta http-equiv=\"X-UA-Compatible\" content=\"ie=edge\">\n+ <link rel=\"stylesheet\"\n+ href=\"https://fonts.googleapis.com/css?family=Cuprum:400,400i,700|PT+Sans:400,700&display=swap&subset=cyrillic\">\n+ <link rel=\"stylesheet\" href=\"https://necolas.github.io/normalize.css/8.0.1/normalize.css\">\n+ <link rel=\"stylesheet\" href=\"css/style.css\">\n <title>HTML Academy: Техномарт</title>\n </head>\n \n <body>\n- <header class=\"site-header\">\n- <a class=\"logo\" href=\"index.html\">\n- <img class=\"logo__img\" src=\"#\" width=\"#\" height=\"#\" alt=\"Логотип интернет-магазина Техномарт\">\n- </a>\n+ <header class=\"header\">\n+ <div class=\"header__top-strip\">\n+ <a class=\"logo header__link_theme_red\" href=\"index.html\">\n+ <img class=\"logo__img\" src=\"img/logo.svg\" width=\"#\" height=\"#\" alt=\"Логотип интернет-магазина Техномарт\">\n+ </a>\n+\n+ <form class=\"search-form\" action=\"#\" method=\"#\">\n+ <input class=\"search-form__input\" type=\"search\">\n+ <button class=\"search-form__button\" type=\"submit\">Search</button>\n+ </form>\n \n- <form class=\"search-form\" action=\"#\" method=\"#\">\n- <input class=\"search-form__input\" type=\"search\">\n- <button class=\"search-form__button\" type=\"submit\">Search</button>\n- </form>\n+ <a class=\"header__link\" href=\"#\">Закладки: 0</a>\n+ <a class=\"header__link header__link_theme_red\" href=\"#\">Корзина: 0</a>\n+ <a class=\"header__link header__link_theme_green\" href=\"#\">Оформить заказ</a>\n+ </div>\n \n- <a class=\"bookmark-link\" href=\"#\">Закладки: 0</a>\n- <a class=\"basket-link\" href=\"#\">Корзина: 0</a>\n- <a class=\"order-link\" href=\"#\">Оформить заказ</a>\n+ <p class=\"header__title\">Интернет-магазин строительных материалов и инструментов для ремонта</p>","path":"catalog.html","position":39,"original_position":39,"commit_id":"053acce5891215f8744191a7825c4e9782e9974c","original_commit_id":"053acce5891215f8744191a7825c4e9782e9974c","user":{"login":"Lak0sta","id":29607180,"node_id":"MDQ6VXNlcjI5NjA3MTgw","avatar_url":"https://avatars1.githubusercontent.com/u/29607180?v=4","gravatar_id":"","url":"https://api.github.com/users/Lak0sta","html_url":"https://github.com/Lak0sta","followers_url":"https://api.github.com/users/Lak0sta/followers","following_url":"https://api.github.com/users/Lak0sta/following{/other_user}","gists_url":"https://api.github.com/users/Lak0sta/gists{/gist_id}","starred_url":"https://api.github.com/users/Lak0sta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lak0sta/subscriptions","organizations_url":"https://api.github.com/users/Lak0sta/orgs","repos_url":"https://api.github.com/users/Lak0sta/repos","events_url":"https://api.github.com/users/Lak0sta/events{/privacy}","received_events_url":"https://api.github.com/users/Lak0sta/received_events","type":"User","site_admin":false},"body":"Почему стал p?","created_at":"2019-06-04T18:49:55Z","updated_at":"2019-06-04T18:49:55Z","html_url":"https://github.com/htmlacademy-htmlcss/229191-technomart-25/pull/5#discussion_r290443826","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/comments/290443826"},"html":{"href":"https://github.com/htmlacademy-htmlcss/229191-technomart-25/pull/5#discussion_r290443826"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/5","id":284667393,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0NjY3Mzkz","html_url":"https://github.com/htmlacademy-htmlcss/229191-technomart-25/pull/5","diff_url":"https://github.com/htmlacademy-htmlcss/229191-technomart-25/pull/5.diff","patch_url":"https://github.com/htmlacademy-htmlcss/229191-technomart-25/pull/5.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/issues/5","number":5,"state":"open","locked":false,"title":"Основное задание: начинаем базовую стилизацию личного проекта","user":{"login":"PavelBalyakin","id":42373209,"node_id":"MDQ6VXNlcjQyMzczMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/42373209?v=4","gravatar_id":"","url":"https://api.github.com/users/PavelBalyakin","html_url":"https://github.com/PavelBalyakin","followers_url":"https://api.github.com/users/PavelBalyakin/followers","following_url":"https://api.github.com/users/PavelBalyakin/following{/other_user}","gists_url":"https://api.github.com/users/PavelBalyakin/gists{/gist_id}","starred_url":"https://api.github.com/users/PavelBalyakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PavelBalyakin/subscriptions","organizations_url":"https://api.github.com/users/PavelBalyakin/orgs","repos_url":"https://api.github.com/users/PavelBalyakin/repos","events_url":"https://api.github.com/users/PavelBalyakin/events{/privacy}","received_events_url":"https://api.github.com/users/PavelBalyakin/received_events","type":"User","site_admin":false},"body":"Простое задание: прописать у всех элементов текстовые свойства. Однако для меня это было самое непонятное и, возможно, сложное задание. Уверен, что построение сеток и декоративная стилизация не вызовет столько вопросов. \n\n---\n:mortar_board: [Основное задание: начинаем базовую стилизацию личного проекта](https://up.htmlacademy.ru/htmlcss/25/user/229191/tasks/12)\n\n:boom: https://htmlacademy-htmlcss.github.io/229191-technomart-25/5/","created_at":"2019-06-03T17:54:34Z","updated_at":"2019-06-04T18:49:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fb4bbb719242517aac3aa8703784f491d8a18df","assignee":{"login":"Lak0sta","id":29607180,"node_id":"MDQ6VXNlcjI5NjA3MTgw","avatar_url":"https://avatars1.githubusercontent.com/u/29607180?v=4","gravatar_id":"","url":"https://api.github.com/users/Lak0sta","html_url":"https://github.com/Lak0sta","followers_url":"https://api.github.com/users/Lak0sta/followers","following_url":"https://api.github.com/users/Lak0sta/following{/other_user}","gists_url":"https://api.github.com/users/Lak0sta/gists{/gist_id}","starred_url":"https://api.github.com/users/Lak0sta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lak0sta/subscriptions","organizations_url":"https://api.github.com/users/Lak0sta/orgs","repos_url":"https://api.github.com/users/Lak0sta/repos","events_url":"https://api.github.com/users/Lak0sta/events{/privacy}","received_events_url":"https://api.github.com/users/Lak0sta/received_events","type":"User","site_admin":false},"assignees":[{"login":"Lak0sta","id":29607180,"node_id":"MDQ6VXNlcjI5NjA3MTgw","avatar_url":"https://avatars1.githubusercontent.com/u/29607180?v=4","gravatar_id":"","url":"https://api.github.com/users/Lak0sta","html_url":"https://github.com/Lak0sta","followers_url":"https://api.github.com/users/Lak0sta/followers","following_url":"https://api.github.com/users/Lak0sta/following{/other_user}","gists_url":"https://api.github.com/users/Lak0sta/gists{/gist_id}","starred_url":"https://api.github.com/users/Lak0sta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lak0sta/subscriptions","organizations_url":"https://api.github.com/users/Lak0sta/orgs","repos_url":"https://api.github.com/users/Lak0sta/repos","events_url":"https://api.github.com/users/Lak0sta/events{/privacy}","received_events_url":"https://api.github.com/users/Lak0sta/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/5/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/5/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/issues/5/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/statuses/053acce5891215f8744191a7825c4e9782e9974c","head":{"label":"PavelBalyakin:master","ref":"master","sha":"053acce5891215f8744191a7825c4e9782e9974c","user":{"login":"PavelBalyakin","id":42373209,"node_id":"MDQ6VXNlcjQyMzczMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/42373209?v=4","gravatar_id":"","url":"https://api.github.com/users/PavelBalyakin","html_url":"https://github.com/PavelBalyakin","followers_url":"https://api.github.com/users/PavelBalyakin/followers","following_url":"https://api.github.com/users/PavelBalyakin/following{/other_user}","gists_url":"https://api.github.com/users/PavelBalyakin/gists{/gist_id}","starred_url":"https://api.github.com/users/PavelBalyakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PavelBalyakin/subscriptions","organizations_url":"https://api.github.com/users/PavelBalyakin/orgs","repos_url":"https://api.github.com/users/PavelBalyakin/repos","events_url":"https://api.github.com/users/PavelBalyakin/events{/privacy}","received_events_url":"https://api.github.com/users/PavelBalyakin/received_events","type":"User","site_admin":false},"repo":{"id":185715496,"node_id":"MDEwOlJlcG9zaXRvcnkxODU3MTU0OTY=","name":"6-technomart","full_name":"PavelBalyakin/6-technomart","private":false,"owner":{"login":"PavelBalyakin","id":42373209,"node_id":"MDQ6VXNlcjQyMzczMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/42373209?v=4","gravatar_id":"","url":"https://api.github.com/users/PavelBalyakin","html_url":"https://github.com/PavelBalyakin","followers_url":"https://api.github.com/users/PavelBalyakin/followers","following_url":"https://api.github.com/users/PavelBalyakin/following{/other_user}","gists_url":"https://api.github.com/users/PavelBalyakin/gists{/gist_id}","starred_url":"https://api.github.com/users/PavelBalyakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PavelBalyakin/subscriptions","organizations_url":"https://api.github.com/users/PavelBalyakin/orgs","repos_url":"https://api.github.com/users/PavelBalyakin/repos","events_url":"https://api.github.com/users/PavelBalyakin/events{/privacy}","received_events_url":"https://api.github.com/users/PavelBalyakin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PavelBalyakin/6-technomart","description":"Павел Балякин","fork":true,"url":"https://api.github.com/repos/PavelBalyakin/6-technomart","forks_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/forks","keys_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/teams","hooks_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/hooks","issue_events_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/issues/events{/number}","events_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/events","assignees_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/assignees{/user}","branches_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/branches{/branch}","tags_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/tags","blobs_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/git/refs{/sha}","trees_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/statuses/{sha}","languages_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/languages","stargazers_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/stargazers","contributors_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/contributors","subscribers_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/subscribers","subscription_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/subscription","commits_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/commits{/sha}","git_commits_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/git/commits{/sha}","comments_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/comments{/number}","issue_comment_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/issues/comments{/number}","contents_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/contents/{+path}","compare_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/merges","archive_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/downloads","issues_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/issues{/number}","pulls_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/pulls{/number}","milestones_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/milestones{/number}","notifications_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/labels{/name}","releases_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/releases{/id}","deployments_url":"https://api.github.com/repos/PavelBalyakin/6-technomart/deployments","created_at":"2019-05-09T02:55:43Z","updated_at":"2019-06-03T17:49:49Z","pushed_at":"2019-06-03T17:49:47Z","git_url":"git://github.com/PavelBalyakin/6-technomart.git","ssh_url":"git@github.com:PavelBalyakin/6-technomart.git","clone_url":"https://github.com/PavelBalyakin/6-technomart.git","svn_url":"https://github.com/PavelBalyakin/6-technomart","homepage":"","size":297,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"5bccf582860a6181e43bd352ad85a628ee73358f","user":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":185715338,"node_id":"MDEwOlJlcG9zaXRvcnkxODU3MTUzMzg=","name":"229191-technomart-25","full_name":"htmlacademy-htmlcss/229191-technomart-25","private":false,"owner":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-htmlcss/229191-technomart-25","description":"Павел Балякин","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/deployments","created_at":"2019-05-09T02:54:32Z","updated_at":"2019-05-24T16:31:37Z","pushed_at":"2019-06-03T17:57:44Z","git_url":"git://github.com/htmlacademy-htmlcss/229191-technomart-25.git","ssh_url":"git@github.com:htmlacademy-htmlcss/229191-technomart-25.git","clone_url":"https://github.com/htmlacademy-htmlcss/229191-technomart-25.git","svn_url":"https://github.com/htmlacademy-htmlcss/229191-technomart-25","homepage":"https://github.com/PavelBalyakin/229191-technomart-25","size":315,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/5"},"html":{"href":"https://github.com/htmlacademy-htmlcss/229191-technomart-25/pull/5"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/issues/5"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25/statuses/053acce5891215f8744191a7825c4e9782e9974c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 185715338,
"name": "htmlacademy-htmlcss/229191-technomart-25",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/229191-technomart-25"
}
|
{
"id": 29607180,
"login": "Lak0sta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29607180?",
"url": "https://api.github.com/users/Lak0sta"
}
|
{
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
}
| 2019-06-04T18:49:55 |
9757686852
|
{"actor":{"display_login":"Lak0sta"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/comments/286210860","pull_request_review_id":240282992,"id":286210860,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NjIxMDg2MA==","diff_hunk":"@@ -6,48 +6,97 @@\n </head>\n <body bgcolor=\"#a5d691\">\n <header class=\"main-header\">\n- <a class=\"header-logo\" href=\"index.html\"><img src=\"img/logo-technomart.svg\" width=\"109\" height=\"19\" alt=\"Логотип Техномарт\"></a>\n- <a class=\"search\" href=\"search.html\">Поиск</a>\n+ <a class=\"header-logo\" href=\"index.html\"><img src=\"img/logo-technomart.svg\" width=\"109\" height=\"19\" alt=\"Логотип магазина Техномарт, нажав на который, Вы можете перейти на главную страницу\"></a>\n+ <a class=\"search\" href=\"search.html\" aria-label=\"Поиск по сайту\">Поиск</a>\n <ul class=\"user-navigation\">\n- <li class=\"marker\"><a href=\"marker.html\">Закладки:0</a></li>\n- <li class=\"basket\"><a href=\"basket.html\">Корзина:10</a></li>\n- <li class=\"order\"><a href=\"order.html\">Оформить заказ</a></li>\n+ <li class=\"marker\"> <a href=\"marker.html\" area-label=\"Сохраненные, выбранные ранее товары\">Закладки:0</a></li>\n+ <li class=\"basket\"><a href=\"basket.html\" area-label=\"Товары, готовые к покупке\">Корзина:10</a></li>\n+ <li class=\"order\"><a href=\"order.html\" area-label=\"Оформеление заказа\">Оформить заказ</a></li>\n </ul>\n <h1 class=\"main-headline\">Интернет-магазин строительных материалов и инструментов для ремонта</h1>\n <address class=\"head-contacts\">г.Санкт-Петербург, ул. Б.Конюшенная,д.19/8</address>\n- <a href=\"tel:+7(812)555-05-55\">+7(812)555-05-55</a>\n+ <a href=\"tel:+7(812)555-05-55\" area-label=\"Контактный номер телефона\">+7(812)555-05-55</a>\n <ul class=\"personal-area-section\">\n- <li class=\"current-user\"><a href=\"current-user.html\">Равшан Джамшутович</a></li>\n- <li class=\"unlogin-link-user\"><a href=\"unlogin.html\">Выход</a></li>\n- <li class=\"order-user\"><a href=\"order-user.html\">Мои заказы</a></li>\n- <li class=\"personal-area\"><a href=\"personal-area.html\">Личный кабинет</a></li>\n+ <li class=\"current-user\">Равшан Джамшутович</li>\n+ <li class=\"unlogin-link-user\"><button class=\"button\" type=\"button\" area-label=\"Разлогиниться\"></button></li>","path":"catalog.html","position":26,"original_position":26,"commit_id":"1aef26d63f4f0a81d69eacfcfbd4da382e3a58b4","original_commit_id":"1aef26d63f4f0a81d69eacfcfbd4da382e3a58b4","user":{"login":"NebeLShaman","id":47223457,"node_id":"MDQ6VXNlcjQ3MjIzNDU3","avatar_url":"https://avatars0.githubusercontent.com/u/47223457?v=4","gravatar_id":"","url":"https://api.github.com/users/NebeLShaman","html_url":"https://github.com/NebeLShaman","followers_url":"https://api.github.com/users/NebeLShaman/followers","following_url":"https://api.github.com/users/NebeLShaman/following{/other_user}","gists_url":"https://api.github.com/users/NebeLShaman/gists{/gist_id}","starred_url":"https://api.github.com/users/NebeLShaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebeLShaman/subscriptions","organizations_url":"https://api.github.com/users/NebeLShaman/orgs","repos_url":"https://api.github.com/users/NebeLShaman/repos","events_url":"https://api.github.com/users/NebeLShaman/events{/privacy}","received_events_url":"https://api.github.com/users/NebeLShaman/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-05-21T20:30:18Z","updated_at":"2019-05-21T20:30:19Z","html_url":"https://github.com/htmlacademy-htmlcss/873825-technomart-25/pull/4#discussion_r286210860","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/comments/286210860"},"html":{"href":"https://github.com/htmlacademy-htmlcss/873825-technomart-25/pull/4#discussion_r286210860"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/4"}},"in_reply_to_id":286137677},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/4","id":280572971,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwNTcyOTcx","html_url":"https://github.com/htmlacademy-htmlcss/873825-technomart-25/pull/4","diff_url":"https://github.com/htmlacademy-htmlcss/873825-technomart-25/pull/4.diff","patch_url":"https://github.com/htmlacademy-htmlcss/873825-technomart-25/pull/4.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/issues/4","number":4,"state":"open","locked":false,"title":"Основное задание: продолжаем разметку личного проекта","user":{"login":"NebeLShaman","id":47223457,"node_id":"MDQ6VXNlcjQ3MjIzNDU3","avatar_url":"https://avatars0.githubusercontent.com/u/47223457?v=4","gravatar_id":"","url":"https://api.github.com/users/NebeLShaman","html_url":"https://github.com/NebeLShaman","followers_url":"https://api.github.com/users/NebeLShaman/followers","following_url":"https://api.github.com/users/NebeLShaman/following{/other_user}","gists_url":"https://api.github.com/users/NebeLShaman/gists{/gist_id}","starred_url":"https://api.github.com/users/NebeLShaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebeLShaman/subscriptions","organizations_url":"https://api.github.com/users/NebeLShaman/orgs","repos_url":"https://api.github.com/users/NebeLShaman/repos","events_url":"https://api.github.com/users/NebeLShaman/events{/privacy}","received_events_url":"https://api.github.com/users/NebeLShaman/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Основное задание: продолжаем разметку личного проекта](https://up.htmlacademy.ru/htmlcss/25/user/873825/tasks/9)\n\n:boom: https://htmlacademy-htmlcss.github.io/873825-technomart-25/4/","created_at":"2019-05-20T23:19:37Z","updated_at":"2019-05-21T20:30:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e35c48a2e4b57af156bacee1f0ecd8a03841267","assignee":{"login":"yukash12","id":13680198,"node_id":"MDQ6VXNlcjEzNjgwMTk4","avatar_url":"https://avatars0.githubusercontent.com/u/13680198?v=4","gravatar_id":"","url":"https://api.github.com/users/yukash12","html_url":"https://github.com/yukash12","followers_url":"https://api.github.com/users/yukash12/followers","following_url":"https://api.github.com/users/yukash12/following{/other_user}","gists_url":"https://api.github.com/users/yukash12/gists{/gist_id}","starred_url":"https://api.github.com/users/yukash12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yukash12/subscriptions","organizations_url":"https://api.github.com/users/yukash12/orgs","repos_url":"https://api.github.com/users/yukash12/repos","events_url":"https://api.github.com/users/yukash12/events{/privacy}","received_events_url":"https://api.github.com/users/yukash12/received_events","type":"User","site_admin":false},"assignees":[{"login":"yukash12","id":13680198,"node_id":"MDQ6VXNlcjEzNjgwMTk4","avatar_url":"https://avatars0.githubusercontent.com/u/13680198?v=4","gravatar_id":"","url":"https://api.github.com/users/yukash12","html_url":"https://github.com/yukash12","followers_url":"https://api.github.com/users/yukash12/followers","following_url":"https://api.github.com/users/yukash12/following{/other_user}","gists_url":"https://api.github.com/users/yukash12/gists{/gist_id}","starred_url":"https://api.github.com/users/yukash12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yukash12/subscriptions","organizations_url":"https://api.github.com/users/yukash12/orgs","repos_url":"https://api.github.com/users/yukash12/repos","events_url":"https://api.github.com/users/yukash12/events{/privacy}","received_events_url":"https://api.github.com/users/yukash12/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/4/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/4/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/issues/4/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/statuses/1aef26d63f4f0a81d69eacfcfbd4da382e3a58b4","head":{"label":"NebeLShaman:master","ref":"master","sha":"1aef26d63f4f0a81d69eacfcfbd4da382e3a58b4","user":{"login":"NebeLShaman","id":47223457,"node_id":"MDQ6VXNlcjQ3MjIzNDU3","avatar_url":"https://avatars0.githubusercontent.com/u/47223457?v=4","gravatar_id":"","url":"https://api.github.com/users/NebeLShaman","html_url":"https://github.com/NebeLShaman","followers_url":"https://api.github.com/users/NebeLShaman/followers","following_url":"https://api.github.com/users/NebeLShaman/following{/other_user}","gists_url":"https://api.github.com/users/NebeLShaman/gists{/gist_id}","starred_url":"https://api.github.com/users/NebeLShaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebeLShaman/subscriptions","organizations_url":"https://api.github.com/users/NebeLShaman/orgs","repos_url":"https://api.github.com/users/NebeLShaman/repos","events_url":"https://api.github.com/users/NebeLShaman/events{/privacy}","received_events_url":"https://api.github.com/users/NebeLShaman/received_events","type":"User","site_admin":false},"repo":{"id":185254458,"node_id":"MDEwOlJlcG9zaXRvcnkxODUyNTQ0NTg=","name":"873825-technomart-25","full_name":"NebeLShaman/873825-technomart-25","private":false,"owner":{"login":"NebeLShaman","id":47223457,"node_id":"MDQ6VXNlcjQ3MjIzNDU3","avatar_url":"https://avatars0.githubusercontent.com/u/47223457?v=4","gravatar_id":"","url":"https://api.github.com/users/NebeLShaman","html_url":"https://github.com/NebeLShaman","followers_url":"https://api.github.com/users/NebeLShaman/followers","following_url":"https://api.github.com/users/NebeLShaman/following{/other_user}","gists_url":"https://api.github.com/users/NebeLShaman/gists{/gist_id}","starred_url":"https://api.github.com/users/NebeLShaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebeLShaman/subscriptions","organizations_url":"https://api.github.com/users/NebeLShaman/orgs","repos_url":"https://api.github.com/users/NebeLShaman/repos","events_url":"https://api.github.com/users/NebeLShaman/events{/privacy}","received_events_url":"https://api.github.com/users/NebeLShaman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NebeLShaman/873825-technomart-25","description":"Яков Рыбаков","fork":true,"url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25","forks_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/forks","keys_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/teams","hooks_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/hooks","issue_events_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/issues/events{/number}","events_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/events","assignees_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/assignees{/user}","branches_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/branches{/branch}","tags_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/tags","blobs_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/git/refs{/sha}","trees_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/statuses/{sha}","languages_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/languages","stargazers_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/stargazers","contributors_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/contributors","subscribers_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/subscribers","subscription_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/subscription","commits_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/commits{/sha}","git_commits_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/git/commits{/sha}","comments_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/comments{/number}","issue_comment_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/issues/comments{/number}","contents_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/contents/{+path}","compare_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/merges","archive_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/downloads","issues_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/issues{/number}","pulls_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/pulls{/number}","milestones_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/milestones{/number}","notifications_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/labels{/name}","releases_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/releases{/id}","deployments_url":"https://api.github.com/repos/NebeLShaman/873825-technomart-25/deployments","created_at":"2019-05-06T18:57:27Z","updated_at":"2019-05-20T23:17:17Z","pushed_at":"2019-05-20T23:17:16Z","git_url":"git://github.com/NebeLShaman/873825-technomart-25.git","ssh_url":"git@github.com:NebeLShaman/873825-technomart-25.git","clone_url":"https://github.com/NebeLShaman/873825-technomart-25.git","svn_url":"https://github.com/NebeLShaman/873825-technomart-25","homepage":null,"size":727,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"8b8901df49662aa7f788766d337ddc6f6604498f","user":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":185253543,"node_id":"MDEwOlJlcG9zaXRvcnkxODUyNTM1NDM=","name":"873825-technomart-25","full_name":"htmlacademy-htmlcss/873825-technomart-25","private":false,"owner":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-htmlcss/873825-technomart-25","description":"Яков Рыбаков","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/deployments","created_at":"2019-05-06T18:50:37Z","updated_at":"2019-05-18T10:51:23Z","pushed_at":"2019-05-21T17:19:42Z","git_url":"git://github.com/htmlacademy-htmlcss/873825-technomart-25.git","ssh_url":"git@github.com:htmlacademy-htmlcss/873825-technomart-25.git","clone_url":"https://github.com/htmlacademy-htmlcss/873825-technomart-25.git","svn_url":"https://github.com/htmlacademy-htmlcss/873825-technomart-25","homepage":"https://github.com/NebeLShaman/873825-technomart-25","size":744,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/4"},"html":{"href":"https://github.com/htmlacademy-htmlcss/873825-technomart-25/pull/4"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/issues/4"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25/statuses/1aef26d63f4f0a81d69eacfcfbd4da382e3a58b4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 185253543,
"name": "htmlacademy-htmlcss/873825-technomart-25",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/873825-technomart-25"
}
|
{
"id": 47223457,
"login": "NebeLShaman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47223457?",
"url": "https://api.github.com/users/NebeLShaman"
}
|
{
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
}
| 2019-05-21T20:30:18 |
9670669286
|
{"actor":{"display_login":"NebeLShaman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/comments/265564521","pull_request_review_id":214502885,"id":265564521,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTU2NDUyMQ==","diff_hunk":"@@ -0,0 +1,733 @@\n+@font-face {\n+ font-family: \"Gilroy\";\n+ src: url(\"../fonts/gilroyextrabold.woff2\") format(\"woff2\"),\n+ url(\"../fonts/gilroyextrabold.woff\") format(\"woff\");\n+ font-weight: 800;\n+ font-style: normal;\n+}\n+\n+@font-face {\n+ font-family: \"Gilroy\";\n+ src: url(\"../fonts/gilroylight.woff2\") format(\"woff2\"),\n+ url(\"../fonts/gilroylight.woff\") format(\"woff\");\n+ font-weight: 300;\n+ font-style: normal;\n+}\n+\n+html {\n+ -webkit-box-sizing: border-box;\n+ -moz-box-sizing: border-box;\n+ box-sizing: border-box;\n+}\n+\n+*, *::before, *::after {\n+ -webkit-box-sizing: inherit;\n+ -moz-box-sizing: inherit;\n+ box-sizing: inherit;\n+}\n+\n+body {\n+ min-width: 1200px;\n+\n+ color: #000000;\n+ font-family: \"Open Sans\", Arial, sans-serif;\n+ font-size: 15px;\n+ line-height: 30px;\n+ font-weight: 300;\n+\n+ margin: 0;\n+}\n+\n+a {\n+ text-decoration: none;\n+}\n+\n+.visually-hidden {\n+ position: absolute;\n+ clip: rect(0 0 0 0);\n+ width: 1px;\n+ height: 1px;\n+ margin: -1px;\n+}\n+\n+.container {\n+ position: relative;\n+ width: 1160px;\n+ margin: 0 auto;\n+}\n+\n+.button {\n+ display: inline-block;\n+\n+ font-family: \"Gilroy\", Arial, sans-serif;\n+ font-size: 18px;\n+ line-height: 24px;\n+ font-weight: 800;\n+ letter-spacing: 3.6px;\n+ text-transform: uppercase;\n+ color: #000000;\n+\n+ background-color: transparent;\n+ cursor: pointer;\n+ border: none;\n+}\n+\n+.input-wrapper {\n+ margin: 0;\n+}\n+\n+.blocks-wrapper {\n+ display: flex;\n+ flex-wrap: wrap;\n+}\n+\n+.title {\n+ margin: 0;\n+\n+ font-family: \"Gilroy\", Arial, sans-serif;\n+ font-size: 47px;\n+ line-height: 48px;\n+ font-weight: 800;\n+ letter-spacing: 0.5px;\n+ color: #000000;\n+}\n+\n+/* Окончание общих стилей */\n+\n+.main-header {\n+ position: relative;\n+\n+ padding-right: 60px;\n+ padding-bottom: 30px;\n+ padding-left: 60px;\n+ margin-top: 40px;\n+\n+ background-color: rgba(240, 197, 46, 0.5);\n+}\n+\n+.logo {\n+ position: relative;\n+ top: -19px;\n+}\n+\n+.main-navigation {\n+ display: flex;\n+}\n+\n+.personal-navigation {\n+ display: flex;\n+ flex-wrap: wrap;\n+}\n+\n+.personal-navigation a {\n+ padding-left: 25px;\n+\n+ font-size: 15px;\n+ line-height: 30px;\n+ color: #000000;\n+ text-align: middle;\n+}\n+\n+.personal-navigation a:hover,\n+.personal-navigation a:focus {\n+ color: rgba(0, 0, 0, 0.6);\n+}\n+\n+.personal-navigation a:active {\n+ color: rgba(0, 0, 0, 0.3);\n+}\n+\n+.search-input {\n+ position: relative;\n+\n+ width: 355px;\n+ height: 49px;\n+\n+ font-size: 15px;\n+ line-height: 30px;\n+ font-weight: 300;\n+ color: #000000;\n+ vertical-align: middle;\n+\n+ background-color: transparent;\n+ \n+ border: none;\n+}\n+\n+.search-input::placeholder {\n+ font-size: 15px;\n+ line-height: 30px;\n+ color: rgba(0, 0, 0, 0.3);\n+}\n+\n+.search-input:hover::placeholder,\n+.search-input:focus::placeholder {\n+ color: rgba(0, 0, 0, 0.6);\n+}\n+\n+.site-navigation {\n+ display: flex;\n+ flex-wrap: wrap;\n+ margin: 0;\n+ padding: 0;\n+}\n+\n+.site-navigation-item {\n+ \n+ list-style: none;\n+}\n+\n+.site-navigation-link {\n+ font-family: \"Gilroy\", Arial, sans-serif;\n+ font-size: 18px;\n+ font-weight: 800;\n+ font-style: normal;\n+ font-stretch: normal;\n+ line-height: 1.33;\n+ letter-spacing: 3.6px;\n+ text-align: left;\n+ color: #000000;\n+ text-transform: uppercase;\n+}\n+\n+.site-navigation-submenu {\n+ position: absolute;\n+ display: flex;\n+ flex-direction: column;\n+ flex-wrap: wrap;\n+ padding: 0;\n+\n+ list-style: none;\n+\n+ display: none; /**/\n+}\n+\n+.site-navigation-submenu-item a {\n+ font-size: 15px;\n+ line-height: 36px;\n+ letter-spacing: 0.15px;\n+ font-weight: 300;\n+ color: #000000;\n+}\n+\n+.products-slider {\n+ margin-bottom: 105px;\n+}\n+\n+.promos-list {\n+ margin: 0;\n+ padding: 0;\n+}\n+\n+.promos-item {\n+ display: flex;\n+}\n+\n+.promo-image {\n+ margin-right: 125px;\n+}\n+\n+.promo-info-title {\n+ margin-bottom: 30px;\n+\n+ line-height: 56px;\n+}\n+\n+.promo-info-description {\n+ margin: 0;\n+}\n+\n+.promo-info-description:last-of-type {\n+ margin-bottom: 60px;\n+}\n+\n+.promo-info-button {\n+ margin-bottom: 70px;\n+}\n+\n+.promo-details {\n+ display: flex;\n+}\n+\n+.promo-details-item {\n+ display: flex;\n+ flex-direction: column-reverse;\n+ margin: 0\n+}\n+\n+.promo-details-item:not(:last-child) {\n+ margin-right: 80px;\n+}\n+\n+.promo-details-name {\n+ font-size: 13px;\n+ line-height: 20px;\n+ letter-spacing: 0.1px;\n+ font-weight: 300;\n+ color: #464646;\n+}\n+\n+.promo-details-value {\n+ margin: 0;\n+\n+ font-family: \"Gilroy\", Arial, sans-serif;\n+ font-size: 36px;\n+ line-height: 48px;\n+ letter-spacing: 0.36px;\n+ font-weight: 300;\n+ color: #000000;\n+}\n+\n+.slide-toggle-button {\n+ display: none;\n+}\n+\n+.slider-item:not(:first-child) {\n+ display: none;\n+}\n+\n+.categories-list {\n+ display: flex;\n+ flex-wrap: wrap;\n+ margin: 0;\n+ padding: 0;\n+ list-style: none;\n+\n+ margin-bottom: 100px; /* */\n+}\n+\n+.categories-item {\n+ position: relative;\n+\n+ width: 160px;\n+}\n+\n+.categories-item:not(:last-child) {\n+ margin-right: 40px;\n+}\n+\n+.categories-card {\n+ position: relative;\n+ display: flex;\n+ width: 160px;\n+ height: 160px;\n+ margin-bottom: 35px;\n+\n+ background-color: rgba(240, 197, 46, 0.5);\n+}\n+\n+.categories-card img {\n+ margin: auto;\n+}\n+\n+.categories-card-selfie img {\n+ position: absolute;\n+ bottom: 2px;\n+ left: 38px;\n+ right: 36px;\n+ width: 86px;\n+ height: 117px;\n+}\n+\n+.categories-card-cameras img {\n+ position: absolute;\n+ left: 49px;\n+ top: 0;\n+ bottom: 0;\n+ width: 71px;\n+ height: 87px;\n+}\n+\n+.categories-card-fitness img {\n+ width: 107px;\n+ height: 65px;\n+}\n+\n+.categories-card-smartwatch img {\n+ width: 56px;\n+ height: 98px;\n+}\n+\n+.categories-card-quadrocopters img {\n+ width: 132px;\n+ height: 69px;\n+}\n+\n+.category-name {\n+ margin: 0;\n+\n+ font-family: \"Gilroy\", Arial, sans-serif;\n+ font-size: 18px;\n+ line-height: 24px;\n+ font-weight: 800;\n+ letter-spacing: 0.2px;\n+ color: #000000;\n+}\n+\n+.services {\n+ min-height: 288px;\n+ margin-bottom: 95px;\n+ background-color: #e5e5e5;\n+}\n+\n+.services-slider {\n+ display: flex;\n+}\n+\n+.services-list {\n+ list-style: none;\n+}\n+\n+.services-item {\n+ position: relative;\n+ top: -40px;\n+}\n+\n+.services-controls {\n+ display: flex;\n+ flex-direction: column;\n+}\n+\n+.services-item-title {\n+ margin-bottom: 40px;\n+}\n+\n+.services-item-description {\n+ max-width: 430px;\n+ margin: 0;\n+}\n+\n+.partners {\n+ margin-bottom: 90px;\n+}\n+\n+.partners-list {\n+ display: flex;\n+ flex-wrap: wrap;\n+ margin: 0;\n+ padding: 0;\n+\n+ list-style: none;\n+}\n+\n+.partners-item:not(:last-child) {\n+ margin-right: 40px;\n+}\n+\n+.partners-link img {\n+ filter: saturate(0);\n+ opacity: 0.2;\n+}\n+\n+.about-us {\n+ max-width: 475px;\n+ margin-right: 120px;\n+}\n+\n+.about-us > p {\n+ margin-top: 0;\n+ margin-bottom: 50px;\n+}\n+\n+.about-us > p:last-of-type {\n+ margin-bottom: 90px;\n+}\n+\n+.about-us-title {\n+ margin-bottom: 60px;\n+}\n+\n+.about-partners {\n+ margin: 0;\n+ padding: 0;\n+}\n+\n+.about-partners-link {\n+ font-family: \"Gilroy\";\n+ font-size: 16px;\n+ line-height: 40px;\n+ font-weight: 800;\n+ color: #000000;\n+}\n+\n+.contacts {\n+ display: flex;\n+ flex-direction: column;\n+ flex-wrap: wrap;\n+ max-width: 560px;\n+}\n+\n+.contacts-title {\n+ margin-bottom: 60px;\n+}\n+\n+.contacts > p {\n+ margin-top: 0;\n+ margin-bottom: 50px;\n+}\n+\n+.contacts > p:last-of-type {\n+ margin-bottom: 45px;\n+}\n+\n+.contacts-map {\n+ display: block;\n+ margin-bottom: 30px;\n+}\n+\n+.contacts-button {\n+ margin-top: auto;\n+}\n+\n+.about-wrapper {\n+ margin-bottom: 90px;\n+}\n+\n+/* Стили каталога */\n+\n+.catalog-page-title {","path":"css/style.css","position":488,"original_position":488,"commit_id":"191aa0a2d031ee4679f178c4a9ffa10322fe0037","original_commit_id":"191aa0a2d031ee4679f178c4a9ffa10322fe0037","user":{"login":"sergeykravchenko","id":9842814,"node_id":"MDQ6VXNlcjk4NDI4MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false},"body":"если навести в инспекторе а родительский контейнер увидишь что маргин заголовка выпадает из него\r\nпоэтому лучше маргин топ убрать а его значение перенести в паддинг топ для catalog-title-contain\r\nбоковые маргин и у заголовка и у breafcrumbs также убрать и перенести значения в боковой паддинг для catalog-title-contain приплюсовав к этому еще по 20 от основного контейнера, т.к. 2 класс переопределяет его стили","created_at":"2019-03-14T13:22:19Z","updated_at":"2019-03-14T13:22:20Z","html_url":"https://github.com/htmlacademy-htmlcss/409751-device-24/pull/3#discussion_r265564521","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/comments/265564521"},"html":{"href":"https://github.com/htmlacademy-htmlcss/409751-device-24/pull/3#discussion_r265564521"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/3","id":261107768,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxMTA3NzY4","html_url":"https://github.com/htmlacademy-htmlcss/409751-device-24/pull/3","diff_url":"https://github.com/htmlacademy-htmlcss/409751-device-24/pull/3.diff","patch_url":"https://github.com/htmlacademy-htmlcss/409751-device-24/pull/3.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/issues/3","number":3,"state":"open","locked":false,"title":"базовая стилизация текста, начало сеток","user":{"login":"qrxt","id":46269438,"node_id":"MDQ6VXNlcjQ2MjY5NDM4","avatar_url":"https://avatars0.githubusercontent.com/u/46269438?v=4","gravatar_id":"","url":"https://api.github.com/users/qrxt","html_url":"https://github.com/qrxt","followers_url":"https://api.github.com/users/qrxt/followers","following_url":"https://api.github.com/users/qrxt/following{/other_user}","gists_url":"https://api.github.com/users/qrxt/gists{/gist_id}","starred_url":"https://api.github.com/users/qrxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qrxt/subscriptions","organizations_url":"https://api.github.com/users/qrxt/orgs","repos_url":"https://api.github.com/users/qrxt/repos","events_url":"https://api.github.com/users/qrxt/events{/privacy}","received_events_url":"https://api.github.com/users/qrxt/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-14T10:30:37Z","updated_at":"2019-03-14T13:22:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccd82f55aa661596acbbcbbef8c0bd7bb07165f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/3/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/3/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/issues/3/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/statuses/191aa0a2d031ee4679f178c4a9ffa10322fe0037","head":{"label":"qrxt:master","ref":"master","sha":"191aa0a2d031ee4679f178c4a9ffa10322fe0037","user":{"login":"qrxt","id":46269438,"node_id":"MDQ6VXNlcjQ2MjY5NDM4","avatar_url":"https://avatars0.githubusercontent.com/u/46269438?v=4","gravatar_id":"","url":"https://api.github.com/users/qrxt","html_url":"https://github.com/qrxt","followers_url":"https://api.github.com/users/qrxt/followers","following_url":"https://api.github.com/users/qrxt/following{/other_user}","gists_url":"https://api.github.com/users/qrxt/gists{/gist_id}","starred_url":"https://api.github.com/users/qrxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qrxt/subscriptions","organizations_url":"https://api.github.com/users/qrxt/orgs","repos_url":"https://api.github.com/users/qrxt/repos","events_url":"https://api.github.com/users/qrxt/events{/privacy}","received_events_url":"https://api.github.com/users/qrxt/received_events","type":"User","site_admin":false},"repo":{"id":174016809,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQwMTY4MDk=","name":"409751-device-24","full_name":"qrxt/409751-device-24","private":false,"owner":{"login":"qrxt","id":46269438,"node_id":"MDQ6VXNlcjQ2MjY5NDM4","avatar_url":"https://avatars0.githubusercontent.com/u/46269438?v=4","gravatar_id":"","url":"https://api.github.com/users/qrxt","html_url":"https://github.com/qrxt","followers_url":"https://api.github.com/users/qrxt/followers","following_url":"https://api.github.com/users/qrxt/following{/other_user}","gists_url":"https://api.github.com/users/qrxt/gists{/gist_id}","starred_url":"https://api.github.com/users/qrxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qrxt/subscriptions","organizations_url":"https://api.github.com/users/qrxt/orgs","repos_url":"https://api.github.com/users/qrxt/repos","events_url":"https://api.github.com/users/qrxt/events{/privacy}","received_events_url":"https://api.github.com/users/qrxt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qrxt/409751-device-24","description":"Eugene Kalinowski","fork":true,"url":"https://api.github.com/repos/qrxt/409751-device-24","forks_url":"https://api.github.com/repos/qrxt/409751-device-24/forks","keys_url":"https://api.github.com/repos/qrxt/409751-device-24/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qrxt/409751-device-24/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qrxt/409751-device-24/teams","hooks_url":"https://api.github.com/repos/qrxt/409751-device-24/hooks","issue_events_url":"https://api.github.com/repos/qrxt/409751-device-24/issues/events{/number}","events_url":"https://api.github.com/repos/qrxt/409751-device-24/events","assignees_url":"https://api.github.com/repos/qrxt/409751-device-24/assignees{/user}","branches_url":"https://api.github.com/repos/qrxt/409751-device-24/branches{/branch}","tags_url":"https://api.github.com/repos/qrxt/409751-device-24/tags","blobs_url":"https://api.github.com/repos/qrxt/409751-device-24/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qrxt/409751-device-24/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qrxt/409751-device-24/git/refs{/sha}","trees_url":"https://api.github.com/repos/qrxt/409751-device-24/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qrxt/409751-device-24/statuses/{sha}","languages_url":"https://api.github.com/repos/qrxt/409751-device-24/languages","stargazers_url":"https://api.github.com/repos/qrxt/409751-device-24/stargazers","contributors_url":"https://api.github.com/repos/qrxt/409751-device-24/contributors","subscribers_url":"https://api.github.com/repos/qrxt/409751-device-24/subscribers","subscription_url":"https://api.github.com/repos/qrxt/409751-device-24/subscription","commits_url":"https://api.github.com/repos/qrxt/409751-device-24/commits{/sha}","git_commits_url":"https://api.github.com/repos/qrxt/409751-device-24/git/commits{/sha}","comments_url":"https://api.github.com/repos/qrxt/409751-device-24/comments{/number}","issue_comment_url":"https://api.github.com/repos/qrxt/409751-device-24/issues/comments{/number}","contents_url":"https://api.github.com/repos/qrxt/409751-device-24/contents/{+path}","compare_url":"https://api.github.com/repos/qrxt/409751-device-24/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qrxt/409751-device-24/merges","archive_url":"https://api.github.com/repos/qrxt/409751-device-24/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qrxt/409751-device-24/downloads","issues_url":"https://api.github.com/repos/qrxt/409751-device-24/issues{/number}","pulls_url":"https://api.github.com/repos/qrxt/409751-device-24/pulls{/number}","milestones_url":"https://api.github.com/repos/qrxt/409751-device-24/milestones{/number}","notifications_url":"https://api.github.com/repos/qrxt/409751-device-24/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qrxt/409751-device-24/labels{/name}","releases_url":"https://api.github.com/repos/qrxt/409751-device-24/releases{/id}","deployments_url":"https://api.github.com/repos/qrxt/409751-device-24/deployments","created_at":"2019-03-05T20:35:35Z","updated_at":"2019-03-14T10:26:08Z","pushed_at":"2019-03-14T10:26:06Z","git_url":"git://github.com/qrxt/409751-device-24.git","ssh_url":"git@github.com:qrxt/409751-device-24.git","clone_url":"https://github.com/qrxt/409751-device-24.git","svn_url":"https://github.com/qrxt/409751-device-24","homepage":null,"size":557,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"c114d48b6b8411e4ad60da115a5600099e416db7","user":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":173974299,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM5NzQyOTk=","name":"409751-device-24","full_name":"htmlacademy-htmlcss/409751-device-24","private":false,"owner":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-htmlcss/409751-device-24","description":"Eugene Kalinowski","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/deployments","created_at":"2019-03-05T15:41:13Z","updated_at":"2019-03-05T15:41:20Z","pushed_at":"2019-03-14T10:30:38Z","git_url":"git://github.com/htmlacademy-htmlcss/409751-device-24.git","ssh_url":"git@github.com:htmlacademy-htmlcss/409751-device-24.git","clone_url":"https://github.com/htmlacademy-htmlcss/409751-device-24.git","svn_url":"https://github.com/htmlacademy-htmlcss/409751-device-24","homepage":null,"size":3,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/3"},"html":{"href":"https://github.com/htmlacademy-htmlcss/409751-device-24/pull/3"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/issues/3"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24/statuses/191aa0a2d031ee4679f178c4a9ffa10322fe0037"}},"author_association":"NONE"}}
|
{
"id": 173974299,
"name": "htmlacademy-htmlcss/409751-device-24",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/409751-device-24"
}
|
{
"id": 9842814,
"login": "sergeykravchenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9842814?",
"url": "https://api.github.com/users/sergeykravchenko"
}
|
{
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
}
| 2019-03-14T13:22:19 |
9242979923
|
{"actor":{"display_login":"sergeykravchenko"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/comments/284406617","pull_request_review_id":238001993,"id":284406617,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDQwNjYxNw==","diff_hunk":"@@ -6,7 +6,155 @@\n </head>\n <body>\n \n- <p>Репозиторий создан для обучения на профессиональном онлайн‑курсе «<a href=\"https://htmlacademy.ru/intensive/htmlcss\">HTML и CSS, уровень 1</a>».</p>\n \n+ <header class=\"header\">\n+\n+ <!--Как лучше оформить контейнер ниже, в тэг nav или div?\n+ И как луше назвать его?-->\n+ <div class=\"top-navigation\">\n+ <a class=\"header-logo\">\n+ <img src=\"img/index-logo.svg\" alt=\"Логотип «Техномарт»\">\n+ </a>\n+ <!-- Элементы ниже нужно объединить в один контейнер или нет?\n+ и какие еще классы нужны добавить этим ссылка?-->\n+ <p>Поиск</p>\n+ <a class=\"button\" href=\"bookmarks.html\">Закладки</a>\n+ <a class=\"button\" href=\"basket.html\">Корзина</a>\n+ <a class=\"button\" href=\"checkout.html\">Оформить заказ</a>\n+ </div>\n+\n+ <!-- Какой тэг лучше всего использовать для текста ниже? абзац, тэг <b>?\n+ Или может сделать его заголовком h1?-->\n+ <p>\n+ Интернет-магазин<br>\n+ строительных материалов<br>\n+ и инструментов для ремонта\n+ </p>\n+\n+ <div class=\"contact-info\">\n+ <span class=\"contact-phone\">+7 (812) 555-05-55</span>\n+ <p>г. Санкт-Петербург, ул. Б. Конюшенная, д. 19/8</p>\n+ </div>\n+ <!-- Нужно ли элементы списка ниже сделать ссылками?\n+ В барбершопе этого не сделали, но ведь по логике\n+ если JS не сработает и попап не всплывет,\n+ то должна открыться отдельная страница со входом или регистрацией-->\n+ <ul class=\"user-navigation\">\n+ <li class=\"login-link\">Вход</li>\n+ <li class=\"register-link\">Регистрация</li>\n+ </ul>\n+\n+\n+ <nav class=\"main-navigation\">\n+ <ul class=\"site-navigation\">\n+ <li><a href=\"index.html\">Главная</a></li>\n+ <li><a href=\"company.html\">Компания</a></li>\n+ <li><a href=\"catalog.html\">Каталог</a></li>\n+ <li><a href=\"news.html\">Новости</a></li>\n+ <li><a href=\"special_offers.html\">Спецпредложения</a></li>\n+ <li><a href=\"delivery.html\">Доставка</a></li>\n+ <li><a href=\"contacts.html\">Контакты</a></li>\n+ </ul>\n+ </nav>\n+ </header>\n+\n+\n+ <main class=\"conteiner\">\n+\n+ <h1 class=\"visually-hidden\">Интернет-магазин Техномарт</h1>\n+\n+ <section class=\"company\">\n+ <h2>Компания «Техномарт»</h2>\n+ <p>\n+ Настоящий мужской шоппинг начинается здесь! Огромный выбор товаров для ремонта и<br>\n+ строительства не оставит равнодушными любителей сэкономить на гастарбайтерах.\n+ </p>\n+ <p>\n+ Мы можем доставить ваш товар в самые отдаленные точки России!<br>\n+ Техномарт работает со многими транспортными компаниями:\n+ </p>\n+ <ul class=\"transport-list\">\n+ <li>Деловые линии</li>\n+ <li>Автотрейдинг</li>\n+ <li>ЖелДорЭкспедиция</li>\n+ </ul>\n+ <a class=\"button\" href=\"company.html\">Подробнее о компании</a>\n+ </section>\n+\n+ <section class=\"contacts\">\n+ <h2>Контакты</h2>\n+ <p>\n+ Вы можете забрать товар сами,<br>\n+ заехав к нам в офис:\n+ </p>\n+ <a class=\"button\" href=\"map.html\">\n+ <img src=\"img/map.svg\" alt=\"г. Санкт-Петербург, ул. Б. Конюшенная, д. 19/8\">\n+ </a>\n+ <a class=\"button\" href=\"#\">Заблудились? Напишите нам!</a>\n+ </section>\n+\n+ </main>\n+\n+\n+ <footer class=\"footer\">\n+\n+ <section class=\"top-footer\">\n+ <a class=\"footer-logo\">\n+ <img src=\"img/index-logo.svg\" alt=\"Логотип «Техномарт»\">\n+ </a>\n+ <p class=\"footer-contact\">\n+ г. Санкт-Петербург, ул. Б. Конюшенная, д. 19/8<br>\n+ +7 (812) 555-05-55\n+ </p>\n+ <!-- правильно ли я сделал, разбив навигацию на 2 списка?","path":"index.html","position":105,"original_position":105,"commit_id":"80af62b8a74d4eb212efcda7b6e0b2f3b4e67742","original_commit_id":"80af62b8a74d4eb212efcda7b6e0b2f3b4e67742","user":{"login":"MrJeffry","id":13581660,"node_id":"MDQ6VXNlcjEzNTgxNjYw","avatar_url":"https://avatars3.githubusercontent.com/u/13581660?v=4","gravatar_id":"","url":"https://api.github.com/users/MrJeffry","html_url":"https://github.com/MrJeffry","followers_url":"https://api.github.com/users/MrJeffry/followers","following_url":"https://api.github.com/users/MrJeffry/following{/other_user}","gists_url":"https://api.github.com/users/MrJeffry/gists{/gist_id}","starred_url":"https://api.github.com/users/MrJeffry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrJeffry/subscriptions","organizations_url":"https://api.github.com/users/MrJeffry/orgs","repos_url":"https://api.github.com/users/MrJeffry/repos","events_url":"https://api.github.com/users/MrJeffry/events{/privacy}","received_events_url":"https://api.github.com/users/MrJeffry/received_events","type":"User","site_admin":false},"body":"Не отстилизовать там один список","created_at":"2019-05-15T19:04:49Z","updated_at":"2019-05-15T19:05:30Z","html_url":"https://github.com/htmlacademy-htmlcss/1012123-technomart-25/pull/2#discussion_r284406617","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/comments/284406617"},"html":{"href":"https://github.com/htmlacademy-htmlcss/1012123-technomart-25/pull/2#discussion_r284406617"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/2","id":278891407,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4ODkxNDA3","html_url":"https://github.com/htmlacademy-htmlcss/1012123-technomart-25/pull/2","diff_url":"https://github.com/htmlacademy-htmlcss/1012123-technomart-25/pull/2.diff","patch_url":"https://github.com/htmlacademy-htmlcss/1012123-technomart-25/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/issues/2","number":2,"state":"open","locked":false,"title":"Основное задание: начинаем разметку личного проекта","user":{"login":"Nattan1el","id":48183047,"node_id":"MDQ6VXNlcjQ4MTgzMDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/48183047?v=4","gravatar_id":"","url":"https://api.github.com/users/Nattan1el","html_url":"https://github.com/Nattan1el","followers_url":"https://api.github.com/users/Nattan1el/followers","following_url":"https://api.github.com/users/Nattan1el/following{/other_user}","gists_url":"https://api.github.com/users/Nattan1el/gists{/gist_id}","starred_url":"https://api.github.com/users/Nattan1el/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nattan1el/subscriptions","organizations_url":"https://api.github.com/users/Nattan1el/orgs","repos_url":"https://api.github.com/users/Nattan1el/repos","events_url":"https://api.github.com/users/Nattan1el/events{/privacy}","received_events_url":"https://api.github.com/users/Nattan1el/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Основное задание: начинаем разметку личного проекта](https://up.htmlacademy.ru/htmlcss/25/user/1012123/tasks/3)","created_at":"2019-05-14T23:57:56Z","updated_at":"2019-05-15T19:05:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c82fb1f6be385e09ed1d1d92d71a12b8daaf9904","assignee":{"login":"MrJeffry","id":13581660,"node_id":"MDQ6VXNlcjEzNTgxNjYw","avatar_url":"https://avatars3.githubusercontent.com/u/13581660?v=4","gravatar_id":"","url":"https://api.github.com/users/MrJeffry","html_url":"https://github.com/MrJeffry","followers_url":"https://api.github.com/users/MrJeffry/followers","following_url":"https://api.github.com/users/MrJeffry/following{/other_user}","gists_url":"https://api.github.com/users/MrJeffry/gists{/gist_id}","starred_url":"https://api.github.com/users/MrJeffry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrJeffry/subscriptions","organizations_url":"https://api.github.com/users/MrJeffry/orgs","repos_url":"https://api.github.com/users/MrJeffry/repos","events_url":"https://api.github.com/users/MrJeffry/events{/privacy}","received_events_url":"https://api.github.com/users/MrJeffry/received_events","type":"User","site_admin":false},"assignees":[{"login":"MrJeffry","id":13581660,"node_id":"MDQ6VXNlcjEzNTgxNjYw","avatar_url":"https://avatars3.githubusercontent.com/u/13581660?v=4","gravatar_id":"","url":"https://api.github.com/users/MrJeffry","html_url":"https://github.com/MrJeffry","followers_url":"https://api.github.com/users/MrJeffry/followers","following_url":"https://api.github.com/users/MrJeffry/following{/other_user}","gists_url":"https://api.github.com/users/MrJeffry/gists{/gist_id}","starred_url":"https://api.github.com/users/MrJeffry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrJeffry/subscriptions","organizations_url":"https://api.github.com/users/MrJeffry/orgs","repos_url":"https://api.github.com/users/MrJeffry/repos","events_url":"https://api.github.com/users/MrJeffry/events{/privacy}","received_events_url":"https://api.github.com/users/MrJeffry/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/statuses/80af62b8a74d4eb212efcda7b6e0b2f3b4e67742","head":{"label":"Nattan1el:master","ref":"master","sha":"80af62b8a74d4eb212efcda7b6e0b2f3b4e67742","user":{"login":"Nattan1el","id":48183047,"node_id":"MDQ6VXNlcjQ4MTgzMDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/48183047?v=4","gravatar_id":"","url":"https://api.github.com/users/Nattan1el","html_url":"https://github.com/Nattan1el","followers_url":"https://api.github.com/users/Nattan1el/followers","following_url":"https://api.github.com/users/Nattan1el/following{/other_user}","gists_url":"https://api.github.com/users/Nattan1el/gists{/gist_id}","starred_url":"https://api.github.com/users/Nattan1el/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nattan1el/subscriptions","organizations_url":"https://api.github.com/users/Nattan1el/orgs","repos_url":"https://api.github.com/users/Nattan1el/repos","events_url":"https://api.github.com/users/Nattan1el/events{/privacy}","received_events_url":"https://api.github.com/users/Nattan1el/received_events","type":"User","site_admin":false},"repo":{"id":185267778,"node_id":"MDEwOlJlcG9zaXRvcnkxODUyNjc3Nzg=","name":"1012123-technomart-25","full_name":"Nattan1el/1012123-technomart-25","private":false,"owner":{"login":"Nattan1el","id":48183047,"node_id":"MDQ6VXNlcjQ4MTgzMDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/48183047?v=4","gravatar_id":"","url":"https://api.github.com/users/Nattan1el","html_url":"https://github.com/Nattan1el","followers_url":"https://api.github.com/users/Nattan1el/followers","following_url":"https://api.github.com/users/Nattan1el/following{/other_user}","gists_url":"https://api.github.com/users/Nattan1el/gists{/gist_id}","starred_url":"https://api.github.com/users/Nattan1el/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nattan1el/subscriptions","organizations_url":"https://api.github.com/users/Nattan1el/orgs","repos_url":"https://api.github.com/users/Nattan1el/repos","events_url":"https://api.github.com/users/Nattan1el/events{/privacy}","received_events_url":"https://api.github.com/users/Nattan1el/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Nattan1el/1012123-technomart-25","description":"Илья Чугунин","fork":true,"url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25","forks_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/forks","keys_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/teams","hooks_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/hooks","issue_events_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/issues/events{/number}","events_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/events","assignees_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/assignees{/user}","branches_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/branches{/branch}","tags_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/tags","blobs_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/statuses/{sha}","languages_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/languages","stargazers_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/stargazers","contributors_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/contributors","subscribers_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/subscribers","subscription_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/subscription","commits_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/contents/{+path}","compare_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/merges","archive_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/downloads","issues_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/issues{/number}","pulls_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/pulls{/number}","milestones_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/milestones{/number}","notifications_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/labels{/name}","releases_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/releases{/id}","deployments_url":"https://api.github.com/repos/Nattan1el/1012123-technomart-25/deployments","created_at":"2019-05-06T20:34:31Z","updated_at":"2019-05-14T23:56:01Z","pushed_at":"2019-05-14T23:55:59Z","git_url":"git://github.com/Nattan1el/1012123-technomart-25.git","ssh_url":"git@github.com:Nattan1el/1012123-technomart-25.git","clone_url":"https://github.com/Nattan1el/1012123-technomart-25.git","svn_url":"https://github.com/Nattan1el/1012123-technomart-25","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"4e8a5c55947f50ebc68a31668e5107092e536383","user":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":185265466,"node_id":"MDEwOlJlcG9zaXRvcnkxODUyNjU0NjY=","name":"1012123-technomart-25","full_name":"htmlacademy-htmlcss/1012123-technomart-25","private":false,"owner":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-htmlcss/1012123-technomart-25","description":"Илья Чугунин","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/deployments","created_at":"2019-05-06T20:17:18Z","updated_at":"2019-05-07T14:08:33Z","pushed_at":"2019-05-14T23:57:57Z","git_url":"git://github.com/htmlacademy-htmlcss/1012123-technomart-25.git","ssh_url":"git@github.com:htmlacademy-htmlcss/1012123-technomart-25.git","clone_url":"https://github.com/htmlacademy-htmlcss/1012123-technomart-25.git","svn_url":"https://github.com/htmlacademy-htmlcss/1012123-technomart-25","homepage":"https://github.com/Nattan1el/1012123-technomart-25","size":7,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/2"},"html":{"href":"https://github.com/htmlacademy-htmlcss/1012123-technomart-25/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25/statuses/80af62b8a74d4eb212efcda7b6e0b2f3b4e67742"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 185265466,
"name": "htmlacademy-htmlcss/1012123-technomart-25",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/1012123-technomart-25"
}
|
{
"id": 13581660,
"login": "MrJeffry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13581660?",
"url": "https://api.github.com/users/MrJeffry"
}
|
{
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
}
| 2019-05-15T19:04:49 |
9633614017
|
{"actor":{"display_login":"MrJeffry"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/comments/256557742","pull_request_review_id":203403543,"id":256557742,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjU1Nzc0Mg==","diff_hunk":"@@ -20,35 +24,38 @@\n <li><a class=\"basket-link\" href=\"basket.html\">Корзина</a></li>\n </ul>\n </nav>\n+ </div>\n </header>\n <main class=\"container\">\n- <ul>\n- <li><b>Долго, дорого, скрупулезно.</b>\n- <p>Математически выверенный дизайн для вашего сайта или мобильного приложения.</p>\n- <a class=\"button\" href=\"#\">УЗНАТЬ БОЛЬШЕ</a></li>\n- <li><b>Любим математику как никто другой</b>\n- <p>Никакого креатива, только математические формулы для расчета идеальных пропорций.</p>\n- <a class=\"button\" href=\"#\">УЗНАТЬ БОЛЬШЕ</a></li>\n- <li><b>Только ночь, только хардкор</b>\n- <p>Работать днем, как все? Мы против этого. Ближе к полуночи работа только начинается.</p>\n- <a class=\"button\" href=\"#\">УЗНАТЬ БОЛЬШЕ</a></li>\n+<section class=\"features\">\n+ <ul class=\"features-list\">\n+ <li><b class=\"cap\">Долго, дорого, скрупулезно.</b>\n+ <p class=\"style-cap\">Математически выверенный дизайн для вашего сайта или мобильного приложения.</p>\n+ <a class=\"button-style1\" href=\"#\">УЗНАТЬ БОЛЬШЕ</a></li>\n+ <li><b class=\"cap\"> Любим математику как никто другой</b>\n+ <p class=\"style-cap\">Никакого креатива, только математические формулы для расчета идеальных пропорций.</p>\n+ <a class=\"button-style1\" href=\"#\">УЗНАТЬ БОЛЬШЕ</a></li>\n+ <li><b class=\"cap\">Только ночь, только хардкор</b>\n+ <p class=\"style-cap\">Работать днем, как все? Мы против этого. Ближе к полуночи работа только начинается.</p>\n+ <a class=\"button-style1\" href=\"#\">УЗНАТЬ БОЛЬШЕ</a></li>\n </ul>\n <ul class=\"list\">\n <li><img src=\"img/illustration-1.png\" alt=\"ВЕБ-САЙТЫ\">\n- <b>ВЕБ-САЙТЫ</b>\n- <p>Мир никогда не будет прежним после того как увидит ваш сайт!</p>\n- <a class=\"button\" href=\"#\">Заказать</a></li>\n+ <b class=\"services\">ВЕБ-САЙТЫ</b>\n+ <p class=\"style-cap1\">Мир никогда не будет прежним после того как увидит ваш сайт!</p>\n+ <a class=\"button-style1\" href=\"#\">Заказать</a></li>\n <li><img src=\"img/illustration-2.png\"alt=\"ПРИЛОЖЕНИЯ\">\n- <b>ПРИЛОЖЕНИЯ</b>\n- <p>Покорите топ-10 приложений в AppStore и Google Play</p>\n- <a class=\"button\" href=\"#\">Заказать</a></li>\n+ <b class=\"services\">ПРИЛОЖЕНИЯ</b>\n+ <p class=\"style-cap1\">Покорите топ-10 приложений в AppStore и Google Play</p>\n+ <a class=\"button-style2\" href=\"#\">Заказать</a></li>\n <li><img src=\"img/illustration-3.png\"alt=\"ПРЕЗЕНТАЦИЯ\">\n- <b>ПРЕЗЕНТАЦИЯ</b>\n- <p>Вы даже не подозреваете, насколько вы изумительны!</p>\n- <a class=\"button\" href=\"#\">Заказать</a></li>\n+ <b class=\"services\">ПРЕЗЕНТАЦИЯ</b>\n+ <p class=\"style-cap1\">Вы даже не подозреваете, насколько вы изумительны!</p>\n+ <a class=\"button-style3\" href=\"#\">Заказать</a></li>\n </ul>\n+</section>\n \n- <h2>Мы — маленькая, но гордая дизайн-студия из Краснодара. </h2>\n+ <h2 class=\"services-style\">Мы — маленькая, но гордая дизайн-студия из Краснодара. </h2>\n <p>Исповедуем принципы минимализма и чистоты. Ставим математический расчет превыше креатива. Работаем не покладая рук, как роботы.</p>\n <h5>Выполняем заказы на разработку:</h5>","path":"index.html","position":74,"original_position":74,"commit_id":"f77b884d38f58d9413e17530722db28c23263a0f","original_commit_id":"f77b884d38f58d9413e17530722db28c23263a0f","user":{"login":"DariaKliukhina","id":25896538,"node_id":"MDQ6VXNlcjI1ODk2NTM4","avatar_url":"https://avatars1.githubusercontent.com/u/25896538?v=4","gravatar_id":"","url":"https://api.github.com/users/DariaKliukhina","html_url":"https://github.com/DariaKliukhina","followers_url":"https://api.github.com/users/DariaKliukhina/followers","following_url":"https://api.github.com/users/DariaKliukhina/following{/other_user}","gists_url":"https://api.github.com/users/DariaKliukhina/gists{/gist_id}","starred_url":"https://api.github.com/users/DariaKliukhina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DariaKliukhina/subscriptions","organizations_url":"https://api.github.com/users/DariaKliukhina/orgs","repos_url":"https://api.github.com/users/DariaKliukhina/repos","events_url":"https://api.github.com/users/DariaKliukhina/events{/privacy}","received_events_url":"https://api.github.com/users/DariaKliukhina/received_events","type":"User","site_admin":false},"body":"Для этого заголовка вообще стили не прописаны","created_at":"2019-02-13T19:41:29Z","updated_at":"2019-02-13T19:58:18Z","html_url":"https://github.com/htmlacademy-htmlcss/866569-nerds-24/pull/6#discussion_r256557742","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/comments/256557742"},"html":{"href":"https://github.com/htmlacademy-htmlcss/866569-nerds-24/pull/6#discussion_r256557742"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/6","id":251692127,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNjkyMTI3","html_url":"https://github.com/htmlacademy-htmlcss/866569-nerds-24/pull/6","diff_url":"https://github.com/htmlacademy-htmlcss/866569-nerds-24/pull/6.diff","patch_url":"https://github.com/htmlacademy-htmlcss/866569-nerds-24/pull/6.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/issues/6","number":6,"state":"open","locked":false,"title":"Основное задание: начинаем базовую стилизацию личного проекта","user":{"login":"Leonid163","id":46902771,"node_id":"MDQ6VXNlcjQ2OTAyNzcx","avatar_url":"https://avatars1.githubusercontent.com/u/46902771?v=4","gravatar_id":"","url":"https://api.github.com/users/Leonid163","html_url":"https://github.com/Leonid163","followers_url":"https://api.github.com/users/Leonid163/followers","following_url":"https://api.github.com/users/Leonid163/following{/other_user}","gists_url":"https://api.github.com/users/Leonid163/gists{/gist_id}","starred_url":"https://api.github.com/users/Leonid163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leonid163/subscriptions","organizations_url":"https://api.github.com/users/Leonid163/orgs","repos_url":"https://api.github.com/users/Leonid163/repos","events_url":"https://api.github.com/users/Leonid163/events{/privacy}","received_events_url":"https://api.github.com/users/Leonid163/received_events","type":"User","site_admin":false},"body":"CSS добавил\n\n---\n:mortar_board: [Основное задание: начинаем базовую стилизацию личного проекта](https://up.htmlacademy.ru/htmlcss/24/user/866569/tasks/12)\n\n:boom: https://htmlacademy-htmlcss.github.io/866569-nerds-24/6/","created_at":"2019-02-09T19:06:08Z","updated_at":"2019-02-13T19:58:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"054ba6cb82b6db3e8f1422fedc5c8c41c7efb72d","assignee":{"login":"DariaKliukhina","id":25896538,"node_id":"MDQ6VXNlcjI1ODk2NTM4","avatar_url":"https://avatars1.githubusercontent.com/u/25896538?v=4","gravatar_id":"","url":"https://api.github.com/users/DariaKliukhina","html_url":"https://github.com/DariaKliukhina","followers_url":"https://api.github.com/users/DariaKliukhina/followers","following_url":"https://api.github.com/users/DariaKliukhina/following{/other_user}","gists_url":"https://api.github.com/users/DariaKliukhina/gists{/gist_id}","starred_url":"https://api.github.com/users/DariaKliukhina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DariaKliukhina/subscriptions","organizations_url":"https://api.github.com/users/DariaKliukhina/orgs","repos_url":"https://api.github.com/users/DariaKliukhina/repos","events_url":"https://api.github.com/users/DariaKliukhina/events{/privacy}","received_events_url":"https://api.github.com/users/DariaKliukhina/received_events","type":"User","site_admin":false},"assignees":[{"login":"DariaKliukhina","id":25896538,"node_id":"MDQ6VXNlcjI1ODk2NTM4","avatar_url":"https://avatars1.githubusercontent.com/u/25896538?v=4","gravatar_id":"","url":"https://api.github.com/users/DariaKliukhina","html_url":"https://github.com/DariaKliukhina","followers_url":"https://api.github.com/users/DariaKliukhina/followers","following_url":"https://api.github.com/users/DariaKliukhina/following{/other_user}","gists_url":"https://api.github.com/users/DariaKliukhina/gists{/gist_id}","starred_url":"https://api.github.com/users/DariaKliukhina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DariaKliukhina/subscriptions","organizations_url":"https://api.github.com/users/DariaKliukhina/orgs","repos_url":"https://api.github.com/users/DariaKliukhina/repos","events_url":"https://api.github.com/users/DariaKliukhina/events{/privacy}","received_events_url":"https://api.github.com/users/DariaKliukhina/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/6/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/6/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/issues/6/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/statuses/f77b884d38f58d9413e17530722db28c23263a0f","head":{"label":"Leonid163:master","ref":"master","sha":"f77b884d38f58d9413e17530722db28c23263a0f","user":{"login":"Leonid163","id":46902771,"node_id":"MDQ6VXNlcjQ2OTAyNzcx","avatar_url":"https://avatars1.githubusercontent.com/u/46902771?v=4","gravatar_id":"","url":"https://api.github.com/users/Leonid163","html_url":"https://github.com/Leonid163","followers_url":"https://api.github.com/users/Leonid163/followers","following_url":"https://api.github.com/users/Leonid163/following{/other_user}","gists_url":"https://api.github.com/users/Leonid163/gists{/gist_id}","starred_url":"https://api.github.com/users/Leonid163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leonid163/subscriptions","organizations_url":"https://api.github.com/users/Leonid163/orgs","repos_url":"https://api.github.com/users/Leonid163/repos","events_url":"https://api.github.com/users/Leonid163/events{/privacy}","received_events_url":"https://api.github.com/users/Leonid163/received_events","type":"User","site_admin":false},"repo":{"id":166955188,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY5NTUxODg=","name":"866569-nerds-24","full_name":"Leonid163/866569-nerds-24","private":false,"owner":{"login":"Leonid163","id":46902771,"node_id":"MDQ6VXNlcjQ2OTAyNzcx","avatar_url":"https://avatars1.githubusercontent.com/u/46902771?v=4","gravatar_id":"","url":"https://api.github.com/users/Leonid163","html_url":"https://github.com/Leonid163","followers_url":"https://api.github.com/users/Leonid163/followers","following_url":"https://api.github.com/users/Leonid163/following{/other_user}","gists_url":"https://api.github.com/users/Leonid163/gists{/gist_id}","starred_url":"https://api.github.com/users/Leonid163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leonid163/subscriptions","organizations_url":"https://api.github.com/users/Leonid163/orgs","repos_url":"https://api.github.com/users/Leonid163/repos","events_url":"https://api.github.com/users/Leonid163/events{/privacy}","received_events_url":"https://api.github.com/users/Leonid163/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Leonid163/866569-nerds-24","description":"Леонид","fork":true,"url":"https://api.github.com/repos/Leonid163/866569-nerds-24","forks_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/forks","keys_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/teams","hooks_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/hooks","issue_events_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/issues/events{/number}","events_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/events","assignees_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/assignees{/user}","branches_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/branches{/branch}","tags_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/tags","blobs_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/git/refs{/sha}","trees_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/statuses/{sha}","languages_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/languages","stargazers_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/stargazers","contributors_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/contributors","subscribers_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/subscribers","subscription_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/subscription","commits_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/commits{/sha}","git_commits_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/git/commits{/sha}","comments_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/comments{/number}","issue_comment_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/issues/comments{/number}","contents_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/contents/{+path}","compare_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/merges","archive_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/downloads","issues_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/issues{/number}","pulls_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/pulls{/number}","milestones_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/milestones{/number}","notifications_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/labels{/name}","releases_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/releases{/id}","deployments_url":"https://api.github.com/repos/Leonid163/866569-nerds-24/deployments","created_at":"2019-01-22T08:18:47Z","updated_at":"2019-02-13T18:34:33Z","pushed_at":"2019-02-13T18:34:31Z","git_url":"git://github.com/Leonid163/866569-nerds-24.git","ssh_url":"git@github.com:Leonid163/866569-nerds-24.git","clone_url":"https://github.com/Leonid163/866569-nerds-24.git","svn_url":"https://github.com/Leonid163/866569-nerds-24","homepage":null,"size":2905,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"43ba5872a6840d7dd85d760ce48f46772e4f126c","user":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":166864278,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY4NjQyNzg=","name":"866569-nerds-24","full_name":"htmlacademy-htmlcss/866569-nerds-24","private":false,"owner":{"login":"htmlacademy-htmlcss","id":16576942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc2OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-htmlcss/866569-nerds-24","description":"Леонид","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/deployments","created_at":"2019-01-21T18:55:58Z","updated_at":"2019-02-06T18:51:19Z","pushed_at":"2019-02-13T19:23:33Z","git_url":"git://github.com/htmlacademy-htmlcss/866569-nerds-24.git","ssh_url":"git@github.com:htmlacademy-htmlcss/866569-nerds-24.git","clone_url":"https://github.com/htmlacademy-htmlcss/866569-nerds-24.git","svn_url":"https://github.com/htmlacademy-htmlcss/866569-nerds-24","homepage":"https://github.com/Leonid163/866569-nerds-24","size":2923,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/6"},"html":{"href":"https://github.com/htmlacademy-htmlcss/866569-nerds-24/pull/6"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/issues/6"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24/statuses/f77b884d38f58d9413e17530722db28c23263a0f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 166864278,
"name": "htmlacademy-htmlcss/866569-nerds-24",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/866569-nerds-24"
}
|
{
"id": 25896538,
"login": "DariaKliukhina",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25896538?",
"url": "https://api.github.com/users/DariaKliukhina"
}
|
{
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
}
| 2019-02-13T19:41:29 |
9062872688
|
{"actor":{"display_login":"DariaKliukhina"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/comments/301780475","pull_request_review_id":259743033,"id":301780475,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTc4MDQ3NQ==","diff_hunk":"@@ -4,10 +4,12 @@ import assert from 'assert';\n import { mount } from 'enzyme';\n import React from 'react';\n import App from '../../components/App';\n+import FeedbackForm from '../../components/FeedbackForm';\n \n describe('<App />', () => {\n it('should render correctly', () => {\n const wrapper = mount(<App />);\n assert(wrapper.contains('Tell us what you think'));\n+ assert(wrapper.contains(FeedbackForm));","path":"app/javascript/image_sharing/test/components/App.spec.js","position":14,"original_position":10,"commit_id":"3645e66ced23992eca2087a5f978f368b66487c2","original_commit_id":"394e928ea9c377eda651c7dd49f1a9ed262f5ed9","user":{"login":"eric199wen","id":23222316,"node_id":"MDQ6VXNlcjIzMjIyMzE2","avatar_url":"https://avatars0.githubusercontent.com/u/23222316?v=4","gravatar_id":"","url":"https://api.github.com/users/eric199wen","html_url":"https://github.com/eric199wen","followers_url":"https://api.github.com/users/eric199wen/followers","following_url":"https://api.github.com/users/eric199wen/following{/other_user}","gists_url":"https://api.github.com/users/eric199wen/gists{/gist_id}","starred_url":"https://api.github.com/users/eric199wen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric199wen/subscriptions","organizations_url":"https://api.github.com/users/eric199wen/orgs","repos_url":"https://api.github.com/users/eric199wen/repos","events_url":"https://api.github.com/users/eric199wen/events{/privacy}","received_events_url":"https://api.github.com/users/eric199wen/received_events","type":"User","site_admin":false},"body":"We can assert the length of `FeedbackForm` equal to 1 to make sure there is only one `FeedbackForm` got rendered.","created_at":"2019-07-09T20:31:53Z","updated_at":"2019-07-09T20:31:53Z","html_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen/pull/7#discussion_r301780475","pull_request_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/comments/301780475"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen/pull/7#discussion_r301780475"},"pull_request":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/7","id":295905134,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1OTA1MTM0","html_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen/pull/7","diff_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen/pull/7.diff","patch_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen/pull/7.patch","issue_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues/7","number":7,"state":"open","locked":false,"title":"Feedback form","user":{"login":"hannaveldhuizen","id":25964572,"node_id":"MDQ6VXNlcjI1OTY0NTcy","avatar_url":"https://avatars0.githubusercontent.com/u/25964572?v=4","gravatar_id":"","url":"https://api.github.com/users/hannaveldhuizen","html_url":"https://github.com/hannaveldhuizen","followers_url":"https://api.github.com/users/hannaveldhuizen/followers","following_url":"https://api.github.com/users/hannaveldhuizen/following{/other_user}","gists_url":"https://api.github.com/users/hannaveldhuizen/gists{/gist_id}","starred_url":"https://api.github.com/users/hannaveldhuizen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannaveldhuizen/subscriptions","organizations_url":"https://api.github.com/users/hannaveldhuizen/orgs","repos_url":"https://api.github.com/users/hannaveldhuizen/repos","events_url":"https://api.github.com/users/hannaveldhuizen/events{/privacy}","received_events_url":"https://api.github.com/users/hannaveldhuizen/received_events","type":"User","site_admin":false},"body":"This adds a feedback form and a footer to the application.","created_at":"2019-07-09T20:21:11Z","updated_at":"2019-07-09T20:31:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"876acf1c754d392c39ef16493d5bfa0c8fb39dda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/7/commits","review_comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/7/comments","review_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues/7/comments","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/statuses/3645e66ced23992eca2087a5f978f368b66487c2","head":{"label":"AppFolioOnboarding:feedbackForm","ref":"feedbackForm","sha":"3645e66ced23992eca2087a5f978f368b66487c2","user":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":194710134,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ3MTAxMzQ=","name":"image-sharer-hannaveldhuizen","full_name":"AppFolioOnboarding/image-sharer-hannaveldhuizen","private":false,"owner":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen","description":"image-sharer-hannaveldhuizen created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/deployments","created_at":"2019-07-01T16:44:50Z","updated_at":"2019-07-09T20:02:50Z","pushed_at":"2019-07-09T20:26:18Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-hannaveldhuizen.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen","homepage":null,"size":497,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"AppFolioOnboarding:master","ref":"master","sha":"b83cbd95109896705e263793f677fe3dd238d8d1","user":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":194710134,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ3MTAxMzQ=","name":"image-sharer-hannaveldhuizen","full_name":"AppFolioOnboarding/image-sharer-hannaveldhuizen","private":false,"owner":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen","description":"image-sharer-hannaveldhuizen created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/deployments","created_at":"2019-07-01T16:44:50Z","updated_at":"2019-07-09T20:02:50Z","pushed_at":"2019-07-09T20:26:18Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-hannaveldhuizen.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen","homepage":null,"size":497,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/7"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-hannaveldhuizen/pull/7"},"issue":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues/7"},"comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen/statuses/3645e66ced23992eca2087a5f978f368b66487c2"}},"author_association":"COLLABORATOR"}}
|
{
"id": 194710134,
"name": "AppFolioOnboarding/image-sharer-hannaveldhuizen",
"url": "https://api.github.com/repos/AppFolioOnboarding/image-sharer-hannaveldhuizen"
}
|
{
"id": 23222316,
"login": "eric199wen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23222316?",
"url": "https://api.github.com/users/eric199wen"
}
|
{
"id": 16782391,
"login": "AppFolioOnboarding",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16782391?",
"url": "https://api.github.com/orgs/AppFolioOnboarding"
}
| 2019-07-09T20:31:53 |
9978680055
|
{"actor":{"display_login":"eric199wen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/comments/316799037","pull_request_review_id":278572422,"id":316799037,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjc5OTAzNw==","diff_hunk":"@@ -1330,45 +1325,53 @@ export type ProjectId = string | null | undefined;\n export interface RequestCallback {\n (\n a?: Error | null,\n- b?: AllocateIdsRequestResponse &\n+ b?: google.datastore.v1.IAllocateIdsResponse &\n google.datastore.v1.ILookupResponse &\n- Entities\n+ google.datastore.v1.ICommitResponse &\n+ google.datastore.v1.IRollbackResponse & {\n+ transaction?: string;\n+ }\n ): void;\n }\n export interface RequestConfig {\n client: string;\n- gaxOpts?: number | CallOptions | KeyProto;\n+ gaxOpts?: CallOptions;\n method: string;\n prepared?: boolean;\n- reqOpts?: Entity | RequestOptions;\n- gaxOptions?: never;\n+ reqOpts?: RequestOptions;\n }\n export interface RequestOptions {\n- mutations?: [] | Array<{delete: KeyProto}> | Array<{}>;\n+ mutations?: google.datastore.v1.IMutation[];\n keys?: Entity;\n- readOptions?: {readConsistency?: number; transaction?: string | number};\n+ readOptions?: {readConsistency?: number; transaction?: string};\n+ partitionId?: google.datastore.v1.IPartitionId | null;\n transactionOptions?: {\n readOnly?: {};\n readWrite?: {previousTransaction?: string};\n- };\n- transaction?: string | number;\n+ } | null;\n+ transaction?: string | null;\n mode?: string;\n- projectId?: string;\n-}\n-export interface RunQueryStreamOptions {\n- gaxOptions?: CallOptions;\n- consistency?: 'strong' | 'eventual';\n+ projectId?: ProjectId;\n+ query?: QueryProto;\n }\n-export interface SaveCallback {\n- (a?: Error | null, b?: Entity): void;\n+export interface RunQueryStreamOptions extends RunQueryOptions {}","path":"src/request.ts","position":433,"original_position":396,"commit_id":"d7dc2656f78c65e7962e07b2e466b19accb57f11","original_commit_id":"da4992e565030d6925ac0d2b81ece473b6534296","user":{"login":"callmehiphop","id":1707267,"node_id":"MDQ6VXNlcjE3MDcyNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1707267?v=4","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"body":"No need, I was mostly curious!","created_at":"2019-08-22T17:30:14Z","updated_at":"2019-08-22T17:33:15Z","html_url":"https://github.com/googleapis/nodejs-datastore/pull/472#discussion_r316799037","pull_request_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/472","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/comments/316799037"},"html":{"href":"https://github.com/googleapis/nodejs-datastore/pull/472#discussion_r316799037"},"pull_request":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/472"}},"in_reply_to_id":315317807},"pull_request":{"url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/472","id":307013990,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3MDEzOTkw","html_url":"https://github.com/googleapis/nodejs-datastore/pull/472","diff_url":"https://github.com/googleapis/nodejs-datastore/pull/472.diff","patch_url":"https://github.com/googleapis/nodejs-datastore/pull/472.patch","issue_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/472","number":472,"state":"open","locked":false,"title":"fix(types): fix and clean up types for request.ts","user":{"login":"AVaksman","id":7764119,"node_id":"MDQ6VXNlcjc3NjQxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7764119?v=4","gravatar_id":"","url":"https://api.github.com/users/AVaksman","html_url":"https://github.com/AVaksman","followers_url":"https://api.github.com/users/AVaksman/followers","following_url":"https://api.github.com/users/AVaksman/following{/other_user}","gists_url":"https://api.github.com/users/AVaksman/gists{/gist_id}","starred_url":"https://api.github.com/users/AVaksman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVaksman/subscriptions","organizations_url":"https://api.github.com/users/AVaksman/orgs","repos_url":"https://api.github.com/users/AVaksman/repos","events_url":"https://api.github.com/users/AVaksman/events{/privacy}","received_events_url":"https://api.github.com/users/AVaksman/received_events","type":"User","site_admin":false},"body":"Towards #460\r\n\r\n- [x] Tests and linter pass\r\n- [x] Code coverage does not decrease (if any source code was changed)\r\n\r\n","created_at":"2019-08-13T17:57:22Z","updated_at":"2019-08-22T17:33:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"176bbd97c50779682b61298092089b3a652af865","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bcoe","id":194609,"node_id":"MDQ6VXNlcjE5NDYwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/194609?v=4","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1016504629,"node_id":"MDU6TGFiZWwxMDE2NTA0NjI5","url":"https://api.github.com/repos/googleapis/nodejs-datastore/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/472/commits","review_comments_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/472/comments","review_comment_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/472/comments","statuses_url":"https://api.github.com/repos/googleapis/nodejs-datastore/statuses/d7dc2656f78c65e7962e07b2e466b19accb57f11","head":{"label":"AVaksman:promise_return_signatures","ref":"promise_return_signatures","sha":"d7dc2656f78c65e7962e07b2e466b19accb57f11","user":{"login":"AVaksman","id":7764119,"node_id":"MDQ6VXNlcjc3NjQxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7764119?v=4","gravatar_id":"","url":"https://api.github.com/users/AVaksman","html_url":"https://github.com/AVaksman","followers_url":"https://api.github.com/users/AVaksman/followers","following_url":"https://api.github.com/users/AVaksman/following{/other_user}","gists_url":"https://api.github.com/users/AVaksman/gists{/gist_id}","starred_url":"https://api.github.com/users/AVaksman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVaksman/subscriptions","organizations_url":"https://api.github.com/users/AVaksman/orgs","repos_url":"https://api.github.com/users/AVaksman/repos","events_url":"https://api.github.com/users/AVaksman/events{/privacy}","received_events_url":"https://api.github.com/users/AVaksman/received_events","type":"User","site_admin":false},"repo":{"id":190649601,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA2NDk2MDE=","name":"nodejs-datastore","full_name":"AVaksman/nodejs-datastore","private":false,"owner":{"login":"AVaksman","id":7764119,"node_id":"MDQ6VXNlcjc3NjQxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7764119?v=4","gravatar_id":"","url":"https://api.github.com/users/AVaksman","html_url":"https://github.com/AVaksman","followers_url":"https://api.github.com/users/AVaksman/followers","following_url":"https://api.github.com/users/AVaksman/following{/other_user}","gists_url":"https://api.github.com/users/AVaksman/gists{/gist_id}","starred_url":"https://api.github.com/users/AVaksman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVaksman/subscriptions","organizations_url":"https://api.github.com/users/AVaksman/orgs","repos_url":"https://api.github.com/users/AVaksman/repos","events_url":"https://api.github.com/users/AVaksman/events{/privacy}","received_events_url":"https://api.github.com/users/AVaksman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AVaksman/nodejs-datastore","description":"Node.js client for Google Cloud Datastore: a highly-scalable NoSQL database for your web and mobile applications.","fork":true,"url":"https://api.github.com/repos/AVaksman/nodejs-datastore","forks_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/forks","keys_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/teams","hooks_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/hooks","issue_events_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/issues/events{/number}","events_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/events","assignees_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/assignees{/user}","branches_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/branches{/branch}","tags_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/tags","blobs_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/git/refs{/sha}","trees_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/statuses/{sha}","languages_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/languages","stargazers_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/stargazers","contributors_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/contributors","subscribers_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/subscribers","subscription_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/subscription","commits_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/commits{/sha}","git_commits_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/git/commits{/sha}","comments_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/comments{/number}","issue_comment_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/issues/comments{/number}","contents_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/contents/{+path}","compare_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/merges","archive_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/downloads","issues_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/issues{/number}","pulls_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/pulls{/number}","milestones_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/milestones{/number}","notifications_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/labels{/name}","releases_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/releases{/id}","deployments_url":"https://api.github.com/repos/AVaksman/nodejs-datastore/deployments","created_at":"2019-06-06T21:04:44Z","updated_at":"2019-08-13T19:48:23Z","pushed_at":"2019-08-22T14:21:17Z","git_url":"git://github.com/AVaksman/nodejs-datastore.git","ssh_url":"git@github.com:AVaksman/nodejs-datastore.git","clone_url":"https://github.com/AVaksman/nodejs-datastore.git","svn_url":"https://github.com/AVaksman/nodejs-datastore","homepage":"https://cloud.google.com/datastore/","size":2066,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"e39c8011d8a7ee172758a0ed2f35065ef49ce943","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":98463536,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQ2MzUzNg==","name":"nodejs-datastore","full_name":"googleapis/nodejs-datastore","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/nodejs-datastore","description":"Node.js client for Google Cloud Datastore: a highly-scalable NoSQL database for your web and mobile applications.","fork":false,"url":"https://api.github.com/repos/googleapis/nodejs-datastore","forks_url":"https://api.github.com/repos/googleapis/nodejs-datastore/forks","keys_url":"https://api.github.com/repos/googleapis/nodejs-datastore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/nodejs-datastore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/nodejs-datastore/teams","hooks_url":"https://api.github.com/repos/googleapis/nodejs-datastore/hooks","issue_events_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/nodejs-datastore/events","assignees_url":"https://api.github.com/repos/googleapis/nodejs-datastore/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/nodejs-datastore/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/nodejs-datastore/tags","blobs_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/nodejs-datastore/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/nodejs-datastore/languages","stargazers_url":"https://api.github.com/repos/googleapis/nodejs-datastore/stargazers","contributors_url":"https://api.github.com/repos/googleapis/nodejs-datastore/contributors","subscribers_url":"https://api.github.com/repos/googleapis/nodejs-datastore/subscribers","subscription_url":"https://api.github.com/repos/googleapis/nodejs-datastore/subscription","commits_url":"https://api.github.com/repos/googleapis/nodejs-datastore/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/nodejs-datastore/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/nodejs-datastore/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/nodejs-datastore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/nodejs-datastore/merges","archive_url":"https://api.github.com/repos/googleapis/nodejs-datastore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/nodejs-datastore/downloads","issues_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/nodejs-datastore/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/nodejs-datastore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/nodejs-datastore/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/nodejs-datastore/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/nodejs-datastore/deployments","created_at":"2017-07-26T20:32:42Z","updated_at":"2019-08-17T15:43:22Z","pushed_at":"2019-08-22T16:31:37Z","git_url":"git://github.com/googleapis/nodejs-datastore.git","ssh_url":"git@github.com:googleapis/nodejs-datastore.git","clone_url":"https://github.com/googleapis/nodejs-datastore.git","svn_url":"https://github.com/googleapis/nodejs-datastore","homepage":"https://cloud.google.com/datastore/","size":2059,"stargazers_count":107,"watchers_count":107,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":24,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/472"},"html":{"href":"https://github.com/googleapis/nodejs-datastore/pull/472"},"issue":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/472"},"comments":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/472/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/472/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/472/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/statuses/d7dc2656f78c65e7962e07b2e466b19accb57f11"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 98463536,
"name": "googleapis/nodejs-datastore",
"url": "https://api.github.com/repos/googleapis/nodejs-datastore"
}
|
{
"id": 1707267,
"login": "callmehiphop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1707267?",
"url": "https://api.github.com/users/callmehiphop"
}
|
{
"id": 16785467,
"login": "googleapis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16785467?",
"url": "https://api.github.com/orgs/googleapis"
}
| 2019-08-22T17:30:14 |
10264914697
|
{"actor":{"display_login":"callmehiphop"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/comments/288228295","pull_request_review_id":242828305,"id":288228295,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODIyODI5NQ==","diff_hunk":"@@ -0,0 +1,45 @@\n+/**\n+ * Copyright 2019 Google LLC\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * https://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+'use strict';\n+\n+function main(datasetId, modelId) {\n+ // [START bigquery_delete_model]\n+ // Import the Google Cloud client library\n+ const {BigQuery} = require('@google-cloud/bigquery');\n+\n+ async function deleteModel() {\n+ // Deletes a model named \"my_model\" from \"my_dataset\".\n+\n+ /**\n+ * TODO(developer): Uncomment the following lines before running the sample\n+ */\n+ // const datasetId = \"my_dataset\";\n+ // const modelId = \"my_model\";\n+\n+ // Create a client\n+ const bigqueryClient = new BigQuery();\n+\n+ const dataset = bigqueryClient.dataset(datasetId);\n+ const model = dataset.model(modelId);\n+ await model.delete();\n+\n+ console.log(`Model ${modelId} deleted.`);\n+ }\n+ deleteModel();\n+ // [END bigquery_delete_model]\n+}\n+main(...process.argv.slice(2));","path":"samples/deleteModel.js","position":45,"original_position":45,"commit_id":"b3d11bb2b2bae6c4c61093c0a63b6644ac82bc26","original_commit_id":"b3d11bb2b2bae6c4c61093c0a63b6644ac82bc26","user":{"login":"callmehiphop","id":1707267,"node_id":"MDQ6VXNlcjE3MDcyNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1707267?v=4","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"body":"I'm kind of surprised to see we don't catch and print errors here, I think they'd result in a unhandled rejection otherwise? Looks like this is true to all the BQ samples. @JustinBeckwith should we open an issue for this?","created_at":"2019-05-28T17:53:18Z","updated_at":"2019-05-28T17:53:19Z","html_url":"https://github.com/googleapis/nodejs-bigquery/pull/460#discussion_r288228295","pull_request_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/460","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/comments/288228295"},"html":{"href":"https://github.com/googleapis/nodejs-bigquery/pull/460#discussion_r288228295"},"pull_request":{"href":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/460"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/460","id":282694311,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyNjk0MzEx","html_url":"https://github.com/googleapis/nodejs-bigquery/pull/460","diff_url":"https://github.com/googleapis/nodejs-bigquery/pull/460.diff","patch_url":"https://github.com/googleapis/nodejs-bigquery/pull/460.patch","issue_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/issues/460","number":460,"state":"open","locked":false,"title":"docs(samples): adds get, delete, list, update model samples","user":{"login":"steffnay","id":30247553,"node_id":"MDQ6VXNlcjMwMjQ3NTUz","avatar_url":"https://avatars0.githubusercontent.com/u/30247553?v=4","gravatar_id":"","url":"https://api.github.com/users/steffnay","html_url":"https://github.com/steffnay","followers_url":"https://api.github.com/users/steffnay/followers","following_url":"https://api.github.com/users/steffnay/following{/other_user}","gists_url":"https://api.github.com/users/steffnay/gists{/gist_id}","starred_url":"https://api.github.com/users/steffnay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffnay/subscriptions","organizations_url":"https://api.github.com/users/steffnay/orgs","repos_url":"https://api.github.com/users/steffnay/repos","events_url":"https://api.github.com/users/steffnay/events{/privacy}","received_events_url":"https://api.github.com/users/steffnay/received_events","type":"User","site_admin":false},"body":"- [ ] Tests and linter pass\r\n- [ ] Code coverage does not decrease (if any source code was changed)\r\n- [ ] Appropriate docs were updated (if necessary)\r\n","created_at":"2019-05-28T07:07:31Z","updated_at":"2019-05-28T17:53:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a39e364c7f7ec6c9049aa1cc6e27aa68f4e507c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1004822193,"node_id":"MDU6TGFiZWwxMDA0ODIyMTkz","url":"https://api.github.com/repos/googleapis/nodejs-bigquery/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/460/commits","review_comments_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/460/comments","review_comment_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/issues/460/comments","statuses_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/statuses/b3d11bb2b2bae6c4c61093c0a63b6644ac82bc26","head":{"label":"steffnay:add-model-samples","ref":"add-model-samples","sha":"b3d11bb2b2bae6c4c61093c0a63b6644ac82bc26","user":{"login":"steffnay","id":30247553,"node_id":"MDQ6VXNlcjMwMjQ3NTUz","avatar_url":"https://avatars0.githubusercontent.com/u/30247553?v=4","gravatar_id":"","url":"https://api.github.com/users/steffnay","html_url":"https://github.com/steffnay","followers_url":"https://api.github.com/users/steffnay/followers","following_url":"https://api.github.com/users/steffnay/following{/other_user}","gists_url":"https://api.github.com/users/steffnay/gists{/gist_id}","starred_url":"https://api.github.com/users/steffnay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffnay/subscriptions","organizations_url":"https://api.github.com/users/steffnay/orgs","repos_url":"https://api.github.com/users/steffnay/repos","events_url":"https://api.github.com/users/steffnay/events{/privacy}","received_events_url":"https://api.github.com/users/steffnay/received_events","type":"User","site_admin":false},"repo":{"id":169917851,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk5MTc4NTE=","name":"nodejs-bigquery","full_name":"steffnay/nodejs-bigquery","private":false,"owner":{"login":"steffnay","id":30247553,"node_id":"MDQ6VXNlcjMwMjQ3NTUz","avatar_url":"https://avatars0.githubusercontent.com/u/30247553?v=4","gravatar_id":"","url":"https://api.github.com/users/steffnay","html_url":"https://github.com/steffnay","followers_url":"https://api.github.com/users/steffnay/followers","following_url":"https://api.github.com/users/steffnay/following{/other_user}","gists_url":"https://api.github.com/users/steffnay/gists{/gist_id}","starred_url":"https://api.github.com/users/steffnay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffnay/subscriptions","organizations_url":"https://api.github.com/users/steffnay/orgs","repos_url":"https://api.github.com/users/steffnay/repos","events_url":"https://api.github.com/users/steffnay/events{/privacy}","received_events_url":"https://api.github.com/users/steffnay/received_events","type":"User","site_admin":false},"html_url":"https://github.com/steffnay/nodejs-bigquery","description":"Node.js client for Google Cloud BigQuery: A fast, economical and fully-managed enterprise data warehouse for large-scale data analytics.","fork":true,"url":"https://api.github.com/repos/steffnay/nodejs-bigquery","forks_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/forks","keys_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/teams","hooks_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/hooks","issue_events_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/issues/events{/number}","events_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/events","assignees_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/assignees{/user}","branches_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/branches{/branch}","tags_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/tags","blobs_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/statuses/{sha}","languages_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/languages","stargazers_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/stargazers","contributors_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/contributors","subscribers_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/subscribers","subscription_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/subscription","commits_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/contents/{+path}","compare_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/merges","archive_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/downloads","issues_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/issues{/number}","pulls_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/pulls{/number}","milestones_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/milestones{/number}","notifications_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/labels{/name}","releases_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/releases{/id}","deployments_url":"https://api.github.com/repos/steffnay/nodejs-bigquery/deployments","created_at":"2019-02-09T21:54:17Z","updated_at":"2019-05-13T18:01:27Z","pushed_at":"2019-05-28T15:41:18Z","git_url":"git://github.com/steffnay/nodejs-bigquery.git","ssh_url":"git@github.com:steffnay/nodejs-bigquery.git","clone_url":"https://github.com/steffnay/nodejs-bigquery.git","svn_url":"https://github.com/steffnay/nodejs-bigquery","homepage":"https://cloud.google.com/bigquery/","size":5324,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"89f58f89fb4ece8541e985457416e410d77c243e","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":98463161,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQ2MzE2MQ==","name":"nodejs-bigquery","full_name":"googleapis/nodejs-bigquery","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/nodejs-bigquery","description":"Node.js client for Google Cloud BigQuery: A fast, economical and fully-managed enterprise data warehouse for large-scale data analytics.","fork":false,"url":"https://api.github.com/repos/googleapis/nodejs-bigquery","forks_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/forks","keys_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/teams","hooks_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/hooks","issue_events_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/events","assignees_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/tags","blobs_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/languages","stargazers_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/stargazers","contributors_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/contributors","subscribers_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/subscribers","subscription_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/subscription","commits_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/merges","archive_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/downloads","issues_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/nodejs-bigquery/deployments","created_at":"2017-07-26T20:27:38Z","updated_at":"2019-05-28T10:26:23Z","pushed_at":"2019-05-28T15:41:19Z","git_url":"git://github.com/googleapis/nodejs-bigquery.git","ssh_url":"git@github.com:googleapis/nodejs-bigquery.git","clone_url":"https://github.com/googleapis/nodejs-bigquery.git","svn_url":"https://github.com/googleapis/nodejs-bigquery","homepage":"https://cloud.google.com/bigquery/","size":5184,"stargazers_count":115,"watchers_count":115,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":70,"open_issues":25,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/460"},"html":{"href":"https://github.com/googleapis/nodejs-bigquery/pull/460"},"issue":{"href":"https://api.github.com/repos/googleapis/nodejs-bigquery/issues/460"},"comments":{"href":"https://api.github.com/repos/googleapis/nodejs-bigquery/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/nodejs-bigquery/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/nodejs-bigquery/statuses/b3d11bb2b2bae6c4c61093c0a63b6644ac82bc26"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 98463161,
"name": "googleapis/nodejs-bigquery",
"url": "https://api.github.com/repos/googleapis/nodejs-bigquery"
}
|
{
"id": 1707267,
"login": "callmehiphop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1707267?",
"url": "https://api.github.com/users/callmehiphop"
}
|
{
"id": 16785467,
"login": "googleapis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16785467?",
"url": "https://api.github.com/orgs/googleapis"
}
| 2019-05-28T17:53:18 |
9712937908
|
{"actor":{"display_login":"callmehiphop"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/comments/263079570","pull_request_review_id":211402784,"id":263079570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzA3OTU3MA==","diff_hunk":"@@ -23,10 +23,11 @@ namespace storage {\n inline namespace STORAGE_CLIENT_NS {\n namespace internal {\n \n-std::vector<std::uint8_t> Sha256Hash(std::string const& str) {\n+namespace {\n+std::vector<std::uint8_t> Sha256Hash(void const* data, std::size_t size) {","path":"google/cloud/storage/internal/sha256_hash.cc","position":6,"original_position":6,"commit_id":"575728355cee57beaa73a68fe9963850c04bba83","original_commit_id":"575728355cee57beaa73a68fe9963850c04bba83","user":{"login":"devbww","id":14679271,"node_id":"MDQ6VXNlcjE0Njc5Mjcx","avatar_url":"https://avatars1.githubusercontent.com/u/14679271?v=4","gravatar_id":"","url":"https://api.github.com/users/devbww","html_url":"https://github.com/devbww","followers_url":"https://api.github.com/users/devbww/followers","following_url":"https://api.github.com/users/devbww/following{/other_user}","gists_url":"https://api.github.com/users/devbww/gists{/gist_id}","starred_url":"https://api.github.com/users/devbww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devbww/subscriptions","organizations_url":"https://api.github.com/users/devbww/orgs","repos_url":"https://api.github.com/users/devbww/repos","events_url":"https://api.github.com/users/devbww/events{/privacy}","received_events_url":"https://api.github.com/users/devbww/received_events","type":"User","site_admin":false},"body":"`[unsigned] char const* data`, so that the meaning of `size` is clear? That is, leave the `void*` stuff to the calls to the lower layers.","created_at":"2019-03-06T18:43:27Z","updated_at":"2019-03-06T18:44:22Z","html_url":"https://github.com/googleapis/google-cloud-cpp/pull/2154#discussion_r263079570","pull_request_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/2154","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/comments/263079570"},"html":{"href":"https://github.com/googleapis/google-cloud-cpp/pull/2154#discussion_r263079570"},"pull_request":{"href":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/2154"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/2154","id":258785352,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4Nzg1MzUy","html_url":"https://github.com/googleapis/google-cloud-cpp/pull/2154","diff_url":"https://github.com/googleapis/google-cloud-cpp/pull/2154.diff","patch_url":"https://github.com/googleapis/google-cloud-cpp/pull/2154.patch","issue_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/issues/2154","number":2154,"state":"open","locked":false,"title":"Better return type for Base64Decode.","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"body":"The sequence of bytes returned by `Base64Decode()` *might*\r\nrepresent a string, but it can also be a binary blob. Return just\r\n`std::vector<std::uint8_t>`, the caller can convert if they have\r\nspecial knowledge allowing them to use a `std::string`.\r\n\r\nIn the process I discovered some duplication for Sha256, and\r\nit was simpler to refactor to the common function instead of fixing\r\nand then refactor.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/googleapis/google-cloud-cpp/2154)\n<!-- Reviewable:end -->\n","created_at":"2019-03-06T16:16:43Z","updated_at":"2019-03-06T18:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a4c6304dfd9c9574ee66726ce42a626a479f481","assignee":null,"assignees":[],"requested_reviewers":[{"login":"devjgm","id":9447643,"node_id":"MDQ6VXNlcjk0NDc2NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/9447643?v=4","gravatar_id":"","url":"https://api.github.com/users/devjgm","html_url":"https://github.com/devjgm","followers_url":"https://api.github.com/users/devjgm/followers","following_url":"https://api.github.com/users/devjgm/following{/other_user}","gists_url":"https://api.github.com/users/devjgm/gists{/gist_id}","starred_url":"https://api.github.com/users/devjgm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devjgm/subscriptions","organizations_url":"https://api.github.com/users/devjgm/orgs","repos_url":"https://api.github.com/users/devjgm/repos","events_url":"https://api.github.com/users/devjgm/events{/privacy}","received_events_url":"https://api.github.com/users/devjgm/received_events","type":"User","site_admin":false},{"login":"houglum","id":14894525,"node_id":"MDQ6VXNlcjE0ODk0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/14894525?v=4","gravatar_id":"","url":"https://api.github.com/users/houglum","html_url":"https://github.com/houglum","followers_url":"https://api.github.com/users/houglum/followers","following_url":"https://api.github.com/users/houglum/following{/other_user}","gists_url":"https://api.github.com/users/houglum/gists{/gist_id}","starred_url":"https://api.github.com/users/houglum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houglum/subscriptions","organizations_url":"https://api.github.com/users/houglum/orgs","repos_url":"https://api.github.com/users/houglum/repos","events_url":"https://api.github.com/users/houglum/events{/privacy}","received_events_url":"https://api.github.com/users/houglum/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":921026962,"node_id":"MDU6TGFiZWw5MjEwMjY5NjI=","url":"https://api.github.com/repos/googleapis/google-cloud-cpp/labels/api:%20storage","name":"api: storage","color":"d4c5f9","default":false},{"id":760104389,"node_id":"MDU6TGFiZWw3NjAxMDQzODk=","url":"https://api.github.com/repos/googleapis/google-cloud-cpp/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false},{"id":952109927,"node_id":"MDU6TGFiZWw5NTIxMDk5Mjc=","url":"https://api.github.com/repos/googleapis/google-cloud-cpp/labels/type:%20cleanup","name":"type: cleanup","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/2154/commits","review_comments_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/2154/comments","review_comment_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/issues/2154/comments","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/statuses/575728355cee57beaa73a68fe9963850c04bba83","head":{"label":"coryan:remove-openssl-struct-pr6","ref":"remove-openssl-struct-pr6","sha":"575728355cee57beaa73a68fe9963850c04bba83","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"repo":{"id":111937615,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE5Mzc2MTU=","name":"google-cloud-cpp","full_name":"coryan/google-cloud-cpp","private":false,"owner":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/coryan/google-cloud-cpp","description":"Google Cloud Platform C++ client libraries","fork":true,"url":"https://api.github.com/repos/coryan/google-cloud-cpp","forks_url":"https://api.github.com/repos/coryan/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/coryan/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coryan/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coryan/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/coryan/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/coryan/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/coryan/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/coryan/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/coryan/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coryan/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/coryan/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/coryan/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/coryan/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/coryan/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/coryan/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/coryan/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/coryan/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/coryan/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/coryan/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coryan/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/coryan/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coryan/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/coryan/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/coryan/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/coryan/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coryan/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/coryan/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/coryan/google-cloud-cpp/deployments","created_at":"2017-11-24T16:28:07Z","updated_at":"2019-03-06T17:12:09Z","pushed_at":"2019-03-06T18:17:40Z","git_url":"git://github.com/coryan/google-cloud-cpp.git","ssh_url":"git@github.com:coryan/google-cloud-cpp.git","clone_url":"https://github.com/coryan/google-cloud-cpp.git","svn_url":"https://github.com/coryan/google-cloud-cpp","homepage":"https://cloud.google.com/","size":109242,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"94e58b4b5ba9bba958f215d55baa78d910986c4f","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":111860063,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4NjAwNjM=","name":"google-cloud-cpp","full_name":"googleapis/google-cloud-cpp","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/google-cloud-cpp","description":"Google Cloud Client Library for C++","fork":false,"url":"https://api.github.com/repos/googleapis/google-cloud-cpp","forks_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/google-cloud-cpp/deployments","created_at":"2017-11-24T00:19:31Z","updated_at":"2019-03-06T17:46:43Z","pushed_at":"2019-03-06T18:19:13Z","git_url":"git://github.com/googleapis/google-cloud-cpp.git","ssh_url":"git@github.com:googleapis/google-cloud-cpp.git","clone_url":"https://github.com/googleapis/google-cloud-cpp.git","svn_url":"https://github.com/googleapis/google-cloud-cpp","homepage":"https://cloud.google.com/","size":106268,"stargazers_count":75,"watchers_count":75,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":55,"open_issues":170,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/2154"},"html":{"href":"https://github.com/googleapis/google-cloud-cpp/pull/2154"},"issue":{"href":"https://api.github.com/repos/googleapis/google-cloud-cpp/issues/2154"},"comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-cpp/issues/2154/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/2154/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/google-cloud-cpp/pulls/2154/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/google-cloud-cpp/statuses/575728355cee57beaa73a68fe9963850c04bba83"}},"author_association":"COLLABORATOR"}}
|
{
"id": 111860063,
"name": "googleapis/google-cloud-cpp",
"url": "https://api.github.com/repos/googleapis/google-cloud-cpp"
}
|
{
"id": 14679271,
"login": "devbww",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14679271?",
"url": "https://api.github.com/users/devbww"
}
|
{
"id": 16785467,
"login": "googleapis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16785467?",
"url": "https://api.github.com/orgs/googleapis"
}
| 2019-03-06T18:43:27 |
9193050629
|
{"actor":{"display_login":"devbww"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/comments/283017077","pull_request_review_id":236279122,"id":283017077,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzAxNzA3Nw==","diff_hunk":"@@ -105,8 +105,8 @@ export GCLOUD_PROFILER_CONFIG=./path/to/your/profiler/configuration.js\n \n The profiler writes log statements to the console log for diagnostic purposes.\n By default, the log level is set to warn. You can adjust this by setting\n-`logLevel` in the config. Setting `logLevel` to 0 will disable logging, 1 sets\n-log level to error, 2 sets it to warn, 3 sets it to info, and 4 sets it to\n+`logLevel` in the config. Setting `logLevel` to 0 will disable logging (default),\n+1 sets log level to error, 2 sets it to warn, 3 sets it to info, and 4 sets it to","path":"README.md","position":7,"original_position":7,"commit_id":"de4740a01c0ecae90e37b4b28b889e11e3696a04","original_commit_id":"de4740a01c0ecae90e37b4b28b889e11e3696a04","user":{"login":"nolanmar511","id":14046562,"node_id":"MDQ6VXNlcjE0MDQ2NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false},"body":"Confirmed by checking configs. \r\n\r\n2, not 0, is default.","created_at":"2019-05-10T19:35:40Z","updated_at":"2019-05-10T19:35:47Z","html_url":"https://github.com/googleapis/cloud-profiler-nodejs/pull/483#discussion_r283017077","pull_request_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/483","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/comments/283017077"},"html":{"href":"https://github.com/googleapis/cloud-profiler-nodejs/pull/483#discussion_r283017077"},"pull_request":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/483"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/483","id":277881794,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3ODgxNzk0","html_url":"https://github.com/googleapis/cloud-profiler-nodejs/pull/483","diff_url":"https://github.com/googleapis/cloud-profiler-nodejs/pull/483.diff","patch_url":"https://github.com/googleapis/cloud-profiler-nodejs/pull/483.patch","issue_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/483","number":483,"state":"open","locked":false,"title":"Specify default logging level","user":{"login":"kalyanac","id":6875403,"node_id":"MDQ6VXNlcjY4NzU0MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/6875403?v=4","gravatar_id":"","url":"https://api.github.com/users/kalyanac","html_url":"https://github.com/kalyanac","followers_url":"https://api.github.com/users/kalyanac/followers","following_url":"https://api.github.com/users/kalyanac/following{/other_user}","gists_url":"https://api.github.com/users/kalyanac/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyanac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyanac/subscriptions","organizations_url":"https://api.github.com/users/kalyanac/orgs","repos_url":"https://api.github.com/users/kalyanac/repos","events_url":"https://api.github.com/users/kalyanac/events{/privacy}","received_events_url":"https://api.github.com/users/kalyanac/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-10T19:17:53Z","updated_at":"2019-05-10T19:35:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fca821b480e85151e640f38adad55d0fe095c1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":318684021,"node_id":"MDU6TGFiZWwzMTg2ODQwMjE=","url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/483/commits","review_comments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/483/comments","review_comment_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/483/comments","statuses_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/statuses/de4740a01c0ecae90e37b4b28b889e11e3696a04","head":{"label":"googleapis:kalyanac-patch-1","ref":"kalyanac-patch-1","sha":"de4740a01c0ecae90e37b4b28b889e11e3696a04","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":50680973,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY4MDk3Mw==","name":"cloud-profiler-nodejs","full_name":"googleapis/cloud-profiler-nodejs","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/cloud-profiler-nodejs","description":"Node.js library for Stackdriver Profiler. Continuous CPU and heap profiling to improve performance and reduce costs.","fork":false,"url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs","forks_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/forks","keys_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/teams","hooks_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/hooks","issue_events_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/events","assignees_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/tags","blobs_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/languages","stargazers_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/stargazers","contributors_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/contributors","subscribers_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/subscribers","subscription_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/subscription","commits_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/merges","archive_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/downloads","issues_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/deployments","created_at":"2016-01-29T18:06:50Z","updated_at":"2019-05-06T22:35:47Z","pushed_at":"2019-05-10T19:22:44Z","git_url":"git://github.com/googleapis/cloud-profiler-nodejs.git","ssh_url":"git@github.com:googleapis/cloud-profiler-nodejs.git","clone_url":"https://github.com/googleapis/cloud-profiler-nodejs.git","svn_url":"https://github.com/googleapis/cloud-profiler-nodejs","homepage":"https://cloud.google.com/profiler/","size":2589,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":19,"watchers":30,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"59429e72b51e655e9524c274c442824810907d0b","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":50680973,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY4MDk3Mw==","name":"cloud-profiler-nodejs","full_name":"googleapis/cloud-profiler-nodejs","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/cloud-profiler-nodejs","description":"Node.js library for Stackdriver Profiler. Continuous CPU and heap profiling to improve performance and reduce costs.","fork":false,"url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs","forks_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/forks","keys_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/teams","hooks_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/hooks","issue_events_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/events","assignees_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/tags","blobs_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/languages","stargazers_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/stargazers","contributors_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/contributors","subscribers_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/subscribers","subscription_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/subscription","commits_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/merges","archive_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/downloads","issues_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/deployments","created_at":"2016-01-29T18:06:50Z","updated_at":"2019-05-06T22:35:47Z","pushed_at":"2019-05-10T19:22:44Z","git_url":"git://github.com/googleapis/cloud-profiler-nodejs.git","ssh_url":"git@github.com:googleapis/cloud-profiler-nodejs.git","clone_url":"https://github.com/googleapis/cloud-profiler-nodejs.git","svn_url":"https://github.com/googleapis/cloud-profiler-nodejs","homepage":"https://cloud.google.com/profiler/","size":2589,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":19,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/483"},"html":{"href":"https://github.com/googleapis/cloud-profiler-nodejs/pull/483"},"issue":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/483"},"comments":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/statuses/de4740a01c0ecae90e37b4b28b889e11e3696a04"}},"author_association":"MEMBER"}}
|
{
"id": 50680973,
"name": "googleapis/cloud-profiler-nodejs",
"url": "https://api.github.com/repos/googleapis/cloud-profiler-nodejs"
}
|
{
"id": 14046562,
"login": "nolanmar511",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14046562?",
"url": "https://api.github.com/users/nolanmar511"
}
|
{
"id": 16785467,
"login": "googleapis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16785467?",
"url": "https://api.github.com/orgs/googleapis"
}
| 2019-05-10T19:35:40 |
9604305795
|
{"actor":{"display_login":"nolanmar511"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/comments/354036398","pull_request_review_id":327219373,"id":354036398,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDAzNjM5OA==","diff_hunk":"@@ -292,12 +300,21 @@ def publish(self, message):\n if not self.will_accept(message):\n return future\n \n- new_size = self._size + message.ByteSize()\n+ size_increase = types.PublishRequest(messages=[message]).ByteSize()\n+\n+ if (self._base_request_size + size_increase) > _SERVER_PUBLISH_MAX_BYTES:\n+ err_msg = (\n+ \"The message being published would produce too large a publish \"\n+ \"request that would exceed the maximum allowed size on the \"\n+ \"backend ({} bytes).\".format(_SERVER_PUBLISH_MAX_BYTES)\n+ )\n+ raise ValueError(err_msg)\n+\n+ new_size = self._size + size_increase\n new_count = len(self._messages) + 1\n- overflow = (\n- new_size > self.settings.max_bytes\n- or new_count >= self._settings.max_messages\n- )\n+\n+ size_limit = min(self.settings.max_bytes, _SERVER_PUBLISH_MAX_BYTES)\n+ overflow = new_size > size_limit or new_count >= self._settings.max_messages","path":"pubsub/google/cloud/pubsub_v1/publisher/_batch/thread.py","position":null,"original_position":60,"commit_id":"289935ebb011904038c0a109b954ec8fbb3b5795","original_commit_id":"20001935c78671cc6eabaca7c355343c2e99d6d7","user":{"login":"software-dov","id":2960535,"node_id":"MDQ6VXNlcjI5NjA1MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2960535?v=4","gravatar_id":"","url":"https://api.github.com/users/software-dov","html_url":"https://github.com/software-dov","followers_url":"https://api.github.com/users/software-dov/followers","following_url":"https://api.github.com/users/software-dov/following{/other_user}","gists_url":"https://api.github.com/users/software-dov/gists{/gist_id}","starred_url":"https://api.github.com/users/software-dov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/software-dov/subscriptions","organizations_url":"https://api.github.com/users/software-dov/orgs","repos_url":"https://api.github.com/users/software-dov/repos","events_url":"https://api.github.com/users/software-dov/events{/privacy}","received_events_url":"https://api.github.com/users/software-dov/received_events","type":"User","site_admin":false},"body":"Thanks!","created_at":"2019-12-04T23:15:40Z","updated_at":"2019-12-04T23:15:41Z","html_url":"https://github.com/googleapis/google-cloud-python/pull/9911#discussion_r354036398","pull_request_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/9911","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/comments/354036398"},"html":{"href":"https://github.com/googleapis/google-cloud-python/pull/9911#discussion_r354036398"},"pull_request":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/9911"}},"in_reply_to_id":353461079},"pull_request":{"url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/9911","id":348588737,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4NTg4NzM3","html_url":"https://github.com/googleapis/google-cloud-python/pull/9911","diff_url":"https://github.com/googleapis/google-cloud-python/pull/9911.diff","patch_url":"https://github.com/googleapis/google-cloud-python/pull/9911.patch","issue_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues/9911","number":9911,"state":"open","locked":false,"title":"fix(pubsub): include request overhead when computing publish batch size overflow","user":{"login":"plamut","id":1235663,"node_id":"MDQ6VXNlcjEyMzU2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1235663?v=4","gravatar_id":"","url":"https://api.github.com/users/plamut","html_url":"https://github.com/plamut","followers_url":"https://api.github.com/users/plamut/followers","following_url":"https://api.github.com/users/plamut/following{/other_user}","gists_url":"https://api.github.com/users/plamut/gists{/gist_id}","starred_url":"https://api.github.com/users/plamut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamut/subscriptions","organizations_url":"https://api.github.com/users/plamut/orgs","repos_url":"https://api.github.com/users/plamut/repos","events_url":"https://api.github.com/users/plamut/events{/privacy}","received_events_url":"https://api.github.com/users/plamut/received_events","type":"User","site_admin":false},"body":"Fixes #7108. \r\n\r\nThis PR fixes the logic that computes the publish batch size overflow, taking the total request message size overhead into account. The improved logic prevents the server-side errors simular to the following:\r\n\r\n> google.api_core.exceptions.InvalidArgument: 400 The value for request_size is too large. You passed 10000096 in the request, but the maximum value is 10000000.\r\n\r\n### How to test\r\n\r\n(see also the system test in this PR)\r\n\r\n- Create a pubisher client with `BatchSettings.max_bytes` substantially larger than 10_000_000, and `BatchSettings.max_latency` to one second (so that the publish autocommit does not kick in too soon).\r\n- Quickly publish a few sizable messages to a topic. Their total size should slightly exceed 10_000_000 bytes.\r\n\r\n**Actual result (before the fix):**\r\nThe backend responds with a \"400 InvalidArgument\" error.\r\n\r\n**Expected result (after the fix):**\r\nAll messages are successfully published (the code splits them into multiple publish batches).\r\n\r\n### PR checklist\r\n- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-cloud-python/issues) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea\r\n- [x] Ensure the tests and linter pass\r\n- [x] Code coverage does not decrease (if any source code was changed)\r\n- [x] Appropriate docs were updated (if necessary)\r\n\r\n","created_at":"2019-12-03T22:35:55Z","updated_at":"2019-12-04T23:15:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9116d33857ad60af68f521995d1fb9a646e4a26","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pradn","id":943279,"node_id":"MDQ6VXNlcjk0MzI3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/943279?v=4","gravatar_id":"","url":"https://api.github.com/users/pradn","html_url":"https://github.com/pradn","followers_url":"https://api.github.com/users/pradn/followers","following_url":"https://api.github.com/users/pradn/following{/other_user}","gists_url":"https://api.github.com/users/pradn/gists{/gist_id}","starred_url":"https://api.github.com/users/pradn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradn/subscriptions","organizations_url":"https://api.github.com/users/pradn/orgs","repos_url":"https://api.github.com/users/pradn/repos","events_url":"https://api.github.com/users/pradn/events{/privacy}","received_events_url":"https://api.github.com/users/pradn/received_events","type":"User","site_admin":false},{"login":"software-dov","id":2960535,"node_id":"MDQ6VXNlcjI5NjA1MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2960535?v=4","gravatar_id":"","url":"https://api.github.com/users/software-dov","html_url":"https://github.com/software-dov","followers_url":"https://api.github.com/users/software-dov/followers","following_url":"https://api.github.com/users/software-dov/following{/other_user}","gists_url":"https://api.github.com/users/software-dov/gists{/gist_id}","starred_url":"https://api.github.com/users/software-dov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/software-dov/subscriptions","organizations_url":"https://api.github.com/users/software-dov/orgs","repos_url":"https://api.github.com/users/software-dov/repos","events_url":"https://api.github.com/users/software-dov/events{/privacy}","received_events_url":"https://api.github.com/users/software-dov/received_events","type":"User","site_admin":false},{"login":"anguillanneuf","id":9518298,"node_id":"MDQ6VXNlcjk1MTgyOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9518298?v=4","gravatar_id":"","url":"https://api.github.com/users/anguillanneuf","html_url":"https://github.com/anguillanneuf","followers_url":"https://api.github.com/users/anguillanneuf/followers","following_url":"https://api.github.com/users/anguillanneuf/following{/other_user}","gists_url":"https://api.github.com/users/anguillanneuf/gists{/gist_id}","starred_url":"https://api.github.com/users/anguillanneuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anguillanneuf/subscriptions","organizations_url":"https://api.github.com/users/anguillanneuf/orgs","repos_url":"https://api.github.com/users/anguillanneuf/repos","events_url":"https://api.github.com/users/anguillanneuf/events{/privacy}","received_events_url":"https://api.github.com/users/anguillanneuf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":139685153,"node_id":"MDU6TGFiZWwxMzk2ODUxNTM=","url":"https://api.github.com/repos/googleapis/google-cloud-python/labels/api:%20pubsub","name":"api: pubsub","color":"f8f8f8","default":false,"description":""},{"id":131682747,"node_id":"MDU6TGFiZWwxMzE2ODI3NDc=","url":"https://api.github.com/repos/googleapis/google-cloud-python/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/9911/commits","review_comments_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/9911/comments","review_comment_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues/9911/comments","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-python/statuses/289935ebb011904038c0a109b954ec8fbb3b5795","head":{"label":"plamut:iss-7108","ref":"iss-7108","sha":"289935ebb011904038c0a109b954ec8fbb3b5795","user":{"login":"plamut","id":1235663,"node_id":"MDQ6VXNlcjEyMzU2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1235663?v=4","gravatar_id":"","url":"https://api.github.com/users/plamut","html_url":"https://github.com/plamut","followers_url":"https://api.github.com/users/plamut/followers","following_url":"https://api.github.com/users/plamut/following{/other_user}","gists_url":"https://api.github.com/users/plamut/gists{/gist_id}","starred_url":"https://api.github.com/users/plamut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamut/subscriptions","organizations_url":"https://api.github.com/users/plamut/orgs","repos_url":"https://api.github.com/users/plamut/repos","events_url":"https://api.github.com/users/plamut/events{/privacy}","received_events_url":"https://api.github.com/users/plamut/received_events","type":"User","site_admin":false},"repo":{"id":177846461,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc4NDY0NjE=","name":"google-cloud-python","full_name":"plamut/google-cloud-python","private":false,"owner":{"login":"plamut","id":1235663,"node_id":"MDQ6VXNlcjEyMzU2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1235663?v=4","gravatar_id":"","url":"https://api.github.com/users/plamut","html_url":"https://github.com/plamut","followers_url":"https://api.github.com/users/plamut/followers","following_url":"https://api.github.com/users/plamut/following{/other_user}","gists_url":"https://api.github.com/users/plamut/gists{/gist_id}","starred_url":"https://api.github.com/users/plamut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamut/subscriptions","organizations_url":"https://api.github.com/users/plamut/orgs","repos_url":"https://api.github.com/users/plamut/repos","events_url":"https://api.github.com/users/plamut/events{/privacy}","received_events_url":"https://api.github.com/users/plamut/received_events","type":"User","site_admin":false},"html_url":"https://github.com/plamut/google-cloud-python","description":"Google Cloud Client Library for Python","fork":true,"url":"https://api.github.com/repos/plamut/google-cloud-python","forks_url":"https://api.github.com/repos/plamut/google-cloud-python/forks","keys_url":"https://api.github.com/repos/plamut/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plamut/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plamut/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/plamut/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/plamut/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/plamut/google-cloud-python/events","assignees_url":"https://api.github.com/repos/plamut/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/plamut/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/plamut/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/plamut/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plamut/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plamut/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/plamut/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plamut/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/plamut/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/plamut/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/plamut/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/plamut/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/plamut/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/plamut/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/plamut/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/plamut/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/plamut/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/plamut/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/plamut/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plamut/google-cloud-python/merges","archive_url":"https://api.github.com/repos/plamut/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plamut/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/plamut/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/plamut/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/plamut/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/plamut/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plamut/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/plamut/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/plamut/google-cloud-python/deployments","created_at":"2019-03-26T18:27:52Z","updated_at":"2019-12-04T21:44:45Z","pushed_at":"2019-12-04T21:58:52Z","git_url":"git://github.com/plamut/google-cloud-python.git","ssh_url":"git@github.com:plamut/google-cloud-python.git","clone_url":"https://github.com/plamut/google-cloud-python.git","svn_url":"https://github.com/plamut/google-cloud-python","homepage":"https://googleapis.github.io/google-cloud-python/","size":893689,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"38d8f2b8bdbfdb27dc84b4f3d4ed4998d4cf52e5","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMxNjQ1MQ==","name":"google-cloud-python","full_name":"googleapis/google-cloud-python","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/googleapis/google-cloud-python","forks_url":"https://api.github.com/repos/googleapis/google-cloud-python/forks","keys_url":"https://api.github.com/repos/googleapis/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/googleapis/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/google-cloud-python/events","assignees_url":"https://api.github.com/repos/googleapis/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/googleapis/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/googleapis/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/googleapis/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/googleapis/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/googleapis/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/google-cloud-python/merges","archive_url":"https://api.github.com/repos/googleapis/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2019-12-04T21:27:01Z","pushed_at":"2019-12-04T21:58:54Z","git_url":"git://github.com/googleapis/google-cloud-python.git","ssh_url":"git@github.com:googleapis/google-cloud-python.git","clone_url":"https://github.com/googleapis/google-cloud-python.git","svn_url":"https://github.com/googleapis/google-cloud-python","homepage":"https://googleapis.github.io/google-cloud-python/","size":1779747,"stargazers_count":2946,"watchers_count":2946,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1227,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":226,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1227,"open_issues":226,"watchers":2946,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/9911"},"html":{"href":"https://github.com/googleapis/google-cloud-python/pull/9911"},"issue":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/issues/9911"},"comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/issues/9911/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/9911/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/9911/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/statuses/289935ebb011904038c0a109b954ec8fbb3b5795"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 16316451,
"name": "googleapis/google-cloud-python",
"url": "https://api.github.com/repos/googleapis/google-cloud-python"
}
|
{
"id": 2960535,
"login": "software-dov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2960535?",
"url": "https://api.github.com/users/software-dov"
}
|
{
"id": 16785467,
"login": "googleapis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16785467?",
"url": "https://api.github.com/orgs/googleapis"
}
| 2019-12-04T23:15:40 |
11014633490
|
{"actor":{"display_login":"software-dov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/druids/django-pymess/pulls/comments/359387524","pull_request_review_id":334027083,"id":359387524,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTM4NzUyNA==","diff_hunk":"@@ -108,7 +114,7 @@ def publish_message(self, message):\n payload = {\n 'queue': (settings.DIALER_DAKTELA.AUTODIALER_QUEUE if message.is_autodialer\n else settings.DIALER_DAKTELA.PREDICTIVE_QUEUE),\n- 'number': message.recipient,\n+ 'number': re.sub(r'^\\+', '00', message.recipient),","path":"pymess/backend/dialer/daktela.py","position":44,"original_position":44,"commit_id":"9e29f570bb552dc7e08634a18a1326db503f56be","original_commit_id":"9e29f570bb552dc7e08634a18a1326db503f56be","user":{"login":"jsilhan","id":5243763,"node_id":"MDQ6VXNlcjUyNDM3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5243763?v=4","gravatar_id":"","url":"https://api.github.com/users/jsilhan","html_url":"https://github.com/jsilhan","followers_url":"https://api.github.com/users/jsilhan/followers","following_url":"https://api.github.com/users/jsilhan/following{/other_user}","gists_url":"https://api.github.com/users/jsilhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilhan/subscriptions","organizations_url":"https://api.github.com/users/jsilhan/orgs","repos_url":"https://api.github.com/users/jsilhan/repos","events_url":"https://api.github.com/users/jsilhan/events{/privacy}","received_events_url":"https://api.github.com/users/jsilhan/received_events","type":"User","site_admin":false},"body":"recommendation from Daktela support.","created_at":"2019-12-18T14:53:45Z","updated_at":"2019-12-18T14:53:45Z","html_url":"https://github.com/druids/django-pymess/pull/49#discussion_r359387524","pull_request_url":"https://api.github.com/repos/druids/django-pymess/pulls/49","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/druids/django-pymess/pulls/comments/359387524"},"html":{"href":"https://github.com/druids/django-pymess/pull/49#discussion_r359387524"},"pull_request":{"href":"https://api.github.com/repos/druids/django-pymess/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/druids/django-pymess/pulls/49","id":354475826,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0NDc1ODI2","html_url":"https://github.com/druids/django-pymess/pull/49","diff_url":"https://github.com/druids/django-pymess/pull/49.diff","patch_url":"https://github.com/druids/django-pymess/pull/49.patch","issue_url":"https://api.github.com/repos/druids/django-pymess/issues/49","number":49,"state":"open","locked":false,"title":"Daktela: handle error responses","user":{"login":"jsilhan","id":5243763,"node_id":"MDQ6VXNlcjUyNDM3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5243763?v=4","gravatar_id":"","url":"https://api.github.com/users/jsilhan","html_url":"https://github.com/jsilhan","followers_url":"https://api.github.com/users/jsilhan/followers","following_url":"https://api.github.com/users/jsilhan/following{/other_user}","gists_url":"https://api.github.com/users/jsilhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilhan/subscriptions","organizations_url":"https://api.github.com/users/jsilhan/orgs","repos_url":"https://api.github.com/users/jsilhan/repos","events_url":"https://api.github.com/users/jsilhan/events{/privacy}","received_events_url":"https://api.github.com/users/jsilhan/received_events","type":"User","site_admin":false},"body":"KNJ-8417 and KNJ-8426 issues are being fixed here.","created_at":"2019-12-18T07:46:58Z","updated_at":"2019-12-18T14:53:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3ea8e7e94c4940e10aac4529d56562974ad1d58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/druids/django-pymess/pulls/49/commits","review_comments_url":"https://api.github.com/repos/druids/django-pymess/pulls/49/comments","review_comment_url":"https://api.github.com/repos/druids/django-pymess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druids/django-pymess/issues/49/comments","statuses_url":"https://api.github.com/repos/druids/django-pymess/statuses/9e29f570bb552dc7e08634a18a1326db503f56be","head":{"label":"jsilhan:KNJ-8417","ref":"KNJ-8417","sha":"9e29f570bb552dc7e08634a18a1326db503f56be","user":{"login":"jsilhan","id":5243763,"node_id":"MDQ6VXNlcjUyNDM3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5243763?v=4","gravatar_id":"","url":"https://api.github.com/users/jsilhan","html_url":"https://github.com/jsilhan","followers_url":"https://api.github.com/users/jsilhan/followers","following_url":"https://api.github.com/users/jsilhan/following{/other_user}","gists_url":"https://api.github.com/users/jsilhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilhan/subscriptions","organizations_url":"https://api.github.com/users/jsilhan/orgs","repos_url":"https://api.github.com/users/jsilhan/repos","events_url":"https://api.github.com/users/jsilhan/events{/privacy}","received_events_url":"https://api.github.com/users/jsilhan/received_events","type":"User","site_admin":false},"repo":{"id":226154786,"node_id":"MDEwOlJlcG9zaXRvcnkyMjYxNTQ3ODY=","name":"django-pymess","full_name":"jsilhan/django-pymess","private":false,"owner":{"login":"jsilhan","id":5243763,"node_id":"MDQ6VXNlcjUyNDM3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5243763?v=4","gravatar_id":"","url":"https://api.github.com/users/jsilhan","html_url":"https://github.com/jsilhan","followers_url":"https://api.github.com/users/jsilhan/followers","following_url":"https://api.github.com/users/jsilhan/following{/other_user}","gists_url":"https://api.github.com/users/jsilhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilhan/subscriptions","organizations_url":"https://api.github.com/users/jsilhan/orgs","repos_url":"https://api.github.com/users/jsilhan/repos","events_url":"https://api.github.com/users/jsilhan/events{/privacy}","received_events_url":"https://api.github.com/users/jsilhan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jsilhan/django-pymess","description":null,"fork":true,"url":"https://api.github.com/repos/jsilhan/django-pymess","forks_url":"https://api.github.com/repos/jsilhan/django-pymess/forks","keys_url":"https://api.github.com/repos/jsilhan/django-pymess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsilhan/django-pymess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsilhan/django-pymess/teams","hooks_url":"https://api.github.com/repos/jsilhan/django-pymess/hooks","issue_events_url":"https://api.github.com/repos/jsilhan/django-pymess/issues/events{/number}","events_url":"https://api.github.com/repos/jsilhan/django-pymess/events","assignees_url":"https://api.github.com/repos/jsilhan/django-pymess/assignees{/user}","branches_url":"https://api.github.com/repos/jsilhan/django-pymess/branches{/branch}","tags_url":"https://api.github.com/repos/jsilhan/django-pymess/tags","blobs_url":"https://api.github.com/repos/jsilhan/django-pymess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsilhan/django-pymess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsilhan/django-pymess/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsilhan/django-pymess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsilhan/django-pymess/statuses/{sha}","languages_url":"https://api.github.com/repos/jsilhan/django-pymess/languages","stargazers_url":"https://api.github.com/repos/jsilhan/django-pymess/stargazers","contributors_url":"https://api.github.com/repos/jsilhan/django-pymess/contributors","subscribers_url":"https://api.github.com/repos/jsilhan/django-pymess/subscribers","subscription_url":"https://api.github.com/repos/jsilhan/django-pymess/subscription","commits_url":"https://api.github.com/repos/jsilhan/django-pymess/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsilhan/django-pymess/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsilhan/django-pymess/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsilhan/django-pymess/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsilhan/django-pymess/contents/{+path}","compare_url":"https://api.github.com/repos/jsilhan/django-pymess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsilhan/django-pymess/merges","archive_url":"https://api.github.com/repos/jsilhan/django-pymess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsilhan/django-pymess/downloads","issues_url":"https://api.github.com/repos/jsilhan/django-pymess/issues{/number}","pulls_url":"https://api.github.com/repos/jsilhan/django-pymess/pulls{/number}","milestones_url":"https://api.github.com/repos/jsilhan/django-pymess/milestones{/number}","notifications_url":"https://api.github.com/repos/jsilhan/django-pymess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsilhan/django-pymess/labels{/name}","releases_url":"https://api.github.com/repos/jsilhan/django-pymess/releases{/id}","deployments_url":"https://api.github.com/repos/jsilhan/django-pymess/deployments","created_at":"2019-12-05T17:29:00Z","updated_at":"2019-12-05T17:29:02Z","pushed_at":"2019-12-18T14:47:26Z","git_url":"git://github.com/jsilhan/django-pymess.git","ssh_url":"git@github.com:jsilhan/django-pymess.git","clone_url":"https://github.com/jsilhan/django-pymess.git","svn_url":"https://github.com/jsilhan/django-pymess","homepage":null,"size":242,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druids:master","ref":"master","sha":"def9558d403d0889e7c38c38f152f671bf2eeaa7","user":{"login":"druids","id":16963627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTYzNjI3","avatar_url":"https://avatars2.githubusercontent.com/u/16963627?v=4","gravatar_id":"","url":"https://api.github.com/users/druids","html_url":"https://github.com/druids","followers_url":"https://api.github.com/users/druids/followers","following_url":"https://api.github.com/users/druids/following{/other_user}","gists_url":"https://api.github.com/users/druids/gists{/gist_id}","starred_url":"https://api.github.com/users/druids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druids/subscriptions","organizations_url":"https://api.github.com/users/druids/orgs","repos_url":"https://api.github.com/users/druids/repos","events_url":"https://api.github.com/users/druids/events{/privacy}","received_events_url":"https://api.github.com/users/druids/received_events","type":"Organization","site_admin":false},"repo":{"id":117111078,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxMTEwNzg=","name":"django-pymess","full_name":"druids/django-pymess","private":false,"owner":{"login":"druids","id":16963627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTYzNjI3","avatar_url":"https://avatars2.githubusercontent.com/u/16963627?v=4","gravatar_id":"","url":"https://api.github.com/users/druids","html_url":"https://github.com/druids","followers_url":"https://api.github.com/users/druids/followers","following_url":"https://api.github.com/users/druids/following{/other_user}","gists_url":"https://api.github.com/users/druids/gists{/gist_id}","starred_url":"https://api.github.com/users/druids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druids/subscriptions","organizations_url":"https://api.github.com/users/druids/orgs","repos_url":"https://api.github.com/users/druids/repos","events_url":"https://api.github.com/users/druids/events{/privacy}","received_events_url":"https://api.github.com/users/druids/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/druids/django-pymess","description":null,"fork":false,"url":"https://api.github.com/repos/druids/django-pymess","forks_url":"https://api.github.com/repos/druids/django-pymess/forks","keys_url":"https://api.github.com/repos/druids/django-pymess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druids/django-pymess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druids/django-pymess/teams","hooks_url":"https://api.github.com/repos/druids/django-pymess/hooks","issue_events_url":"https://api.github.com/repos/druids/django-pymess/issues/events{/number}","events_url":"https://api.github.com/repos/druids/django-pymess/events","assignees_url":"https://api.github.com/repos/druids/django-pymess/assignees{/user}","branches_url":"https://api.github.com/repos/druids/django-pymess/branches{/branch}","tags_url":"https://api.github.com/repos/druids/django-pymess/tags","blobs_url":"https://api.github.com/repos/druids/django-pymess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druids/django-pymess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druids/django-pymess/git/refs{/sha}","trees_url":"https://api.github.com/repos/druids/django-pymess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druids/django-pymess/statuses/{sha}","languages_url":"https://api.github.com/repos/druids/django-pymess/languages","stargazers_url":"https://api.github.com/repos/druids/django-pymess/stargazers","contributors_url":"https://api.github.com/repos/druids/django-pymess/contributors","subscribers_url":"https://api.github.com/repos/druids/django-pymess/subscribers","subscription_url":"https://api.github.com/repos/druids/django-pymess/subscription","commits_url":"https://api.github.com/repos/druids/django-pymess/commits{/sha}","git_commits_url":"https://api.github.com/repos/druids/django-pymess/git/commits{/sha}","comments_url":"https://api.github.com/repos/druids/django-pymess/comments{/number}","issue_comment_url":"https://api.github.com/repos/druids/django-pymess/issues/comments{/number}","contents_url":"https://api.github.com/repos/druids/django-pymess/contents/{+path}","compare_url":"https://api.github.com/repos/druids/django-pymess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druids/django-pymess/merges","archive_url":"https://api.github.com/repos/druids/django-pymess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druids/django-pymess/downloads","issues_url":"https://api.github.com/repos/druids/django-pymess/issues{/number}","pulls_url":"https://api.github.com/repos/druids/django-pymess/pulls{/number}","milestones_url":"https://api.github.com/repos/druids/django-pymess/milestones{/number}","notifications_url":"https://api.github.com/repos/druids/django-pymess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druids/django-pymess/labels{/name}","releases_url":"https://api.github.com/repos/druids/django-pymess/releases{/id}","deployments_url":"https://api.github.com/repos/druids/django-pymess/deployments","created_at":"2018-01-11T14:27:55Z","updated_at":"2019-12-13T11:53:51Z","pushed_at":"2019-12-18T14:47:28Z","git_url":"git://github.com/druids/django-pymess.git","ssh_url":"git@github.com:druids/django-pymess.git","clone_url":"https://github.com/druids/django-pymess.git","svn_url":"https://github.com/druids/django-pymess","homepage":null,"size":239,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":9,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druids/django-pymess/pulls/49"},"html":{"href":"https://github.com/druids/django-pymess/pull/49"},"issue":{"href":"https://api.github.com/repos/druids/django-pymess/issues/49"},"comments":{"href":"https://api.github.com/repos/druids/django-pymess/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/druids/django-pymess/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/druids/django-pymess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druids/django-pymess/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/druids/django-pymess/statuses/9e29f570bb552dc7e08634a18a1326db503f56be"}},"author_association":"NONE"}}
|
{
"id": 117111078,
"name": "druids/django-pymess",
"url": "https://api.github.com/repos/druids/django-pymess"
}
|
{
"id": 5243763,
"login": "jsilhan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5243763?",
"url": "https://api.github.com/users/jsilhan"
}
|
{
"id": 16963627,
"login": "druids",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16963627?",
"url": "https://api.github.com/orgs/druids"
}
| 2019-12-18T14:53:45 |
11117420316
|
{"actor":{"display_login":"jsilhan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/comments/277188628","pull_request_review_id":228934487,"id":277188628,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzE4ODYyOA==","diff_hunk":"@@ -0,0 +1,221 @@\n+package com.videocartago.renting.domain;\n+\n+import java.util.List;\n+\n+import com.videocartago.renting.domain.Pelicula;\n+import com.videocartago.renting.factoryAbstract.PeliculaAbstract;\n+\n+public class TodoPublicoPersona extends PeliculaAbstract\t {\n+\tprivate int codPelicula;\n+\tprivate String titulo;\n+\tprivate int totalPeliculas;\n+\tprivate boolean subtitulada;","path":"B77436/Tarea3+B77346/renting/src/main/java/com/videocartago/renting/domain/TodoPublicoPersona.java","position":12,"original_position":12,"commit_id":"a4fa4cdd7729e10b2215d18f028d2691892e9678","original_commit_id":"a4fa4cdd7729e10b2215d18f028d2691892e9678","user":{"login":"cguillencr","id":3529048,"node_id":"MDQ6VXNlcjM1MjkwNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3529048?v=4","gravatar_id":"","url":"https://api.github.com/users/cguillencr","html_url":"https://github.com/cguillencr","followers_url":"https://api.github.com/users/cguillencr/followers","following_url":"https://api.github.com/users/cguillencr/following{/other_user}","gists_url":"https://api.github.com/users/cguillencr/gists{/gist_id}","starred_url":"https://api.github.com/users/cguillencr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cguillencr/subscriptions","organizations_url":"https://api.github.com/users/cguillencr/orgs","repos_url":"https://api.github.com/users/cguillencr/repos","events_url":"https://api.github.com/users/cguillencr/events{/privacy}","received_events_url":"https://api.github.com/users/cguillencr/received_events","type":"User","site_admin":false},"body":"Mover todas las propiedades comunes en las subclases a la super clase.","created_at":"2019-04-22T01:16:39Z","updated_at":"2019-04-22T01:17:11Z","html_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pull/92#discussion_r277188628","pull_request_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/92","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/comments/277188628"},"html":{"href":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pull/92#discussion_r277188628"},"pull_request":{"href":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/92"}}},"pull_request":{"url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/92","id":270276983,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMjc2OTgz","html_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pull/92","diff_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pull/92.diff","patch_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pull/92.patch","issue_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues/92","number":92,"state":"open","locked":false,"title":"Tarea4_B77436","user":{"login":"EmmanuelSolano","id":37588135,"node_id":"MDQ6VXNlcjM3NTg4MTM1","avatar_url":"https://avatars0.githubusercontent.com/u/37588135?v=4","gravatar_id":"","url":"https://api.github.com/users/EmmanuelSolano","html_url":"https://github.com/EmmanuelSolano","followers_url":"https://api.github.com/users/EmmanuelSolano/followers","following_url":"https://api.github.com/users/EmmanuelSolano/following{/other_user}","gists_url":"https://api.github.com/users/EmmanuelSolano/gists{/gist_id}","starred_url":"https://api.github.com/users/EmmanuelSolano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmmanuelSolano/subscriptions","organizations_url":"https://api.github.com/users/EmmanuelSolano/orgs","repos_url":"https://api.github.com/users/EmmanuelSolano/repos","events_url":"https://api.github.com/users/EmmanuelSolano/events{/privacy}","received_events_url":"https://api.github.com/users/EmmanuelSolano/received_events","type":"User","site_admin":false},"body":"Tarea3+B77436","created_at":"2019-04-14T07:12:47Z","updated_at":"2019-04-22T01:17:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3f35800f3d74352204ab067553a6b8d1f944bc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/92/commits","review_comments_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/92/comments","review_comment_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues/92/comments","statuses_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/statuses/a4fa4cdd7729e10b2215d18f028d2691892e9678","head":{"label":"UCR-Paraiso-Lenguajes:Tarea4_B77436","ref":"Tarea4_B77436","sha":"a4fa4cdd7729e10b2215d18f028d2691892e9678","user":{"login":"UCR-Paraiso-Lenguajes","id":17264950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjY0OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/17264950?v=4","gravatar_id":"","url":"https://api.github.com/users/UCR-Paraiso-Lenguajes","html_url":"https://github.com/UCR-Paraiso-Lenguajes","followers_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/followers","following_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/following{/other_user}","gists_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/gists{/gist_id}","starred_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/subscriptions","organizations_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/orgs","repos_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/repos","events_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/events{/privacy}","received_events_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/received_events","type":"Organization","site_admin":false},"repo":{"id":176178641,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYxNzg2NDE=","name":"Lenguajes-1-12019","full_name":"UCR-Paraiso-Lenguajes/Lenguajes-1-12019","private":false,"owner":{"login":"UCR-Paraiso-Lenguajes","id":17264950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjY0OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/17264950?v=4","gravatar_id":"","url":"https://api.github.com/users/UCR-Paraiso-Lenguajes","html_url":"https://github.com/UCR-Paraiso-Lenguajes","followers_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/followers","following_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/following{/other_user}","gists_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/gists{/gist_id}","starred_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/subscriptions","organizations_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/orgs","repos_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/repos","events_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/events{/privacy}","received_events_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019","description":null,"fork":false,"url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019","forks_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/forks","keys_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/teams","hooks_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/hooks","issue_events_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues/events{/number}","events_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/events","assignees_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/assignees{/user}","branches_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/branches{/branch}","tags_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/tags","blobs_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/statuses/{sha}","languages_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/languages","stargazers_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/stargazers","contributors_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/contributors","subscribers_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/subscribers","subscription_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/subscription","commits_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/contents/{+path}","compare_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/merges","archive_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/downloads","issues_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues{/number}","pulls_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls{/number}","milestones_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/milestones{/number}","notifications_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/labels{/name}","releases_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/releases{/id}","deployments_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/deployments","created_at":"2019-03-18T00:42:16Z","updated_at":"2019-04-21T22:27:10Z","pushed_at":"2019-04-21T22:27:04Z","git_url":"git://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019.git","ssh_url":"git@github.com:UCR-Paraiso-Lenguajes/Lenguajes-1-12019.git","clone_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019.git","svn_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019","homepage":null,"size":22528,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":null,"forks":1,"open_issues":36,"watchers":2,"default_branch":"master"}},"base":{"label":"UCR-Paraiso-Lenguajes:master","ref":"master","sha":"14a85405fea5b823c803674e4515f1bae94bd412","user":{"login":"UCR-Paraiso-Lenguajes","id":17264950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjY0OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/17264950?v=4","gravatar_id":"","url":"https://api.github.com/users/UCR-Paraiso-Lenguajes","html_url":"https://github.com/UCR-Paraiso-Lenguajes","followers_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/followers","following_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/following{/other_user}","gists_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/gists{/gist_id}","starred_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/subscriptions","organizations_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/orgs","repos_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/repos","events_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/events{/privacy}","received_events_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/received_events","type":"Organization","site_admin":false},"repo":{"id":176178641,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYxNzg2NDE=","name":"Lenguajes-1-12019","full_name":"UCR-Paraiso-Lenguajes/Lenguajes-1-12019","private":false,"owner":{"login":"UCR-Paraiso-Lenguajes","id":17264950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjY0OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/17264950?v=4","gravatar_id":"","url":"https://api.github.com/users/UCR-Paraiso-Lenguajes","html_url":"https://github.com/UCR-Paraiso-Lenguajes","followers_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/followers","following_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/following{/other_user}","gists_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/gists{/gist_id}","starred_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/subscriptions","organizations_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/orgs","repos_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/repos","events_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/events{/privacy}","received_events_url":"https://api.github.com/users/UCR-Paraiso-Lenguajes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019","description":null,"fork":false,"url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019","forks_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/forks","keys_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/teams","hooks_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/hooks","issue_events_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues/events{/number}","events_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/events","assignees_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/assignees{/user}","branches_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/branches{/branch}","tags_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/tags","blobs_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/statuses/{sha}","languages_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/languages","stargazers_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/stargazers","contributors_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/contributors","subscribers_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/subscribers","subscription_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/subscription","commits_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/contents/{+path}","compare_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/merges","archive_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/downloads","issues_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues{/number}","pulls_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls{/number}","milestones_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/milestones{/number}","notifications_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/labels{/name}","releases_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/releases{/id}","deployments_url":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/deployments","created_at":"2019-03-18T00:42:16Z","updated_at":"2019-04-21T22:27:10Z","pushed_at":"2019-04-21T22:27:04Z","git_url":"git://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019.git","ssh_url":"git@github.com:UCR-Paraiso-Lenguajes/Lenguajes-1-12019.git","clone_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019.git","svn_url":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019","homepage":null,"size":22528,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":null,"forks":1,"open_issues":36,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/92"},"html":{"href":"https://github.com/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pull/92"},"issue":{"href":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues/92"},"comments":{"href":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019/statuses/a4fa4cdd7729e10b2215d18f028d2691892e9678"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 176178641,
"name": "UCR-Paraiso-Lenguajes/Lenguajes-1-12019",
"url": "https://api.github.com/repos/UCR-Paraiso-Lenguajes/Lenguajes-1-12019"
}
|
{
"id": 3529048,
"login": "cguillencr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3529048?",
"url": "https://api.github.com/users/cguillencr"
}
|
{
"id": 17264950,
"login": "UCR-Paraiso-Lenguajes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17264950?",
"url": "https://api.github.com/orgs/UCR-Paraiso-Lenguajes"
}
| 2019-04-22T01:16:39 |
9483552658
|
{"actor":{"display_login":"cguillencr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/comments/257069701","pull_request_review_id":204038403,"id":257069701,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzA2OTcwMQ==","diff_hunk":"@@ -38,11 +32,8 @@ const screenerState: fromScreener.State = {\n error: '',\n selectedConstantQuestion: 'fake_id',\n selectedConditionalQuestion: undefined,\n- keys: [\n- {name: 'boolean_key', type: 'boolean'},\n- {name: 'integer_key', type: 'integer'}\n- ],\n- created: 0\n+ created: 0,\n+ DATA: 'TEST'","path":"frontend/src/app/admin/screener/screener-toolbar/screener-toolbar.component.spec.ts","position":28,"original_position":28,"commit_id":"f153bc00df9f093a577256af66259994aeae8888","original_commit_id":"f153bc00df9f093a577256af66259994aeae8888","user":{"login":"slmyers","id":6344732,"node_id":"MDQ6VXNlcjYzNDQ3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6344732?v=4","gravatar_id":"","url":"https://api.github.com/users/slmyers","html_url":"https://github.com/slmyers","followers_url":"https://api.github.com/users/slmyers/followers","following_url":"https://api.github.com/users/slmyers/following{/other_user}","gists_url":"https://api.github.com/users/slmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/slmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slmyers/subscriptions","organizations_url":"https://api.github.com/users/slmyers/orgs","repos_url":"https://api.github.com/users/slmyers/repos","events_url":"https://api.github.com/users/slmyers/events{/privacy}","received_events_url":"https://api.github.com/users/slmyers/received_events","type":"User","site_admin":false},"body":"please remove test value","created_at":"2019-02-15T00:46:10Z","updated_at":"2019-02-15T00:59:35Z","html_url":"https://github.com/yeg-relief/youcanbenefit/pull/76#discussion_r257069701","pull_request_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/76","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/comments/257069701"},"html":{"href":"https://github.com/yeg-relief/youcanbenefit/pull/76#discussion_r257069701"},"pull_request":{"href":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/76","id":252118936,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyMTE4OTM2","html_url":"https://github.com/yeg-relief/youcanbenefit/pull/76","diff_url":"https://github.com/yeg-relief/youcanbenefit/pull/76.diff","patch_url":"https://github.com/yeg-relief/youcanbenefit/pull/76.patch","issue_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/issues/76","number":76,"state":"open","locked":false,"title":"Issue #41 - Remove keys","user":{"login":"CodyGramlich","id":32050152,"node_id":"MDQ6VXNlcjMyMDUwMTUy","avatar_url":"https://avatars1.githubusercontent.com/u/32050152?v=4","gravatar_id":"","url":"https://api.github.com/users/CodyGramlich","html_url":"https://github.com/CodyGramlich","followers_url":"https://api.github.com/users/CodyGramlich/followers","following_url":"https://api.github.com/users/CodyGramlich/following{/other_user}","gists_url":"https://api.github.com/users/CodyGramlich/gists{/gist_id}","starred_url":"https://api.github.com/users/CodyGramlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodyGramlich/subscriptions","organizations_url":"https://api.github.com/users/CodyGramlich/orgs","repos_url":"https://api.github.com/users/CodyGramlich/repos","events_url":"https://api.github.com/users/CodyGramlich/events{/privacy}","received_events_url":"https://api.github.com/users/CodyGramlich/received_events","type":"User","site_admin":false},"body":"Resolves issue [#41](https://github.com/yeg-relief/youcanbenefit/issues/41).\r\n\r\nMain changes to look at:\r\n-backend/src/modules/key/key.service.ts\r\n-frontend/src/app/admin/screener/screener-toolbar/screener-toolbar.component.ts\r\n\r\nOnce I got it working without keys, I removed the key object from the frontend in many places, so a lot of the changes are due to that.\r\n\r\nNotes:\r\n- Since you cannot remove mappings in elasticsearch ([see here](https://www.elastic.co/guide/en/elasticsearch/reference/6.4/indices-delete-mapping.html)), I chose to back up the queries, delete the index, and upload the queries and the new mappings every time save screener is clicked.\r\n- If a question belongs to a query and then that question is removed from the screener, I made it so that the conditions with that question are removed from the queries. If there are no conditions left in a query, then that query is deleted. This all happens when re-indexing.\r\n- Queries in elasticsearch now contain a questionTexts object under meta to map the question ID to question text\r\n- I replaced the key object\r\n```\r\nexport interface Key {\r\n name: string;\r\n type: 'boolean' | 'integer' | 'number' | 'invalid' | '';\r\n}\r\n```\r\nwith\r\n```\r\nexport interface QuestionKey {\r\n text: string;\r\n id: string;\r\n type: 'boolean' | 'integer' | 'number' | 'invalid' | '';\r\n}\r\n```\r\nI was going to call this new data type Question, but there is already a type called Question and I didn't want to confuse the two. I went with QuestionKey to also distnguish it from a key. I wasn't sure of a good name for the object. This object type is used on both the frontend and the backend.\r\n- Question texts appear for conditions instead of the key name\r\n- For the most part, key.name has been replaced with questionKey.id. In some cases it has been replaced with questionKey.text, such as when displaying the question texts.\r\n- Multiselect options now have an ID associated with them.\r\n- Keys section has been removed.\r\n- Key filter has been removed.\r\n- There is no longer a drop down menu to select a key for questions and for multiselect options.\r\n- Question_2 interface has been removed.\r\n- The Key attribute of the Question interface has been removed.\r\n- The NumberSelect type of question (select one from the following) has been disabled. I could update it so that it handles this, but for now I left it disabled.\r\n- I haven't changed the name of KeyService or KeyModule in the backend.\r\n- Many tests need to be updated.\r\n- I pulled from release/10 to get Steven's work with mine and resolved the merge conflicts.\r\n- To test it out, you must use Init and then create programs, questions, queries. Uploading an old backup will not work because the key names need to be replaced with question ID's, along with some other stuff. I can convert our current backup to this new format later.\r\n\r\nAny feedback would be great.","created_at":"2019-02-12T00:18:17Z","updated_at":"2019-02-15T00:59:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbd4bc429cd695601440b892bb8897f282a3286c","assignee":{"login":"slmyers","id":6344732,"node_id":"MDQ6VXNlcjYzNDQ3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6344732?v=4","gravatar_id":"","url":"https://api.github.com/users/slmyers","html_url":"https://github.com/slmyers","followers_url":"https://api.github.com/users/slmyers/followers","following_url":"https://api.github.com/users/slmyers/following{/other_user}","gists_url":"https://api.github.com/users/slmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/slmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slmyers/subscriptions","organizations_url":"https://api.github.com/users/slmyers/orgs","repos_url":"https://api.github.com/users/slmyers/repos","events_url":"https://api.github.com/users/slmyers/events{/privacy}","received_events_url":"https://api.github.com/users/slmyers/received_events","type":"User","site_admin":false},"assignees":[{"login":"slmyers","id":6344732,"node_id":"MDQ6VXNlcjYzNDQ3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6344732?v=4","gravatar_id":"","url":"https://api.github.com/users/slmyers","html_url":"https://github.com/slmyers","followers_url":"https://api.github.com/users/slmyers/followers","following_url":"https://api.github.com/users/slmyers/following{/other_user}","gists_url":"https://api.github.com/users/slmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/slmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slmyers/subscriptions","organizations_url":"https://api.github.com/users/slmyers/orgs","repos_url":"https://api.github.com/users/slmyers/repos","events_url":"https://api.github.com/users/slmyers/events{/privacy}","received_events_url":"https://api.github.com/users/slmyers/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/76/commits","review_comments_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/76/comments","review_comment_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/issues/76/comments","statuses_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/statuses/f153bc00df9f093a577256af66259994aeae8888","head":{"label":"CodyGramlich:remove-keys-pull-release/10","ref":"remove-keys-pull-release/10","sha":"f153bc00df9f093a577256af66259994aeae8888","user":{"login":"CodyGramlich","id":32050152,"node_id":"MDQ6VXNlcjMyMDUwMTUy","avatar_url":"https://avatars1.githubusercontent.com/u/32050152?v=4","gravatar_id":"","url":"https://api.github.com/users/CodyGramlich","html_url":"https://github.com/CodyGramlich","followers_url":"https://api.github.com/users/CodyGramlich/followers","following_url":"https://api.github.com/users/CodyGramlich/following{/other_user}","gists_url":"https://api.github.com/users/CodyGramlich/gists{/gist_id}","starred_url":"https://api.github.com/users/CodyGramlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodyGramlich/subscriptions","organizations_url":"https://api.github.com/users/CodyGramlich/orgs","repos_url":"https://api.github.com/users/CodyGramlich/repos","events_url":"https://api.github.com/users/CodyGramlich/events{/privacy}","received_events_url":"https://api.github.com/users/CodyGramlich/received_events","type":"User","site_admin":false},"repo":{"id":164724193,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ3MjQxOTM=","name":"youcanbenefit","full_name":"CodyGramlich/youcanbenefit","private":false,"owner":{"login":"CodyGramlich","id":32050152,"node_id":"MDQ6VXNlcjMyMDUwMTUy","avatar_url":"https://avatars1.githubusercontent.com/u/32050152?v=4","gravatar_id":"","url":"https://api.github.com/users/CodyGramlich","html_url":"https://github.com/CodyGramlich","followers_url":"https://api.github.com/users/CodyGramlich/followers","following_url":"https://api.github.com/users/CodyGramlich/following{/other_user}","gists_url":"https://api.github.com/users/CodyGramlich/gists{/gist_id}","starred_url":"https://api.github.com/users/CodyGramlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodyGramlich/subscriptions","organizations_url":"https://api.github.com/users/CodyGramlich/orgs","repos_url":"https://api.github.com/users/CodyGramlich/repos","events_url":"https://api.github.com/users/CodyGramlich/events{/privacy}","received_events_url":"https://api.github.com/users/CodyGramlich/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CodyGramlich/youcanbenefit","description":" YouCanBenefit is a web application that increases social benefit program discoverability for people of lesser means and their allies.","fork":true,"url":"https://api.github.com/repos/CodyGramlich/youcanbenefit","forks_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/forks","keys_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/teams","hooks_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/hooks","issue_events_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/issues/events{/number}","events_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/events","assignees_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/assignees{/user}","branches_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/branches{/branch}","tags_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/tags","blobs_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/statuses/{sha}","languages_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/languages","stargazers_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/stargazers","contributors_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/contributors","subscribers_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/subscribers","subscription_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/subscription","commits_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/contents/{+path}","compare_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/merges","archive_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/downloads","issues_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/issues{/number}","pulls_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/pulls{/number}","milestones_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/milestones{/number}","notifications_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/labels{/name}","releases_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/releases{/id}","deployments_url":"https://api.github.com/repos/CodyGramlich/youcanbenefit/deployments","created_at":"2019-01-08T20:06:35Z","updated_at":"2019-01-31T18:41:55Z","pushed_at":"2019-02-15T00:28:07Z","git_url":"git://github.com/CodyGramlich/youcanbenefit.git","ssh_url":"git@github.com:CodyGramlich/youcanbenefit.git","clone_url":"https://github.com/CodyGramlich/youcanbenefit.git","svn_url":"https://github.com/CodyGramlich/youcanbenefit","homepage":"https://youcanbenefit.edmonton.ca","size":1110,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yeg-relief:release/41","ref":"release/41","sha":"1de39e6cb738ab12374d0aca358192a0acf83079","user":{"login":"yeg-relief","id":17507869,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTA3ODY5","avatar_url":"https://avatars2.githubusercontent.com/u/17507869?v=4","gravatar_id":"","url":"https://api.github.com/users/yeg-relief","html_url":"https://github.com/yeg-relief","followers_url":"https://api.github.com/users/yeg-relief/followers","following_url":"https://api.github.com/users/yeg-relief/following{/other_user}","gists_url":"https://api.github.com/users/yeg-relief/gists{/gist_id}","starred_url":"https://api.github.com/users/yeg-relief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeg-relief/subscriptions","organizations_url":"https://api.github.com/users/yeg-relief/orgs","repos_url":"https://api.github.com/users/yeg-relief/repos","events_url":"https://api.github.com/users/yeg-relief/events{/privacy}","received_events_url":"https://api.github.com/users/yeg-relief/received_events","type":"Organization","site_admin":false},"repo":{"id":154894647,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4OTQ2NDc=","name":"youcanbenefit","full_name":"yeg-relief/youcanbenefit","private":false,"owner":{"login":"yeg-relief","id":17507869,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTA3ODY5","avatar_url":"https://avatars2.githubusercontent.com/u/17507869?v=4","gravatar_id":"","url":"https://api.github.com/users/yeg-relief","html_url":"https://github.com/yeg-relief","followers_url":"https://api.github.com/users/yeg-relief/followers","following_url":"https://api.github.com/users/yeg-relief/following{/other_user}","gists_url":"https://api.github.com/users/yeg-relief/gists{/gist_id}","starred_url":"https://api.github.com/users/yeg-relief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeg-relief/subscriptions","organizations_url":"https://api.github.com/users/yeg-relief/orgs","repos_url":"https://api.github.com/users/yeg-relief/repos","events_url":"https://api.github.com/users/yeg-relief/events{/privacy}","received_events_url":"https://api.github.com/users/yeg-relief/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yeg-relief/youcanbenefit","description":" YouCanBenefit is a web application that increases social benefit program discoverability for people of lesser means and their allies.","fork":false,"url":"https://api.github.com/repos/yeg-relief/youcanbenefit","forks_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/forks","keys_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/teams","hooks_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/hooks","issue_events_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/issues/events{/number}","events_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/events","assignees_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/assignees{/user}","branches_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/branches{/branch}","tags_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/tags","blobs_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/git/refs{/sha}","trees_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/statuses/{sha}","languages_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/languages","stargazers_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/stargazers","contributors_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/contributors","subscribers_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/subscribers","subscription_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/subscription","commits_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/commits{/sha}","git_commits_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/git/commits{/sha}","comments_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/comments{/number}","issue_comment_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/issues/comments{/number}","contents_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/contents/{+path}","compare_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/merges","archive_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/downloads","issues_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/issues{/number}","pulls_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls{/number}","milestones_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/milestones{/number}","notifications_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/labels{/name}","releases_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/releases{/id}","deployments_url":"https://api.github.com/repos/yeg-relief/youcanbenefit/deployments","created_at":"2018-10-26T21:08:06Z","updated_at":"2019-02-06T19:23:59Z","pushed_at":"2019-02-15T00:28:08Z","git_url":"git://github.com/yeg-relief/youcanbenefit.git","ssh_url":"git@github.com:yeg-relief/youcanbenefit.git","clone_url":"https://github.com/yeg-relief/youcanbenefit.git","svn_url":"https://github.com/yeg-relief/youcanbenefit","homepage":"https://youcanbenefit.edmonton.ca","size":1018,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":20,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/76"},"html":{"href":"https://github.com/yeg-relief/youcanbenefit/pull/76"},"issue":{"href":"https://api.github.com/repos/yeg-relief/youcanbenefit/issues/76"},"comments":{"href":"https://api.github.com/repos/yeg-relief/youcanbenefit/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yeg-relief/youcanbenefit/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/yeg-relief/youcanbenefit/statuses/f153bc00df9f093a577256af66259994aeae8888"}},"author_association":"COLLABORATOR"}}
|
{
"id": 154894647,
"name": "yeg-relief/youcanbenefit",
"url": "https://api.github.com/repos/yeg-relief/youcanbenefit"
}
|
{
"id": 6344732,
"login": "slmyers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6344732?",
"url": "https://api.github.com/users/slmyers"
}
|
{
"id": 17507869,
"login": "yeg-relief",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17507869?",
"url": "https://api.github.com/orgs/yeg-relief"
}
| 2019-02-15T00:46:10 |
9072032859
|
{"actor":{"display_login":"slmyers"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cuappdev/acai-backend/pulls/comments/269688440","pull_request_review_id":219623194,"id":269688440,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTY4ODQ0MA==","diff_hunk":"@@ -23,6 +24,7 @@ class API extends ApplicationAPI {\n HelloWorldRouter,\n LoginRouter,\n RegisterRouter,\n+ RefreshRouter,","path":"src/API.ts","position":12,"original_position":12,"commit_id":"7d2064da294698555a6cf35c42b26907d39f67fe","original_commit_id":"7d2064da294698555a6cf35c42b26907d39f67fe","user":{"login":"kq-li","id":6081311,"node_id":"MDQ6VXNlcjYwODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6081311?v=4","gravatar_id":"","url":"https://api.github.com/users/kq-li","html_url":"https://github.com/kq-li","followers_url":"https://api.github.com/users/kq-li/followers","following_url":"https://api.github.com/users/kq-li/following{/other_user}","gists_url":"https://api.github.com/users/kq-li/gists{/gist_id}","starred_url":"https://api.github.com/users/kq-li/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kq-li/subscriptions","organizations_url":"https://api.github.com/users/kq-li/orgs","repos_url":"https://api.github.com/users/kq-li/repos","events_url":"https://api.github.com/users/kq-li/events{/privacy}","received_events_url":"https://api.github.com/users/kq-li/received_events","type":"User","site_admin":false},"body":"swag","created_at":"2019-03-27T17:40:05Z","updated_at":"2019-03-27T17:40:06Z","html_url":"https://github.com/cuappdev/acai-backend/pull/45#discussion_r269688440","pull_request_url":"https://api.github.com/repos/cuappdev/acai-backend/pulls/45","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cuappdev/acai-backend/pulls/comments/269688440"},"html":{"href":"https://github.com/cuappdev/acai-backend/pull/45#discussion_r269688440"},"pull_request":{"href":"https://api.github.com/repos/cuappdev/acai-backend/pulls/45"}},"in_reply_to_id":269621332},"pull_request":{"url":"https://api.github.com/repos/cuappdev/acai-backend/pulls/45","id":264789599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0Nzg5NTk5","html_url":"https://github.com/cuappdev/acai-backend/pull/45","diff_url":"https://github.com/cuappdev/acai-backend/pull/45.diff","patch_url":"https://github.com/cuappdev/acai-backend/pull/45.patch","issue_url":"https://api.github.com/repos/cuappdev/acai-backend/issues/45","number":45,"state":"open","locked":false,"title":"Implement session authentication","user":{"login":"kq-li","id":6081311,"node_id":"MDQ6VXNlcjYwODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6081311?v=4","gravatar_id":"","url":"https://api.github.com/users/kq-li","html_url":"https://github.com/kq-li","followers_url":"https://api.github.com/users/kq-li/followers","following_url":"https://api.github.com/users/kq-li/following{/other_user}","gists_url":"https://api.github.com/users/kq-li/gists{/gist_id}","starred_url":"https://api.github.com/users/kq-li/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kq-li/subscriptions","organizations_url":"https://api.github.com/users/kq-li/orgs","repos_url":"https://api.github.com/users/kq-li/repos","events_url":"https://api.github.com/users/kq-li/events{/privacy}","received_events_url":"https://api.github.com/users/kq-li/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-27T05:59:11Z","updated_at":"2019-03-27T17:40:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4549030ca6debd007ded37dd3793658e7da26def","assignee":null,"assignees":[],"requested_reviewers":[{"login":"keivanshahida","id":7966410,"node_id":"MDQ6VXNlcjc5NjY0MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7966410?v=4","gravatar_id":"","url":"https://api.github.com/users/keivanshahida","html_url":"https://github.com/keivanshahida","followers_url":"https://api.github.com/users/keivanshahida/followers","following_url":"https://api.github.com/users/keivanshahida/following{/other_user}","gists_url":"https://api.github.com/users/keivanshahida/gists{/gist_id}","starred_url":"https://api.github.com/users/keivanshahida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keivanshahida/subscriptions","organizations_url":"https://api.github.com/users/keivanshahida/orgs","repos_url":"https://api.github.com/users/keivanshahida/repos","events_url":"https://api.github.com/users/keivanshahida/events{/privacy}","received_events_url":"https://api.github.com/users/keivanshahida/received_events","type":"User","site_admin":false},{"login":"young-k","id":8889311,"node_id":"MDQ6VXNlcjg4ODkzMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/8889311?v=4","gravatar_id":"","url":"https://api.github.com/users/young-k","html_url":"https://github.com/young-k","followers_url":"https://api.github.com/users/young-k/followers","following_url":"https://api.github.com/users/young-k/following{/other_user}","gists_url":"https://api.github.com/users/young-k/gists{/gist_id}","starred_url":"https://api.github.com/users/young-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/young-k/subscriptions","organizations_url":"https://api.github.com/users/young-k/orgs","repos_url":"https://api.github.com/users/young-k/repos","events_url":"https://api.github.com/users/young-k/events{/privacy}","received_events_url":"https://api.github.com/users/young-k/received_events","type":"User","site_admin":false},{"login":"aliciaxw","id":27324207,"node_id":"MDQ6VXNlcjI3MzI0MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/27324207?v=4","gravatar_id":"","url":"https://api.github.com/users/aliciaxw","html_url":"https://github.com/aliciaxw","followers_url":"https://api.github.com/users/aliciaxw/followers","following_url":"https://api.github.com/users/aliciaxw/following{/other_user}","gists_url":"https://api.github.com/users/aliciaxw/gists{/gist_id}","starred_url":"https://api.github.com/users/aliciaxw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliciaxw/subscriptions","organizations_url":"https://api.github.com/users/aliciaxw/orgs","repos_url":"https://api.github.com/users/aliciaxw/repos","events_url":"https://api.github.com/users/aliciaxw/events{/privacy}","received_events_url":"https://api.github.com/users/aliciaxw/received_events","type":"User","site_admin":false},{"login":"yuna878","id":36527727,"node_id":"MDQ6VXNlcjM2NTI3NzI3","avatar_url":"https://avatars1.githubusercontent.com/u/36527727?v=4","gravatar_id":"","url":"https://api.github.com/users/yuna878","html_url":"https://github.com/yuna878","followers_url":"https://api.github.com/users/yuna878/followers","following_url":"https://api.github.com/users/yuna878/following{/other_user}","gists_url":"https://api.github.com/users/yuna878/gists{/gist_id}","starred_url":"https://api.github.com/users/yuna878/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuna878/subscriptions","organizations_url":"https://api.github.com/users/yuna878/orgs","repos_url":"https://api.github.com/users/yuna878/repos","events_url":"https://api.github.com/users/yuna878/events{/privacy}","received_events_url":"https://api.github.com/users/yuna878/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cuappdev/acai-backend/pulls/45/commits","review_comments_url":"https://api.github.com/repos/cuappdev/acai-backend/pulls/45/comments","review_comment_url":"https://api.github.com/repos/cuappdev/acai-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cuappdev/acai-backend/issues/45/comments","statuses_url":"https://api.github.com/repos/cuappdev/acai-backend/statuses/7d2064da294698555a6cf35c42b26907d39f67fe","head":{"label":"cuappdev:kenneth/sessions","ref":"kenneth/sessions","sha":"7d2064da294698555a6cf35c42b26907d39f67fe","user":{"login":"cuappdev","id":17533691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTMzNjkx","avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"repo":{"id":170780485,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA3ODA0ODU=","name":"acai-backend","full_name":"cuappdev/acai-backend","private":false,"owner":{"login":"cuappdev","id":17533691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTMzNjkx","avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cuappdev/acai-backend","description":"An open-sourced backend service for Acai iOS.","fork":false,"url":"https://api.github.com/repos/cuappdev/acai-backend","forks_url":"https://api.github.com/repos/cuappdev/acai-backend/forks","keys_url":"https://api.github.com/repos/cuappdev/acai-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuappdev/acai-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuappdev/acai-backend/teams","hooks_url":"https://api.github.com/repos/cuappdev/acai-backend/hooks","issue_events_url":"https://api.github.com/repos/cuappdev/acai-backend/issues/events{/number}","events_url":"https://api.github.com/repos/cuappdev/acai-backend/events","assignees_url":"https://api.github.com/repos/cuappdev/acai-backend/assignees{/user}","branches_url":"https://api.github.com/repos/cuappdev/acai-backend/branches{/branch}","tags_url":"https://api.github.com/repos/cuappdev/acai-backend/tags","blobs_url":"https://api.github.com/repos/cuappdev/acai-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuappdev/acai-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuappdev/acai-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuappdev/acai-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuappdev/acai-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/cuappdev/acai-backend/languages","stargazers_url":"https://api.github.com/repos/cuappdev/acai-backend/stargazers","contributors_url":"https://api.github.com/repos/cuappdev/acai-backend/contributors","subscribers_url":"https://api.github.com/repos/cuappdev/acai-backend/subscribers","subscription_url":"https://api.github.com/repos/cuappdev/acai-backend/subscription","commits_url":"https://api.github.com/repos/cuappdev/acai-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuappdev/acai-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuappdev/acai-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuappdev/acai-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuappdev/acai-backend/contents/{+path}","compare_url":"https://api.github.com/repos/cuappdev/acai-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuappdev/acai-backend/merges","archive_url":"https://api.github.com/repos/cuappdev/acai-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuappdev/acai-backend/downloads","issues_url":"https://api.github.com/repos/cuappdev/acai-backend/issues{/number}","pulls_url":"https://api.github.com/repos/cuappdev/acai-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/cuappdev/acai-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/cuappdev/acai-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuappdev/acai-backend/labels{/name}","releases_url":"https://api.github.com/repos/cuappdev/acai-backend/releases{/id}","deployments_url":"https://api.github.com/repos/cuappdev/acai-backend/deployments","created_at":"2019-02-15T01:01:44Z","updated_at":"2019-03-20T21:51:49Z","pushed_at":"2019-03-27T16:52:51Z","git_url":"git://github.com/cuappdev/acai-backend.git","ssh_url":"git@github.com:cuappdev/acai-backend.git","clone_url":"https://github.com/cuappdev/acai-backend.git","svn_url":"https://github.com/cuappdev/acai-backend","homepage":"","size":206,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"base":{"label":"cuappdev:master","ref":"master","sha":"3c5ba78d4bc24da72512c4477cbe652f6b353e6c","user":{"login":"cuappdev","id":17533691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTMzNjkx","avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"repo":{"id":170780485,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA3ODA0ODU=","name":"acai-backend","full_name":"cuappdev/acai-backend","private":false,"owner":{"login":"cuappdev","id":17533691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTMzNjkx","avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cuappdev/acai-backend","description":"An open-sourced backend service for Acai iOS.","fork":false,"url":"https://api.github.com/repos/cuappdev/acai-backend","forks_url":"https://api.github.com/repos/cuappdev/acai-backend/forks","keys_url":"https://api.github.com/repos/cuappdev/acai-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuappdev/acai-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuappdev/acai-backend/teams","hooks_url":"https://api.github.com/repos/cuappdev/acai-backend/hooks","issue_events_url":"https://api.github.com/repos/cuappdev/acai-backend/issues/events{/number}","events_url":"https://api.github.com/repos/cuappdev/acai-backend/events","assignees_url":"https://api.github.com/repos/cuappdev/acai-backend/assignees{/user}","branches_url":"https://api.github.com/repos/cuappdev/acai-backend/branches{/branch}","tags_url":"https://api.github.com/repos/cuappdev/acai-backend/tags","blobs_url":"https://api.github.com/repos/cuappdev/acai-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuappdev/acai-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuappdev/acai-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuappdev/acai-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuappdev/acai-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/cuappdev/acai-backend/languages","stargazers_url":"https://api.github.com/repos/cuappdev/acai-backend/stargazers","contributors_url":"https://api.github.com/repos/cuappdev/acai-backend/contributors","subscribers_url":"https://api.github.com/repos/cuappdev/acai-backend/subscribers","subscription_url":"https://api.github.com/repos/cuappdev/acai-backend/subscription","commits_url":"https://api.github.com/repos/cuappdev/acai-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuappdev/acai-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuappdev/acai-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuappdev/acai-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuappdev/acai-backend/contents/{+path}","compare_url":"https://api.github.com/repos/cuappdev/acai-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuappdev/acai-backend/merges","archive_url":"https://api.github.com/repos/cuappdev/acai-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuappdev/acai-backend/downloads","issues_url":"https://api.github.com/repos/cuappdev/acai-backend/issues{/number}","pulls_url":"https://api.github.com/repos/cuappdev/acai-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/cuappdev/acai-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/cuappdev/acai-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuappdev/acai-backend/labels{/name}","releases_url":"https://api.github.com/repos/cuappdev/acai-backend/releases{/id}","deployments_url":"https://api.github.com/repos/cuappdev/acai-backend/deployments","created_at":"2019-02-15T01:01:44Z","updated_at":"2019-03-20T21:51:49Z","pushed_at":"2019-03-27T16:52:51Z","git_url":"git://github.com/cuappdev/acai-backend.git","ssh_url":"git@github.com:cuappdev/acai-backend.git","clone_url":"https://github.com/cuappdev/acai-backend.git","svn_url":"https://github.com/cuappdev/acai-backend","homepage":"","size":206,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cuappdev/acai-backend/pulls/45"},"html":{"href":"https://github.com/cuappdev/acai-backend/pull/45"},"issue":{"href":"https://api.github.com/repos/cuappdev/acai-backend/issues/45"},"comments":{"href":"https://api.github.com/repos/cuappdev/acai-backend/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/cuappdev/acai-backend/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/cuappdev/acai-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cuappdev/acai-backend/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/cuappdev/acai-backend/statuses/7d2064da294698555a6cf35c42b26907d39f67fe"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 170780485,
"name": "cuappdev/acai-backend",
"url": "https://api.github.com/repos/cuappdev/acai-backend"
}
|
{
"id": 6081311,
"login": "kq-li",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6081311?",
"url": "https://api.github.com/users/kq-li"
}
|
{
"id": 17533691,
"login": "cuappdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17533691?",
"url": "https://api.github.com/orgs/cuappdev"
}
| 2019-03-27T17:40:05 |
9326737295
|
{"actor":{"display_login":"kq-li"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/scala-native/scala-native/pulls/comments/271153169","pull_request_review_id":221473203,"id":271153169,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTE1MzE2OQ==","diff_hunk":"@@ -9,18 +9,47 @@ import scala.scalanative.posix.{fcntl, unistd}\n import scala.io.Source\n \n object ProcessSuite extends tests.Suite {\n+\n+ private def blockTestOnConditions(process: Process): Unit = {","path":"unit-tests/src/test/scala/java/lang/ProcessSuite.scala","position":null,"original_position":5,"commit_id":"07786602361e08e5cfdc137ca945b0942136333c","original_commit_id":"0dca5f92aefbc4ed33437b3dc18f941a4f6f139a","user":{"login":"LeeTibbert","id":12221035,"node_id":"MDQ6VXNlcjEyMjIxMDM1","avatar_url":"https://avatars1.githubusercontent.com/u/12221035?v=4","gravatar_id":"","url":"https://api.github.com/users/LeeTibbert","html_url":"https://github.com/LeeTibbert","followers_url":"https://api.github.com/users/LeeTibbert/followers","following_url":"https://api.github.com/users/LeeTibbert/following{/other_user}","gists_url":"https://api.github.com/users/LeeTibbert/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeTibbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeTibbert/subscriptions","organizations_url":"https://api.github.com/users/LeeTibbert/orgs","repos_url":"https://api.github.com/users/LeeTibbert/repos","events_url":"https://api.github.com/users/LeeTibbert/events{/privacy}","received_events_url":"https://api.github.com/users/LeeTibbert/received_events","type":"User","site_admin":false},"body":"Done. If the new name is not suitable, I can change it again.","created_at":"2019-04-02T06:48:01Z","updated_at":"2019-04-02T06:48:01Z","html_url":"https://github.com/scala-native/scala-native/pull/1515#discussion_r271153169","pull_request_url":"https://api.github.com/repos/scala-native/scala-native/pulls/1515","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scala-native/scala-native/pulls/comments/271153169"},"html":{"href":"https://github.com/scala-native/scala-native/pull/1515#discussion_r271153169"},"pull_request":{"href":"https://api.github.com/repos/scala-native/scala-native/pulls/1515"}},"in_reply_to_id":270807715},"pull_request":{"url":"https://api.github.com/repos/scala-native/scala-native/pulls/1515","id":265063641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1MDYzNjQx","html_url":"https://github.com/scala-native/scala-native/pull/1515","diff_url":"https://github.com/scala-native/scala-native/pull/1515.diff","patch_url":"https://github.com/scala-native/scala-native/pull/1515.patch","issue_url":"https://api.github.com/repos/scala-native/scala-native/issues/1515","number":1515,"state":"open","locked":false,"title":"Fix #1511 \"ProcessSuite should always use waitFor with a timeout\"","user":{"login":"LeeTibbert","id":12221035,"node_id":"MDQ6VXNlcjEyMjIxMDM1","avatar_url":"https://avatars1.githubusercontent.com/u/12221035?v=4","gravatar_id":"","url":"https://api.github.com/users/LeeTibbert","html_url":"https://github.com/LeeTibbert","followers_url":"https://api.github.com/users/LeeTibbert/followers","following_url":"https://api.github.com/users/LeeTibbert/following{/other_user}","gists_url":"https://api.github.com/users/LeeTibbert/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeTibbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeTibbert/subscriptions","organizations_url":"https://api.github.com/users/LeeTibbert/orgs","repos_url":"https://api.github.com/users/LeeTibbert/repos","events_url":"https://api.github.com/users/LeeTibbert/events{/privacy}","received_events_url":"https://api.github.com/users/LeeTibbert/received_events","type":"User","site_admin":false},"body":" * The motivating issue was reported as Issue #1511\r\n \"ProcessSuite should always use waitFor with a timeout\"\r\n\r\n That issue is now fixed. Since the defects were in a unit-test\r\n Suite, there is no new test provided to test the test Suite.\r\n\r\n * My thanks to @eatkins for pointing out the defect and motivating\r\n this PR.\r\n\r\nDocumentation:\r\n\r\n * None needed. Unit-tests are internal to SN. There is a design\r\n note at the top of ProcessSuite.scala which describes the\r\n reasoning for future SN developers.\r\n\r\nTesting:\r\n\r\n * Built and tested (\"test-all\") with sbt 1.2.6 in release mode on\r\n X86_64 only . All tests pass (footnote 1). Travis CI should cover\r\n the sbt 0.13.7 in debug mode cell of the 2x2 matrix.\r\n\r\n * The tests above show that the new timout test does not introduce\r\n problems when the underling process exits as expected.\r\n\r\n The existing test \"waitFor with timeout times out\" detects\r\n that the timeout should execute and terminate the test when\r\n the underlying process hangs, Q.E.D. I believe the logical space is\r\n covered so there is no need to create an additional \"hanging process\"\r\n test.\r\n\r\n footnote 1: Of course, there is the standard disclaimer.\r\n By \"All tests\" I mean \"all tests other than the known\r\n broken link-order\". There is a PR in the queue for\r\n\t\tthat failure, caused by an change in sbt between 0.13.7\r\n\t\tand 1.2.6.","created_at":"2019-03-27T19:08:11Z","updated_at":"2019-04-02T06:48:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4ff13073041504861c5d1d64462692db96caf93","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scala-native/scala-native/pulls/1515/commits","review_comments_url":"https://api.github.com/repos/scala-native/scala-native/pulls/1515/comments","review_comment_url":"https://api.github.com/repos/scala-native/scala-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala-native/scala-native/issues/1515/comments","statuses_url":"https://api.github.com/repos/scala-native/scala-native/statuses/07786602361e08e5cfdc137ca945b0942136333c","head":{"label":"LeeTibbert:PR_ProcessWaitFor_I1511","ref":"PR_ProcessWaitFor_I1511","sha":"07786602361e08e5cfdc137ca945b0942136333c","user":{"login":"LeeTibbert","id":12221035,"node_id":"MDQ6VXNlcjEyMjIxMDM1","avatar_url":"https://avatars1.githubusercontent.com/u/12221035?v=4","gravatar_id":"","url":"https://api.github.com/users/LeeTibbert","html_url":"https://github.com/LeeTibbert","followers_url":"https://api.github.com/users/LeeTibbert/followers","following_url":"https://api.github.com/users/LeeTibbert/following{/other_user}","gists_url":"https://api.github.com/users/LeeTibbert/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeTibbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeTibbert/subscriptions","organizations_url":"https://api.github.com/users/LeeTibbert/orgs","repos_url":"https://api.github.com/users/LeeTibbert/repos","events_url":"https://api.github.com/users/LeeTibbert/events{/privacy}","received_events_url":"https://api.github.com/users/LeeTibbert/received_events","type":"User","site_admin":false},"repo":{"id":121595362,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1OTUzNjI=","name":"scala-native-fork","full_name":"LeeTibbert/scala-native-fork","private":false,"owner":{"login":"LeeTibbert","id":12221035,"node_id":"MDQ6VXNlcjEyMjIxMDM1","avatar_url":"https://avatars1.githubusercontent.com/u/12221035?v=4","gravatar_id":"","url":"https://api.github.com/users/LeeTibbert","html_url":"https://github.com/LeeTibbert","followers_url":"https://api.github.com/users/LeeTibbert/followers","following_url":"https://api.github.com/users/LeeTibbert/following{/other_user}","gists_url":"https://api.github.com/users/LeeTibbert/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeTibbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeTibbert/subscriptions","organizations_url":"https://api.github.com/users/LeeTibbert/orgs","repos_url":"https://api.github.com/users/LeeTibbert/repos","events_url":"https://api.github.com/users/LeeTibbert/events{/privacy}","received_events_url":"https://api.github.com/users/LeeTibbert/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LeeTibbert/scala-native-fork","description":"Contributor development clone of ","fork":true,"url":"https://api.github.com/repos/LeeTibbert/scala-native-fork","forks_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/forks","keys_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/teams","hooks_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/hooks","issue_events_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/issues/events{/number}","events_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/events","assignees_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/assignees{/user}","branches_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/branches{/branch}","tags_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/tags","blobs_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/statuses/{sha}","languages_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/languages","stargazers_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/stargazers","contributors_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/contributors","subscribers_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/subscribers","subscription_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/subscription","commits_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/contents/{+path}","compare_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/merges","archive_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/downloads","issues_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/issues{/number}","pulls_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/pulls{/number}","milestones_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/milestones{/number}","notifications_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/labels{/name}","releases_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/releases{/id}","deployments_url":"https://api.github.com/repos/LeeTibbert/scala-native-fork/deployments","created_at":"2018-02-15T05:43:46Z","updated_at":"2019-03-27T16:50:16Z","pushed_at":"2019-04-02T06:12:46Z","git_url":"git://github.com/LeeTibbert/scala-native-fork.git","ssh_url":"git@github.com:LeeTibbert/scala-native-fork.git","clone_url":"https://github.com/LeeTibbert/scala-native-fork.git","svn_url":"https://github.com/LeeTibbert/scala-native-fork","homepage":"http://scala-native.org","size":8204,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala-native:master","ref":"master","sha":"782217b2e123f95b30cb7f958957fd1e3f449882","user":{"login":"scala-native","id":17545605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTQ1NjA1","avatar_url":"https://avatars2.githubusercontent.com/u/17545605?v=4","gravatar_id":"","url":"https://api.github.com/users/scala-native","html_url":"https://github.com/scala-native","followers_url":"https://api.github.com/users/scala-native/followers","following_url":"https://api.github.com/users/scala-native/following{/other_user}","gists_url":"https://api.github.com/users/scala-native/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-native/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-native/subscriptions","organizations_url":"https://api.github.com/users/scala-native/orgs","repos_url":"https://api.github.com/users/scala-native/repos","events_url":"https://api.github.com/users/scala-native/events{/privacy}","received_events_url":"https://api.github.com/users/scala-native/received_events","type":"Organization","site_admin":false},"repo":{"id":27235687,"node_id":"MDEwOlJlcG9zaXRvcnkyNzIzNTY4Nw==","name":"scala-native","full_name":"scala-native/scala-native","private":false,"owner":{"login":"scala-native","id":17545605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTQ1NjA1","avatar_url":"https://avatars2.githubusercontent.com/u/17545605?v=4","gravatar_id":"","url":"https://api.github.com/users/scala-native","html_url":"https://github.com/scala-native","followers_url":"https://api.github.com/users/scala-native/followers","following_url":"https://api.github.com/users/scala-native/following{/other_user}","gists_url":"https://api.github.com/users/scala-native/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-native/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-native/subscriptions","organizations_url":"https://api.github.com/users/scala-native/orgs","repos_url":"https://api.github.com/users/scala-native/repos","events_url":"https://api.github.com/users/scala-native/events{/privacy}","received_events_url":"https://api.github.com/users/scala-native/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scala-native/scala-native","description":"Your favorite language gets closer to bare metal.","fork":false,"url":"https://api.github.com/repos/scala-native/scala-native","forks_url":"https://api.github.com/repos/scala-native/scala-native/forks","keys_url":"https://api.github.com/repos/scala-native/scala-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala-native/scala-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala-native/scala-native/teams","hooks_url":"https://api.github.com/repos/scala-native/scala-native/hooks","issue_events_url":"https://api.github.com/repos/scala-native/scala-native/issues/events{/number}","events_url":"https://api.github.com/repos/scala-native/scala-native/events","assignees_url":"https://api.github.com/repos/scala-native/scala-native/assignees{/user}","branches_url":"https://api.github.com/repos/scala-native/scala-native/branches{/branch}","tags_url":"https://api.github.com/repos/scala-native/scala-native/tags","blobs_url":"https://api.github.com/repos/scala-native/scala-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala-native/scala-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala-native/scala-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala-native/scala-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala-native/scala-native/statuses/{sha}","languages_url":"https://api.github.com/repos/scala-native/scala-native/languages","stargazers_url":"https://api.github.com/repos/scala-native/scala-native/stargazers","contributors_url":"https://api.github.com/repos/scala-native/scala-native/contributors","subscribers_url":"https://api.github.com/repos/scala-native/scala-native/subscribers","subscription_url":"https://api.github.com/repos/scala-native/scala-native/subscription","commits_url":"https://api.github.com/repos/scala-native/scala-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala-native/scala-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala-native/scala-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala-native/scala-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala-native/scala-native/contents/{+path}","compare_url":"https://api.github.com/repos/scala-native/scala-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala-native/scala-native/merges","archive_url":"https://api.github.com/repos/scala-native/scala-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala-native/scala-native/downloads","issues_url":"https://api.github.com/repos/scala-native/scala-native/issues{/number}","pulls_url":"https://api.github.com/repos/scala-native/scala-native/pulls{/number}","milestones_url":"https://api.github.com/repos/scala-native/scala-native/milestones{/number}","notifications_url":"https://api.github.com/repos/scala-native/scala-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala-native/scala-native/labels{/name}","releases_url":"https://api.github.com/repos/scala-native/scala-native/releases{/id}","deployments_url":"https://api.github.com/repos/scala-native/scala-native/deployments","created_at":"2014-11-27T17:38:28Z","updated_at":"2019-04-01T17:34:08Z","pushed_at":"2019-04-02T06:12:48Z","git_url":"git://github.com/scala-native/scala-native.git","ssh_url":"git@github.com:scala-native/scala-native.git","clone_url":"https://github.com/scala-native/scala-native.git","svn_url":"https://github.com/scala-native/scala-native","homepage":"http://scala-native.org","size":7045,"stargazers_count":3534,"watchers_count":3534,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":246,"mirror_url":null,"archived":false,"open_issues_count":204,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":246,"open_issues":204,"watchers":3534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala-native/scala-native/pulls/1515"},"html":{"href":"https://github.com/scala-native/scala-native/pull/1515"},"issue":{"href":"https://api.github.com/repos/scala-native/scala-native/issues/1515"},"comments":{"href":"https://api.github.com/repos/scala-native/scala-native/issues/1515/comments"},"review_comments":{"href":"https://api.github.com/repos/scala-native/scala-native/pulls/1515/comments"},"review_comment":{"href":"https://api.github.com/repos/scala-native/scala-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala-native/scala-native/pulls/1515/commits"},"statuses":{"href":"https://api.github.com/repos/scala-native/scala-native/statuses/07786602361e08e5cfdc137ca945b0942136333c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27235687,
"name": "scala-native/scala-native",
"url": "https://api.github.com/repos/scala-native/scala-native"
}
|
{
"id": 12221035,
"login": "LeeTibbert",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12221035?",
"url": "https://api.github.com/users/LeeTibbert"
}
|
{
"id": 17545605,
"login": "scala-native",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17545605?",
"url": "https://api.github.com/orgs/scala-native"
}
| 2019-04-02T06:48:01 |
9359419596
|
{"actor":{"display_login":"LeeTibbert"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/intel/sriov-cni/pulls/comments/258651944","pull_request_review_id":205969564,"id":258651944,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODY1MTk0NA==","diff_hunk":"@@ -15,6 +15,8 @@ var (\n \tNetDirectory = \"/sys/class/net\"\n \t// SysBusPci is sysfs pci device directory\n \tSysBusPci = \"/sys/bus/pci/devices\"\n+\t// UserspaceDrivers is a list of driver names that don't have netlink representation for their devices\n+\tUserspaceDrivers = []string{\"vfio-pci\", \"uio_pci_generic\"}","path":"pkg/utils/utils.go","position":5,"original_position":5,"commit_id":"0538918b3513e8a82fd9dc4ca6c51bde7b93cb4a","original_commit_id":"0538918b3513e8a82fd9dc4ca6c51bde7b93cb4a","user":{"login":"booxter","id":90200,"node_id":"MDQ6VXNlcjkwMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/90200?v=4","gravatar_id":"","url":"https://api.github.com/users/booxter","html_url":"https://github.com/booxter","followers_url":"https://api.github.com/users/booxter/followers","following_url":"https://api.github.com/users/booxter/following{/other_user}","gists_url":"https://api.github.com/users/booxter/gists{/gist_id}","starred_url":"https://api.github.com/users/booxter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booxter/subscriptions","organizations_url":"https://api.github.com/users/booxter/orgs","repos_url":"https://api.github.com/users/booxter/repos","events_url":"https://api.github.com/users/booxter/events{/privacy}","received_events_url":"https://api.github.com/users/booxter/received_events","type":"User","site_admin":false},"body":"I *think* that's the right name for UIO driver but I am not sure. Perhaps someone with uio experience can clarify.","created_at":"2019-02-20T19:57:14Z","updated_at":"2019-02-20T19:57:15Z","html_url":"https://github.com/intel/sriov-cni/pull/64#discussion_r258651944","pull_request_url":"https://api.github.com/repos/intel/sriov-cni/pulls/64","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/intel/sriov-cni/pulls/comments/258651944"},"html":{"href":"https://github.com/intel/sriov-cni/pull/64#discussion_r258651944"},"pull_request":{"href":"https://api.github.com/repos/intel/sriov-cni/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/intel/sriov-cni/pulls/64","id":254076195,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0MDc2MTk1","html_url":"https://github.com/intel/sriov-cni/pull/64","diff_url":"https://github.com/intel/sriov-cni/pull/64.diff","patch_url":"https://github.com/intel/sriov-cni/pull/64.patch","issue_url":"https://api.github.com/repos/intel/sriov-cni/issues/64","number":64,"state":"open","locked":false,"title":"Don't crash when netlink interface is not present (for vfio devices)","user":{"login":"booxter","id":90200,"node_id":"MDQ6VXNlcjkwMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/90200?v=4","gravatar_id":"","url":"https://api.github.com/users/booxter","html_url":"https://github.com/booxter","followers_url":"https://api.github.com/users/booxter/followers","following_url":"https://api.github.com/users/booxter/following{/other_user}","gists_url":"https://api.github.com/users/booxter/gists{/gist_id}","starred_url":"https://api.github.com/users/booxter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booxter/subscriptions","organizations_url":"https://api.github.com/users/booxter/orgs","repos_url":"https://api.github.com/users/booxter/repos","events_url":"https://api.github.com/users/booxter/events{/privacy}","received_events_url":"https://api.github.com/users/booxter/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-19T00:04:20Z","updated_at":"2019-02-20T19:57:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fba474810891bd5b032a2126ff1aaa6d69c669dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel/sriov-cni/pulls/64/commits","review_comments_url":"https://api.github.com/repos/intel/sriov-cni/pulls/64/comments","review_comment_url":"https://api.github.com/repos/intel/sriov-cni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel/sriov-cni/issues/64/comments","statuses_url":"https://api.github.com/repos/intel/sriov-cni/statuses/0538918b3513e8a82fd9dc4ca6c51bde7b93cb4a","head":{"label":"booxter:vfio","ref":"vfio","sha":"0538918b3513e8a82fd9dc4ca6c51bde7b93cb4a","user":{"login":"booxter","id":90200,"node_id":"MDQ6VXNlcjkwMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/90200?v=4","gravatar_id":"","url":"https://api.github.com/users/booxter","html_url":"https://github.com/booxter","followers_url":"https://api.github.com/users/booxter/followers","following_url":"https://api.github.com/users/booxter/following{/other_user}","gists_url":"https://api.github.com/users/booxter/gists{/gist_id}","starred_url":"https://api.github.com/users/booxter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booxter/subscriptions","organizations_url":"https://api.github.com/users/booxter/orgs","repos_url":"https://api.github.com/users/booxter/repos","events_url":"https://api.github.com/users/booxter/events{/privacy}","received_events_url":"https://api.github.com/users/booxter/received_events","type":"User","site_admin":false},"repo":{"id":157764385,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3NjQzODU=","name":"sriov-cni","full_name":"booxter/sriov-cni","private":false,"owner":{"login":"booxter","id":90200,"node_id":"MDQ6VXNlcjkwMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/90200?v=4","gravatar_id":"","url":"https://api.github.com/users/booxter","html_url":"https://github.com/booxter","followers_url":"https://api.github.com/users/booxter/followers","following_url":"https://api.github.com/users/booxter/following{/other_user}","gists_url":"https://api.github.com/users/booxter/gists{/gist_id}","starred_url":"https://api.github.com/users/booxter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booxter/subscriptions","organizations_url":"https://api.github.com/users/booxter/orgs","repos_url":"https://api.github.com/users/booxter/repos","events_url":"https://api.github.com/users/booxter/events{/privacy}","received_events_url":"https://api.github.com/users/booxter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/booxter/sriov-cni","description":"DPDK & SR-IOV CNI plugin","fork":true,"url":"https://api.github.com/repos/booxter/sriov-cni","forks_url":"https://api.github.com/repos/booxter/sriov-cni/forks","keys_url":"https://api.github.com/repos/booxter/sriov-cni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/booxter/sriov-cni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/booxter/sriov-cni/teams","hooks_url":"https://api.github.com/repos/booxter/sriov-cni/hooks","issue_events_url":"https://api.github.com/repos/booxter/sriov-cni/issues/events{/number}","events_url":"https://api.github.com/repos/booxter/sriov-cni/events","assignees_url":"https://api.github.com/repos/booxter/sriov-cni/assignees{/user}","branches_url":"https://api.github.com/repos/booxter/sriov-cni/branches{/branch}","tags_url":"https://api.github.com/repos/booxter/sriov-cni/tags","blobs_url":"https://api.github.com/repos/booxter/sriov-cni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/booxter/sriov-cni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/booxter/sriov-cni/git/refs{/sha}","trees_url":"https://api.github.com/repos/booxter/sriov-cni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/booxter/sriov-cni/statuses/{sha}","languages_url":"https://api.github.com/repos/booxter/sriov-cni/languages","stargazers_url":"https://api.github.com/repos/booxter/sriov-cni/stargazers","contributors_url":"https://api.github.com/repos/booxter/sriov-cni/contributors","subscribers_url":"https://api.github.com/repos/booxter/sriov-cni/subscribers","subscription_url":"https://api.github.com/repos/booxter/sriov-cni/subscription","commits_url":"https://api.github.com/repos/booxter/sriov-cni/commits{/sha}","git_commits_url":"https://api.github.com/repos/booxter/sriov-cni/git/commits{/sha}","comments_url":"https://api.github.com/repos/booxter/sriov-cni/comments{/number}","issue_comment_url":"https://api.github.com/repos/booxter/sriov-cni/issues/comments{/number}","contents_url":"https://api.github.com/repos/booxter/sriov-cni/contents/{+path}","compare_url":"https://api.github.com/repos/booxter/sriov-cni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/booxter/sriov-cni/merges","archive_url":"https://api.github.com/repos/booxter/sriov-cni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/booxter/sriov-cni/downloads","issues_url":"https://api.github.com/repos/booxter/sriov-cni/issues{/number}","pulls_url":"https://api.github.com/repos/booxter/sriov-cni/pulls{/number}","milestones_url":"https://api.github.com/repos/booxter/sriov-cni/milestones{/number}","notifications_url":"https://api.github.com/repos/booxter/sriov-cni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/booxter/sriov-cni/labels{/name}","releases_url":"https://api.github.com/repos/booxter/sriov-cni/releases{/id}","deployments_url":"https://api.github.com/repos/booxter/sriov-cni/deployments","created_at":"2018-11-15T19:50:20Z","updated_at":"2018-11-15T19:51:13Z","pushed_at":"2019-02-19T21:55:16Z","git_url":"git://github.com/booxter/sriov-cni.git","ssh_url":"git@github.com:booxter/sriov-cni.git","clone_url":"https://github.com/booxter/sriov-cni.git","svn_url":"https://github.com/booxter/sriov-cni","homepage":"","size":28462,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intel:master","ref":"master","sha":"a87cb21e2f4aadedec7021eefa45523af51071ac","user":{"login":"intel","id":17888862,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg4ODYy","avatar_url":"https://avatars3.githubusercontent.com/u/17888862?v=4","gravatar_id":"","url":"https://api.github.com/users/intel","html_url":"https://github.com/intel","followers_url":"https://api.github.com/users/intel/followers","following_url":"https://api.github.com/users/intel/following{/other_user}","gists_url":"https://api.github.com/users/intel/gists{/gist_id}","starred_url":"https://api.github.com/users/intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel/subscriptions","organizations_url":"https://api.github.com/users/intel/orgs","repos_url":"https://api.github.com/users/intel/repos","events_url":"https://api.github.com/users/intel/events{/privacy}","received_events_url":"https://api.github.com/users/intel/received_events","type":"Organization","site_admin":false},"repo":{"id":76365128,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM2NTEyOA==","name":"sriov-cni","full_name":"intel/sriov-cni","private":false,"owner":{"login":"intel","id":17888862,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg4ODYy","avatar_url":"https://avatars3.githubusercontent.com/u/17888862?v=4","gravatar_id":"","url":"https://api.github.com/users/intel","html_url":"https://github.com/intel","followers_url":"https://api.github.com/users/intel/followers","following_url":"https://api.github.com/users/intel/following{/other_user}","gists_url":"https://api.github.com/users/intel/gists{/gist_id}","starred_url":"https://api.github.com/users/intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel/subscriptions","organizations_url":"https://api.github.com/users/intel/orgs","repos_url":"https://api.github.com/users/intel/repos","events_url":"https://api.github.com/users/intel/events{/privacy}","received_events_url":"https://api.github.com/users/intel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/intel/sriov-cni","description":"DPDK & SR-IOV CNI plugin","fork":true,"url":"https://api.github.com/repos/intel/sriov-cni","forks_url":"https://api.github.com/repos/intel/sriov-cni/forks","keys_url":"https://api.github.com/repos/intel/sriov-cni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel/sriov-cni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel/sriov-cni/teams","hooks_url":"https://api.github.com/repos/intel/sriov-cni/hooks","issue_events_url":"https://api.github.com/repos/intel/sriov-cni/issues/events{/number}","events_url":"https://api.github.com/repos/intel/sriov-cni/events","assignees_url":"https://api.github.com/repos/intel/sriov-cni/assignees{/user}","branches_url":"https://api.github.com/repos/intel/sriov-cni/branches{/branch}","tags_url":"https://api.github.com/repos/intel/sriov-cni/tags","blobs_url":"https://api.github.com/repos/intel/sriov-cni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel/sriov-cni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel/sriov-cni/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel/sriov-cni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel/sriov-cni/statuses/{sha}","languages_url":"https://api.github.com/repos/intel/sriov-cni/languages","stargazers_url":"https://api.github.com/repos/intel/sriov-cni/stargazers","contributors_url":"https://api.github.com/repos/intel/sriov-cni/contributors","subscribers_url":"https://api.github.com/repos/intel/sriov-cni/subscribers","subscription_url":"https://api.github.com/repos/intel/sriov-cni/subscription","commits_url":"https://api.github.com/repos/intel/sriov-cni/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel/sriov-cni/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel/sriov-cni/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel/sriov-cni/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel/sriov-cni/contents/{+path}","compare_url":"https://api.github.com/repos/intel/sriov-cni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel/sriov-cni/merges","archive_url":"https://api.github.com/repos/intel/sriov-cni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel/sriov-cni/downloads","issues_url":"https://api.github.com/repos/intel/sriov-cni/issues{/number}","pulls_url":"https://api.github.com/repos/intel/sriov-cni/pulls{/number}","milestones_url":"https://api.github.com/repos/intel/sriov-cni/milestones{/number}","notifications_url":"https://api.github.com/repos/intel/sriov-cni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel/sriov-cni/labels{/name}","releases_url":"https://api.github.com/repos/intel/sriov-cni/releases{/id}","deployments_url":"https://api.github.com/repos/intel/sriov-cni/deployments","created_at":"2016-12-13T14:17:38Z","updated_at":"2019-02-20T17:17:24Z","pushed_at":"2019-02-20T17:17:21Z","git_url":"git://github.com/intel/sriov-cni.git","ssh_url":"git@github.com:intel/sriov-cni.git","clone_url":"https://github.com/intel/sriov-cni.git","svn_url":"https://github.com/intel/sriov-cni","homepage":"","size":28462,"stargazers_count":65,"watchers_count":65,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":25,"open_issues":18,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel/sriov-cni/pulls/64"},"html":{"href":"https://github.com/intel/sriov-cni/pull/64"},"issue":{"href":"https://api.github.com/repos/intel/sriov-cni/issues/64"},"comments":{"href":"https://api.github.com/repos/intel/sriov-cni/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/intel/sriov-cni/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/intel/sriov-cni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel/sriov-cni/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/intel/sriov-cni/statuses/0538918b3513e8a82fd9dc4ca6c51bde7b93cb4a"}},"author_association":"NONE"}}
|
{
"id": 76365128,
"name": "intel/sriov-cni",
"url": "https://api.github.com/repos/intel/sriov-cni"
}
|
{
"id": 90200,
"login": "booxter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/90200?",
"url": "https://api.github.com/users/booxter"
}
|
{
"id": 17888862,
"login": "intel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17888862?",
"url": "https://api.github.com/orgs/intel"
}
| 2019-02-20T19:57:14 |
9105129263
|
{"actor":{"display_login":"booxter"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/comments/344737763","pull_request_review_id":314932167,"id":344737763,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDczNzc2Mw==","diff_hunk":"@@ -0,0 +1,65 @@\n+//\n+// SNCConfiguration.h\n+// SonectSDK\n+//\n+// Created by Bruno Sousa on 21/12/2018.\n+// Copyright © 2018 Sonect. All rights reserved.\n+//\n+\n+#import <Foundation/Foundation.h>\n+\n+NS_ASSUME_NONNULL_BEGIN\n+\n+@interface SNCConfiguration : NSObject\n+\n+/**\n+ A 2 digit ISO country code i.e. \"ch\" for Switzerland\n+ */\n+@property (nonatomic, nullable, copy, readonly) NSString* alpha2CountryCode;\n+\n+/**\n+ The user's preferred currency i.e. \"CHF\" for Swiss Francs\n+ */\n+@property (nonatomic, nullable, copy, readonly) NSString* currency;\n+\n+/**\n+ Set allowed country codes.\n+ Example: would be US and Switzerland\n+ @[@1, @41]\n+ */\n+@property (nonatomic, nullable, copy, readonly) NSArray <NSNumber *> *allowedCountryCodes;\n+\n+/**\n+ A default withdraw amount index in the Withdraw View Controller amount picker control.\n+ This control also remembers the user's last picked value.\n+ */\n+@property (nonatomic, readonly) NSUInteger defaultWithdrawAmountIndex;","path":"platforms/ios/HelloCordova.xcarchive/Products/Applications/HelloCordova.app/Frameworks/Sonect.framework/Headers/SNCConfiguration.h","position":36,"original_position":36,"commit_id":"ef0c9d8e1dd8669834cd0166fd7bc8d043e13693","original_commit_id":"ef0c9d8e1dd8669834cd0166fd7bc8d043e13693","user":{"login":"dryaz","id":1395176,"node_id":"MDQ6VXNlcjEzOTUxNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1395176?v=4","gravatar_id":"","url":"https://api.github.com/users/dryaz","html_url":"https://github.com/dryaz","followers_url":"https://api.github.com/users/dryaz/followers","following_url":"https://api.github.com/users/dryaz/following{/other_user}","gists_url":"https://api.github.com/users/dryaz/gists{/gist_id}","starred_url":"https://api.github.com/users/dryaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryaz/subscriptions","organizations_url":"https://api.github.com/users/dryaz/orgs","repos_url":"https://api.github.com/users/dryaz/repos","events_url":"https://api.github.com/users/dryaz/events{/privacy}","received_events_url":"https://api.github.com/users/dryaz/received_events","type":"User","site_admin":false},"body":"Looks like we support even 15 but we don't atm","created_at":"2019-11-11T14:32:28Z","updated_at":"2019-11-11T14:34:46Z","html_url":"https://github.com/sonect/sonect-cordova-testapp/pull/6#discussion_r344737763","pull_request_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/comments/344737763"},"html":{"href":"https://github.com/sonect/sonect-cordova-testapp/pull/6#discussion_r344737763"},"pull_request":{"href":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/6","id":339436878,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5NDM2ODc4","html_url":"https://github.com/sonect/sonect-cordova-testapp/pull/6","diff_url":"https://github.com/sonect/sonect-cordova-testapp/pull/6.diff","patch_url":"https://github.com/sonect/sonect-cordova-testapp/pull/6.patch","issue_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues/6","number":6,"state":"open","locked":false,"title":"Feature/ios 1160 update cordova sdk","user":{"login":"markohlebar","id":148891,"node_id":"MDQ6VXNlcjE0ODg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/148891?v=4","gravatar_id":"","url":"https://api.github.com/users/markohlebar","html_url":"https://github.com/markohlebar","followers_url":"https://api.github.com/users/markohlebar/followers","following_url":"https://api.github.com/users/markohlebar/following{/other_user}","gists_url":"https://api.github.com/users/markohlebar/gists{/gist_id}","starred_url":"https://api.github.com/users/markohlebar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markohlebar/subscriptions","organizations_url":"https://api.github.com/users/markohlebar/orgs","repos_url":"https://api.github.com/users/markohlebar/repos","events_url":"https://api.github.com/users/markohlebar/events{/privacy}","received_events_url":"https://api.github.com/users/markohlebar/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-11T13:30:51Z","updated_at":"2019-11-11T14:34:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62d8cc186aa2603026df255ca459bada1737ea0c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andre-sonect","id":45486808,"node_id":"MDQ6VXNlcjQ1NDg2ODA4","avatar_url":"https://avatars2.githubusercontent.com/u/45486808?v=4","gravatar_id":"","url":"https://api.github.com/users/andre-sonect","html_url":"https://github.com/andre-sonect","followers_url":"https://api.github.com/users/andre-sonect/followers","following_url":"https://api.github.com/users/andre-sonect/following{/other_user}","gists_url":"https://api.github.com/users/andre-sonect/gists{/gist_id}","starred_url":"https://api.github.com/users/andre-sonect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre-sonect/subscriptions","organizations_url":"https://api.github.com/users/andre-sonect/orgs","repos_url":"https://api.github.com/users/andre-sonect/repos","events_url":"https://api.github.com/users/andre-sonect/events{/privacy}","received_events_url":"https://api.github.com/users/andre-sonect/received_events","type":"User","site_admin":false},{"login":"ivan-yanakiev-sonect","id":48434396,"node_id":"MDQ6VXNlcjQ4NDM0Mzk2","avatar_url":"https://avatars2.githubusercontent.com/u/48434396?v=4","gravatar_id":"","url":"https://api.github.com/users/ivan-yanakiev-sonect","html_url":"https://github.com/ivan-yanakiev-sonect","followers_url":"https://api.github.com/users/ivan-yanakiev-sonect/followers","following_url":"https://api.github.com/users/ivan-yanakiev-sonect/following{/other_user}","gists_url":"https://api.github.com/users/ivan-yanakiev-sonect/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan-yanakiev-sonect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan-yanakiev-sonect/subscriptions","organizations_url":"https://api.github.com/users/ivan-yanakiev-sonect/orgs","repos_url":"https://api.github.com/users/ivan-yanakiev-sonect/repos","events_url":"https://api.github.com/users/ivan-yanakiev-sonect/events{/privacy}","received_events_url":"https://api.github.com/users/ivan-yanakiev-sonect/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/6/commits","review_comments_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/6/comments","review_comment_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues/6/comments","statuses_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/statuses/ef0c9d8e1dd8669834cd0166fd7bc8d043e13693","head":{"label":"sonect:feature/IOS-1160-update-cordova-sdk","ref":"feature/IOS-1160-update-cordova-sdk","sha":"ef0c9d8e1dd8669834cd0166fd7bc8d043e13693","user":{"login":"sonect","id":17914937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE0OTM3","avatar_url":"https://avatars2.githubusercontent.com/u/17914937?v=4","gravatar_id":"","url":"https://api.github.com/users/sonect","html_url":"https://github.com/sonect","followers_url":"https://api.github.com/users/sonect/followers","following_url":"https://api.github.com/users/sonect/following{/other_user}","gists_url":"https://api.github.com/users/sonect/gists{/gist_id}","starred_url":"https://api.github.com/users/sonect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonect/subscriptions","organizations_url":"https://api.github.com/users/sonect/orgs","repos_url":"https://api.github.com/users/sonect/repos","events_url":"https://api.github.com/users/sonect/events{/privacy}","received_events_url":"https://api.github.com/users/sonect/received_events","type":"Organization","site_admin":false},"repo":{"id":194262092,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQyNjIwOTI=","name":"sonect-cordova-testapp","full_name":"sonect/sonect-cordova-testapp","private":false,"owner":{"login":"sonect","id":17914937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE0OTM3","avatar_url":"https://avatars2.githubusercontent.com/u/17914937?v=4","gravatar_id":"","url":"https://api.github.com/users/sonect","html_url":"https://github.com/sonect","followers_url":"https://api.github.com/users/sonect/followers","following_url":"https://api.github.com/users/sonect/following{/other_user}","gists_url":"https://api.github.com/users/sonect/gists{/gist_id}","starred_url":"https://api.github.com/users/sonect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonect/subscriptions","organizations_url":"https://api.github.com/users/sonect/orgs","repos_url":"https://api.github.com/users/sonect/repos","events_url":"https://api.github.com/users/sonect/events{/privacy}","received_events_url":"https://api.github.com/users/sonect/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sonect/sonect-cordova-testapp","description":"This is the Sonect SDK Cordova integration test app","fork":false,"url":"https://api.github.com/repos/sonect/sonect-cordova-testapp","forks_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/forks","keys_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/teams","hooks_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/hooks","issue_events_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues/events{/number}","events_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/events","assignees_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/assignees{/user}","branches_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/branches{/branch}","tags_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/tags","blobs_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/statuses/{sha}","languages_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/languages","stargazers_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/stargazers","contributors_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/contributors","subscribers_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/subscribers","subscription_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/subscription","commits_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/contents/{+path}","compare_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/merges","archive_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/downloads","issues_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues{/number}","pulls_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls{/number}","milestones_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/milestones{/number}","notifications_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/labels{/name}","releases_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/releases{/id}","deployments_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/deployments","created_at":"2019-06-28T11:25:28Z","updated_at":"2019-08-09T12:39:49Z","pushed_at":"2019-11-11T13:30:51Z","git_url":"git://github.com/sonect/sonect-cordova-testapp.git","ssh_url":"git@github.com:sonect/sonect-cordova-testapp.git","clone_url":"https://github.com/sonect/sonect-cordova-testapp.git","svn_url":"https://github.com/sonect/sonect-cordova-testapp","homepage":"","size":29325,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sonect:master","ref":"master","sha":"ba5fdf31d0c1fc789bb8194587c18039a868ad7a","user":{"login":"sonect","id":17914937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE0OTM3","avatar_url":"https://avatars2.githubusercontent.com/u/17914937?v=4","gravatar_id":"","url":"https://api.github.com/users/sonect","html_url":"https://github.com/sonect","followers_url":"https://api.github.com/users/sonect/followers","following_url":"https://api.github.com/users/sonect/following{/other_user}","gists_url":"https://api.github.com/users/sonect/gists{/gist_id}","starred_url":"https://api.github.com/users/sonect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonect/subscriptions","organizations_url":"https://api.github.com/users/sonect/orgs","repos_url":"https://api.github.com/users/sonect/repos","events_url":"https://api.github.com/users/sonect/events{/privacy}","received_events_url":"https://api.github.com/users/sonect/received_events","type":"Organization","site_admin":false},"repo":{"id":194262092,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQyNjIwOTI=","name":"sonect-cordova-testapp","full_name":"sonect/sonect-cordova-testapp","private":false,"owner":{"login":"sonect","id":17914937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE0OTM3","avatar_url":"https://avatars2.githubusercontent.com/u/17914937?v=4","gravatar_id":"","url":"https://api.github.com/users/sonect","html_url":"https://github.com/sonect","followers_url":"https://api.github.com/users/sonect/followers","following_url":"https://api.github.com/users/sonect/following{/other_user}","gists_url":"https://api.github.com/users/sonect/gists{/gist_id}","starred_url":"https://api.github.com/users/sonect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonect/subscriptions","organizations_url":"https://api.github.com/users/sonect/orgs","repos_url":"https://api.github.com/users/sonect/repos","events_url":"https://api.github.com/users/sonect/events{/privacy}","received_events_url":"https://api.github.com/users/sonect/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sonect/sonect-cordova-testapp","description":"This is the Sonect SDK Cordova integration test app","fork":false,"url":"https://api.github.com/repos/sonect/sonect-cordova-testapp","forks_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/forks","keys_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/teams","hooks_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/hooks","issue_events_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues/events{/number}","events_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/events","assignees_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/assignees{/user}","branches_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/branches{/branch}","tags_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/tags","blobs_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/statuses/{sha}","languages_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/languages","stargazers_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/stargazers","contributors_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/contributors","subscribers_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/subscribers","subscription_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/subscription","commits_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/contents/{+path}","compare_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/merges","archive_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/downloads","issues_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues{/number}","pulls_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls{/number}","milestones_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/milestones{/number}","notifications_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/labels{/name}","releases_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/releases{/id}","deployments_url":"https://api.github.com/repos/sonect/sonect-cordova-testapp/deployments","created_at":"2019-06-28T11:25:28Z","updated_at":"2019-08-09T12:39:49Z","pushed_at":"2019-11-11T13:30:51Z","git_url":"git://github.com/sonect/sonect-cordova-testapp.git","ssh_url":"git@github.com:sonect/sonect-cordova-testapp.git","clone_url":"https://github.com/sonect/sonect-cordova-testapp.git","svn_url":"https://github.com/sonect/sonect-cordova-testapp","homepage":"","size":29325,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/6"},"html":{"href":"https://github.com/sonect/sonect-cordova-testapp/pull/6"},"issue":{"href":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues/6"},"comments":{"href":"https://api.github.com/repos/sonect/sonect-cordova-testapp/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonect/sonect-cordova-testapp/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/sonect/sonect-cordova-testapp/statuses/ef0c9d8e1dd8669834cd0166fd7bc8d043e13693"}},"author_association":"COLLABORATOR"}}
|
{
"id": 194262092,
"name": "sonect/sonect-cordova-testapp",
"url": "https://api.github.com/repos/sonect/sonect-cordova-testapp"
}
|
{
"id": 1395176,
"login": "dryaz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1395176?",
"url": "https://api.github.com/users/dryaz"
}
|
{
"id": 17914937,
"login": "sonect",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17914937?",
"url": "https://api.github.com/orgs/sonect"
}
| 2019-11-11T14:32:28 |
10834208227
|
{"actor":{"display_login":"dryaz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/260595867","pull_request_review_id":208338102,"id":260595867,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDU5NTg2Nw==","diff_hunk":"@@ -50,28 +50,28 @@ const AP_Param::GroupInfo AP_Relay::var_info[] = {\n // @DisplayName: First Relay Pin\n // @Description: Digital pin number for first relay control. This is the pin used for camera control.\n // @User: Standard\n- // @Values: -1:Disabled,49:BB Blue GP0 pin 4,50:Pixhawk AUXOUT1,51:Pixhawk AUXOUT2,52:Pixhawk AUXOUT3,53:Pixhawk AUXOUT4,54:Pixhawk AUXOUT5,55:Pixhawk AUXOUT6,57:BB Blue GP0 pin 3,111:PX4 FMU Relay1,112:PX4 FMU Relay2,113:PX4IO Relay1/BB Blue GP0 pin 6,114:PX4IO Relay2,115:PX4IO ACC1,116:PX4IO ACC2/BB Blue GP0 pin 5\n+ // @Values: -1:Disabled,49:BB Blue GP0 pin 4,50:AUXOUT1,51:AUXOUT2,52:AUXOUT3,53:AUXOUT4,54:AUXOUT5,55:AUXOUT6,57:BB Blue GP0 pin 3,113:BB Blue GP0 pin 6,115:PX4IO ACC1.116:BB Blue GP0 pin 5","path":"libraries/AP_Relay/AP_Relay.cpp","position":null,"original_position":5,"commit_id":"f90b265b794a27fad90c94962136abd7edfa8244","original_commit_id":"128197a5388039a11be31212d7f2158ac35b3675","user":{"login":"tridge","id":831867,"node_id":"MDQ6VXNlcjgzMTg2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/831867?v=4","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"body":"i've removed it, its unused","created_at":"2019-02-27T05:16:48Z","updated_at":"2019-02-27T05:16:48Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/10618#discussion_r260595867","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/10618","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/260595867"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/10618#discussion_r260595867"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/10618"}},"in_reply_to_id":260090981},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/10618","id":255759673,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NzU5Njcz","html_url":"https://github.com/ArduPilot/ardupilot/pull/10618","diff_url":"https://github.com/ArduPilot/ardupilot/pull/10618.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/10618.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/10618","number":10618,"state":"open","locked":false,"title":"remove more px4 remnants","user":{"login":"tridge","id":831867,"node_id":"MDQ6VXNlcjgzMTg2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/831867?v=4","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"body":"small bits throughout the tree\r\n","created_at":"2019-02-25T05:14:57Z","updated_at":"2019-02-27T05:16:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d269698a802b1041b2966a356cf91c11e837b0f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":36065544,"node_id":"MDU6TGFiZWwzNjA2NTU0NA==","url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/PX4","name":"PX4","color":"d3d3d3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/10618/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/10618/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/10618/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/f90b265b794a27fad90c94962136abd7edfa8244","head":{"label":"tridge:pr-remove-px4-remnants","ref":"pr-remove-px4-remnants","sha":"f90b265b794a27fad90c94962136abd7edfa8244","user":{"login":"tridge","id":831867,"node_id":"MDQ6VXNlcjgzMTg2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/831867?v=4","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"repo":{"id":7513848,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEzODQ4","name":"ardupilot","full_name":"tridge/ardupilot","private":false,"owner":{"login":"tridge","id":831867,"node_id":"MDQ6VXNlcjgzMTg2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/831867?v=4","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tridge/ardupilot","description":null,"fork":true,"url":"https://api.github.com/repos/tridge/ardupilot","forks_url":"https://api.github.com/repos/tridge/ardupilot/forks","keys_url":"https://api.github.com/repos/tridge/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tridge/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tridge/ardupilot/teams","hooks_url":"https://api.github.com/repos/tridge/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/tridge/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/tridge/ardupilot/events","assignees_url":"https://api.github.com/repos/tridge/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/tridge/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/tridge/ardupilot/tags","blobs_url":"https://api.github.com/repos/tridge/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tridge/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tridge/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/tridge/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tridge/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/tridge/ardupilot/languages","stargazers_url":"https://api.github.com/repos/tridge/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/tridge/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/tridge/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/tridge/ardupilot/subscription","commits_url":"https://api.github.com/repos/tridge/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/tridge/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/tridge/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/tridge/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/tridge/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/tridge/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tridge/ardupilot/merges","archive_url":"https://api.github.com/repos/tridge/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tridge/ardupilot/downloads","issues_url":"https://api.github.com/repos/tridge/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/tridge/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/tridge/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/tridge/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tridge/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/tridge/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/tridge/ardupilot/deployments","created_at":"2013-01-09T02:57:15Z","updated_at":"2019-01-10T09:08:55Z","pushed_at":"2019-02-27T05:16:42Z","git_url":"git://github.com/tridge/ardupilot.git","ssh_url":"git@github.com:tridge/ardupilot.git","clone_url":"https://github.com/tridge/ardupilot.git","svn_url":"https://github.com/tridge/ardupilot","homepage":null,"size":148097,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":11,"open_issues":1,"watchers":24,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"384bca94820a31d31966862e6cb16989ca87a9ba","user":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEyNDg0","name":"ardupilot","full_name":"ArduPilot/ardupilot","private":false,"owner":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2019-02-27T04:32:03Z","pushed_at":"2019-02-27T05:16:47Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":127041,"stargazers_count":3797,"watchers_count":3797,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7488,"mirror_url":null,"archived":false,"open_issues_count":1436,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":7488,"open_issues":1436,"watchers":3797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/10618"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/10618"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/10618"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/10618/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/10618/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/10618/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/f90b265b794a27fad90c94962136abd7edfa8244"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 7512484,
"name": "ArduPilot/ardupilot",
"url": "https://api.github.com/repos/ArduPilot/ardupilot"
}
|
{
"id": 831867,
"login": "tridge",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/831867?",
"url": "https://api.github.com/users/tridge"
}
|
{
"id": 17919847,
"login": "ArduPilot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17919847?",
"url": "https://api.github.com/orgs/ArduPilot"
}
| 2019-02-27T05:16:48 |
9143930639
|
{"actor":{"display_login":"tridge"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/comments/254846499","pull_request_review_id":201294928,"id":254846499,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDg0NjQ5OQ==","diff_hunk":"@@ -61,9 +62,9 @@ def get_result_message(self, user):\n return alert, message\n \n async def post(self):\n- username = self.get_body_argument('username', strip=False)\n- password = self.get_body_argument('password', strip=False)\n- user = self.authenticator.get_or_create_user(username, password)\n+ body = self.request.body.decode('utf-8')\n+ body_arguments = dict(parse.parse_qsl(body))","path":"nativeauthenticator/handlers.py","position":16,"original_position":16,"commit_id":"2bc9006e0785d1550baaffb08baef320925be09b","original_commit_id":"2bc9006e0785d1550baaffb08baef320925be09b","user":{"login":"leportella","id":7255297,"node_id":"MDQ6VXNlcjcyNTUyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7255297?v=4","gravatar_id":"","url":"https://api.github.com/users/leportella","html_url":"https://github.com/leportella","followers_url":"https://api.github.com/users/leportella/followers","following_url":"https://api.github.com/users/leportella/following{/other_user}","gists_url":"https://api.github.com/users/leportella/gists{/gist_id}","starred_url":"https://api.github.com/users/leportella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leportella/subscriptions","organizations_url":"https://api.github.com/users/leportella/orgs","repos_url":"https://api.github.com/users/leportella/repos","events_url":"https://api.github.com/users/leportella/events{/privacy}","received_events_url":"https://api.github.com/users/leportella/received_events","type":"User","site_admin":false},"body":"I'm not sure what you think is best. Could you explain please?","created_at":"2019-02-07T20:00:20Z","updated_at":"2019-02-07T20:00:20Z","html_url":"https://github.com/jupyterhub/nativeauthenticator/pull/48#discussion_r254846499","pull_request_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/48","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/comments/254846499"},"html":{"href":"https://github.com/jupyterhub/nativeauthenticator/pull/48#discussion_r254846499"},"pull_request":{"href":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/48"}},"in_reply_to_id":254812766},"pull_request":{"url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/48","id":250750347,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwNzUwMzQ3","html_url":"https://github.com/jupyterhub/nativeauthenticator/pull/48","diff_url":"https://github.com/jupyterhub/nativeauthenticator/pull/48.diff","patch_url":"https://github.com/jupyterhub/nativeauthenticator/pull/48.patch","issue_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues/48","number":48,"state":"open","locked":false,"title":"Add all info from signup post to get_or_create_user","user":{"login":"leportella","id":7255297,"node_id":"MDQ6VXNlcjcyNTUyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7255297?v=4","gravatar_id":"","url":"https://api.github.com/users/leportella","html_url":"https://github.com/leportella","followers_url":"https://api.github.com/users/leportella/followers","following_url":"https://api.github.com/users/leportella/following{/other_user}","gists_url":"https://api.github.com/users/leportella/gists{/gist_id}","starred_url":"https://api.github.com/users/leportella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leportella/subscriptions","organizations_url":"https://api.github.com/users/leportella/orgs","repos_url":"https://api.github.com/users/leportella/repos","events_url":"https://api.github.com/users/leportella/events{/privacy}","received_events_url":"https://api.github.com/users/leportella/received_events","type":"User","site_admin":false},"body":"When creating a new user with email, the handler was not passing this information to the function `get_or_create_user` and the email was not being stored. This fixes this problem","created_at":"2019-02-06T13:16:32Z","updated_at":"2019-02-07T20:00:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f82ba4638ae8ae51d8a61ce93e6adc8d70e54aa1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/48/commits","review_comments_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/48/comments","review_comment_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues/48/comments","statuses_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/statuses/2bc9006e0785d1550baaffb08baef320925be09b","head":{"label":"jupyterhub:add-email-info","ref":"add-email-info","sha":"2bc9006e0785d1550baaffb08baef320925be09b","user":{"login":"jupyterhub","id":17927519,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTI3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/17927519?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"repo":{"id":160229874,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyMjk4NzQ=","name":"nativeauthenticator","full_name":"jupyterhub/nativeauthenticator","private":false,"owner":{"login":"jupyterhub","id":17927519,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTI3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/17927519?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jupyterhub/nativeauthenticator","description":"JupyterHub-native user authenticator","fork":false,"url":"https://api.github.com/repos/jupyterhub/nativeauthenticator","forks_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/forks","keys_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/teams","hooks_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/hooks","issue_events_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues/events{/number}","events_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/events","assignees_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/assignees{/user}","branches_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/branches{/branch}","tags_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/tags","blobs_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/languages","stargazers_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/stargazers","contributors_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/contributors","subscribers_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/subscribers","subscription_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/subscription","commits_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/contents/{+path}","compare_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/merges","archive_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/downloads","issues_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues{/number}","pulls_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/labels{/name}","releases_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/releases{/id}","deployments_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/deployments","created_at":"2018-12-03T17:38:18Z","updated_at":"2019-02-06T14:00:06Z","pushed_at":"2019-02-07T18:29:40Z","git_url":"git://github.com/jupyterhub/nativeauthenticator.git","ssh_url":"git@github.com:jupyterhub/nativeauthenticator.git","clone_url":"https://github.com/jupyterhub/nativeauthenticator.git","svn_url":"https://github.com/jupyterhub/nativeauthenticator","homepage":null,"size":202,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"jupyterhub:master","ref":"master","sha":"7b0953c83b4b7d725561808cfa3ab5dbdd97b9a5","user":{"login":"jupyterhub","id":17927519,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTI3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/17927519?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"repo":{"id":160229874,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyMjk4NzQ=","name":"nativeauthenticator","full_name":"jupyterhub/nativeauthenticator","private":false,"owner":{"login":"jupyterhub","id":17927519,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTI3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/17927519?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jupyterhub/nativeauthenticator","description":"JupyterHub-native user authenticator","fork":false,"url":"https://api.github.com/repos/jupyterhub/nativeauthenticator","forks_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/forks","keys_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/teams","hooks_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/hooks","issue_events_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues/events{/number}","events_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/events","assignees_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/assignees{/user}","branches_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/branches{/branch}","tags_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/tags","blobs_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/languages","stargazers_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/stargazers","contributors_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/contributors","subscribers_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/subscribers","subscription_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/subscription","commits_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/contents/{+path}","compare_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/merges","archive_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/downloads","issues_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues{/number}","pulls_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/labels{/name}","releases_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/releases{/id}","deployments_url":"https://api.github.com/repos/jupyterhub/nativeauthenticator/deployments","created_at":"2018-12-03T17:38:18Z","updated_at":"2019-02-06T14:00:06Z","pushed_at":"2019-02-07T18:29:40Z","git_url":"git://github.com/jupyterhub/nativeauthenticator.git","ssh_url":"git@github.com:jupyterhub/nativeauthenticator.git","clone_url":"https://github.com/jupyterhub/nativeauthenticator.git","svn_url":"https://github.com/jupyterhub/nativeauthenticator","homepage":null,"size":202,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/48"},"html":{"href":"https://github.com/jupyterhub/nativeauthenticator/pull/48"},"issue":{"href":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues/48"},"comments":{"href":"https://api.github.com/repos/jupyterhub/nativeauthenticator/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyterhub/nativeauthenticator/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/jupyterhub/nativeauthenticator/statuses/2bc9006e0785d1550baaffb08baef320925be09b"}},"author_association":"COLLABORATOR"}}
|
{
"id": 160229874,
"name": "jupyterhub/nativeauthenticator",
"url": "https://api.github.com/repos/jupyterhub/nativeauthenticator"
}
|
{
"id": 7255297,
"login": "leportella",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7255297?",
"url": "https://api.github.com/users/leportella"
}
|
{
"id": 17927519,
"login": "jupyterhub",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17927519?",
"url": "https://api.github.com/orgs/jupyterhub"
}
| 2019-02-07T20:00:20 |
9028138897
|
{"actor":{"display_login":"leportella"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/comments/366467892","pull_request_review_id":342700789,"id":366467892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NjQ2Nzg5Mg==","diff_hunk":"@@ -0,0 +1,65 @@\n+global:\n+ ## Reference to one or more secrets to be used when pulling images\n+ ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/\n+ ##\n+ imagePullSecrets: []\n+ # - name: \"image-pull-secret\"\n+\n+ohmyglb:\n+ image: ytsarev/ohmyglb:v0.2.1\n+ ingressNamespace: \"ohmyglb\"\n+\n+externaldns:\n+ image: registry.opensource.zalan.do/teapot/external-dns:latest\n+\n+etcd-operator:\n+ customResources:\n+ createEtcdClusterCRD: true\n+ etcdOperator:\n+ image:\n+ repository: quay.io/coreos/etcd-operator\n+ backupOperator:\n+ image:\n+ repository: quay.io/coreos/etcd-operator\n+ restoreOperator:\n+ image:\n+ repository: quay.io/coreos/etcd-operator\n+ etcdCluster:\n+ image:\n+ repository: quay.io/coreos/etcd\n+ pod:\n+ busyboxImage: busybox:1.28.0-glibc\n+\n+coredns:\n+ image:\n+ repository: coredns/coredns\n+ tag: \"1.6.6\"\n+ servers:\n+ - zones:\n+ - zone: .\n+ port: 53\n+ plugins:\n+ - name: cache\n+ parameters: 30\n+ - name: errors\n+ # Serves a /health endpoint on :8080, required for livenessProbe\n+ - name: health\n+ # Serves a /ready endpoint on :8181, required for readinessProbe\n+ - name: ready\n+ # Required to query kubernetes API for data\n+ - name: kubernetes\n+ parameters: cluster.local\n+ - name: loadbalance\n+ parameters: round_robin\n+ # Serves a /metrics endpoint on :9153, required for serviceMonitor\n+ - name: prometheus\n+ parameters: 0.0.0.0:9153\n+ - name: forward\n+ parameters: . /etc/resolv.conf\n+ - name: etcd\n+ parameters: absa.internal","path":"chart/ohmyglb/values.yaml","position":60,"original_position":60,"commit_id":"971577f8a0fc737b2075e91a9d034b2300e525f2","original_commit_id":"971577f8a0fc737b2075e91a9d034b2300e525f2","user":{"login":"donovanmuller","id":1175891,"node_id":"MDQ6VXNlcjExNzU4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1175891?v=4","gravatar_id":"","url":"https://api.github.com/users/donovanmuller","html_url":"https://github.com/donovanmuller","followers_url":"https://api.github.com/users/donovanmuller/followers","following_url":"https://api.github.com/users/donovanmuller/following{/other_user}","gists_url":"https://api.github.com/users/donovanmuller/gists{/gist_id}","starred_url":"https://api.github.com/users/donovanmuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donovanmuller/subscriptions","organizations_url":"https://api.github.com/users/donovanmuller/orgs","repos_url":"https://api.github.com/users/donovanmuller/repos","events_url":"https://api.github.com/users/donovanmuller/events{/privacy}","received_events_url":"https://api.github.com/users/donovanmuller/received_events","type":"User","site_admin":false},"body":"For future perhaps but refrain from using Absa in any configuration defaults","created_at":"2020-01-14T17:17:54Z","updated_at":"2020-01-14T17:19:50Z","html_url":"https://github.com/AbsaOSS/ohmyglb/pull/26#discussion_r366467892","pull_request_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/26","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/comments/366467892"},"html":{"href":"https://github.com/AbsaOSS/ohmyglb/pull/26#discussion_r366467892"},"pull_request":{"href":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/26","id":362747380,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYyNzQ3Mzgw","html_url":"https://github.com/AbsaOSS/ohmyglb/pull/26","diff_url":"https://github.com/AbsaOSS/ohmyglb/pull/26.diff","patch_url":"https://github.com/AbsaOSS/ohmyglb/pull/26.patch","issue_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues/26","number":26,"state":"open","locked":false,"title":"Ohmyglb operator chart","user":{"login":"ytsarev","id":518532,"node_id":"MDQ6VXNlcjUxODUzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/518532?v=4","gravatar_id":"","url":"https://api.github.com/users/ytsarev","html_url":"https://github.com/ytsarev","followers_url":"https://api.github.com/users/ytsarev/followers","following_url":"https://api.github.com/users/ytsarev/following{/other_user}","gists_url":"https://api.github.com/users/ytsarev/gists{/gist_id}","starred_url":"https://api.github.com/users/ytsarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytsarev/subscriptions","organizations_url":"https://api.github.com/users/ytsarev/orgs","repos_url":"https://api.github.com/users/ytsarev/repos","events_url":"https://api.github.com/users/ytsarev/events{/privacy}","received_events_url":"https://api.github.com/users/ytsarev/received_events","type":"User","site_admin":false},"body":"* Create ohmyglb chart including dependencies\r\n\r\nMotivation\r\n\r\n* Control operator and subchart config variables in\r\n a single place\r\n* Handle use cases like image location in private registry\r\n* More streamlined installation\r\n\r\nUnsolved issues\r\n* Duplication of declarations between `/deploy` and chart\r\n* How to handle provisioning in e2e tests(related to the above)\r\n* Chart requires thorough testing","created_at":"2020-01-14T17:12:59Z","updated_at":"2020-01-14T17:19:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c587ab23988e11ccb1b8f958ae80aa4486fd4da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/26/commits","review_comments_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/26/comments","review_comment_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues/26/comments","statuses_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/statuses/971577f8a0fc737b2075e91a9d034b2300e525f2","head":{"label":"AbsaOSS:private_registry","ref":"private_registry","sha":"971577f8a0fc737b2075e91a9d034b2300e525f2","user":{"login":"AbsaOSS","id":18133719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMzNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/18133719?v=4","gravatar_id":"","url":"https://api.github.com/users/AbsaOSS","html_url":"https://github.com/AbsaOSS","followers_url":"https://api.github.com/users/AbsaOSS/followers","following_url":"https://api.github.com/users/AbsaOSS/following{/other_user}","gists_url":"https://api.github.com/users/AbsaOSS/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsaOSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsaOSS/subscriptions","organizations_url":"https://api.github.com/users/AbsaOSS/orgs","repos_url":"https://api.github.com/users/AbsaOSS/repos","events_url":"https://api.github.com/users/AbsaOSS/events{/privacy}","received_events_url":"https://api.github.com/users/AbsaOSS/received_events","type":"Organization","site_admin":false},"repo":{"id":224421982,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0MjE5ODI=","name":"ohmyglb","full_name":"AbsaOSS/ohmyglb","private":false,"owner":{"login":"AbsaOSS","id":18133719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMzNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/18133719?v=4","gravatar_id":"","url":"https://api.github.com/users/AbsaOSS","html_url":"https://github.com/AbsaOSS","followers_url":"https://api.github.com/users/AbsaOSS/followers","following_url":"https://api.github.com/users/AbsaOSS/following{/other_user}","gists_url":"https://api.github.com/users/AbsaOSS/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsaOSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsaOSS/subscriptions","organizations_url":"https://api.github.com/users/AbsaOSS/orgs","repos_url":"https://api.github.com/users/AbsaOSS/repos","events_url":"https://api.github.com/users/AbsaOSS/events{/privacy}","received_events_url":"https://api.github.com/users/AbsaOSS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AbsaOSS/ohmyglb","description":"A cloud native GSLB (Global Server Load Balancing) solution","fork":false,"url":"https://api.github.com/repos/AbsaOSS/ohmyglb","forks_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/forks","keys_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/teams","hooks_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/hooks","issue_events_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues/events{/number}","events_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/events","assignees_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/assignees{/user}","branches_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/branches{/branch}","tags_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/tags","blobs_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/statuses/{sha}","languages_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/languages","stargazers_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/stargazers","contributors_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/contributors","subscribers_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/subscribers","subscription_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/subscription","commits_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/contents/{+path}","compare_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/merges","archive_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/downloads","issues_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues{/number}","pulls_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls{/number}","milestones_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/milestones{/number}","notifications_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/labels{/name}","releases_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/releases{/id}","deployments_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/deployments","created_at":"2019-11-27T12:06:47Z","updated_at":"2020-01-10T20:02:33Z","pushed_at":"2020-01-14T17:12:59Z","git_url":"git://github.com/AbsaOSS/ohmyglb.git","ssh_url":"git@github.com:AbsaOSS/ohmyglb.git","clone_url":"https://github.com/AbsaOSS/ohmyglb.git","svn_url":"https://github.com/AbsaOSS/ohmyglb","homepage":null,"size":5144,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":14,"default_branch":"master"}},"base":{"label":"AbsaOSS:master","ref":"master","sha":"3a714887514d0b371add2967436c40d055d5b9e1","user":{"login":"AbsaOSS","id":18133719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMzNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/18133719?v=4","gravatar_id":"","url":"https://api.github.com/users/AbsaOSS","html_url":"https://github.com/AbsaOSS","followers_url":"https://api.github.com/users/AbsaOSS/followers","following_url":"https://api.github.com/users/AbsaOSS/following{/other_user}","gists_url":"https://api.github.com/users/AbsaOSS/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsaOSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsaOSS/subscriptions","organizations_url":"https://api.github.com/users/AbsaOSS/orgs","repos_url":"https://api.github.com/users/AbsaOSS/repos","events_url":"https://api.github.com/users/AbsaOSS/events{/privacy}","received_events_url":"https://api.github.com/users/AbsaOSS/received_events","type":"Organization","site_admin":false},"repo":{"id":224421982,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0MjE5ODI=","name":"ohmyglb","full_name":"AbsaOSS/ohmyglb","private":false,"owner":{"login":"AbsaOSS","id":18133719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMzNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/18133719?v=4","gravatar_id":"","url":"https://api.github.com/users/AbsaOSS","html_url":"https://github.com/AbsaOSS","followers_url":"https://api.github.com/users/AbsaOSS/followers","following_url":"https://api.github.com/users/AbsaOSS/following{/other_user}","gists_url":"https://api.github.com/users/AbsaOSS/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsaOSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsaOSS/subscriptions","organizations_url":"https://api.github.com/users/AbsaOSS/orgs","repos_url":"https://api.github.com/users/AbsaOSS/repos","events_url":"https://api.github.com/users/AbsaOSS/events{/privacy}","received_events_url":"https://api.github.com/users/AbsaOSS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AbsaOSS/ohmyglb","description":"A cloud native GSLB (Global Server Load Balancing) solution","fork":false,"url":"https://api.github.com/repos/AbsaOSS/ohmyglb","forks_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/forks","keys_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/teams","hooks_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/hooks","issue_events_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues/events{/number}","events_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/events","assignees_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/assignees{/user}","branches_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/branches{/branch}","tags_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/tags","blobs_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/statuses/{sha}","languages_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/languages","stargazers_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/stargazers","contributors_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/contributors","subscribers_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/subscribers","subscription_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/subscription","commits_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/contents/{+path}","compare_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/merges","archive_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/downloads","issues_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues{/number}","pulls_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls{/number}","milestones_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/milestones{/number}","notifications_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/labels{/name}","releases_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/releases{/id}","deployments_url":"https://api.github.com/repos/AbsaOSS/ohmyglb/deployments","created_at":"2019-11-27T12:06:47Z","updated_at":"2020-01-10T20:02:33Z","pushed_at":"2020-01-14T17:12:59Z","git_url":"git://github.com/AbsaOSS/ohmyglb.git","ssh_url":"git@github.com:AbsaOSS/ohmyglb.git","clone_url":"https://github.com/AbsaOSS/ohmyglb.git","svn_url":"https://github.com/AbsaOSS/ohmyglb","homepage":null,"size":5144,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/26"},"html":{"href":"https://github.com/AbsaOSS/ohmyglb/pull/26"},"issue":{"href":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues/26"},"comments":{"href":"https://api.github.com/repos/AbsaOSS/ohmyglb/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AbsaOSS/ohmyglb/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/AbsaOSS/ohmyglb/statuses/971577f8a0fc737b2075e91a9d034b2300e525f2"}},"author_association":"COLLABORATOR"}}
|
{
"id": 224421982,
"name": "AbsaOSS/ohmyglb",
"url": "https://api.github.com/repos/AbsaOSS/ohmyglb"
}
|
{
"id": 1175891,
"login": "donovanmuller",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1175891?",
"url": "https://api.github.com/users/donovanmuller"
}
|
{
"id": 18133719,
"login": "AbsaOSS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18133719?",
"url": "https://api.github.com/orgs/AbsaOSS"
}
| 2020-01-14T17:17:54 |
11273853581
|
{"actor":{"display_login":"donovanmuller"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/comments/322365326","pull_request_review_id":285667745,"id":322365326,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjM2NTMyNg==","diff_hunk":"@@ -30,7 +30,9 @@\n {{#banner.nav}}\n <ul class=\"menu vertical large-horizontal\">\n <li>{{link-to 'Search' 'show-geography'}}</li>\n- {{sign-in}}\n+ {{#if (in-array (array \"development\" \"test\") this.ENV.environment)}}","path":"app/templates/application.hbs","position":5,"original_position":5,"commit_id":"b701ad2163534d391cb36283e7d248207e53a446","original_commit_id":"b701ad2163534d391cb36283e7d248207e53a446","user":{"login":"godfreyyeung","id":3311663,"node_id":"MDQ6VXNlcjMzMTE2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3311663?v=4","gravatar_id":"","url":"https://api.github.com/users/godfreyyeung","html_url":"https://github.com/godfreyyeung","followers_url":"https://api.github.com/users/godfreyyeung/followers","following_url":"https://api.github.com/users/godfreyyeung/following{/other_user}","gists_url":"https://api.github.com/users/godfreyyeung/gists{/gist_id}","starred_url":"https://api.github.com/users/godfreyyeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godfreyyeung/subscriptions","organizations_url":"https://api.github.com/users/godfreyyeung/orgs","repos_url":"https://api.github.com/users/godfreyyeung/repos","events_url":"https://api.github.com/users/godfreyyeung/events{/privacy}","received_events_url":"https://api.github.com/users/godfreyyeung/received_events","type":"User","site_admin":false},"body":"Ohh I see. I was thinking we would just remove these conditionals when the sign-in is no longer \"Development\" ... but yeah this is not as good as the feature flag solution you mentioned. ","created_at":"2019-09-09T17:33:39Z","updated_at":"2019-09-09T17:33:39Z","html_url":"https://github.com/NYCPlanning/labs-zap-search/pull/633#discussion_r322365326","pull_request_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/633","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/comments/322365326"},"html":{"href":"https://github.com/NYCPlanning/labs-zap-search/pull/633#discussion_r322365326"},"pull_request":{"href":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/633"}},"in_reply_to_id":322360415},"pull_request":{"url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/633","id":315591345,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1NTkxMzQ1","html_url":"https://github.com/NYCPlanning/labs-zap-search/pull/633","diff_url":"https://github.com/NYCPlanning/labs-zap-search/pull/633.diff","patch_url":"https://github.com/NYCPlanning/labs-zap-search/pull/633.patch","issue_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/633","number":633,"state":"open","locked":false,"title":"631 & 632 - Hide dev features in staging and prod, hide rec+hearing btns if not auth'd","user":{"login":"godfreyyeung","id":3311663,"node_id":"MDQ6VXNlcjMzMTE2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3311663?v=4","gravatar_id":"","url":"https://api.github.com/users/godfreyyeung","html_url":"https://github.com/godfreyyeung","followers_url":"https://api.github.com/users/godfreyyeung/followers","following_url":"https://api.github.com/users/godfreyyeung/following{/other_user}","gists_url":"https://api.github.com/users/godfreyyeung/gists{/gist_id}","starred_url":"https://api.github.com/users/godfreyyeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godfreyyeung/subscriptions","organizations_url":"https://api.github.com/users/godfreyyeung/orgs","repos_url":"https://api.github.com/users/godfreyyeung/repos","events_url":"https://api.github.com/users/godfreyyeung/events{/privacy}","received_events_url":"https://api.github.com/users/godfreyyeung/received_events","type":"User","site_admin":false},"body":"- (#631) Adds ability to hide \"Development\" features when building to staging and production.\r\n- (#632) This PR includes 1 rider: hiding rec+hearing buttons on `show-project` page if user not auth'd","created_at":"2019-09-09T15:32:18Z","updated_at":"2019-09-09T17:33:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6a4b973959828ff3411529bfba48a4bdfe97bac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/633/commits","review_comments_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/633/comments","review_comment_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/633/comments","statuses_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/statuses/b701ad2163534d391cb36283e7d248207e53a446","head":{"label":"NYCPlanning:631-hide-signin-rec-hearing-btns","ref":"631-hide-signin-rec-hearing-btns","sha":"b701ad2163534d391cb36283e7d248207e53a446","user":{"login":"NYCPlanning","id":18286928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4Mjg2OTI4","avatar_url":"https://avatars1.githubusercontent.com/u/18286928?v=4","gravatar_id":"","url":"https://api.github.com/users/NYCPlanning","html_url":"https://github.com/NYCPlanning","followers_url":"https://api.github.com/users/NYCPlanning/followers","following_url":"https://api.github.com/users/NYCPlanning/following{/other_user}","gists_url":"https://api.github.com/users/NYCPlanning/gists{/gist_id}","starred_url":"https://api.github.com/users/NYCPlanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYCPlanning/subscriptions","organizations_url":"https://api.github.com/users/NYCPlanning/orgs","repos_url":"https://api.github.com/users/NYCPlanning/repos","events_url":"https://api.github.com/users/NYCPlanning/events{/privacy}","received_events_url":"https://api.github.com/users/NYCPlanning/received_events","type":"Organization","site_admin":false},"repo":{"id":136931116,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MzExMTY=","name":"labs-zap-search","full_name":"NYCPlanning/labs-zap-search","private":false,"owner":{"login":"NYCPlanning","id":18286928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4Mjg2OTI4","avatar_url":"https://avatars1.githubusercontent.com/u/18286928?v=4","gravatar_id":"","url":"https://api.github.com/users/NYCPlanning","html_url":"https://github.com/NYCPlanning","followers_url":"https://api.github.com/users/NYCPlanning/followers","following_url":"https://api.github.com/users/NYCPlanning/following{/other_user}","gists_url":"https://api.github.com/users/NYCPlanning/gists{/gist_id}","starred_url":"https://api.github.com/users/NYCPlanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYCPlanning/subscriptions","organizations_url":"https://api.github.com/users/NYCPlanning/orgs","repos_url":"https://api.github.com/users/NYCPlanning/repos","events_url":"https://api.github.com/users/NYCPlanning/events{/privacy}","received_events_url":"https://api.github.com/users/NYCPlanning/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NYCPlanning/labs-zap-search","description":"Search application for the DCP Zoning Application Search","fork":false,"url":"https://api.github.com/repos/NYCPlanning/labs-zap-search","forks_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/forks","keys_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/teams","hooks_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/hooks","issue_events_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/events{/number}","events_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/events","assignees_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/assignees{/user}","branches_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/branches{/branch}","tags_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/tags","blobs_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/statuses/{sha}","languages_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/languages","stargazers_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/stargazers","contributors_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/contributors","subscribers_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/subscribers","subscription_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/subscription","commits_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/contents/{+path}","compare_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/merges","archive_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/downloads","issues_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues{/number}","pulls_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls{/number}","milestones_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/milestones{/number}","notifications_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/labels{/name}","releases_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/releases{/id}","deployments_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/deployments","created_at":"2018-06-11T13:35:52Z","updated_at":"2019-08-27T19:53:37Z","pushed_at":"2019-09-09T17:33:34Z","git_url":"git://github.com/NYCPlanning/labs-zap-search.git","ssh_url":"git@github.com:NYCPlanning/labs-zap-search.git","clone_url":"https://github.com/NYCPlanning/labs-zap-search.git","svn_url":"https://github.com/NYCPlanning/labs-zap-search","homepage":"https://zap.planning.nyc.gov","size":3733,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":122,"license":null,"forks":2,"open_issues":122,"watchers":9,"default_branch":"develop"}},"base":{"label":"NYCPlanning:develop-future","ref":"develop-future","sha":"ac97893082b6cc5353c1051b12dde05fd50fff23","user":{"login":"NYCPlanning","id":18286928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4Mjg2OTI4","avatar_url":"https://avatars1.githubusercontent.com/u/18286928?v=4","gravatar_id":"","url":"https://api.github.com/users/NYCPlanning","html_url":"https://github.com/NYCPlanning","followers_url":"https://api.github.com/users/NYCPlanning/followers","following_url":"https://api.github.com/users/NYCPlanning/following{/other_user}","gists_url":"https://api.github.com/users/NYCPlanning/gists{/gist_id}","starred_url":"https://api.github.com/users/NYCPlanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYCPlanning/subscriptions","organizations_url":"https://api.github.com/users/NYCPlanning/orgs","repos_url":"https://api.github.com/users/NYCPlanning/repos","events_url":"https://api.github.com/users/NYCPlanning/events{/privacy}","received_events_url":"https://api.github.com/users/NYCPlanning/received_events","type":"Organization","site_admin":false},"repo":{"id":136931116,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MzExMTY=","name":"labs-zap-search","full_name":"NYCPlanning/labs-zap-search","private":false,"owner":{"login":"NYCPlanning","id":18286928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4Mjg2OTI4","avatar_url":"https://avatars1.githubusercontent.com/u/18286928?v=4","gravatar_id":"","url":"https://api.github.com/users/NYCPlanning","html_url":"https://github.com/NYCPlanning","followers_url":"https://api.github.com/users/NYCPlanning/followers","following_url":"https://api.github.com/users/NYCPlanning/following{/other_user}","gists_url":"https://api.github.com/users/NYCPlanning/gists{/gist_id}","starred_url":"https://api.github.com/users/NYCPlanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYCPlanning/subscriptions","organizations_url":"https://api.github.com/users/NYCPlanning/orgs","repos_url":"https://api.github.com/users/NYCPlanning/repos","events_url":"https://api.github.com/users/NYCPlanning/events{/privacy}","received_events_url":"https://api.github.com/users/NYCPlanning/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NYCPlanning/labs-zap-search","description":"Search application for the DCP Zoning Application Search","fork":false,"url":"https://api.github.com/repos/NYCPlanning/labs-zap-search","forks_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/forks","keys_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/teams","hooks_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/hooks","issue_events_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/events{/number}","events_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/events","assignees_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/assignees{/user}","branches_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/branches{/branch}","tags_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/tags","blobs_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/statuses/{sha}","languages_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/languages","stargazers_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/stargazers","contributors_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/contributors","subscribers_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/subscribers","subscription_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/subscription","commits_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/contents/{+path}","compare_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/merges","archive_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/downloads","issues_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues{/number}","pulls_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls{/number}","milestones_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/milestones{/number}","notifications_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/labels{/name}","releases_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/releases{/id}","deployments_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/deployments","created_at":"2018-06-11T13:35:52Z","updated_at":"2019-08-27T19:53:37Z","pushed_at":"2019-09-09T17:33:34Z","git_url":"git://github.com/NYCPlanning/labs-zap-search.git","ssh_url":"git@github.com:NYCPlanning/labs-zap-search.git","clone_url":"https://github.com/NYCPlanning/labs-zap-search.git","svn_url":"https://github.com/NYCPlanning/labs-zap-search","homepage":"https://zap.planning.nyc.gov","size":3733,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":122,"license":null,"forks":2,"open_issues":122,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/633"},"html":{"href":"https://github.com/NYCPlanning/labs-zap-search/pull/633"},"issue":{"href":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/633"},"comments":{"href":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/NYCPlanning/labs-zap-search/statuses/b701ad2163534d391cb36283e7d248207e53a446"}},"author_association":"NONE"}}
|
{
"id": 136931116,
"name": "NYCPlanning/labs-zap-search",
"url": "https://api.github.com/repos/NYCPlanning/labs-zap-search"
}
|
{
"id": 3311663,
"login": "godfreyyeung",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3311663?",
"url": "https://api.github.com/users/godfreyyeung"
}
|
{
"id": 18286928,
"login": "NYCPlanning",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18286928?",
"url": "https://api.github.com/orgs/NYCPlanning"
}
| 2019-09-09T17:33:39 |
10378188006
|
{"actor":{"display_login":"godfreyyeung"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Tencent/wepy/pulls/comments/308672754","pull_request_review_id":268325542,"id":308672754,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODY3Mjc1NA==","diff_hunk":"@@ -12,59 +12,74 @@ const setPath = (key, path) => {\n : `${path}.${key}`;\n }\n \n+const pickPathMap = obj => obj && obj.__ob__ && obj.__ob__.op.pathMap\n+\n export default class ObserverPath {\n- constructor (key, parent, observer) {\n- this.observer = observer;\n- this.pathMap = parent && parent.__ob__ && parent.__ob__.op\n- ? parent.__ob__.op.getPathMap(key)\n- : ( key\n- ? { [key] : {key, root: key, path: key} }\n- : {}\n- );\n+ constructor (key, parent, ob) {\n+ this.observer = ob;\n+ this.pathMap = ObserverPath.getPathMap(key, pickPathMap(parent));\n }\n \n /**\n- * 更新 __ob__ 的 path\n+ * 添加新的 __ob__ 的 path\n */\n- traverseUpdatePath (key, value, parent) {\n+ traverseAddPath (key, value, parentPathMap) {\n // 得到此 value 挂载到 parent 的 pathMap\n- const pathMap = parent && parent.__ob__ && parent.__ob__.op\n- ? parent.__ob__.op.getPathMap(key)\n- : ( key\n- ? { [key] : {key, root: key, path: key} }\n- : {}\n- );\n+ const pathMap = ObserverPath.getPathMap(key, parentPathMap);\n const keys = Object.keys(pathMap);\n+ let newPathMap = {};\n \n // 遍历 pathMap\n for (let i = 0; i < keys.length; i++) {\n const {root, path} = pathMap[keys[i]];\n-\n- // 判断 path 是否存在，如果不存在则新增一条 path\n if (!(path in this.pathMap)) {\n- this.pathMap[path] = {key, root, path};\n+ // 新增一条 path\n+ newPathMap[path] = {key, root, path};\n+ this.pathMap[path] = newPathMap[path];\n+ }\n+ }\n \n- // 深度遍历更新路径\n- let keys;\n- if (Array.isArray(value)) {\n- keys = Array.from(Array(value.length), (val, index) => index);\n- } else {\n- keys = Object.keys(value);\n+ // 深度遍历添加路径\n+ if (Array.isArray(value)) {\n+ for (let i = 0; i < value.length; i++) {\n+ if (isObject(value[i]) && hasOwn(value[i], '__ob__')) {\n+ value[i].__ob__.op.traverseAddPath(i, value[i], newPathMap);\n }\n- for (let i = 0; i < keys.length; i++) {\n- const key = keys[i];\n- if (isObject(value[key]) && hasOwn(value[key], '__ob__')) {\n- value[key].__ob__.op.traverseUpdatePath(key, value[key], value.observer.vm);\n- }\n+ }\n+ } else {\n+ const keys = Object.keys(value);\n+ for (let i = 0; i < keys.length; i++) {\n+ const key = keys[i];\n+ if (isObject(value[key]) && hasOwn(value[key], '__ob__')) {\n+ value[key].__ob__.op.traverseAddPath(key, value[key], newPathMap);\n }\n+ }\n+ }\n+ }\n \n- // 清除不存在的路径\n- keys = Object.keys(this.pathMap);\n- for (let i = 0; i < keys.length; i++) {\n- const key = keys[i];\n- if (!this.observer.isPathEq(key, value)) {\n- delete this.pathMap[key];\n- }\n+ delInvalidPaths (key, value, parentPathMap) {","path":"packages/core/weapp/observer/observerPath.js","position":86,"original_position":86,"commit_id":"b6f71d2dd12d73266316a1d66e8d87faf8e95678","original_commit_id":"b6f71d2dd12d73266316a1d66e8d87faf8e95678","user":{"login":"Gcaufy","id":2182004,"node_id":"MDQ6VXNlcjIxODIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2182004?v=4","gravatar_id":"","url":"https://api.github.com/users/Gcaufy","html_url":"https://github.com/Gcaufy","followers_url":"https://api.github.com/users/Gcaufy/followers","following_url":"https://api.github.com/users/Gcaufy/following{/other_user}","gists_url":"https://api.github.com/users/Gcaufy/gists{/gist_id}","starred_url":"https://api.github.com/users/Gcaufy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gcaufy/subscriptions","organizations_url":"https://api.github.com/users/Gcaufy/orgs","repos_url":"https://api.github.com/users/Gcaufy/repos","events_url":"https://api.github.com/users/Gcaufy/events{/privacy}","received_events_url":"https://api.github.com/users/Gcaufy/received_events","type":"User","site_admin":false},"body":"尽量用简单方法名：\r\n如 clean 之类的。","created_at":"2019-07-30T11:38:02Z","updated_at":"2019-07-30T11:45:10Z","html_url":"https://github.com/Tencent/wepy/pull/2273#discussion_r308672754","pull_request_url":"https://api.github.com/repos/Tencent/wepy/pulls/2273","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Tencent/wepy/pulls/comments/308672754"},"html":{"href":"https://github.com/Tencent/wepy/pull/2273#discussion_r308672754"},"pull_request":{"href":"https://api.github.com/repos/Tencent/wepy/pulls/2273"}}},"pull_request":{"url":"https://api.github.com/repos/Tencent/wepy/pulls/2273","id":301805291,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxODA1Mjkx","html_url":"https://github.com/Tencent/wepy/pull/2273","diff_url":"https://github.com/Tencent/wepy/pull/2273.diff","patch_url":"https://github.com/Tencent/wepy/pull/2273.patch","issue_url":"https://api.github.com/repos/Tencent/wepy/issues/2273","number":2273,"state":"open","locked":false,"title":" refactor(core): 优化 ObserverPath 以及 set dirty 相关逻辑","user":{"login":"nishino-tsukasa","id":12985781,"node_id":"MDQ6VXNlcjEyOTg1Nzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12985781?v=4","gravatar_id":"","url":"https://api.github.com/users/nishino-tsukasa","html_url":"https://github.com/nishino-tsukasa","followers_url":"https://api.github.com/users/nishino-tsukasa/followers","following_url":"https://api.github.com/users/nishino-tsukasa/following{/other_user}","gists_url":"https://api.github.com/users/nishino-tsukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nishino-tsukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishino-tsukasa/subscriptions","organizations_url":"https://api.github.com/users/nishino-tsukasa/orgs","repos_url":"https://api.github.com/users/nishino-tsukasa/repos","events_url":"https://api.github.com/users/nishino-tsukasa/events{/privacy}","received_events_url":"https://api.github.com/users/nishino-tsukasa/received_events","type":"User","site_admin":false},"body":"1. 重构 ObserverPath ，重新梳理了一下逻辑，做了一定的抽象。\r\n\r\n data 可以看做一颗树，树的每个节点都可以存放一个 val。因此我们要做的就是收集记录每个 val 所在节点到根节点的路径集合。其中，不同节点的 val 可以指向同一个引用。因此当节点发生变化时，就需要对节点相对应的 val 的路径集合进行更新。\r\n\r\n 修改更新树的方式有四种：\r\n\r\n 1. 插入一个新的节点\r\n 2. 删除一个已有节点\r\n 3. 更新一个已有节点的 val\r\n 4. 清除一个已有节点的 val\r\n\r\n 对应到路径集合的维护，变成两种操作：\r\n\r\n 1. 添加路径集合\r\n 2. 删除路径集合\r\n\r\n 因此只需要在赋值操作、vm.$set 、vm.$delete 以及数组的变异操作这几个可以修改更新树的地方维护路径集合即可\r\n\r\n2. 优化 dirty set\r\n\r\n 根据微信小程序官方文档指出：出于性能考虑，使用 usingComponents 时， setData 内容不会被直接深复制，即 this.setData({ field: obj }) 后 this.data.field === obj 。（深复制会在这个值被组件间传递时发生。）\r\n\r\n 因此如果存在多条路径，只需要将一条路径放入 dirty ，setData 这一条路径，就可以更新有相同引用的其它路径了。","created_at":"2019-07-28T05:10:33Z","updated_at":"2019-07-30T11:45:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf0f6e5ce5461fa3cdcff848f8ccd092a7f58993","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Tencent/wepy/pulls/2273/commits","review_comments_url":"https://api.github.com/repos/Tencent/wepy/pulls/2273/comments","review_comment_url":"https://api.github.com/repos/Tencent/wepy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tencent/wepy/issues/2273/comments","statuses_url":"https://api.github.com/repos/Tencent/wepy/statuses/b6f71d2dd12d73266316a1d66e8d87faf8e95678","head":{"label":"nishino-tsukasa:wepy-core-observer","ref":"wepy-core-observer","sha":"b6f71d2dd12d73266316a1d66e8d87faf8e95678","user":{"login":"nishino-tsukasa","id":12985781,"node_id":"MDQ6VXNlcjEyOTg1Nzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12985781?v=4","gravatar_id":"","url":"https://api.github.com/users/nishino-tsukasa","html_url":"https://github.com/nishino-tsukasa","followers_url":"https://api.github.com/users/nishino-tsukasa/followers","following_url":"https://api.github.com/users/nishino-tsukasa/following{/other_user}","gists_url":"https://api.github.com/users/nishino-tsukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nishino-tsukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishino-tsukasa/subscriptions","organizations_url":"https://api.github.com/users/nishino-tsukasa/orgs","repos_url":"https://api.github.com/users/nishino-tsukasa/repos","events_url":"https://api.github.com/users/nishino-tsukasa/events{/privacy}","received_events_url":"https://api.github.com/users/nishino-tsukasa/received_events","type":"User","site_admin":false},"repo":{"id":196785511,"node_id":"MDEwOlJlcG9zaXRvcnkxOTY3ODU1MTE=","name":"wepy","full_name":"nishino-tsukasa/wepy","private":false,"owner":{"login":"nishino-tsukasa","id":12985781,"node_id":"MDQ6VXNlcjEyOTg1Nzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12985781?v=4","gravatar_id":"","url":"https://api.github.com/users/nishino-tsukasa","html_url":"https://github.com/nishino-tsukasa","followers_url":"https://api.github.com/users/nishino-tsukasa/followers","following_url":"https://api.github.com/users/nishino-tsukasa/following{/other_user}","gists_url":"https://api.github.com/users/nishino-tsukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nishino-tsukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishino-tsukasa/subscriptions","organizations_url":"https://api.github.com/users/nishino-tsukasa/orgs","repos_url":"https://api.github.com/users/nishino-tsukasa/repos","events_url":"https://api.github.com/users/nishino-tsukasa/events{/privacy}","received_events_url":"https://api.github.com/users/nishino-tsukasa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nishino-tsukasa/wepy","description":"小程序组件化开发框架","fork":true,"url":"https://api.github.com/repos/nishino-tsukasa/wepy","forks_url":"https://api.github.com/repos/nishino-tsukasa/wepy/forks","keys_url":"https://api.github.com/repos/nishino-tsukasa/wepy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nishino-tsukasa/wepy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nishino-tsukasa/wepy/teams","hooks_url":"https://api.github.com/repos/nishino-tsukasa/wepy/hooks","issue_events_url":"https://api.github.com/repos/nishino-tsukasa/wepy/issues/events{/number}","events_url":"https://api.github.com/repos/nishino-tsukasa/wepy/events","assignees_url":"https://api.github.com/repos/nishino-tsukasa/wepy/assignees{/user}","branches_url":"https://api.github.com/repos/nishino-tsukasa/wepy/branches{/branch}","tags_url":"https://api.github.com/repos/nishino-tsukasa/wepy/tags","blobs_url":"https://api.github.com/repos/nishino-tsukasa/wepy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nishino-tsukasa/wepy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nishino-tsukasa/wepy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nishino-tsukasa/wepy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nishino-tsukasa/wepy/statuses/{sha}","languages_url":"https://api.github.com/repos/nishino-tsukasa/wepy/languages","stargazers_url":"https://api.github.com/repos/nishino-tsukasa/wepy/stargazers","contributors_url":"https://api.github.com/repos/nishino-tsukasa/wepy/contributors","subscribers_url":"https://api.github.com/repos/nishino-tsukasa/wepy/subscribers","subscription_url":"https://api.github.com/repos/nishino-tsukasa/wepy/subscription","commits_url":"https://api.github.com/repos/nishino-tsukasa/wepy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nishino-tsukasa/wepy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nishino-tsukasa/wepy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nishino-tsukasa/wepy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nishino-tsukasa/wepy/contents/{+path}","compare_url":"https://api.github.com/repos/nishino-tsukasa/wepy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nishino-tsukasa/wepy/merges","archive_url":"https://api.github.com/repos/nishino-tsukasa/wepy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nishino-tsukasa/wepy/downloads","issues_url":"https://api.github.com/repos/nishino-tsukasa/wepy/issues{/number}","pulls_url":"https://api.github.com/repos/nishino-tsukasa/wepy/pulls{/number}","milestones_url":"https://api.github.com/repos/nishino-tsukasa/wepy/milestones{/number}","notifications_url":"https://api.github.com/repos/nishino-tsukasa/wepy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nishino-tsukasa/wepy/labels{/name}","releases_url":"https://api.github.com/repos/nishino-tsukasa/wepy/releases{/id}","deployments_url":"https://api.github.com/repos/nishino-tsukasa/wepy/deployments","created_at":"2019-07-14T02:32:58Z","updated_at":"2019-07-14T02:33:02Z","pushed_at":"2019-07-29T10:52:21Z","git_url":"git://github.com/nishino-tsukasa/wepy.git","ssh_url":"git@github.com:nishino-tsukasa/wepy.git","clone_url":"https://github.com/nishino-tsukasa/wepy.git","svn_url":"https://github.com/nishino-tsukasa/wepy","homepage":"https://wepyjs.github.io/wepy-docs/","size":7153,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.0.x"}},"base":{"label":"Tencent:2.0.x","ref":"2.0.x","sha":"865364284452220c8db36e798e31cc6646545acd","user":{"login":"Tencent","id":18461506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDYxNTA2","avatar_url":"https://avatars3.githubusercontent.com/u/18461506?v=4","gravatar_id":"","url":"https://api.github.com/users/Tencent","html_url":"https://github.com/Tencent","followers_url":"https://api.github.com/users/Tencent/followers","following_url":"https://api.github.com/users/Tencent/following{/other_user}","gists_url":"https://api.github.com/users/Tencent/gists{/gist_id}","starred_url":"https://api.github.com/users/Tencent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tencent/subscriptions","organizations_url":"https://api.github.com/users/Tencent/orgs","repos_url":"https://api.github.com/users/Tencent/repos","events_url":"https://api.github.com/users/Tencent/events{/privacy}","received_events_url":"https://api.github.com/users/Tencent/received_events","type":"Organization","site_admin":false},"repo":{"id":73681508,"node_id":"MDEwOlJlcG9zaXRvcnk3MzY4MTUwOA==","name":"wepy","full_name":"Tencent/wepy","private":false,"owner":{"login":"Tencent","id":18461506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDYxNTA2","avatar_url":"https://avatars3.githubusercontent.com/u/18461506?v=4","gravatar_id":"","url":"https://api.github.com/users/Tencent","html_url":"https://github.com/Tencent","followers_url":"https://api.github.com/users/Tencent/followers","following_url":"https://api.github.com/users/Tencent/following{/other_user}","gists_url":"https://api.github.com/users/Tencent/gists{/gist_id}","starred_url":"https://api.github.com/users/Tencent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tencent/subscriptions","organizations_url":"https://api.github.com/users/Tencent/orgs","repos_url":"https://api.github.com/users/Tencent/repos","events_url":"https://api.github.com/users/Tencent/events{/privacy}","received_events_url":"https://api.github.com/users/Tencent/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Tencent/wepy","description":"小程序组件化开发框架","fork":false,"url":"https://api.github.com/repos/Tencent/wepy","forks_url":"https://api.github.com/repos/Tencent/wepy/forks","keys_url":"https://api.github.com/repos/Tencent/wepy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tencent/wepy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tencent/wepy/teams","hooks_url":"https://api.github.com/repos/Tencent/wepy/hooks","issue_events_url":"https://api.github.com/repos/Tencent/wepy/issues/events{/number}","events_url":"https://api.github.com/repos/Tencent/wepy/events","assignees_url":"https://api.github.com/repos/Tencent/wepy/assignees{/user}","branches_url":"https://api.github.com/repos/Tencent/wepy/branches{/branch}","tags_url":"https://api.github.com/repos/Tencent/wepy/tags","blobs_url":"https://api.github.com/repos/Tencent/wepy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tencent/wepy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tencent/wepy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tencent/wepy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tencent/wepy/statuses/{sha}","languages_url":"https://api.github.com/repos/Tencent/wepy/languages","stargazers_url":"https://api.github.com/repos/Tencent/wepy/stargazers","contributors_url":"https://api.github.com/repos/Tencent/wepy/contributors","subscribers_url":"https://api.github.com/repos/Tencent/wepy/subscribers","subscription_url":"https://api.github.com/repos/Tencent/wepy/subscription","commits_url":"https://api.github.com/repos/Tencent/wepy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tencent/wepy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tencent/wepy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tencent/wepy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tencent/wepy/contents/{+path}","compare_url":"https://api.github.com/repos/Tencent/wepy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tencent/wepy/merges","archive_url":"https://api.github.com/repos/Tencent/wepy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tencent/wepy/downloads","issues_url":"https://api.github.com/repos/Tencent/wepy/issues{/number}","pulls_url":"https://api.github.com/repos/Tencent/wepy/pulls{/number}","milestones_url":"https://api.github.com/repos/Tencent/wepy/milestones{/number}","notifications_url":"https://api.github.com/repos/Tencent/wepy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tencent/wepy/labels{/name}","releases_url":"https://api.github.com/repos/Tencent/wepy/releases{/id}","deployments_url":"https://api.github.com/repos/Tencent/wepy/deployments","created_at":"2016-11-14T08:06:56Z","updated_at":"2019-07-30T09:47:12Z","pushed_at":"2019-07-30T07:47:19Z","git_url":"git://github.com/Tencent/wepy.git","ssh_url":"git@github.com:Tencent/wepy.git","clone_url":"https://github.com/Tencent/wepy.git","svn_url":"https://github.com/Tencent/wepy","homepage":"https://wepyjs.github.io/wepy-docs/","size":7075,"stargazers_count":18488,"watchers_count":18488,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2695,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":216,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2695,"open_issues":216,"watchers":18488,"default_branch":"2.0.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Tencent/wepy/pulls/2273"},"html":{"href":"https://github.com/Tencent/wepy/pull/2273"},"issue":{"href":"https://api.github.com/repos/Tencent/wepy/issues/2273"},"comments":{"href":"https://api.github.com/repos/Tencent/wepy/issues/2273/comments"},"review_comments":{"href":"https://api.github.com/repos/Tencent/wepy/pulls/2273/comments"},"review_comment":{"href":"https://api.github.com/repos/Tencent/wepy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tencent/wepy/pulls/2273/commits"},"statuses":{"href":"https://api.github.com/repos/Tencent/wepy/statuses/b6f71d2dd12d73266316a1d66e8d87faf8e95678"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 73681508,
"name": "Tencent/wepy",
"url": "https://api.github.com/repos/Tencent/wepy"
}
|
{
"id": 2182004,
"login": "Gcaufy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2182004?",
"url": "https://api.github.com/users/Gcaufy"
}
|
{
"id": 18461506,
"login": "Tencent",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18461506?",
"url": "https://api.github.com/orgs/Tencent"
}
| 2019-07-30T11:38:02 |
10111019288
|
{"actor":{"display_login":"Gcaufy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kontur-courses/di/pulls/comments/356752011","pull_request_review_id":330737590,"id":356752011,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Njc1MjAxMQ==","diff_hunk":"@@ -36,14 +34,8 @@ public static void Main(string[] args)\n builder.RegisterType<ArchimedeSpiral>().As<ISpiral>();\n builder.RegisterType<TagsProcessor>().As<ITagsProcessor>();\n builder.RegisterType<WordsProcessor>().As<IWordsProcessor>();\n- builder.RegisterType<WordFiltersApplyer>()\n- .WithParameter(ResolvedParameter\n- .ForNamed<Func<string, bool>>(\"defaultFilter\"))\n- .As<IWordFiltersApplyer>();\n- builder\n- .Register<Func<string, bool>>(c => word => word.Length >= 3)\n- .Named<Func<string, bool>>(\"defaultFilter\");\n builder.RegisterInstance(new TxtReader(sourceTextFilePath)).As<ITextReader>();\n+ builder.RegisterType<WordLengthFilter>().As<IWordFilter>();","path":"TagsCloud/Program.cs","position":38,"original_position":49,"commit_id":"14dc87d3418336a9e187cd90a924d35227a9293d","original_commit_id":"14dc87d3418336a9e187cd90a924d35227a9293d","user":{"login":"Kamikoto-sama","id":38423206,"node_id":"MDQ6VXNlcjM4NDIzMjA2","avatar_url":"https://avatars3.githubusercontent.com/u/38423206?v=4","gravatar_id":"","url":"https://api.github.com/users/Kamikoto-sama","html_url":"https://github.com/Kamikoto-sama","followers_url":"https://api.github.com/users/Kamikoto-sama/followers","following_url":"https://api.github.com/users/Kamikoto-sama/following{/other_user}","gists_url":"https://api.github.com/users/Kamikoto-sama/gists{/gist_id}","starred_url":"https://api.github.com/users/Kamikoto-sama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kamikoto-sama/subscriptions","organizations_url":"https://api.github.com/users/Kamikoto-sama/orgs","repos_url":"https://api.github.com/users/Kamikoto-sama/repos","events_url":"https://api.github.com/users/Kamikoto-sama/events{/privacy}","received_events_url":"https://api.github.com/users/Kamikoto-sama/received_events","type":"User","site_admin":false},"body":"Сделал.","created_at":"2019-12-11T18:07:24Z","updated_at":"2019-12-11T18:07:24Z","html_url":"https://github.com/kontur-courses/di/pull/43#discussion_r356752011","pull_request_url":"https://api.github.com/repos/kontur-courses/di/pulls/43","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kontur-courses/di/pulls/comments/356752011"},"html":{"href":"https://github.com/kontur-courses/di/pull/43#discussion_r356752011"},"pull_request":{"href":"https://api.github.com/repos/kontur-courses/di/pulls/43"}},"in_reply_to_id":356644413},"pull_request":{"url":"https://api.github.com/repos/kontur-courses/di/pulls/43","id":347257299,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MjU3Mjk5","html_url":"https://github.com/kontur-courses/di/pull/43","diff_url":"https://github.com/kontur-courses/di/pull/43.diff","patch_url":"https://github.com/kontur-courses/di/pull/43.patch","issue_url":"https://api.github.com/repos/kontur-courses/di/issues/43","number":43,"state":"open","locked":false,"title":"Мохов Даниил","user":{"login":"Kamikoto-sama","id":38423206,"node_id":"MDQ6VXNlcjM4NDIzMjA2","avatar_url":"https://avatars3.githubusercontent.com/u/38423206?v=4","gravatar_id":"","url":"https://api.github.com/users/Kamikoto-sama","html_url":"https://github.com/Kamikoto-sama","followers_url":"https://api.github.com/users/Kamikoto-sama/followers","following_url":"https://api.github.com/users/Kamikoto-sama/following{/other_user}","gists_url":"https://api.github.com/users/Kamikoto-sama/gists{/gist_id}","starred_url":"https://api.github.com/users/Kamikoto-sama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kamikoto-sama/subscriptions","organizations_url":"https://api.github.com/users/Kamikoto-sama/orgs","repos_url":"https://api.github.com/users/Kamikoto-sama/repos","events_url":"https://api.github.com/users/Kamikoto-sama/events{/privacy}","received_events_url":"https://api.github.com/users/Kamikoto-sama/received_events","type":"User","site_admin":false},"body":"@goodoldlameme","created_at":"2019-11-30T20:27:53Z","updated_at":"2019-12-11T18:07:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c02c92a8026537ad5209e825dc1bf54d1a3a4f89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kontur-courses/di/pulls/43/commits","review_comments_url":"https://api.github.com/repos/kontur-courses/di/pulls/43/comments","review_comment_url":"https://api.github.com/repos/kontur-courses/di/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kontur-courses/di/issues/43/comments","statuses_url":"https://api.github.com/repos/kontur-courses/di/statuses/14dc87d3418336a9e187cd90a924d35227a9293d","head":{"label":"Kamikoto-sama:master","ref":"master","sha":"14dc87d3418336a9e187cd90a924d35227a9293d","user":{"login":"Kamikoto-sama","id":38423206,"node_id":"MDQ6VXNlcjM4NDIzMjA2","avatar_url":"https://avatars3.githubusercontent.com/u/38423206?v=4","gravatar_id":"","url":"https://api.github.com/users/Kamikoto-sama","html_url":"https://github.com/Kamikoto-sama","followers_url":"https://api.github.com/users/Kamikoto-sama/followers","following_url":"https://api.github.com/users/Kamikoto-sama/following{/other_user}","gists_url":"https://api.github.com/users/Kamikoto-sama/gists{/gist_id}","starred_url":"https://api.github.com/users/Kamikoto-sama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kamikoto-sama/subscriptions","organizations_url":"https://api.github.com/users/Kamikoto-sama/orgs","repos_url":"https://api.github.com/users/Kamikoto-sama/repos","events_url":"https://api.github.com/users/Kamikoto-sama/events{/privacy}","received_events_url":"https://api.github.com/users/Kamikoto-sama/received_events","type":"User","site_admin":false},"repo":{"id":224422062,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0MjIwNjI=","name":"di","full_name":"Kamikoto-sama/di","private":false,"owner":{"login":"Kamikoto-sama","id":38423206,"node_id":"MDQ6VXNlcjM4NDIzMjA2","avatar_url":"https://avatars3.githubusercontent.com/u/38423206?v=4","gravatar_id":"","url":"https://api.github.com/users/Kamikoto-sama","html_url":"https://github.com/Kamikoto-sama","followers_url":"https://api.github.com/users/Kamikoto-sama/followers","following_url":"https://api.github.com/users/Kamikoto-sama/following{/other_user}","gists_url":"https://api.github.com/users/Kamikoto-sama/gists{/gist_id}","starred_url":"https://api.github.com/users/Kamikoto-sama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kamikoto-sama/subscriptions","organizations_url":"https://api.github.com/users/Kamikoto-sama/orgs","repos_url":"https://api.github.com/users/Kamikoto-sama/repos","events_url":"https://api.github.com/users/Kamikoto-sama/events{/privacy}","received_events_url":"https://api.github.com/users/Kamikoto-sama/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Kamikoto-sama/di","description":null,"fork":true,"url":"https://api.github.com/repos/Kamikoto-sama/di","forks_url":"https://api.github.com/repos/Kamikoto-sama/di/forks","keys_url":"https://api.github.com/repos/Kamikoto-sama/di/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kamikoto-sama/di/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kamikoto-sama/di/teams","hooks_url":"https://api.github.com/repos/Kamikoto-sama/di/hooks","issue_events_url":"https://api.github.com/repos/Kamikoto-sama/di/issues/events{/number}","events_url":"https://api.github.com/repos/Kamikoto-sama/di/events","assignees_url":"https://api.github.com/repos/Kamikoto-sama/di/assignees{/user}","branches_url":"https://api.github.com/repos/Kamikoto-sama/di/branches{/branch}","tags_url":"https://api.github.com/repos/Kamikoto-sama/di/tags","blobs_url":"https://api.github.com/repos/Kamikoto-sama/di/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kamikoto-sama/di/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kamikoto-sama/di/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kamikoto-sama/di/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kamikoto-sama/di/statuses/{sha}","languages_url":"https://api.github.com/repos/Kamikoto-sama/di/languages","stargazers_url":"https://api.github.com/repos/Kamikoto-sama/di/stargazers","contributors_url":"https://api.github.com/repos/Kamikoto-sama/di/contributors","subscribers_url":"https://api.github.com/repos/Kamikoto-sama/di/subscribers","subscription_url":"https://api.github.com/repos/Kamikoto-sama/di/subscription","commits_url":"https://api.github.com/repos/Kamikoto-sama/di/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kamikoto-sama/di/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kamikoto-sama/di/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kamikoto-sama/di/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kamikoto-sama/di/contents/{+path}","compare_url":"https://api.github.com/repos/Kamikoto-sama/di/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kamikoto-sama/di/merges","archive_url":"https://api.github.com/repos/Kamikoto-sama/di/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kamikoto-sama/di/downloads","issues_url":"https://api.github.com/repos/Kamikoto-sama/di/issues{/number}","pulls_url":"https://api.github.com/repos/Kamikoto-sama/di/pulls{/number}","milestones_url":"https://api.github.com/repos/Kamikoto-sama/di/milestones{/number}","notifications_url":"https://api.github.com/repos/Kamikoto-sama/di/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kamikoto-sama/di/labels{/name}","releases_url":"https://api.github.com/repos/Kamikoto-sama/di/releases{/id}","deployments_url":"https://api.github.com/repos/Kamikoto-sama/di/deployments","created_at":"2019-11-27T12:07:14Z","updated_at":"2019-12-09T20:58:18Z","pushed_at":"2019-12-09T20:58:15Z","git_url":"git://github.com/Kamikoto-sama/di.git","ssh_url":"git@github.com:Kamikoto-sama/di.git","clone_url":"https://github.com/Kamikoto-sama/di.git","svn_url":"https://github.com/Kamikoto-sama/di","homepage":null,"size":877,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kontur-courses:master","ref":"master","sha":"ad3fa12f1c937d408294925d09714408e16281c6","user":{"login":"kontur-courses","id":19208073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjA4MDcz","avatar_url":"https://avatars2.githubusercontent.com/u/19208073?v=4","gravatar_id":"","url":"https://api.github.com/users/kontur-courses","html_url":"https://github.com/kontur-courses","followers_url":"https://api.github.com/users/kontur-courses/followers","following_url":"https://api.github.com/users/kontur-courses/following{/other_user}","gists_url":"https://api.github.com/users/kontur-courses/gists{/gist_id}","starred_url":"https://api.github.com/users/kontur-courses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontur-courses/subscriptions","organizations_url":"https://api.github.com/users/kontur-courses/orgs","repos_url":"https://api.github.com/users/kontur-courses/repos","events_url":"https://api.github.com/users/kontur-courses/events{/privacy}","received_events_url":"https://api.github.com/users/kontur-courses/received_events","type":"Organization","site_admin":false},"repo":{"id":63904305,"node_id":"MDEwOlJlcG9zaXRvcnk2MzkwNDMwNQ==","name":"di","full_name":"kontur-courses/di","private":false,"owner":{"login":"kontur-courses","id":19208073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjA4MDcz","avatar_url":"https://avatars2.githubusercontent.com/u/19208073?v=4","gravatar_id":"","url":"https://api.github.com/users/kontur-courses","html_url":"https://github.com/kontur-courses","followers_url":"https://api.github.com/users/kontur-courses/followers","following_url":"https://api.github.com/users/kontur-courses/following{/other_user}","gists_url":"https://api.github.com/users/kontur-courses/gists{/gist_id}","starred_url":"https://api.github.com/users/kontur-courses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontur-courses/subscriptions","organizations_url":"https://api.github.com/users/kontur-courses/orgs","repos_url":"https://api.github.com/users/kontur-courses/repos","events_url":"https://api.github.com/users/kontur-courses/events{/privacy}","received_events_url":"https://api.github.com/users/kontur-courses/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kontur-courses/di","description":null,"fork":false,"url":"https://api.github.com/repos/kontur-courses/di","forks_url":"https://api.github.com/repos/kontur-courses/di/forks","keys_url":"https://api.github.com/repos/kontur-courses/di/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontur-courses/di/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontur-courses/di/teams","hooks_url":"https://api.github.com/repos/kontur-courses/di/hooks","issue_events_url":"https://api.github.com/repos/kontur-courses/di/issues/events{/number}","events_url":"https://api.github.com/repos/kontur-courses/di/events","assignees_url":"https://api.github.com/repos/kontur-courses/di/assignees{/user}","branches_url":"https://api.github.com/repos/kontur-courses/di/branches{/branch}","tags_url":"https://api.github.com/repos/kontur-courses/di/tags","blobs_url":"https://api.github.com/repos/kontur-courses/di/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontur-courses/di/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontur-courses/di/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontur-courses/di/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontur-courses/di/statuses/{sha}","languages_url":"https://api.github.com/repos/kontur-courses/di/languages","stargazers_url":"https://api.github.com/repos/kontur-courses/di/stargazers","contributors_url":"https://api.github.com/repos/kontur-courses/di/contributors","subscribers_url":"https://api.github.com/repos/kontur-courses/di/subscribers","subscription_url":"https://api.github.com/repos/kontur-courses/di/subscription","commits_url":"https://api.github.com/repos/kontur-courses/di/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontur-courses/di/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontur-courses/di/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontur-courses/di/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontur-courses/di/contents/{+path}","compare_url":"https://api.github.com/repos/kontur-courses/di/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontur-courses/di/merges","archive_url":"https://api.github.com/repos/kontur-courses/di/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontur-courses/di/downloads","issues_url":"https://api.github.com/repos/kontur-courses/di/issues{/number}","pulls_url":"https://api.github.com/repos/kontur-courses/di/pulls{/number}","milestones_url":"https://api.github.com/repos/kontur-courses/di/milestones{/number}","notifications_url":"https://api.github.com/repos/kontur-courses/di/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontur-courses/di/labels{/name}","releases_url":"https://api.github.com/repos/kontur-courses/di/releases{/id}","deployments_url":"https://api.github.com/repos/kontur-courses/di/deployments","created_at":"2016-07-21T21:43:51Z","updated_at":"2019-12-05T15:20:20Z","pushed_at":"2019-12-11T17:55:18Z","git_url":"git://github.com/kontur-courses/di.git","ssh_url":"git@github.com:kontur-courses/di.git","clone_url":"https://github.com/kontur-courses/di.git","svn_url":"https://github.com/kontur-courses/di","homepage":null,"size":772,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":71,"license":null,"forks":142,"open_issues":71,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kontur-courses/di/pulls/43"},"html":{"href":"https://github.com/kontur-courses/di/pull/43"},"issue":{"href":"https://api.github.com/repos/kontur-courses/di/issues/43"},"comments":{"href":"https://api.github.com/repos/kontur-courses/di/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/kontur-courses/di/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/kontur-courses/di/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kontur-courses/di/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/kontur-courses/di/statuses/14dc87d3418336a9e187cd90a924d35227a9293d"}},"author_association":"NONE"}}
|
{
"id": 63904305,
"name": "kontur-courses/di",
"url": "https://api.github.com/repos/kontur-courses/di"
}
|
{
"id": 38423206,
"login": "Kamikoto-sama",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38423206?",
"url": "https://api.github.com/users/Kamikoto-sama"
}
|
{
"id": 19208073,
"login": "kontur-courses",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19208073?",
"url": "https://api.github.com/orgs/kontur-courses"
}
| 2019-12-11T18:07:24 |
11066826144
|
{"actor":{"display_login":"Kamikoto-sama"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nextcloud/news-android/pulls/comments/272739346","pull_request_review_id":223473309,"id":272739346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MjczOTM0Ng==","diff_hunk":"@@ -0,0 +1,102 @@\n+package de.luhmer.owncloudnewsreader.di;\n+\n+import android.content.Context;\n+import android.content.SharedPreferences;\n+import android.os.Looper;\n+import android.os.NetworkOnMainThreadException;\n+import android.util.Log;\n+\n+import com.nextcloud.android.sso.aidl.NextcloudRequest;\n+import com.nextcloud.android.sso.api.NetworkRequest;\n+import com.nextcloud.android.sso.api.NextcloudAPI;\n+import com.nextcloud.android.sso.exceptions.NextcloudHttpRequestFailedException;\n+\n+import org.mockito.Mockito;\n+\n+import java.io.ByteArrayInputStream;\n+import java.io.InputStream;\n+import java.nio.charset.Charset;\n+\n+import de.luhmer.owncloudnewsreader.helper.GsonConfig;\n+import de.luhmer.owncloudnewsreader.reader.nextcloud.API;\n+import de.luhmer.owncloudnewsreader.ssl.MemorizingTrustManager;\n+import retrofit2.NextcloudRetrofitApiBuilder;\n+\n+import static org.mockito.ArgumentMatchers.any;\n+\n+public class TestApiProvider extends ApiProvider {\n+\n+\n+ private static final String TAG = TestApiProvider.class.getCanonicalName();\n+\n+ public NewsTestNetworkRequest networkRequestSpy;\n+\n+ TestApiProvider(MemorizingTrustManager mtm, SharedPreferences sp, Context context) {\n+ super(mtm, sp, context);\n+ }\n+\n+ @Override\n+ protected void initSsoApi(final NextcloudAPI.ApiConnectedListener callback) {\n+ NewsTestNetworkRequest networkRequest = new NewsTestNetworkRequest(callback);\n+ networkRequestSpy = Mockito.spy(networkRequest);\n+\n+ // By spying on the method \"performNetworkRequest\" we can later check if requests were build correctly\n+ try {\n+ Mockito.doCallRealMethod().when(networkRequestSpy).performNetworkRequest(any(), any());\n+ } catch (Exception e) {\n+ e.printStackTrace();\n+ }\n+\n+ NextcloudAPI nextcloudAPI = new NextcloudAPI(GsonConfig.GetGson(), networkRequestSpy);\n+ mApi = new NextcloudRetrofitApiBuilder(nextcloudAPI, API.mApiEndpoint).create(API.class);\n+ }\n+\n+\n+ class NewsTestNetworkRequest extends NetworkRequest {\n+\n+ NewsTestNetworkRequest(NextcloudAPI.ApiConnectedListener callback) {\n+ super(null, null, callback);\n+ }\n+\n+ @Override\n+ public InputStream performNetworkRequest(NextcloudRequest request, InputStream requestBodyInputStream) throws Exception {\n+ if(Looper.myLooper() == Looper.getMainLooper()) {\n+ throw new NetworkOnMainThreadException();\n+ }\n+\n+ Log.e(TAG, \"Requested URL: \" + request.getUrl());\n+ InputStream inputStream = null;\n+ switch (request.getUrl()) {\n+ case \"/index.php/apps/news/api/v1-2/feeds\":\n+ inputStream = handleCreateFeed(request);\n+ break;\n+\n+ }\n+ return inputStream;\n+ }\n+\n+\n+ private final String NEW_FEED_SUCCESS = \"http://test.de/new\";\n+ private final String NEW_FEED_EXISTING = \"http://test.de/existing\";\n+ private final String NEW_FEED_FAIL = \"http://test.de/fail\";\n+ private final String NEW_FEED_EXISTING_ERROR_MESSAGE = \"{\\\"message\\\":\\\"Feed konnte nicht hinzugef\\\\u00fcgt werden: Existiert bereits\\\"}\";","path":"News-Android-App/src/androidTest/java/de/luhmer/owncloudnewsreader/di/TestApiProvider.java","position":82,"original_position":82,"commit_id":"d2abb52e012b4fb51bb26edbc4a2148b051dc6c1","original_commit_id":"d2abb52e012b4fb51bb26edbc4a2148b051dc6c1","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.](https://app.codacy.com/app/Nextcloud/news-android/pullRequest?prid=3353796)","created_at":"2019-04-05T20:49:19Z","updated_at":"2019-04-05T20:49:20Z","html_url":"https://github.com/nextcloud/news-android/pull/743#discussion_r272739346","pull_request_url":"https://api.github.com/repos/nextcloud/news-android/pulls/743","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nextcloud/news-android/pulls/comments/272739346"},"html":{"href":"https://github.com/nextcloud/news-android/pull/743#discussion_r272739346"},"pull_request":{"href":"https://api.github.com/repos/nextcloud/news-android/pulls/743"}}},"pull_request":{"url":"https://api.github.com/repos/nextcloud/news-android/pulls/743","id":265923815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1OTIzODE1","html_url":"https://github.com/nextcloud/news-android/pull/743","diff_url":"https://github.com/nextcloud/news-android/pull/743.diff","patch_url":"https://github.com/nextcloud/news-android/pull/743.patch","issue_url":"https://api.github.com/repos/nextcloud/news-android/issues/743","number":743,"state":"open","locked":false,"title":"[WIP] Update to androidx","user":{"login":"David-Development","id":4489723,"node_id":"MDQ6VXNlcjQ0ODk3MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4489723?v=4","gravatar_id":"","url":"https://api.github.com/users/David-Development","html_url":"https://github.com/David-Development","followers_url":"https://api.github.com/users/David-Development/followers","following_url":"https://api.github.com/users/David-Development/following{/other_user}","gists_url":"https://api.github.com/users/David-Development/gists{/gist_id}","starred_url":"https://api.github.com/users/David-Development/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/David-Development/subscriptions","organizations_url":"https://api.github.com/users/David-Development/orgs","repos_url":"https://api.github.com/users/David-Development/repos","events_url":"https://api.github.com/users/David-Development/events{/privacy}","received_events_url":"https://api.github.com/users/David-Development/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-30T08:08:00Z","updated_at":"2019-04-05T20:49:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd80f7469cc5b7d63b511bba5c8d145b801c3c1b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nextcloud/news-android/pulls/743/commits","review_comments_url":"https://api.github.com/repos/nextcloud/news-android/pulls/743/comments","review_comment_url":"https://api.github.com/repos/nextcloud/news-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/news-android/issues/743/comments","statuses_url":"https://api.github.com/repos/nextcloud/news-android/statuses/d2abb52e012b4fb51bb26edbc4a2148b051dc6c1","head":{"label":"nextcloud:androidx","ref":"androidx","sha":"d2abb52e012b4fb51bb26edbc4a2148b051dc6c1","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":10296149,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5NjE0OQ==","name":"news-android","full_name":"nextcloud/news-android","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/news-android","description":"📱:newspaper: Android client for the Nextcloud news/feed reader app","fork":false,"url":"https://api.github.com/repos/nextcloud/news-android","forks_url":"https://api.github.com/repos/nextcloud/news-android/forks","keys_url":"https://api.github.com/repos/nextcloud/news-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/news-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/news-android/teams","hooks_url":"https://api.github.com/repos/nextcloud/news-android/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/news-android/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/news-android/events","assignees_url":"https://api.github.com/repos/nextcloud/news-android/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/news-android/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/news-android/tags","blobs_url":"https://api.github.com/repos/nextcloud/news-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/news-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/news-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/news-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/news-android/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/news-android/languages","stargazers_url":"https://api.github.com/repos/nextcloud/news-android/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/news-android/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/news-android/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/news-android/subscription","commits_url":"https://api.github.com/repos/nextcloud/news-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/news-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/news-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/news-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/news-android/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/news-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/news-android/merges","archive_url":"https://api.github.com/repos/nextcloud/news-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/news-android/downloads","issues_url":"https://api.github.com/repos/nextcloud/news-android/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/news-android/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/news-android/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/news-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/news-android/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/news-android/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/news-android/deployments","created_at":"2013-05-26T09:54:08Z","updated_at":"2019-04-05T08:21:10Z","pushed_at":"2019-04-05T20:28:06Z","git_url":"git://github.com/nextcloud/news-android.git","ssh_url":"git@github.com:nextcloud/news-android.git","clone_url":"https://github.com/nextcloud/news-android.git","svn_url":"https://github.com/nextcloud/news-android","homepage":"https://play.google.com/store/apps/details?id=de.luhmer.owncloudnewsreader","size":197536,"stargazers_count":404,"watchers_count":404,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":201,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":201,"open_issues":75,"watchers":404,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"938a7ec07c1c682ee58553bca041828cba559bb0","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":10296149,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5NjE0OQ==","name":"news-android","full_name":"nextcloud/news-android","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/news-android","description":"📱:newspaper: Android client for the Nextcloud news/feed reader app","fork":false,"url":"https://api.github.com/repos/nextcloud/news-android","forks_url":"https://api.github.com/repos/nextcloud/news-android/forks","keys_url":"https://api.github.com/repos/nextcloud/news-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/news-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/news-android/teams","hooks_url":"https://api.github.com/repos/nextcloud/news-android/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/news-android/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/news-android/events","assignees_url":"https://api.github.com/repos/nextcloud/news-android/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/news-android/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/news-android/tags","blobs_url":"https://api.github.com/repos/nextcloud/news-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/news-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/news-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/news-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/news-android/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/news-android/languages","stargazers_url":"https://api.github.com/repos/nextcloud/news-android/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/news-android/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/news-android/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/news-android/subscription","commits_url":"https://api.github.com/repos/nextcloud/news-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/news-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/news-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/news-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/news-android/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/news-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/news-android/merges","archive_url":"https://api.github.com/repos/nextcloud/news-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/news-android/downloads","issues_url":"https://api.github.com/repos/nextcloud/news-android/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/news-android/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/news-android/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/news-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/news-android/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/news-android/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/news-android/deployments","created_at":"2013-05-26T09:54:08Z","updated_at":"2019-04-05T08:21:10Z","pushed_at":"2019-04-05T20:28:06Z","git_url":"git://github.com/nextcloud/news-android.git","ssh_url":"git@github.com:nextcloud/news-android.git","clone_url":"https://github.com/nextcloud/news-android.git","svn_url":"https://github.com/nextcloud/news-android","homepage":"https://play.google.com/store/apps/details?id=de.luhmer.owncloudnewsreader","size":197536,"stargazers_count":404,"watchers_count":404,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":201,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":201,"open_issues":75,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/news-android/pulls/743"},"html":{"href":"https://github.com/nextcloud/news-android/pull/743"},"issue":{"href":"https://api.github.com/repos/nextcloud/news-android/issues/743"},"comments":{"href":"https://api.github.com/repos/nextcloud/news-android/issues/743/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/news-android/pulls/743/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/news-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/news-android/pulls/743/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/news-android/statuses/d2abb52e012b4fb51bb26edbc4a2148b051dc6c1"}},"author_association":"MEMBER"}}
|
{
"id": 10296149,
"name": "nextcloud/news-android",
"url": "https://api.github.com/repos/nextcloud/news-android"
}
|
{
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
}
|
{
"id": 19211038,
"login": "nextcloud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19211038?",
"url": "https://api.github.com/orgs/nextcloud"
}
| 2019-04-05T20:49:19 |
9389183630
|
{"actor":{"display_login":"codacy-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nextcloud/server/pulls/comments/336761473","pull_request_review_id":304240003,"id":336761473,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjc2MTQ3Mw==","diff_hunk":"@@ -5,16 +5,18 @@ labels: enhancement, 0. Needs triage\n ---\r\n \r\n <!--\r\n-Thanks for reporting issues back to Nextcloud! This is the issue tracker of Nextcloud, if you have any support question please check out https://nextcloud.com/support\r\n+Thanks for reporting issues back to Nextcloud!\r\n+\r\n+Note: This is the **issue tracker of Nextcloud**, please do NOT use this to get answers to your questions or get help for fixing your installation. This is a place to report bugs to developers, after your server has been debugged. You can find help debugging your system on our home user forums: https://help.nextcloud.com or, if you use Nextcloud in a large organization, ask our engineers on https://portal.nextcloud.com. See also https://nextcloud.com/support for support options.\r\n \r\n This is the bug tracker for the Server component. Find other components at https://github.com/nextcloud/\r\n \r\n For reporting potential security issues please see https://nextcloud.com/security/\r\n \r\n-To make it possible for us to help you please fill out below information carefully. \r\n+To make it possible for us to deal with the bug please fill out below information carefully. \r","path":".github/ISSUE_TEMPLATE/Feature_request.md","position":14,"original_position":14,"commit_id":"5b44cb57a589822b8ea66328690c4f75de8eca6c","original_commit_id":"5b44cb57a589822b8ea66328690c4f75de8eca6c","user":{"login":"gary-kim","id":47195730,"node_id":"MDQ6VXNlcjQ3MTk1NzMw","avatar_url":"https://avatars1.githubusercontent.com/u/47195730?v=4","gravatar_id":"","url":"https://api.github.com/users/gary-kim","html_url":"https://github.com/gary-kim","followers_url":"https://api.github.com/users/gary-kim/followers","following_url":"https://api.github.com/users/gary-kim/following{/other_user}","gists_url":"https://api.github.com/users/gary-kim/gists{/gist_id}","starred_url":"https://api.github.com/users/gary-kim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gary-kim/subscriptions","organizations_url":"https://api.github.com/users/gary-kim/orgs","repos_url":"https://api.github.com/users/gary-kim/repos","events_url":"https://api.github.com/users/gary-kim/events{/privacy}","received_events_url":"https://api.github.com/users/gary-kim/received_events","type":"User","site_admin":false},"body":"How about something like this:\r\n```suggestion\r\nTo make it possible for us to best accommodate your use case, please fill out the information below carefully. \r\n```","created_at":"2019-10-20T03:15:12Z","updated_at":"2019-10-20T03:15:13Z","html_url":"https://github.com/nextcloud/server/pull/17564#discussion_r336761473","pull_request_url":"https://api.github.com/repos/nextcloud/server/pulls/17564","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments/336761473"},"html":{"href":"https://github.com/nextcloud/server/pull/17564#discussion_r336761473"},"pull_request":{"href":"https://api.github.com/repos/nextcloud/server/pulls/17564"}},"in_reply_to_id":336448793},"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/17564","id":328691256,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4NjkxMjU2","html_url":"https://github.com/nextcloud/server/pull/17564","diff_url":"https://github.com/nextcloud/server/pull/17564.diff","patch_url":"https://github.com/nextcloud/server/pull/17564.patch","issue_url":"https://api.github.com/repos/nextcloud/server/issues/17564","number":17564,"state":"open","locked":false,"title":"Update Feature_request.md","user":{"login":"kesselb","id":3902676,"node_id":"MDQ6VXNlcjM5MDI2NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3902676?v=4","gravatar_id":"","url":"https://api.github.com/users/kesselb","html_url":"https://github.com/kesselb","followers_url":"https://api.github.com/users/kesselb/followers","following_url":"https://api.github.com/users/kesselb/following{/other_user}","gists_url":"https://api.github.com/users/kesselb/gists{/gist_id}","starred_url":"https://api.github.com/users/kesselb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kesselb/subscriptions","organizations_url":"https://api.github.com/users/kesselb/orgs","repos_url":"https://api.github.com/users/kesselb/repos","events_url":"https://api.github.com/users/kesselb/events{/privacy}","received_events_url":"https://api.github.com/users/kesselb/received_events","type":"User","site_admin":false},"body":"Does not fit 100% to feature request but does not hurt.","created_at":"2019-10-16T10:42:07Z","updated_at":"2019-10-20T03:15:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"142197f4699d61a9674e48e4d4eb6e851a721e11","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jospoortvliet","id":551757,"node_id":"MDQ6VXNlcjU1MTc1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/551757?v=4","gravatar_id":"","url":"https://api.github.com/users/jospoortvliet","html_url":"https://github.com/jospoortvliet","followers_url":"https://api.github.com/users/jospoortvliet/followers","following_url":"https://api.github.com/users/jospoortvliet/following{/other_user}","gists_url":"https://api.github.com/users/jospoortvliet/gists{/gist_id}","starred_url":"https://api.github.com/users/jospoortvliet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jospoortvliet/subscriptions","organizations_url":"https://api.github.com/users/jospoortvliet/orgs","repos_url":"https://api.github.com/users/jospoortvliet/repos","events_url":"https://api.github.com/users/jospoortvliet/events{/privacy}","received_events_url":"https://api.github.com/users/jospoortvliet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nextcloud/server/pulls/17564/commits","review_comments_url":"https://api.github.com/repos/nextcloud/server/pulls/17564/comments","review_comment_url":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/17564/comments","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/5b44cb57a589822b8ea66328690c4f75de8eca6c","head":{"label":"nextcloud:kesselb-patch-1-1","ref":"kesselb-patch-1-1","sha":"5b44cb57a589822b8ea66328690c4f75de8eca6c","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2019-10-20T02:31:57Z","pushed_at":"2019-10-20T02:17:08Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":521247,"stargazers_count":8680,"watchers_count":8680,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1557,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2119,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1557,"open_issues":2119,"watchers":8680,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"f7319e139dfcfcd6309ce94cb514ebb58a4b49ad","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2019-10-20T02:31:57Z","pushed_at":"2019-10-20T02:17:08Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":521247,"stargazers_count":8680,"watchers_count":8680,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1557,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2119,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1557,"open_issues":2119,"watchers":8680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/17564"},"html":{"href":"https://github.com/nextcloud/server/pull/17564"},"issue":{"href":"https://api.github.com/repos/nextcloud/server/issues/17564"},"comments":{"href":"https://api.github.com/repos/nextcloud/server/issues/17564/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/server/pulls/17564/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/server/pulls/17564/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/server/statuses/5b44cb57a589822b8ea66328690c4f75de8eca6c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 60243197,
"name": "nextcloud/server",
"url": "https://api.github.com/repos/nextcloud/server"
}
|
{
"id": 47195730,
"login": "gary-kim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47195730?",
"url": "https://api.github.com/users/gary-kim"
}
|
{
"id": 19211038,
"login": "nextcloud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19211038?",
"url": "https://api.github.com/orgs/nextcloud"
}
| 2019-10-20T03:15:12 |
10669237782
|
{"actor":{"display_login":"gary-kim"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/qri-io/registry/pulls/comments/254405527","pull_request_review_id":200747418,"id":254405527,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDQwNTUyNw==","diff_hunk":"@@ -156,11 +154,15 @@ func (c Client) statusPoll(path string, interval time.Duration) (updates chan pi\n \t\t\t\tstatus, err := c.Status(path)\n \t\t\t\tif err != nil {\n \t\t\t\t\tstatus.Error = err.Error()\n+\t\t\t\t\tgo done()\n \t\t\t\t}\n \t\t\t\tupdates <- status\n+\t\t\t\tif status.Pinned == true {","path":"regclient/pin.go","position":41,"original_position":41,"commit_id":"80535be8b2c78d595b1f3e189d3975bfd9167276","original_commit_id":"80535be8b2c78d595b1f3e189d3975bfd9167276","user":{"login":"dustmop","id":2515490,"node_id":"MDQ6VXNlcjI1MTU0OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2515490?v=4","gravatar_id":"","url":"https://api.github.com/users/dustmop","html_url":"https://github.com/dustmop","followers_url":"https://api.github.com/users/dustmop/followers","following_url":"https://api.github.com/users/dustmop/following{/other_user}","gists_url":"https://api.github.com/users/dustmop/gists{/gist_id}","starred_url":"https://api.github.com/users/dustmop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustmop/subscriptions","organizations_url":"https://api.github.com/users/dustmop/orgs","repos_url":"https://api.github.com/users/dustmop/repos","events_url":"https://api.github.com/users/dustmop/events{/privacy}","received_events_url":"https://api.github.com/users/dustmop/received_events","type":"User","site_admin":false},"body":"`if status.Pinned {` instead","created_at":"2019-02-06T18:58:36Z","updated_at":"2019-02-06T18:58:46Z","html_url":"https://github.com/qri-io/registry/pull/26#discussion_r254405527","pull_request_url":"https://api.github.com/repos/qri-io/registry/pulls/26","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/qri-io/registry/pulls/comments/254405527"},"html":{"href":"https://github.com/qri-io/registry/pull/26#discussion_r254405527"},"pull_request":{"href":"https://api.github.com/repos/qri-io/registry/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/qri-io/registry/pulls/26","id":250868885,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwODY4ODg1","html_url":"https://github.com/qri-io/registry/pull/26","diff_url":"https://github.com/qri-io/registry/pull/26.diff","patch_url":"https://github.com/qri-io/registry/pull/26.patch","issue_url":"https://api.github.com/repos/qri-io/registry/issues/26","number":26,"state":"open","locked":false,"title":"fix(pin status polling): fix defer/goroutine deadlock","user":{"login":"b5","id":1154390,"node_id":"MDQ6VXNlcjExNTQzOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1154390?v=4","gravatar_id":"","url":"https://api.github.com/users/b5","html_url":"https://github.com/b5","followers_url":"https://api.github.com/users/b5/followers","following_url":"https://api.github.com/users/b5/following{/other_user}","gists_url":"https://api.github.com/users/b5/gists{/gist_id}","starred_url":"https://api.github.com/users/b5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b5/subscriptions","organizations_url":"https://api.github.com/users/b5/orgs","repos_url":"https://api.github.com/users/b5/repos","events_url":"https://api.github.com/users/b5/events{/privacy}","received_events_url":"https://api.github.com/users/b5/received_events","type":"User","site_admin":false},"body":"This is what's making `qri publish` hang.\r\n\r\nTurns out closing a channel in a defer statement is a great way to mess everything up. reworked logic to make this more sensible.","created_at":"2019-02-06T18:56:06Z","updated_at":"2019-02-06T18:58:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"946ab42c3036c3b70cd3c9aebba857f5f8f16c6c","assignee":{"login":"b5","id":1154390,"node_id":"MDQ6VXNlcjExNTQzOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1154390?v=4","gravatar_id":"","url":"https://api.github.com/users/b5","html_url":"https://github.com/b5","followers_url":"https://api.github.com/users/b5/followers","following_url":"https://api.github.com/users/b5/following{/other_user}","gists_url":"https://api.github.com/users/b5/gists{/gist_id}","starred_url":"https://api.github.com/users/b5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b5/subscriptions","organizations_url":"https://api.github.com/users/b5/orgs","repos_url":"https://api.github.com/users/b5/repos","events_url":"https://api.github.com/users/b5/events{/privacy}","received_events_url":"https://api.github.com/users/b5/received_events","type":"User","site_admin":false},"assignees":[{"login":"b5","id":1154390,"node_id":"MDQ6VXNlcjExNTQzOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1154390?v=4","gravatar_id":"","url":"https://api.github.com/users/b5","html_url":"https://github.com/b5","followers_url":"https://api.github.com/users/b5/followers","following_url":"https://api.github.com/users/b5/following{/other_user}","gists_url":"https://api.github.com/users/b5/gists{/gist_id}","starred_url":"https://api.github.com/users/b5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b5/subscriptions","organizations_url":"https://api.github.com/users/b5/orgs","repos_url":"https://api.github.com/users/b5/repos","events_url":"https://api.github.com/users/b5/events{/privacy}","received_events_url":"https://api.github.com/users/b5/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ramfox","id":17440142,"node_id":"MDQ6VXNlcjE3NDQwMTQy","avatar_url":"https://avatars0.githubusercontent.com/u/17440142?v=4","gravatar_id":"","url":"https://api.github.com/users/ramfox","html_url":"https://github.com/ramfox","followers_url":"https://api.github.com/users/ramfox/followers","following_url":"https://api.github.com/users/ramfox/following{/other_user}","gists_url":"https://api.github.com/users/ramfox/gists{/gist_id}","starred_url":"https://api.github.com/users/ramfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramfox/subscriptions","organizations_url":"https://api.github.com/users/ramfox/orgs","repos_url":"https://api.github.com/users/ramfox/repos","events_url":"https://api.github.com/users/ramfox/events{/privacy}","received_events_url":"https://api.github.com/users/ramfox/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1130185541,"node_id":"MDU6TGFiZWwxMTMwMTg1NTQx","url":"https://api.github.com/repos/qri-io/registry/labels/fix","name":"fix","color":"1d76db","default":false},{"id":900826390,"node_id":"MDU6TGFiZWw5MDA4MjYzOTA=","url":"https://api.github.com/repos/qri-io/registry/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/qri-io/registry/pulls/26/commits","review_comments_url":"https://api.github.com/repos/qri-io/registry/pulls/26/comments","review_comment_url":"https://api.github.com/repos/qri-io/registry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qri-io/registry/issues/26/comments","statuses_url":"https://api.github.com/repos/qri-io/registry/statuses/80535be8b2c78d595b1f3e189d3975bfd9167276","head":{"label":"qri-io:fix_pin_polling","ref":"fix_pin_polling","sha":"80535be8b2c78d595b1f3e189d3975bfd9167276","user":{"login":"qri-io","id":19268065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjY4MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/19268065?v=4","gravatar_id":"","url":"https://api.github.com/users/qri-io","html_url":"https://github.com/qri-io","followers_url":"https://api.github.com/users/qri-io/followers","following_url":"https://api.github.com/users/qri-io/following{/other_user}","gists_url":"https://api.github.com/users/qri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/qri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qri-io/subscriptions","organizations_url":"https://api.github.com/users/qri-io/orgs","repos_url":"https://api.github.com/users/qri-io/repos","events_url":"https://api.github.com/users/qri-io/events{/privacy}","received_events_url":"https://api.github.com/users/qri-io/received_events","type":"Organization","site_admin":false},"repo":{"id":129295668,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyOTU2Njg=","name":"registry","full_name":"qri-io/registry","private":false,"owner":{"login":"qri-io","id":19268065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjY4MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/19268065?v=4","gravatar_id":"","url":"https://api.github.com/users/qri-io","html_url":"https://github.com/qri-io","followers_url":"https://api.github.com/users/qri-io/followers","following_url":"https://api.github.com/users/qri-io/following{/other_user}","gists_url":"https://api.github.com/users/qri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/qri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qri-io/subscriptions","organizations_url":"https://api.github.com/users/qri-io/orgs","repos_url":"https://api.github.com/users/qri-io/repos","events_url":"https://api.github.com/users/qri-io/events{/privacy}","received_events_url":"https://api.github.com/users/qri-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qri-io/registry","description":"centralized repositories of decentralized stuff","fork":false,"url":"https://api.github.com/repos/qri-io/registry","forks_url":"https://api.github.com/repos/qri-io/registry/forks","keys_url":"https://api.github.com/repos/qri-io/registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qri-io/registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qri-io/registry/teams","hooks_url":"https://api.github.com/repos/qri-io/registry/hooks","issue_events_url":"https://api.github.com/repos/qri-io/registry/issues/events{/number}","events_url":"https://api.github.com/repos/qri-io/registry/events","assignees_url":"https://api.github.com/repos/qri-io/registry/assignees{/user}","branches_url":"https://api.github.com/repos/qri-io/registry/branches{/branch}","tags_url":"https://api.github.com/repos/qri-io/registry/tags","blobs_url":"https://api.github.com/repos/qri-io/registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qri-io/registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qri-io/registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/qri-io/registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qri-io/registry/statuses/{sha}","languages_url":"https://api.github.com/repos/qri-io/registry/languages","stargazers_url":"https://api.github.com/repos/qri-io/registry/stargazers","contributors_url":"https://api.github.com/repos/qri-io/registry/contributors","subscribers_url":"https://api.github.com/repos/qri-io/registry/subscribers","subscription_url":"https://api.github.com/repos/qri-io/registry/subscription","commits_url":"https://api.github.com/repos/qri-io/registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/qri-io/registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/qri-io/registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/qri-io/registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/qri-io/registry/contents/{+path}","compare_url":"https://api.github.com/repos/qri-io/registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qri-io/registry/merges","archive_url":"https://api.github.com/repos/qri-io/registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qri-io/registry/downloads","issues_url":"https://api.github.com/repos/qri-io/registry/issues{/number}","pulls_url":"https://api.github.com/repos/qri-io/registry/pulls{/number}","milestones_url":"https://api.github.com/repos/qri-io/registry/milestones{/number}","notifications_url":"https://api.github.com/repos/qri-io/registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qri-io/registry/labels{/name}","releases_url":"https://api.github.com/repos/qri-io/registry/releases{/id}","deployments_url":"https://api.github.com/repos/qri-io/registry/deployments","created_at":"2018-04-12T18:37:00Z","updated_at":"2019-02-03T11:20:33Z","pushed_at":"2019-02-06T18:56:06Z","git_url":"git://github.com/qri-io/registry.git","ssh_url":"git@github.com:qri-io/registry.git","clone_url":"https://github.com/qri-io/registry.git","svn_url":"https://github.com/qri-io/registry","homepage":null,"size":177,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"qri-io:master","ref":"master","sha":"85c71f9143207507289cf4e922fad10373fc07fc","user":{"login":"qri-io","id":19268065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjY4MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/19268065?v=4","gravatar_id":"","url":"https://api.github.com/users/qri-io","html_url":"https://github.com/qri-io","followers_url":"https://api.github.com/users/qri-io/followers","following_url":"https://api.github.com/users/qri-io/following{/other_user}","gists_url":"https://api.github.com/users/qri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/qri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qri-io/subscriptions","organizations_url":"https://api.github.com/users/qri-io/orgs","repos_url":"https://api.github.com/users/qri-io/repos","events_url":"https://api.github.com/users/qri-io/events{/privacy}","received_events_url":"https://api.github.com/users/qri-io/received_events","type":"Organization","site_admin":false},"repo":{"id":129295668,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyOTU2Njg=","name":"registry","full_name":"qri-io/registry","private":false,"owner":{"login":"qri-io","id":19268065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjY4MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/19268065?v=4","gravatar_id":"","url":"https://api.github.com/users/qri-io","html_url":"https://github.com/qri-io","followers_url":"https://api.github.com/users/qri-io/followers","following_url":"https://api.github.com/users/qri-io/following{/other_user}","gists_url":"https://api.github.com/users/qri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/qri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qri-io/subscriptions","organizations_url":"https://api.github.com/users/qri-io/orgs","repos_url":"https://api.github.com/users/qri-io/repos","events_url":"https://api.github.com/users/qri-io/events{/privacy}","received_events_url":"https://api.github.com/users/qri-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qri-io/registry","description":"centralized repositories of decentralized stuff","fork":false,"url":"https://api.github.com/repos/qri-io/registry","forks_url":"https://api.github.com/repos/qri-io/registry/forks","keys_url":"https://api.github.com/repos/qri-io/registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qri-io/registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qri-io/registry/teams","hooks_url":"https://api.github.com/repos/qri-io/registry/hooks","issue_events_url":"https://api.github.com/repos/qri-io/registry/issues/events{/number}","events_url":"https://api.github.com/repos/qri-io/registry/events","assignees_url":"https://api.github.com/repos/qri-io/registry/assignees{/user}","branches_url":"https://api.github.com/repos/qri-io/registry/branches{/branch}","tags_url":"https://api.github.com/repos/qri-io/registry/tags","blobs_url":"https://api.github.com/repos/qri-io/registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qri-io/registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qri-io/registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/qri-io/registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qri-io/registry/statuses/{sha}","languages_url":"https://api.github.com/repos/qri-io/registry/languages","stargazers_url":"https://api.github.com/repos/qri-io/registry/stargazers","contributors_url":"https://api.github.com/repos/qri-io/registry/contributors","subscribers_url":"https://api.github.com/repos/qri-io/registry/subscribers","subscription_url":"https://api.github.com/repos/qri-io/registry/subscription","commits_url":"https://api.github.com/repos/qri-io/registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/qri-io/registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/qri-io/registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/qri-io/registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/qri-io/registry/contents/{+path}","compare_url":"https://api.github.com/repos/qri-io/registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qri-io/registry/merges","archive_url":"https://api.github.com/repos/qri-io/registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qri-io/registry/downloads","issues_url":"https://api.github.com/repos/qri-io/registry/issues{/number}","pulls_url":"https://api.github.com/repos/qri-io/registry/pulls{/number}","milestones_url":"https://api.github.com/repos/qri-io/registry/milestones{/number}","notifications_url":"https://api.github.com/repos/qri-io/registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qri-io/registry/labels{/name}","releases_url":"https://api.github.com/repos/qri-io/registry/releases{/id}","deployments_url":"https://api.github.com/repos/qri-io/registry/deployments","created_at":"2018-04-12T18:37:00Z","updated_at":"2019-02-03T11:20:33Z","pushed_at":"2019-02-06T18:56:06Z","git_url":"git://github.com/qri-io/registry.git","ssh_url":"git@github.com:qri-io/registry.git","clone_url":"https://github.com/qri-io/registry.git","svn_url":"https://github.com/qri-io/registry","homepage":null,"size":177,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qri-io/registry/pulls/26"},"html":{"href":"https://github.com/qri-io/registry/pull/26"},"issue":{"href":"https://api.github.com/repos/qri-io/registry/issues/26"},"comments":{"href":"https://api.github.com/repos/qri-io/registry/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/qri-io/registry/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/qri-io/registry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qri-io/registry/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/qri-io/registry/statuses/80535be8b2c78d595b1f3e189d3975bfd9167276"}},"author_association":"MEMBER"}}
|
{
"id": 129295668,
"name": "qri-io/registry",
"url": "https://api.github.com/repos/qri-io/registry"
}
|
{
"id": 2515490,
"login": "dustmop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2515490?",
"url": "https://api.github.com/users/dustmop"
}
|
{
"id": 19268065,
"login": "qri-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19268065?",
"url": "https://api.github.com/orgs/qri-io"
}
| 2019-02-06T18:58:36 |
9020426662
|
{"actor":{"display_login":"dustmop"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/quadrama/Corpus/pulls/comments/266836139","pull_request_review_id":216090792,"id":266836139,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjgzNjEzOQ==","diff_hunk":"@@ -1001,8 +1001,8 @@\n <l> Wen denn?</l>\n <pb n=\"141\"/>\n </sp>\n- <sp who=\"#guhli\">\n- <speaker>GUHLI.</speaker>\n+ <sp who=\"#gurli\">\n+ <speaker>GURLI.</speaker>","path":"tei/r2mn.0.xml","position":16,"original_position":16,"commit_id":"055d7c89614758765f25bff91165ae4d774eac6b","original_commit_id":"055d7c89614758765f25bff91165ae4d774eac6b","user":{"login":"pagelj","id":12445355,"node_id":"MDQ6VXNlcjEyNDQ1MzU1","avatar_url":"https://avatars2.githubusercontent.com/u/12445355?v=4","gravatar_id":"","url":"https://api.github.com/users/pagelj","html_url":"https://github.com/pagelj","followers_url":"https://api.github.com/users/pagelj/followers","following_url":"https://api.github.com/users/pagelj/following{/other_user}","gists_url":"https://api.github.com/users/pagelj/gists{/gist_id}","starred_url":"https://api.github.com/users/pagelj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagelj/subscriptions","organizations_url":"https://api.github.com/users/pagelj/orgs","repos_url":"https://api.github.com/users/pagelj/repos","events_url":"https://api.github.com/users/pagelj/events{/privacy}","received_events_url":"https://api.github.com/users/pagelj/received_events","type":"User","site_admin":false},"body":"@leaduempelmann Wenn Speaker-Tags Fehler ausweisen, wird das in `<listPerson>` abgefangen. In diesem Fall sieht das z.B. so aus:\r\n```\r\n<person xml:id=\"gurli\">\r\n<persName>GURLI</persName>\r\n<persName xml:id=\"guhli\">GUHLI</persName>\r\n</person>\r\n```","created_at":"2019-03-19T11:13:18Z","updated_at":"2019-03-19T11:13:19Z","html_url":"https://github.com/quadrama/Corpus/pull/16#discussion_r266836139","pull_request_url":"https://api.github.com/repos/quadrama/Corpus/pulls/16","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/quadrama/Corpus/pulls/comments/266836139"},"html":{"href":"https://github.com/quadrama/Corpus/pull/16#discussion_r266836139"},"pull_request":{"href":"https://api.github.com/repos/quadrama/Corpus/pulls/16"}},"in_reply_to_id":266748833},"pull_request":{"url":"https://api.github.com/repos/quadrama/Corpus/pulls/16","id":260364805,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwMzY0ODA1","html_url":"https://github.com/quadrama/Corpus/pull/16","diff_url":"https://github.com/quadrama/Corpus/pull/16.diff","patch_url":"https://github.com/quadrama/Corpus/pull/16.patch","issue_url":"https://api.github.com/repos/quadrama/Corpus/issues/16","number":16,"state":"open","locked":false,"title":"Korrekturen und Einfügungen tags ","user":{"login":"leaduempelmann","id":47987900,"node_id":"MDQ6VXNlcjQ3OTg3OTAw","avatar_url":"https://avatars0.githubusercontent.com/u/47987900?v=4","gravatar_id":"","url":"https://api.github.com/users/leaduempelmann","html_url":"https://github.com/leaduempelmann","followers_url":"https://api.github.com/users/leaduempelmann/followers","following_url":"https://api.github.com/users/leaduempelmann/following{/other_user}","gists_url":"https://api.github.com/users/leaduempelmann/gists{/gist_id}","starred_url":"https://api.github.com/users/leaduempelmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leaduempelmann/subscriptions","organizations_url":"https://api.github.com/users/leaduempelmann/orgs","repos_url":"https://api.github.com/users/leaduempelmann/repos","events_url":"https://api.github.com/users/leaduempelmann/events{/privacy}","received_events_url":"https://api.github.com/users/leaduempelmann/received_events","type":"User","site_admin":false},"body":"issue #15","created_at":"2019-03-12T13:33:46Z","updated_at":"2019-03-19T11:13:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ff4bfe7db3f582a19af3e4ef8b36082b594775","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/quadrama/Corpus/pulls/16/commits","review_comments_url":"https://api.github.com/repos/quadrama/Corpus/pulls/16/comments","review_comment_url":"https://api.github.com/repos/quadrama/Corpus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quadrama/Corpus/issues/16/comments","statuses_url":"https://api.github.com/repos/quadrama/Corpus/statuses/055d7c89614758765f25bff91165ae4d774eac6b","head":{"label":"quadrama:leatwt3.0","ref":"leatwt3.0","sha":"055d7c89614758765f25bff91165ae4d774eac6b","user":{"login":"quadrama","id":19320828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzIwODI4","avatar_url":"https://avatars2.githubusercontent.com/u/19320828?v=4","gravatar_id":"","url":"https://api.github.com/users/quadrama","html_url":"https://github.com/quadrama","followers_url":"https://api.github.com/users/quadrama/followers","following_url":"https://api.github.com/users/quadrama/following{/other_user}","gists_url":"https://api.github.com/users/quadrama/gists{/gist_id}","starred_url":"https://api.github.com/users/quadrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quadrama/subscriptions","organizations_url":"https://api.github.com/users/quadrama/orgs","repos_url":"https://api.github.com/users/quadrama/repos","events_url":"https://api.github.com/users/quadrama/events{/privacy}","received_events_url":"https://api.github.com/users/quadrama/received_events","type":"Organization","site_admin":false},"repo":{"id":126166428,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxNjY0Mjg=","name":"Corpus","full_name":"quadrama/Corpus","private":false,"owner":{"login":"quadrama","id":19320828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzIwODI4","avatar_url":"https://avatars2.githubusercontent.com/u/19320828?v=4","gravatar_id":"","url":"https://api.github.com/users/quadrama","html_url":"https://github.com/quadrama","followers_url":"https://api.github.com/users/quadrama/followers","following_url":"https://api.github.com/users/quadrama/following{/other_user}","gists_url":"https://api.github.com/users/quadrama/gists{/gist_id}","starred_url":"https://api.github.com/users/quadrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quadrama/subscriptions","organizations_url":"https://api.github.com/users/quadrama/orgs","repos_url":"https://api.github.com/users/quadrama/repos","events_url":"https://api.github.com/users/quadrama/events{/privacy}","received_events_url":"https://api.github.com/users/quadrama/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/quadrama/Corpus","description":"The main quadrama corpus","fork":false,"url":"https://api.github.com/repos/quadrama/Corpus","forks_url":"https://api.github.com/repos/quadrama/Corpus/forks","keys_url":"https://api.github.com/repos/quadrama/Corpus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quadrama/Corpus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quadrama/Corpus/teams","hooks_url":"https://api.github.com/repos/quadrama/Corpus/hooks","issue_events_url":"https://api.github.com/repos/quadrama/Corpus/issues/events{/number}","events_url":"https://api.github.com/repos/quadrama/Corpus/events","assignees_url":"https://api.github.com/repos/quadrama/Corpus/assignees{/user}","branches_url":"https://api.github.com/repos/quadrama/Corpus/branches{/branch}","tags_url":"https://api.github.com/repos/quadrama/Corpus/tags","blobs_url":"https://api.github.com/repos/quadrama/Corpus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quadrama/Corpus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quadrama/Corpus/git/refs{/sha}","trees_url":"https://api.github.com/repos/quadrama/Corpus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quadrama/Corpus/statuses/{sha}","languages_url":"https://api.github.com/repos/quadrama/Corpus/languages","stargazers_url":"https://api.github.com/repos/quadrama/Corpus/stargazers","contributors_url":"https://api.github.com/repos/quadrama/Corpus/contributors","subscribers_url":"https://api.github.com/repos/quadrama/Corpus/subscribers","subscription_url":"https://api.github.com/repos/quadrama/Corpus/subscription","commits_url":"https://api.github.com/repos/quadrama/Corpus/commits{/sha}","git_commits_url":"https://api.github.com/repos/quadrama/Corpus/git/commits{/sha}","comments_url":"https://api.github.com/repos/quadrama/Corpus/comments{/number}","issue_comment_url":"https://api.github.com/repos/quadrama/Corpus/issues/comments{/number}","contents_url":"https://api.github.com/repos/quadrama/Corpus/contents/{+path}","compare_url":"https://api.github.com/repos/quadrama/Corpus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quadrama/Corpus/merges","archive_url":"https://api.github.com/repos/quadrama/Corpus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quadrama/Corpus/downloads","issues_url":"https://api.github.com/repos/quadrama/Corpus/issues{/number}","pulls_url":"https://api.github.com/repos/quadrama/Corpus/pulls{/number}","milestones_url":"https://api.github.com/repos/quadrama/Corpus/milestones{/number}","notifications_url":"https://api.github.com/repos/quadrama/Corpus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quadrama/Corpus/labels{/name}","releases_url":"https://api.github.com/repos/quadrama/Corpus/releases{/id}","deployments_url":"https://api.github.com/repos/quadrama/Corpus/deployments","created_at":"2018-03-21T11:08:01Z","updated_at":"2019-03-11T09:37:09Z","pushed_at":"2019-03-17T15:49:27Z","git_url":"git://github.com/quadrama/Corpus.git","ssh_url":"git@github.com:quadrama/Corpus.git","clone_url":"https://github.com/quadrama/Corpus.git","svn_url":"https://github.com/quadrama/Corpus","homepage":null,"size":39273,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"quadrama:master","ref":"master","sha":"209142b72df1aacf9b86e19cc2a2addb5341670d","user":{"login":"quadrama","id":19320828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzIwODI4","avatar_url":"https://avatars2.githubusercontent.com/u/19320828?v=4","gravatar_id":"","url":"https://api.github.com/users/quadrama","html_url":"https://github.com/quadrama","followers_url":"https://api.github.com/users/quadrama/followers","following_url":"https://api.github.com/users/quadrama/following{/other_user}","gists_url":"https://api.github.com/users/quadrama/gists{/gist_id}","starred_url":"https://api.github.com/users/quadrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quadrama/subscriptions","organizations_url":"https://api.github.com/users/quadrama/orgs","repos_url":"https://api.github.com/users/quadrama/repos","events_url":"https://api.github.com/users/quadrama/events{/privacy}","received_events_url":"https://api.github.com/users/quadrama/received_events","type":"Organization","site_admin":false},"repo":{"id":126166428,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxNjY0Mjg=","name":"Corpus","full_name":"quadrama/Corpus","private":false,"owner":{"login":"quadrama","id":19320828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzIwODI4","avatar_url":"https://avatars2.githubusercontent.com/u/19320828?v=4","gravatar_id":"","url":"https://api.github.com/users/quadrama","html_url":"https://github.com/quadrama","followers_url":"https://api.github.com/users/quadrama/followers","following_url":"https://api.github.com/users/quadrama/following{/other_user}","gists_url":"https://api.github.com/users/quadrama/gists{/gist_id}","starred_url":"https://api.github.com/users/quadrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quadrama/subscriptions","organizations_url":"https://api.github.com/users/quadrama/orgs","repos_url":"https://api.github.com/users/quadrama/repos","events_url":"https://api.github.com/users/quadrama/events{/privacy}","received_events_url":"https://api.github.com/users/quadrama/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/quadrama/Corpus","description":"The main quadrama corpus","fork":false,"url":"https://api.github.com/repos/quadrama/Corpus","forks_url":"https://api.github.com/repos/quadrama/Corpus/forks","keys_url":"https://api.github.com/repos/quadrama/Corpus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quadrama/Corpus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quadrama/Corpus/teams","hooks_url":"https://api.github.com/repos/quadrama/Corpus/hooks","issue_events_url":"https://api.github.com/repos/quadrama/Corpus/issues/events{/number}","events_url":"https://api.github.com/repos/quadrama/Corpus/events","assignees_url":"https://api.github.com/repos/quadrama/Corpus/assignees{/user}","branches_url":"https://api.github.com/repos/quadrama/Corpus/branches{/branch}","tags_url":"https://api.github.com/repos/quadrama/Corpus/tags","blobs_url":"https://api.github.com/repos/quadrama/Corpus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quadrama/Corpus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quadrama/Corpus/git/refs{/sha}","trees_url":"https://api.github.com/repos/quadrama/Corpus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quadrama/Corpus/statuses/{sha}","languages_url":"https://api.github.com/repos/quadrama/Corpus/languages","stargazers_url":"https://api.github.com/repos/quadrama/Corpus/stargazers","contributors_url":"https://api.github.com/repos/quadrama/Corpus/contributors","subscribers_url":"https://api.github.com/repos/quadrama/Corpus/subscribers","subscription_url":"https://api.github.com/repos/quadrama/Corpus/subscription","commits_url":"https://api.github.com/repos/quadrama/Corpus/commits{/sha}","git_commits_url":"https://api.github.com/repos/quadrama/Corpus/git/commits{/sha}","comments_url":"https://api.github.com/repos/quadrama/Corpus/comments{/number}","issue_comment_url":"https://api.github.com/repos/quadrama/Corpus/issues/comments{/number}","contents_url":"https://api.github.com/repos/quadrama/Corpus/contents/{+path}","compare_url":"https://api.github.com/repos/quadrama/Corpus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quadrama/Corpus/merges","archive_url":"https://api.github.com/repos/quadrama/Corpus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quadrama/Corpus/downloads","issues_url":"https://api.github.com/repos/quadrama/Corpus/issues{/number}","pulls_url":"https://api.github.com/repos/quadrama/Corpus/pulls{/number}","milestones_url":"https://api.github.com/repos/quadrama/Corpus/milestones{/number}","notifications_url":"https://api.github.com/repos/quadrama/Corpus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quadrama/Corpus/labels{/name}","releases_url":"https://api.github.com/repos/quadrama/Corpus/releases{/id}","deployments_url":"https://api.github.com/repos/quadrama/Corpus/deployments","created_at":"2018-03-21T11:08:01Z","updated_at":"2019-03-11T09:37:09Z","pushed_at":"2019-03-17T15:49:27Z","git_url":"git://github.com/quadrama/Corpus.git","ssh_url":"git@github.com:quadrama/Corpus.git","clone_url":"https://github.com/quadrama/Corpus.git","svn_url":"https://github.com/quadrama/Corpus","homepage":null,"size":39273,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quadrama/Corpus/pulls/16"},"html":{"href":"https://github.com/quadrama/Corpus/pull/16"},"issue":{"href":"https://api.github.com/repos/quadrama/Corpus/issues/16"},"comments":{"href":"https://api.github.com/repos/quadrama/Corpus/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/quadrama/Corpus/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/quadrama/Corpus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quadrama/Corpus/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/quadrama/Corpus/statuses/055d7c89614758765f25bff91165ae4d774eac6b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 126166428,
"name": "quadrama/Corpus",
"url": "https://api.github.com/repos/quadrama/Corpus"
}
|
{
"id": 12445355,
"login": "pagelj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12445355?",
"url": "https://api.github.com/users/pagelj"
}
|
{
"id": 19320828,
"login": "quadrama",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19320828?",
"url": "https://api.github.com/orgs/quadrama"
}
| 2019-03-19T11:13:18 |
9270490195
|
{"actor":{"display_login":"pagelj"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cornell-dti/course-plan/pulls/comments/347208974","pull_request_review_id":318109555,"id":347208974,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzIwODk3NA==","diff_hunk":"@@ -1,26 +1,276 @@\n <template>\n <div class=\"requirements\">\n- <div class=\"requirements-ayesha\">REQUIREMENTS GO HERE AYESHA</div>\n+ <h1 class=\"title\">School Requirements</h1>\n+ <!-- loop through reqs array of req objects -->\n+ <div class=\"reqs\" v-for=\"(req, index) in reqs\" v-bind:key=\"req.id\">\n+ <div class=\"row top\">\n+ <p class=\"name col p-0\">{{ req.name }}</p>\n+ <div class=\"col-1 text-right p-0\">\n+ <button class=\"btn\">\n+ <!-- svg for settings icon -->\n+ <svg class=\"settings\" x=\"0px\" y=\"0px\" viewBox=\"0 0 24 24\"><path d=\"M 9.6679688 2 L 9.1757812 4.5234375 C 8.3550224 4.8338012 7.5961042 5.2674041 6.9296875 5.8144531 L 4.5058594 4.9785156 L 2.1738281 9.0214844 L 4.1132812 10.707031 C 4.0445153 11.128986 4 11.558619 4 12 C 4 12.441381 4.0445153 12.871014 4.1132812 13.292969 L 2.1738281 14.978516 L 4.5058594 19.021484 L 6.9296875 18.185547 C 7.5961042 18.732596 8.3550224 19.166199 9.1757812 19.476562 L 9.6679688 22 L 14.332031 22 L 14.824219 19.476562 C 15.644978 19.166199 16.403896 18.732596 17.070312 18.185547 L 19.494141 19.021484 L 21.826172 14.978516 L 19.886719 13.292969 C 19.955485 12.871014 20 12.441381 20 12 C 20 11.558619 19.955485 11.128986 19.886719 10.707031 L 21.826172 9.0214844 L 19.494141 4.9785156 L 17.070312 5.8144531 C 16.403896 5.2674041 15.644978 4.8338012 14.824219 4.5234375 L 14.332031 2 L 9.6679688 2 z M 12 8 C 14.209 8 16 9.791 16 12 C 16 14.209 14.209 16 12 16 C 9.791 16 8 14.209 8 12 C 8 9.791 9.791 8 12 8 z\"></path></svg>\n+ </button>\n+ </div>\n+ </div>\n+ <!-- progress bar settings -->\n+ <div class=\"progress\"><div class=\"progress-bar\" v-bind:style=\"{ 'background-color': req.color, width: `${(req.progress/req.total)*100}%`}\" role=\"progressbar\"></div></div>\n+ <p class=\"progress-text\"><strong>{{ req.progress }}/{{ req.total }}</strong> Total {{ req.count }} Inputted on Schedule</p>\n+ <!-- display button (off when req.displayDetails is false) -->\n+ <button class=\"view btn\" v-if=\"!req.displayDetails\" v-bind:style=\"{ 'background-color': req.color }\" v-on:click=\"turnDetails(index, true)\">\n+ View All {{ req.type }} Requirements\n+ </button>\n+ <!-- when displayDetails is true -->\n+ <div class=\"detail\" v-if=\"req.displayDetails\">\n+ <div class=\"todo\">\n+ <div class=\"row detail-bar\">\n+ <p class=\"col detail-text p-0\">In-Depth {{ req.type }} Requirements</p> \n+ <div class=\"text-right p-0\">\n+ <button class=\"btn\" v-on:click=\"turnDetails(index, false)\">\n+ <!-- picture of close (x) icon -->\n+ <img class=\"cancel\" src=\"../assets/images/x.png\" alt=\"X\">\n+ </button>\n+ </div>\n+ </div>\n+ <!-- loop through uncompleted reqs in req.todo array -->\n+ <div class=\"list\" v-for=\"value in req.todo\" v-bind:key=\"value.id\">\n+ <div class=\"separator\"></div>\n+ <div class=\"row req\">\n+ <p class=\"col float-left p-0 req-name\">{{ value.name }}</p>\n+ <p class=\"col float-right text-right p-0 req-progress\">({{ value.progress }}/{{ value.total }} {{ value.count }})</p>\n+ </div>\n+ </div>\n+ <div class=\"separator\"></div>\n+ </div>\n+ <!-- Display completed section if there are completed reqs -->\n+ <div class=\"completed\" v-if=\"req.completed.length > 0\">\n+ <div class=\"row detail-bar\">\n+ <p class=\"col detail-text p-0\">Completed {{ req.type }} Requirements</p>\n+ <button class=\"btn\" v-bind:style=\"{ 'color': req.color }\">\n+ <!-- Toggle to display completed reqs -->\n+ <p class=\"toggle\" v-if=\"req.displayCompleted\" v-on:click=\"turnCompleted(index, false)\">HIDE</p>\n+ <p class=\"toggle\" v-else v-on:click=\"turnCompleted(index, true)\">SHOW</p>\n+ </button>\n+ </div>\n+ <div v-if=\"req.displayCompleted\">\n+ <!-- loop through completed reqs in req.completed array -->\n+ <div class=\"list\" v-for=\"value in req.completed\" v-bind:key=\"value.id\">\n+ <div class=\"separator\"></div>\n+ <div class=\"row req\">\n+ <p class=\"col float-left p-0 req-name\">{{ value.name }}</p>\n+ <p class=\"col float-right text-right p-0 req-progress\">({{ value.progress }}/{{ value.total }} {{ value.count }})</p>\n+ </div>\n+ </div>\n+ </div>\n+ </div>\n+ </div>\n+ <!-- Add separator if not last req or not displaying details -->\n+ <div class=\"separator\" v-if=\"index < reqs.length - 1 || req.displayDetails\"></div>\n+ </div>\n </div>\n </template>\n \n <script>\n import Vue from 'vue';\n \n-export default {}\n+export default {\n+ data() {\n+ return {\n+ reqs: [\n+ {\n+ name: \"College Requirements\",\n+ type: \"College\",\n+ count: \"Credits\",\n+ progress: 46,\n+ total: 120,\n+ color: '#2BBCC6',\n+ displayDetails: false,\n+ todo: [\n+ {\n+ name: \"CALS Credits\",\n+ count: \"Credits\",\n+ progress: 12,\n+ total: 55\n+ },\n+ {\n+ name: \"PE Credits\",\n+ count: \"Credits\",\n+ progress: 1,\n+ total: 2\n+ }\n+ ],\n+ displayCompleted: true,\n+ completed: [\n+ {\n+ name: \"Quantitative Literacy\",\n+ count: \"Credits\",\n+ progress: 2,\n+ total: 2\n+ },\n+ {\n+ name: \"Chemistry/Physics\",\n+ count: \"Credits\",\n+ progress: 1,\n+ total: 2\n+ }\n+ ]\n+ },\n+ {\n+ name: \"Major Requirements\",\n+ type: \"Major\",\n+ count: \"Courses\",\n+ progress: 4,\n+ total: 8,\n+ color: '#4D53DC',\n+ displayDetails: false,\n+ todo: [\n+ {\n+ name: \"CALS Credits\",\n+ count: \"Credits\",\n+ progress: 12,\n+ total: 55\n+ },\n+ {\n+ name: \"PE Credits\",\n+ count: \"Credits\",\n+ progress: 1,\n+ total: 2\n+ }\n+ ],\n+ displayCompleted: true,\n+ completed: [\n+ {\n+ name: \"Quantitative Literacy\",\n+ count: \"Credits\",\n+ progress: 2,\n+ total: 2\n+ },\n+ {\n+ name: \"Chemistry/Physics\",\n+ count: \"Credits\",\n+ progress: 1,\n+ total: 2\n+ }\n+ ]\n+ }\n+ ]\n+ }\n+ },\n+\n+ methods: {\n+ turnDetails: function(index, bool) {\n+ this.reqs[index].displayDetails = bool;\n+ },\n+ turnCompleted: function(index, bool) {\n+ this.reqs[index].displayCompleted = bool;\n+ }\n+ }\n+}\n </script>\n \n <style scoped lang=\"scss\">\n+\n+.btn {\n+ padding: 0;\n+}\n+\n .requirements {\n- width: 25rem;\n- background-color: lightblue;\n- border: 2px black solid;\n-\n- &-ayesha {\n- width: 25rem;\n- font-size: 50px;\n- color: black;\n- text-align: center;\n+ width: 30rem;\n+ padding: 1.625rem 1.5rem 1.625rem 1.5rem;\n+ background-color: white;\n+}\n+\n+h1.title {\n+ margin: 0 0 0 0;\n+ font-weight: 600;\n+ font-size: 24px;\n+ line-height: 24px;\n+}\n+\n+.top {\n+ margin: 1.5rem 0 1rem 0;\n+}\n+\n+.name {\n+ margin-top: auto;\n+ margin-bottom: auto;\n+ font-style: normal;\n+ font-weight: normal;\n+ font-size: 16px;\n+ line-height: 16px;\n+}\n+\n+.settings {\n+ height: 14px;\n+ width: 14px;\n+ fill: #999999;\n+}\n+\n+.progress-text {\n+ margin: 0.3125rem 0 0 0;\n+ font-size: 12px;\n+ line-height: 12px;\n+}\n+\n+button.view {\n+ margin: 0.7rem 0 2rem 0;\n+ min-height: 40px;\n+ width: 100%;\n+ font-weight: bold;\n+ font-size: 14px;\n+ line-height: 14px;\n+ text-align: center;\n+ color: white;\n+ text-transform: uppercase;\n+}\n+\n+.detail-bar {\n+ margin: 1.625rem 0 0.8125rem 0;\n+ width: 100%;\n+}\n+\n+.detail-text {\n+ margin-top: auto;\n+ margin-bottom: auto;\n+ font-weight: bold;\n+ font-size: 14px;\n+ line-height: 14px;\n+}\n+\n+.cancel {\n+ height: 10px;\n+ width: 10px;\n+}\n+\n+.toggle {\n+ margin-top: auto;\n+ margin-bottom: auto;\n+ font-weight: bold;\n+ font-size: 12px;\n+ line-height: 12px;\n+}\n+\n+.req {\n+ margin: 0.5rem 0 0 0;\n+ padding: 0;","path":"src/components/Requirements.vue","position":265,"original_position":265,"commit_id":"f6c6ca15571742151458e2ec704029dc5223693c","original_commit_id":"f6c6ca15571742151458e2ec704029dc5223693c","user":{"login":"hanywang2","id":44352119,"node_id":"MDQ6VXNlcjQ0MzUyMTE5","avatar_url":"https://avatars0.githubusercontent.com/u/44352119?v=4","gravatar_id":"","url":"https://api.github.com/users/hanywang2","html_url":"https://github.com/hanywang2","followers_url":"https://api.github.com/users/hanywang2/followers","following_url":"https://api.github.com/users/hanywang2/following{/other_user}","gists_url":"https://api.github.com/users/hanywang2/gists{/gist_id}","starred_url":"https://api.github.com/users/hanywang2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanywang2/subscriptions","organizations_url":"https://api.github.com/users/hanywang2/orgs","repos_url":"https://api.github.com/users/hanywang2/repos","events_url":"https://api.github.com/users/hanywang2/events{/privacy}","received_events_url":"https://api.github.com/users/hanywang2/received_events","type":"User","site_admin":false},"body":"I was trying to override a bootstrap style. Pretty sure it didn't work and I forgot to remove it","created_at":"2019-11-18T05:47:02Z","updated_at":"2019-11-18T05:47:03Z","html_url":"https://github.com/cornell-dti/course-plan/pull/5#discussion_r347208974","pull_request_url":"https://api.github.com/repos/cornell-dti/course-plan/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cornell-dti/course-plan/pulls/comments/347208974"},"html":{"href":"https://github.com/cornell-dti/course-plan/pull/5#discussion_r347208974"},"pull_request":{"href":"https://api.github.com/repos/cornell-dti/course-plan/pulls/5"}},"in_reply_to_id":347203694},"pull_request":{"url":"https://api.github.com/repos/cornell-dti/course-plan/pulls/5","id":341961269,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxOTYxMjY5","html_url":"https://github.com/cornell-dti/course-plan/pull/5","diff_url":"https://github.com/cornell-dti/course-plan/pull/5.diff","patch_url":"https://github.com/cornell-dti/course-plan/pull/5.patch","issue_url":"https://api.github.com/repos/cornell-dti/course-plan/issues/5","number":5,"state":"open","locked":false,"title":"Initial Requirements Menu Setup","user":{"login":"hanywang2","id":44352119,"node_id":"MDQ6VXNlcjQ0MzUyMTE5","avatar_url":"https://avatars0.githubusercontent.com/u/44352119?v=4","gravatar_id":"","url":"https://api.github.com/users/hanywang2","html_url":"https://github.com/hanywang2","followers_url":"https://api.github.com/users/hanywang2/followers","following_url":"https://api.github.com/users/hanywang2/following{/other_user}","gists_url":"https://api.github.com/users/hanywang2/gists{/gist_id}","starred_url":"https://api.github.com/users/hanywang2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanywang2/subscriptions","organizations_url":"https://api.github.com/users/hanywang2/orgs","repos_url":"https://api.github.com/users/hanywang2/repos","events_url":"https://api.github.com/users/hanywang2/events{/privacy}","received_events_url":"https://api.github.com/users/hanywang2/received_events","type":"User","site_admin":false},"body":"### Summary <!-- Required -->\r\n\r\nDeveloped the frontend for the requirements menu and made it adaptable with Vue's template binding. And made minor style changes to dashboard.\r\n\r\n- [x] Added Bootstrap and JQuery\r\n\r\n### Test Plan <!-- Required -->\r\n\r\n@willespencer @tcho6319 @ayesha4698 please test the functionality of basic buttons and provide feedback on the data setup for the requirements menu.","created_at":"2019-11-18T04:44:46Z","updated_at":"2019-11-18T05:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71cf138073eac1efafc4884bc9aca22a461a3d74","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tcho6319","id":54298311,"node_id":"MDQ6VXNlcjU0Mjk4MzEx","avatar_url":"https://avatars1.githubusercontent.com/u/54298311?v=4","gravatar_id":"","url":"https://api.github.com/users/tcho6319","html_url":"https://github.com/tcho6319","followers_url":"https://api.github.com/users/tcho6319/followers","following_url":"https://api.github.com/users/tcho6319/following{/other_user}","gists_url":"https://api.github.com/users/tcho6319/gists{/gist_id}","starred_url":"https://api.github.com/users/tcho6319/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcho6319/subscriptions","organizations_url":"https://api.github.com/users/tcho6319/orgs","repos_url":"https://api.github.com/users/tcho6319/repos","events_url":"https://api.github.com/users/tcho6319/events{/privacy}","received_events_url":"https://api.github.com/users/tcho6319/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cornell-dti/course-plan/pulls/5/commits","review_comments_url":"https://api.github.com/repos/cornell-dti/course-plan/pulls/5/comments","review_comment_url":"https://api.github.com/repos/cornell-dti/course-plan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cornell-dti/course-plan/issues/5/comments","statuses_url":"https://api.github.com/repos/cornell-dti/course-plan/statuses/f6c6ca15571742151458e2ec704029dc5223693c","head":{"label":"cornell-dti:requirements","ref":"requirements","sha":"f6c6ca15571742151458e2ec704029dc5223693c","user":{"login":"cornell-dti","id":19356609,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzU2NjA5","avatar_url":"https://avatars2.githubusercontent.com/u/19356609?v=4","gravatar_id":"","url":"https://api.github.com/users/cornell-dti","html_url":"https://github.com/cornell-dti","followers_url":"https://api.github.com/users/cornell-dti/followers","following_url":"https://api.github.com/users/cornell-dti/following{/other_user}","gists_url":"https://api.github.com/users/cornell-dti/gists{/gist_id}","starred_url":"https://api.github.com/users/cornell-dti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornell-dti/subscriptions","organizations_url":"https://api.github.com/users/cornell-dti/orgs","repos_url":"https://api.github.com/users/cornell-dti/repos","events_url":"https://api.github.com/users/cornell-dti/events{/privacy}","received_events_url":"https://api.github.com/users/cornell-dti/received_events","type":"Organization","site_admin":false},"repo":{"id":211447283,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE0NDcyODM=","name":"course-plan","full_name":"cornell-dti/course-plan","private":false,"owner":{"login":"cornell-dti","id":19356609,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzU2NjA5","avatar_url":"https://avatars2.githubusercontent.com/u/19356609?v=4","gravatar_id":"","url":"https://api.github.com/users/cornell-dti","html_url":"https://github.com/cornell-dti","followers_url":"https://api.github.com/users/cornell-dti/followers","following_url":"https://api.github.com/users/cornell-dti/following{/other_user}","gists_url":"https://api.github.com/users/cornell-dti/gists{/gist_id}","starred_url":"https://api.github.com/users/cornell-dti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornell-dti/subscriptions","organizations_url":"https://api.github.com/users/cornell-dti/orgs","repos_url":"https://api.github.com/users/cornell-dti/repos","events_url":"https://api.github.com/users/cornell-dti/events{/privacy}","received_events_url":"https://api.github.com/users/cornell-dti/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cornell-dti/course-plan","description":null,"fork":false,"url":"https://api.github.com/repos/cornell-dti/course-plan","forks_url":"https://api.github.com/repos/cornell-dti/course-plan/forks","keys_url":"https://api.github.com/repos/cornell-dti/course-plan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cornell-dti/course-plan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cornell-dti/course-plan/teams","hooks_url":"https://api.github.com/repos/cornell-dti/course-plan/hooks","issue_events_url":"https://api.github.com/repos/cornell-dti/course-plan/issues/events{/number}","events_url":"https://api.github.com/repos/cornell-dti/course-plan/events","assignees_url":"https://api.github.com/repos/cornell-dti/course-plan/assignees{/user}","branches_url":"https://api.github.com/repos/cornell-dti/course-plan/branches{/branch}","tags_url":"https://api.github.com/repos/cornell-dti/course-plan/tags","blobs_url":"https://api.github.com/repos/cornell-dti/course-plan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cornell-dti/course-plan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cornell-dti/course-plan/git/refs{/sha}","trees_url":"https://api.github.com/repos/cornell-dti/course-plan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cornell-dti/course-plan/statuses/{sha}","languages_url":"https://api.github.com/repos/cornell-dti/course-plan/languages","stargazers_url":"https://api.github.com/repos/cornell-dti/course-plan/stargazers","contributors_url":"https://api.github.com/repos/cornell-dti/course-plan/contributors","subscribers_url":"https://api.github.com/repos/cornell-dti/course-plan/subscribers","subscription_url":"https://api.github.com/repos/cornell-dti/course-plan/subscription","commits_url":"https://api.github.com/repos/cornell-dti/course-plan/commits{/sha}","git_commits_url":"https://api.github.com/repos/cornell-dti/course-plan/git/commits{/sha}","comments_url":"https://api.github.com/repos/cornell-dti/course-plan/comments{/number}","issue_comment_url":"https://api.github.com/repos/cornell-dti/course-plan/issues/comments{/number}","contents_url":"https://api.github.com/repos/cornell-dti/course-plan/contents/{+path}","compare_url":"https://api.github.com/repos/cornell-dti/course-plan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cornell-dti/course-plan/merges","archive_url":"https://api.github.com/repos/cornell-dti/course-plan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cornell-dti/course-plan/downloads","issues_url":"https://api.github.com/repos/cornell-dti/course-plan/issues{/number}","pulls_url":"https://api.github.com/repos/cornell-dti/course-plan/pulls{/number}","milestones_url":"https://api.github.com/repos/cornell-dti/course-plan/milestones{/number}","notifications_url":"https://api.github.com/repos/cornell-dti/course-plan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cornell-dti/course-plan/labels{/name}","releases_url":"https://api.github.com/repos/cornell-dti/course-plan/releases{/id}","deployments_url":"https://api.github.com/repos/cornell-dti/course-plan/deployments","created_at":"2019-09-28T05:07:54Z","updated_at":"2019-11-14T20:27:57Z","pushed_at":"2019-11-18T04:44:47Z","git_url":"git://github.com/cornell-dti/course-plan.git","ssh_url":"git@github.com:cornell-dti/course-plan.git","clone_url":"https://github.com/cornell-dti/course-plan.git","svn_url":"https://github.com/cornell-dti/course-plan","homepage":null,"size":3575,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"cornell-dti:semesters","ref":"semesters","sha":"34fc848feaa9f66231e85e8e69851e9ece3d5935","user":{"login":"cornell-dti","id":19356609,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzU2NjA5","avatar_url":"https://avatars2.githubusercontent.com/u/19356609?v=4","gravatar_id":"","url":"https://api.github.com/users/cornell-dti","html_url":"https://github.com/cornell-dti","followers_url":"https://api.github.com/users/cornell-dti/followers","following_url":"https://api.github.com/users/cornell-dti/following{/other_user}","gists_url":"https://api.github.com/users/cornell-dti/gists{/gist_id}","starred_url":"https://api.github.com/users/cornell-dti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornell-dti/subscriptions","organizations_url":"https://api.github.com/users/cornell-dti/orgs","repos_url":"https://api.github.com/users/cornell-dti/repos","events_url":"https://api.github.com/users/cornell-dti/events{/privacy}","received_events_url":"https://api.github.com/users/cornell-dti/received_events","type":"Organization","site_admin":false},"repo":{"id":211447283,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE0NDcyODM=","name":"course-plan","full_name":"cornell-dti/course-plan","private":false,"owner":{"login":"cornell-dti","id":19356609,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzU2NjA5","avatar_url":"https://avatars2.githubusercontent.com/u/19356609?v=4","gravatar_id":"","url":"https://api.github.com/users/cornell-dti","html_url":"https://github.com/cornell-dti","followers_url":"https://api.github.com/users/cornell-dti/followers","following_url":"https://api.github.com/users/cornell-dti/following{/other_user}","gists_url":"https://api.github.com/users/cornell-dti/gists{/gist_id}","starred_url":"https://api.github.com/users/cornell-dti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornell-dti/subscriptions","organizations_url":"https://api.github.com/users/cornell-dti/orgs","repos_url":"https://api.github.com/users/cornell-dti/repos","events_url":"https://api.github.com/users/cornell-dti/events{/privacy}","received_events_url":"https://api.github.com/users/cornell-dti/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cornell-dti/course-plan","description":null,"fork":false,"url":"https://api.github.com/repos/cornell-dti/course-plan","forks_url":"https://api.github.com/repos/cornell-dti/course-plan/forks","keys_url":"https://api.github.com/repos/cornell-dti/course-plan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cornell-dti/course-plan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cornell-dti/course-plan/teams","hooks_url":"https://api.github.com/repos/cornell-dti/course-plan/hooks","issue_events_url":"https://api.github.com/repos/cornell-dti/course-plan/issues/events{/number}","events_url":"https://api.github.com/repos/cornell-dti/course-plan/events","assignees_url":"https://api.github.com/repos/cornell-dti/course-plan/assignees{/user}","branches_url":"https://api.github.com/repos/cornell-dti/course-plan/branches{/branch}","tags_url":"https://api.github.com/repos/cornell-dti/course-plan/tags","blobs_url":"https://api.github.com/repos/cornell-dti/course-plan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cornell-dti/course-plan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cornell-dti/course-plan/git/refs{/sha}","trees_url":"https://api.github.com/repos/cornell-dti/course-plan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cornell-dti/course-plan/statuses/{sha}","languages_url":"https://api.github.com/repos/cornell-dti/course-plan/languages","stargazers_url":"https://api.github.com/repos/cornell-dti/course-plan/stargazers","contributors_url":"https://api.github.com/repos/cornell-dti/course-plan/contributors","subscribers_url":"https://api.github.com/repos/cornell-dti/course-plan/subscribers","subscription_url":"https://api.github.com/repos/cornell-dti/course-plan/subscription","commits_url":"https://api.github.com/repos/cornell-dti/course-plan/commits{/sha}","git_commits_url":"https://api.github.com/repos/cornell-dti/course-plan/git/commits{/sha}","comments_url":"https://api.github.com/repos/cornell-dti/course-plan/comments{/number}","issue_comment_url":"https://api.github.com/repos/cornell-dti/course-plan/issues/comments{/number}","contents_url":"https://api.github.com/repos/cornell-dti/course-plan/contents/{+path}","compare_url":"https://api.github.com/repos/cornell-dti/course-plan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cornell-dti/course-plan/merges","archive_url":"https://api.github.com/repos/cornell-dti/course-plan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cornell-dti/course-plan/downloads","issues_url":"https://api.github.com/repos/cornell-dti/course-plan/issues{/number}","pulls_url":"https://api.github.com/repos/cornell-dti/course-plan/pulls{/number}","milestones_url":"https://api.github.com/repos/cornell-dti/course-plan/milestones{/number}","notifications_url":"https://api.github.com/repos/cornell-dti/course-plan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cornell-dti/course-plan/labels{/name}","releases_url":"https://api.github.com/repos/cornell-dti/course-plan/releases{/id}","deployments_url":"https://api.github.com/repos/cornell-dti/course-plan/deployments","created_at":"2019-09-28T05:07:54Z","updated_at":"2019-11-14T20:27:57Z","pushed_at":"2019-11-18T04:44:47Z","git_url":"git://github.com/cornell-dti/course-plan.git","ssh_url":"git@github.com:cornell-dti/course-plan.git","clone_url":"https://github.com/cornell-dti/course-plan.git","svn_url":"https://github.com/cornell-dti/course-plan","homepage":null,"size":3575,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cornell-dti/course-plan/pulls/5"},"html":{"href":"https://github.com/cornell-dti/course-plan/pull/5"},"issue":{"href":"https://api.github.com/repos/cornell-dti/course-plan/issues/5"},"comments":{"href":"https://api.github.com/repos/cornell-dti/course-plan/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/cornell-dti/course-plan/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/cornell-dti/course-plan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cornell-dti/course-plan/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/cornell-dti/course-plan/statuses/f6c6ca15571742151458e2ec704029dc5223693c"}},"author_association":"MEMBER"}}
|
{
"id": 211447283,
"name": "cornell-dti/course-plan",
"url": "https://api.github.com/repos/cornell-dti/course-plan"
}
|
{
"id": 44352119,
"login": "hanywang2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44352119?",
"url": "https://api.github.com/users/hanywang2"
}
|
{
"id": 19356609,
"login": "cornell-dti",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19356609?",
"url": "https://api.github.com/orgs/cornell-dti"
}
| 2019-11-18T05:47:02 |
10883647893
|
{"actor":{"display_login":"hanywang2"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/comments/275149967","pull_request_review_id":226388370,"id":275149967,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTE0OTk2Nw==","diff_hunk":"@@ -0,0 +1,125 @@\n+# Current limitations:\n+# - use fixed values for some properties\n+# - EAGERFREQ = 100\n+# - NEEDSCONS = TRUE\n+# - SEPAPRIORITY = 0\n+# - SEPAFREQ = -1\n+# - DELAYSEPA = FALSE\n+# - PROPFREQ = -1\n+# - DELAYPROP = -1\n+# - PROP_TIMING = SCIP_PROPTIMING_BEFORELP\n+# - PRESOLTIMING = SCIP_PRESOLTIMING_MEDIUM\n+# - MAXPREROUNDS = -1\n+# - don't support optional methods: CONSHLDRCOPY, CONSFREE, CONSINIT, CONSEXIT,\n+# CONSINITPRE, CONSEXITPRE, CONSINITSOL, CONSEXITSOL, CONSDELETE, CONSTRANS,\n+# CONSINITLP, CONSSEPALP, CONSSEPASOL, CONSENFORELAX, CONSPROP, CONSPRESOL,\n+# CONSRESPROP, CONSACTIVE, CONSDEACTIVE, CONSENABLE, CONSDISABLE, CONSDELVARS,\n+# CONSPRINT, CONSCOPY, CONSPARSE, CONSGETVARS, CONSGETNVARS, CONSGETDIVEBDCHGS\n+# - don't support linear or nonlinear constraint upgrading","path":"src/conshdlr.jl","position":18,"original_position":18,"commit_id":"85ba6a9e68b814355a90a95b485c978370aff12b","original_commit_id":"85ba6a9e68b814355a90a95b485c978370aff12b","user":{"login":"robertschwarz","id":43053,"node_id":"MDQ6VXNlcjQzMDUz","avatar_url":"https://avatars2.githubusercontent.com/u/43053?v=4","gravatar_id":"","url":"https://api.github.com/users/robertschwarz","html_url":"https://github.com/robertschwarz","followers_url":"https://api.github.com/users/robertschwarz/followers","following_url":"https://api.github.com/users/robertschwarz/following{/other_user}","gists_url":"https://api.github.com/users/robertschwarz/gists{/gist_id}","starred_url":"https://api.github.com/users/robertschwarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertschwarz/subscriptions","organizations_url":"https://api.github.com/users/robertschwarz/orgs","repos_url":"https://api.github.com/users/robertschwarz/repos","events_url":"https://api.github.com/users/robertschwarz/events{/privacy}","received_events_url":"https://api.github.com/users/robertschwarz/received_events","type":"User","site_admin":false},"body":"Constraint upgrading means detecting special structure, and then converting a given constraint to a constraint of a different handler. For example, a user might create a linear constraint, but then SCIP detects that it is actually a set-cover constraint, so it will create a constraint of that type in order to use specialized methods for cuts, presolve etc. Similarly, a user might submit a constraint with a nonlinear, but then SCIP detects that it can be represented as a quadratic constraint handler and upgrades to that. Not sure whether the original constraints remain in the (transformed) problem or not.","created_at":"2019-04-14T10:25:58Z","updated_at":"2019-04-14T10:25:58Z","html_url":"https://github.com/SCIP-Interfaces/SCIP.jl/pull/109#discussion_r275149967","pull_request_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/109","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/comments/275149967"},"html":{"href":"https://github.com/SCIP-Interfaces/SCIP.jl/pull/109#discussion_r275149967"},"pull_request":{"href":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/109"}},"in_reply_to_id":275134560},"pull_request":{"url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/109","id":263924558,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzOTI0NTU4","html_url":"https://github.com/SCIP-Interfaces/SCIP.jl/pull/109","diff_url":"https://github.com/SCIP-Interfaces/SCIP.jl/pull/109.diff","patch_url":"https://github.com/SCIP-Interfaces/SCIP.jl/pull/109.patch","issue_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues/109","number":109,"state":"open","locked":false,"title":"WIP: add support for constraint handlers","user":{"login":"robertschwarz","id":43053,"node_id":"MDQ6VXNlcjQzMDUz","avatar_url":"https://avatars2.githubusercontent.com/u/43053?v=4","gravatar_id":"","url":"https://api.github.com/users/robertschwarz","html_url":"https://github.com/robertschwarz","followers_url":"https://api.github.com/users/robertschwarz/followers","following_url":"https://api.github.com/users/robertschwarz/following{/other_user}","gists_url":"https://api.github.com/users/robertschwarz/gists{/gist_id}","starred_url":"https://api.github.com/users/robertschwarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertschwarz/subscriptions","organizations_url":"https://api.github.com/users/robertschwarz/orgs","repos_url":"https://api.github.com/users/robertschwarz/repos","events_url":"https://api.github.com/users/robertschwarz/events{/privacy}","received_events_url":"https://api.github.com/users/robertschwarz/received_events","type":"User","site_admin":false},"body":"Adresses part of #94.\r\n","created_at":"2019-03-24T18:04:21Z","updated_at":"2019-04-14T10:25:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6c6afc6f2d02fbe33985d70cf5cc8b2f98561f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/109/commits","review_comments_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/109/comments","review_comment_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues/109/comments","statuses_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/statuses/85ba6a9e68b814355a90a95b485c978370aff12b","head":{"label":"SCIP-Interfaces:rs/conshdlr","ref":"rs/conshdlr","sha":"85ba6a9e68b814355a90a95b485c978370aff12b","user":{"login":"SCIP-Interfaces","id":19473229,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDczMjI5","avatar_url":"https://avatars1.githubusercontent.com/u/19473229?v=4","gravatar_id":"","url":"https://api.github.com/users/SCIP-Interfaces","html_url":"https://github.com/SCIP-Interfaces","followers_url":"https://api.github.com/users/SCIP-Interfaces/followers","following_url":"https://api.github.com/users/SCIP-Interfaces/following{/other_user}","gists_url":"https://api.github.com/users/SCIP-Interfaces/gists{/gist_id}","starred_url":"https://api.github.com/users/SCIP-Interfaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCIP-Interfaces/subscriptions","organizations_url":"https://api.github.com/users/SCIP-Interfaces/orgs","repos_url":"https://api.github.com/users/SCIP-Interfaces/repos","events_url":"https://api.github.com/users/SCIP-Interfaces/events{/privacy}","received_events_url":"https://api.github.com/users/SCIP-Interfaces/received_events","type":"Organization","site_admin":false},"repo":{"id":61443344,"node_id":"MDEwOlJlcG9zaXRvcnk2MTQ0MzM0NA==","name":"SCIP.jl","full_name":"SCIP-Interfaces/SCIP.jl","private":false,"owner":{"login":"SCIP-Interfaces","id":19473229,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDczMjI5","avatar_url":"https://avatars1.githubusercontent.com/u/19473229?v=4","gravatar_id":"","url":"https://api.github.com/users/SCIP-Interfaces","html_url":"https://github.com/SCIP-Interfaces","followers_url":"https://api.github.com/users/SCIP-Interfaces/followers","following_url":"https://api.github.com/users/SCIP-Interfaces/following{/other_user}","gists_url":"https://api.github.com/users/SCIP-Interfaces/gists{/gist_id}","starred_url":"https://api.github.com/users/SCIP-Interfaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCIP-Interfaces/subscriptions","organizations_url":"https://api.github.com/users/SCIP-Interfaces/orgs","repos_url":"https://api.github.com/users/SCIP-Interfaces/repos","events_url":"https://api.github.com/users/SCIP-Interfaces/events{/privacy}","received_events_url":"https://api.github.com/users/SCIP-Interfaces/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SCIP-Interfaces/SCIP.jl","description":"Julia interface to SCIP solver","fork":false,"url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl","forks_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/forks","keys_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/teams","hooks_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/hooks","issue_events_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues/events{/number}","events_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/events","assignees_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/assignees{/user}","branches_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/branches{/branch}","tags_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/tags","blobs_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/languages","stargazers_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/stargazers","contributors_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/contributors","subscribers_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/subscribers","subscription_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/subscription","commits_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/contents/{+path}","compare_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/merges","archive_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/downloads","issues_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues{/number}","pulls_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/labels{/name}","releases_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/releases{/id}","deployments_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/deployments","created_at":"2016-06-18T16:46:25Z","updated_at":"2019-04-13T19:54:49Z","pushed_at":"2019-04-09T07:17:01Z","git_url":"git://github.com/SCIP-Interfaces/SCIP.jl.git","ssh_url":"git@github.com:SCIP-Interfaces/SCIP.jl.git","clone_url":"https://github.com/SCIP-Interfaces/SCIP.jl.git","svn_url":"https://github.com/SCIP-Interfaces/SCIP.jl","homepage":null,"size":499,"stargazers_count":27,"watchers_count":27,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":11,"watchers":27,"default_branch":"master"}},"base":{"label":"SCIP-Interfaces:master","ref":"master","sha":"3c020c47aef593d6a050f63c8f0b207a4acc4403","user":{"login":"SCIP-Interfaces","id":19473229,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDczMjI5","avatar_url":"https://avatars1.githubusercontent.com/u/19473229?v=4","gravatar_id":"","url":"https://api.github.com/users/SCIP-Interfaces","html_url":"https://github.com/SCIP-Interfaces","followers_url":"https://api.github.com/users/SCIP-Interfaces/followers","following_url":"https://api.github.com/users/SCIP-Interfaces/following{/other_user}","gists_url":"https://api.github.com/users/SCIP-Interfaces/gists{/gist_id}","starred_url":"https://api.github.com/users/SCIP-Interfaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCIP-Interfaces/subscriptions","organizations_url":"https://api.github.com/users/SCIP-Interfaces/orgs","repos_url":"https://api.github.com/users/SCIP-Interfaces/repos","events_url":"https://api.github.com/users/SCIP-Interfaces/events{/privacy}","received_events_url":"https://api.github.com/users/SCIP-Interfaces/received_events","type":"Organization","site_admin":false},"repo":{"id":61443344,"node_id":"MDEwOlJlcG9zaXRvcnk2MTQ0MzM0NA==","name":"SCIP.jl","full_name":"SCIP-Interfaces/SCIP.jl","private":false,"owner":{"login":"SCIP-Interfaces","id":19473229,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDczMjI5","avatar_url":"https://avatars1.githubusercontent.com/u/19473229?v=4","gravatar_id":"","url":"https://api.github.com/users/SCIP-Interfaces","html_url":"https://github.com/SCIP-Interfaces","followers_url":"https://api.github.com/users/SCIP-Interfaces/followers","following_url":"https://api.github.com/users/SCIP-Interfaces/following{/other_user}","gists_url":"https://api.github.com/users/SCIP-Interfaces/gists{/gist_id}","starred_url":"https://api.github.com/users/SCIP-Interfaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCIP-Interfaces/subscriptions","organizations_url":"https://api.github.com/users/SCIP-Interfaces/orgs","repos_url":"https://api.github.com/users/SCIP-Interfaces/repos","events_url":"https://api.github.com/users/SCIP-Interfaces/events{/privacy}","received_events_url":"https://api.github.com/users/SCIP-Interfaces/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SCIP-Interfaces/SCIP.jl","description":"Julia interface to SCIP solver","fork":false,"url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl","forks_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/forks","keys_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/teams","hooks_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/hooks","issue_events_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues/events{/number}","events_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/events","assignees_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/assignees{/user}","branches_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/branches{/branch}","tags_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/tags","blobs_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/languages","stargazers_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/stargazers","contributors_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/contributors","subscribers_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/subscribers","subscription_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/subscription","commits_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/contents/{+path}","compare_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/merges","archive_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/downloads","issues_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues{/number}","pulls_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/labels{/name}","releases_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/releases{/id}","deployments_url":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/deployments","created_at":"2016-06-18T16:46:25Z","updated_at":"2019-04-13T19:54:49Z","pushed_at":"2019-04-09T07:17:01Z","git_url":"git://github.com/SCIP-Interfaces/SCIP.jl.git","ssh_url":"git@github.com:SCIP-Interfaces/SCIP.jl.git","clone_url":"https://github.com/SCIP-Interfaces/SCIP.jl.git","svn_url":"https://github.com/SCIP-Interfaces/SCIP.jl","homepage":null,"size":499,"stargazers_count":27,"watchers_count":27,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":11,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/109"},"html":{"href":"https://github.com/SCIP-Interfaces/SCIP.jl/pull/109"},"issue":{"href":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues/109"},"comments":{"href":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/SCIP-Interfaces/SCIP.jl/statuses/85ba6a9e68b814355a90a95b485c978370aff12b"}},"author_association":"MEMBER"}}
|
{
"id": 61443344,
"name": "SCIP-Interfaces/SCIP.jl",
"url": "https://api.github.com/repos/SCIP-Interfaces/SCIP.jl"
}
|
{
"id": 43053,
"login": "robertschwarz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43053?",
"url": "https://api.github.com/users/robertschwarz"
}
|
{
"id": 19473229,
"login": "SCIP-Interfaces",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19473229?",
"url": "https://api.github.com/orgs/SCIP-Interfaces"
}
| 2019-04-14T10:25:58 |
9439436350
|
{"actor":{"display_login":"robertschwarz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/278462403","pull_request_review_id":230533249,"id":278462403,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODQ2MjQwMw==","diff_hunk":"@@ -58,20 +58,36 @@ type Seed struct {\n }\n \n func ReadSeedYaml(fn string) (*Seed, error) {\n+\terrPrefix := \"cannot read seed yaml: \"\n+\n \tyamlData, err := ioutil.ReadFile(fn)\n \tif err != nil {\n-\t\treturn nil, fmt.Errorf(\"cannot read seed yaml: %s\", fn)\n+\t\treturn nil, fmt.Errorf(errPrefix+\"%v\", err)","path":"snap/seed_yaml.go","position":9,"original_position":9,"commit_id":"e68bfcf7b86b4f0287f5573062ebce9cab2d5f43","original_commit_id":"e68bfcf7b86b4f0287f5573062ebce9cab2d5f43","user":{"login":"stolowski","id":168604,"node_id":"MDQ6VXNlcjE2ODYwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/168604?v=4","gravatar_id":"","url":"https://api.github.com/users/stolowski","html_url":"https://github.com/stolowski","followers_url":"https://api.github.com/users/stolowski/followers","following_url":"https://api.github.com/users/stolowski/following{/other_user}","gists_url":"https://api.github.com/users/stolowski/gists{/gist_id}","starred_url":"https://api.github.com/users/stolowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stolowski/subscriptions","organizations_url":"https://api.github.com/users/stolowski/orgs","repos_url":"https://api.github.com/users/stolowski/repos","events_url":"https://api.github.com/users/stolowski/events{/privacy}","received_events_url":"https://api.github.com/users/stolowski/received_events","type":"User","site_admin":false},"body":"Nitpick: looks a bit weird to concatenate errorPrefix that way when using fmt formatting anyway, why not simply `fmt.Errorf(\"%s%v\", errorPrefix, err)` (also below)?","created_at":"2019-04-25T09:13:26Z","updated_at":"2019-04-25T09:14:49Z","html_url":"https://github.com/snapcore/snapd/pull/6771#discussion_r278462403","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/6771","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/278462403"},"html":{"href":"https://github.com/snapcore/snapd/pull/6771#discussion_r278462403"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6771"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/6771","id":273167093,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczMTY3MDkz","html_url":"https://github.com/snapcore/snapd/pull/6771","diff_url":"https://github.com/snapcore/snapd/pull/6771.diff","patch_url":"https://github.com/snapcore/snapd/pull/6771.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/6771","number":6771,"state":"open","locked":false,"title":"cmd: add `snap debug validate-seed <path>` cmd","user":{"login":"mvo5","id":914418,"node_id":"MDQ6VXNlcjkxNDQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"body":"We had a bug where one of the recent livecd-rootfs build images\r\nhad an incorrect seed.yaml. This caused a panic of snapd on when\r\nseeding. To prevent this here is a small helper that we can run\r\ninside livecd-rootfs to ensure seed.yaml is good enough to not\r\ncrash snapd.\r\n\r\nThis is for https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1825437","created_at":"2019-04-24T14:48:45Z","updated_at":"2019-04-25T09:14:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"847fad2279bf8638388c2995ab3b365c01a89882","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/snapcore/snapd/milestones/24","html_url":"https://github.com/snapcore/snapd/milestone/24","labels_url":"https://api.github.com/repos/snapcore/snapd/milestones/24/labels","id":4099487,"node_id":"MDk6TWlsZXN0b25lNDA5OTQ4Nw==","number":24,"title":"2.39","description":"","creator":{"login":"pedronis","id":975757,"node_id":"MDQ6VXNlcjk3NTc1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/975757?v=4","gravatar_id":"","url":"https://api.github.com/users/pedronis","html_url":"https://github.com/pedronis","followers_url":"https://api.github.com/users/pedronis/followers","following_url":"https://api.github.com/users/pedronis/following{/other_user}","gists_url":"https://api.github.com/users/pedronis/gists{/gist_id}","starred_url":"https://api.github.com/users/pedronis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedronis/subscriptions","organizations_url":"https://api.github.com/users/pedronis/orgs","repos_url":"https://api.github.com/users/pedronis/repos","events_url":"https://api.github.com/users/pedronis/events{/privacy}","received_events_url":"https://api.github.com/users/pedronis/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":10,"state":"open","created_at":"2019-03-01T09:52:52Z","updated_at":"2019-04-25T06:40:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/6771/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/6771/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/6771/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/e68bfcf7b86b4f0287f5573062ebce9cab2d5f43","head":{"label":"mvo5:validate-seed","ref":"validate-seed","sha":"e68bfcf7b86b4f0287f5573062ebce9cab2d5f43","user":{"login":"mvo5","id":914418,"node_id":"MDQ6VXNlcjkxNDQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"repo":{"id":45067233,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2NzIzMw==","name":"snappy","full_name":"mvo5/snappy","private":false,"owner":{"login":"mvo5","id":914418,"node_id":"MDQ6VXNlcjkxNDQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mvo5/snappy","description":"Snappy is the software at the heart of Ubuntu Core.","fork":true,"url":"https://api.github.com/repos/mvo5/snappy","forks_url":"https://api.github.com/repos/mvo5/snappy/forks","keys_url":"https://api.github.com/repos/mvo5/snappy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvo5/snappy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvo5/snappy/teams","hooks_url":"https://api.github.com/repos/mvo5/snappy/hooks","issue_events_url":"https://api.github.com/repos/mvo5/snappy/issues/events{/number}","events_url":"https://api.github.com/repos/mvo5/snappy/events","assignees_url":"https://api.github.com/repos/mvo5/snappy/assignees{/user}","branches_url":"https://api.github.com/repos/mvo5/snappy/branches{/branch}","tags_url":"https://api.github.com/repos/mvo5/snappy/tags","blobs_url":"https://api.github.com/repos/mvo5/snappy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvo5/snappy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvo5/snappy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvo5/snappy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvo5/snappy/statuses/{sha}","languages_url":"https://api.github.com/repos/mvo5/snappy/languages","stargazers_url":"https://api.github.com/repos/mvo5/snappy/stargazers","contributors_url":"https://api.github.com/repos/mvo5/snappy/contributors","subscribers_url":"https://api.github.com/repos/mvo5/snappy/subscribers","subscription_url":"https://api.github.com/repos/mvo5/snappy/subscription","commits_url":"https://api.github.com/repos/mvo5/snappy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvo5/snappy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvo5/snappy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvo5/snappy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvo5/snappy/contents/{+path}","compare_url":"https://api.github.com/repos/mvo5/snappy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvo5/snappy/merges","archive_url":"https://api.github.com/repos/mvo5/snappy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvo5/snappy/downloads","issues_url":"https://api.github.com/repos/mvo5/snappy/issues{/number}","pulls_url":"https://api.github.com/repos/mvo5/snappy/pulls{/number}","milestones_url":"https://api.github.com/repos/mvo5/snappy/milestones{/number}","notifications_url":"https://api.github.com/repos/mvo5/snappy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvo5/snappy/labels{/name}","releases_url":"https://api.github.com/repos/mvo5/snappy/releases{/id}","deployments_url":"https://api.github.com/repos/mvo5/snappy/deployments","created_at":"2015-10-27T20:12:18Z","updated_at":"2019-04-25T09:11:41Z","pushed_at":"2019-04-25T09:11:27Z","git_url":"git://github.com/mvo5/snappy.git","ssh_url":"git@github.com:mvo5/snappy.git","clone_url":"https://github.com/mvo5/snappy.git","svn_url":"https://github.com/mvo5/snappy","homepage":null,"size":91324,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"4e68eda844b32923ffa0c7cecd2244b9489a8a65","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"node_id":"MDEwOlJlcG9zaXRvcnk0NDY3Mjc0NA==","name":"snapd","full_name":"snapcore/snapd","private":false,"owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2019-04-25T06:10:57Z","pushed_at":"2019-04-25T08:40:01Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":81799,"stargazers_count":1142,"watchers_count":1142,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":286,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":63,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":286,"open_issues":63,"watchers":1142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6771"},"html":{"href":"https://github.com/snapcore/snapd/pull/6771"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/6771"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/6771/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6771/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6771/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/e68bfcf7b86b4f0287f5573062ebce9cab2d5f43"}},"author_association":"COLLABORATOR"}}
|
{
"id": 44672744,
"name": "snapcore/snapd",
"url": "https://api.github.com/repos/snapcore/snapd"
}
|
{
"id": 168604,
"login": "stolowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168604?",
"url": "https://api.github.com/users/stolowski"
}
|
{
"id": 19532717,
"login": "snapcore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19532717?",
"url": "https://api.github.com/orgs/snapcore"
}
| 2019-04-25T09:13:26 |
9508699131
|
{"actor":{"display_login":"stolowski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/340194063","pull_request_review_id":308660066,"id":340194063,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDE5NDA2Mw==","diff_hunk":"@@ -40,6 +40,11 @@ but it has only been tested on Linux.\n This port will **not** work in Windows Subsystem for Linux (WSL) because WSL\n does not support native 32-bit binaries.\n \n+.. note::\n+ To run the test cases, either via sanitycheck script or manual via\n+ west/cmake, you must have a version of libasan installed (in Ubuntu 18.04\n+ install the libasan4 package).","path":"boards/posix/native_posix/doc/index.rst","position":7,"original_position":7,"commit_id":"83d4f132b3337635b630b11ee589c054c1b4afbb","original_commit_id":"5a17e6038f0e3a4207a92498e5e4a7e4c495673b","user":{"login":"aescolar","id":32480799,"node_id":"MDQ6VXNlcjMyNDgwNzk5","avatar_url":"https://avatars0.githubusercontent.com/u/32480799?v=4","gravatar_id":"","url":"https://api.github.com/users/aescolar","html_url":"https://github.com/aescolar","followers_url":"https://api.github.com/users/aescolar/followers","following_url":"https://api.github.com/users/aescolar/following{/other_user}","gists_url":"https://api.github.com/users/aescolar/gists{/gist_id}","starred_url":"https://api.github.com/users/aescolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aescolar/subscriptions","organizations_url":"https://api.github.com/users/aescolar/orgs","repos_url":"https://api.github.com/users/aescolar/repos","events_url":"https://api.github.com/users/aescolar/events{/privacy}","received_events_url":"https://api.github.com/users/aescolar/received_events","type":"User","site_admin":false},"body":"Please add this dependency to the list of packages in the getting started guide. Too many people are not going to read this note.","created_at":"2019-10-29T16:41:22Z","updated_at":"2019-10-29T16:52:16Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/19093#discussion_r340194063","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/19093","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/340194063"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/19093#discussion_r340194063"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/19093"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/19093","id":316655784,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2NjU1Nzg0","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/19093","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/19093.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/19093.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/19093","number":19093,"state":"open","locked":false,"title":"Enabled ASAN by default while running sanitycheck for native_posix","user":{"login":"vanwinkeljan","id":1586475,"node_id":"MDQ6VXNlcjE1ODY0NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1586475?v=4","gravatar_id":"","url":"https://api.github.com/users/vanwinkeljan","html_url":"https://github.com/vanwinkeljan","followers_url":"https://api.github.com/users/vanwinkeljan/followers","following_url":"https://api.github.com/users/vanwinkeljan/following{/other_user}","gists_url":"https://api.github.com/users/vanwinkeljan/gists{/gist_id}","starred_url":"https://api.github.com/users/vanwinkeljan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanwinkeljan/subscriptions","organizations_url":"https://api.github.com/users/vanwinkeljan/orgs","repos_url":"https://api.github.com/users/vanwinkeljan/repos","events_url":"https://api.github.com/users/vanwinkeljan/events{/privacy}","received_events_url":"https://api.github.com/users/vanwinkeljan/received_events","type":"User","site_admin":false},"body":"Enable address sanitizer for CI test runs\r\n\r\nFixes: #19012\r\nFixes: #20122\r\n\r\n~Blocked by #20160~","created_at":"2019-09-11T22:13:43Z","updated_at":"2019-10-29T16:52:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28068b7c85b8c489b4b32cbd3b73e3382710741d","assignee":{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},"assignees":[{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"galak","id":16417047,"node_id":"MDQ6VXNlcjE2NDE3MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/16417047?v=4","gravatar_id":"","url":"https://api.github.com/users/galak","html_url":"https://github.com/galak","followers_url":"https://api.github.com/users/galak/followers","following_url":"https://api.github.com/users/galak/following{/other_user}","gists_url":"https://api.github.com/users/galak/gists{/gist_id}","starred_url":"https://api.github.com/users/galak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galak/subscriptions","organizations_url":"https://api.github.com/users/galak/orgs","repos_url":"https://api.github.com/users/galak/repos","events_url":"https://api.github.com/users/galak/events{/privacy}","received_events_url":"https://api.github.com/users/galak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":700753703,"node_id":"MDU6TGFiZWw3MDA3NTM3MDM=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Boards","name":"area: Boards","color":"ededed","default":false},{"id":972907894,"node_id":"MDU6TGFiZWw5NzI5MDc4OTQ=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Kconfig","name":"area: Kconfig","color":"ededed","default":false},{"id":1372215310,"node_id":"MDU6TGFiZWwxMzcyMjE1MzEw","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Modules","name":"area: Modules","color":"ededed","default":false},{"id":1063503689,"node_id":"MDU6TGFiZWwxMDYzNTAzNjg5","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Sanitycheck","name":"area: Sanitycheck","color":"ededed","default":false},{"id":787143007,"node_id":"MDU6TGFiZWw3ODcxNDMwMDc=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20native%20port","name":"area: native port","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/19093/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/19093/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/19093/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/83d4f132b3337635b630b11ee589c054c1b4afbb","head":{"label":"vanwinkeljan:sanitycheck_asan","ref":"sanitycheck_asan","sha":"83d4f132b3337635b630b11ee589c054c1b4afbb","user":{"login":"vanwinkeljan","id":1586475,"node_id":"MDQ6VXNlcjE1ODY0NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1586475?v=4","gravatar_id":"","url":"https://api.github.com/users/vanwinkeljan","html_url":"https://github.com/vanwinkeljan","followers_url":"https://api.github.com/users/vanwinkeljan/followers","following_url":"https://api.github.com/users/vanwinkeljan/following{/other_user}","gists_url":"https://api.github.com/users/vanwinkeljan/gists{/gist_id}","starred_url":"https://api.github.com/users/vanwinkeljan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanwinkeljan/subscriptions","organizations_url":"https://api.github.com/users/vanwinkeljan/orgs","repos_url":"https://api.github.com/users/vanwinkeljan/repos","events_url":"https://api.github.com/users/vanwinkeljan/events{/privacy}","received_events_url":"https://api.github.com/users/vanwinkeljan/received_events","type":"User","site_admin":false},"repo":{"id":102777565,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3Nzc1NjU=","name":"zephyr","full_name":"vanwinkeljan/zephyr","private":false,"owner":{"login":"vanwinkeljan","id":1586475,"node_id":"MDQ6VXNlcjE1ODY0NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1586475?v=4","gravatar_id":"","url":"https://api.github.com/users/vanwinkeljan","html_url":"https://github.com/vanwinkeljan","followers_url":"https://api.github.com/users/vanwinkeljan/followers","following_url":"https://api.github.com/users/vanwinkeljan/following{/other_user}","gists_url":"https://api.github.com/users/vanwinkeljan/gists{/gist_id}","starred_url":"https://api.github.com/users/vanwinkeljan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanwinkeljan/subscriptions","organizations_url":"https://api.github.com/users/vanwinkeljan/orgs","repos_url":"https://api.github.com/users/vanwinkeljan/repos","events_url":"https://api.github.com/users/vanwinkeljan/events{/privacy}","received_events_url":"https://api.github.com/users/vanwinkeljan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vanwinkeljan/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/vanwinkeljan/zephyr","forks_url":"https://api.github.com/repos/vanwinkeljan/zephyr/forks","keys_url":"https://api.github.com/repos/vanwinkeljan/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanwinkeljan/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanwinkeljan/zephyr/teams","hooks_url":"https://api.github.com/repos/vanwinkeljan/zephyr/hooks","issue_events_url":"https://api.github.com/repos/vanwinkeljan/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/vanwinkeljan/zephyr/events","assignees_url":"https://api.github.com/repos/vanwinkeljan/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/vanwinkeljan/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/vanwinkeljan/zephyr/tags","blobs_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanwinkeljan/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/vanwinkeljan/zephyr/languages","stargazers_url":"https://api.github.com/repos/vanwinkeljan/zephyr/stargazers","contributors_url":"https://api.github.com/repos/vanwinkeljan/zephyr/contributors","subscribers_url":"https://api.github.com/repos/vanwinkeljan/zephyr/subscribers","subscription_url":"https://api.github.com/repos/vanwinkeljan/zephyr/subscription","commits_url":"https://api.github.com/repos/vanwinkeljan/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanwinkeljan/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanwinkeljan/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanwinkeljan/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/vanwinkeljan/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanwinkeljan/zephyr/merges","archive_url":"https://api.github.com/repos/vanwinkeljan/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanwinkeljan/zephyr/downloads","issues_url":"https://api.github.com/repos/vanwinkeljan/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/vanwinkeljan/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/vanwinkeljan/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/vanwinkeljan/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanwinkeljan/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/vanwinkeljan/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/vanwinkeljan/zephyr/deployments","created_at":"2017-09-07T19:30:18Z","updated_at":"2018-12-01T18:46:11Z","pushed_at":"2019-10-29T16:35:42Z","git_url":"git://github.com/vanwinkeljan/zephyr.git","ssh_url":"git@github.com:vanwinkeljan/zephyr.git","clone_url":"https://github.com/vanwinkeljan/zephyr.git","svn_url":"https://github.com/vanwinkeljan/zephyr","homepage":"http://zephyrproject.org/doc","size":288613,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"wip"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"da5a595f248f4383cf75c8d9902cf7d328caa9d1","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","private":false,"owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2019-10-29T14:51:31Z","pushed_at":"2019-10-29T16:35:45Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":288662,"stargazers_count":2584,"watchers_count":2584,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1557,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1321,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1557,"open_issues":1321,"watchers":2584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/19093"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/19093"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/19093"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/19093/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/19093/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/19093/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/83d4f132b3337635b630b11ee589c054c1b4afbb"}},"author_association":"COLLABORATOR"}}
|
{
"id": 59771425,
"name": "zephyrproject-rtos/zephyr",
"url": "https://api.github.com/repos/zephyrproject-rtos/zephyr"
}
|
{
"id": 32480799,
"login": "aescolar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32480799?",
"url": "https://api.github.com/users/aescolar"
}
|
{
"id": 19595895,
"login": "zephyrproject-rtos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19595895?",
"url": "https://api.github.com/orgs/zephyrproject-rtos"
}
| 2019-10-29T16:41:22 |
10739731123
|
{"actor":{"display_login":"aescolar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/328071835","pull_request_review_id":293010584,"id":328071835,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODA3MTgzNQ==","diff_hunk":"@@ -0,0 +1,98 @@\n+version: 2\n+\n+settings:\n+ gas_price: \"fast\"\n+ chain: any\n+ services:\n+ pfs:\n+ url: https://pfs-goerli-with-fee.services-dev.raiden.network\n+ udc:\n+ enable: true\n+ token:\n+ deposit: true\n+\n+token:\n+ address: \"0x62083c80353Df771426D209eF578619EE68D5C7A\"\n+ balance_min: 1_000_000\n+ balance_fund: 1_000_000\n+\n+nodes:\n+ mode: managed\n+ count: 3\n+ raiden_version: local\n+\n+ default_options:\n+ gas-price: fast\n+ environment-type: development\n+ routing-mode: pfs\n+ pathfinding-max-paths: 5\n+ pathfinding-max-fee: 100\n+ flat-fee:\n+ - \"0x62083c80353Df771426D209eF578619EE68D5C7A\"\n+ - 0\n+ proportional-fee:\n+ - \"0x62083c80353Df771426D209eF578619EE68D5C7A\"\n+ - 0\n+ proportional-imbalance-fee:\n+ - \"0x62083c80353Df771426D209eF578619EE68D5C7A\"\n+ - 10_000\n+\n+## This is the MFEE3 scenario. It creates a network with topology 0 -> 1 -> 2 and checks\n+## whether a path is returned. It also checks that correct imbalance fees are deducted or added in order\n+## to keep the channel imbalances within the desired limits.\n+## For every 10000 TKNs tranferred a fee of 10 TKN is expected.\n+\n+scenario:\n+ serial:\n+ tasks:\n+ - parallel:\n+ name: \"Open channels\"\n+ tasks:\n+ - open_channel: {from: 0, to: 1, total_deposit: 100_000}\n+ - open_channel: {from: 1, to: 2, total_deposit: 100_000}\n+ - serial:\n+ name: \"Test providing routes\"\n+ tasks:\n+ - wait_blocks: 2\n+ # Check that the PFS returns a path from 0 to 3\n+ - transfer: {from: 0, to: 2, amount: 50_000, expected_http_status: 200}\n+\n+ ## Check that the path is indeed the expected one\n+ - assert_pfs_history:\n+ source: 0\n+ request_count: 1\n+ target: 2\n+ expected_routes:\n+ - [0, 1, 2]\n+\n+ # Test that correct imbalance fees were used\n+ # Imbalance fee is 1%\n+ # Fee of fee is 1%","path":"raiden/tests/scenarios/mfee3_imbalance_fee.yaml","position":70,"original_position":70,"commit_id":"af0571ef7ff2a21260ee3c15c0baa156c408f5d0","original_commit_id":"af0571ef7ff2a21260ee3c15c0baa156c408f5d0","user":{"login":"LefterisJP","id":1658405,"node_id":"MDQ6VXNlcjE2NTg0MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1658405?v=4","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"What is fee of fee? The fees I know are: flat, proportional and proportional imbalance","created_at":"2019-09-25T11:38:21Z","updated_at":"2019-09-25T11:39:20Z","html_url":"https://github.com/raiden-network/raiden/pull/4977#discussion_r328071835","pull_request_url":"https://api.github.com/repos/raiden-network/raiden/pulls/4977","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/328071835"},"html":{"href":"https://github.com/raiden-network/raiden/pull/4977#discussion_r328071835"},"pull_request":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/4977"}}},"pull_request":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/4977","id":321151637,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxMTUxNjM3","html_url":"https://github.com/raiden-network/raiden/pull/4977","diff_url":"https://github.com/raiden-network/raiden/pull/4977.diff","patch_url":"https://github.com/raiden-network/raiden/pull/4977.patch","issue_url":"https://api.github.com/repos/raiden-network/raiden/issues/4977","number":4977,"state":"open","locked":false,"title":"Add scenario for imbalance fees [skip tests]","user":{"login":"czepluch","id":1026799,"node_id":"MDQ6VXNlcjEwMjY3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1026799?v=4","gravatar_id":"","url":"https://api.github.com/users/czepluch","html_url":"https://github.com/czepluch","followers_url":"https://api.github.com/users/czepluch/followers","following_url":"https://api.github.com/users/czepluch/following{/other_user}","gists_url":"https://api.github.com/users/czepluch/gists{/gist_id}","starred_url":"https://api.github.com/users/czepluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czepluch/subscriptions","organizations_url":"https://api.github.com/users/czepluch/orgs","repos_url":"https://api.github.com/users/czepluch/repos","events_url":"https://api.github.com/users/czepluch/events{/privacy}","received_events_url":"https://api.github.com/users/czepluch/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/raiden-network/raiden/issues/4969\r\n\r\nThis scenario tests imbalance fees in two direction.\r\n\r\nI am not able to run any scenarios locally at the moment, so I have not yet been able to verify whether the numbers are correct.","created_at":"2019-09-25T09:36:30Z","updated_at":"2019-09-25T11:39:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4164e7cd2707efedaa044156a55afe490b0a16de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":456350195,"node_id":"MDU6TGFiZWw0NTYzNTAxOTU=","url":"https://api.github.com/repos/raiden-network/raiden/labels/dev:%20Please%20Review","name":"dev: Please Review","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/raiden-network/raiden/pulls/4977/commits","review_comments_url":"https://api.github.com/repos/raiden-network/raiden/pulls/4977/comments","review_comment_url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raiden-network/raiden/issues/4977/comments","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/af0571ef7ff2a21260ee3c15c0baa156c408f5d0","head":{"label":"czepluch:imbalance_fee_scenario","ref":"imbalance_fee_scenario","sha":"af0571ef7ff2a21260ee3c15c0baa156c408f5d0","user":{"login":"czepluch","id":1026799,"node_id":"MDQ6VXNlcjEwMjY3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1026799?v=4","gravatar_id":"","url":"https://api.github.com/users/czepluch","html_url":"https://github.com/czepluch","followers_url":"https://api.github.com/users/czepluch/followers","following_url":"https://api.github.com/users/czepluch/following{/other_user}","gists_url":"https://api.github.com/users/czepluch/gists{/gist_id}","starred_url":"https://api.github.com/users/czepluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czepluch/subscriptions","organizations_url":"https://api.github.com/users/czepluch/orgs","repos_url":"https://api.github.com/users/czepluch/repos","events_url":"https://api.github.com/users/czepluch/events{/privacy}","received_events_url":"https://api.github.com/users/czepluch/received_events","type":"User","site_admin":false},"repo":{"id":70597153,"node_id":"MDEwOlJlcG9zaXRvcnk3MDU5NzE1Mw==","name":"raiden","full_name":"czepluch/raiden","private":false,"owner":{"login":"czepluch","id":1026799,"node_id":"MDQ6VXNlcjEwMjY3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1026799?v=4","gravatar_id":"","url":"https://api.github.com/users/czepluch","html_url":"https://github.com/czepluch","followers_url":"https://api.github.com/users/czepluch/followers","following_url":"https://api.github.com/users/czepluch/following{/other_user}","gists_url":"https://api.github.com/users/czepluch/gists{/gist_id}","starred_url":"https://api.github.com/users/czepluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czepluch/subscriptions","organizations_url":"https://api.github.com/users/czepluch/orgs","repos_url":"https://api.github.com/users/czepluch/repos","events_url":"https://api.github.com/users/czepluch/events{/privacy}","received_events_url":"https://api.github.com/users/czepluch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/czepluch/raiden","description":"Raiden Network","fork":true,"url":"https://api.github.com/repos/czepluch/raiden","forks_url":"https://api.github.com/repos/czepluch/raiden/forks","keys_url":"https://api.github.com/repos/czepluch/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/czepluch/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/czepluch/raiden/teams","hooks_url":"https://api.github.com/repos/czepluch/raiden/hooks","issue_events_url":"https://api.github.com/repos/czepluch/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/czepluch/raiden/events","assignees_url":"https://api.github.com/repos/czepluch/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/czepluch/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/czepluch/raiden/tags","blobs_url":"https://api.github.com/repos/czepluch/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/czepluch/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/czepluch/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/czepluch/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/czepluch/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/czepluch/raiden/languages","stargazers_url":"https://api.github.com/repos/czepluch/raiden/stargazers","contributors_url":"https://api.github.com/repos/czepluch/raiden/contributors","subscribers_url":"https://api.github.com/repos/czepluch/raiden/subscribers","subscription_url":"https://api.github.com/repos/czepluch/raiden/subscription","commits_url":"https://api.github.com/repos/czepluch/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/czepluch/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/czepluch/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/czepluch/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/czepluch/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/czepluch/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/czepluch/raiden/merges","archive_url":"https://api.github.com/repos/czepluch/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/czepluch/raiden/downloads","issues_url":"https://api.github.com/repos/czepluch/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/czepluch/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/czepluch/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/czepluch/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/czepluch/raiden/labels{/name}","releases_url":"https://api.github.com/repos/czepluch/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/czepluch/raiden/deployments","created_at":"2016-10-11T13:38:35Z","updated_at":"2016-10-11T13:38:37Z","pushed_at":"2019-09-25T09:34:29Z","git_url":"git://github.com/czepluch/raiden.git","ssh_url":"git@github.com:czepluch/raiden.git","clone_url":"https://github.com/czepluch/raiden.git","svn_url":"https://github.com/czepluch/raiden","homepage":null,"size":21764,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raiden-network:develop","ref":"develop","sha":"198ce54bb57b8da94f4a17eab67caa19cc52e057","user":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"repo":{"id":50646767,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY0Njc2Nw==","name":"raiden","full_name":"raiden-network/raiden","private":false,"owner":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/raiden-network/raiden","description":"Raiden Network","fork":false,"url":"https://api.github.com/repos/raiden-network/raiden","forks_url":"https://api.github.com/repos/raiden-network/raiden/forks","keys_url":"https://api.github.com/repos/raiden-network/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raiden-network/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raiden-network/raiden/teams","hooks_url":"https://api.github.com/repos/raiden-network/raiden/hooks","issue_events_url":"https://api.github.com/repos/raiden-network/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/raiden-network/raiden/events","assignees_url":"https://api.github.com/repos/raiden-network/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/raiden-network/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/raiden-network/raiden/tags","blobs_url":"https://api.github.com/repos/raiden-network/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raiden-network/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raiden-network/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/raiden-network/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/raiden-network/raiden/languages","stargazers_url":"https://api.github.com/repos/raiden-network/raiden/stargazers","contributors_url":"https://api.github.com/repos/raiden-network/raiden/contributors","subscribers_url":"https://api.github.com/repos/raiden-network/raiden/subscribers","subscription_url":"https://api.github.com/repos/raiden-network/raiden/subscription","commits_url":"https://api.github.com/repos/raiden-network/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/raiden-network/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/raiden-network/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/raiden-network/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/raiden-network/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/raiden-network/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raiden-network/raiden/merges","archive_url":"https://api.github.com/repos/raiden-network/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raiden-network/raiden/downloads","issues_url":"https://api.github.com/repos/raiden-network/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/raiden-network/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/raiden-network/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/raiden-network/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raiden-network/raiden/labels{/name}","releases_url":"https://api.github.com/repos/raiden-network/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/raiden-network/raiden/deployments","created_at":"2016-01-29T07:40:47Z","updated_at":"2019-09-25T11:33:50Z","pushed_at":"2019-09-25T11:33:46Z","git_url":"git://github.com/raiden-network/raiden.git","ssh_url":"git@github.com:raiden-network/raiden.git","clone_url":"https://github.com/raiden-network/raiden.git","svn_url":"https://github.com/raiden-network/raiden","homepage":"https://developer.raiden.network","size":21515,"stargazers_count":1743,"watchers_count":1743,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":365,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":329,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":365,"open_issues":329,"watchers":1743,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/4977"},"html":{"href":"https://github.com/raiden-network/raiden/pull/4977"},"issue":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/4977"},"comments":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/4977/comments"},"review_comments":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/4977/comments"},"review_comment":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/4977/commits"},"statuses":{"href":"https://api.github.com/repos/raiden-network/raiden/statuses/af0571ef7ff2a21260ee3c15c0baa156c408f5d0"}},"author_association":"COLLABORATOR"}}
|
{
"id": 50646767,
"name": "raiden-network/raiden",
"url": "https://api.github.com/repos/raiden-network/raiden"
}
|
{
"id": 1658405,
"login": "LefterisJP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1658405?",
"url": "https://api.github.com/users/LefterisJP"
}
|
{
"id": 19666847,
"login": "raiden-network",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19666847?",
"url": "https://api.github.com/orgs/raiden-network"
}
| 2019-09-25T11:38:21 |
10491656100
|
{"actor":{"display_login":"LefterisJP"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/comments/338888464","pull_request_review_id":306985359,"id":338888464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODg4ODQ2NA==","diff_hunk":"@@ -0,0 +1,40 @@\n+\"\"\"\n+Tests for converters (so far only pld2sobp.py)\n+\"\"\"\n+import unittest\n+import logging\n+import pymchelper.utils.mcscripter\n+import pymchelper.run\n+\n+logger = logging.getLogger(__name__)\n+\n+\n+class TestMcScripter(unittest.TestCase):\n+ def test_help(self):\n+ \"\"\" Print usage and exit normally.\n+ \"\"\"\n+ try:\n+ pymchelper.utils.mcscripter.main([])","path":"tests/test_mcscripter.py","position":17,"original_position":17,"commit_id":"ed0b6b276765789d16752c2aac8b2dfb583bf374","original_commit_id":"ed0b6b276765789d16752c2aac8b2dfb583bf374","user":{"login":"grzanka","id":7374733,"node_id":"MDQ6VXNlcjczNzQ3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7374733?v=4","gravatar_id":"","url":"https://api.github.com/users/grzanka","html_url":"https://github.com/grzanka","followers_url":"https://api.github.com/users/grzanka/followers","following_url":"https://api.github.com/users/grzanka/following{/other_user}","gists_url":"https://api.github.com/users/grzanka/gists{/gist_id}","starred_url":"https://api.github.com/users/grzanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzanka/subscriptions","organizations_url":"https://api.github.com/users/grzanka/orgs","repos_url":"https://api.github.com/users/grzanka/repos","events_url":"https://api.github.com/users/grzanka/events{/privacy}","received_events_url":"https://api.github.com/users/grzanka/received_events","type":"User","site_admin":false},"body":"Why do you expect exit code 0 if no arguments to `mcscripter` are provided ?\r\nWith argparse tests will fail. Better to check for exit code 2, or check `--version` option","created_at":"2019-10-25T05:12:19Z","updated_at":"2019-10-25T05:12:19Z","html_url":"https://github.com/DataMedSci/pymchelper/pull/341#discussion_r338888464","pull_request_url":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/341","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/comments/338888464"},"html":{"href":"https://github.com/DataMedSci/pymchelper/pull/341#discussion_r338888464"},"pull_request":{"href":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/341"}}},"pull_request":{"url":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/341","id":331271728,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxMjcxNzI4","html_url":"https://github.com/DataMedSci/pymchelper/pull/341","diff_url":"https://github.com/DataMedSci/pymchelper/pull/341.diff","patch_url":"https://github.com/DataMedSci/pymchelper/pull/341.patch","issue_url":"https://api.github.com/repos/DataMedSci/pymchelper/issues/341","number":341,"state":"open","locked":false,"title":"Feature/338 generalized scripter","user":{"login":"nbassler","id":7140398,"node_id":"MDQ6VXNlcjcxNDAzOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/7140398?v=4","gravatar_id":"","url":"https://api.github.com/users/nbassler","html_url":"https://github.com/nbassler","followers_url":"https://api.github.com/users/nbassler/followers","following_url":"https://api.github.com/users/nbassler/following{/other_user}","gists_url":"https://api.github.com/users/nbassler/gists{/gist_id}","starred_url":"https://api.github.com/users/nbassler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbassler/subscriptions","organizations_url":"https://api.github.com/users/nbassler/orgs","repos_url":"https://api.github.com/users/nbassler/repos","events_url":"https://api.github.com/users/nbassler/events{/privacy}","received_events_url":"https://api.github.com/users/nbassler/received_events","type":"User","site_admin":false},"body":"Closes #338 ","created_at":"2019-10-22T23:49:14Z","updated_at":"2019-10-25T05:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b983c49d862cb05d2e26bf650df5417cd168ac68","assignee":{"login":"grzanka","id":7374733,"node_id":"MDQ6VXNlcjczNzQ3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7374733?v=4","gravatar_id":"","url":"https://api.github.com/users/grzanka","html_url":"https://github.com/grzanka","followers_url":"https://api.github.com/users/grzanka/followers","following_url":"https://api.github.com/users/grzanka/following{/other_user}","gists_url":"https://api.github.com/users/grzanka/gists{/gist_id}","starred_url":"https://api.github.com/users/grzanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzanka/subscriptions","organizations_url":"https://api.github.com/users/grzanka/orgs","repos_url":"https://api.github.com/users/grzanka/repos","events_url":"https://api.github.com/users/grzanka/events{/privacy}","received_events_url":"https://api.github.com/users/grzanka/received_events","type":"User","site_admin":false},"assignees":[{"login":"grzanka","id":7374733,"node_id":"MDQ6VXNlcjczNzQ3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7374733?v=4","gravatar_id":"","url":"https://api.github.com/users/grzanka","html_url":"https://github.com/grzanka","followers_url":"https://api.github.com/users/grzanka/followers","following_url":"https://api.github.com/users/grzanka/following{/other_user}","gists_url":"https://api.github.com/users/grzanka/gists{/gist_id}","starred_url":"https://api.github.com/users/grzanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzanka/subscriptions","organizations_url":"https://api.github.com/users/grzanka/orgs","repos_url":"https://api.github.com/users/grzanka/repos","events_url":"https://api.github.com/users/grzanka/events{/privacy}","received_events_url":"https://api.github.com/users/grzanka/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":502587829,"node_id":"MDU6TGFiZWw1MDI1ODc4Mjk=","url":"https://api.github.com/repos/DataMedSci/pymchelper/labels/ready","name":"ready","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/341/commits","review_comments_url":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/341/comments","review_comment_url":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataMedSci/pymchelper/issues/341/comments","statuses_url":"https://api.github.com/repos/DataMedSci/pymchelper/statuses/ed0b6b276765789d16752c2aac8b2dfb583bf374","head":{"label":"DataMedSci:feature/338-generalized-scripter","ref":"feature/338-generalized-scripter","sha":"ed0b6b276765789d16752c2aac8b2dfb583bf374","user":{"login":"DataMedSci","id":19749591,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzQ5NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/19749591?v=4","gravatar_id":"","url":"https://api.github.com/users/DataMedSci","html_url":"https://github.com/DataMedSci","followers_url":"https://api.github.com/users/DataMedSci/followers","following_url":"https://api.github.com/users/DataMedSci/following{/other_user}","gists_url":"https://api.github.com/users/DataMedSci/gists{/gist_id}","starred_url":"https://api.github.com/users/DataMedSci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataMedSci/subscriptions","organizations_url":"https://api.github.com/users/DataMedSci/orgs","repos_url":"https://api.github.com/users/DataMedSci/repos","events_url":"https://api.github.com/users/DataMedSci/events{/privacy}","received_events_url":"https://api.github.com/users/DataMedSci/received_events","type":"Organization","site_admin":false},"repo":{"id":60605358,"node_id":"MDEwOlJlcG9zaXRvcnk2MDYwNTM1OA==","name":"pymchelper","full_name":"DataMedSci/pymchelper","private":false,"owner":{"login":"DataMedSci","id":19749591,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzQ5NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/19749591?v=4","gravatar_id":"","url":"https://api.github.com/users/DataMedSci","html_url":"https://github.com/DataMedSci","followers_url":"https://api.github.com/users/DataMedSci/followers","following_url":"https://api.github.com/users/DataMedSci/following{/other_user}","gists_url":"https://api.github.com/users/DataMedSci/gists{/gist_id}","starred_url":"https://api.github.com/users/DataMedSci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataMedSci/subscriptions","organizations_url":"https://api.github.com/users/DataMedSci/orgs","repos_url":"https://api.github.com/users/DataMedSci/repos","events_url":"https://api.github.com/users/DataMedSci/events{/privacy}","received_events_url":"https://api.github.com/users/DataMedSci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataMedSci/pymchelper","description":"Python toolkit for SHIELD-HIT12A and FLUKA","fork":false,"url":"https://api.github.com/repos/DataMedSci/pymchelper","forks_url":"https://api.github.com/repos/DataMedSci/pymchelper/forks","keys_url":"https://api.github.com/repos/DataMedSci/pymchelper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataMedSci/pymchelper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataMedSci/pymchelper/teams","hooks_url":"https://api.github.com/repos/DataMedSci/pymchelper/hooks","issue_events_url":"https://api.github.com/repos/DataMedSci/pymchelper/issues/events{/number}","events_url":"https://api.github.com/repos/DataMedSci/pymchelper/events","assignees_url":"https://api.github.com/repos/DataMedSci/pymchelper/assignees{/user}","branches_url":"https://api.github.com/repos/DataMedSci/pymchelper/branches{/branch}","tags_url":"https://api.github.com/repos/DataMedSci/pymchelper/tags","blobs_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataMedSci/pymchelper/statuses/{sha}","languages_url":"https://api.github.com/repos/DataMedSci/pymchelper/languages","stargazers_url":"https://api.github.com/repos/DataMedSci/pymchelper/stargazers","contributors_url":"https://api.github.com/repos/DataMedSci/pymchelper/contributors","subscribers_url":"https://api.github.com/repos/DataMedSci/pymchelper/subscribers","subscription_url":"https://api.github.com/repos/DataMedSci/pymchelper/subscription","commits_url":"https://api.github.com/repos/DataMedSci/pymchelper/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataMedSci/pymchelper/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataMedSci/pymchelper/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataMedSci/pymchelper/contents/{+path}","compare_url":"https://api.github.com/repos/DataMedSci/pymchelper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataMedSci/pymchelper/merges","archive_url":"https://api.github.com/repos/DataMedSci/pymchelper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataMedSci/pymchelper/downloads","issues_url":"https://api.github.com/repos/DataMedSci/pymchelper/issues{/number}","pulls_url":"https://api.github.com/repos/DataMedSci/pymchelper/pulls{/number}","milestones_url":"https://api.github.com/repos/DataMedSci/pymchelper/milestones{/number}","notifications_url":"https://api.github.com/repos/DataMedSci/pymchelper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataMedSci/pymchelper/labels{/name}","releases_url":"https://api.github.com/repos/DataMedSci/pymchelper/releases{/id}","deployments_url":"https://api.github.com/repos/DataMedSci/pymchelper/deployments","created_at":"2016-06-07T10:41:12Z","updated_at":"2019-10-09T13:44:01Z","pushed_at":"2019-10-24T21:28:43Z","git_url":"git://github.com/DataMedSci/pymchelper.git","ssh_url":"git@github.com:DataMedSci/pymchelper.git","clone_url":"https://github.com/DataMedSci/pymchelper.git","svn_url":"https://github.com/DataMedSci/pymchelper","homepage":"","size":2515,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":68,"license":null,"forks":4,"open_issues":68,"watchers":6,"default_branch":"master"}},"base":{"label":"DataMedSci:master","ref":"master","sha":"c4752118dbe861c2edc1012003cd6ff9a3dc44ac","user":{"login":"DataMedSci","id":19749591,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzQ5NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/19749591?v=4","gravatar_id":"","url":"https://api.github.com/users/DataMedSci","html_url":"https://github.com/DataMedSci","followers_url":"https://api.github.com/users/DataMedSci/followers","following_url":"https://api.github.com/users/DataMedSci/following{/other_user}","gists_url":"https://api.github.com/users/DataMedSci/gists{/gist_id}","starred_url":"https://api.github.com/users/DataMedSci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataMedSci/subscriptions","organizations_url":"https://api.github.com/users/DataMedSci/orgs","repos_url":"https://api.github.com/users/DataMedSci/repos","events_url":"https://api.github.com/users/DataMedSci/events{/privacy}","received_events_url":"https://api.github.com/users/DataMedSci/received_events","type":"Organization","site_admin":false},"repo":{"id":60605358,"node_id":"MDEwOlJlcG9zaXRvcnk2MDYwNTM1OA==","name":"pymchelper","full_name":"DataMedSci/pymchelper","private":false,"owner":{"login":"DataMedSci","id":19749591,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzQ5NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/19749591?v=4","gravatar_id":"","url":"https://api.github.com/users/DataMedSci","html_url":"https://github.com/DataMedSci","followers_url":"https://api.github.com/users/DataMedSci/followers","following_url":"https://api.github.com/users/DataMedSci/following{/other_user}","gists_url":"https://api.github.com/users/DataMedSci/gists{/gist_id}","starred_url":"https://api.github.com/users/DataMedSci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataMedSci/subscriptions","organizations_url":"https://api.github.com/users/DataMedSci/orgs","repos_url":"https://api.github.com/users/DataMedSci/repos","events_url":"https://api.github.com/users/DataMedSci/events{/privacy}","received_events_url":"https://api.github.com/users/DataMedSci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataMedSci/pymchelper","description":"Python toolkit for SHIELD-HIT12A and FLUKA","fork":false,"url":"https://api.github.com/repos/DataMedSci/pymchelper","forks_url":"https://api.github.com/repos/DataMedSci/pymchelper/forks","keys_url":"https://api.github.com/repos/DataMedSci/pymchelper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataMedSci/pymchelper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataMedSci/pymchelper/teams","hooks_url":"https://api.github.com/repos/DataMedSci/pymchelper/hooks","issue_events_url":"https://api.github.com/repos/DataMedSci/pymchelper/issues/events{/number}","events_url":"https://api.github.com/repos/DataMedSci/pymchelper/events","assignees_url":"https://api.github.com/repos/DataMedSci/pymchelper/assignees{/user}","branches_url":"https://api.github.com/repos/DataMedSci/pymchelper/branches{/branch}","tags_url":"https://api.github.com/repos/DataMedSci/pymchelper/tags","blobs_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataMedSci/pymchelper/statuses/{sha}","languages_url":"https://api.github.com/repos/DataMedSci/pymchelper/languages","stargazers_url":"https://api.github.com/repos/DataMedSci/pymchelper/stargazers","contributors_url":"https://api.github.com/repos/DataMedSci/pymchelper/contributors","subscribers_url":"https://api.github.com/repos/DataMedSci/pymchelper/subscribers","subscription_url":"https://api.github.com/repos/DataMedSci/pymchelper/subscription","commits_url":"https://api.github.com/repos/DataMedSci/pymchelper/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataMedSci/pymchelper/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataMedSci/pymchelper/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataMedSci/pymchelper/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataMedSci/pymchelper/contents/{+path}","compare_url":"https://api.github.com/repos/DataMedSci/pymchelper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataMedSci/pymchelper/merges","archive_url":"https://api.github.com/repos/DataMedSci/pymchelper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataMedSci/pymchelper/downloads","issues_url":"https://api.github.com/repos/DataMedSci/pymchelper/issues{/number}","pulls_url":"https://api.github.com/repos/DataMedSci/pymchelper/pulls{/number}","milestones_url":"https://api.github.com/repos/DataMedSci/pymchelper/milestones{/number}","notifications_url":"https://api.github.com/repos/DataMedSci/pymchelper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataMedSci/pymchelper/labels{/name}","releases_url":"https://api.github.com/repos/DataMedSci/pymchelper/releases{/id}","deployments_url":"https://api.github.com/repos/DataMedSci/pymchelper/deployments","created_at":"2016-06-07T10:41:12Z","updated_at":"2019-10-09T13:44:01Z","pushed_at":"2019-10-24T21:28:43Z","git_url":"git://github.com/DataMedSci/pymchelper.git","ssh_url":"git@github.com:DataMedSci/pymchelper.git","clone_url":"https://github.com/DataMedSci/pymchelper.git","svn_url":"https://github.com/DataMedSci/pymchelper","homepage":"","size":2515,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":68,"license":null,"forks":4,"open_issues":68,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/341"},"html":{"href":"https://github.com/DataMedSci/pymchelper/pull/341"},"issue":{"href":"https://api.github.com/repos/DataMedSci/pymchelper/issues/341"},"comments":{"href":"https://api.github.com/repos/DataMedSci/pymchelper/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataMedSci/pymchelper/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/DataMedSci/pymchelper/statuses/ed0b6b276765789d16752c2aac8b2dfb583bf374"}},"author_association":"MEMBER"}}
|
{
"id": 60605358,
"name": "DataMedSci/pymchelper",
"url": "https://api.github.com/repos/DataMedSci/pymchelper"
}
|
{
"id": 7374733,
"login": "grzanka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7374733?",
"url": "https://api.github.com/users/grzanka"
}
|
{
"id": 19749591,
"login": "DataMedSci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19749591?",
"url": "https://api.github.com/orgs/DataMedSci"
}
| 2019-10-25T05:12:19 |
10711128409
|
{"actor":{"display_login":"grzanka"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/comments/277140583","pull_request_review_id":228884283,"id":277140583,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzE0MDU4Mw==","diff_hunk":"@@ -176,33 +176,33 @@ def world_championship_podiums\n end\n \n def championship_podiums_with_condition\n- # Get all championship competitions of the given type where the person made it to the finals.\n- # For each of these competitions, get final results only for people eligible for the championship\n- # and reassign their positions. If a result belongs to the person, add it to the array.\n+ # Get all championship competitions of the given type in which the person competed.\n+ # For each of these competitions, get results only for people eligible for the championship\n+ # and reassign their positions. If a podium result belongs to the person, add it to the array.\n [].tap do |championship_podium_results|\n yield(results)\n- .final\n .succeeded\n .order(\"year DESC\")\n .includes(:competition)\n .map(&:competition)\n .uniq\n .each do |competition|\n yield(competition.results)\n- .final\n .succeeded\n- .joins(:event)\n- .order(\"Events.rank, pos\")\n+ .joins(:event, :round_type)\n+ .order(\"Events.rank, RoundTypes.rank DESC, pos\")\n .includes(:format, :competition)\n .group_by(&:eventId)\n- .each_value do |final_results|\n- previous_old_pos = nil\n- previous_new_pos = nil\n- final_results.each_with_index do |result, index|\n- old_pos = result.pos\n- result.pos = (result.pos == previous_old_pos ? previous_new_pos : index + 1)\n- previous_old_pos = old_pos\n- previous_new_pos = result.pos\n+ .each_value do |event_results|\n+ event_results = event_results.uniq(&:personId)\n+ previous_result = nil\n+ event_results.each_with_index do |result, index|\n+ if result.roundTypeId == previous_result&.roundTypeId && result.pos == previous_result&.pos_was","path":"WcaOnRails/app/models/person.rb","position":40,"original_position":40,"commit_id":"7ca08b666478e79c1b7063cba06952cf0024ddea","original_commit_id":"7ca08b666478e79c1b7063cba06952cf0024ddea","user":{"login":"jfly","id":277474,"node_id":"MDQ6VXNlcjI3NzQ3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/277474?v=4","gravatar_id":"","url":"https://api.github.com/users/jfly","html_url":"https://github.com/jfly","followers_url":"https://api.github.com/users/jfly/followers","following_url":"https://api.github.com/users/jfly/following{/other_user}","gists_url":"https://api.github.com/users/jfly/gists{/gist_id}","starred_url":"https://api.github.com/users/jfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfly/subscriptions","organizations_url":"https://api.github.com/users/jfly/orgs","repos_url":"https://api.github.com/users/jfly/repos","events_url":"https://api.github.com/users/jfly/events{/privacy}","received_events_url":"https://api.github.com/users/jfly/received_events","type":"User","site_admin":false},"body":"This call to `.pos_was` reminded me that we're doing this temporary munging of the `pos` attribute, but not writing it to the database. That is kind of weird! It would probably be nice to instead create a custom type (`OpenStruct`?) to return here instead. Definitely not something that needs to happen as part of this PR, just something I realized.","created_at":"2019-04-20T17:07:19Z","updated_at":"2019-04-20T17:18:25Z","html_url":"https://github.com/thewca/worldcubeassociation.org/pull/4070#discussion_r277140583","pull_request_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/4070","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/comments/277140583"},"html":{"href":"https://github.com/thewca/worldcubeassociation.org/pull/4070#discussion_r277140583"},"pull_request":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/4070"}}},"pull_request":{"url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/4070","id":271861922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxODYxOTIy","html_url":"https://github.com/thewca/worldcubeassociation.org/pull/4070","diff_url":"https://github.com/thewca/worldcubeassociation.org/pull/4070.diff","patch_url":"https://github.com/thewca/worldcubeassociation.org/pull/4070.patch","issue_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/4070","number":4070,"state":"open","locked":false,"title":"Change championship title computation to consider all rounds","user":{"login":"jonatanklosko","id":17034772,"node_id":"MDQ6VXNlcjE3MDM0Nzcy","avatar_url":"https://avatars1.githubusercontent.com/u/17034772?v=4","gravatar_id":"","url":"https://api.github.com/users/jonatanklosko","html_url":"https://github.com/jonatanklosko","followers_url":"https://api.github.com/users/jonatanklosko/followers","following_url":"https://api.github.com/users/jonatanklosko/following{/other_user}","gists_url":"https://api.github.com/users/jonatanklosko/gists{/gist_id}","starred_url":"https://api.github.com/users/jonatanklosko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonatanklosko/subscriptions","organizations_url":"https://api.github.com/users/jonatanklosko/orgs","repos_url":"https://api.github.com/users/jonatanklosko/repos","events_url":"https://api.github.com/users/jonatanklosko/events{/privacy}","received_events_url":"https://api.github.com/users/jonatanklosko/received_events","type":"User","site_admin":false},"body":"Currently there are some championships with no champions, because only foreigners made it to the finals ([example](https://www.worldcubeassociation.org/competitions/Andorra2017/results/all#e333_f)). The Board approved taking previous rounds into account. Quoting the verbose description from the corresponding mailing thread:\r\n> we order all results for an event that are eligible to be champions by **round** type then **position**, while keeping only one result per person, and that unambiguously determines the champions","created_at":"2019-04-18T23:04:05Z","updated_at":"2019-04-20T17:18:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d9561009bb5cf4548dcefdcde3b9366db9fcecc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/4070/commits","review_comments_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/4070/comments","review_comment_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/4070/comments","statuses_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/statuses/7ca08b666478e79c1b7063cba06952cf0024ddea","head":{"label":"jonatanklosko:championship-podiums","ref":"championship-podiums","sha":"7ca08b666478e79c1b7063cba06952cf0024ddea","user":{"login":"jonatanklosko","id":17034772,"node_id":"MDQ6VXNlcjE3MDM0Nzcy","avatar_url":"https://avatars1.githubusercontent.com/u/17034772?v=4","gravatar_id":"","url":"https://api.github.com/users/jonatanklosko","html_url":"https://github.com/jonatanklosko","followers_url":"https://api.github.com/users/jonatanklosko/followers","following_url":"https://api.github.com/users/jonatanklosko/following{/other_user}","gists_url":"https://api.github.com/users/jonatanklosko/gists{/gist_id}","starred_url":"https://api.github.com/users/jonatanklosko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonatanklosko/subscriptions","organizations_url":"https://api.github.com/users/jonatanklosko/orgs","repos_url":"https://api.github.com/users/jonatanklosko/repos","events_url":"https://api.github.com/users/jonatanklosko/events{/privacy}","received_events_url":"https://api.github.com/users/jonatanklosko/received_events","type":"User","site_admin":false},"repo":{"id":54846746,"node_id":"MDEwOlJlcG9zaXRvcnk1NDg0Njc0Ng==","name":"worldcubeassociation.org","full_name":"jonatanklosko/worldcubeassociation.org","private":false,"owner":{"login":"jonatanklosko","id":17034772,"node_id":"MDQ6VXNlcjE3MDM0Nzcy","avatar_url":"https://avatars1.githubusercontent.com/u/17034772?v=4","gravatar_id":"","url":"https://api.github.com/users/jonatanklosko","html_url":"https://github.com/jonatanklosko","followers_url":"https://api.github.com/users/jonatanklosko/followers","following_url":"https://api.github.com/users/jonatanklosko/following{/other_user}","gists_url":"https://api.github.com/users/jonatanklosko/gists{/gist_id}","starred_url":"https://api.github.com/users/jonatanklosko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonatanklosko/subscriptions","organizations_url":"https://api.github.com/users/jonatanklosko/orgs","repos_url":"https://api.github.com/users/jonatanklosko/repos","events_url":"https://api.github.com/users/jonatanklosko/events{/privacy}","received_events_url":"https://api.github.com/users/jonatanklosko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jonatanklosko/worldcubeassociation.org","description":"[WCA Project] All of the code that runs on worldcubeassociation.org","fork":true,"url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org","forks_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/deployments","created_at":"2016-03-27T20:29:06Z","updated_at":"2019-04-05T20:35:08Z","pushed_at":"2019-04-18T22:59:15Z","git_url":"git://github.com/jonatanklosko/worldcubeassociation.org.git","ssh_url":"git@github.com:jonatanklosko/worldcubeassociation.org.git","clone_url":"https://github.com/jonatanklosko/worldcubeassociation.org.git","svn_url":"https://github.com/jonatanklosko/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":101265,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"thewca:master","ref":"master","sha":"3a9bbf48e5ab88a6fab98401b5d0108302e3809d","user":{"login":"thewca","id":19806436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODA2NDM2","avatar_url":"https://avatars0.githubusercontent.com/u/19806436?v=4","gravatar_id":"","url":"https://api.github.com/users/thewca","html_url":"https://github.com/thewca","followers_url":"https://api.github.com/users/thewca/followers","following_url":"https://api.github.com/users/thewca/following{/other_user}","gists_url":"https://api.github.com/users/thewca/gists{/gist_id}","starred_url":"https://api.github.com/users/thewca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewca/subscriptions","organizations_url":"https://api.github.com/users/thewca/orgs","repos_url":"https://api.github.com/users/thewca/repos","events_url":"https://api.github.com/users/thewca/events{/privacy}","received_events_url":"https://api.github.com/users/thewca/received_events","type":"Organization","site_admin":false},"repo":{"id":34161579,"node_id":"MDEwOlJlcG9zaXRvcnkzNDE2MTU3OQ==","name":"worldcubeassociation.org","full_name":"thewca/worldcubeassociation.org","private":false,"owner":{"login":"thewca","id":19806436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODA2NDM2","avatar_url":"https://avatars0.githubusercontent.com/u/19806436?v=4","gravatar_id":"","url":"https://api.github.com/users/thewca","html_url":"https://github.com/thewca","followers_url":"https://api.github.com/users/thewca/followers","following_url":"https://api.github.com/users/thewca/following{/other_user}","gists_url":"https://api.github.com/users/thewca/gists{/gist_id}","starred_url":"https://api.github.com/users/thewca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewca/subscriptions","organizations_url":"https://api.github.com/users/thewca/orgs","repos_url":"https://api.github.com/users/thewca/repos","events_url":"https://api.github.com/users/thewca/events{/privacy}","received_events_url":"https://api.github.com/users/thewca/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thewca/worldcubeassociation.org","description":"All of the code that runs on worldcubeassociation.org","fork":false,"url":"https://api.github.com/repos/thewca/worldcubeassociation.org","forks_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/deployments","created_at":"2015-04-18T10:21:53Z","updated_at":"2019-04-20T16:39:15Z","pushed_at":"2019-04-20T16:39:10Z","git_url":"git://github.com/thewca/worldcubeassociation.org.git","ssh_url":"git@github.com:thewca/worldcubeassociation.org.git","clone_url":"https://github.com/thewca/worldcubeassociation.org.git","svn_url":"https://github.com/thewca/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":146569,"stargazers_count":95,"watchers_count":95,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":290,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":77,"open_issues":290,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/4070"},"html":{"href":"https://github.com/thewca/worldcubeassociation.org/pull/4070"},"issue":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/4070"},"comments":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/4070/comments"},"review_comments":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/4070/comments"},"review_comment":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/pulls/4070/commits"},"statuses":{"href":"https://api.github.com/repos/thewca/worldcubeassociation.org/statuses/7ca08b666478e79c1b7063cba06952cf0024ddea"}},"author_association":"MEMBER"}}
|
{
"id": 34161579,
"name": "thewca/worldcubeassociation.org",
"url": "https://api.github.com/repos/thewca/worldcubeassociation.org"
}
|
{
"id": 277474,
"login": "jfly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/277474?",
"url": "https://api.github.com/users/jfly"
}
|
{
"id": 19806436,
"login": "thewca",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19806436?",
"url": "https://api.github.com/orgs/thewca"
}
| 2019-04-20T17:07:19 |
9480380321
|
{"actor":{"display_login":"jfly"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/comments/279810038","pull_request_review_id":232243197,"id":279810038,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTgxMDAzOA==","diff_hunk":"@@ -4,6 +4,20 @@\n [id='configuring-{context}']\n = Configuring {ProductName}\n \n+The service operator configures {ProductName} by defining resources constituting the \"service configuration\". This configuration contains instances of the following resource types:\n+\n+* `AuthenticationService` - Describes an authentication service instance used to authenticate messaging clients.\n+* `AddressSpacePlan` - Describes the messaging resources available for address spaces using this plan, such as the available address plans, the amount of router and broker resources that can be used.\n+* `AddressPlan` - Describes the messaging resources consumed by a particular address using this plan, such as what fraction of routers and brokers an address will use and other properties that should be set for multiple addresses.\n+* `StandardInfraConfig` - Describes the router and broker configuration for the `standard` address space type such as memory limits, storage capacity, affinity and more.\n+* `BrokeredInfraConfig` - Describes the broker configuration for the `brokered` address space type such as memory limits, storage capacity, affainity and more.\n+\n+When created, these resources defines the configuration that are available to the messaging tenants.","path":"documentation/assemblies/assembly-configuring.adoc","position":12,"original_position":12,"commit_id":"ead428e7b37b37bc822e5acb0b7884b794bb9d09","original_commit_id":"ead428e7b37b37bc822e5acb0b7884b794bb9d09","user":{"login":"jenmalloy","id":19193696,"node_id":"MDQ6VXNlcjE5MTkzNjk2","avatar_url":"https://avatars2.githubusercontent.com/u/19193696?v=4","gravatar_id":"","url":"https://api.github.com/users/jenmalloy","html_url":"https://github.com/jenmalloy","followers_url":"https://api.github.com/users/jenmalloy/followers","following_url":"https://api.github.com/users/jenmalloy/following{/other_user}","gists_url":"https://api.github.com/users/jenmalloy/gists{/gist_id}","starred_url":"https://api.github.com/users/jenmalloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenmalloy/subscriptions","organizations_url":"https://api.github.com/users/jenmalloy/orgs","repos_url":"https://api.github.com/users/jenmalloy/repos","events_url":"https://api.github.com/users/jenmalloy/events{/privacy}","received_events_url":"https://api.github.com/users/jenmalloy/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nWhen created, these resources define the configuration that is available to the messaging tenants.\r\n```","created_at":"2019-04-30T15:31:59Z","updated_at":"2019-04-30T15:37:36Z","html_url":"https://github.com/EnMasseProject/enmasse/pull/2755#discussion_r279810038","pull_request_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/2755","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/comments/279810038"},"html":{"href":"https://github.com/EnMasseProject/enmasse/pull/2755#discussion_r279810038"},"pull_request":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/2755"}}},"pull_request":{"url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/2755","id":274717392,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NzE3Mzky","html_url":"https://github.com/EnMasseProject/enmasse/pull/2755","diff_url":"https://github.com/EnMasseProject/enmasse/pull/2755.diff","patch_url":"https://github.com/EnMasseProject/enmasse/pull/2755.patch","issue_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues/2755","number":2755,"state":"open","locked":false,"title":"Improve plan documentation","user":{"login":"lulf","id":19670,"node_id":"MDQ6VXNlcjE5Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/19670?v=4","gravatar_id":"","url":"https://api.github.com/users/lulf","html_url":"https://github.com/lulf","followers_url":"https://api.github.com/users/lulf/followers","following_url":"https://api.github.com/users/lulf/following{/other_user}","gists_url":"https://api.github.com/users/lulf/gists{/gist_id}","starred_url":"https://api.github.com/users/lulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lulf/subscriptions","organizations_url":"https://api.github.com/users/lulf/orgs","repos_url":"https://api.github.com/users/lulf/repos","events_url":"https://api.github.com/users/lulf/events{/privacy}","received_events_url":"https://api.github.com/users/lulf/received_events","type":"User","site_admin":false},"body":"* Add image describing relationship between different service\r\nconfiguration entities.\r\n* Add introductory paragraph to the 'Configuring' section of the service\r\nadmin book.\r\n* Improve plan examples and inline.","created_at":"2019-04-30T12:49:44Z","updated_at":"2019-04-30T15:37:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daf56caff338f04490b69ef82f4d50927d3b9ddf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":711505568,"node_id":"MDU6TGFiZWw3MTE1MDU1Njg=","url":"https://api.github.com/repos/EnMasseProject/enmasse/labels/Peer%20Review%20Needed","name":"Peer Review Needed","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/2755/commits","review_comments_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/2755/comments","review_comment_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues/2755/comments","statuses_url":"https://api.github.com/repos/EnMasseProject/enmasse/statuses/ead428e7b37b37bc822e5acb0b7884b794bb9d09","head":{"label":"lulf:improve-plan-docs","ref":"improve-plan-docs","sha":"ead428e7b37b37bc822e5acb0b7884b794bb9d09","user":{"login":"lulf","id":19670,"node_id":"MDQ6VXNlcjE5Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/19670?v=4","gravatar_id":"","url":"https://api.github.com/users/lulf","html_url":"https://github.com/lulf","followers_url":"https://api.github.com/users/lulf/followers","following_url":"https://api.github.com/users/lulf/following{/other_user}","gists_url":"https://api.github.com/users/lulf/gists{/gist_id}","starred_url":"https://api.github.com/users/lulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lulf/subscriptions","organizations_url":"https://api.github.com/users/lulf/orgs","repos_url":"https://api.github.com/users/lulf/repos","events_url":"https://api.github.com/users/lulf/events{/privacy}","received_events_url":"https://api.github.com/users/lulf/received_events","type":"User","site_admin":false},"repo":{"id":135259492,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyNTk0OTI=","name":"enmasse","full_name":"lulf/enmasse","private":false,"owner":{"login":"lulf","id":19670,"node_id":"MDQ6VXNlcjE5Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/19670?v=4","gravatar_id":"","url":"https://api.github.com/users/lulf","html_url":"https://github.com/lulf","followers_url":"https://api.github.com/users/lulf/followers","following_url":"https://api.github.com/users/lulf/following{/other_user}","gists_url":"https://api.github.com/users/lulf/gists{/gist_id}","starred_url":"https://api.github.com/users/lulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lulf/subscriptions","organizations_url":"https://api.github.com/users/lulf/orgs","repos_url":"https://api.github.com/users/lulf/repos","events_url":"https://api.github.com/users/lulf/events{/privacy}","received_events_url":"https://api.github.com/users/lulf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lulf/enmasse","description":"EnMasse main repository","fork":true,"url":"https://api.github.com/repos/lulf/enmasse","forks_url":"https://api.github.com/repos/lulf/enmasse/forks","keys_url":"https://api.github.com/repos/lulf/enmasse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lulf/enmasse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lulf/enmasse/teams","hooks_url":"https://api.github.com/repos/lulf/enmasse/hooks","issue_events_url":"https://api.github.com/repos/lulf/enmasse/issues/events{/number}","events_url":"https://api.github.com/repos/lulf/enmasse/events","assignees_url":"https://api.github.com/repos/lulf/enmasse/assignees{/user}","branches_url":"https://api.github.com/repos/lulf/enmasse/branches{/branch}","tags_url":"https://api.github.com/repos/lulf/enmasse/tags","blobs_url":"https://api.github.com/repos/lulf/enmasse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lulf/enmasse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lulf/enmasse/git/refs{/sha}","trees_url":"https://api.github.com/repos/lulf/enmasse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lulf/enmasse/statuses/{sha}","languages_url":"https://api.github.com/repos/lulf/enmasse/languages","stargazers_url":"https://api.github.com/repos/lulf/enmasse/stargazers","contributors_url":"https://api.github.com/repos/lulf/enmasse/contributors","subscribers_url":"https://api.github.com/repos/lulf/enmasse/subscribers","subscription_url":"https://api.github.com/repos/lulf/enmasse/subscription","commits_url":"https://api.github.com/repos/lulf/enmasse/commits{/sha}","git_commits_url":"https://api.github.com/repos/lulf/enmasse/git/commits{/sha}","comments_url":"https://api.github.com/repos/lulf/enmasse/comments{/number}","issue_comment_url":"https://api.github.com/repos/lulf/enmasse/issues/comments{/number}","contents_url":"https://api.github.com/repos/lulf/enmasse/contents/{+path}","compare_url":"https://api.github.com/repos/lulf/enmasse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lulf/enmasse/merges","archive_url":"https://api.github.com/repos/lulf/enmasse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lulf/enmasse/downloads","issues_url":"https://api.github.com/repos/lulf/enmasse/issues{/number}","pulls_url":"https://api.github.com/repos/lulf/enmasse/pulls{/number}","milestones_url":"https://api.github.com/repos/lulf/enmasse/milestones{/number}","notifications_url":"https://api.github.com/repos/lulf/enmasse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lulf/enmasse/labels{/name}","releases_url":"https://api.github.com/repos/lulf/enmasse/releases{/id}","deployments_url":"https://api.github.com/repos/lulf/enmasse/deployments","created_at":"2018-05-29T07:40:48Z","updated_at":"2019-04-29T13:54:36Z","pushed_at":"2019-04-30T12:49:30Z","git_url":"git://github.com/lulf/enmasse.git","ssh_url":"git@github.com:lulf/enmasse.git","clone_url":"https://github.com/lulf/enmasse.git","svn_url":"https://github.com/lulf/enmasse","homepage":"","size":56685,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EnMasseProject:master","ref":"master","sha":"00b8dcdde3988c6cb227f1d53587c0bc8d7935c2","user":{"login":"EnMasseProject","id":19907745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTA3NzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/19907745?v=4","gravatar_id":"","url":"https://api.github.com/users/EnMasseProject","html_url":"https://github.com/EnMasseProject","followers_url":"https://api.github.com/users/EnMasseProject/followers","following_url":"https://api.github.com/users/EnMasseProject/following{/other_user}","gists_url":"https://api.github.com/users/EnMasseProject/gists{/gist_id}","starred_url":"https://api.github.com/users/EnMasseProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnMasseProject/subscriptions","organizations_url":"https://api.github.com/users/EnMasseProject/orgs","repos_url":"https://api.github.com/users/EnMasseProject/repos","events_url":"https://api.github.com/users/EnMasseProject/events{/privacy}","received_events_url":"https://api.github.com/users/EnMasseProject/received_events","type":"Organization","site_admin":false},"repo":{"id":62793144,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjc5MzE0NA==","name":"enmasse","full_name":"EnMasseProject/enmasse","private":false,"owner":{"login":"EnMasseProject","id":19907745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTA3NzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/19907745?v=4","gravatar_id":"","url":"https://api.github.com/users/EnMasseProject","html_url":"https://github.com/EnMasseProject","followers_url":"https://api.github.com/users/EnMasseProject/followers","following_url":"https://api.github.com/users/EnMasseProject/following{/other_user}","gists_url":"https://api.github.com/users/EnMasseProject/gists{/gist_id}","starred_url":"https://api.github.com/users/EnMasseProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnMasseProject/subscriptions","organizations_url":"https://api.github.com/users/EnMasseProject/orgs","repos_url":"https://api.github.com/users/EnMasseProject/repos","events_url":"https://api.github.com/users/EnMasseProject/events{/privacy}","received_events_url":"https://api.github.com/users/EnMasseProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EnMasseProject/enmasse","description":"EnMasse - Self-service messaging on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/EnMasseProject/enmasse","forks_url":"https://api.github.com/repos/EnMasseProject/enmasse/forks","keys_url":"https://api.github.com/repos/EnMasseProject/enmasse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnMasseProject/enmasse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnMasseProject/enmasse/teams","hooks_url":"https://api.github.com/repos/EnMasseProject/enmasse/hooks","issue_events_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues/events{/number}","events_url":"https://api.github.com/repos/EnMasseProject/enmasse/events","assignees_url":"https://api.github.com/repos/EnMasseProject/enmasse/assignees{/user}","branches_url":"https://api.github.com/repos/EnMasseProject/enmasse/branches{/branch}","tags_url":"https://api.github.com/repos/EnMasseProject/enmasse/tags","blobs_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnMasseProject/enmasse/statuses/{sha}","languages_url":"https://api.github.com/repos/EnMasseProject/enmasse/languages","stargazers_url":"https://api.github.com/repos/EnMasseProject/enmasse/stargazers","contributors_url":"https://api.github.com/repos/EnMasseProject/enmasse/contributors","subscribers_url":"https://api.github.com/repos/EnMasseProject/enmasse/subscribers","subscription_url":"https://api.github.com/repos/EnMasseProject/enmasse/subscription","commits_url":"https://api.github.com/repos/EnMasseProject/enmasse/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnMasseProject/enmasse/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnMasseProject/enmasse/contents/{+path}","compare_url":"https://api.github.com/repos/EnMasseProject/enmasse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnMasseProject/enmasse/merges","archive_url":"https://api.github.com/repos/EnMasseProject/enmasse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnMasseProject/enmasse/downloads","issues_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues{/number}","pulls_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls{/number}","milestones_url":"https://api.github.com/repos/EnMasseProject/enmasse/milestones{/number}","notifications_url":"https://api.github.com/repos/EnMasseProject/enmasse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnMasseProject/enmasse/labels{/name}","releases_url":"https://api.github.com/repos/EnMasseProject/enmasse/releases{/id}","deployments_url":"https://api.github.com/repos/EnMasseProject/enmasse/deployments","created_at":"2016-07-07T09:18:27Z","updated_at":"2019-04-30T09:14:46Z","pushed_at":"2019-04-30T14:47:44Z","git_url":"git://github.com/EnMasseProject/enmasse.git","ssh_url":"git@github.com:EnMasseProject/enmasse.git","clone_url":"https://github.com/EnMasseProject/enmasse.git","svn_url":"https://github.com/EnMasseProject/enmasse","homepage":"http://enmasse.io","size":54998,"stargazers_count":133,"watchers_count":133,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":208,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":58,"open_issues":208,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/2755"},"html":{"href":"https://github.com/EnMasseProject/enmasse/pull/2755"},"issue":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/issues/2755"},"comments":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/issues/2755/comments"},"review_comments":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/2755/comments"},"review_comment":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/2755/commits"},"statuses":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/statuses/ead428e7b37b37bc822e5acb0b7884b794bb9d09"}},"author_association":"MEMBER"}}
|
{
"id": 62793144,
"name": "EnMasseProject/enmasse",
"url": "https://api.github.com/repos/EnMasseProject/enmasse"
}
|
{
"id": 19193696,
"login": "jenmalloy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19193696?",
"url": "https://api.github.com/users/jenmalloy"
}
|
{
"id": 19907745,
"login": "EnMasseProject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19907745?",
"url": "https://api.github.com/orgs/EnMasseProject"
}
| 2019-04-30T15:31:59 |
9538875536
|
{"actor":{"display_login":"jenmalloy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3/pulls/comments/289540362","pull_request_review_id":244505954,"id":289540362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4OTU0MDM2Mg==","diff_hunk":"@@ -87,13 +87,12 @@ func (h *PromReadInstantHandler) ServeHTTP(w http.ResponseWriter, r *http.Reques\n \t\treturn\n \t}\n \n-\tengineOpts := &executor.EngineOptions{\n-\t\tQueryContextOptions: models.QueryContextOptions{\n-\t\t\tLimitMaxTimeseries: fetchOpts.Limit,\n-\t\t},\n-\t}\n+\tengineOpts := h.engine.Opts().SetQueryContextOptions(models.QueryContextOptions{\n+\t\tLimitMaxTimeseries: fetchOpts.Limit,\n+\t})\n+\th.engine = h.engine.SetOpts(engineOpts)","path":"src/query/api/v1/handler/prometheus/native/read_instantaneous.go","position":30,"original_position":30,"commit_id":"ecb601ba1f2894061394bcf858c5ab1e3b4b6d8d","original_commit_id":"ecb601ba1f2894061394bcf858c5ab1e3b4b6d8d","user":{"login":"arnikola","id":14959893,"node_id":"MDQ6VXNlcjE0OTU5ODkz","avatar_url":"https://avatars0.githubusercontent.com/u/14959893?v=4","gravatar_id":"","url":"https://api.github.com/users/arnikola","html_url":"https://github.com/arnikola","followers_url":"https://api.github.com/users/arnikola/followers","following_url":"https://api.github.com/users/arnikola/following{/other_user}","gists_url":"https://api.github.com/users/arnikola/gists{/gist_id}","starred_url":"https://api.github.com/users/arnikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnikola/subscriptions","organizations_url":"https://api.github.com/users/arnikola/orgs","repos_url":"https://api.github.com/users/arnikola/repos","events_url":"https://api.github.com/users/arnikola/events{/privacy}","received_events_url":"https://api.github.com/users/arnikola/received_events","type":"User","site_admin":false},"body":"Again, this feels racy","created_at":"2019-05-31T20:29:12Z","updated_at":"2019-05-31T20:29:13Z","html_url":"https://github.com/m3db/m3/pull/1690#discussion_r289540362","pull_request_url":"https://api.github.com/repos/m3db/m3/pulls/1690","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3/pulls/comments/289540362"},"html":{"href":"https://github.com/m3db/m3/pull/1690#discussion_r289540362"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3/pulls/1690"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/m3/pulls/1690","id":284161585,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0MTYxNTg1","html_url":"https://github.com/m3db/m3/pull/1690","diff_url":"https://github.com/m3db/m3/pull/1690.diff","patch_url":"https://github.com/m3db/m3/pull/1690.patch","issue_url":"https://api.github.com/repos/m3db/m3/issues/1690","number":1690,"state":"open","locked":false,"title":"[query]Make executor engine an interface","user":{"login":"benraskin92","id":4688976,"node_id":"MDQ6VXNlcjQ2ODg5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4688976?v=4","gravatar_id":"","url":"https://api.github.com/users/benraskin92","html_url":"https://github.com/benraskin92","followers_url":"https://api.github.com/users/benraskin92/followers","following_url":"https://api.github.com/users/benraskin92/following{/other_user}","gists_url":"https://api.github.com/users/benraskin92/gists{/gist_id}","starred_url":"https://api.github.com/users/benraskin92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benraskin92/subscriptions","organizations_url":"https://api.github.com/users/benraskin92/orgs","repos_url":"https://api.github.com/users/benraskin92/repos","events_url":"https://api.github.com/users/benraskin92/events{/privacy}","received_events_url":"https://api.github.com/users/benraskin92/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first time, please read our contributor guidelines: https://github.com/m3db/m3/blob/master/CONTRIBUTING.md and developer notes https://github.com/m3db/m3/blob/master/DEVELOPER.md\r\n2. Please prefix the name of the pull request with the component you are updating in the format \"[component] Change title\" (for example \"[dbnode] Support out of order writes\") and also label this pull request according to what type of issue you are addressing. Furthermore, if this is a WIP or DRAFT PR, please create a draft PR instead: https://github.blog/2019-02-14-introducing-draft-pull-requests/\r\n3. Ensure you have added or ran the appropriate tests for your PR: read more at https://github.com/m3db/m3/blob/master/DEVELOPER.md#testing-changes\r\n4. Follow the instructions for writing a changelog note: read more at https://github.com/m3db/m3/blob/master/DEVELOPER.md#adding-a-changelog\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n<!--\r\nIf you have an issue this change addresses, please add the following details:\r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n-->\r\nThis PR turns the engine in `query/executor` into an interface. This will allow us to better test queries as we can easily mock out the engine.\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing and/or backwards incompatible change?**:\r\n<!--\r\nIf no, just write \"NONE\" in the release-note block below.\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n\r\n**Does this PR require updating code package or user-facing documentation?**:\r\n<!--\r\nIf no, just write \"NONE\" in the documentation-note block below.\r\nIf yes, describe which documentation you updated.\r\nNote: Any changes that significantly updates how a code package is architectured or functions requires code package documentation updates in the form of updates to the README.md file in that package.\r\n-->\r\n```documentation-note\r\nNONE\r\n```\r\n","created_at":"2019-05-31T19:10:20Z","updated_at":"2019-05-31T20:29:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b1fe9ec9da3ac84826a51286357f8df127f0fc2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"robskillington","id":339615,"node_id":"MDQ6VXNlcjMzOTYxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/339615?v=4","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3/pulls/1690/commits","review_comments_url":"https://api.github.com/repos/m3db/m3/pulls/1690/comments","review_comment_url":"https://api.github.com/repos/m3db/m3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3/issues/1690/comments","statuses_url":"https://api.github.com/repos/m3db/m3/statuses/ecb601ba1f2894061394bcf858c5ab1e3b4b6d8d","head":{"label":"m3db:braskin/engine-interface","ref":"braskin/engine-interface","sha":"ecb601ba1f2894061394bcf858c5ab1e3b4b6d8d","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE1MzY3Nw==","name":"m3","full_name":"m3db/m3","private":false,"owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/m3db/m3","description":"M3 monorepo - Distributed TSDB, Aggregator and Query Engine, Prometheus Sidecar, Graphite Compatible, Metrics Platform","fork":false,"url":"https://api.github.com/repos/m3db/m3","forks_url":"https://api.github.com/repos/m3db/m3/forks","keys_url":"https://api.github.com/repos/m3db/m3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3/teams","hooks_url":"https://api.github.com/repos/m3db/m3/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3/events","assignees_url":"https://api.github.com/repos/m3db/m3/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3/tags","blobs_url":"https://api.github.com/repos/m3db/m3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3/languages","stargazers_url":"https://api.github.com/repos/m3db/m3/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3/subscription","commits_url":"https://api.github.com/repos/m3db/m3/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3/merges","archive_url":"https://api.github.com/repos/m3db/m3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3/downloads","issues_url":"https://api.github.com/repos/m3db/m3/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2019-05-31T19:45:05Z","pushed_at":"2019-05-31T19:56:40Z","git_url":"git://github.com/m3db/m3.git","ssh_url":"git@github.com:m3db/m3.git","clone_url":"https://github.com/m3db/m3.git","svn_url":"https://github.com/m3db/m3","homepage":"https://m3db.io/","size":49636,"stargazers_count":1836,"watchers_count":1836,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":153,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":225,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":153,"open_issues":225,"watchers":1836,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"7a89168054f01ebd67226c76d40d9c953c8712dc","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE1MzY3Nw==","name":"m3","full_name":"m3db/m3","private":false,"owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/m3db/m3","description":"M3 monorepo - Distributed TSDB, Aggregator and Query Engine, Prometheus Sidecar, Graphite Compatible, Metrics Platform","fork":false,"url":"https://api.github.com/repos/m3db/m3","forks_url":"https://api.github.com/repos/m3db/m3/forks","keys_url":"https://api.github.com/repos/m3db/m3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3/teams","hooks_url":"https://api.github.com/repos/m3db/m3/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3/events","assignees_url":"https://api.github.com/repos/m3db/m3/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3/tags","blobs_url":"https://api.github.com/repos/m3db/m3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3/languages","stargazers_url":"https://api.github.com/repos/m3db/m3/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3/subscription","commits_url":"https://api.github.com/repos/m3db/m3/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3/merges","archive_url":"https://api.github.com/repos/m3db/m3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3/downloads","issues_url":"https://api.github.com/repos/m3db/m3/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2019-05-31T19:45:05Z","pushed_at":"2019-05-31T19:56:40Z","git_url":"git://github.com/m3db/m3.git","ssh_url":"git@github.com:m3db/m3.git","clone_url":"https://github.com/m3db/m3.git","svn_url":"https://github.com/m3db/m3","homepage":"https://m3db.io/","size":49636,"stargazers_count":1836,"watchers_count":1836,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":153,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":225,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":153,"open_issues":225,"watchers":1836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3/pulls/1690"},"html":{"href":"https://github.com/m3db/m3/pull/1690"},"issue":{"href":"https://api.github.com/repos/m3db/m3/issues/1690"},"comments":{"href":"https://api.github.com/repos/m3db/m3/issues/1690/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3/pulls/1690/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3/pulls/1690/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3/statuses/ecb601ba1f2894061394bcf858c5ab1e3b4b6d8d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 61153677,
"name": "m3db/m3",
"url": "https://api.github.com/repos/m3db/m3"
}
|
{
"id": 14959893,
"login": "arnikola",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14959893?",
"url": "https://api.github.com/users/arnikola"
}
|
{
"id": 19937171,
"login": "m3db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19937171?",
"url": "https://api.github.com/orgs/m3db"
}
| 2019-05-31T20:29:12 |
9737479314
|
{"actor":{"display_login":"arnikola"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/iotaledger/iri/pulls/comments/364030348","pull_request_review_id":339605811,"id":364030348,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDAzMDM0OA==","diff_hunk":"@@ -75,3 +78,100 @@ def read_ls_metadata(step, node):\n for hash_val in hashes:\n assert hash_val in node_metadata, \"Provided hash: {} was not found in the snapshot metadata\".format(hash_val)\n logger.info(\"Snapshot Metadata contains the provided hashes.\")\n+\n+\n+@step(r'the spent addresses are exported from \"([^\"]+)\"')\n+def export_spent_addresses(step, node):\n+ \"\"\"\n+ Uses an ixi module to export the spent addresses from the current node to a text file.\n+\n+ :param node: The node that the spent addresses will be pulled from\n+ \"\"\"\n+ command = {\"command\": \"export-spent.generateSpentAddressesFile\"}\n+ request_return = api_utils.send_ixi_request(node, command)\n+ assert 'ixi' in request_return, \"Error: {}\".format(request_return['error'])\n+\n+ num_exports = request_return['ixi']['amount']\n+ checksum = request_return['ixi']['checksum']\n+\n+ # Change these assertion value with the appropriate ones if you have used a custom db and not the provided one\n+ expected_num_exports = 74\n+ expected_checksum = \"919432abf85f939057f020d1a589f4d5513ff8890b0fb6b8e2242f90fa9158bc\"\n+\n+ assert num_exports == expected_num_exports, \\\n+ \"Expected to export {} addresses, instead exported {}\".format(expected_num_exports, num_exports)\n+ assert checksum == expected_checksum, \\\n+ \"The checksum {} does not match the expected: {}\".format(checksum, expected_checksum)\n+\n+ logger.info(\"Spent addresses file exported as: {}\".format(request_return['ixi']['fileName']))\n+\n+ try:\n+ podname = world.machine['nodes'][node]['podname']\n+ config.load_kube_config()\n+ v1 = client.CoreV1Api()\n+ response = stream(v1.connect_get_namespaced_pod_exec,\n+ podname, 'default',\n+ command=['cat', '/iri/data/spentAddresses.txt'],\n+ stderr=True, stdin=True, stdout=True, tty=False,\n+ _preload_content=False)\n+\n+ while response.is_open():\n+ response.update(timeout=1)\n+ if response.peek_stdout():\n+ f = open(\"/tmp/spentAddresses.txt\", \"w+\")\n+ f.write(response.read_stdout())\n+\n+ except:\n+ logger.info(\"No pod name found, skipping file transfer from k8s pod\")\n+\n+\n+@step(r'the spent addresses are imported on \"([^\"]+)\" from:')\n+def merge_spent_addresses_file(step, node):\n+ \"\"\"\n+ Reads the spentAddresses.txt file using the specified path and file name in the Gherkin options, and merges it into\n+ the provided node. Then the return values for the IXI call are checked to make sure no failures occurred.\n+\n+ :param node: The node that the spent addresses will be merged into\n+ \"\"\"\n+ args = step.hashes\n+ for x in range(len(args)):\n+ key = args[x]['keys']\n+ value = args[x]['values']\n+\n+ if key == 'basePath':\n+ base_path = value\n+ elif key == 'file':\n+ file_name = value\n+\n+ spent_addresses_file = base_path + file_name\n+ logger.info(spent_addresses_file)\n+ command = {\"command\": \"merge-spent.mergeSpentAddresses\", \"files\": [spent_addresses_file]}\n+ request_return = api_utils.send_ixi_request(node, command)\n+ assert 'ixi' in request_return, \"Error: {}\".format(request_return['error'])\n+\n+ failures = request_return['ixi']['errors']\n+ assert len(failures) == 0, \"There were failures in the merge request: {}\".format(failures)\n+\n+\n+@step(r'reading the exported spent addresses file on \"([^\"]+)\" returns with:')\n+def read_spent_addresses_file(step, node):\n+ \"\"\"\n+ Reads the spentAddresses.txt file that should be present on the node, and ensures the expected values are there.\n+\n+ :param step.hashes: The pointer to the expected values that should be present in the file\n+ :param node: The node whose exported spent addresses file will be read\n+ \"\"\"\n+ arg_list = step.hashes\n+\n+ options = {}\n+ api_utils.prepare_options(arg_list, options)\n+\n+ logger.info(\"###Current directory: \".join(os.listdir(\"./\")))\n+ logger.info(\"###Tmp: \".join(os.listdir(\"/tmp/\")))\n+ file_name = '/tmp/spentAddresses.txt'","path":"python-regression/tests/features/steps/local_snapshots_steps.py","position":104,"original_position":104,"commit_id":"5feb1b95866dba97a5b0548318abe696936e9340","original_commit_id":"5feb1b95866dba97a5b0548318abe696936e9340","user":{"login":"GalRogozinski","id":7954839,"node_id":"MDQ6VXNlcjc5NTQ4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7954839?v=4","gravatar_id":"","url":"https://api.github.com/users/GalRogozinski","html_url":"https://github.com/GalRogozinski","followers_url":"https://api.github.com/users/GalRogozinski/followers","following_url":"https://api.github.com/users/GalRogozinski/following{/other_user}","gists_url":"https://api.github.com/users/GalRogozinski/gists{/gist_id}","starred_url":"https://api.github.com/users/GalRogozinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalRogozinski/subscriptions","organizations_url":"https://api.github.com/users/GalRogozinski/orgs","repos_url":"https://api.github.com/users/GalRogozinski/repos","events_url":"https://api.github.com/users/GalRogozinski/events{/privacy}","received_events_url":"https://api.github.com/users/GalRogozinski/received_events","type":"User","site_admin":false},"body":" Issue found: [Probable insecure usage of temp file/directory.](https://app.codacy.com/manual/GalRogozinski/iri/pullRequest?prid=3955655)","created_at":"2020-01-08T01:32:30Z","updated_at":"2020-01-08T01:32:30Z","html_url":"https://github.com/iotaledger/iri/pull/1561#discussion_r364030348","pull_request_url":"https://api.github.com/repos/iotaledger/iri/pulls/1561","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/comments/364030348"},"html":{"href":"https://github.com/iotaledger/iri/pull/1561#discussion_r364030348"},"pull_request":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1561"}}},"pull_request":{"url":"https://api.github.com/repos/iotaledger/iri/pulls/1561","id":304086800,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0MDg2ODAw","html_url":"https://github.com/iotaledger/iri/pull/1561","diff_url":"https://github.com/iotaledger/iri/pull/1561.diff","patch_url":"https://github.com/iotaledger/iri/pull/1561.patch","issue_url":"https://api.github.com/repos/iotaledger/iri/issues/1561","number":1561,"state":"open","locked":false,"title":"Add spent addresses export test","user":{"login":"DyrellC","id":34013004,"node_id":"MDQ6VXNlcjM0MDEzMDA0","avatar_url":"https://avatars2.githubusercontent.com/u/34013004?v=4","gravatar_id":"","url":"https://api.github.com/users/DyrellC","html_url":"https://github.com/DyrellC","followers_url":"https://api.github.com/users/DyrellC/followers","following_url":"https://api.github.com/users/DyrellC/following{/other_user}","gists_url":"https://api.github.com/users/DyrellC/gists{/gist_id}","starred_url":"https://api.github.com/users/DyrellC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DyrellC/subscriptions","organizations_url":"https://api.github.com/users/DyrellC/orgs","repos_url":"https://api.github.com/users/DyrellC/repos","events_url":"https://api.github.com/users/DyrellC/events{/privacy}","received_events_url":"https://api.github.com/users/DyrellC/received_events","type":"User","site_admin":false},"body":"# Description\r\nAdds a regression test for exporting and importing spentAddresses.txt files using the export-spent and merge-spent iri-extension tools. The tests export the spent addresses of one node into a file and checks to ensure that they have been exported correctly. It then imports the same addresses into an empty node and checks that the addresses were added as spent addresses. \r\n\r\n**Note: This test currently only tests with one spent address db to test and is an incomplete PR until further notice. It should not be merged until the additional test has been added, but needs to be tested in the build pipeline to ensure it is working correctly.\r\n\r\nFixes #1468 \r\n\r\n## Type of change\r\n- Enhancement (a non-breaking change which adds functionality)\r\n\r\n# How Has This Been Tested?\r\n- Locally tested prior to change in file location\r\n- Testing on buildkite pipeline to ensure pod file locations are correct **\r\n\r\n\r\n# Checklist:\r\n- [x] My code follows the style guidelines for this project\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n","created_at":"2019-08-04T18:38:40Z","updated_at":"2020-01-08T01:32:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91c0df1e19ae09e1e68a7ec73d2acb8974a4008c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotaledger/iri/pulls/1561/commits","review_comments_url":"https://api.github.com/repos/iotaledger/iri/pulls/1561/comments","review_comment_url":"https://api.github.com/repos/iotaledger/iri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotaledger/iri/issues/1561/comments","statuses_url":"https://api.github.com/repos/iotaledger/iri/statuses/5feb1b95866dba97a5b0548318abe696936e9340","head":{"label":"DyrellC:add-spent-addresses-export-test","ref":"add-spent-addresses-export-test","sha":"5feb1b95866dba97a5b0548318abe696936e9340","user":{"login":"DyrellC","id":34013004,"node_id":"MDQ6VXNlcjM0MDEzMDA0","avatar_url":"https://avatars2.githubusercontent.com/u/34013004?v=4","gravatar_id":"","url":"https://api.github.com/users/DyrellC","html_url":"https://github.com/DyrellC","followers_url":"https://api.github.com/users/DyrellC/followers","following_url":"https://api.github.com/users/DyrellC/following{/other_user}","gists_url":"https://api.github.com/users/DyrellC/gists{/gist_id}","starred_url":"https://api.github.com/users/DyrellC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DyrellC/subscriptions","organizations_url":"https://api.github.com/users/DyrellC/orgs","repos_url":"https://api.github.com/users/DyrellC/repos","events_url":"https://api.github.com/users/DyrellC/events{/privacy}","received_events_url":"https://api.github.com/users/DyrellC/received_events","type":"User","site_admin":false},"repo":{"id":155443791,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU0NDM3OTE=","name":"iri","full_name":"DyrellC/iri","private":false,"owner":{"login":"DyrellC","id":34013004,"node_id":"MDQ6VXNlcjM0MDEzMDA0","avatar_url":"https://avatars2.githubusercontent.com/u/34013004?v=4","gravatar_id":"","url":"https://api.github.com/users/DyrellC","html_url":"https://github.com/DyrellC","followers_url":"https://api.github.com/users/DyrellC/followers","following_url":"https://api.github.com/users/DyrellC/following{/other_user}","gists_url":"https://api.github.com/users/DyrellC/gists{/gist_id}","starred_url":"https://api.github.com/users/DyrellC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DyrellC/subscriptions","organizations_url":"https://api.github.com/users/DyrellC/orgs","repos_url":"https://api.github.com/users/DyrellC/repos","events_url":"https://api.github.com/users/DyrellC/events{/privacy}","received_events_url":"https://api.github.com/users/DyrellC/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DyrellC/iri","description":"IOTA Reference Implementation","fork":true,"url":"https://api.github.com/repos/DyrellC/iri","forks_url":"https://api.github.com/repos/DyrellC/iri/forks","keys_url":"https://api.github.com/repos/DyrellC/iri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DyrellC/iri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DyrellC/iri/teams","hooks_url":"https://api.github.com/repos/DyrellC/iri/hooks","issue_events_url":"https://api.github.com/repos/DyrellC/iri/issues/events{/number}","events_url":"https://api.github.com/repos/DyrellC/iri/events","assignees_url":"https://api.github.com/repos/DyrellC/iri/assignees{/user}","branches_url":"https://api.github.com/repos/DyrellC/iri/branches{/branch}","tags_url":"https://api.github.com/repos/DyrellC/iri/tags","blobs_url":"https://api.github.com/repos/DyrellC/iri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DyrellC/iri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DyrellC/iri/git/refs{/sha}","trees_url":"https://api.github.com/repos/DyrellC/iri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DyrellC/iri/statuses/{sha}","languages_url":"https://api.github.com/repos/DyrellC/iri/languages","stargazers_url":"https://api.github.com/repos/DyrellC/iri/stargazers","contributors_url":"https://api.github.com/repos/DyrellC/iri/contributors","subscribers_url":"https://api.github.com/repos/DyrellC/iri/subscribers","subscription_url":"https://api.github.com/repos/DyrellC/iri/subscription","commits_url":"https://api.github.com/repos/DyrellC/iri/commits{/sha}","git_commits_url":"https://api.github.com/repos/DyrellC/iri/git/commits{/sha}","comments_url":"https://api.github.com/repos/DyrellC/iri/comments{/number}","issue_comment_url":"https://api.github.com/repos/DyrellC/iri/issues/comments{/number}","contents_url":"https://api.github.com/repos/DyrellC/iri/contents/{+path}","compare_url":"https://api.github.com/repos/DyrellC/iri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DyrellC/iri/merges","archive_url":"https://api.github.com/repos/DyrellC/iri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DyrellC/iri/downloads","issues_url":"https://api.github.com/repos/DyrellC/iri/issues{/number}","pulls_url":"https://api.github.com/repos/DyrellC/iri/pulls{/number}","milestones_url":"https://api.github.com/repos/DyrellC/iri/milestones{/number}","notifications_url":"https://api.github.com/repos/DyrellC/iri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DyrellC/iri/labels{/name}","releases_url":"https://api.github.com/repos/DyrellC/iri/releases{/id}","deployments_url":"https://api.github.com/repos/DyrellC/iri/deployments","created_at":"2018-10-30T19:24:35Z","updated_at":"2019-10-04T16:58:31Z","pushed_at":"2020-01-08T01:29:34Z","git_url":"git://github.com/DyrellC/iri.git","ssh_url":"git@github.com:DyrellC/iri.git","clone_url":"https://github.com/DyrellC/iri.git","svn_url":"https://github.com/DyrellC/iri","homepage":null,"size":239092,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"iotaledger:dev","ref":"dev","sha":"4ff8bae6e7515c703cfc5271498beb5c8957e08a","user":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"repo":{"id":71836159,"node_id":"MDEwOlJlcG9zaXRvcnk3MTgzNjE1OQ==","name":"iri","full_name":"iotaledger/iri","private":false,"owner":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotaledger/iri","description":"IOTA Reference Implementation","fork":false,"url":"https://api.github.com/repos/iotaledger/iri","forks_url":"https://api.github.com/repos/iotaledger/iri/forks","keys_url":"https://api.github.com/repos/iotaledger/iri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotaledger/iri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotaledger/iri/teams","hooks_url":"https://api.github.com/repos/iotaledger/iri/hooks","issue_events_url":"https://api.github.com/repos/iotaledger/iri/issues/events{/number}","events_url":"https://api.github.com/repos/iotaledger/iri/events","assignees_url":"https://api.github.com/repos/iotaledger/iri/assignees{/user}","branches_url":"https://api.github.com/repos/iotaledger/iri/branches{/branch}","tags_url":"https://api.github.com/repos/iotaledger/iri/tags","blobs_url":"https://api.github.com/repos/iotaledger/iri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotaledger/iri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotaledger/iri/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotaledger/iri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotaledger/iri/statuses/{sha}","languages_url":"https://api.github.com/repos/iotaledger/iri/languages","stargazers_url":"https://api.github.com/repos/iotaledger/iri/stargazers","contributors_url":"https://api.github.com/repos/iotaledger/iri/contributors","subscribers_url":"https://api.github.com/repos/iotaledger/iri/subscribers","subscription_url":"https://api.github.com/repos/iotaledger/iri/subscription","commits_url":"https://api.github.com/repos/iotaledger/iri/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotaledger/iri/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotaledger/iri/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotaledger/iri/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotaledger/iri/contents/{+path}","compare_url":"https://api.github.com/repos/iotaledger/iri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotaledger/iri/merges","archive_url":"https://api.github.com/repos/iotaledger/iri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotaledger/iri/downloads","issues_url":"https://api.github.com/repos/iotaledger/iri/issues{/number}","pulls_url":"https://api.github.com/repos/iotaledger/iri/pulls{/number}","milestones_url":"https://api.github.com/repos/iotaledger/iri/milestones{/number}","notifications_url":"https://api.github.com/repos/iotaledger/iri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotaledger/iri/labels{/name}","releases_url":"https://api.github.com/repos/iotaledger/iri/releases{/id}","deployments_url":"https://api.github.com/repos/iotaledger/iri/deployments","created_at":"2016-10-24T22:06:06Z","updated_at":"2020-01-06T14:44:34Z","pushed_at":"2020-01-08T01:29:35Z","git_url":"git://github.com/iotaledger/iri.git","ssh_url":"git@github.com:iotaledger/iri.git","clone_url":"https://github.com/iotaledger/iri.git","svn_url":"https://github.com/iotaledger/iri","homepage":null,"size":238688,"stargazers_count":1180,"watchers_count":1180,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":425,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":411,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":425,"open_issues":411,"watchers":1180,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1561"},"html":{"href":"https://github.com/iotaledger/iri/pull/1561"},"issue":{"href":"https://api.github.com/repos/iotaledger/iri/issues/1561"},"comments":{"href":"https://api.github.com/repos/iotaledger/iri/issues/1561/comments"},"review_comments":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1561/comments"},"review_comment":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1561/commits"},"statuses":{"href":"https://api.github.com/repos/iotaledger/iri/statuses/5feb1b95866dba97a5b0548318abe696936e9340"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 71836159,
"name": "iotaledger/iri",
"url": "https://api.github.com/repos/iotaledger/iri"
}
|
{
"id": 7954839,
"login": "GalRogozinski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7954839?",
"url": "https://api.github.com/users/GalRogozinski"
}
|
{
"id": 20126597,
"login": "iotaledger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20126597?",
"url": "https://api.github.com/orgs/iotaledger"
}
| 2020-01-08T01:32:30 |
11224240225
|
{"actor":{"display_login":"GalRogozinski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/comments/267610765","pull_request_review_id":217060742,"id":267610765,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzYxMDc2NQ==","diff_hunk":"@@ -635,21 +695,22 @@ Function GetTWetBulbFromHumRatio(ByVal TDryBulb As Variant, ByVal HumRatio As Va\n \n ' Bisection loop\n Tol = GetTol()\n- While (TWetBulbSup - TWetBulbInf > Tol)\n+ index = 0\n+ While (((TWetBulbSup - TWetBulbInf) > Tol) Or (index < MAX_ITER_COUNT))","path":"src/vba/psychrolib.bas","position":194,"original_position":194,"commit_id":"2c5ae2f24311d6eb95de12c8a57aed8b70c7bf72","original_commit_id":"2c5ae2f24311d6eb95de12c8a57aed8b70c7bf72","user":{"login":"didierthevenard","id":11446141,"node_id":"MDQ6VXNlcjExNDQ2MTQx","avatar_url":"https://avatars0.githubusercontent.com/u/11446141?v=4","gravatar_id":"","url":"https://api.github.com/users/didierthevenard","html_url":"https://github.com/didierthevenard","followers_url":"https://api.github.com/users/didierthevenard/followers","following_url":"https://api.github.com/users/didierthevenard/following{/other_user}","gists_url":"https://api.github.com/users/didierthevenard/gists{/gist_id}","starred_url":"https://api.github.com/users/didierthevenard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/didierthevenard/subscriptions","organizations_url":"https://api.github.com/users/didierthevenard/orgs","repos_url":"https://api.github.com/users/didierthevenard/repos","events_url":"https://api.github.com/users/didierthevenard/events{/privacy}","received_events_url":"https://api.github.com/users/didierthevenard/received_events","type":"User","site_admin":false},"body":"The test on index < MAX_ITER_COUNT is wrong. It should be a separate line of code inside the loop (same as in other languages) and if not satisfied should send to ErrHandler","created_at":"2019-03-21T02:33:08Z","updated_at":"2019-03-21T02:33:09Z","html_url":"https://github.com/psychrometrics/psychrolib/pull/30#discussion_r267610765","pull_request_url":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/30","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/comments/267610765"},"html":{"href":"https://github.com/psychrometrics/psychrolib/pull/30#discussion_r267610765"},"pull_request":{"href":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/30","id":262971809,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyOTcxODA5","html_url":"https://github.com/psychrometrics/psychrolib/pull/30","diff_url":"https://github.com/psychrometrics/psychrolib/pull/30.diff","patch_url":"https://github.com/psychrometrics/psychrolib/pull/30.patch","issue_url":"https://api.github.com/repos/psychrometrics/psychrolib/issues/30","number":30,"state":"open","locked":false,"title":"Fix GetTDewPointFromVapPres in case of discontinuity with GetSatVapPres + bound HumRatio for all","user":{"login":"dmey","id":26348635,"node_id":"MDQ6VXNlcjI2MzQ4NjM1","avatar_url":"https://avatars2.githubusercontent.com/u/26348635?v=4","gravatar_id":"","url":"https://api.github.com/users/dmey","html_url":"https://github.com/dmey","followers_url":"https://api.github.com/users/dmey/followers","following_url":"https://api.github.com/users/dmey/following{/other_user}","gists_url":"https://api.github.com/users/dmey/gists{/gist_id}","starred_url":"https://api.github.com/users/dmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmey/subscriptions","organizations_url":"https://api.github.com/users/dmey/orgs","repos_url":"https://api.github.com/users/dmey/repos","events_url":"https://api.github.com/users/dmey/events{/privacy}","received_events_url":"https://api.github.com/users/dmey/received_events","type":"User","site_admin":false},"body":"This PR tightens up checks for handling the minimum value of humidity ratio (now reset to no lower than 1e-7) as well and it resolves the issue in `GetTDewPointFromVapPres` due to the discontinuity in the formulae in `GetSatVapPres` -- we restrict iteration to either left or right part of the saturation vapour pressure curve to avoid iterating back and forth across the discontinuity of the curve at the freezing point. When the partial pressure of water vapour is within the discontinuity of GetSatVapPres we simply return the freezing point of water.\r\n\r\nAll changes have now been propagated to all languages. All tests pass. Including the manual VBA (run using the .xlsm provided).\r\n\r\n@didierthevenard In the interest of time and process, and given that all tests pass, it may be easier to start the reviewing one language -- if there are changes to make, I can then propagate it to the others as well.","created_at":"2019-03-20T17:46:11Z","updated_at":"2019-03-21T02:33:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3be44eaa8b9bd2376611b9c398126f1072b19c4b","assignee":{"login":"dmey","id":26348635,"node_id":"MDQ6VXNlcjI2MzQ4NjM1","avatar_url":"https://avatars2.githubusercontent.com/u/26348635?v=4","gravatar_id":"","url":"https://api.github.com/users/dmey","html_url":"https://github.com/dmey","followers_url":"https://api.github.com/users/dmey/followers","following_url":"https://api.github.com/users/dmey/following{/other_user}","gists_url":"https://api.github.com/users/dmey/gists{/gist_id}","starred_url":"https://api.github.com/users/dmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmey/subscriptions","organizations_url":"https://api.github.com/users/dmey/orgs","repos_url":"https://api.github.com/users/dmey/repos","events_url":"https://api.github.com/users/dmey/events{/privacy}","received_events_url":"https://api.github.com/users/dmey/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmey","id":26348635,"node_id":"MDQ6VXNlcjI2MzQ4NjM1","avatar_url":"https://avatars2.githubusercontent.com/u/26348635?v=4","gravatar_id":"","url":"https://api.github.com/users/dmey","html_url":"https://github.com/dmey","followers_url":"https://api.github.com/users/dmey/followers","following_url":"https://api.github.com/users/dmey/following{/other_user}","gists_url":"https://api.github.com/users/dmey/gists{/gist_id}","starred_url":"https://api.github.com/users/dmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmey/subscriptions","organizations_url":"https://api.github.com/users/dmey/orgs","repos_url":"https://api.github.com/users/dmey/repos","events_url":"https://api.github.com/users/dmey/events{/privacy}","received_events_url":"https://api.github.com/users/dmey/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":447966850,"node_id":"MDU6TGFiZWw0NDc5NjY4NTA=","url":"https://api.github.com/repos/psychrometrics/psychrolib/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":{"url":"https://api.github.com/repos/psychrometrics/psychrolib/milestones/2","html_url":"https://github.com/psychrometrics/psychrolib/milestone/2","labels_url":"https://api.github.com/repos/psychrometrics/psychrolib/milestones/2/labels","id":4045248,"node_id":"MDk6TWlsZXN0b25lNDA0NTI0OA==","number":2,"title":"2.1.0","description":"","creator":{"login":"dmey","id":26348635,"node_id":"MDQ6VXNlcjI2MzQ4NjM1","avatar_url":"https://avatars2.githubusercontent.com/u/26348635?v=4","gravatar_id":"","url":"https://api.github.com/users/dmey","html_url":"https://github.com/dmey","followers_url":"https://api.github.com/users/dmey/followers","following_url":"https://api.github.com/users/dmey/following{/other_user}","gists_url":"https://api.github.com/users/dmey/gists{/gist_id}","starred_url":"https://api.github.com/users/dmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmey/subscriptions","organizations_url":"https://api.github.com/users/dmey/orgs","repos_url":"https://api.github.com/users/dmey/repos","events_url":"https://api.github.com/users/dmey/events{/privacy}","received_events_url":"https://api.github.com/users/dmey/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":16,"state":"open","created_at":"2019-02-10T21:23:23Z","updated_at":"2019-03-20T17:47:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/30/commits","review_comments_url":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/30/comments","review_comment_url":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/psychrometrics/psychrolib/issues/30/comments","statuses_url":"https://api.github.com/repos/psychrometrics/psychrolib/statuses/2c5ae2f24311d6eb95de12c8a57aed8b70c7bf72","head":{"label":"psychrometrics:revise-NR-and-bound-HumRatio","ref":"revise-NR-and-bound-HumRatio","sha":"2c5ae2f24311d6eb95de12c8a57aed8b70c7bf72","user":{"login":"psychrometrics","id":20244958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ0OTU4","avatar_url":"https://avatars1.githubusercontent.com/u/20244958?v=4","gravatar_id":"","url":"https://api.github.com/users/psychrometrics","html_url":"https://github.com/psychrometrics","followers_url":"https://api.github.com/users/psychrometrics/followers","following_url":"https://api.github.com/users/psychrometrics/following{/other_user}","gists_url":"https://api.github.com/users/psychrometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/psychrometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychrometrics/subscriptions","organizations_url":"https://api.github.com/users/psychrometrics/orgs","repos_url":"https://api.github.com/users/psychrometrics/repos","events_url":"https://api.github.com/users/psychrometrics/events{/privacy}","received_events_url":"https://api.github.com/users/psychrometrics/received_events","type":"Organization","site_admin":false},"repo":{"id":68980860,"node_id":"MDEwOlJlcG9zaXRvcnk2ODk4MDg2MA==","name":"psychrolib","full_name":"psychrometrics/psychrolib","private":false,"owner":{"login":"psychrometrics","id":20244958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ0OTU4","avatar_url":"https://avatars1.githubusercontent.com/u/20244958?v=4","gravatar_id":"","url":"https://api.github.com/users/psychrometrics","html_url":"https://github.com/psychrometrics","followers_url":"https://api.github.com/users/psychrometrics/followers","following_url":"https://api.github.com/users/psychrometrics/following{/other_user}","gists_url":"https://api.github.com/users/psychrometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/psychrometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychrometrics/subscriptions","organizations_url":"https://api.github.com/users/psychrometrics/orgs","repos_url":"https://api.github.com/users/psychrometrics/repos","events_url":"https://api.github.com/users/psychrometrics/events{/privacy}","received_events_url":"https://api.github.com/users/psychrometrics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/psychrometrics/psychrolib","description":"Library of psychrometric functions to calculate thermodynamic properties of air for Python, C, Fortran, JavaScript and VBA/Excel","fork":false,"url":"https://api.github.com/repos/psychrometrics/psychrolib","forks_url":"https://api.github.com/repos/psychrometrics/psychrolib/forks","keys_url":"https://api.github.com/repos/psychrometrics/psychrolib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psychrometrics/psychrolib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psychrometrics/psychrolib/teams","hooks_url":"https://api.github.com/repos/psychrometrics/psychrolib/hooks","issue_events_url":"https://api.github.com/repos/psychrometrics/psychrolib/issues/events{/number}","events_url":"https://api.github.com/repos/psychrometrics/psychrolib/events","assignees_url":"https://api.github.com/repos/psychrometrics/psychrolib/assignees{/user}","branches_url":"https://api.github.com/repos/psychrometrics/psychrolib/branches{/branch}","tags_url":"https://api.github.com/repos/psychrometrics/psychrolib/tags","blobs_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/refs{/sha}","trees_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psychrometrics/psychrolib/statuses/{sha}","languages_url":"https://api.github.com/repos/psychrometrics/psychrolib/languages","stargazers_url":"https://api.github.com/repos/psychrometrics/psychrolib/stargazers","contributors_url":"https://api.github.com/repos/psychrometrics/psychrolib/contributors","subscribers_url":"https://api.github.com/repos/psychrometrics/psychrolib/subscribers","subscription_url":"https://api.github.com/repos/psychrometrics/psychrolib/subscription","commits_url":"https://api.github.com/repos/psychrometrics/psychrolib/commits{/sha}","git_commits_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/commits{/sha}","comments_url":"https://api.github.com/repos/psychrometrics/psychrolib/comments{/number}","issue_comment_url":"https://api.github.com/repos/psychrometrics/psychrolib/issues/comments{/number}","contents_url":"https://api.github.com/repos/psychrometrics/psychrolib/contents/{+path}","compare_url":"https://api.github.com/repos/psychrometrics/psychrolib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psychrometrics/psychrolib/merges","archive_url":"https://api.github.com/repos/psychrometrics/psychrolib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psychrometrics/psychrolib/downloads","issues_url":"https://api.github.com/repos/psychrometrics/psychrolib/issues{/number}","pulls_url":"https://api.github.com/repos/psychrometrics/psychrolib/pulls{/number}","milestones_url":"https://api.github.com/repos/psychrometrics/psychrolib/milestones{/number}","notifications_url":"https://api.github.com/repos/psychrometrics/psychrolib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psychrometrics/psychrolib/labels{/name}","releases_url":"https://api.github.com/repos/psychrometrics/psychrolib/releases{/id}","deployments_url":"https://api.github.com/repos/psychrometrics/psychrolib/deployments","created_at":"2016-09-23T02:26:34Z","updated_at":"2019-03-19T21:58:33Z","pushed_at":"2019-03-20T17:47:13Z","git_url":"git://github.com/psychrometrics/psychrolib.git","ssh_url":"git@github.com:psychrometrics/psychrolib.git","clone_url":"https://github.com/psychrometrics/psychrolib.git","svn_url":"https://github.com/psychrometrics/psychrolib","homepage":"","size":2022,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":3,"watchers":24,"default_branch":"master"}},"base":{"label":"psychrometrics:master","ref":"master","sha":"91dd95fc4f4f964aaeaf472666edd9a92da5c0c7","user":{"login":"psychrometrics","id":20244958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ0OTU4","avatar_url":"https://avatars1.githubusercontent.com/u/20244958?v=4","gravatar_id":"","url":"https://api.github.com/users/psychrometrics","html_url":"https://github.com/psychrometrics","followers_url":"https://api.github.com/users/psychrometrics/followers","following_url":"https://api.github.com/users/psychrometrics/following{/other_user}","gists_url":"https://api.github.com/users/psychrometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/psychrometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychrometrics/subscriptions","organizations_url":"https://api.github.com/users/psychrometrics/orgs","repos_url":"https://api.github.com/users/psychrometrics/repos","events_url":"https://api.github.com/users/psychrometrics/events{/privacy}","received_events_url":"https://api.github.com/users/psychrometrics/received_events","type":"Organization","site_admin":false},"repo":{"id":68980860,"node_id":"MDEwOlJlcG9zaXRvcnk2ODk4MDg2MA==","name":"psychrolib","full_name":"psychrometrics/psychrolib","private":false,"owner":{"login":"psychrometrics","id":20244958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ0OTU4","avatar_url":"https://avatars1.githubusercontent.com/u/20244958?v=4","gravatar_id":"","url":"https://api.github.com/users/psychrometrics","html_url":"https://github.com/psychrometrics","followers_url":"https://api.github.com/users/psychrometrics/followers","following_url":"https://api.github.com/users/psychrometrics/following{/other_user}","gists_url":"https://api.github.com/users/psychrometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/psychrometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychrometrics/subscriptions","organizations_url":"https://api.github.com/users/psychrometrics/orgs","repos_url":"https://api.github.com/users/psychrometrics/repos","events_url":"https://api.github.com/users/psychrometrics/events{/privacy}","received_events_url":"https://api.github.com/users/psychrometrics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/psychrometrics/psychrolib","description":"Library of psychrometric functions to calculate thermodynamic properties of air for Python, C, Fortran, JavaScript and VBA/Excel","fork":false,"url":"https://api.github.com/repos/psychrometrics/psychrolib","forks_url":"https://api.github.com/repos/psychrometrics/psychrolib/forks","keys_url":"https://api.github.com/repos/psychrometrics/psychrolib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psychrometrics/psychrolib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psychrometrics/psychrolib/teams","hooks_url":"https://api.github.com/repos/psychrometrics/psychrolib/hooks","issue_events_url":"https://api.github.com/repos/psychrometrics/psychrolib/issues/events{/number}","events_url":"https://api.github.com/repos/psychrometrics/psychrolib/events","assignees_url":"https://api.github.com/repos/psychrometrics/psychrolib/assignees{/user}","branches_url":"https://api.github.com/repos/psychrometrics/psychrolib/branches{/branch}","tags_url":"https://api.github.com/repos/psychrometrics/psychrolib/tags","blobs_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/refs{/sha}","trees_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psychrometrics/psychrolib/statuses/{sha}","languages_url":"https://api.github.com/repos/psychrometrics/psychrolib/languages","stargazers_url":"https://api.github.com/repos/psychrometrics/psychrolib/stargazers","contributors_url":"https://api.github.com/repos/psychrometrics/psychrolib/contributors","subscribers_url":"https://api.github.com/repos/psychrometrics/psychrolib/subscribers","subscription_url":"https://api.github.com/repos/psychrometrics/psychrolib/subscription","commits_url":"https://api.github.com/repos/psychrometrics/psychrolib/commits{/sha}","git_commits_url":"https://api.github.com/repos/psychrometrics/psychrolib/git/commits{/sha}","comments_url":"https://api.github.com/repos/psychrometrics/psychrolib/comments{/number}","issue_comment_url":"https://api.github.com/repos/psychrometrics/psychrolib/issues/comments{/number}","contents_url":"https://api.github.com/repos/psychrometrics/psychrolib/contents/{+path}","compare_url":"https://api.github.com/repos/psychrometrics/psychrolib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psychrometrics/psychrolib/merges","archive_url":"https://api.github.com/repos/psychrometrics/psychrolib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psychrometrics/psychrolib/downloads","issues_url":"https://api.github.com/repos/psychrometrics/psychrolib/issues{/number}","pulls_url":"https://api.github.com/repos/psychrometrics/psychrolib/pulls{/number}","milestones_url":"https://api.github.com/repos/psychrometrics/psychrolib/milestones{/number}","notifications_url":"https://api.github.com/repos/psychrometrics/psychrolib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psychrometrics/psychrolib/labels{/name}","releases_url":"https://api.github.com/repos/psychrometrics/psychrolib/releases{/id}","deployments_url":"https://api.github.com/repos/psychrometrics/psychrolib/deployments","created_at":"2016-09-23T02:26:34Z","updated_at":"2019-03-19T21:58:33Z","pushed_at":"2019-03-20T17:47:13Z","git_url":"git://github.com/psychrometrics/psychrolib.git","ssh_url":"git@github.com:psychrometrics/psychrolib.git","clone_url":"https://github.com/psychrometrics/psychrolib.git","svn_url":"https://github.com/psychrometrics/psychrolib","homepage":"","size":2022,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":3,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/30"},"html":{"href":"https://github.com/psychrometrics/psychrolib/pull/30"},"issue":{"href":"https://api.github.com/repos/psychrometrics/psychrolib/issues/30"},"comments":{"href":"https://api.github.com/repos/psychrometrics/psychrolib/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/psychrometrics/psychrolib/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/psychrometrics/psychrolib/statuses/2c5ae2f24311d6eb95de12c8a57aed8b70c7bf72"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 68980860,
"name": "psychrometrics/psychrolib",
"url": "https://api.github.com/repos/psychrometrics/psychrolib"
}
|
{
"id": 11446141,
"login": "didierthevenard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11446141?",
"url": "https://api.github.com/users/didierthevenard"
}
|
{
"id": 20244958,
"login": "psychrometrics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20244958?",
"url": "https://api.github.com/orgs/psychrometrics"
}
| 2019-03-21T02:33:08 |
9284612436
|
{"actor":{"display_login":"didierthevenard"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tokio-rs/mio/pulls/comments/278737691","pull_request_review_id":230891469,"id":278737691,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODczNzY5MQ==","diff_hunk":"@@ -1044,6 +1044,216 @@ fn test_debug_ready() {\n assert_eq!(\"Writable\", format!(\"{:?}\", Ready::writable()));\n }\n \n+\n+/// Interests used in registering.\n+///\n+/// Interests are used in registering [`Evented`] handles with [`Poll`],\n+/// they indicate what readiness should be monitored for. For example if a\n+/// socket is registered with readable interests and the socket becomes\n+/// writable, no event will be returned from [`poll`].\n+///\n+/// [`Poll`]: struct.Poll.html \n+/// [`readable`]: #method.readable\n+/// [`writable`]: #method.writable\n+#[derive(Copy, PartialEq, Eq, Clone, PartialOrd, Ord)]\n+pub struct Interests(usize);\n+\n+impl Interests {\n+\n+ /// Returns a `Interests` representing readable readiness.\n+ ///\n+ /// See [`Poll`] for more documentation on polling.\n+ ///\n+ /// # Examples\n+ ///\n+ /// ```\n+ /// use mio::Interests;\n+ ///\n+ /// let interest = Interests::readable();\n+ ///\n+ /// assert!(interest.is_readable());\n+ /// ```\n+ ///\n+ /// [`Poll`]: struct.Poll.html\n+ #[inline]\n+ pub fn readable() -> Interests {\n+ Interests(READABLE)\n+ }\n+\n+ /// Returns a `Interests` representing writable readiness.\n+ ///\n+ /// See [`Poll`] for more documentation on polling.\n+ ///\n+ /// # Examples\n+ ///\n+ /// ```\n+ /// use mio::Interests;\n+ ///\n+ /// let interest = Interests::writable();\n+ ///\n+ /// assert!(interest.is_writable());\n+ /// ```\n+ ///\n+ /// [`Poll`]: struct.Poll.html\n+ #[inline]\n+ pub fn writable() -> Interests {\n+ Interests(WRITABLE)\n+ }\n+\n+ /// Returns a `Interests` representing readable and writable readiness.","path":"src/event_imp.rs","position":171,"original_position":171,"commit_id":"3dcfd335eeda2d7c038e0a829cfc05a867b90b41","original_commit_id":"3dcfd335eeda2d7c038e0a829cfc05a867b90b41","user":{"login":"Thomasdezeeuw","id":3159064,"node_id":"MDQ6VXNlcjMxNTkwNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3159064?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomasdezeeuw","html_url":"https://github.com/Thomasdezeeuw","followers_url":"https://api.github.com/users/Thomasdezeeuw/followers","following_url":"https://api.github.com/users/Thomasdezeeuw/following{/other_user}","gists_url":"https://api.github.com/users/Thomasdezeeuw/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomasdezeeuw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomasdezeeuw/subscriptions","organizations_url":"https://api.github.com/users/Thomasdezeeuw/orgs","repos_url":"https://api.github.com/users/Thomasdezeeuw/repos","events_url":"https://api.github.com/users/Thomasdezeeuw/events{/privacy}","received_events_url":"https://api.github.com/users/Thomasdezeeuw/received_events","type":"User","site_admin":false},"body":"And again remove \"a\".","created_at":"2019-04-25T21:23:51Z","updated_at":"2019-04-25T21:38:47Z","html_url":"https://github.com/tokio-rs/mio/pull/925#discussion_r278737691","pull_request_url":"https://api.github.com/repos/tokio-rs/mio/pulls/925","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tokio-rs/mio/pulls/comments/278737691"},"html":{"href":"https://github.com/tokio-rs/mio/pull/925#discussion_r278737691"},"pull_request":{"href":"https://api.github.com/repos/tokio-rs/mio/pulls/925"}}},"pull_request":{"url":"https://api.github.com/repos/tokio-rs/mio/pulls/925","id":271770862,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxNzcwODYy","html_url":"https://github.com/tokio-rs/mio/pull/925","diff_url":"https://github.com/tokio-rs/mio/pull/925.diff","patch_url":"https://github.com/tokio-rs/mio/pull/925.patch","issue_url":"https://api.github.com/repos/tokio-rs/mio/issues/925","number":925,"state":"open","locked":false,"title":"Add `Interests` for registering process(Issue #908)","user":{"login":"FXTi","id":3260882,"node_id":"MDQ6VXNlcjMyNjA4ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/3260882?v=4","gravatar_id":"","url":"https://api.github.com/users/FXTi","html_url":"https://github.com/FXTi","followers_url":"https://api.github.com/users/FXTi/followers","following_url":"https://api.github.com/users/FXTi/following{/other_user}","gists_url":"https://api.github.com/users/FXTi/gists{/gist_id}","starred_url":"https://api.github.com/users/FXTi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FXTi/subscriptions","organizations_url":"https://api.github.com/users/FXTi/orgs","repos_url":"https://api.github.com/users/FXTi/repos","events_url":"https://api.github.com/users/FXTi/events{/privacy}","received_events_url":"https://api.github.com/users/FXTi/received_events","type":"User","site_admin":false},"body":"Add new `Interests` based on mio-st version and `Ready` struct.","created_at":"2019-04-18T17:20:29Z","updated_at":"2019-04-25T21:38:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c44b0e0fdf42ecfe674e0e5f8cb2166b5bf49b56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tokio-rs/mio/pulls/925/commits","review_comments_url":"https://api.github.com/repos/tokio-rs/mio/pulls/925/comments","review_comment_url":"https://api.github.com/repos/tokio-rs/mio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tokio-rs/mio/issues/925/comments","statuses_url":"https://api.github.com/repos/tokio-rs/mio/statuses/3dcfd335eeda2d7c038e0a829cfc05a867b90b41","head":{"label":"FXTi:issue908","ref":"issue908","sha":"3dcfd335eeda2d7c038e0a829cfc05a867b90b41","user":{"login":"FXTi","id":3260882,"node_id":"MDQ6VXNlcjMyNjA4ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/3260882?v=4","gravatar_id":"","url":"https://api.github.com/users/FXTi","html_url":"https://github.com/FXTi","followers_url":"https://api.github.com/users/FXTi/followers","following_url":"https://api.github.com/users/FXTi/following{/other_user}","gists_url":"https://api.github.com/users/FXTi/gists{/gist_id}","starred_url":"https://api.github.com/users/FXTi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FXTi/subscriptions","organizations_url":"https://api.github.com/users/FXTi/orgs","repos_url":"https://api.github.com/users/FXTi/repos","events_url":"https://api.github.com/users/FXTi/events{/privacy}","received_events_url":"https://api.github.com/users/FXTi/received_events","type":"User","site_admin":false},"repo":{"id":180295868,"node_id":"MDEwOlJlcG9zaXRvcnkxODAyOTU4Njg=","name":"mio","full_name":"FXTi/mio","private":false,"owner":{"login":"FXTi","id":3260882,"node_id":"MDQ6VXNlcjMyNjA4ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/3260882?v=4","gravatar_id":"","url":"https://api.github.com/users/FXTi","html_url":"https://github.com/FXTi","followers_url":"https://api.github.com/users/FXTi/followers","following_url":"https://api.github.com/users/FXTi/following{/other_user}","gists_url":"https://api.github.com/users/FXTi/gists{/gist_id}","starred_url":"https://api.github.com/users/FXTi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FXTi/subscriptions","organizations_url":"https://api.github.com/users/FXTi/orgs","repos_url":"https://api.github.com/users/FXTi/repos","events_url":"https://api.github.com/users/FXTi/events{/privacy}","received_events_url":"https://api.github.com/users/FXTi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FXTi/mio","description":"Metal IO library for Rust","fork":true,"url":"https://api.github.com/repos/FXTi/mio","forks_url":"https://api.github.com/repos/FXTi/mio/forks","keys_url":"https://api.github.com/repos/FXTi/mio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FXTi/mio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FXTi/mio/teams","hooks_url":"https://api.github.com/repos/FXTi/mio/hooks","issue_events_url":"https://api.github.com/repos/FXTi/mio/issues/events{/number}","events_url":"https://api.github.com/repos/FXTi/mio/events","assignees_url":"https://api.github.com/repos/FXTi/mio/assignees{/user}","branches_url":"https://api.github.com/repos/FXTi/mio/branches{/branch}","tags_url":"https://api.github.com/repos/FXTi/mio/tags","blobs_url":"https://api.github.com/repos/FXTi/mio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FXTi/mio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FXTi/mio/git/refs{/sha}","trees_url":"https://api.github.com/repos/FXTi/mio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FXTi/mio/statuses/{sha}","languages_url":"https://api.github.com/repos/FXTi/mio/languages","stargazers_url":"https://api.github.com/repos/FXTi/mio/stargazers","contributors_url":"https://api.github.com/repos/FXTi/mio/contributors","subscribers_url":"https://api.github.com/repos/FXTi/mio/subscribers","subscription_url":"https://api.github.com/repos/FXTi/mio/subscription","commits_url":"https://api.github.com/repos/FXTi/mio/commits{/sha}","git_commits_url":"https://api.github.com/repos/FXTi/mio/git/commits{/sha}","comments_url":"https://api.github.com/repos/FXTi/mio/comments{/number}","issue_comment_url":"https://api.github.com/repos/FXTi/mio/issues/comments{/number}","contents_url":"https://api.github.com/repos/FXTi/mio/contents/{+path}","compare_url":"https://api.github.com/repos/FXTi/mio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FXTi/mio/merges","archive_url":"https://api.github.com/repos/FXTi/mio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FXTi/mio/downloads","issues_url":"https://api.github.com/repos/FXTi/mio/issues{/number}","pulls_url":"https://api.github.com/repos/FXTi/mio/pulls{/number}","milestones_url":"https://api.github.com/repos/FXTi/mio/milestones{/number}","notifications_url":"https://api.github.com/repos/FXTi/mio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FXTi/mio/labels{/name}","releases_url":"https://api.github.com/repos/FXTi/mio/releases{/id}","deployments_url":"https://api.github.com/repos/FXTi/mio/deployments","created_at":"2019-04-09T06:02:10Z","updated_at":"2019-04-24T20:51:10Z","pushed_at":"2019-04-25T10:21:30Z","git_url":"git://github.com/FXTi/mio.git","ssh_url":"git@github.com:FXTi/mio.git","clone_url":"https://github.com/FXTi/mio.git","svn_url":"https://github.com/FXTi/mio","homepage":"","size":2662,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tokio-rs:master","ref":"master","sha":"3aa20a8a5d0cbb83e83b70c1a8f47ca98cdb8080","user":{"login":"tokio-rs","id":20248544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ4NTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/20248544?v=4","gravatar_id":"","url":"https://api.github.com/users/tokio-rs","html_url":"https://github.com/tokio-rs","followers_url":"https://api.github.com/users/tokio-rs/followers","following_url":"https://api.github.com/users/tokio-rs/following{/other_user}","gists_url":"https://api.github.com/users/tokio-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tokio-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokio-rs/subscriptions","organizations_url":"https://api.github.com/users/tokio-rs/orgs","repos_url":"https://api.github.com/users/tokio-rs/repos","events_url":"https://api.github.com/users/tokio-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tokio-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":23138984,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEzODk4NA==","name":"mio","full_name":"tokio-rs/mio","private":false,"owner":{"login":"tokio-rs","id":20248544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ4NTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/20248544?v=4","gravatar_id":"","url":"https://api.github.com/users/tokio-rs","html_url":"https://github.com/tokio-rs","followers_url":"https://api.github.com/users/tokio-rs/followers","following_url":"https://api.github.com/users/tokio-rs/following{/other_user}","gists_url":"https://api.github.com/users/tokio-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tokio-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokio-rs/subscriptions","organizations_url":"https://api.github.com/users/tokio-rs/orgs","repos_url":"https://api.github.com/users/tokio-rs/repos","events_url":"https://api.github.com/users/tokio-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tokio-rs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tokio-rs/mio","description":"Metal IO library for Rust","fork":false,"url":"https://api.github.com/repos/tokio-rs/mio","forks_url":"https://api.github.com/repos/tokio-rs/mio/forks","keys_url":"https://api.github.com/repos/tokio-rs/mio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tokio-rs/mio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tokio-rs/mio/teams","hooks_url":"https://api.github.com/repos/tokio-rs/mio/hooks","issue_events_url":"https://api.github.com/repos/tokio-rs/mio/issues/events{/number}","events_url":"https://api.github.com/repos/tokio-rs/mio/events","assignees_url":"https://api.github.com/repos/tokio-rs/mio/assignees{/user}","branches_url":"https://api.github.com/repos/tokio-rs/mio/branches{/branch}","tags_url":"https://api.github.com/repos/tokio-rs/mio/tags","blobs_url":"https://api.github.com/repos/tokio-rs/mio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tokio-rs/mio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tokio-rs/mio/git/refs{/sha}","trees_url":"https://api.github.com/repos/tokio-rs/mio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tokio-rs/mio/statuses/{sha}","languages_url":"https://api.github.com/repos/tokio-rs/mio/languages","stargazers_url":"https://api.github.com/repos/tokio-rs/mio/stargazers","contributors_url":"https://api.github.com/repos/tokio-rs/mio/contributors","subscribers_url":"https://api.github.com/repos/tokio-rs/mio/subscribers","subscription_url":"https://api.github.com/repos/tokio-rs/mio/subscription","commits_url":"https://api.github.com/repos/tokio-rs/mio/commits{/sha}","git_commits_url":"https://api.github.com/repos/tokio-rs/mio/git/commits{/sha}","comments_url":"https://api.github.com/repos/tokio-rs/mio/comments{/number}","issue_comment_url":"https://api.github.com/repos/tokio-rs/mio/issues/comments{/number}","contents_url":"https://api.github.com/repos/tokio-rs/mio/contents/{+path}","compare_url":"https://api.github.com/repos/tokio-rs/mio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tokio-rs/mio/merges","archive_url":"https://api.github.com/repos/tokio-rs/mio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tokio-rs/mio/downloads","issues_url":"https://api.github.com/repos/tokio-rs/mio/issues{/number}","pulls_url":"https://api.github.com/repos/tokio-rs/mio/pulls{/number}","milestones_url":"https://api.github.com/repos/tokio-rs/mio/milestones{/number}","notifications_url":"https://api.github.com/repos/tokio-rs/mio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tokio-rs/mio/labels{/name}","releases_url":"https://api.github.com/repos/tokio-rs/mio/releases{/id}","deployments_url":"https://api.github.com/repos/tokio-rs/mio/deployments","created_at":"2014-08-20T06:52:12Z","updated_at":"2019-04-25T20:24:15Z","pushed_at":"2019-04-25T20:31:40Z","git_url":"git://github.com/tokio-rs/mio.git","ssh_url":"git@github.com:tokio-rs/mio.git","clone_url":"https://github.com/tokio-rs/mio.git","svn_url":"https://github.com/tokio-rs/mio","homepage":"","size":2583,"stargazers_count":2978,"watchers_count":2978,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":358,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":358,"open_issues":61,"watchers":2978,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tokio-rs/mio/pulls/925"},"html":{"href":"https://github.com/tokio-rs/mio/pull/925"},"issue":{"href":"https://api.github.com/repos/tokio-rs/mio/issues/925"},"comments":{"href":"https://api.github.com/repos/tokio-rs/mio/issues/925/comments"},"review_comments":{"href":"https://api.github.com/repos/tokio-rs/mio/pulls/925/comments"},"review_comment":{"href":"https://api.github.com/repos/tokio-rs/mio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tokio-rs/mio/pulls/925/commits"},"statuses":{"href":"https://api.github.com/repos/tokio-rs/mio/statuses/3dcfd335eeda2d7c038e0a829cfc05a867b90b41"}},"author_association":"NONE"}}
|
{
"id": 23138984,
"name": "tokio-rs/mio",
"url": "https://api.github.com/repos/tokio-rs/mio"
}
|
{
"id": 3159064,
"login": "Thomasdezeeuw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3159064?",
"url": "https://api.github.com/users/Thomasdezeeuw"
}
|
{
"id": 20248544,
"login": "tokio-rs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20248544?",
"url": "https://api.github.com/orgs/tokio-rs"
}
| 2019-04-25T21:23:51 |
9513772151
|
{"actor":{"display_login":"Thomasdezeeuw"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tokio-rs/tracing/pulls/comments/340929929","pull_request_review_id":309610167,"id":340929929,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDkyOTkyOQ==","diff_hunk":"@@ -800,4 +807,38 @@ mod test {\n \n with_default(&Dispatch::new(TestSubscriber), || mk_span())\n }\n+\n+ #[test]\n+ fn create_default_dispatcher() {\n+ let default_dispatcher = Dispatch::default();\n+ assert!(default_dispatcher.is::<NoSubscriber>());\n+ }\n+\n+ #[cfg(feature = \"std\")]\n+ #[test]\n+ fn returns_default_dispatcher() {\n+ struct TestSubscriber;\n+ impl Subscriber for TestSubscriber {\n+ fn enabled(&self, _: &Metadata<'_>) -> bool {\n+ true\n+ }\n+\n+ fn new_span(&self, _: &span::Attributes<'_>) -> span::Id {\n+ span::Id::from_u64(0xAAAA)\n+ }\n+\n+ fn record(&self, _: &span::Id, _: &span::Record<'_>) {}\n+\n+ fn record_follows_from(&self, _: &span::Id, _: &span::Id) {}\n+\n+ fn event(&self, _: &Event<'_>) {}\n+\n+ fn enter(&self, _: &span::Id) {}\n+\n+ fn exit(&self, _: &span::Id) {}\n+ }\n+ let _guard = set_default(&Dispatch::new(TestSubscriber));\n+ let default_dispatcher = Dispatch::default();\n+ assert!(default_dispatcher.is::<TestSubscriber>());","path":"tracing-core/src/dispatcher.rs","position":50,"original_position":50,"commit_id":"e34c9be655b590941b1b837b49c5a4d09f5c5364","original_commit_id":"47f8ea9e982382b544d6baf74dd6a77b6d4a4001","user":{"login":"lunchboxav","id":1574827,"node_id":"MDQ6VXNlcjE1NzQ4Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1574827?v=4","gravatar_id":"","url":"https://api.github.com/users/lunchboxav","html_url":"https://github.com/lunchboxav","followers_url":"https://api.github.com/users/lunchboxav/followers","following_url":"https://api.github.com/users/lunchboxav/following{/other_user}","gists_url":"https://api.github.com/users/lunchboxav/gists{/gist_id}","starred_url":"https://api.github.com/users/lunchboxav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunchboxav/subscriptions","organizations_url":"https://api.github.com/users/lunchboxav/orgs","repos_url":"https://api.github.com/users/lunchboxav/repos","events_url":"https://api.github.com/users/lunchboxav/events{/privacy}","received_events_url":"https://api.github.com/users/lunchboxav/received_events","type":"User","site_admin":false},"body":"got it, makes a lot of sense to test that way, I've added that to the PR.","created_at":"2019-10-31T01:43:41Z","updated_at":"2019-10-31T01:43:41Z","html_url":"https://github.com/tokio-rs/tracing/pull/411#discussion_r340929929","pull_request_url":"https://api.github.com/repos/tokio-rs/tracing/pulls/411","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tokio-rs/tracing/pulls/comments/340929929"},"html":{"href":"https://github.com/tokio-rs/tracing/pull/411#discussion_r340929929"},"pull_request":{"href":"https://api.github.com/repos/tokio-rs/tracing/pulls/411"}},"in_reply_to_id":340760532},"pull_request":{"url":"https://api.github.com/repos/tokio-rs/tracing/pulls/411","id":332731249,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyNzMxMjQ5","html_url":"https://github.com/tokio-rs/tracing/pull/411","diff_url":"https://github.com/tokio-rs/tracing/pull/411.diff","patch_url":"https://github.com/tokio-rs/tracing/pull/411.patch","issue_url":"https://api.github.com/repos/tokio-rs/tracing/issues/411","number":411,"state":"open","locked":false,"title":"Implemented Default trait for Dispatch in tracing-core","user":{"login":"lunchboxav","id":1574827,"node_id":"MDQ6VXNlcjE1NzQ4Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1574827?v=4","gravatar_id":"","url":"https://api.github.com/users/lunchboxav","html_url":"https://github.com/lunchboxav","followers_url":"https://api.github.com/users/lunchboxav/followers","following_url":"https://api.github.com/users/lunchboxav/following{/other_user}","gists_url":"https://api.github.com/users/lunchboxav/gists{/gist_id}","starred_url":"https://api.github.com/users/lunchboxav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunchboxav/subscriptions","organizations_url":"https://api.github.com/users/lunchboxav/orgs","repos_url":"https://api.github.com/users/lunchboxav/repos","events_url":"https://api.github.com/users/lunchboxav/events{/privacy}","received_events_url":"https://api.github.com/users/lunchboxav/received_events","type":"User","site_admin":false},"body":"This PR addresses the issue outlined in #172 \r\n\r\n## Motivation\r\nAs outlined in #172 , we can improve the use of default dispatch by implementing `Default` to create `Dispatch::default`, thus ease the use of dispatch.\r\n\r\n## Solution\r\nimplementation of `Default` trait from standard library that calls `get_default` and produces a clone of default.\r\n","created_at":"2019-10-26T03:31:43Z","updated_at":"2019-10-31T01:43:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a6e2bb9ee8a2facae13bf4b344d9885cfb04c41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tokio-rs/tracing/pulls/411/commits","review_comments_url":"https://api.github.com/repos/tokio-rs/tracing/pulls/411/comments","review_comment_url":"https://api.github.com/repos/tokio-rs/tracing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tokio-rs/tracing/issues/411/comments","statuses_url":"https://api.github.com/repos/tokio-rs/tracing/statuses/e34c9be655b590941b1b837b49c5a4d09f5c5364","head":{"label":"lunchboxav:dispatch-default-impl","ref":"dispatch-default-impl","sha":"e34c9be655b590941b1b837b49c5a4d09f5c5364","user":{"login":"lunchboxav","id":1574827,"node_id":"MDQ6VXNlcjE1NzQ4Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1574827?v=4","gravatar_id":"","url":"https://api.github.com/users/lunchboxav","html_url":"https://github.com/lunchboxav","followers_url":"https://api.github.com/users/lunchboxav/followers","following_url":"https://api.github.com/users/lunchboxav/following{/other_user}","gists_url":"https://api.github.com/users/lunchboxav/gists{/gist_id}","starred_url":"https://api.github.com/users/lunchboxav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunchboxav/subscriptions","organizations_url":"https://api.github.com/users/lunchboxav/orgs","repos_url":"https://api.github.com/users/lunchboxav/repos","events_url":"https://api.github.com/users/lunchboxav/events{/privacy}","received_events_url":"https://api.github.com/users/lunchboxav/received_events","type":"User","site_admin":false},"repo":{"id":217247299,"node_id":"MDEwOlJlcG9zaXRvcnkyMTcyNDcyOTk=","name":"tracing","full_name":"lunchboxav/tracing","private":false,"owner":{"login":"lunchboxav","id":1574827,"node_id":"MDQ6VXNlcjE1NzQ4Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1574827?v=4","gravatar_id":"","url":"https://api.github.com/users/lunchboxav","html_url":"https://github.com/lunchboxav","followers_url":"https://api.github.com/users/lunchboxav/followers","following_url":"https://api.github.com/users/lunchboxav/following{/other_user}","gists_url":"https://api.github.com/users/lunchboxav/gists{/gist_id}","starred_url":"https://api.github.com/users/lunchboxav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunchboxav/subscriptions","organizations_url":"https://api.github.com/users/lunchboxav/orgs","repos_url":"https://api.github.com/users/lunchboxav/repos","events_url":"https://api.github.com/users/lunchboxav/events{/privacy}","received_events_url":"https://api.github.com/users/lunchboxav/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lunchboxav/tracing","description":"Application level tracing for Rust.","fork":true,"url":"https://api.github.com/repos/lunchboxav/tracing","forks_url":"https://api.github.com/repos/lunchboxav/tracing/forks","keys_url":"https://api.github.com/repos/lunchboxav/tracing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lunchboxav/tracing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lunchboxav/tracing/teams","hooks_url":"https://api.github.com/repos/lunchboxav/tracing/hooks","issue_events_url":"https://api.github.com/repos/lunchboxav/tracing/issues/events{/number}","events_url":"https://api.github.com/repos/lunchboxav/tracing/events","assignees_url":"https://api.github.com/repos/lunchboxav/tracing/assignees{/user}","branches_url":"https://api.github.com/repos/lunchboxav/tracing/branches{/branch}","tags_url":"https://api.github.com/repos/lunchboxav/tracing/tags","blobs_url":"https://api.github.com/repos/lunchboxav/tracing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lunchboxav/tracing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lunchboxav/tracing/git/refs{/sha}","trees_url":"https://api.github.com/repos/lunchboxav/tracing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lunchboxav/tracing/statuses/{sha}","languages_url":"https://api.github.com/repos/lunchboxav/tracing/languages","stargazers_url":"https://api.github.com/repos/lunchboxav/tracing/stargazers","contributors_url":"https://api.github.com/repos/lunchboxav/tracing/contributors","subscribers_url":"https://api.github.com/repos/lunchboxav/tracing/subscribers","subscription_url":"https://api.github.com/repos/lunchboxav/tracing/subscription","commits_url":"https://api.github.com/repos/lunchboxav/tracing/commits{/sha}","git_commits_url":"https://api.github.com/repos/lunchboxav/tracing/git/commits{/sha}","comments_url":"https://api.github.com/repos/lunchboxav/tracing/comments{/number}","issue_comment_url":"https://api.github.com/repos/lunchboxav/tracing/issues/comments{/number}","contents_url":"https://api.github.com/repos/lunchboxav/tracing/contents/{+path}","compare_url":"https://api.github.com/repos/lunchboxav/tracing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lunchboxav/tracing/merges","archive_url":"https://api.github.com/repos/lunchboxav/tracing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lunchboxav/tracing/downloads","issues_url":"https://api.github.com/repos/lunchboxav/tracing/issues{/number}","pulls_url":"https://api.github.com/repos/lunchboxav/tracing/pulls{/number}","milestones_url":"https://api.github.com/repos/lunchboxav/tracing/milestones{/number}","notifications_url":"https://api.github.com/repos/lunchboxav/tracing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lunchboxav/tracing/labels{/name}","releases_url":"https://api.github.com/repos/lunchboxav/tracing/releases{/id}","deployments_url":"https://api.github.com/repos/lunchboxav/tracing/deployments","created_at":"2019-10-24T08:16:16Z","updated_at":"2019-10-24T08:16:18Z","pushed_at":"2019-10-31T01:43:11Z","git_url":"git://github.com/lunchboxav/tracing.git","ssh_url":"git@github.com:lunchboxav/tracing.git","clone_url":"https://github.com/lunchboxav/tracing.git","svn_url":"https://github.com/lunchboxav/tracing","homepage":"https://tokio.rs","size":2047,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tokio-rs:master","ref":"master","sha":"e0132f8879e43450fdfe8dea234d0904c8c8ca1a","user":{"login":"tokio-rs","id":20248544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ4NTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/20248544?v=4","gravatar_id":"","url":"https://api.github.com/users/tokio-rs","html_url":"https://github.com/tokio-rs","followers_url":"https://api.github.com/users/tokio-rs/followers","following_url":"https://api.github.com/users/tokio-rs/following{/other_user}","gists_url":"https://api.github.com/users/tokio-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tokio-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokio-rs/subscriptions","organizations_url":"https://api.github.com/users/tokio-rs/orgs","repos_url":"https://api.github.com/users/tokio-rs/repos","events_url":"https://api.github.com/users/tokio-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tokio-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":165289175,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUyODkxNzU=","name":"tracing","full_name":"tokio-rs/tracing","private":false,"owner":{"login":"tokio-rs","id":20248544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ4NTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/20248544?v=4","gravatar_id":"","url":"https://api.github.com/users/tokio-rs","html_url":"https://github.com/tokio-rs","followers_url":"https://api.github.com/users/tokio-rs/followers","following_url":"https://api.github.com/users/tokio-rs/following{/other_user}","gists_url":"https://api.github.com/users/tokio-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tokio-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokio-rs/subscriptions","organizations_url":"https://api.github.com/users/tokio-rs/orgs","repos_url":"https://api.github.com/users/tokio-rs/repos","events_url":"https://api.github.com/users/tokio-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tokio-rs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tokio-rs/tracing","description":"Application level tracing for Rust.","fork":false,"url":"https://api.github.com/repos/tokio-rs/tracing","forks_url":"https://api.github.com/repos/tokio-rs/tracing/forks","keys_url":"https://api.github.com/repos/tokio-rs/tracing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tokio-rs/tracing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tokio-rs/tracing/teams","hooks_url":"https://api.github.com/repos/tokio-rs/tracing/hooks","issue_events_url":"https://api.github.com/repos/tokio-rs/tracing/issues/events{/number}","events_url":"https://api.github.com/repos/tokio-rs/tracing/events","assignees_url":"https://api.github.com/repos/tokio-rs/tracing/assignees{/user}","branches_url":"https://api.github.com/repos/tokio-rs/tracing/branches{/branch}","tags_url":"https://api.github.com/repos/tokio-rs/tracing/tags","blobs_url":"https://api.github.com/repos/tokio-rs/tracing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tokio-rs/tracing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tokio-rs/tracing/git/refs{/sha}","trees_url":"https://api.github.com/repos/tokio-rs/tracing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tokio-rs/tracing/statuses/{sha}","languages_url":"https://api.github.com/repos/tokio-rs/tracing/languages","stargazers_url":"https://api.github.com/repos/tokio-rs/tracing/stargazers","contributors_url":"https://api.github.com/repos/tokio-rs/tracing/contributors","subscribers_url":"https://api.github.com/repos/tokio-rs/tracing/subscribers","subscription_url":"https://api.github.com/repos/tokio-rs/tracing/subscription","commits_url":"https://api.github.com/repos/tokio-rs/tracing/commits{/sha}","git_commits_url":"https://api.github.com/repos/tokio-rs/tracing/git/commits{/sha}","comments_url":"https://api.github.com/repos/tokio-rs/tracing/comments{/number}","issue_comment_url":"https://api.github.com/repos/tokio-rs/tracing/issues/comments{/number}","contents_url":"https://api.github.com/repos/tokio-rs/tracing/contents/{+path}","compare_url":"https://api.github.com/repos/tokio-rs/tracing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tokio-rs/tracing/merges","archive_url":"https://api.github.com/repos/tokio-rs/tracing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tokio-rs/tracing/downloads","issues_url":"https://api.github.com/repos/tokio-rs/tracing/issues{/number}","pulls_url":"https://api.github.com/repos/tokio-rs/tracing/pulls{/number}","milestones_url":"https://api.github.com/repos/tokio-rs/tracing/milestones{/number}","notifications_url":"https://api.github.com/repos/tokio-rs/tracing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tokio-rs/tracing/labels{/name}","releases_url":"https://api.github.com/repos/tokio-rs/tracing/releases{/id}","deployments_url":"https://api.github.com/repos/tokio-rs/tracing/deployments","created_at":"2019-01-11T18:17:15Z","updated_at":"2019-10-30T23:33:55Z","pushed_at":"2019-10-31T01:43:13Z","git_url":"git://github.com/tokio-rs/tracing.git","ssh_url":"git@github.com:tokio-rs/tracing.git","clone_url":"https://github.com/tokio-rs/tracing.git","svn_url":"https://github.com/tokio-rs/tracing","homepage":"https://tokio.rs","size":2164,"stargazers_count":401,"watchers_count":401,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":60,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":43,"open_issues":60,"watchers":401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tokio-rs/tracing/pulls/411"},"html":{"href":"https://github.com/tokio-rs/tracing/pull/411"},"issue":{"href":"https://api.github.com/repos/tokio-rs/tracing/issues/411"},"comments":{"href":"https://api.github.com/repos/tokio-rs/tracing/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/tokio-rs/tracing/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/tokio-rs/tracing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tokio-rs/tracing/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/tokio-rs/tracing/statuses/e34c9be655b590941b1b837b49c5a4d09f5c5364"}},"author_association":"NONE"}}
|
{
"id": 165289175,
"name": "tokio-rs/tracing",
"url": "https://api.github.com/repos/tokio-rs/tracing"
}
|
{
"id": 1574827,
"login": "lunchboxav",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1574827?",
"url": "https://api.github.com/users/lunchboxav"
}
|
{
"id": 20248544,
"login": "tokio-rs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20248544?",
"url": "https://api.github.com/orgs/tokio-rs"
}
| 2019-10-31T01:43:41 |
10753264834
|
{"actor":{"display_login":"lunchboxav"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/adjoint-io/fcl/pulls/comments/309132868","pull_request_review_id":268901989,"id":309132868,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTEzMjg2OA==","diff_hunk":"@@ -0,0 +1,122 @@\n+{-# LANGUAGE GADTSyntax #-}\n+{-# LANGUAGE PatternSynonyms #-}\n+{-# LANGUAGE ViewPatterns #-}\n+module Language.FCL.Reachability.StructuredTransition\n+ ( SimpleTransition(NoSplit)\n+ , StructuredTransition(Single)\n+ , pattern XORTransitions\n+ , pattern ANDSplit\n+\n+ , mkSimpleTransition\n+ , unstructureSimpleTransition\n+ , mkStructuredTransition\n+ , unstructureTransition\n+\n+ , inputState\n+ , outputStates\n+\n+ , TransitionsGroup\n+ , structureSimply\n+ , unstructureSimply\n+ , structureTransitions\n+ , unstructureTransitions\n+\n+ ) where\n+\n+import Protolude hiding (Complex, toList)\n+\n+import qualified Data.Set as S\n+\n+import Language.FCL.AST\n+import Language.FCL.Debug (Debug(..))\n+import Language.FCL.Pretty (ppr)\n+\n+-- QUESTION: should this be here?\n+data List2 a where\n+ List2 :: a -> a -> [a] -> List2 a\n+ deriving (Eq, Ord, Show)\n+\n+fromList :: [a] -> List2 a\n+fromList [] = panic \"toList2: The input list is empty\"\n+fromList [x] = panic \"toList2: The input list is a singleton\"\n+fromList (x:y:ys) = List2 x y ys\n+\n+toList :: List2 a -> [a]\n+toList (List2 x y ys) = x:y:ys","path":"src/Language/FCL/Reachability/StructuredTransition.hs","position":45,"original_position":45,"commit_id":"1749ebf3739c6155830f3f7ba94849ccf2e4f66b","original_commit_id":"502645a5b488899cdd8a725f5425f1f0729f4224","user":{"login":"Anabra","id":18696486,"node_id":"MDQ6VXNlcjE4Njk2NDg2","avatar_url":"https://avatars3.githubusercontent.com/u/18696486?v=4","gravatar_id":"","url":"https://api.github.com/users/Anabra","html_url":"https://github.com/Anabra","followers_url":"https://api.github.com/users/Anabra/followers","following_url":"https://api.github.com/users/Anabra/following{/other_user}","gists_url":"https://api.github.com/users/Anabra/gists{/gist_id}","starred_url":"https://api.github.com/users/Anabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anabra/subscriptions","organizations_url":"https://api.github.com/users/Anabra/orgs","repos_url":"https://api.github.com/users/Anabra/repos","events_url":"https://api.github.com/users/Anabra/events{/privacy}","received_events_url":"https://api.github.com/users/Anabra/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2019-07-31T09:51:21Z","updated_at":"2019-07-31T09:51:21Z","html_url":"https://github.com/adjoint-io/fcl/pull/33#discussion_r309132868","pull_request_url":"https://api.github.com/repos/adjoint-io/fcl/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/adjoint-io/fcl/pulls/comments/309132868"},"html":{"href":"https://github.com/adjoint-io/fcl/pull/33#discussion_r309132868"},"pull_request":{"href":"https://api.github.com/repos/adjoint-io/fcl/pulls/33"}},"in_reply_to_id":308810720},"pull_request":{"url":"https://api.github.com/repos/adjoint-io/fcl/pulls/33","id":301634741,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNjM0NzQx","html_url":"https://github.com/adjoint-io/fcl/pull/33","diff_url":"https://github.com/adjoint-io/fcl/pull/33.diff","patch_url":"https://github.com/adjoint-io/fcl/pull/33.patch","issue_url":"https://api.github.com/repos/adjoint-io/fcl/issues/33","number":33,"state":"open","locked":false,"title":"Revisiting reachability analysis","user":{"login":"Anabra","id":18696486,"node_id":"MDQ6VXNlcjE4Njk2NDg2","avatar_url":"https://avatars3.githubusercontent.com/u/18696486?v=4","gravatar_id":"","url":"https://api.github.com/users/Anabra","html_url":"https://github.com/Anabra","followers_url":"https://api.github.com/users/Anabra/followers","following_url":"https://api.github.com/users/Anabra/following{/other_user}","gists_url":"https://api.github.com/users/Anabra/gists{/gist_id}","starred_url":"https://api.github.com/users/Anabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anabra/subscriptions","organizations_url":"https://api.github.com/users/Anabra/orgs","repos_url":"https://api.github.com/users/Anabra/repos","events_url":"https://api.github.com/users/Anabra/events{/privacy}","received_events_url":"https://api.github.com/users/Anabra/received_events","type":"User","site_admin":false},"body":"### Revisiting reachability analysis\r\n\r\nThe purpose of this PR is to provide a cleaner implementation for the free choice net based reachability analysis. It turned out that soundness checking is really difficult to implement with the split-and-merge approach. This version of the split-and-merge analysis identifies a subclass of sound free choice workflows. This subset is probably the set of `SafeWorkflows` (based on the QuickCheck test results).\r\n\r\nMore on this topic in the design-docs.\r\n\r\n### Testing \r\n\r\nThe new algorithm had to be tested thoroughly, so more QuickCheck tests were needed. \r\n\r\n- added extended safe workflow generation (extended by arbitrary transitions)\r\n- added cross-validation tests for split-and-merge analysis and general sound checking\r\n- refined control over the size of safe workflows during generation\r\n- added several new property-based tests \r\n\r\n### Other changes\r\n\r\nBesides the above-mentioned topic, there were some other changes as well. \r\n\r\n- structured reachability analysis into a separate directory\r\n- simplified test directory structure\r\n- generalized graphviz generation algorithm","created_at":"2019-07-26T18:05:26Z","updated_at":"2019-07-31T09:51:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d649d10e3393c941da3bb4f8850e6485a9109f93","assignee":{"login":"Anabra","id":18696486,"node_id":"MDQ6VXNlcjE4Njk2NDg2","avatar_url":"https://avatars3.githubusercontent.com/u/18696486?v=4","gravatar_id":"","url":"https://api.github.com/users/Anabra","html_url":"https://github.com/Anabra","followers_url":"https://api.github.com/users/Anabra/followers","following_url":"https://api.github.com/users/Anabra/following{/other_user}","gists_url":"https://api.github.com/users/Anabra/gists{/gist_id}","starred_url":"https://api.github.com/users/Anabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anabra/subscriptions","organizations_url":"https://api.github.com/users/Anabra/orgs","repos_url":"https://api.github.com/users/Anabra/repos","events_url":"https://api.github.com/users/Anabra/events{/privacy}","received_events_url":"https://api.github.com/users/Anabra/received_events","type":"User","site_admin":false},"assignees":[{"login":"Anabra","id":18696486,"node_id":"MDQ6VXNlcjE4Njk2NDg2","avatar_url":"https://avatars3.githubusercontent.com/u/18696486?v=4","gravatar_id":"","url":"https://api.github.com/users/Anabra","html_url":"https://github.com/Anabra","followers_url":"https://api.github.com/users/Anabra/followers","following_url":"https://api.github.com/users/Anabra/following{/other_user}","gists_url":"https://api.github.com/users/Anabra/gists{/gist_id}","starred_url":"https://api.github.com/users/Anabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anabra/subscriptions","organizations_url":"https://api.github.com/users/Anabra/orgs","repos_url":"https://api.github.com/users/Anabra/repos","events_url":"https://api.github.com/users/Anabra/events{/privacy}","received_events_url":"https://api.github.com/users/Anabra/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sdiehl","id":236767,"node_id":"MDQ6VXNlcjIzNjc2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/236767?v=4","gravatar_id":"","url":"https://api.github.com/users/sdiehl","html_url":"https://github.com/sdiehl","followers_url":"https://api.github.com/users/sdiehl/followers","following_url":"https://api.github.com/users/sdiehl/following{/other_user}","gists_url":"https://api.github.com/users/sdiehl/gists{/gist_id}","starred_url":"https://api.github.com/users/sdiehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdiehl/subscriptions","organizations_url":"https://api.github.com/users/sdiehl/orgs","repos_url":"https://api.github.com/users/sdiehl/repos","events_url":"https://api.github.com/users/sdiehl/events{/privacy}","received_events_url":"https://api.github.com/users/sdiehl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1431580362,"node_id":"MDU6TGFiZWwxNDMxNTgwMzYy","url":"https://api.github.com/repos/adjoint-io/fcl/labels/ready%20to%20review","name":"ready to review","color":"05b0c6","default":false},{"id":1380516151,"node_id":"MDU6TGFiZWwxMzgwNTE2MTUx","url":"https://api.github.com/repos/adjoint-io/fcl/labels/wip","name":"wip","color":"f7a233","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/adjoint-io/fcl/pulls/33/commits","review_comments_url":"https://api.github.com/repos/adjoint-io/fcl/pulls/33/comments","review_comment_url":"https://api.github.com/repos/adjoint-io/fcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adjoint-io/fcl/issues/33/comments","statuses_url":"https://api.github.com/repos/adjoint-io/fcl/statuses/1749ebf3739c6155830f3f7ba94849ccf2e4f66b","head":{"label":"adjoint-io:readd-general-reachability","ref":"readd-general-reachability","sha":"1749ebf3739c6155830f3f7ba94849ccf2e4f66b","user":{"login":"adjoint-io","id":20385259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzg1MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/20385259?v=4","gravatar_id":"","url":"https://api.github.com/users/adjoint-io","html_url":"https://github.com/adjoint-io","followers_url":"https://api.github.com/users/adjoint-io/followers","following_url":"https://api.github.com/users/adjoint-io/following{/other_user}","gists_url":"https://api.github.com/users/adjoint-io/gists{/gist_id}","starred_url":"https://api.github.com/users/adjoint-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjoint-io/subscriptions","organizations_url":"https://api.github.com/users/adjoint-io/orgs","repos_url":"https://api.github.com/users/adjoint-io/repos","events_url":"https://api.github.com/users/adjoint-io/events{/privacy}","received_events_url":"https://api.github.com/users/adjoint-io/received_events","type":"Organization","site_admin":false},"repo":{"id":183052276,"node_id":"MDEwOlJlcG9zaXRvcnkxODMwNTIyNzY=","name":"fcl","full_name":"adjoint-io/fcl","private":false,"owner":{"login":"adjoint-io","id":20385259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzg1MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/20385259?v=4","gravatar_id":"","url":"https://api.github.com/users/adjoint-io","html_url":"https://github.com/adjoint-io","followers_url":"https://api.github.com/users/adjoint-io/followers","following_url":"https://api.github.com/users/adjoint-io/following{/other_user}","gists_url":"https://api.github.com/users/adjoint-io/gists{/gist_id}","starred_url":"https://api.github.com/users/adjoint-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjoint-io/subscriptions","organizations_url":"https://api.github.com/users/adjoint-io/orgs","repos_url":"https://api.github.com/users/adjoint-io/repos","events_url":"https://api.github.com/users/adjoint-io/events{/privacy}","received_events_url":"https://api.github.com/users/adjoint-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adjoint-io/fcl","description":"A runtime for secure multiparty computation","fork":false,"url":"https://api.github.com/repos/adjoint-io/fcl","forks_url":"https://api.github.com/repos/adjoint-io/fcl/forks","keys_url":"https://api.github.com/repos/adjoint-io/fcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adjoint-io/fcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adjoint-io/fcl/teams","hooks_url":"https://api.github.com/repos/adjoint-io/fcl/hooks","issue_events_url":"https://api.github.com/repos/adjoint-io/fcl/issues/events{/number}","events_url":"https://api.github.com/repos/adjoint-io/fcl/events","assignees_url":"https://api.github.com/repos/adjoint-io/fcl/assignees{/user}","branches_url":"https://api.github.com/repos/adjoint-io/fcl/branches{/branch}","tags_url":"https://api.github.com/repos/adjoint-io/fcl/tags","blobs_url":"https://api.github.com/repos/adjoint-io/fcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adjoint-io/fcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adjoint-io/fcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/adjoint-io/fcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adjoint-io/fcl/statuses/{sha}","languages_url":"https://api.github.com/repos/adjoint-io/fcl/languages","stargazers_url":"https://api.github.com/repos/adjoint-io/fcl/stargazers","contributors_url":"https://api.github.com/repos/adjoint-io/fcl/contributors","subscribers_url":"https://api.github.com/repos/adjoint-io/fcl/subscribers","subscription_url":"https://api.github.com/repos/adjoint-io/fcl/subscription","commits_url":"https://api.github.com/repos/adjoint-io/fcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/adjoint-io/fcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/adjoint-io/fcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/adjoint-io/fcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/adjoint-io/fcl/contents/{+path}","compare_url":"https://api.github.com/repos/adjoint-io/fcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adjoint-io/fcl/merges","archive_url":"https://api.github.com/repos/adjoint-io/fcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adjoint-io/fcl/downloads","issues_url":"https://api.github.com/repos/adjoint-io/fcl/issues{/number}","pulls_url":"https://api.github.com/repos/adjoint-io/fcl/pulls{/number}","milestones_url":"https://api.github.com/repos/adjoint-io/fcl/milestones{/number}","notifications_url":"https://api.github.com/repos/adjoint-io/fcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adjoint-io/fcl/labels{/name}","releases_url":"https://api.github.com/repos/adjoint-io/fcl/releases{/id}","deployments_url":"https://api.github.com/repos/adjoint-io/fcl/deployments","created_at":"2019-04-23T16:13:33Z","updated_at":"2019-07-30T08:40:01Z","pushed_at":"2019-07-30T20:52:40Z","git_url":"git://github.com/adjoint-io/fcl.git","ssh_url":"git@github.com:adjoint-io/fcl.git","clone_url":"https://github.com/adjoint-io/fcl.git","svn_url":"https://github.com/adjoint-io/fcl","homepage":"https://www.adjoint.io","size":853,"stargazers_count":17,"watchers_count":17,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":17,"default_branch":"master"}},"base":{"label":"adjoint-io:master","ref":"master","sha":"0afbe884d9435fef221468fe58ff2ca079efe8a0","user":{"login":"adjoint-io","id":20385259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzg1MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/20385259?v=4","gravatar_id":"","url":"https://api.github.com/users/adjoint-io","html_url":"https://github.com/adjoint-io","followers_url":"https://api.github.com/users/adjoint-io/followers","following_url":"https://api.github.com/users/adjoint-io/following{/other_user}","gists_url":"https://api.github.com/users/adjoint-io/gists{/gist_id}","starred_url":"https://api.github.com/users/adjoint-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjoint-io/subscriptions","organizations_url":"https://api.github.com/users/adjoint-io/orgs","repos_url":"https://api.github.com/users/adjoint-io/repos","events_url":"https://api.github.com/users/adjoint-io/events{/privacy}","received_events_url":"https://api.github.com/users/adjoint-io/received_events","type":"Organization","site_admin":false},"repo":{"id":183052276,"node_id":"MDEwOlJlcG9zaXRvcnkxODMwNTIyNzY=","name":"fcl","full_name":"adjoint-io/fcl","private":false,"owner":{"login":"adjoint-io","id":20385259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzg1MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/20385259?v=4","gravatar_id":"","url":"https://api.github.com/users/adjoint-io","html_url":"https://github.com/adjoint-io","followers_url":"https://api.github.com/users/adjoint-io/followers","following_url":"https://api.github.com/users/adjoint-io/following{/other_user}","gists_url":"https://api.github.com/users/adjoint-io/gists{/gist_id}","starred_url":"https://api.github.com/users/adjoint-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjoint-io/subscriptions","organizations_url":"https://api.github.com/users/adjoint-io/orgs","repos_url":"https://api.github.com/users/adjoint-io/repos","events_url":"https://api.github.com/users/adjoint-io/events{/privacy}","received_events_url":"https://api.github.com/users/adjoint-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adjoint-io/fcl","description":"A runtime for secure multiparty computation","fork":false,"url":"https://api.github.com/repos/adjoint-io/fcl","forks_url":"https://api.github.com/repos/adjoint-io/fcl/forks","keys_url":"https://api.github.com/repos/adjoint-io/fcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adjoint-io/fcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adjoint-io/fcl/teams","hooks_url":"https://api.github.com/repos/adjoint-io/fcl/hooks","issue_events_url":"https://api.github.com/repos/adjoint-io/fcl/issues/events{/number}","events_url":"https://api.github.com/repos/adjoint-io/fcl/events","assignees_url":"https://api.github.com/repos/adjoint-io/fcl/assignees{/user}","branches_url":"https://api.github.com/repos/adjoint-io/fcl/branches{/branch}","tags_url":"https://api.github.com/repos/adjoint-io/fcl/tags","blobs_url":"https://api.github.com/repos/adjoint-io/fcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adjoint-io/fcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adjoint-io/fcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/adjoint-io/fcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adjoint-io/fcl/statuses/{sha}","languages_url":"https://api.github.com/repos/adjoint-io/fcl/languages","stargazers_url":"https://api.github.com/repos/adjoint-io/fcl/stargazers","contributors_url":"https://api.github.com/repos/adjoint-io/fcl/contributors","subscribers_url":"https://api.github.com/repos/adjoint-io/fcl/subscribers","subscription_url":"https://api.github.com/repos/adjoint-io/fcl/subscription","commits_url":"https://api.github.com/repos/adjoint-io/fcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/adjoint-io/fcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/adjoint-io/fcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/adjoint-io/fcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/adjoint-io/fcl/contents/{+path}","compare_url":"https://api.github.com/repos/adjoint-io/fcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adjoint-io/fcl/merges","archive_url":"https://api.github.com/repos/adjoint-io/fcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adjoint-io/fcl/downloads","issues_url":"https://api.github.com/repos/adjoint-io/fcl/issues{/number}","pulls_url":"https://api.github.com/repos/adjoint-io/fcl/pulls{/number}","milestones_url":"https://api.github.com/repos/adjoint-io/fcl/milestones{/number}","notifications_url":"https://api.github.com/repos/adjoint-io/fcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adjoint-io/fcl/labels{/name}","releases_url":"https://api.github.com/repos/adjoint-io/fcl/releases{/id}","deployments_url":"https://api.github.com/repos/adjoint-io/fcl/deployments","created_at":"2019-04-23T16:13:33Z","updated_at":"2019-07-30T08:40:01Z","pushed_at":"2019-07-30T20:52:40Z","git_url":"git://github.com/adjoint-io/fcl.git","ssh_url":"git@github.com:adjoint-io/fcl.git","clone_url":"https://github.com/adjoint-io/fcl.git","svn_url":"https://github.com/adjoint-io/fcl","homepage":"https://www.adjoint.io","size":853,"stargazers_count":17,"watchers_count":17,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adjoint-io/fcl/pulls/33"},"html":{"href":"https://github.com/adjoint-io/fcl/pull/33"},"issue":{"href":"https://api.github.com/repos/adjoint-io/fcl/issues/33"},"comments":{"href":"https://api.github.com/repos/adjoint-io/fcl/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/adjoint-io/fcl/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/adjoint-io/fcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adjoint-io/fcl/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/adjoint-io/fcl/statuses/1749ebf3739c6155830f3f7ba94849ccf2e4f66b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 183052276,
"name": "adjoint-io/fcl",
"url": "https://api.github.com/repos/adjoint-io/fcl"
}
|
{
"id": 18696486,
"login": "Anabra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18696486?",
"url": "https://api.github.com/users/Anabra"
}
|
{
"id": 20385259,
"login": "adjoint-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20385259?",
"url": "https://api.github.com/orgs/adjoint-io"
}
| 2019-07-31T09:51:21 |
10118790928
|
{"actor":{"display_login":"Anabra"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/anz-bank/go-slides/pulls/comments/284594548","pull_request_review_id":238232869,"id":284594548,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDU5NDU0OA==","diff_hunk":"@@ -813,49 +816,106 @@ Embedding types introduces the possiblity for naming conflicts. Go follows some\n .caption J. D. Frazer \"Illiad\", User Friendly - [[https://en.wikipedia.org/wiki/User_Friendly#Crud_Puppy][Crud Puppy]]\n \n \n-* Errors (1/3)\n+* Errors in Go\n \n-\"Errors are values.\" - [[https://go-proverbs.github.io/][Rob Pike]]\n-\n-The `error` type is a built-in interface:\n+- `error` a builtin interface ([[https://golang.org/src/builtin/builtin.go?s=11246:11286#L251][source: error]])\n+- Check errors explicitly\n+- The [[https://golang.org/pkg/errors/][`errors`]] package has functions for creating new error type\n+- Creation of new error type can be done in a few ways:\n \n-\ttype error interface {\n-\t Error() string\n+\tfunc Sqrt(f float64) (float64, error) {\n+\t\tif f < 0 {\n+\t\t\treturn 0, errors.New(\"math: square root of negative number\")\n+\t\t}\n+\t\t// implementation\n \t}\n+- Or use formatted error message using `fmt.Errorf`:\n+\tif f < 0 {\n+\t\treturn 0, fmt.Errorf(\"math: square root of negative number %g\", f)\n+\t}\n+\n+* Errors in Go (continued)\n \n-By convention, functions often return `error` as the second/last return value.\n-The calling code should handle errors by testing whether the error equals nil:\n+- Custom error types can be created. Example from `net` package [[https://golang.org/pkg/net/#AddrError][net/AddrError]]:\n+\ttype AddrError struct {\n+\t\tErr string\n+\t\tAddr string\n+\t}\n \n-\tfunc getCat(strID string) (*Cat, error) {\n-\t\tid, err := strconv.Atoi(strID)\n-\t\tif err != nil {\n-\t\t return nil, CatError(err)\n+\tfunc (e *AddrError) Error() string {\n+\t\tif e == nil {\n+\t\t\treturn \"<nil>\"\n+\t\t}\n+\t\ts := e.Err\n+\t\tif e.Addr != \"\" {\n+\t\t\ts = \"address \" + e.Addr + \": \" + s\n \t\t}\n-\t\treturn catStore.cats[id], nil\n+\t\treturn s\n \t}\n+- The error values can be logged and printed:\n \n+\t_, err := Sqrt(-1); err != nil {\n+\t\tlog.Println(err)\n+\t}\n \n-* Errors (2/3)\n \n-\"Don't panic.\" - [[https://go-proverbs.github.io/][Rob Pike]]\n+* Error Handling\n \n-Panic should be used when something went unexpectedly wrong.\n-For instance, initialise a regular expression with [[https://golang.org/pkg/regexp/#MustCompile][regexp.MustCompile]] if the pattern is a string constant.\n-`MustCompile` will `panic` at initialisation.\n+- Check for the presence of an error (compare with nil)\n+- Do not compare error variables ([[https://goplay.space/#mgw9QAmeLUP][samples/errors4.go]])\n+- Errors are values so it can be programmed ([[https://goplay.space/#kbBftimqvuF][samples/errors5.go]])\n+- Handle errors gracefully ([[https://goplay.space/#GkfuGGvpL0F][A useful pattern (samples/errors6.go)]])","path":"content/gocourse-2019-05-melbourne.slide","position":126,"original_position":126,"commit_id":"062792feface9b2fa3179c9b79e28a438749e099","original_commit_id":"062792feface9b2fa3179c9b79e28a438749e099","user":{"login":"juliaogris","id":1596871,"node_id":"MDQ6VXNlcjE1OTY4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1596871?v=4","gravatar_id":"","url":"https://api.github.com/users/juliaogris","html_url":"https://github.com/juliaogris","followers_url":"https://api.github.com/users/juliaogris/followers","following_url":"https://api.github.com/users/juliaogris/following{/other_user}","gists_url":"https://api.github.com/users/juliaogris/gists{/gist_id}","starred_url":"https://api.github.com/users/juliaogris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliaogris/subscriptions","organizations_url":"https://api.github.com/users/juliaogris/orgs","repos_url":"https://api.github.com/users/juliaogris/repos","events_url":"https://api.github.com/users/juliaogris/events{/privacy}","received_events_url":"https://api.github.com/users/juliaogris/received_events","type":"User","site_admin":false},"body":"This is a pretty long example and I didn't quite get what it intends to illustrate.\r\n`AppendClosure` is a bit of a confusing term to me as closure indicates Function Closure as often used in JS, [wiki](https://en.wikipedia.org/wiki/Closure_(computer_programming)), [StackOverflow](https://stackoverflow.com/a/7464475)) and also available in Go (and discussed in [slides](http://go-course.org/gocourse-2019-05-melbourne.slide#55))","created_at":"2019-05-16T08:32:50Z","updated_at":"2019-05-16T08:38:35Z","html_url":"https://github.com/anz-bank/go-slides/pull/62#discussion_r284594548","pull_request_url":"https://api.github.com/repos/anz-bank/go-slides/pulls/62","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/anz-bank/go-slides/pulls/comments/284594548"},"html":{"href":"https://github.com/anz-bank/go-slides/pull/62#discussion_r284594548"},"pull_request":{"href":"https://api.github.com/repos/anz-bank/go-slides/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/anz-bank/go-slides/pulls/62","id":278112829,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4MTEyODI5","html_url":"https://github.com/anz-bank/go-slides/pull/62","diff_url":"https://github.com/anz-bank/go-slides/pull/62.diff","patch_url":"https://github.com/anz-bank/go-slides/pull/62.patch","issue_url":"https://api.github.com/repos/anz-bank/go-slides/issues/62","number":62,"state":"open","locked":false,"title":"Add and update slides for errors, defer, panic and recover","user":{"login":"linuxmonk","id":16968915,"node_id":"MDQ6VXNlcjE2OTY4OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/16968915?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxmonk","html_url":"https://github.com/linuxmonk","followers_url":"https://api.github.com/users/linuxmonk/followers","following_url":"https://api.github.com/users/linuxmonk/following{/other_user}","gists_url":"https://api.github.com/users/linuxmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxmonk/subscriptions","organizations_url":"https://api.github.com/users/linuxmonk/orgs","repos_url":"https://api.github.com/users/linuxmonk/repos","events_url":"https://api.github.com/users/linuxmonk/events{/privacy}","received_events_url":"https://api.github.com/users/linuxmonk/received_events","type":"User","site_admin":false},"body":"* Update slides 58-64\r\n* Examples for error detection and handling\r\n* Examples for defer, panic and recover\r\n\r\nCloses #27\r\n\r\nReview at\r\nhttps://pr62-dot-gotraining-testing.appspot.com/gocourse-2019-05-melbourne.slide#66","created_at":"2019-05-13T03:42:58Z","updated_at":"2019-05-16T08:38:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f31001b91489c993ceb3175e2c41a1c76dca3b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/anz-bank/go-slides/pulls/62/commits","review_comments_url":"https://api.github.com/repos/anz-bank/go-slides/pulls/62/comments","review_comment_url":"https://api.github.com/repos/anz-bank/go-slides/pulls/comments{/number}","comments_url":"https://api.github.com/repos/anz-bank/go-slides/issues/62/comments","statuses_url":"https://api.github.com/repos/anz-bank/go-slides/statuses/062792feface9b2fa3179c9b79e28a438749e099","head":{"label":"anz-bank:content/update-slide-errors","ref":"content/update-slide-errors","sha":"062792feface9b2fa3179c9b79e28a438749e099","user":{"login":"anz-bank","id":20446890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQ2ODkw","avatar_url":"https://avatars1.githubusercontent.com/u/20446890?v=4","gravatar_id":"","url":"https://api.github.com/users/anz-bank","html_url":"https://github.com/anz-bank","followers_url":"https://api.github.com/users/anz-bank/followers","following_url":"https://api.github.com/users/anz-bank/following{/other_user}","gists_url":"https://api.github.com/users/anz-bank/gists{/gist_id}","starred_url":"https://api.github.com/users/anz-bank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anz-bank/subscriptions","organizations_url":"https://api.github.com/users/anz-bank/orgs","repos_url":"https://api.github.com/users/anz-bank/repos","events_url":"https://api.github.com/users/anz-bank/events{/privacy}","received_events_url":"https://api.github.com/users/anz-bank/received_events","type":"Organization","site_admin":false},"repo":{"id":168247757,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgyNDc3NTc=","name":"go-slides","full_name":"anz-bank/go-slides","private":false,"owner":{"login":"anz-bank","id":20446890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQ2ODkw","avatar_url":"https://avatars1.githubusercontent.com/u/20446890?v=4","gravatar_id":"","url":"https://api.github.com/users/anz-bank","html_url":"https://github.com/anz-bank","followers_url":"https://api.github.com/users/anz-bank/followers","following_url":"https://api.github.com/users/anz-bank/following{/other_user}","gists_url":"https://api.github.com/users/anz-bank/gists{/gist_id}","starred_url":"https://api.github.com/users/anz-bank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anz-bank/subscriptions","organizations_url":"https://api.github.com/users/anz-bank/orgs","repos_url":"https://api.github.com/users/anz-bank/repos","events_url":"https://api.github.com/users/anz-bank/events{/privacy}","received_events_url":"https://api.github.com/users/anz-bank/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/anz-bank/go-slides","description":"Go Training slides and demos","fork":false,"url":"https://api.github.com/repos/anz-bank/go-slides","forks_url":"https://api.github.com/repos/anz-bank/go-slides/forks","keys_url":"https://api.github.com/repos/anz-bank/go-slides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anz-bank/go-slides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anz-bank/go-slides/teams","hooks_url":"https://api.github.com/repos/anz-bank/go-slides/hooks","issue_events_url":"https://api.github.com/repos/anz-bank/go-slides/issues/events{/number}","events_url":"https://api.github.com/repos/anz-bank/go-slides/events","assignees_url":"https://api.github.com/repos/anz-bank/go-slides/assignees{/user}","branches_url":"https://api.github.com/repos/anz-bank/go-slides/branches{/branch}","tags_url":"https://api.github.com/repos/anz-bank/go-slides/tags","blobs_url":"https://api.github.com/repos/anz-bank/go-slides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anz-bank/go-slides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anz-bank/go-slides/git/refs{/sha}","trees_url":"https://api.github.com/repos/anz-bank/go-slides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anz-bank/go-slides/statuses/{sha}","languages_url":"https://api.github.com/repos/anz-bank/go-slides/languages","stargazers_url":"https://api.github.com/repos/anz-bank/go-slides/stargazers","contributors_url":"https://api.github.com/repos/anz-bank/go-slides/contributors","subscribers_url":"https://api.github.com/repos/anz-bank/go-slides/subscribers","subscription_url":"https://api.github.com/repos/anz-bank/go-slides/subscription","commits_url":"https://api.github.com/repos/anz-bank/go-slides/commits{/sha}","git_commits_url":"https://api.github.com/repos/anz-bank/go-slides/git/commits{/sha}","comments_url":"https://api.github.com/repos/anz-bank/go-slides/comments{/number}","issue_comment_url":"https://api.github.com/repos/anz-bank/go-slides/issues/comments{/number}","contents_url":"https://api.github.com/repos/anz-bank/go-slides/contents/{+path}","compare_url":"https://api.github.com/repos/anz-bank/go-slides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anz-bank/go-slides/merges","archive_url":"https://api.github.com/repos/anz-bank/go-slides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anz-bank/go-slides/downloads","issues_url":"https://api.github.com/repos/anz-bank/go-slides/issues{/number}","pulls_url":"https://api.github.com/repos/anz-bank/go-slides/pulls{/number}","milestones_url":"https://api.github.com/repos/anz-bank/go-slides/milestones{/number}","notifications_url":"https://api.github.com/repos/anz-bank/go-slides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anz-bank/go-slides/labels{/name}","releases_url":"https://api.github.com/repos/anz-bank/go-slides/releases{/id}","deployments_url":"https://api.github.com/repos/anz-bank/go-slides/deployments","created_at":"2019-01-29T23:46:33Z","updated_at":"2019-05-13T06:13:05Z","pushed_at":"2019-05-16T06:31:52Z","git_url":"git://github.com/anz-bank/go-slides.git","ssh_url":"git@github.com:anz-bank/go-slides.git","clone_url":"https://github.com/anz-bank/go-slides.git","svn_url":"https://github.com/anz-bank/go-slides","homepage":"https://go-course.org/","size":536,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":22,"watchers":0,"default_branch":"master"}},"base":{"label":"anz-bank:master","ref":"master","sha":"fe008a362b449b3bd2212215b01c0f96f5951d16","user":{"login":"anz-bank","id":20446890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQ2ODkw","avatar_url":"https://avatars1.githubusercontent.com/u/20446890?v=4","gravatar_id":"","url":"https://api.github.com/users/anz-bank","html_url":"https://github.com/anz-bank","followers_url":"https://api.github.com/users/anz-bank/followers","following_url":"https://api.github.com/users/anz-bank/following{/other_user}","gists_url":"https://api.github.com/users/anz-bank/gists{/gist_id}","starred_url":"https://api.github.com/users/anz-bank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anz-bank/subscriptions","organizations_url":"https://api.github.com/users/anz-bank/orgs","repos_url":"https://api.github.com/users/anz-bank/repos","events_url":"https://api.github.com/users/anz-bank/events{/privacy}","received_events_url":"https://api.github.com/users/anz-bank/received_events","type":"Organization","site_admin":false},"repo":{"id":168247757,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgyNDc3NTc=","name":"go-slides","full_name":"anz-bank/go-slides","private":false,"owner":{"login":"anz-bank","id":20446890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQ2ODkw","avatar_url":"https://avatars1.githubusercontent.com/u/20446890?v=4","gravatar_id":"","url":"https://api.github.com/users/anz-bank","html_url":"https://github.com/anz-bank","followers_url":"https://api.github.com/users/anz-bank/followers","following_url":"https://api.github.com/users/anz-bank/following{/other_user}","gists_url":"https://api.github.com/users/anz-bank/gists{/gist_id}","starred_url":"https://api.github.com/users/anz-bank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anz-bank/subscriptions","organizations_url":"https://api.github.com/users/anz-bank/orgs","repos_url":"https://api.github.com/users/anz-bank/repos","events_url":"https://api.github.com/users/anz-bank/events{/privacy}","received_events_url":"https://api.github.com/users/anz-bank/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/anz-bank/go-slides","description":"Go Training slides and demos","fork":false,"url":"https://api.github.com/repos/anz-bank/go-slides","forks_url":"https://api.github.com/repos/anz-bank/go-slides/forks","keys_url":"https://api.github.com/repos/anz-bank/go-slides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anz-bank/go-slides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anz-bank/go-slides/teams","hooks_url":"https://api.github.com/repos/anz-bank/go-slides/hooks","issue_events_url":"https://api.github.com/repos/anz-bank/go-slides/issues/events{/number}","events_url":"https://api.github.com/repos/anz-bank/go-slides/events","assignees_url":"https://api.github.com/repos/anz-bank/go-slides/assignees{/user}","branches_url":"https://api.github.com/repos/anz-bank/go-slides/branches{/branch}","tags_url":"https://api.github.com/repos/anz-bank/go-slides/tags","blobs_url":"https://api.github.com/repos/anz-bank/go-slides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anz-bank/go-slides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anz-bank/go-slides/git/refs{/sha}","trees_url":"https://api.github.com/repos/anz-bank/go-slides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anz-bank/go-slides/statuses/{sha}","languages_url":"https://api.github.com/repos/anz-bank/go-slides/languages","stargazers_url":"https://api.github.com/repos/anz-bank/go-slides/stargazers","contributors_url":"https://api.github.com/repos/anz-bank/go-slides/contributors","subscribers_url":"https://api.github.com/repos/anz-bank/go-slides/subscribers","subscription_url":"https://api.github.com/repos/anz-bank/go-slides/subscription","commits_url":"https://api.github.com/repos/anz-bank/go-slides/commits{/sha}","git_commits_url":"https://api.github.com/repos/anz-bank/go-slides/git/commits{/sha}","comments_url":"https://api.github.com/repos/anz-bank/go-slides/comments{/number}","issue_comment_url":"https://api.github.com/repos/anz-bank/go-slides/issues/comments{/number}","contents_url":"https://api.github.com/repos/anz-bank/go-slides/contents/{+path}","compare_url":"https://api.github.com/repos/anz-bank/go-slides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anz-bank/go-slides/merges","archive_url":"https://api.github.com/repos/anz-bank/go-slides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anz-bank/go-slides/downloads","issues_url":"https://api.github.com/repos/anz-bank/go-slides/issues{/number}","pulls_url":"https://api.github.com/repos/anz-bank/go-slides/pulls{/number}","milestones_url":"https://api.github.com/repos/anz-bank/go-slides/milestones{/number}","notifications_url":"https://api.github.com/repos/anz-bank/go-slides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anz-bank/go-slides/labels{/name}","releases_url":"https://api.github.com/repos/anz-bank/go-slides/releases{/id}","deployments_url":"https://api.github.com/repos/anz-bank/go-slides/deployments","created_at":"2019-01-29T23:46:33Z","updated_at":"2019-05-13T06:13:05Z","pushed_at":"2019-05-16T06:31:52Z","git_url":"git://github.com/anz-bank/go-slides.git","ssh_url":"git@github.com:anz-bank/go-slides.git","clone_url":"https://github.com/anz-bank/go-slides.git","svn_url":"https://github.com/anz-bank/go-slides","homepage":"https://go-course.org/","size":536,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":22,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/anz-bank/go-slides/pulls/62"},"html":{"href":"https://github.com/anz-bank/go-slides/pull/62"},"issue":{"href":"https://api.github.com/repos/anz-bank/go-slides/issues/62"},"comments":{"href":"https://api.github.com/repos/anz-bank/go-slides/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/anz-bank/go-slides/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/anz-bank/go-slides/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/anz-bank/go-slides/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/anz-bank/go-slides/statuses/062792feface9b2fa3179c9b79e28a438749e099"}},"author_association":"COLLABORATOR"}}
|
{
"id": 168247757,
"name": "anz-bank/go-slides",
"url": "https://api.github.com/repos/anz-bank/go-slides"
}
|
{
"id": 1596871,
"login": "juliaogris",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1596871?",
"url": "https://api.github.com/users/juliaogris"
}
|
{
"id": 20446890,
"login": "anz-bank",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20446890?",
"url": "https://api.github.com/orgs/anz-bank"
}
| 2019-05-16T08:32:50 |
9637365278
|
{"actor":{"display_login":"juliaogris"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/anz-bank/sysl/pulls/comments/335784134","pull_request_review_id":302970821,"id":335784134,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTc4NDEzNA==","diff_hunk":"@@ -0,0 +1,50 @@\n+package main\n+\n+import (\n+\t\"fmt\"\n+\t\"io/ioutil\"\n+\n+\t\"github.com/anz-bank/sysl/sysl2/sysl/exporter\"\n+\t\"gopkg.in/alecthomas/kingpin.v2\"\n+)\n+\n+type swaggerExportCmd struct {\n+\tappName string\n+\toutSwagger string\n+}\n+\n+func (p *swaggerExportCmd) Name() string { return \"export-swagger\" }\n+func (p *swaggerExportCmd) RequireSyslModule() bool { return true }\n+\n+func (p *swaggerExportCmd) Configure(app *kingpin.Application) *kingpin.CmdClause {","path":"sysl2/sysl/cmd_swaggerexport.go","position":19,"original_position":19,"commit_id":"89f7978367d4c5359b98afff093453a9edc1e51b","original_commit_id":"89f7978367d4c5359b98afff093453a9edc1e51b","user":{"login":"golangcibot","id":42910462,"node_id":"MDQ6VXNlcjQyOTEwNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/42910462?v=4","gravatar_id":"","url":"https://api.github.com/users/golangcibot","html_url":"https://github.com/golangcibot","followers_url":"https://api.github.com/users/golangcibot/followers","following_url":"https://api.github.com/users/golangcibot/following{/other_user}","gists_url":"https://api.github.com/users/golangcibot/gists{/gist_id}","starred_url":"https://api.github.com/users/golangcibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangcibot/subscriptions","organizations_url":"https://api.github.com/users/golangcibot/orgs","repos_url":"https://api.github.com/users/golangcibot/repos","events_url":"https://api.github.com/users/golangcibot/events{/privacy}","received_events_url":"https://api.github.com/users/golangcibot/received_events","type":"User","site_admin":false},"body":"unnecessary leading newline (from `whitespace`)","created_at":"2019-10-17T02:18:06Z","updated_at":"2019-10-17T02:18:06Z","html_url":"https://github.com/anz-bank/sysl/pull/366#discussion_r335784134","pull_request_url":"https://api.github.com/repos/anz-bank/sysl/pulls/366","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/anz-bank/sysl/pulls/comments/335784134"},"html":{"href":"https://github.com/anz-bank/sysl/pull/366#discussion_r335784134"},"pull_request":{"href":"https://api.github.com/repos/anz-bank/sysl/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/anz-bank/sysl/pulls/366","id":329033160,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MDMzMTYw","html_url":"https://github.com/anz-bank/sysl/pull/366","diff_url":"https://github.com/anz-bank/sysl/pull/366.diff","patch_url":"https://github.com/anz-bank/sysl/pull/366.patch","issue_url":"https://api.github.com/repos/anz-bank/sysl/issues/366","number":366,"state":"open","locked":false,"title":"Export sysl to swagger spec","user":{"login":"springwiz","id":35112291,"node_id":"MDQ6VXNlcjM1MTEyMjkx","avatar_url":"https://avatars3.githubusercontent.com/u/35112291?v=4","gravatar_id":"","url":"https://api.github.com/users/springwiz","html_url":"https://github.com/springwiz","followers_url":"https://api.github.com/users/springwiz/followers","following_url":"https://api.github.com/users/springwiz/following{/other_user}","gists_url":"https://api.github.com/users/springwiz/gists{/gist_id}","starred_url":"https://api.github.com/users/springwiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springwiz/subscriptions","organizations_url":"https://api.github.com/users/springwiz/orgs","repos_url":"https://api.github.com/users/springwiz/repos","events_url":"https://api.github.com/users/springwiz/events{/privacy}","received_events_url":"https://api.github.com/users/springwiz/received_events","type":"User","site_admin":false},"body":"Export sysl file to Swagger spec.\r\n\r\nChanges proposed in this pull request:\r\n- Basic type mapping between Sysl and Swagger Types\r\n- Added Swagger Export as a new Sysl Subcommand\r\n- Test-Data for testing Swagger Export\r\n\r\n@anz-bank/sysl-developers\r\n","created_at":"2019-10-17T02:16:16Z","updated_at":"2019-10-17T02:18:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1a9df3ee6d6d52652d853094ff16615dc58a3dc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anzdaddy","id":13160581,"node_id":"MDQ6VXNlcjEzMTYwNTgx","avatar_url":"https://avatars0.githubusercontent.com/u/13160581?v=4","gravatar_id":"","url":"https://api.github.com/users/anzdaddy","html_url":"https://github.com/anzdaddy","followers_url":"https://api.github.com/users/anzdaddy/followers","following_url":"https://api.github.com/users/anzdaddy/following{/other_user}","gists_url":"https://api.github.com/users/anzdaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/anzdaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anzdaddy/subscriptions","organizations_url":"https://api.github.com/users/anzdaddy/orgs","repos_url":"https://api.github.com/users/anzdaddy/repos","events_url":"https://api.github.com/users/anzdaddy/events{/privacy}","received_events_url":"https://api.github.com/users/anzdaddy/received_events","type":"User","site_admin":false},{"login":"anz-gordonj7","id":55072966,"node_id":"MDQ6VXNlcjU1MDcyOTY2","avatar_url":"https://avatars0.githubusercontent.com/u/55072966?v=4","gravatar_id":"","url":"https://api.github.com/users/anz-gordonj7","html_url":"https://github.com/anz-gordonj7","followers_url":"https://api.github.com/users/anz-gordonj7/followers","following_url":"https://api.github.com/users/anz-gordonj7/following{/other_user}","gists_url":"https://api.github.com/users/anz-gordonj7/gists{/gist_id}","starred_url":"https://api.github.com/users/anz-gordonj7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anz-gordonj7/subscriptions","organizations_url":"https://api.github.com/users/anz-gordonj7/orgs","repos_url":"https://api.github.com/users/anz-gordonj7/repos","events_url":"https://api.github.com/users/anz-gordonj7/events{/privacy}","received_events_url":"https://api.github.com/users/anz-gordonj7/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/anz-bank/sysl/pulls/366/commits","review_comments_url":"https://api.github.com/repos/anz-bank/sysl/pulls/366/comments","review_comment_url":"https://api.github.com/repos/anz-bank/sysl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/anz-bank/sysl/issues/366/comments","statuses_url":"https://api.github.com/repos/anz-bank/sysl/statuses/89f7978367d4c5359b98afff093453a9edc1e51b","head":{"label":"springwiz:swaggerexport","ref":"swaggerexport","sha":"89f7978367d4c5359b98afff093453a9edc1e51b","user":{"login":"springwiz","id":35112291,"node_id":"MDQ6VXNlcjM1MTEyMjkx","avatar_url":"https://avatars3.githubusercontent.com/u/35112291?v=4","gravatar_id":"","url":"https://api.github.com/users/springwiz","html_url":"https://github.com/springwiz","followers_url":"https://api.github.com/users/springwiz/followers","following_url":"https://api.github.com/users/springwiz/following{/other_user}","gists_url":"https://api.github.com/users/springwiz/gists{/gist_id}","starred_url":"https://api.github.com/users/springwiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springwiz/subscriptions","organizations_url":"https://api.github.com/users/springwiz/orgs","repos_url":"https://api.github.com/users/springwiz/repos","events_url":"https://api.github.com/users/springwiz/events{/privacy}","received_events_url":"https://api.github.com/users/springwiz/received_events","type":"User","site_admin":false},"repo":{"id":196334507,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYzMzQ1MDc=","name":"sysl","full_name":"springwiz/sysl","private":false,"owner":{"login":"springwiz","id":35112291,"node_id":"MDQ6VXNlcjM1MTEyMjkx","avatar_url":"https://avatars3.githubusercontent.com/u/35112291?v=4","gravatar_id":"","url":"https://api.github.com/users/springwiz","html_url":"https://github.com/springwiz","followers_url":"https://api.github.com/users/springwiz/followers","following_url":"https://api.github.com/users/springwiz/following{/other_user}","gists_url":"https://api.github.com/users/springwiz/gists{/gist_id}","starred_url":"https://api.github.com/users/springwiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springwiz/subscriptions","organizations_url":"https://api.github.com/users/springwiz/orgs","repos_url":"https://api.github.com/users/springwiz/repos","events_url":"https://api.github.com/users/springwiz/events{/privacy}","received_events_url":"https://api.github.com/users/springwiz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/springwiz/sysl","description":"Sysl (pronounced \"sizzle\") is a system specification language","fork":true,"url":"https://api.github.com/repos/springwiz/sysl","forks_url":"https://api.github.com/repos/springwiz/sysl/forks","keys_url":"https://api.github.com/repos/springwiz/sysl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/springwiz/sysl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/springwiz/sysl/teams","hooks_url":"https://api.github.com/repos/springwiz/sysl/hooks","issue_events_url":"https://api.github.com/repos/springwiz/sysl/issues/events{/number}","events_url":"https://api.github.com/repos/springwiz/sysl/events","assignees_url":"https://api.github.com/repos/springwiz/sysl/assignees{/user}","branches_url":"https://api.github.com/repos/springwiz/sysl/branches{/branch}","tags_url":"https://api.github.com/repos/springwiz/sysl/tags","blobs_url":"https://api.github.com/repos/springwiz/sysl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/springwiz/sysl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/springwiz/sysl/git/refs{/sha}","trees_url":"https://api.github.com/repos/springwiz/sysl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/springwiz/sysl/statuses/{sha}","languages_url":"https://api.github.com/repos/springwiz/sysl/languages","stargazers_url":"https://api.github.com/repos/springwiz/sysl/stargazers","contributors_url":"https://api.github.com/repos/springwiz/sysl/contributors","subscribers_url":"https://api.github.com/repos/springwiz/sysl/subscribers","subscription_url":"https://api.github.com/repos/springwiz/sysl/subscription","commits_url":"https://api.github.com/repos/springwiz/sysl/commits{/sha}","git_commits_url":"https://api.github.com/repos/springwiz/sysl/git/commits{/sha}","comments_url":"https://api.github.com/repos/springwiz/sysl/comments{/number}","issue_comment_url":"https://api.github.com/repos/springwiz/sysl/issues/comments{/number}","contents_url":"https://api.github.com/repos/springwiz/sysl/contents/{+path}","compare_url":"https://api.github.com/repos/springwiz/sysl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/springwiz/sysl/merges","archive_url":"https://api.github.com/repos/springwiz/sysl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/springwiz/sysl/downloads","issues_url":"https://api.github.com/repos/springwiz/sysl/issues{/number}","pulls_url":"https://api.github.com/repos/springwiz/sysl/pulls{/number}","milestones_url":"https://api.github.com/repos/springwiz/sysl/milestones{/number}","notifications_url":"https://api.github.com/repos/springwiz/sysl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/springwiz/sysl/labels{/name}","releases_url":"https://api.github.com/repos/springwiz/sysl/releases{/id}","deployments_url":"https://api.github.com/repos/springwiz/sysl/deployments","created_at":"2019-07-11T06:38:22Z","updated_at":"2019-10-17T01:54:38Z","pushed_at":"2019-10-17T02:11:31Z","git_url":"git://github.com/springwiz/sysl.git","ssh_url":"git@github.com:springwiz/sysl.git","clone_url":"https://github.com/springwiz/sysl.git","svn_url":"https://github.com/springwiz/sysl","homepage":"https://sysl.io","size":6200,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"anz-bank:master","ref":"master","sha":"c905466f151bda1e5aaea75e75c0f5f121d0e278","user":{"login":"anz-bank","id":20446890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQ2ODkw","avatar_url":"https://avatars1.githubusercontent.com/u/20446890?v=4","gravatar_id":"","url":"https://api.github.com/users/anz-bank","html_url":"https://github.com/anz-bank","followers_url":"https://api.github.com/users/anz-bank/followers","following_url":"https://api.github.com/users/anz-bank/following{/other_user}","gists_url":"https://api.github.com/users/anz-bank/gists{/gist_id}","starred_url":"https://api.github.com/users/anz-bank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anz-bank/subscriptions","organizations_url":"https://api.github.com/users/anz-bank/orgs","repos_url":"https://api.github.com/users/anz-bank/repos","events_url":"https://api.github.com/users/anz-bank/events{/privacy}","received_events_url":"https://api.github.com/users/anz-bank/received_events","type":"Organization","site_admin":false},"repo":{"id":63280456,"node_id":"MDEwOlJlcG9zaXRvcnk2MzI4MDQ1Ng==","name":"sysl","full_name":"anz-bank/sysl","private":false,"owner":{"login":"anz-bank","id":20446890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQ2ODkw","avatar_url":"https://avatars1.githubusercontent.com/u/20446890?v=4","gravatar_id":"","url":"https://api.github.com/users/anz-bank","html_url":"https://github.com/anz-bank","followers_url":"https://api.github.com/users/anz-bank/followers","following_url":"https://api.github.com/users/anz-bank/following{/other_user}","gists_url":"https://api.github.com/users/anz-bank/gists{/gist_id}","starred_url":"https://api.github.com/users/anz-bank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anz-bank/subscriptions","organizations_url":"https://api.github.com/users/anz-bank/orgs","repos_url":"https://api.github.com/users/anz-bank/repos","events_url":"https://api.github.com/users/anz-bank/events{/privacy}","received_events_url":"https://api.github.com/users/anz-bank/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/anz-bank/sysl","description":"Sysl (pronounced \"sizzle\") is a system specification language","fork":false,"url":"https://api.github.com/repos/anz-bank/sysl","forks_url":"https://api.github.com/repos/anz-bank/sysl/forks","keys_url":"https://api.github.com/repos/anz-bank/sysl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anz-bank/sysl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anz-bank/sysl/teams","hooks_url":"https://api.github.com/repos/anz-bank/sysl/hooks","issue_events_url":"https://api.github.com/repos/anz-bank/sysl/issues/events{/number}","events_url":"https://api.github.com/repos/anz-bank/sysl/events","assignees_url":"https://api.github.com/repos/anz-bank/sysl/assignees{/user}","branches_url":"https://api.github.com/repos/anz-bank/sysl/branches{/branch}","tags_url":"https://api.github.com/repos/anz-bank/sysl/tags","blobs_url":"https://api.github.com/repos/anz-bank/sysl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anz-bank/sysl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anz-bank/sysl/git/refs{/sha}","trees_url":"https://api.github.com/repos/anz-bank/sysl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anz-bank/sysl/statuses/{sha}","languages_url":"https://api.github.com/repos/anz-bank/sysl/languages","stargazers_url":"https://api.github.com/repos/anz-bank/sysl/stargazers","contributors_url":"https://api.github.com/repos/anz-bank/sysl/contributors","subscribers_url":"https://api.github.com/repos/anz-bank/sysl/subscribers","subscription_url":"https://api.github.com/repos/anz-bank/sysl/subscription","commits_url":"https://api.github.com/repos/anz-bank/sysl/commits{/sha}","git_commits_url":"https://api.github.com/repos/anz-bank/sysl/git/commits{/sha}","comments_url":"https://api.github.com/repos/anz-bank/sysl/comments{/number}","issue_comment_url":"https://api.github.com/repos/anz-bank/sysl/issues/comments{/number}","contents_url":"https://api.github.com/repos/anz-bank/sysl/contents/{+path}","compare_url":"https://api.github.com/repos/anz-bank/sysl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anz-bank/sysl/merges","archive_url":"https://api.github.com/repos/anz-bank/sysl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anz-bank/sysl/downloads","issues_url":"https://api.github.com/repos/anz-bank/sysl/issues{/number}","pulls_url":"https://api.github.com/repos/anz-bank/sysl/pulls{/number}","milestones_url":"https://api.github.com/repos/anz-bank/sysl/milestones{/number}","notifications_url":"https://api.github.com/repos/anz-bank/sysl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anz-bank/sysl/labels{/name}","releases_url":"https://api.github.com/repos/anz-bank/sysl/releases{/id}","deployments_url":"https://api.github.com/repos/anz-bank/sysl/deployments","created_at":"2016-07-13T21:22:21Z","updated_at":"2019-10-14T04:15:22Z","pushed_at":"2019-10-17T02:16:17Z","git_url":"git://github.com/anz-bank/sysl.git","ssh_url":"git@github.com:anz-bank/sysl.git","clone_url":"https://github.com/anz-bank/sysl.git","svn_url":"https://github.com/anz-bank/sysl","homepage":"https://sysl.io","size":6388,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":69,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":69,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/anz-bank/sysl/pulls/366"},"html":{"href":"https://github.com/anz-bank/sysl/pull/366"},"issue":{"href":"https://api.github.com/repos/anz-bank/sysl/issues/366"},"comments":{"href":"https://api.github.com/repos/anz-bank/sysl/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/anz-bank/sysl/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/anz-bank/sysl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/anz-bank/sysl/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/anz-bank/sysl/statuses/89f7978367d4c5359b98afff093453a9edc1e51b"}},"author_association":"MEMBER"}}
|
{
"id": 63280456,
"name": "anz-bank/sysl",
"url": "https://api.github.com/repos/anz-bank/sysl"
}
|
{
"id": 42910462,
"login": "golangcibot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42910462?",
"url": "https://api.github.com/users/golangcibot"
}
|
{
"id": 20446890,
"login": "anz-bank",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20446890?",
"url": "https://api.github.com/orgs/anz-bank"
}
| 2019-10-17T02:18:06 |
10648606427
|
{"actor":{"display_login":"golangcibot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/anz-bank/go-course/pulls/comments/315073107","pull_request_review_id":276384515,"id":315073107,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNTA3MzEwNw==","diff_hunk":"@@ -0,0 +1,41 @@\n+package main\n+\n+import (\n+\t\"fmt\"\n+\t\"io\"\n+\t\"os\"\n+)\n+\n+var out io.Writer = os.Stdout\n+\n+//Compare two adjacent numbers","path":"02_bubble/nicholeL/main.go","position":null,"original_position":11,"commit_id":"33f6d26d00d91ab853605886d4e900d50697182c","original_commit_id":"0a3cd371e728a6d8beb41bba68b4126f39f3d111","user":{"login":"NicholeL","id":50978989,"node_id":"MDQ6VXNlcjUwOTc4OTg5","avatar_url":"https://avatars1.githubusercontent.com/u/50978989?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholeL","html_url":"https://github.com/NicholeL","followers_url":"https://api.github.com/users/NicholeL/followers","following_url":"https://api.github.com/users/NicholeL/following{/other_user}","gists_url":"https://api.github.com/users/NicholeL/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholeL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholeL/subscriptions","organizations_url":"https://api.github.com/users/NicholeL/orgs","repos_url":"https://api.github.com/users/NicholeL/repos","events_url":"https://api.github.com/users/NicholeL/events{/privacy}","received_events_url":"https://api.github.com/users/NicholeL/received_events","type":"User","site_admin":false},"body":"will update","created_at":"2019-08-19T07:37:03Z","updated_at":"2019-08-19T07:37:03Z","html_url":"https://github.com/anz-bank/go-course/pull/580#discussion_r315073107","pull_request_url":"https://api.github.com/repos/anz-bank/go-course/pulls/580","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/anz-bank/go-course/pulls/comments/315073107"},"html":{"href":"https://github.com/anz-bank/go-course/pull/580#discussion_r315073107"},"pull_request":{"href":"https://api.github.com/repos/anz-bank/go-course/pulls/580"}},"in_reply_to_id":314591827},"pull_request":{"url":"https://api.github.com/repos/anz-bank/go-course/pulls/580","id":307191719,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3MTkxNzE5","html_url":"https://github.com/anz-bank/go-course/pull/580","diff_url":"https://github.com/anz-bank/go-course/pull/580.diff","patch_url":"https://github.com/anz-bank/go-course/pull/580.patch","issue_url":"https://api.github.com/repos/anz-bank/go-course/issues/580","number":580,"state":"open","locked":false,"title":"Lab 2 -bubble sort & insertion sort","user":{"login":"NicholeL","id":50978989,"node_id":"MDQ6VXNlcjUwOTc4OTg5","avatar_url":"https://avatars1.githubusercontent.com/u/50978989?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholeL","html_url":"https://github.com/NicholeL","followers_url":"https://api.github.com/users/NicholeL/followers","following_url":"https://api.github.com/users/NicholeL/following{/other_user}","gists_url":"https://api.github.com/users/NicholeL/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholeL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholeL/subscriptions","organizations_url":"https://api.github.com/users/NicholeL/orgs","repos_url":"https://api.github.com/users/NicholeL/repos","events_url":"https://api.github.com/users/NicholeL/events{/privacy}","received_events_url":"https://api.github.com/users/NicholeL/received_events","type":"User","site_admin":false},"body":"Fixes #580 \r\n\r\nReview of colleague's PR \r\n\r\nChanges proposed in this PR:\r\nimplement bubble() function\r\nimplement insertion() function\r\nimplement main function to call bubble and insertion with required input\r\ntest main ,insertion and bubble\r\n","created_at":"2019-08-14T06:49:28Z","updated_at":"2019-08-19T07:37:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f2a40a48eb7bc5e53ac96248dd0b5ec59ed4f1e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pentaphobe","id":418523,"node_id":"MDQ6VXNlcjQxODUyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/418523?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaphobe","html_url":"https://github.com/pentaphobe","followers_url":"https://api.github.com/users/pentaphobe/followers","following_url":"https://api.github.com/users/pentaphobe/following{/other_user}","gists_url":"https://api.github.com/users/pentaphobe/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaphobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaphobe/subscriptions","organizations_url":"https://api.github.com/users/pentaphobe/orgs","repos_url":"https://api.github.com/users/pentaphobe/repos","events_url":"https://api.github.com/users/pentaphobe/events{/privacy}","received_events_url":"https://api.github.com/users/pentaphobe/received_events","type":"User","site_admin":false},{"login":"samuong","id":8053866,"node_id":"MDQ6VXNlcjgwNTM4NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/8053866?v=4","gravatar_id":"","url":"https://api.github.com/users/samuong","html_url":"https://github.com/samuong","followers_url":"https://api.github.com/users/samuong/followers","following_url":"https://api.github.com/users/samuong/following{/other_user}","gists_url":"https://api.github.com/users/samuong/gists{/gist_id}","starred_url":"https://api.github.com/users/samuong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuong/subscriptions","organizations_url":"https://api.github.com/users/samuong/orgs","repos_url":"https://api.github.com/users/samuong/repos","events_url":"https://api.github.com/users/samuong/events{/privacy}","received_events_url":"https://api.github.com/users/samuong/received_events","type":"User","site_admin":false},{"login":"rokane","id":11910247,"node_id":"MDQ6VXNlcjExOTEwMjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/11910247?v=4","gravatar_id":"","url":"https://api.github.com/users/rokane","html_url":"https://github.com/rokane","followers_url":"https://api.github.com/users/rokane/followers","following_url":"https://api.github.com/users/rokane/following{/other_user}","gists_url":"https://api.github.com/users/rokane/gists{/gist_id}","starred_url":"https://api.github.com/users/rokane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokane/subscriptions","organizations_url":"https://api.github.com/users/rokane/orgs","repos_url":"https://api.github.com/users/rokane/repos","events_url":"https://api.github.com/users/rokane/events{/privacy}","received_events_url":"https://api.github.com/users/rokane/received_events","type":"User","site_admin":false},{"login":"anzdaddy","id":13160581,"node_id":"MDQ6VXNlcjEzMTYwNTgx","avatar_url":"https://avatars0.githubusercontent.com/u/13160581?v=4","gravatar_id":"","url":"https://api.github.com/users/anzdaddy","html_url":"https://github.com/anzdaddy","followers_url":"https://api.github.com/users/anzdaddy/followers","following_url":"https://api.github.com/users/anzdaddy/following{/other_user}","gists_url":"https://api.github.com/users/anzdaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/anzdaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anzdaddy/subscriptions","organizations_url":"https://api.github.com/users/anzdaddy/orgs","repos_url":"https://api.github.com/users/anzdaddy/repos","events_url":"https://api.github.com/users/anzdaddy/events{/privacy}","received_events_url":"https://api.github.com/users/anzdaddy/received_events","type":"User","site_admin":false},{"login":"linuxmonk","id":16968915,"node_id":"MDQ6VXNlcjE2OTY4OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/16968915?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxmonk","html_url":"https://github.com/linuxmonk","followers_url":"https://api.github.com/users/linuxmonk/followers","following_url":"https://api.github.com/users/linuxmonk/following{/other_user}","gists_url":"https://api.github.com/users/linuxmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxmonk/subscriptions","organizations_url":"https://api.github.com/users/linuxmonk/orgs","repos_url":"https://api.github.com/users/linuxmonk/repos","events_url":"https://api.github.com/users/linuxmonk/events{/privacy}","received_events_url":"https://api.github.com/users/linuxmonk/received_events","type":"User","site_admin":false},{"login":"Joshcarp","id":32605850,"node_id":"MDQ6VXNlcjMyNjA1ODUw","avatar_url":"https://avatars2.githubusercontent.com/u/32605850?v=4","gravatar_id":"","url":"https://api.github.com/users/Joshcarp","html_url":"https://github.com/Joshcarp","followers_url":"https://api.github.com/users/Joshcarp/followers","following_url":"https://api.github.com/users/Joshcarp/following{/other_user}","gists_url":"https://api.github.com/users/Joshcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshcarp/subscriptions","organizations_url":"https://api.github.com/users/Joshcarp/orgs","repos_url":"https://api.github.com/users/Joshcarp/repos","events_url":"https://api.github.com/users/Joshcarp/events{/privacy}","received_events_url":"https://api.github.com/users/Joshcarp/received_events","type":"User","site_admin":false},{"login":"camh-anz","id":35285934,"node_id":"MDQ6VXNlcjM1Mjg1OTM0","avatar_url":"https://avatars2.githubusercontent.com/u/35285934?v=4","gravatar_id":"","url":"https://api.github.com/users/camh-anz","html_url":"https://github.com/camh-anz","followers_url":"https://api.github.com/users/camh-anz/followers","following_url":"https://api.github.com/users/camh-anz/following{/other_user}","gists_url":"https://api.github.com/users/camh-anz/gists{/gist_id}","starred_url":"https://api.github.com/users/camh-anz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camh-anz/subscriptions","organizations_url":"https://api.github.com/users/camh-anz/orgs","repos_url":"https://api.github.com/users/camh-anz/repos","events_url":"https://api.github.com/users/camh-anz/events{/privacy}","received_events_url":"https://api.github.com/users/camh-anz/received_events","type":"User","site_admin":false},{"login":"anzboi","id":43394287,"node_id":"MDQ6VXNlcjQzMzk0Mjg3","avatar_url":"https://avatars0.githubusercontent.com/u/43394287?v=4","gravatar_id":"","url":"https://api.github.com/users/anzboi","html_url":"https://github.com/anzboi","followers_url":"https://api.github.com/users/anzboi/followers","following_url":"https://api.github.com/users/anzboi/following{/other_user}","gists_url":"https://api.github.com/users/anzboi/gists{/gist_id}","starred_url":"https://api.github.com/users/anzboi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anzboi/subscriptions","organizations_url":"https://api.github.com/users/anzboi/orgs","repos_url":"https://api.github.com/users/anzboi/repos","events_url":"https://api.github.com/users/anzboi/events{/privacy}","received_events_url":"https://api.github.com/users/anzboi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1229576812,"node_id":"MDU6TGFiZWwxMjI5NTc2ODEy","url":"https://api.github.com/repos/anz-bank/go-course/labels/Changes%20requested","name":"Changes requested","color":"d86e83","default":false},{"id":1229668223,"node_id":"MDU6TGFiZWwxMjI5NjY4MjIz","url":"https://api.github.com/repos/anz-bank/go-course/labels/lab2","name":"lab2","color":"8bd7e8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/anz-bank/go-course/pulls/580/commits","review_comments_url":"https://api.github.com/repos/anz-bank/go-course/pulls/580/comments","review_comment_url":"https://api.github.com/repos/anz-bank/go-course/pulls/comments{/number}","comments_url":"https://api.github.com/repos/anz-bank/go-course/issues/580/comments","statuses_url":"https://api.github.com/repos/anz-bank/go-course/statuses/33f6d26d00d91ab853605886d4e900d50697182c","head":{"label":"NicholeL:Fab2-bubble","ref":"Fab2-bubble","sha":"33f6d26d00d91ab853605886d4e900d50697182c","user":{"login":"NicholeL","id":50978989,"node_id":"MDQ6VXNlcjUwOTc4OTg5","avatar_url":"https://avatars1.githubusercontent.com/u/50978989?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholeL","html_url":"https://github.com/NicholeL","followers_url":"https://api.github.com/users/NicholeL/followers","following_url":"https://api.github.com/users/NicholeL/following{/other_user}","gists_url":"https://api.github.com/users/NicholeL/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholeL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholeL/subscriptions","organizations_url":"https://api.github.com/users/NicholeL/orgs","repos_url":"https://api.github.com/users/NicholeL/repos","events_url":"https://api.github.com/users/NicholeL/events{/privacy}","received_events_url":"https://api.github.com/users/NicholeL/received_events","type":"User","site_admin":false},"repo":{"id":201211473,"node_id":"MDEwOlJlcG9zaXRvcnkyMDEyMTE0NzM=","name":"go-course","full_name":"NicholeL/go-course","private":false,"owner":{"login":"NicholeL","id":50978989,"node_id":"MDQ6VXNlcjUwOTc4OTg5","avatar_url":"https://avatars1.githubusercontent.com/u/50978989?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholeL","html_url":"https://github.com/NicholeL","followers_url":"https://api.github.com/users/NicholeL/followers","following_url":"https://api.github.com/users/NicholeL/following{/other_user}","gists_url":"https://api.github.com/users/NicholeL/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholeL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholeL/subscriptions","organizations_url":"https://api.github.com/users/NicholeL/orgs","repos_url":"https://api.github.com/users/NicholeL/repos","events_url":"https://api.github.com/users/NicholeL/events{/privacy}","received_events_url":"https://api.github.com/users/NicholeL/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NicholeL/go-course","description":"Go Programming Language Course","fork":true,"url":"https://api.github.com/repos/NicholeL/go-course","forks_url":"https://api.github.com/repos/NicholeL/go-course/forks","keys_url":"https://api.github.com/repos/NicholeL/go-course/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NicholeL/go-course/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NicholeL/go-course/teams","hooks_url":"https://api.github.com/repos/NicholeL/go-course/hooks","issue_events_url":"https://api.github.com/repos/NicholeL/go-course/issues/events{/number}","events_url":"https://api.github.com/repos/NicholeL/go-course/events","assignees_url":"https://api.github.com/repos/NicholeL/go-course/assignees{/user}","branches_url":"https://api.github.com/repos/NicholeL/go-course/branches{/branch}","tags_url":"https://api.github.com/repos/NicholeL/go-course/tags","blobs_url":"https://api.github.com/repos/NicholeL/go-course/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NicholeL/go-course/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NicholeL/go-course/git/refs{/sha}","trees_url":"https://api.github.com/repos/NicholeL/go-course/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NicholeL/go-course/statuses/{sha}","languages_url":"https://api.github.com/repos/NicholeL/go-course/languages","stargazers_url":"https://api.github.com/repos/NicholeL/go-course/stargazers","contributors_url":"https://api.github.com/repos/NicholeL/go-course/contributors","subscribers_url":"https://api.github.com/repos/NicholeL/go-course/subscribers","subscription_url":"https://api.github.com/repos/NicholeL/go-course/subscription","commits_url":"https://api.github.com/repos/NicholeL/go-course/commits{/sha}","git_commits_url":"https://api.github.com/repos/NicholeL/go-course/git/commits{/sha}","comments_url":"https://api.github.com/repos/NicholeL/go-course/comments{/number}","issue_comment_url":"https://api.github.com/repos/NicholeL/go-course/issues/comments{/number}","contents_url":"https://api.github.com/repos/NicholeL/go-course/contents/{+path}","compare_url":"https://api.github.com/repos/NicholeL/go-course/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NicholeL/go-course/merges","archive_url":"https://api.github.com/repos/NicholeL/go-course/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NicholeL/go-course/downloads","issues_url":"https://api.github.com/repos/NicholeL/go-course/issues{/number}","pulls_url":"https://api.github.com/repos/NicholeL/go-course/pulls{/number}","milestones_url":"https://api.github.com/repos/NicholeL/go-course/milestones{/number}","notifications_url":"https://api.github.com/repos/NicholeL/go-course/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NicholeL/go-course/labels{/name}","releases_url":"https://api.github.com/repos/NicholeL/go-course/releases{/id}","deployments_url":"https://api.github.com/repos/NicholeL/go-course/deployments","created_at":"2019-08-08T08:14:43Z","updated_at":"2019-08-19T06:36:44Z","pushed_at":"2019-08-19T07:35:14Z","git_url":"git://github.com/NicholeL/go-course.git","ssh_url":"git@github.com:NicholeL/go-course.git","clone_url":"https://github.com/NicholeL/go-course.git","svn_url":"https://github.com/NicholeL/go-course","homepage":"https://go-course.org/","size":1571,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"anz-bank:master","ref":"master","sha":"1fc43448deacd7db3a3813f6fc1b3c8b1faf01a6","user":{"login":"anz-bank","id":20446890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQ2ODkw","avatar_url":"https://avatars1.githubusercontent.com/u/20446890?v=4","gravatar_id":"","url":"https://api.github.com/users/anz-bank","html_url":"https://github.com/anz-bank","followers_url":"https://api.github.com/users/anz-bank/followers","following_url":"https://api.github.com/users/anz-bank/following{/other_user}","gists_url":"https://api.github.com/users/anz-bank/gists{/gist_id}","starred_url":"https://api.github.com/users/anz-bank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anz-bank/subscriptions","organizations_url":"https://api.github.com/users/anz-bank/orgs","repos_url":"https://api.github.com/users/anz-bank/repos","events_url":"https://api.github.com/users/anz-bank/events{/privacy}","received_events_url":"https://api.github.com/users/anz-bank/received_events","type":"Organization","site_admin":false},"repo":{"id":167305845,"node_id":"MDEwOlJlcG9zaXRvcnkxNjczMDU4NDU=","name":"go-course","full_name":"anz-bank/go-course","private":false,"owner":{"login":"anz-bank","id":20446890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDQ2ODkw","avatar_url":"https://avatars1.githubusercontent.com/u/20446890?v=4","gravatar_id":"","url":"https://api.github.com/users/anz-bank","html_url":"https://github.com/anz-bank","followers_url":"https://api.github.com/users/anz-bank/followers","following_url":"https://api.github.com/users/anz-bank/following{/other_user}","gists_url":"https://api.github.com/users/anz-bank/gists{/gist_id}","starred_url":"https://api.github.com/users/anz-bank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anz-bank/subscriptions","organizations_url":"https://api.github.com/users/anz-bank/orgs","repos_url":"https://api.github.com/users/anz-bank/repos","events_url":"https://api.github.com/users/anz-bank/events{/privacy}","received_events_url":"https://api.github.com/users/anz-bank/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/anz-bank/go-course","description":"Go Programming Language Course","fork":false,"url":"https://api.github.com/repos/anz-bank/go-course","forks_url":"https://api.github.com/repos/anz-bank/go-course/forks","keys_url":"https://api.github.com/repos/anz-bank/go-course/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anz-bank/go-course/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anz-bank/go-course/teams","hooks_url":"https://api.github.com/repos/anz-bank/go-course/hooks","issue_events_url":"https://api.github.com/repos/anz-bank/go-course/issues/events{/number}","events_url":"https://api.github.com/repos/anz-bank/go-course/events","assignees_url":"https://api.github.com/repos/anz-bank/go-course/assignees{/user}","branches_url":"https://api.github.com/repos/anz-bank/go-course/branches{/branch}","tags_url":"https://api.github.com/repos/anz-bank/go-course/tags","blobs_url":"https://api.github.com/repos/anz-bank/go-course/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anz-bank/go-course/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anz-bank/go-course/git/refs{/sha}","trees_url":"https://api.github.com/repos/anz-bank/go-course/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anz-bank/go-course/statuses/{sha}","languages_url":"https://api.github.com/repos/anz-bank/go-course/languages","stargazers_url":"https://api.github.com/repos/anz-bank/go-course/stargazers","contributors_url":"https://api.github.com/repos/anz-bank/go-course/contributors","subscribers_url":"https://api.github.com/repos/anz-bank/go-course/subscribers","subscription_url":"https://api.github.com/repos/anz-bank/go-course/subscription","commits_url":"https://api.github.com/repos/anz-bank/go-course/commits{/sha}","git_commits_url":"https://api.github.com/repos/anz-bank/go-course/git/commits{/sha}","comments_url":"https://api.github.com/repos/anz-bank/go-course/comments{/number}","issue_comment_url":"https://api.github.com/repos/anz-bank/go-course/issues/comments{/number}","contents_url":"https://api.github.com/repos/anz-bank/go-course/contents/{+path}","compare_url":"https://api.github.com/repos/anz-bank/go-course/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anz-bank/go-course/merges","archive_url":"https://api.github.com/repos/anz-bank/go-course/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anz-bank/go-course/downloads","issues_url":"https://api.github.com/repos/anz-bank/go-course/issues{/number}","pulls_url":"https://api.github.com/repos/anz-bank/go-course/pulls{/number}","milestones_url":"https://api.github.com/repos/anz-bank/go-course/milestones{/number}","notifications_url":"https://api.github.com/repos/anz-bank/go-course/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anz-bank/go-course/labels{/name}","releases_url":"https://api.github.com/repos/anz-bank/go-course/releases{/id}","deployments_url":"https://api.github.com/repos/anz-bank/go-course/deployments","created_at":"2019-01-24T04:57:12Z","updated_at":"2019-08-18T23:19:13Z","pushed_at":"2019-08-19T07:35:16Z","git_url":"git://github.com/anz-bank/go-course.git","ssh_url":"git@github.com:anz-bank/go-course.git","clone_url":"https://github.com/anz-bank/go-course.git","svn_url":"https://github.com/anz-bank/go-course","homepage":"https://go-course.org/","size":1631,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":149,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":165,"open_issues":149,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/anz-bank/go-course/pulls/580"},"html":{"href":"https://github.com/anz-bank/go-course/pull/580"},"issue":{"href":"https://api.github.com/repos/anz-bank/go-course/issues/580"},"comments":{"href":"https://api.github.com/repos/anz-bank/go-course/issues/580/comments"},"review_comments":{"href":"https://api.github.com/repos/anz-bank/go-course/pulls/580/comments"},"review_comment":{"href":"https://api.github.com/repos/anz-bank/go-course/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/anz-bank/go-course/pulls/580/commits"},"statuses":{"href":"https://api.github.com/repos/anz-bank/go-course/statuses/33f6d26d00d91ab853605886d4e900d50697182c"}},"author_association":"COLLABORATOR"}}
|
{
"id": 167305845,
"name": "anz-bank/go-course",
"url": "https://api.github.com/repos/anz-bank/go-course"
}
|
{
"id": 50978989,
"login": "NicholeL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50978989?",
"url": "https://api.github.com/users/NicholeL"
}
|
{
"id": 20446890,
"login": "anz-bank",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20446890?",
"url": "https://api.github.com/orgs/anz-bank"
}
| 2019-08-19T07:37:03 |
10234809427
|
{"actor":{"display_login":"NicholeL"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/comments/294138174","pull_request_review_id":250294416,"id":294138174,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDEzODE3NA==","diff_hunk":"@@ -1,11 +1,10 @@\n using System;\n \n-namespace Example\n+namespace Algorithms.Strings\n {\n- public static partial class StringViewModel\n+ public static class StringViewModel\n {\n-\n- public static Tuple<char, int> LongesConsecutiveCharacters(string input)\n+ public static Tuple<char, int> LongestConsecutiveCharacters(string input)","path":"Algorithms/Strings/lcc.cs","position":11,"original_position":11,"commit_id":"74f9b58b608f35a323203a69299eade0ce2ac33a","original_commit_id":"74f9b58b608f35a323203a69299eade0ce2ac33a","user":{"login":"siriak","id":29201949,"node_id":"MDQ6VXNlcjI5MjAxOTQ5","avatar_url":"https://avatars1.githubusercontent.com/u/29201949?v=4","gravatar_id":"","url":"https://api.github.com/users/siriak","html_url":"https://github.com/siriak","followers_url":"https://api.github.com/users/siriak/followers","following_url":"https://api.github.com/users/siriak/following{/other_user}","gists_url":"https://api.github.com/users/siriak/gists{/gist_id}","starred_url":"https://api.github.com/users/siriak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siriak/subscriptions","organizations_url":"https://api.github.com/users/siriak/orgs","repos_url":"https://api.github.com/users/siriak/repos","events_url":"https://api.github.com/users/siriak/events{/privacy}","received_events_url":"https://api.github.com/users/siriak/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n public static Tuple<char, int> FindLongestConsecutiveCharacters(string input)\r\n```","created_at":"2019-06-17T05:16:48Z","updated_at":"2019-06-17T05:18:28Z","html_url":"https://github.com/TheAlgorithms/C-Sharp/pull/66#discussion_r294138174","pull_request_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/66","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/comments/294138174"},"html":{"href":"https://github.com/TheAlgorithms/C-Sharp/pull/66#discussion_r294138174"},"pull_request":{"href":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/66","id":288657944,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NjU3OTQ0","html_url":"https://github.com/TheAlgorithms/C-Sharp/pull/66","diff_url":"https://github.com/TheAlgorithms/C-Sharp/pull/66.diff","patch_url":"https://github.com/TheAlgorithms/C-Sharp/pull/66.patch","issue_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/issues/66","number":66,"state":"open","locked":false,"title":"Tests for lcc","user":{"login":"1fisedi","id":51143882,"node_id":"MDQ6VXNlcjUxMTQzODgy","avatar_url":"https://avatars3.githubusercontent.com/u/51143882?v=4","gravatar_id":"","url":"https://api.github.com/users/1fisedi","html_url":"https://github.com/1fisedi","followers_url":"https://api.github.com/users/1fisedi/followers","following_url":"https://api.github.com/users/1fisedi/following{/other_user}","gists_url":"https://api.github.com/users/1fisedi/gists{/gist_id}","starred_url":"https://api.github.com/users/1fisedi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1fisedi/subscriptions","organizations_url":"https://api.github.com/users/1fisedi/orgs","repos_url":"https://api.github.com/users/1fisedi/repos","events_url":"https://api.github.com/users/1fisedi/events{/privacy}","received_events_url":"https://api.github.com/users/1fisedi/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-16T22:55:28Z","updated_at":"2019-06-17T05:18:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdb543a2b21c27067b4c73e5c929be48a4e6ab2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/66/commits","review_comments_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/66/comments","review_comment_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/issues/66/comments","statuses_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/statuses/74f9b58b608f35a323203a69299eade0ce2ac33a","head":{"label":"1fisedi:master","ref":"master","sha":"74f9b58b608f35a323203a69299eade0ce2ac33a","user":{"login":"1fisedi","id":51143882,"node_id":"MDQ6VXNlcjUxMTQzODgy","avatar_url":"https://avatars3.githubusercontent.com/u/51143882?v=4","gravatar_id":"","url":"https://api.github.com/users/1fisedi","html_url":"https://github.com/1fisedi","followers_url":"https://api.github.com/users/1fisedi/followers","following_url":"https://api.github.com/users/1fisedi/following{/other_user}","gists_url":"https://api.github.com/users/1fisedi/gists{/gist_id}","starred_url":"https://api.github.com/users/1fisedi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1fisedi/subscriptions","organizations_url":"https://api.github.com/users/1fisedi/orgs","repos_url":"https://api.github.com/users/1fisedi/repos","events_url":"https://api.github.com/users/1fisedi/events{/privacy}","received_events_url":"https://api.github.com/users/1fisedi/received_events","type":"User","site_admin":false},"repo":{"id":190942296,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA5NDIyOTY=","name":"C-Sharp","full_name":"1fisedi/C-Sharp","private":false,"owner":{"login":"1fisedi","id":51143882,"node_id":"MDQ6VXNlcjUxMTQzODgy","avatar_url":"https://avatars3.githubusercontent.com/u/51143882?v=4","gravatar_id":"","url":"https://api.github.com/users/1fisedi","html_url":"https://github.com/1fisedi","followers_url":"https://api.github.com/users/1fisedi/followers","following_url":"https://api.github.com/users/1fisedi/following{/other_user}","gists_url":"https://api.github.com/users/1fisedi/gists{/gist_id}","starred_url":"https://api.github.com/users/1fisedi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1fisedi/subscriptions","organizations_url":"https://api.github.com/users/1fisedi/orgs","repos_url":"https://api.github.com/users/1fisedi/repos","events_url":"https://api.github.com/users/1fisedi/events{/privacy}","received_events_url":"https://api.github.com/users/1fisedi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/1fisedi/C-Sharp","description":"All algorithms implemented in C#.","fork":true,"url":"https://api.github.com/repos/1fisedi/C-Sharp","forks_url":"https://api.github.com/repos/1fisedi/C-Sharp/forks","keys_url":"https://api.github.com/repos/1fisedi/C-Sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1fisedi/C-Sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1fisedi/C-Sharp/teams","hooks_url":"https://api.github.com/repos/1fisedi/C-Sharp/hooks","issue_events_url":"https://api.github.com/repos/1fisedi/C-Sharp/issues/events{/number}","events_url":"https://api.github.com/repos/1fisedi/C-Sharp/events","assignees_url":"https://api.github.com/repos/1fisedi/C-Sharp/assignees{/user}","branches_url":"https://api.github.com/repos/1fisedi/C-Sharp/branches{/branch}","tags_url":"https://api.github.com/repos/1fisedi/C-Sharp/tags","blobs_url":"https://api.github.com/repos/1fisedi/C-Sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1fisedi/C-Sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1fisedi/C-Sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/1fisedi/C-Sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1fisedi/C-Sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/1fisedi/C-Sharp/languages","stargazers_url":"https://api.github.com/repos/1fisedi/C-Sharp/stargazers","contributors_url":"https://api.github.com/repos/1fisedi/C-Sharp/contributors","subscribers_url":"https://api.github.com/repos/1fisedi/C-Sharp/subscribers","subscription_url":"https://api.github.com/repos/1fisedi/C-Sharp/subscription","commits_url":"https://api.github.com/repos/1fisedi/C-Sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/1fisedi/C-Sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/1fisedi/C-Sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/1fisedi/C-Sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/1fisedi/C-Sharp/contents/{+path}","compare_url":"https://api.github.com/repos/1fisedi/C-Sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1fisedi/C-Sharp/merges","archive_url":"https://api.github.com/repos/1fisedi/C-Sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1fisedi/C-Sharp/downloads","issues_url":"https://api.github.com/repos/1fisedi/C-Sharp/issues{/number}","pulls_url":"https://api.github.com/repos/1fisedi/C-Sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/1fisedi/C-Sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/1fisedi/C-Sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1fisedi/C-Sharp/labels{/name}","releases_url":"https://api.github.com/repos/1fisedi/C-Sharp/releases{/id}","deployments_url":"https://api.github.com/repos/1fisedi/C-Sharp/deployments","created_at":"2019-06-08T22:47:47Z","updated_at":"2019-06-16T22:43:30Z","pushed_at":"2019-06-16T22:43:28Z","git_url":"git://github.com/1fisedi/C-Sharp.git","ssh_url":"git@github.com:1fisedi/C-Sharp.git","clone_url":"https://github.com/1fisedi/C-Sharp.git","svn_url":"https://github.com/1fisedi/C-Sharp","homepage":null,"size":493,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TheAlgorithms:master","ref":"master","sha":"c0ce45061ed74cb9c1216ab76de403fdf399a6b4","user":{"login":"TheAlgorithms","id":20487725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDg3NzI1","avatar_url":"https://avatars1.githubusercontent.com/u/20487725?v=4","gravatar_id":"","url":"https://api.github.com/users/TheAlgorithms","html_url":"https://github.com/TheAlgorithms","followers_url":"https://api.github.com/users/TheAlgorithms/followers","following_url":"https://api.github.com/users/TheAlgorithms/following{/other_user}","gists_url":"https://api.github.com/users/TheAlgorithms/gists{/gist_id}","starred_url":"https://api.github.com/users/TheAlgorithms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheAlgorithms/subscriptions","organizations_url":"https://api.github.com/users/TheAlgorithms/orgs","repos_url":"https://api.github.com/users/TheAlgorithms/repos","events_url":"https://api.github.com/users/TheAlgorithms/events{/privacy}","received_events_url":"https://api.github.com/users/TheAlgorithms/received_events","type":"Organization","site_admin":false},"repo":{"id":64454952,"node_id":"MDEwOlJlcG9zaXRvcnk2NDQ1NDk1Mg==","name":"C-Sharp","full_name":"TheAlgorithms/C-Sharp","private":false,"owner":{"login":"TheAlgorithms","id":20487725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDg3NzI1","avatar_url":"https://avatars1.githubusercontent.com/u/20487725?v=4","gravatar_id":"","url":"https://api.github.com/users/TheAlgorithms","html_url":"https://github.com/TheAlgorithms","followers_url":"https://api.github.com/users/TheAlgorithms/followers","following_url":"https://api.github.com/users/TheAlgorithms/following{/other_user}","gists_url":"https://api.github.com/users/TheAlgorithms/gists{/gist_id}","starred_url":"https://api.github.com/users/TheAlgorithms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheAlgorithms/subscriptions","organizations_url":"https://api.github.com/users/TheAlgorithms/orgs","repos_url":"https://api.github.com/users/TheAlgorithms/repos","events_url":"https://api.github.com/users/TheAlgorithms/events{/privacy}","received_events_url":"https://api.github.com/users/TheAlgorithms/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TheAlgorithms/C-Sharp","description":"All algorithms implemented in C#.","fork":false,"url":"https://api.github.com/repos/TheAlgorithms/C-Sharp","forks_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/forks","keys_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/teams","hooks_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/hooks","issue_events_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/issues/events{/number}","events_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/events","assignees_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/assignees{/user}","branches_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/branches{/branch}","tags_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/tags","blobs_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/languages","stargazers_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/stargazers","contributors_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/contributors","subscribers_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/subscribers","subscription_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/subscription","commits_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/contents/{+path}","compare_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/merges","archive_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/downloads","issues_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/issues{/number}","pulls_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/labels{/name}","releases_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/releases{/id}","deployments_url":"https://api.github.com/repos/TheAlgorithms/C-Sharp/deployments","created_at":"2016-07-29T06:04:43Z","updated_at":"2019-06-17T00:20:01Z","pushed_at":"2019-06-16T22:55:29Z","git_url":"git://github.com/TheAlgorithms/C-Sharp.git","ssh_url":"git@github.com:TheAlgorithms/C-Sharp.git","clone_url":"https://github.com/TheAlgorithms/C-Sharp.git","svn_url":"https://github.com/TheAlgorithms/C-Sharp","homepage":null,"size":493,"stargazers_count":745,"watchers_count":745,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":214,"open_issues":3,"watchers":745,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/66"},"html":{"href":"https://github.com/TheAlgorithms/C-Sharp/pull/66"},"issue":{"href":"https://api.github.com/repos/TheAlgorithms/C-Sharp/issues/66"},"comments":{"href":"https://api.github.com/repos/TheAlgorithms/C-Sharp/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheAlgorithms/C-Sharp/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/TheAlgorithms/C-Sharp/statuses/74f9b58b608f35a323203a69299eade0ce2ac33a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 64454952,
"name": "TheAlgorithms/C-Sharp",
"url": "https://api.github.com/repos/TheAlgorithms/C-Sharp"
}
|
{
"id": 29201949,
"login": "siriak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29201949?",
"url": "https://api.github.com/users/siriak"
}
|
{
"id": 20487725,
"login": "TheAlgorithms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20487725?",
"url": "https://api.github.com/orgs/TheAlgorithms"
}
| 2019-06-17T05:16:48 |
9832998794
|
{"actor":{"display_login":"siriak"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/IntelPython/sdc/pulls/comments/359258308","pull_request_review_id":333860880,"id":359258308,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTI1ODMwOA==","diff_hunk":"@@ -573,10 +573,10 @@ def _resolve_map_func(self, ary, args, kws):\n def resolve_map(self, ary, args, kws):\n return self._resolve_map_func(ary, args, kws)\n \n- @bound_function(\"series.apply\")\n- def resolve_apply(self, ary, args, kws):\n- # TODO: handle apply differences: extra args, np ufuncs etc.\n- return self._resolve_map_func(ary, args, kws)\n+ # @bound_function(\"series.apply\")\n+ # def resolve_apply(self, ary, args, kws):\n+ # # TODO: handle apply differences: extra args, np ufuncs etc.\n+ # return self._resolve_map_func(ary, args, kws)","path":"sdc/hiframes/pd_series_ext.py","position":11,"original_position":11,"commit_id":"567a09f8936a2c0f094245e87a88e4de94b28b53","original_commit_id":"567a09f8936a2c0f094245e87a88e4de94b28b53","user":{"login":"densmirn","id":53897164,"node_id":"MDQ6VXNlcjUzODk3MTY0","avatar_url":"https://avatars2.githubusercontent.com/u/53897164?v=4","gravatar_id":"","url":"https://api.github.com/users/densmirn","html_url":"https://github.com/densmirn","followers_url":"https://api.github.com/users/densmirn/followers","following_url":"https://api.github.com/users/densmirn/following{/other_user}","gists_url":"https://api.github.com/users/densmirn/gists{/gist_id}","starred_url":"https://api.github.com/users/densmirn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/densmirn/subscriptions","organizations_url":"https://api.github.com/users/densmirn/orgs","repos_url":"https://api.github.com/users/densmirn/repos","events_url":"https://api.github.com/users/densmirn/events{/privacy}","received_events_url":"https://api.github.com/users/densmirn/received_events","type":"User","site_admin":false},"body":"Eventually I think we can leave the lines without changes.","created_at":"2019-12-18T10:12:52Z","updated_at":"2019-12-18T10:12:53Z","html_url":"https://github.com/IntelPython/sdc/pull/422#discussion_r359258308","pull_request_url":"https://api.github.com/repos/IntelPython/sdc/pulls/422","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/IntelPython/sdc/pulls/comments/359258308"},"html":{"href":"https://github.com/IntelPython/sdc/pull/422#discussion_r359258308"},"pull_request":{"href":"https://api.github.com/repos/IntelPython/sdc/pulls/422"}},"in_reply_to_id":359203346},"pull_request":{"url":"https://api.github.com/repos/IntelPython/sdc/pulls/422","id":354049005,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0MDQ5MDA1","html_url":"https://github.com/IntelPython/sdc/pull/422","diff_url":"https://github.com/IntelPython/sdc/pull/422.diff","patch_url":"https://github.com/IntelPython/sdc/pull/422.patch","issue_url":"https://api.github.com/repos/IntelPython/sdc/issues/422","number":422,"state":"open","locked":false,"title":"Implement series.apply()","user":{"login":"PokhodenkoSA","id":1541421,"node_id":"MDQ6VXNlcjE1NDE0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1541421?v=4","gravatar_id":"","url":"https://api.github.com/users/PokhodenkoSA","html_url":"https://github.com/PokhodenkoSA","followers_url":"https://api.github.com/users/PokhodenkoSA/followers","following_url":"https://api.github.com/users/PokhodenkoSA/following{/other_user}","gists_url":"https://api.github.com/users/PokhodenkoSA/gists{/gist_id}","starred_url":"https://api.github.com/users/PokhodenkoSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PokhodenkoSA/subscriptions","organizations_url":"https://api.github.com/users/PokhodenkoSA/orgs","repos_url":"https://api.github.com/users/PokhodenkoSA/repos","events_url":"https://api.github.com/users/PokhodenkoSA/events{/privacy}","received_events_url":"https://api.github.com/users/PokhodenkoSA/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-17T11:13:24Z","updated_at":"2019-12-18T10:12:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"755f51cd11a5d210aab69c8c362d2f34ba2926f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1638008485,"node_id":"MDU6TGFiZWwxNjM4MDA4NDg1","url":"https://api.github.com/repos/IntelPython/sdc/labels/Waiting%20on%20author","name":"Waiting on author","color":"c2ebfc","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/IntelPython/sdc/pulls/422/commits","review_comments_url":"https://api.github.com/repos/IntelPython/sdc/pulls/422/comments","review_comment_url":"https://api.github.com/repos/IntelPython/sdc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IntelPython/sdc/issues/422/comments","statuses_url":"https://api.github.com/repos/IntelPython/sdc/statuses/567a09f8936a2c0f094245e87a88e4de94b28b53","head":{"label":"PokhodenkoSA:series-apply","ref":"series-apply","sha":"567a09f8936a2c0f094245e87a88e4de94b28b53","user":{"login":"PokhodenkoSA","id":1541421,"node_id":"MDQ6VXNlcjE1NDE0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1541421?v=4","gravatar_id":"","url":"https://api.github.com/users/PokhodenkoSA","html_url":"https://github.com/PokhodenkoSA","followers_url":"https://api.github.com/users/PokhodenkoSA/followers","following_url":"https://api.github.com/users/PokhodenkoSA/following{/other_user}","gists_url":"https://api.github.com/users/PokhodenkoSA/gists{/gist_id}","starred_url":"https://api.github.com/users/PokhodenkoSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PokhodenkoSA/subscriptions","organizations_url":"https://api.github.com/users/PokhodenkoSA/orgs","repos_url":"https://api.github.com/users/PokhodenkoSA/repos","events_url":"https://api.github.com/users/PokhodenkoSA/events{/privacy}","received_events_url":"https://api.github.com/users/PokhodenkoSA/received_events","type":"User","site_admin":false},"repo":{"id":212749531,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI3NDk1MzE=","name":"sdc","full_name":"PokhodenkoSA/sdc","private":false,"owner":{"login":"PokhodenkoSA","id":1541421,"node_id":"MDQ6VXNlcjE1NDE0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1541421?v=4","gravatar_id":"","url":"https://api.github.com/users/PokhodenkoSA","html_url":"https://github.com/PokhodenkoSA","followers_url":"https://api.github.com/users/PokhodenkoSA/followers","following_url":"https://api.github.com/users/PokhodenkoSA/following{/other_user}","gists_url":"https://api.github.com/users/PokhodenkoSA/gists{/gist_id}","starred_url":"https://api.github.com/users/PokhodenkoSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PokhodenkoSA/subscriptions","organizations_url":"https://api.github.com/users/PokhodenkoSA/orgs","repos_url":"https://api.github.com/users/PokhodenkoSA/repos","events_url":"https://api.github.com/users/PokhodenkoSA/events{/privacy}","received_events_url":"https://api.github.com/users/PokhodenkoSA/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PokhodenkoSA/sdc","description":"A compiler-based big data framework in Python","fork":true,"url":"https://api.github.com/repos/PokhodenkoSA/sdc","forks_url":"https://api.github.com/repos/PokhodenkoSA/sdc/forks","keys_url":"https://api.github.com/repos/PokhodenkoSA/sdc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PokhodenkoSA/sdc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PokhodenkoSA/sdc/teams","hooks_url":"https://api.github.com/repos/PokhodenkoSA/sdc/hooks","issue_events_url":"https://api.github.com/repos/PokhodenkoSA/sdc/issues/events{/number}","events_url":"https://api.github.com/repos/PokhodenkoSA/sdc/events","assignees_url":"https://api.github.com/repos/PokhodenkoSA/sdc/assignees{/user}","branches_url":"https://api.github.com/repos/PokhodenkoSA/sdc/branches{/branch}","tags_url":"https://api.github.com/repos/PokhodenkoSA/sdc/tags","blobs_url":"https://api.github.com/repos/PokhodenkoSA/sdc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PokhodenkoSA/sdc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PokhodenkoSA/sdc/git/refs{/sha}","trees_url":"https://api.github.com/repos/PokhodenkoSA/sdc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PokhodenkoSA/sdc/statuses/{sha}","languages_url":"https://api.github.com/repos/PokhodenkoSA/sdc/languages","stargazers_url":"https://api.github.com/repos/PokhodenkoSA/sdc/stargazers","contributors_url":"https://api.github.com/repos/PokhodenkoSA/sdc/contributors","subscribers_url":"https://api.github.com/repos/PokhodenkoSA/sdc/subscribers","subscription_url":"https://api.github.com/repos/PokhodenkoSA/sdc/subscription","commits_url":"https://api.github.com/repos/PokhodenkoSA/sdc/commits{/sha}","git_commits_url":"https://api.github.com/repos/PokhodenkoSA/sdc/git/commits{/sha}","comments_url":"https://api.github.com/repos/PokhodenkoSA/sdc/comments{/number}","issue_comment_url":"https://api.github.com/repos/PokhodenkoSA/sdc/issues/comments{/number}","contents_url":"https://api.github.com/repos/PokhodenkoSA/sdc/contents/{+path}","compare_url":"https://api.github.com/repos/PokhodenkoSA/sdc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PokhodenkoSA/sdc/merges","archive_url":"https://api.github.com/repos/PokhodenkoSA/sdc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PokhodenkoSA/sdc/downloads","issues_url":"https://api.github.com/repos/PokhodenkoSA/sdc/issues{/number}","pulls_url":"https://api.github.com/repos/PokhodenkoSA/sdc/pulls{/number}","milestones_url":"https://api.github.com/repos/PokhodenkoSA/sdc/milestones{/number}","notifications_url":"https://api.github.com/repos/PokhodenkoSA/sdc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PokhodenkoSA/sdc/labels{/name}","releases_url":"https://api.github.com/repos/PokhodenkoSA/sdc/releases{/id}","deployments_url":"https://api.github.com/repos/PokhodenkoSA/sdc/deployments","created_at":"2019-10-04T06:26:07Z","updated_at":"2019-12-16T07:35:09Z","pushed_at":"2019-12-17T11:27:22Z","git_url":"git://github.com/PokhodenkoSA/sdc.git","ssh_url":"git@github.com:PokhodenkoSA/sdc.git","clone_url":"https://github.com/PokhodenkoSA/sdc.git","svn_url":"https://github.com/PokhodenkoSA/sdc","homepage":"https://intellabs.github.io/hpat-doc/","size":14992,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IntelPython:master","ref":"master","sha":"ade53e69c12d845d5563ef21a9482a87708a45d2","user":{"login":"IntelPython","id":20491374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDkxMzc0","avatar_url":"https://avatars1.githubusercontent.com/u/20491374?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelPython","html_url":"https://github.com/IntelPython","followers_url":"https://api.github.com/users/IntelPython/followers","following_url":"https://api.github.com/users/IntelPython/following{/other_user}","gists_url":"https://api.github.com/users/IntelPython/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelPython/subscriptions","organizations_url":"https://api.github.com/users/IntelPython/orgs","repos_url":"https://api.github.com/users/IntelPython/repos","events_url":"https://api.github.com/users/IntelPython/events{/privacy}","received_events_url":"https://api.github.com/users/IntelPython/received_events","type":"Organization","site_admin":false},"repo":{"id":93080202,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA4MDIwMg==","name":"sdc","full_name":"IntelPython/sdc","private":false,"owner":{"login":"IntelPython","id":20491374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDkxMzc0","avatar_url":"https://avatars1.githubusercontent.com/u/20491374?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelPython","html_url":"https://github.com/IntelPython","followers_url":"https://api.github.com/users/IntelPython/followers","following_url":"https://api.github.com/users/IntelPython/following{/other_user}","gists_url":"https://api.github.com/users/IntelPython/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelPython/subscriptions","organizations_url":"https://api.github.com/users/IntelPython/orgs","repos_url":"https://api.github.com/users/IntelPython/repos","events_url":"https://api.github.com/users/IntelPython/events{/privacy}","received_events_url":"https://api.github.com/users/IntelPython/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IntelPython/sdc","description":"Intel® Scalable Dataframe Compiler for Pandas*","fork":false,"url":"https://api.github.com/repos/IntelPython/sdc","forks_url":"https://api.github.com/repos/IntelPython/sdc/forks","keys_url":"https://api.github.com/repos/IntelPython/sdc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntelPython/sdc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntelPython/sdc/teams","hooks_url":"https://api.github.com/repos/IntelPython/sdc/hooks","issue_events_url":"https://api.github.com/repos/IntelPython/sdc/issues/events{/number}","events_url":"https://api.github.com/repos/IntelPython/sdc/events","assignees_url":"https://api.github.com/repos/IntelPython/sdc/assignees{/user}","branches_url":"https://api.github.com/repos/IntelPython/sdc/branches{/branch}","tags_url":"https://api.github.com/repos/IntelPython/sdc/tags","blobs_url":"https://api.github.com/repos/IntelPython/sdc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntelPython/sdc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntelPython/sdc/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntelPython/sdc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntelPython/sdc/statuses/{sha}","languages_url":"https://api.github.com/repos/IntelPython/sdc/languages","stargazers_url":"https://api.github.com/repos/IntelPython/sdc/stargazers","contributors_url":"https://api.github.com/repos/IntelPython/sdc/contributors","subscribers_url":"https://api.github.com/repos/IntelPython/sdc/subscribers","subscription_url":"https://api.github.com/repos/IntelPython/sdc/subscription","commits_url":"https://api.github.com/repos/IntelPython/sdc/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntelPython/sdc/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntelPython/sdc/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntelPython/sdc/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntelPython/sdc/contents/{+path}","compare_url":"https://api.github.com/repos/IntelPython/sdc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntelPython/sdc/merges","archive_url":"https://api.github.com/repos/IntelPython/sdc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntelPython/sdc/downloads","issues_url":"https://api.github.com/repos/IntelPython/sdc/issues{/number}","pulls_url":"https://api.github.com/repos/IntelPython/sdc/pulls{/number}","milestones_url":"https://api.github.com/repos/IntelPython/sdc/milestones{/number}","notifications_url":"https://api.github.com/repos/IntelPython/sdc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntelPython/sdc/labels{/name}","releases_url":"https://api.github.com/repos/IntelPython/sdc/releases{/id}","deployments_url":"https://api.github.com/repos/IntelPython/sdc/deployments","created_at":"2017-06-01T16:59:41Z","updated_at":"2019-12-17T09:44:20Z","pushed_at":"2019-12-18T07:16:57Z","git_url":"git://github.com/IntelPython/sdc.git","ssh_url":"git@github.com:IntelPython/sdc.git","clone_url":"https://github.com/IntelPython/sdc.git","svn_url":"https://github.com/IntelPython/sdc","homepage":"https://intellabs.github.io/hpat-doc/","size":13182,"stargazers_count":563,"watchers_count":563,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":58,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":55,"open_issues":58,"watchers":563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IntelPython/sdc/pulls/422"},"html":{"href":"https://github.com/IntelPython/sdc/pull/422"},"issue":{"href":"https://api.github.com/repos/IntelPython/sdc/issues/422"},"comments":{"href":"https://api.github.com/repos/IntelPython/sdc/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/IntelPython/sdc/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/IntelPython/sdc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IntelPython/sdc/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/IntelPython/sdc/statuses/567a09f8936a2c0f094245e87a88e4de94b28b53"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 93080202,
"name": "IntelPython/sdc",
"url": "https://api.github.com/repos/IntelPython/sdc"
}
|
{
"id": 53897164,
"login": "densmirn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53897164?",
"url": "https://api.github.com/users/densmirn"
}
|
{
"id": 20491374,
"login": "IntelPython",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20491374?",
"url": "https://api.github.com/orgs/IntelPython"
}
| 2019-12-18T10:12:52 |
11115180602
|
{"actor":{"display_login":"densmirn"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/fastai/fastai_dev/pulls/comments/324676819","pull_request_review_id":288630409,"id":324676819,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDY3NjgxOQ==","diff_hunk":"@@ -535,13 +535,25 @@\n \"cell_type\": \"markdown\",","path":"dev/02_data_transforms.ipynb","position":1,"original_position":1,"commit_id":"bbf4361b92f05453690ba7ff46339b15b3b109c8","original_commit_id":"bbf4361b92f05453690ba7ff46339b15b3b109c8","user":{"login":"sgugger","id":35901082,"node_id":"MDQ6VXNlcjM1OTAxMDgy","avatar_url":"https://avatars3.githubusercontent.com/u/35901082?v=4","gravatar_id":"","url":"https://api.github.com/users/sgugger","html_url":"https://github.com/sgugger","followers_url":"https://api.github.com/users/sgugger/followers","following_url":"https://api.github.com/users/sgugger/following{/other_user}","gists_url":"https://api.github.com/users/sgugger/gists{/gist_id}","starred_url":"https://api.github.com/users/sgugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgugger/subscriptions","organizations_url":"https://api.github.com/users/sgugger/orgs","repos_url":"https://api.github.com/users/sgugger/repos","events_url":"https://api.github.com/users/sgugger/events{/privacy}","received_events_url":"https://api.github.com/users/sgugger/received_events","type":"User","site_admin":false},"body":"<p>In \"handling of tuples\", there is a typo to transform. You should also say you have to set <code>as_item=True</code> to opt out of this behavior and expand a little bit more about <code>as_item_force</code> saying that setting this flag will always override <code>as_item</code> (for transforms that can only be applied at a tuple level such as <code>PointScaler</code>).</p><p> </p><p>In \"Reversability\", your example is wrong: a <code>TensorImage</code> is something we can show and the transform that converts an image to a tensor is not reversed. A better example would be a category converted to the corresponding index that you need to reverse for showing purposes.</p><p> </p><p>In \"Filtering based on the dataset type\", you should say used only on a specific <code>DataSource</code> subset (the datasource has a training and validation set).</p><p> </p><p>In \"appending a new behavior...\" I think you should point out that it's for new types of objects with an annotation.</p><p> </p>\n<br/>\n\n _Reply via <a href='https://app.reviewnb.com/fastai/fastai_dev/pull/202/discussion/'>ReviewNB</a>_ <div id='ReviewNBCommentContext-DoNotDelete' style='display:none' data-state='OPEN' data-cellIndex='35'/>","created_at":"2019-09-16T13:33:06Z","updated_at":"2019-09-16T13:33:06Z","html_url":"https://github.com/fastai/fastai_dev/pull/202#discussion_r324676819","pull_request_url":"https://api.github.com/repos/fastai/fastai_dev/pulls/202","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fastai/fastai_dev/pulls/comments/324676819"},"html":{"href":"https://github.com/fastai/fastai_dev/pull/202#discussion_r324676819"},"pull_request":{"href":"https://api.github.com/repos/fastai/fastai_dev/pulls/202"}}},"pull_request":{"url":"https://api.github.com/repos/fastai/fastai_dev/pulls/202","id":317650396,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NjUwMzk2","html_url":"https://github.com/fastai/fastai_dev/pull/202","diff_url":"https://github.com/fastai/fastai_dev/pull/202.diff","patch_url":"https://github.com/fastai/fastai_dev/pull/202.patch","issue_url":"https://api.github.com/repos/fastai/fastai_dev/issues/202","number":202,"state":"open","locked":false,"title":"Transform refactor docs","user":{"login":"slawekslex","id":12817106,"node_id":"MDQ6VXNlcjEyODE3MTA2","avatar_url":"https://avatars0.githubusercontent.com/u/12817106?v=4","gravatar_id":"","url":"https://api.github.com/users/slawekslex","html_url":"https://github.com/slawekslex","followers_url":"https://api.github.com/users/slawekslex/followers","following_url":"https://api.github.com/users/slawekslex/following{/other_user}","gists_url":"https://api.github.com/users/slawekslex/gists{/gist_id}","starred_url":"https://api.github.com/users/slawekslex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slawekslex/subscriptions","organizations_url":"https://api.github.com/users/slawekslex/orgs","repos_url":"https://api.github.com/users/slawekslex/repos","events_url":"https://api.github.com/users/slawekslex/events{/privacy}","received_events_url":"https://api.github.com/users/slawekslex/received_events","type":"User","site_admin":false},"body":"Reading code in notebooks is great to understand how things work but not always why things exist and why they are done the way they are. Jeremy has explained the rationale behind Transform well in his walk-thrus and I'm trying to distill it into the notebook.\n\nThe main idea here is to use the text to explain what we want from Transform and leave the details on how to use it in the code examples.","created_at":"2019-09-15T16:04:58Z","updated_at":"2019-09-16T13:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af147c4abd40180aa5b55b7a2ba562ec594afd62","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastai/fastai_dev/pulls/202/commits","review_comments_url":"https://api.github.com/repos/fastai/fastai_dev/pulls/202/comments","review_comment_url":"https://api.github.com/repos/fastai/fastai_dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastai/fastai_dev/issues/202/comments","statuses_url":"https://api.github.com/repos/fastai/fastai_dev/statuses/bbf4361b92f05453690ba7ff46339b15b3b109c8","head":{"label":"slawekslex:transform_docs","ref":"transform_docs","sha":"bbf4361b92f05453690ba7ff46339b15b3b109c8","user":{"login":"slawekslex","id":12817106,"node_id":"MDQ6VXNlcjEyODE3MTA2","avatar_url":"https://avatars0.githubusercontent.com/u/12817106?v=4","gravatar_id":"","url":"https://api.github.com/users/slawekslex","html_url":"https://github.com/slawekslex","followers_url":"https://api.github.com/users/slawekslex/followers","following_url":"https://api.github.com/users/slawekslex/following{/other_user}","gists_url":"https://api.github.com/users/slawekslex/gists{/gist_id}","starred_url":"https://api.github.com/users/slawekslex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slawekslex/subscriptions","organizations_url":"https://api.github.com/users/slawekslex/orgs","repos_url":"https://api.github.com/users/slawekslex/repos","events_url":"https://api.github.com/users/slawekslex/events{/privacy}","received_events_url":"https://api.github.com/users/slawekslex/received_events","type":"User","site_admin":false},"repo":{"id":207591455,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc1OTE0NTU=","name":"fastai_dev","full_name":"slawekslex/fastai_dev","private":false,"owner":{"login":"slawekslex","id":12817106,"node_id":"MDQ6VXNlcjEyODE3MTA2","avatar_url":"https://avatars0.githubusercontent.com/u/12817106?v=4","gravatar_id":"","url":"https://api.github.com/users/slawekslex","html_url":"https://github.com/slawekslex","followers_url":"https://api.github.com/users/slawekslex/followers","following_url":"https://api.github.com/users/slawekslex/following{/other_user}","gists_url":"https://api.github.com/users/slawekslex/gists{/gist_id}","starred_url":"https://api.github.com/users/slawekslex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slawekslex/subscriptions","organizations_url":"https://api.github.com/users/slawekslex/orgs","repos_url":"https://api.github.com/users/slawekslex/repos","events_url":"https://api.github.com/users/slawekslex/events{/privacy}","received_events_url":"https://api.github.com/users/slawekslex/received_events","type":"User","site_admin":false},"html_url":"https://github.com/slawekslex/fastai_dev","description":"development of the next version of fastai","fork":true,"url":"https://api.github.com/repos/slawekslex/fastai_dev","forks_url":"https://api.github.com/repos/slawekslex/fastai_dev/forks","keys_url":"https://api.github.com/repos/slawekslex/fastai_dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slawekslex/fastai_dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slawekslex/fastai_dev/teams","hooks_url":"https://api.github.com/repos/slawekslex/fastai_dev/hooks","issue_events_url":"https://api.github.com/repos/slawekslex/fastai_dev/issues/events{/number}","events_url":"https://api.github.com/repos/slawekslex/fastai_dev/events","assignees_url":"https://api.github.com/repos/slawekslex/fastai_dev/assignees{/user}","branches_url":"https://api.github.com/repos/slawekslex/fastai_dev/branches{/branch}","tags_url":"https://api.github.com/repos/slawekslex/fastai_dev/tags","blobs_url":"https://api.github.com/repos/slawekslex/fastai_dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slawekslex/fastai_dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slawekslex/fastai_dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/slawekslex/fastai_dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slawekslex/fastai_dev/statuses/{sha}","languages_url":"https://api.github.com/repos/slawekslex/fastai_dev/languages","stargazers_url":"https://api.github.com/repos/slawekslex/fastai_dev/stargazers","contributors_url":"https://api.github.com/repos/slawekslex/fastai_dev/contributors","subscribers_url":"https://api.github.com/repos/slawekslex/fastai_dev/subscribers","subscription_url":"https://api.github.com/repos/slawekslex/fastai_dev/subscription","commits_url":"https://api.github.com/repos/slawekslex/fastai_dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/slawekslex/fastai_dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/slawekslex/fastai_dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/slawekslex/fastai_dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/slawekslex/fastai_dev/contents/{+path}","compare_url":"https://api.github.com/repos/slawekslex/fastai_dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slawekslex/fastai_dev/merges","archive_url":"https://api.github.com/repos/slawekslex/fastai_dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slawekslex/fastai_dev/downloads","issues_url":"https://api.github.com/repos/slawekslex/fastai_dev/issues{/number}","pulls_url":"https://api.github.com/repos/slawekslex/fastai_dev/pulls{/number}","milestones_url":"https://api.github.com/repos/slawekslex/fastai_dev/milestones{/number}","notifications_url":"https://api.github.com/repos/slawekslex/fastai_dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slawekslex/fastai_dev/labels{/name}","releases_url":"https://api.github.com/repos/slawekslex/fastai_dev/releases{/id}","deployments_url":"https://api.github.com/repos/slawekslex/fastai_dev/deployments","created_at":"2019-09-10T15:09:05Z","updated_at":"2019-09-10T15:09:07Z","pushed_at":"2019-09-15T16:04:12Z","git_url":"git://github.com/slawekslex/fastai_dev.git","ssh_url":"git@github.com:slawekslex/fastai_dev.git","clone_url":"https://github.com/slawekslex/fastai_dev.git","svn_url":"https://github.com/slawekslex/fastai_dev","homepage":"https://docs.fast.ai","size":499704,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastai:master","ref":"master","sha":"364ab1dfa98f1d6ae0418a81d51df5e60d45e3c6","user":{"login":"fastai","id":20547620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTQ3NjIw","avatar_url":"https://avatars3.githubusercontent.com/u/20547620?v=4","gravatar_id":"","url":"https://api.github.com/users/fastai","html_url":"https://github.com/fastai","followers_url":"https://api.github.com/users/fastai/followers","following_url":"https://api.github.com/users/fastai/following{/other_user}","gists_url":"https://api.github.com/users/fastai/gists{/gist_id}","starred_url":"https://api.github.com/users/fastai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastai/subscriptions","organizations_url":"https://api.github.com/users/fastai/orgs","repos_url":"https://api.github.com/users/fastai/repos","events_url":"https://api.github.com/users/fastai/events{/privacy}","received_events_url":"https://api.github.com/users/fastai/received_events","type":"Organization","site_admin":false},"repo":{"id":150974871,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA5NzQ4NzE=","name":"fastai_dev","full_name":"fastai/fastai_dev","private":false,"owner":{"login":"fastai","id":20547620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTQ3NjIw","avatar_url":"https://avatars3.githubusercontent.com/u/20547620?v=4","gravatar_id":"","url":"https://api.github.com/users/fastai","html_url":"https://github.com/fastai","followers_url":"https://api.github.com/users/fastai/followers","following_url":"https://api.github.com/users/fastai/following{/other_user}","gists_url":"https://api.github.com/users/fastai/gists{/gist_id}","starred_url":"https://api.github.com/users/fastai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastai/subscriptions","organizations_url":"https://api.github.com/users/fastai/orgs","repos_url":"https://api.github.com/users/fastai/repos","events_url":"https://api.github.com/users/fastai/events{/privacy}","received_events_url":"https://api.github.com/users/fastai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fastai/fastai_dev","description":"development of the next version of fastai","fork":false,"url":"https://api.github.com/repos/fastai/fastai_dev","forks_url":"https://api.github.com/repos/fastai/fastai_dev/forks","keys_url":"https://api.github.com/repos/fastai/fastai_dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastai/fastai_dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastai/fastai_dev/teams","hooks_url":"https://api.github.com/repos/fastai/fastai_dev/hooks","issue_events_url":"https://api.github.com/repos/fastai/fastai_dev/issues/events{/number}","events_url":"https://api.github.com/repos/fastai/fastai_dev/events","assignees_url":"https://api.github.com/repos/fastai/fastai_dev/assignees{/user}","branches_url":"https://api.github.com/repos/fastai/fastai_dev/branches{/branch}","tags_url":"https://api.github.com/repos/fastai/fastai_dev/tags","blobs_url":"https://api.github.com/repos/fastai/fastai_dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastai/fastai_dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastai/fastai_dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastai/fastai_dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastai/fastai_dev/statuses/{sha}","languages_url":"https://api.github.com/repos/fastai/fastai_dev/languages","stargazers_url":"https://api.github.com/repos/fastai/fastai_dev/stargazers","contributors_url":"https://api.github.com/repos/fastai/fastai_dev/contributors","subscribers_url":"https://api.github.com/repos/fastai/fastai_dev/subscribers","subscription_url":"https://api.github.com/repos/fastai/fastai_dev/subscription","commits_url":"https://api.github.com/repos/fastai/fastai_dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastai/fastai_dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastai/fastai_dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastai/fastai_dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastai/fastai_dev/contents/{+path}","compare_url":"https://api.github.com/repos/fastai/fastai_dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastai/fastai_dev/merges","archive_url":"https://api.github.com/repos/fastai/fastai_dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastai/fastai_dev/downloads","issues_url":"https://api.github.com/repos/fastai/fastai_dev/issues{/number}","pulls_url":"https://api.github.com/repos/fastai/fastai_dev/pulls{/number}","milestones_url":"https://api.github.com/repos/fastai/fastai_dev/milestones{/number}","notifications_url":"https://api.github.com/repos/fastai/fastai_dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastai/fastai_dev/labels{/name}","releases_url":"https://api.github.com/repos/fastai/fastai_dev/releases{/id}","deployments_url":"https://api.github.com/repos/fastai/fastai_dev/deployments","created_at":"2018-09-30T14:34:48Z","updated_at":"2019-09-14T13:50:53Z","pushed_at":"2019-09-15T16:04:59Z","git_url":"git://github.com/fastai/fastai_dev.git","ssh_url":"git@github.com:fastai/fastai_dev.git","clone_url":"https://github.com/fastai/fastai_dev.git","svn_url":"https://github.com/fastai/fastai_dev","homepage":"https://docs.fast.ai","size":499725,"stargazers_count":374,"watchers_count":374,"language":"Jupyter Notebook","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":235,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":235,"open_issues":7,"watchers":374,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastai/fastai_dev/pulls/202"},"html":{"href":"https://github.com/fastai/fastai_dev/pull/202"},"issue":{"href":"https://api.github.com/repos/fastai/fastai_dev/issues/202"},"comments":{"href":"https://api.github.com/repos/fastai/fastai_dev/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/fastai/fastai_dev/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/fastai/fastai_dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastai/fastai_dev/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/fastai/fastai_dev/statuses/bbf4361b92f05453690ba7ff46339b15b3b109c8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 150974871,
"name": "fastai/fastai_dev",
"url": "https://api.github.com/repos/fastai/fastai_dev"
}
|
{
"id": 35901082,
"login": "sgugger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35901082?",
"url": "https://api.github.com/users/sgugger"
}
|
{
"id": 20547620,
"login": "fastai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20547620?",
"url": "https://api.github.com/orgs/fastai"
}
| 2019-09-16T13:33:06 |
10424390553
|
{"actor":{"display_login":"sgugger"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/comments/359613745","pull_request_review_id":334253340,"id":359613745,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTYxMzc0NQ==","diff_hunk":"@@ -13,334 +12,32 @@\n import zipfile\n import pandas as pd\n import pprint\n+import ast\n \n-import classify_CT\n+import dicom_processor\n+import common_utils","path":"run.py","position":16,"original_position":16,"commit_id":"d6ab81222e120087ab3a73cad138d7e09708c8c1","original_commit_id":"d6ab81222e120087ab3a73cad138d7e09708c8c1","user":{"login":"NPann","id":6107897,"node_id":"MDQ6VXNlcjYxMDc4OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6107897?v=4","gravatar_id":"","url":"https://api.github.com/users/NPann","html_url":"https://github.com/NPann","followers_url":"https://api.github.com/users/NPann/followers","following_url":"https://api.github.com/users/NPann/following{/other_user}","gists_url":"https://api.github.com/users/NPann/gists{/gist_id}","starred_url":"https://api.github.com/users/NPann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NPann/subscriptions","organizations_url":"https://api.github.com/users/NPann/orgs","repos_url":"https://api.github.com/users/NPann/repos","events_url":"https://api.github.com/users/NPann/events{/privacy}","received_events_url":"https://api.github.com/users/NPann/received_events","type":"User","site_admin":false},"body":"import can be cleanup\r\n```\r\nimport os\r\nimport json\r\nimport sys\r\nimport logging\r\nimport flywheel\r\nimport pprint\r\nimport dicom_processor\r\nimport CT_classifier\r\nimport MR_classifier\r\n```","created_at":"2019-12-18T23:06:25Z","updated_at":"2019-12-18T23:16:26Z","html_url":"https://github.com/flywheel-apps/GRP-3B/pull/8#discussion_r359613745","pull_request_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/comments/359613745"},"html":{"href":"https://github.com/flywheel-apps/GRP-3B/pull/8#discussion_r359613745"},"pull_request":{"href":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/8","id":353915917,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzOTE1OTE3","html_url":"https://github.com/flywheel-apps/GRP-3B/pull/8","diff_url":"https://github.com/flywheel-apps/GRP-3B/pull/8.diff","patch_url":"https://github.com/flywheel-apps/GRP-3B/pull/8.patch","issue_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/issues/8","number":8,"state":"open","locked":false,"title":"Modifications to CT classification and gear refactoring","user":{"login":"bhalchandranoopur","id":58004080,"node_id":"MDQ6VXNlcjU4MDA0MDgw","avatar_url":"https://avatars2.githubusercontent.com/u/58004080?v=4","gravatar_id":"","url":"https://api.github.com/users/bhalchandranoopur","html_url":"https://github.com/bhalchandranoopur","followers_url":"https://api.github.com/users/bhalchandranoopur/followers","following_url":"https://api.github.com/users/bhalchandranoopur/following{/other_user}","gists_url":"https://api.github.com/users/bhalchandranoopur/gists{/gist_id}","starred_url":"https://api.github.com/users/bhalchandranoopur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhalchandranoopur/subscriptions","organizations_url":"https://api.github.com/users/bhalchandranoopur/orgs","repos_url":"https://api.github.com/users/bhalchandranoopur/repos","events_url":"https://api.github.com/users/bhalchandranoopur/events{/privacy}","received_events_url":"https://api.github.com/users/bhalchandranoopur/received_events","type":"User","site_admin":false},"body":"- Modifications to CT classification \r\n Reconstruction window check\r\n\r\n- Gear refactoring","created_at":"2019-12-17T05:12:59Z","updated_at":"2019-12-18T23:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"784cdc062ace03a0bac25f0121e6ac6baf07394e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/8/commits","review_comments_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/8/comments","review_comment_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/issues/8/comments","statuses_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/statuses/d6ab81222e120087ab3a73cad138d7e09708c8c1","head":{"label":"bhalchandranoopur:gear-refactored","ref":"gear-refactored","sha":"d6ab81222e120087ab3a73cad138d7e09708c8c1","user":{"login":"bhalchandranoopur","id":58004080,"node_id":"MDQ6VXNlcjU4MDA0MDgw","avatar_url":"https://avatars2.githubusercontent.com/u/58004080?v=4","gravatar_id":"","url":"https://api.github.com/users/bhalchandranoopur","html_url":"https://github.com/bhalchandranoopur","followers_url":"https://api.github.com/users/bhalchandranoopur/followers","following_url":"https://api.github.com/users/bhalchandranoopur/following{/other_user}","gists_url":"https://api.github.com/users/bhalchandranoopur/gists{/gist_id}","starred_url":"https://api.github.com/users/bhalchandranoopur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhalchandranoopur/subscriptions","organizations_url":"https://api.github.com/users/bhalchandranoopur/orgs","repos_url":"https://api.github.com/users/bhalchandranoopur/repos","events_url":"https://api.github.com/users/bhalchandranoopur/events{/privacy}","received_events_url":"https://api.github.com/users/bhalchandranoopur/received_events","type":"User","site_admin":false},"repo":{"id":222993275,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI5OTMyNzU=","name":"GRP-3B","full_name":"bhalchandranoopur/GRP-3B","private":false,"owner":{"login":"bhalchandranoopur","id":58004080,"node_id":"MDQ6VXNlcjU4MDA0MDgw","avatar_url":"https://avatars2.githubusercontent.com/u/58004080?v=4","gravatar_id":"","url":"https://api.github.com/users/bhalchandranoopur","html_url":"https://github.com/bhalchandranoopur","followers_url":"https://api.github.com/users/bhalchandranoopur/followers","following_url":"https://api.github.com/users/bhalchandranoopur/following{/other_user}","gists_url":"https://api.github.com/users/bhalchandranoopur/gists{/gist_id}","starred_url":"https://api.github.com/users/bhalchandranoopur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhalchandranoopur/subscriptions","organizations_url":"https://api.github.com/users/bhalchandranoopur/orgs","repos_url":"https://api.github.com/users/bhalchandranoopur/repos","events_url":"https://api.github.com/users/bhalchandranoopur/events{/privacy}","received_events_url":"https://api.github.com/users/bhalchandranoopur/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bhalchandranoopur/GRP-3B","description":"This gear is intended to classify data after the assignment of modality (by GRP-3)","fork":true,"url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B","forks_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/forks","keys_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/teams","hooks_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/hooks","issue_events_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/issues/events{/number}","events_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/events","assignees_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/assignees{/user}","branches_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/branches{/branch}","tags_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/tags","blobs_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/statuses/{sha}","languages_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/languages","stargazers_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/stargazers","contributors_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/contributors","subscribers_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/subscribers","subscription_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/subscription","commits_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/contents/{+path}","compare_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/merges","archive_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/downloads","issues_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/issues{/number}","pulls_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/pulls{/number}","milestones_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/milestones{/number}","notifications_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/labels{/name}","releases_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/releases{/id}","deployments_url":"https://api.github.com/repos/bhalchandranoopur/GRP-3B/deployments","created_at":"2019-11-20T17:38:23Z","updated_at":"2019-11-20T17:38:25Z","pushed_at":"2019-12-18T22:57:22Z","git_url":"git://github.com/bhalchandranoopur/GRP-3B.git","ssh_url":"git@github.com:bhalchandranoopur/GRP-3B.git","clone_url":"https://github.com/bhalchandranoopur/GRP-3B.git","svn_url":"https://github.com/bhalchandranoopur/GRP-3B","homepage":null,"size":44,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flywheel-apps:master","ref":"master","sha":"69daeb634a3f8b8802aa716f2f64f0bcb7ac12d8","user":{"login":"flywheel-apps","id":20566067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTY2MDY3","avatar_url":"https://avatars3.githubusercontent.com/u/20566067?v=4","gravatar_id":"","url":"https://api.github.com/users/flywheel-apps","html_url":"https://github.com/flywheel-apps","followers_url":"https://api.github.com/users/flywheel-apps/followers","following_url":"https://api.github.com/users/flywheel-apps/following{/other_user}","gists_url":"https://api.github.com/users/flywheel-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/flywheel-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flywheel-apps/subscriptions","organizations_url":"https://api.github.com/users/flywheel-apps/orgs","repos_url":"https://api.github.com/users/flywheel-apps/repos","events_url":"https://api.github.com/users/flywheel-apps/events{/privacy}","received_events_url":"https://api.github.com/users/flywheel-apps/received_events","type":"Organization","site_admin":false},"repo":{"id":188469887,"node_id":"MDEwOlJlcG9zaXRvcnkxODg0Njk4ODc=","name":"GRP-3B","full_name":"flywheel-apps/GRP-3B","private":false,"owner":{"login":"flywheel-apps","id":20566067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTY2MDY3","avatar_url":"https://avatars3.githubusercontent.com/u/20566067?v=4","gravatar_id":"","url":"https://api.github.com/users/flywheel-apps","html_url":"https://github.com/flywheel-apps","followers_url":"https://api.github.com/users/flywheel-apps/followers","following_url":"https://api.github.com/users/flywheel-apps/following{/other_user}","gists_url":"https://api.github.com/users/flywheel-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/flywheel-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flywheel-apps/subscriptions","organizations_url":"https://api.github.com/users/flywheel-apps/orgs","repos_url":"https://api.github.com/users/flywheel-apps/repos","events_url":"https://api.github.com/users/flywheel-apps/events{/privacy}","received_events_url":"https://api.github.com/users/flywheel-apps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flywheel-apps/GRP-3B","description":"This gear is intended to classify data after the assignment of modality (by GRP-3)","fork":false,"url":"https://api.github.com/repos/flywheel-apps/GRP-3B","forks_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/forks","keys_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/teams","hooks_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/hooks","issue_events_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/issues/events{/number}","events_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/events","assignees_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/assignees{/user}","branches_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/branches{/branch}","tags_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/tags","blobs_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/git/refs{/sha}","trees_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/statuses/{sha}","languages_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/languages","stargazers_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/stargazers","contributors_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/contributors","subscribers_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/subscribers","subscription_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/subscription","commits_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/commits{/sha}","git_commits_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/git/commits{/sha}","comments_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/comments{/number}","issue_comment_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/issues/comments{/number}","contents_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/contents/{+path}","compare_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/merges","archive_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/downloads","issues_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/issues{/number}","pulls_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls{/number}","milestones_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/milestones{/number}","notifications_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/labels{/name}","releases_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/releases{/id}","deployments_url":"https://api.github.com/repos/flywheel-apps/GRP-3B/deployments","created_at":"2019-05-24T18:29:52Z","updated_at":"2019-08-13T15:53:35Z","pushed_at":"2019-12-18T22:57:24Z","git_url":"git://github.com/flywheel-apps/GRP-3B.git","ssh_url":"git@github.com:flywheel-apps/GRP-3B.git","clone_url":"https://github.com/flywheel-apps/GRP-3B.git","svn_url":"https://github.com/flywheel-apps/GRP-3B","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/8"},"html":{"href":"https://github.com/flywheel-apps/GRP-3B/pull/8"},"issue":{"href":"https://api.github.com/repos/flywheel-apps/GRP-3B/issues/8"},"comments":{"href":"https://api.github.com/repos/flywheel-apps/GRP-3B/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flywheel-apps/GRP-3B/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/flywheel-apps/GRP-3B/statuses/d6ab81222e120087ab3a73cad138d7e09708c8c1"}},"author_association":"NONE"}}
|
{
"id": 188469887,
"name": "flywheel-apps/GRP-3B",
"url": "https://api.github.com/repos/flywheel-apps/GRP-3B"
}
|
{
"id": 6107897,
"login": "NPann",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6107897?",
"url": "https://api.github.com/users/NPann"
}
|
{
"id": 20566067,
"login": "flywheel-apps",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20566067?",
"url": "https://api.github.com/orgs/flywheel-apps"
}
| 2019-12-18T23:06:25 |
11121206526
|
{"actor":{"display_login":"NPann"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pygame/pygame/pulls/comments/255300435","pull_request_review_id":201864789,"id":255300435,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTMwMDQzNQ==","diff_hunk":"@@ -45,8 +45,31 @@ Starting from pygame 1.9.5 masks with width or height 0 are supported.\n \n .. class:: Mask\n \n- | :sl:`pygame object for representing 2d bitmasks`\n- | :sg:`Mask((width, height)) -> Mask`\n+ | :sl:`pygame object for representing 2D bitmasks`\n+ | :sg:`Mask(size=(width, height)[, fill=False]) -> Mask`\n+\n+ A ``Mask`` object is used to represent a 2D bitmask. Each bit in\n+ the mask represents a pixel. 1 is used to indicate a set bit and 0 is used\n+ to indicate an unset bit. Set bits in a mask can be used to detect\n+ collisions with other masks and their set bits.\n+\n+ A filled mask has all of its bits set to 1, conversely an unfilled/cleared\n+ mask has all of its bits set to 0. Masks can be created unfilled (default)\n+ or filled by using the ``fill`` parameter. Masks can also be cleared or\n+ filled using the :func:`pygame.mask.Mask.clear()` and\n+ :func:`pygame.mask.Mask.fill()` methods respectively. Individual bits can\n+ be accessed using the :func:`pygame.mask.Mask.get_at()` and\n+ :func:`pygame.mask.Mask.set_at()` methods.\n+\n+ :param list|tuple size: sequence of 2 ints indicating the width","path":"docs/reST/ref/mask.rst","position":22,"original_position":22,"commit_id":"fa2abd2b76fce9fe8c31d5f338279b04b5230bf2","original_commit_id":"fa2abd2b76fce9fe8c31d5f338279b04b5230bf2","user":{"login":"dlon","id":2653485,"node_id":"MDQ6VXNlcjI2NTM0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2653485?v=4","gravatar_id":"","url":"https://api.github.com/users/dlon","html_url":"https://github.com/dlon","followers_url":"https://api.github.com/users/dlon/followers","following_url":"https://api.github.com/users/dlon/following{/other_user}","gists_url":"https://api.github.com/users/dlon/gists{/gist_id}","starred_url":"https://api.github.com/users/dlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlon/subscriptions","organizations_url":"https://api.github.com/users/dlon/orgs","repos_url":"https://api.github.com/users/dlon/repos","events_url":"https://api.github.com/users/dlon/events{/privacy}","received_events_url":"https://api.github.com/users/dlon/received_events","type":"User","site_admin":false},"body":"I think the correct syntax is `:param list or tuple size:`, according to http://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html","created_at":"2019-02-09T14:32:03Z","updated_at":"2019-02-09T14:33:01Z","html_url":"https://github.com/pygame/pygame/pull/806#discussion_r255300435","pull_request_url":"https://api.github.com/repos/pygame/pygame/pulls/806","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pygame/pygame/pulls/comments/255300435"},"html":{"href":"https://github.com/pygame/pygame/pull/806#discussion_r255300435"},"pull_request":{"href":"https://api.github.com/repos/pygame/pygame/pulls/806"}}},"pull_request":{"url":"https://api.github.com/repos/pygame/pygame/pulls/806","id":251618654,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNjE4NjU0","html_url":"https://github.com/pygame/pygame/pull/806","diff_url":"https://github.com/pygame/pygame/pull/806.diff","patch_url":"https://github.com/pygame/pygame/pull/806.patch","issue_url":"https://api.github.com/repos/pygame/pygame/issues/806","number":806,"state":"open","locked":false,"title":"Add fill kwarg to the Mask constructor","user":{"login":"charlesej","id":4837704,"node_id":"MDQ6VXNlcjQ4Mzc3MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4837704?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesej","html_url":"https://github.com/charlesej","followers_url":"https://api.github.com/users/charlesej/followers","following_url":"https://api.github.com/users/charlesej/following{/other_user}","gists_url":"https://api.github.com/users/charlesej/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesej/subscriptions","organizations_url":"https://api.github.com/users/charlesej/orgs","repos_url":"https://api.github.com/users/charlesej/repos","events_url":"https://api.github.com/users/charlesej/events{/privacy}","received_events_url":"https://api.github.com/users/charlesej/received_events","type":"User","site_admin":false},"body":"This update adds a `fill` keyword parameter to the `Mask` constructor.\r\n\r\nOverview of changes:\r\n* Added the `fill` keyword parameter to the `Mask` constructor. The default value is `False` to maintain backward compatibility.\r\n* Changed the `Mask` constructor to raise a `PyExc_MemoryError` if `bitmask_create()` fails to return a valid mask object.\r\n* Updated the `pygame.mask` documentation.\r\n* Added test methods to test `Mask` constructor parameters.\r\n\r\nSystem details:\r\n* os: windows 10 (64bit)\r\n* python: 3.7.2 (64bit) and 2.7.10 (64bit)\r\n* pygame: 1.9.5.dev0 (SDL: 1.2.15) at 5de404e926f4b7563b90839fe4e91cda46dba4b3\r\n\r\nResolves the \"Add an argument to the `Mask()` constructor...\" item of #800.","created_at":"2019-02-08T22:32:00Z","updated_at":"2019-02-09T14:33:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09d8a19d7acded93d8815ca8b89c86eba18e4b29","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pygame/pygame/pulls/806/commits","review_comments_url":"https://api.github.com/repos/pygame/pygame/pulls/806/comments","review_comment_url":"https://api.github.com/repos/pygame/pygame/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pygame/pygame/issues/806/comments","statuses_url":"https://api.github.com/repos/pygame/pygame/statuses/fa2abd2b76fce9fe8c31d5f338279b04b5230bf2","head":{"label":"charlesej:add-mask-fill-kwarg","ref":"add-mask-fill-kwarg","sha":"fa2abd2b76fce9fe8c31d5f338279b04b5230bf2","user":{"login":"charlesej","id":4837704,"node_id":"MDQ6VXNlcjQ4Mzc3MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4837704?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesej","html_url":"https://github.com/charlesej","followers_url":"https://api.github.com/users/charlesej/followers","following_url":"https://api.github.com/users/charlesej/following{/other_user}","gists_url":"https://api.github.com/users/charlesej/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesej/subscriptions","organizations_url":"https://api.github.com/users/charlesej/orgs","repos_url":"https://api.github.com/users/charlesej/repos","events_url":"https://api.github.com/users/charlesej/events{/privacy}","received_events_url":"https://api.github.com/users/charlesej/received_events","type":"User","site_admin":false},"repo":{"id":165430418,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU0MzA0MTg=","name":"pygame","full_name":"charlesej/pygame","private":false,"owner":{"login":"charlesej","id":4837704,"node_id":"MDQ6VXNlcjQ4Mzc3MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4837704?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesej","html_url":"https://github.com/charlesej","followers_url":"https://api.github.com/users/charlesej/followers","following_url":"https://api.github.com/users/charlesej/following{/other_user}","gists_url":"https://api.github.com/users/charlesej/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesej/subscriptions","organizations_url":"https://api.github.com/users/charlesej/orgs","repos_url":"https://api.github.com/users/charlesej/repos","events_url":"https://api.github.com/users/charlesej/events{/privacy}","received_events_url":"https://api.github.com/users/charlesej/received_events","type":"User","site_admin":false},"html_url":"https://github.com/charlesej/pygame","description":"pygame (the library) is a Free and Open Source python programming language library for making multimedia applications like games built on top of the excellent SDL library. C, Python, Native, OpenGL.","fork":true,"url":"https://api.github.com/repos/charlesej/pygame","forks_url":"https://api.github.com/repos/charlesej/pygame/forks","keys_url":"https://api.github.com/repos/charlesej/pygame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charlesej/pygame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charlesej/pygame/teams","hooks_url":"https://api.github.com/repos/charlesej/pygame/hooks","issue_events_url":"https://api.github.com/repos/charlesej/pygame/issues/events{/number}","events_url":"https://api.github.com/repos/charlesej/pygame/events","assignees_url":"https://api.github.com/repos/charlesej/pygame/assignees{/user}","branches_url":"https://api.github.com/repos/charlesej/pygame/branches{/branch}","tags_url":"https://api.github.com/repos/charlesej/pygame/tags","blobs_url":"https://api.github.com/repos/charlesej/pygame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charlesej/pygame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charlesej/pygame/git/refs{/sha}","trees_url":"https://api.github.com/repos/charlesej/pygame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charlesej/pygame/statuses/{sha}","languages_url":"https://api.github.com/repos/charlesej/pygame/languages","stargazers_url":"https://api.github.com/repos/charlesej/pygame/stargazers","contributors_url":"https://api.github.com/repos/charlesej/pygame/contributors","subscribers_url":"https://api.github.com/repos/charlesej/pygame/subscribers","subscription_url":"https://api.github.com/repos/charlesej/pygame/subscription","commits_url":"https://api.github.com/repos/charlesej/pygame/commits{/sha}","git_commits_url":"https://api.github.com/repos/charlesej/pygame/git/commits{/sha}","comments_url":"https://api.github.com/repos/charlesej/pygame/comments{/number}","issue_comment_url":"https://api.github.com/repos/charlesej/pygame/issues/comments{/number}","contents_url":"https://api.github.com/repos/charlesej/pygame/contents/{+path}","compare_url":"https://api.github.com/repos/charlesej/pygame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charlesej/pygame/merges","archive_url":"https://api.github.com/repos/charlesej/pygame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charlesej/pygame/downloads","issues_url":"https://api.github.com/repos/charlesej/pygame/issues{/number}","pulls_url":"https://api.github.com/repos/charlesej/pygame/pulls{/number}","milestones_url":"https://api.github.com/repos/charlesej/pygame/milestones{/number}","notifications_url":"https://api.github.com/repos/charlesej/pygame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charlesej/pygame/labels{/name}","releases_url":"https://api.github.com/repos/charlesej/pygame/releases{/id}","deployments_url":"https://api.github.com/repos/charlesej/pygame/deployments","created_at":"2019-01-12T20:01:37Z","updated_at":"2019-02-08T18:11:58Z","pushed_at":"2019-02-09T01:22:27Z","git_url":"git://github.com/charlesej/pygame.git","ssh_url":"git@github.com:charlesej/pygame.git","clone_url":"https://github.com/charlesej/pygame.git","svn_url":"https://github.com/charlesej/pygame","homepage":"https://www.pygame.org","size":10667,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pygame:master","ref":"master","sha":"5de404e926f4b7563b90839fe4e91cda46dba4b3","user":{"login":"pygame","id":20628127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjI4MTI3","avatar_url":"https://avatars0.githubusercontent.com/u/20628127?v=4","gravatar_id":"","url":"https://api.github.com/users/pygame","html_url":"https://github.com/pygame","followers_url":"https://api.github.com/users/pygame/followers","following_url":"https://api.github.com/users/pygame/following{/other_user}","gists_url":"https://api.github.com/users/pygame/gists{/gist_id}","starred_url":"https://api.github.com/users/pygame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pygame/subscriptions","organizations_url":"https://api.github.com/users/pygame/orgs","repos_url":"https://api.github.com/users/pygame/repos","events_url":"https://api.github.com/users/pygame/events{/privacy}","received_events_url":"https://api.github.com/users/pygame/received_events","type":"Organization","site_admin":false},"repo":{"id":86245815,"node_id":"MDEwOlJlcG9zaXRvcnk4NjI0NTgxNQ==","name":"pygame","full_name":"pygame/pygame","private":false,"owner":{"login":"pygame","id":20628127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjI4MTI3","avatar_url":"https://avatars0.githubusercontent.com/u/20628127?v=4","gravatar_id":"","url":"https://api.github.com/users/pygame","html_url":"https://github.com/pygame","followers_url":"https://api.github.com/users/pygame/followers","following_url":"https://api.github.com/users/pygame/following{/other_user}","gists_url":"https://api.github.com/users/pygame/gists{/gist_id}","starred_url":"https://api.github.com/users/pygame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pygame/subscriptions","organizations_url":"https://api.github.com/users/pygame/orgs","repos_url":"https://api.github.com/users/pygame/repos","events_url":"https://api.github.com/users/pygame/events{/privacy}","received_events_url":"https://api.github.com/users/pygame/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pygame/pygame","description":"pygame (the library) is a Free and Open Source python programming language library for making multimedia applications like games built on top of the excellent SDL library. C, Python, Native, OpenGL.","fork":false,"url":"https://api.github.com/repos/pygame/pygame","forks_url":"https://api.github.com/repos/pygame/pygame/forks","keys_url":"https://api.github.com/repos/pygame/pygame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pygame/pygame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pygame/pygame/teams","hooks_url":"https://api.github.com/repos/pygame/pygame/hooks","issue_events_url":"https://api.github.com/repos/pygame/pygame/issues/events{/number}","events_url":"https://api.github.com/repos/pygame/pygame/events","assignees_url":"https://api.github.com/repos/pygame/pygame/assignees{/user}","branches_url":"https://api.github.com/repos/pygame/pygame/branches{/branch}","tags_url":"https://api.github.com/repos/pygame/pygame/tags","blobs_url":"https://api.github.com/repos/pygame/pygame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pygame/pygame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pygame/pygame/git/refs{/sha}","trees_url":"https://api.github.com/repos/pygame/pygame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pygame/pygame/statuses/{sha}","languages_url":"https://api.github.com/repos/pygame/pygame/languages","stargazers_url":"https://api.github.com/repos/pygame/pygame/stargazers","contributors_url":"https://api.github.com/repos/pygame/pygame/contributors","subscribers_url":"https://api.github.com/repos/pygame/pygame/subscribers","subscription_url":"https://api.github.com/repos/pygame/pygame/subscription","commits_url":"https://api.github.com/repos/pygame/pygame/commits{/sha}","git_commits_url":"https://api.github.com/repos/pygame/pygame/git/commits{/sha}","comments_url":"https://api.github.com/repos/pygame/pygame/comments{/number}","issue_comment_url":"https://api.github.com/repos/pygame/pygame/issues/comments{/number}","contents_url":"https://api.github.com/repos/pygame/pygame/contents/{+path}","compare_url":"https://api.github.com/repos/pygame/pygame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pygame/pygame/merges","archive_url":"https://api.github.com/repos/pygame/pygame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pygame/pygame/downloads","issues_url":"https://api.github.com/repos/pygame/pygame/issues{/number}","pulls_url":"https://api.github.com/repos/pygame/pygame/pulls{/number}","milestones_url":"https://api.github.com/repos/pygame/pygame/milestones{/number}","notifications_url":"https://api.github.com/repos/pygame/pygame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pygame/pygame/labels{/name}","releases_url":"https://api.github.com/repos/pygame/pygame/releases{/id}","deployments_url":"https://api.github.com/repos/pygame/pygame/deployments","created_at":"2017-03-26T16:06:59Z","updated_at":"2019-02-09T13:48:18Z","pushed_at":"2019-02-09T13:45:56Z","git_url":"git://github.com/pygame/pygame.git","ssh_url":"git@github.com:pygame/pygame.git","clone_url":"https://github.com/pygame/pygame.git","svn_url":"https://github.com/pygame/pygame","homepage":"https://www.pygame.org","size":13013,"stargazers_count":939,"watchers_count":939,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":248,"mirror_url":null,"archived":false,"open_issues_count":178,"license":null,"forks":248,"open_issues":178,"watchers":939,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pygame/pygame/pulls/806"},"html":{"href":"https://github.com/pygame/pygame/pull/806"},"issue":{"href":"https://api.github.com/repos/pygame/pygame/issues/806"},"comments":{"href":"https://api.github.com/repos/pygame/pygame/issues/806/comments"},"review_comments":{"href":"https://api.github.com/repos/pygame/pygame/pulls/806/comments"},"review_comment":{"href":"https://api.github.com/repos/pygame/pygame/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pygame/pygame/pulls/806/commits"},"statuses":{"href":"https://api.github.com/repos/pygame/pygame/statuses/fa2abd2b76fce9fe8c31d5f338279b04b5230bf2"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 86245815,
"name": "pygame/pygame",
"url": "https://api.github.com/repos/pygame/pygame"
}
|
{
"id": 2653485,
"login": "dlon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2653485?",
"url": "https://api.github.com/users/dlon"
}
|
{
"id": 20628127,
"login": "pygame",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20628127?",
"url": "https://api.github.com/orgs/pygame"
}
| 2019-02-09T14:32:03 |
9037819824
|
{"actor":{"display_login":"dlon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/comments/341018838","pull_request_review_id":309723910,"id":341018838,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTAxODgzOA==","diff_hunk":"@@ -42,14 +42,15 @@ where\n clamped\n }\n \n-pub trait PointCulling<S>: objekt::Clone + Debug + Sync + Send\n+pub trait PointCulling<S>: Debug + Sync + Send\n where\n S: BaseFloat + Sync + Send,\n {\n fn contains(&self, point: &Point3<S>) -> bool;\n // TODO(catevita): return Relation\n fn intersects_aabb3(&self, aabb: &Aabb3<S>) -> bool;\n fn transformed(&self, global_from_query: &Isometry3<S>) -> Box<dyn PointCulling<S>>;\n+ fn corners(&self) -> [Point3<S>; 8];","path":"src/math.rs","position":22,"original_position":22,"commit_id":"78e5789a16e7682884826c02f7c641fd1c783483","original_commit_id":"78e5789a16e7682884826c02f7c641fd1c783483","user":{"login":"nnmm","id":1933253,"node_id":"MDQ6VXNlcjE5MzMyNTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1933253?v=4","gravatar_id":"","url":"https://api.github.com/users/nnmm","html_url":"https://github.com/nnmm","followers_url":"https://api.github.com/users/nnmm/followers","following_url":"https://api.github.com/users/nnmm/following{/other_user}","gists_url":"https://api.github.com/users/nnmm/gists{/gist_id}","starred_url":"https://api.github.com/users/nnmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnmm/subscriptions","organizations_url":"https://api.github.com/users/nnmm/orgs","repos_url":"https://api.github.com/users/nnmm/repos","events_url":"https://api.github.com/users/nnmm/events{/privacy}","received_events_url":"https://api.github.com/users/nnmm/received_events","type":"User","site_admin":false},"body":"Wouldn't this be a little limiting in the future to have this in the trait?","created_at":"2019-10-31T08:57:40Z","updated_at":"2019-10-31T08:57:40Z","html_url":"https://github.com/googlecartographer/point_cloud_viewer/pull/381#discussion_r341018838","pull_request_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/381","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/comments/341018838"},"html":{"href":"https://github.com/googlecartographer/point_cloud_viewer/pull/381#discussion_r341018838"},"pull_request":{"href":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/381"}}},"pull_request":{"url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/381","id":334234132,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0MjM0MTMy","html_url":"https://github.com/googlecartographer/point_cloud_viewer/pull/381","diff_url":"https://github.com/googlecartographer/point_cloud_viewer/pull/381.diff","patch_url":"https://github.com/googlecartographer/point_cloud_viewer/pull/381.patch","issue_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues/381","number":381,"state":"open","locked":false,"title":"Fix oriented beam query.","user":{"login":"feuerste","id":362372,"node_id":"MDQ6VXNlcjM2MjM3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/362372?v=4","gravatar_id":"","url":"https://api.github.com/users/feuerste","html_url":"https://github.com/feuerste","followers_url":"https://api.github.com/users/feuerste/followers","following_url":"https://api.github.com/users/feuerste/following{/other_user}","gists_url":"https://api.github.com/users/feuerste/gists{/gist_id}","starred_url":"https://api.github.com/users/feuerste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feuerste/subscriptions","organizations_url":"https://api.github.com/users/feuerste/orgs","repos_url":"https://api.github.com/users/feuerste/repos","events_url":"https://api.github.com/users/feuerste/events{/privacy}","received_events_url":"https://api.github.com/users/feuerste/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-30T12:58:27Z","updated_at":"2019-10-31T08:57:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8f81567845beb9e9d72a06387ea1035a3f275fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":793842091,"node_id":"MDU6TGFiZWw3OTM4NDIwOTE=","url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/381/commits","review_comments_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/381/comments","review_comment_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues/381/comments","statuses_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/statuses/78e5789a16e7682884826c02f7c641fd1c783483","head":{"label":"googlecartographer:feuerste/fix_beam_query","ref":"feuerste/fix_beam_query","sha":"78e5789a16e7682884826c02f7c641fd1c783483","user":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"repo":{"id":75620240,"node_id":"MDEwOlJlcG9zaXRvcnk3NTYyMDI0MA==","name":"point_cloud_viewer","full_name":"googlecartographer/point_cloud_viewer","private":false,"owner":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googlecartographer/point_cloud_viewer","description":"View billions of points in your browser.","fork":false,"url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer","forks_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/forks","keys_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/teams","hooks_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/hooks","issue_events_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues/events{/number}","events_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/events","assignees_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/assignees{/user}","branches_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/branches{/branch}","tags_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/tags","blobs_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/languages","stargazers_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/stargazers","contributors_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/contributors","subscribers_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/subscribers","subscription_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/subscription","commits_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/contents/{+path}","compare_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/merges","archive_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/downloads","issues_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues{/number}","pulls_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/labels{/name}","releases_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/releases{/id}","deployments_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/deployments","created_at":"2016-12-05T11:54:40Z","updated_at":"2019-10-29T19:52:45Z","pushed_at":"2019-10-31T08:51:44Z","git_url":"git://github.com/googlecartographer/point_cloud_viewer.git","ssh_url":"git@github.com:googlecartographer/point_cloud_viewer.git","clone_url":"https://github.com/googlecartographer/point_cloud_viewer.git","svn_url":"https://github.com/googlecartographer/point_cloud_viewer","homepage":"","size":1731,"stargazers_count":183,"watchers_count":183,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":16,"watchers":183,"default_branch":"master"}},"base":{"label":"googlecartographer:master","ref":"master","sha":"d5afc2ae2c077343562e979500677b61754c5318","user":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"repo":{"id":75620240,"node_id":"MDEwOlJlcG9zaXRvcnk3NTYyMDI0MA==","name":"point_cloud_viewer","full_name":"googlecartographer/point_cloud_viewer","private":false,"owner":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googlecartographer/point_cloud_viewer","description":"View billions of points in your browser.","fork":false,"url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer","forks_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/forks","keys_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/teams","hooks_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/hooks","issue_events_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues/events{/number}","events_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/events","assignees_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/assignees{/user}","branches_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/branches{/branch}","tags_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/tags","blobs_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/languages","stargazers_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/stargazers","contributors_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/contributors","subscribers_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/subscribers","subscription_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/subscription","commits_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/contents/{+path}","compare_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/merges","archive_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/downloads","issues_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues{/number}","pulls_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/labels{/name}","releases_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/releases{/id}","deployments_url":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/deployments","created_at":"2016-12-05T11:54:40Z","updated_at":"2019-10-29T19:52:45Z","pushed_at":"2019-10-31T08:51:44Z","git_url":"git://github.com/googlecartographer/point_cloud_viewer.git","ssh_url":"git@github.com:googlecartographer/point_cloud_viewer.git","clone_url":"https://github.com/googlecartographer/point_cloud_viewer.git","svn_url":"https://github.com/googlecartographer/point_cloud_viewer","homepage":"","size":1731,"stargazers_count":183,"watchers_count":183,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":16,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/381"},"html":{"href":"https://github.com/googlecartographer/point_cloud_viewer/pull/381"},"issue":{"href":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues/381"},"comments":{"href":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/issues/381/comments"},"review_comments":{"href":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/381/comments"},"review_comment":{"href":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/pulls/381/commits"},"statuses":{"href":"https://api.github.com/repos/googlecartographer/point_cloud_viewer/statuses/78e5789a16e7682884826c02f7c641fd1c783483"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 75620240,
"name": "googlecartographer/point_cloud_viewer",
"url": "https://api.github.com/repos/googlecartographer/point_cloud_viewer"
}
|
{
"id": 1933253,
"login": "nnmm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1933253?",
"url": "https://api.github.com/users/nnmm"
}
|
{
"id": 20636162,
"login": "googlecartographer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20636162?",
"url": "https://api.github.com/orgs/googlecartographer"
}
| 2019-10-31T08:57:40 |
10755353078
|
{"actor":{"display_login":"nnmm"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/comments/348605686","pull_request_review_id":320105987,"id":348605686,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODYwNTY4Ng==","diff_hunk":"@@ -5797,11 +5797,11 @@ static const unsigned int obj_objs[NUM_OBJ] = {\n 1204, /* OBJ_picnicl1fs 1 3 6 1 4 1 311 89 2 1 1 */\n 1205, /* OBJ_p256_picnicl1fs 1 3 6 1 4 1 311 89 2 1 2 */\n 1206, /* OBJ_rsa3072_picnicl1fs 1 3 6 1 4 1 311 89 2 1 3 */\n- 1207, /* OBJ_qteslapi 1 3 6 1 4 1 311 89 2 2 1 */\n- 1208, /* OBJ_p256_qteslapi 1 3 6 1 4 1 311 89 2 2 2 */\n- 1209, /* OBJ_rsa3072_qteslapi 1 3 6 1 4 1 311 89 2 2 3 */\n- 1210, /* OBJ_qteslapiii 1 3 6 1 4 1 311 89 2 2 4 */\n- 1211, /* OBJ_p384_qteslapiii 1 3 6 1 4 1 311 89 2 2 5 */\n+ 1207, /* OBJ_qteslapi 1 3 6 1 4 1 311 89 2 2 10 */","path":"crypto/objects/obj_dat.h","position":26,"original_position":26,"commit_id":"02acb7f50ed7f31c1eb19db2ed5202418286a2ca","original_commit_id":"02acb7f50ed7f31c1eb19db2ed5202418286a2ca","user":{"login":"baentsch","id":57787676,"node_id":"MDQ6VXNlcjU3Nzg3Njc2","avatar_url":"https://avatars1.githubusercontent.com/u/57787676?v=4","gravatar_id":"","url":"https://api.github.com/users/baentsch","html_url":"https://github.com/baentsch","followers_url":"https://api.github.com/users/baentsch/followers","following_url":"https://api.github.com/users/baentsch/following{/other_user}","gists_url":"https://api.github.com/users/baentsch/gists{/gist_id}","starred_url":"https://api.github.com/users/baentsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baentsch/subscriptions","organizations_url":"https://api.github.com/users/baentsch/orgs","repos_url":"https://api.github.com/users/baentsch/repos","events_url":"https://api.github.com/users/baentsch/events{/privacy}","received_events_url":"https://api.github.com/users/baentsch/received_events","type":"User","site_admin":false},"body":"I completely agree: OIDs should remain as registered. I do not remember touching this file at all and assumed all changes were caused by running `make generate_crypto_objects` (after adding sha512 to obj_xref.txt). Let me see whether I can find the reason/mechanism causing this change (and avoid it).","created_at":"2019-11-20T16:34:25Z","updated_at":"2019-11-20T16:34:26Z","html_url":"https://github.com/open-quantum-safe/openssl/pull/130#discussion_r348605686","pull_request_url":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/130","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/comments/348605686"},"html":{"href":"https://github.com/open-quantum-safe/openssl/pull/130#discussion_r348605686"},"pull_request":{"href":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/130"}},"in_reply_to_id":348565546},"pull_request":{"url":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/130","id":341475849,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxNDc1ODQ5","html_url":"https://github.com/open-quantum-safe/openssl/pull/130","diff_url":"https://github.com/open-quantum-safe/openssl/pull/130.diff","patch_url":"https://github.com/open-quantum-safe/openssl/pull/130.patch","issue_url":"https://api.github.com/repos/open-quantum-safe/openssl/issues/130","number":130,"state":"open","locked":false,"title":"OQS-CMS ","user":{"login":"baentsch","id":57787676,"node_id":"MDQ6VXNlcjU3Nzg3Njc2","avatar_url":"https://avatars1.githubusercontent.com/u/57787676?v=4","gravatar_id":"","url":"https://api.github.com/users/baentsch","html_url":"https://github.com/baentsch","followers_url":"https://api.github.com/users/baentsch/followers","following_url":"https://api.github.com/users/baentsch/following{/other_user}","gists_url":"https://api.github.com/users/baentsch/gists{/gist_id}","starred_url":"https://api.github.com/users/baentsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baentsch/subscriptions","organizations_url":"https://api.github.com/users/baentsch/orgs","repos_url":"https://api.github.com/users/baentsch/repos","events_url":"https://api.github.com/users/baentsch/events{/privacy}","received_events_url":"https://api.github.com/users/baentsch/received_events","type":"User","site_admin":false},"body":"This 'activates' CMS sign-verify support for OQS algorithms. Digest is fixed to SHA512.\r\n\r\n##### Checklist\r\n- [x] documentation is added or updated\r\n- [x] tests are added or updated\r\n","created_at":"2019-11-15T13:49:36Z","updated_at":"2019-11-20T16:34:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f933b287aeb0f4ea900605bc19893d7538cc28b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dstebila","id":8843219,"node_id":"MDQ6VXNlcjg4NDMyMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/8843219?v=4","gravatar_id":"","url":"https://api.github.com/users/dstebila","html_url":"https://github.com/dstebila","followers_url":"https://api.github.com/users/dstebila/followers","following_url":"https://api.github.com/users/dstebila/following{/other_user}","gists_url":"https://api.github.com/users/dstebila/gists{/gist_id}","starred_url":"https://api.github.com/users/dstebila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstebila/subscriptions","organizations_url":"https://api.github.com/users/dstebila/orgs","repos_url":"https://api.github.com/users/dstebila/repos","events_url":"https://api.github.com/users/dstebila/events{/privacy}","received_events_url":"https://api.github.com/users/dstebila/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/130/commits","review_comments_url":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/130/comments","review_comment_url":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-quantum-safe/openssl/issues/130/comments","statuses_url":"https://api.github.com/repos/open-quantum-safe/openssl/statuses/02acb7f50ed7f31c1eb19db2ed5202418286a2ca","head":{"label":"baentsch:OQS-OpenSSL_1_1_1-stable","ref":"OQS-OpenSSL_1_1_1-stable","sha":"02acb7f50ed7f31c1eb19db2ed5202418286a2ca","user":{"login":"baentsch","id":57787676,"node_id":"MDQ6VXNlcjU3Nzg3Njc2","avatar_url":"https://avatars1.githubusercontent.com/u/57787676?v=4","gravatar_id":"","url":"https://api.github.com/users/baentsch","html_url":"https://github.com/baentsch","followers_url":"https://api.github.com/users/baentsch/followers","following_url":"https://api.github.com/users/baentsch/following{/other_user}","gists_url":"https://api.github.com/users/baentsch/gists{/gist_id}","starred_url":"https://api.github.com/users/baentsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baentsch/subscriptions","organizations_url":"https://api.github.com/users/baentsch/orgs","repos_url":"https://api.github.com/users/baentsch/repos","events_url":"https://api.github.com/users/baentsch/events{/privacy}","received_events_url":"https://api.github.com/users/baentsch/received_events","type":"User","site_admin":false},"repo":{"id":221923441,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE5MjM0NDE=","name":"openssl","full_name":"baentsch/openssl","private":false,"owner":{"login":"baentsch","id":57787676,"node_id":"MDQ6VXNlcjU3Nzg3Njc2","avatar_url":"https://avatars1.githubusercontent.com/u/57787676?v=4","gravatar_id":"","url":"https://api.github.com/users/baentsch","html_url":"https://github.com/baentsch","followers_url":"https://api.github.com/users/baentsch/followers","following_url":"https://api.github.com/users/baentsch/following{/other_user}","gists_url":"https://api.github.com/users/baentsch/gists{/gist_id}","starred_url":"https://api.github.com/users/baentsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baentsch/subscriptions","organizations_url":"https://api.github.com/users/baentsch/orgs","repos_url":"https://api.github.com/users/baentsch/repos","events_url":"https://api.github.com/users/baentsch/events{/privacy}","received_events_url":"https://api.github.com/users/baentsch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/baentsch/openssl","description":"Fork of OpenSSL that includes quantum-resistant algorithms and ciphersuites based on liboqs.","fork":true,"url":"https://api.github.com/repos/baentsch/openssl","forks_url":"https://api.github.com/repos/baentsch/openssl/forks","keys_url":"https://api.github.com/repos/baentsch/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baentsch/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baentsch/openssl/teams","hooks_url":"https://api.github.com/repos/baentsch/openssl/hooks","issue_events_url":"https://api.github.com/repos/baentsch/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/baentsch/openssl/events","assignees_url":"https://api.github.com/repos/baentsch/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/baentsch/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/baentsch/openssl/tags","blobs_url":"https://api.github.com/repos/baentsch/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baentsch/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baentsch/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/baentsch/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baentsch/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/baentsch/openssl/languages","stargazers_url":"https://api.github.com/repos/baentsch/openssl/stargazers","contributors_url":"https://api.github.com/repos/baentsch/openssl/contributors","subscribers_url":"https://api.github.com/repos/baentsch/openssl/subscribers","subscription_url":"https://api.github.com/repos/baentsch/openssl/subscription","commits_url":"https://api.github.com/repos/baentsch/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/baentsch/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/baentsch/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/baentsch/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/baentsch/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/baentsch/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baentsch/openssl/merges","archive_url":"https://api.github.com/repos/baentsch/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baentsch/openssl/downloads","issues_url":"https://api.github.com/repos/baentsch/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/baentsch/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/baentsch/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/baentsch/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baentsch/openssl/labels{/name}","releases_url":"https://api.github.com/repos/baentsch/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/baentsch/openssl/deployments","created_at":"2019-11-15T12:51:35Z","updated_at":"2019-11-20T07:33:16Z","pushed_at":"2019-11-20T07:33:06Z","git_url":"git://github.com/baentsch/openssl.git","ssh_url":"git@github.com:baentsch/openssl.git","clone_url":"https://github.com/baentsch/openssl.git","svn_url":"https://github.com/baentsch/openssl","homepage":"https://openquantumsafe.org/","size":164441,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"OQS-OpenSSL_1_1_1-stable"}},"base":{"label":"open-quantum-safe:OQS-OpenSSL_1_1_1-stable","ref":"OQS-OpenSSL_1_1_1-stable","sha":"34264357a50a24c393db67f0fe313e25b84dc9e6","user":{"login":"open-quantum-safe","id":20689385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjg5Mzg1","avatar_url":"https://avatars3.githubusercontent.com/u/20689385?v=4","gravatar_id":"","url":"https://api.github.com/users/open-quantum-safe","html_url":"https://github.com/open-quantum-safe","followers_url":"https://api.github.com/users/open-quantum-safe/followers","following_url":"https://api.github.com/users/open-quantum-safe/following{/other_user}","gists_url":"https://api.github.com/users/open-quantum-safe/gists{/gist_id}","starred_url":"https://api.github.com/users/open-quantum-safe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-quantum-safe/subscriptions","organizations_url":"https://api.github.com/users/open-quantum-safe/orgs","repos_url":"https://api.github.com/users/open-quantum-safe/repos","events_url":"https://api.github.com/users/open-quantum-safe/events{/privacy}","received_events_url":"https://api.github.com/users/open-quantum-safe/received_events","type":"Organization","site_admin":false},"repo":{"id":66578799,"node_id":"MDEwOlJlcG9zaXRvcnk2NjU3ODc5OQ==","name":"openssl","full_name":"open-quantum-safe/openssl","private":false,"owner":{"login":"open-quantum-safe","id":20689385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjg5Mzg1","avatar_url":"https://avatars3.githubusercontent.com/u/20689385?v=4","gravatar_id":"","url":"https://api.github.com/users/open-quantum-safe","html_url":"https://github.com/open-quantum-safe","followers_url":"https://api.github.com/users/open-quantum-safe/followers","following_url":"https://api.github.com/users/open-quantum-safe/following{/other_user}","gists_url":"https://api.github.com/users/open-quantum-safe/gists{/gist_id}","starred_url":"https://api.github.com/users/open-quantum-safe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-quantum-safe/subscriptions","organizations_url":"https://api.github.com/users/open-quantum-safe/orgs","repos_url":"https://api.github.com/users/open-quantum-safe/repos","events_url":"https://api.github.com/users/open-quantum-safe/events{/privacy}","received_events_url":"https://api.github.com/users/open-quantum-safe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-quantum-safe/openssl","description":"Fork of OpenSSL that includes quantum-resistant algorithms and ciphersuites based on liboqs.","fork":true,"url":"https://api.github.com/repos/open-quantum-safe/openssl","forks_url":"https://api.github.com/repos/open-quantum-safe/openssl/forks","keys_url":"https://api.github.com/repos/open-quantum-safe/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-quantum-safe/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-quantum-safe/openssl/teams","hooks_url":"https://api.github.com/repos/open-quantum-safe/openssl/hooks","issue_events_url":"https://api.github.com/repos/open-quantum-safe/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/open-quantum-safe/openssl/events","assignees_url":"https://api.github.com/repos/open-quantum-safe/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/open-quantum-safe/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/open-quantum-safe/openssl/tags","blobs_url":"https://api.github.com/repos/open-quantum-safe/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-quantum-safe/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-quantum-safe/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-quantum-safe/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-quantum-safe/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/open-quantum-safe/openssl/languages","stargazers_url":"https://api.github.com/repos/open-quantum-safe/openssl/stargazers","contributors_url":"https://api.github.com/repos/open-quantum-safe/openssl/contributors","subscribers_url":"https://api.github.com/repos/open-quantum-safe/openssl/subscribers","subscription_url":"https://api.github.com/repos/open-quantum-safe/openssl/subscription","commits_url":"https://api.github.com/repos/open-quantum-safe/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-quantum-safe/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-quantum-safe/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-quantum-safe/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-quantum-safe/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/open-quantum-safe/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-quantum-safe/openssl/merges","archive_url":"https://api.github.com/repos/open-quantum-safe/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-quantum-safe/openssl/downloads","issues_url":"https://api.github.com/repos/open-quantum-safe/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/open-quantum-safe/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/open-quantum-safe/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/open-quantum-safe/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-quantum-safe/openssl/labels{/name}","releases_url":"https://api.github.com/repos/open-quantum-safe/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/open-quantum-safe/openssl/deployments","created_at":"2016-08-25T17:25:43Z","updated_at":"2019-11-12T02:25:35Z","pushed_at":"2019-11-20T07:33:16Z","git_url":"git://github.com/open-quantum-safe/openssl.git","ssh_url":"git@github.com:open-quantum-safe/openssl.git","clone_url":"https://github.com/open-quantum-safe/openssl.git","svn_url":"https://github.com/open-quantum-safe/openssl","homepage":"https://openquantumsafe.org/","size":164425,"stargazers_count":82,"watchers_count":82,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":8,"watchers":82,"default_branch":"OQS-OpenSSL_1_1_1-stable"}},"_links":{"self":{"href":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/130"},"html":{"href":"https://github.com/open-quantum-safe/openssl/pull/130"},"issue":{"href":"https://api.github.com/repos/open-quantum-safe/openssl/issues/130"},"comments":{"href":"https://api.github.com/repos/open-quantum-safe/openssl/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-quantum-safe/openssl/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/open-quantum-safe/openssl/statuses/02acb7f50ed7f31c1eb19db2ed5202418286a2ca"}},"author_association":"NONE"}}
|
{
"id": 66578799,
"name": "open-quantum-safe/openssl",
"url": "https://api.github.com/repos/open-quantum-safe/openssl"
}
|
{
"id": 57787676,
"login": "baentsch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/57787676?",
"url": "https://api.github.com/users/baentsch"
}
|
{
"id": 20689385,
"login": "open-quantum-safe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20689385?",
"url": "https://api.github.com/orgs/open-quantum-safe"
}
| 2019-11-20T16:34:25 |
10908463592
|
{"actor":{"display_login":"baentsch"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/comments/355290720","pull_request_review_id":328721153,"id":355290720,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTI5MDcyMA==","diff_hunk":"@@ -0,0 +1,25 @@\n+'use strict'\n+\n+const drinkTray = [];\n+const drinkTypes = ['cola', 'lemonade', 'water'];\n+\n+\n+ for (let i =0; i <=5 ; i++ ){\n+ \n+ if (i < 2) {\n+ drinkTray.push(drinkTypes[0]); \n+ continue;\n+ }\n+ if (i < 4) {\n+ drinkTray.push(drinkTypes[1]); \n+ continue;\n+ }\n+ if (i < 5) {\n+ drinkTray.push(drinkTypes[2]); \n+ }\n+ }\n+ \n+ console.log('\\\"Hey guys, I brought a '+ drinkTray + '!\\\"');","path":"Week2/homework/js-exercises/5-Who wants a drink.js","position":22,"original_position":22,"commit_id":"201cf0db38749d4adfb94eb66d31357c5bf482f9","original_commit_id":"201cf0db38749d4adfb94eb66d31357c5bf482f9","user":{"login":"marcianoviereck","id":3209488,"node_id":"MDQ6VXNlcjMyMDk0ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/3209488?v=4","gravatar_id":"","url":"https://api.github.com/users/marcianoviereck","html_url":"https://github.com/marcianoviereck","followers_url":"https://api.github.com/users/marcianoviereck/followers","following_url":"https://api.github.com/users/marcianoviereck/following{/other_user}","gists_url":"https://api.github.com/users/marcianoviereck/gists{/gist_id}","starred_url":"https://api.github.com/users/marcianoviereck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcianoviereck/subscriptions","organizations_url":"https://api.github.com/users/marcianoviereck/orgs","repos_url":"https://api.github.com/users/marcianoviereck/repos","events_url":"https://api.github.com/users/marcianoviereck/events{/privacy}","received_events_url":"https://api.github.com/users/marcianoviereck/received_events","type":"User","site_admin":false},"body":"hah nice!","created_at":"2019-12-09T07:13:09Z","updated_at":"2019-12-09T07:15:27Z","html_url":"https://github.com/HackYourFuture/JavaScript1/pull/227#discussion_r355290720","pull_request_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/227","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/comments/355290720"},"html":{"href":"https://github.com/HackYourFuture/JavaScript1/pull/227#discussion_r355290720"},"pull_request":{"href":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/227","id":350318432,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwMzE4NDMy","html_url":"https://github.com/HackYourFuture/JavaScript1/pull/227","diff_url":"https://github.com/HackYourFuture/JavaScript1/pull/227.diff","patch_url":"https://github.com/HackYourFuture/JavaScript1/pull/227.patch","issue_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/issues/227","number":227,"state":"open","locked":false,"title":" homework week2 wesam akfere ","user":{"login":"wesam-k","id":53225954,"node_id":"MDQ6VXNlcjUzMjI1OTU0","avatar_url":"https://avatars2.githubusercontent.com/u/53225954?v=4","gravatar_id":"","url":"https://api.github.com/users/wesam-k","html_url":"https://github.com/wesam-k","followers_url":"https://api.github.com/users/wesam-k/followers","following_url":"https://api.github.com/users/wesam-k/following{/other_user}","gists_url":"https://api.github.com/users/wesam-k/gists{/gist_id}","starred_url":"https://api.github.com/users/wesam-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesam-k/subscriptions","organizations_url":"https://api.github.com/users/wesam-k/orgs","repos_url":"https://api.github.com/users/wesam-k/repos","events_url":"https://api.github.com/users/wesam-k/events{/privacy}","received_events_url":"https://api.github.com/users/wesam-k/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-07T15:07:35Z","updated_at":"2019-12-09T07:15:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e858df1b16e37bb515d91dab1829615ff9b04d38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/227/commits","review_comments_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/227/comments","review_comment_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/issues/227/comments","statuses_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/statuses/201cf0db38749d4adfb94eb66d31357c5bf482f9","head":{"label":"wesam-k:week2-homework-wesam-alkfere","ref":"week2-homework-wesam-alkfere","sha":"201cf0db38749d4adfb94eb66d31357c5bf482f9","user":{"login":"wesam-k","id":53225954,"node_id":"MDQ6VXNlcjUzMjI1OTU0","avatar_url":"https://avatars2.githubusercontent.com/u/53225954?v=4","gravatar_id":"","url":"https://api.github.com/users/wesam-k","html_url":"https://github.com/wesam-k","followers_url":"https://api.github.com/users/wesam-k/followers","following_url":"https://api.github.com/users/wesam-k/following{/other_user}","gists_url":"https://api.github.com/users/wesam-k/gists{/gist_id}","starred_url":"https://api.github.com/users/wesam-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesam-k/subscriptions","organizations_url":"https://api.github.com/users/wesam-k/orgs","repos_url":"https://api.github.com/users/wesam-k/repos","events_url":"https://api.github.com/users/wesam-k/events{/privacy}","received_events_url":"https://api.github.com/users/wesam-k/received_events","type":"User","site_admin":false},"repo":{"id":223760368,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM3NjAzNjg=","name":"JavaScript1","full_name":"wesam-k/JavaScript1","private":false,"owner":{"login":"wesam-k","id":53225954,"node_id":"MDQ6VXNlcjUzMjI1OTU0","avatar_url":"https://avatars2.githubusercontent.com/u/53225954?v=4","gravatar_id":"","url":"https://api.github.com/users/wesam-k","html_url":"https://github.com/wesam-k","followers_url":"https://api.github.com/users/wesam-k/followers","following_url":"https://api.github.com/users/wesam-k/following{/other_user}","gists_url":"https://api.github.com/users/wesam-k/gists{/gist_id}","starred_url":"https://api.github.com/users/wesam-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesam-k/subscriptions","organizations_url":"https://api.github.com/users/wesam-k/orgs","repos_url":"https://api.github.com/users/wesam-k/repos","events_url":"https://api.github.com/users/wesam-k/events{/privacy}","received_events_url":"https://api.github.com/users/wesam-k/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wesam-k/JavaScript1","description":"This repository contains all the material for the HackYourFuture module \"JavaScript 1: Programmming Basics\"","fork":true,"url":"https://api.github.com/repos/wesam-k/JavaScript1","forks_url":"https://api.github.com/repos/wesam-k/JavaScript1/forks","keys_url":"https://api.github.com/repos/wesam-k/JavaScript1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesam-k/JavaScript1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesam-k/JavaScript1/teams","hooks_url":"https://api.github.com/repos/wesam-k/JavaScript1/hooks","issue_events_url":"https://api.github.com/repos/wesam-k/JavaScript1/issues/events{/number}","events_url":"https://api.github.com/repos/wesam-k/JavaScript1/events","assignees_url":"https://api.github.com/repos/wesam-k/JavaScript1/assignees{/user}","branches_url":"https://api.github.com/repos/wesam-k/JavaScript1/branches{/branch}","tags_url":"https://api.github.com/repos/wesam-k/JavaScript1/tags","blobs_url":"https://api.github.com/repos/wesam-k/JavaScript1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesam-k/JavaScript1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesam-k/JavaScript1/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesam-k/JavaScript1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesam-k/JavaScript1/statuses/{sha}","languages_url":"https://api.github.com/repos/wesam-k/JavaScript1/languages","stargazers_url":"https://api.github.com/repos/wesam-k/JavaScript1/stargazers","contributors_url":"https://api.github.com/repos/wesam-k/JavaScript1/contributors","subscribers_url":"https://api.github.com/repos/wesam-k/JavaScript1/subscribers","subscription_url":"https://api.github.com/repos/wesam-k/JavaScript1/subscription","commits_url":"https://api.github.com/repos/wesam-k/JavaScript1/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesam-k/JavaScript1/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesam-k/JavaScript1/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesam-k/JavaScript1/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesam-k/JavaScript1/contents/{+path}","compare_url":"https://api.github.com/repos/wesam-k/JavaScript1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesam-k/JavaScript1/merges","archive_url":"https://api.github.com/repos/wesam-k/JavaScript1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesam-k/JavaScript1/downloads","issues_url":"https://api.github.com/repos/wesam-k/JavaScript1/issues{/number}","pulls_url":"https://api.github.com/repos/wesam-k/JavaScript1/pulls{/number}","milestones_url":"https://api.github.com/repos/wesam-k/JavaScript1/milestones{/number}","notifications_url":"https://api.github.com/repos/wesam-k/JavaScript1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesam-k/JavaScript1/labels{/name}","releases_url":"https://api.github.com/repos/wesam-k/JavaScript1/releases{/id}","deployments_url":"https://api.github.com/repos/wesam-k/JavaScript1/deployments","created_at":"2019-11-24T14:49:10Z","updated_at":"2019-11-24T14:49:12Z","pushed_at":"2019-12-07T22:07:51Z","git_url":"git://github.com/wesam-k/JavaScript1.git","ssh_url":"git@github.com:wesam-k/JavaScript1.git","clone_url":"https://github.com/wesam-k/JavaScript1.git","svn_url":"https://github.com/wesam-k/JavaScript1","homepage":"","size":11402,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HackYourFuture:master","ref":"master","sha":"3ba32e5e38f63b0a2d0a1e8351711efd46630f95","user":{"login":"HackYourFuture","id":20858568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODU4NTY4","avatar_url":"https://avatars2.githubusercontent.com/u/20858568?v=4","gravatar_id":"","url":"https://api.github.com/users/HackYourFuture","html_url":"https://github.com/HackYourFuture","followers_url":"https://api.github.com/users/HackYourFuture/followers","following_url":"https://api.github.com/users/HackYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/HackYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/HackYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackYourFuture/subscriptions","organizations_url":"https://api.github.com/users/HackYourFuture/orgs","repos_url":"https://api.github.com/users/HackYourFuture/repos","events_url":"https://api.github.com/users/HackYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/HackYourFuture/received_events","type":"Organization","site_admin":false},"repo":{"id":70716559,"node_id":"MDEwOlJlcG9zaXRvcnk3MDcxNjU1OQ==","name":"JavaScript1","full_name":"HackYourFuture/JavaScript1","private":false,"owner":{"login":"HackYourFuture","id":20858568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODU4NTY4","avatar_url":"https://avatars2.githubusercontent.com/u/20858568?v=4","gravatar_id":"","url":"https://api.github.com/users/HackYourFuture","html_url":"https://github.com/HackYourFuture","followers_url":"https://api.github.com/users/HackYourFuture/followers","following_url":"https://api.github.com/users/HackYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/HackYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/HackYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackYourFuture/subscriptions","organizations_url":"https://api.github.com/users/HackYourFuture/orgs","repos_url":"https://api.github.com/users/HackYourFuture/repos","events_url":"https://api.github.com/users/HackYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/HackYourFuture/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HackYourFuture/JavaScript1","description":"This repository contains all the material for the HackYourFuture module \"JavaScript 1: Programming Basics\"","fork":false,"url":"https://api.github.com/repos/HackYourFuture/JavaScript1","forks_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/forks","keys_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/teams","hooks_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/hooks","issue_events_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/issues/events{/number}","events_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/events","assignees_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/assignees{/user}","branches_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/branches{/branch}","tags_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/tags","blobs_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/git/refs{/sha}","trees_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/statuses/{sha}","languages_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/languages","stargazers_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/stargazers","contributors_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/contributors","subscribers_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/subscribers","subscription_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/subscription","commits_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/commits{/sha}","git_commits_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/git/commits{/sha}","comments_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/comments{/number}","issue_comment_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/issues/comments{/number}","contents_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/contents/{+path}","compare_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/merges","archive_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/downloads","issues_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/issues{/number}","pulls_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls{/number}","milestones_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/milestones{/number}","notifications_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/labels{/name}","releases_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/releases{/id}","deployments_url":"https://api.github.com/repos/HackYourFuture/JavaScript1/deployments","created_at":"2016-10-12T15:59:04Z","updated_at":"2019-12-08T07:54:44Z","pushed_at":"2019-12-08T15:06:57Z","git_url":"git://github.com/HackYourFuture/JavaScript1.git","ssh_url":"git@github.com:HackYourFuture/JavaScript1.git","clone_url":"https://github.com/HackYourFuture/JavaScript1.git","svn_url":"https://github.com/HackYourFuture/JavaScript1","homepage":"","size":11421,"stargazers_count":55,"watchers_count":55,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":null,"forks":195,"open_issues":15,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/227"},"html":{"href":"https://github.com/HackYourFuture/JavaScript1/pull/227"},"issue":{"href":"https://api.github.com/repos/HackYourFuture/JavaScript1/issues/227"},"comments":{"href":"https://api.github.com/repos/HackYourFuture/JavaScript1/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HackYourFuture/JavaScript1/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/HackYourFuture/JavaScript1/statuses/201cf0db38749d4adfb94eb66d31357c5bf482f9"}},"author_association":"NONE"}}
|
{
"id": 70716559,
"name": "HackYourFuture/JavaScript1",
"url": "https://api.github.com/repos/HackYourFuture/JavaScript1"
}
|
{
"id": 3209488,
"login": "marcianoviereck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3209488?",
"url": "https://api.github.com/users/marcianoviereck"
}
|
{
"id": 20858568,
"login": "HackYourFuture",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20858568?",
"url": "https://api.github.com/orgs/HackYourFuture"
}
| 2019-12-09T07:13:09 |
11041673722
|
{"actor":{"display_login":"marcianoviereck"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/HackYourFuture/React/pulls/comments/303373684","pull_request_review_id":261736394,"id":303373684,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzM3MzY4NA==","diff_hunk":"@@ -0,0 +1,183 @@\n+import React from 'react';\n+\n+// ContentDynamicTodo component is for map function to use\n+const ContentDynamicTodo = ({ description, deadline, className, deleteItem }) => {\n+ return (\n+ <tbody>\n+ <tr className={className} onClick={deleteItem}>\n+ <td class=\"evenBackgroundColor\">\n+ <td class=\"content\"> {description} </td> <td class=\"content\"> {deadline} </td>{' '}\n+ <td class=\"content\"> {className} </td>{' '}\n+ </td>{' '}\n+ </tr>{' '}\n+ </tbody>\n+ );\n+};\n+\n+// DynamicList where map function is\n+const DynamicList = ({ list, deleteItem }) => {\n+ const runTodoList = list.map(todo => (\n+ <ContentDynamicTodo\n+ key={todo.id}","path":"homework-submission/react-hyf/react-hyf-client/src/React_HW2/todoApp2.jsx","position":21,"original_position":21,"commit_id":"88d25624afb744a0876dec2e6c2c0a5a8de63c89","original_commit_id":"88d25624afb744a0876dec2e6c2c0a5a8de63c89","user":{"login":"Meno-101","id":25272822,"node_id":"MDQ6VXNlcjI1MjcyODIy","avatar_url":"https://avatars0.githubusercontent.com/u/25272822?v=4","gravatar_id":"","url":"https://api.github.com/users/Meno-101","html_url":"https://github.com/Meno-101","followers_url":"https://api.github.com/users/Meno-101/followers","following_url":"https://api.github.com/users/Meno-101/following{/other_user}","gists_url":"https://api.github.com/users/Meno-101/gists{/gist_id}","starred_url":"https://api.github.com/users/Meno-101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meno-101/subscriptions","organizations_url":"https://api.github.com/users/Meno-101/orgs","repos_url":"https://api.github.com/users/Meno-101/repos","events_url":"https://api.github.com/users/Meno-101/events{/privacy}","received_events_url":"https://api.github.com/users/Meno-101/received_events","type":"User","site_admin":false},"body":"Please have a look to the previous homework review.","created_at":"2019-07-15T10:34:49Z","updated_at":"2019-07-15T10:40:41Z","html_url":"https://github.com/HackYourFuture/React/pull/437#discussion_r303373684","pull_request_url":"https://api.github.com/repos/HackYourFuture/React/pulls/437","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/comments/303373684"},"html":{"href":"https://github.com/HackYourFuture/React/pull/437#discussion_r303373684"},"pull_request":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/437"}}},"pull_request":{"url":"https://api.github.com/repos/HackYourFuture/React/pulls/437","id":297358940,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MzU4OTQw","html_url":"https://github.com/HackYourFuture/React/pull/437","diff_url":"https://github.com/HackYourFuture/React/pull/437.diff","patch_url":"https://github.com/HackYourFuture/React/pull/437.patch","issue_url":"https://api.github.com/repos/HackYourFuture/React/issues/437","number":437,"state":"open","locked":false,"title":"RamazanInce_React_HW3_New","user":{"login":"RamazanInce","id":45245705,"node_id":"MDQ6VXNlcjQ1MjQ1NzA1","avatar_url":"https://avatars2.githubusercontent.com/u/45245705?v=4","gravatar_id":"","url":"https://api.github.com/users/RamazanInce","html_url":"https://github.com/RamazanInce","followers_url":"https://api.github.com/users/RamazanInce/followers","following_url":"https://api.github.com/users/RamazanInce/following{/other_user}","gists_url":"https://api.github.com/users/RamazanInce/gists{/gist_id}","starred_url":"https://api.github.com/users/RamazanInce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamazanInce/subscriptions","organizations_url":"https://api.github.com/users/RamazanInce/orgs","repos_url":"https://api.github.com/users/RamazanInce/repos","events_url":"https://api.github.com/users/RamazanInce/events{/privacy}","received_events_url":"https://api.github.com/users/RamazanInce/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-14T01:16:03Z","updated_at":"2019-07-15T10:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3def7c3ed269fc65f8aca4d24dc3fc400432583","assignee":{"login":"Meno-101","id":25272822,"node_id":"MDQ6VXNlcjI1MjcyODIy","avatar_url":"https://avatars0.githubusercontent.com/u/25272822?v=4","gravatar_id":"","url":"https://api.github.com/users/Meno-101","html_url":"https://github.com/Meno-101","followers_url":"https://api.github.com/users/Meno-101/followers","following_url":"https://api.github.com/users/Meno-101/following{/other_user}","gists_url":"https://api.github.com/users/Meno-101/gists{/gist_id}","starred_url":"https://api.github.com/users/Meno-101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meno-101/subscriptions","organizations_url":"https://api.github.com/users/Meno-101/orgs","repos_url":"https://api.github.com/users/Meno-101/repos","events_url":"https://api.github.com/users/Meno-101/events{/privacy}","received_events_url":"https://api.github.com/users/Meno-101/received_events","type":"User","site_admin":false},"assignees":[{"login":"Meno-101","id":25272822,"node_id":"MDQ6VXNlcjI1MjcyODIy","avatar_url":"https://avatars0.githubusercontent.com/u/25272822?v=4","gravatar_id":"","url":"https://api.github.com/users/Meno-101","html_url":"https://github.com/Meno-101","followers_url":"https://api.github.com/users/Meno-101/followers","following_url":"https://api.github.com/users/Meno-101/following{/other_user}","gists_url":"https://api.github.com/users/Meno-101/gists{/gist_id}","starred_url":"https://api.github.com/users/Meno-101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meno-101/subscriptions","organizations_url":"https://api.github.com/users/Meno-101/orgs","repos_url":"https://api.github.com/users/Meno-101/repos","events_url":"https://api.github.com/users/Meno-101/events{/privacy}","received_events_url":"https://api.github.com/users/Meno-101/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":891096321,"node_id":"MDU6TGFiZWw4OTEwOTYzMjE=","url":"https://api.github.com/repos/HackYourFuture/React/labels/homework3","name":"homework3","color":"0bead8","default":false},{"id":891097835,"node_id":"MDU6TGFiZWw4OTEwOTc4MzU=","url":"https://api.github.com/repos/HackYourFuture/React/labels/needs%20work","name":"needs work","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HackYourFuture/React/pulls/437/commits","review_comments_url":"https://api.github.com/repos/HackYourFuture/React/pulls/437/comments","review_comment_url":"https://api.github.com/repos/HackYourFuture/React/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HackYourFuture/React/issues/437/comments","statuses_url":"https://api.github.com/repos/HackYourFuture/React/statuses/88d25624afb744a0876dec2e6c2c0a5a8de63c89","head":{"label":"RamazanInce:RamazanInce_React_HW3_New","ref":"RamazanInce_React_HW3_New","sha":"88d25624afb744a0876dec2e6c2c0a5a8de63c89","user":{"login":"RamazanInce","id":45245705,"node_id":"MDQ6VXNlcjQ1MjQ1NzA1","avatar_url":"https://avatars2.githubusercontent.com/u/45245705?v=4","gravatar_id":"","url":"https://api.github.com/users/RamazanInce","html_url":"https://github.com/RamazanInce","followers_url":"https://api.github.com/users/RamazanInce/followers","following_url":"https://api.github.com/users/RamazanInce/following{/other_user}","gists_url":"https://api.github.com/users/RamazanInce/gists{/gist_id}","starred_url":"https://api.github.com/users/RamazanInce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamazanInce/subscriptions","organizations_url":"https://api.github.com/users/RamazanInce/orgs","repos_url":"https://api.github.com/users/RamazanInce/repos","events_url":"https://api.github.com/users/RamazanInce/events{/privacy}","received_events_url":"https://api.github.com/users/RamazanInce/received_events","type":"User","site_admin":false},"repo":{"id":193334540,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMzMzQ1NDA=","name":"React","full_name":"RamazanInce/React","private":false,"owner":{"login":"RamazanInce","id":45245705,"node_id":"MDQ6VXNlcjQ1MjQ1NzA1","avatar_url":"https://avatars2.githubusercontent.com/u/45245705?v=4","gravatar_id":"","url":"https://api.github.com/users/RamazanInce","html_url":"https://github.com/RamazanInce","followers_url":"https://api.github.com/users/RamazanInce/followers","following_url":"https://api.github.com/users/RamazanInce/following{/other_user}","gists_url":"https://api.github.com/users/RamazanInce/gists{/gist_id}","starred_url":"https://api.github.com/users/RamazanInce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamazanInce/subscriptions","organizations_url":"https://api.github.com/users/RamazanInce/orgs","repos_url":"https://api.github.com/users/RamazanInce/repos","events_url":"https://api.github.com/users/RamazanInce/events{/privacy}","received_events_url":"https://api.github.com/users/RamazanInce/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RamazanInce/React","description":"Specifications React Module","fork":true,"url":"https://api.github.com/repos/RamazanInce/React","forks_url":"https://api.github.com/repos/RamazanInce/React/forks","keys_url":"https://api.github.com/repos/RamazanInce/React/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RamazanInce/React/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RamazanInce/React/teams","hooks_url":"https://api.github.com/repos/RamazanInce/React/hooks","issue_events_url":"https://api.github.com/repos/RamazanInce/React/issues/events{/number}","events_url":"https://api.github.com/repos/RamazanInce/React/events","assignees_url":"https://api.github.com/repos/RamazanInce/React/assignees{/user}","branches_url":"https://api.github.com/repos/RamazanInce/React/branches{/branch}","tags_url":"https://api.github.com/repos/RamazanInce/React/tags","blobs_url":"https://api.github.com/repos/RamazanInce/React/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RamazanInce/React/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RamazanInce/React/git/refs{/sha}","trees_url":"https://api.github.com/repos/RamazanInce/React/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RamazanInce/React/statuses/{sha}","languages_url":"https://api.github.com/repos/RamazanInce/React/languages","stargazers_url":"https://api.github.com/repos/RamazanInce/React/stargazers","contributors_url":"https://api.github.com/repos/RamazanInce/React/contributors","subscribers_url":"https://api.github.com/repos/RamazanInce/React/subscribers","subscription_url":"https://api.github.com/repos/RamazanInce/React/subscription","commits_url":"https://api.github.com/repos/RamazanInce/React/commits{/sha}","git_commits_url":"https://api.github.com/repos/RamazanInce/React/git/commits{/sha}","comments_url":"https://api.github.com/repos/RamazanInce/React/comments{/number}","issue_comment_url":"https://api.github.com/repos/RamazanInce/React/issues/comments{/number}","contents_url":"https://api.github.com/repos/RamazanInce/React/contents/{+path}","compare_url":"https://api.github.com/repos/RamazanInce/React/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RamazanInce/React/merges","archive_url":"https://api.github.com/repos/RamazanInce/React/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RamazanInce/React/downloads","issues_url":"https://api.github.com/repos/RamazanInce/React/issues{/number}","pulls_url":"https://api.github.com/repos/RamazanInce/React/pulls{/number}","milestones_url":"https://api.github.com/repos/RamazanInce/React/milestones{/number}","notifications_url":"https://api.github.com/repos/RamazanInce/React/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RamazanInce/React/labels{/name}","releases_url":"https://api.github.com/repos/RamazanInce/React/releases{/id}","deployments_url":"https://api.github.com/repos/RamazanInce/React/deployments","created_at":"2019-06-23T10:28:02Z","updated_at":"2019-06-23T10:28:05Z","pushed_at":"2019-07-14T01:14:02Z","git_url":"git://github.com/RamazanInce/React.git","ssh_url":"git@github.com:RamazanInce/React.git","clone_url":"https://github.com/RamazanInce/React.git","svn_url":"https://github.com/RamazanInce/React","homepage":null,"size":1389,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HackYourFuture:master","ref":"master","sha":"b2d1283dcef62bec6fb399363b0b16b10b53e194","user":{"login":"HackYourFuture","id":20858568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODU4NTY4","avatar_url":"https://avatars2.githubusercontent.com/u/20858568?v=4","gravatar_id":"","url":"https://api.github.com/users/HackYourFuture","html_url":"https://github.com/HackYourFuture","followers_url":"https://api.github.com/users/HackYourFuture/followers","following_url":"https://api.github.com/users/HackYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/HackYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/HackYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackYourFuture/subscriptions","organizations_url":"https://api.github.com/users/HackYourFuture/orgs","repos_url":"https://api.github.com/users/HackYourFuture/repos","events_url":"https://api.github.com/users/HackYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/HackYourFuture/received_events","type":"Organization","site_admin":false},"repo":{"id":93503545,"node_id":"MDEwOlJlcG9zaXRvcnk5MzUwMzU0NQ==","name":"React","full_name":"HackYourFuture/React","private":false,"owner":{"login":"HackYourFuture","id":20858568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODU4NTY4","avatar_url":"https://avatars2.githubusercontent.com/u/20858568?v=4","gravatar_id":"","url":"https://api.github.com/users/HackYourFuture","html_url":"https://github.com/HackYourFuture","followers_url":"https://api.github.com/users/HackYourFuture/followers","following_url":"https://api.github.com/users/HackYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/HackYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/HackYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackYourFuture/subscriptions","organizations_url":"https://api.github.com/users/HackYourFuture/orgs","repos_url":"https://api.github.com/users/HackYourFuture/repos","events_url":"https://api.github.com/users/HackYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/HackYourFuture/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HackYourFuture/React","description":"Specifications React Module","fork":false,"url":"https://api.github.com/repos/HackYourFuture/React","forks_url":"https://api.github.com/repos/HackYourFuture/React/forks","keys_url":"https://api.github.com/repos/HackYourFuture/React/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HackYourFuture/React/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HackYourFuture/React/teams","hooks_url":"https://api.github.com/repos/HackYourFuture/React/hooks","issue_events_url":"https://api.github.com/repos/HackYourFuture/React/issues/events{/number}","events_url":"https://api.github.com/repos/HackYourFuture/React/events","assignees_url":"https://api.github.com/repos/HackYourFuture/React/assignees{/user}","branches_url":"https://api.github.com/repos/HackYourFuture/React/branches{/branch}","tags_url":"https://api.github.com/repos/HackYourFuture/React/tags","blobs_url":"https://api.github.com/repos/HackYourFuture/React/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HackYourFuture/React/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HackYourFuture/React/git/refs{/sha}","trees_url":"https://api.github.com/repos/HackYourFuture/React/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HackYourFuture/React/statuses/{sha}","languages_url":"https://api.github.com/repos/HackYourFuture/React/languages","stargazers_url":"https://api.github.com/repos/HackYourFuture/React/stargazers","contributors_url":"https://api.github.com/repos/HackYourFuture/React/contributors","subscribers_url":"https://api.github.com/repos/HackYourFuture/React/subscribers","subscription_url":"https://api.github.com/repos/HackYourFuture/React/subscription","commits_url":"https://api.github.com/repos/HackYourFuture/React/commits{/sha}","git_commits_url":"https://api.github.com/repos/HackYourFuture/React/git/commits{/sha}","comments_url":"https://api.github.com/repos/HackYourFuture/React/comments{/number}","issue_comment_url":"https://api.github.com/repos/HackYourFuture/React/issues/comments{/number}","contents_url":"https://api.github.com/repos/HackYourFuture/React/contents/{+path}","compare_url":"https://api.github.com/repos/HackYourFuture/React/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HackYourFuture/React/merges","archive_url":"https://api.github.com/repos/HackYourFuture/React/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HackYourFuture/React/downloads","issues_url":"https://api.github.com/repos/HackYourFuture/React/issues{/number}","pulls_url":"https://api.github.com/repos/HackYourFuture/React/pulls{/number}","milestones_url":"https://api.github.com/repos/HackYourFuture/React/milestones{/number}","notifications_url":"https://api.github.com/repos/HackYourFuture/React/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HackYourFuture/React/labels{/name}","releases_url":"https://api.github.com/repos/HackYourFuture/React/releases{/id}","deployments_url":"https://api.github.com/repos/HackYourFuture/React/deployments","created_at":"2017-06-06T09:58:23Z","updated_at":"2019-07-08T09:42:28Z","pushed_at":"2019-07-14T21:16:14Z","git_url":"git://github.com/HackYourFuture/React.git","ssh_url":"git@github.com:HackYourFuture/React.git","clone_url":"https://github.com/HackYourFuture/React.git","svn_url":"https://github.com/HackYourFuture/React","homepage":null,"size":1404,"stargazers_count":27,"watchers_count":27,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":37,"license":null,"forks":155,"open_issues":37,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/437"},"html":{"href":"https://github.com/HackYourFuture/React/pull/437"},"issue":{"href":"https://api.github.com/repos/HackYourFuture/React/issues/437"},"comments":{"href":"https://api.github.com/repos/HackYourFuture/React/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/HackYourFuture/React/statuses/88d25624afb744a0876dec2e6c2c0a5a8de63c89"}},"author_association":"NONE"}}
|
{
"id": 93503545,
"name": "HackYourFuture/React",
"url": "https://api.github.com/repos/HackYourFuture/React"
}
|
{
"id": 25272822,
"login": "Meno-101",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25272822?",
"url": "https://api.github.com/users/Meno-101"
}
|
{
"id": 20858568,
"login": "HackYourFuture",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20858568?",
"url": "https://api.github.com/orgs/HackYourFuture"
}
| 2019-07-15T10:34:49 |
10011466561
|
{"actor":{"display_login":"Meno-101"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/295947932","pull_request_review_id":252471021,"id":295947932,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTk0NzkzMg==","diff_hunk":"@@ -505,6 +505,8 @@ class RegionValueBuilder(var region: Region) {\n addRegionValue(t, uis.region, uis.aoff)\n }\n \n+ def addAnnotation(t: PType, a: Annotation): Unit = addAnnotation(t.virtualType, a)","path":"hail/src/main/scala/is/hail/annotations/RegionValueBuilder.scala","position":null,"original_position":4,"commit_id":"09bb42415676438ace3314fa9076985393eba4a1","original_commit_id":"6875d103e07c7aecfbd29a5344c5c590b5bacc86","user":{"login":"akotlar","id":5543229,"node_id":"MDQ6VXNlcjU1NDMyMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5543229?v=4","gravatar_id":"","url":"https://api.github.com/users/akotlar","html_url":"https://github.com/akotlar","followers_url":"https://api.github.com/users/akotlar/followers","following_url":"https://api.github.com/users/akotlar/following{/other_user}","gists_url":"https://api.github.com/users/akotlar/gists{/gist_id}","starred_url":"https://api.github.com/users/akotlar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akotlar/subscriptions","organizations_url":"https://api.github.com/users/akotlar/orgs","repos_url":"https://api.github.com/users/akotlar/repos","events_url":"https://api.github.com/users/akotlar/events{/privacy}","received_events_url":"https://api.github.com/users/akotlar/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-06-20T18:50:17Z","updated_at":"2019-06-20T18:50:17Z","html_url":"https://github.com/hail-is/hail/pull/6421#discussion_r295947932","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/6421","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/295947932"},"html":{"href":"https://github.com/hail-is/hail/pull/6421#discussion_r295947932"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6421"}},"in_reply_to_id":295935301},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/6421","id":290323229,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwMzIzMjI5","html_url":"https://github.com/hail-is/hail/pull/6421","diff_url":"https://github.com/hail-is/hail/pull/6421.diff","patch_url":"https://github.com/hail-is/hail/pull/6421.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/6421","number":6421,"state":"open","locked":false,"title":"[hail] LoadPlink ptype","user":{"login":"akotlar","id":5543229,"node_id":"MDQ6VXNlcjU1NDMyMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5543229?v=4","gravatar_id":"","url":"https://api.github.com/users/akotlar","html_url":"https://github.com/akotlar","followers_url":"https://api.github.com/users/akotlar/followers","following_url":"https://api.github.com/users/akotlar/following{/other_user}","gists_url":"https://api.github.com/users/akotlar/gists{/gist_id}","starred_url":"https://api.github.com/users/akotlar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akotlar/subscriptions","organizations_url":"https://api.github.com/users/akotlar/orgs","repos_url":"https://api.github.com/users/akotlar/repos","events_url":"https://api.github.com/users/akotlar/events{/privacy}","received_events_url":"https://api.github.com/users/akotlar/received_events","type":"User","site_admin":false},"body":"Stacked on #6416 ","created_at":"2019-06-20T18:19:30Z","updated_at":"2019-06-20T18:50:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e164a3dec92c58a3098dd8ecdb562236fe6f705e","assignee":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"assignees":[{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":724839962,"node_id":"MDU6TGFiZWw3MjQ4Mzk5NjI=","url":"https://api.github.com/repos/hail-is/hail/labels/stacked%20PR","name":"stacked PR","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/6421/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/6421/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/6421/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/09bb42415676438ace3314fa9076985393eba4a1","head":{"label":"akotlar:LoadPlink-ptype","ref":"LoadPlink-ptype","sha":"09bb42415676438ace3314fa9076985393eba4a1","user":{"login":"akotlar","id":5543229,"node_id":"MDQ6VXNlcjU1NDMyMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5543229?v=4","gravatar_id":"","url":"https://api.github.com/users/akotlar","html_url":"https://github.com/akotlar","followers_url":"https://api.github.com/users/akotlar/followers","following_url":"https://api.github.com/users/akotlar/following{/other_user}","gists_url":"https://api.github.com/users/akotlar/gists{/gist_id}","starred_url":"https://api.github.com/users/akotlar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akotlar/subscriptions","organizations_url":"https://api.github.com/users/akotlar/orgs","repos_url":"https://api.github.com/users/akotlar/repos","events_url":"https://api.github.com/users/akotlar/events{/privacy}","received_events_url":"https://api.github.com/users/akotlar/received_events","type":"User","site_admin":false},"repo":{"id":154883178,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4ODMxNzg=","name":"hail","full_name":"akotlar/hail","private":false,"owner":{"login":"akotlar","id":5543229,"node_id":"MDQ6VXNlcjU1NDMyMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5543229?v=4","gravatar_id":"","url":"https://api.github.com/users/akotlar","html_url":"https://github.com/akotlar","followers_url":"https://api.github.com/users/akotlar/followers","following_url":"https://api.github.com/users/akotlar/following{/other_user}","gists_url":"https://api.github.com/users/akotlar/gists{/gist_id}","starred_url":"https://api.github.com/users/akotlar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akotlar/subscriptions","organizations_url":"https://api.github.com/users/akotlar/orgs","repos_url":"https://api.github.com/users/akotlar/repos","events_url":"https://api.github.com/users/akotlar/events{/privacy}","received_events_url":"https://api.github.com/users/akotlar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/akotlar/hail","description":"Scalable genomic data analysis.","fork":true,"url":"https://api.github.com/repos/akotlar/hail","forks_url":"https://api.github.com/repos/akotlar/hail/forks","keys_url":"https://api.github.com/repos/akotlar/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akotlar/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akotlar/hail/teams","hooks_url":"https://api.github.com/repos/akotlar/hail/hooks","issue_events_url":"https://api.github.com/repos/akotlar/hail/issues/events{/number}","events_url":"https://api.github.com/repos/akotlar/hail/events","assignees_url":"https://api.github.com/repos/akotlar/hail/assignees{/user}","branches_url":"https://api.github.com/repos/akotlar/hail/branches{/branch}","tags_url":"https://api.github.com/repos/akotlar/hail/tags","blobs_url":"https://api.github.com/repos/akotlar/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akotlar/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akotlar/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/akotlar/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akotlar/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/akotlar/hail/languages","stargazers_url":"https://api.github.com/repos/akotlar/hail/stargazers","contributors_url":"https://api.github.com/repos/akotlar/hail/contributors","subscribers_url":"https://api.github.com/repos/akotlar/hail/subscribers","subscription_url":"https://api.github.com/repos/akotlar/hail/subscription","commits_url":"https://api.github.com/repos/akotlar/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/akotlar/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/akotlar/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/akotlar/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/akotlar/hail/contents/{+path}","compare_url":"https://api.github.com/repos/akotlar/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akotlar/hail/merges","archive_url":"https://api.github.com/repos/akotlar/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akotlar/hail/downloads","issues_url":"https://api.github.com/repos/akotlar/hail/issues{/number}","pulls_url":"https://api.github.com/repos/akotlar/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/akotlar/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/akotlar/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akotlar/hail/labels{/name}","releases_url":"https://api.github.com/repos/akotlar/hail/releases{/id}","deployments_url":"https://api.github.com/repos/akotlar/hail/deployments","created_at":"2018-10-26T19:15:50Z","updated_at":"2019-01-16T16:38:48Z","pushed_at":"2019-06-20T18:49:27Z","git_url":"git://github.com/akotlar/hail.git","ssh_url":"git@github.com:akotlar/hail.git","clone_url":"https://github.com/akotlar/hail.git","svn_url":"https://github.com/akotlar/hail","homepage":"https://hail.is","size":84487,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"1ab1ce24bb270ccd11fad448fdf80ff8dfcfb99d","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","private":false,"owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2019-06-20T17:53:08Z","pushed_at":"2019-06-20T18:49:29Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":69411,"stargazers_count":531,"watchers_count":531,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":233,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":134,"open_issues":233,"watchers":531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6421"},"html":{"href":"https://github.com/hail-is/hail/pull/6421"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/6421"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/6421/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6421/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6421/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/09bb42415676438ace3314fa9076985393eba4a1"}},"author_association":"COLLABORATOR"}}
|
{
"id": 45069467,
"name": "hail-is/hail",
"url": "https://api.github.com/repos/hail-is/hail"
}
|
{
"id": 5543229,
"login": "akotlar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5543229?",
"url": "https://api.github.com/users/akotlar"
}
|
{
"id": 20861792,
"login": "hail-is",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20861792?",
"url": "https://api.github.com/orgs/hail-is"
}
| 2019-06-20T18:50:17 |
9863211517
|
{"actor":{"display_login":"akotlar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/360849361","pull_request_review_id":335812967,"id":360849361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MDg0OTM2MQ==","diff_hunk":"@@ -58,6 +58,31 @@\n \n docker = aiodocker.Docker()\n \n+port_allocator = None\n+\n+worker = None\n+\n+\n+class PortAllocator:\n+ def __init__(self):\n+ # random unallocated ports take from\n+ # https://stackoverflow.com/questions/10476987/best-tcp-port-number-range-for-internal-applications","path":"batch/batch/worker.py","position":12,"original_position":12,"commit_id":"d55e361410187bee0ef9bcbfe0cefcae4125d259","original_commit_id":"d55e361410187bee0ef9bcbfe0cefcae4125d259","user":{"login":"cseed","id":1244990,"node_id":"MDQ6VXNlcjEyNDQ5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"body":"Yes. I updated the link to point to the second answer.","created_at":"2019-12-23T10:59:12Z","updated_at":"2019-12-23T10:59:13Z","html_url":"https://github.com/hail-is/hail/pull/7723#discussion_r360849361","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/7723","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/360849361"},"html":{"href":"https://github.com/hail-is/hail/pull/7723#discussion_r360849361"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/7723"}},"in_reply_to_id":358396576},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/7723","id":352900796,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyOTAwNzk2","html_url":"https://github.com/hail-is/hail/pull/7723","diff_url":"https://github.com/hail-is/hail/pull/7723.diff","patch_url":"https://github.com/hail-is/hail/pull/7723.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/7723","number":7723,"state":"open","locked":false,"title":"[batch] allow jobs to request a port","user":{"login":"cseed","id":1244990,"node_id":"MDQ6VXNlcjEyNDQ5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"body":"This is for the batch callback test, so I can make test_batch a direct pod.","created_at":"2019-12-13T14:08:49Z","updated_at":"2019-12-23T10:59:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"623c11965cbf8e5df32539462d8f67c3a6fc989c","assignee":{"login":"danking","id":106194,"node_id":"MDQ6VXNlcjEwNjE5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"assignees":[{"login":"danking","id":106194,"node_id":"MDQ6VXNlcjEwNjE5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/7723/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/7723/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/7723/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/d55e361410187bee0ef9bcbfe0cefcae4125d259","head":{"label":"cseed:batch-port","ref":"batch-port","sha":"d55e361410187bee0ef9bcbfe0cefcae4125d259","user":{"login":"cseed","id":1244990,"node_id":"MDQ6VXNlcjEyNDQ5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"repo":{"id":64697338,"node_id":"MDEwOlJlcG9zaXRvcnk2NDY5NzMzOA==","name":"hail","full_name":"cseed/hail","private":false,"owner":{"login":"cseed","id":1244990,"node_id":"MDQ6VXNlcjEyNDQ5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cseed/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/cseed/hail","forks_url":"https://api.github.com/repos/cseed/hail/forks","keys_url":"https://api.github.com/repos/cseed/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cseed/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cseed/hail/teams","hooks_url":"https://api.github.com/repos/cseed/hail/hooks","issue_events_url":"https://api.github.com/repos/cseed/hail/issues/events{/number}","events_url":"https://api.github.com/repos/cseed/hail/events","assignees_url":"https://api.github.com/repos/cseed/hail/assignees{/user}","branches_url":"https://api.github.com/repos/cseed/hail/branches{/branch}","tags_url":"https://api.github.com/repos/cseed/hail/tags","blobs_url":"https://api.github.com/repos/cseed/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cseed/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cseed/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/cseed/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cseed/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/cseed/hail/languages","stargazers_url":"https://api.github.com/repos/cseed/hail/stargazers","contributors_url":"https://api.github.com/repos/cseed/hail/contributors","subscribers_url":"https://api.github.com/repos/cseed/hail/subscribers","subscription_url":"https://api.github.com/repos/cseed/hail/subscription","commits_url":"https://api.github.com/repos/cseed/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/cseed/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/cseed/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/cseed/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/cseed/hail/contents/{+path}","compare_url":"https://api.github.com/repos/cseed/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cseed/hail/merges","archive_url":"https://api.github.com/repos/cseed/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cseed/hail/downloads","issues_url":"https://api.github.com/repos/cseed/hail/issues{/number}","pulls_url":"https://api.github.com/repos/cseed/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/cseed/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/cseed/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cseed/hail/labels{/name}","releases_url":"https://api.github.com/repos/cseed/hail/releases{/id}","deployments_url":"https://api.github.com/repos/cseed/hail/deployments","created_at":"2016-08-01T19:57:20Z","updated_at":"2019-12-13T09:32:40Z","pushed_at":"2019-12-14T06:56:05Z","git_url":"git://github.com/cseed/hail.git","ssh_url":"git@github.com:cseed/hail.git","clone_url":"https://github.com/cseed/hail.git","svn_url":"https://github.com/cseed/hail","homepage":"","size":103060,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"9b7031ca1877ade4890b92e1c5492162c9cefac9","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","private":false,"owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2019-12-22T23:49:46Z","pushed_at":"2019-12-22T23:49:43Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":78024,"stargazers_count":583,"watchers_count":583,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":297,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":154,"open_issues":297,"watchers":583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/7723"},"html":{"href":"https://github.com/hail-is/hail/pull/7723"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/7723"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/7723/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/7723/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/7723/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/d55e361410187bee0ef9bcbfe0cefcae4125d259"}},"author_association":"COLLABORATOR"}}
|
{
"id": 45069467,
"name": "hail-is/hail",
"url": "https://api.github.com/repos/hail-is/hail"
}
|
{
"id": 1244990,
"login": "cseed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1244990?",
"url": "https://api.github.com/users/cseed"
}
|
{
"id": 20861792,
"login": "hail-is",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20861792?",
"url": "https://api.github.com/orgs/hail-is"
}
| 2019-12-23T10:59:12 |
11146902990
|
{"actor":{"display_login":"cseed"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/264693374","pull_request_review_id":213407762,"id":264693374,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDY5MzM3NA==","diff_hunk":"@@ -1404,6 +1448,17 @@ struct C10_API TensorImpl : public c10::intrusive_ptr_target {\n // and its subclasses to find which fields are copied by value.\n bool allow_tensor_metadata_change_ = true;\n \n+ // An opaque handle `opaque_handle_` allows customized data layout other than the default\n+ // strided layout. A valid opaque handle manages the tensor storage by itself so the default\n+ // `storage_` is never initialized and getting data pointer from the default `storage_`\n+ // would fail. Metadata like device, dtype and dims can be queried like a normal tensor with\n+ // strided layout but cannot be changed. Call to `is_contiguous()` always returns false\n+ // since \"contiguous\" is not well-defined for a customized layout.\n+ //\n+ // Following invariant holds when `opaque_handle_` is valid:\n+ // `!is_contiguous() && !storage_initialized() && !allow_tensor_metadata_change()`\n+ c10::intrusive_ptr<c10::intrusive_ptr_target> opaque_handle_;","path":"c10/core/TensorImpl.h","position":222,"original_position":222,"commit_id":"14adb84b4d80498202e5cbea34ff134d7730827a","original_commit_id":"5439bd58f032f26f435d4ddc3cb6cc41ae9dd18f","user":{"login":"jgong5","id":8359223,"node_id":"MDQ6VXNlcjgzNTkyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8359223?v=4","gravatar_id":"","url":"https://api.github.com/users/jgong5","html_url":"https://github.com/jgong5","followers_url":"https://api.github.com/users/jgong5/followers","following_url":"https://api.github.com/users/jgong5/following{/other_user}","gists_url":"https://api.github.com/users/jgong5/gists{/gist_id}","starred_url":"https://api.github.com/users/jgong5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgong5/subscriptions","organizations_url":"https://api.github.com/users/jgong5/orgs","repos_url":"https://api.github.com/users/jgong5/repos","events_url":"https://api.github.com/users/jgong5/events{/privacy}","received_events_url":"https://api.github.com/users/jgong5/received_events","type":"User","site_admin":false},"body":"> does it need to be a proper intrusive_ptr? (including refcounting)\r\n\r\n@dzhulgakov It is required to support the semantics of `shallow_copy_and_detach` which clones TensorImpl while shares the storage or opaque_handle.","created_at":"2019-03-12T14:02:13Z","updated_at":"2019-03-12T14:02:13Z","html_url":"https://github.com/pytorch/pytorch/pull/17748#discussion_r264693374","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/17748","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/264693374"},"html":{"href":"https://github.com/pytorch/pytorch/pull/17748#discussion_r264693374"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/17748"}},"in_reply_to_id":264530686},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/17748","id":259135041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MTM1MDQx","html_url":"https://github.com/pytorch/pytorch/pull/17748","diff_url":"https://github.com/pytorch/pytorch/pull/17748.diff","patch_url":"https://github.com/pytorch/pytorch/pull/17748.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/17748","number":17748,"state":"open","locked":false,"title":"Add MKL-DNN Tensor","user":{"login":"jgong5","id":8359223,"node_id":"MDQ6VXNlcjgzNTkyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8359223?v=4","gravatar_id":"","url":"https://api.github.com/users/jgong5","html_url":"https://github.com/jgong5","followers_url":"https://api.github.com/users/jgong5/followers","following_url":"https://api.github.com/users/jgong5/following{/other_user}","gists_url":"https://api.github.com/users/jgong5/gists{/gist_id}","starred_url":"https://api.github.com/users/jgong5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgong5/subscriptions","organizations_url":"https://api.github.com/users/jgong5/orgs","repos_url":"https://api.github.com/users/jgong5/repos","events_url":"https://api.github.com/users/jgong5/events{/privacy}","received_events_url":"https://api.github.com/users/jgong5/received_events","type":"User","site_admin":false},"body":"This is a minimalist PR to add MKL-DNN tensor per discussion from Github issue: https://github.com/pytorch/pytorch/issues/16038\r\n\r\nChanges include:\r\n1. An opaque handle is added to `TensorImpl`, i.e. `TensorImpl::opaque_handle_`. It allows customized data layout other than the default strided layout. A valid opaque handle manages the tensor storage by itself so the default `storage_` is never initialized and getting data pointer from the default `storage_` would fail. Metadata like device, dtype and dims can be queried like a normal tensor with strided layout but cannot be changed. Call to `is_contiguous()` always returns false since \"contiguous\" is not well-defined for a customized layout.\r\n2. A new \"Mkldnn\" opaque layout is added.\r\n3. MKL-DNN tensor is added with a new \"Mkldnn\" layout via MKLDNNHandle plugged into TensorImpl::opaque_handle_, similar to Sparse tensor. Now it only supports CPU device (with tensor id MkldnnCPU) and fp32 data type.\r\n4. On Pytorch frontend, conversion method \"to_mkldnn\" is added to convert from strided CPU tensor to MKL-DNN tensor, similar to \"to_sparse\"call. Reuse \"to_dense\" to convert back. Corresponding backward conversions are also added.\r\n4. A simple test case is added to test the conversion and the query of tensor device, dtype and dim info.\r\n\r\nOps with MKL-DNN tensor will be supported in following-up PRs to speed up imperative path.","created_at":"2019-03-07T14:30:35Z","updated_at":"2019-03-12T14:02:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88560b24d411611f5e38ef8a78f9c90bdd115ad8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/17748/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/17748/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/17748/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/14adb84b4d80498202e5cbea34ff134d7730827a","head":{"label":"jgong5:mkldnn_tensor_dev","ref":"mkldnn_tensor_dev","sha":"14adb84b4d80498202e5cbea34ff134d7730827a","user":{"login":"jgong5","id":8359223,"node_id":"MDQ6VXNlcjgzNTkyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8359223?v=4","gravatar_id":"","url":"https://api.github.com/users/jgong5","html_url":"https://github.com/jgong5","followers_url":"https://api.github.com/users/jgong5/followers","following_url":"https://api.github.com/users/jgong5/following{/other_user}","gists_url":"https://api.github.com/users/jgong5/gists{/gist_id}","starred_url":"https://api.github.com/users/jgong5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgong5/subscriptions","organizations_url":"https://api.github.com/users/jgong5/orgs","repos_url":"https://api.github.com/users/jgong5/repos","events_url":"https://api.github.com/users/jgong5/events{/privacy}","received_events_url":"https://api.github.com/users/jgong5/received_events","type":"User","site_admin":false},"repo":{"id":143240128,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyNDAxMjg=","name":"pytorch","full_name":"jgong5/pytorch","private":false,"owner":{"login":"jgong5","id":8359223,"node_id":"MDQ6VXNlcjgzNTkyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8359223?v=4","gravatar_id":"","url":"https://api.github.com/users/jgong5","html_url":"https://github.com/jgong5","followers_url":"https://api.github.com/users/jgong5/followers","following_url":"https://api.github.com/users/jgong5/following{/other_user}","gists_url":"https://api.github.com/users/jgong5/gists{/gist_id}","starred_url":"https://api.github.com/users/jgong5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgong5/subscriptions","organizations_url":"https://api.github.com/users/jgong5/orgs","repos_url":"https://api.github.com/users/jgong5/repos","events_url":"https://api.github.com/users/jgong5/events{/privacy}","received_events_url":"https://api.github.com/users/jgong5/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jgong5/pytorch","description":"Tensors and Dynamic neural networks in Python with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/jgong5/pytorch","forks_url":"https://api.github.com/repos/jgong5/pytorch/forks","keys_url":"https://api.github.com/repos/jgong5/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgong5/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgong5/pytorch/teams","hooks_url":"https://api.github.com/repos/jgong5/pytorch/hooks","issue_events_url":"https://api.github.com/repos/jgong5/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/jgong5/pytorch/events","assignees_url":"https://api.github.com/repos/jgong5/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/jgong5/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/jgong5/pytorch/tags","blobs_url":"https://api.github.com/repos/jgong5/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgong5/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgong5/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgong5/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgong5/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/jgong5/pytorch/languages","stargazers_url":"https://api.github.com/repos/jgong5/pytorch/stargazers","contributors_url":"https://api.github.com/repos/jgong5/pytorch/contributors","subscribers_url":"https://api.github.com/repos/jgong5/pytorch/subscribers","subscription_url":"https://api.github.com/repos/jgong5/pytorch/subscription","commits_url":"https://api.github.com/repos/jgong5/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgong5/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgong5/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgong5/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgong5/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/jgong5/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgong5/pytorch/merges","archive_url":"https://api.github.com/repos/jgong5/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgong5/pytorch/downloads","issues_url":"https://api.github.com/repos/jgong5/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/jgong5/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/jgong5/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/jgong5/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgong5/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/jgong5/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/jgong5/pytorch/deployments","created_at":"2018-08-02T03:57:43Z","updated_at":"2018-08-09T07:56:00Z","pushed_at":"2019-03-12T07:00:41Z","git_url":"git://github.com/jgong5/pytorch.git","ssh_url":"git@github.com:jgong5/pytorch.git","clone_url":"https://github.com/jgong5/pytorch.git","svn_url":"https://github.com/jgong5/pytorch","homepage":"http://pytorch.org","size":106075,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"3f1d0ee5d5f48bb0fbef433a61cef0be9ad40a76","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2019-03-12T13:37:15Z","pushed_at":"2019-03-12T13:34:50Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"https://pytorch.org","size":109037,"stargazers_count":25685,"watchers_count":25685,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6093,"mirror_url":null,"archived":false,"open_issues_count":2678,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6093,"open_issues":2678,"watchers":25685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/17748"},"html":{"href":"https://github.com/pytorch/pytorch/pull/17748"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/17748"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/17748/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/17748/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/17748/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/14adb84b4d80498202e5cbea34ff134d7730827a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 65600975,
"name": "pytorch/pytorch",
"url": "https://api.github.com/repos/pytorch/pytorch"
}
|
{
"id": 8359223,
"login": "jgong5",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8359223?",
"url": "https://api.github.com/users/jgong5"
}
|
{
"id": 21003710,
"login": "pytorch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21003710?",
"url": "https://api.github.com/orgs/pytorch"
}
| 2019-03-12T14:02:13 |
9226898680
|
{"actor":{"display_login":"jgong5"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/334167899","pull_request_review_id":300918867,"id":334167899,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDE2Nzg5OQ==","diff_hunk":"@@ -1695,18 +1695,25 @@ def merge_dicts(*dicts):\n r\"\"\"\n .. function:: div(input, other, out=None) -> Tensor\n \n-Divides each element of the input :attr:`input` with the scalar :attr:`other`\n-and returns a new resulting tensor.\n+Divides each element of the input ``input`` with the scalar ``other`` and\n+returns a new resulting tensor.\n \n .. math::\n- \\text{out}_i = \\frac{\\text{input}_i}{\\text{other}}\n+ \\text{{out}}_i = \\frac{{\\text{{input}}_i}}{{\\text{{other}}}}\n \n-If :attr:`input` is of type `FloatTensor` or `DoubleTensor`, :attr:`other`\n-should be a real number, otherwise it should be an integer\n+If the :class:`torch.dtype` of ``input`` and ``other`` differ, the\n+:class:`torch.dtype` of the result tensor is determined following rules\n+described in the type promotion :ref:`documentation <type-promotion-doc>`. If\n+``out`` is specified, the result must be :ref:`castable <type-promotion-doc>`\n+to the :class:`torch.dtype` of the specified output tensor. If ``input`` is\n+integral, and ``other`` is integral and zero, the behavior is undefined and\n+arbitrary.","path":"torch/_torch_docs.py","position":null,"original_position":21,"commit_id":"5731f9e872931118655805d51959affa8534093f","original_commit_id":"9c1dbddeed274c899adfc6d3017912b6ebc5592e","user":{"login":"xuhdev","id":325476,"node_id":"MDQ6VXNlcjMyNTQ3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/325476?v=4","gravatar_id":"","url":"https://api.github.com/users/xuhdev","html_url":"https://github.com/xuhdev","followers_url":"https://api.github.com/users/xuhdev/followers","following_url":"https://api.github.com/users/xuhdev/following{/other_user}","gists_url":"https://api.github.com/users/xuhdev/gists{/gist_id}","starred_url":"https://api.github.com/users/xuhdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuhdev/subscriptions","organizations_url":"https://api.github.com/users/xuhdev/orgs","repos_url":"https://api.github.com/users/xuhdev/repos","events_url":"https://api.github.com/users/xuhdev/events{/privacy}","received_events_url":"https://api.github.com/users/xuhdev/received_events","type":"User","site_admin":false},"body":"Updated!","created_at":"2019-10-11T20:46:12Z","updated_at":"2019-10-11T20:46:12Z","html_url":"https://github.com/pytorch/pytorch/pull/25968#discussion_r334167899","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/25968","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/334167899"},"html":{"href":"https://github.com/pytorch/pytorch/pull/25968#discussion_r334167899"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/25968"}},"in_reply_to_id":334154734},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/25968","id":316225257,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2MjI1MjU3","html_url":"https://github.com/pytorch/pytorch/pull/25968","diff_url":"https://github.com/pytorch/pytorch/pull/25968.diff","patch_url":"https://github.com/pytorch/pytorch/pull/25968.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/25968","number":25968,"state":"open","locked":false,"title":"Clarify that when the divisor in div is zero and the dividend is integral, the behavior is undefined.","user":{"login":"xuhdev","id":325476,"node_id":"MDQ6VXNlcjMyNTQ3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/325476?v=4","gravatar_id":"","url":"https://api.github.com/users/xuhdev","html_url":"https://github.com/xuhdev","followers_url":"https://api.github.com/users/xuhdev/followers","following_url":"https://api.github.com/users/xuhdev/following{/other_user}","gists_url":"https://api.github.com/users/xuhdev/gists{/gist_id}","starred_url":"https://api.github.com/users/xuhdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuhdev/subscriptions","organizations_url":"https://api.github.com/users/xuhdev/orgs","repos_url":"https://api.github.com/users/xuhdev/repos","events_url":"https://api.github.com/users/xuhdev/events{/privacy}","received_events_url":"https://api.github.com/users/xuhdev/received_events","type":"User","site_admin":false},"body":"Currently when an integral tensor is divided by zero, it emits a\n\"floating point exception\" (which can be different from system to\nsystem). Clarify in the document that nothing would be guaranteed under\nthis circumstance.","created_at":"2019-09-11T00:21:03Z","updated_at":"2019-10-11T20:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98a9368357f6b68ed2a9480582231edb3f90301a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nairbv","id":582713,"node_id":"MDQ6VXNlcjU4MjcxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/582713?v=4","gravatar_id":"","url":"https://api.github.com/users/nairbv","html_url":"https://github.com/nairbv","followers_url":"https://api.github.com/users/nairbv/followers","following_url":"https://api.github.com/users/nairbv/following{/other_user}","gists_url":"https://api.github.com/users/nairbv/gists{/gist_id}","starred_url":"https://api.github.com/users/nairbv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nairbv/subscriptions","organizations_url":"https://api.github.com/users/nairbv/orgs","repos_url":"https://api.github.com/users/nairbv/repos","events_url":"https://api.github.com/users/nairbv/events{/privacy}","received_events_url":"https://api.github.com/users/nairbv/received_events","type":"User","site_admin":false},{"login":"yf225","id":4063635,"node_id":"MDQ6VXNlcjQwNjM2MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/4063635?v=4","gravatar_id":"","url":"https://api.github.com/users/yf225","html_url":"https://github.com/yf225","followers_url":"https://api.github.com/users/yf225/followers","following_url":"https://api.github.com/users/yf225/following{/other_user}","gists_url":"https://api.github.com/users/yf225/gists{/gist_id}","starred_url":"https://api.github.com/users/yf225/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yf225/subscriptions","organizations_url":"https://api.github.com/users/yf225/orgs","repos_url":"https://api.github.com/users/yf225/repos","events_url":"https://api.github.com/users/yf225/events{/privacy}","received_events_url":"https://api.github.com/users/yf225/received_events","type":"User","site_admin":false},{"login":"izdeby","id":47012416,"node_id":"MDQ6VXNlcjQ3MDEyNDE2","avatar_url":"https://avatars0.githubusercontent.com/u/47012416?v=4","gravatar_id":"","url":"https://api.github.com/users/izdeby","html_url":"https://github.com/izdeby","followers_url":"https://api.github.com/users/izdeby/followers","following_url":"https://api.github.com/users/izdeby/following{/other_user}","gists_url":"https://api.github.com/users/izdeby/gists{/gist_id}","starred_url":"https://api.github.com/users/izdeby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izdeby/subscriptions","organizations_url":"https://api.github.com/users/izdeby/orgs","repos_url":"https://api.github.com/users/izdeby/repos","events_url":"https://api.github.com/users/izdeby/events{/privacy}","received_events_url":"https://api.github.com/users/izdeby/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":897287230,"node_id":"MDU6TGFiZWw4OTcyODcyMzA=","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20docs","name":"module: docs","color":"f7e101","default":false},{"id":1392590051,"node_id":"MDU6TGFiZWwxMzkyNTkwMDUx","url":"https://api.github.com/repos/pytorch/pytorch/labels/open%20source","name":"open source","color":"ededed","default":false},{"id":1301347167,"node_id":"MDU6TGFiZWwxMzAxMzQ3MTY3","url":"https://api.github.com/repos/pytorch/pytorch/labels/triaged","name":"triaged","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/25968/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/25968/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/25968/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/5731f9e872931118655805d51959affa8534093f","head":{"label":"xuhdev:div-int-zero","ref":"div-int-zero","sha":"5731f9e872931118655805d51959affa8534093f","user":{"login":"xuhdev","id":325476,"node_id":"MDQ6VXNlcjMyNTQ3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/325476?v=4","gravatar_id":"","url":"https://api.github.com/users/xuhdev","html_url":"https://github.com/xuhdev","followers_url":"https://api.github.com/users/xuhdev/followers","following_url":"https://api.github.com/users/xuhdev/following{/other_user}","gists_url":"https://api.github.com/users/xuhdev/gists{/gist_id}","starred_url":"https://api.github.com/users/xuhdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuhdev/subscriptions","organizations_url":"https://api.github.com/users/xuhdev/orgs","repos_url":"https://api.github.com/users/xuhdev/repos","events_url":"https://api.github.com/users/xuhdev/events{/privacy}","received_events_url":"https://api.github.com/users/xuhdev/received_events","type":"User","site_admin":false},"repo":{"id":149419235,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0MTkyMzU=","name":"pytorch","full_name":"xuhdev/pytorch","private":false,"owner":{"login":"xuhdev","id":325476,"node_id":"MDQ6VXNlcjMyNTQ3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/325476?v=4","gravatar_id":"","url":"https://api.github.com/users/xuhdev","html_url":"https://github.com/xuhdev","followers_url":"https://api.github.com/users/xuhdev/followers","following_url":"https://api.github.com/users/xuhdev/following{/other_user}","gists_url":"https://api.github.com/users/xuhdev/gists{/gist_id}","starred_url":"https://api.github.com/users/xuhdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuhdev/subscriptions","organizations_url":"https://api.github.com/users/xuhdev/orgs","repos_url":"https://api.github.com/users/xuhdev/repos","events_url":"https://api.github.com/users/xuhdev/events{/privacy}","received_events_url":"https://api.github.com/users/xuhdev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xuhdev/pytorch","description":"Tensors and Dynamic neural networks in Python with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/xuhdev/pytorch","forks_url":"https://api.github.com/repos/xuhdev/pytorch/forks","keys_url":"https://api.github.com/repos/xuhdev/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuhdev/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuhdev/pytorch/teams","hooks_url":"https://api.github.com/repos/xuhdev/pytorch/hooks","issue_events_url":"https://api.github.com/repos/xuhdev/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/xuhdev/pytorch/events","assignees_url":"https://api.github.com/repos/xuhdev/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/xuhdev/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/xuhdev/pytorch/tags","blobs_url":"https://api.github.com/repos/xuhdev/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuhdev/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuhdev/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuhdev/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuhdev/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/xuhdev/pytorch/languages","stargazers_url":"https://api.github.com/repos/xuhdev/pytorch/stargazers","contributors_url":"https://api.github.com/repos/xuhdev/pytorch/contributors","subscribers_url":"https://api.github.com/repos/xuhdev/pytorch/subscribers","subscription_url":"https://api.github.com/repos/xuhdev/pytorch/subscription","commits_url":"https://api.github.com/repos/xuhdev/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuhdev/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuhdev/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuhdev/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuhdev/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/xuhdev/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuhdev/pytorch/merges","archive_url":"https://api.github.com/repos/xuhdev/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuhdev/pytorch/downloads","issues_url":"https://api.github.com/repos/xuhdev/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/xuhdev/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/xuhdev/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/xuhdev/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuhdev/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/xuhdev/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/xuhdev/pytorch/deployments","created_at":"2018-09-19T08:39:42Z","updated_at":"2019-09-05T02:19:34Z","pushed_at":"2019-10-11T20:46:01Z","git_url":"git://github.com/xuhdev/pytorch.git","ssh_url":"git@github.com:xuhdev/pytorch.git","clone_url":"https://github.com/xuhdev/pytorch.git","svn_url":"https://github.com/xuhdev/pytorch","homepage":"http://pytorch.org","size":146977,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"7135f7c263f3075ffb0f1b926b444dfa0870fab5","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2019-10-11T20:41:59Z","pushed_at":"2019-10-11T20:46:04Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"https://pytorch.org","size":246198,"stargazers_count":32338,"watchers_count":32338,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7981,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4367,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7981,"open_issues":4367,"watchers":32338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/25968"},"html":{"href":"https://github.com/pytorch/pytorch/pull/25968"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/25968"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/25968/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/25968/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/25968/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/5731f9e872931118655805d51959affa8534093f"}},"author_association":"MEMBER"}}
|
{
"id": 65600975,
"name": "pytorch/pytorch",
"url": "https://api.github.com/repos/pytorch/pytorch"
}
|
{
"id": 325476,
"login": "xuhdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/325476?",
"url": "https://api.github.com/users/xuhdev"
}
|
{
"id": 21003710,
"login": "pytorch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21003710?",
"url": "https://api.github.com/orgs/pytorch"
}
| 2019-10-11T20:46:12 |
10614081746
|
{"actor":{"display_login":"xuhdev"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/311346701","pull_request_review_id":271702318,"id":311346701,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTM0NjcwMQ==","diff_hunk":"@@ -0,0 +1,227 @@\n+#include <torch/csrc/distributed/rpc/ProcessGroupAgent.h>\n+\n+namespace torch {\n+namespace distributed {\n+namespace rpc {\n+\n+namespace {\n+\n+// Write the message into the given ostream\n+void serialize(const Message& message, std::ostream& os) {\n+ // We cast const void* to void* here because we need to create a tensor using\n+ // that memory space. If is fine as that tensor stays function-local, and will\n+ // not be modified during its lifetime.\n+ auto payload = const_cast<void*>( // NOLINT\n+ static_cast<const void*>(message.payload().data()));\n+ auto payload_size = message.payload().size();\n+\n+ // getting tensor table from the message\n+ std::vector<torch::Tensor> tensors = message.tensors();\n+ // append payload as a tensor\n+ tensors.push_back(torch::from_blob(payload, payload_size, {torch::kChar}));\n+ // append id and type as a tensor\n+ tensors.push_back(torch::tensor(\n+ {message.id(), (int64_t) message.type()}, {torch::kInt64}\n+ ));\n+\n+ torch::save(tensors, os);","path":"torch/csrc/distributed/rpc/ProcessGroupAgent.cpp","position":27,"original_position":27,"commit_id":"919024f9ba32be66ca664dcdd3a720870ebf12c3","original_commit_id":"919024f9ba32be66ca664dcdd3a720870ebf12c3","user":{"login":"mrshenli","id":16999635,"node_id":"MDQ6VXNlcjE2OTk5NjM1","avatar_url":"https://avatars2.githubusercontent.com/u/16999635?v=4","gravatar_id":"","url":"https://api.github.com/users/mrshenli","html_url":"https://github.com/mrshenli","followers_url":"https://api.github.com/users/mrshenli/followers","following_url":"https://api.github.com/users/mrshenli/following{/other_user}","gists_url":"https://api.github.com/users/mrshenli/gists{/gist_id}","starred_url":"https://api.github.com/users/mrshenli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrshenli/subscriptions","organizations_url":"https://api.github.com/users/mrshenli/orgs","repos_url":"https://api.github.com/users/mrshenli/repos","events_url":"https://api.github.com/users/mrshenli/events{/privacy}","received_events_url":"https://api.github.com/users/mrshenli/received_events","type":"User","site_admin":false},"body":"Yep, I also learnt that from @aazzolini. I will try the new pickle API when #23241 is merged","created_at":"2019-08-07T02:29:42Z","updated_at":"2019-08-07T02:29:42Z","html_url":"https://github.com/pytorch/pytorch/pull/23228#discussion_r311346701","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/23228","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/311346701"},"html":{"href":"https://github.com/pytorch/pytorch/pull/23228#discussion_r311346701"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/23228"}},"in_reply_to_id":311318040},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/23228","id":300318443,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMzE4NDQz","html_url":"https://github.com/pytorch/pytorch/pull/23228","diff_url":"https://github.com/pytorch/pytorch/pull/23228.diff","patch_url":"https://github.com/pytorch/pytorch/pull/23228.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/23228","number":23228,"state":"closed","locked":false,"title":"sync and async torch.distributed.rpc for builtin operators","user":{"login":"mrshenli","id":16999635,"node_id":"MDQ6VXNlcjE2OTk5NjM1","avatar_url":"https://avatars2.githubusercontent.com/u/16999635?v=4","gravatar_id":"","url":"https://api.github.com/users/mrshenli","html_url":"https://github.com/mrshenli","followers_url":"https://api.github.com/users/mrshenli/followers","following_url":"https://api.github.com/users/mrshenli/following{/other_user}","gists_url":"https://api.github.com/users/mrshenli/gists{/gist_id}","starred_url":"https://api.github.com/users/mrshenli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrshenli/subscriptions","organizations_url":"https://api.github.com/users/mrshenli/orgs","repos_url":"https://api.github.com/users/mrshenli/repos","events_url":"https://api.github.com/users/mrshenli/events{/privacy}","received_events_url":"https://api.github.com/users/mrshenli/received_events","type":"User","site_admin":false},"body":"Stack from [ghstack](https://github.com/ezyang/ghstack):\n* **#23228 sync and async torch.distributed.rpc for builtin operators**\n\r\nFeatures:\r\n\r\n* sync and async RPC for builtin operators\r\n* RpcAgent API\r\n* ProcessGroupAgent implementation\r\n\r\nGoal:\r\n\r\nThis is the first PR for #23110, and there will be many followup ones. So let's focus on the overall API and code structure. Details like efficiency and error handling can be improved in future PRs.\r\n\r\n* have a minimum working and testable RPC implementation.\r\n* make sure the RpcAgent API is sufficient for future ThriftAgent and TensorPipeAgent implementation\r\n * For tensor pipe implementation, it might allocate multiple underlying communication channels with different types, and might also use streaming serialization/deserialization for large tensors. To support this requirement, the current implementation only convert a BuiltinOp into a Message which contains a byte vector and a tensor table. It is up to the RpcAgent implementation to determine how it would like to serialize a Message object.\r\n * For ThriftAgent, as Thrift has it own request/response matching solution, the Message.id is no longer necessary. Hence the id can be dropped during serialization. All it needs to do is to pass the response Message object to the Future returned by send(...).\r\n* support blocking and non-blocking RequestCallback\r\n * blocking means the callback won't return before sending out the response\r\n * non-blocking can be achieved by enqueue the `(from, request, RpcAgent&)` tuple and use a different thread to process them. That is why there is an `RpcAgent&` arg in the param list.\r\n\r\n\r\n\r\nDifferential Revision: [D15194693](https://our.internmc.facebook.com/intern/diff/D15194693/)","created_at":"2019-07-23T14:16:20Z","updated_at":"2019-08-07T02:29:42Z","closed_at":"2019-08-06T23:06:13Z","merged_at":null,"merge_commit_sha":"86ec2c7785fd98f40b159d7ca11eb1437b265240","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pietern","id":9845,"node_id":"MDQ6VXNlcjk4NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/9845?v=4","gravatar_id":"","url":"https://api.github.com/users/pietern","html_url":"https://github.com/pietern","followers_url":"https://api.github.com/users/pietern/followers","following_url":"https://api.github.com/users/pietern/following{/other_user}","gists_url":"https://api.github.com/users/pietern/gists{/gist_id}","starred_url":"https://api.github.com/users/pietern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietern/subscriptions","organizations_url":"https://api.github.com/users/pietern/orgs","repos_url":"https://api.github.com/users/pietern/repos","events_url":"https://api.github.com/users/pietern/events{/privacy}","received_events_url":"https://api.github.com/users/pietern/received_events","type":"User","site_admin":false},{"login":"soumith","id":1310570,"node_id":"MDQ6VXNlcjEzMTA1NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1310570?v=4","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},{"login":"suo","id":1617424,"node_id":"MDQ6VXNlcjE2MTc0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1617424?v=4","gravatar_id":"","url":"https://api.github.com/users/suo","html_url":"https://github.com/suo","followers_url":"https://api.github.com/users/suo/followers","following_url":"https://api.github.com/users/suo/following{/other_user}","gists_url":"https://api.github.com/users/suo/gists{/gist_id}","starred_url":"https://api.github.com/users/suo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suo/subscriptions","organizations_url":"https://api.github.com/users/suo/orgs","repos_url":"https://api.github.com/users/suo/repos","events_url":"https://api.github.com/users/suo/events{/privacy}","received_events_url":"https://api.github.com/users/suo/received_events","type":"User","site_admin":false},{"login":"gchanan","id":3768583,"node_id":"MDQ6VXNlcjM3Njg1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3768583?v=4","gravatar_id":"","url":"https://api.github.com/users/gchanan","html_url":"https://github.com/gchanan","followers_url":"https://api.github.com/users/gchanan/followers","following_url":"https://api.github.com/users/gchanan/following{/other_user}","gists_url":"https://api.github.com/users/gchanan/gists{/gist_id}","starred_url":"https://api.github.com/users/gchanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchanan/subscriptions","organizations_url":"https://api.github.com/users/gchanan/orgs","repos_url":"https://api.github.com/users/gchanan/repos","events_url":"https://api.github.com/users/gchanan/events{/privacy}","received_events_url":"https://api.github.com/users/gchanan/received_events","type":"User","site_admin":false},{"login":"gqchen","id":5759674,"node_id":"MDQ6VXNlcjU3NTk2NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5759674?v=4","gravatar_id":"","url":"https://api.github.com/users/gqchen","html_url":"https://github.com/gqchen","followers_url":"https://api.github.com/users/gqchen/followers","following_url":"https://api.github.com/users/gqchen/following{/other_user}","gists_url":"https://api.github.com/users/gqchen/gists{/gist_id}","starred_url":"https://api.github.com/users/gqchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gqchen/subscriptions","organizations_url":"https://api.github.com/users/gqchen/orgs","repos_url":"https://api.github.com/users/gqchen/repos","events_url":"https://api.github.com/users/gqchen/events{/privacy}","received_events_url":"https://api.github.com/users/gqchen/received_events","type":"User","site_admin":false},{"login":"bddppq","id":9300575,"node_id":"MDQ6VXNlcjkzMDA1NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9300575?v=4","gravatar_id":"","url":"https://api.github.com/users/bddppq","html_url":"https://github.com/bddppq","followers_url":"https://api.github.com/users/bddppq/followers","following_url":"https://api.github.com/users/bddppq/following{/other_user}","gists_url":"https://api.github.com/users/bddppq/gists{/gist_id}","starred_url":"https://api.github.com/users/bddppq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bddppq/subscriptions","organizations_url":"https://api.github.com/users/bddppq/orgs","repos_url":"https://api.github.com/users/bddppq/repos","events_url":"https://api.github.com/users/bddppq/events{/privacy}","received_events_url":"https://api.github.com/users/bddppq/received_events","type":"User","site_admin":false},{"login":"dzhulgakov","id":17890620,"node_id":"MDQ6VXNlcjE3ODkwNjIw","avatar_url":"https://avatars2.githubusercontent.com/u/17890620?v=4","gravatar_id":"","url":"https://api.github.com/users/dzhulgakov","html_url":"https://github.com/dzhulgakov","followers_url":"https://api.github.com/users/dzhulgakov/followers","following_url":"https://api.github.com/users/dzhulgakov/following{/other_user}","gists_url":"https://api.github.com/users/dzhulgakov/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhulgakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhulgakov/subscriptions","organizations_url":"https://api.github.com/users/dzhulgakov/orgs","repos_url":"https://api.github.com/users/dzhulgakov/repos","events_url":"https://api.github.com/users/dzhulgakov/events{/privacy}","received_events_url":"https://api.github.com/users/dzhulgakov/received_events","type":"User","site_admin":false},{"login":"aazzolini","id":37222419,"node_id":"MDQ6VXNlcjM3MjIyNDE5","avatar_url":"https://avatars2.githubusercontent.com/u/37222419?v=4","gravatar_id":"","url":"https://api.github.com/users/aazzolini","html_url":"https://github.com/aazzolini","followers_url":"https://api.github.com/users/aazzolini/followers","following_url":"https://api.github.com/users/aazzolini/following{/other_user}","gists_url":"https://api.github.com/users/aazzolini/gists{/gist_id}","starred_url":"https://api.github.com/users/aazzolini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aazzolini/subscriptions","organizations_url":"https://api.github.com/users/aazzolini/orgs","repos_url":"https://api.github.com/users/aazzolini/repos","events_url":"https://api.github.com/users/aazzolini/events{/privacy}","received_events_url":"https://api.github.com/users/aazzolini/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":890282107,"node_id":"MDU6TGFiZWw4OTAyODIxMDc=","url":"https://api.github.com/repos/pytorch/pytorch/labels/caffe2","name":"caffe2","color":"210aa8","default":false},{"id":778855555,"node_id":"MDU6TGFiZWw3Nzg4NTU1NTU=","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20build","name":"module: build","color":"f7e101","default":false},{"id":679953883,"node_id":"MDU6TGFiZWw2Nzk5NTM4ODM=","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20distributed","name":"module: distributed","color":"f7e101","default":false},{"id":912691507,"node_id":"MDU6TGFiZWw5MTI2OTE1MDc=","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20internals","name":"module: internals","color":"f7e101","default":false},{"id":1311350199,"node_id":"MDU6TGFiZWwxMzExMzUwMTk5","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20pybind","name":"module: pybind","color":"f7e101","default":false},{"id":1300933336,"node_id":"MDU6TGFiZWwxMzAwOTMzMzM2","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20tests","name":"module: tests","color":"f7e101","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/23228/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/23228/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/23228/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/919024f9ba32be66ca664dcdd3a720870ebf12c3","head":{"label":"pytorch:gh/mrshenli/7/head","ref":"gh/mrshenli/7/head","sha":"919024f9ba32be66ca664dcdd3a720870ebf12c3","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2019-08-07T01:14:50Z","pushed_at":"2019-08-07T02:20:58Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"https://pytorch.org","size":144903,"stargazers_count":30526,"watchers_count":30526,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7469,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3461,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7469,"open_issues":3461,"watchers":30526,"default_branch":"master"}},"base":{"label":"pytorch:gh/mrshenli/7/base","ref":"gh/mrshenli/7/base","sha":"40f0b1c844788f5e99de338553eb711d226c0638","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2019-08-07T01:14:50Z","pushed_at":"2019-08-07T02:20:58Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"https://pytorch.org","size":144903,"stargazers_count":30526,"watchers_count":30526,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7469,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3461,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7469,"open_issues":3461,"watchers":30526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/23228"},"html":{"href":"https://github.com/pytorch/pytorch/pull/23228"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/23228"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/23228/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/23228/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/23228/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/919024f9ba32be66ca664dcdd3a720870ebf12c3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 65600975,
"name": "pytorch/pytorch",
"url": "https://api.github.com/repos/pytorch/pytorch"
}
|
{
"id": 16999635,
"login": "mrshenli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16999635?",
"url": "https://api.github.com/users/mrshenli"
}
|
{
"id": 21003710,
"login": "pytorch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21003710?",
"url": "https://api.github.com/orgs/pytorch"
}
| 2019-08-07T02:29:42 |
10161417176
|
{"actor":{"display_login":"mrshenli"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/277741212","pull_request_review_id":229631495,"id":277741212,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Nzc0MTIxMg==","diff_hunk":"@@ -435,6 +435,11 @@\n \n - func: conv_transpose3d(Tensor input, Tensor weight, Tensor? bias=None, int[3] stride=1, int[3] padding=0, int[3] output_padding=0, int groups=1, int[3] dilation=1) -> Tensor\n \n+- func: copy_(Tensor(a!) self, Tensor src, bool non_blocking=False) -> Tensor(a!)\n+ matches_jit_signature: True\n+ variants: function, method","path":"aten/src/ATen/native/native_functions.yaml","position":6,"original_position":6,"commit_id":"c288ea3a5054f791c164f29cd394859c0f38276c","original_commit_id":"c288ea3a5054f791c164f29cd394859c0f38276c","user":{"login":"gchanan","id":3768583,"node_id":"MDQ6VXNlcjM3Njg1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3768583?v=4","gravatar_id":"","url":"https://api.github.com/users/gchanan","html_url":"https://github.com/gchanan","followers_url":"https://api.github.com/users/gchanan/followers","following_url":"https://api.github.com/users/gchanan/following{/other_user}","gists_url":"https://api.github.com/users/gchanan/gists{/gist_id}","starred_url":"https://api.github.com/users/gchanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchanan/subscriptions","organizations_url":"https://api.github.com/users/gchanan/orgs","repos_url":"https://api.github.com/users/gchanan/repos","events_url":"https://api.github.com/users/gchanan/events{/privacy}","received_events_url":"https://api.github.com/users/gchanan/received_events","type":"User","site_admin":false},"body":"why is this a function? IMO we shouldn't have inplace functions.","created_at":"2019-04-23T15:34:31Z","updated_at":"2019-04-23T15:51:41Z","html_url":"https://github.com/pytorch/pytorch/pull/18972#discussion_r277741212","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/18972","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/277741212"},"html":{"href":"https://github.com/pytorch/pytorch/pull/18972#discussion_r277741212"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/18972"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/18972","id":267992456,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3OTkyNDU2","html_url":"https://github.com/pytorch/pytorch/pull/18972","diff_url":"https://github.com/pytorch/pytorch/pull/18972.diff","patch_url":"https://github.com/pytorch/pytorch/pull/18972.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/18972","number":18972,"state":"closed","locked":false,"title":"Make copy_ a native function, remove copy and copy_ from Type","user":{"login":"li-roy","id":8813817,"node_id":"MDQ6VXNlcjg4MTM4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"body":"Stack from [ghstack](https://github.com/ezyang/ghstack):\r\n* **#18972 Remove copy and copy_ special case on Type**\r\n\r\n- Make copy_ a native function\r\n- Remove copy and copy_ from Type\r\n- Changed backwards of copy to work on copy_ instead of s_copy_\r\n- Fixed logic for sparse copy (moved it from VariableTypeManual to non variable copy_, old logic in non variable copy_ was incorrect but never tested/reached)\r\n\r\nDifferential Revision: [D14816530](https://our.internmc.facebook.com/intern/diff/D14816530)","created_at":"2019-04-05T23:33:25Z","updated_at":"2019-04-23T15:51:41Z","closed_at":"2019-04-18T07:23:28Z","merged_at":null,"merge_commit_sha":"e38064b730ab48e06800565cc122f74533bf2e02","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1243252054,"node_id":"MDU6TGFiZWwxMjQzMjUyMDU0","url":"https://api.github.com/repos/pytorch/pytorch/labels/merged","name":"merged","color":"39ce72","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/18972/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/18972/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/18972/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/c288ea3a5054f791c164f29cd394859c0f38276c","head":{"label":"pytorch:gh/li-roy/4/head","ref":"gh/li-roy/4/head","sha":"c288ea3a5054f791c164f29cd394859c0f38276c","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2019-04-23T15:50:10Z","pushed_at":"2019-04-23T15:48:10Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"https://pytorch.org","size":120462,"stargazers_count":27199,"watchers_count":27199,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6475,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2914,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6475,"open_issues":2914,"watchers":27199,"default_branch":"master"}},"base":{"label":"pytorch:gh/li-roy/4/base","ref":"gh/li-roy/4/base","sha":"776fec0f9f3ea5ebd7cdd18d52e8702d81064bc7","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2019-04-23T15:50:10Z","pushed_at":"2019-04-23T15:48:10Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"https://pytorch.org","size":120462,"stargazers_count":27199,"watchers_count":27199,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6475,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2914,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6475,"open_issues":2914,"watchers":27199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/18972"},"html":{"href":"https://github.com/pytorch/pytorch/pull/18972"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/18972"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/18972/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/18972/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/18972/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/c288ea3a5054f791c164f29cd394859c0f38276c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 65600975,
"name": "pytorch/pytorch",
"url": "https://api.github.com/repos/pytorch/pytorch"
}
|
{
"id": 3768583,
"login": "gchanan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3768583?",
"url": "https://api.github.com/users/gchanan"
}
|
{
"id": 21003710,
"login": "pytorch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21003710?",
"url": "https://api.github.com/orgs/pytorch"
}
| 2019-04-23T15:34:31 |
9495131386
|
{"actor":{"display_login":"gchanan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/glow/pulls/comments/313554252","pull_request_review_id":274468711,"id":313554252,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzU1NDI1Mg==","diff_hunk":"@@ -0,0 +1,197 @@\n+/**\n+ * Copyright (c) 2017-present, Facebook, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+#include \"TorchGlowTraining.h\"\n+#include \"PyTorchFileLoader.h\"\n+#include \"glow/Exporter/ONNXModelWriter.h\"\n+#include \"glow/Importer/ONNXModelLoader.h\"\n+#include \"glow/Optimizer/GraphOptimizer/TrainingPreparation.h\"\n+#include \"glow/Support/Error.h\"\n+\n+namespace glow {\n+\n+namespace {\n+\n+bool isValidSamplesForSingleInput(const Tensor &input, const Tensor &samples) {\n+ return input.dims() == samples.dims().slice(1) &&\n+ input.getElementType() == samples.getElementType();\n+}\n+\n+bool isValidSamplesForSliceInput(const Tensor &input, const Tensor &samples) {\n+ return input.dims().size() > 1 &&\n+ input.dims().slice(1) == samples.dims().slice(1) &&\n+ input.getElementType() == samples.getElementType();\n+}\n+\n+} // namespace\n+\n+void TorchGlowTraining::clear() {\n+ F_ = nullptr;\n+ TF_ = nullptr;\n+ inputPHs_.clear();\n+ outputPHs_.clear();\n+ selectedPH_ = nullptr;\n+ bindings_.clear();\n+ engine_.clear();\n+}\n+\n+TorchGlowTraining::~TorchGlowTraining() { clear(); }\n+\n+llvm::Error TorchGlowTraining::init(llvm::StringRef modelFile,\n+ std::vector<torch::jit::IValue> &inputs,\n+ llvm::StringRef backend,\n+ const ONNXWriterParameters ¶meters,\n+ const PyTorchLoaderSettings &settings,\n+ const TrainingConfig &config,\n+ RandomizeWeights mode) {\n+ // Clean up all previous allocations, if any.\n+ clear();\n+ // Initialize execution engine.\n+ engine_.setBackendName(backend);\n+ // Create glow Function, only one object will be in module.\n+ F_ = engine_.getModule().createFunction(\"torch_glow_model\");\n+ // Execution lambda.\n+ auto setup = [&]() -> llvm::Error {\n+ // Detect the proper loader.\n+ if (modelFile.endswith_lower(\".pt\")) {\n+ RETURN_IF_ERR(PyTorchFileLoader::loadPyTorchGraph(\n+ modelFile.str(), inputs, *F_, inputPHs_, outputPHs_, settings, true));\n+ if (mode == RandomizeWeights::AUTO) {\n+ mode = RandomizeWeights::YES;\n+ }\n+ } else if (modelFile.endswith_lower(\".onnx\")) {\n+ llvm::Error err = llvm::Error::success();\n+ MARK_ERR_CHECKED(err);\n+ ONNXModelLoader loader(modelFile.str(), {}, {}, *F_, &err);\n+ RETURN_IF_ERR(err);\n+ if (mode == RandomizeWeights::AUTO) {\n+ mode = RandomizeWeights::NO;\n+ }\n+ } else {\n+ RETURN_ERR(\"Unrecognized file extension, expect *.pt or *.onnx.\");\n+ }\n+\n+ RETURN_ERR_IF_NOT(inputPHs_.size() == 1,\n+ glow::strFormat(\"Only 1 input is supported, got %lu\",\n+ inputPHs_.size()));\n+ RETURN_ERR_IF_NOT(outputPHs_.size() == 1,\n+ glow::strFormat(\"Only 1 output is supported, got %lu\",\n+ outputPHs_.size()));\n+\n+ // Initialization succeeded, prepare for training.\n+ bindings_.allocate(engine_.getModule().getPlaceholders());\n+ TensorInitializer initializer;\n+ switch (mode) {\n+ case RandomizeWeights::AUTO:\n+ assert(false);\n+ break;\n+ case RandomizeWeights::YES:\n+ initializer = getDefaultTensorInitializer();\n+ break;\n+ case RandomizeWeights::NO:\n+ initializer = [](Function *, Node *, unsigned, Tensor *) {};\n+ break;\n+ }\n+\n+ RETURN_IF_ERR(glow::prepareFunctionForTraining(F_, bindings_, selectedPH_,\n+ std::move(initializer)));\n+\n+ TF_ = glow::differentiate(F_, config);\n+ engine_.compile(CompilationMode::Train);\n+\n+ return llvm::Error::success();\n+ };\n+\n+ llvm::Error err = setup();\n+ if (err) {\n+ // On failure cleanup resources.\n+ clear();\n+ }\n+\n+ parameters_ = parameters;\n+ return llvm::Error::success();\n+}\n+\n+llvm::Error TorchGlowTraining::train(const Tensor &samples,\n+ const Tensor &labels) {\n+ RETURN_ERR_IF_NOT(TF_, \"Class instance, wasn't properly initialized.\");\n+ auto *input = bindings_.get(inputPHs_[0]);\n+ auto *label = bindings_.get(selectedPH_);\n+ auto TFName = TF_->getName();\n+\n+ // Sanity check.\n+ const bool isSlice = isValidSamplesForSliceInput(*input, samples) &&\n+ isValidSamplesForSliceInput(*label, labels);\n+\n+ if (!isSlice && (!isValidSamplesForSingleInput(*input, samples) ||\n+ !isValidSamplesForSingleInput(*label, labels))) {\n+ RETURN_ERR(\"Invalid samples/labels dimensions.\");\n+ }\n+\n+ size_t numEpochs = samples.dims()[0] / input->dims()[0];\n+ for (size_t e = 0; e < numEpochs; ++e) {\n+ isSlice ? input->copyConsecutiveSlices(&samples, e)\n+ : input->copySlice(&samples, e);\n+ isSlice ? label->copyConsecutiveSlices(&labels, e)\n+ : label->copySlice(&labels, e);\n+ engine_.run(bindings_, TFName);\n+ }\n+\n+ return llvm::Error::success();\n+}\n+\n+llvm::Error TorchGlowTraining::save(llvm::StringRef snapshotFile) {\n+ // Execution lambda.","path":"torch_glow/src/TorchGlowTraining.cpp","position":157,"original_position":157,"commit_id":"3196cb9d685bfbc3ceead8a3f9c989f74e8df3e8","original_commit_id":"3196cb9d685bfbc3ceead8a3f9c989f74e8df3e8","user":{"login":"jackm321","id":1740091,"node_id":"MDQ6VXNlcjE3NDAwOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1740091?v=4","gravatar_id":"","url":"https://api.github.com/users/jackm321","html_url":"https://github.com/jackm321","followers_url":"https://api.github.com/users/jackm321/followers","following_url":"https://api.github.com/users/jackm321/following{/other_user}","gists_url":"https://api.github.com/users/jackm321/gists{/gist_id}","starred_url":"https://api.github.com/users/jackm321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackm321/subscriptions","organizations_url":"https://api.github.com/users/jackm321/orgs","repos_url":"https://api.github.com/users/jackm321/repos","events_url":"https://api.github.com/users/jackm321/events{/privacy}","received_events_url":"https://api.github.com/users/jackm321/received_events","type":"User","site_admin":false},"body":"?","created_at":"2019-08-13T18:43:07Z","updated_at":"2019-08-13T18:48:59Z","html_url":"https://github.com/pytorch/glow/pull/3410#discussion_r313554252","pull_request_url":"https://api.github.com/repos/pytorch/glow/pulls/3410","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments/313554252"},"html":{"href":"https://github.com/pytorch/glow/pull/3410#discussion_r313554252"},"pull_request":{"href":"https://api.github.com/repos/pytorch/glow/pulls/3410"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/glow/pulls/3410","id":306713619,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2NzEzNjE5","html_url":"https://github.com/pytorch/glow/pull/3410","diff_url":"https://github.com/pytorch/glow/pull/3410.diff","patch_url":"https://github.com/pytorch/glow/pull/3410.patch","issue_url":"https://api.github.com/repos/pytorch/glow/issues/3410","number":3410,"state":"open","locked":false,"title":"Glow/PyTorch training library","user":{"login":"putivsky","id":9681346,"node_id":"MDQ6VXNlcjk2ODEzNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/9681346?v=4","gravatar_id":"","url":"https://api.github.com/users/putivsky","html_url":"https://github.com/putivsky","followers_url":"https://api.github.com/users/putivsky/followers","following_url":"https://api.github.com/users/putivsky/following{/other_user}","gists_url":"https://api.github.com/users/putivsky/gists{/gist_id}","starred_url":"https://api.github.com/users/putivsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/putivsky/subscriptions","organizations_url":"https://api.github.com/users/putivsky/orgs","repos_url":"https://api.github.com/users/putivsky/repos","events_url":"https://api.github.com/users/putivsky/events{/privacy}","received_events_url":"https://api.github.com/users/putivsky/received_events","type":"User","site_admin":false},"body":"\r\n\r\n\r\nSummary:\r\nLoads PyTorch model files, or ONNX snapshot files and preforms training.\r\nAfter training model weights and topology got saved into ONNX file.\r\n\r\nDocumentation:\r\n\r\n[Optional Fixes #issue]\r\n\r\nTest Plan:\r\n\r\nPlease see a detailed explanation of how to fill out the fields in the relevant sections in PULL_REQUEST.md.\r\n","created_at":"2019-08-13T01:23:59Z","updated_at":"2019-08-13T18:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fecb3999ecafe415f09f25067a0b81aa144b0d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706497924,"node_id":"MDU6TGFiZWw3MDY0OTc5MjQ=","url":"https://api.github.com/repos/pytorch/glow/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/glow/pulls/3410/commits","review_comments_url":"https://api.github.com/repos/pytorch/glow/pulls/3410/comments","review_comment_url":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/glow/issues/3410/comments","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/3196cb9d685bfbc3ceead8a3f9c989f74e8df3e8","head":{"label":"putivsky:torch_glow_training_lib","ref":"torch_glow_training_lib","sha":"3196cb9d685bfbc3ceead8a3f9c989f74e8df3e8","user":{"login":"putivsky","id":9681346,"node_id":"MDQ6VXNlcjk2ODEzNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/9681346?v=4","gravatar_id":"","url":"https://api.github.com/users/putivsky","html_url":"https://github.com/putivsky","followers_url":"https://api.github.com/users/putivsky/followers","following_url":"https://api.github.com/users/putivsky/following{/other_user}","gists_url":"https://api.github.com/users/putivsky/gists{/gist_id}","starred_url":"https://api.github.com/users/putivsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/putivsky/subscriptions","organizations_url":"https://api.github.com/users/putivsky/orgs","repos_url":"https://api.github.com/users/putivsky/repos","events_url":"https://api.github.com/users/putivsky/events{/privacy}","received_events_url":"https://api.github.com/users/putivsky/received_events","type":"User","site_admin":false},"repo":{"id":178938590,"node_id":"MDEwOlJlcG9zaXRvcnkxNzg5Mzg1OTA=","name":"glow","full_name":"putivsky/glow","private":false,"owner":{"login":"putivsky","id":9681346,"node_id":"MDQ6VXNlcjk2ODEzNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/9681346?v=4","gravatar_id":"","url":"https://api.github.com/users/putivsky","html_url":"https://github.com/putivsky","followers_url":"https://api.github.com/users/putivsky/followers","following_url":"https://api.github.com/users/putivsky/following{/other_user}","gists_url":"https://api.github.com/users/putivsky/gists{/gist_id}","starred_url":"https://api.github.com/users/putivsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/putivsky/subscriptions","organizations_url":"https://api.github.com/users/putivsky/orgs","repos_url":"https://api.github.com/users/putivsky/repos","events_url":"https://api.github.com/users/putivsky/events{/privacy}","received_events_url":"https://api.github.com/users/putivsky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/putivsky/glow","description":"Compiler for Neural Network hardware accelerators","fork":true,"url":"https://api.github.com/repos/putivsky/glow","forks_url":"https://api.github.com/repos/putivsky/glow/forks","keys_url":"https://api.github.com/repos/putivsky/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/putivsky/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/putivsky/glow/teams","hooks_url":"https://api.github.com/repos/putivsky/glow/hooks","issue_events_url":"https://api.github.com/repos/putivsky/glow/issues/events{/number}","events_url":"https://api.github.com/repos/putivsky/glow/events","assignees_url":"https://api.github.com/repos/putivsky/glow/assignees{/user}","branches_url":"https://api.github.com/repos/putivsky/glow/branches{/branch}","tags_url":"https://api.github.com/repos/putivsky/glow/tags","blobs_url":"https://api.github.com/repos/putivsky/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/putivsky/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/putivsky/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/putivsky/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/putivsky/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/putivsky/glow/languages","stargazers_url":"https://api.github.com/repos/putivsky/glow/stargazers","contributors_url":"https://api.github.com/repos/putivsky/glow/contributors","subscribers_url":"https://api.github.com/repos/putivsky/glow/subscribers","subscription_url":"https://api.github.com/repos/putivsky/glow/subscription","commits_url":"https://api.github.com/repos/putivsky/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/putivsky/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/putivsky/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/putivsky/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/putivsky/glow/contents/{+path}","compare_url":"https://api.github.com/repos/putivsky/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/putivsky/glow/merges","archive_url":"https://api.github.com/repos/putivsky/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/putivsky/glow/downloads","issues_url":"https://api.github.com/repos/putivsky/glow/issues{/number}","pulls_url":"https://api.github.com/repos/putivsky/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/putivsky/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/putivsky/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/putivsky/glow/labels{/name}","releases_url":"https://api.github.com/repos/putivsky/glow/releases{/id}","deployments_url":"https://api.github.com/repos/putivsky/glow/deployments","created_at":"2019-04-01T20:05:24Z","updated_at":"2019-04-08T17:59:20Z","pushed_at":"2019-08-13T16:36:54Z","git_url":"git://github.com/putivsky/glow.git","ssh_url":"git@github.com:putivsky/glow.git","clone_url":"https://github.com/putivsky/glow.git","svn_url":"https://github.com/putivsky/glow","homepage":null,"size":58973,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"2fc5da00c5821a473545c0cd9a1999d7563f42be","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":105281531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODE1MzE=","name":"glow","full_name":"pytorch/glow","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/glow","description":"Compiler for Neural Network hardware accelerators","fork":false,"url":"https://api.github.com/repos/pytorch/glow","forks_url":"https://api.github.com/repos/pytorch/glow/forks","keys_url":"https://api.github.com/repos/pytorch/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/glow/teams","hooks_url":"https://api.github.com/repos/pytorch/glow/hooks","issue_events_url":"https://api.github.com/repos/pytorch/glow/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/glow/events","assignees_url":"https://api.github.com/repos/pytorch/glow/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/glow/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/glow/tags","blobs_url":"https://api.github.com/repos/pytorch/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/glow/languages","stargazers_url":"https://api.github.com/repos/pytorch/glow/stargazers","contributors_url":"https://api.github.com/repos/pytorch/glow/contributors","subscribers_url":"https://api.github.com/repos/pytorch/glow/subscribers","subscription_url":"https://api.github.com/repos/pytorch/glow/subscription","commits_url":"https://api.github.com/repos/pytorch/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/glow/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/glow/merges","archive_url":"https://api.github.com/repos/pytorch/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/glow/downloads","issues_url":"https://api.github.com/repos/pytorch/glow/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/glow/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/glow/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/glow/deployments","created_at":"2017-09-29T14:28:18Z","updated_at":"2019-08-13T17:27:58Z","pushed_at":"2019-08-13T18:31:15Z","git_url":"git://github.com/pytorch/glow.git","ssh_url":"git@github.com:pytorch/glow.git","clone_url":"https://github.com/pytorch/glow.git","svn_url":"https://github.com/pytorch/glow","homepage":null,"size":58977,"stargazers_count":1620,"watchers_count":1620,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":150,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":270,"open_issues":150,"watchers":1620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/3410"},"html":{"href":"https://github.com/pytorch/glow/pull/3410"},"issue":{"href":"https://api.github.com/repos/pytorch/glow/issues/3410"},"comments":{"href":"https://api.github.com/repos/pytorch/glow/issues/3410/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/glow/pulls/3410/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/glow/pulls/3410/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/glow/statuses/3196cb9d685bfbc3ceead8a3f9c989f74e8df3e8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 105281531,
"name": "pytorch/glow",
"url": "https://api.github.com/repos/pytorch/glow"
}
|
{
"id": 1740091,
"login": "jackm321",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1740091?",
"url": "https://api.github.com/users/jackm321"
}
|
{
"id": 21003710,
"login": "pytorch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21003710?",
"url": "https://api.github.com/orgs/pytorch"
}
| 2019-08-13T18:43:07 |
10203950846
|
{"actor":{"display_login":"jackm321"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/FabricMC/yarn/pulls/comments/361535714","pull_request_review_id":336618717,"id":361535714,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTUzNTcxNA==","diff_hunk":"@@ -1,4 +1,17 @@\n-CLASS net/minecraft/class_4492 com/mojang/blaze3d/platform/FramebufferInfo\n-\tFIELD field_20457 target I\n-\tFIELD field_20458 renderBufferTarget I\n-\tFIELD field_20460 attachment I\n+CLASS net/minecraft/class_4492 com/mojang/blaze3d/platform/FrameBufferInfo\n+\tCOMMENT Contains global constants for the frame buffer and frame buffer states,\n+\tCOMMENT normalized to the current implementation running on the target system.\n+\tFIELD field_20457 FRAME_BUFFER I\n+\tFIELD field_20458 RENDER_BUFFER I\n+\tFIELD field_20459 COLOR_ATTACHMENT I\n+\tFIELD field_20460 DEPTH_ATTACHMENT I\n+\tFIELD field_20461 FRAME_BUFFER_COMPLETE I\n+\t\tCOMMENT {@see GL30#GL_FRAMEBUFFER_COMPLETE}\n+\tFIELD field_20462 FRAME_BUFFER_INCOMPLETE_ATTACHMENT I\n+\t\tCOMMENT {@see GL30#GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT}\n+\tFIELD field_20463 FRAME_BUFFER_INCOMPLETE_MISSING_ATTACHMENT I\n+\t\tCOMMENT {@see GL30#GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT}\n+\tFIELD field_20464 FRAME_BUFFER_INCOMPLETE_DRAW_BUFFER I\n+\t\tCOMMENT {@see GL30#GL_FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER}\n+\tFIELD field_20465 FRAME_BUFFER_INCOMPLETE_READ_BUFFER I\n+\t\tCOMMENT {@see GL30#GL_FRAMEBUFFER_INCOMPLETE_READ_BUFFER}","path":"mappings/com/mojang/blaze3d/platform/FramebufferInfo.mapping","position":20,"original_position":21,"commit_id":"862dd3d0c0e865e775b88bc47e718e586e4b15c1","original_commit_id":"80be63ce12795995334613f7b394abc62120aa9d","user":{"login":"Sollace","id":6429283,"node_id":"MDQ6VXNlcjY0MjkyODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6429283?v=4","gravatar_id":"","url":"https://api.github.com/users/Sollace","html_url":"https://github.com/Sollace","followers_url":"https://api.github.com/users/Sollace/followers","following_url":"https://api.github.com/users/Sollace/following{/other_user}","gists_url":"https://api.github.com/users/Sollace/gists{/gist_id}","starred_url":"https://api.github.com/users/Sollace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sollace/subscriptions","organizations_url":"https://api.github.com/users/Sollace/orgs","repos_url":"https://api.github.com/users/Sollace/repos","events_url":"https://api.github.com/users/Sollace/events{/privacy}","received_events_url":"https://api.github.com/users/Sollace/received_events","type":"User","site_admin":false},"body":"Going to leave this open until I can actually test that.","created_at":"2019-12-26T21:25:56Z","updated_at":"2019-12-26T21:25:57Z","html_url":"https://github.com/FabricMC/yarn/pull/1010#discussion_r361535714","pull_request_url":"https://api.github.com/repos/FabricMC/yarn/pulls/1010","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/comments/361535714"},"html":{"href":"https://github.com/FabricMC/yarn/pull/1010#discussion_r361535714"},"pull_request":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/1010"}},"in_reply_to_id":358021879},"pull_request":{"url":"https://api.github.com/repos/FabricMC/yarn/pulls/1010","id":352435020,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyNDM1MDIw","html_url":"https://github.com/FabricMC/yarn/pull/1010","diff_url":"https://github.com/FabricMC/yarn/pull/1010.diff","patch_url":"https://github.com/FabricMC/yarn/pull/1010.patch","issue_url":"https://api.github.com/repos/FabricMC/yarn/issues/1010","number":1010,"state":"open","locked":false,"title":"Mapped FrameBufferInfo","user":{"login":"Sollace","id":6429283,"node_id":"MDQ6VXNlcjY0MjkyODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6429283?v=4","gravatar_id":"","url":"https://api.github.com/users/Sollace","html_url":"https://github.com/Sollace","followers_url":"https://api.github.com/users/Sollace/followers","following_url":"https://api.github.com/users/Sollace/following{/other_user}","gists_url":"https://api.github.com/users/Sollace/gists{/gist_id}","starred_url":"https://api.github.com/users/Sollace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sollace/subscriptions","organizations_url":"https://api.github.com/users/Sollace/orgs","repos_url":"https://api.github.com/users/Sollace/repos","events_url":"https://api.github.com/users/Sollace/events{/privacy}","received_events_url":"https://api.github.com/users/Sollace/received_events","type":"User","site_admin":false},"body":"At long last I don't have to put all my explanations into the commit messages! Check the javadocs in the commits. They reveal everything.","created_at":"2019-12-12T14:13:16Z","updated_at":"2019-12-26T21:25:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4149e4290bae6c5279db3a608fd3f49909182364","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1347504571,"node_id":"MDU6TGFiZWwxMzQ3NTA0NTcx","url":"https://api.github.com/repos/FabricMC/yarn/labels/new","name":"new","color":"129127","default":false,"description":"A PR that maps out mainly new names"},{"id":1606173366,"node_id":"MDU6TGFiZWwxNjA2MTczMzY2","url":"https://api.github.com/repos/FabricMC/yarn/labels/release","name":"release","color":"3ec9b2","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/FabricMC/yarn/pulls/1010/commits","review_comments_url":"https://api.github.com/repos/FabricMC/yarn/pulls/1010/comments","review_comment_url":"https://api.github.com/repos/FabricMC/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FabricMC/yarn/issues/1010/comments","statuses_url":"https://api.github.com/repos/FabricMC/yarn/statuses/862dd3d0c0e865e775b88bc47e718e586e4b15c1","head":{"label":"Sollace:mapped_frame_buffer_info","ref":"mapped_frame_buffer_info","sha":"862dd3d0c0e865e775b88bc47e718e586e4b15c1","user":{"login":"Sollace","id":6429283,"node_id":"MDQ6VXNlcjY0MjkyODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6429283?v=4","gravatar_id":"","url":"https://api.github.com/users/Sollace","html_url":"https://github.com/Sollace","followers_url":"https://api.github.com/users/Sollace/followers","following_url":"https://api.github.com/users/Sollace/following{/other_user}","gists_url":"https://api.github.com/users/Sollace/gists{/gist_id}","starred_url":"https://api.github.com/users/Sollace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sollace/subscriptions","organizations_url":"https://api.github.com/users/Sollace/orgs","repos_url":"https://api.github.com/users/Sollace/repos","events_url":"https://api.github.com/users/Sollace/events{/privacy}","received_events_url":"https://api.github.com/users/Sollace/received_events","type":"User","site_admin":false},"repo":{"id":189890473,"node_id":"MDEwOlJlcG9zaXRvcnkxODk4OTA0NzM=","name":"yarn","full_name":"Sollace/yarn","private":false,"owner":{"login":"Sollace","id":6429283,"node_id":"MDQ6VXNlcjY0MjkyODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6429283?v=4","gravatar_id":"","url":"https://api.github.com/users/Sollace","html_url":"https://github.com/Sollace","followers_url":"https://api.github.com/users/Sollace/followers","following_url":"https://api.github.com/users/Sollace/following{/other_user}","gists_url":"https://api.github.com/users/Sollace/gists{/gist_id}","starred_url":"https://api.github.com/users/Sollace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sollace/subscriptions","organizations_url":"https://api.github.com/users/Sollace/orgs","repos_url":"https://api.github.com/users/Sollace/repos","events_url":"https://api.github.com/users/Sollace/events{/privacy}","received_events_url":"https://api.github.com/users/Sollace/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Sollace/yarn","description":"Libre Minecraft mappings, free to use for everyone. No exceptions.","fork":true,"url":"https://api.github.com/repos/Sollace/yarn","forks_url":"https://api.github.com/repos/Sollace/yarn/forks","keys_url":"https://api.github.com/repos/Sollace/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sollace/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sollace/yarn/teams","hooks_url":"https://api.github.com/repos/Sollace/yarn/hooks","issue_events_url":"https://api.github.com/repos/Sollace/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/Sollace/yarn/events","assignees_url":"https://api.github.com/repos/Sollace/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/Sollace/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/Sollace/yarn/tags","blobs_url":"https://api.github.com/repos/Sollace/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sollace/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sollace/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sollace/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sollace/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/Sollace/yarn/languages","stargazers_url":"https://api.github.com/repos/Sollace/yarn/stargazers","contributors_url":"https://api.github.com/repos/Sollace/yarn/contributors","subscribers_url":"https://api.github.com/repos/Sollace/yarn/subscribers","subscription_url":"https://api.github.com/repos/Sollace/yarn/subscription","commits_url":"https://api.github.com/repos/Sollace/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sollace/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sollace/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sollace/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sollace/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/Sollace/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sollace/yarn/merges","archive_url":"https://api.github.com/repos/Sollace/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sollace/yarn/downloads","issues_url":"https://api.github.com/repos/Sollace/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/Sollace/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/Sollace/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/Sollace/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sollace/yarn/labels{/name}","releases_url":"https://api.github.com/repos/Sollace/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/Sollace/yarn/deployments","created_at":"2019-06-02T20:11:19Z","updated_at":"2019-11-04T10:41:08Z","pushed_at":"2019-12-26T21:25:21Z","git_url":"git://github.com/Sollace/yarn.git","ssh_url":"git@github.com:Sollace/yarn.git","clone_url":"https://github.com/Sollace/yarn.git","svn_url":"https://github.com/Sollace/yarn","homepage":"","size":22099,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.14.4"}},"base":{"label":"FabricMC:1.15.1-pre1","ref":"1.15.1-pre1","sha":"a6b72cef3d946bdf792be8ead978789ba2a04249","user":{"login":"FabricMC","id":21025855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDI1ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/21025855?v=4","gravatar_id":"","url":"https://api.github.com/users/FabricMC","html_url":"https://github.com/FabricMC","followers_url":"https://api.github.com/users/FabricMC/followers","following_url":"https://api.github.com/users/FabricMC/following{/other_user}","gists_url":"https://api.github.com/users/FabricMC/gists{/gist_id}","starred_url":"https://api.github.com/users/FabricMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabricMC/subscriptions","organizations_url":"https://api.github.com/users/FabricMC/orgs","repos_url":"https://api.github.com/users/FabricMC/repos","events_url":"https://api.github.com/users/FabricMC/events{/privacy}","received_events_url":"https://api.github.com/users/FabricMC/received_events","type":"Organization","site_admin":false},"repo":{"id":65555184,"node_id":"MDEwOlJlcG9zaXRvcnk2NTU1NTE4NA==","name":"yarn","full_name":"FabricMC/yarn","private":false,"owner":{"login":"FabricMC","id":21025855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDI1ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/21025855?v=4","gravatar_id":"","url":"https://api.github.com/users/FabricMC","html_url":"https://github.com/FabricMC","followers_url":"https://api.github.com/users/FabricMC/followers","following_url":"https://api.github.com/users/FabricMC/following{/other_user}","gists_url":"https://api.github.com/users/FabricMC/gists{/gist_id}","starred_url":"https://api.github.com/users/FabricMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabricMC/subscriptions","organizations_url":"https://api.github.com/users/FabricMC/orgs","repos_url":"https://api.github.com/users/FabricMC/repos","events_url":"https://api.github.com/users/FabricMC/events{/privacy}","received_events_url":"https://api.github.com/users/FabricMC/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FabricMC/yarn","description":"Libre Minecraft mappings, free to use for everyone. No exceptions.","fork":false,"url":"https://api.github.com/repos/FabricMC/yarn","forks_url":"https://api.github.com/repos/FabricMC/yarn/forks","keys_url":"https://api.github.com/repos/FabricMC/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FabricMC/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FabricMC/yarn/teams","hooks_url":"https://api.github.com/repos/FabricMC/yarn/hooks","issue_events_url":"https://api.github.com/repos/FabricMC/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/FabricMC/yarn/events","assignees_url":"https://api.github.com/repos/FabricMC/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/FabricMC/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/FabricMC/yarn/tags","blobs_url":"https://api.github.com/repos/FabricMC/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FabricMC/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FabricMC/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/FabricMC/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FabricMC/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/FabricMC/yarn/languages","stargazers_url":"https://api.github.com/repos/FabricMC/yarn/stargazers","contributors_url":"https://api.github.com/repos/FabricMC/yarn/contributors","subscribers_url":"https://api.github.com/repos/FabricMC/yarn/subscribers","subscription_url":"https://api.github.com/repos/FabricMC/yarn/subscription","commits_url":"https://api.github.com/repos/FabricMC/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/FabricMC/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/FabricMC/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/FabricMC/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/FabricMC/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/FabricMC/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FabricMC/yarn/merges","archive_url":"https://api.github.com/repos/FabricMC/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FabricMC/yarn/downloads","issues_url":"https://api.github.com/repos/FabricMC/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/FabricMC/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/FabricMC/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/FabricMC/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FabricMC/yarn/labels{/name}","releases_url":"https://api.github.com/repos/FabricMC/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/FabricMC/yarn/deployments","created_at":"2016-08-12T13:27:21Z","updated_at":"2019-12-26T12:36:46Z","pushed_at":"2019-12-26T21:25:22Z","git_url":"git://github.com/FabricMC/yarn.git","ssh_url":"git@github.com:FabricMC/yarn.git","clone_url":"https://github.com/FabricMC/yarn.git","svn_url":"https://github.com/FabricMC/yarn","homepage":"","size":22978,"stargazers_count":251,"watchers_count":251,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":88,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":148,"open_issues":88,"watchers":251,"default_branch":"1.15.1"}},"_links":{"self":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/1010"},"html":{"href":"https://github.com/FabricMC/yarn/pull/1010"},"issue":{"href":"https://api.github.com/repos/FabricMC/yarn/issues/1010"},"comments":{"href":"https://api.github.com/repos/FabricMC/yarn/issues/1010/comments"},"review_comments":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/1010/comments"},"review_comment":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/1010/commits"},"statuses":{"href":"https://api.github.com/repos/FabricMC/yarn/statuses/862dd3d0c0e865e775b88bc47e718e586e4b15c1"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 65555184,
"name": "FabricMC/yarn",
"url": "https://api.github.com/repos/FabricMC/yarn"
}
|
{
"id": 6429283,
"login": "Sollace",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6429283?",
"url": "https://api.github.com/users/Sollace"
}
|
{
"id": 21025855,
"login": "FabricMC",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21025855?",
"url": "https://api.github.com/orgs/FabricMC"
}
| 2019-12-26T21:25:56 |
11163231361
|
{"actor":{"display_login":"Sollace"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments/291598351","pull_request_review_id":247103033,"id":291598351,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTU5ODM1MQ==","diff_hunk":"@@ -394,12 +394,29 @@ impl MDARegions {\n }\n }\n \n+/// A type representing the actual size of variable length metadata written within this metadata","path":"src/engine/strat_engine/backstore/metadata/mda.rs","position":18,"original_position":18,"commit_id":"ef819951e21f1d6c39666dbc91e9bce768a9ab18","original_commit_id":"ef819951e21f1d6c39666dbc91e9bce768a9ab18","user":{"login":"bgurney-rh","id":32554660,"node_id":"MDQ6VXNlcjMyNTU0NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/32554660?v=4","gravatar_id":"","url":"https://api.github.com/users/bgurney-rh","html_url":"https://github.com/bgurney-rh","followers_url":"https://api.github.com/users/bgurney-rh/followers","following_url":"https://api.github.com/users/bgurney-rh/following{/other_user}","gists_url":"https://api.github.com/users/bgurney-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/bgurney-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgurney-rh/subscriptions","organizations_url":"https://api.github.com/users/bgurney-rh/orgs","repos_url":"https://api.github.com/users/bgurney-rh/repos","events_url":"https://api.github.com/users/bgurney-rh/events{/privacy}","received_events_url":"https://api.github.com/users/bgurney-rh/received_events","type":"User","site_admin":false},"body":"Strange; this is part of what was added in stratisd PR #1554, but the stratisd test passed for that PR. I wonder why it's failing now.","created_at":"2019-06-07T13:44:40Z","updated_at":"2019-06-07T13:44:41Z","html_url":"https://github.com/stratis-storage/stratisd/pull/1546#discussion_r291598351","pull_request_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/1546","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments/291598351"},"html":{"href":"https://github.com/stratis-storage/stratisd/pull/1546#discussion_r291598351"},"pull_request":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/1546"}},"in_reply_to_id":291595880},"pull_request":{"url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/1546","id":283652212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzNjUyMjEy","html_url":"https://github.com/stratis-storage/stratisd/pull/1546","diff_url":"https://github.com/stratis-storage/stratisd/pull/1546.diff","patch_url":"https://github.com/stratis-storage/stratisd/pull/1546.patch","issue_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/1546","number":1546,"state":"open","locked":false,"title":"Create specific type for MDAHeader's used field","user":{"login":"GuillaumeGomez","id":3050060,"node_id":"MDQ6VXNlcjMwNTAwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3050060?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"body":"Fixes #1544.","created_at":"2019-05-30T13:21:38Z","updated_at":"2019-06-07T13:44:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83ccaddcd8b2254b98e01b327fad1b0e078bec53","assignee":{"login":"GuillaumeGomez","id":3050060,"node_id":"MDQ6VXNlcjMwNTAwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3050060?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"assignees":[{"login":"GuillaumeGomez","id":3050060,"node_id":"MDQ6VXNlcjMwNTAwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3050060?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/1546/commits","review_comments_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/1546/comments","review_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/1546/comments","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/ef819951e21f1d6c39666dbc91e9bce768a9ab18","head":{"label":"GuillaumeGomez:mdaheader-used-field-type","ref":"mdaheader-used-field-type","sha":"ef819951e21f1d6c39666dbc91e9bce768a9ab18","user":{"login":"GuillaumeGomez","id":3050060,"node_id":"MDQ6VXNlcjMwNTAwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3050060?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"repo":{"id":188568860,"node_id":"MDEwOlJlcG9zaXRvcnkxODg1Njg4NjA=","name":"stratisd","full_name":"GuillaumeGomez/stratisd","private":false,"owner":{"login":"GuillaumeGomez","id":3050060,"node_id":"MDQ6VXNlcjMwNTAwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3050060?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GuillaumeGomez/stratisd","description":"Easy to use local storage management for Linux.","fork":true,"url":"https://api.github.com/repos/GuillaumeGomez/stratisd","forks_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/forks","keys_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/teams","hooks_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/hooks","issue_events_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/events","assignees_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/tags","blobs_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/languages","stargazers_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/stargazers","contributors_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/contributors","subscribers_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/subscribers","subscription_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/subscription","commits_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/merges","archive_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/downloads","issues_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/GuillaumeGomez/stratisd/deployments","created_at":"2019-05-25T13:21:05Z","updated_at":"2019-06-02T19:29:46Z","pushed_at":"2019-06-07T13:30:39Z","git_url":"git://github.com/GuillaumeGomez/stratisd.git","ssh_url":"git@github.com:GuillaumeGomez/stratisd.git","clone_url":"https://github.com/GuillaumeGomez/stratisd.git","svn_url":"https://github.com/GuillaumeGomez/stratisd","homepage":"https://stratis-storage.github.io","size":3606,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratis-storage:master","ref":"master","sha":"8751c24b549e6b47a3983759867692c411931da2","user":{"login":"stratis-storage","id":21202300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyMzAw","avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"repo":{"id":66564704,"node_id":"MDEwOlJlcG9zaXRvcnk2NjU2NDcwNA==","name":"stratisd","full_name":"stratis-storage/stratisd","private":false,"owner":{"login":"stratis-storage","id":21202300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyMzAw","avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stratis-storage/stratisd","description":"Easy to use local storage management for Linux.","fork":false,"url":"https://api.github.com/repos/stratis-storage/stratisd","forks_url":"https://api.github.com/repos/stratis-storage/stratisd/forks","keys_url":"https://api.github.com/repos/stratis-storage/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratis-storage/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratis-storage/stratisd/teams","hooks_url":"https://api.github.com/repos/stratis-storage/stratisd/hooks","issue_events_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/stratis-storage/stratisd/events","assignees_url":"https://api.github.com/repos/stratis-storage/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/stratis-storage/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/stratis-storage/stratisd/tags","blobs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratis-storage/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratis-storage/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/stratis-storage/stratisd/languages","stargazers_url":"https://api.github.com/repos/stratis-storage/stratisd/stargazers","contributors_url":"https://api.github.com/repos/stratis-storage/stratisd/contributors","subscribers_url":"https://api.github.com/repos/stratis-storage/stratisd/subscribers","subscription_url":"https://api.github.com/repos/stratis-storage/stratisd/subscription","commits_url":"https://api.github.com/repos/stratis-storage/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratis-storage/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratis-storage/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/stratis-storage/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratis-storage/stratisd/merges","archive_url":"https://api.github.com/repos/stratis-storage/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratis-storage/stratisd/downloads","issues_url":"https://api.github.com/repos/stratis-storage/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/stratis-storage/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/stratis-storage/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratis-storage/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/stratis-storage/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/stratis-storage/stratisd/deployments","created_at":"2016-08-25T14:24:19Z","updated_at":"2019-06-06T22:43:46Z","pushed_at":"2019-06-07T13:30:40Z","git_url":"git://github.com/stratis-storage/stratisd.git","ssh_url":"git@github.com:stratis-storage/stratisd.git","clone_url":"https://github.com/stratis-storage/stratisd.git","svn_url":"https://github.com/stratis-storage/stratisd","homepage":"https://stratis-storage.github.io","size":3612,"stargazers_count":456,"watchers_count":456,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":169,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":35,"open_issues":169,"watchers":456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/1546"},"html":{"href":"https://github.com/stratis-storage/stratisd/pull/1546"},"issue":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/1546"},"comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/1546/comments"},"review_comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/1546/comments"},"review_comment":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/1546/commits"},"statuses":{"href":"https://api.github.com/repos/stratis-storage/stratisd/statuses/ef819951e21f1d6c39666dbc91e9bce768a9ab18"}},"author_association":"COLLABORATOR"}}
|
{
"id": 66564704,
"name": "stratis-storage/stratisd",
"url": "https://api.github.com/repos/stratis-storage/stratisd"
}
|
{
"id": 32554660,
"login": "bgurney-rh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32554660?",
"url": "https://api.github.com/users/bgurney-rh"
}
|
{
"id": 21202300,
"login": "stratis-storage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21202300?",
"url": "https://api.github.com/orgs/stratis-storage"
}
| 2019-06-07T13:44:40 |
9779093779
|
{"actor":{"display_login":"bgurney-rh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/361217700","pull_request_review_id":336264832,"id":361217700,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTIxNzcwMA==","diff_hunk":"@@ -4704,6 +4704,7 @@ def sort_values(\n inplace=False,\n kind=\"quicksort\",\n na_position=\"last\",\n+ ignore_index=False,","path":"pandas/core/frame.py","position":null,"original_position":4,"commit_id":"4ce9f439698e96ec6c99a9bfaa56100c77da3453","original_commit_id":"bbb4754b5fb7d2998ec4f30353a8bfc99be03e1a","user":{"login":"WillAyd","id":609873,"node_id":"MDQ6VXNlcjYwOTg3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/609873?v=4","gravatar_id":"","url":"https://api.github.com/users/WillAyd","html_url":"https://github.com/WillAyd","followers_url":"https://api.github.com/users/WillAyd/followers","following_url":"https://api.github.com/users/WillAyd/following{/other_user}","gists_url":"https://api.github.com/users/WillAyd/gists{/gist_id}","starred_url":"https://api.github.com/users/WillAyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillAyd/subscriptions","organizations_url":"https://api.github.com/users/WillAyd/orgs","repos_url":"https://api.github.com/users/WillAyd/repos","events_url":"https://api.github.com/users/WillAyd/events{/privacy}","received_events_url":"https://api.github.com/users/WillAyd/received_events","type":"User","site_admin":false},"body":"Yea I think that is reasonable","created_at":"2019-12-24T19:39:41Z","updated_at":"2019-12-24T19:39:41Z","html_url":"https://github.com/pandas-dev/pandas/pull/30402#discussion_r361217700","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/30402","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/361217700"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/30402#discussion_r361217700"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/30402"}},"in_reply_to_id":361196673},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/30402","id":356080811,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2MDgwODEx","html_url":"https://github.com/pandas-dev/pandas/pull/30402","diff_url":"https://github.com/pandas-dev/pandas/pull/30402.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/30402.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/30402","number":30402,"state":"open","locked":false,"title":"ENH: Add ignore_index for df.sort_values and series.sort_values","user":{"login":"charlesdong1991","id":9269816,"node_id":"MDQ6VXNlcjkyNjk4MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9269816?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesdong1991","html_url":"https://github.com/charlesdong1991","followers_url":"https://api.github.com/users/charlesdong1991/followers","following_url":"https://api.github.com/users/charlesdong1991/following{/other_user}","gists_url":"https://api.github.com/users/charlesdong1991/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesdong1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesdong1991/subscriptions","organizations_url":"https://api.github.com/users/charlesdong1991/orgs","repos_url":"https://api.github.com/users/charlesdong1991/repos","events_url":"https://api.github.com/users/charlesdong1991/events{/privacy}","received_events_url":"https://api.github.com/users/charlesdong1991/received_events","type":"User","site_admin":false},"body":"- [x] xref #30114 \r\n- [x] tests added / passed\r\n- [x] passes `black pandas`\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [x] whatsnew entry\r\n\r\nThis is the first step for closing the PR #30114, I will come up with another PR for `drop_duplicates`","created_at":"2019-12-22T12:14:23Z","updated_at":"2019-12-24T19:39:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1784c66ae2c6ac40dd25e5ddcd21f9f1eafb2471","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":35818298,"node_id":"MDU6TGFiZWwzNTgxODI5OA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/API%20Design","name":"API Design","color":"AD7FA8","default":false,"description":null},{"id":13098779,"node_id":"MDU6TGFiZWwxMzA5ODc3OQ==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Reshaping","name":"Reshaping","color":"02d7e1","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/30402/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/30402/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/30402/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/4ce9f439698e96ec6c99a9bfaa56100c77da3453","head":{"label":"charlesdong1991:fix_issue_30114","ref":"fix_issue_30114","sha":"4ce9f439698e96ec6c99a9bfaa56100c77da3453","user":{"login":"charlesdong1991","id":9269816,"node_id":"MDQ6VXNlcjkyNjk4MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9269816?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesdong1991","html_url":"https://github.com/charlesdong1991","followers_url":"https://api.github.com/users/charlesdong1991/followers","following_url":"https://api.github.com/users/charlesdong1991/following{/other_user}","gists_url":"https://api.github.com/users/charlesdong1991/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesdong1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesdong1991/subscriptions","organizations_url":"https://api.github.com/users/charlesdong1991/orgs","repos_url":"https://api.github.com/users/charlesdong1991/repos","events_url":"https://api.github.com/users/charlesdong1991/events{/privacy}","received_events_url":"https://api.github.com/users/charlesdong1991/received_events","type":"User","site_admin":false},"repo":{"id":154377364,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzNzczNjQ=","name":"pandas","full_name":"charlesdong1991/pandas","private":false,"owner":{"login":"charlesdong1991","id":9269816,"node_id":"MDQ6VXNlcjkyNjk4MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9269816?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesdong1991","html_url":"https://github.com/charlesdong1991","followers_url":"https://api.github.com/users/charlesdong1991/followers","following_url":"https://api.github.com/users/charlesdong1991/following{/other_user}","gists_url":"https://api.github.com/users/charlesdong1991/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesdong1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesdong1991/subscriptions","organizations_url":"https://api.github.com/users/charlesdong1991/orgs","repos_url":"https://api.github.com/users/charlesdong1991/repos","events_url":"https://api.github.com/users/charlesdong1991/events{/privacy}","received_events_url":"https://api.github.com/users/charlesdong1991/received_events","type":"User","site_admin":false},"html_url":"https://github.com/charlesdong1991/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/charlesdong1991/pandas","forks_url":"https://api.github.com/repos/charlesdong1991/pandas/forks","keys_url":"https://api.github.com/repos/charlesdong1991/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charlesdong1991/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charlesdong1991/pandas/teams","hooks_url":"https://api.github.com/repos/charlesdong1991/pandas/hooks","issue_events_url":"https://api.github.com/repos/charlesdong1991/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/charlesdong1991/pandas/events","assignees_url":"https://api.github.com/repos/charlesdong1991/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/charlesdong1991/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/charlesdong1991/pandas/tags","blobs_url":"https://api.github.com/repos/charlesdong1991/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charlesdong1991/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charlesdong1991/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/charlesdong1991/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charlesdong1991/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/charlesdong1991/pandas/languages","stargazers_url":"https://api.github.com/repos/charlesdong1991/pandas/stargazers","contributors_url":"https://api.github.com/repos/charlesdong1991/pandas/contributors","subscribers_url":"https://api.github.com/repos/charlesdong1991/pandas/subscribers","subscription_url":"https://api.github.com/repos/charlesdong1991/pandas/subscription","commits_url":"https://api.github.com/repos/charlesdong1991/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/charlesdong1991/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/charlesdong1991/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/charlesdong1991/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/charlesdong1991/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/charlesdong1991/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charlesdong1991/pandas/merges","archive_url":"https://api.github.com/repos/charlesdong1991/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charlesdong1991/pandas/downloads","issues_url":"https://api.github.com/repos/charlesdong1991/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/charlesdong1991/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/charlesdong1991/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/charlesdong1991/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charlesdong1991/pandas/labels{/name}","releases_url":"https://api.github.com/repos/charlesdong1991/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/charlesdong1991/pandas/deployments","created_at":"2018-10-23T18:26:01Z","updated_at":"2019-07-30T19:52:38Z","pushed_at":"2019-12-24T19:13:23Z","git_url":"git://github.com/charlesdong1991/pandas.git","ssh_url":"git@github.com:charlesdong1991/pandas.git","clone_url":"https://github.com/charlesdong1991/pandas.git","svn_url":"https://github.com/charlesdong1991/pandas","homepage":"https://pandas.pydata.org","size":175492,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"5a7b5c958c6f004c395136f9438a1ed6c04861dd","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2019-12-24T19:23:49Z","pushed_at":"2019-12-24T19:30:13Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":175315,"stargazers_count":22794,"watchers_count":22794,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9093,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3312,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":9093,"open_issues":3312,"watchers":22794,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/30402"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/30402"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/30402"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/30402/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/30402/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/30402/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/4ce9f439698e96ec6c99a9bfaa56100c77da3453"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 858127,
"name": "pandas-dev/pandas",
"url": "https://api.github.com/repos/pandas-dev/pandas"
}
|
{
"id": 609873,
"login": "WillAyd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/609873?",
"url": "https://api.github.com/users/WillAyd"
}
|
{
"id": 21206976,
"login": "pandas-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21206976?",
"url": "https://api.github.com/orgs/pandas-dev"
}
| 2019-12-24T19:39:41 |
11155015273
|
{"actor":{"display_login":"WillAyd"}}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.